Conduct 1st User Testing

Conduct user testing session of first iteration of prototype with someone from target user group.

The team conducted a usability testing session with a user who works in the charity sector in a role that requires organising group decisions. Learnings were taken to create second iteration of Prototype


[Bug] !Skip will jump over multiple songs

I have just upgraded to Rc7, and when i use the skip command it will jump over five to ten songs within the queue. It does not always do this, i think its mainly when downloading new songs.

Also having this problem with Rc7. No other issues so far though!

Has to do with when the bot checks the links for validity when added to the queue and then keeps the connection to youtube open too long causing it to time out and the bot to skip over everything else in the queue (that is youtube).

I am unable to reproduce this.  I know multiple people have this happen, but I have yet to see it happen.  I can't fix a bug that doesn't exist for me, so I can't really fix this right now.  Maybe i'll find/fix it by accident, but I have nothing to go on right now.  If someone can reliably reproduce this, please let me know exactly how.

Setup the queue with several youtube videos (like 7ish) in a row (i.e. all requested within a few mins). After the 3rd or 4th one you'll notice the bot will skip through the rest of the list because the server connections have timed out.

If I add a big playlist and type !skip once every couple seconds I can make it happen after a few skips (5-10 !skip s and it will usually start randomly skipping through the songs)
After doing it enough times it just skipped through an entire playlist in like 15 seconds flat http://i.imgur.com/ApDep4u.png

@Echoskope I'm not sure where you got this "connection timed out" idea from, but that's not how the bot works.  Resolving urls and playlists is all done by youtube_dl.  If something is breaking, it that library.  In the case of youtube playlists, I did a trick to queue the songs sequentially instead of having to wait for youtube_dl to resolve the entire playlist first, which can take a long time with a large playlist.  Instead of having youtube_dl process the entire playlist, I get the unprocessed version of the playlist, generate the urls myself, and queue each of those urls individually.  Skipping during this part shouldn't break anything, but i'll do some more testing.

@imayhaveborkedit I spent some time last night trying to recreate the problem just to make sure I'm not crazy but couldn't get it to do it again :( Maybe the problem we ran into was a red herring.

@Echoskope Nope, this is a problem affecting my bot and one of my friends bot too, what I noticed that a song starts playing, ffmpeg freezes/crashes and then the next 5-6 songs get skipped. I posted detailed logs of what's going on and what events are getting fired when this happens but I got ignored cause it only affects some users.

I'm fairly sure this is gone now since people have stopped mentioning it.


prince command not found in container

No next link found!
........
/usr/local/bin/prince: exec: line 3: /usr/local/lib/prince/bin/prince: not found

Same here.
After executing:
docker run --rm -it --init \
  -v $(pwd)/pdf:/app/pdf \
  openbayes/docusaurus-prince-pdf \
  -u https://docusaurus.io/docs/

I'm getting:
...
Got link: https://docusaurus.io/docs/migration/manual
Got link: https://docusaurus.io/docs/migration/versioned-sites
Got link: https://docusaurus.io/docs/migration/translated-sites
No next link found!
Writing buffer (52 links) to ./pdf/docusaurus.io-docs.txt
Generating PDF ./pdf/docusaurus.io-docs.pdf
Executing command: prince --no-warn-css --style=/app/print.css --input-list=./pdf/docusaurus.io-docs.txt -o ./pdf/docusaurus.io-docs.pdf
Error: Command failed: prince --no-warn-css --style=/app/print.css --input-list=./pdf/docusaurus.io-docs.txt -o ./pdf/docusaurus.io-docs.pdf
/usr/local/bin/prince: exec: line 3: /usr/local/lib/prince/bin/prince: not found

Same here

Does anyone using old verison is working?

Hey guys,
Please use 1.1.1 instead of latest version of the image
 docker run --rm -it --init \
  -v $(pwd)/pdf:/app/pdf \
  -v $(pwd)/fonts:/root/.fonts \
  openbayes/docusaurus-prince-pdf:1.1.1 \
  -u https://docusaurus.io/docs/

I'm using 1.1.1, but still getting this error.
Output:
docker run --rm -it --init -v "D:/code/redacted/build:/app/pdf:rw" openbayes/docusaurus-prince-pdf:1.1.1 -u http://host.docker.internal:4000
(node:7) ExperimentalWarning: Importing JSON modules is an experimental feature. This feature could change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
Got link: http://host.docker.internal:4000/docs
Got link: http://host.docker.internal:4000/docs/page1
Got link: http://host.docker.internal:4000/docs/page2
No next link found!
Writing buffer (3 links) to ./pdf/host.docker.internal.txt
Generating PDF ./pdf/host.docker.internal.pdf
Executing command: prince --no-warn-css --style=/app/print.css --input-list=./pdf/host.docker.internal.txt -o ./pdf/host.docker.internal.pdf
Error: Command failed: prince --no-warn-css --style=/app/print.css --input-list=./pdf/host.docker.internal.txt -o ./pdf/host.docker.internal.pdf
/usr/local/bin/prince: exec: line 3: /usr/local/lib/prince/bin/prince: not found

    at ChildProcess.exithandler (node:child_process:398:12)
    at ChildProcess.emit (node:events:527:28)
    at maybeClose (node:internal/child_process:1092:16)
    at Socket.<anonymous> (node:internal/child_process:451:11)
    at Socket.emit (node:events:527:28)
    at Pipe.<anonymous> (node:net:709:12) {
  code: 127,
  killed: false,
  signal: null,
  cmd: 'prince --no-warn-css --style=/app/print.css --input-list=./pdf/host.docker.internal.txt -o ./pdf/host.docker.internal.pdf '
}

Due to downloading an incompatible version of PrinceXML and a broken dependency, it is not working.
I'm not sure if I should submit a merge request, but the issue can be easily resolved by editing the Dockerfile and building it.
To resolve the problem, follow these steps:

Clone the repository.
Build the Docker image using the provided Dockerfile:

Note that below hard-coded Dockerfile only works on x86_64 machine.

Then it sould works.
Windows
$outputPath = $pwd.Path.Replace("`n", "").Replace("`r", "") + "/pdf"; `
docker run --rm -it --init `
  -v $outputPath\:/app/pdf `
  dpp `
  -u "https://docusaurus.io/docs/cli"

I've update the prince version. Please let me know if it works for you.

docker run --rm -it --init
-v $(pwd)/pdf:/app/pdf
-v $(pwd)/fonts:/root/.fonts
openbayes/docusaurus-prince-pdf:1.1.1
-u https://docusaurus.io/docs/

The problem still exists

I've updated the prince version. Please let me know if it works for you.

docker run --rm -it --init
-v $(pwd)/pdf:/app/pdf
-v $(pwd)/fonts:/root/.fonts
openbayes/docusaurus-prince-pdf:1.1.1
-u https://docusaurus.io/docs/

I've updated the prince version. Please let me know if it works for you.

The problem still exists


Update Pipeline Editor to 0.10.1

Update Pipeline Editor to 0.10.0 which brings up fix for #1877
Developer's Certificate of Origin 1.1
   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

See follow-up issue https://github.com/elyra-ai/elyra/issues/1901


fix(test): Update E-line test to match suspension data

Summary of changes
No ticket, fixes a failing test in CI.
The train isn't running past Government Center starting in a few days.

Before getting review, please check the following:

[x] Does frontend functionality render and work correctly in IE?
[x] Have we load-tested any new pages or internal API endpoints that will receive significant traffic? See load testing docs
[x] Are interactive elements accessible to screen readers?
[x] Have you checked for tech debt you can address in the area you're working in?
[x] If this change involves routes, does it work correctly with pertinent "unusual" routes such as the combined Green Line, Silver Line, Foxboro commuter rail, and single-direction bus routes like the 170?
[x] Are the changes organized into self-contained commits with descriptive and well-formatted commit messages?

There are a few more failures around shutdowns of parts of the other Green line trains -- @arkadyan want to fix them while we're here?


Fixed build problem on windows

I switched the module imports over to using System.PosixCompat instead of System.Posix.
It now builds fine on Windows

Thanks, Jacob!


Mark kmcaster as EOL

The source code repository and developer account related to kmcaster seem to have been deleted.
@bbhtt Is it possible to mark the application as EOL?
https://github.com/DaveJarvis/kmcaster/

https://github.com/flathub/com.whitemagicsoftware.kmcaster/releases/download/1.1.0/kmcaster.jar replace the url with this.

Woah it vanished! Isnt around an archive.org or similar alternative? No github.com forks?

I uploaded the last tarball as a release, you can use that to EOL it.


Shifter: update ControlBuffer system for control shapes

From @miquelcampos on May 16, 2018 21:56
after finish mGear: IO curves #76.
Re-implement the way the control curve shapes are stored and restored in the rig.
Copied from original issue: mgear-dev/mgear#207

Discovered that when a control doesn't have an index after a size the copy of the shape doesn't happen either. For example the eyes controls.

Did you mean the index after the side correct?
I will research it


Description
The singularly can pull players and items through full solid walls, windows, and field generators.
Reproduction
Set up singularity.
Stand next to it behind a wall.
???
You are now a ghost.
Screenshots
The area where players and items are being sucked through on delta station.
(note that anything entering the PA room will be sucked in.)

The pull is even sucking players through maintenance on the lower part of the singularity.

Additional context
The pull radius is long enough to suck in someone all the way from past the PA computer console and through the windows and shutters on either side.

https://user-images.githubusercontent.com/54602815/183499101-a8b8032b-132f-492a-bf85-32a834a2ba67.mp4
This might be fixed?


Show where (which zone) a resource is stored on resource landing page

This needs a complete description of what is proposed.  I actually would like to see a design document that works this out before we go to code.  This is related to federated iRODS stores and a user's quota on each.  Firstly here are some considerations.

Information on the iRODS store a resource is held in is only relevant to owners, so should only be shown on the landing page if you are an owner.
Each user has a set quota on each iRODS store federated with HydroShare.  This is by default 20 GB on the HydroShare store and 0 GB on any other federated store.  I have suggested elsewhere that a quota resource be used by the administrators of federated zones to specify the quota for users on the iRODS store they administer.  Users can increase their quota by requesting and motivating it form the respective iRODS store administrator.
A resource can have multiple owners.
A resource has one owner who is a "quota holder" for the resource.
When any owner is looking at the landing page for a resource they should be able to see who the quota holder for the resource is.
When any owner is looking at the landing page for a resource they should be able to see the name of the iRODS store that the resource is held in.
When any owner is looking at the landing page for a resource they should have a button "Move to different iRODS store" that is enabled when the quota holder has quota on a different federated iRODS store. If they click on this button they should then be able to select the destination iRODS store to move the resource to.  This action should be rejected if the quota holder does not have sufficient quota on the destination iRODS store to hold the resource.
Any owner should be able to change the quota holder to any other owner.  This action should be rejected if the new quota holder does not have sufficient quota on the iRODS store where the resource is stored.
Note that these rules allows owners complete control over moving resources around subject to quota limitations.  Owners can perform actions that consume the quota of other owners.  This is consistent with the principle that Owners trust each other.  We do not attempt to manage the social interactions or set rules between Owners.  Owners need to work together.  If you do not trust someone, do not make them an owner of your resource.

There may be additional rules that are needed and some of these may be repetitive of requirements expressed elsewhere.  I encourage discussion and development of a design document that fleshes these out before implementation.  It would be good to have @alvacouch and @rayi113 comment.

@dtarb Here are my comments/answers to each of your bullets:

Can implement this in this PR.
This is complicated and its implementation depends on existence of external federated zones and quota management for external federated zones. Given that the first complete quota implementation is not even in yet, I don't think we are ready to implement this yet. It can be implemented at the second pass after we have an external federated zone and our current quota management implementation from admin or implementation of a quota management resource for external quota management as you suggested are in place first. I don't think we have time to do anything about this for HydroShare 1.0 since we only have 3 weeks left for HydroShare 1.0.
already implemented.
already implemented.
already implemented.
Related to No. 1 and can be implemented in this PR.
Related to No. 2 and should be implemented together with No. 2 as the second pass with detailed explained on No. 2 above.
This is already implemented, however, the check is not done to make sure the owner to be changed to quota holder has enough quota before being made a new quota holder for the resource. I'll create an issue to have this check added for release 1.11.
already implemented.
@dtarb do you want me to implement No. 1 and No. 6 in this PR to have it merged for release 1.11 or 1.12 given that No. 2 and No. 7 cannot be implemented as explained above? I am fine to retract this PR if you think we should not put it in until we are ready to implement more complete solution such as including implementation for No. 2 and No. 7, although I personally think it has merit even though we cannot implement No. 2 and No. 7 yet. Looping in @alvacouch @rayi113 @mjstealey for their reference and comments as well.

Without an ability to move a resource from one zone to another (No. 7), I do not think we should show a user anything about the zone a resource is in.  Furthermore, until we have this ability I think we should put all resources in the data zone.  I think that the complications of having multiple zones are just getting us into trouble without the ability to do anything about it and move resources around.  So, until this can be done properly, I think this should be deferred.

@dtarb Having federated multiple zones is essential for extended and distributed storage and quota management. We are patching things up and making the system to work better as we work through the issues, but we are heading in the right direction to leverage iRODS federation for distributed data and storage management. After giving this a bit of more thought, I think I can add partial solution for No. 2 and No. 7 based on what we have currently implemented. Specifically, I can add move option for users to move the resource between HydroShare data zone and HydroShare user zone regardless of whether users have iRODS user account in the user zone or not. Then in the future when external third party federated zones come into existence in HydroShare, this move-between-zones functionality can be extended to external zones. If you think this partial solution has merits and we should pursue for HydroShare 1.0, I can make an effort to make it happen. Otherwise, I am happy to close this PR to defer this for now. Let me know.

I agree that the functionality is essential.  But half the functionality is not very helpful.  I think that if you can make a plan that states what the end functionality will be for both federated zones and for the interface that allows users to work with resources in them, and the sequence of steps for implementing the plan, then I will be more comfortable moving ahead.

@dtarb I can write a design doc for this, but I don't think I will have time to implement this plan even for the partial solution I suggested above given the time left, my vacation schedule, and items for other projects I have to address before I leave for vacation. I will keep this PR open for a week or two just for discussion purposes based on the design doc I will write, then I'll close this PR since the actions will have to be deferred due to limited time we have left.

@hyi Can you comment on the status of this?

@Lizabrazil I think the plan for third party federated iRODS zone storage is still in the works or up in the air, looping in @dtarb and @alvacouch for comments as needed. I'll defer to @dtarb on whether we should close this issue or not.

@Lizabrazil @hyi @dtarb @alvacouch The current thinking via the RENCI HydroShare roadmap work-in-progress is to no longer pursue federation via iRODS in HydroShare.  Recommend closing this issue.


snap - add permission for getting key material by bip44 code

blocked by relevant permissions added to metamask-snaps-beta https://github.com/MetaMask/metamask-snaps-beta/pull/166

@kumavis is this error happening when you run tests locally?

no it was a node v12 vs node v14 issue. should be fixed in latest commit


Update Config “general”

Automatically generated by Netlify CMS

👷 Deploy Preview for determined-meninsky-f29d45 processing.
🔨 Explore the source changes: 46ac6bb24006259cfce838e8421630e01c3a681a
🔍 Inspect the deploy log: https://app.netlify.com/sites/determined-meninsky-f29d45/deploys/6137faadcaeedf0008a2aa96


Base option in nuxtconfig doesn't change scripts/styles to actually be based on that link

This makes uploading to GitHub Pages basically impossible.

I'd like to upload my Nuxt app to GitHub and use GitHub Pages with it. A search on how to do that gives these two options:

Just uploading the dist folder. This defeats the point of open source, as it makes reading the code and contributing to it pretty much impossible.
Using the GitHub action. This works in the sense that the page is public and the HTML actually gets used for that page, that actually has nothing in it (of course, as it's a static site). > The imported Javascript, however, doesn't load. This is because the code gets fetched from https://username.github.io/whatever.js, instead of https://username.github.io/page/whatever.js. Sometimes something is said about the base option, but that makes no difference.

So none of these work - how do you use Nuxt with GitHub Pages, if you even can?
Originally posted by @mybearworld in https://github.com/nuxt/nuxt/discussions/21550

Check out https://nitro.unjs.io/deploy/providers/github-pages.
Nuxt supports app.baseURL which you can set to /page/ (in your example)


Add to PATH on install.

It'd be nice for an option to add yuema to usr/bin on install so that the source directory can be deleted

The way it's supposed to be used is having the binary, the lib directory and user code files in the same directory hierarchy. System-wide installation of the binary does not make sense at this point in time and would create a lot of problems that I don't want to deal with right now.

Ah okay. I assumed it was to be installed system-wide. With the updated readme I've got it all working. Thanks very much :smile:

Happy to hear that!
The goal is for every project to be as self-contained as possible, and to make it easy to distribute your game for game jams etc., without having to worry about package installation or possible version conflicts/library incompatibilities.
The examples are a special case, that's why they must be run in this specific way.


Growroot Function Not Working

Looks like EL7's disk geometry related dracut modules don't grok LVM. Need to locate and patch requisite scripts to be more like the AMIgen6-patched versions.

Vendor-included functionality works for unpartitioned systems (typical of PVM-style launches). Vendor does not currently see the value in addressing issue for partitioned root-disks - particularly ones using LVM. In the near term, use the following work-round:
#cloud-config
write_files:
  - content: |-
      pvresize /dev/xvda2
      sed -i '/diskgrow.sh/d' /etc/rc.d/rc.local
      chmod 644 /etc/rc.d/rc.local
      rm $0
    path: /etc/rc.d/diskgrow.sh
    permissions: '0755'
runcmd:
  - |-
      echo "d
      2
      n
      p
      2

      t
      2
      8e
      w"  | fdisk /dev/xvda
  - partprobe
  - chmod 755 /etc/rc.d/rc.local
  - echo "/etc/rc.d/diskgrow.sh" >> /etc/rc.d/rc.local
  - init 6

(passed to cloud-init via UserData)

The cloud-init package still isn't updated. However, changing above runcmd method to:
runcmd:
  - parted -s /dev/xvda rm 2 mkpart primary ext4 500m 100%
  - partprobe

Produces more-reliable results. Still seems to require the init 6 to make LVM2 fully happy with the changed partitioning.

Looks like 7.4's upgrades to cloud-init fixed the growpart functionality (which closes this issue). Adding:
growpart:
  mode: auto
  devices: ['/dev/xvda2']
  ignore_growroot_disabled: false

runcmd:
  - pvresize /dev/xvda2
  - lvresize -r -L 10G VolGroup00/rootVol
  - lvresize -r -L +2G VolGroup00/varVol
  - lvresize -r -l +100%FREE VolGroup00/auditVol

After upping my root EBS by 10GiB, /dev/xvda2 gets resized by cloud-init in a way that satisfies LVM2 without need for rebooting.


Multiple initializations when used in multiple components

Hey there,
first of all, thanks a lot for developing this project!
I have tried to integrate the mnFullpage directive with an application that uses it in multiple components. When navigating between those components, the second time the directive is encountered (and on all subsequent encounters), fullPage.js throws the following error message and functionality breaks:
fullPage: Fullpage.js can only be initialized once and you are doing it multiple times!

I have created a PR that fixes this by destroying fullpage every time before initializing it. If you could accept the PR or offer any other kind of help/workaround for this issue in case I'm missing something, I would appreciate it a lot :)

Hello,
I have the same problem.
@cedrichaase Do u think your fix will be merge soon ?
Thx

Same issue here. Actually it also occurs also when you navigate from a fullscreen component to a regular component and then back to a fullscreen component.
A quick fix is to do destroy your fullpage service in the ngOnDrestoy lifecycle method :
import {
  Component,
  OnInit,
  OnDestroy
} from '@angular/core';

import { MnFullpageService } from 'ng2-fullpage';

export class YourFullpageComponent implements OnInit {
[...]
  constructor( private fullpageService: MnFullpageService ) {}
[...]
  ngOnDestroy() { this.fullpageService.destroy('all'); }
[...]
}

Thx @jpvignolo  good job 👍

Thanks for contributing the workaround @jpvignolo !
Unfortunately, this method does not do the trick for me, as I'm working with a multitude of components and I don't want to have to implement OnDestroy for every one of them just for the purpose of making fullpage.js work.
Just in case anyone stumbles upon this thread looking for a cleaner solution: I also tried calling the destroy method every time the angular Router's NavigationStart event is triggered, which didn't seem to work for some reason though.
As such, I had to abandon the idea of using this library for now. Seeing as this is a pretty cool project and I'm not the only one who experiences this issue, I'd still be happy to get a comment by @meiblorn on this and help getting a proper solution on the way!

Updated to the new version. Closing.


nit: Update repo URL in package.json

Change-type: patch
Signed-off-by: Dimitrios Lytras<EMAIL_ADDRESS>

This is a dummy PR to retrigger balenaCI, since it didn't apply a version previously.


Package and update zlib to latest

Description
There are multiple projects that depends on zlib compression library. It's currently within the project in binary form and built with old compiler configurations. Therefore to create a clean build, we'll need to:

update it, see that  nothing breaks.
package it, to it's easy to update as needed. we could put it in ko-vendor repo.

This can be closed now, because we no longer have depends on old zlib binaries in the project.


feat: 🎸 adds a company with letter f

adds a company details
fixes broken links on readme

Nice!


Paul/fix pruning

Description

This PR is the fixing mentioned on #71. It adds the slot field for message then it can be pruned by the slot field without joining transaction table.
Checklist

[x] Targeted PR against correct branch.
[x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Wrote unit tests.
[ ] Re-reviewed Files changed in the Github PR explorer.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@3bac283). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #72   +/-   ##
=========================================
  Coverage          ?   61.88%
=========================================
  Files             ?       21
  Lines             ?      913
  Branches          ?        0
=========================================
  Hits              ?      565
  Misses            ?      335
  Partials          ?       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bac283...55a660d. Read the comment docs.


Nodes added or deleted from a graph with nodes in fixed positions will cause issues

If you set <fx, fy> (fixed static) for some of the nodes on your graph and add or delete nodes thereafter your graph will "break" and become un-editable.

Now that I noticed it seems to happen even without setting specific fx or fy :thinking:

Thanks, Daniel

Just revisited this issue, seems that somehow the problem is not on the setting of fx and fy but rather on the nodes which are removed from the graph, therefore I'm closing this as it is a client-side integration issue. This can be easily triggered in the react-d3-graph sandbox where nodes and links are removed randomly and depending on the removed node and links the sandbox can break due to the randomness of the sample implementation. Before removing the nodes you should always remove the links that are source or target of the removed node.
Check the implementation that causes the issue:
    /**
     * Remove a node.
     */
    onClickRemoveNode = () => {
        if (this.state.data.nodes && this.state.data.nodes.length) {
            const id = this.state.data.nodes[0].id;

            this.state.data.nodes.splice(0, 1);
            const links = this.state.data.links.filter(l => l.source !== id && l.target !== id);
            const data = { nodes: this.state.data.nodes, links };

            this.setState({ data });
        } else {
            window.alert('No more nodes to remove!');
        }
    };

From the screenshot, it seems that this issue also pointed out this one https://github.com/danielcaldas/react-d3-graph/issues/183 which is going to be fixed here https://github.com/danielcaldas/react-d3-graph/pull/186


fix: Add null check to entityConfig

Description
Adds null check to ensure that entityConfig is valid, before accessing.
Fixes #22700
Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Jest

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:
Dev activity

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Test plan has been approved by relevant developers
[ ] Test plan has been peer reviewed by QA
[ ] Cypress test cases have been added and approved by either SDET or manual QA
[ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
[ ] Added Test Plan Approved label after reveiwing all Cypress test

/ok-to-test sha=dffffbd

/build-deploy-preview env=release

/ok-to-test sha=5c4054d

/build-deploy-preview env=release

/ok-to-test sha=d3fa178


cronjon anyone?

i wonder why that isn't in any dictionary 📖

would the correct spelling be cron_job ?


Add support for Collection property in Assets

Motivation
New collection property will be added to the Asset models in management api, this SDK should support it too.
The property will be nullable and at first be hidden behind a feature toggle and accessible only to customers that wish to participate in early access.
Proposed solution
Extend Asset models with a new Collection reference property
Additional context
early access release date: 14.6.2023
docs
the new Collection property will be an object containing a nullable reference to a collection
example of the property in json:
"collection": {        "reference": { "id": "00000000-0000-0000-0000-000000000000" }   }

Fixed in #248


Shouldn't change bug type to "defect" for regressions if they're set to "task"

If bug X that was a task bug does something wrong that is internal and has no direct user consequence, the regression bug is still a task, not a defect, and shouldn't be changed - but is still validly a regression, and the bot shouldn't claim otherwise.

This warrants a broader discussion, the rule "regression" -> "defect" is defined somewhere in the Firefox Source Docs.
Do you have a specific example?

(I ended up removing the "regressed by" ref and using "depends" instead to make the bot stop trying to mark it as defect etc. etc, but because it was over the weekend, I was effectively a bit late)

I would be interested in the Firefox source docs link for what you describe. What I can imagine being reasonable is that regressions can't be enhancements - enhancements should be new/improved features, and requests for them shouldn't reasonably be regressions.

I would be interested in the Firefox source docs link for what you describe.

Here it is in the Firefox source docs: https://firefox-source-docs.mozilla.org/bug-mgmt/processes/regressions.html#marking-a-regression-bug

OK. So I see two ways forward here:

change the policy. Personally, I think it's peculiar to claim that tasks cannot cause other task regressions, but ymmv. Perhaps @sylvestre remembers discussions around this from when that document got written / migrated from github.
come up with a different way of tracking "regressing bug", probably by using depends/blocks, and therefore in situations like the above, needinfo the triage owner instead of automatically moving from task to defect, and ask them to choose if this is a task (and if so use blocks/depends) or a defect (and if so change the bug type to defect).

(1) seems easier to me but I'm biased...

A clarification question: since the cases mentioned in https://github.com/mozilla/relman-auto-nag/issues/1832#issuecomment-1375822222 require fixing unexpected behaviour induced by a previous task (even though end users do not see it), why do we should not consider the unexpected behaviours as defects?

My understanding is that defect is only supposed to be used for something that actually affects users in some way (even if it's "just" e.g. performance, and the ultimate behaviour is otherwise the same). But these issues literally did not impact users, they were only code cleanup issues.

The definition for defect at https://firefox-source-docs.mozilla.org/bug-mgmt/guides/bug-types.html is "regression, crash, hang, security vulnerability and any other reported issue", it doesn't mention that the issue must be directly impacting users.

OK, so it sounds like this is just about me feeling like the distinction between defects/tasks should be about user impact, and this should be closed.


[2.1] salt-master config: support public cloud

Configure salt-master to read public cloud pillar
Configure mysql pillar to support public cloud specific datanae pillars
that have more nested levels and also require a list data set.
Depends-On: https://github.com/kubic-project/caasp-container-manifests/pull/172

 salt-master config: support public cloud

@jgleissner I've added you to this GitHub org - you'll need to accept for PRs to get CI'd automatically :)

I'm not sure why, but this change seems to cause issues for salt:
 [CRITICAL] Pillar render error: Failed to load ext_pillar mysql: 'list' object has no attribute 'split'

That error is caused by a bug in salt, see https://bugzilla.suse.com/show_bug.cgi?id=1072218. The bug was fixed in SLE12, but it would still show when testing with the salt SLE12 GA package.

That error is caused by a bug in salt, see https://bugzilla.suse.com/show_bug.cgi?id=1072218. The bug was fixed in SLE12, but it would still show when testing with the salt SLE12 GA package.

Then, it seems like we need to get an updated salt package into the 2.1 IBS projects (though, I thought we already did - would need to double check). If we merge this, then all the builds will start failing - and when it eventually goes out to customers - will break their environments too...

Then, it seems like we need to get an updated salt package into the 2.1 IBS projects (though, I thought we already did - would need to double check). If we merge this, then all the builds will start failing - and when it eventually goes out to customers - will break their environments too...

As said, the salt package in SUSE:SLE-12:Update was fixed, and the salt-master container in SUSE:SLE-12-SP3:Update:Products:CASP20:Update was already with using it. Anything update would automatically have the fix, or am I missing something?

As said, the salt package in SUSE:SLE-12:Update was fixed, and the salt-master container in SUSE:SLE-12-SP3:Update:Products:CASP20:Update was already with using it. Anything update would automatically have the fix, or am I missing something?

No, not missing anything. But - The builds tested here should include that fix/updated package, which suggests either the IBS projects are setup wrong - or this is a different issue of some kind..
cc @jordimassaguerpla

Sorry guys there was an old salt package in the Devel repos. A leftover when our package was newer than the one in the official SUSE repos.

waiting for the builds to finish...

tests are green.

Thanks @jordimassaguerpla for finding the issue!


onDownloadRequested

I'm sorry, I've tried many different ways but I still can't download a .png file from my url.
I'm pretty sure that the problem is with my url. (https://aguantaok.com.ar/creador-de-memes/) Yeah, it's in spanish.
Basically it's a meme generator, you upload an image file, put some text, and I really have no idea what it does when you press "Descargar" (Download).
When I managed it to work, it just opens a new url, with the meme generated but it doesn't dowload a .png file on the device.
Please let me know if this isn't the right place to ask, I'm new to this.
Thanks!!

If helps: when I do the same operation in Chrome it works great. Not in the webview.

The site is using “html2canvas” and probably something like data URLs instead of serving files directly as traditional downloads. That’s why Android’s WebView, and this library here, don’t seem to support those downloads.
If you want to test a traditional download, try it with a site like this.
You can probably work around this since you can execute JavaScript code directly from your Android application. Perhaps you could call toDataURL on a HTMLCanvasElement instance or something like that – but you’d obviously have to figure that out yourself.

Thank you so much! I'll try that out later. Thank you!


LayoutTests need to be retriaged

@alan-knight marked a chunk of co19 layout-tests as "Everything below this point is associated with co19 Issue 747". However that issue has been closed a long time ago: https://github.com/dart-lang/co19/issues/11
These tests should be retriaged.

@alan-knight I'm working on getting more gardening issues assigned. If you're not the right person to assign this to, please reassign to that person.


Refactor using Full Calendar

https://fullcalendar.io/

Resource Time Grid is a Premium feature, so it won't work.


As an athlete, I want to be able to set my display name myself, in order to maybe make it match up with a forum name or customize it further

We should let people pick their display names.
We should also give people the option of using their forum names.

This might be a duplicate of #75

I'm closing this as a dupe of #75.


Enable proxy service in the helm chart

Hi,
I had a requirement to have the proxy service enabled via the helm chart, and so based off the worker configuration I've updated the template. I've tested this on my own deployment and it worked for my purposes. It could use a review in the required java environment variables for the proxy as I wasn't 100% sure of the proxy requirements, however I assumed master from the template, and the worker on the same host as the proxy.

Can one of the admins verify this patch?

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-PR-Builder/11352/
Test PASSed.

@keifgwinn This is a cool feature. Please let me and @madanadit know when it's ready for review. Thanks!

also @keifgwinn  have you signed the cla https://cla.alluxio.org/ ?

My CEO needs to sign it, and I've passed it to him

@keifgwinn  any update on CLA ?

ping @keifgwinn any update?

We're waiting for an update on the alluxio side as to the location of the legal basis of the CLA

@keifgwinn Please let us know when you have an update. And please note that you need to do a git rebase and git push -f because the files you are changing have been modified. Thanks!

Hiya,
Situation is with your side to establish region for basis of law in your CLA
I’ve pushed this a couple of times and not gotten a reply.
--
Keif

On 22 Dec 2020, at 12:09, Jiacheng Liu<EMAIL_ADDRESS>wrote:

@keifgwinn Please let us know when you have an update. And please note that you need to do a git rebase and git push -f because the files you are changing have been modified. Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

/ping @keifgwinn

this is what i need as well, thank you for making it, do we know when it will merge and release?

it's now a few versions behind so I was going to do a new one when we moved
back into alluxio upgrades, but our own project is delayed somewhat on that
activity.
On Thu, 20 May 2021 at 09:42, StevenWCU @.***> wrote:

this is what i need as well, thank you for making it, do we know when it
will merge and release?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Alluxio/alluxio/pull/12165#issuecomment-844869104,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFSJQ6LNAKIQNYQ4PGR7VFLTOTDQ5ANCNFSM4R63FBDQ
.

it's now a few versions behind so I was going to do a new one when we moved back into alluxio upgrades, but our own project is delayed somewhat on that activity.
…
On Thu, 20 May 2021 at 09:42, StevenWCU @.***> wrote: this is what i need as well, thank you for making it, do we know when it will merge and release? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#12165 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFSJQ6LNAKIQNYQ4PGR7VFLTOTDQ5ANCNFSM4R63FBDQ .

awesome, thanks for making this pr 👯

The CLA is signed now so I'll be able to do this later.

@jiacheliu3 @keifgwinn Will this pr be updated？ We have now encountered the scenario of using proxy on k8s。

@bzheng888 I don't think this PR is active any more. Would it be possible for you to take over?

@bzheng888 I don't think this PR is active any more. Would it be possible for you to take over?
Ok, I can follow up on this pr and update.

Closing this PR as inactive, as it has been superceded by https://github.com/Alluxio/alluxio/pull/14759


Token Limit Exceeded in Workflow Generation.

Description

When running experiments (details below), I encounter errors when generating workflows using gpt-3.5-turbo caused by the query token limits.
I wonder whether this is acceptable.

Error

Implementation Details

model: gpt-3.5-turbo
benchmark: test_domain
website: tripadvisor

Upon generating workflows for approximately 9 examples, the prompt exceeds the token limit, resulting in the error shown above. As a consequence, subsequent examples rely on existing workflows, halting the generation of new workflows.

Thanks for your response!

Hi! This can happen when the model generates too many lengthy workflows, but this did not happen often during my experiments. One general advice is to keep the induced workflow short enough to fit into the context, e.g., keep temperature=0 or try sampling multiple times to get the shortest workflows. Alternatively, switching to longer-context models also works (I remember there was a 32k gpt-3.5 variant but it seems no longer available).
At the very least, it is okay to not input all workflows for one example, and/or not induce workflows only after this example. It should not affect the final results too much.
Hope this helps!

Thanks a lot!


Homepage - hero text size

Please make eyebrow, title and description text size match that of the "why zesty" page. (DON'T change colors) See comparisons:

@Katiemoser this is the updated whyzesty page

Thank you!


Error - win_year / periods_per_year not passed to CAGR function

In line 839 of the file 'reports.py' the function '_stats.cagr' is called without passing the periods per year defined in the main call:
metrics["CAGR﹪%"] = _stats.cagr(df, rf, compounded) * pct
This causes the CAGR to always be calculated with the default periods per year (252), which leads to errors in the calculation when using other periods. It should be solved with:
metrics["CAGR﹪%"] = _stats.cagr(df, rf, compounded, periods=win_year) * pct

Duplicate of https://github.com/ranaroussi/quantstats/issues/291
Unfortunately, @ranaroussi is merging PR relatively slowly so this still is an active bug although a PR is available

I was coming to report the same error. I'm not sure it's a duplicate because the periods parameter is not being passed at all whereas the other issue recommends using 365 as the default number of periods if I understand correctly.


Exclude versionlocked updates in fact yum_package_updates/yum_has_updates

How to reproduce (e.g Puppet code you use)
Fact yum_package_updates/yum_has_updates is using /usr/bin/yum --assumeyes --quiet --cacheonly list updates to list available updates. It does not take into account that packages can be versionlocked. So when a system has versionlocked packages and the system is updated through yum update, the fact  yum_has_updates will still return true. I would expect a false because the system is up to date (except the versionlocked packages).
Instead of using list updates, check-update can be considered. See below.
What are you seeing
[root@server ~]# /usr/bin/yum --assumeyes --quiet --cacheonly list updates
Available Upgrades
at.x86_64            3.1.20-12.el8            rhel-8-for-x86_64-baseos-rpms
[root@server ~]#

[root@server ~]# /usr/bin/yum versionlock at*
Updating Subscription Management repositories.
Last metadata expiration check: 0:00:56 ago on Mon 19 Dec 2022 03:11:31 PM CET.
Adding versionlock on: at-0:3.1.20-11.el8.*
Adding versionlock on: attr-0:2.4.48-3.el8.*
[root@server ~]#

[root@server ~]# /usr/bin/yum --assumeyes --quiet --cacheonly list updates
Available Upgrades
at.x86_64            3.1.20-12.el8            rhel-8-for-x86_64-baseos-rpms
[root@server ~]#

[root@server ~]# /usr/bin/yum --assumeyes --quiet --cacheonly check-update
[root@server ~]#

[root@server ~]# /usr/bin/yum versionlock clear
Updating Subscription Management repositories.
Last metadata expiration check: 0:05:49 ago on Mon 19 Dec 2022 03:11:31 PM CET.
[root@server ~]#

[root@server ~]# /usr/bin/yum --assumeyes --quiet --cacheonly check-update

at.x86_64            3.1.20-12.el8            rhel-8-for-x86_64-baseos-rpms
[root@server ~]#

What behaviour did you expect instead
If a system is up to date - even when there are versionlocked packages - I expect false.
I can create a PR, but I am not sure which approach is the way to go.
Approach 1:
Replace /usr/bin/yum --assumeyes --quiet --cacheonly list updates with /usr/bin/yum --quiet --cacheonly check-update
Approach 2:
Add a new fact (for example: yum_has_updates_ex_versionlocked). This fact uses /usr/bin/yum --quiet --cacheonly check-update.

I stepped on the same issue recently, I would use former, one should expect the fact to be empty if yum update won't update anything


Duplicated comments in JSX

Flow version: 0.123.0
<Example />; // a
<Example />; // b

Expected behavior
There should be 2 comments in the AST.
Actual behavior
3 comments in the AST. // a is duplicated.

Link to Try-Flow or Github repo: https://github.com/prettier/prettier/pull/8071, Try-Flow

Should be fixed in the next version


Attach to the right touch events in pointer event utils

We're currently attaching to mouseup for up, and touchend for leave in out pointer event util.
This works most of the time, but when an interaction is cancelled you don't get a mouseup event on touch devices according to https://developer.mozilla.org/en-US/docs/Web/API/Touch_events/Supporting_both_TouchEvent_and_MouseEvent
I think the solution is to use touchend for up, and touchcancel for leave.
I tried tracing this back, but it looks like it's been there for when the util was introduced in https://github.com/Microsoft/pxt/commit/e73516a2c51dcb72c35ce9b26cc1332e072786e0
In Blockly we use touchend and touchcancel for mouseup, so someone should investigate this, but I think the root cause is somewhere in this code.
https://github.com/Microsoft/pxt/pull/5203 is just one example that we ran into where we've had to hack it to subscribe to the correct events.

Fixed


Fix nrf5x sector count

Fix sector count setting, looks like a typo to me.

/morph test

/morph test


Input value overwritten by initialization

Is it expected behavior that if a value attribute is provided for the input field, it will be ignored and overwritten as null upon the datetimepicker initialization?  I see documentation that allows me to set a defaultDate option during initialization, but I want to be able to provide a date (string format) to the input value instead.  I can't imagine that I'm the only one who expected/wanted that to work, so I am thinking it must be a bug of some sort.

@NVV-WebManager, it will do that if your value doesn't match the expected date format of the datetimepicker.  Try passing the format option into the datetimepicker initializer with the same format as your field's value (i.e. if your value is 10/04/2016 then the format should be format: 'MM/DD/YYYY').  It uses moment.js' date formats (http://momentjs.com/docs/#/displaying/format/).

Thanks for the suggestion, but I had already read that that could be the cause, and formatting the dates doesn't address the problem.  I have my php output value set to format as ''m/d/Y g:i A' and the datepicker is set to format 'MM/DD/YYYY h:mm A' - that should be exactly the same.  But my value is still getting overwritten as blank once the datepicker is initialized.  Any other ideas?

Hi. I have the same issue in .NET MVC. it's very strange and unexpected behaviour. Date format, used in code, can be different from display format.


[EUWE] Fix missing Back button on Host Drift comparison page

Caused by missing cherry-pick of https://github.com/ManageIQ/manageiq/pull/13084
This PR is adding the class for ShowSummary (Back Button on Hosts' Drift comparison) from the original PR as it's sufficient as a bugfix
https://bugzilla.redhat.com/show_bug.cgi?id=1436074

updated PR, fixed Rubocop issues

@miq-bot add_label bug

@simaishi : sorry for merging this one. I just realized I should have just review it :-(
Hope I have not broken something.


@eessex => More Gucci QA

A few items in: https://waffle.io/artsy/publishing/cards/5a06602bba60dc0093adc64d

👏


[IMP] Updated xsd files

Updated xsd files from SAT

@nhomar
Could you merge this PR and make the release, please?
Regards


fix(types): fix mergeProps type when spreading array as params

Summary
This fixes the return type of mergeProps when an array is spread as params: mergeProps(...propsArray), mergeProps(...propsArray, props), and mergeProps(props1, ...propsArray, props2). Previously these calls would ignore the type of the array being spread and all props after the spread e.g.:
const merged = mergeProps({ a: 1 }, ...[{ b: 2 }], { c: 3}); // { a: 1 }

Allow mergeProps to be called with all manner of spread params and return the correct type.
As a consequence of the above, mergeProps' type allows calling it with no params.
Brought back Simplify, since it doesn't interfere with generics and improves readability of the result type.
Simplified and added comments for component.ts type tests.

How did you test this change?
Added new type test cases to component.type-tests.ts (and ran tests).

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 89.005%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1242

Relevant Lines:
1325

💛  - Coveralls


Keywords are reserved in CDL files.

et me amend my previous reply.
re: e-support ticket BNL-694121
There is an ambiguity in the grammar for cdl files.
Consider this CDL file fragment:
netcdf X {
variables:
int data;:
data:_Fillvalue = ...
The last line is ambiguous because it can be interpreted as the beginning
of the data: section. If you remove that line, thecdl file
compiles ok. This is going to be difficult to fix (maybe impossible)
because it can require significant lookahead.
It appears that this is only a problem for variables named 'data' or 'group'.
Possible solutions:

require the use of '' escape so one has to write:
\data: _Fillvalue=...

Ok, so I had this wrong. ncgen handles this ok, as per this comment in the ncgen man page.

Note  also that the words variable', dimension', data', group', and
`types' are legal CDL names, but be careful that there is a  space  be-
tween  them  and  any following colon character when used as a variable
name.  This is mostly an issue with attribute declarations.

However, ncdump does not obey this rule. So that needs to be fixed.

Ok, so the fix is in as a pull request. Closing issue.


Small updates to tests

#642  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @carolineechen and the rest of your teammates on  Graphite


Internal ROM reading

Hello,
you write in the page readme

8 KB of integrated ROM at 0x0000-0x1FFF, cannot be read by user

this is not true. The DATA instruction OPcode 35H reads the data from the internal ROM when the address in AB is in the 0000-1FFF range

Ha, didn't know that. Thanks a lot for the info and the PR!


Message on login?

Instead of having an infobox would it be possible to just have it send a message on login? Sort of how 'Daily Task Indicator' does it.

Resolved in 8eb07afaff44d5b24560a6f650e608c0b5463670


http1.1: support half closed clients

In http1.1 a client can choose to add "Connection: close" to the header and half close their (write) end of the socket and wait for the answer
What happens is envoy does forward the request but then immediately closes both end (probably because it reads the EOF/readability of 0 as an error instead of normal)
Repro
$ fortio curl -loglevel=debug -keepalive=false -halfclose http://echosrv2:8080/debug
18:41:30 D http.go:290> Created client:
{IP:<IP_ADDRESS> Port:8080 Zone:}
GET /debug HTTP/1.1
Host: echosrv2:8080
Connection: close
User-Agent: istio/fortio-0.3.6

18:41:30 D http.go:504> Half closed ok after sending request &{{0xc4200e25b0}} {<IP_ADDRESS> 8080 }
18:41:30 E http.go:545> EOF before reading anything on &{{0xc4200e25b0}} {<IP_ADDRESS> 8080 }
18:41:30 V fortio_main.go:141> Fetch result code -1, data len 0, headerlen 0

envoy log
[2017-11-16T18:41:30.081Z] "GET /debug HTTP/1.1" 0 - 0 0 0 - "-" "istio/fortio-0.3.6" "e16c359b-048a-47a5-b5ab-b5e917bd2f72" "echosrv2:8080" "<IP_ADDRESS>:8080"

Spec extract

Servers SHOULD always respond to at least one request per connection, if at all possible. Servers SHOULD NOT close a connection in the middle of transmitting a response, unless a network or client failure is suspected.

cc @ggreenway who mentioned he is fixing it for tcp

Tracking tcp proxy issue at https://github.com/envoyproxy/envoy/issues/2067

Does anyone know if mainstream browsers (Chrome, Firefox etc) can end up doing TCP half-close under certain scenarios ?

It clearly shows that there are web apps that end up doing TCP half-close
(eg: see attachment Reviewboard app in Firefox)
Given this behavior, shouldn't Envoy support TCP half-close on HTTP connections?
HA-Proxy seems to work just fine with this.
I haven't yet seen client badness/error etc due to this but its very confusing to see so many "DC" response flag messages being logged in Envoy access logs frequently. I'm not sure how the app recovers from this lack of HTTP response due to cnxn close.
firefox-half-close.pdf

It clearly shows that there are web apps that end up doing TCP half-close
(eg: see attachment Reviewboard app in Firefox)
Given this behavior, shouldn't Envoy support TCP half-close on HTTP connections?
HA-Proxy seems to work just fine with this.
I haven't yet seen client badness/error etc due to this but its very confusing to see so many "DC" response flag messages being logged in Envoy access logs frequently. I'm not sure how the app recovers from this lack of HTTP response due to cnxn close.
firefox-half-close.pdf

I brought this up a few years ago as a potential issue, and at the time, no widely-used http client was sending a half-close after the request but before the response. I looked at several.  If that's changed, we may need to revisit this.

I looked at several. If that's changed, we may need to revisit this.

As mentioned on the (dupe) issue #17160 filed by my colleague, looks like busybox's wget has moved to using half-close in recent versions.  Since busybox is used a lot for tire-kicking in Kubernetes, I think this is worth fixing.  It makes Envoy appear flaky.

What version of busybox is it that's broken? I went grep'ing through the busybox source and found this in wget.c:
/* Tried doing this unconditionally.
 * Cloudflare and nginx/1.11.5 are shocked to see SHUT_WR on non-HTTPS.
 */
#if SSL_SUPPORTED
		if (target.protocol == P_HTTPS) {
			/* If we use SSL helper, keeping our end of the socket open for writing
			 * makes our end (i.e. the same fd!) readable (EAGAIN instead of EOF)
			 * even after child closes its copy of the fd.
			 * This helps:
			 */
			shutdown(fileno(sfp), SHUT_WR);
		}
#endif

Looking at the history, the shutdown( SHUT_WR) call was added in 2016-08-20, and the conditional for only doing it on https (and comment) were added 2017-01-11, so I'm wondering if you're on a version between those two dates. Also, sounds like other widely-deployed http proxies also don't like half-close, based on that comment.

Yes, I think we hit the sweet spot for that issue.  v1.26.  I misread my colleague's comment on our slack; he said they "only do it for HTTPS since v1.27" which I took to mean "only started doing it for HTTPS too in v1.27".

ping

ping

@ldemailly this is unlikely to see any movement unless someone shows a need for it and is willing to work on the fix.

This is a real problem for CONNECT. TCP half-close is much more common and if we want to faithfully map onto HTTP/1.1 CONNECT,  we need to support half-closed semantics. The issue can happen with read direction, too (e.g. upstream closing their end, which is interpreted as full close by Envoy but as half-close by tcp_proxy client).


OSX: Remove support for 32-bit and fat binaries

Mac OS X is 64-bit only since 10.7 (Lion), which has reached End-Of-Life in October 2014.
On top of that, Apple is also now refusing 32-bit only apps from its App Store, and will remove the existing ones by mid 2018.
Therefore it no longer makes sense to support exporting 32-bit binaries for Mac OS X,
and we can now default to 64-bit instead of bigger "fat" binaries.
Fixes #12704.

Additional commits to cherry-pick (pushed a bit too fast a couple times...): 42c5af5e + 3e6f2b7 (fixup), 1602e0cd

Since we shipped 3.0 with fat binaries I'd like to continue doing that until 3.1. If someone out there started their project on an unsupported MacOS version they should be able to finish it on 3.0.z

Since we shipped 3.0 with fat binaries I'd like to continue doing that until 3.1. If someone out there started their project on an unsupported MacOS version they should be able to finish it on 3.0.z

If we ever do a 3.0.7 build (e.g. to solve #41186 for 3.0 users, if there are still any), this change will be needed as there is no 32-bit support in recent Xcode versions, necessary to build against the expected SDK for recent macOS. So putting this back in the queue for a potential 3.0 cherrypick (I'm cherrypicking it for 2.1.7 in a dedicated PR).


Use -panel suffix for trayicons

Hey there.
I recently noticed that pa-applet uses the normal audio-volume-* icons, which is generally fine.
However, for monochrome icon themes (or icon themes that use monochrome icons for the tray) it would be great if you could first check for the audio-volume-*-panel icons and use the normal ones as fallback.
Cheers!

@ochosi This doesn't work with some themes. I checked Adwaita, GNOME and HighContrast.


Root-relative URLs do not work for JS files

Root-relative URLs for JS files cause errors like this: Error: Could not load script: "file:///test.js"/
Originally posted in https://github.com/giakki/uncss/pull/280#issuecomment-281437450, because I thought the issue was specific to the JSDom implementation. @RyanZim informed me, though, that the same error occurs with PhantomJS, it is just quietly ignored.
@vseventer suggested:

uncss allows /css/main.css, so there is no reason why /js/main.js shouldn't be supported also. This could be fixed by having htmlroot (or, more precise, utility.parsePath) apply to stylesheets and scripts (currently, it only applies to stylesheets).

Forgot to mention: I created a simple test repo to illustrate the problem at https://github.com/davidtheclark/uncss-jsdom-test.

uncss allows /css/main.css, so there is no reason why /js/main.js shouldn't be supported also.

I agree with @vseventer.
I don't know if/how this is possible via PhantomJS, however, in jsdom, this could be done via

config.resourceLoader: a function that intercepts subresource requests and allows you to re-route them, modify, or outright replace them with your own content.

I will submit a patch to the jsdom branch when I get a chance (unless someone gets there before me). When it is merged to the jsdom branch, I will publish a new version of uncss-jsdom.

Sorry so long; I finally got the patch released as uncss-jsdom v2.0.0

I've just released uncss 0.15.0, which I believe should include all of the above fixes.

I'm hitting this with gulp-postcss and uncss 0.15.
var gulp = require('gulp');
var cssmin = require('gulp-clean-css');
var postcss = require('gulp-postcss')
var uncss = require('uncss').postcssPlugin;
var config = require('../../config').optimize.css;

gulp.task('optimize:css', function() {
    return gulp.src(config.src)
        .pipe(postcss(uncss(config.uncss)))
        .pipe(cssmin(config.options))
        .pipe(gulp.dest(config.dest));
});

...js
uncss: {
html: [buildDir + '/**/*.html'],
ignore: [
/\w.in/,
'.fade',
'.collapse',
'.collapsed',
'.collapsing',
/(#|.)navbar(-[a-zA-Z]+)?/,
/(#|.)dropdown(-[a-zA-Z]+)?/,
/(#|.)(open)/,
// injected via JS
/disabled/,
/.no-js/,
/.defer/
]
}

C:\Users\xmr\Desktop\foo>node -v && npm -v
v8.2.1
5.3.0
C:\Users\xmr\Desktop\foo>npm run build

<EMAIL_ADDRESS>build C:\Users\xmr\Desktop\foo
gulp production:build

[19:57:51] Using gulpfile ~\Desktop\foo\gulpfile.js
[19:57:52] Starting 'optimize:css'...
Error: Could not load script: "file:///C:/assets/js/pack.js"
at C:\Users\xmr\Desktop\foo\node_modules\jsdom\lib\jsdom\browser\resource-loader.js:44:23
at Object.check (C:\Users\xmr\Desktop\foo\node_modules\jsdom\lib\jsdom\living\nodes\Document-impl.js:89:11)
at ReadStream. (C:\Users\xmr\Desktop\foo\node_modules\jsdom\lib\jsdom\living\nodes\Document-impl.js:108:12)
at ReadStream.wrappedEnqueued (C:\Users\xmr\Desktop\foo\node_modules\jsdom\lib\jsdom\browser\resource-loader.js:255:16)
at emitOne (events.js:115:13)
at ReadStream.emit (events.js:210:7)
at fs.js:1940:12
at FSReqWrap.oncomplete (fs.js:135:15) { Error: ENOENT: no such file or directory, open 'C:\assets\js\pack.js'
errno: -4058,
code: 'ENOENT',
syscall: 'open',
path: 'C:\assets\js\pack.js' }

I'm simply using `<script src="/assets/js/pack.js" async></script>` to load the script. Uncss even fails for the google analytics script which is in a JS file itself and is using protocol relative URL.

Oh sorry, my comment above about 'fixing this' was wrong. I was overzealous and tagged this one.
No, scheme-relative and host-relative paths will not work when you are accessing local html files. If you are accessing C:/Users/you/Projects/web/file.html that references /assets/js/pack.js, then what is the correct place to look for pack.js? This is not a solvable problem given the information available.
Scheme-relative ones are also tricky, in that it's using a file:// scheme, and google-analytics JS will not work that way. You can just specify https:// in your path-to-google-analytics.js (instead of a scheme-relative path), and things should just work there. Basically, don't use scheme-relative...just use http or https instead, as appropriate (based on what the target resource is served under).

In the past IIRC htmlRoot was being used. Did that change?

htmlroot (String): Where the project root is. Useful for example if you have HTML that references local files with root-relative URLs, i.e. href="/css/style.css"

The thing is that things worked with 0.14.1. And I also have the canvas issue which is why I haven't updated uncss in grunt-uncss.
These two issues are blockers and quite important IMO.

Just to clarify, are we talking about protocol-relative URLs or root-relative URLs?

Root-relative URLs. Protocol-relative URLs don't work too but that's a different issue.

So, after specifying htmlroot I'm getting this:
[12:15:42] Starting 'optimize:css'...

events.js:182
      throw er; // Unhandled 'error' event
      ^
TypeError: css.walkRules is not a function
    at getUsedSelectors (C:\Users\xmr\Desktop\foo\node_modules\uncss\src\lib.js:129:9)
    at C:\Users\xmr\Desktop\foo\node_modules\uncss\src\lib.js:226:16
    at tryCatcher (C:\Users\xmr\Desktop\foo\node_modules\bluebird\js\release\util.js:16:23)
    at MappingPromiseArray._promiseFulfilled (C:\Users\xmr\Desktop\foo\node_modules\bluebird\js\release\map.js:61:38)
    at MappingPromiseArray.PromiseArray._iterate (C:\Users\xmr\Desktop\foo\node_modules\bluebird\js\release\promise_array.js:114:31)
    at MappingPromiseArray.init (C:\Users\xmr\Desktop\foo\node_modules\bluebird\js\release\promise_array.js:78:10)
    at MappingPromiseArray._asyncInit (C:\Users\xmr\Desktop\foo\node_modules\bluebird\js\release\map.js:30:10)
    at Async._drainQueue (C:\Users\xmr\Desktop\foo\node_modules\bluebird\js\release\async.js:138:12)
    at Async._drainQueues (C:\Users\xmr\Desktop\foo\node_modules\bluebird\js\release\async.js:143:10)
    at Immediate.Async.drainQueues (C:\Users\xmr\Desktop\foo\node_modules\bluebird\js\release\async.js:17:14)
    at runCallback (timers.js:781:20)
    at tryOnImmediate (timers.js:743:5)
    at processImmediate [as _immediateCallback] (timers.js:714:5)

Did you investigate this issue at all, or are you just sharing it here? Do you need me to help debug it for you?
What version of postcss are you using, from the postcss/package.json? Do you have a 'walkRules' in your postcss package?
And from the other angle, what is the 'css' object passed into that function? Is it a valid postcss object? What methods does it have on it?

@mikelambert This is an internal uncss error coming from https://github.com/giakki/uncss/blob/master/src/lib.js#L129.
The postcss version would be the same as what uncss is using. postcss does have a walkRules function. It seems somehow, uncss is passing that function an object other than a postcss root object.

@XhmikosR is it possible to reproduce this issue without using grunt? If so, I'd be willing to investigate if you could make a test case repo or gist.

That is not with Grunt. It's with gulp-postcss and uncss.

Thanks @RyanZim on the last bit.
And yes, I'm aware the uncss code is emitting the exception, and that uncss has a dependency on postcss that should contain the walkRules. But I also know @XhmikosR has various uncss checkouts of uncss as a developer with commit privileges, so wanted to do a sanity-check that the dependencies were properly reinstalled in his/her checkouts. Especially since it's not clear what steps @XhmikosR has taken in debugging the issue yet.
But yes, I am also curious what object is actually being passed into the getUsedSelectors function.

Nah, this is with vanilla uncss 0.15, see https://github.com/giakki/uncss/issues/287#issuecomment-320300504
I can't find why this happens. If I could I would have said so :P

I mean, the css file is there, generated with sass before the uncss task runs. The html files are there too. I can't figure out why this error.

Ok thanks. Can you provide a self-contained repro case? Or can you log and share the values I requested above? Namely, what is the 'css' object being passed into getUsedSelectors ?

[01:08:50] Starting 'optimize:css'...
>> uncss - css: <File "main.css" <Buffer 2f 2a 21 0d 0a 20 2a 20 42 6f 6f 74 73 74 72 61 70 20 76 34
 2e 30 2e 30 2d 61 6c 70 68 61 2e 36 20 28 68 74 74 70 73 3a 2f 2f 67 65 74 62 6f 6f 74 73 ... >>

events.js:182
      throw er; // Unhandled 'error' event
      ^
TypeError: css.walkRules is not a function
    at getUsedSelectors (C:\Users\xmr\Desktop\foo\node_modules\uncss\src\lib.js:130:9)
    at C:\Users\xmr\Desktop\foo\node_modules\uncss\src\lib.js:227:16
    at tryCatcher (C:\Users\xmr\Desktop\foo\node_modules\bluebird\js\release\util.js:16:23)
    at MappingPromiseArray._promiseFulfilled (C:\Users\xmr\Desktop\foo\node_modules\bluebird\js\release\map.js:61:38)
    at MappingPromiseArray.PromiseArray._iterate (C:\Users\xmr\Desktop\foo\node_modules\bluebird\js\release\promise_array.js:114:31)
    at MappingPromiseArray.init (C:\Users\xmr\Desktop\foo\node_modules\bluebird\js\release\promise_array.js:78:10)
    at MappingPromiseArray._asyncInit (C:\Users\xmr\Desktop\foo\node_modules\bluebird\js\release\map.js:30:10)
    at Async._drainQueue (C:\Users\xmr\Desktop\foo\node_modules\bluebird\js\release\async.js:138:12)
    at Async._drainQueues (C:\Users\xmr\Desktop\foo\node_modules\bluebird\js\release\async.js:143:10)
    at Immediate.Async.drainQueues (C:\Users\xmr\Desktop\foo\node_modules\bluebird\js\release\async.js:17:14)
    at runCallback (timers.js:781:20)
    at tryOnImmediate (timers.js:743:5)
    at processImmediate [as _immediateCallback] (timers.js:714:5)

Unfortunately I cannot share the repo so if this info doesn't help, I'll need to try to make a small test case.

Ok, I found it!

Glad you found it. Them bugs can be mean. Can we close this now?

I think this issue is no longer valid, yeah. Root-relative files work fine with htmlroot.


Add option time till autosave bar

Feature request: Add option for Time till Autosave bar under the Next cookie, Next Reindeer bar/countdown.
Helps with save scumming.

This statistics is already included. You can find it under the Miscellaneous section!


minor.

Codecov Report

Merging #4 into master will decrease coverage by 0.50%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master       #4      +/-   ##
==========================================
- Coverage   72.00%   71.50%   -0.50%
==========================================
  Files           1        1
  Lines         200      200
==========================================
- Hits          144      143       -1
- Misses         56       57       +1

Impacted Files
Coverage Δ

wikiapi.js
71.50% <0.00%> (-0.50%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fba9354...589cc9a. Read the comment docs.


Save the last checkpoint also in a folder as others

Currently, the last checkpoint is saved in the root folder of other checkpoints. This minor change put the last one also in the same level of folder as others.

The original setup where the last checkpoint data is saved to the folder root is, basically, a carry-over from some Huggingface script. This means, we don't really have a good reason for doing that. On the other hand it is something I used to assume that many people are used to . I wonder if there is a good reason to change the current setup?

Hi @luyug, thanks for the feedback.
I see its carry-over from Huggingface examples and it really doesn't matter a lot for now.
The reason that I propose this change is that I am developing an automatic validation toolkit for DRs and I'm taking tevatron as the example to generate DR checkpoints (so my toolkit should be directly usable for tevatron once it's done). This change is just more convenient for my case. I think we can leave this pull requirest here and see if this is necessary later.

In that case, one thing we could potentially do is to keep the original setup and store last checkpoint files at root. On top of that, have a folder like checkpoint_last where we keep a set of symlinks. Or the other way around, keep the actual files in that folder and the symlinks at root.

Hi @luyug @MXueguang, here is the DR checkpoints validation toolkit that I mentioned in this pull request: https://github.com/ielab/asyncval/tree/main/examples/msmarco-passage
Tevatron users can just pip install asyncval and then follow this example to run DR checkpoint validation generated by tevatron trainer. Any feedback or suggestions?

Hi @ArvinZhuang, this looks nice! I will take a closer look at it and see if it can also work with our planned future developments.
BTW, would you like to potentially put an example into the Tevatron's example folder?

Hi @luyug, yep I definitely would like to add an example in Tevatron as well. I'll do this once I have time.
and for compatible future tevatron plans, I think as long as the encode_passage and encode_query APIs in DenseModelforInference class keep unchanged, then it will work.

Hi @luyug, I have added a section in example/READEME.md for Asyncval, feel free to move it in an additional example folder if you like. Also, I undo the changes made before as it will break some examples. So for Asyncval, the problem is still there: an error will raise for the last checkpoint validation as it is not in the same path level as other checkpoints.

Hi @ArvinZhuang
I just updated docs in /examples, so the current change here will have conflicts.
Do you mind move the asyncval example to examples/example_asyncval? then we can merge the PR.

@MXueguang Hi, I have created the example file.


V.3+ (CRITICAL BUG)  App freezes when user navigates away from it

Version 3.0.6 (ios)
When user stops using app and goes to different apps (for a long stretch of time) the application frequently freezes and becomes unresponsive. Only way for user to 'unfreeze' is to delete the app and reinstall it.
ToDO: make sure the app status remains active and accessible EVEN when the user navigates away from the app.
https://user-images.githubusercontent.com/62637055/195475674-1c3ed355-f9f1-46b3-8f22-d2768fc78bc0.MOV

Did not experience any freezes while navigating through the app

https://user-images.githubusercontent.com/6989882/199072281-9cce9aee-b107-473c-afd8-f5748c4a5fd9.mp4
The app froze for a while after navigating out to other apps but after much clicking it finally responded.

how much time did you put the iSeaTree app on background status, @queenieth ?

@bestw07 I made different videos, some as  much as 4 mins but couldn't upload it coz of the size

@mtalhadev I'm wondering if this might have anything to do with the fact we switched off expo a few years ago (and went for a pure react-native framework). Reading this made me wonder if the bug was somehow related to that
https://blog.expo.dev/how-to-run-background-tasks-in-react-native-e1619acef48f

I haven't seen this issue in the latest testflight build (4.0 / 67). I believe @mtalhadev has fully resolved it - thank you!


feat(kebernetes-incluster): Adding kubernetes in cluster subcommand

What type of PR is this?
/kind feature
Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area cmd
/area pkg
What this PR does / why we need it:

Adding a sub-command to use Kubernetes feature inside a kube pods with the appropriate service token/account.
Adding configs/flags options to handle non root execution and pull secrets when using custom builder image.
Fixing Kubenertes execution and probe module extraction. (Now extract module and probe properly, than delete the configmap and the pod)

To make non root execution works, I had to make a sub docker image builder with this owner change:
FROM falcosecurity/driverkit-builder

RUN chown -R nobody /usr/bin

I have to do this because driverkit's generated build script run a ln -sf /usr/bin/gcc ..., requiring root right/access.
Can you see another workaround ? Except to rewrite the builder Dockerfile and scripts to make them non-root executable.
Which issue(s) this PR fixes:
None
* New sub-command `kubernetes-in-cluster` or `k8s-ic`
* New Kubernetes flags:
  * namespace: Namespace where to execute the builder pod
  * run-as-user: User Id of the pod
  * imagePullSecret: Pull secret for custom builder image

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Lowaiz
Once this PR has been reviewed and has the lgtm label, please assign dwindsor for approval by writing /assign @dwindsor in a comment. For more information see:The Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Hi @Lowaiz ! Thanks for this great PR!

I have to do this because driverkit's generated build script run a ln -sf /usr/bin/gcc ..., requiring root right/access.
Can you see another workaround ? Except to rewrite the builder Dockerfile and scripts to make them non-root executable.

Mmmh perhaps we could override CC env variable?
For reference, the ubuntu one would become:
{{ if .BuildModule }}
# Build the module
cd {{ .DriverBuildDir }}
make CC=/usr/bin/gcc-{{ .GCCVersion }} KERNELDIR=$sourcedir
mv {{ .ModuleDriverName }}.ko {{ .ModuleFullPath }}
strip -g {{ .ModuleFullPath }}
# Print results
modinfo {{ .ModuleFullPath }}
{{ end }}

This is what we already do for clang btw, eg (taken from same ubuntu script):
{{ if .BuildProbe }}
# Build the eBPF probe
cd {{ .DriverBuildDir }}/bpf
if [[ -x /usr/bin/llc ]]; then
	LLC_BIN=/usr/bin/llc
else
	LLC_BIN=/usr/bin/llc-7
fi

if [[ -x /usr/bin/clang ]]; then
	CLANG_BIN=/usr/bin/clang
else
	CLANG_BIN=/usr/bin/clang-7
fi

make LLC=$LLC_BIN CLANG=$CLANG_BIN CC=/usr/bin/gcc-8 KERNELDIR=$sourcedir

Hi @FedeDP,

I think this would be a valuable improvement that perhaps could go in a different PR, wdyt?

This enhancement make usable the non-root security context, so I guess we should put them together.
I already pushed the changes, but I can move them elsewhere if needed

This enhancement make usable the non-root security context, so I guess we should put them together.

Yep, no problem on my side :)

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP, Lowaiz
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 6909a3694c978790a47bb7e4f0e83f5afe8871b0


Is there a way to know how much time remains before a token expires?

Just what the subject says.

I did try make_headers() but this seems to make the created-at and expired-at values anew.

Have a look at the code between the lines 421 and 458.

Right. I have been there. I was hoping there was already a facility to return it. Yes, if there were such a method, the code would have been refactored. But it does not hurt to ask...

if you are using TimedJSONWebSignatureSerializer to generate the tokens, u can set return_header to True while you are loading a token, the returned header has values through which you can compute the remaining time.

max_age = 300
serializer = TimedSerializer('secret')
token = s.dumps('message')
_, ts = t.loads(t, max_age=max_age, return_timestamp=True)
remaining = max_age - (datetime.utcnow() - ts).total_seconds()


Wrap showOptionsWithButtons over zenity

Coverage increased (+0.02%) to 80.925% when pulling ab988718030d6afe15903875fa86bb61cbd3851a on feature/wrap-button-options-over-zenity into e01e59f11e57abd7afbdc7f32049ea4a195cd756 on main.


Read-Only Access to Users in Logz.io not available in tf provider

A few months ago we started looking into this new feature https://logz.io/blog/assign-read-only-access-to-users-in-logz-io/ that was published on the blog.
We would like to apply this feature across 100s of users in our org. We manage our Logz.io users using terraform. It seems this feature is not yet part of the terraform provider https://registry.terraform.io/providers/logzio/logzio/latest/docs/resources/user .
I'd like to know if this is something on the roadmap and when we can expect it in the tf provider ?

Hi @TaSeeMba ,
This feature will be available in the next release of our provider, which should be released in the next couple of weeks, stay tuned :)

Hi @TaSeeMba, we release v1.10.0, and it should handle this issue.
Can you please upgrade and confirm that the issue was solved?


[ASCII-1813] Update macos old runner to 12 for gohai test workflow

What does this PR do?

Update the "old" MacOS runner in the gohai test workflow to MacOS 12.
Motivation

MacOS 11 will soon be deprecated so we should stop using it before then.
Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge


fix: automated publish

I think the syntax for scheduling jobs may have changed.
Ref: https://help.github.com/en/actions/reference/events-that-trigger-workflows

If this works here the .github dir needs copying to the https://github.com/ipfs/npm-go-ipfs-dep repo as that's probably why the automated publish has never worked there.


Not possible overrride splashFactory and highlightColor  in ButtonStyleButton

I like the TextButton introduced in 1.22, and I try to expand it into my own favorite style.
But I found that I cannot set the splashFactory, because the splashFactory parameter in _ButtonStyleState is a fixed value "InkRipple.splashFactory".
This is really boring, because I can't get rid of the click effect.
I think it should be the same as the previous Button, following the setting of Theme instead of a fixed value.
child: InkWell(
          ...
          splashFactory: InkRipple.splashFactory, // this.
          overlayColor: overlayColor,
          highlightColor: Colors.transparent, // and here
          ...

@HansMuller

Hi @HeebeLee
I believe this is by design, button_style_button follows material design guidelines
https://github.com/flutter/flutter/blob/a0a65fc60442285b99d179ce7923430d129819a4/packages/flutter/lib/src/material/button_style_button.dart#L356-L360

code sample
import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Material App',
      theme: ThemeData.dark(),
      home: Home(),
    );
  }
}

class Home extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text('Material App Bar'),
      ),
      body: Center(
        child: TextButton(
            style: ButtonStyle(
              backgroundColor: MaterialStateProperty.all<Color>(Colors.white),
              elevation: MaterialStateProperty.all(5),
            ),
            onPressed: () {},
            child: Text('Press here')),
      ),
      floatingActionButton: FloatingActionButton(
        child: Icon(Icons.add),
        onPressed: () {},
      ),
    );
  }
}

flutter doctor -v
[✓] Flutter (Channel master, 1.23.0-8.0.pre.132, on Mac OS X 10.15.7 19H2
    x86_64, locale en-GB)
    • Flutter version 1.23.0-8.0.pre.132 at
      /Users/tahatesser/Code/flutter_master
    • Framework revision 5e97eed895 (71 minutes ago), 2020-10-05 00:42:50 -0700
    • Engine revision a8d7d97bef
    • Dart version 2.11.0 (build 2.11.0-185.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at /Users/tahatesser/Code/sdk
    • Platform android-30, build-tools 30.0.2
    • ANDROID_HOME = /Users/tahatesser/Code/sdk
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.0.1, Build version 12A7300
    • CocoaPods version 1.9.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 50.0.1
    • Dart plugin version 193.7547
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.49.3)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.15.0

[✓] Connected device (3 available)
    • macOS (desktop)  • macos      • darwin-x64     • Mac OS X 10.15.7 19H2
      x86_64
    • Web Server (web) • web-server • web-javascript • Flutter Tools
    • Chrome (web)     • chrome     • web-javascript • Google Chrome
      85.0.4183.121

• No issues found!

but I kinda understand the need to remove Splash Effect so labelling as a proposal rather than a bug

This is very bad design decision. This was allowed with previous implementation of material buttons, why would you do that? Why would we have ThemeData.splashFactory then?  Now we cannot customize our splash colors in any way at all (I mean, we cannot even change splash color, what on earth is that)

+1 I need remove splash effect

+1 I need remove splash effect

If this is Hans Muller flutter_buttons code, there is
splashFactory: InkRipple.splashFactory, // TODO put this in ButtonStyle
I thing this was one of those to things that passed to the final version or a bad decision, unless IOS development is a second class citizen. In there is kind-of unacceptable to have google's splash thing.
+1 for this...

If this is Hans Muller flutter_buttons code, there is
splashFactory: InkRipple.splashFactory, // TODO put this in ButtonStyle
I thing this was one of those to things that passed to the final version or a bad decision, unless IOS development is a second class citizen. In there is kind-of unacceptable to have google's splash thing.
+1 for this...

You're (all) correct, ButtonStyle should support overriding the splash factory. Will restore that.

You're (all) correct, ButtonStyle should support overriding the splash factory. Will restore that.

Thank you for understanding.  In fact, in addition to making components
comply with standards, flexible design and matching are also very important.
On Fri, Jan 15, 2021 at 1:12 AM Hans Muller<EMAIL_ADDRESS>wrote:

You're (all) correct, ButtonStyle should support overriding the splash
factory. Will restore that.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/flutter/flutter/issues/67149#issuecomment-760334866,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACV6CILGLBG2EJH5DJ6LWYTSZ4QWPANCNFSM4SB7KNBQ
.

Thank you for understanding.  In fact, in addition to making components
comply with standards, flexible design and matching are also very important.
On Fri, Jan 15, 2021 at 1:12 AM Hans Muller<EMAIL_ADDRESS>wrote:

You're (all) correct, ButtonStyle should support overriding the splash
factory. Will restore that.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/flutter/flutter/issues/67149#issuecomment-760334866,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACV6CILGLBG2EJH5DJ6LWYTSZ4QWPANCNFSM4SB7KNBQ
.


Native Run-Time Type Information support

This PR is based on https://github.com/Autodesk/AutomaticComponentToolkit/pull/141  and https://github.com/Autodesk/AutomaticComponentToolkit/issues/142
PR is in draft state so far but fully illustrate an approach that allows using native RTTI support.
In a few words the PR addresses missed part of ACT - original type of an object that has been passed from library to application side.
Let's look on an example.
AnimalIterator class has a method GetNextAnimal() method that returns instance of Animal.

But in fact, actual object could be any of derived animal classes.
So the signature of the method is defined. And this is what ACT generates today:

It creates shared pointer to an instance of Animal class. Just like defined in IDL file.
However, this is not what actually happens under the hood. Animal objects on library side belong to other classes.
This information just gets lost through ACT because it passes objects as a typeless handle.
IMHO, ideally, class type should be just a part of Handle type. Instead of void * it could be a struct with two fields: void* and a classId.
But in this PR for a simplicity of reviewing the idea I leave handle as void * and just add class type id.
Each class has unique Class Type Id in a form of 64 bits unsigned integer. It's generated as 64 most significant bits of SHA1 for a string NameSpace::ClassName, where NameSpace is a namespace defined in IDL file and ClassName is an actual name of a given class.
Base class has a virtual method uint64 ClassIdType(). In C++ implementation it belongs to interfaces layer and thus completely hidden from developers.
Actual name is configured in IDL by global setting classtypeidmethod. It's autogenerated by ACT and returns class type id.
On a bindings side (application) ACT implements hidden from developer PolymorphicFactory() function that is used to instantiate objects from handle. Instead of std::make_shared on C++, for example.
It serves only one goal - instantiate correct class on an application side that matches class of a handle on a library side.
C++ example:
template <class T>
std::shared_ptr<T> CWrapper::polymorphicFactory(RTTIHandle pHandle)
{
	RTTI_uint64 resultClassTypeId = 0;
	CheckError(nullptr, m_WrapperTable.m_Base_ClassTypeId(pHandle, &resultClassTypeId));
	switch(resultClassTypeId) {
		case 0x1549AD28813DAE05UL: return std::dynamic_pointer_cast<T>(std::make_shared<CBase>(this, pHandle)); break; // First 64 bits of SHA1 of a string: "RTTI::Base"
		case 0x8B40467DA6D327AFUL: return std::dynamic_pointer_cast<T>(std::make_shared<CAnimal>(this, pHandle)); break; // First 64 bits of SHA1 of a string: "RTTI::Animal"
		....
	}
	return std::make_shared<T>(this, pHandle);
}

and then used instead of std::make_shared in class method implementation for class parameters passed as out or return.
/**
* CAnimalIterator::GetNextAnimal - Return next animal
* @return
*/
PAnimal CAnimalIterator::GetNextAnimal()
{
    RTTIHandle hAnimal = nullptr;
    CheckError(m_pWrapper->m_WrapperTable.m_AnimalIterator_GetNextAnimal(m_pHandle, &hAnimal));

    if (hAnimal) {
        return m_pWrapper->polymorphicFactory<CAnimal>(hAnimal);
    } else {
        return nullptr;
    }
}

I already mentioned above that direct call to ClassTypeId() method to retrieve object class is not optimal and could be optimized.
It's better passing class type with a handle. Either as part of Handle type or by extra parameter of a C function call.
This PR includes implementation for C++, Python and Pascal bindings and C++ with Pascal Stubs.
On an application side code relies on a language native capabilities:
C++
while (auto animal = iter->GetNextAnimal()) {
	std::cout << "Animal name: " << animal->Name() << std::endl;
	if (auto tiger = std::dynamic_pointer_cast<CTiger>(animal)) {
		std::cout << "  ^ is a real tiger!!!" << std::endl;
		tiger->Roar();
	}
}

Python
while animal := iter.GetNextAnimal():
    if isinstance(animal, RTTI.Tiger):
        print("  ^ is a real tiger!!!")
        animal.Roar()
    print("Animal name: " + animal.Name())

Pascal:
Animal := Iterator.GetNextAnimal();
while Animal <> nil do
begin
    writeln('Animal name: ', Animal.Name());
    if Animal is TRTTITiger then
    begin
        writeln('  ^ is a real tiger!!!');
        Tiger := Animal as TRTTITiger;
        Tiger.Roar();
    end;
    Animal := Iterator.GetNextAnimal();
end;

NOTES and TODO:

Check functionality in case of injected components - done at https://github.com/anpilog/AutomaticComponentToolkit/pull/1
String that is used for calculating SHA1 hash should include whole hierarchy of parent classes. Theoretically, library can change data model without breaking ABI. And in this case it's safer to ignore RTTI and instantiate explicitly defined class in IDL. Looks like it's not necessary as objects are always resolved in corresponded PolymorphicFactory.

Now covered by https://github.com/Autodesk/AutomaticComponentToolkit/pull/182


Github Status Badge App

Hi!
I really wanted to be able to fetch the badge.svg from github but it appears that there is an issue with private repos where it can't be fetched. So I opted to write this using personal access tokens and GitHubs Rest API.
Here is a gif example showing the marquee and default preview for the app:

Nice! Thanks for the PR!


Should a Gateway Listener Surface Programmed=True if the Gateway Surfaces Programmed=False

Should a Gateway listener surface a Programmed: True status condition if the Gateway is surfacing Programmed: False?
$ kubectl get gateway/eg -o yaml
apiVersion: gateway.networking.k8s.io/v1beta1
kind: Gateway
metadata:
  name: eg
  namespace: default
spec:
  gatewayClassName: eg
  listeners:
  - allowedRoutes:
      namespaces:
        from: Same
    name: http
    port: 8080
    protocol: HTTP
status:
  addresses:
  - type: IPAddress
    value: <IP_ADDRESS>
  conditions:
  - lastTransitionTime: "2022-12-15T17:36:18Z"
    message: The Gateway has been scheduled by Envoy Gateway
    observedGeneration: 1
    reason: Accepted
    status: "True"
    type: Accepted
  - lastTransitionTime: "2022-12-15T17:36:18Z"
    message: Deployment replicas unavailable
    observedGeneration: 1
    reason: NoResources
    status: "False"
    type: Programmed
  listeners:
  - attachedRoutes: 1
    conditions:
    - lastTransitionTime: "2022-12-15T17:36:18Z"
      message: Listener is ready
      observedGeneration: 1
      reason: Programmed
      status: "True"
      type: Programmed
    name: http
    supportedKinds:
    - group: gateway.networking.k8s.io
      kind: HTTPRoute

cc @youngnick

I dont think there are any upstream conformance tests checking for Programmed on the top level Gateway conditions, only Listeners so worth adding some there too if we come to some conclusion


Added comments/suggestions for peer review

Great work thus far, Jenn! :)
@datalorax

Nice review, Ashley! I like your suggestion to stay consistent within the tidyverse using mutate. I generally recommend trying to stay consistent within one style as much as possible unless there's a clear reason to jump from one to another.
Rather than removing the outlier you might consider de-emphasizing and labeling it (if labeling makes sense). For example, something like this.
Nice job!


[Bugfix] Set up correct import paths for objects/IFrame.ts and IFrameProperty.js

Import paths were wrong (bad letter sizes) and the project don't want to start.

@radekaz
Show me how that bug doesn't work

Hi. Sorry for not precise information.

src/components/imagemap/properties/PropertyDefinition.js:11 - you import "IframeProperty" when the filename is: "src/components/imagemap/properties/IFrameProperty.js",
that same

After cloning and starting the repository in dev (npm run start:dev) in Ubuntu system I had an error with that import.

@radekaz
Can you captures image?

@radekaz
I check it. Change the file name IFrame -> Iframe


Feature expanding window

Reference Issues/PRs

Feature #552
What does this implement/fix? Explain your changes.
It adds a functionality crossvalidate models with an expanding window.

Does your contribution introduce a new dependency? If yes, which one?
No, it does not.

What should a reviewer concentrate their feedback on?
Still in debugging

Any other comments?

PR checklist

For all contributions

[x] I've added myself to the list of contributors.
[x] Optionally, I've updated sktime's CODEOWNERS to receive notifications about future changes to these files.
[ ] I've added unit tests and made sure they pass locally.

For new estimators

[ ] I've added the estimator to the online documentation.
[ ] I've updated the existing example notebooks or provided a new one to showcase how my estimator works.

@mloning Yes, I was thinking of doing that, I still need to check the existing unit tests which are being used on other splitters. I will be updating the PR when the unit tests are also implemented.

@mloning Yes, I was thinking of doing that, I still need to check the existing unit tests which are being used on other splitters. I will be updating the PR when the unit tests are also implemented.

Great - thanks @koralturkk!

Great - thanks @koralturkk!

Hi @mloning, I have added a notebook example and unit tests, I would appreciate if you take a look and let me know if you want to add more.

Hi @mloning, I have added a notebook example and unit tests, I would appreciate if you take a look and let me know if you want to add more.

Thanks again @koralturkk - now merging!

Thanks again @koralturkk - now merging!


Different transition for previous and next

What I want to do is have two transitions on my website. One is a slide to the left to indicate that it is the next page and one is a slide to the right indicating a previous page.
Now, my thought was to have the two transitions and then in the getTransition method check which of the two to return. However, I could not find how to detect which of the two is going on. Any ideas?

Hello @Cellcote!
Have two transitions is certainly a good approach, but depending on the final animation you want to achieve, you may consider to have just one single Transition object, and maybe change some parameters for the animation.
For example, for a left or right animation, could be just a matter of changing the destination of the tween.
In order to modify your Transition, or choose the right Transition object you may want to use Barba.Pjax.HistoryManager.
on Barba.Pjax.HistoryManager you have two useful functions:

currentStatus
prevStatus

which respectively returns information about the next/prev urls and namespaces.
(I just noticed that the generated documentation for that part, seems broken, i'll try to fix it asap.)
Try to have a look look at this demo and his source code:
http://barbajs.org/demo/nextprev/
Hope it answer to your question!

Hi !
I'm trying to have a different transition too, when the new page is the same as the previous page of the actual page.
For example :

I'm on About page
I click an item on my nav and go to Portfolio page
Back to About (previous button in my browser or on the same item in the navigation)

I'll try to use your "nextprev" demo but the this.oldContainer.dataset.prev on line 48 is undefined and I can't find it.
In fact, I want to make like your demo, but with no next/prev buttons.
Any idea to make this clean ?
Thanks for your help, and thanks for Barba!
— G

+1
Same problem here, can't figure it out :(

@kekkorider Try to have a look here: https://github.com/luruke/barba.js/issues/19#issuecomment-223874845

@lekkorider A different approach using the history API. It's a little chunky but perhaps helps.
https://gist.github.com/lukaskleinschmidt/f1c6a6bebb7bb131604f1884d4b2a6e0

@luruke unfortunately it didn't work, but @lukaskleinschmidt did! Thanks a lot mate :D