Use HTTP 200s in fee recipient API

I don't think 202 and 204 are the correct status codes to use for the fee recipient responses. These are status codes with very specific meanings in the HTTP protocol and I think our use of them is unjustified and overcomplicates things.
Regarding 202:

The HyperText Transfer Protocol (HTTP) 202 Accepted response status code indicates that the request has been accepted for processing, but the processing has not been completed; in fact, processing may not have started yet. The request might or might not eventually be acted upon, as it might be disallowed when processing actually takes place.

Emphasis added, text from https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/202
Sending a 202 "processing not completed" is inaccurate if the fee-recipient POST is actually processed synchronously, which seems like an obvious way to implement it. To require an async response when we don't do this anywhere else in the API is strange.

Regarding 204 for delete:
My argument against the 204 isn't as strong, except to say that the decision to send "no content" in response is entirely up to the API, we could just as well send a body with the message too. Sending an extra 21 bytes for {"status":"success"} is negligible from a performance and bandwidth PoV.

Closing, as @rolfyone pointed out that the validator client doesn't finish the process of setting the fee recipient until it asynchronously publishes the fee recipient to the beacon node. In this framing I think the 202 makes sense, and we may as well keep the 204 too


Adds warning for domains-move token expiration

Adds warning for domains-move token expiration
Example:
> Token Nfdjasklfsd;agd42%3D
> WARN! Your token will expire in 30 minutes

Codecov Report

Merging #1916 into canary will decrease coverage by 0.25%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           canary   #1916      +/-   ##
=========================================
- Coverage    6.62%   6.36%   -0.26%
=========================================
  Files          91      91
  Lines        4063    4056       -7
=========================================
- Hits          269     258      -11
- Misses       3794    3798       +4

Impacted Files
Coverage Δ

src/util/get-files.js
96.89% <0%> (-3.11%)
:arrow_down:

src/util/read-metadata.js
100% <0%> (ø)
:arrow_up:

src/util/get-project-name.js
100% <0%> (ø)
:arrow_up:

src/util/hash.js
100% <0%> (ø)
:arrow_up:

src/util/error.js
100% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6399253...d89a1dd. Read the comment docs.


Fixes NatNet so that it compiles.

NatNet didn't compile. This wasn't noticed because it's not in any roles.
Looks like MotionCapture.proto was changed to snake_case and no one realised it affected NatNet.
Changed frameNumber to frame_number in MotionCapture.proto since it seemed to be the only thing not snake_case in there.

@Bidski


[hyperctl / API] Add -q params to hyperctl list command

The original PR was #414 . I have lost some info during rebasing my work so I created a new PR, sorry for the inconvenience. Here are the description from old PR:
While running docker ps command, there is a params called -q, that only list container ids, without header and other information. The pure id list can be added to some other commands easily, such as docker stop $(docker ps -aq).
This PR added -q to hyperctl list command to simulate the function. With this params, hyperctl list only shows id for VM / Pod / Container. Please help to review, thanks.

Can one of the admins verify this patch?

five commits and nine changed files, it's far beyond my imagination... Does docker implement ps -q in this way?

@gnawux Just checked docker code, they only modify the output string in client side. I have made similar changes, which reverted the server / daemon side change and only modified print part of CLI side.
Please help to review. Thanks.

@hzmangel Very sorry to ask you change so much code. And may I have a last request --- could you squash the changes to a new commit? I will merge it as soon as possible (I hope it could ship with the 0.8 release targeting on Monday. And I am working on updating the docs for 0.8 as well.)

@gnawux Sure thing, I have just pushed the new squashed commit.

Thank you @hzmangel

ready to test, hykins

ok to test, hykins

retest this please, hykins


feat: set loglevel

Type of Change

New Feature to set a specific loglevel and do not log anything below that level. It also incoorperates with custom loglevels. I did not change the documentation yet since I'm awaiting your feedback on the PR. For me it is reasonable and also works nicely with custom level. So no big change. As this repo is mainly used for aws lambda setting fine granular loglevels can save lots of cloudwatch costs.
Description of Change(s)

Changed the Levels like:
this[symbols.LEVELS] = {
  off: ['log', 200],
  error: ['error', 300],
  warn: ['warn', 400],
  info: ['info', 500],
  debug: ['debug', 600],
  ...levels
};

to enable a classic loglevel setting. I removed the debug option and added the level more implicit. This works with custom level too.
Checklist

[ x] Commit messages are in proper Conventional Commits format.
[ x] Tests updated or added (if applicable).
[x] Test coverage remains at 100%.
[ x] There are no errors or warning in ESLint.
[ ] Documentation updated (if applicable).

Awesome work on this! I'm currently in the process of building version 4.0.0 of LambdaLog now to solve this issue along with a few others that have been on my backlog. In order to solve one of the other issues (typescript types), I will need to remove the custom log levels anyway.
I think this change is too big right now and should be a major version release (ex. v4.0.0) because it contains breaking changes for a feature that is widely used by others at this time. I also do not want to release back-to-back major version releases that would end up forcing people to change their code twice.
I'm going to leave this open for right now and integrate a portion of this PR into my current build. If I'm not able to get this build shipped within the next few weeks, I will merge this PR :)
Thanks again for this! I will keep you updated!


Expose resize method for regl-managed contexts

There's a resize method that gets called internally whenever the window resizes; however, it's not accessible from the consuming code.
Sometimes other factors can cause a container element to become resized, like when using a layout management library such as FlexLayout.
It would be greatly helpful if, at least for cases where regl manages the context and canvas, a resize method were exposed on the regl object (eg. as regl.forceResize), such that it's possible to manually force a resize operation when needed.

Just going to bump this because I think it's a good idea

There is a workaround described in #431


Propose adding text on behavior of return/exit and copy-out

When a control/function/action executes a return or exit statement, should the copy-out behavior of any 'out' or 'inout' direction parameters be skipped, or performed?  The sections on the 'return' and 'exit' statements do not say.  There might be somewhere else in the spec that does, but I do not recall such a mention anywhere.
This p4c issue has a sample program, and what the p4c compiler currently does when transforming it over various passes, that raised this question: https://github.com/p4lang/p4c/issues/2225

Hmm, my guess is that people would probably be quite surprised if executing a 'return' inside of a function call would skip the copy-out behavior of any 'out' or 'inout' direction parameters, given that 'return ;' is a normal expected way to return a value from inside a function body.
The answer is less clear what people expect for 'return;' executed within an action or control.

Another related question that might be worth clarifying at the same time: Is it supported to use an exit statement inside of a function body?  The latest p4c as of today gives an error that it is not supported if you attempt to define a function that contains an exit statement.

Thinking a bit more on examples today, it seems that for a top level control like ingress or egress, where architectures like both v1model and PSA, and I believe other proprietary ones, have direction out or inout parameters for various kinds of 'standard metadata' for that architecture, P4 developers expect that those copy-out actions do occur if one executes a return or exit statement inside of that ingress/egress control.  If those copy-out actions did not occur, then there would be no way to have changes to metadata to control things like the desired egress port, whether to clone/not-cone, whether to drop, etc. be visible to the architecture.

Discussed at 2020-Apr-06 P4 language design work group meeting, and this PR was merged in to resolve this issue: https://github.com/p4lang/p4-spec/pull/823#event-3207187161


tests/raftstore: implement partition function for Cluster

PTAL @BusyJay

PTAL @BusyJay @siddontang

test_transport.rs still can't pass CI, I'll put them in the next PRs


Azure Databricks integration with Redis only works with Redis Enterprise

It is not clear that Azure Databricks integration with Azure Cache for Redis will only work with Redis Enterprise and not with other SKUs.
In the notebook of how to integrate: https://docs.microsoft.com/en-us/azure/databricks/_static/notebooks/redis.html explains that it works with a package that is for Redis Enterprise only.
Please clarify in the documentation the type of Azure Cache for Redis that can be used since it is not obvious and there are several SKUs. Thanks.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5864695c-56ef-5ee6-276b-9972b9cc93b7
Version Independent ID: 6fd628b4-39a6-4423-b47b-0e8767c3ca57
Content: Redis - Azure Databricks - Workspace
Content Source: databricks/data/data-sources/redis.md
Service: azure-databricks
GitHub Login: @mssaperla
Microsoft Alias: saperla

Hi @gmndrg -
Thanks for the feedback! We have assigned the issue to the content author to further review this and update the document as appropriate.

@leifbro - Could you please review this enhancement feedback? - Thank you

Created a Jira ticket in the internal Databricks DOC project: DOC-2918

#label:"in-progress"

Thanks for your dedication to our documentation. Unfortunately, we have been unable to review your issue and apologize for the delayed response. The requested updates have not yet been made. The timeline for resolution varies based on resourcing. We've created an internal work item (DOC-3573) to incorporate your suggestions. We are closing this issue for now, but feel free to comment here as necessary.
#please-close

#please-close


Upgrade to Terraform 1.4.6

Upgrade to Terraform 1.4.6 (latest)
See OBS build
Fixes https://github.com/SUSE/spacewalk/issues/20256

You should probably update the PR. We are already at version 1.5.2 😉 https://github.com/hashicorp/terraform/blob/v1.5/CHANGELOG.md

Oh haha hard to catch up with them 😂
Last time I worked on this we had problems with Salt in the test suite so I had to leave it for the time. Now there are more pressing issues about sumaform so this is on hold for now.

Yes, this is a never ending story. On my personal machine I use the version Tumbleweed ships which is currently also 1.5.2, and I have no issues so far. But our SUMA setup is quite different. If you need help with testing this PR in the future, just ping me.

If I am not wrong, the latest version with an open source license is 1.5.7. Maybe it should be our target for this PR.
Then we could take our time to switch to openTofu 1.6.0 or upper.


Update the sign methods in iOS and android

Updates the methods to hash and uses the identity key directly to sign.

I still think this would be good to update from a clean code perspective and example to others. But it doesn't fix the underlying issue so up to you @nmalzieu if you want to merge this or not.


virtcontainers: fix unit tests

Fix unit tests according with new changes introduced recently.
Use noopAgent in unit tests to add online fake resources.
Factorize configuration and hardware support for hotplugging block
devices into a single function and use that.
fixes #192
Signed-off-by: Archana Shinde<EMAIL_ADDRESS>Signed-off-by: Julio Montes<EMAIL_ADDRESS>

lgtm

@devimc CI not passing because of CNI unit tests.

https://github.com/kata-containers/tests/pull/219 makes the CI to run the virtcontainers unit tests with root user only. But now I see a panic in the CI logs of the ubuntu 16.04 job. and an issue with the log-parser tool in the 17.10 job

For the PID log fix that was btw...

@sboeuf Can we merge this one?


Rewatch files on change event

See discussion at #1853. Somehow, at least one application (the TextMate 2 alpha) is saving files in such a way that a single change event is emitted—and then the file no longer emits events, as if it had been deleted. My hunch is that the change event is somehow shadowing a rename event.
It's unclear whose bug this really is. Maybe it's something that can be fixed in fs.watch? Or maybe TM2 is doing something it shouldn't do? But we can work around it by re-watching files on every change, just as we re-watch them on every rename. With this patch, coffee --watch treats all file events as synonymous, hopefully giving us more consistent behavior.

Uhh, not sure why all those extra commits got added to this pull req... only the last two are relevant. Sigh.

I think you got this pull request mixed up with some other changes?

It's a very small change; might be easier to do it manually on your end, Jeremy. It's just replacing
  if event is 'change'
    compile()
  else if event is 'rename'
    watcher.close()
    wait 250, ->
      compile()
      try
        watcher = fs.watch source, callback
      catch e
        watchErr e

with
  compile()
  wait 250, ->
    try
      watcher.close()
      watcher = fs.watch source, callback
    catch e
      watchErr e

Don't you need to wait before the recompile, on renames?

There's already a 25ms delay between compile being called and the fs.stat being run. That seems to be sufficient for Coda saves to work (the original motivation for adding the delay). Though that's on a fast system with an SSD and nothing else interacting with the drive.
Actually, a bigger concern is that when the fs.stat hits an ENOENT, removeSource is called; but if the file is then replaced and re-watched, the file isn't added back into sources. I'll keep working on this...

Migrated to #1964.


OSSL_CRYPTO_ALLOC attribute introduction proposal.

Giving hint to the compiler the returned pointer is not aliased
(so realloc-like api is de facto excluded).

This pull request is ready to merge

Merged, thanks for the contribution.


Support for Realtime Database query based security rules

Realtime Database now has query based security rules. This new feature allows users to write new security rules. Can Bolt support this new addition?

I'm not sure if that helps but you can already use them just fine they dont have their own bolt syntax just yet.
path /todos {
    read(){
        query.orderByChild == 'userId' && query.equalTo == auth.uid
    }
}

compiles to
"todos": {
    ".read": "query.orderByChild == 'userId' && query.equalTo == auth.uid"
 },

@0xClpz You sir are amazing!!

Looks like this works, if there are more bolt specific syntax desired, please open a new issue.


KedroContextError in jupyter notebook when using unreleased 0.18 from develop branch

Description
I am building a hook that uses after_dataset_loaded so I ran pip install ../kedro,  pointing at a locally checked out version of kedro develop branch. After running kedro new --starter pandas-iris I cannot access the context object of kedro jupyter lab.
Note: The kedro new ... command also didn't trigger the usual interactive questions. The packages was called default. Is using pip install <path_to_git_repo> potentially not working properly? If so, how would one use the latest develop branch version of kedro in a project?
Expected Result
context is available in a notebook
Actual Result
Looking at startup_error I receive
kedro.framework.context.context.KedroContextError('Expected an instance of `ConfigLoader`, got `NoneType` instead.')

Your Environment
Running
$ kedro --version
kedro, version 0.17.0

But that makes sense since the develop branch's __init__.py still states .17.0 on the current develop branch
https://github.com/quantumblacklabs/kedro/blob/develop/kedro/__init__.py
python37
MacOS BigSur

Hi @pascalwhoop,
Thanks for reaching out. We've made some changes to the interaction flow when creating a new project, but the starters haven't been released with these new changes yet. Whenever we make a change that affect the starters, we need to release Kedro first and then the starters to make it work.
This means that when you're using an unreleased version of Kedro e.g. from master or develop, you'll need to specify a commit to check out on the starter side. For this case specifically you could use kedro new --starter=pandas-iris --checkout 310f2ff15adfb95fb458738bcd56c8b022069912

cool thanks Merel for that note. Closing then


remove shape-outside

closes #8025

verified that this does in fact fix the bug. absolutely bananas.

I might investigate by hooking into the dev tools


Installed apps show up as stacks

Apps that were installed with docker app install show up both as app, and as stack;
docker app ls
INSTALLATION   APPLICATION        LAST ACTION RESULT  CREATED    MODIFIED  REFERENCE
myinstallation myotherapp (0.1.0) upgrade     success 12 minutes 8 minutes

docker stack ls
NAME                SERVICES            ORCHESTRATOR
myinstallation      1                   Swarm
mystack             1                   Swarm

Do we want stacks and apps to work in the same "namespace"? Or should we prevent users from interacting with apps through docker stack xxx commands (and vice-versa)?
I guess there's two possible angles;

apps and stacks are separate things
apps and stacks form a hierarchy; an app consists of 1 (or perhaps in future more than 1) stacks (and stacks consist of 1 or more services, volumes, etc.)

If 2., then stacks that are part of an app should likely show up under docker stack ls, but we should think how users can/are allows to interact with them.
I think in both cases, we should add additional metadata/labels to (both stacks, and) apps so that we can distinguish apps from stacks, allowing use to filter and/or provide info about the stack/app separate from the local storage in ~/.docker/apps.

Note that adding additional metadata/labels to the deployed apps would also help with https://github.com/docker/app/issues/604
Looking at the information stored (~/.docker/app/installations/37a8eec1ce19687d132fe29051dca629d164e2c4958ba141d5f4133a33f0688f/myinstallation.json)

37a8eec1ce19687d132fe29051dca629d164e2c4958ba141d5f4133a33f0688f could be stored as ID (e.g. com.docker.app.id)
myinstallation is the installation name, which is already stored as com.docker.stack.namespace, but we may want to store that as a "docker app" specific label as well (com.docker.app.name ?)

From the myinstallation.json (shown below, collapsed);

{
  "name": "myinstallation",
  "revision": "01DNS4S9HPYSTS1FCG77WVJCXT",
  "created": "2019-09-27T12:34:06.685081+02:00",
  "modified": "2019-09-27T12:38:08.950407+02:00",
  "bundle": {
    "name": "myotherapp",
    "version": "0.1.0",
    "description": "",
    "maintainers": [
      {
        "name": "sebastiaan",
        "email"<EMAIL_ADDRESS>      }
    ],
    "invocationImages": [
      {
        "imageType": "docker",
        "image": "myotherapp:0.1.0-invoc"
      }
    ],
    "images": {
      "hello": {
        "imageType": "docker",
        "image": "hashicorp/http-echo",
        "description": "hashicorp/http-echo"
      }
    },
    "actions": {
      "com.docker.app.inspect": {
        "stateless": true
      },
      "com.docker.app.render": {
        "stateless": true
      },
      "com.docker.app.status": {}
    },
    "parameters": {
      "com.docker.app.kubernetes-namespace": {
        "type": "string",
        "default": "",
        "metadata": {
          "description": "Namespace in which to deploy"
        },
        "destination": {
          "env": "DOCKER_KUBERNETES_NAMESPACE"
        },
        "apply-to": [
          "install",
          "upgrade",
          "uninstall",
          "com.docker.app.status"
        ]
      },
      "com.docker.app.orchestrator": {
        "type": "string",
        "default": "",
        "allowedValues": [
          "",
          "swarm",
          "kubernetes"
        ],
        "metadata": {
          "description": "Orchestrator on which to deploy"
        },
        "destination": {
          "env": "DOCKER_STACK_ORCHESTRATOR"
        },
        "apply-to": [
          "install",
          "upgrade",
          "uninstall",
          "com.docker.app.status"
        ]
      },
      "com.docker.app.render-format": {
        "type": "string",
        "default": "yaml",
        "allowedValues": [
          "yaml",
          "json"
        ],
        "metadata": {
          "description": "Output format for the render command"
        },
        "destination": {
          "env": "DOCKER_RENDER_FORMAT"
        },
        "apply-to": [
          "com.docker.app.render"
        ]
      },
      "com.docker.app.share-registry-creds": {
        "type": "bool",
        "default": false,
        "metadata": {
          "description": "Share registry credentials with the invocation image"
        },
        "destination": {
          "env": "DOCKER_SHARE_REGISTRY_CREDS"
        }
      },
      "hello.port": {
        "type": "string",
        "default": "8080",
        "destination": {
          "env": "docker_param1"
        }
      },
      "hello.text": {
        "type": "string",
        "default": "Hello myotherapp!",
        "destination": {
          "env": "docker_param2"
        }
      }
    },
    "credentials": {
      "com.docker.app.registry-creds": {
        "path": "/cnab/app/registry-creds.json"
      },
      "docker.context": {
        "path": "/cnab/app/context.dockercontext"
      }
    }
  },
  "result": {
    "message": "",
    "action": "upgrade",
    "status": "success"
  },
  "parameters": {
    "com.docker.app.kubernetes-namespace": "default",
    "com.docker.app.orchestrator": "",
    "com.docker.app.render-format": "yaml",
    "com.docker.app.share-registry-creds": false,
    "hello.port": "8080",
    "hello.text": "Hello myapp!"
  },
  "files": null
}

name (already mentioned above), revision, created, modified could be good candidates for labels (com.docker.app.<property>)

Possibly;

store standard parameters as labels (com.docker.app.kubernetes-namespace ?)
not sure about the custom parameters, as they may contain sensitive data. If not, they could be stored as com.docker.app.parameters.<name-of-parameter>

/cc @chris-crone @silvin-lubecki

Hm, actually, looks like the 37a8eec1ce19687d132fe29051dca629d164e2c4958ba141d5f4133a33f0688f is not an ID (or at least, the same ID is created when re-deploying the application after removing the local store); is it a hash of the name, not a UUID/random ID?

So, looks like interacting through docker stack is indeed problematic, because docker app currently relies on the local store;
$ docker stack rm myinstallation
Removing service myinstallation_hello
Removing network myinstallation_default

$ docker app ls
INSTALLATION   APPLICATION        LAST ACTION RESULT  CREATED   MODIFIED       REFERENCE
myinstallation myotherapp (0.1.0) upgrade     success 7 minutes About a minute

@thaJeztah your last result is weird, status should have failed, not being able to reach the rmed stack.

37a8eec1ce19687d132fe29051dca629d164e2c4958ba141d5f4133a33f0688f could be stored as ID (e.g. com.docker.app.id)

Actually  37a8eec1ce19687d132fe29051dca629d164e2c4958ba141d5f4133a33f0688f is the id of the installation context 😅
The installation store is split by context ids, and inside you will find all the named installations.

Ah! Gotcha 👍 Guess having a GUID stored somewhere would work for IDs

At a high level, I like the idea of 2 where an app consists of one or more stacks. But, I feel that might lead to confusion about apps vs stacks.
I think labeling app-based deployments so that existing stack/service commands can work with them would ease adoption, and make them interoperable with third-party tools like Portainer out of the box.
Perhaps a bigger gain for apps and stacks as a whole would be to create a resource type and APIs for it (as a combined entity). Right now, there is no actual stack resource in the Docker API. The concept of stacks only exist in the Docker CLI. A new resource type could hold the information that's currently being stored locally in ~/.docker/app/installations/, and finally provide an API that external tools can use.


fix: GitHub raw URL references to notebook.

Description
GitHub does not seem to honor raw URLs with a blob/ path component any more. These URLs result in a 404 response.

[x] Follow the CONTRIBUTING Guide.
[ ] You are listed as the author in your notebook or README file.

[ ] Your account is listed in CODEOWNERS for the file(s).

[x] Make your Pull Request title in the https://www.conventionalcommits.org/ specification.
[ ] Ensure the tests and linter pass (Run nox -s format from the repository root to format).
[x] Appropriate docs were updated (if necessary)

Fixes #817 🦕

Spelling errors were in the original notebook. Out of scope for the PR
"Lint Code Base" check is a false positive error matching Facebook page access token to a base64 representation of an image.


Dia.app: error “cannot open display” has returned. Regression?

General troubleshooting steps

[x] I have retried my command with --force and the issue is still present.
[x] I have checked the instructions for reporting bugs (or making requests) before opening the issue.

[ ] None of the templates was appropriate for my issue, or I’m not sure.
(The appropriate template came up by default, and I’m using it right now)

[x] I ran brew update-reset && brew update and retried my command.
[x] I ran brew doctor, fixed as many issues as possible and retried my command.
[x] I understand that if I ignore these instructions, my issue may be closed without review.

Description of issue
~#45650~ (Edit: #28511) has broken Dia for me. It aborts immediately on launch with status code 1 and the error message cannot open display:
$ /Applications/Dia.app/Contents/Resources/bin/dia
22:28: execution error: „XQuartz“ hat einen Fehler erhalten: Das Programm läuft nicht. (-600)
Warning: AppleCollationOrder setting not found, using AppleLocale.
Setting Language: de.UTF8

(dia-bin:73320): Gtk-WARNING **: cannot open display: /private/tmp/com.apple.launchd.luAbLYqYkB/org.macosforge.xquartz:0

I can’t find any explanation or reason as to why the Contents/Resources/bin/dia script would “[n]o longer [need] to export the display”. Google suggests that the issue may indeed have vanished for most people but puzzling enough, for me the app still errors out consistently.
Setting DISPLAY to :0 works around the issue as expected:
$ DISPLAY=':0' /Applications/Dia.app/Contents/Resources/bin/dia

How do we go about this? I’d be happy to maintain a private tap but I suspect other users (albeit very few) may have the same issue. Is it reasonable to re-insert the patch for everyone?
Command that failed
/Applications/Dia.app/Contents/Resources/bin/dia

Output of command with --force --verbose --debug
(does not apply)
Output of brew cask doctor
==> Homebrew-Cask Version
Homebrew-Cask 1.6.2-33-g27ec9da
caskroom/homebrew-cask (git revision 85020; last commit 2018-04-26)
==> macOS
10.12.6
==> SIP
Enabled
==> Java
10.0.1, 1.8.0_172
==> Homebrew-Cask Install Location
<NONE>
==> Homebrew-Cask Staging Location
/usr/local/Caskroom
==> Homebrew-Cask Cached Downloads
~/Library/Caches/Homebrew/Cask (48 files, 3.7GB)
==> Homebrew-Cask Taps:
/usr/local/Homebrew/Library/Taps/caskroom/homebrew-cask (3956 casks)
/usr/local/Homebrew/Library/Taps/bsiegel/homebrew-tap (1 cask)
/usr/local/Homebrew/Library/Taps/caskroom/homebrew-drivers (143 casks)
/usr/local/Homebrew/Library/Taps/caskroom/homebrew-fonts (1160 casks)
/usr/local/Homebrew/Library/Taps/caskroom/homebrew-versions (176 casks)
/usr/local/Homebrew/Library/Taps/claui/homebrew-cask-aged (9 casks)
/usr/local/Homebrew/Library/Taps/claui/homebrew-cask-games (2 casks)
/usr/local/Homebrew/Library/Taps/claui/homebrew-cask-test (3 casks)
/usr/local/Homebrew/Library/Taps/claui/homebrew-cask-unofficial (4 casks)
/usr/local/Homebrew/Library/Taps/claui/homebrew-cask-versions (3 casks)
/usr/local/Homebrew/Library/Taps/claui/homebrew-textmate (6 casks)
==> Contents of $LOAD_PATH
/usr/local/Homebrew/Library/Homebrew/cask/lib
/usr/local/Homebrew/Library/Homebrew
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.3/lib/ruby/gems/2.3.0/gems/did_you_mean-1.0.0/lib
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.3/lib/ruby/site_ruby/2.3.0
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.3/lib/ruby/site_ruby/2.3.0/x86_64-darwin9.0
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.3/lib/ruby/site_ruby/2.3.0/universal-darwin9.0
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.3/lib/ruby/site_ruby
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.3/lib/ruby/vendor_ruby/2.3.0
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.3/lib/ruby/vendor_ruby/2.3.0/x86_64-darwin9.0
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.3/lib/ruby/vendor_ruby/2.3.0/universal-darwin9.0
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.3/lib/ruby/vendor_ruby
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.3/lib/ruby/2.3.0
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.3/lib/ruby/2.3.0/x86_64-darwin9.0
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.3/lib/ruby/2.3.0/universal-darwin9.0
==> Environment Variables
LC_ALL="en_US.UTF-8"
PATH="/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/Homebrew/Library/Homebrew/shims/scm"
SHELL="/bin/bash"

Output of brew tap
bsiegel/tap
caskroom/cask
caskroom/drivers
caskroom/fonts
caskroom/versions
claui/cask-aged
claui/cask-games
claui/cask-test
claui/cask-unofficial
claui/cask-versions
claui/cleanup-bin
claui/public
claui/services-bulk
claui/tap-git
claui/textmate
claui/unofficial
ethereum/ethereum
homebrew/core
homebrew/dev-tools
homebrew/dupes
homebrew/games
homebrew/gui
homebrew/science
homebrew/services
homebrew/x11
jaybrown/cn
mistertea/et
osx-cross/avr
rosaland/rosa
vitorgalvao/tiny-scripts
watsonbox/cmu-sphinx

Edit: fixed issue reference.

Is it reasonable to re-insert the patch for everyone?

I’m fine with that.
But I’d also like for an issue to be opened with the developers about this, and a comment above the fix pointing to the online discussion.

Still trying to figure out where to file that issue. Looks like the issue is in the build process/a build artifact, which is not part of the upstream project but handled separately, and overseen by an individual maintainer, who passed away in 2014. The latest binary release for Mac predates that. It’s not clear who even has access to the Mac build scripts as of today.
Not sure who to ask about the Mac release process as it seems pretty much abandoned.


Create notebook about feature selection

🚀 Feature Request
Create notebook demonstrating our method for feature selection
Motivation
Show our feature selection methods to the users
Proposal

Create notebook with the short description and demonstration of out feature selection transforms(TreeFeatureSelectionTransform, GaleShapleyFeatureSelectionTransform, MRMRFeatureSelectionTransform)
Include also plot_feature_relevance method here

Test cases
No response
Alternatives
No response
Additional context
No response
Checklist

[ ] I discussed this issue with ETNA Team

sudo py-spy record -o speedscope.json -f speedscope python f.py --rate 50 --nonblocking

# %% [markdown]
# # Feature selection
#
# This notebook contains the simple examples of using feature extractor transforms with ETNA library.
#
# ### Navigation
#
# - [Intro](#20-intro-to-feature-selection)
# - [TreeFeatureSelectionTransform](#21-tree)
# - [GaleShapleyFeatureSelectionTransform](#21-galeshapleyfeatureselectiontransform)
# - [MRMRFeatureSelectionTransform](#22-mrmrfeatureselectiontransform)
#

# %%
import warnings

warnings.filterwarnings("ignore")

# %% [markdown]
# ## 1. Load Dataset
#
# We are going to work with the time series from Tabular Playground Series - Jan 2022. The dataset contains daily merchandise sales – mugs, hats, and stickers – at two imaginary store chains across three Scandinavian countries. As exogenous data, we will use Finland, Norway, and Sweden Weather Data 2015-2019 dataset containing daily country average precipitation, snow depth and air temperature data.

# %%
import pandas as pd
import warnings

warnings.filterwarnings("ignore")

df = pd.read_csv("examples/data/nordic_merch_sales.csv")

# %%
from etna.datasets import TSDataset

df = TSDataset.to_dataset(df)
ts = TSDataset(df, freq="D")
ts.plot(4)

# %%
HORIZON = 60

# %% [markdown]
# ## 2. Feature selection methods
#
# ### 2.0 Intro to feature selection
#
# Let's create features and build pipeline with dataset:

# %%
from etna.pipeline import Pipeline
from etna.models import CatBoostModelPerSegment
from etna.transforms import (
    DateFlagsTransform,
    MeanTransform,
    LagTransform,
    TrendTransform,
    FourierTransform,
    HolidayTransform,
)
from etna.metrics import SMAPE

transforms = [
    TrendTransform(in_column="target", out_column="trend"),
    LagTransform(in_column="target", lags=range(HORIZON, 100), out_column="target_lag"),
    DateFlagsTransform(
        day_number_in_month=True, day_number_in_week=False, is_weekend=False, out_column="datetime_flag"
    ),
    MeanTransform(in_column=f"target_lag_{HORIZON}", window=12, seasonality=7, out_column="mean_transform"),
    FourierTransform(period=250, order=6, out_column="fourier"),
    HolidayTransform(iso_code="SWE", out_column="SWE_holidays"),
    HolidayTransform(iso_code="NOR", out_column="NOR_holidays"),
    HolidayTransform(iso_code="FIN", out_column="FIN_holidays"),
]

# %% [markdown]
# With this simple transform we improved SMAPE and backtest time in more than twice.
#
# ETNA also provides methods to plot importance of each feature:

# %%
from etna.transforms import GaleShapleyFeatureSelectionTransform
from etna.analysis.feature_relevance import StatisticsRelevanceTable

rt = StatisticsRelevanceTable()
feature_selector_transform = GaleShapleyFeatureSelectionTransform(top_k=20, relevance_table=rt, return_features=True)

pipeline = Pipeline(
    model=CatBoostModelPerSegment(), transforms=transforms + [feature_selector_transform], horizon=HORIZON
)
metrics_galeshapley_feature_selector, forecast_galeshapley_feature_selector, _ = pipeline.backtest(
    ts=ts, metrics=[SMAPE()], n_folds=1
)

speedcope.json

Maybe we can pass all columns to mann whitney test.
current implementation compares features separately.

Waiting for #886.

Closed by #875.


Two deprecated error messages after trying to do simple 2 ** 3 function

Fixed as far as I can tell


Move __version__ out of the twocaptcha package

Move the __version__ variable definition outside of the twocaptcha package. When setup.py tries to import that value, it causes an import of the requests library (via the ApiClient import) in twocaptcha/__init__.py . This breaks builds because it necessitates that users install requests before twocaptcha rather than being able to install libraries all in one go (e.g. via pip install -r requirements.tx).
Suggestion: Move it to a __version__.txt file and have setup.py and twocaptcha/__init__.py read it in as a value.

This should solve #16 .

Can you guys make a pull request that properly implements the recommended approach?
Will be really appreciated.

fixed with #28 in v1.1.1 thanks to @nathanielobrown


Show admin user label in orange

From best guess.
BTW I haven't actually tested it. Here is a great post to test: https://lihkg.com/thread/16076/page/1

唔識用 github pull request [sosad]

Why would you want to remove the lang attribute?


[Fixes # 4533] Replaced cpx2 with local test module

Which problem is this PR solving?
Replaced the external dependency of cpx2 package, with a local test module (test-non-core-module) that mimics the cpx2 package. Made the required changes in RequireInTheMiddleSingleton.
Fixes #4533
Short description of the changes
Added the module test-non-core-module with package.json.
Updated RequireInTheMiddleSingleton.test.ts
Also updated package.json to remove the cpx2 dependency.
How Has This Been Tested?
npm run compile
npm test with no errors or warnings
Checklist:

[x] Followed the style guidelines of this project
[ ] Unit tests have been added
[ ] Documentation has been updated

@pichlermarc Please review the changes. TIA

@pichlermarc Changelog and unit test are failing:
For changelog I added a comment in PR specifying changelog isn't required.
Why are the Unit/ browser tests failing?
The tests and compile were running without errors on my local machine.

WRT to the changelog, usually someone with Triage permissions decides if the entry needs a changelog or not by applying the Skip Changelog label it it's not necessary. I added it just now.

@pichlermarc restored both files.
There could be couple reasons for these new dependencies. What is the most likely reason here? And as a developer how is one supposed to know that these are unnecessary changes?
Note: TY for your patience and guidance.

There could be couple reasons for these new dependencies. What is the most likely reason here? And as a developer how is one supposed to know that these are unnecessary changes?

The most likely reason the diff in https://github.com/open-telemetry/opentelemetry-js/pull/5077/files/fe6eb7917fd994c88cb4e6280dc04ef4b120b072#diff-053150b640a7ce75eff69d1a22cae7f0f94ad64ce9a855db544dda0929316519 is that you might've run something like npm install sinon and npm install require-in-the-middle at some point during the development process. This also updates the package-lock.json and introduces some problems (in this case a new major version of sinon that was not compatible with our current webpack config - breaking changes in new major versions are to be expected).

I see this message on this PR too.

A large part of our contributions never touch any dependencies so this PR was a bit of a special case. The remaining conflicts with the package-lock.json are the product of a trade-off we have to make in this repo to keep our our test workflows somewhat stable:
Transitive dependencies often change and we use a lot of tooling to test against Node.js and in a browser-like environment. We've made the experience that just pinning the devDependencies is not sufficient, as these transitive dependencies update and cause intermittent failures in CI. This was very difficult to troubleshoot for us as we didn't have a reference which transitive dependency was causing the issue.
We made the decision to also check-in a package-lock.json to avoid these transitive dependencies from updating, and we now use renovate-bot to do an update of this file on a weekly basis. With the diff in the package-lock.json maintainers can see what transitive dependencies changed and address any issues without holding back others that may be working on different things.
But adding the package-lock.json has the trade-off that there's a larger potential for merge conflicts as you see in this PR right now. When another PR that changes that file is merged, and there's another PR that modifies that file (like this one), we end up having a merge-conflict. The fix for it is relatively simple though (this is how I do it, but there are many other ways):

merging main into your branch
accepting the changes frommain for package-lock.json
running npm install --package-lock-only again, committing, and pushing the result

That will resolve the conflicts and make it so that we can merge the PR :slightly_smiling_face:

@pichlermarc Thank you for an elaborate explanation, that makes sense now.
I followed the steps you mentioned and found that actually running npm install --package-lock-only introduces require-in-the-middle and sinon dev-dependencies. I'm going to commit changes without running npm install --package-lock-only.
I assume this is not an ideal way of making changes.  :(

@pichlermarc One unit test/browser test is failing. Could you advise on potential steps for resolving this issue?

@pichlermarc running npm install --package-lock-only shows vulnerabilities in code. Can I audit fix, force fix or mannually update the versions in package.json if required?

@pichlermarc I assume this PR is ready to be merged. Can you check please? TIA!


Upload from local file

Currently giving a path. How do we upload a local file? Can a volume to mount be specified at run time? or pipe? or rely on the use to know where the mounted dirs are?

@pkerpedjiev/@ngehlenborg : I am doing this the wrong way. I'm wondering if file upload should really be something we do via http, or if it'd make more sense to do it via manage.py. For an admin activity like this, it's not unreasonable that it be done via the command line, and it would save us trouble other places, too:

Don't need to worry about ad hoc user creation
Don't need to worry about django instances that didn't get reaped
Don't need to worry about nginx timeouts
Less risk that we end up storing large files twice on disk

There might be larger issues about the story you want to tell with this software, so I won't jump into this.

I've made some progress with the approach of having a shared directory between the host and the container, but it adds a lot of superficial complexity: The user needs to keep track of the path on localhost, and in the container, and if one is confused for the other it will be hard to debug.
I wonder if we don't want to keep URLs as the way files are specified. It avoids all these problems of trying to set up a back door in the container. If someone does really want to work with local files, maybe that should be considered the weird case, and the thing to do is bring up a one-line server for the files?

Talked with Nils: Probably put this on hold and see if we can sort out the original nginx problem. If that were good, we wouldn't need any of this.

doing it via cli works.


@1aurabrown => Updates to CocoaPods 0.36 Beta 1

In the process of writing that blog post, I thought it'd be prudent to update to the new CocoaPods beta.
The project doesn't currently build – the compiler segfaults. It looks similar to the error we were getting in XCGLogger when optimizations turned on, so through some trial-and-error, I figured out that it was the Pods target itself. Disabling compiler optimization for this target fixed the segfaults – maybe something in cocoapods-keys?

[ ] Disable Pods optimizations using post-install hook
[x] Fix UIFonts pod (the resource files aren't being accessed properly, causing a runtime crash)
[x] Investigate why compiler is segfaulting on first-pass but succeeding on subsequent builds

At any rate, I think including an example of how to disable optimizations on a specific pod would be :+1: in the blog post.

also, rebase

also, rebase

I expect that this CI build will segfault. It's on my todo list in the PR description.

@mrackwitz It looks like it might be a problem with ReactiveCocoa, or possibly Moya. The first time I try and build, the compiler segfaults with "Cannot define category for undefined class 'RACSignal'":
/Users/ash/Library/Developer/Xcode/DerivedData/Kiosk-dywhoqbddoimmpfuccrbwpyyoagk/Build/Products/Debug-iphonesimulator/Pods/Moya.framework/Headers/Moya-Swift.h:72:12: error: cannot define category for undefined class 'RACSignal'
@interface RACSignal (SWIFT_EXTENSION(Moya))
           ^
/Users/ash/bin/eidolon/Pods/ReactiveCocoa/ReactiveCocoa/Objective-C/NSData+RACSupport.h:12:8: note: forward declaration of class here
@class RACSignal;
       ^
<unknown>:0: error: could not build Objective-C module 'Moya'

But subsequent builds succeed without the error. If I clean the build folder, I get the segfault again on the first build.
I'm going to look into the Moya project. It has ReactiveCocoa as a dependency, and I have ReactiveCocoa above Moya/Reactive in my podfile.

So frustrating.

Looks like Travis is getting the same errors I am: https://travis-ci.org/artsy/eidolon/builds/46053263#L780-L782 The file producing the error appears to have been created by the Swift compiler. It's almost like the @import ReactiveCocoa; isn't being included – maybe the #if defined(__has_feature) && __has_feature(modules) is failing?
@mrackwitz Is there any way to influence how this file is created?
// Generated by Swift version 1.1 (swift-6<IP_ADDRESS>)
#pragma clang diagnostic push

#if defined(__has_include) && __has_include(<swift/objc-prologue.h>)
# include <swift/objc-prologue.h>
#endif

#pragma clang diagnostic ignored "-Wauto-import"
#include <objc/NSObject.h>
#include <stdint.h>
#include <stddef.h>
#include <stdbool.h>

#if defined(__has_include) && __has_include(<uchar.h>)
# include <uchar.h>
#elif !defined(__cplusplus) || __cplusplus < 201103L
typedef uint_least16_t char16_t;
typedef uint_least32_t char32_t;
#endif

typedef struct _NSZone NSZone;

#if !defined(SWIFT_PASTE)
# define SWIFT_PASTE_HELPER(x, y) x##y
# define SWIFT_PASTE(x, y) SWIFT_PASTE_HELPER(x, y)
#endif
#if !defined(SWIFT_METATYPE)
# define SWIFT_METATYPE(X) Class
#endif

#if defined(__has_attribute) && __has_attribute(objc_runtime_name)
# define SWIFT_RUNTIME_NAME(X) __attribute__((objc_runtime_name(X)))
#else
# define SWIFT_RUNTIME_NAME(X)
#endif
#if !defined(SWIFT_CLASS_EXTRA)
# define SWIFT_CLASS_EXTRA
#endif
#if !defined(SWIFT_PROTOCOL_EXTRA)
# define SWIFT_PROTOCOL_EXTRA
#endif
#if !defined(SWIFT_CLASS)
# if defined(__has_attribute) && __has_attribute(objc_subclassing_restricted)
#  define SWIFT_CLASS(SWIFT_NAME) SWIFT_RUNTIME_NAME(SWIFT_NAME) __attribute__((objc_subclassing_restricted)) SWIFT_CLASS_EXTRA
# else
#  define SWIFT_CLASS(SWIFT_NAME) SWIFT_RUNTIME_NAME(SWIFT_NAME) SWIFT_CLASS_EXTRA
# endif
#endif

#if !defined(SWIFT_PROTOCOL)
# define SWIFT_PROTOCOL(SWIFT_NAME) SWIFT_RUNTIME_NAME(SWIFT_NAME) SWIFT_PROTOCOL_EXTRA
#endif

#if !defined(SWIFT_EXTENSION)
# define SWIFT_EXTENSION(M) SWIFT_PASTE(M##_Swift_, __LINE__)
#endif

#if !defined(OBJC_DESIGNATED_INITIALIZER)
# if defined(__has_attribute) && __has_attribute(objc_designated_initializer)
#  define OBJC_DESIGNATED_INITIALIZER __attribute__((objc_designated_initializer))
# else
#  define OBJC_DESIGNATED_INITIALIZER
# endif
#endif
#if defined(__has_feature) && __has_feature(modules)
@import ReactiveCocoa;
#endif

#pragma clang diagnostic ignored "-Wproperty-attribute-mismatch"
#pragma clang diagnostic ignored "-Wduplicate-method-arg"

@interface RACSignal (SWIFT_EXTENSION(Moya))
- (RACSignal *)filterStatusCode:(NSInteger)code;
- (RACSignal *)filterSuccessfulStatusCodes;

/// Maps data received from the signal into a UIImage. If the conversion fails, the signal errors.
- (RACSignal *)mapImage;

/// Maps data received from the signal into a JSON object. If the conversion fails, the signal errors.
- (RACSignal *)mapJSON;

/// Maps data received from the signal into a String. If the conversion fails, the signal errors.
- (RACSignal *)mapString;
@end

#pragma clang diagnostic pop

From what I understand, import ReactiveCocoa in the Moya files should give me access to all of ReactiveCocoa's classes (I've double-checked that ReactiveCocoa's umbrella header contains all of the header files). If I navigate to the Moya import statement, I see the following error:
Cannot load underlying module for 'ReactiveCocoa'

Also strange that the compiler error is "could not build Objective-C module 'Moya'".

Couldn't figure out why this was segfaulting. I tried to reproduce the issue in a new project and couldn't, so I just recreated the Kiosk Xcode project from scratch. Shouldn't be any problems, eh @orta?
OK, so the tests are now failing, not erroring, which is definitely a :+1: And they're only failing because of some weird Travis issue:

2015-01-06 17:43:08.632 xcodebuild[23326:4503]  iPhoneSimulator: Timed out waiting 120 seconds for simulator to boot, current state is 1.

Looking into that now.

Since @orta is mostly unavailable this week, I'm going to reassign this to @1aurabrown – feel free to merge when you think it's good to go.

This looks good from my side, merggggging


0.4 release candidate 3

hard limit of number of variants per lineage of 20K, to reduce computing time and avoid out-of-memory crashes
restored scrollbar for beadplots to deal with massive lineages
save beadplot as SVG
merge search-interface branch
beadplot loading visual feedback

Running a test job on the cluster with dev branch right now (commit ee4e352)

🏄 [1 day, 4:16:33.811121] All done!

Found a bug, need help @GopiGugan @horaciobam.
To repro:

Select a relatively small beadplot.
Export the SVG.
Switch to a larger beadplot (more variants).
New SVG is now truncated to vertical extent of previous beadplot.

Beadplot SVG on load, select small cluster:

Export SVG:

Switch to longer beadplot:

Can we wipe the style of the SVG when switching between beadplots?

Nice catch. Yes, the latest commit removes the attributes once the SVG has been exported


Support for Service Authorizations

When a user has the "engineer" level, specific access to specific
services can be granted using service authorizations.
This change adds support for creating, retrieving, updating and deleting
service authorizations using the Go client.

I have now addressed all your comments

🙌


globalPos() const' is marked as deprecated

Hi
When moving the window I get an

......./main.py:188: DeprecationWarning: Function: 'globalPos() const' is marked as deprecated, please check the documentation for more information.
self.drag_position = event.globalPos()

error.
Just for info
python 3.9
PySide 6.2.0
OSX Big Sur

you can use the    event.globalPosition().toPoint() to replace the code, these can find from
https://doc.qt.io/qtforpython-6/PySide6/QtGui/QMouseEvent.html?highlight=globalpos#PySide6.QtGui.PySide6.QtGui.QMouseEvent.globalPos
good luck

Hi
Thanks for the info.
I eliminated this part already out of my fork.


HTTP Driver should use eager by default

@Cmdv
Related: https://github.com/cyclejs/core/issues/238

Is this done in the diversity branch?

I've still not done it full stop but I can look into it later @TylorS

It's done in Diversity branch


fix: Close #189556, gulp task do not display task name

After add Task Name

The git repo is not clean after compiling the /build/ folder. Did you forget to commit .js output for .ts files?

the above error is present

it's still failing. @alexr00 looks like @alexdima added this code originally, so maybe he should have a look, though it's been awhile

The git repo is not clean after compiling the /build/ folder. Did you forget to commit .js output for .ts files?

The git repo is not clean after compiling the /build/ folder. Did you forget to commit .js output for .ts files?

Sorry, Let me confirm. You mean this file should not be submitted, right? Because it is compiled.

I think the previous submissions seem to have submitted the compiled products. However, it's okay. If the repo is kept clean, it really cannot be submitted.

maybe try removing this file from the changes?
build/lib/compilation.js

Okay, I 've already done that

Thanks for your work @yiliang114 !


Make generator create a .showcased_test file instead of _test.showcased

Because the generator was creating a file with the name _test.showcased, when trying to run flutter test for the generated files, the run fails to find any tests as the command searches for files which filename ends in test.
This PR changes the name of the generated files to .shocased_test so the flutter test command runs accordingly.

Nice, thanks!


Add selection of primary interface on Failover LAGG

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[x ] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[x ] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Is your feature request related to a problem? Please describe.
When trying to setup a LAGG interface of type 'Failover', I am missing the possibility to select the primary interface. Currently it takes whatever is first in the list of selected interfaces. This is needed when one wants to select interfaces of different speeds (i.e. 10Gbe & 1Gbe)
Describe the solution you like
Add a dropdown box to select the primary interface.
Additional context
I am using OPNsense 3.7.12_5.

failover mode is not very popular for lagg interfaces, although not very specifically stated in the documentation, order should prioritize in this case. Since we remove all interfaces before configure, it shouldn't be a huge issue to change something in the ordering.
https://github.com/opnsense/core/blob/4b1bc0c0f37ba58535b0ac2261dc6c741a0f90b8/src/etc/inc/interfaces.inc#L420-L424
I'll put it on the list, no promises.


fix(comments): rephrasing comment. Structuring into block

SUMMARY
Cleaning up comment for cleaner flow, and structured into block

closing/reopening to get CI in gear.

Sorry this slid under the radar for so egregiously long. Hoping we can get it through finally 🤞


Open Folder with preserve window option makes terminals stick to old path

Bug Description:
While preserve window option is true, opening a folder makes the terminals stick to old path.
Steps to Reproduce:
1.Open a folder
2.Open a terminal
3.Open different folder
4.See terminal is pointing old folder path.
https://user-images.githubusercontent.com/15328038/168532818-1f6c3fdf-1184-4444-a28b-1c4d985b224c.mp4

Operating System:
Win11 21H2
Theia Version:
Eclipse Theia Blueprint
Version 1.25.0 (Beta)
VS Code API Version: 1.53.2

Thank you for the report, I can reproduce it on Linux as well. We will have a look
One addition to the Steps to Reproduce: When opening a folder the window layout for this folder is restored. In order to reproduce the issue, the folder we are switching to, should have had a terminal open before.

The latest version of blueprint contains the upstream theia fix for this issue.
Please reopen if this is still reproducible with the latest version.


Add full API model support to create, update, delete by file

e2e is failing on unrelated issue, I will try to track it down and apply some fix. this change can go through.


create a flow diagram and description of the process of name alignment

to help document the process of name alignment

@jtmiller28 - today in a conversation with bat biologist Aja Sherman @ajacsherman a desire for a flow diagram came to the surface again. I was thinking to create, and then also remembered https://github.com/Big-Bee-Network/name-alignment-workshop/issues/9, and I was wondering whether I can re-use your flow diagram. If not, I can create one and share with you instead.

Hi Jorrit, Thats right! I had momentarily forgotten about that. I will try to create one and post it on this issue to see if you have any suggestions/ideas to add.

Hi Jorrit,

Commit alignment refers to the commiting step in regards to editing the readme to initiate alignment. I initially thought it'd be a good way to integrate some of the unfriendly github language into the diagram to make better sense in what is happening/the process. But if it causes more confusion, I can change it to saving alignment configuration and proceed to start alignment.

Not sure! Color coding with a legend might be an option, say yellow for user inputs, grey for intermediates, and light blue for outputs? Was already "testing" that route with Yellow/Orange indicating user data/steps that the user should take. Any other suggestions in regards to this?

@jtmiller28 thanks for your prompt reply.
re: 1. I leave this up to you! Maybe you can ask some of your peers to what communicates most information
re: 2. some diagrams use different shapes for different kind of things. Perhaps UML will inspire . . . https://en.wikipedia.org/wiki/Activity_diagram . I leave the final decision up to you and what makes most sense to you and your peers.

Well now thats interesting, I was not aware of UML (My flow diagrams come from ecological modeling theory rather than CS). Ill try it out and see!

Whatever is more intuitive to you. UML can be kind of clunky.

Second rough draft utilizing some UML:

Agreed its a tad clunky, but I always enjoy trying to find different ways to break down and visualize systems. Maybe a bit intuitive with the legend added?

btw - I liked your explicit reference to default catalogs. Perhaps do the same with names? We do have a default name list.

I think I enjoy the logic of these types of diagrams, though trying to keep in mind that simplest explanation of whats going on is probably for the best. For now I'll go with these unless there's pushback about how approachable they are.
Forgot about the default name list! Changes should be reflected in this new diagram.

Fancy! Thanks for updating the diagram. Curious to see what will make it into the workshop publication.


Use register assumptions to mark certain code regions as unreachable

When analyzing binaries that use opaque predicates to obfuscate the control flow, it would be very useful if Ghidra's builtin register assumptions could be used to mark certain blocks as unreachable.
For example, I have created a little program which contains a very simple opaque predicate. The following screenshot depicts me trying to use register assumptions to eliminate the unreachable branch, without success:

It would be very nice if the first branch of the if-statement in this example would be completely eliminated by either of the register assumptions I attempted to use (i.e. the one for EAX and the one for ZF).

At the moment, register assumptions are only sent to the decompiler if they are defined at the entry point of a function.
You can deal with opaque predicates in two ways:

By using the instruction patcher to change the conditional jump to an unconditional jump.
By defining a special reference (of type JUMP_OVERRIDE_UNCONDITIONAL) on the conditional jump.  This will essentially change the conditional jump to an unconditional jump before decompilation.  The reference must be declared primary for the override to take effect.

There's an example in the "Advanced" Ghidra class: see the "Control Flow Oddities" subsection of improvingDisassemblyAndDecompilation.pdf.
Note that the overriding references are new to Ghidra 9.1.

Thank you very much! I was unfamiliar with JUMP_OVERRIDE_UNCONDITIONAL; and it works like a charm!

Although I don't think I know an example that isn't theoretically covered by the options that were already mentioned, I still think it would be a useful feature if register assumptions at any point in the code would influence the decompiled code. At least for me, this would be an incredibly versatile and useful tool. That said, I can very well understand if this request is rejected given that there are other ways to go about it.


[5.1] IRGen: Backward-deploy associated types on opaque types using open-coded accessors

Explanation: The Swift 5.1 compiler mangled associated types of opaque types in a form that can't be reliably demangled, and the Swift 5.1 runtime can't demangle the new mangling defined for them in #27014. If we mangled an opaque associated type while targeting an older OS, we can use a \9
accessor reference string to instantiate the associated type.
Scope: Runtime crash due to unsupported mangling. Fix is entirely compiler-side.
Issue: rdar://problem/54084733
Testing: Swift CI
Risk: Low. The new code should only affect code that would have crashed in Swift 5.1.
Reviewed by: TBD

@swift-ci Please test

Build failed
Swift Test Linux Platform
Git Sha - 9b04349c1c284b5cd82c19b645dd7c444e3a2599

@swift-ci Please test

Build failed
Swift Test OS X Platform
Git Sha - 9b04349c1c284b5cd82c19b645dd7c444e3a2599

Build failed
Swift Test Linux Platform
Git Sha - 9b04349c1c284b5cd82c19b645dd7c444e3a2599

@swift-ci Please test Linux

@swift-ci Please nominate


[Feature]-[6000]:CMD+Click to access APIs/Entities/queries

Summary

Allow users to cmd+click in the property pane to access the APIs or entities

@areyabhishek would you please help with more information about this idea? What is the problem that we are trying to solve?

@rohan-arthur this helps users navigate to an entity the way they do in code by cmd + clicking the class / variable name

Stats

Stat
Values

Reach
12000

Effort (months)
1

Handled by #15652


[Support] tls-crypt unwrap error: bad packet ID (may be a replay)

In raising this issue, I confirm the following:
{please fill the checkboxes, e.g: [X]}

[X] I have read and understood the contributors guide.
[X] The issue I am reporting can be replicated.
[X] The issue I am reporting can be is directly related to the pivpn installer script.
[X] The issue I am reporting isn't a duplicate (see FAQs, closed issues, and open issues).

Upon attempting to connect to openvpn after installing using pivpn, I get the following error:
Aug 17 23:38:45 omv ovpn-server[1016]: REDACTED:1028 TLS: Initial packet from [AF_INET]REDACTED:1028, sid=07e232f8 735e23e4
Aug 17 23:38:46 omv ovpn-server[1016]: REDACTED:1028 tls-crypt unwrap error: bad packet ID (may be a replay): [ #1 / time =<PHONE_NUMBER>) Mon Aug 17 23:38:44 2020 ] -- see the man page entry for --no-replay and --replay-window for more info or silence this warning with --mute-replay-warnings
Aug 17 23:38:46 omv ovpn-server[1016]: REDACTED:1028 tls-crypt unwrap error: packet replay
Aug 17 23:38:46 omv ovpn-server[1016]: REDACTED:1028 TLS Error: tls-crypt unwrapping failed from [AF_INET]REDACTED:1028
Aug 17 23:38:47 omv ovpn-server[1016]: REDACTED:1028 tls-crypt unwrap error: bad packet ID (may be a replay): [ #1 / time =<PHONE_NUMBER>) Mon Aug 17 23:38:44 2020 ] -- see the man page entry for --no-replay and --replay-window for more info or silence this warning with --mute-replay-warnings
Aug 17 23:38:47 omv ovpn-server[1016]: REDACTED:1028 tls-crypt unwrap error: packet replay
Aug 17 23:38:47 omv ovpn-server[1016]: REDACTED:1028 TLS Error: tls-crypt unwrapping failed from [AF_INET]REDACTED:1028
Aug 17 23:38:48 omv ovpn-server[1016]: REDACTED:1028 tls-crypt unwrap error: bad packet ID (may be a replay): [ #1 / time =<PHONE_NUMBER>) Mon Aug 17 23:38:44 2020 ] -- see the man page entry for --no-replay and --replay-window for more info or silence this warning with --mute-replay-warnings
Aug 17 23:38:48 omv ovpn-server[1016]: REDACTED:1028 tls-crypt unwrap error: packet replay
Aug 17 23:38:48 omv ovpn-server[1016]: REDACTED:1028 TLS Error: tls-crypt unwrapping failed from [AF_INET]REDACTED:1028
Aug 17 23:39:15 omv ovpn-server[1016]: REDACTED:1025 TLS Error: TLS key negotiation failed to occur within 60 seconds (check your network connectivity)
Aug 17 23:39:15 omv ovpn-server[1016]: REDACTED:1025 TLS Error: TLS handshake failed
Aug 17 23:39:15 omv ovpn-server[1016]: REDACTED:1025 SIGUSR1[soft,tls-error] received, client-instance restarting
Aug 17 23:39:24 omv ovpn-server[1016]: REDACTED:1024 TLS: Initial packet from [AF_INET]REDACTED:1024, sid=5dacab12 3b4909aa
Aug 17 23:39:25 omv ovpn-server[1016]: REDACTED:1026 TLS Error: TLS key negotiation failed to occur within 60 seconds (check your network connectivity)
Aug 17 23:39:25 omv ovpn-server[1016]: REDACTED:1026 TLS Error: TLS handshake failed
Aug 17 23:39:25 omv ovpn-server[1016]: REDACTED:1026 SIGUSR1[soft,tls-error] received, client-instance restarting
Aug 17 23:39:35 omv ovpn-server[1016]: REDACTED:1027 TLS Error: TLS key negotiation failed to occur within 60 seconds (check your network connectivity)
Aug 17 23:39:35 omv ovpn-server[1016]: REDACTED:1027 TLS Error: TLS handshake failed
Aug 17 23:39:35 omv ovpn-server[1016]: REDACTED:1027 SIGUSR1[soft,tls-error] received, client-instance restarting
=============================================
::::		Debug complete		 ::::
:::
::: Debug output completed above.
::: Copy saved to /tmp/debug.txt

Have you searched for similar issues and solutions?
Yes

Console output of      pivpn debug
::: Generating Debug Output
::::		PiVPN debug		 ::::
=============================================
::::		Latest commit		 ::::
commit 32bd1c628af9e1926f3f4471c0bf49c74deff7c7
Author: Orazio<EMAIL_ADDRESS>Date:   Fri Jul 24 18:52:57 2020 +0200

    Update LatestUpdate.md
=============================================
::::	    Installation settings    	 ::::
PLAT=Raspbian
OSCN=buster
USING_UFW=0
IPv4dev=enxb827eb4ad778
IPv4addr=<IP_ADDRESS>/24
IPv4gw=<IP_ADDRESS>
install_user=pi
install_home=/home/pi
VPN=openvpn
pivpnPROTO=udp
pivpnPORT=1194
pivpnDNS1=<IP_ADDRESS>
pivpnDNS2=<IP_ADDRESS>
pivpnSEARCHDOMAIN=
pivpnHOST=REDACTED
TWO_POINT_FOUR=1
pivpnENCRYPT=256
USE_PREDEFINED_DH_PARAM=
INPUT_CHAIN_EDITED=0
FORWARD_CHAIN_EDITED=1
pivpnDEV=tun0
pivpnNET=<IP_ADDRESS>
subnetClass=24
UNATTUPG=1
INSTALLED_PACKAGES=()
HELP_SHOWN=1
=============================================
::::  Server configuration shown below   ::::
dev tun
proto udp
port 1194
ca /etc/openvpn/easy-rsa/pki/ca.crt
cert /etc/openvpn/easy-rsa/pki/issued/omv_7785372f-4d3c-43cc-81cd-0730a0119963.crt
key /etc/openvpn/easy-rsa/pki/private/omv_7785372f-4d3c-43cc-81cd-0730a0119963.key
dh none
ecdh-curve prime256v1
topology subnet
server <IP_ADDRESS> <IP_ADDRESS>
# Set your primary domain name server address for clients
push "dhcp-option DNS <IP_ADDRESS>"
push "dhcp-option DNS <IP_ADDRESS>"
# Prevent DNS leaks on Windows
push "block-outside-dns"
# Override the Client default gateway by using <IP_ADDRESS>/1 and
# <IP_ADDRESS>/1 rather than <IP_ADDRESS>/0. This has the benefit of
# overriding but not wiping out the original default gateway.
push "redirect-gateway def1"
client-to-client
client-config-dir /etc/openvpn/ccd
keepalive 15 120
remote-cert-tls client
tls-version-min 1.2
tls-crypt /etc/openvpn/easy-rsa/pki/ta.key
cipher AES-256-CBC
auth SHA256
user openvpn
group openvpn
persist-key
persist-tun
crl-verify /etc/openvpn/crl.pem
status /var/log/openvpn-status.log 20
status-version 3
syslog
verb 3
#DuplicateCNs allow access control on a less-granular, per user basis.
#Remove # if you will manage access by user instead of device.
#duplicate-cn
# Generated for use by PiVPN.io
=============================================
::::  Client template file shown below   ::::
client
dev tun
proto udp
remote REDACTED 1194
resolv-retry infinite
nobind
remote-cert-tls server
tls-version-min 1.2
verify-x509-name omv_7785372f-4d3c-43cc-81cd-0730a0119963 name
cipher AES-256-CBC
auth SHA256
auth-nocache
verb 3
=============================================
:::: 	Recursive list of files in	 ::::
::: /etc/openvpn/easy-rsa/pki shows below :::
/etc/openvpn/easy-rsa/pki/:
Default.txt
ca.crt
crl.pem
ecparams
index.txt
index.txt.attr
index.txt.attr.old
index.txt.old
issued
james.ovpn
openssl-easyrsa.cnf
private
renewed
revoked
safessl-easyrsa.cnf
serial
serial.old
ta.key

/etc/openvpn/easy-rsa/pki/ecparams:
prime256v1.pem

/etc/openvpn/easy-rsa/pki/issued:
james.crt
omv_7785372f-4d3c-43cc-81cd-0730a0119963.crt

/etc/openvpn/easy-rsa/pki/private:
ca.key
james.key
omv_7785372f-4d3c-43cc-81cd-0730a0119963.key

/etc/openvpn/easy-rsa/pki/renewed:
private_by_serial
reqs_by_serial

/etc/openvpn/easy-rsa/pki/renewed/private_by_serial:

/etc/openvpn/easy-rsa/pki/renewed/reqs_by_serial:

/etc/openvpn/easy-rsa/pki/revoked:
private_by_serial
reqs_by_serial

/etc/openvpn/easy-rsa/pki/revoked/private_by_serial:

/etc/openvpn/easy-rsa/pki/revoked/reqs_by_serial:
=============================================
::::		Self check		 ::::
:: [OK] IP forwarding is enabled
:: [OK] Iptables MASQUERADE rule set
:: [OK] Iptables FORWARD rule set
:: [OK] OpenVPN is running
:: [OK] OpenVPN is enabled (it will automatically start on reboot)
:: [OK] OpenVPN is listening on port 1194/udp
=============================================
:::: Having trouble connecting? Take a look at the FAQ:
:::: https://github.com/pivpn/pivpn/wiki/FAQ
=============================================
::::      Snippet of the server log      ::::
Aug 17 23:50:12 omv ovpn-server[5616]: Initialization Sequence Completed
Aug 17 23:51:54 omv ovpn-server[5616]: REDACTED:1024 TLS: Initial packet from [AF_INET]REDACTED:1024, sid=1932e07e 1bb6e9b4
Aug 17 23:51:55 omv ovpn-server[5616]: REDACTED:1024 tls-crypt unwrap error: bad packet ID (may be a replay): [ #1 / time =<PHONE_NUMBER>) Mon Aug 17 23:51:53 2020 ] -- see the man page entry for --no-replay and --replay-window for more info or silence this warning with --mute-replay-warnings
Aug 17 23:51:55 omv ovpn-server[5616]: REDACTED:1024 tls-crypt unwrap error: packet replay
Aug 17 23:51:55 omv ovpn-server[5616]: REDACTED:1024 TLS Error: tls-crypt unwrapping failed from [AF_INET]REDACTED:1024
Aug 17 23:51:56 omv ovpn-server[5616]: REDACTED:1024 tls-crypt unwrap error: bad packet ID (may be a replay): [ #1 / time =<PHONE_NUMBER>) Mon Aug 17 23:51:53 2020 ] -- see the man page entry for --no-replay and --replay-window for more info or silence this warning with --mute-replay-warnings
Aug 17 23:51:56 omv ovpn-server[5616]: REDACTED:1024 tls-crypt unwrap error: packet replay
Aug 17 23:51:56 omv ovpn-server[5616]: REDACTED:1024 TLS Error: tls-crypt unwrapping failed from [AF_INET]REDACTED:1024
Aug 17 23:51:57 omv ovpn-server[5616]: REDACTED:1024 tls-crypt unwrap error: bad packet ID (may be a replay): [ #1 / time =<PHONE_NUMBER>) Mon Aug 17 23:51:53 2020 ] -- see the man page entry for --no-replay and --replay-window for more info or silence this warning with --mute-replay-warnings
Aug 17 23:51:57 omv ovpn-server[5616]: REDACTED:1024 tls-crypt unwrap error: packet replay
Aug 17 23:51:57 omv ovpn-server[5616]: REDACTED:1024 TLS Error: tls-crypt unwrapping failed from [AF_INET]REDACTED:1024
Aug 17 23:51:58 omv ovpn-server[5616]: REDACTED:1024 tls-crypt unwrap error: bad packet ID (may be a replay): [ #1 / time =<PHONE_NUMBER>) Mon Aug 17 23:51:53 2020 ] -- see the man page entry for --no-replay and --replay-window for more info or silence this warning with --mute-replay-warnings
Aug 17 23:51:58 omv ovpn-server[5616]: REDACTED:1024 tls-crypt unwrap error: packet replay
Aug 17 23:51:58 omv ovpn-server[5616]: REDACTED:1024 TLS Error: tls-crypt unwrapping failed from [AF_INET]REDACTED:1024
Aug 17 23:51:59 omv ovpn-server[5616]: REDACTED:1024 tls-crypt unwrap error: bad packet ID (may be a replay): [ #1 / time =<PHONE_NUMBER>) Mon Aug 17 23:51:53 2020 ] -- see the man page entry for --no-replay and --replay-window for more info or silence this warning with --mute-replay-warnings
Aug 17 23:51:59 omv ovpn-server[5616]: REDACTED:1024 tls-crypt unwrap error: packet replay
Aug 17 23:51:59 omv ovpn-server[5616]: REDACTED:1024 TLS Error: tls-crypt unwrapping failed from [AF_INET]REDACTED:1024
Aug 17 23:52:00 omv ovpn-server[5616]: REDACTED:1024 tls-crypt unwrap error: bad packet ID (may be a replay): [ #1 / time =<PHONE_NUMBER>) Mon Aug 17 23:51:53 2020 ] -- see the man page entry for --no-replay and --replay-window for more info or silence this warning with --mute-replay-warnings
Aug 17 23:52:00 omv ovpn-server[5616]: REDACTED:1024 tls-crypt unwrap error: packet replay
Aug 17 23:52:00 omv ovpn-server[5616]: REDACTED:1024 TLS Error: tls-crypt unwrapping failed from [AF_INET]REDACTED:1024
=============================================
::::		Debug complete		 ::::
:::
::: Debug output completed above.
::: Copy saved to /tmp/debug.txt

Have you taken any steps towards solving your issue?
Tried reinstalling multiple times but get the same error

This error usually if related to bad connectivity, what network are you trying to connect from? Can you try from a different network (wifi, cellular, public wifi)?

I've tried from cellular connection and get the same error. The error above is when I was using wifi.

Try reinstalling and selecting TCP. Remember to port forward TCP port this time.

No replies in a while, closing...


Ball own line out of play test

This PR is aimed to test the AutoRef's behavior when the ball leaves the field from the own goal line. It relates to issue #19 .

This is the actual log of running this scenario:
[0000.001|0000.000] Error: Host is not correctly defined in game.json file, it should be <IP_ADDRESS> instead of <IP_ADDRESS>.
[0000.003|0000.000] Info: Real time factor is set to 0. Simulation will run as fast as possible, real time waiting times will be minimised.
[0001.094|0000.000] Info: Spawned RED_PLAYER_1 RobocupRobot on port 10001 at halfTimeStartingPose: translation (-3.5 -3.06 0.24), rotation (0 0 1 1.57).
[0001.680|0000.000] Info: Spawned BLUE_PLAYER_1 RobocupRobot on port 10021 at halfTimeStartingPose: translation (3.5 -3.06 0.24), rotation (0 0 1 1.571592653589793).
[0001.684|0000.000] Info: Connected to GameControllerSimulator at localhost:8750.
[0001.684|0000.000] Info: Game type is NORMAL.
[0001.684|0000.000] Info: Red team is Funny Dingos.
[0001.684|0000.000] Info: Blue team is Agile Lynxes.
[0001.684|0000.000] Info: Left side is red.
[0001.684|0000.000] Info: Kickoff is blue.
[0001.684|0000.000] Info: Beginning of first half.
[0001.684|0000.000] Info: Sending 1:SIDE_LEFT:1 to GameController.
[0001.684|0000.000] Info: Sending 2:KICKOFF:2 to GameController.
[0002.159|0000.432] Info: New state received from GameController: STATE_INITIAL.
[0003.134|0010.024] Info: Sending 1257:STATE:READY to GameController.
[0003.662|0015.696] Info: New state received from GameController: STATE_READY.
[0008.671|0063.376] Info: New state received from GameController: STATE_SET.
[0008.672|0063.376] Info: Sending 7927:PENALTY:1:1:INCAPABLE to GameController.
[0008.675|0063.376] Info: INCAPABLE penalty for red player 1: did not move to kickoff position. Sent to translation (-3 3.11 0.24), rotation (0.0 0.0 1.0 4.711592653589793).
[0008.675|0063.376] Info: Sending 7928:PENALTY:2:1:INCAPABLE to GameController.
[0008.677|0063.376] Info: INCAPABLE penalty for blue player 1: did not move to kickoff position. Sent to translation (3 3.11 0.24), rotation (0.0 0.0 1.0 4.713185307179587).
[0011.155|0068.368] Info: Sending 8553:STATE:PLAY to GameController.
[0011.677|0074.384] Info: New state received from GameController: STATE_PLAYING.
[0012.683|0083.248] Info: Ball in play.
[0052.804|0088.016] Info: Ball touched by red player 1.
[0109.427|0092.968] Info: Ball left the field at (-4.571663847965667 -2.000242930610987 0.07843799905340398) after being touched by red player 1.
[0109.427|0092.968] Info: Sending 11629:CORNERKICK:2 to GameController.
[0109.427|0092.968] Info: Corner kick awarded to red team.
[0110.335|0093.808] Info: awarding a corner kick.
[0110.836|0094.296] Info: awarding a corner kick.
[0111.342|0094.784] Info: awarding a corner kick.
[0111.514|0094.960] Info: Ball respawned at -4.475 -2.975 0.07843799905340398.
[0111.514|0094.960] Info: Sending 11879:CORNERKICK:2:READY to GameController.
[0111.837|0095.264] Info: awarding a corner kick.


Better ISSUE and PR templates

We can now have better ISSUE and PR templates on GitHub, please see for example it here:
https://github.com/doctrine/doctrine2/issues/new/choose
I think it would be nice to update it also in ZF org :) Thoughts? Suggestions?

Questions:

Who can create these templates? (the template creator is only available in the settings)
Is there an API endpoint for this?

@froschdesign Hm... It looks like these are just normal files in the repository:
https://github.com/doctrine/doctrine2/tree/master/.github
So I guess, we would need first templates created here, approved here - in that repo and then we can spread it to all repos :)

@webimpress
I read this in the help section but did not find the folder. 🤦♂

in that repo and then we can spread it to all repos.

via API!

via API!

Of course, I can't imagine do it manually for all repos :) I've done it already couple times so it's not a problem at all. We just need approved templates


Getting weird coverage reports

So I am trying to use this to do coverage reports on my es6 code with babel however I am getting weird results.  For example, I see this in the html output of:

Line 1 is weird as it is expecting to test a if / else / else statement when there is none.  Lines 4 and 5 are weird as I don't know what it is talking about as I do render an Application component in my tests.  The command I am using to run my tests is:
./node_modules/.bin/babel-node ./node_modules/.bin/babel-istanbul cover ./node_modules/.bin/_mocha

and my mocha.opts file is:
--compilers js:./test/compiler.js
--reporter spec
--timeout 4000
--require test/mocha-generator.js
--require test/setup.js

test/specs/**/*.spec.jsx

Am I missing something are are there false failure showing up?

If you dig into the code generated by babel at the import * as React from 'React'; line, you'll find the mystery branches live in that code. I'm not sure why your coverage report is not ignoring the code generated by babel. What version of babel are you using? I'll investigate further, but I think there are a few possible problems:

Your project's version of babel could be generating very different code than the version used by babel-istanbul. This package is currently using 6.3.x, so I might need to update it to be any version of 6+.
Something weird could be happening in your compilers.js mocha-generator.js, or setup.js files.

So the generated code looks like this in case it is useful to you (with 6.5.x version of babel):
'use strict';var _createClass = function () {function defineProperties(target, props) {for (var i = 0; i < props.length; i++) {var descriptor = props[i];descriptor.enumerable = descriptor.enumerable || false;descriptor.configurable = true;if ("value" in descriptor) descriptor.writable = true;Object.defineProperty(target, descriptor.key, descriptor);}}return function (Constructor, protoProps, staticProps) {if (protoProps) defineProperties(Constructor.prototype, protoProps);if (staticProps) defineProperties(Constructor, staticProps);return Constructor;};}();var _react = __webpack_require__(153);var React = _interopRequireWildcard(_react);var _headerComponent = __webpack_require__(254);var _headerComponent2 = _interopRequireDefault(_headerComponent);function _interopRequireDefault(obj) {return obj && obj.__esModule ? obj : { default: obj };}function _interopRequireWildcard(obj) {if (obj && obj.__esModule) {return obj;} else {var newObj = {};if (obj != null) {for (var key in obj) {if (Object.prototype.hasOwnProperty.call(obj, key)) newObj[key] = obj[key];}}newObj.default = obj;return newObj;}}function _classCallCheck(instance, Constructor) {if (!(instance instanceof Constructor)) {throw new TypeError("Cannot call a class as a function");}}function _possibleConstructorReturn(self, call) {if (!self) {throw new ReferenceError("this hasn't been initialised - super() hasn't been called");}return call && (typeof call === "object" || typeof call === "function") ? call : self;}function _inherits(subClass, superClass) {if (typeof superClass !== "function" && superClass !== null) {throw new TypeError("Super expression must either be null or a function, not " + typeof superClass);}subClass.prototype = Object.create(superClass && superClass.prototype, { constructor: { value: subClass, enumerable: false, writable: true, configurable: true } });if (superClass) Object.setPrototypeOf ? Object.setPrototypeOf(subClass, superClass) : subClass.__proto__ = superClass;}var

	Application = function (_React$Component) {_inherits(Application, _React$Component);
	  function Application(props) {_classCallCheck(this, Application);return _possibleConstructorReturn(this, Object.getPrototypeOf(Application).call(this,
	    props));}_createClass(Application, [{ key: 'render', value: function render()

	    {
	      return (
	        React.createElement('div', { className: 'application' },
	        React.createElement(_headerComponent2.default, null),
	        this.props.children));} }]);return Application;}(React.Component);

	Application.displayName = 'Application';

	module.exports = Application;

I also tried updating the following libraries to the listed version:
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>
and got the same result.
As for my other files, they are
compilers.js
var babel = require('babel-core/register');
var noop = function(){return null;};

//assets the webpack parsers that node can't
require.extensions['.html'] = noop;
require.extensions['.scss'] = noop;
require.extensions['.jpg'] = noop;
require.extensions['.jpeg'] = noop;
require.extensions['.png'] = noop;

mocha-generators.js
var co = require('co');
var mocha = require('mocha');
var Runnable = mocha.Runnable;
var run = Runnable.prototype.run;

Runnable.prototype.run = function(fn) {
  if(this.fn.constructor.name === 'GeneratorFunction') {
    this.fn = co(this.fn);
    this.sync = !(this.async = true);
  }

  return run.call(this, fn);
};

setup.js
//NOTE: setup expect as global
import {expect} from 'chai';

global.expect = expect;

//NOTE: setup JSDOM for test running
import * as jsdom from 'jsdom';

var exposedProperties = ['window', 'navigator', 'document'];

global.document = jsdom.jsdom('');
global.window = document.defaultView;

Object.keys(document.defaultView).forEach((property) => {
  if (typeof global[property] === 'undefined') {
    exposedProperties.push(property);
    global[property] = document.defaultView[property];
  }
});

global.navigator = {
  userAgent: 'node.js'
};

//NOTE: need to include the i18n testing file
global.window.i18n = require('./i18n-node.js');

//NOTE: include all files that should have coverage numbers on them in-case there are files the specs don't trigger inclusion
import globArray from 'glob-array';

var filesForCoverage = [
  process.cwd() + '/web/app/**/*.js',
  process.cwd() + '/web/app/**/*.jsx',

  //NOTE: pages are tested through ui tests, not unit tests
  '!' + process.cwd() + '/web/app/pages/**/*.js',
  '!' + process.cwd() + '/web/app/pages/**/*.jsx',

  //NOTE: mocks are not that important to coverage test
  '!' + process.cwd() + '/web/app/mock/**/*.js',

  //NOTE: 3rd party libraries that there is no point in testing
  '!' + process.cwd() + '/web/app/misc/ua-parser.js',

  //router based stuff seems to cause issue with needing the history location for react-router so just skip those file
  '!' + process.cwd() + '/web/app/application.jsx',
  '!' + process.cwd() + '/web/app/router.jsx',
  '!' + process.cwd() + '/web/app/routes.jsx'
];

globArray.sync(filesForCoverage).forEach(function(filePath) {
  require(filePath);
});

Let me know if you see anything weird that might be causing this issue in these files or if I can provide any other information to help you debug this issue.

I am suspecting something strange could be happening in your filesForCoverage setup step. Perhaps try omitting that part to see if it helps.
I'll go ahead and update the babel dependency also, just to make sure it isn't related.

Still the same issue with that block of code relating to filesForCoverage.  I mean since it just include files it should not cause any issues (not to mention I don't think there is any other way of make sure that a file is include in the report incase the unit tests don't trigger the inclusion of the proper files).

@ryanzec The preferred method of making sure all files are covered is using a common root setting and using the include-all-sources flag either on the command line or in your .istanbul.yml file. I just wanted to make sure that wasn't causing the issue since require magic often does cause a lot of trouble with Istanbul.
I have published 0.6.1, so you should try to install from scratch (you want to make sure old versions of babel are not being used) and see if that fixes your issue.

Also, one other thing you can try is import React from 'React'; instead of import * as React from 'React';. The star import produces a lot more code than the require import.

It was the import * as React that was causing the issue.  Weird that other locations use that way of importing did not report the same issues.
I do agree that it is generally bad to do import * for the reasons you mentioned but I was unaware I could import react and react-dom in that way.  I have updated by code and guess I will close this issue for now.  If I find it again, I will re-open.

Ok, getting this issue again.  This seems to be an issue when using import * as ..., the new use case is:

and the prevent-double-click.constants.js is:
export const ENABLE = 'PreventDoubleClick::enable';
export const DISABLE = 'PreventDoubleClick::disable';

This is a case where I think using the import * as ... is valid.

More weirdness in the results:

I am not sure why it is telling me that the red highlight statement is not covered when it shows that the class is created twice.
The only code coverage number that seems to be reliable is the lines covered.

Your only option here is to look at the generated code and try to figure out why it is doing what it is doing. Babel is literally creating statements that are not being run, so Istanbul is doing its job. This project has no control over how Istanbul covers or how Babel compiles. With that being said, you can try a few things:

Skip the statements that are causing trouble.
Use the runtime plugin (this could solve some, but not all your problems)
Bug the Babel maintainers (or contribute yourself) to make the compiled code less verbose.

I've had the same issue using babel-node ./node_modules/.bin/babel-istanbul
but pure<EMAIL_ADDRESS>using babel-node ./node_modules/istanbul/lib/cli.js works fine

I guess I will use the 1.x.x branch of the regular istanbul and see how using that goes.

@ryanzec do you by any chance use retainLines : true in your babelrc and in the context of instrumentation of your sources?
Nonetheless, I also get weird coverage results. The report shows 100% branch/function/line whatever coverage, but when digging into the generated HTML report it shows that multiple lines/branches are not being covered at all.

@silkentrance  @ryanzec I actually have not been able to get completely correct coverage from babel-istanbul, isparta, or istanbul's aphla. I believe there is just some inherent weirdness with the source maps generated by babel. Both babel-istanbul and isparta work by skipping coverage in the instrumentation layer based on source maps. Istanbul's alpha works in the reporting layer, but also uses source maps. My hunch is that some of the transformers do not completely play well with source mapping. That is, they probably don't clean up after themselves very well. I've pinpointed babel-plugin-transform-es2015-typeof-symbol as one that causes trouble for me.
TLDR: Any implementation that uses source maps for coverage are at the mercy of the quality of the source map.

@jmcriffey yeah, however, and in my case I think that it maybe has something to do with the HTML reporter, though. Since, when I go through my test cases and sources I think that the counters to the left are correct, but that the HTML reporter somehow gets it all wrong. We will have to wait for an istanbul update, I think.

While it is a newer project https://github.com/dtinth/babel-plugin-coverage was able to produce accurate HTML reports for us.


feature/implementOnUnpublishCallbackEtc

Handle error for unpublish/subscribe/unsubscribe (https://github.com/zevarito/Licode-ErizoClientIOS/issues/76)

Refactor to return NSError instead of error reason string in ECSignalingChannelRoomDelegate and ECRoomDelegate.
Add ECSignalingChannelErrorCode.

@allenlinli I've seen you've closed this one, so no need to review?


Rollback ledger and tests

Added tests for ledger rollback and fixed a bug on ledger not rolling back.

For contributor use:

[X] Targeted PR against master branch
[ ] Linked to GitHub issue with discussion and accepted design OR link to spec that describes this work
[X] Code follows the standards mentioned here
[ ] Updated relevant documentation
[X] Re-reviewed Files changed in the GitHub PR explorer
[ ] Added appropriate labels

thanks for fixing this, for those that wondered the error was found in this branch https://github.com/findonflow/find/actions/runs/4864765731/jobs/8674212937 in the TestFIND test.


⚠ Bofrost.fr has degraded performance

In a13b051, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1089 ms

Resolved: Bofrost.fr performance has improved in 0969610 after 6 minutes.


Feature Request: if not specified, get location from public IP address

If the user does not pass the required coordinates, we should use his approximate location instead.
We could do this by finding the public IP address and see where it originates from.

 The approximate location based on IP is not even close, so what is the point?
Better to just default to a location with a high chance of spotting aircraft, such as an airbase/airport.
Closing.


Update AUTHORS

Fix my name and email

I believe this github is a read-only mirror to gerrit.ovirt.org , where we accept patches.

Sure, cancelling then :)
Thanks!


Added better documentation around the withPG function.

Description
And also explicitly call it out in the front page documentation. Hopefully this will increase
adoption and prevent plenty of poorly written code as I was originally doing.
The most important note that I have made is that calls to withPG can be nested safely and still only result in a single Connection being reserved.
Screenshots
In the initial documentation:

In the withPG method:

Awesome, thank you.


tpm_main: flush transient objects

When using tpm2-tools directly with a TPM without a resource manager transient objects were not flushed. This caused the agent to crash because the TPM ran out of storage.
This is the better fix than #952.

/packit retest-failed

/packit retest-failed


Armageddon

src/nbl/asset/CGLSLScanBuiltinIncludeLoader.cpp can be safely removed from the engine

src/nbl/asset/CGLSLScanBuiltinIncludeLoader.cpp can be safely removed from the engine

you mean src/nbl/asset/CGLSLScanBuiltinIncludeLoader.h?

@Przemog1 @Crisspl @Hazardu @AnastaZIuk address the comments in separate PRs


Reduce backtracking in Lua “for” statement parsing.

When parsing “for a in …” the parser will currently first try to match a
rule of the form “for a = …” and then backtrack, causing the name “a” to
be parsed twice. This refactoring delays the choice and avoids backtracking.
This partly addresses the discussion in #32.

Coverage remained the same at 99.904% when pulling d705daba81e8528d1809b54c8107cfbcaf3c71f2 on lolengine:fix-lua-backtracking into ddc257b24f8213d033dd94752d8ebe75e6257657 on taocpp:master.

Coverage remained the same at 99.904% when pulling 5e63cff6eb0ad0a4d2c66f3045335af3eaae3222 on lolengine:fix-lua-backtracking into ddc257b24f8213d033dd94752d8ebe75e6257657 on taocpp:master.


replace layer in resnet

Is it possible to remove/replace the lower layers of a pretrained ResNet50 model in tf.keras.applications? trying to replace the first Conv2D layer with a new one. The only examples I've seen online do it for adding to the top of the network, not the first few layers.
For instance, I've tried doing this:
import tensorflow as tf
pretrained_resnet = tf.keras.applications.ResNet50(include_top=False, weights='imagenet')
inputs = tf.keras.Input(shape=(256,256,1))
x = tf.keras.layers.ZeroPadding2D()(inputs)
x = tf.keras.layers.Conv2D(filters=64,
                           kernel_size=(7,7),
                           strides=(2,2),
                           padding='same')(x)
outputs = pretrained_resnet.layers[3](x)
test = tf.keras.Model(inputs, pretrained_resnet.output)

But it gives an error.

How did you resolve this @coded5282 ?

I've attempted multiple work arounds for this exact issue. I have been unable to fix it. I suggest you either copy the code in the tf.keras implementation ResNet, then slice out the layers in the ResNet construction code and tack them on after your custom layer code. This allows you to get essentially pretrained_resnet[3:]. Then copy the imagenet weights across.


Generate default github actions

Spring initializr generates .gitignore by default.
We should also generate a github action file based on the :

JDK version
Language
Build system

@backwind1233 could you give it a try?

you can reference these:

io.spring.initializr.generator.spring.configuration.ApplicationPropertiesContributor
io.spring.initializr.generator.spring.scm.git.GitIgnoreContributor
https://github.com/Azure/azure-spring-initializr/blob/main/.github/workflows/maven.yml

Close it because the My Azure Initializr project finishes.
If the code needs review and merge to this repository in the future, will reopen the issue.


Hashing in C++

🚀 Feature
Hashing in C++.
Various problems like Is sudoku valid, triplet sum in array, Key pair, Intersection of two arrays can be solved using hashing.
Have you read the Contributing Guidelines on Pull Requests?
Yes
Motivation
Competitive coding
Pitch
These are some of the must do coding questions for interviews in various companies.

I would like to solve this issue. Please assign me this issue @Debashish-hub

Need more details


same isue

          <img width="588" alt="image" src="https://github.com/Shopify/cli/assets/28214740/a10439b2-5656-4bd4-b5b6-4acaaa5089bb">

Facing Same issue.
This is my first Shopify experience. Any solutions are appreciated.
Tried logging out and logging in
Also tried making a new project
Originally posted by @tiwarishikesh in https://github.com/Shopify/cli/issues/866#issuecomment-1656713656

Hi @looks-pk.
What's the CLI version you're using?
@Shopify/theme-code-tools

Hi @looks-pk.
What's the CLI version you're using?
@Shopify/theme-code-tools