New Logo

Hello sir.
You have a great app, unfortunately this app does not have a logo yet, may I donate a logo for your app?

This isn't an app - it's a collection of apps dedicated to Free and Open Source standards - did you mean a logo for this repository in general?

I think this is an app, thank you bro

Thank you for your attention.
greeting me respectfully.


dbt Seed, throwing a error

i am new to dbt, so i was trying to seed a csv file to snowflake using dbt seed command. and i am ending with this error.

@Rahul-Gajula Welcome! Which version of dbt are you using? (Could you run dbt --version and copy the output here?)
It sounds like there may have a mismatch between the versions of dbt-core and dbt-snowflake that you have installed. The get_batch_size macro was added in dbt-core v0.21 (https://github.com/dbt-labs/dbt-core/pull/3623).

installed version: 0.20.2
latest version: 0.21.0
Your version of dbt is out of date! You can find instructions for upgrading here:
https://docs.getdbt.com/docs/installation
Plugins:

bigquery: 0.21.0
postgres: 0.21.0
redshift: 0.21.0
snowflake: 0.21.0
sqlserver: 0.20.1
synapse: 0.20.0

is this the problem of version, or do i need to configure in dbt_project.yml.
Just correct me if the process is right

i copied the csv file to data folder of  dbt project
without any configuration in the dbt_project.yml i ran dbt seed

@Rahul-Gajula As I suspected, you have dbt-core==0.20.2 and dbt-snowflake==0.21.0 installed. Those versions are not mutually compatible.
If you installed dbt with pip, you can upgrade to the latest versions (and ensure compatibility) by running:
pip install dbt-snowflake --upgrade

yes, it worked like a charm. Thank you Jeremy, appreciate your kind help.


expand prototype test matrix to different Python versions

This expands the prototype test matrix to test all Python versions on Linux. This should give us some extra safety to catch stuff like #5801 and https://github.com/pytorch/data/runs/6500848588#step:9:1977, which are not visible on Python 3.7.
Since GitHub actions is free for OSS projects, this does not add any costs.

After some offline discussion with @NicolasHug, we decided to only follow up on this after the release to avoid for the CI going red for something that does not need to be fixed before the release.

@NicolasHug apart from the flaky open file handle warning, expanding the CI matrix also turned up warnings that #5219 tried to solve. I've added fixes for ImageNet and CUB200 here and CI is now green. Do you want me to extract these changes out of this PR and send a separate one, or keep them here?

Do you want me to extract these changes out of this PR and send a separate one

Yes please!

See #6076.


Modularise scripts

Would a PR to modularise scripts in react-scripts be considered?
For example, with start.js:
scripts
    start.js
utils
    addWebpackMiddleware.js
    createWebpackCompiler.js
    createWebpackDevServer.js
    runWebpackDevServer.js

Reasons for doing this:

Clearer for new contributors and people reading code for learning
Make the process of modifying an ejected CRA app simpler
Make scripts more extensible in ejected apps and forks (by removing interweaving and enabling reuse)
Reduce complexity of upstream merges to forks of create-react-app (my motivation)

Sounds good, let's give it a try!

Fixed by #1433.


Update running-and-debugging-sdn-interface.md

Docs Build status updates of commit 22c7337:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Skype/SDN/articles/running-and-debugging-sdn-interface.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


"Company owned" devices are not reported

Hello,
I noticed the Get-GSMobileDevice doesn't report the list of devices registered as company owned.
It is the same behavior while using Google tool Try this API at the link Mobiledevices: list, using the filter:

customerId = <CustomerId>
query = serial:<SerialNumber> (it is the serial number of company owned device appearing on G Suite console; if I specify a serial number of any User owned device, then it works).

Note: "query" field syntax is provided by Use search operators to find devices > Company-owned device search operators section
So the question is: how is it possible Google isn't allowing company owned devices to be searched via API ? I cannot believe that. So, what did I miss ?
Thank you,
Luca

Hey @lucafabbri365 - How are you currently determining if a device is company owned or not in the Admin Console? We use MDM, but primarily for device policy enforcement on BYOD mobile devices, so I honestly haven't used the APIs or the UI for searching for company-owned devices. It seems like you're getting the same results though when using the API Explorer as you are with PSGSuite, so I'm wondering if this would be a better question for Google / the team that supports that API?

Hello @scrthq,
in Admin Console the "Ownership" column identifies if a device is "User owned" (BYOD) or "Company owned". Company devices are those registered under Device management  > Company owned inventory section.
As I can see it's a Google API limit and, to be honest, it doesn't make any sense to me: a mobile device, is a mobile device either company owned or user owned; so why an API with generic name Mobiledevices should return user owned only devices and not company owned ?

Hello @scrthq,
I'm going to close the issue because not related to PSGSuite.
Bye,
Luca


WIP - Add policy-publisher to list of migrated apps

We're migrating policy-publisher to use the publishing api so that we have a single source of truth for tags.
This is related to https://trello.com/c/87jz9T24/465-migrate-policy-publisher-to-new-tagging-infrastructure
and depends on alphagov/policy-publisher#121

I think this should be merged (when we're ready) for completeness, but I believe that panopticon doesn't currently get told about the policies, so this won't have any effect.  It's good to keep the various lists of migrated apps in sync, though, so :+1:.

Is this still WIP (as the PR title suggests) or can this be merged?

@benilovj I originally thought it was best to leave this open until the policy-publisher PR is merged (which is still a WIP). We have a deploy step to run the migrate_taggings task.
If there is actually no effect of this as @rboulton says then I'm not aware of any reason not to merge now :+1:


BUG FIX: when open a notebook with open().....

BUG FIX: when open a notebook with open(), default encoding method is locale-dependent. while notebook is always of 'utf-8' encoding. so we should explicitly use open('xx.ipynb',encoding='utf8'). Refer to this official notebook loader example

Coverage remained the same at 92.021% when pulling 380e2007c634dbed7716fb12e22a7748490d5187 on mickeydonkey:master into 12e2cbad91f1d82552ec0b4329e4a588b6e6f639 on paulgb:master.

oops... incompatible with python 2.7

Coverage increased (+0.02%) to 92.042% when pulling 24439f0598e91de3ce2dca3a757faed8374e1afd on mickeydonkey:master into 12e2cbad91f1d82552ec0b4329e4a588b6e6f639 on paulgb:master.

Thanks @mickeydonkey.


Update fast coverage implemenation to support EI guidance.

This is great, thanks! Will review/merge this soon.


apcu get keys by regex

per implementation it looks like there is some functionality arround getting keys from apcu by regex:
https://github.com/gordalina/cachetool/blob/fa4b8c736a5942d39edabaf3d9f26741fb42b1ea/src/CacheTool.php#L22
but neither the README:
https://github.com/gordalina/cachetool/blob/fa4b8c736a5942d39edabaf3d9f26741fb42b1ea/README.md?plain=1#L103-L127
nor the CLI usage description does contain in hint on how to invoke the tool to get it working.
is it missing or is it intentionally not published?

This was a mistake, I'll remove it. Thank you for flagging.


Fix inline equation example in README.adoc

The inline equation in the Diophantine equation theorem environment is interpreted as a literal string rather than an equation. Removing the back slashes fixes this. I am not sure if this is a bug with the documentation or the program.

@jxxcarlson can you confirm?

The README is formatted using asciidoctor-latex but Github does not know that. There is a note about that in the README also:

However, since this document will not render fully in GitHub, you are encouraged to compile it yourself using asciidoctor-latex -b html README.adoc or to consult the README at S3.

Matt -- thankyou!


Overriding RelocationHandler and ElfExtension

I seem to be having a difficult time overriding these two features. I am directly extending MIPS_ElfRelocationHandler and MIPS_ElfExtension as what I'm dealing with is a MIPS processor but it just has some unusual differences and some things need to be handled differently. The problem is since this is still a MIPS processor, the respective getHandler methods seem to pick up the overriding classes only when it feels like it and returns the default MIPS ones the rest of the time. This is a problem because I don't get the required behavior every single time.
Is there something I can do to ensure that the overriding classes get picked everytime instead of the handler search stopping when the default MIPS handler is found?
It appears this is occurring because the ClassSearcher is returning an unsorted list. Since it is unsorted sometimes the MIPS_RelocationHandler is closer to the start of the list than my implementation which causes my implementation to go unused.
Same thing occurs with extending GnuDemangler.

A Ghidra installation has an optional "patch" directory where you can place class files to override default behavior.  Other than that, we don't recommend trying to override behavior by hijacking the classpath.
Are you working on a one-off solution for personal use or do you hope to contribute these changes back for others to use?

A Ghidra installation has an optional "patch" directory where you can place class files to override default behavior. Other than that, we don't recommend trying to override behavior by hijacking the classpath.
Are you working on a one-off solution for personal use or do you hope to contribute these changes back for others to use?

This would be for a contribution somewhere. I'm just looking to extend the MIPS_RelocationHandler.

The intended design is for you to create a new subclass of ElfRelocationHandler and override the canRelocate() method with something specific to your processor variant.  But it sounds like the existing relocation handler is also hitting on your specific processor?

The intended design is for you to create a new subclass of ElfRelocationHandler and override the canRelocate() method with something specific to your processor variant. But it sounds like the existing relocation handler is also hitting on your specific processor?

Yes. I have more details in #1260

Ok makes sense.  To answer your question in this ticket, you'll have to go into the existing relocation handler and change it to not hit on your MIPS variant.  This is the standard solution (ex: X86_32_CoffRelocationHandler vs X86_64_CoffRelocationHandler).  The obvious downside to this approach is that they all need to be aware of each other for things to work correctly.
You bring up a good general point though, but we can discuss that in the other ticket.

Ok makes sense. To answer your question in this ticket, you'll have to go into the existing relocation handler and change it to not hit on your MIPS variant. This is the standard solution (ex: X86_32_CoffRelocationHandler vs X86_64_CoffRelocationHandler). The obvious downside to this approach is that they all need to be aware of each other for things to work correctly.
You bring up a good general point though, but we can discuss that in the other ticket.

I see. I built a custom loader for it which extends the ElfLoader. So I'll just clear the messageLog to hide the relocation errors and iterate through the relocations to correct them. Thank you.


do not add to pub use in assists that insert a use statement

closes #5657 , see issue for rationale
Initially I wrote a version of this that changed the signature of insert_use_statement to take an Option<VisibilityKind> and only add to use statements with the same visibility, but that didn't make sense for any of the current uses of insert_use_statement (they all expected private visibility).

Thanks, looks good!
bors r+


tests: failing due to argparse.ArgumentError: argument --fast_dev_run: expected one argument

🐛 Bug
The current tests on the master branch are failing due to:
argparse.ArgumentError: argument --fast_dev_run: expected one argument

Failing runs
(due to the above error on https://github.com/PyTorchLightning/pytorch-lightning-bolts/commit/a72766c461a498ab67b7c2efe7e0d49224290837 for example)

https://github.com/PyTorchLightning/pytorch-lightning-bolts/runs/1586140031
https://github.com/PyTorchLightning/pytorch-lightning-bolts/runs/1586140045

Failing tests
tests/models/test_scripts.py::test_cli_run_basic_ae[--dataset cifar10 --data_dir /home/runner/work/pytorch-lightning-bolts/pytorch-lightning-bolts/datasets --max_epochs 1 --batch_size 2 --fast_dev_run]
tests/models/test_scripts.py::test_cli_run_basic_vae[--dataset cifar10 --data_dir /home/runner/work/pytorch-lightning-bolts/pytorch-lightning-bolts/datasets --max_epochs 1 --batch_size 2 --fast_dev_run]
tests/models/rl/test_scripts.py::test_cli_run_rl_dqn[--env PongNoFrameskip-v4 --max_steps 10 --fast_dev_run --warm_start_size 10 --n_steps 2 --batch_size 10]
tests/models/rl/test_scripts.py::test_cli_run_rl_double_dqn[--env PongNoFrameskip-v4 --max_steps 10 --fast_dev_run --warm_start_size 10 --n_steps 2 --batch_size 10]
tests/models/rl/test_scripts.py::test_cli_run_rl_dueling_dqn[--env PongNoFrameskip-v4 --max_steps 10 --fast_dev_run --warm_start_size 10 --n_steps 2 --batch_size 10]
tests/models/rl/test_scripts.py::test_cli_run_rl_noisy_dqn[--env PongNoFrameskip-v4 --max_steps 10 --fast_dev_run --warm_start_size 10 --n_steps 2 --batch_size 10]
tests/models/rl/test_scripts.py::test_cli_run_rl_per_dqn[--env PongNoFrameskip-v4 --max_steps 10 --fast_dev_run --warm_start_size 10 --n_steps 2 --batch_size 10]
tests/models/rl/test_scripts.py::test_cli_run_rl_reinforce[--env CartPole-v0 --max_steps 10 --fast_dev_run --batch_size 10]
tests/models/rl/test_scripts.py::test_cli_run_rl_vanilla_policy_gradient[--env CartPole-v0 --max_steps 10 --fast_dev_run --batch_size 10]
tests/models/self_supervised/test_scripts.py::test_cli_run_self_supervised_amdim[--data_dir /home/runner/work/pytorch-lightning-bolts/pytorch-lightning-bolts/datasets --max_epochs 1 --max_steps 3 --fast_dev_run --batch_size 2]
tests/models/self_supervised/test_scripts.py::test_cli_run_self_supervised_moco[--data_dir /home/runner/work/pytorch-lightning-bolts/pytorch-lightning-bolts/datasets --max_epochs 1 --max_steps 3 --fast_dev_run --batch_size 2]
tests/models/self_supervised/test_scripts.py::test_cli_run_self_supervised_byol[--data_dir /home/runner/work/pytorch-lightning-bolts/pytorch-lightning-bolts/datasets --max_epochs 1 --max_steps 3 --fast_dev_run --batch_size 2 --online_ft]

To Reproduce
It looks tests on {macOS, Ubuntu} x {3.6} are failing...
further investigating...

I was guessing that all tests with --fast_dev_run are failing, but that's not true as the following test which has --fast_dev_run passes:
tests/models/self_supervised/test_scripts.py::test_cli_run_self_supervised_simclr[--data_dir /home/runner/work/pytorch-lightning-bolts/pytorch-lightning-bolts/datasets --gpus 0 --fp32 --max_epochs 1 --max_steps 3 --fast_dev_run --batch_size 2 --online_ft] PASSED [ 83%]

I feel that the problem is that this fast dev is not the one taken from Trainer but coded/added extra...

You're right. The models passing the tests have their own --fast_dev_run. I'm not sure yet why the tests for the rest models fail only on Python 3.6 though.
Do you think it's reasonable to add --fast_dev_run to the other models for now? (although I think  --fast_dev_run should be included not in models but in trainer...)

@ananyahjha93 I looked through the changelog (3.6->3.7) of argparse and the docs and tried to locate how this fast dev is not the one taken from Trainer but coded/added extra... as @Borda mentioned, but I couldn't find a way to solve this problem.
An easy workaround to fix this error would be to add --fast_dev_run args to faiilng models... https://github.com/PyTorchLightning/pytorch-lightning-bolts/issues/471#issuecomment-750794733

@ananyahjha93 I looked through the changelog (3.6->3.7) of argparse and the docs and tried to locate how this fast dev is not the one taken from Trainer but coded/added extra... as @Borda mentioned, but I couldn't find a way to solve this problem.
An easy workaround to fix this error would be to add --fast_dev_run args to faiilng models... https://github.com/PyTorchLightning/pytorch-lightning-bolts/issues/471#issuecomment-750794733

I resolved this by passing --fast_dev_run 1 as command line argument

I resolved this by passing --fast_dev_run 1 as command line argument


CreateNamedPipe failed, GLE=231.

When I run the exe I get:
Opening discord-ipc-0 Windows pipe
CreateNamedPipe failed, GLE=231.

How do I fix this?

That means there's already a bridge running.


[VT-38] vit "splashscreen"

David Patrick on 2013-09-11T00:00:46Z says:
You can choose what filter and report vit starts with, by including the options;
vit filter-a filter-b report
and if you don't supply a report, vit will use the default report from .taskrc
This feature request is to add an option to how vit starts up, when no filter or report is supplied.
With a related configuration entry in .vitrc, something like a pre-default-report routine can be easily set up.
something like this;
splash=task logo ; fortune ; figlet Taskwarrior ; echo '    Taskwarrior is a command-line todo list manager' ; date
could (did) produce something like this;

and the great thing is that is can be totally user-configurable, put what you like/ need in there!
Hitting < enter > would then go to your default report.

Migrated metadata:
Created: 2013-09-11T00:00:46Z
Modified: 2014-02-09T01:16:51Z


[Feature] AutoComplete

derived from https://github.com/dooboolab/dooboo-ui-native/issues/37
Material UI AutoComplete Page
Goal

Implementing strictly typed AutoComplete component with test codes
Adding storybooks for AutoComplete component and sub-components
assigned to jb9229
Examples

Hackatalk UI Design

Text Fields
Selects

Material UI reference page for AutoComplete

Libraries

styled-components
storybook.js
@testing-library/react-native

Structure

Render Input

Render Option

Options

[RenderInput] requires:
assigned to vanayun, impressor615

focus

Active

Inactive

filter
assigned to hmhm2292

scroll top to the screen as the screenshot when touched

[Render Option] requires:
assigned to imjihun

background highlight when touched
set value for Render Input when selected
have various options such as icon, image, styles, etc.

[Options] requires:

resize to max out the device's screen size and scroll top along with the Render Input
filtered when the value of Render Input satisfies search requirements
scrollable if height of its contents exceeds the screenHeight subtracts to the renderInput height

TODO

to accept various types of input data
to accept placeholder style prop
smooth animation for open/close optionList (sizes, colors)
smooth animation for optionItem onPress event (sizes, colors, underlay color, selected color)
smooth keyframe rotation animation for caret arrow
accept external caret component
accept external reset button component
test codes
storybook integration with webpage configuration

[RenderInput] assign me

[Render Option] assign me

[Adding storybooks for AutoComplete component and sub-components] assign me

[filter] assign me

@marsinearth How is this going?

@marsinearth

@marsinearth

@marsinearth ??


Search page and functionality

Adding Search page where the using type the name of the author or post content. Filtering done though matching content and search terms.
Description:
Please provide a summary of changes made and the relevant issue that has been worked on. Also list any major changes made to project structure/dependencies if applicable
All Submissions:

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to change)
[x] My code follows the code style of this project
[ ] My code has been commented
[ ] My change requires a change to the documentation
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[ ] All new and existing tests passed

James has refactored the code to use data from the DB rather than mock-data now, you'll need to incorporate that change into your branch before this can be merged I think

PR is stale with too many merge conflicts.
A2 has decided to Abandon this PR


Enhancement #1155

This is my enhancement for #1155. Added columns for engagement and associated test whenever a finding is pulled up in the simple search. The engagement column lists the engagement that the finding is associated with. The associated test column displays the test that the finding is associated with. If the associated test is not titled, the associated scan is displayed instead.

Looks good to me! Thank you.


encoding/json.Unmarshal doesn't deal with conflicting keys

What version of Go are you using (go version)?

$ go version
go version go1.14.1 darwin/amd64

Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE="on"
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/nat/Library/Caches/go-build"
GOENV="/Users/nat/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/nat/Projects"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org"
GOROOT="/usr/local/Cellar/go/1.14.1/libexec"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.14.1/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/nat/Projects/relay/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/x_/nv225yzx4d32q31hf_g735cc0000gn/T/go-build148188573=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?
a.go
package lib

import (
	"encoding/json"
	"fmt"
	"io"
	"io/ioutil"
)

type Data struct {
	*A
	*B
}

type A struct {
	Episodes []struct {
		ID             int    `json:"id"`
		EpisodeNumber  int    `json:"episodeNumber"`
		SeasonNumber   int    `json:"seasonNumber"`
		Title          string `json:"title"`
		QualityVersion int    `json:"qualityVersion"`
	} `json:"episodes"`
	EventType string `json:"eventType"`
	Series    struct {
		ID     int    `json:"id"`
		Title  string `json:"title"`
		Path   string `json:"path"`
		TvdbID int    `json:"tvdbId"`
	} `json:"series"`
}

type B struct {
	Albums []struct {
		ID             int    `json:"id"`
		Title          string `json:"title"`
		QualityVersion int    `json:"qualityVersion"`
	} `json:"albums"`
	EventType string `json:"eventType"`
	Artist    struct {
		ID   int    `json:"id"`
		Name string `json:"name"`
		Path string `json:"path"`
		MbID string `json:"mbId"`
	} `json:"artist"`
}

func Parse(b io.Reader) (string, error) {
	var data Data

	buf, err := ioutil.ReadAll(b)
	if err != nil {
		return "", err
	}

	if err := json.Unmarshal(buf, &data); err != nil {
		return "", fmt.Errorf("decoding json to structured data: %w", err)
	}

	if data.A != nil {
		return data.A.EventType, nil
	}

	if data.B != nil {
		return data.B.EventType, nil
	}

	return "", fmt.Errorf("no valid type data")
}

a_test.go
package lib

import (
	"strings"
	"testing"
)

func TestParse(t *testing.T) {
	tests := map[string]struct {
		Have string
		Want string
	}{

		"A": {
			Have: `{
  "episodes": [
    {
      "id": 123,
      "episodeNumber": 1,
      "seasonNumber": 1,
      "title": "Test title",
      "qualityVersion": 0
    }
  ],
  "eventType": "Test",
  "series": {
    "id": 1,
    "title": "Test Title",
    "path": "C:\\testpath",
    "tvdbId": 1234
  }
}`,
			Want: "Test",
		},
		"B": {
			Have: `{
  "albums": [
    {
      "id": 123,
      "title": "Test title",
      "qualityVersion": 0
    }
  ],
  "eventType": "Test",
  "artist": {
    "id": 1,
    "name": "Test Name",
    "path": "C:\\testpath",
    "mbId": "aaaaa-aaa-aaaa-aaaaaa"
  }
}`,
			Want: "Test",
		},
	}

	for name, tc := range tests {
		t.Run(name, func(t *testing.T) {
			got, err := Parse(strings.NewReader(tc.Have))
			if err != nil {
				t.Error(err)
			}

			if got != tc.Want {
				t.Errorf("ReaderToMessage(%q) returned %q wanted %q", tc.Have, got, tc.Want)
			}
		})
	}
}

What did you expect to see?
I expected the tests to pass.
What did you see instead?
The EventType field on both structs is empty.

Conflicting fields from embedded structs can only be accessed through .EmbededType.Field and not .Field directly, so json has nowhere to unmarshal to

That makes sense, is there a common way to change this code to deal with this case?
Otherwise, it does feel like a bug because it silently fails.
I wonder if it would be worth adding to go vet or something to prevent people from doing this.

That makes sense, is there a common way to change this code to deal with this case?

The general answer here is don't use anonymous struct fields that introduce ambiguity. There is also json:"-" if you want to skip an entire anonymous field, to let another one be used completely.

Otherwise, it does feel like a bug because it silently fails.

There is no failure. It's just not doing what you think it should.

I wonder if it would be worth adding to go vet or something to prevent people from doing this.

The program above is valid, so vet shouldn't complain about it.
I believe the docs are already pretty unambiguous about this case:

Anonymous struct fields are usually marshaled as if their inner exported fields were fields in the outer struct, subject to the usual Go visibility rules amended as described in the next paragraph.

If you think the docs could be made clearer, suggestions or patches are welcome. But there isn't a bug here, as far as I can tell.

Sorry, @mvdan I think you're talking about the inverse case? I'm decoding JSON that I don't control. Depending on the circumstances, the source sends different JSON. There are no conflicting keys in this JSON except the "event_type" key.
I've created two types to cover each different situation. Even if the types have different names for the struct value EventType (for instance if I called one EventTypeA and the other EventTypeB). But because they have the same json: tag, neither gets filled. This seems like a bug to me.
The code also works if there is just one type, with no conflicting json: tag. The docs are talking about turning structs into json, I care about turning json into structs.
In UnMarshal, the docs say:

To unmarshal JSON into a struct, Unmarshal matches incoming object keys to the keys used by Marshal (either the struct field name or its tag), preferring an exact match but also accepting a case-insensitive match. By default, object keys which don't have a corresponding struct field are ignored (see Decoder.DisallowUnknownFields for an alternative).

I guess the change I'd make to the docs is add the sentence: If there are two fields with the same tag, anywhere in the underlying struct (or it's children), Go will not decode into either.

The rules for anonymous structs (i.e. following the Go visibility rules) are the same when unmarshaling - that's why I linked them earlier. If you want to make that clearer, we can, but we should point to the existing rules (already documented) instead of explaining the same rules in a different way.

I see, I misunderstood. You're referring to #3 below. Thank you.

Of those fields, if any are JSON-tagged, only tagged fields are considered, even if there are multiple untagged fields that would otherwise conflict.
If there is exactly one field (tagged or not according to the first rule), that is selected.
Otherwise there are multiple fields, and all are ignored; no error occurs.

Re your comment The general answer here is don't use anonymous struct fields that introduce ambiguity. How would you change the above code to have the tests pass? My understanding of https://blog.golang.org/json is that anonymous structs are the best practice here.

Define a struct type with all the possible fields; use pointers so that json inputs which lack a field yield nil.
type Data struct {
   EventType int
   Artist *struct {...}
   Albums []struct {...}
   Series *struct {...}
   Episodes []struct {...}
}

Cool. Thanks.


add InterfaceAddrs stub

LGTM

Thanks @eliasnaur for the addition and to @scottfeldman for review. Now merging.


[BT] put decorator on the correct place

What does this PR do?
This PR puts the decorator check_if_pytorch_greater_112 in the correct place. In fact, putting the decorator above the definition of the class does not somehow activates the check
cc @michaelbenayoun @fxmarty

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Do we have tests of BetterTransformer for both 1.12 and 1.13?

Actually we don't have any tests for PT 1.12 and we can, the thing is I was just afraid it will add more boilerplate on the current testing suite (we already have ~40 tests and 2 CI runners), wdyt?

I'm not sure, when trying with torchserve + pytorch 1.12. I recall having errors with 1.12. I'll come up with a reproducible example ASAP.
Let's merge this anywas, LGTM


Refactor shouldCompress function

Refactor shouldCompress function to use template literals for debug messages and const for variable declaration

Using ES6 syntax will require to drop support for all Node.js versions, so this PR can be included in the next major potentially.


Attempt to streamline action files

Testing some changes in the action scripts

This did not appear to trigger actions - will try to launch again


Terrain Control SimpleDimensions world causes crash when selected

https://github.com/zmaster587/AdvancedRocketry/files/1083404/crash-2017-06-18_17.54.47-client.txt
Here's the crash log.
When I select the world in the Warp Controller or planet selector menu, the game crashes clientside.
It's a SimpleDimensions world with the TerrainControl world type that's been dimmapped to an AR planet in a nearby solar system to Earth.
TerrainControl is a separate mod from SD which has its own, customizable world type.

would it be at all possible to send a copy of the planetDefs.xml as well as the id of the planet you're trying access?
The odd thing about this is that it's an NPE getting a star, not a planet, that's causing the issue.

Here you go:
planetDefs.txt
I turned it into a txt file so it would upload.
The planet's dim ID is 30001. SimpleDimensions IDs start at 30000.

Is this still a issue? Please comment if it is and i will reopen if if you are unable? We are closing old issues to see what is still relevant and needs to be fixed.


Remove dependency on Google's bastion module

This module was originally a simple wrapper around Google's module but now has evolved to not need or expose all the options provided by that module. Investigate removal of Google's module and simply spin up a VM directly.
Related to #71 and others like it.

Not stale

Not stale


Crash with unknown PID

---------------------------
unhandled exception!
---------------------------
System.ArgumentException: Process with an Id of 7804 is not running.

   at System.Diagnostics.Process.GetProcessById(Int32 processId, String machineName)

   at workspacer.WindowsWindow.get_Process()

   at workspacer.WindowRouter.<>c.<.ctor>b__3_4(IWindow window)

   at workspacer.WindowRouter.RouteWindow(IWindow window, IWorkspace defaultWorkspace)

   at workspacer.WorkspaceManager.AddWindow(IWindow window, Boolean switchToWorkspace, Boolean firstCreate)

   at workspacer.WindowsManager.RegisterWindow(IntPtr handle, Boolean emitEvent)

press ctrl-c to copy this
---------------------------
OK
---------------------------

This occurred when I clicked on an application as workspacer was starting up.
I saw the application flash black briefly, so maybe internally it like swapped itself out for a new process or something strang?

this should be resolved in the latest unstable release


Check and update the  apis  of board with the style of stateless

In GitLab by @sokril on Dec 18, 2019, 24:52

In GitLab by @luotian-github on Mar 3, 2020, 08:47
assigned to @sokril


Internal error occurred: failed calling webhook connect: no route to host

[root@master-node ~]# kubectl apply -f test-resources.yaml
namespace/cert-manager unchanged
Error from server (InternalError): error when creating "test-resources.yaml": Internal error occurred: failed calling webhook "webhook.cert-manager.io": Post "https://cert-manager-webhook.cert-manager.svc:443/mutate?timeout=10s": dial tcp <IP_ADDRESS>:443: connect: no route to host

Steps to reproduce the bug:
Use this manual:
https://cert-manager.io/docs/installation/kubernetes/
kubectl apply --validate=false -f https://github.com/jetstack/cert-manager/releases/download/v1.0.1/cert-manager.yaml
kubectl apply --validate=false -f https://github.com/jetstack/cert-manager/releases/download/v1.0.1/cert-manager.crds.yaml
Pods are running
[root@master-node ~]# kubectl get pods -n cert-manager
NAME                                       READY   STATUS    RESTARTS   AGE
cert-manager-5dcd6c7d7f-4df6z              1/1     Running   1          44m
cert-manager-cainjector-7c88fb85dd-b75xk   1/1     Running   2          44m
cert-manager-webhook-65f4cc9b55-b5l7f      1/1     Running   0          44m

[root@master-node ~]# kubectl get svc -n cert-manager
NAME                   TYPE        CLUSTER-IP      EXTERNAL-IP   PORT(S)    AGE
cert-manager           ClusterIP   <IP_ADDRESS>    <none>        9402/TCP   44m
cert-manager-webhook   ClusterIP   <IP_ADDRESS>   <none>        443/TCP    44m

I raised the cluster from scratch. The error persists
Environment details:

Kubernetes version: v1.19.0
cert-manager version: v1.0.1
Install method: static manifests
Centos 7

/kind bug

This seems to be a problem with your CNI of your cluster.
/triage support

@ser60v Did you find a solution? I've run into exact same problem with pretty standard Calico CNI.

Same issue here, also using Calico CNI, nothing special, default install.
In the cert-manager logs:
dial tcp <IP_ADDRESS>:443: connect: no route to host"
controller.go:158] cert-manager/controller/CertificateReadiness "msg"="re-queuing item due to error processing" "error"="Internal error occurred: failed calling webhook \"webhook.cert-manager.io\": Post \"https://cert-manager-webhook.cert-manager.svc:443/mutate?timeout=10s\": dial tcp <IP_ADDRESS>:443: connect: no route to host" "key"="cert-manager-test/selfsigned-cert"

Here's the service:
$ kubectl get -n cert-manager svc
NAME                   TYPE        CLUSTER-IP       EXTERNAL-IP   PORT(S)    AGE
cert-manager           ClusterIP   <IP_ADDRESS>   <none>        9402/TCP   3h28m
cert-manager-webhook   ClusterIP   <IP_ADDRESS>      <none>        443/TCP    3h28m

exec into another container with debug tools in the default namespace:
bash-4.3# curl https://<IP_ADDRESS> --insecure
404 page not found

Looks like the CNI is working, there's connectivity to the cert-manager webhook service within cluster.
k8s v1.20.2
Next steps for debugging?

May have figured this out.
TLDR;
kubectl apply -f https://github.com/jetstack/cert-manager/releases/download/v1.3.0-alpha.1/cert-manager.crds.yaml`
helm repo add jetstack https://charts.jetstack.io
kubectl create namespace cert-manager
helm install cert-manager --set webhook.hostNetwork=true --set webhook.securePort=10251 --namespace cert-manager jetstack/cert-manager

Am running k8s bare-metal but noticed in the AWS EKS section of the Compatibility
troubleshooting docs it mentioned Calico

the webhook can be run in the host network so it can be reached by cert-manager, by setting the webhook.hostNetwork key to true on your deployment

I didn't find hostNetwork in the cert-manager.yaml manifest so took a stab at using the
helm chart for cert-manager
This led to...
...
 Normal  Issuing    3m26s  cert-manager  The certificate has been successfully issued

I followed @recipedude and was able to make all the three pods running fine, the only change i did is to stop and disable firewalld service and selinux on worker nodes and master


Tags which are starting with a 0 (zero) in the slug can't be filtered

Issue Summary
When creating a new tag e.g. with name "030", the auto generated slug is also "030" (zero, three, zero).
In the tags overview, it shows up all pages/posts which have this tag, but if you click on the no. of posts with this tag, the list is empty.
The same happens, when trying to filter with the #get helper inside a template.
To Reproduce

Login to ghost admin
Click Tags
Create a new tag called "030" (also slug should be 030)
Create a post, and tag it with "030"
Go back to Tag list, and click on the "# post(s)" in the row of tag "030"
Page shows no posts / pages

What did you expect to happen instead?
Page should show all posts with this tag and filtering with get helper should recognize this posts/pages too.
Technical details:

Ghost Version: 3.22.0
Node Version: 12.10.0
Browser/OS: Chrome (83.0.4103.116)
Database: sqlite (default after local setup)

I've clearly got too much spare time today... 🤦♂
Anyway I've tracked this down to the use of the package NQL. Basically it's (probably correctly) parsing out the tag it to a number which drops the leading 0. When it's doing a DB search it doesn't pull back the correct record. You can easily confirm this by making a tag 30 and the result using the tag 030 will show up there instead to mimic that behaviour.
Also fwiw a super easy repro to show that nql is doing this would be the following:
const nql = require('@nexes/nql');
const res = nql('tag:030').toJSON();
console.log(res);

// { tag: 30 }

I guess there are two options here, somehow stringify the all tags before parsing them through NQL or change the behavior of NQL? Not knowing enough of the semantics of this app (yet) I'm guessing I'd have to defer how best to fix / not fix this to one of the maintainers. Hope this helps the dev team though...

@iamscottcab Thank you for breaking this down. I've not had the time to do so. 👍

@iamscottcab Thank you for breaking this down. I've not had the time to do so. 👍


Deps exclusions support

Hi! Seems like it doesn't support deps exclusions or am I wrong?

It’s better to check. Write a repro and post it here if it doesn’t?

I checked again, It was my mistake, sorry for bothering.


Redict/Valkey support?

Given the recent flap about Redis changing its license to one that doesn't meet the definition of open source software, do you plan to support either of the two major forks of Redis (Redict/Valkey) in coredis?
Feel free to close this if it's too off-topic -- I'm just curious what your thoughts are.

@coandco - completely open to it - I think the first step would be to add these to the CI compatibility matrix.
I have something like this for keydb & dragonflydb as well

Just added valkey to the CI and it mostly behaves as expected: https://github.com/alisaifee/coredis/actions/runs/8767165485/job/24060116715

Both redict and valkey are now tested against in the CI. Let me know if there's something else specific that you had in mind?

I think that's it.  Mostly it'll be good to know what the support level is if we end up moving to one of the open-source forks.


[CHORE] Add usr msg for df.explain(show_all=True)

Suggestion to add a line to highlight show_all=True to get more info about dataframe incl. num_partitions.
CONTEXT:
with Dask I'm used to calling df (without a compute/collect) to get a sense of my dataframe structure. I particularly like seeing how many partitions I have. Screenshot below to compare outputs.

I made a suggestion here based on the assumption that we'll want to keep df and df.explain(show_all=False) away from running the optimizer. Instead we could point people to df.explain(show_all=True) as the place to get a birds-eye view of their dataframe layout. Thoughts welcome!

Seems fine to me, could you also share a screenshot of the outputs after the change?

Bump on this @avriiil !


[windows] Allow only exe capitalization in tests.

Clang 8 or 9 seems to have changed from EXE to exe. Allow the new
capitalization (which is not important in Windows).
With these changes, there will still be failures in:

IRGen/multithread_module.swift: Failure during linking.
Driver/driver-compile.swift: An uppercased path is lowercased in the output.
Driver/options.swift: The swift.exe driver cannot find a valid stdlib (while swiftc.exe can).

With https://github.com/apple/swift/pull/27475
@swift-ci please test Windows platform

I don't think the code is being built with the previous PR, so it will fail building LLDB.

@swift-ci please test Windows platform

FWIW, I'm in favour of just dropping the capital.

@swift-ci please smoke test

@swift-ci please test Windows platform

@swift-ci please test Windows platform

@swift-ci please test Windows platform

From the last Windows testing:
Failing Tests (3):
    Swift(windows-x86_64) :: Parse/confusables.swift
    Swift(windows-x86_64) :: IRGen/multithread_module.swift
    Swift(windows-x86_64) :: Driver/driver-compile.swift

I was expecting options.swift which fails for me locally, and I wasn't expecting confusables.swift, which doesn't. I think this can be merged and we can deal with the rest in different PRs as we find solutions.
PD: I also removed the uppercased EXE from the code.

@swift-ci please smoke test

@swift-ci please smoke test Linux platform

@swift-ci please test Linux platform

Build failed
Swift Test Linux Platform
Git Sha - 02d32f62e7863736b59231d08b257b7385b4671f

@swift-ci please smoke test Linux platform


09/09/2018 22:46 : Create Pull Request for branch prTesting_2018090922 -> master

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestCon.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


missing library which is actually present

Here is my jbuild file:
(executable
 ((name        Foo)
  (libraries (batteries email_message core_kernel ocamlnet))
  ))

Trying to build:
$ jbuilder external-lib-deps --missing Foo.o
Error: The following libraries are missing in the default context:
- vcardgen
Hint: try: opam install ocamlnet

But the package is already installed!
$ opam install ocamlnet
[NOTE] Package ocamlnet is already installed (current version is 4.1.4).

ocamlnet is an opam package, not a findlib library. You need to specify which ocamlnet libraries you are using. Here's the list:
dra@zesty64:~$ ocamlfind list | fgrep 4.1.4
equeue              (version: 4.1.4)
netcamlbox          (version: 4.1.4)
netcgi2             (version: 4.1.4)
netcgi2-plex        (version: 4.1.4)
netclient           (version: 4.1.4)
nethttpd            (version: 4.1.4)
netmulticore        (version: 4.1.4)
netplex             (version: 4.1.4)
netshm              (version: 4.1.4)
netstring           (version: 4.1.4)
netstring-pcre      (version: 4.1.4)
netsys              (version: 4.1.4)
netsys.outofheap    (version: 4.1.4)
netunidata          (version: 4.1.4)
rpc                 (version: 4.1.4)
rpc-auth-local      (version: 4.1.4)
rpc-generator       (version: 4.1.4)
shell               (version: 4.1.4)


updating /etc/modprobe.d/*.conf requires initramfs rebuild after every change

Installing Nvidia-drivers has shown that the added config file /etc/modprobe.d/nvidia.conf is being ignored. nouveau is still being loaded even though its blacklisted. Currently, blacklisting modules requires grub cmdline additions. modprobe.blacklist=nouvaeu until you rebuild the initramfs.
finalize.yaml should require:
mos kernel gi --all --grub --set-links
this will rebuild initramfs to include new driver modules and update modprobe config rules.

Additionally, Nouveau should be a separate package as nvidia is.
Ideally, blacklisting should have been enabled in the kernel, right?


BUG: scalar operations with np.nan result in Stairs instance with wrong internal representation

[ ] I have checked that this issue has not already been reported.

[ ] I have confirmed this bug exists on the latest version of staircase.

Note: Please read this guide detailing how to provide the necessary information for us to reproduce your bug.
Code Sample, a copy-pastable example
s = sc.Stairs().layer(0,1)
assert (np.nan*s)._data is None
assert (s*np.nan)._data is None
assert (np.nan+s)._data is None
assert (s+np.nan)._data is None
assert (np.nan/s)._data is None
assert (s/np.nan)._data is None
assert (np.nan-s)._data is None
assert (s-np.nan)._data is None

assert (np.nan & s)._data is None
assert (s & np.nan)._data is None
assert (np.nan | s)._data is None
assert (s | np.nan)._data is None
assert (np.nan ^ s)._data is None
assert (s ^ np.nan)._data is None

assert (np.nan >= s)._data is None
assert (np.nan > s)._data is None
assert (np.nan <= s)._data is None
assert (np.nan < s)._data is None
assert (np.nan  == s)._data is None
assert (np.nan != s)._data is None

Problem description
The above should all pass, but several, if not all, do not.
This is the cause of #87

fixed in commit eae333


Add PDF export

The web version of diagrams.net allows a PDF export, which is useful with LaTeX.

I am also missing the SVG and PNG export features available in the web version. It would be great if these were supported.

need svg export too.

Would love export functionality.


Name change broke Codepen pens

All the Codepen pens that were using https://unpkg.com/picodom or https://unpkg.com/picodom@latest are currently broken due to the name change. At this point this means the vast majority are broken. Surprisingly, I have two pens that use specific versions of picodom and those still work. By the way, https://unpkg.com/patchdom doesn't seem to work. Unpkg.com says the package doesn't exist.

Thanx, otherwise, congrats on the major upgrade.

picodom.js.org is down as well - you might want to make sure it redirects? with the correct status code - or you'll lose the juice. A lot of links and bookmarks out there already.

hmmm... problem want to rename the Redit.com/r/picodom as well.

@rbiggs Can't on reddit. 😓


Add new put_event for liveview 0.20.1 :live_temp

They renamed the private field again, It's now :live_temp. This PR adds support for that new key, while maintaining support for the two previous names.
Closes #11

Thanks you so much @dfalling! Released 0.2.2 with your fix.


Export reader state hook

Hey, I just made a Pull Request!

Exports useReaderState from techdocs so we can use the hook in our TechDocs addons. I would also be open to exporting TechDocsReaderContext if that is the preferred solution from the maintainers.
I was also unclear on best practices for the api-reports docs, so any feedback is appreciated!
:heavy_check_mark: Checklist

[X] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[X] All your commits have a Signed-off-by line in the message. (more info)

Awesome. We need this to be able to retry fetching techdocs metadata after the documentation is generated the first time.

Hey @ryan-hanchett, thanks for the PR!
Although I totally understand the need, I'm not sure this is the right approach.
See https://github.com/backstage/backstage/pull/15232 for a similar discussion.
In order to try to think of a better solution, can you describe your use case? I'm gonna be looking into how we can proceed with this in the coming days.

Hey @agentbellnorm - thanks for pointing me towards that other PR - it does look like we're facing similar issues (lack of shared state among techdocs components).
Our primary use-case is trying to access the content of the given techdocs page a user is on via an add-on to enable starring individual pages rather than an entire entity's docs, and we'd like to store the title (first h1, rather than the path) as part of the starred item.
Currently there's no real way for me (as a Backstage consumer) to easily tell when the ShadowDOM has finished loading (at least, none that I'm aware of, perhaps I've missed something obvious along the way 😓) which makes our add-ons behavior flakey at best (often times grabbing the content of the last page before the new one has fully rendered) or only working via some less-than-ideal workarounds.
Perhaps exporting the entire readerState hook is too heavy, I think our use-case would be solved by exposing the value of const {state} = useReaderState() as part of the existing useTechDocsReaderPage() hook, or at least something to signify when the content is fully rendered into the DOM, not just the entity's values.
Let me know if you have any questions, happy to close this PR and move this conversation to a single issue if that'd be easier to coordinate.


Could not supply the template Asciidoc Slide

I try to create slides, so I have tried "New template -> Asciidoc Slide (reveal.js)"
Unfortunately I get follwing error in the log, I think this has something to do with proxy here? I did not find any configuration for the proxy.
234620 [] ERROR c.kodedu.component.TemplateSubMenu - Could not supply the template Asciidoc Slide (Reveal.js)
java.net.ConnectException: null
	at java.net.http/jdk.internal.net.http.HttpClientImpl.send(HttpClientImpl.java:896)
	at java.net.http/jdk.internal.net.http.HttpClientFacade.send(HttpClientFacade.java:133)
	at com.kodedu.service.TemplateService.download(TemplateService.java:170)
	at com.kodedu.service.TemplateService.provide(TemplateService.java:87)
	at com.kodedu.component.TemplateSubMenu.lambda$templateMenuItemOnClick$4(TemplateSubMenu.java:74)
	at com.kodedu.service.impl.ThreadServiceImpl$1.call(ThreadServiceImpl.java:53)
	at javafx.graphics@20.0.1/javafx.concurrent.Task$TaskCallable.call(Task.java:1426)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:317)
	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:577)
	at java.base/java.util.concurrent.ThreadPerTaskExecutor$ThreadBoundFuture.run(ThreadPerTaskExecutor.java:352)
	at java.base/java.lang.VirtualThread.run(VirtualThread.java:305)
	at java.base/java.lang.VirtualThread$VThreadContinuation.lambda$new$0(VirtualThread.java:177)
	at java.base/jdk.internal.vm.Continuation.enter0(Continuation.java:327)
	at java.base/jdk.internal.vm.Continuation.enter(Continuation.java:320)
Caused by: java.net.ConnectException: null
	at java.net.http/jdk.internal.net.http.common.Utils.toConnectException(Utils.java:1053)
	at java.net.http/jdk.internal.net.http.PlainHttpConnection.connectAsync(PlainHttpConnection.java:224)
	at java.net.http/jdk.internal.net.http.PlainHttpConnection.checkRetryConnect(PlainHttpConnection.java:259)
	at java.net.http/jdk.internal.net.http.PlainHttpConnection.lambda$connectAsync$2(PlainHttpConnection.java:235)
	at java.base/java.util.concurrent.CompletableFuture.uniHandle(CompletableFuture.java:934)
	at java.base/java.util.concurrent.CompletableFuture$UniHandle.tryFire(CompletableFuture.java:911)
	at java.base/java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:510)
	at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1773)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
	at java.base/java.lang.Thread.run(Thread.java:1623)
Caused by: java.nio.channels.ClosedChannelException: null
	at java.base/sun.nio.ch.SocketChannelImpl.ensureOpen(SocketChannelImpl.java:202)
	at java.base/sun.nio.ch.SocketChannelImpl.beginConnect(SocketChannelImpl.java:786)
	at java.base/sun.nio.ch.SocketChannelImpl.connect(SocketChannelImpl.java:874)
	at java.net.http/jdk.internal.net.http.PlainHttpConnection.lambda$connectAsync$1(PlainHttpConnection.java:208)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:571)
	at java.net.http/jdk.internal.net.http.PlainHttpConnection.connectAsync(PlainHttpConnection.java:210)
	... 9 common frames omitted

I did not override it, it is "https://github.com/rahmanusta/Asciidoc-RevealJs-Demo".

Do you need to setup a proxy to connect github from a running app?

As already mentioned - I did not find configuration options for proxy in AsciidocFX.

In AsciidocFX installation folder there is a vmproperties.txt file. You should be able to configure the proxy through the vm settings.
These two should resolve proxy settings from the system.
-Djavafx.autoproxy.disable=false
-Djava.net.useSystemProxies=true

Other proxy settings can be seen here https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/net/doc-files/net-properties.html

Have tried this, but only with partial success.
The log shows now:
DEBUG => Downloading template from: https://github.com/rahmanusta/Asciidoc-RevealJs-Demo
DEBUG => Template provided: https://github.com/rahmanusta/Asciidoc-RevealJs-Demo

But there is no directory or file created for a slide. Similar happens for the other templates.
Have tried the following too without success:
-Djavafx.autoproxy.disable=true
-Dhttp.nonProxyHosts=<my confgiration>
-Dhttp.proxyHost=<my confgiration>
-Dhttp.proxyPort=<my confgiration>
-Dhttps.proxyHost=<my confgiration>
-Dhttps.proxyPort=<my confgiration>


RfE: Custom set project name for multi-module / multi-project Maven builds

We do have typical builds with mvn -am -pl <project list>: Several modules from a multi-module build would be build then including their dependent modules. For this case it would be hard to derive a proper project name. In multi-module builds we do have many entries in the scan list, all with the same top level project name. From my point of view a custom name would be great (e.g., something like -Dscan.build.name=...).

Interesting idea. For now, the solution is to use a custom value to define the build/project name.

Interesting idea. For now, the solution is to use a custom value to define the build/project name.


pre-installation of dependencies?

Hello,
I would like run some of the Snakemake workflows on an HPC system whose compute nodes do not connect to the internet. Currently, the workflows require downloading and installing the dependencies during the workflow itself. Is it possible to modify the Snakefile such that the programs (like minimap2, checkm etc.) can be downloaded and installed ahead of time? I can do that on a head node, and then submit the job to run on a compute node if no new downloads are necessary.
I realize this might be a substantial change to the code; if there are edits I could make to the Snakefile myself, I'd be happy to give that a try, but would love some guidance from the developers.
Thanks,
Nastassia

Hi Nastassia,
This should be relatively easy to do. The conda environments only need to be installed once (e.g., they do not re-install themselves each time the pipeline is run).
On the node with internet access, you can execute the snakemake file using the general command:
snakemake --snakefile Snakefile --configfile configs/Sample-Config.yaml --use-conda --conda-create-envs-only

The key flag to include is --conda-create-envs-only. This flag will allow you to download and install the conda environments without running any of the workflow rules. Once you have downloaded the environments, you should be able to execute the workflows from the non-internet nodes.
Please let me know if this works for your use-case.

Thank you Daniel, that worked great! I'm grateful there was a simple
solution.
On Wed, Nov 17, 2021 at 11:19 AM Daniel Portik @.***>
wrote:

Hi Nastassia,
This should be relatively easy to do. The conda environments only need to
be installed once (e.g., they do not re-install themselves each time the
pipeline is run).
On the node with internet access, you can execute the snakemake file using
the general command:
snakemake --snakefile Snakefile --configfile configs/Sample-Config.yaml --use-conda --conda-create-envs-only
The key flag to include is --conda-create-envs-only. This flag will allow
you to download and install the conda environments without running any of
the workflow rules. Once you have downloaded the environments, you should
be able to execute the workflows from the non-internet nodes.
Please let me know if this works for your use-case.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/PacificBiosciences/pb-metagenomics-tools/issues/12#issuecomment-971897057,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB3EEDJ24RJGW5JFHB5RKLLUMP54RANCNFSM5IHX5EEA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

--
Dr. Nastassia Patin
Postdoctoral Associate
Cooperative Institute for Marine and Atmospheric Studies
University of Miami/NOAA
Address:
AOML & SWFSC
8901 La Jolla Shores Drive
La Jolla, CA
92037

Happy to help! Please let me know if you encounter any other issues along the way. I'll go ahead and close this specific issue now.


Error when adding Connect to speaker group

Hi
Been testing your script as a daemon on my Sonolgy NAS, and noticed the following;
When adding the Sonos device (ZP90/Connect) controlling the Yamaha reciever to a new or existing group of speakers, starting with another Sonos device, the script fails to correctly identify the playstatus of the Yamaha-connected device. This does not happen if you create a group starting with the device connected to the reciever.
Is this a known issue? Can it be fixed?
Apart from this bug the script is worlking flawlessly.

I'll look into that, thanks for the heads up. The script does nothing much but wait for notifications from the Sonos devices, so this may be unfixable, but I'll have a try.

I just tried and cannot reproduce this. Here's what I do:

Start playing a tune in room 1 (Sonos 1)
Add room 2 (Sonos Z90/Connect with Yamaha Receiver) to the room 1 zone (grouping)
Press "Done"
=> The Yamaha connected to the room-2-Sonos switches on and starts playing.

Did I miss something? Please look into the log files to see what was recognized. Once the rooms are connected, the script produces these log lines
2015-04-15 16:33:35.347634 SONOS play status: PLAYING
Setting Yamaha MAIN:PWR to On (was: Standby)
Setting Yamaha MAIN:VOL to -20.0 (was: -30.5)
Setting Yamaha MAIN:SOUNDPRG to 5ch Stereo (was: Standard)
Setting Yamaha MAIN:INP to AV1 (was: HDMI2)

Yes, that's what I'm experiencing too. The bug only reveals itself if adding room 2 to a group from room1 while room 1 is paused. At the moment room 2 is added to the paused group the script logs this action as status: PLAYING, although music is in fact paused. And from that point on, no play/pause action in the group is picked up by the script.
2015-04-15 21:11:01.001976 SONOS play status: STOPPED   <=== Room 1 paused
2015-04-15 21:11:12.114505 SONOS play status: PLAYING    <=== This is logged at moment of adding room 2
Taking room 2 back out of the group solves the problem however, and the script returns to function properly.
It's not a major issue, but can sometimes be a little annoying.

Michael, I really appreciate you posting this script. It was exactly what I was looking for.
I'm also having the issue where a grouped Connect does not detect the play command, and can reproduce. I have to ungroup the Connect and then re-group into a group that is already playing for the script to see status changes.
Like the above comment, when you are in the error condition (by adding Connect to a paused group), the script simply does not log any Playing/status updates.
Can anything be done to the script to detect this condition, or is this an issue with soco?

I've looked into this and I'm afraid there's little I can do.
The problem appears whenever the Connect gets added to a group and is itself not the "master" of this group, meaning that the room with the Connect is not the one you add other rooms to, but the room with the Connect itself is added to another room.
It also doesn't matter whether the "master" room is paused or not. Even if is playing - subsequent play state changes of the group are not reported to the "non master" room subscribers (of which the sonos-monitor.py is one). This is probably due to the mesh architecture of the Sonos devices - the master room propagates just the music stream to its slaves, but not its states.
This is annoying, but the "solution" is simple: When grouping rooms, go to the room with the Connect in it and add the other rooms to this room, not the other way around.
Could you try - does this solve your issues?

I've looked further into this and, well ... there would be a way to solve this ...
But this would be a major rewrite. There is in fact a way to find out if the Connect is the slave in a group. One would have to re-subscribe to the group's master and listen to its events. Once the group is split, one would have to re-subscribe to the Connect again.
I'm currently looking into this.

Ok, last note: Unfortunately I cannot recognize if the group is split again - there is just no event triggered with the group master. So even if I would provide a fix, after splitting the group, one would be monitoring the wrong device -the group master- and the monitoring service would be pointless.
The only solution then would be to handle two subscriptions simultaneously - one steady one to the Connect and an eventual one to a possible zone master. But that would require a much more complicated logic and is beyond the scope of this little project.
Perhaps if I suffer from severe boredom in the future ...

Thanks for the info Michael – it’s at least very helpful to understand the issue so I can work around it.
A suggestion. How about an option to work in “promiscuous” mode? Power-on the receiver if any Sonos device started playing. Easier?

Not really. Handling multiple subscriptions simultaneously requires threading as waiting for an event blocks the individual thread. It's all possible but would result in an entirely different script :-)

I was wondering if any new solutions to this problem have presented themselves since the original finding?  Does SoCo offer any easy way to fix?  I'm experiencing this a lot as my Connect is almost always grouped with other rooms of my house.  Greatly enjoy the script when it works, though!

note: I've also modified (very poorly) your script to work with my Onkyo receiver.

No news from my side.
A related question to the crowd here: The Play-Pause-problem with this script only occurs when grouping the Connect to other Sonos players. But I have given this up completely, because there is an about 0.5 sec lag between the grouped players then, which makes the "synchronized" group sound horrible.
This is because Sonos cannot know or control the processing time of the receivers connected to the Connect. And unfortunately, one cannot determine the delay in the configuration of the Connect (which has been a feature suggestion for years).
In a nutshell: Grouping of the Connect doesn't work for me anyway. How come anybody wants this? ;-)

Wow, that's terrible.  I don't experience this as all.  Generally I'm always grouped with two other rooms in my house.  Is your connect behind or ahead of the other sonos units?  Could your AVR be tweaked to be in sync?

The Yamaha needs about 0.3-0.5 sec for processing (even in "direct" mode). So it's always behind.
And because of that I cannot tweak the sync on the Yamaha ("process faster!") side. It has to be done on the Sonos side.
But as a workaround, as a stated above, start the group from the Connect player and connect the other rooms to the Connect, not the other way around. This way, the Play-Pause-detection works.

@mlamoure would you provide your onkyo modifications?

@thehigherlife Sure.  I am not using this code any longer, but you are welcome to take a look.
sonos-monitor.py.zip


feat(nexus)!: set rate limit during asset registration

Description

Optionally set a rate limit during asset registration
axelarnet/evm CLI/tx hooks will be implemented in the module specific PRs

Todos

[ ] Unit tests
[ ] Manual tests
[ ] Documentation
[ ] Connect epics/issues
[ ] Tag type of change
[ ] Upgrade handler

Steps to Test
Expected Behaviour
Other Notes

I don't understand the point of this PR. It adds the limit to the signature, but never does anything with it

It's just changing the API. The PRs specific to evm and axelarnet will make use of it. Since they both depend on this I wanted to update the API first.


there is no return session

getCacheKey() don't work properly
Cache and cookies saved in the file, but it can't access. So I notice reconnect after query, it's no sense to use savesession();
https://github.com/postaddictme/instagram-php-scraper/blob/71b85009f514c2c71bad52c9e4b767c29fc373c2/src/InstagramScraper/Instagram.php#L1647

Ok, I fixed it by adding a path to the project folder, but there are 3 queries for 1 query - getAccount
I mean phpfastcache keep my session by previous query, but after the next run, it does 3 queries again instead 1.

@fastcd Can you create a pull request to fix it?

@fastcd Can you create a pull request to fix it?

I use @aporat branch, https://github.com/postaddictme/instagram-php-scraper/pull/768
It's working well, but the session lives only  15 minutes. And he removed TwoStepVerification..

I dont have any issues with short sessions. Are you sure you're setting TTL on the cache?
$instance_cache = CacheManager::getInstance('Files', new Config([
  'path' => realpath(__DIR__.'/../../../storage/app/'),
  'defaultTtl' => 0
]));

I removed TwoStepVerification because it didn't login at all for me and the code associated with it was hard to work with.

I dont have any issues with short sessions. Are you sure you're setting TTL on the cache?
$instance_cache = CacheManager::getInstance('Files', new Config([
  'path' => realpath(__DIR__.'/../../../storage/app/'),
  'defaultTtl' => 0
]));

I removed TwoStepVerification because it didn't login at all for me and the code associated with it was hard to work with.

Thank you, it helped me!
Did you try to debug TwoStepVerification? I explored that Instagram requires the two-step auth after 300-500 queries to profiles.


[SPARK-7128][ML] Bagging (bootstrap aggregating) ensemble method

Categorical is ~7x slower, suggestions on speeding up the SQL are appreciated

Merged build triggered.

Merged build started.

Test build #42063 has started for   PR 8618 at commit 040798f.

Test build #42063 has finished for   PR 8618 at commit 040798f.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42063/
Test FAILed.

Merged build triggered.

Merged build started.

Test build #42068 has started for   PR 8618 at commit a7aa159.

Test build #42068 has finished for   PR 8618 at commit a7aa159.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/42068/
Test PASSed.

@feynmanliang I don't think we'll be able to get this merged soon b/c of limited review bandwidth, but please don't delete the branch since it's something we'd eventually want.  Could you please close this issue for now?  Thanks!


Switch to single-process (uvicorn) container

Closes #282

Remove gunicorn from the containerized deployment
Turns Prometheus metrics on by default
Makes the multiprocess mechanism in Prometheus (the memory-mapped files) optional, off by default
Simplifies Dockerfile
Moves the code that checks for scalable config settings out of a one-off script and into the CLI as --scalable

I think this is a great simplification. Gunicorn was seen as a necessary step to acheive scaling, but the realization that even docker-compose can easily perform round-robin load balancing lets us take a lot of complexity out of containers and into the deployment, where it belongs.
It is truly sad that podman-compose doe not achieve this out of the box. In that case, one could imagine a gunicorn container and multiple tiled containers to achieve horizontal scaling.


Switch to fixed version of pretext graph

Found an error in pretext graph's wrapper, fixed but didn't update the version, so switching out for fixed wrapper
Installation sequence for tool-installers

[ ] Test using @galaxybot test this
[ ] Inspect CI output for expected changes
[ ] Deploy using @galaxybot deploy this if test install was successful
[ ] Merge this PR

@galaxybot test this

@galaxybot deploy this


rows_affected not returned by adapter

I am using the dbt artifacts package for monitoring ETL runs, dbt artifacts supports logging the number of rows affected but requires the adapter to return this information, currently it seems that the dbt-databricks adapter doesn't return this info in the result object hence the column is empty.
Is it possible to return this information for all materializations where data is persisted (atleast the table and incremental materializations?)

What would be the timeline for this feature to become available. Having insights in the rows_affected on persisted tables (materialization = table or incremental) is key to:
-understand if the result of the model doesn't accidentally load incorrect/duplicated data due to incorrect logic in the model.
-what data volume is processed and to identify growth in data volume over time
A possible solution direction (but maybe there is a smarter, more efficient and secure wat to accomplish)?
Databricks creates delta lake tables by default, delta lake tables preserve the history of CRUD operations executed on the table.
For a table materialization the number of rows affected can be fetched by performing the following steps:
DESCRIBE HISTORY schema.table_name
Get the last record where column operation = 'DESCRIBE HISTORY x239_int.campaign'
Get the number of rows written from column operationMetrics ->  numOfOutputRows

For an incremental materialization the number of rows affected can be retrieved the same way as for a table materialization but the the column operation should be equal to WRITE or MERGE depending if the incremental strategy is append, insert-overwrite or merge. The number of rows affected can be retrieved from the operationMetrics column as well.
The logic above should be executed directly after the execution of the SQL or Python code defined in the DBT model.

Hi,
Is there any chance that this feature gets planned in upcoming releases?
Thanks!

Hi @benc-db. Thanks for your feedback. Sorry if my comment sounded as a request -- it was not. Should I need it much sooner, I will definitely look into contributing! And thank you for the adapter, it is very useful.


Use Hopac

Since default F# Async is well known of its bad performance, one of the possible optimizations may be using Hopac library instead (which is already used in projects such as Suave or Logary).

First change would be to replace Async<_> with Job<_>. As almost entire internals are hidden, we could convert them all to Hopac, but use Async<_> only in top-level functions (which are Schema.AsyncExecute and FieldDef.Resolve) and check the performance.
As there is no direct replacement of Async.Parallel in Hopac, we would need to think about optimal way of replacing it using existing primitives.
Also in many cases we don't need to use async version of FieldDef.Resolve, however it's still necessary for compatibility reasons. We need to investigate if Hopac has some equivalent of value jobs - optimized, immediately returned objects, compatible with Job<_> class.

Update
Hopac has been introduced, but as mentioned in #44 , there is a problem with thread locking inside Hopac itself. Need to investigate that further.


Help command bug

In the jar release
If i type the help command multiple times after i open help, App cannot be shutdown.
Multiple instances of help will appear each time i close each help.

Fixed in commit https://github.com/CS2103AUG2016-W11-C2/main/commit/12ac24c5b2061db99540b84bc17bfebaf7738d2f


Events on iOS includes spurious Resource notice

On iOS event in feed, the notice "RESOURCE ENDS SEP 13, 2020" is given

Closing as covered in upcoming Events on Mobile implementation and tracked here: https://github.com/Hylozoic/HyloReactNative/issues/335


[FLINK-30449][sql-gateway] Introduce ResultInfo to improve the serialization and deserialization of FetchResultsResponseBody

What is the purpose of the change
Currently, the REST endpoint serialize and deserialize the ResultSet in the FetchResultsResponseBody. But many information of ResultSet will be also put in the FetchResultsResponseBody, so it's not a good way. I propose to introduce a ResultInfo to replace the ResultSet in the FetchResultsResponseBody.
Brief change log

Add ResultInfo in sql gateway.
Add ResultInfoJsonSerializer and ResultInfoJsonDeserializer and test.
Remove useless ser/de code of ResultSet.

Verifying this change
This change added tests and can be verified as follows:

ResultInfoJsonSerDeTest.
SqlGatewayRestEndpointStatementITCase.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): yes
The serializers: yes
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? yes
If yes, how is the feature documented?  JavaDocs

I add a commit to improve the codes. @yuzelin Please take a look.

@fsk119 thx, LGTM. I have added a bytes case to the resultInfo.txt.


Should ocpsvg have a tolerance parameter?

I don't know the right answer to this problem, but wanted to bring to your attention in case it is best to fix here.
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<svg
   width="187.80397mm"
   height="190.72836mm"
   viewBox="0 0 187.80397 190.72836"
   version="1.1"
   id="svg1"
   xml:space="preserve"
   xmlns="http://www.w3.org/2000/svg"
   xmlns:svg="http://www.w3.org/2000/svg"><defs
     id="defs1" /><g
     id="layer1"
     transform="translate(-10.064523,-56.933011)"><g
       id="g1"><ns0:path xmlns:ns0="http://www.w3.org/2000/svg" id="path5" style="fill:#f7f8f8" d="M 104.11876,56.934021 C 63.736597,56.737648 25.41552,85.182615 13.677255,126.80417 c -16.0876352,57.04356 23.474457,116.30107 80.550639,120.65207 5.762765,0.4393 20.717906,0.12691 23.944796,-0.50023 29.53134,-5.73943 50.78323,-20.45287 66.04713,-45.72692 4.31274,-7.14105 7.72319,-15.32478 10.39678,-24.94783 13.17482,-47.42016 -14.87779,-98.88564 -62.53934,-114.734601 -3.61363,-1.201644 -4.26535,-1.369129 -10.59728,-2.729549 -5.78154,-1.242168 -11.59234,-1.855036 -17.36122,-1.883089 z" /></g></g></svg>

The above SVG results in the following behavior in build123d:
from build123d import *
b = import_svg('circle.svg')
len(b.vertices()) # returns 9

Looking at b.vertices() there are two nearly identical duplicate vertices:
[Vertex: (94.05428778934001,<PHONE_NUMBER>9296872, 0.0),
...
 Vertex: (94.05428778938001,<PHONE_NUMBER>931684, 0.0)]

Should ocpsvg have a tolerance parameter to merge these vertices, or should this be done at the build123d level somehow?

I'd feel more comfortable if that was handled on either side of ocpsvg (preprocessing to "fix" the SVG or post-processing to "fix" the OCC curves).
We have to use a tolerance parameter when converting from OCC to SVG because some curves types need to be approximated; but when going from SVG to OCC I think it's fair that ocpsvg gives you the curves as the SVG actually describes them.
I'm assuming in this case the first and last vertices don't line up because of the drift from the relative coordinates, in which case I'm going to claim "not a bug; won't fix"

According to inkscape there are only 8 nodes, yet I think ocpsvg is returning a shape with 9 vertices.

looks like the path does have 9 vertices though
M 104.11876,56.934021
C 63.736597,56.737648 25.41552,85.182615 13.677255,126.80417
c -16.0876352,57.04356 23.474457,116.30107 80.550639,120.65207
   5.762765,0.4393 20.717906,0.12691 23.944796,-0.50023
   29.53134,-5.73943 50.78323,-20.45287 66.04713,-45.72692
   4.31274,-7.14105 7.72319,-15.32478 10.39678,-24.94783
   13.17482,-47.42016 -14.87779,-98.88564 -62.53934,-114.734601
   -3.61363,-1.201644 -4.26535,-1.369129 -10.59728,-2.729549
   -5.78154,-1.242168 -11.59234,-1.855036 -17.36122,-1.883089
   z

I guess the question is how the z command is handled and whether it should merge the first and last vertices.
I do have a tolerance for that internally (https://github.com/snoyer/ocpsvg/blob/main/ocpsvg/svg.py#L353) but if I remember correctly I hardcoded just small enough to avoid issues with OCC (ie. not create excessively short closing segments that would upset OCC).
In this case it looks like the accumulated error is higher that my empirically derived 1e-10 so the z command will add a segment to connect to the start and the last vertex will not be the starting vertex
>>> a = complex(94.05428778934001,<PHONE_NUMBER>9296872)
>>> b = complex(94.05428778938001,<PHONE_NUMBER>931684)
>>> abs(a-b)
2.0365842040460295e-10

I'll double check by actually running some code later.
Regardless, technically I could expose that parameter all the way up the call chain to the user entry-point but I still think that could and should be done after the fact on the OCC wires instead.

@jdegenstein, it looks like this issue got (accidentally!) fixed since you first brought it up, could you confirm?

@snoyer yes I can confirm this issue is now resolved, thanks for checking back on it! closing issue.


Handle literal ranges the same way we handle other literal generics

Motivation
Currently, literal ranges are desugared into calls to Range.new for historical reasons:

@elliottt:
yes, i think it's sort of accidental that Range.new has a more precise type right now
looking at when it was first introduced, it was before generics existed in sorbet
so i think it was just code-modded forwards, while types like Array and Hash got more attention

This means that the type of literal ranges is determined by the Range.new signature which uses the type of the first argument.
This behaviour is 1) incoherent with other bare generics initialized through new:
T.reveal_type(Hash.new(a: 1, b: 2)) # Revealed type: T::Hash[T.untyped, T.untyped]
T.reveal_type(Array.new(1, 2)) # Revealed type: T::Array[T.untyped]
T.reveal_type(Range.new(1, 2)) # Revealed type: T::Range[Integer]

And 2) it's also brittle and leads to wrong types being inferred:
T.reveal_type(Range.new(1)) # Revealed type: T::Range[Integer(1)]

^ it's not a range of literal 1s, it's a T::Range[Integer].
This pull request changes the way we handle literal ranges to use a similar approach than for literal arrays and hashes:

literal ranges are kept in the tree instead of being desugared away as Range.new
The range initialization is rewritten into a Magic#buildRange
The magic is used to attach an intrinsic for the return type figuring the return type

There is also two changes related to ranges:

Removing the duplicated signature for Range::new and keeping only Range#initialize
Fixing the test for incorrect T::Range[Integer(1)]

This will also be fixing the behaviour of the T::Range[NilClass] discussed in https://github.com/sorbet/sorbet/pull/3313#discussion_r459127000 once https://github.com/sorbet/sorbet/pull/3313 is merged.
Test plan

See included automated tests.

@elliottt from our discussion I though we wanted them to be handled exactly the same way than other generics.

Could you remove the Range tree node, and switch to constructing the buildRange intrinsic directly in Desugar.cc

Yes, I dropped that commit and updated the expected desugar trees accordingly. The rest is unchanged.

@elliottt from our discussion I though we wanted them to be handled exactly the same way than other generics.
What I had meant there was that we should rely on the use of the constructor from T::Range[...] to propagate type information. I don't think that I made the approach I was thinking of clear enough, sorry for leading you down the wrong path there!

Yes, I dropped that commit and updated the expected desugar trees accordingly. The rest is unchanged.
Thanks! I'll re-review this today.

@elliottt I integrated your suggestions 👍
About the error: it seems that real world examples with different bounds can be used correctly:
(Time.now.utc - 2.hours)...Time.now.utc
                           ^^^^^^^^^^^^ # error: Range with incoherent bounds: Float and Time

 (Time.now .. Date::Infinity.new)
              ^^^^^^^^^^^^^^^^^^ # error: Range with incoherent bounds: Time and Date::Infinity

@elliottt I integrated your suggestions 👍
About the error: it seems that real world examples with different bounds can be used correctly:
(Time.now.utc - 2.hours)...Time.now.utc
                           ^^^^^^^^^^^^ # error: Range with incoherent bounds: Float and Time

 (Time.now .. Date::Infinity.new)
              ^^^^^^^^^^^^^^^^^^ # error: Range with incoherent bounds: Time and Date::Infinity

In this case is there a subtyping relationship between the bounds? Maybe we can reformulate the use of Types::equiv to a more permissive subtyping relationship?

In this case is there a subtyping relationship between the bounds? Maybe we can reformulate the use of Types::equiv to a more permissive subtyping relationship?

Let's discuss about this in another PR. I think the same test should be applied at least for T::Range.new, maybe also for Range.new.

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR.  When the build
finishes, I'll share with you whether or how it failed. Thanks!
Stripe employees can see the build result here:
→ https://go/builds/bui_HuHJEeifJ8pnZ9

This will require a few internal changes to land -- I'll make them and then merge this PR.

Could you rebase this PR on master?

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR.  When the build
finishes, I'll share with you whether or how it failed. Thanks!
Stripe employees can see the build result here:
→ https://go/builds/bui_HzB7Aga9620ibn

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR.  When the build
finishes, I'll share with you whether or how it failed. Thanks!
Stripe employees can see the build result here:
→ https://go/builds/bui_HzDovrFYTmKRrs

Passing build on stripe CI: https://go/builds/bui_HzEICOkVebYcTX


Arnej/add uptime metric for sentinel

@hakonhall please review and merge
this ensures the "sentinel.restarts.count" metric will have a bump at sentinel restart,
and also adds a "sentinel.uptime" metric that may make it easier to see disparity between nodes when graphed.
@ldalves FYI

great! thanks @arnej27959

Differentiating between 0 and the config sentinel being down can already be done in Yamas, and adding 1 may be confusing for a metric named 'restarts'.
https://yamas.ops.yahoo.com:4443/#/ws/DrF74V/tim

The metric named "restarts" should count "yinst restart", that is the feature request...


Add default rails form support

Could you add for default rails form support. It is really unnoying to install formtastic in order to use this gem.

+1

+1

:+1:

+1

+1


WebSocket Error 400

I've installed it by mup on a fresh Digital Ocean instance. On the browser client side, there is an error  Error during WebSocket handshake: Unexpected response code: 400

Does the error affect the app in any way?

Getting the same error on a fresh Digital Ocean install too.
WebSocket connection to 'ws://<IP_ADDRESS>/sockjs/594/fwuotuhc/websocket' failed: Error during WebSocket handshake: Unexpected response code: 400


Add method for validating the go2rtc server version is supported

Proposed Changes
Add method for validating the go2rtc server version is supported
Related Issues

We need to rebase here now. Let's merge after that.


Rendering the first page sooner

Hi
I have some "big" PDFs (~130-180pag, 5-70MB), that do not start rendering until the file is completely downloaded or almost completely. This means that the first page renders (on a fast computer with a 50mb downlink) after 10-30 seconds. The viewer does ~30 requests, most are exactly 64kb in size

It'd be lovely if pdf.js could be able to render the pages upon arrival. Maybe I'm doing something wrong on my end?
Currently using PDFJS.version = '1.1.469';
Edit: The timings don't change if I "linearize" the pdf with pdfopt.

Please provide PDF that correspond to the figure above. Also browser kind and its version.
It normal to really "fragmented" and non optimized for web PDF to have multiple range request: for header, tralier and xref, and for page and its resources. Based on the figure above it only means either the PDF document is too framented (all the needed data located in different parts of file) or PDF is corrupted and PDF.js is trying to recover it.

Sure. This is the file https://curso.especificosba.com.ar/pdfs/Clase8.pdf
I'm accessing the file through the viewer: https://curso.especificosba.com.ar/js/ViewerJS/#../../pdfs/1448045373_Clase8.pdf
On Firefox 43, Linux

If I may add a bit. This PDF file really is weird. It doesn't display in the viewer on the given link, and when opened in Chrome PDF viewer it also took ages to render.  It took longer than anything I ever opened in Foxit Reader on Windows too.

It does display, after 98 requests and 28s. On mupdf/okular on linux, the file displays immediately

On mupdf/okular on linux, the file displays immediately

Assuming that you are comparing loading locally downloaded file with network hosted one, could you also post how long it take to open using pdf.js if file is located locally?

Hosting it locally with SimpleHTTPServer takes about 6-7 seconds to render. Even after refreshing (the request shows the pdf is cached already)

Hosting matters. It looks like your hosting (using nginx?) delays every request by 300-900 ms! I tried to host the same file at my remote server:

I'm receiving response within seconds. Check your deployment on different servers. Keeping this issue opened just to see if we can reduce amount of requests or abandon range requests for badly deployed solutions.

with SimpleHTTPServer takes about 6-7 seconds to render.

SimpleHTTPServer cannot not handle range requests and cannot handle resource requests in parallel.

I'll see if I can modify the behavior of nginx, it might be because the server is 10 thousand kilometers away (latency is always ~200ms)

SimpleHTTPServer cannot not handle range requests and cannot handle resource requests in parallel.

nginx locally, completing all requests takes 2.5s and rendering takes 7s after that. This is on a Core 2 Duo at 2.4ghz

How much time it takes to render if you open your file using "Open File" button at http://mozilla.github.io/pdf.js/web/viewer.html ?

It's instant. In my tests I'm using ViewerJS (that uses pdf.js)

In my tests I'm using ViewerJS

Older version of PDF.js (1.1.469) is used there. However I suspect that nginx cannot handle range requests (for big files?). Can you try different web server?

@DavidVentura also, not sure if ViewerJS start displaying after it gets first page or it waits for all pages to be loaded. But that's question for the ViewerJS vendor.

nginx supports  byte ranges: http://nginx.org/en/docs/http/ngx_http_core_module.html#max_ranges
I can't install another webserver atm. I'll use pdf.js and comment the results here

Ok.. I just cloned the website you linked and works instantly on localhost. I'll upload it to the server and close the issue if it was ViewerJS all along

Ok..
https://curso.especificosba.com.ar/js/pdfjs/web/viewer.html?file=../../../pdfs/1448045373_Clase8.pdf
Renders within 2-3 seconds, makes the same amount of requests and takes the same time to download the entire file( which was what I expected, even if I think >100 requests to download a 7mb file is a lot) , but there's almost instant rendering of the first page. Excellent!


Wrong path in usbimager

Issue description
When installing usbimager the path in the desktop file is /usr/bin/usbimager, so when you try to open the application it doesn't open, to fix it you have to copy the desktop file from /run/current-system/sw/share/applications/usbimager.desktop to ~/.local/share/applications and edit the desktop so it reads Exec=usbimager
Steps to reproduce
Install usbimager, try to open the application from your menu, at least this is the behaviour on xfce, I've not tested it on other desktop environments
Technical details

system: "x86_64-linux"
host os: Linux 6.8.7, NixOS, 24.05 (Uakari), 24.05pre615930.572af610f615
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.18.2
channels(root): "nixos"
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

Does it work in a nix-shell?
nix-shell -p usbimager
usbimager
Worked perfectly for me on hyprland.

It works in a shell, it also works when installed system wide when you launch it from a terminal, its when you try and launch it from a menu like xfce's whiskermenu it doesn't launch, because the desktop file has Exec=/usr/bin/usbimager


Windows and Linux versions?

Hi, this is a cool app. Any chance you might release this for GNU/Linux and/or Windows?

Hey, I'd love to but there are some dependencies the app uses that for some reason don't work on Windows or Linux. I'll let you know here if anything changes :)


[SPARK-23182][CORE] Allow enabling TCP keep alive on the master RPC connections.

What changes were proposed in this pull request?
Make it possible for the master to enable TCP keep alive on the RPC connections with clients.
How was this patch tested?
Manually tested.
Added the following:
spark.rpc.io.enableTcpKeepAlive  true
to spark-defaults.conf.
Observed the following on the Spark master:
$ netstat -town | grep 7077
tcp6       0      0 <IP_ADDRESS>:7077       <IP_ADDRESS>:42851       ESTABLISHED keepalive (6736.50/0/0)
tcp6       0      0 <IP_ADDRESS>:44911      <IP_ADDRESS>:7077       ESTABLISHED keepalive (4098.68/0/0)
tcp6       0      0 <IP_ADDRESS>:7077       <IP_ADDRESS>:44911      ESTABLISHED keepalive (4098.68/0/0)
Which proves that the keep alive setting is taking effect.
It's currently possible to enable TCP keep alive on the worker / executor, but is not possible to configure on the master. It's unclear to me why this could be the case. Keep alive is more important for the master to protect it against suddenly departing workers / executors, thus I think it's very important to have it. Particularly this makes the master resilient in case of using preemptible worker VMs in GCE. GCE has the concept of shutdown scripts, which it doesn't guarantee to execute. So workers often don't get shutdown gracefully and the TCP connections on the master linger as there's nothing to close them. Thus the need of enabling keep alive.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Is it possible that TCP keepalive is disable by kernel, so that your approach cannot be worked? I was thinking if it is better to add application level heartbeat msg to detect lost workers?

For completeness it should be possible to enable OS-level TCP keep alives. The client does enable TCP keepalive on its side and it should be possible on the server too.
However, independent of that it perhaps makes sense to also have application level heartbeats because in the JVM it seems it's not possible to tune the timeouts of TCP keepalive.

Any update?
We have rolled out our Spark clusters with this change and it seems to be working great. We see no lingering connections on the masters.

cc @squito @vanzin
Can you please comment on this PR?

this is just far enough outside my expertise I don't have an opinion -- but @zsxwing might have some thoughts

Can one of the admins verify this patch?

Is there any downside to enabling keepalive? should it be on by default, or always? seems OK to me.

Test build #4475 has started for PR 20512 at commit c5e2d98.

Test build #4475 has finished for PR 20512 at commit c5e2d98.

This patch fails Spark unit tests.
This patch does not merge cleanly.
This patch adds no public classes.

I don't think there is, but didn't want to change the default behavior.

Ignore the test failure for now, I think it's unrelated.
For Spark 3, I think we can make the default 'true' and leave this as a safety valve, if this is probably what people want to set always.
For back-porting to Spark 2.x, we could then open an identical PR that sets it to false.

Test build #4483 has finished for PR 20512 at commit c5e2d98.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

I pinged some people offline who know more about networking to take a look at this. It might take a while before they can due to holiday schedule though.


Getting this ported/working on Linux

"If you for some reason do want to build it on Linux or something feel free to get in touch I am happy to help point out what bits of the codebase are non-portable and what could be done."
Soooo...what bits of the codebase are non-portable and what can be done?
If it's relevant what my system is:
Distro -->        Ubuntu 18.04.1 LTS
Kernel -->      4.15.0-33-generic
Graphics -->  Nvidia GTX 750TI with 396.51
gcc -->          version 7.3.0 (Ubuntu 7.3.0-16ubuntu3)

Hi, there shouldn't be too much that is non-portable. There are still probably a couple headaches though, the big one being DirectXTex which I'll explain after going through the easy stuff.
Firstly I'm lazy. And by that I mean I couldn't be bothered to use include guards and just used #pragma once. You're not wanting to compile this on some esoteric platform though so that shouldn't be a problem, I believe all major C++ compilers carry it as an extension.
Next the tool uses memory mapped files. I suspect it should be quite simple to create an implemntation of mapped_file that uses Linux apis.
The codebase has one unsafe use of reinterpret_cast in view_type_as that causes undefined behaviour. On Windows the desired thing always ends up happening so I never bothered to fix this. But I did abstract it away into a function so it could be replaced with a call to memcpy later if needed. However in all my great wisdom I stupidly made the return type be a reference, which obviously won't work  with a memcpy.
Thankfully the return type is const so switching it away from a reference should be fairly simple and only as far as I know only two call sites depend on the result being a reference. Them being Ucfb_reader::read_trivial and Ucfb_reader::read_array respectively. I don't know how much (if any) code depends on the return type of read_array being a gsl::span instead of container but I imagine it shouldn't be too much. The real shame is that performance would be lost on having to do a heap allocation each time an array is read, but the tool seldoms takes long to run so that is probably moot.
It would probably be quicker to just pass -fno-strict-aliasing (I think that's it at least) to GCC and move on with life.
The hard part will be dealing with the dependencies. As far as I know glm and tbb should just build and work on Linux. DirectXTex however won't, not without a lot pain and tears at least. That means save_image, handle_texture, handle_texture_ps2 and handle_texture_xbox will have to be rewritten using a different library for image saving or removed outright. main.cpp also contains the function calls for initalizing COM that DirectXTex needs.
I'm not very familiar with imaging libraries but gli and libpng seem like they could be used together as a viable replacement. I'd probably personally just stub out the texture functions and focus on porting the rest of the tool first in any event.
I think that is about that. As I said the dependency on DirectXTex is probably the biggest hurdle to overcome. If you do end up trying to build it on Linux a go feel free to let me know what problems you encounter, I'd be curious to know what mistakes I made and how I could've written it to be more portable.