remove obsolete patch for exact-image

The include guard that was added by this patch has already made it
upstream. So it is not needed anymore.
Signed-off-by: Heiko Voigt<EMAIL_ADDRESS>

Remove all the references to the patch, not just the patch itself :)

Just saw that myself when preparing another formula. Fixed, hopefully :)

Thanks for the tip/patience! As you can probably tell, I am not a ruby specialist... just trying to fix an installation issue for me. Updated. Now the integration test still fails because of a SSL certificate error when trying to checkout from the SVN. Is that ok?

No worries! The syntax can take a little while to grasp. It looks like the SVN repo upstream may be having some issues, the SSL cert gets rejected, but if you drop to HTTP instead of HTTPS you get this:
svn: E175013: Unable to connect to a repository at URL 'http://svn.exactcode.de/exact-image/trunk'
svn: E175013: Access to 'http://svn.exactcode.de/exact-image/trunk' forbidden

Same thing happens when you use the svn:// protocol instead. Might be an upstream issue.

It seems like it is a new upstream problem, since the tests yesterday still passed and I did not change the url. While at it, added a commit to removing all the unnecessary require 'formula'. It looks good but I do not know how to test this thoroughly. I hope the testsuite would catch if I made a mistake right?
Will send a mail to the exact-image mailinglist whether this is intended or will be fixed.

Might just be a temporary connection problem upstream. It happens.

While at it, added a commit to removing all the unnecessary require 'formula'

This was dedication, but I don't know if the maintainers here will accept it. Generally "style-only" changes aren't accepted because users get notified about each formula update when they brew update, so a sudden wad of changes can look overwhelming :smile_cat:. But yes, the bot will point out any errors :+1:.

While at it, added a commit to removing all the unnecessary require 'formula'

This was dedication, but I don't know if the maintainers here will accept it. Generally "style-only" changes aren't accepted because users get notified about each formula update when they brew update, so a sudden wad of changes can look overwhelming :smile_cat:. But yes, the bot will point out any errors :+1:.

Well it was a quick change if you know your editor (took me less than 5 minutes). I thought it would be nice for others, like me, so they do not copy from a source that still has it and you have to tell them to remove it. But I can imagine that a user might be concerned by a change like this. Removed the extra file changes.

Ok I got an answer from the developers. They are using a cacert certificate. Is it a feasible solution to add the cacert root certificate (http://www.cacert.org) to the build bot?

Sadly, probably not. Adding root certificates is a fairly dangerous game, and beyond that, given the way the bots are set up in terms of VM's at the moment, a nightmare to implement. @mikemcquaid is the master of all things bot though; He'll know whether it's a go or not as an idea.

I just got a tip from from the developer that there are actually releases and why we are not using that. So I will open a PR over in the main repository with basically this formulae switched over to the tarball url.

And here is the PR https://github.com/Homebrew/homebrew/pull/38368

Nice! That works, especially if we can avoid using an unrecognised SSL/TLS cert. You can turn this PR into a PR to delete the formula here if you like.

Thanks. Done, hopefully. Just need to wait on the other pull request.


Immediate crash after opening a folder/file on manjaro KDE

I am using the snap version. whenever I open a folder, It immediately crashes

Can you run with code --verbose and see what error comes out?


Translations for Self Registration

[ ] Add Vue I18n Package
[ ] Replace all strings in Self Registration with I18n calls
[ ] Automatically choose the user language by browser settings
[ ] Language select button to switch language
[ ] Add English Translation
[ ] Add Turkish Translation
[ ] Add Arabic Translation

I would work on the setup in the project

@jonathangpk: Very important, but given the current timeline, I would like to de-prioritize this!


[SPARK-44128][BUILD] Upgrade netty to 4.1.93

What changes were proposed in this pull request?
This pr aims to upgrade netty from 4.1.92 to 4.1.93.
Why are the changes needed?
1.v4.1.92 VS v4.1.93
https://github.com/netty/netty/compare/netty-4.1.92.Final...netty-4.1.93.Final
2.The new version brings some bug fix, eg:

Reset byte buffer in loop for AbstractDiskHttpData.setContent (#13320)
OpenSSL MAX_CERTIFICATE_LIST_BYTES option supported (#13365)
Adapt to DirectByteBuffer constructor in Java 21 (#13366)
HTTP/2 encoder: allow HEADER_TABLE_SIZE greater than Integer.MAX_VALUE (#13368)
Upgrade to latest netty-tcnative to fix memory leak (#13375)
H2/H2C server stream channels deactivated while write still in progress (#13388)
Channel#bytesBefore(un)writable off by 1 (#13389)
HTTP/2 should forward shutdown user events to active streams (#13394)
Respect the number of bytes read per datagram when using recvmmsg (#13399)

3.The release notes as follows:

https://netty.io/news/2023/05/25/4-1-93-Final.html

4.Why not upgrade to 4-1-94-Final version?
Because the return value of the 'threadCache()' (from PoolThreadCache to PoolArenasCache) method of the netty Inner class used in the 'arrow memory netty' version '12.0.1' has changed and belongs to break change, let's wait for the upgrade of the 'arrow memory netty' before upgrading to the '4-1-94-Final' version.
The reference is as follows:
https://github.com/apache/arrow/blob/6af660f48472b8b45a5e01b7136b9b040b185eb1/java/memory/memory-netty/src/main/java/io/netty/buffer/PooledByteBufAllocatorL.java#L164
https://github.com/netty/netty/blob/da1a448d5bc4f36cc1744db93fcaf64e198db2bd/buffer/src/main/java/io/netty/buffer/PooledByteBufAllocator.java#L732-L736
Does this PR introduce any user-facing change?
No
How was this patch tested?
Pass GA.

This version has been released on the official website, but it is not yet available in Maven Repo. Let's wait for a moment. 😄

What I mean is that we may need to wait for the next arrow version to be compatible with the netty 4.1.94.Final

https://github.com/apache/arrow/blob/6af660f48472b8b45a5e01b7136b9b040b185eb1/java/memory/memory-netty/src/main/java/io/netty/buffer/PooledByteBufAllocatorL.java#L164
https://github.com/netty/netty/blob/da1a448d5bc4f36cc1744db93fcaf64e198db2bd/buffer/src/main/java/io/netty/buffer/PooledByteBufAllocator.java#L732-L736

What I mean is that we may need to wait for the next arrow version to be compatible with the netty 4.1.94.Final

Let's upgrade to the netty 4.1.93.Final version first. After arrow memory netty' completes the same upgrade, we will consider netty 4.1.94.Final again.

https://github.com/apache/arrow/pull/36211/files
arrow already upgrade Netty to 4.1.94.Final and this may be released in arrow 13.0,  I'm not sure if this is available because it also updates the grpc to 1.56.0, which is different from Spark Connect using a different grpc version
On the other hand, Netty 4.1.94 fixes a CVE https://github.com/apache/arrow/pull/36211, I want to know if this CVE will affect Spark?

friendly ping @srowen @dongjoon-hyun further review
I think we can upgrade to use netty 4.1.93 first, the versions greater than 4.1.94 need to wait for arrow-memory-netty to resolve compatibility issues and upgrade together.

I agree with you, @LuciferYang and @panbingkun , because 4.1.93.Final is the first release for Java 21 official support.

Thank you for working on this, @LuciferYang and @panbingkun !

FYI the next arrow-memory-netty release should be compatible with netty <4.1.94 and >=4.1.96. We plan to upgrade to 4.1.96 in arrow-memory-netty v13: https://github.com/apache/arrow/pull/36926


2.0.0 Checklist

Not actually a pull request.
Checklist

[ ] Playwright
[ ] Test and fix Badges feature (A big headache for me right now, because new table schemas breaks this feature a lots)
[ ] Migration guide from v1 to v2 (Wiki)

[ ] New Docker tags
[ ] Found out all breaking changes

[ ] Warns Debian/Raspbian Buster users

[ ] Benchmark
[ ] Write the changelog
[ ] Release 2.0.0-beta.0
[ ] Release 2.0.0-beta.1
[ ] ...
[ ] Release 2.0.0

I also plan to rewrite/expand the wiki using the four functions of documentation system to make it more approachable.

adding more fields (database, filesystem, amount of monitors) to the issue templates might also be helpful before releasing 2.0.0-beta.0

Add Publish to NPM in the list aswell

Add Publish to NPM in the list aswell

Postponed to another milestone, as adopting the aggregate tables are higher priority.

Add Publish to NPM in the list aswell

Postponed to another milestone, as adopting the aggregate tables are higher priority.

Ohhh ok👍

Hello,
When will we be able to have a docker image of 2.0.0?

@mabed-fr once it is ready.
See checklist above: Release 2.0.0-beta.0

Focusing on other things in real life recently, but since 2.0.0 may have been held off for a bit too long, I am setting a date here.
I hope 2.0.0-beta.0 can be released in spring 2024, which doesn't include the e2e tests yet. During the beta test, I will try to work on implementing the e2e tests.

@chakflying @louislam
I am going to close this issue as I have made this into a pin-able issue.
I feel our users/contributors have a hard time finding this PR => transfering the discussion there is better for transparency (and reduces the workload of issues which are invalid due to this miscommunication) ^^

Thanks, no problem. I will come back soon.


Implement Combinations::nth

Hi there, this PR addresses #301 in the same way as #329. @Philippe-Cholet I was indeed wrong that this wouldn't give a substantial performance gain
cargo bench --bench specializations "combinations[1234]/nth"

combinations1/nth       time:   [4.8406 ms 4.8562 ms 4.8734 ms]
                        change: [-53.963% -53.706% -53.442%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 15 outliers among 100 measurements (15.00%)
  6 (6.00%) high mild
  9 (9.00%) high severe

combinations2/nth       time:   [4.6338 ms 4.6532 ms 4.6762 ms]
                        change: [-55.198% -54.769% -54.327%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 11 outliers among 100 measurements (11.00%)
  1 (1.00%) high mild
  10 (10.00%) high severe

combinations3/nth       time:   [4.7743 ms 4.8138 ms 4.8600 ms]
                        change: [-53.934% -53.322% -52.707%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 14 outliers among 100 measurements (14.00%)
  8 (8.00%) high mild
  6 (6.00%) high severe

combinations4/nth       time:   [5.1255 ms 5.1524 ms 5.1841 ms]
                        change: [-53.459% -52.613% -51.852%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 18 outliers among 100 measurements (18.00%)
  6 (6.00%) high mild
  12 (12.00%) high severe

As discussed in the comments of #301, an even more efficient solution which would be performant even in the large n/k regime, would be to use the combinatorial number system. For record keeping sake, here's the function I sketched out before I realised that the itertools uses a 'reversed' lexicographic ordering.
    fn nth(&mut self, n: usize) -> Option<Self::Item> {
        self.state += n;

        // https://en.wikipedia.org/wiki/Combinatorial_number_system#Finding_the_k-combination_for_a_given_number
        let mut remainder = self.state;
        let mut delta = 0;
        for i in (0..self.k()).rev() {
            let mut m = i;
            while let Some(d) = checked_binomial(m, i + 1) {
                if d > remainder {
                    self.indices[i] = m - 1;
                    remainder -= delta;
                    break;
                }

                m += 1;
                delta = d;
            }
        }

        // We may need to pad out the pool
        if let Some(x) = self.indices.last() {
            self.pool.prefill(x + 1);
            if *x >= self.n() {
                return None;
            }
        }

        // We should only return an empty list once
        if self.indices.is_empty() && self.state > 0 {
            return None;
        }

        Some(self.indices.iter().map(|i| self.pool[*i].clone()).collect())
    }

It's possible to use this same idea with the lexicographic ordering used by itertools, but we'd need to know number of elements in the underlying iterator. Suppose we do, and we label this N. Then the function above would just need to be modified so that

We initialise remainder = checked_binomial(N, self.k()) - n - 1
We 'invert' the indices before returning the combination so that i = N-1-i and then reverse the order to ensure that the indices remain strictly increasing.

Ah sorry had the wrong tab open! Will put the PR in the right repo. How embarrassing


Cant enable addon and tried everything that i could think of

It says to restart blender and then enable CATS, but I've done it a thousand times as well at trying to uninstall blender and do it again, and restarting my computer but that seemed to do nothing, not sure what to do here because I've tried the "Go into the Addons in the User Preferences Search for "cats" and disable every version you can find, Press Save User Settings Restart Blender Enable Cats and press Save User Settings again." but that wont work either.

I think this should be fixed now, please test again with the latest development version of cats. Reopen this if these errors still occur.


Simplify the code of experiment examples

No need for generic type parameters
No need for a lot of inheritance
No need for many imports (any?)
sarsa.qToPolicy could be changed to an extension method
Formatting of the output seems the same 4-5 boilerplate lines for all examples.  Could we abstract and reuse this?
Change indentation to 3 spaces
Set all experiment tests to ignore (they are not really the tests to run with all test suites).  Eventually we may want to collect them in a single testSuite that we can run separately (all experiments)
Rename all experiments spec classes to Experiments and make sure they are in files named Experiments.scala
If an example is episodic mix-in the Episodic trait and activate the respective test

The simplemaze.Experiments have been already cleaned up partly (in an upcoming pull-request).

I have extracted a common Spec trait (ExperimentSpec) that allows to reduce repetition across different experiements
Changed indentation to 3 spaces whenever possible
Added a test for qlearning with Unit agent
Unified experiment class names with their file names
for now have not ignored them: rather working towards activating and speeding them up
Made the maze episodic and added the test
Made mountaincar episodic, but have deactivated the test because randomized reachability for mountain car is too hard to be reliable (test fails from time to time).


Bump CONTROLLER_TOOLS_VERSION to 0.14.0

bump controller tools to the version which bumps k8s deps to v0.29.0, which aligns with the version in the operators.

@fmount there is an issue with the glance crd which prevents bumping to controller tools 0.14.0. The imageCache.size is a required value. With controller-tools 0.14.0 support for empty maps/lists was introduced https://github.com/kubernetes-sigs/controller-tools/releases/tag/v0.14.0 . This now really applies the defaulting in [1] . Is the imageCache config a required config for glance, or can it be optional and we remove [1], so that we can bump to controller-tools 0.14.0?
[1] https://github.com/openstack-k8s-operators/glance-operator/blob/main/api/v1beta1/glance_types.go#L110C5-L110C28

This is the error:
  [FAILED] Unexpected error:
      <*fmt.wrapError | 0xc0001ba1a0>:
      unable to install CRDs onto control plane: unable to create CRD instances: unable to create CRD "glances.glance.openstack.org": CustomResourceDefinition.apiextensions.k8s.io "glances.glance.openstack.org" is invalid: spec.validation.openAPIV3Schema.properties[spec].properties[imageCache].default.size: Required value
      {
          msg: "unable to install CRDs onto control plane: unable to create CRD instances: unable to create CRD \"glances.glance.openstack.org\": CustomResourceDefinition.apiextensions.k8s.io \"glances.glance.openstack.org\" is invalid: spec.validation.openAPIV3Schema.properties[spec].properties[imageCache].default.size: Required value",
          err: <*fmt.wrapError | 0xc0001ba180>{
              msg: "unable to create CRD instances: unable to create CRD \"glances.glance.openstack.org\": CustomResourceDefinition.apiextensions.k8s.io \"glances.glance.openstack.org\" is invalid: spec.validation.openAPIV3Schema.properties[spec].properties[imageCache].default.size: Required value",
              err: <*fmt.wrapError | 0xc0001ba160>{
                  msg: "unable to create CRD \"glances.glance.openstack.org\": CustomResourceDefinition.apiextensions.k8s.io \"glances.glance.openstack.org\" is invalid: spec.validation.openAPIV3Schema.properties[spec].properties[imageCache].default.size: Required value",
                  err: <*errors.StatusError | 0xc0003a2280>{
                      ErrStatus: {
                          TypeMeta: {Kind: "", APIVersion: ""},
                          ListMeta: {
                              SelfLink: "",
                              ResourceVersion: "",
                              Continue: "",
                              RemainingItemCount: nil,
                          },
                          Status: "Failure",
                          Message: "CustomResourceDefinition.apiextensions.k8s.io \"glances.glance.openstack.org\" is invalid: spec.validation.openAPIV3Schema.properties[spec].properties[imageCache].default.size: Required value",
                          Reason: "Invalid",
                          Details: {
                              Name: "glances.glance.openstack.org",
                              Group: "apiextensions.k8s.io",
                              Kind: "CustomResourceDefinition",
                              UID: "",
                              Causes: [
                                  {
                                      Type: "FieldValueRequired",
                                      Message: "Required value",
                                      Field: "spec.validation.openAPIV3Schema.properties[spec].properties[imageCache].default.size",
                                  },
                              ],
                              RetryAfterSeconds: 0,
                          },
                          Code: 422,
                      },
                  },
              },
          },
      }
  occurred

could be fixed by removing https://github.com/openstack-k8s-operators/glance-operator/blob/main/api/v1beta1/glance_types.go#L110C5-L110C28

@fmount there is an issue with the glance crd which prevents bumping to controller tools 0.14.0. The imageCache.size is a required value. With controller-tools 0.14.0 support for empty maps/lists was introduced https://github.com/kubernetes-sigs/controller-tools/releases/tag/v0.14.0 . This now really applies the defaulting in [1] . Is the imageCache config a required config for glance, or can it be optional and we remove [1], so that we can bump to controller-tools 0.14.0?
[1] https://github.com/openstack-k8s-operators/glance-operator/blob/main/api/v1beta1/glance_types.go#L110C5-L110C28

ImageCache is not required at deployment time: customers can decide to enable this feature later in time (day2) and patch the Glance CR. So I agree this is not a required parameter and the API should be fixed to reflect that.
Thank you, I guess you can remove [1].
[1] https://github.com/openstack-k8s-operators/glance-operator/blob/main/api/v1beta1/glance_types.go#L110

@fmount there is an issue with the glance crd which prevents bumping to controller tools 0.14.0. The imageCache.size is a required value. With controller-tools 0.14.0 support for empty maps/lists was introduced https://github.com/kubernetes-sigs/controller-tools/releases/tag/v0.14.0 . This now really applies the defaulting in [1] . Is the imageCache config a required config for glance, or can it be optional and we remove [1], so that we can bump to controller-tools 0.14.0?
[1] https://github.com/openstack-k8s-operators/glance-operator/blob/main/api/v1beta1/glance_types.go#L110C5-L110C28

ImageCache is not required at deployment time: customers can decide to enable this feature later in time (day2) and patch the Glance CR. So I agree this is not a required parameter and the API should be fixed to reflect that. Thank you, I guess you can remove [1].
[1] https://github.com/openstack-k8s-operators/glance-operator/blob/main/api/v1beta1/glance_types.go#L110

Ack, was guessing that, but first wanted to check with you. Thanks, will update the pr.

@stuggi seems good now and kuttl (which is supposed to validate imageCache) seems to work.

yes seems to be good. can you approve ?

/retest


Remove error_on_stderr setting

Closes #6730 (supersedes it).
What was the end-user problem that led to this PR?
The problem was that this is not a good fit for a feature flag nor a setting since it was just a bug fix.
What was your diagnosis of the problem?
My diagnosis was that we can remove the setting, specially since the behavior has already changed.
What is your fix for the problem, implemented in this PR?
My fix is to remove the setting.

This is a bit nit-picky but it would be nice to keep the attribution by either adding these commits to either the original PR. Or copying the original PR's commits into here.
Bundler is open source, so any work/effort on it should be recognized

It's not nitpicky, you are absolutely 100% right. The only reason I didn't use the original PR was that it's pointed to 2-0-stable, but I should've reused the commits or add @greysteil as co-author if not reusing them (like in this case).
Thanks so much for pointing this out :heart:. I'm going to instead change the target branch of #7117 and rebase it.


Fix inner transport not closed

The inner transport will be closed automatically when closing outer transport.
But, CacheConnectionPool wraps the pool of type RequestInterface, which do not have close method. I'm not sure how to fix the closing of pool.
fix #145

Looks great, thanks! For AsyncCacheConnectionPool and CacheConnectionPool, I'd recommend something like this:
    async def aclose(self) -> None:
        await self._storage.aclose()

        if hasattr(self._pool, "aclose"):  # pragma: no cover
            await self._pool.aclose()

This is what we use in httpcore for such cases.

Updated. added close to cachepool


InstrumentClass need addSetter method

RabbitMQ com.rabbitmq.client.AMQP$BasicProperties
setHeader is deprecated, and headers field is Collections.unmodifiableMap, so i want InstrumentClass interface add method addSetter

@majinkai
is this issue still relevant? One possible way to go around not having a setter would be to hook the method that calls the constructor/builder of AMQP$BasicProperties and inject Pinpoint headers there.
Is this a possibility?

transformTemplate.transform("com.rabbitmq.client.impl.ChannelN", new TransformCallback() {
    @Override
    public byte[] doInTransform(Instrumentor instrumentor, ClassLoader loader, String className, Class<?> classBeingRedefined, ProtectionDomain protectionDomain, byte[] classfileBuffer) throws InstrumentException {
        InstrumentClass target = instrumentor.getInstrumentClass(loader, className, classfileBuffer);

        final InstrumentMethod method = target.getDeclaredMethod("basicPublish", "java.lang.String", "java.lang.String", "boolean", "boolean", "com.rabbitmq.client.AMQP$BasicProperties", "byte[]");
        if (method != null) {
            method.addInterceptor(PUBLISHER_INTERCEPTOR_FQCN);
        }

        return target.toBytecode();
    }
});

Publisher excute basicPublish method with AMQP$BasicProperties.
Maybe I am not familiar with the use of the pinpoint.

Is it possible to make an interceptor for AMQP$BasicProperties's constructor?
It could check the 3rd argument Map<String, Object> headers (@before) and if it's not null, inject Pinpoint headers here.
This would however not work for calls with null headers...

public BasicProperties(
            String contentType,
            String contentEncoding,
            Map<String,Object> headers,
            Integer deliveryMode,
            Integer priority,
            String correlationId,
            String replyTo,
            String expiration,
            String messageId,
            Date timestamp,
            String type,
            String userId,
            String appId,
            String clusterId)
        {
            this.contentType = contentType;
            this.contentEncoding = contentEncoding;
            this.headers = headers==null ? null : Collections.unmodifiableMap(new HashMap<String,Object>(headers));
            this.deliveryMode = deliveryMode;
            this.priority = priority;
            this.correlationId = correlationId;
            this.replyTo = replyTo;
            this.expiration = expiration;
            this.messageId = messageId;
            this.timestamp = timestamp;
            this.type = type;
            this.userId = userId;
            this.appId = appId;
            this.clusterId = clusterId;
        }

This is AMQP$BasicPropertiess constructor

We've looked at the code/codegen for RabbitMQ but couldn't find a way to inject Pinpoint headers if the headers (or BasicProperties) is null.
We'll add addSetter to our InstrumentClass API per your request.
Thanks :)

Thanks a lot.

@majinkai code has been pushed to master.
Please take a look and open up a new issue if anything's wrong.
Thanks!

It working for me, and i will open new issue if anything's wrong.
Thanks a lot again.


unattended upgrades

security updates should be automatically installed (at least) daily.
non-security updates should be installed weekly (lower priority)

closed by https://github.com/rehabstudio/oneill-server/commit/36de133d6dca2996abfb7e07cacaf71cc89b3cba


Modal, Dropdown and Toast updates

Codecov Report

Merging #5 into master will increase coverage by 0.71%.
The diff coverage is 71.42%.

@@            Coverage Diff            @@
##           master      #5      +/-   ##
=========================================
+ Coverage   71.18%   71.9%   +0.71%
=========================================
  Files          10      10
  Lines         118     121       +3
  Branches       18      18
=========================================
+ Hits           84      87       +3
  Misses         25      25
  Partials        9       9

Impacted Files
Coverage Δ

src/utils.js
100% <100%> (ø)
:arrow_up:

src/theme.js
100% <100%> (ø)
:arrow_up:

src/Dropdown/Dropdown.js
41.86% <50%> (+1.38%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fd962e...ccdb0a2. Read the comment docs.


[$1000] Dev: Web - Workspace- Personal information (step 3 of 5) Not going to the next step when entered number for First name , Last name and city

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open app
Go to settings > workspace >Bank account > connect manually
Fill the form until step 3
Enter number for First name , Last name and city

Expected Result:
User proceed to the next step
Actual Result:
User stays in Step 3
Workaround:
Unkown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.26-1
Reproducible in staging?: n/a
Reproducible in production?: n/a
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/1c7c21cc-1f35-4aea-9ad0-bde1b8a8eecd
Expensify/Expensify Issue URL:
Issue reported by: @narzullome
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686391710577659
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~018267fd61dd0e018e
Upwork Job ID:<PHONE_NUMBER>626402816
Last Price Increase: 2023-06-19

Proposal
Please re-state the problem that we are trying to solve in this issue.
Dev: Web - Workspace- Personal information (step 3 of 5) Not going to the next step when entering number for First name, Last name, and city
What is the root cause of that problem?
The backend is sending an error when only the number is entered in firstName or lastName

What changes do you think we should make in order to solve the problem?
We should make sure that it is expected behavior not to accept only numbers in firstName and lastName. If yes we should add validation for these fields to check if they are only numbers or not. We can use something like this:
/^\d+$/.test(str)

We can also add checks for special characters if needed.
What alternative solutions did you explore? (Optional)

Hey @grgia - I can't test in dev, can you let me know if this is reproducible? ty!

@grgia @bfitzexpensify Hey guys! I would like to clarify - if we send this information for API - and API return an error - should we show that error and highlight fields which cause it?

Hey @narefyev91 - yes, we should show the error and indicate which fields are incorrect

Hey @narefyev91 - yes, we should show the error and indicate which fields are incorrect

Hey @bfitzexpensify! Thanks for the reply - one more thing to clarify - do we need local check instead of sending to API not valid fields? I think that this makes more sense

Changes should be done on BE side - based on the discussion in slack https://www.expensify.com/_devportal/tools/logSearch/#query=request_id:("7da2e3285a1a0332-AMD")+AND+timestamp:[2023-06-20T08:11:58.612Z+TO+2023-06-20T10:11:58.612Z]&index=logs_expensify-022893
API should return something similar as we have for empty fields:
{"error":{"type":"validation_error","message":"There was a validation error on this request","fields":{"first_name":["can't be blank"],"last_name":["can't be blank"]}}}

OK @grgia can you handle the BE changes or should I run the eng auto-assigner again?

@narefyev91 can you link the discussion in slack?

@grgia https://expensify.slack.com/archives/C02NK2DQWUX/p1687245299888519

@narefyev91 thank you! Made internal, I should be able to look at this EOW or by early next week

Haven't gotten to this yet

Still haven't

I've hit my hours for this week, so I'm going to try to prioritize getting a PR up for this one on Monday.

Working on this

I had to put this on the back burner this week

Going to try and work on this before EOW, if I can't, I'll post a summary of the next steps and look for a volunteer since I'm OOO next week.

Looking for volunteers before going OOO next week - https://expensify.slack.com/archives/C03TQ48KC/p1691074750730509

Back from OOO, will likely try to find a volunteer still for this one

not prioritizing currently

^

^

^

not a priority currently

@grgia I think we can just close this - the action taken to produce it (entering numbers as first and last name) doesn't seem like something someone would ever do. Do you agree?

Fortune favours the bold, I'm gonna close this


PPP slackernoob

https://nus-cs2103-ay2223s2.github.io/website/admin/tp-deliverables.html#deliverable-project-portfolio-page-ppp

Addressed in #387 . Closing issue.


Hooks, HTTP code 500

Hey everyone,
Not sure it's the good place to ask, but we did call MangoPay, and made a lot of researches about our server but we can't find a way out!
So, we put our site on line, our hooks got a http code 500, we did test them with postman and everything is fine.
We use
Plesk Obsidian
Version 18.0.40 Mise à jour 1, dernière mise à jour le 14 Déc 2021 14:33. Seems that we are blocking MangoPay, the log appears with unknowned agent.
Thanks for all the help

Hi @HysteriaKa,

Hey everyone, Not sure it's the good place to ask, but we did call MangoPay, and made a lot of researches about our server but we can't find a way out! So, we put our site on line, our hooks got a http code 500,

Well, this has for sure nothing to do with the MangoPay PHP SDK, but let's try to help you out :)

we did test them with postman and everything is fine. We use Plesk Obsidian Version 18.0.40 Mise à jour 1, dernière mise à jour le 14 Déc 2021 14:33. Seems that we are blocking MangoPay, the log appears with unknowned agent. Thanks for all the help

So, if you were blocking MangoPay request, you should end up with an error code 401, not a 500. 500 usually mean something went really wrong on your end, and that your server do not know how to handle the request.
Now, the problem here is you are talking about Plesk, which is just a GUI to manage your server, but it doesn't tell anything about what your system your server is running (Windows ? Linux ? What version ?), which web server (apache ? ngnix ? , IIS ?), neither what is the stack of your webApp ?
MangoPay actually have a user agent set to "MANGOPAY", or at least, there is one set when it call the hook for my service. My guess is Plesk maybe only display user agent he knows.
The log should look like this :
78.*.*.* - - [17/Dec/2021:18:21:34 +0000] "GET /payment/mp/callback?RessourceId=2064179080&EventType=PAYIN_NORMAL_SUCCEEDED&Date=1639765294 HTTP/1.1" 200 5146 "-" "MANGOPAY"
Can you share some of the code from your controller that take care of the hook callback ?
Cheers,
Marc


Found a bug. Needs to be fixed urgently.

Hi @Defxult !
I just found a new bug while I was testing my code.

ISSUE:

The issue I am currently facing is, the database file (.db) created using the DiscordLevelingSystem.create_database_file(file_path: str) method only registers the member id as the primary key in leaderboard table, while the guild id doesn't get registered.
I checked out the code of class DiscordLevelingSystem (leveling_system.py), I couldn't find any code which registers the guild in the leaderboard table. This means the bot would only update the leaderboard table when the member/author sends a message, regardless of being in the same guild or a different one.
I levelled up to 1 in a server and my next level in another server was level 2 (while testing the code).
The member's level and XP shouldn't remain the same in all the servers.

Probably not a bug:

The member data cannot be accessed from await DiscordLevelingSystem.get_data_for(member: Member) method.
Please provide an example using the class MemberData in the readme.md file.

Requesting you to please resolve this issue as soon as possible.
Thank you

You're right. When developing this library I only did my testing in a single server so the thought of that issue never came up. I'll see what I can do about it and if I find a solution it will fixed next update.
As for the MemberData example, the README.md will be updated as well with the next update. But for now here is an example
lvl = DiscordLevelingSystem(...)

@bot.command()
async def example(ctx):
    data = await lvl.get_data_for(ctx.author)
    await ctx.send(f"{ctx.author.name} has {data.total_xp} XP")

All attributes for MemberData are located in the readme


shift+click to select text is broken when installed

If I install Robot Framework Assistant, then try to select text by holding SHIFT, and clicking, nothing happens!
Expected behavior is that the text from the current caret position is selected until the position that you clicked on.
Removing this package instantly fixes the issue.
OS X 10.11.6
Sublime Text Stable Channel 3126
Robot Framework Assistant v5.1.2
All file extensions are affected

I haven't used that shortcut, could you explain what actually should happen? In what file extension this happens and if it's not a normal txt file, could you show an example?
Also what is the sublime text and plugin version that you are using?

If you open sublime console do you see any errors or stack trace when you execute the shortcut? If you do could you copy/paste it to here?
If you don't see any errors could you execute sublime.log_input(True) in the console. And then execute the shortcut with plugin installed and when it's installed.

I haven't used that shortcut, could you explain what actually should happen? In what file extension this happens and if it's not a normal txt file, could you show an example?
This is the common behavior across operating systems where if you shift+left-click then the text is selected from the original cursor location to the new cursor location.

I have the same issue with build 3126 and plugin version 5.1.2
It appears that shift+left-click is being used as a shortcut for either 'Jump to Keyword' or 'Show Keyword Documentation' as "... not found from db" error

The Mac and other operating system mouse maps are different because Mac keyboard is different. In other mouse maps modifier key is Alt
To temporally overcome the problem you can define user mouse map set the modifier key as you want.
I am open to suggestions how to fix it in the next release. Which modifier key(s) you would like to use in Mac to show the documentation with mouse.

most IDEs "find definition" with Ctrl+Click, or on Mac, Cmd+Click

Ctrl sounds fine by me. But I don't have Mac where I could test the fix. @kevin-- could you copy the https://github.com/andriyko/sublime-robot-framework-assistant/blob/master/Default (OSX).sublime-mousemap file to the Packages/User folder. Then change line       "button": "button1", "count": 1, "modifiers": ["shift"], to       "button": "button1", "count": 1, "modifiers": ["ctrl"],. Restart of sublime maybe required.
If that works I could make a new release to fix it officially.

Or even pull request to provide the fix could be nice too.

yes, changing the modifier to ctrl works great

Fixed in https://github.com/andriyko/sublime-robot-framework-assistant/commit/8c36fdd4e77ce2dda03ff9e349237f3a8b699408

There are few minor things to be fixed before next release. Once those are done, I will create a new release.


enum abstract handling

The tree for enum abstract isn't intuitive - enum in this case is more like a modifier, so it should probably be a child of the CIdent like other modifiers. This would allow handling it more consistently with how @:enum abstract is handled.
The private and extern modifiers are where I'd expect, but enum is on top of everything (even though the type is an abstract, not an enum).

(background: enum in enum abstract is the only modifier not included in the range in document symbols)


Duplicate default settings session

btw, there's a duplicate default settings session.
Originally posted by @taooceros in https://github.com/lostping/Flow.Launcher.Plugin.Kitty/issues/1#issuecomment-1018682458
Solution: Remove "default session" from results
(Default session will be started anyway when no parameter is given)

Fixed in 1d90fa6


pull request for e2e test at 12/22/2016 01:15:22

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Fixing example in documentation

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hello @kenske,Thanks again for the PR! We want to show our appreciation by sending                                              you some swag. Could you please fill out                                              this form so we can send it to you? Thanks!                                             Team SendGrid DX


OAuth2 request_type="code" scope="openid ..." is spuriously validating id_token

I'm getting a validation error with a response from a plain OAuth2 (non-OIDC) AS. The request_type is "code" and I have the "openid" scope included. Line 43 of ResponseValidator is validating based on the openid scope, and part of that validation is to check that id_token is a valid JWT.
However, as per the example in the specs, the id_token response is mandatory only for request_type "id_token":
https://openid.net/specs/openid-connect-core-1_0.html#codeExample
I believe the validation should consider whether or not the request_type is "code"; if it is, it should only validate the format of id_token if it exists. It should not fail validation if it does not exist.

Which Idp are you using? Typically when you set openid you get an id_token.
Why do you need to set scope=openid anyway when you do not need the id_token anyway?


Steam Group Permissions and Whitelists

Current scenario:  There are servers on which they have two opposing groups of players, basically "good guys vs bad guys".  Be it cops vs robbers, or two opposing military groups, players decide which team they play for by joining steam groups.  At the moment, there is no way of automatically assigning different permissions to different steam groups, and nothing prevents any users of joining the server even if they are not a member of the steam groups.
What would be extremely useful for these types of servers would be:

Being able to add a steam group to Rocket's permission file to specify which permissions teams have.
Add steam groups to Rocket's whitelist, so nobody can join unless they are a member of one of the two steam groups.

Also on my wishlist, removing inheritance of the default group by default...  The inheritance should only take effect if the default group is specified as a ParentGroup.
The result would be being able to allow different kits for different teams.
Thanks!
Kraken

This can be done by a plugin


Smarter loading of CKAN resources

Based on a British Red Cross requirement reported by @SimonbJohnson , recognise a CKAN resource URL, at least from HDX, and use the CKAN API to get the latest file for that resource.  This will make it possible to update HDX resources in place with new files, without having to change any filters set up (in the HXL Proxy or elsewhere).
HDX resource URLs look like this: https://data.hdx.rwlabs.org/dataset/nepal-consolidated-3w/resource/62d4b11f-1a29-4753-a54f-c327f21f0b0b (they're not always easy to get, though, especially if the resource is not previewable).
We may want to add this support just in the HXL Proxy rather than in the library generally -- TBD.

Implemented by 120515d2bd5005365a3b45e99c0c6fed720a06d8


Idea: Add tools to check that the regions/metrics are correctly configured

While I was working on the World Happiness Report demo, I realized that it would be good to have a way to preview/test/check if the metrics and region setup is done correctly. For example:

List all the regions with links to their corresponding pages. This will allow us to check that the URL / filesystem routing was done correctly.
Allow the user to load some data in the metrics explorer page. We could add a dropdown so the user can select a region, and show the data for each metric for that specific region.

We could also have a script that runs some diagnostics/checks to confirm the configuration, availability of data, etc.

@chasulin is adding a regions page in https://github.com/act-now-coalition/act-now-template/pull/88.


Empower Intellect

We can just delete this from the map outright. There don't seem to be any units using it, and the spell isn't good enough to recreate.

Closed by https://github.com/AzerothWarsLR/WarcraftLegacies/commit/fd8cef5f1e45cb72592d41c6d5a393d2cf8bab67.


Homebrew should respect the active Xcode

Please always follow these steps:

[x] Confirmed this is a problem with running a brew command and not brew installing or the post-install behaviour of one or more formulae? If it's a formulae-specific problem please file this issue at https://github.com/Homebrew/homebrew-core/issues/new
[x] Ran brew update and retried your prior step?
[x] Ran brew doctor, fixed all issues and retried your prior step?
[x] Ran brew config and brew doctor and included their output with your issue?

Please note we will close your issue without comment if you delete or do not fill out the issue checklist and provide ALL the requested information.
Reproduce

Install Xcode 9.0 beta
Install Xcode 8.3.3
$ sudo xcode-select --switch /Xcode/8.3.3/Xcode.app/Contents/Developer
$ brew upgrade

Expected
Brew to upgrade using the Xcode 8.3.3 toolchain.
Found
$ brew upgrade
Error: Your Xcode (8.3.3) is too outdated.
Please update to Xcode 9.0 (or delete it).
Xcode can be updated from
  https://developer.apple.com/download/more/

Notes
From the config, Homebrew detects Xcode 8.3.3  is the active Xcode.
$ brew config
HOMEBREW_VERSION: 1.2.3
<snip>
Xcode: 8.3.3 => /Xcode/8.3.3/Xcode.app/Contents/Developer
<snip>

Is there some way to tell homebrew to use a particular Xcode?
Related

https://github.com/Homebrew/brew/pull/2736

Required
$ brew config
HOMEBREW_VERSION: 1.2.3
ORIGIN: https://github.com/Homebrew/brew
HEAD: ed9942fbd1ec4243f0a92ab8f9b2411c8b1fb091
Last commit: 2 weeks ago
Core tap ORIGIN: https://github.com/Homebrew/homebrew-core
Core tap HEAD: 6b31936eee598557390e9b33929b493578f10269
Core tap last commit: 57 minutes ago
HOMEBREW_PREFIX: /usr/local
HOMEBREW_REPOSITORY: /usr/local/Homebrew
HOMEBREW_CELLAR: /usr/local/Cellar
HOMEBREW_BOTTLE_DOMAIN: https://homebrew.bintray.com
CPU: octa-core 64-bit skylake
Homebrew Ruby: 2.3.3 => /System/Library/Frameworks/Ruby.framework/Versions/2.3/usr/bin/ruby
Clang: 8.1 build 802
Git: 2.13.1 => /usr/local/bin/git
Perl: /usr/local/bin/perl => /usr/local/Cellar/perl/5.24.1/bin/perl
Python: /usr/local/bin/python => /usr/local/Cellar/python/2.7.13/Frameworks/Python.framework/Versions/2.7/bin/python2.7
Ruby: /Users/moody/.rbenv/shims/ruby => /Users/moody/.rbenv/versions/2.3.1/bin/ruby
Java: 1.8.0_101
macOS: 10.13-x86_64
Xcode: 8.3.3 => /Xcode/8.3.3/Xcode.app/Contents/Developer
CLT: N/A
X11: N/A

$ brew doctor
Warning: Your Xcode (8.3.3) is outdated.
Please update to Xcode 9.0 (or delete it).
Xcode can be updated from
  https://developer.apple.com/download/more/

If 9.0 is installed, you may need to:
  sudo xcode-select --switch /Applications/Xcode.app
Current developer directory is:
  /Xcode/8.3.3/Xcode.app/Contents/Developer

This is intentional, as we require the use of Xcode 9 on 10.13. Thanks for reporting, though!

I am suggesting this the wrong behavior.

@jmoody fair enough. Nonetheless, it's what we intentionally require.

Is there some way to tell homebrew to use a particular Xcode?

To answer this specific question: no. We intentionally require Xcode 9 on High Sierra.

Is this due to it having support for APFS? Or just personal choice to go with latest version. Its a huge download and a pain in the buttocks to have it installed alongside 8.3.3

You're using a beta OS which means you need a beta Xcode.

Patently false. The beta OS isn't inclusive of a new version of Xcode and there are perfectly valid reasons to update OS but not update Xcode.

Patently false. The beta OS isn't inclusive of a new version of Xcode and there are perfectly valid reasons to update OS but not update Xcode.

A lot of things Homebrew installs will break if you use Xcode 8.3 so we require a newer version. Feel free to use whatever Xcode you wish but we don't support it.