feat: ingress annotations supports the specified upstream schema

Type of change:
#1420

[ ] Bugfix
[x] New feature provided
[ ] Improve performance
[ ] Backport patches

What this PR does / why we need it:

Pre-submission checklist:

[x] Did you explain what problem does this PR solve? Or what new features have been added?
[x] Have you added corresponding test cases?
[x] Have you modified the corresponding document?
[x] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

Codecov Report

Merging #1451 (6493ec9) into master (febeab4) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1451      +/-   ##
==========================================
- Coverage   41.30%   41.26%   -0.04%
==========================================
  Files          82       82
  Lines        7271     7277       +6
==========================================
  Hits         3003     3003
- Misses       3921     3927       +6
  Partials      347      347

Impacted Files
Coverage Δ

pkg/providers/ingress/translation/annotations.go
58.82% <ø> (ø)

pkg/providers/ingress/translation/translator.go
0.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

sorry for delay, could you please merge master branch? thanks!

Please take a look at this unit-test-ci

please help me re-run ci.

Please help me re-run ci.


XamlCompilation attribute

As per the link, we need to put XamlCompilation attribute in the AssemblyInfo.cs file.
However, I don't see any AssemblyInfo.cs file in .net MAUI project structure.
Can you please clarify where exactly do we need to put this attribute to pre-compile all of our xaml files?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 12b6e5f6-7ab1-1373-242e-4f28cee2b773
Version Independent ID: 12b6e5f6-7ab1-1373-242e-4f28cee2b773
Content: XAML compilation - .NET MAUI
Content Source: docs/xaml/xamlc.md
Product: dotnet-mobile
Technology: dotnet-maui
GitHub Login: @davidbritch
Microsoft Alias: dabritch

Hi @ataparia
You know that XAML compilation is enabled by default, right? So you only need to add the XamlCompilation attribute if you're disabling it (which isn't recommended). If you do want to disable it, just add a new file called AssemblyInfo.cs.

Thank you for your response @davidbritch


Add functional tests

Would be nice to have some tests using this in an actual notebook and simulating user interaction. I don't consider this super-higher priority right now.
Marked this as a good first issue. By which I mean it's great for someone who wants to contribute to this project, but who does have experience with Jupyter, ipywidgets, and testing.

Hello, I am a beginner and I want to contribute to it.

Hi @Himanxu1! Welcome. This project is very very very new so we're not exactly sure what needs work. I'm not sure if @almarklein knows how, but I have no idea how to implement the tests he's hoping for here. We use pytest for our testing in this package, but do you know of any way to run tests with a jupyter notebook and test user interaction in some way? That will be the big hurdle with this issue.
Any help is appreciated. Thanks.

I also have no idea right now, but I'm sure we can learn a lot from how projects like ipywidgets and some of its popular subclass projects (e.g. ipyleaflet, ipyvolume) do it.

Thanks for your interest, by the way! I did not expect new contributors so quickly :)

Thanks for your advice. I am just new to open source and want to Contribute !
I have intermediate knowledge of java >


Condition on tab

Is there a solution to hide a tab based on the selection from an other tab. Conditions don't seem to work on tabs.
Enhancement
Would be nice to be able to have condition on a tab
Expected behaviour
Consider this form :
[
  {
    "type": "tabs",
    "tabs": [
      {
        "items": [
          {
            "items": [
              {
                "titleMap": [
                  {
                    "name": "Option A",
                    "value": "clusters_of_delivery_points_1"
                  },
                  {
                    "name": "Option B",
                    "value": "clusters_of_delivery_points_2"
                  },
                  {
                    "name": "Option C",
                    "value": "minimum_linear_density"
                  }
                ],
                "notitle": true,
                "type": "radios",
                "key": "clustering"
              }
            ],
            "title": "Clustering",
            "type": "fieldset",
            "htmlClass": "form-group form-border"
          }
        ],
        "title": "Tab 1"
      },
      {
        "items": [],
        "condition": "model.clustering==='minimum_linear_density'",
        "title": "Tab 2"
      }
    ]
  }
]

Tab 2 should show only when Option C is selected in Tab 1.

@david4City I agree, this could be an expected behaviour.
Can you do me a favour and try updating your tabs template to include this:
ng-if="(!tab.condition || evalExpr(tab.condition, { model: model, arrayIndex: $index}))"
The full template would look like this, but adding just one attribute may be easier if you don't want to try compiling the templates.
If you can try that and not find any issues with it then I am happy to look at adding it as a PR.

        {{ tab.title }}

Oh it still needs some code in the decorator if you want to destroy the data after it is added if the tab is then hidden. I'll look into that side of it too.

Well it appears easy, the builder function for tabs would need to be updated to this
  var tabs = function(args) {
    if (args.form.tabs && args.form.tabs.length > 0) {
      var tabContent = args.fieldFrag.querySelector('.tab-content');

      args.form.tabs.forEach(function(tab, index) {
        var evalExpr = '(evalExpr(' + args.path + '.tabs[' + index + ']' +
                       '.condition, { model: model, "arrayIndex": $index}))';
        var div = document.createElement('div');
        div.className = 'tab-pane';
        div.setAttribute('ng-disabled', 'form.readonly');
        div.setAttribute('ng-show', 'selected.tab === ' + index);
        div.setAttribute('ng-class', '{active: selected.tab === ' + index + '}');
        if(!!tab.condition) {
          div.setAttribute('ng-if', evalExpr);
        };

        var childFrag = args.build(tab.items, args.path + '.tabs[' + index + '].items', args.state);
        div.appendChild(childFrag);
        tabContent.appendChild(div);
      });
    }
  };

@david4City you can get the latest dist/angular-schema-form-bootstrap.js (not in the minified version yet) from the latest commit to the webpack branch to give it a try, it includes all the dependencies so you just need that file, you can look at the example file to see how to use it. Be great if you could try it out and let me know how you go :)

Hi.
Thanks for the quick reply.
I can only see the feature/webpack-babel branch.
Is the webpack branch private ?

@david4City feature/webpack-babel is what I was referring to :)

FYI this still needs work, it fails if you hide the first tab. I remembered there was already a PR to add this functionality a while back in the bootstrap repo. I have been looking at it but it also has the issue of failing if the first tab is not available, once I solve that issue it will be ok, but I need to find a way to push the selected tab value to the first visible tab.

I wrote the PR your referring to I believe?  If you email me I'll try and address the issue and update the PR.

Hi @kyse, yes this one https://github.com/json-schema-form/angular-schema-form-bootstrap/pull/24
I added a comment to it, I admit I wasn't thinking when I made the basic change above in my own code and ran into the issue where a removed tab can cause issues in tab selection, I added a question to that issue if you can shed some light on it I would appreciate it :)

This will be an awesome feature. When can how can I get it please?

Just leaving this here for myself :)
#329 also has related information as it manages accordion status display.


Tinkey: many warning messages when encrypting with AWS KMS

When I ran the command mentioned in https://github.com/google/tink/issues/392, I got a lot of warning messages when I specified the --master-key-uri with aws-kms:
MacBook-Pro:dir user$ tinkey create-keyset --out=keyset.json --key-template=ECIES_P256_HKDF_HMAC_SHA256_AES128_GCM --master-key-uri=aws-kms://...
Jul 15, 2020 10:32:49 AM com.amazonaws.auth.profile.internal.BasicProfileConfigLoader loadProfiles
WARNING: Your profile name includes a 'profile ' prefix. This is considered part of the profile name in the Java SDK, so you will need to include this prefix in your profile name when you reference this profile from your Java code.
Jul 15, 2020 10:32:49 AM com.amazonaws.auth.profile.internal.BasicProfileConfigLoader loadProfiles
WARNING: Your profile name includes a 'profile ' prefix. This is considered part of the profile name in the Java SDK, so you will need to include this prefix in your profile name when you reference this profile from your Java code.
Jul 15, 2020 10:32:49 AM com.amazonaws.auth.profile.internal.BasicProfileConfigLoader loadProfiles
WARNING: Your profile name includes a 'profile ' prefix. This is considered part of the profile name in the Java SDK, so you will need to include this prefix in your profile name when you reference this profile from your Java code.
Jul 15, 2020 10:32:49 AM com.amazonaws.auth.profile.internal.BasicProfileConfigLoader loadProfiles
WARNING: Your profile name includes a 'profile ' prefix. This is considered part of the profile name in the Java SDK, so you will need to include this prefix in your profile name when you reference this profile from your Java code.
Jul 15, 2020 10:32:49 AM com.amazonaws.auth.profile.internal.BasicProfileConfigLoader loadProfiles
WARNING: Your profile name includes a 'profile ' prefix. This is considered part of the profile name in the Java SDK, so you will need to include this prefix in your profile name when you reference this profile from your Java code.
Jul 15, 2020 10:32:51 AM com.amazonaws.util.Base64 warn
WARNING: JAXB is unavailable. Will fallback to SDK implementation which may be less performant.If you are using Java 9+, you will need to include javax.xml.bind:jaxb-api as a dependency.

Despite the warning messages, I was still able to get the keyset created and encrypted just fine.

Thanks for the report. These warnings come from the AWS SDK. Honestly I don't know how to suppress them.

Closing this issue. Feel free to reopen it if you have additional questions/feedback.


Rename master branch to main

Signed-off-by: Emilio Lahr-Vivaz<EMAIL_ADDRESS>

Merged in main and master.  (While 'master' is the default...)


QLoRA with bias + Llama 3.2 Vision QLoRA configs

After opening https://github.com/pytorch/ao/issues/979 on torchao, it was pointed out to me that I was overcomplicating things.. we can just keep the bias in bf16, which is apparently a pretty standard thing to do (ref).
So this PR does exactly that.. just let bias stay in the higher precision for our FrozenNF4Linear, LoRALinear, and DoRALinear when we set quantize_base=True.
Test plan
Added test cases for LoRALinear and FrozenNF4Linear with bias=True.
Fun fact I discovered while writing the LoRALinear test: if x, weight, bias are all bf16 then F.linear(x, weight, bias) != F.linear(x, weight) + bias (repro here). So I left that test case out.
E2E tests:
tune run lora_finetune_single_device --config llama3_2_vision/11B_qlora_single_device \
metric_logger=torchtune.training.metric_logging.WandBLogger metric_logger.project=qlora-32-vision \
metric_logger.name=single-device max_steps_per_epoch=500

and
tune run --nproc_per_node 2 lora_finetune_distributed --config llama3_2_vision/11B_qlora \
metric_logger=torchtune.training.metric_logging.WandBLogger metric_logger.project=qlora-32-vision \
metric_logger.name=distributed max_steps_per_epoch=500

Loss curves from both these runs (compared to analogous LoRA runs as a baseline):

Also run with DoRA applied to MLP and output layers as a sanity check:
tune run lora_finetune_single_device --config llama3_2_vision/11B_qlora_single_device \
metric_logger=torchtune.training.metric_logging.WandBLogger metric_logger.project=qlora-32-vision \
metric_logger.name=single-device max_steps_per_epoch=5 model.apply_lora_to_mlp=True model.apply_lora_to_output=True model.use_dora=True max_steps_per_epoch=5 gradient_accumulation_steps=1
...

Codecov Report
Attention: Patch coverage is 92.63158% with 7 lines in your changes missing coverage. Please review.

Project coverage is 67.89%. Comparing base (73aa126) to head (09491e6).
Report is 10 commits behind head on main.

Files with missing lines
Patch %
Lines

...tune/models/llama3_2_vision/_component_builders.py
46.15%
7 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1726      +/-   ##
==========================================
- Coverage   70.25%   67.89%   -2.36%
==========================================
  Files         309      308       -1
  Lines       16285    16301      +16
==========================================
- Hits        11441    11068     -373
- Misses       4844     5233     +389

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


API review, useRefHistory flush default

Hello!
Awesome to see the preparation for the first stable release https://github.com/antfu/vueuse/issues/166 🎉
We have been using useRefHistory for https://github.com/Leniolabs/layoutit-grid using the extended API and it has been working well. The only thing that I am still not sure of is the right API choice to freeze is the default flush:sync. I think we should still try to make it work with the same default, 'pre', as watch/watchEffect.
I had to import batch in several places to fix issues with the flush:sync. I could have placed them in the actions, but it is still easy to get spurious history points. There also seems to be an issue with array refs and splice. Looks like calling splice is generating two history points (maybe a bug in Vue.js itself?).
I have an idea to use two watchers that may enable us to offer pre/post (and also sync as an option), so we could choose pre as the default. I still have to see if it works, but if not, I still think we should try to find a solution.
@antfu should I create a PR against the new dev branch if I managed to get it right? What do you think?

should I create a PR against the new dev branch if I managed to get it right? What do you think?

Sure! Let's see the PR! I would need to do more experiments about it as well :P
In addition, maybe we can have a manual option, and users would need to call commit() to create history points explicitly.


IW doesn't work with "View: Join All Editor Groups"

What happened?
Calling "View: Join All Editor Groups" from the command palette frequently leads to visual artifacts when using the IW.
In this screen recording, after calling "View: Join All Editor Groups", I expect to only see the Python file. Instead the file is overlayed by a remnant of the IW. There's no reliable way of getting rid of this artifact. Just playing around with the tabs and editor groups sometimes makes it disappear.
https://user-images.githubusercontent.com/30958850/135086657-7408e37f-b8a7-4cb2-9fb0-22b55267ed32.mp4
VS Code Version
1.60.2
Jupyter Extension Version
v2021.8.2041215044

Checking in for updates. This bug is occurring a lot lately and hard to recover from.

This affects notebooks as well.
Version: 1.72.0-insider (user setup)
Commit: a12109a6ac8cdb070d94d63a5dc3a3a8f53bad8c
Date: 2022-10-04T12:24:00.023Z
Electron: 19.0.17
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19044
Sandboxed: Yes


Freeze timer for monsters as well as players

As far as I can tell freeze timers only show in PVP, haven't tested all NPC's but would be notably good for barrows(if not already implemented), bandos, inferno, and a lot more.

Duplicate of #2011


Arbitration clause

Under Terms of Service and Privacy Policy documents, we could add an indicator stating "The Terms of Service do not include a binding mandatory private arbitration clause." Or is that too far afield?

George and I were discussing this yesterday. There are a number of unconscionable clauses that we could include (unilateral modification, automatic renewal, bar on class actions, short opt-out window for arbitration clause (if there is one), etc.).

@taliesan was this discussed when the DS was being developed?

This isn't strictly a privacy or security issue. It's also not about data.
It is, however, something Consumer Reports works on overall. But I'd suggest it's too legal-ish an assertion for inclusion in the Digital Standard.


Update the 'Set up a connection' section

Update the 'Set up a connection' section to use AwsProductApiClient instead of AwsProductApi

Hope @nkcraddock will have sometime to look at the pull requests!


webqsp dataset: full 0.439317 accuracy, half 0.346397

May I know how do you run your model in webqsp dataset?
I use the following command to run the model on webqsp half
python3 main.py --mode train --relation_dim 200 --do_batch_norm 1
--gpu 2 --freeze 1 --batch_size 16 --validate_every 10 --hops webqsp_half --lr 0.00002 --entdrop 0.0 --reldrop 0.0 --scoredrop 0.0
--decay 1.0 --model ComplEx --patience 20 --ls 0.05 --l3_reg 0.001 --nb_epochs 200 --outfile half_fbwq
and the following command to run the model on webqsp full
python3 main.py --mode train --relation_dim 128--do_batch_norm 1
--gpu 2 --freeze 1 --batch_size 16 --validate_every 10 --hops webqsp_half --lr 0.00002 --entdrop 0.0 --reldrop 0.0 --scoredrop 0.0
--decay 1.0 --model ComplEx --patience 20 --ls 0.05 --l3_reg 0.001 --nb_epochs 200 --outfile half_fbwq
But the accuracies are full 0.439317 accuracy, half 0.346397.

are you using the pre-trained complex embeddings? @lihuiliullh

yes, I think so. Because I downloaded the pretrained_models.zip, and used the above command line. @apoorvumang

wait for a while, let me get back to you later. Because I found that the "nb_epochs" I used is 20 instead of 200.

did you get a chance to run with 200 epochs? @lihuiliullh

yes, I ran 200 epochs. The accuracy for full is 0.56, for half is 0.47. @apoorvumang
How do you get the accuracy in the paper?

do these numbers include relation matching, or just the output of training script? @lihuiliullh

How to do relation matching? I just follow the instruction on the github, and ran the command. @apoorvumang

please see this https://github.com/malllabiisc/EmbedKGQA/blob/master/KGQA/RoBERTa/README.md

Do you have half version dataset like webqsp_scores_full_kg_fixed.pkl?
If I want to run the half datset, what should I do? @apoorvumang

Also, may I know how do you get the candidates in webqsp_scores_full_kg_fixed.pkl?
Are they the top-200 prediction of the very basic model without relation matching and 2-hop filter?

I do not yet have saved scores for half-kg model output. Will update you once I get it. You can however get scores from your own model through the instructions outlined in the above mentioned readme (you will have to uncomment a line in code to save file)

The given scores file contain top-200 prediction without relation matching, without 2-hop filter

closing since remaining points have been raised in another issue


Secure gRPC Connections Between Client and Server

Story
Currently the connection between the Forseti Client and Forseti Server are insecure.  This is theoretically susceptible to MITM attacks.  Authorization would be a nice-to-have, but is not necessary in the scope of this ticket.
Proposal
Implement secure gRPC connections between the Forseti Client and Forseti Server.
Validation
GIVEN A deployment of Forseti on GCE or GKE
WHEN A secure connection is initiated by the Forseti Client
THEN It is accepted by the Forseti Server

This isn't hard.  Just needs some thought.

Check to see if a cert and key are already available on the GCE VM's?
Ability to BYO-cert?
Have Terraform generate self-signed certs if none are provided?


Move /polls/:id route to bottom of controller.

Minor bug fix to avoid having the :id wildcard slurp up other routes unintentionally.
This may be a minor (or even imaginary) issue if no other route are actually affected.  I tried to enter /polls/new into the browser by hand and ran into it, so I thought I would fix it.

Cool thank you!


URL of template repo

From README, under Development -> Creating a new GitHub repository:
The python template URL is broken.

@ymnliu I can not find the broken link. Do you mind copy/pasting the sentence that includes the broken link?

The link works. I added a note that the user has to click on the button Use this template once he/she lands on the repository.


Still not being able to automatically back up or manually back up

Steps to reproduce
I have tachyiyomisy  and mihon so im trying to create a back up on tachisy and restore 1)I follow the steps and go to the data storage
2)I click the options for automatic back up with destination  but it never automatically backs up
So I manually back up and pick the correct file and it starts the back up  loading bar in my notifications
And then it loads for abit then it just stops no error no crash nothing
Expected behavior
My mihon backs up automatically so I go back between the 2 to see if the settings are the same and if so if I did something different on accident or didn't have a permission for the app, I have tachiyomisy set up for 6 hours  for auto just to see if it it works
Actual behavior
Nothing happens it always says last time automatically backed up never and and my manual back up just stops and I get no notification
Crash logs
tachiyomi_crash_logs.txt
Tachiyomi version
1.10.2
Android version
13
Device
Galaxy a13 5G
Other details

I go to restore the files and this is what's shown
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] If this is an issue with an extension, I should be opening an issue in the extension's repository.
[X] I have gone through the FAQ and troubleshooting guide.
[X] I have updated the app to version 1.10.2.
[X] I have updated all installed extensions.
[X] I will fill out all of the requested information in this form.

Also I get this in my backup file schema


Correction of "trade" command

Processing in the absence of arguments was missing.
・If it is only "/ trade", we can get help.
・Help made function

I made a mistake


Possibility to search for specific payment

Would be great with the ability to search the account ledger for a payment and get the current status of a specific payment and to verify that it exist.

Sorry for my poor suport there. For some reason this got left behind.
We have some specific calls that are created for specific types of integrations as these calls are not a part of the general API they are not linked on the overall developer portal. As such they are not included in this example library either until the point where they are made available for everybody.
Having that said however all the function calls to the API are fairly simple and straightforward, adding this call by yourself should be a 5min feat as the functions in Api/signed are more or less only a mapping between function arguments and the data structure in the call, in this case it will be 3 fields that you need to add.


fix(deps): update terraform terraform-ibm-modules/secrets-manager/ibm to v1.17.13

This PR contains the following updates:

Package
Type
Update
Change

terraform-ibm-modules/secrets-manager/ibm (source)
module
patch
1.17.12 -> 1.17.13

Release Notes

terraform-ibm-modules/terraform-ibm-secrets-manager (terraform-ibm-modules/secrets-manager/ibm)
v1.17.13
Compare Source
Bug Fixes

deps: update terraform ibm to latest for the deployable architecture solution (#194) (dd819a8)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

:tada: This PR is included in version 1.19.8 :tada:
The release is available on:

GitHub release
v1.19.8

Your semantic-release bot :package::rocket:


/help command ingame prints to console

When using /help ingame, its shown in console, not ingame

It would be somewhat hard to have the help command print out in-game(for the whole list.), as the list would need to be paginated(the whole list would be too long to fit in the chat history that the game has.).

The chat is just ugly, and vanilla does the same.


compose close button

Replaced the compose close button with font awesome icon
This PR is for issue #20403
Attaching testing screenshots:

@timabbott Hi Tim,hope you are doing well.I updated the changes suggested by you while reviewing the PR #20531.
Please merge my PR #21194

hy @akbajwa , it would be great if you can please check out the Zulip commit message guidelines before raising a PR: https://zulip.readthedocs.io/en/latest/contributing/version-control.html#commit-messages

hy @akbajwa , it would be great if you can please check out the Zulip commit message guidelines before raising a PR: https://zulip.readthedocs.io/en/latest/contributing/version-control.html#commit-messages

hi @jai2201 .I am new to contributions. Could you please tell me where i went wrong?and i am not sure what to do for to make all checks succesful

Closing, since we merged a different PR for https://github.com/zulip/zulip/issues/20403. You'll likely find it useful to read, since it takes a different approach that has a much cleaner end result.


Shuffle All Songs Option

Not much more to say than the title suggests.

For what it's worth, Play Song will respect your current iTunes shuffle setting when playing an artist/album/playlist. In the past, I have tried to add functionality that automatically enables/disables iTunes Shuffle for Play Song. However, doing so requires simulating menu clicks in AppleScript, which is rather unreliable. And surely, this implementation did not work for many of Play Song's non-English users who had their system languages set to something other than English. Yet, this is the only way to manipulate Shuffle settings in Play Song.
Similar to my own personal workflow, I would recommend creating a new Alfred workflow with two hotkey triggers—one for enabling shuffle, the other for disabling it. Each hotkey will run a AppleScript "Run Script" object that enables or disables Shuffle (respectively).
See my code below for an example of enabling shuffle:
tell application "System Events"
	tell process "iTunes"
		click menu item ¬
			"On" of menu 1 of menu item ¬
			"Shuffle" of menu 1 of menu bar item ¬
			"Controls" of menu bar 1
	end tell
end tell

And for disabling shuffle (only change was replacing "On" with "Off"):
tell application "System Events"
	tell process "iTunes"
		click menu item ¬
			"Off" of menu 1 of menu item ¬
			"Shuffle" of menu 1 of menu bar item ¬
			"Controls" of menu bar 1
	end tell
end tell

Caleb


fix EndpointShardsByService concurrent access

Fixes #12339

Protects EndpointShardsByService using mutex read lock
Opportunistically updates bucketization for convergence time metric.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: mandarjog
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: nmittler
If they are not already assigned, you can assign the PR to them by writing /assign @nmittler in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@duderino simple fix, but necessary.

@mandarjog: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
5b4e870c90752ac8b12774005d023f92ddc41ccd
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mandarjog: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
5b4e870c90752ac8b12774005d023f92ddc41ccd
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
5b4e870c90752ac8b12774005d023f92ddc41ccd
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: costinm, mandarjog
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/OWNERS [costinm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

How come this tweaking doesn't require a FLAG? if data can be used as basis of tweaking then the CDS change clearly has tons of data from multiple independent testers, while this obscure fix changing numbers, adding locks has NO data on perf impact.
Also, the sigsev is not consistent. Occurs only during high load situations. Just like the CDS issue. So to be fair, this needs a flag guard

Also, the sigsev is not consistent. Occurs only during high load situations. Just like the CDS issue. So to be fair, this needs a flag guard

I think that this bottoms out on minimizing risk and there are two big ways we can do that.

test the crap out of something, ideally with an automated test that prevents future regressions, but in case of issues like this that are caught in more prod-like tests we'll accept results from a manual load test, etc.

a feature flag to make a more speculative/less tested fix less risky.

So if you look at https://github.com/istio/istio/pull/12278#discussion_r263121336, I think @costinm got it right there.  He said tests || feature flag.
In the case of this PR, I believe @mandarjog reproduced this and verified the fix in a perf cluster, but he should say that and give us some data.  Without that, then, yes, this should be guarded by a flag.

I was able to reproduce this problem 4 times before I opened the PR. I updated the cluster with a pilot image from this PR, and did not see the problem.


Snapping Explorer to a zone does not save the size of the window

Windows build number: Windows 10 Build 19041.423
PowerToys version: 0.20.0
PowerToy module: FancyZones

📝 Reproduction steps

Snap the windows explorer to a zone
Close the window
Reopen windows explorer

✔ Expected result
Window to be the size of the zone it was previously in.
❌ Actual result
Size of the window is equal to the size before it was put into the zone.

@abitofmaya
is this still happening with 0.21.1? https://github.com/microsoft/PowerToys/releases/download/v0.21.1/PowerToysSetup-0.21.1-x64.exe

@enricogior,
Yes. It still does. But other applications just work the way they should, e.g. notepad++

@abitofmaya
Explorer, Edge and other applications that may have multiple windows, right now only the first window is snapped to a zone.
Is there some specific application that doesn't snap to the last known zone when opening the first window?

@enricogior
It still does not work after trying the mentioned steps in #5919 , https://github.com/microsoft/PowerToys/issues/5919#issuecomment-692247190 .
Application with multiple windows like Edge work fine. It is just the explorer.

@abitofmaya
can you post screenshots showing the Explorer window when it's snapped to the zone, and then when you reopen it?
Thanks.

@enricogior
Here.

@abitofmaya
that is very strange, I wonder if it depends of the type/position of the zone.
What layout are you using?
Can you try with a custom layout with a zone that doesn't touch the borders of the screen?

@abitofmaya
can you also provide more details on the monitor configuration?
It's a single monitor or multi monitor?
What the native monitor resolution? Are you using a DPI scaling different from 100%?

@enricogior
I was using a custom layout. I just created a new layout and snapped the window in the center without touching the border but it still does not work. I also checked/unchecked the show space around zones option with both negative and positive values.
I am currently only using a single monitor. But I do run two sometimes. Has not worked on multi-monitor too. Native resolution is 1920 x 1080. I was using 100% scaling. I just tried with 125 which is recommended by Windows but that didn't work either.

@abitofmaya
OK thanks for the info.

I use a single monitor at a time too. But I switch between my laptop's monitor (1080p) and an external one (1200p). 100% scaling on both. External monitor has a higher refresh rate.

@abitofmaya
can you still reproduce this problem with 0.29.3? Do you have one monitor or multi-monitor?
I've tried again but for me it works as expected.

@abitofmaya
can you still reproduce this problem with 0.29.3? Do you have one monitor or multi-monitor?
I've tried again but for me it works as expected.

@enricogior,
It still is a problem in 0.29.3. Also the zones editor does not work.

@enricogior,
It still is a problem in 0.29.3. Also the zones editor does not work.

@abitofmaya

the zones editor does not work.

This is too generic, can you open an issue with detailed information.

@abitofmaya

the zones editor does not work.

This is too generic, can you open an issue with detailed information.

@abitofmaya

the zones editor does not work.

This is too generic, can you open an issue with detailed information.

@abitofmaya

the zones editor does not work.

This is too generic, can you open an issue with detailed information.

@enricogior ,
Are you using the "Move newly created windows to their last zone" option in FancyZones settings? Turning this option on fixes the issue. The problem is that it will always move the window to that zone.

@enricogior ,
Are you using the "Move newly created windows to their last zone" option in FancyZones settings? Turning this option on fixes the issue. The problem is that it will always move the window to that zone.

@abitofmaya
I gave for granted that the problem was about "Move newly created windows to their last zone" not working as expected.
If the option is not on, FZ doesn't interfere with whatever logic is used by the application to save its current position.
We can try sending a WM_SIZE event to the window to see if that triggers the expected behavior.

@abitofmaya
I gave for granted that the problem was about "Move newly created windows to their last zone" not working as expected.
If the option is not on, FZ doesn't interfere with whatever logic is used by the application to save its current position.
We can try sending a WM_SIZE event to the window to see if that triggers the expected behavior.

Hopefully that fixes this issue.

Hopefully that fixes this issue.

@abitofmaya
I've tried several workarounds but none worked.
Also, Explorer has this same behavior when PowerToys is not running and you use Windows Snap.
Closing this issue since we cannot fix it.

@abitofmaya
I've tried several workarounds but none worked.
Also, Explorer has this same behavior when PowerToys is not running and you use Windows Snap.
Closing this issue since we cannot fix it.


Command crash when have parentheses

Describe the bug
We have a bug when the command has parentheses. The problem is that we need to split the command by pipes to execute one to one with CLAI and the paraentheses broken the commands. It's really complex right now to fix because we need a lex analyzer :S
To Reproduce
Steps to reproduce the behavior:

Write command with parentheses (ls | grep hi) | grep .

Expected behavior
process the command without break it.
shell and OS (please complete the following information):

OS: all
Shell all

I think that using a simple recursive solution might resolve this issue. But for other purposes/future use/proofing if we need lex analyser, then only I think we should use lex analyser.
Your thoughts??


feat: Add .is_enabled to check current status

This allows configurations to do things such as my use case of
notifying the new state when using .toggle()

Not adding low effort API for no reason. Can you describe the use case?

Sure. Here's the file where I'm using this: https://github.com/aarondill/LazyVim/commit/b433415267cd6c271953bb50b756ada8f8824f80
The relevant code is:

local ctx = require("treesitter-context")
        ctx.toggle()
        if not ctx.is_enabled then return vim.notify("Toggled context") end -- Function's not available. Notify of success.

        local action = "Enabled"
        if not ctx.is_enabled() then action = "Disabled" end
        vim.notify(action .. " context")

This code toggles the active state then notifies the user as which action was done. This A) allows me to know at a glance whether it's active or not and B) allows for symmetry with LazyVim's default key maps used to toggle options (they notify of the state)

@lewis6991 have you had a chance to look at my use case? If so, is there anything else I can do to move this PR along?


AnyPattern handling of nullable data

Description
When you have an endpoint that returns an array of JSON data that can also be nullable. The generation of data fails and you get an exception in the AnyPattern class
This is because the AnyPattern class doesn't handle nullable fields correctly
Steps to reproduce

Given the following openapi contract:

openapi: 3.0.3
info:
  contact:
    url: http://balbala
  title: MyFileRestAPI
  description: A file rest api
  version: 1.0.0
servers:
  - url: "http://{hostname}:{port}/{basePath}/"
    variables:
      hostname:
        default: localhost
      port:
        default: "8080"
      basePath:
        default: rest
  - url: "http://localhost:9000"
tags:
  - name: importantstuff
paths:

  "/importantstuff/{id}/status":
    get:
      tags:
        - importantstuff
      operationId: getImportantStuffStatus
      parameters:
        - in: path
          name: "id"
          description: "id"
          required: true
          schema:
            type: integer
            format: int64
      responses:
        "200":
          description: "List of important stuff status"
          content:
            application/json:
              schema:
                type: object
                title: Response
                properties:
                  errorMsg:
                    type: string
                    nullable: true
                  data:
                    nullable: true
                    type: array
                    items:
                      type: object
                      nullable: true
                      title: ImportantStuffStatus
                      properties:
                        type:
                          type: string
                          minLength: 1
                        flag:
                          type: boolean
                        sentDate:
                          type: string
                          format: date-time
                        document:
                          type: string
                          minLength: 1
                          nullable: true
                      required:
                        - type
                        - flag
                        - sentDate
                        - document

Run specmatic in stub mode: specmatic stub myamazingapi.yaml
Make an http request looking like this: GET http://localhost:9000/importantstuff/1/status

You need to try the request a few times to encounter the bug, the RNG decides between generating a NullPattern & the AnyPattern
Expected behavior
I expect Specmatic to generate the data without crashing
Screenshots

System Information:

OS & version: Windows 11
Browser & version: Insomnia 2023.5.8
Specmatic version: 0.76.0
JDK version: OpenJDK 17

Thanks @aeoncl for reporting this. Looks like a bug, and we were able to reproduce it using the specification you've shared.
Happy to accept a PR if you happen to have the time :-)

Hehe already made the PR !


Node.js v0.12.0 compatibility?

In the installation manual, here: https://github.com/silentrob/superscript-editor
I read that is needed node.js 0.10.x , do you think that also the usage of node.js v0.12.0 will be all right too?

This should be fixed now.


Replace thin server with puma in development

Puma gives us a server that can handle true multiprocessing in development. This is useful for uncovering concurrency related bugs before they make their way to production.

@david-yz-liu. Confirmed that this works with the current vagrant setup.


App Crashes on Selecting Camera Icon

I'm using Naxam image picker in my android app. Its working fine on selecting images from gallery but when I click the camera icon , the app crashes. I can't find the reason why it's happening.I have given all the required permissions in Manifest file.OnActivityResult is also not called.

@siddh1004 Plz check out latest binding here. Raise a new issue if it perists.


Config Changes didnt work

I changed the Config file to this, but Harvester still require Hoe(playing on a Server):
[expulsion_pylon]
#Which dimensions the Expulsion Pylon is allowed to operate in.
expulsionAllowedDimensions = ["minecraft:overworld"]
#The radius around the world spawn where the pylon is not allowed to operate.
#By default this uses the world spawn radius (/gamerule spawnRadius).
#This config will only take effect if it is larger than the world spawn radius.
#Range: 1 ~ 512
expulsionWorldSpawnRadius = 1
#Whether the Expulsion Pylon can be destroyed with explosions.
expulsionPylonCanExplode = false
#Limit the max radius for expulsion pylons.
#Does not include center chunk, so a radius of 2 equals a 5x5 chunk diameter.
#Range: 0 ~ 2
expulsionPylonMaxRadius = 2
[infusion_pylon]
#The minimum effect duration (in seconds) that can be used for Potion Filters.
#This defaults to 60 seconds to prevent unintended interactions
#with other mods that add persistent potion effects at low durations.
#Range: 1 ~ 3600
infusionMinimumDuration = 60
#The total duration (in seconds) required before a Potion Filter can be used.
#By default this is 3600 seconds/1 hour, which is equivalent to 7.5 vanilla extended potions.
#Range: 1 ~ 28800
infusionRequiredDuration = 3600
#The max duration of effects (in seconds) applied to the player.
#The duration is refreshed up to this amount every 60 ticks.
#Range: 5 ~ 60
infusionAppliedDuration = 20
#Whether the Infusion Pylon chunkloads itself.
#This is limited to one pylon per player, while the player is online.
infusionChunkloads = true
#Effects that may be used in the Infusion Pylon.
#List may include either effect IDs (like minecraft:strength) or an entire namespace (like minecraft).
#If the list is empty, then all effects will be allowed except for those specifically denied.
infusionAllowedEffects = []
#Effects that may not be used in the Infusion Pylon.
#This list will override the allowed effect list.
infusionDeniedEffects = ["minecraft:absorption", "tombstone:ghostly_shape"]
[harvester_pylon]
#Delay between harvest attempts (in ticks).
#Range: 10 ~ 120
harvesterWorkDelay = 20
#Whether the harvester requires a hoe to work.
#If enabled, it will use 1 durability per harvest action
harvesterRequiresTool = false
#Whether the harvester can have tools piped in to automate it.
#By default, unbreakable tools are required for full automation.
harvesterCanBeAutomated = false

Just to confirm, did you make this change to this file on the server: world/serverconfig/pylons-server.toml with the server turned off?

Omg i changed the config file in the defaultconfigs folder. Now it works! Thank you!


Image resizes when mouse hovers over

Whenever the mouse hovers over any image it changes the size slightly and restores when it leaves the area. That becomes annoying when mouse is moving across Obsidian UI. With no custom theme this doesn't happen. Can you please disable this behavior? Thanks

Hey! I don't notice this behavior on my system, but it would definitely infuriate me - so I'll fix it)
Can you clarify:

what is your operating system - windows, mac, linux?
what version of obsidian?
is the bug reproduced at any screen resolution? (in case you use multiple monitors with different resolutions)
the bug is reproduced if at least one note is open, or you need to open several (if several - then from how many and how the panels are located)?

Windows 10 Pro build 21359
Obsidian 0.11.5
I'm using the built-in monitor of my notebook which is at 1080P resolution
Reproducible with one note open
Just another piece of info in case it matters, the behavior also exists with Obsidian dark rmx by _ph that yours is based on.


Deduplicate cop documentation and cop descriptions like rubocop-rspec

I refactored part of our configuration a while back for rubocop-rspec and I'm pretty happy with it. See https://github.com/backus/rubocop-rspec/pull/174. Basically, all of the cop documentation had something like this
module RuboCop
  module Cop
    module RSpec
      # Check for test expectations that can use `be` instead of `eql`
      #
      # (longer description snipped)
      #
      # (examples section snipped)
      #
      # (more long form description snipped)
      #
      class BeEql < Cop
      end
    end
  end
end

and the configuration description is subtly different for (IMO) no good reason:
RSpec/BeEql:
  Description: 'Check for expectations where `be(...)` can be used instead of `eql(...)`'
  Enabled: true

We now have a build command you can execute (bin/build_config) that will parse the YARD documentation and write the leading docstring to the configuration. This is run in CI too so these don't fall out of sync. I think this is a nice change because it removes a lot of duplicated work.
I would be happy to eventually help upstream this functionality to rubocop. It would be harder since your configuration files are heavily commented and spread across multiple config files. It still would be worth it though I think.

Yeah, something like this has been on my mind for a long time now.
The current way we do things is simply a remnant of the very early days of the project when this was a marginal concern compared to implementing more and more cops. It should definitely be improved at some point - I'd appreciate your help with it. I want the cop's source documentation to be the single source of truth for sure.

I guess we can revisit this after @Darhazer is done with the metadata epic, as those are somewhat related. That might also remove the need for inline documentation of the various options in the config file, although that'd assume that all those options are properly documented in the cop sources.

I will take a stab at this. Feel free to assign me.
To paraphrase - this change should make the cop itself the single source of truth for descriptions.
Deliverables:

:build_config_descriptions task that updates our central config file descriptions with the cops themselves
:confirm_config task to be checked in CI to enforce these are in sync

That might also remove the need for inline documentation of the various options in the config file, although that'd assume that all those options are properly documented in the cop sources.

I think this could indeed be built on top of this logic. But probably in another PR, or multiple PRs that update cop docs with the options before making them the single source of truth for this info.

Unfortunately enough, due to a deficiency in LibYAML, it is impossible presently to parse and dump comments, which we have plenty in config/default.yml. So for now, extracting and keeping in sync config/default.yml basing on YARD cop code docs' description doesn't seem to be possible.
I suggest postponing this to a later version (currently the milestone is set to 2.0).

Ok to remove this from Milestone 2.0, since we're blocked with this on LibYAML?


Error on create a new container

Expected behavior
Actual behavior
Information about the Issue
Steps to reproduce the behavior

... Create a new Container
... (HTTP code 500) server error - {"message":"Get https://registry-1.docker.io/v2/: dial tcp: lookup registry-1.docker.io on [::1]:53: read udp [::1]:40511->[::1]:53: read: connection refused"}

Are you behind a firewall or VPN?
See our wiki for possible solutions:
https://github.com/docker/kitematic/wiki/Common-Proxy-Issues-&-Fixes


Version update: 0.2.6 -> 0.2.7

In order to let packagist.org pick up changes in repo, version needs to be incremented and new tag needs to be made based on master.

Hey @samcleaver
Can you please merge this change and make new tag based on master afterwards?
Thanks!

Updated and tagged -- many thanks @YevKov


Mobile Redesign - Absence calendar screen

The absence selection design should be setup in the yaki application.
Need to determine how to release the visual of the calendar

duplicate with #1098


Should the X509_V_ERR_ defines keep the same value in OSSL3?

Many (most?) of the X509_V_ERR_ values seem to be unchanged across versions of OpenSSL, but X509_V_ERR_INVALID_CA has changed for 3.0 (now 79, was 24).
Changing the value of the define is fine under recompilation, but if the library is used from languages that don't support ingesting C headers (such as C# p/invokes), or if the application uses a loose coupling via dylib then the changed value complicates the caller's understanding.
In case there's a project goal to not change the define values, but this one got missed, it seemed prudent to ask the question before doing the work to work around the complication.
1.1.1:
https://github.com/openssl/openssl/blob/c2fc1115eac53d2043e09bfa43ac5407f87fe417/include/openssl/x509_vfy.h#L118-L127
3.0 (current):
https://github.com/openssl/openssl/blob/a2a5506b9329b978a2a5b11a518b9789446ad310/include/openssl/x509_vfy.h.in#L154-L163

3.0 is a major release.  Recompilation is expected.
A binary compatible release would not change these error numbers.  3.0 was never intended to be binary compatible.

3.0 is a major release.  Recompilation is expected.
A binary compatible release would not change these error numbers.  3.0 was never intended to be binary compatible.


Use nonroot user

I was trying to test this but couldn't figure out how to bash into it. @stephen-frank, does the base image have bash?
heslinge at 12:19:34 in ~/Repos/Wattile (run-docker-as-non-root)
🌟 docker run 2f81bf21e1d4 -it bin/bash
python: can't open file '/usr/src/app/bin/bash': [Errno 2] No such file or directory
>>>

I really don't know! But if the entry point is python is it a python prompt?
https://github.com/NREL/Wattile/blob/develop/Dockerfile#L18C1-L18C22

I ran into this by having Python write files in Linux... it created them as root.root. So I think you could test it by creating a new file and then reading back its user and group?

I really don't know! But if the entry point is python is it a python prompt?
https://github.com/NREL/Wattile/blob/develop/Dockerfile#L18C1-L18C22

docker run 2f81bf21e1d4 -it bin/bash overwrite the enterpoint as bin/bash

Ok, I see.

I haven't been able to test this yet. I'd like to test it with the SkySpark dev server. Can you explain what these lines do?
# use non root user.
RUN groupadd -r user && useradd -r -g user user
USER user

ENTRYPOINT ["python"]

Does this add a user called "user" and a group called "user" and make Docker run as that user? If yes, is it possible to make the user a Docker build argument?

I think I answered my own question; going to test over here... https://github.com/NREL/nrelWattileExt/pull/42

closed cause https://github.com/NREL/Wattile/pull/302


Code Quality: Reduce Tutorial code duplication

closed in https://github.com/sopra-fs23-group-37/client/pull/205/commits/d5a80a4ab191b0959649c8c2e05fec7a3ddf9d1f


Rework

Summary

Add HTTP::Schema and HTTP::Attribute
Add custom HTTP::MapperCompiler
Remove manual transformations in favor of auto-mapping feature from core
Remove applying transformations in insert/update - this type of functionality is not supported by core and it's actually something we intentionally do not want to have. Input that doesn't match canonical data structures can be handled by changesets with their mappings
Refactor Dataset so that it only uses its options
Remove Dataset#name as it felt like additional complexity
Remove Dataset::ClassInterface (we're in beta phase, no need to go through deprecation cycles)
Add Dataset#{get?,post?,put?,delete?}
Remove HTTP::Relation#wrap as this is now a core method and it does something else
Simplify specs

@AMHOL @cflipse @flash-gordon @timriley ding dong, please check this out. I'd love to get it done and add a couple features (associations mostly and a built-in json adapter specialization) on top of this rework.

Looks okay so far

@solnic can this branch be deleted?


Don’t propagate RESET event from switch router to nested stack routers

software
version

react-navigation
3.3.2

react-navigation/core
3.1.0

react-native
https://github.com/expo/react-native/archive/sdk-32.0.0.tar.gz

This pull request fixes the error "There is no route defined for key..." when you supply RESET event to your root StackRouter and it is passed down to one of your nested StackRouters.
Bug:
video: https://drive.google.com/file/d/1QJvZ_C47xLAfXpb6YJfwFQsT2XRSf5Mv/view
snack: https://snack.expo.io/@serhiipalash/test-react-navigation-reset
repo: https://github.com/serhiipalash/test-react-navigation-reset
screenshot:

There is no sense to spread root StackRouter RESET event to all nested StackRouters. You can do like this only if all your StackRouters are isomorphic to each other (have the same routes and configs). In that case potentially your can raise event “Reset to HomeScreen” and your root StackRouter and all your nested StackRouters will fall back to their HomeScreen as they all have it. But if your nested stack routers are not isomorphic to your root stack router (more realistic case), there will be an error “There is no route defined for key HomeScreen” caused by some of them.
This pull request adds “type” property to StackRouter and SwitchRouter and prevents passing down RESET event from SwitchRouter to its nested StackRouters.
To test this fix
git clone https://github.com/serhiipalash/test-react-navigation-reset
cd test-react-navigation-reset
git checkout -b fix-reset-event-propagation
npm install
expo start -c

video: https://drive.google.com/file/d/1QtHU4SqC0KlTA_9Bn_SZyu08ol7JHaqD/view
P.S. I am not sure why, but the bug happens only when you dispatch RESET event from SwitchRouter screen. When you do the same on one of root StackRouter screens, everything works fine.
https://drive.google.com/file/d/11PcjeIVmEieVJ-Ccw03rKae0hRiIst_x/view
P.P.S @ericvicenti can you please review this pr? If you remember, you reviewed one of my pr for fixing navigation reseting https://github.com/react-navigation/react-navigation/pull/3593.

P.S. I am not sure why, but the bug happens only when you dispatch RESET event from SwitchRouter screen. When you do the same on one of root StackRouter screens, everything works fine.

I've tested everything again and the bug could be fix by changing
function isResetToRootStack(action) {
  return action.type === StackActions.RESET && action.key === null;
}

to
function isResetToRootStack(action) {
  return action.type === StackActions.RESET && action.key == null;
}

in StackRouter.js
@ericvicenti, @brentvatne should I update this pr?

should I update this pr?

It's just I am not sure what is the expected behaviour for reseting navigation. Maybe you want user to be able to reset some part of app navigation without updating anything else (partial reseting)? Then we should only fix isResetToRootStack function, else we should prevent RESET event propagation in nested routers.

So, this may be a documentation/types problem, but it looks like your reset action is lacking a key.
NavigationActions.reset({
  key: 'myStack', // key of the parent navigation state (if there is a parent navigator, route.key)
  index: 1,
  routes: [{...}, {...}],
});

Maybe you want user to be able to reset some part of app navigation without updating anything else (partial reseting)?

Exactly right. The key is provided to target which stack needs to be reset. By specifying the key, the behavior will not get passed down to children routers.

So I don't think this change is necessary. But we should make it clear that key is required with the reset action, maybe by throwing an error.

fwiw "reset" is a bit awkward and i'd really love for this to be implemented: https://github.com/react-navigation/rfcs/issues/70

So I don't think this change is necessary. But we should make it clear that key is required with the reset action, maybe by throwing an error.

@ericvicenti Ok, I understand. This seems like a breaking change, as I don't remember that "key" was required before, and without the "key" navigation can crash depending on the screen where you try to use RESET.

Maybe we can just work with undefined as null in "key" prop and make the docs synced with the code in this way?
function isResetToRootStack(action) {
  return action.type === StackActions.RESET && action.key == null;
}

Another question, why does RESET action can crash the app in any way? Why if I have screens "Home", "Settings" and try to reset to "Profile", app will crash with error "There is no route defined for key Profile"? In opposite, when I have screens "Home" and "Settings" and try to navigate to "Profile", nothing happens. This should be an intended behaviour of any action - if it can't be processed, it should do nothing, IMHO. I can create a pr for this, if you want to.

@serhiipalash - i think the best option here is to change the StackActions.reset creator so that if key is not provided then key defaults to null. https://github.com/react-navigation/react-navigation-core/blob/master/src/routers/StackActions.js#L23-L26

i think the best option here is to change the StackActions.reset creator so that if key is not provided then key defaults to null.

I made a new pr https://github.com/react-navigation/react-navigation-core/pull/44
I tested its changes in https://github.com/serhiipalash/test-react-navigation-reset and everything works fine both when key is missing (root stack is reseted) and when it is set to nested navigator key (Profile stack is reseted).


Flaky e2e_reject_offer

https://github.com/get10101/10101/actions/runs/7969843098/job/21756644996?pr=2070#step:10:493

Maybe we just need to increase the number of available UTXOs for the app/coordinator.

We just need to wait a bit longer before we try to submit another channel-opening order!


⚠ Bofrost.nl has degraded performance

In 9587265, Bofrost.nl (https://www.bofrost.nl) experienced degraded performance:

HTTP code: 200
Response time: 841 ms

Resolved: Bofrost.nl performance has improved in 4c3b421.


feat(core): eagerly load extension sources

Codecov Report
Attention: Patch coverage is 81.67539% with 35 lines in your changes are missing coverage. Please review.

Project coverage is 80.34%. Comparing base (c43ac7e) to head (75e59b1).

Files
Patch %
Lines

core/extension_set.rs
65.38%
27 Missing :warning:

core/fast_string.rs
50.00%
3 Missing :warning:

core/runtime/jsruntime.rs
96.07%
2 Missing :warning:

testing/checkin/runner/ts_module_loader.rs
85.71%
2 Missing :warning:

core/extensions.rs
0.00%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #633      +/-   ##
==========================================
- Coverage   80.44%   80.34%   -0.10%
==========================================
  Files          97       97
  Lines       23763    23774      +11
==========================================
- Hits        19116    19102      -14
- Misses       4647     4672      +25

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Remaining stylx's from #83

Upgrade stylx's to Pro 1.1 see: #83

Assigning to @Dbarnes1 to verify & merge (just contact when you are ready & want to go over this process)

@abouffard is going to need the Pro 1.1 mil2525c.stylx to test the Mil2525 D->C SIDC converter ( https://github.com/Esri/military-feature-toolbox/pull/24 ) so assigning this PR to him.

...and assigning back to @Dbarnes1 ...


wrapper script

I'd like to wrap the whole weekly procedure in one script to make it really easy on the next librarian/Mike. My plan is to import the /bin scripts I need as modules, and essentially copy-paste the stuff under 'if name==main' into my wrapper script, to run it all in one go.

Already hitting a roadblock:
Traceback (most recent call last):
File "/groups/scicompsoft/home/scarlettv/dis-utilities/utility/bin/weekly_pubs.py", line 42, in
update_dois.initialize_program()
File "/groups/scicompsoft/home/scarlettv/dis-utilities/sync/bin/update_dois.py", line 105, in initialize_program
if ARG.TARGET == 'dis':
NameError: name 'ARG' is not defined
I think the problem is that this function relies on ARG variables that were defined in the namespace of that running program. A solution would be to rewrite the function to pass ARG.TARGET and ARG.MANIFOLD as command-line args.

Use a shell script instead


Revert #15025

See https://github.com/gradle/gradle-private/issues/3228

@bot-gradle test QF

OK, I've already triggered QuickFeedback build for you.


Added dark mode to DappBrowserNavigationBar and ButtonsBarBackgroundView

On the main wallet menu, tap the ... button on the upper right corner, then tap buy crypto or rename wallet.

Discovered more screens that need to be updated.


Log version negotiation frame

Currently, Quiche does not log received version negotiation frames to qlog. Since the default wire version of quiche is babababa, it might cause some confusion if a user is checking the qlog of quiche-client.

Confirmed. This is caused by a minor bug inside quiche, we just need to get around to fixing it. Thanks for the report @triplewy .


[Age-viewer-Go] API function for disconnecting databse and Docs for backend added

[Age-viewer-Go] API function for disconnecting databse and Docs for backend added

@aked21 Please merge, I have checked


Create Queue.c

this is the code for the queue Data structure using linked list

Hacktoberfest-2023 accepted


Assignment 1

Hey team,
I just started with the code review. Will update my progress/issues here.
Thanks,
Nawaz

Hello Team,
Please update the wiki as soon as possible with steps to checkout and run your project in linux environment.
I am unable to follow steps to run virtual env for linux.

Hi Nawaz,
We have created separate instructions for Linux platform.
Link for the same is https://github.com/airavata-courses/CookieArmy/wiki/Release-Instructions-Linux
Thanks
CookieArmy

Hey Team,
I see a lot of effort has been put in writing the documentation of your project. Kudos for that!
I still facing some issues with the installation, Please follow up with me on Slack.
Regards,
Nawaz

Hey Team,
I followed all the steps mentioned on the Linux release date.

This is error I got on running the final step.
Can you help me resolve this?

Hello Nawaz,
Could you try
sudo npm install --save-dev --unsafe-perm node-sass

Sure, which branch do I run the above command?

This issue was faced earlier and was solved using the steps mentioned in the issue attached.
please run the command on the hybrid mobile app.
https://github.com/airavata-courses/CookieArmy/issues/26

Do mention this page in your wiki on installing mysql https://www.digitalocean.com/community/tutorials/how-to-install-mysql-on-ubuntu-18-04

Hey Team,
Great job on the project! It is working good and I could login and check for available rides.
Here is my summary:

When I book a ride, should I be seeing it in the requested ride as well? I could not see it in this demo.
Rides posted page is blank even though I had created new rides. Is this something expected?

Related to project:

Please come up with test cases to test your functionality. It is highly recommended as we progress in the project.
Please streamline your documentation.

Apart from that, Kudos for the effort! Its a great project!
Keep up the good work!
Thanks,
Nawaz

Hi Nawaz,

we have not added requested ride in Project 1, would be added in future releases.
Rides Posted page has not been added yet.

Related to project.

We did not know that we have to add test cases in documentation for each micro service. we would update to it.

Oh no, you need not mention test cases in the documentation.
Suggestion 1 in "related to projects" was for java service. On building the service, it built the jar successfully without checking if there was a connection with the DB.
If there was a test case to test the connection at the time of building the jar, we would not face run time SQLConnectionException.
Including a test case to check it would definitely help you in the future builds.


Fix CI error

https://github.com/fzyzcjy/flutter_smooth/actions/runs/3310275240/jobs/5464296839

e.g.
2022-10-24T05:37:55.0748627Z diff --git a/data/comments/raw/github_flutter_engine_36775.json b/data/comments/raw/github_flutter_engine_36775.json
2022-10-24T05:37:55.0749205Z index 3545089..e9c8fd0 100644
2022-10-24T05:37:55.0749774Z --- a/data/comments/raw/github_flutter_engine_36775.json
2022-10-24T05:37:55.0750497Z +++ b/data/comments/raw/github_flutter_engine_36775.json
2022-10-24T05:37:55.0750854Z @@ -1 +1 @@
2022-10-24T05:37:55.0763540Z -{"source": "github", "metadata": {"org": "flutter", "repo": "engine", "issue": 36775}, "content": {"author": {"login": "fzyzcjy"}, "body": "Firstly, we know `VSYNC` event in timeline is special - `chrome://tracing` tool will show \"zebra\" colors (gray and white) at every VSYNC. Therefore, it is critical to let this event have correct timing, otherwise every user is doing reasoning with the wrong vsync time.\r\n\r\nIn the image below, the \"a\" shows the new VSYNC with this PR, while the \"b\" shows the old VSYNC interval before this PR. As we can see, the left side of \"a\" and \"b\" does not coincide. In other words, before this PR (where we have \"b\" as the VSYNC and there is no \"a\"), we consider the wrong time as the vsync time.\r\n\r\nThe cause is quite simple: Before this PR, the left edge of \"VSYNC\" event is (for example) the call time of `VsyncWaiterAndroid::OnVsyncFromJava`. However, there exist \"frame delay\" (e.g. `frameDelayNanos` argument in `OnVsyncFromJava`), so the real vsync time should minus that delay.\r\n\r\nAs a side remark, in the image below the difference is not very much, but in real scenarios, I have seen once in a while it has large differences. Then you know, the visualization goes wild, and it took me some time before I realized, it is not a bug in code anywhere, but a bug of the VSYNC event time.\r\n\r\n![image](https://user-images.githubusercontent.com/5236035/195964378-c509e647-7740-4e87-a19e-30fa4fee9221.png)\r\n\r\n\r\nClose #113475\r\n\r\n## Pre-launch Checklist\r\n\r\n- [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.\r\n- [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities.\r\n- [x] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].\r\n- [x] I listed at least one issue that this PR fixes in the description above.\r\n- [ ] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on\r\nwriting and running engine tests.\r\n- [x] I updated/added relevant documentation (doc comments with `///`).\r\n- [x] I signed the [CLA].\r\n- [x] All existing and new tests are passing.\r\n\r\nIf you need help, consider asking for advice on the #hackers-new channel on [Discord].\r\n\r\n<!-- Links -->\r\n[Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview\r\n[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene\r\n[Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo\r\n[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style\r\n[testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine\r\n[CLA]: https://cla.developers.google.com/\r\n[flutter/tests]: https://github.com/flutter/tests\r\n[breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes\r\n[Discord]: https://github.com/flutter/flutter/wiki/Chat\r\n", "comments": [{"author": {"login": "flutter-dashboard"}, "authorAssociation": "NONE", "body": "It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need [an exemption](https://github.com/flutter/flutter/wiki/Tree-hygiene#tests) to this rule, contact Hixie on the #hackers channel in [Chat](https://github.com/flutter/flutter/wiki/Chat) (don't just cc him here, he won't see it! *He's on Discord!*).\n\nIf you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, **is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?**\n\n__Reviewers__: Read the [Tree Hygiene page](https://github.com/flutter/flutter/wiki/Tree-hygiene#how-to-review-code) and make sure this patch meets those guidelines before LGTMing.", "createdAt": "2022-10-15T02:26:29Z", "includesCreatedEdit": false, "isMinimized": false, "minimizedReason": "", "reactionGroups": []}], "createdAt": "2022-10-15T02:11:34Z", "title": "Fix wrong `VSYNC` event"}}
2022-10-24T05:37:55.0771666Z \ No newline at end of file
2022-10-24T05:37:55.0829333Z +{"source": "github", "metadata": {"org": "flutter", "repo": "engine", "issue": 36775}, "content": {"author": {"login": "fzyzcjy"}, "body": "Firstly, we know `VSYNC` event in timeline is special - `chrome://tracing` tool will show \"zebra\" colors (gray and white) at every VSYNC. Therefore, it is critical to let this event have correct timing, otherwise every user is doing reasoning with the wrong vsync time.\r\n\r\nIn the image below, the \"a\" shows the new VSYNC with this PR, while the \"b\" shows the old VSYNC interval before this PR. As we can see, the left side of \"a\" and \"b\" does not coincide. In other words, before this PR (where we have \"b\" as the VSYNC and there is no \"a\"), we consider the wrong time as the vsync time.\r\n\r\nThe cause is quite simple: Before this PR, the left edge of \"VSYNC\" event is (for example) the call time of `VsyncWaiterAndroid::OnVsyncFromJava`. However, there exist \"frame delay\" (e.g. `frameDelayNanos` argument in `OnVsyncFromJava`), so the real vsync time should minus that delay.\r\n\r\nAs a side remark, in the image below the difference is not very much, but in real scenarios, I have seen once in a while it has large differences. Then you know, the visualization goes wild, and it took me some time before I realized, it is not a bug in code anywhere, but a bug of the VSYNC event time.\r\n\r\n![image](https://user-images.githubusercontent.com/5236035/195964378-c509e647-7740-4e87-a19e-30fa4fee9221.png)\r\n\r\n\r\nClose #113475\r\n\r\n## Pre-launch Checklist\r\n\r\n- [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.\r\n- [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities.\r\n- [x] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].\r\n- [x] I listed at least one issue that this PR fixes in the description above.\r\n- [ ] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on\r\nwriting and running engine tests.\r\n- [x] I updated/added relevant documentation (doc comments with `///`).\r\n- [x] I signed the [CLA].\r\n- [x] All existing and new tests are passing.\r\n\r\nIf you need help, consider asking for advice on the #hackers-new channel on [Discord].\r\n\r\n<!-- Links -->\r\n[Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview\r\n[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene\r\n[Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo\r\n[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style\r\n[testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine\r\n[CLA]: https://cla.developers.google.com/\r\n[flutter/tests]: https://github.com/flutter/tests\r\n[breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes\r\n[Discord]: https://github.com/flutter/flutter/wiki/Chat\r\n", "comments": [{"id": "IC_kwDOAlZRSc5MRbTz", "author": {"login": "flutter-dashboard"}, "authorAssociation": "NONE", "body": "It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need [an exemption](https://github.com/flutter/flutter/wiki/Tree-hygiene#tests) to this rule, contact Hixie on the #hackers channel in [Chat](https://github.com/flutter/flutter/wiki/Chat) (don't just cc him here, he won't see it! *He's on Discord!*).\n\nIf you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, **is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?**\n\n__Reviewers__: Read the [Tree Hygiene page](https://github.com/flutter/flutter/wiki/Tree-hygiene#how-to-review-code) and make sure this patch meets those guidelines before LGTMing.", "createdAt": "2022-10-15T02:26:29Z", "includesCreatedEdit": false, "isMinimized": false, "minimizedReason": "", "reactionGroups": [], "url": "https://github.com/flutter/engine/pull/36775#issuecomment-1279636723", "viewerDidAuthor": false}], "createdAt": "2022-10-15T02:11:34Z", "title": "Fix wrong `VSYNC` event"}}
2022-10-24T05:37:55.0836429Z \ No newline at end of file

(base) ➜  flutter_smooth git:(master) ✗ gh --version
gh version 2.14.3 (2022-07-26)
https://github.com/cli/cli/releases/tag/v2.14.3

A new release of gh is available: 2.14.3 → 2.18.1
To upgrade, run: brew update && brew upgrade gh
https://github.com/cli/cli/releases/tag/v2.18.1

maybe should upgrade my local gh?

2022-10-24T05:44:08.0596338Z diff --git a/data/comments/raw/github_flutter_engine_36856.json b/data/comments/raw/github_flutter_engine_36856.json
2022-10-24T05:44:08.0596735Z index 6d72ee0..ec1bfd4 100644
2022-10-24T05:44:08.0597165Z --- a/data/comments/raw/github_flutter_engine_36856.json
2022-10-24T05:44:08.0597543Z +++ b/data/comments/raw/github_flutter_engine_36856.json
2022-10-24T05:44:08.0598230Z @@ -1 +1 @@
2022-10-24T05:44:08.0605250Z -{"source": "github", "metadata": {"org": "flutter", "repo": "engine", "issue": 36856}, "content": {"author": {"login": "fzyzcjy"}, "body": "Hope there exist a more lightweight way to fix typos...\r\n\r\n*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*\r\n\r\n*List which issues are fixed by this PR. You must list at least one issue.*\r\n\r\n*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*\r\n\r\n## Pre-launch Checklist\r\n\r\n- [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.\r\n- [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities.\r\n- [x] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].\r\n- [ ] I listed at least one issue that this PR fixes in the description above.\r\n- [x] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on\r\nwriting and running engine tests.\r\n- [x] I updated/added relevant documentation (doc comments with `///`).\r\n- [x] I signed the [CLA].\r\n- [ ] All existing and new tests are passing.\r\n\r\nIf you need help, consider asking for advice on the #hackers-new channel on [Discord].\r\n\r\n<!-- Links -->\r\n[Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview\r\n[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene\r\n[Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo\r\n[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style\r\n[testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine\r\n[CLA]: https://cla.developers.google.com/\r\n[flutter/tests]: https://github.com/flutter/tests\r\n[breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes\r\n[Discord]: https://github.com/flutter/flutter/wiki/Chat\r\n", "comments": [{"id": "IC_kwDOAlZRSc5MfCec", "author": {"login": "fzyzcjy"}, "authorAssociation": "CONTRIBUTOR", "body": "My bad, it is correct :)", "createdAt": "2022-10-19T00:57:58Z", "includesCreatedEdit": false, "isMinimized": false, "minimizedReason": "", "reactionGroups": [], "url": "https://github.com/flutter/engine/pull/36856#issuecomment-1283205020", "viewerDidAuthor": true}], "createdAt": "2022-10-19T00:56:17Z", "title": "Maybe another typo (2 char only)"}}
2022-10-24T05:44:08.0609475Z \ No newline at end of file
2022-10-24T05:44:08.0617082Z +{"source": "github", "metadata": {"org": "flutter", "repo": "engine", "issue": 36856}, "content": {"author": {"login": "fzyzcjy"}, "body": "Hope there exist a more lightweight way to fix typos...\r\n\r\n*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*\r\n\r\n*List which issues are fixed by this PR. You must list at least one issue.*\r\n\r\n*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*\r\n\r\n## Pre-launch Checklist\r\n\r\n- [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.\r\n- [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities.\r\n- [x] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].\r\n- [ ] I listed at least one issue that this PR fixes in the description above.\r\n- [x] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on\r\nwriting and running engine tests.\r\n- [x] I updated/added relevant documentation (doc comments with `///`).\r\n- [x] I signed the [CLA].\r\n- [ ] All existing and new tests are passing.\r\n\r\nIf you need help, consider asking for advice on the #hackers-new channel on [Discord].\r\n\r\n<!-- Links -->\r\n[Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview\r\n[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene\r\n[Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo\r\n[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style\r\n[testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine\r\n[CLA]: https://cla.developers.google.com/\r\n[flutter/tests]: https://github.com/flutter/tests\r\n[breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes\r\n[Discord]: https://github.com/flutter/flutter/wiki/Chat\r\n", "comments": [{"id": "IC_kwDOAlZRSc5MfCec", "author": {"login": "fzyzcjy"}, "authorAssociation": "CONTRIBUTOR", "body": "My bad, it is correct :)", "createdAt": "2022-10-19T00:57:58Z", "includesCreatedEdit": false, "isMinimized": false, "minimizedReason": "", "reactionGroups": [], "url": "https://github.com/flutter/engine/pull/36856#issuecomment-1283205020", "viewerDidAuthor": false}], "createdAt": "2022-10-19T00:56:17Z", "title": "Maybe another typo (2 char only)"}}
2022-10-24T05:44:08.0621195Z \ No newline at end of file


Add Duncan Fermor to Contributors list

Testing the open-source waters with a trial contribution.
Thanks,
Duncan

Hi  @Peregrine42, I'm quite elated about your pull request. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a pull request and learned that I merged it?
We’ve recently added social share  to our web app. Could you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.


Webpack 5 - Memory Leak

Bug report

What is the current behavior?
When I make a change in my web app and Webpack compiles, memory usage seems to increase. If I keep making changes and Webpack keeps re-compiling, memory usage will continue to climb. In a large project I work in, it takes about 10 compilations until Webpack crashes with a "Allocation failed - JavaScript heap out of memory" exception.
If the current behavior is a bug, please provide the steps to reproduce.

Please see the minimal repo I created to reproduce the issue: https://github.com/smparsons/webpack-memory-leak-issue. The instructions to reproduce are on the README.
What is the expected behavior?

I would expect some kind of garbage collection to happen in between compilations.
Other relevant information:
webpack version: 5.0.0-beta.15
Node.js version: 11.10.1
Operating System: macOS Catalina Version 10.15
Additional tools:

Do not use any kind of hash in the filename during development when using webpack-dev-middleware. Each compilation will create a new file as filename changes. Just like files will pile up on disk, they will pile up in memory as the webpack-dev-middleware stores output files in memory.

Got it. That makes my problem go away during development.
However, I noticed that in my project when I build in production mode (where I am using hash in the filenames), I also get a Javascript heap out of memory error.
I updated my repo with new instructions and some changes so you can reproduce the issue: https://github.com/smparsons/webpack-memory-leak-issue
What I did to sort of "simulate" a large amount of code is created a few files with tons of console log statements. You'll see that "npm run start" works fine but "npm run build" doesn't work.
Let me know if I need to make a new issue and I can do that.

It works for me, but it's near the memory limit.
But that it needs a lot of memory is not related to having a memory leak.
For larger builds you need to increase the node memory limit, which is pretty low by default.

Got it. I'll open up another issue if I see anything else. Thanks for the help.

This one does the trick, right?
{
    output: {
      filename: mode === 'production' ? '[chunkhash].js' : '[name].js',
      chunkFilename: mode === 'production' ? '[chunkhash].js' : '[name].js',
    },
}


SEQ-7207: parallel assembly.

This PR is for parallelization of assembly, alignment, and genotyping across many nodes. To this end, I extracted that execution path from run_metasv into asm_sc_intervals, which is called by run_metasv when in standalone mode. To allow for different run modes, --disable_assembly is replaced (albeit still supported) by --assembly=?, where ? is either run, disable, defer, parallel, or merge. The last three values summon the new features, as briefly explained in the changes to index.html. Those new run modes come with additional arguments for slicing work across nodes and for which sliced result files to merge. In addition to run_metasv, main.py now also has run_distributed_assembly and run_merge_assembly_sliced to support the new modes of execution. These entry points are resolved by the existing launcher function in scripts/run_metasv. The should not affect existing workflows and features. For example, the alternative entry points in run_spades.py and run_age.py still exist, and --nthreads can still be used, e.g. people who use LSF with -n can use multiple threads on each parallel worker. Please do not merge yet - intended for review, discussion, testing, and fixes.

Thanks @sbandara. The parallelization changes are similar to what I had in mind, especially the case checks for nthreads > 1.

Looks good to me for now.

Looks good to me too.

Thanks everyone for the quick review! Before merging, we should still check off the following:

[ ] Resolve RES-119. It looks like any fix will also take care of RES-113. Merge conflicts unlikely here because changes probably localized to generate_sv_intervals.py only.
[ ] Much more testing with different slicing parameters on both Mac and Linux. Will certainly do that as part of SEQ-7163.

Any timeline on this, @sbandara ? I am planning on upping the MetaSV version tomorrow.

Sure, I can back-merge and resolve the conflicts tonight.

Limping behing on this one too much. It would be nice if I could contribute in smaller chunks soon.


Master had an additional commit not in develop

Changed 'less' to 'fewer' in an error message. Patch from @tempoz
I found a commit in boost format master branch not in develop:
jking@ubuntu:~/boost/libs/format$ git checkout master
Switched to branch 'master'
Your branch is up-to-date with 'origin/master'.
jking@ubuntu:~/boost/libs/format$ git blame include/boost/format/exceptions.hpp | grep '  7'
0fde2d2b (Gennaro Prota 2006-07-20 13:36:16 +0000   7) // Distributed under the Boost Software License, Version 1.0.
18785faa (Samuel Krempp 2004-01-24 17:33:18 +0000  70)             too_many_args(std::size_t cur, std::size_t expected)
18785faa (Samuel Krempp 2004-01-24 17:33:18 +0000  71)                 : cur_(cur), expected_(expected) {}
beb10ca1 (Samuel Krempp 2004-01-21 11:51:23 +0000  72)             std::size_t get_cur() const { return cur_; }
beb10ca1 (Samuel Krempp 2004-01-21 11:51:23 +0000  73)             std::size_t get_expected() const { return expected_; }
beb10ca1 (Samuel Krempp 2004-01-21 11:51:23 +0000  74)             virtual const char *what() const throw() {
beb10ca1 (Samuel Krempp 2004-01-21 11:51:23 +0000  75)                 return "boost::too_many_args: "
d8053752 (Marshall Clow 2015-05-18 08:34:53 -0700  76)                     "format-string referred to fewer arguments than were passed";
beb10ca1 (Samuel Krempp 2004-01-21 11:51:23 +0000  77)             }
beb10ca1 (Samuel Krempp 2004-01-21 11:51:23 +0000  78)         };
beb10ca1 (Samuel Krempp 2004-01-21 11:51:23 +0000  79)

jking@ubuntu:~/boost/libs/format$ git checkout develop
Switched to branch 'develop'
Your branch is up-to-date with 'origin/develop'.
jking@ubuntu:~/boost/libs/format$ git blame include/boost/format/exceptions.hpp | grep '  7'
fe2c3f37 (Gennaro Prota 2006-07-20 12:13:16 +0000   7) // Distributed under the Boost Software License, Version 1.0.
18785faa (Samuel Krempp 2004-01-24 17:33:18 +0000  70)             too_many_args(std::size_t cur, std::size_t expected)
18785faa (Samuel Krempp 2004-01-24 17:33:18 +0000  71)                 : cur_(cur), expected_(expected) {}
beb10ca1 (Samuel Krempp 2004-01-21 11:51:23 +0000  72)             std::size_t get_cur() const { return cur_; }
beb10ca1 (Samuel Krempp 2004-01-21 11:51:23 +0000  73)             std::size_t get_expected() const { return expected_; }
beb10ca1 (Samuel Krempp 2004-01-21 11:51:23 +0000  74)             virtual const char *what() const throw() {
beb10ca1 (Samuel Krempp 2004-01-21 11:51:23 +0000  75)                 return "boost::too_many_args: "
fe2c3f37 (Gennaro Prota 2006-07-20 12:13:16 +0000  76)                     "format-string referred to less arguments than were passed";
beb10ca1 (Samuel Krempp 2004-01-21 11:51:23 +0000  77)             }
beb10ca1 (Samuel Krempp 2004-01-21 11:51:23 +0000  78)         };
beb10ca1 (Samuel Krempp 2004-01-21 11:51:23 +0000  79)

jking@ubuntu:~/boost/libs/format$ git show d8053752
commit d80537520b8aeaa51271acfd2eeb3c6a522fb04e
Author: Marshall Clow<EMAIL_ADDRESS>Date:   Mon May 18 08:34:53 2015 -0700

    Changed 'less' to 'fewer' in an error message. Patch from @tempoz

diff --git a/include/boost/format/exceptions.hpp b/include/boost/format/exceptions.hpp
index 9b2de83..56ee30d 100644
--- a/include/boost/format/exceptions.hpp
+++ b/include/boost/format/exceptions.hpp
@@ -73,7 +73,7 @@ namespace boost {
             std::size_t get_expected() const { return expected_; }
             virtual const char *what() const throw() {
                 return "boost::too_many_args: "
-                    "format-string referred to less arguments than were passed";
+                    "format-string referred to fewer arguments than were passed";
             }
         };

I remember screwing this up; I thought that I fixed it in develop as well. Apparently not. Thanks.

@eldiener can you merge develop into master so this and the ubsan fix are in the next release?  Should items in boost trac be marked as resolved when they are fixed in develop, and then a milestone added when the fix is merged into master?  What's the protocol there?  Thanks.

I usually note in the Trac ticket the commit that fixed it in develop, and close the ticket when things get merged to master.

I will merge into master when the regression tests cycle. That is usually in about a week.


[EventRequest] Tab 37 Sales Line

Due to Polish Localization App building, we need a publisher in Table 37. Polish localization modifies how the prepayment amount to deduct is calculated and we need to overwrite the standard behaviour
Function: CalcPrepaymentToDeduct
BEGIN
// START/BC14PL
IsHandled := false;
OnBeforeCalcPrepaymentToDeduct(Rec, IsHandled);
IF IsHandled THEN
EXIT;
// STOP/ BC14PL
IF ("Qty. to Invoice" <> 0) AND ("Prepmt. Amt. Inv." <> 0) THEN BEGIN
GetSalesHeader;
IF ("Prepayment %" = 100) AND NOT IsFinalInvoice THEN
"Prepmt Amt to Deduct" := GetLineAmountToHandle("Qty. to Invoice")
ELSE
"Prepmt Amt to Deduct" :=
ROUND(
("Prepmt. Amt. Inv." - "Prepmt Amt Deducted") *
"Qty. to Invoice" / (Quantity - "Quantity Invoiced"),Currency."Amount Rounding Precision")
END ELSE
"Prepmt Amt to Deduct" := 0
END;

Publisher signature: [Integration] LOCAL PROCEDURE OnAfterCalcPrepaymentToDeduct@229(VAR SalesLine@1000 : Record 37; VAR IsHandled@1001 : Boolean);

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


Add task returns "There is no working folder mapping for......" message and does nothing

Hi Jesse
I wonder if you can help please?
I am trying to add a zip file extracted as part of a build in the build artifact folder to a visual studio online/tfvc repository/project. I have added the "Add task" to the build process to add the file to the repository but it keeps returning the message "There is no working folder mapping for the targetfolderselected"
I think I am doing something wrong but not sure what to do.
Below is how I have setup the Add task

Is the "Files to add" meant to specify the destination file and if so is the source of the files to add meant to be specified or is this above what these tasks are meant for?

Many thanks in advance.

The add task assumes there is a workspace mapping for the folder you're
adding to.
In order to achieve your purpose you need to add a folder mapping to the
build definitions get sources step. Then copy the files to the
sources/whatever you mapped folder and then run add.
In theory you could invoke tf workfold to map the artefacts directory,
but my tasks currently don't directly support this.
I've been working on, but not at rapid pace, a bunch of new build tasks for
tfvc that would Include a recipe to map&get additional files optionally in
a separate workspace.
On Tue, 27 Mar 2018, 23:08 aobubo856<EMAIL_ADDRESS>wrote:

Hi Jesse
I wonder if you can help please?
I am trying to add a zip file extracted as part of a build in the build
artifact folder to a visual studio online/tfvc repository/project. I have
added the "Add task" to the build process to add the file to the repository
but it keeps returning the message "There is no working folder mapping for
the targetfolderselected"
I think I am doing something wrong but not sure what to do.
Below is how I have setup the Add task
[image: image]
https://user-images.githubusercontent.com/35798134/37994730-537b95ac-320a-11e8-8e6d-654cec4d51f3.png
Is the "Files to add" meant to specify the destination file and if so is
the source of the files to add meant to be specified or is this above what
these tasks are meant for?
[image: image]
https://user-images.githubusercontent.com/35798134/37995126-4e9cd0b8-320b-11e8-91d6-fd701db03152.png
[image: image]
https://user-images.githubusercontent.com/35798134/37995069-33ea62da-320b-11e8-8694-4e4555b824af.png
Many thanks in advance.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/jessehouwing/vsts-tfvc-tasks/issues/63, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AD-uS1hBU6Hng9-Q-OTUN-ilxtV29oUnks5tiqpogaJpZM4S9pHT
.

Fixed


global: installation slimdown

Slimdown installation. See individual commits for explanation.
Rebased against: #3371

done

s/remove/removal/

done

:shipit:


EDIT DATA

SQL Operations Studio Version: sqlops 0.23.6 (8a3011756318a2ded1e6e84332230a2b2bf9c544, 2017-11-06T21:51:43.232Z)
OS Version: Windows_NT x64 10.0.16299

Steps to Reproduce:
Data editor does not allow to change the select or order.

@juanfhoyo Edit data feature is in early preview form. Please keep filing issues / suggestions in that feature area. [help wanted]

This is huge. It is the biggest reason why I can't switch to this as my day to day over SSMS

Closing as duplicate of #78.  @corivera is currently implementing this feature by adding a SQL editor to the edit data document.


Refactor the collpasible component

Use the Web animation API to animate the collapsible
Extract the header in a separate component

@alizedebray is this issue still a thing?

No, it is not. I close it.


No 'compute_perturbation_metrics' from 'scgpt.utils'

Hello, I ran the perturbation tutorial and faced this error:

Traceback (most recent call last):
File "/scgpt_tutorial_perturbation.py", line 46, in
from scgpt.utils import set_seed, map_raw_id_to_vocab_id, compute_perturbation_metrics
ImportError: cannot import name 'compute_perturbation_metrics' from 'scgpt.utils' (/.local/lib/python3.10/site-packages/scgpt/utils/init.py)

I installed the 0.2.1 version of scgpt, I pulled up the 'utils/util.py' file but there is no function called 'compute_perturbation_metrics' in there.
Thank you!

Hi,
I am not the developer, but I also faced this issue.
I solved it by copying the "scgpt/utils/util.py" file from the GitHub to (/.local/lib/python3.10/site-packages/scgpt/utils/)
The file in the git hub has the functions, not sure why they are not present when installed via pip.
Hope it works for you


Add basic documentation on how to integrate Bevy into mobile applications

How can Bevy's documentation be improved?
The documentation on Bevy on mobile platforms is quite sparse. See https://github.com/bevyengine/bevy/discussions/10900.
We're currently missing directions on how to build using Android Studio, how to integrate with other apps via FFI, or how to call OS-level APIs for things such as notifications.
https://github.com/jinleili/bevy-in-app is a compelling piece of third party documentation / template that we should learn from and integrate into our own documentation.

@alice-i-cecile  btw the provided example has performance issue need Bevy creator’s guideline to improve rendering pipeline when Bevy implemented through SurfaceView in Android. I can help with documentation and improved example if someone help to explain render part in Bevy with custom window other than winit.

Isn't "how Bevy integrates with Android" the same as "How wgpu/winit integrates with Android"?

Yes and no: a holistic guide would be useful, and Bevy is likely to have additional setup steps at some points.

This is where I'm stuck. Bevy's example is stuck in old versions for dependencies. If I recreate bare project with android studio, the game crashes without error. It won't even attach debugger.


Allow to custom table search render

Our designer like to make crazy things and we need to adjust searchRender a bit.

Coverage decreased (-0.04%) to 75.913% when pulling 000ba5753d058915775814577088d96456b36b44 on Vallher:feature/custom-TableSearch into 47f844d013b7652928d1aaaef63f626c97455c28 on gregnb:master.

Would it not be better to just allow the passing of props to the search Component?

@jagribble The precedent in this library is to allow full customization of components where possible as this maximizes customization potential. I don't think that props would allow for the same things that a custom render would.
Additionally, this PR would satisfy some longstanding open issues like https://github.com/gregnb/mui-datatables/issues/608 and https://github.com/gregnb/mui-datatables/issues/91.

This PR would also solve https://github.com/gregnb/mui-datatables/issues/494.  Taking a closer look, my comment in that thread is incorrect. Since the TableSearch component is controlled, "handleSearch" can't be wrapped and still have the component work (since any debouncing would cause the text field not to update with one's typing). The only way to do what 494 wants is to use a different search component that isn't controlled.

@gabrielliwerant updated