Unable to use search parameters on resources imported via bulk import

Describe the bug
When I import a resource using the bulk import feature, I am unable to perform a search on this resource. The resource seems to be correctly imported though since it can be retrieved by its id or in the list of its resource type.
Everything works when the resource is created via a simple POST on the API.
To Reproduce

Import the following ndjson file containing one Patient resource

{"resourceType":"Patient","id":"1772b6bb75a-fd1b2296-6666-4ac1-8b06-f3651eebcc0a","meta":{"profile":["http://hl7.org/fhir/us/core/StructureDefinition/us-core-patient"]},"text":{"status":"generated","div":"
Generated by Synthea.Version identifier: master-branch-latest\n .   Person seed:<PHONE_NUMBER>487461664  Population seed:<PHONE_NUMBER>419
"},"extension":[{"url":"http://hl7.org/fhir/us/core/StructureDefinition/us-core-race","extension":[{"url":"ombCategory","valueCoding":{"system":"urn:oid:2.16.840.1.113883.6.238","code":"2106-3","display":"White"}},{"url":"text","valueString":"White"}]},{"url":"http://hl7.org/fhir/us/core/StructureDefinition/us-core-ethnicity","extension":[{"url":"ombCategory","valueCoding":{"system":"urn:oid:2.16.840.1.113883.6.238","code":"2186-5","display":"Non Hispanic or Latino"}},{"url":"text","valueString":"Non Hispanic or Latino"}]},{"url":"http://hl7.org/fhir/StructureDefinition/patient-mothersMaidenName","valueString":"Librada521 Cassin499"},{"url":"http://hl7.org/fhir/us/core/StructureDefinition/us-core-birthsex","valueCode":"M"},{"url":"http://hl7.org/fhir/StructureDefinition/patient-birthPlace","valueAddress":{"city":"Lynn","state":"Massachusetts","country":"US"}},{"url":"http://synthetichealth.github.io/synthea/disability-adjusted-life-years","valueDecimal":2.039551033112163},{"url":"http://synthetichealth.github.io/synthea/quality-adjusted-life-years","valueDecimal":58.96044896688784}],"identifier":[{"system":"https://github.com/synthetichealth/synthea","value":"05f7fb9c-3358-e686-d1ff-a6de1aa2aaf7"},{"type":{"coding":[{"system":"http://terminology.hl7.org/CodeSystem/v2-0203","code":"MR","display":"Medical Record Number"}],"text":"Medical Record Number"},"system":"http://hospital.smarthealthit.org","value":"05f7fb9c-3358-e686-d1ff-a6de1aa2aaf7"},{"type":{"coding":[{"system":"http://terminology.hl7.org/CodeSystem/v2-0203","code":"SS","display":"Social Security Number"}],"text":"Social Security Number"},"system":"http://hl7.org/fhir/sid/us-ssn","value":"999-32-8982"},{"type":{"coding":[{"system":"http://terminology.hl7.org/CodeSystem/v2-0203","code":"DL","display":"Driver's License"}],"text":"Driver's License"},"system":"urn:oid:2.16.840.1.1138<IP_ADDRESS>","value":"S99935913"},{"type":{"coding":[{"system":"http://terminology.hl7.org/CodeSystem/v2-0203","code":"PPN","display":"Passport Number"}],"text":"Passport Number"},"system":"http://standardhealthrecord.org/fhir/StructureDefinition/passportNumber","value":"X71919634X"}],"name":[{"use":"official","family":"Volkman526","given":["Abdul218"],"prefix":["Mr."]}],"telecom":[{"system":"phone","value":"555-341-1712","use":"home"}],"gender":"male","birthDate":"1958-08-31","address":[{"extension":[{"url":"http://hl7.org/fhir/StructureDefinition/geolocation","extension":[{"url":"latitude","valueDecimal":42.06848443888001},{"url":"longitude","valueDecimal":-70.18801548971284}]}],"line":["405 Schmitt Knoll Unit 25"],"city":"Provincetown","state":"MA","country":"US"}],"maritalStatus":{"coding":[{"system":"http://terminology.hl7.org/CodeSystem/v3-MaritalStatus","code":"M","display":"M"}],"text":"M"},"multipleBirthBoolean":false,"communication":[{"language":{"coding":[{"system":"urn:ietf:bcp:47","code":"en-US","display":"English"}],"text":"English"}}]}

Request a bulk import of this file

curl -k -v -u "fhiruser:change-password" -H 'Content-Type: application/fhir+json' 'https://localhost:9443/fhir-server/api/v4/$import' -d "{
    \"resourceType\": \"Parameters\",
    \"id\": \"30321130-5032-49fb-be54-9b8b82b2445a\",
    \"parameter\": [
        {
            \"name\": \"inputFormat\",
            \"valueString\": \"application/fhir+ndjson\"
        },
        {
            \"name\": \"inputSource\",
            \"valueUri\": \"https://localhost:9443/source-fhir-server\"
        },
        {
            \"name\": \"input\",
            \"part\": [
                {
                    \"name\": \"type\",
                    \"valueString\": \"Patient\"
                },
                {
                    \"name\": \"url\",
                    \"valueUrl\": \"https://webserv:8080/Patient.fhir.ndjson\"
                }
            ]
        },
        {
            \"name\": \"storageDetail\",
            \"valueString\": \"https\"
        }
    ]
}"

Search male patients

curl -X GET "https://localhost:9443/fhir-server/api/v4/Patient?gender=male" -H "accept: application/fhir+json"

The API returns :
{
  "resourceType": "Bundle",
  "id": "16312f11-49c7-4297-9a34-659ee1428052",
  "type": "searchset",
  "total": 0,
  "link": [
    {
      "relation": "self",
      "url": "https://localhost:9443/fhir-server/api/v4/Patient?_count=10&gender=male&_page=1"
    }
  ]
}

Expected behavior
The request should returns the resource in the result
Additional context
I am using ibmcom/ibm-fhir-server:4.5.4 Docker image

@tevariou can you share an example resource that fails?

@tevariou can you share an example resource that fails?

Some further investigation: it works if I use the birthday or name search parameters. Still no luck with gender. I've tested with the following resource Observation:
{"resourceType":"Observation","id":"1772b3c4e78-19b8293a-4cf2-7777-8f40-5331d02b7666","meta":{"profile":["http://hl7.org/fhir/StructureDefinition/bodyheight","http://hl7.org/fhir/StructureDefinition/vitalsigns"]},"status":"final","category":[{"coding":[{"system":"http://terminology.hl7.org/CodeSystem/observation-category","code":"vital-signs","display":"vital-signs"}]}],"code":{"coding":[{"system":"http://loinc.org","code":"8302-2","display":"Body Height"}],"text":"Body Height"},"subject":{"reference":"Patient/1772b6bb75a-fd1b2296-6666-4ac1-8b06-f3651eebcc0a"},"encounter":{"reference":"Encounter/0dbb35ac-febc-c403-2d0d-6c19798f6b6e"},"effectiveDateTime":"2011-09-18T14:40:37+02:00","issued":"2011-09-18T14:40:37.468+02:00","valueQuantity":{"value":180,"unit":"cm","system":"http://unitsofmeasure.org","code":"cm"}}

I can find it when I filter on value-quantity=180 but It won't return anything when I filter on some reference like encounter or subject.

Some further investigation: it works if I use the birthday or name search parameters. Still no luck with gender. I've tested with the following resource Observation:
{"resourceType":"Observation","id":"1772b3c4e78-19b8293a-4cf2-7777-8f40-5331d02b7666","meta":{"profile":["http://hl7.org/fhir/StructureDefinition/bodyheight","http://hl7.org/fhir/StructureDefinition/vitalsigns"]},"status":"final","category":[{"coding":[{"system":"http://terminology.hl7.org/CodeSystem/observation-category","code":"vital-signs","display":"vital-signs"}]}],"code":{"coding":[{"system":"http://loinc.org","code":"8302-2","display":"Body Height"}],"text":"Body Height"},"subject":{"reference":"Patient/1772b6bb75a-fd1b2296-6666-4ac1-8b06-f3651eebcc0a"},"encounter":{"reference":"Encounter/0dbb35ac-febc-c403-2d0d-6c19798f6b6e"},"effectiveDateTime":"2011-09-18T14:40:37+02:00","issued":"2011-09-18T14:40:37.468+02:00","valueQuantity":{"value":180,"unit":"cm","system":"http://unitsofmeasure.org","code":"cm"}}

I can find it when I filter on value-quantity=180 but It won't return anything when I filter on some reference like encounter or subject.

Yeah - I'm pretty sure it's a token search problem.  I'm currently looking at the code.

Yeah - I'm pretty sure it's a token search problem.  I'm currently looking at the code.

I added an Integration Test for this. https://github.com/IBM/FHIR/pull/1882/files

I added an Integration Test for this. https://github.com/IBM/FHIR/pull/1882/files

IN addition to the fix and Server integration test I am going to raise, please note there is an error in the example data (re Profile conformance).
Please note the sample data includes an invalid reference to Non Hispanic or Latino
{
                    "url": "ombCategory",
                    "valueCoding": {
                        "system": "urn:oid:2.16.840.1.113883.6.238",
                        "code": "2186-5",
                        "display": "Not Hispanic or Latino"
                    }
                }```

Second issue was the CacheSynchronization beforeCompletion wasn't registered since the transaction was in progress.
The PR addresses this issue, and may need an alternative implementation based on review.


Neopixel LED driver stability

This is more of a question than a feature request.
The Neopixel LED driver has been merged into experimental with a few examples.
My question is the stability of the driver, and if it will be merged into master, it seem well implemented, but would like to what are the future decisions with the driver.

The driver is being rewritten, so do not consider it stable. It is very not stable. When the driver will be promoted to stable this will be announced in the release notes; I generally do not use an issue to track this so I'll close this issue.
Not that it's a bad idea, it's just that I don't have the time to manage the overhead myself.


MSSQL - TimeoutError: Knex: Timeout acquiring a connection. The pool is probably full

Knex version: 0.19.5
Database: mssql
OS: Win 10 Pro
I have two nodejs processes running - one with
const knexLogging = Knex({
  client: "mssql",
  connection: {
    host: process.env.LOGGING_MSSQL_DB_SERVER,
    user: process.env.LOGGING_MSSQL_DB_USER,
    password: process.env.LOGGING_MSSQL_DB_PASSWORD,
    port: Number.parseInt(process.env.LOGGING_MSSQL_PORT, 10),
    database: process.env.LOGGING_DATABASE,
    encrypt: true,
    stream: true,
    connectionTimeout: 30000,
    requestTimeout: 30000
  }
});

which is running insertions to a table at about 2/s
Another with
const knexLogging = Knex({
  client: "mssql",
  connection: {
    host: process.env.LOGGING_MSSQL_DB_SERVER,
    user: process.env.LOGGING_MSSQL_DB_USER,
    password: process.env.LOGGING_MSSQL_DB_PASSWORD,
    port: Number.parseInt(process.env.LOGGING_MSSQL_PORT, 10),
    database: process.env.LOGGING_DATABASE,
    encrypt: true,
    stream: true,
    connectionTimeout: 300000,
    requestTimeout: Infinity
  }
});

which runs every 5 minutes and makes about 6 or 7 calls to a stored procedure
which executes a deletion and an insertion with a try catch, SP called like this.
...
let query = "EXEC ... ?, ?, ? "; // attribute value hours
          knexLogging
            .raw(query, [...])
            .then(null);

...
From time to time this second process throws this.
Unhandled rejection TimeoutError: Knex: Timeout acquiring a connection. The pool is probably full. Are you missing a .transacting(trx) call
I don't understand how having a transaction anywhere would make any difference to a connection timeout.
Any ideas what I am doing wrong?

Sounds like you are running too many parallel transactions.  I suppose that requestTimeout: Infinity may cause that some long running queries will run minutes or hours and in that case the transaction where those slow queries are reserving connection from pool for the whole time.
If you think this is a bug, please add minimal reproduction code for the problem.

Thank you so much.  I appreciate your response.
I think you are probably right in your description.  The stored procedure executes a potentially long running deletion.  I understand this deletion will run in an implicit transaction.  Every few hours, the stored procedure is executed from knex several times without waiting.  It is necessary I do not await because if I await, the framework from which it is called (which I have no choice about) will kill it and fail itself.  Also I set Infinity because I must have these deletions complete and it is difficult to estimate how long they may last.
Do you happen to know how I might be able find out how many parallel transactions is too many and if there is any way to increase this number?

Actually the case you described doesn't sound anything specific to transactions.... It just seems that your pool runs out of connections. You can check pool status from knex.client.pool object. By default there is only 10 connections reserved in pool so you can increase that for example to be 100 or so.
Connection pool docs are found here for more information: https://github.com/vincit/tarn.js/


convert_script returns a INF instead of "INF" on the SF command and 'type' instead of skipping /TYPE.

🤓 Before submitting the issue

[X] I have visited the Troubleshooting section.
[X] I have searched among the existing issues.
[X] I am using a Python virtual environment.
[X] I am using the latest version of PyMAPDL and its dependencies (fully updated virtual environment). You can update them using pip install --upgrade --upgrade-strategy eager ansys-mapdl-core in your activated virtual environment.

🔍 Description of the bug
In electrostatic analyses when using the infinite boundary element the SF,ALL,INF command defines the exterior surface.  When translated by convert_script the resulting commands is:
mapdl.sf("ALL", INF)

Instead of
mapdl.sf("ALL", "INF")

Mike
🕵 Steps To Reproduce
The log will automatically be formatted as Python code! No need to type backticks.

💻 Which Operating System are you using?
Windows
🐍 Which Python version are you using?
3.10
📝 PyMAPDL Report
Show the Report!

# PASTE HERE THE OUTPUT OF `python -c "from ansys.mapdl import core as pymapdl; print(pymapdl.Report())"` here

📝 Installed packages
Show the installed packages!

# PASTE HERE THE OUTPUT OF `python -m pip freeze` here

📝 Logger output file
Show the logger output file.

# PASTE HERE THE CONTENT OF THE LOGGER OUTPUT FILE.

Would like to add that the MAPDL command /TYPE, which defines the graphics type of display, gets translated to 'type' which is a different command (used to set the current element type to be meshed with).
Mike

Hi @mikerife
Yes.. I owe you a release.
If you check out the main branch, the problem with "INF" is solved:
>>> convert_apdl_block("SF,ALL,INF", only_commands=True)
'mapdl.sf("ALL", "INF")'

And the /TYPE is not converted:
>>> convert_apdl_block("/TYPE", only_commands=True)
'mapdl.run("/TYPE")'


where are hx files I finally installed haxeflixel and iwant to know how they work

Describe your problem here. If you are modding, please try testing your problem in a clean version of the engine instead, this ensures the problem is actually caused by the engine itself. Also, if you're using an older version of JSE, please try the latest action build in the Actions tab or the latest release build. The issue has probably been fixed since that version. Oh yeah, and also be sure to check the pinned 'JS Engine: Known Issues' issue, to double check if your issue hasn't already been found!
tynytty
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
no

you need to download the source code from here


sample code creates ubuntu 18.04, which ade does not support

The sample code to create the linux vm creates the latest LTS version by default, which is 18.04.  This is not supported at this time by azure disk encryption.
The code should be changed to look like:
az vm create
--resource-group $resourcegroup
--name myVM
--image Canonical:UbuntuServer:16.04-LTS:latest
--admin-username azureuser
--generate-ssh-keys
--data-disk-sizes-gb 5

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 92f22921-4ced-4353-0a71-71536aee57c2
Version Independent ID: 36873789-a9c9-6e27-c0c1-a24bf4c0b5aa
Content: Encrypt disks on a Linux VM in Azure
Content Source: articles/virtual-machines/linux/encrypt-disks.md
Service: virtual-machines-linux
GitHub Login: @cynthn
Microsoft Alias: cynthn

I created pr #23987 with this fix

Thanks for the feedback! We are currently investigating and will update you shortly.

@larryms  We will now close this issue. If there are further questions regarding this matter, please tag me in a comment. I will reopen it and we will gladly continue the discussion.


feat(nodejs): add logger sdk, fix metrics and update some packages

fixes #1458

It looks to me like the sdk-logs package is missing in the package.json file.

It looks to me like the sdk-logs package is missing in the package.json file.

Good catch, just realized one my changes didn't go through

Hi @martinkuba @tylerbenson is there a way to release an alpha version of this layer for some manual tests?

I'm not sure what the process is, but I believe you can publish the layer to your own account and test from there.

I have this working on my own account for Metrics and Tracing already, checking logs

I now have Logs, Tracing, Metrics, and Tracing correlation with Logs working!

Log code:
const otelLogger = logsAPI.logs.getLogger('default');
  otelLogger.emit({
    severityNumber: logsAPI.SeverityNumber.INFO,
    severityText: 'INFO',
    body: 'this is a log record body - test on new build',
    attributes: { 'log.type': 'LogRecord' },
  });

👋🏽 @tylerbenson do you think we can release this change this week?

Hi @tylerbenson mind approving the last merge test run? there was a conflict with the other PR merged yesterday

LGTM!
One question: Does enabling logging exporter mean that console log methods (log, trace, debug, info, error, ...) are automatically patched/wrapped and all console logs are exported by default?

@serkan-ozal no, your own lib has to be compatible with the OTEL SPEC, OR you have to manually emit logs using the OTEL Logs API:
const otelLogger = logsAPI.logs.getLogger('default');
  otelLogger.emit({
    severityNumber: logsAPI.SeverityNumber.INFO,
    severityText: 'INFO',
    body: 'this is a log record body - test on new build',
    attributes: { 'log.type': 'LogRecord' },
  });

In my example, my project was using winston, so I just had to add https://github.com/open-telemetry/opentelemetry-js-contrib/tree/main/packages/winston-transport so that my existing logging lib can also emit otel resources automatically


pip install punch

Looks like there's something fishy going on here:
; pip install punch
Collecting punch
Requirement already satisfied (use --upgrade to upgrade): webob in /home/usr/.virtualenvs/widle/lib/python2.7/site-packages (from punch)
Installing collected packages: punch
Successfully installed punch-0.0.1

and
; pip uninstall punch
Uninstalling punch-0.0.1:
  /home/usr/.virtualenvs/widle/lib/python2.7/site-packages/punch-0.0.1.dist-info/DESCRIPTION.rst
  /home/usr/.virtualenvs/widle/lib/python2.7/site-packages/punch-0.0.1.dist-info/INSTALLER
  /home/usr/.virtualenvs/widle/lib/python2.7/site-packages/punch-0.0.1.dist-info/METADATA
  /home/usr/.virtualenvs/widle/lib/python2.7/site-packages/punch-0.0.1.dist-info/RECORD
  /home/usr/.virtualenvs/widle/lib/python2.7/site-packages/punch-0.0.1.dist-info/WHEEL
  /home/usr/.virtualenvs/widle/lib/python2.7/site-packages/punch-0.0.1.dist-info/metadata.json
  /home/usr/.virtualenvs/widle/lib/python2.7/site-packages/punch-0.0.1.dist-info/top_level.txt
  /home/usr/.virtualenvs/widle/lib/python2.7/site-packages/punch/__init__.py
  /home/usr/.virtualenvs/widle/lib/python2.7/site-packages/punch/__init__.pyc
  /home/usr/.virtualenvs/widle/lib/python2.7/site-packages/punch/app.py
  /home/usr/.virtualenvs/widle/lib/python2.7/site-packages/punch/app.pyc
Proceed (y/n)? y
  Successfully uninstalled punch-0.0.1

Unfortunately the name "punch" was already registered on PyPI and I had to switch to "punch.py", so be sure to use that when installing with pip. Moreover at the moment I am experiencing some connection issues with PyPI, so you have to wait soem time for the new release to be available, sorry

☺ No worries.  Thank you.

Now version 1.1.2 is available on PyPI

Thank you very much.


Dockerfile fails

Hello
Thanks for sharing your very interesting project!
I m interested in building a binary but, I guess the instructions in the wiki will only work in linux right? for me reading about it for the first time it was not obvious I tried and fail miserable in Macos catalina (suggestion add some pointers for the environment and requisites).
Then I tried and fail building the Dockerfile
last messages:
=> => transferring context: 2B                                                        0.0s
=> [build  2/16] RUN apt-get update && apt-get install --no-install-recommends -y   207.0s
=> [build  3/16] WORKDIR /prk_firmware                                                0.5s
=> [build  4/16] COPY . .                                                             0.3s
=> [build  5/16] WORKDIR /prk_firmware/src/ruby                                       0.4s
=> ERROR [build  6/16] RUN bundle install                                             1.2s

[build  6/16] RUN bundle install:
#10 1.161 Could not locate Gemfile

executor failed running [/bin/sh -c bundle install]: exit code: 10

@pbrena Do you use an M1 Mac? I'm not sure but M1 Mac possibly doesn't work due to the Arm architecture

(suggestion add some pointers for the environment and requisites).

OK.

Ah, Catalina couldn't run on M1. So I totally don't know what happened on your end. Would you provide the full output message?

right x86
doker.txt
rakenativeonmacoos.txt
thx

i cleaned up and ran
docker build . -t prk
but i still get
=> ERROR [6/6] RUN rake setup                                             0.7s

[6/6] RUN rake setup:
#11 0.604 rake aborted!
#11 0.604 No Rakefile found (looking for: rakefile, Rakefile, rakefile.rb, Rakefile.rb)
#11 0.604
#11 0.604 (See full trace by running task with --trace)

so i cant Setup... i dont know what to do

The message changed. It says you simply don't have Rakefile in the top directory.
I would think you have to learn programming basics, to be exact, how to use Linux/Unix command line and how to read an error message.
Really sorry but I am closing this issue because I believe the problem isn't on our end

I understand and dont complain, Im a newbie and will keep on reading, and further learning.
Having said that, I just want to point out something...
As far as I understand the guide... the setup command (docker build . -t prk) is the very first to be run and the user has in principle no control of what is or isnt downloaded (particularly Rakefile in the top directory) without modifying the dokerfile itself and as the container isnt created and  no further command is posible... this should run as is, right?
I lost what my original deviation was so my approach was to cleanup my previos environment (following some online guides) to reinstall/upgrade Docker, (hence the change of message) and even re run the setup with --no-cache parameter to no avail...
I cannt identify the step in the dockerfile where top directory is populated but i will try to create an environment that gives a command prompt and proceed manually


chezmoi: 2.0.9 -> 2.0.10

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/twpayne/chezmoi/releases.
meta.description for chezmoi is: "Manage your dotfiles across multiple machines, securely"
meta.homepage for chezmoi is: "https://www.chezmoi.io/"
meta.changelog for chezmoi is: ""
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

/nix/store/104ylprap3sllm2xy3pv78dmn4p78n0q-chezmoi-2.0.10/bin/chezmoi passed the binary check.

1 of 1 passed binary check by having a zero exit code.

0 of 1 passed binary check by having the new version present in output.

found 2.0.10 with grep in /nix/store/104ylprap3sllm2xy3pv78dmn4p78n0q-chezmoi-2.0.10

found 2.0.10 in filename of file in /nix/store/104ylprap3sllm2xy3pv78dmn4p78n0q-chezmoi-2.0.10

directory tree listing: https://gist.github.com/d94fc641766d19bd783b8d512a8a97f2

du listing: https://gist.github.com/abed54be1cb94dc731ea403ffc8b0cf5

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
chezmoi

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/104ylprap3sllm2xy3pv78dmn4p78n0q-chezmoi-2.0.10 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A chezmoi https://github.com/r-ryantm/nixpkgs/archive/ab3c516f0872062c7fa52ce9728eb0778be598e0.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/104ylprap3sllm2xy3pv78dmn4p78n0q-chezmoi-2.0.10
ls -la /nix/store/104ylprap3sllm2xy3pv78dmn4p78n0q-chezmoi-2.0.10/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

chezmoi

Maintainer pings
cc @jhillyerd @kalbasit for testing.

Result of nixpkgs-review pr 120164 run on x86_64-linux 1

1 package built:

chezmoi


update scratch-l10n version to add xh, tn, qu, or, nso, af; update translations

Resolves
update scratch-l10n version to add xh, tn, qu, or, nso, af; update translations

@chrisgarrity Take a look now. It turned out there were a bunch more errors in the translations, should all be fixed now!

@chrisgarrity Take a look now. It turned out there were a bunch more errors in the translations, should all be fixed now!


network manager: Improve logging

Improve startup logging around determining external address and
interface to use

LGTM
nit: would have been easier to review if the rename and logs were in separate commits.

OK, I'll know for next time 😄


Add diagnostic levels

Adds diagnostic levels to the diagnostics, and configuration for them.
This is mostly for other editors, since without a plugin to make it nice you just get a wall of warnings

Looks very reasonable to me, thanks for putting in the work!


unify option component (close #7)

Pull Request Test Coverage Report for Build 374294266

140 of 152 (92.11%)  changed or added relevant lines in 9 files are covered.
18 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-6.6%) to 90.374%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/GeminiLab.Core2.CommandLineParser/Default/OptionComponent.cs
116
128
90.63%

Files with Coverage Reduction
New Missed Lines
%

src/GeminiLab.Core2.CommandLineParser/Default/DefaultCategoryBase.cs
4
0%

src/GeminiLab.Core2.CommandLineParser/CommandLineParser.cs
14
89.71%

Totals

Change from base Build 374266007:
-6.6%

Covered Lines:
360

Relevant Lines:
401

💛  - Coveralls


Quartz statistics offset haserror,msg is null

kafka-eagle 1.2.6
centos 7.2
set up and config as doc says, but still get error : OffsetsQuartz.org.springframework.scheduling.quartz.SchedulerFactoryBean#0_Worker-2 - ERROR - Quartz statistics offset haserror,msg is null
the kafka and zookeeper is working well .
beside, when I add topic alarm, after clicking the add button, there  was a failure with no response !!!!

@zhouhoo Hi, What is the kafka version number you use?

kafka is 0.11 version，sorry so late


[Bug] Android devices alert users that they are offline when Firestore tries to connect without internet connection

Description
Since we updated to Firebase 12 some users are reporting that their Android devices alert them that they are offline when Firestore tries to syncs without internet connection. If the device is not online the following is observed every 3-5 seconds which seems to trigger an "Offline" message on the Android device and users can't use the app. The app is designed to work offline and this never happened on prior Firebase versions.
Not sure if it is necessarily a bug, but is there a way to suppress the message?
Thank you!
Relevant manifest lines:
 <uses-permission android:name="android.permission.INTERNET" />   <uses-permission android:name="android.permission.WAKE_LOCK" />   <uses-permission android:name="android.permission.ACCESS_NETWORK_STATE"/>   <uses-permission android:name="com.android.vending.BILLING"/>
Reproducing the issue
Unity App with a Firestore listener which works when the device is online
Turn off Internet in the device
Start the app and observe the message every 3-5 seconds in Logcat
The Firestore sync attempt seems to generate a message on the Android device alerting the user that the device is offline
Firebase Unity SDK Version
12.0.0 and 12.1.0
Unity editor version
2022.3.39f1
Installation Method
.unitypackage
Problematic Firebase Component(s)
Firestore
Other Firebase Component(s) in use
Analytics, Authentication, Crashlytics, Remote Config
Additional SDKs you are using
No response
Targeted Platform(s)
Apple Platforms, Android
Unity editor platform
Mac
Scripting Runtime
IL2CPP
Release Distribution Type
Pre-built SDK from https://firebase.google.com/download/unity
Relevant Log Output
2024-07-29 14:00:33.635 14515-14719 ManagedChannelImpl      com.bundle      W  [{0}] Failed to resolve name. status={1}
2024-07-29 14:00:35.842 14515-14710 Firestore               com.bundle       W  (25.0.0) [WriteStream]: (aa9c84b) Stream closed with status: Status{code=UNAVAILABLE, description=Unable to resolve host firestore.googleapis.com, cause=java.lang.RuntimeException: java.net.UnknownHostException: Unable to resolve host "firestore.googleapis.com": No address associated with hostname
                                                                                at io.grpc.internal.DnsNameResolver.resolveAddresses(DnsNameResolver.java:223)
                                                                                at io.grpc.internal.DnsNameResolver.doResolve(DnsNameResolver.java:282)
                                                                                at io.grpc.internal.DnsNameResolver$Resolve.run(DnsNameResolver.java:318)
                                                                                at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
                                                                                at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:644)
                                                                                at java.lang.Thread.run(Thread.java:1012)
                                                                                Caused by: java.net.UnknownHostException: Unable to resolve host "firestore.googleapis.com": No address associated with hostname
                                                                                at java.net.Inet6AddressImpl.lookupHostByName(Inet6AddressImpl.java:156)
                                                                                at java.net.Inet6AddressImpl.lookupAllHostAddr(Inet6AddressImpl.java:103)
                                                                                at java.net.InetAddress.getAllByName(InetAddress.java:1152)
                                                                                at io.grpc.internal.DnsNameResolver$JdkAddressResolver.resolveAddress(DnsNameResolver.java:632)
                                                                                at io.grpc.internal.DnsNameResolver.resolveAddresses(DnsNameResolver.java:219)
                                                                                at io.grpc.internal.DnsNameResolver.doResolve(DnsNameResolver.java:282)
                                                                                at io.grpc.internal.DnsNameResolver$Resolve.run(DnsNameResolver.java:318)
                                                                                at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
                                                                                at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:644)
                                                                                at java.lang.Thread.run(Thread.java:1012)
                                                                                Caused by: android.system.GaiException: android_getaddrinfo failed: EAI_NODATA (No address associated with hostname)
                                                                                at libcore.io.Linux.android_getaddrinfo(Native Method)
                                                                                at libcore.io.ForwardingOs.android_getaddrinfo(ForwardingOs.java:133)
                                                                                at libcore.io.BlockGuardOs.android_getaddrinfo(BlockGuardOs.java:222)
                                                                                at libcore.io.ForwardingOs.android_getaddrinfo(ForwardingOs.java:133)
                                                                                at java.net.Inet6AddressImpl.lookupHostByName(Inet6AddressImpl.java:135)
                                                                                at java.net.Inet6AddressImpl.lookupAllHostAddr(Inet6AddressImpl.java:103)
                                                                                at java.net.InetAddress.getAllByName(InetAddress.java:1152)
                                                                                at io.grpc.internal.DnsNameResolver$JdkAddressResolver.resolveAddress(DnsNameResolver.java:632)
                                                                                at io.grpc.internal.DnsNameResolver.resolveAddresses(DnsNameResolver.java:219)
                                                                                at io.grpc.internal.DnsNameResolver.doResolve(DnsNameResolver.java:282)
                                                                                at io.grpc.internal.DnsNameResolver$Resolve.run(DnsNameResolver.java:318)
                                                                                at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
                                                                                at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:644)
                                                                                at java.lang.Thread.run(Thread.java:1012)
                                                                                }.

If using CocoaPods for Apple platforms, the project's Podfile.lock

Expand Podfile.lock snippet

👀 Replace this line with the contents of your Podfile.lock!

Thanks for reaching out, @pstpetrov-dev. I was able to reproduce this behavior for both Unity built Android app and native Android app using our Firebase Quickstarts for Unity and Android. Let me bring this up to our engineers and see what we can do here.

Hey @argzdev

When you mentioned "Firestore listener", do you mean the listener for getting realtime updates with Cloud Firestore?

Yes, see attached txt file for code snippets
Listeners.txt

You mentioned that "Firestore sync attempt seems to generate a message on the Android device alerting the user that the device is offline". The warning in the stacktrace should only be displayed in your logcat, is this somehow being shown to your users?

Yes, they get a native popup on their Android device a few seconds after app start. See attached user provided video (around 0:27).
https://github.com/user-attachments/assets/bd8a1d5f-51b3-48e5-93f6-6f76793f7c60

Any chance you could share code snippets?

See code provided in point 1. Let me know if you need anything specific please. These listeners start when the app starts and are active throughout.

I tried testing this with Firestore both 11.9.0 and 12.1.0 with slight deviation from your steps:

Run app
Turn on airplane mode
Trigger Firestore real time updates
UnknownHostException is observed, but it looks like it has backoff retry so it doesn't repeat every 3-5 seconds.

Is this the behavior you're also encountering?

No, I see the error appearing every 3-5 seconds as if the code is retrying the connection. I believe this was observed after we updated to 12.0.0.

Hi. Recently, my application cannot open when the device is offline. When I open my app it will open Google Play immediately. I see Logcat and I'm sure this issue comes from Firebase. I don't know how to fix it. Please help me

@argzdev were you and the team able to pinpoint where the issue is?

Thank you for your patience. I've tried testing multiple scenarios with something similar to your code snippet:
protected void GetRealtimeValue()
    {
      Query doc1 = db.Collection("col1").Document("doc1").Collection("collection1");
      ListenerRegistration listener1 = doc1.Listen(snapshot =>
      {
        foreach (DocumentSnapshot documentSnapshot in snapshot.Documents)
        {
          DebugLog(documentSnapshot.Id);
        }
      });

      Query doc2 = db.Collection("col2").Document("doc2").Collection("collection2");
      ListenerRegistration listener2 = doc2.Listen(snapshot =>
      {
        foreach (DocumentSnapshot documentSnapshot in snapshot.Documents)
        {
          DebugLog(documentSnapshot.Id);
        }
      });

      Query doc3 = db.Collection("col3").Document("doc3").Collection("collection3");
      ListenerRegistration listener3 = doc3.Listen(snapshot =>
      {
        foreach (DocumentSnapshot documentSnapshot in snapshot.Documents)
        {
          DebugLog(documentSnapshot.Id);
        }
      });
    }

And I was able to retrieve the same stacktrace:
2024/08/30 19:04:25.896 22462 22563 Warn ManagedChannelImpl [{0}] Failed to resolve name. status={1}
2024/08/30 19:04:26.573 22462 22557 Warn Firestore (25.0.0) [WatchStream]: (edb787e) Stream closed with status: Status{code=UNAVAILABLE, description=Unable to resolve host firestore.googleapis.com, cause=java.lang.RuntimeException: java.net.UnknownHostException: Unable to resolve host "firestore.googleapis.com": No address associated with hostname
2024/08/30 19:04:26.573 22462 22557 Warn Firestore 	at io.grpc.internal.DnsNameResolver.resolveAddresses(DnsNameResolver.java:223)
2024/08/30 19:04:26.573 22462 22557 Warn Firestore 	at io.grpc.internal.DnsNameResolver.doResolve(DnsNameResolver.java:282)
2024/08/30 19:04:26.573 22462 22557 Warn Firestore 	at io.grpc.internal.DnsNameResolver$Resolve.run(DnsNameResolver.java:318)
2024/08/30 19:04:26.573 22462 22557 Warn Firestore 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1137)
2024/08/30 19:04:26.573 22462 22557 Warn Firestore 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:637)
2024/08/30 19:04:26.573 22462 22557 Warn Firestore 	at java.lang.Thread.run(Thread.java:1012)

This is working as intended, AFAIK this stacktrace will be appear since the real time listener is trying to reconnect to the internet to receive updates. However, like I previously mentioned this stacktrace warning will only show up in your logcat.
The native pop up is not a feature we have in Firestore that would automatically show up or redirect to Google Play. This is most likely due to something else entirely unrelated to our SDKs.
That said, if you have reason to believe that Firestore is causing this popup issue, kindly provide an MCVE so we can investigate this further. Thanks!

Hi. Recently, my application cannot open when the device is offline. When I open my app it will open Google Play immediately. I see Logcat and I'm sure this issue comes from Firebase. I don't know how to fix it. Please help me

@VanHop94  Were you able to localize it to Firebase? If so can you produce a sample project where this happens? I don't see the error on my test Android devices, so can't reproduce it.


Optimization for get_search_results() in admin

When searching in fields of reverse relations, the previous implementation for constructing the queryset inside the get_search_results() method, caused Django ORM to introduce unnecessary JOINs in the final query (related issues: https://code.djangoproject.com/ticket/16603 and https://code.djangoproject.com/ticket/25789). The more words were in the search term the more inefficient was the query. This small patch seems that it makes Django ORM take a different path that does not introduce unnecessary JOINs. Searching with a great number of words in the searching term is not a problem anymore.

Keep in mind that filter(or_queries[0] & or_queries[1] & ... & or_queries[n]) can generate different results from filter(or_queries[0]).filter(or_queries[1]).filter(...).filter(or_queries[n]) if any of filters spans multi-valued relationships.
For example, given models Book and Author and a AuthorAmin searching both books__title  and books__description your solution could filter out results that use to be displayed.

buildbot, add to whitelist.

@charettes you are right.
So, the question is whether that behavior is absolutely necessary for searches in the admin. I mean, I think that, in your example, it is quite advanced the scenario that an end user uses e.g. the search term "word1 word2" knowing/expecting that the search is going to return authors that have both books with "word1" as a title and books with "word2" in their description. Surely, it is a possibility and some people may find the current implementation handy, but considering the fact that it produces quite unoptimized queries and lets people bring down the system with just a few words in the search term, I think we should reconsider this.
In my case, having 3 tables with just a few rows involved in the search (they were not huge or even big), the executed query for a search term with just 3 words was running for 25 minutes before I eventually killed it on the database server. Also, since end user people tend to repeat again and again when something is taking too much time to return results, they can easily cause a denial of service.

The current behavior is documented so you'll need to raise the idea on the django-developers mailing list to see if there's consensus to change it.

@timgraham Well, actually the documentation of the current behavior says nothing about that corner case we are talking about here. So, the proposed change does not make the current documentation inconsistent. Nonetheless, I will raise the idea on the dev list as you said. :)

FYI: https://groups.google.com/forum/#!topic/django-developers/V8M49P326dI

I'm not sure how the etiquette works for responding to old posts, but I think this is a necessary change that should be revived. I've posted in the linked developers thread as well, as I don't know which is more likely to be seen.
I know there may be users who expect the previous query behavior, but this is a gotcha that can hide for awhile before somebody accidentally breaks everything.
This problem brought down our site yesterday when an unsuspecting admin user tried a 3-word search in an admin that had several search fields involving joins. The result was that the number of joins was multiplied by the number of search terms. The database machine literally ran out of space, apparently from making the temporary table to hold all the joins (it had been about 10% full -- this query occupied many times the size of the entire database), and crashed everything. It works fine with just 1 word. As a workaround, we blocked nonessential users from being able to make that search and will be removing less-important fields from the search_fields in a future code update. But it took awhile to figure out what the problem was, and this could happen in any admin with enough related search fields or search terms. Eventually, I came up with the same fix Ernest suggests in their PR.
More related tickets:

https://code.djangoproject.com/ticket/16063 (with a similar solution)
https://code.djangoproject.com/ticket/27864 (mitigate by limiting number of search terms)


Easier way to support camelCase for objects marked as [FromQuery]

If you have a complex object that you are mapping with [FromQuery] then there doesn't seem to be a great way to make those follow camelCase convention unless you put [FromQuery(Name="camelCase"] on each property. Seems like a simple convention could be configured or an option on FromQuery, but this is usually an app setting, not something you decide to do for each API.
Let me know if there is a better way to support this.  I'd be happy to help if there is obvious place for this to go.

Is there a widely accepted convention for this?
Although Microsoft suggests using camelCase for query parameters (https://github.com/Microsoft/api-guidelines/blob/master/Guidelines.md), I'm not sure Microsoft should be the only reference.
At the company where I'm currently empoyed, convention is to use lowercase (eg: pagesize) but I've seen other uses (eg: Facebook uses snake_case if I'm not mistaken).
I've forked your repo and I am adding an option QueryParametersCapitalization to SchemaRegistryOptions of enum type CapitalizationType:
    public enum CapitalizationType     {         None,         CamelCase,         PascalCase,         SnakeCase,         KebabCase     }
The generator then converts the query parameter names.
Ofcourse, model binding would also need its custom implementation but that's outside of Swashbuckle's scope.
What's your opinion on the above?
Thanks!

See d8ba4d35c17afa3f1d06884b9653a89ea746fe3c

@domaindrivendev be great to publish a new package for this.

Available with latest pre-release. Note the package rename to "Swashbuckle.AspNetCore.1.0.0-rc1"

Still not available in latest nuget package

The hack to put [FromQuery(Name="camelCase"] does not work with .Net Core 2.2. Is there another solution for this?

@RamunasAdamonis please provide a code example that repro's your issue. I just tested in a .Net Core 2.2 project and both the [FromQuery] annotation AND the global config setting DescribeAllParametersInCamelCase work exactly as expected.

@domaindrivendev I was not using DescribeAllParametersInCamelCase option. It works as expected now. Thank you for highlighting this.


Mouse does not lineup on palette after scrolling in scrollable container

When the color picker is placed in a scrollable container and the container is scrolled after the color picker is opened, the mouse no longer lines up on the palette and is unusable.
https://jsfiddle.net/p0q7Lfzb/8/

Just saw this previously reported in #18
Let me know if I can help troubleshoot.

The parent option should point to the scrollable container itself, not to one of its children. I updated the jsfiddle to reflect that:
https://jsfiddle.net/Lvfj4w01/
Maybe I need to update the documentation to make that a bit clearer.

@mdbassit that solution worked for me, thanks :)


Added organisation fighting for rights and freedom

i think i went with the guidelines. please Review  https://github.com/OpenGenus/Find.Your.Purpose/issues/8

Looks good 👍
Hope you enjoy your journey with OpenGenus


Documentation

Write short and descriptive docs for modules, most important functions and datatypes

[ ] Grids
[ ] Fields
[ ] BoundaryConditions
[ ] GridOperators
[ ] Physics
[ ] Utils
[ ] Logging
[ ] Models: Isothermal Full-Stokes
[ ] Models: Thermomechanical Full-Stokes

The Documenter doc is ready and can be viewed here https://ptsolvers.github.io/FastIce.jl/dev/.


JBPM-5573: Stunner - Integration of latest KIE Forms API & implementations

added dependencies to the missing forms ADF engine
refactored changed API's
fixed testing issues

These PR's should be merged together:
https://github.com/droolsjbpm/droolsjbpm-build-bootstrap/pull/364
https://github.com/droolsjbpm/kie-wb-common/pull/640
https://github.com/droolsjbpm/jbpm-console-ng/pull/609
https://github.com/droolsjbpm/jbpm-designer/pull/533
https://github.com/droolsjbpm/appformer/pull/66

@cristianonicolai this PR adds new dependencies introduced by https://github.com/droolsjbpm/kie-wb-common/pull/640
It also fixes the form providing tests.

@pefernan this one is in conflict now. Can you resolve, please?

@csadilek conflicts fixed. Let's see what jenkins says about it ;)


uldidellel / ulemdid

uldidellel / ulemdid created by<EMAIL_ADDRESS>on 2018-02-01 13:30:04

<EMAIL_ADDRESS>replied, Kerresel has "uldidellel a did el ngii ulemdid er ngii" but ulemdid is not defined.Â  In the examples, "Ng ko er a kellechakl, ngulemdasu e ulemdid er a uldesuel" is translated as "But he seems calm, he thought, and following his plan."Â  So maybe "ulemdid" is the past tense for "omdid"?Â  And "uldidellel" could be translated as "the path she followed"? (a course of action taken in the past, as opposed to a course of action planned for the future).Â  Uaisei?

<EMAIL_ADDRESS>replied, Uaisei.


Update homepage.json documentation and website links

Description
Homepage (app) documentation link was broken. I also suggest changing the website to the main homepage website instead of the github repo (which is linked from the true main page)
Fixes # (issue)
Type of change
Please check the relevant option(s):

[x] Bug fix (non-breaking change that resolves an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (a fix or feature that would cause existing functionality to change unexpectedly)
[ ] New script (a fully functional and thoroughly tested script or set of scripts.)

Prerequisites
The following efforts must be made for the PR to be considered. Please check when completed:

[x] Self-review performed (I have reviewed my code, ensuring it follows established patterns and conventions)
[x] Testing performed (I have tested my changes, ensuring everything works as expected) (as much as is possible with a url correction)
[x] Documentation updated (I have updated any relevant documentation)

Additional Information (optional)
Provide any additional context or screenshots about the feature or fix here.
Related Pull Requests / Discussions
If there are other pull requests or discussions related to this change, please link them here:

Related PR #

Thanks for fixing this.


[BUGish] Highlight project attributes that could indicate high risk for users

Description
Context:

https://discord.com/channels/775859454780244028/789559668233601086/936083266233057311
https://discord.com/channels/775859454780244028/879851197857677372/936459321716400140

Some project scenarios/configurations can be especially high risk for users, such as:

High supply of manually-minted tokens for an early project. Current token holders will benefit from all payments to a project, and heavily dilute the share contributors.
Token minting is enabled (v1.1) Any supply of tokens could be minted at any time by the project owners, diluting the token share of all existing contributors.
Ballot address is 0x0000... Funding cycle reconfigurations can be created moments before a new cycle begins, giving project owners an opportunity to take advantage of contributors, for example by withdrawing overflow.
Reserved rate is 100% (or very high). Contributors will receive a relatively small portion of tokens (if any) in exchange for paying the project.
Duration not set. Reconfigurations can be made at any point without notice—similar to having a ballot address of 0x0000....
No funding target: contributor can’t redeem

most of my concern comes from the

contributors so far
not using a multisig
questionably valid twitter followers

highlight parameters of projects that could indicate high risk to contributors (no fc duration, token minting allowed, high reserved rate, etc).

Proposal
In any of these cases, the information should be highlighted on a project page, without a user needing to click into the funding cycle details.

Closing for now, will continue to iterate and open a new issue if necessary.


Make BaseController state immutable

The state member variable exposed by the BaseController is mutable and can be modified externally. Direct state modification shouldn't be allowed since it bypasses notification. The state variable should be made readonly so that it's immutable and can only be modified by calling update or an exposed API method that modifies state internally.

This is covered by the new controller API


Update 1Password.app to v5.4.2

Thank you for the contribution. It was merged directly as 10bbc7fd43dd3c36d1e7ded4a903f9055cca6ca6 to keep commit history cleaner. Your contribution is still credited to you.


Crash when changing "Number of tiles per subgrid" below 4

Hey,
so i tried to change the number of tiles per subgrind by typing in 3 and pressed enter and the game crashed on me. :/
It also crashes with 0. ;)
Error MainLoop.cpp:1202: Exception at tick 29206134: The mod Tapeline (1.0.3) caused a non-recoverable error.
Please report this error to the mod author.
Error while running event Tapeline::on_gui_confirmed (ID 141)
Tapeline/scripts/util.lua:84: bad argument #1 of 2 to '__newindex' (string expected, got nil)
stack traceback:
[C]: in function '__newindex'
Tapeline/scripts/util.lua:84: in function 'set_last_valid_value'
Tapeline/scripts/gui/draw.lua:65: in function 'handler'
Tapeline/lualib/event.lua:86: in function <Tapeline/lualib/event.lua:26>
5463.823 Error ServerMultiplayerManager.cpp:92: MultiplayerManager failed: "The mod Tapeline (1.0.3) caused a non-recoverable error.
Please report this error to the mod author.
Error while running event Tapeline::on_gui_confirmed (ID 141)
Tapeline/scripts/util.lua:84: bad argument #1 of 2 to '__newindex' (string expected, got nil)
stack traceback:
[C]: in function '__newindex'
Tapeline/scripts/util.lua:84: in function 'set_last_valid_value'
Tapeline/scripts/gui/draw.lua:65: in function 'handler'
Tapeline/lualib/event.lua:86: in function <Tapeline/lualib/event.lua:26>"

Thanks for the report, I'll look into it when I have time.

It's been fixed for the next release. Thank you!


[Snyk] Upgrade react-intersection-observer from 8.26.2 to 8.34.0

This PR was automatically created by Snyk using the credentials of a real user.![snyk-top-banner](https://github.com/andygongea/OWASP-Benchmark/assets/818805/c518c423-16fe-447e-b67f-ad5a49b5d123)
Snyk has created this PR to upgrade react-intersection-observer from 8.26.2 to 8.34.0.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 28 versions ahead of your current version.

The recommended version was released on 2 years ago.

[!IMPORTANT]

Check the changes in this PR to ensure they won't cause issues with your project.
This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:

🧐 View latest project report
📜 Customise PR templates
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

Close this until we found a way to make this pass the DCO check


Multiselect is messed up in case of screen rotation

HI,
If we rotate the screen while multi select is on and Contextual Action Bar (CAB) is showing, the selected items are shown as selected (changed color) but in fact they are not. Also CAB menu item (delete) and number of selected items are not shown. At this stage, we can't tap on any item to select it. We have to long click on item and then delete icon and number of selected items (1) is shown, which again is wrong.
And this I've experienced while using the sample app.
Pl check and fix these issues.

you have to bring the adapter into the same state as it was before rotating as it is recreated. and it does not know what it needs to do.
The changes need to be done in your project and not in this library.
Also ensure to correctly remember the saved instance state

The changes need to be done in your project and not in this library.

See I clearly mentioned that my observations are based on the sample app; I haven't used this library in any of my projects as yet. Just check your sample app and see if u can reproduce what I mentioned above.

It is a sample so not a perfect implementing of what's possible and what
needs to be done. There are simply to many edge cases I'm which some things
have to be done. And that's not too special about this library that is true
in general.
If you want to improve the sample. We always are happy to see pull requests
On Sat, Jul 14, 2018, 2:21 PM Shahood ul Hassan<EMAIL_ADDRESS>wrote:

The changes need to be done in your project and not in this library.
See I clearly mentioned that my observations are based on the sample app
https://play.google.com/store/apps/details?id=com.mikepenz.fastadapter.app;
I haven't used this library in any of my projects as yet. Just check your
sample app and see if u can reproduce what I mentioned above.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/mikepenz/FastAdapter/issues/699#issuecomment-405020359,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABaGiCIRLo76dCESLoJM5K3no8aau06rks5uGeJAgaJpZM4VPa6I
.

--
Mike Penz

Mike Penz
Android | Backend | Open Source
mikepenz.com

Please feel free to open a PR if you want to improve the sample's behaviour for this case.


3-4 files created in temp dir but just need one ... ?

hi
i start my streaming with
videoStreamer = peerflix(torrent.info, {
connections: 100,
path: tmpFolder,
index: id
});
my app stream to good file BUT before starting it freeze my app few seconds on torrents with multiples avi files for exemple and in my temp dir i don t have only the file i selected, i have 3 or 4 folders created with their files... so i think the space allocation time of this files is the problem
any idear how to fix this ?
thanks

I think that happens because of .torrent.pieceLength, peerflix downloads in pieces and all the pieces (except the last one) have the same byte length.
When you download a file, the first and last parts of that file are downloaded first, and those particular pieces might contain parts of the previous and the next file in the torrent, so those files are created too, although only a very small part of them was downloaded.

To understand this better, in a visual environment, you can check out the app I posted last night, when in video streaming mode, right click and go to "Torrent Data" and you will be presented with the Torrent Client User Interface.
You can see that the files before and after the file that is selected are also downloaded (but only about 3% of them), if the files are very small, like text files, etc, it will be fully downloaded as they are part of that piece's length entirely.
This is normal behavior for Peerflix, I don't think this is a bug or can be fixed.

hello jaruba :)
you re everywhere !!
thanks for the explanation good to know !
i ll test you app asap, congratulations for that :)

Lol, yeah, I get around. One small question though, does the code you posted work for you?
videoStreamer = peerflix(torrent.info, {
    connections: 100,
    path: tmpFolder,
    index: id
});

any param ("connections", "tmp", "path", ...) I try to add this way when calling peerflix seems to be ignored.

ah yeah everything works, path is respected and index too :)

strange, maybe I need to update peerflix in my app :)

maybe, i modified some few things in peerflix or use the one of popcorn time :p


Node shows warning 'Possible memory leak'  during run of few tests .

To reproduce this issue, run next steps:

Create TestCafe, a TestCafe runner instance and a browser connection.
Establish the browser connection (for example, open connection.url in the local browser or call method establish() )
Run chain

runner
    .src(...)
    .browsers(...)
    .run()

at least 11 times (simultaneously or sequentially, it doesn't matter).

This is because of default EventEmitter subscribers limit (see: https://nodejs.org/api/events.html#events_emitter_removelistener_event_listener). It's not a big deal to disable this warning. On the other hand, I wonder which emitter shows warning, because everything was designed to avoid big number of subscribers for the emitter. So this require investigation.

I'm working on this.

It seems the cause of the problem is here. We add a listener for both events (idle and closed) but just one is raised. So, maybe we should remove the second event listener when the first event is raised. @georgiy-abbasov is investigating this

Need to cancel subscriptions once race is resolved (see: https://github.com/inikulin/promisify-event)

yes, we have a working solution yet. But we've found the same issue in the other place and will resolve it


Doesn't rerender when props change

I think this line is wrong.  It should be !keys(prev).every(k => prev[k] === next[k]).
Going to try my hand at writing a test for this :D

Even though (I think), that's wrong, regular components are fine because with-render.js ignores that: https://github.com/skatejs/skatejs/blob/dac2c4dff7824221aebf3bf55c402c04b0ad8674/src/with-render.js#L13
I don't quite understand, is the point of propsUpdatedCallback to determine if the props have changed? If so, shouldn't with-render be using propsChangedCallback instead?  @treshugart

I think this line is wrong. It should be !keys(prev).every(k => prev[k] === next[k]).

I think you are right @matthewp , but it makes it very non human readable and also iterating through all props may be slow.
This should do the trick:
keys(prev).some(k => prev[k] !== next[k])

Even though (I think), that's wrong, regular components are fine because with-render.js ignores that: https://github.com/skatejs/skatejs/blob/dac2c4dff7824221aebf3bf55c402c04b0ad8674/src/with-render.js#L13

Hmm good catch! I think this is wrong, because if props have been not changed we don't wanna trigger render, otherwise it don't make sense to have it there at all

@Hotell I would slightly amend that to:
!prev || keys(prev).some(k => prev[k] !== next[k]);

We know it will be undefined or an object, so shortening it is fine.

@matthewp it looks like we should be using propsChangedCallback instead as that will only be called when propsUpdatedCallback returns true, and we're not overriding it.

I'm also happy to change names to reflect the intent better, if there are any clearly better suggestions. I don't want to spend too much time on that bike shed, though.

I don't want to bikeshed either, was just trying to understand the code.  I was mostly wondering if with-render used propsUpdatedCallback on purpose for a reason or now.
Ok, so then I think the conclusion here is that:

with-render should use propsChangedCallback  and not override propsUpdatedCallback.
Fix the bug in with-props.

I think I can handle this!

Yeah, that sounds great! Thanks, @matthewp.

There's a problem with the way we render. This doesn't do what we want in Preact:
var div = document.createElement('div');
div.attachShadow({mode:'open'});
document.body.appendChild(div);

render(h('div', null, 'foo'), div.shadowRoot);
render(h('div', null, 'bar'), div.shadowRoot);

It will create 2 divs, not overwrite the first one. What is the correct way to re-render an element with vdom, without creating a preact component. Or should we create a preact component?

Answered on twitter :D

https://github.com/skatejs/skatejs/pull/1135

This was fixed by #1135


Communication: Improve auto completion for tagging users and channels

Fixed the clipping of the AutoCompletionPopup as described in #72 and closes this issue.
Additionally also changed the search for courses, lectures, and channels to be case-insensitive to be more intuitive.
Before:

After:

Can you please add screenshots on how this will look in the following cases:

entering a multi line text into the text field. e.g. when already being in line 3 and then starting an autocomplete dialog
when doing the same on a foldable
when doing the same on a tablet

Can you please add screenshots on how this will look in the following cases:
1. entering a multi line text into the text field. e.g. when already being in line 3 and then starting an autocomplete dialog
2. when doing the same on a foldable
3. when doing the same on a tablet

I am not at my dev setup right now, so I can't provide screenshots at the moment.
Regarding (1.), with my current understanding of the code, the popup will show above the edit / preview buttons, regardless of the cursor position. I will check that as soon as I am back.
Regarding the foldable and tablet, dont know what the behaviour would be like and I understand that this is important for future proving the app. However, I feel like adjusting the UI for tablet and foldables should probably be part of a different bigger ticket (as this likely also includes a completely altered design (with sidebar navigation eg)) and we should focus our limited resources on the main form factor for now.

Can you please add screenshots on how this will look in the following cases:
1. entering a multi line text into the text field. e.g. when already being in line 3 and then starting an autocomplete dialog
2. when doing the same on a foldable
3. when doing the same on a tablet

I am not at my dev setup right now, so I can't provide screenshots at the moment.
Regarding (1.), with my current understanding of the code, the popup will show above the edit / preview buttons, regardless of the cursor position. I will check that as soon as I am back.
Regarding the foldable and tablet, dont know what the behaviour would be like and I understand that this is important for future proving the app. However, I feel like adjusting the UI for tablet and foldables should probably be part of a different bigger ticket (as this likely also includes a completely altered design (with sidebar navigation eg)) and we should focus our limited resources on the main form factor for now.

The app, and especially the communication component already supports tablet mode interactions. It was part of a greater feature I implemented a some time ago. Therefore, it is important that when making these changes we consider how the tablet and foldable layouts are affected.
So please provide the screenshots once you have time.

Sorry, I did not know that tablet mode is already supported. Here are the screenshots:
Multiline mode on Phone:

Foldable:

Autocompletion on Tablet:

@TimOrtel Do you think the autocompletion dialog is fine for the tablet, or should we introduce some kind of maximum width, so the dialog does not span the whole screen?

Ah sorry, I meant adding a maximum height for tablets, not width. My fault

I think a maximum height would be quite reasonable. It would definitely look visually more appealing on tablets. We could set it to be the height of 5-6 items.

New Changes

I added a maxHeight to the dialog to show about 5-6 items max
I also updated the design to be more consistent

Screenshots
Phone

Foldable

Tablet

Good catch, I'll have a look

Okay, so it turns out this is a flaw of the M3 design specifications. Specifically, in dark mode, the colors surfaceVariant and outlineVariant are exactly the same ("neutral-variant30"). This causes all dividers to be invisible in dark mode.
We could either:

Ignore the problem
Deviate from the M3 design specs and manually change the value for md_theme_dark_outlineVariant in Color.kt
Not use surfaceVariant at all and replace it with something else in the app to avoid the problem. In a newer versions of M3 than we currently use, there eg is surfaceContainer.  (This would be a separate PR for sure)

I would suggest that for now we either do 1 or 2 (I'd tent to 2), and eventually follow up with 3 separately, as this involves updating the theme and replacing all occurrences of surfaceVariant. What do you think? @julian-wls

I would suggest that for now we either do 1 or 2 (I'd tent to 2), and eventually follow up with 3 separately, as this involves updating the theme and replacing all occurrences of surfaceVariant. What do you think? @julian-wls

I agree. Let's do 2 and follow up with 3 in the future as part of a different PR :)

Turns out the app uses dynamic colors for sdk >= 31, so we can not directly change the outlineVariant color. So, these changes will only be visible for users with sdk 30.
I also noticed that lifting the requirement for minSdk from 30 -> 31 was not necassary (as no other dependencies require this), so I lowered it again to 30.
I created a follow up issue #102


Errors during DB load

v 5.0.0-M1
01:10:30  [WARN] Unable to save property 'NVD CVE 2004' with a value of '1550826213000' to the database
01:10:30  [INFO] Processing Complete for NVD CVE - 2004  (224429 ms)
01:10:30  [INFO] Processing Started for NVD CVE - 2003
01:10:30  [WARN] Unable to save property 'NVD CVE 2003' with a value of '1550913336000' to the database
01:10:30  [INFO] Processing Complete for NVD CVE - 2003  (120305 ms)
01:10:30  [INFO] Processing Started for NVD CVE - 2005
01:10:30  [WARN] Unable to save property 'NVD CVE 2002' with a value of '1550654459000' to the database
01:10:30  [INFO] Processing Complete for NVD CVE - 2002  (487477 ms)
01:10:30  [INFO] Processing Started for NVD CVE - 2006
01:10:30  [WARN] Unable to save property 'NVD CVE 2005' with a value of '1550913287000' to the database
01:10:30  [INFO] Processing Complete for NVD CVE - 2005  (472959 ms)
01:10:30  [INFO] Processing Started for NVD CVE - 2007
01:10:30  [WARN] Unable to save property 'NVD CVE 2006' with a value of '1550913156000' to the database
01:10:30  [INFO] Processing Complete for NVD CVE - 2006  (753054 ms)
01:10:30  [INFO] Processing Started for NVD CVE - 2008
01:10:30  [WARN] Unable to save property 'NVD CVE 2007' with a value of '1551171105000' to the database
01:10:30  [INFO] Processing Complete for NVD CVE - 2007  (710564 ms)
01:10:30  [INFO] Processing Started for NVD CVE - 2009
01:10:30  [WARN] Unable to save property 'NVD CVE 2008' with a value of '1551170897000' to the database
01:10:30  [INFO] Processing Complete for NVD CVE - 2008  (989086 ms)
01:10:30  [INFO] Processing Started for NVD CVE - 2010
01:10:30  [WARN] Unable to save property 'NVD CVE 2009' with a value of '1551170669000' to the database
01:10:30  [INFO] Processing Complete for NVD CVE - 2009  (768471 ms)
01:10:30  [INFO] Processing Started for NVD CVE - 2012
01:10:30  [WARN] Unable to save property 'NVD CVE 2010' with a value of '1550912347000' to the database
01:10:30  [INFO] Processing Complete for NVD CVE - 2010  (1467811 ms)
01:10:30  [INFO] Processing Started for NVD CVE - 2011
01:10:30  [WARN] Unable to save property 'NVD CVE 2012' with a value of '1550911772000' to the database
01:10:30  [INFO] Processing Complete for NVD CVE - 2012  (1704685 ms)
01:10:30  [INFO] Processing Started for NVD CVE - 2013
01:10:30  [WARN] Unable to save property 'NVD CVE 2011' with a value of '1550912120000' to the database
01:10:30  [INFO] Processing Complete for NVD CVE - 2011  (3150254 ms)
01:10:30  [INFO] Processing Started for NVD CVE - 2014
01:10:30  [WARN] Unable to save property 'NVD CVE 2013' with a value of '1550911549000' to the database
01:10:30  [INFO] Processing Complete for NVD CVE - 2013  (3306057 ms)
01:10:30  [INFO] Processing Started for NVD CVE - 2015
01:10:30  [WARN] Unable to save property 'NVD CVE 2014' with a value of '1551170497000' to the database
01:10:30  [INFO] Processing Complete for NVD CVE - 2014  (1204029 ms)
01:10:30  [INFO] Processing Started for NVD CVE - 2016
01:10:30  [WARN] Unable to save property 'NVD CVE 2015' with a value of '1551170247000' to the database
01:10:30  [INFO] Processing Complete for NVD CVE - 2015  (837819 ms)
01:10:30  [INFO] Processing Started for NVD CVE - 2019
01:10:30  [WARN] Unable to save property 'NVD CVE 2019' with a value of '1551168083000' to the database
01:10:30  [INFO] Processing Complete for NVD CVE - 2019  (67480 ms)
01:10:30  [INFO] Processing Started for NVD CVE - 2017
01:10:30  [WARN] Unable to save property 'NVD CVE 2016' with a value of '1551170003000' to the database
01:10:30  [INFO] Processing Complete for NVD CVE - 2016  (794561 ms)
01:10:30  [INFO] Processing Started for NVD CVE - 2018
01:10:30  [WARN] Unable to save property 'NVD CVE 2017' with a value of '1551169671000' to the database
01:10:30  [INFO] Processing Complete for NVD CVE - 2017  (1076138 ms)
01:10:30  [INFO] Processing Started for NVD CVE - Modified
01:10:30  [WARN] Unable to save property 'NVD CVE Modified' with a value of '1551214963000' to the database
01:10:30  [INFO] Processing Complete for NVD CVE - Modified  (65180 ms)
01:10:30  [WARN] Unable to save property 'NVD CVE 2018' with a value of '1551168912000' to the database
01:10:30  [INFO] Processing Complete for NVD CVE - 2018  (705343 ms)
01:10:30  [WARN] Unable to save property 'NVD CVE Modified' with a value of '1551214963000' to the database
01:10:30  [INFO] Begin database maintenance.
01:10:30  [ERROR] An unexpected SQL Exception occurred; please see the verbose log for more details.
01:10:30  [INFO] End database maintenance.
01:10:30  [WARN] Unable to save property 'NVD CVE Checked' with a value of '1551229824025' to the database
01:10:30  [WARN] Unable to save property 'CurrentEngineRelease' with a value of '5.0.0.m1' to the database
01:10:30  [WARN] Unable to save property 'VersionCheckOn' with a value of '1551229824030' to the database
01:10:30  [INFO] Check for updates complete (9558609 ms)```

There appear to be a number of issues above - unfortunately we are about to cut code for a release of the project today and this could delay the release. Is the best thing to do to roll back to v4.0.1 and disable our version checking code?

I will re-run with verbose logging on and attach that to this issue.

Unfortunately due to time pressure I've had to roll us back to 4.0.2. I do still have the DB from above.
I've noticed that 4.0.2 is giving me [WARN] Unable to save property 'NVD CVE 2003' with a value of '1550913335000' to the database in the log file

I might have an answer to the issue of case sensitive table names: https://dev.mysql.com/doc/refman/5.6/en/identifier-case-sensitivity.html

2019-02-27 12:46:33,642 org.owasp.dependencycheck.data.nvdcve.CveDB:491
DEBUG -
com.mysql.jdbc.exceptions.jdbc4.MySQLSyntaxErrorException: PROCEDURE dependencycheck.save_property does not exist
        at sun.reflect.GeneratedConstructorAccessor37.newInstance(Unknown Source)
        at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
        at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
        at com.mysql.jdbc.Util.handleNewInstance(Util.java:411)
        at com.mysql.jdbc.Util.getInstance(Util.java:386)
        at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:1052)
        at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:3597)
        at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:3529)
        at com.mysql.jdbc.MysqlIO.sendCommand(MysqlIO.java:1990)
        at com.mysql.jdbc.MysqlIO.sqlQueryDirect(MysqlIO.java:2151)
        at com.mysql.jdbc.ConnectionImpl.execSQL(ConnectionImpl.java:2625)
        at com.mysql.jdbc.PreparedStatement.executeInternal(PreparedStatement.java:2119)
        at com.mysql.jdbc.PreparedStatement.execute(PreparedStatement.java:1362)
        at org.owasp.dependencycheck.data.nvdcve.CveDB.saveProperty(CveDB.java:476)
        at org.owasp.dependencycheck.data.nvdcve.DatabaseProperties.save(DatabaseProperties.java:126)
        at org.owasp.dependencycheck.data.nvdcve.DatabaseProperties.save(DatabaseProperties.java:114)
        at org.owasp.dependencycheck.data.update.nvd.ProcessTask.processFiles(ProcessTask.java:169)
        at org.owasp.dependencycheck.data.update.nvd.ProcessTask.call(ProcessTask.java:119)
        at org.owasp.dependencycheck.data.update.nvd.ProcessTask.call(ProcessTask.java:46)
        at java.util.concurrent.FutureTask.run(FutureTask.java:266)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
        at java.lang.Thread.run(Thread.java:748)

I can only assume that I cocked up initialising the DB somehow...


Add precommit hooks for black/flake. Global formatting PR

Add precommit hooks
Run global formatting.

in case it helps i'm close to https://github.com/charliermarsh/ruff which is a flake8 alternative

Let's do one big formatting-only PR as part of this.

Hi there! I am interested in contributing to this project and would like to request permission to work on this issue. I have experience with the technologies involved and believe I can provide a useful contribution to the project. Please let me know if there are any specific guidelines or instructions I should follow when working on this issue. Thank you!

That would be excellent if you want to! We basically want to integrate https://pre-commit.com/ to run flake8 and black on git commit. Then we want to use precommit run all files to to a global formatting pass. https://pre-commit.com/#4-optional-run-against-all-the-files

I've assigned the issue to you @rodneyosodo - if you decide not to take this on let me know! Was planning on doing it later this week :)

Can we try ruff?

#483


Reset Scan Average count on pause

With scans-to-average set to say 10, using the 'play/pause' or 'scan/save/stop' buttons, the scan batch doesn't start fresh, rather starts in the middle of a batch (ie. pauses at 4 of 10 scans, then scan/save/stops starting on 5 of 10 scans)
Ideally scan would start at 1 of 10 every time.
Marking as 'Easy' and 'Unspecified', because it seems easy but I haven't investigated.

"I've installed the 4.0.12 version and setup to conduct 5 second scans with 36 scan averages (3 minutes total).  I've notice that when I click on the Step Forward and Save, during the initial round the Scan averaging starts at 1.  However when I click it a 2nd time the Scan averaging never resets and continues cycling through.  Example if it takes me 1 minute to swap out samples when I click on the Step Forward and Save the Scan Averaging will say Collected 12 of 36 scans, and continue averaging up from 12.
For now after swapping the samples I'm just letting the system run through the 5sec x 36 scans when I'm swapping the samples  and using the next 5 x 36 set where it is only looking at the newer sample. "

Trying to make steps to reproduce.

Use 4.0.12 release $ git checkout 4.0.12

Set scan avg=36, int=5000

Pause acquisition

Click "Step forward and save"

Let it count to 12.

Click "Stop"

Again click "Step forward and save"

It hangs on 12 for [0,5) sec

Then it resets to one.

The first half of the observation is reproduced "...when I click on the Step Forward and Save [again] the Scan Averaging will say Collected 12 of 36 scans".
I'm not seeing next part "and continue averaging up from 12,". I'm seeing it reset to 1 after up to 5 sec.


Ruby 3

This pull request adds Ruby 3 to the test suite and relaxes some test and development dependencies to get the tests to run.
It also removes Ruby 2.3, 2.4, and 2.5 from the test suite, which are officially EOL.
This supersedes #937, which includes the fix for splatting of keyword arguments.

Closing in favor of #943, which includes these changes and more to get the tests running against modern versions of Ruby/Rails


Use Method.valueOf() instead of looping through toString()

Using toString() in Enum is unsafe as is can be overridden, name() is preferred. Moreover, valueOf() has the same effect as the lookup in values().
Added a few warning suppression for Eclipse.
Fixed super-minor typo.

I corrected an incorrect change but I'm not sure Travis re-did the check to ensure it is now passing all tests. It should though...

.

thanks!


feat(react): :sparkles: #807 - Created checkboxSplitProps hook

Created a checkbox specific createSplitProps hook.
Resolves: #807

Thanks for your contribution. For now we will not export this part of ark ui


When updating scope no "some are selected" symbols appear

Hi Folks,
If I change one of the leaf nodes to be selected by setting the model (i.e. leaf.selected = true) I expected to see the "some are selected" symbols, but the checkboxes are all empty.  It works when I manually click the box
Am I missing some option?

Thanks for your help!
Ash

Instead of modifying selected properties directly (i.e. leaf.selected = true) use the ivhTreeviewMgr service to change selected states (i.e. ivhTreeviewMgr.select(myTree, leaf)). Otherwise, as you noted, selection changes won't propagate through the tree - this done intentionally to ensure data consistency.

Thanks, I didn't realise you could do it without referencing the dom, but it works when using the model data, perfect!


Allow to configure the SSL configuration of the lumberjack component at the component level

Thanks for merging it !


Signpost blog contributors to “Write a blog post”

Link from content/en/blog/_index.md to https://kubernetes.io/docs/contribute/new-content/blogs-case-studies/#write-a-blog-post, so that someone who's considering contributing to the blog can easily find advice on doing that.

👋 @sftim ,
The change looks okay. One of the icons on the blog page points to this info:
https://kubernetes.io/docs/contribute/start/#write-a-blog-post
I bet most contributors don't read the _index.md files.
/lgtm

/lgtm
/approve


WIP Use early preview of .Net Core 3.0

PR Summary
There are only 1 failing test on Windows due to Compatibility section in application manifest not being embedded in pwsh.exe (https://github.com/dotnet/core-setup/issues/4963).
.Net Core 3.0 adds one reference assembly and also a .nupkg.metadata file for each shipped module containing the hash, which I ignore for the installer.
Removed dependency on rcedit to embed manifest and update assembly file properties as .Net Core 3.0 SDK supports same capabilities from csproj file.  Due to this change, the fileversion and productversion embedded as rouces in pwsh.exe has changed to their desired format defined in the csproj.  Tests were updated to account for this difference.
.Net Core 3.0 supports writing to reserved device names (like CON which writes to the console as expected; didn't test COM or LPT but presumably they would write to the COM and printer ports), so updated code to only check for CLOCK$ as a reserved device name.
Breaking Change By default, long paths are returned by the FileSystemProvider whereas before, it would retain the short path.   This change is due to a change in .Net Core 3.0 behavior related to long paths which invalidated existing tests that used $TestDrive which is built from $env:TEMP which has a short path (if the username is > 8 characters which is the case on AzPipelines for Windows).
PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[ ] Change is not breaking
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[ ] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

User-facing changes

[ ] Not Applicable
OR
[ ] User-facing Documentation needed

[ ] Issue filed - Issue link:

Testing - New and feature

[ ] Not Applicable or can only be tested interactively
OR
[ ] Make sure you've added a new test if existing tests do not effectively test the code changed

[ ] Add [feature] if the change is significant or affects feature tests

@bergmeister As discussed previously we'll release 6.2 before release .Net Core 3.0 so 6.2 should be on 2.1 version. I'd expect moving to 3.0 at april-may 2019.
First public preview 3.0 was announced for the end of 2018 and release May 2019. Only after release 3.0 we free to use it in the repo. You could keep the branch locally and update it.

Yes, the point of this is rather to check/monitor compatibility with .Net Core 3 early so that the .Net team has time to fix issues before they release.

Reverted attempt to move to newer 3.0 release since it caused more problems

We should try the new preview3 that got published yesterday

Since 6.2-GA was forked we can actively work on the PR.
I think we need rebase and then move to 3.0-Preview3.

I tried to update to preview3 locally but cannot even do a dotnet restore. It seems there are no matching Asp.Net Core Nuget packages. The version available on NuGet here is of version 3.0.0-preview3-19153-02 and does not match the requirements of projects depending on it. I get lots of errors similar to this:
C:\PowerShell\src\Microsoft.PowerShell.SDK\Microsoft.PowerShell.SDK.csproj : error NU1603: Microsoft.PowerShell.SDK depends on runtime.win-x64.Microsoft.AspNetCore.App (>= 3.0.0-preview3-27503-5) but runtime.win-x64.Microsoft.AspNetCore.App 3.0.0-preview3-27503-5 was not found. An approximate best match of runtime.win-x64.Microsoft.AspNetCore.App 3.0.0-preview4-19121-08 was resolved. [C:\PowerShell\src\powershell-win-core\powershell-win-core.csproj]
....
C:\PowerShell\src\powershell-win-core\powershell-win-core.csproj : error NU1603: pwsh depends on runtime.win-x64.Microsoft.AspNetCore.App (>= 3.0.0-preview3-27503-5) but runtime.win-x64.Microsoft.AspNetCore.App 3.0.0-preview3-27503-5 was not found. An approximate best match of runtime.win-x64.Microsoft.AspNetCore.App 3.0.0-preview4-19121-08 was resolved.

I wonder how we depend on Microsoft.AspNetCore.App?

@PoshChan Please get failures

@SteveL-MSFT, you are not authorized to request test failures

@PoshChan-Staging Please get failures

@PoshChan-Staging Please get failures

@PoshChan Please get failures

@PoshChan-Staging Please get failures

@PoshChan Please get failures

@SteveL-MSFT, you are not authorized to request test failures

@PoshChan-Staging Please get failures

@SteveL-MSFT, you are not authorized to request test failures

@PoshChan-Staging Please get failures

@SteveL-MSFT, you are not authorized to request test failures

@PoshChan-Staging Please get failures

@SteveL-MSFT, you are not authorized to request test failures

@PoshChan Please get failures

@PoshChan-Staging Please get failures

@bergmeister I try to compile your .net v3 branch and found the same symptom.
If I remove 'RuntimeFrameworkVersion' on PowerShell.Common.props and Test.Common.props PowerShell.Common.props, it lets me compile.
I also rollback your change to Microsoft.WindowsDesktop.App
dotnet.exe -info
.NET Core runtimes installed:
  Microsoft.AspNetCore.App 3.0.0-preview3-19153-02 [c:\program files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 3.0.0-preview3-27503-5 [c:\program files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.WindowsDesktop.App 3.0.0-preview3-27504-2 [c:\program files\dotnet\shared\Microsoft.WindowsDesktop.App]

There is a version's conflict between  all Microsoft.*.App runtimes and PowerShell.Common.props
I read all previous what's news about dotnet and aspnet, i don't found anything interesting.

@fmichaleczek At the moment we are waiting for preview4 to fix problems like that. If you want to try out a working version of netcore3 you could try using a daily build or checkout one of the older commits on this branch that used preview1 or preview2

Looks like Preview.4 just became available, I'll move the build to that version

Moving this to a working branch on PS/PS


Usage with react-intl

I suggest, that this should be allowed
<Helmet >
   <FormattedMessage {...msg.title}>
      {title => <title>{title}</title>}
   </FormattedMessage>
</Helmet>

What do you think?

Thanks for your interest in Helmet.
You can see an explanation here - https://github.com/nfl/react-helmet/issues/262#issuecomment-291000077

You can also use the injectIntl HoC and do intl.formatMessage() in your component instead.

@cesarp Yes, I know that. I just prefer less imperative approach.

@cwelch5 By the way, just FYI https://twitter.com/dan_abramov/status/855872355406671872 ))

You can simply switch things around:
<FormattedMessage id="msg.title">
  {title => <Helmet><title>{title}</title></Helmet>}
</FormattedMessage>

You can simply switch things around:
<FormattedMessage id="msg.title">
  {title => <Helmet><title>{title}</title></Helmet>}
</FormattedMessage>

Thanks @fxlemire , it works!

You can simply switch things around:
<FormattedMessage id="msg.title">
  {title => <Helmet><title>{title}</title></Helmet>}
</FormattedMessage>

save my day! kkk


Light client friendly events

This PR proposes a solution for light client friendly SRML events.
Each deposited event can specify zero or more topics. A topic is a fixed sized value (atm, is just a hash). When an event is deposited with some topic, the runtime adds the index of this event in the <Events<T>> list to a mapping that maps from topics to lists of indexes.
Light clients can "subscribe" to changes of specific storage values (see #628). The idea is that light clients would subscribe to changes of the storage values for a topic they are interested in. When the light client detects a change, it fetches the contents of the indexes list for the specific topic and with this the light client can query events' data by the indexes.
Marking this as draft, since I don't know if this is the way that we want to go, I didn't test this with light-client nor inspected the storage values and there are some questions left

Be good to get an opinion on this @svyatonik

I've checked the storage entries and add a test. This should be ready for review then.

There might be a problem with this approach, marking it inprogress until we figure it out.

what might the problem be?

Yes, there is indeed a problem, although not a significant one.
Consider the case when an event E was deposited with a topic A.
So at the end of the block N the field <EventTopics<T>> will be like:
A => vec![EventIndex(0)]

then, let's suppose that the same event E with the same topic A was deposited at the block N+1. Therefore, <EventTopics<T>> will look the same at the end of the N+1 block:
A => vec![EventIndex(0)]

Because the value at the storage location of A doesn't change there will be no notification of change between for the N+1.
I am still not entirely sure, but it seems to be a problem. If the light-client doesn't follow each block, and say, it "subscribes" to changes at the block N+1 it won't get the update.
To circumvent this problem we could store Vec<(EventIndex, BlockNumber)> in EventTopics instead of just Vec<EventIndex>. Or maybe even something like Option<(BlockNumber, Vec<EventIndex>)>.

Ok, I put up a commit which fixes this. However, I went with Vec<(EventIndex, BlockNumber)> instead of Option<(BlockNumber, Vec<EventIndex>)>. The reason for that is ::append is not available for this type. See the commit for details:
https://github.com/paritytech/substrate/pull/2491/commits/5f9ca06de6471b48e6ea84ebf2e3cb9c48cff122
Apparently it starts asking for a hand-rolled structure tailored for this particular use-case.

ok, but please add a TODO and issue explaining that this is highly inefficient and needs to be altered to Option<(BlockNumber, Vec<EventIndex>)> once we can implement ::append for it. please also assign it 1.x milestone

This seems like a breaking change and requires JS SDK side change as well.
@jacogr I don't think it is easy to have a JS SDK that compatible with Substrate versions that with and without this change.


generic generator - integrates feature generator

Codecov Report

Merging #245 into master will increase coverage by 0.14%.
The diff coverage is 87.5%.

@@            Coverage Diff            @@
##           master    #245      +/-   ##
=========================================
+ Coverage   67.96%   68.1%   +0.14%
=========================================
  Files          65      64       -1
  Lines        5294    5293       -1
=========================================
+ Hits         3598    3605       +7
+ Misses       1696    1688       -8

Impacted Files
Coverage Δ

onmt/modules/init.lua
100% <ø> (ø)
:arrow_up:

onmt/modules/Network.lua
100% <100%> (ø)
:arrow_up:

onmt/modules/Generator.lua
100% <100%> (ø)
:arrow_up:

onmt/Factory.lua
29.49% <25%> (+0.21%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 676d165...41e59d6. Read the comment docs.


RichSelect fetchEndpoint: URLs without hostname do not work

When using RichSelect with a URL that does not contain a hostname the query parameters will not be added to the request.
For example:
fetchEndpoint="http://localhost/api/options" will correctly request http://localhost/api/options?query=test&page=1
fetchEndpoint="/api/options" will always request http://localhost/api/options without any query parameters.
The documentation mentions that a FQDN should be used but it probably shouldn't fail in this fashion.

I accept a PR if you are willing to do so, the library is on maintenance mode for now.


Permissions: applying IsAuthenticated directive to entire schema

Hi there,
Instead of applying the IsAuthenticated() directive to individual fields, I'm looking to apply this to an entire schema.
I'd wondered if this might work, but it doesn't:
authenticated_schema = gql.Schema(
    query=AuthenticatedQueries,
    mutation=AuthenticatedMutations,
    extensions=[SchemaDirectiveExtension],
    directives=[IsAuthenticated()]
)

I get a type error:
Expected type 'Iterable[StrawberryDirective]', got 'list[IsAuthenticated]' instead
And an actual error:
AttributeError: 'IsAuthenticated' object has no attribute 'arguments'.
Any thoughts?

Hey @gghdev ,
That directives argument in Schema is just so that you can pass directives that can be used by the client, like this one (strawberry has support for that but it is missing documentation)
There isn't an easy way to insert IsAuthenticated in all queries currently, but if you ensure that all queries inside the Query type and all mutations inside the Mutation type have this directive, then it should do what you need, since the root queries are required to retrieve any information below them

@bellini666 So I presume there's no way to apply a directive to an object either? Would that be difficult to implement? Where one would have to start?


How do I add a new port

Hello, I  have a quite general question. I was thinking about adding a port to some library. But since this library is not supported on all the platforms/configurations, I added a number of "vcpkg_fail_port_install" in the portfile.cmake file, as was suggested  https://github.com/microsoft/vcpkg/issues/8602#issuecomment-543033779
Now this port tells "Some checks were not successful" : https://github.com/microsoft/vcpkg/pull/8628l
Is this an expected behavior? Should the port pass all the checks in order to be integrated? Should every port support all the platforms/configurations? If it is possible not to support all the configurations, then then what is the correct way to handle this?
Best regards, Igor

Hi @ig-or, thanks join us as our contributor! We already have documentation and examples, please see these link.

Thanks.

Does this issue still bother you?

Will be able to check again after January 2, sorry..
Happy new year!!
On Mon, Dec 30, 2019 at 7:10 PM Jack·Boos·Yu<EMAIL_ADDRESS>wrote:

Does this issue still bother you?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vcpkg/issues/8823?email_source=notifications&email_token=AEW4RWGA4BNPO2ETB4TZFKLQ3KZ2BA5CNFSM4JHC2TM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEH3UVNA#issuecomment-569854644,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEW4RWB2LNL3PKZ4OU3GWSLQ3KZ2BANCNFSM4JHC2TMQ
.

If this issue is still not resolved, please reopen it.


Is there a way to make the window unresizable in a portable way?

Probably using setFixedSize with the result of size. But I don't see the point...

It's to avoid resizing the window, as the interface don't really adapt to a new size, and also to avoid misclicking on the maximize button