Programmatically moving to new tab leaves previous tab title bolded

I'm using a ButtonBarPagerTabStrip with 4 tabs. The first view controller is a collection view with cells that link to the subsequent tabs. I'm programmatically switching tabs with the following code, where tabIndex is the new tab index:
self.buttonBarView.moveTo(index: tabIndex, animated: true, swipeDirection: .none, pagerScroll: .yes)
self.moveToViewController(at: tabIndex, animated: false)

It works as anticipated when moving to the second tab, but when it moves to the third or fourth tab the first tab title remains bolded.
Screenshot of buggy behavior:

Screenshot of anticipated behavior:

Anyone else seen this bug? Is there a workaround?
Thanks!

Was wondering if there may have been any movement on this issue? We're running into the same problem when moving to tabs over the index 2/3.

@miranda-elliott @djneely Any workaround for this issue?

@rehannali unfortunately not for us. what we wound up doing is having to disable programmatic navigation to the different tabs for now as it was a glaring bug but without a fix for now. so while the app isn't as functional as we'd like there isn't a bug atm.
hoping we hear something back soon from the devs with regards to either a fix on our side or if they've patched this.

Hi, @miranda-elliott , @djneely  I haven't the proper solution for it.but following code snippet works for me.Its bit hack solution for this issue.
Simple paste following line after your code.
if let cell = strongSelf.buttonBarView.cellForItem(at: IndexPath(item: 0, section: 0)) as? XLButtonBarViewCell {             cell.label.textColor = UIColor.black.withAlphaComponent(0.40)           }
Your new code will be
self.buttonBarView.moveTo(index: tabIndex, animated: true, swipeDirection: .none, pagerScroll: .yes)

self.moveToViewController(at: tabIndex, animated: false)

if let cell = strongSelf.buttonBarView.cellForItem(at: IndexPath(item: 0, section: 0)) as? XLButtonBarViewCell {
            cell.label.textColor = UIColor.black.withAlphaComponent(0.40)
          }

Thanks @kevadiyaVishal I'll give that a shot and see how it fairs for us.

@kevadiyaVishal this does not appear to work. I'm seeing: 'Use of undeclared type XLButtonBarViewCell'.
When looking at what self.buttonBarView.cellForItem(...) returns it appears its returning a UICollectionViewCell?
I haven't dug much deeper into pulling out and parsing through all those subviews as of yet but will come back to it at another time.

Sorry. Simple fix. Its now ButtonBarViewCell.

@kevadiyaVishal thanks again for your help. Definitely got us going on the right direction. I wound up fixing it by doing this:
if let cell = self.buttonBarView.cellForItem(at: IndexPath(item: 0, section: 0)) as? ButtonBarViewCell {
     // cell.label.textColor = UIColor.black.withAlphaComponent(0.40)
    cell.label.font = UIFont(name: "Avenir-Light", size: 14)!
}

Setting the label's font back to the font we're using per the setting:
self.settings.style.buttonBarItemFont = UIFont(name: "Avenir-Light", size: 14)!

Did the trick for us. Using just the alpha component still let the font Bold but made it gray-ish to match the other tabs.

Hi
Thank you very much for your reply.
This is one of my most favorite library
Thanks for sharing with us
On Thu, May 17, 2018, 10:57 PM Derek Neely<EMAIL_ADDRESS>wrote:

@kevadiyaVishal https://github.com/kevadiyaVishal thanks again for your
help. Definitely got us going on the right direction. I wound up fixing it
by doing this:
if let cell = self.buttonBarView.cellForItem(at: IndexPath(item: 0, section: 0)) as? ButtonBarViewCell {
// cell.label.textColor = UIColor.black.withAlphaComponent(0.40)
cell.label.font = UIFont(name: "Avenir-Light", size: 14)!
}
Setting the label's font back to the font we're using per the setting:
self.settings.style.buttonBarItemFont = UIFont(name: "Avenir-Light", size: 14)!
Did the trick for us. Using just the alpha component still let the font
Bold but made it gray-ish to match the other tabs.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/xmartlabs/XLPagerTabStrip/issues/554#issuecomment-389945576,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQhvCHGkhknt6M2caOUwHlw7aYvCWcDzks5tzbLvgaJpZM4SyfHb
.

Thanks, Working.. @kevadiyaVishal

@dasSoumen welcome brother :)

Thanks, It's working @kevadiyaVishal


Remove ase/pymatgen/... inputs from constructor in favor of from_ classmethods

Currently the constructor of the StructureData still has e.g. the ase input to initialize an instance from an ASE Atoms object:
https://github.com/aiidateam/aiida-atomistic/blob/1af101e382920ab0489bb3f00ac416e5bf330b70/src/aiida_atomistic/data/structure/__init__.py#L717-L727
I would instead want to see a from_ase() class method, e.g.:
from ase.build import bulk

bulk_si = bulk('Si', cubic=True)

structure_data = StructureData.from_ase(bulk_si)

Hi @mbercx , I will work on this :rocket: today


Make column summary statistics optional

Currently calculated for each column but requires multiple column searches which can be expensive on larger files. Make this is a parquet option.

Currently writing a higher level library for consumers that want to read and surface dataframes called parquet-util pushing #78 in that and will integrate into parq with @AndyCross to give DF summaries


use yarn as package manager

added react-addons-test-utils because it was an unmet dependency of react-shallow-testutils

so Travis automatically runs the install with yarn instead of npm install if it detects both package.json and yarn.lock which is pretty cool.  have you played with the yarn cache yet?  does it speed things up?  if so, maybe we tell Travis to use it too: https://docs.travis-ci.com/user/languages/javascript-with-nodejs/#Caching-with-yarn

I ran the PR build three times and I am seeing slight performance increase in yarn install I added the cache directive in travis.yml

👍


[url_launcher] Unupdated url_launcher_android dependency will cause version 2.1.0 to not work correctly

The current url_launcher pubspec.yaml (version 6.1.0) will not force the update of its url_launcher_android dependency from 6.0.13 to the newest version 6.0.16.
The 6.0.16 version for url_launcher_android will effectively fix the problem targeted by the url_launcher update 2.1.0, but since it's not correctly indicated in url_launcher's pubspec, devs would have the manually update their pubspec.lock files to use the correct version.
The pictures below should illustrate it better.
url_launcher changelog stating the fix for preventing common issues with providing invalid URL strings.

url_launcher's pubspec.yaml

url_launcher_android's changelog - fix only applied in version 6.0.16

I'm opening a PR with this pubspec update and will leave it there for your appreciation. Thanks!

The current url_launcher pubspec.yaml (version 6.1.0) will not force the update of its url_launcher_android dependency from 6.0.13 to the newest version 6.0.16.

This is intentional; url_launcher 6.1.0 is compatible with earlier versions of url_launcher_android.

The 6.0.16 version for url_launcher_android will effectively fix the problem targeted by the url_launcher update 2.1.0

url_launcher_android 6.0.16 fixes an issue with false negatives in canLaunch* for certain http(s) URLs on Android. url_launcher 6.1.0 provides a new API surface that is harder to use incorrectly. The two are unrelated.

but since it's not correctly indicated in url_launcher's pubspec, devs would have the manually update their pubspec.lock files

dart pub upgrade, with or without a target package, will upgrade dependencies transitively. Nobody needs to manually edit pubspec.lock files to get updates to transitive dependencies.

to use the correct version.

There is no "correct" here. People who want updated version of their transitive dependencies need to update them, yes, but if they don't they are welcome to continue using older versions.
Closing as there is no bug here. The title's claim that the combination will not work correctly is not correct.

@stuartmorgan Actually it won't launch if we don't update the url_launcher_android lib to 2.0.16. Here's a minimal version showing the bug:
run flutter create project_name
import url_launcher
Replace main.dart with this snippet:
import 'package:flutter/material.dart';
import 'package:url_launcher/url_launcher.dart' as url_launcher;

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({Key? key}) : super(key: key);

  // This widget is the root of your application.
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        // This is the theme of your application.
        //
        // Try running your application with "flutter run". You'll see the
        // application has a blue toolbar. Then, without quitting the app, try
        // changing the primarySwatch below to Colors.green and then invoke
        // "hot reload" (press "r" in the console where you ran "flutter run",
        // or simply save your changes to "hot reload" in a Flutter IDE).
        // Notice that the counter didn't reset back to zero; the application
        // is not restarted.
        primarySwatch: Colors.blue,
      ),
      home: const MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  const MyHomePage({Key? key, required this.title}) : super(key: key);

  // This widget is the home page of your application. It is stateful, meaning
  // that it has a State object (defined below) that contains fields that affect
  // how it looks.

  // This class is the configuration for the state. It holds the values (in this
  // case the title) provided by the parent (in this case the App widget) and
  // used by the build method of the State. Fields in a Widget subclass are
  // always marked "final".

  final String title;

  @override
  State<MyHomePage> createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  bool result = true;
  final link = Uri.parse('https://www.linkedin.com/in/gabrielaraujoz');

  void _incrementCounter() async {
    if (await url_launcher.canLaunchUrl(link)) {
      result = await url_launcher.launchUrl(link);
    } else {
      print('url cannot be launched, stackTrace: ${StackTrace.current}');
      result = false;
    }
    setState(() {});
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        // Here we take the value from the MyHomePage object that was created by
        // the App.build method, and use it to set our appbar title.
        title: Text(widget.title),
      ),
      body: Center(
        // Center is a layout widget. It takes a single child and positions it
        // in the middle of the parent.
        child: Column(
          // Column is also a layout widget. It takes a list of children and
          // arranges them vertically. By default, it sizes itself to fit its
          // children horizontally, and tries to be as tall as its parent.
          //
          // Invoke "debug painting" (press "p" in the console, choose the
          // "Toggle Debug Paint" action from the Flutter Inspector in Android
          // Studio, or the "Toggle Debug Paint" command in Visual Studio Code)
          // to see the wireframe for each widget.
          //
          // Column has various properties to control how it sizes itself and
          // how it positions its children. Here we use mainAxisAlignment to
          // center the children vertically; the main axis here is the vertical
          // axis because Columns are vertical (the cross axis would be
          // horizontal).
          mainAxisAlignment: MainAxisAlignment.center,
          children: <Widget>[
            const Text(
              'This button will launch the link',
            ),
            Text(
              result.toString(),
              style: Theme.of(context).textTheme.headline4,
            ),
          ],
        ),
      ),
      floatingActionButton: FloatingActionButton(
        onPressed: _incrementCounter,
        tooltip: 'Launch link',
        child: const Icon(Icons.add),
      ), // This trailing comma makes auto-formatting nicer for build methods.
    );
  }
}

You'll see it won't launch, the error being:
I/UrlLauncher(29601): component name for https://www.linkedin.com/in/gabrielaraujoz is null
I/UrlLauncher(29601): component name for https://flutter.dev is null
I/flutter (29601): url cannot be launched, stackTrace: #0      _MyHomePageState._incrementCounter
package:url_launcher_test/main.dart:59
I/flutter (29601): <asynchronous suspension>

Could you please try this out and see if it works for you in an Android Emulator/Device? If it does it might be some configuration I have in my machine. Thanks!

@stuartmorgan honest question here: should I open another issue with this info as well?

Ok @stuartmorgan , thanks for the review and input. Sorry for wasting your time, I really thought this was necessary since in my project (with url_launcher_android at 6.0.13) it wouldn't launch the link and only got to work with the update to 6.0.16 - maybe we should add some documentation on this or do you think it shouldn't be necessary?

I really thought this was necessary since in my project (with url_launcher_android at 6.0.13) it wouldn't launch the link and only got to work with the update to 6.0.16

If "the link" is a link with a custom app handler, and "won't launch the link" means that canLaunch* returns false (which isn't the same as not actually being able to launch the link, since launch* will work in that scenario—it's a false negative in canLaunch) that's expected, because url_launcher_android 6.0.16 is what fixed that specific issue. As documented in the url_launcher_android release notes in your screenshot above.

maybe we should add some documentation on this

It's not clear to me what you want to document (or where). The issue you had is that you wanted a fix from url_launcher_android 6.0.16 but were using 6.0.13, and the solution is simply to update your package dependencies to get 6.0.16. How to update dependencies is already documented.


Auto collecting Serum doesnt stay disabled

Every time when i load my save i have to turn off auto collecting Zombie Serum for every colonist.

Thanks. It will be fixed in release 3.1.1


response 403 when generating scaffold

I already have neo4j server up and running correctly on http://localhost:7474
When i use rails generate scaffold
I get the following error: neo4j-core-5.1.6/lib/neo4j-server/cypher_session.rb:51:in `open': Server not available on http://localhost:7474 (response code 403) (RuntimeError)
I tried disabling password authentication and still the same error pops up:
Is it to do with the fact that i am behind a http proxy  (But i do have the bash proxy environment variables set).
Below is my application.rb file:
require File.expand_path('../boot', __FILE__)

require "rails"
# Pick the frameworks you want:
require "active_model/railtie"
require "active_job/railtie"
# require "active_record/railtie"
require "action_controller/railtie"
require "action_mailer/railtie"
require "action_view/railtie"
require "sprockets/railtie"
require 'neo4j/railtie'
require "rails/test_unit/railtie"

# Require the gems listed in Gemfile, including any gems
# you've limited to :test, :development, or :production.
Bundler.require(*Rails.groups)

module TestdbApp
  class Application < Rails::Application

    config.generators do |g|
      g.orm             :neo4j
    end

    #config.neo4j.session_options = { basic_auth: { username: 'neo4j', password: 'dbpasswd'} }
    config.neo4j.session_type = :server_db
    config.neo4j.session_path = 'http://localhost:7474'
    # Configure where the embedded neo4j database should exist
    # Notice embedded db is only available for JRuby
    # config.neo4j.session_type = :embedded_db  # default #server_db
    # config.neo4j.session_path = File.expand_path('neo4j-db', Rails.root)

    # Settings in config/environments/* take precedence over those specified here.
    # Application configuration should go into files in config/initializers
    # -- all .rb files in that directory are automatically loaded.

    # Set Time.zone default to the specified zone and make Active Record auto-convert to this zone.
    # Run "rake -D time" for a list of tasks for finding time zone names. Default is UTC.
    # config.time_zone = 'Central Time (US & Canada)'

    # The default locale is :en and all translations from config/locales/*.rb,yml are auto loaded.
    # config.i18n.load_path += Dir[Rails.root.join('my', 'locales', '*.{rb,yml}').to_s]
    # config.i18n.default_locale = :de
  end
end

I'm guessing that it's probably the proxy.  First I should ask: Did you restart after disabling Neo4j's auth?
Can you try it without a proxy to debug?
Also if auth is enabled you may want to log into the neo4j web console and change the default password because Neo4j won't allow you to login via the HTTP endpoints (like Neo4j.rb does) until you've done that

Well i don't think it's the proxy, instead of http://localhost:7474 i tried http://myipaddress:7474 and it worked. And also it worked only when i disabled password auth, if i do it with auth then it just gets stuck and doesn't proceed at all.

Oh, interesting, I thought you were saying that it didn't work still when you disabled auth.  That would make some more sense, at least.
Have you yet logged into the Neo4j web console in your browser and set a new password from the default neo4j/neo4j?

Also, a bug to stick in @subvertallchris or anybody else who cares to think about this:
It might be good for us to catch particularly HTTP status codes and provide help for people on things that they can try.  Maybe text in the error with a suggestion or two, or maybe even just a link to the readthedocs docs so that we can easily update what to do in case of a 401, 403, 404, etc...  GitHub issues provide some search-ability, but it would be nice to have something kind of official.

Yes, i did change my password from the original from the browser, that was the first thing i did so i don't think that's the problem.

I'm not really sure what's going on, but since it's working this seems to be working in the non-localhost case I would guess it's an issue with networking and not the gem.  I'm going to close it, but if you find it's an issue with the gem, definitely re-open (or open another issue).
There is also a public Neo4j slack group where somebody else might be able to help you:
http://neo4j.com/blog/public-neo4j-users-slack-group/
I'm on Holiday this week so I have limited time, unfortunately.


Error to save JSON Field

I'm trying to save a json field in the Mysql database, and it's returning me the following error (look at the Gist):
https://gist.github.com/danielsalles/fa75a48835406ea7262c421ceec238f2

You need to stringify the json it before you save it to the database

@webdevian No. I want to save with JSON, mysql already supports JSON in version 5.7.


Streaming search results instead of only keyword in public stream

If would be great to be able to stream the public results for more complex queries than a single keyword. I routinely monitor twitter results for searches involving long sequences of ORed terms.
What would be the easiest way to implement this given the structuring of the code?

Any solution to this ? Is it in any way achievable ?
My use case is I'm monitoring for simple search query, but which involve multiple keywords.


Add fetcher: fetchFromSourcehut

Motivation for this change
I start to see programs hosted on sourcehut, so I think adding a fetcher will be helpful.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Should I continue modifying srcs to use fetchFromSourcehut instead of fetchurl?

One quick question: is the sourcehut url format stable? If yes, never mind, but if it isn't, maybe we should be able to override the function that generates the url!

I think the domain should be able to change, as far as I know you can host your own instance.
Besides that, we need to get the base approved, with how fetchFromSourcehut works, before any more are changed (I would say. Maybe @worldofpeace  can help on this?
Also tagging @SuperSandro2000 and @mweinelt as they seemed interested in this!

is the sourcehut url format stable

I hope!

IIRC Drew has said that the ~ is not going to change so the URL is stable but as mentioned before you can host SourceHut yourself and so it could be git.your.domain. Perhaps an FQDN override (or something better named since your.domain isn't fully qualified, it's missing the git giving git.your.domain).

Perhaps an FQDN override

This is already implemented: domain ? "sr.ht". domain may not be the best name for it, but it's called like that in the gitlab fetcher.

on SourceHut the discussion is ongoing on what the organisation (user group) prefix will be

Thanks for the information!
I think there are two solutions to that.

we add group ? false to the args and swap ~ to whatever it will be (like + or ^) if group is true.
Usage example with git.sr.ht/^sourcehut/core.sr.ht (or git.sr.ht/+sourcehut/core.sr.ht):

src = fetchFromSourcehut {
  owner = "sourcehut";
  group = true;
  repo = "core.sr.ht";
  rev = ...;
  sha256 = ...;
};

we default owner and group to null and use the one that is not null with the correct prefix.

src = fetchFromSourcehut {
  group = "sourcehut";
  repo = "core.sr.ht";
  rev = ...;
  sha256 = ...;
};

Usage example with git.sr.ht/~sourcehut/core.sr.ht in both cases:
src = fetchFromSourcehut {
  owner = "sourcehut";
  repo = "core.sr.ht";
  rev = ...;
  sha256 = ...;
};

Wouldn't it be easer to use one attribute for users and one for groups?
src = fetchFromSourcehut {
  user = "sourcehut";
  repo = "core.sr.ht";
  rev = ...;
  sha256 = ...;
};

src = fetchFromSourcehut {
  group = "sourcehuters";
  repo = "core.sr.ht";
  rev = ...;
  sha256 = ...;
};

Wouldn't it be easer to use one attribute for users and one for groups?

Might be a better option, although it would make the code more complicated. And also it might end up more confusing if people read the code of the fetchFromSourceHut function.
A flag is less complex to understand and adds little overhead IMO.

Wouldn't it be easer to use one attribute for users and one for groups?

I think we should keep the owner naming for what you are referring as user, even if a group is technically an owner, because that's how the other fetchers are naming it.

A flag is less complex to understand and adds little overhead IMO.

having to set a flag if I want to download things from a group is not very intuitiv for people coming from GitHub, GitLab or Gitea because they all don't have that difference.

Didn't you come to the conclusion that groups on sourcehut are a bit different from all other platforms?

I don't know how they work on github and gitlab, so I can't tell if it is different.

And if users are confused we can throw an explanation if they pass owner into the fetcher.

That could be a solution, but we are all used to give owner, repo, rev and sha256 to fetchers. I think it would be annoying to have a fetcher that uses a different naming for one thing, and I would see myself mixing up owner and user.
It would not be a big deal, especially if it throws a good error, but I see it being annoying

I don't know how they work on github and gitlab, so I can't tell if it is different.

the URL scheme is just the same. github.com/NixOS could be a group or a user.

But if other people think too it should be user and group, I'm not against it, I just think there are drawbacks.

Or the owner is prefixed with ~ or something else but adding a flag isGroup = true is the most inconvenient solution.

Can you please fix the merge conflcit?

I don't want to bikeshed, but by analogy with fetchFromGitHub, I would have expected this to be called fetchFromSource**H**ut.

I don't want to bikeshed

We are already in a bikeshed problem :P

by analogy with fetchFromGitHub, I would have expected this to be called fetchFromSourceHut.

IDK, because it's GitHub, GitLab and SourceForge, but it's sourcehut or Sourcehut, they chose to not capitalize it for some reason.
We still need someone to decide the best solution for the group/user/owner/flag problem.

That's fair, I'm just catching up with the rest of the thread now. What if we just sidestep the owner/group altogether, and just say owner = "~sircmpwn";? And if group support is added further down the line with some other sigil, we can just do owner = "^group", without having to change the fetcher code? You could still have a shorthand as follows:
{ user ? nulll
, owner ? "~${user}"
}

And if/when they make up their mind about what sigil to use, you could update that to:
{ user ? nulll
, group ? nulll
, owner ? if !isNull group then "^${group}" else "~${user}"
}

But in any case there's no reason for this PR to be blocked on that.

Thanks, this is a great solution!
@SuperSandro2000 what do you think?

Thanks, this is a great solution!
@SuperSandro2000 what do you think?

sounds go to me.

I start to see programs hosted on sourcehut, so I think adding a fetcher will be helpful.

Just in case:
$ egrep -ir --include="*.nix" "url.*=.*sr.ht" nixpkgs/ | wc -l
29

I start to see programs hosted on sourcehut, so I think adding a fetcher will be helpful.

Just in case:
$ egrep -ir --include="*.nix" "url.*=.*sr.ht" nixpkgs/ | wc -l
29

@luc65r please fix the merge conflict.

@luc65r please fix the merge conflict.

I lost track of this since my last comment but I intend to give it a final review tomorrow and hopefully merge it (so that we can also properly fix #115397), so please let me know if there are any important objections (likely not but just to be sure). And if someone else reviews/merges it before that that's obviously fine as well :)


ebiten: RunOptions.InitUnfocused doesn't work

Ebitengine Version
v2.7.9
Operating System

[X] Windows
[X] macOS
[X] Linux
[X] FreeBSD
[X] OpenBSD
[ ] Android
[ ] iOS
[ ] Nintendo Switch
[ ] PlayStation 5
[ ] Xbox
[ ] Web Browsers

Go Version (go version)
go version go1.22.6 darwin/arm64
What steps will reproduce the problem?

The window is unfocused when launching
What happens instead?
The window was focused when launching
Anything else you feel useful to add?
2.6 didn't reproduce the issue. This is a regression.

I think the fix for #2924 is the culprit


Simplify reservation flow by disabling the need for any other signature than the one from the client reserving

During the beta on testnet we want to simplify the reservation flow described here as much as possible.
So instead of having signature from customer, farmer and potential stakeholder. We want to simplify this as just requiring a signature from the customer only.
So as soon as the reservation is sent and signed by the customer that want to reserve, the reservation should be marked as ready to deploy so 0-OS nodes can pick it up and deploy it asap.

I've been looking at the code of the workload_manager, it seems we could also reduce the number of API call to 1 to create a reservation if the user sends a reservation schema with it's signature already present inside.
At the moment registering a reservation and sending the customer signature always requires 2 call. This is not really needed I think.

fixed in #161


Update package:intl lints dependency to v4

@mosuem I updated the generated files to conform to the lints, could you land this PR internally and perhaps add the generator changes? I appreciate the help!

@parlough Thanks for the PR! This just needs a changelog entry, then I can approve the PR and it will be imported to g3 and then auto-merged here.


MSM8996 support?

With gus' Secure Boot unlock flaw making it possible to exploit MSM8996 devices like the HP Elite X3, would it be possible to port this UEFI firmware to MSM8996? Does the MSM8994 used in the 950s share a significant amount of code with the MSM8996?

This requires significant engineering effort and thus it is out of the scope.


ocpp1.6: PropertyConstraintViolation - ConfigurationKey[3].Value must be maximum 500, but was 0

Here's what's happened in https://github.com/evcc-io/evcc/issues/6817:
enqueued CALL [2627073400, GetConfiguration] for TACW****
dispatched request<PHONE_NUMBER> for TACW****
sent JSON message to TACW****: [2,"2627073400","GetConfiguration",{}]
received JSON message from TACW****: [3, "2627073400", {"configurationKey": [{"key": "GetConfigurationMaxKeys", "readonly": true, "value": "20"}, {"key": "HeartbeatInterval", "readonly": false, "value": "60"}, {"key": "MeterValueSampleInterval", "readonly": false, "value": "30"}, {"key": "AuthorizationKey", "readonly": false}, {"key": "LocalAuthorizeOffline", "readonly": false, "value": "true"}, {"key": "LocalPreAuthorize", "readonly": false, "value": "false"}, {"key": "LocalAuthListEnabled", "readonly": false, "value": "true"}, {"key": "LocalAuthListMaxLength", "readonly": true, "value": "16"}, {"key": "SendLocalListMaxLength", "readonly": true, "value": "8"}, {"key": "SupportedFeatureProfiles", "readonly": true, "value": "Core,FirmwareManagement,LocalAuthListManagement,SmartCharging,RemoteTrigger"}, {"key": "ChargeProfileMaxStackLevel", "readonly": true, "value": "3"}, {"key": "ChargingScheduleAllowedChargingRateUnit", "readonly": true, "value": "Current,Power"}, {"key": "ChargingScheduleMaxPeriods", "readonly": true, "value": "25"}, {"key": "MaxChargingProfilesInstalled", "readonly": true, "value": "16"}, {"key": "NumberOfConnectors", "readonly": true, "value": "1"}, {"key": "AllowOfflineTxForUnknownId", "readonly": false, "value": "false"}, {"key": "AuthorizeRemoteTxRequests", "readonly": false, "value": "false"}, {"key": "ConnectionTimeOut", "readonly": false, "value": "120"}, {"key": "WebSocketPingInterval", "readonly": false, "value": "60"}, {"key": "StopTransactionOnInvalidId", "readonly": false, "value": "true"}, {"key": "MaxEnergyOnInvalidId", "readonly": false, "value": "1000"}, {"key": "MeterValuesAlignedData", "readonly": false, "value": "Energy.Active.Import.Register"}, {"key": "MeterValuesAlignedDataMaxLength", "readonly": true, "value": "4"}, {"key": "ClockAlignedDataInterval", "readonly": false, "value": "0"}, {"key": "MeterValuesSampledData", "readonly": false, "value": "Current.Import,Current.Offered,Energy.Active.Import.Register,Power.Active.Import,Voltage"}, {"key": "MeterValuesSampledDataMaxLength", "readonly": true, "value": "22"}, {"key": "ResetRetries", "readonly": false, "value": "0"}, {"key": "TransactionMessageAttempts", "readonly": false, "value": "10"}, {"key": "TransactionMessageRetryInterval", "readonly": false, "value": "10"}]}]
sent CALL ERROR [2627073400] for TACW****
ocpp message<PHONE_NUMBER>): PropertyConstraintViolation - Field CallResult.Payload.ConfigurationKey[3].Value must be maximum 500, but was 0 for feature GetConfiguration

If I don't misjudge this the culprit 3 is
{"key": "AuthorizationKey", "readonly": false}

It looks as if the validation rule in https://github.com/lorenzodonini/ocpp-go/blob/fc83394875b1fc6f96fe4ad46e5d6889c3daa0f4/ocpp1.6/core/get_configuration.go#L15 is mis-triggering? The message is bogus if it's checking for maximum- seems this is more a required fields check?

Confirmed. I can repro the error by sending the following Configuration to the CS:
func (handler *ChargePointHandler) OnGetConfiguration(request *core.GetConfigurationRequest) (confirmation *core.GetConfigurationConfirmation, err error) {
	return core.NewGetConfigurationConfirmation([]core.ConfigurationKey{
		{Key: "AuthorizationKey"},
	}), nil
}

I've also noticed a follow-on error. The PropertyConstraintViolation is returned from CS to CP. It is not returned to the GetConfiguration() call though. Eventually, GetConfiguration will time out with GenericError which seems really unfortunate as it hides the underlying issue. Shall I open separate issue for this?

Nice catch, I'm looking into it and will try to tackle both issues directly, no need to open another issue.

Great thank you! This was only possible thanks to the new logging capabilities:)

Shall I open separate issue for the error return now or do you think current behaviour is by design?

@andig no need, the other issue is WIP. I closed this issue by mistake. I just reopened it.

@lorenzodonini any chance to get this fixed? I had a look at the code but don't quite understand how/where the errors are returned or why the actual error gets swallowed. Would be happy to put up a small bounty!

@andig I have an open branch with a working solution. Need to write some tests then I'll merge the fix.

@andig I merged a fix. When a response with an invalid payload is returned, the library will now send an error instead to the requesting endpoint. Let me know if you still encounter any issues.

When a response with an invalid payload is returned, the library will now send an error instead to the requesting endpoint.

@lorenzodonini does that only cover invalid payloads or any errors returned by the chargepoint? Imho the expected behaviour would be that any request that the remote endpoint returns an error for returns that error to the caller instead of waiting for timeout.
Is that the correct understanding? I'll merge your changes into our dev environment and check for feedback.

It covers any error encountered while sending a response, in either direction. For network errors, the timeout/disconnect will still be the quickest indicator though.
Feel free to look at the charge_point.go/sendResponse function logic for more info.

Think this one has been fixed, much appreciated!


[FEAT] Monterey style theme almost ready

Is your feature request related to a problem? If so, please describe.
Hello, @AdamXweb @easonwong-de ! Guys, I need your help with modding this theme. I'm not an expert, but somehow I've adapted vinceliuice WhiteSur GTK Theme  with Monterey style for WIndows, but window button position is same as Windows(close button is the last and not the first like in macOS) and their size and distance is a bit off(check my screenshot). I would like to ask you for help to make them correct or how to do it, can you please inspect my code? I will add my archive file here. And a special request to @easonwong-de  for adapting this theme for Adaptive Tab Bar colour. A lot of people wished this theme style for Windows but I see that you didn't developed it so I thought to adapt it by myself but this version have some minor problems since I'm not into programming and I'm already tired because I learnt so many new stuff today just to implement this code from GTK theme lol...

chrome.zip
Describe the solution you'd like
Change window buttons to correct macOS position and fix size and their distance between them. And maybe add Adaptive-Tab-Bar-Colour support
Priority
Medium (Would be very useful)
Is this something you would be keen to implement
Yes!
P.S sorry for bad grammar and my English - not my first language and I didn't practiced for a while.

Hi! U have any update for this one? looks pretty good and i really need a theme like that. Monterey\onliner style. Looking for hover bookmark bar too.


Missing spinner while toggle-tree

Hi,
when using datagrid in tree mode I came across the situation when loading subtree takes some time. In this case there is no spinner showing up to let user know that something is happening. Is there any reason why the spinner is absent?
If not I would be very happy to prepare PR, or to be more specific - I have already prepared it, but I ended up hesitating where is the right place for showing the spinner up (any ideas?).
Otherwise thank you for the great datagrid.

Well, I really don't know. Do you have any idea? :) I would merge it definitely.


Add KNN classification examples on unobserved data

So far no KNN classifier is trained. We only observe correlations between variables. We need to add a classifier.

Issue is not needed anymore. Can be closed.


11814 CNN mappings

This PR adds the HL7v2 to FHIR and FHIR to HL7 mappings for the CNN datatype.
This branch is not intended to be merged to master. These changes will be merged along with the changes for #11672.
Test Steps:

Confirm that new tests pass. (Note: there is one failing test, for HCI [OBR.34]; this will be handled in the process of completing #11672)

Changes

Added HL7v2 to FHIR and FHIR to HL7v2 mappings for the CNN HL7 datatype.
Adjusted existing schemas to use the new mappings.
Added integration tests.

Checklist
Testing

[x] Tested locally?
[x] Ran ./prime test or ./gradlew testSmoke against local Docker ReportStream container?
[x] Added tests?

Linked Issues

#11814

To Be Done

#11672

Closing as planned; superseded by #12002


Upgrade to the latest kotlin version

Current version of abi is far behind the latest stable.
Could you please upgrade it?

Thanks for the interest in this project.
I've been meaning to upgrade it but kotlinx-io was taking it's sweet time to catch up to 1.3.50. It caught up yesterday so I will be able to upgrade this soon.

Version 0.1.6 is built with Kotlin 1.3.50.

Great! Much appreciated. But it's not over yet =)

Could not find com.kgl:kgl-glfw-macosx64:0.1.6.
Could not find com.kgl:kgl-opengl-macosx64:0.1.6.

macos build is not available.

Hmm, bintray publishing seems to fail at random. Will have to further investigate this (Might be some race condition, not sure).
0.1.6-dev-4 published just fine, so that can be used as a work-around for now.

Nope =(

Could not find com.kgl:kgl-glfw-macosx64:0.1.6-dev-4
Could not find com.kgl:kgl-opengl-macosx64:0.1.6-dev-4

0.1.5 works fine though

The mac os target is called macosX64 and not macosx64. Did you specify this explicitly or did you just depend on common?

In the module file, it says,
....,
{
  "name": "linuxX64-api",
  "attributes": {
    "org.gradle.usage": "kotlin-api",
    "org.jetbrains.kotlin.native.target": "linux_x64",
    "org.jetbrains.kotlin.platform.type": "native"
  },
  "available-at": {
    "url": "../../kgl-opengl-linuxX64/0.1.6/kgl-opengl-linuxX64-0.1.6.module",
    "group": "com.kgl",
    "module": "kgl-opengl-linuxX64",
    "version": "0.1.6"
  }
},
{
  "name": "macosX64-api",
  "attributes": {
    "org.gradle.usage": "kotlin-api",
    "org.jetbrains.kotlin.native.target": "macos_x64",
    "org.jetbrains.kotlin.platform.type": "native"
  },
  "available-at": {
    "url": "../../kgl-opengl-macosx64/0.1.6/kgl-opengl-macosx64-0.1.6.module",
    "group": "com.kgl",
    "module": "kgl-opengl-macosx64",
    "version": "0.1.6"
  }
},
....

Only the macos ones have been lowercased.

Ok. I will continue with this project after short vacation. Currently can't check anything.

Experiencing same issue even with 'macosx64' instead of 'macosX64':

Could not find com.kgl:kgl-glfw-macosx64:0.1.6.
Searched in the following locations:
- https://repo.maven.apache.org/maven2/com/kgl/kgl-glfw-macosx64/0.1.6/kgl-glfw-macosx64-0.1.6.module
- https://repo.maven.apache.org/maven2/com/kgl/kgl-glfw-macosx64/0.1.6/kgl-glfw-macosx64-0.1.6.pom
- https://dl.bintray.com/dominaezzz/kotlin-native/com/kgl/kgl-glfw-macosx64/0.1.6/kgl-glfw-macosx64-0.1.6.module
- https://dl.bintray.com/dominaezzz/kotlin-native/com/kgl/kgl-glfw-macosx64/0.1.6/kgl-glfw-macosx64-0.1.6.pom
Required by:
project : > com.kgl:kgl-glfw:0.1.6
Could not find com.kgl:kgl-opengl-macosx64:0.1.6.
Searched in the following locations:
- https://repo.maven.apache.org/maven2/com/kgl/kgl-opengl-macosx64/0.1.6/kgl-opengl-macosx64-0.1.6.module
- https://repo.maven.apache.org/maven2/com/kgl/kgl-opengl-macosx64/0.1.6/kgl-opengl-macosx64-0.1.6.pom
- https://dl.bintray.com/dominaezzz/kotlin-native/com/kgl/kgl-opengl-macosx64/0.1.6/kgl-opengl-macosx64-0.1.6.module
- https://dl.bintray.com/dominaezzz/kotlin-native/com/kgl/kgl-opengl-macosx64/0.1.6/kgl-opengl-macosx64-0.1.6.pom
Required by:
project : > com.kgl:kgl-opengl:0.1.6

Could you please take a look once again?

Ha-ha! It works!
Thanks a lot!


Popover with third-party frames triggers DOMExceptions

🐛 Bug report
We have a website with third-party frames (cookiebot and google tag manager) and when using the Popover component from ark-ui we are getting the following warnings in the console:
DOMException: Blocked a frame with origin "http://localhost:3000" from accessing a cross-origin frame.
This is coming from zag-js/interact-outside which is setup as a utility for the popover component.
💥 Steps to reproduce
Hard to reproduce,
we traced the source code and it seems that the zag-js/interact-outside tries to attach event handlers to all window frames including the ones from cookiebot and google tag manager, and they reject the event handlers due to cross-origin policy.
💻 Link to reproduction
on request
🧐 Expected behavior
no console warnings/errors, no dom exceptions
🧭 Possible Solution
remove console warnings
🌍 System information

Software
Version(s)

Zag Version
0.19.1

Browser
Chrome

Operating System
MacOS

📝 Additional information

I just pushed a fix for this. We'll release an update shortly.
If the issue persists after upgrading, I'll re-open it.


Updated the supported versions of Django.

Removed support for 1.11, 2.0 and 2.1.
Added support for 3.1.

Codecov Report

Merging #223 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #223   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           16        16
  Lines          256       256
  Branches        30        30
=========================================
  Hits           256       256

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28e4f97...efacff0. Read the comment docs.


Problem with copyFileViaServerSideCopy.

I have forced to change SMB2ShareAccess.ALL to EnumSet.of(SMB2ShareAccess.FILE_SHARE_READ, SMB2ShareAccess.FILE_SHARE_DELETE) when opening the sourceFile because of impossibility to remove the sourceFile after copying which leads to STATUS_SHARING_VIOLATION (0xc0000043)
public void copyFileViaServerSideCopy(SmbFile destinationSmbFile) throws Buffer.BufferException, TransportException {
    try (
        File sourceFile = getDiskShare().openFile(getPath(), EnumSet.of(AccessMask.GENERIC_READ), null, SMB2ShareAccess.ALL, SMB2CreateDisposition.FILE_OPEN, null);
        File destinationFile = getDiskShare().openFile(destinationSmbFile.getPath(), EnumSet.of(AccessMask.GENERIC_ALL), null, SMB2ShareAccess.ALL, SMB2CreateDisposition.FILE_OVERWRITE_IF, null);
    ) {
        sourceFile.remoteCopyTo(destinationFile);
    }
}

Hey thanks for reporting a bug and a workaround. Can you provide more information according to the issue template:

Version of Java
Version of smbj and smbjwrapper
Version/type of your OS, e.g Linux x64 or Windows
Version/type of the share you are testing against, e.g Windows SMB share, Linux Samba share, Synology share etc.
Additional file permissions on the directories/files

The reason I ask: I tried to reproduce your problem with the following code (Which worked and deleted the source file):
public class SmbTest {

    public static void main(String[] arguments) throws Exception {
        AuthenticationContext authenticationContext = new AuthenticationContext("SNIPPED", "SNIPPED".toCharArray(), "");
        try (SmbConnection smbConnection = new SmbConnection("<IP_ADDRESS>", "Share", authenticationContext)) {
            // Copy the file
            SmbFile sourceFile = new SmbFile(smbConnection, "StreetPermit.pdf");
            SmbFile destinationFile = new SmbFile(smbConnection, "StreetPermitCopied.pdf");
            sourceFile.copyFileViaServerSideCopy(destinationFile);

            // Delete the source file
            sourceFile.deleteFile();
            System.out.println("Does source file exist: " + sourceFile.isExisting());
        }
    }
}

@isabsent Can you confirm that EnumSet.of(SMB2ShareAccess.FILE_SHARE_READ also works (No FILE_SHARE_DELETE)?


fix: declare all props. Fix #17

Codecov Report
Base: 97.34% // Head: 97.48% // Increases project coverage by +0.14% :tada:

Coverage data is based on head (5ff6b22) compared to base (9f3e758).
Patch coverage: 100.00% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #18      +/-   ##
==========================================
+ Coverage   97.34%   97.48%   +0.14%
==========================================
  Files          10       10
  Lines         188      199      +11
  Branches       24       24
==========================================
+ Hits          183      194      +11
  Misses          5        5

Impacted Files
Coverage Δ

src/lib/renderer/Children.svelte
100.00% <100.00%> (ø)

src/lib/renderer/Renderer.svelte
100.00% <100.00%> (ø)

src/lib/renderer/Text.svelte
100.00% <100.00%> (ø)

src/lib/renderer/html/Default.svelte
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Replace StartCom-issued certs with certs from a different CA

I don't think an implementation should have to trust StartCom's roots in order to pass the test, but I'm told that is currently the case today.

Newly-released TryTLS v0.3.7 contains pull request #300 that removed tlsfun.de tests.

Thanks!


Use IPFS gateway API

Gateway API docs: https://docs.ipfs.tech/concepts/ipfs-gateway/

8/12

working on some new tests before slamming submit on PR


enable delete of draft publication

Describe the improvement
When running through the "add single publication" workflow, the current status of the submission is saved as draft even if the user did not run through the complete workflow. At the end of the workflow, the user can also save as draft. When initiating a workflow multiple times, the same/similar draft is created with a new publication id. I want to be able to delete drafts that are e.g. redundant to other drafts on the "Publications overview" page.
Expected behavior
On the "Publications overview" page, I want to select the draft publications using the check boxes and perform an action on the selected publications through a "Delete" button on the top (next to publications, see screenshot) and/or bottom (next to the pagination of the "Publications overview" page. I should only be possible to delete drafts, not validated publications and only drafts that were registered by me.
Screenshots

position top button:

position bottom button:

A publication id is created in the database as soon as the "add publication" workflow is initiated. Currently, deleting records from the database is not straightforward. Revisit this issue when the database will be reimplemented.


Activities mapping for PSC connection

PSC authentication token should come with a list of activities
This ticket to see how we could add information about this activities in the MX display name to avoid mistaking homonyms.

Can be done in the module created #343


How does OAuth1 fit into Ember-Simple-Auth? (or does it?)

I'm working with a number of different approaches to sort out how to "authorize" a session using an external login form.
To obtain the required oauth variables and external urls (access, authorize, request), I built a custom session that

checks the existing session data
if needed, makes a series of ajax requests to sign and obtain temporary request tokens
stores this authentication data in an authentication key under session.data

I'd like to call the session.authorize method to follow patterns, but it would need to open a new window (or redirect the current window) to an authentication url (compiled in the steps above). After external sign-in then has a redirect back with an oauth_verifier in a query string.  For this reason, a session isn't truly "authorized" unless that verifier exists either in the session store, or in the querystring when loaded.
However it's expected that an authorizer returns proper credentials from the authorize() promise.
So as best practice, should I trigger the authorize method to launch the external login, and then automatically re-trigger authorize when the session is restored (thus storing the credentials in the "authorized" key)?

The best solution for supporting OAuth 1.0a providers is using torii via the Torii authenticator.

Closing as this is supported by Torii and can be integrated in ESA via the Torii authenticator as mentioned above.

👍


Model Builder Error

System Information (please complete the following information):

Model Builder Version: 16.0.2003.302
Visual Studio Version: Microsoft Visual Studio Community 2019
Version 16.3.8

Describe the bug
at Microsoft.ML.ModelBuilder.AutoMLService.Experiments.AutoMLExperiment`3.d__23.MoveNext() in E:\A_work\1326\s\Microsoft.ML.ModelBuilder.AutoMLService\Experiments\AutoMLExperiment.cs:line 103
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Microsoft.ML.ModelBuilder.AutoMLEngine.d__28.MoveNext() in E:\A_work\1326\s\Microsoft.ML.ModelBuilder.AutoMLService\AutoMLEngineService\AutoMLEngine.cs:line 134
To Reproduce
Steps to reproduce the behavior:

Create a New Proyect
Add ML
Go ahead until Traing when it finish launch the error
See error

Hello,
Thanks for reporting this issue.  In order to help, I need more information.
Can you share the following details:

What scenario type did you run?
Can you share the dataset or information about it?

Cheers,
Jake

Resolving this due to lack of details/response. Please provide more details and re-open!
@jmorfeu Sorry you're hitting this issue! We'd love to help but need more information.


Support zstd compression in RocksDB

RocksDB supports zstd compression for greatly improved compression ratios. It would be great if this option were exposed in ArangoDB.

at the time being the ZST library doesn't have cmake files, which makes integrating it into the arangodb build a bit more work.
It's also questionable how it will work on existing installations, and how to configure it. We will look into it, but it will most probably not be part of arangodb 3.7.
If you like to speed up things, introduce CMake files to the library, for RocksDB they also accepted 3rd party contributions without big hassle.

I believe they have cmake files now
https://github.com/facebook/zstd/tree/dev/build/cmake


"Global" keyboard listening

Reading through https://github.com/microsoft/react-native-macos/issues/966 and https://github.com/microsoft/react-native-macos/issues/823

It seemed that the recommended way to get global keyboard listeners was using onKeyDown on a top-level View
This seems not to work however I found:
onKeyPress={(e)=> {
        console.log(e.nativeEvent.key)
    }}

Works just fine (even though the type of View doesn't specify it ... however it only works after I e.g. click a specific TextInput (even if I move it out of focus later).
Is there an updated workaround to getting global keyboard listening to work (thus allowing things like hotkeys/shortcuts) ?

onKeyPress is a TextInput only prop / event which I suppose bubbled up without us realizing.. I wouldn't rely on that. We inherit that prop from React Native on mobile, and it doesn't really fit into the desktop keyboard API.
For global keyboard listening, since React Native is mostly only Root view and down, I think you still have to rely on implementing that natively with something like https://github.com/sindresorhus/KeyboardShortcuts unfortunately.


WIP of converting examples to Webpack v2

This change is

@alexfedoseev Can you take a look at my conversions of the webpack configs in /spec/dummy/client.

Still some issues:

Tests fail with no JS being run due to a syntax error. See below. cd spec/dummy && rspec.
Hot reloading is broken with this error below. foreman start -f Procfile.hot

Phantomjs issue

➜  ~/shakacode/react-on-rails/react_on_rails/spec/dummy (update-to-webpack-v2 u=) ✗ rspec './spec/features/integration_spec.rb[1:1:1:1]'                                                                                ✹ [21:00:16]
Capybara using driver: poltergeist
Run options: include {:ids=>{"./spec/features/integration_spec.rb"=>["1:1:1:1"]}}
Pages/Index
All in one page
Server Rendered/Cached React/Redux Component
====> React On Rails: Checking app/assets/webpack for outdated/missing bundles
[SERVER] RENDERED RenderedHtml to dom node with id: HelloWorld-react-component-4 with railsContext: {"inMailer":false,"i18nLocale":"en","i18nDefaultLocale":"en","href":"http://<IP_ADDRESS>:59126/","location":"/","scheme":"http","host":"<IP_ADDRESS>","port":59126,"pathname":"/","search":null,"httpAcceptLanguage":"en-US,*","somethingUseful":"REALLY USEFUL","serverSide":true}
TURBO: USING TURBOLINKS 2: document added event listeners page:before-unload and page:change.
TURBO: reactOnRailsPageLoaded
RENDERED ReduxApp to dom node with id: ReduxApp-react-component-0 with props, railsContext: [object Object] [object Object]
example at ./spec/features/integration_spec.rb:15 (FAILED - 1)
HTML screenshot: file:///Users/justin/shakacode/react-on-rails/react_on_rails/spec/dummy/tmp/capybara/screenshot_2017-03-01-21-00-44.888.html
Image screenshot: file:///Users/justin/shakacode/react-on-rails/react_on_rails/spec/dummy/tmp/capybara/screenshot_2017-03-01-21-00-44.888.png
Failures:

Pages/Index All in one page Server Rendered/Cached React/Redux Component
Failure/Error: visit root_path
Capybara::Poltergeist::JavascriptError:
One or more errors were raised in the Javascript code on the page. If you don't care about these errors, you can ignore them by setting js_errors: false in your Poltergeist configuration (see documentation for details).
TypeError: ReactOnRails encountered an error while rendering component: ReduxApp.
Original message: undefined is not a constructor (evaluating 'Object.assign({}, props, { railsContext: railsContext })')
TypeError: ReactOnRails encountered an error while rendering component: ReduxApp.
Original message: undefined is not a constructor (evaluating 'Object.assign({}, props, { railsContext: railsContext })')
at undefined:10 in default
at :41 in default
at :45 in createReactElement
at :133 in render
at :66 in forEach
at :71 in forEachComponent
at :167 in reactOnRailsPageLoaded
at :0 in dispatchEvent
at http://<IP_ADDRESS>:59126/assets/application_static-b5e9b7937a49f12d63506a83dcc03e6b8a0f635b24e2cc91ed1234c6688e6fb7.js:4572 in triggerEvent
at http://<IP_ADDRESS>:59126/assets/application_static-b5e9b7937a49f12d63506a83dcc03e6b8a0f635b24e2cc91ed1234c6688e6fb7.js:4941
Shared Example Group: "React Component" called from ./spec/features/integration_spec.rb:31
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/poltergeist-1.12.0/lib/capybara/poltergeist/browser.rb:376:in `command'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/poltergeist-1.12.0/lib/capybara/poltergeist/browser.rb:35:in `visit'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/poltergeist-1.12.0/lib/capybara/poltergeist/driver.rb:97:in `visit'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/capybara-2.7.1/lib/capybara/session.rb:233:in `visit'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/capybara-2.7.1/lib/capybara/dsl.rb:52:in `block (2 levels) in module:DSL'
./spec/features/integration_spec.rb:27:in `block (3 levels) in <top (required)>'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/rspec-retry-0.5.2/lib/rspec/retry.rb:112:in `block in run'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/rspec-retry-0.5.2/lib/rspec/retry.rb:101:in `loop'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/rspec-retry-0.5.2/lib/rspec/retry.rb:101:in `run'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/rspec-retry-0.5.2/lib/rspec_ext/rspec_ext.rb:12:in `run_with_retry'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/rspec-retry-0.5.2/lib/rspec/retry.rb:30:in `block (2 levels) in setup'

Finished in 8.31 seconds (files took 10.52 seconds to load)
1 example, 1 failure
Failed examples:
rspec './spec/features/integration_spec.rb[1:1:1:1]' # Pages/Index All in one page Server Rendered/Cached React/Redux Component

Hot Reload Issue

➜  ~/shakacode/react-on-rails/react_on_rails/spec/dummy (update-to-webpack-v2 u=) foreman start -f Procfile.hot                                                                                [21:06:20]
21:06:30 rails.1               | started with pid 7264
21:06:30 hot-assets.1          | started with pid 7265
21:06:30 rails-server-assets.1 | started with pid 7266
21:06:30 hot-assets.1          | yarn run v0.20.3
21:06:30 rails-server-assets.1 | yarn run v0.20.3
21:06:31 rails-server-assets.1 | $ (cd client && yarn run build:dev:server --silent)
21:06:31 hot-assets.1          | $ (cd client && yarn run hot-assets)
21:06:32 hot-assets.1          | yarn run v0.20.3
21:06:32 rails-server-assets.1 | yarn run v0.20.3
21:06:32 hot-assets.1          | $ babel-node server-rails-hot.js
21:06:32 rails-server-assets.1 | $ webpack -w --config webpack.server.rails.build.config.js
21:06:33 rails-server-assets.1 |
21:06:33 rails-server-assets.1 | Webpack is watching the files…
21:06:33 rails-server-assets.1 |
21:06:35 rails.1               | => Booting Puma
21:06:35 rails.1               | => Rails 4.2.8 application starting in development on http://<IP_ADDRESS>:3000
21:06:35 rails.1               | => Run `rails server -h` for more startup options
21:06:35 rails.1               | => Ctrl-C to shutdown server
21:06:35 rails.1               | ================================================================================
21:06:35 rails.1               | Using caching = false
21:06:35 rails.1               | ================================================================================
21:06:36 hot-assets.1          | /Users/justin/shakacode/react-on-rails/react_on_rails/spec/dummy/client/webpack.client.rails.hot.config.js:24
21:06:36 hot-assets.1          | config.module.loaders.push({
21:06:36 hot-assets.1          |                      ^
21:06:36 hot-assets.1          |
21:06:36 hot-assets.1          | TypeError: Cannot read property 'push' of undefined
21:06:36 hot-assets.1          |     at Object. (/Users/justin/shakacode/react-on-rails/react_on_rails/spec/dummy/client/webpack.client.rails.hot.config.js:25:1)
21:06:36 hot-assets.1          |     at Module._compile (module.js:571:32)
21:06:36 hot-assets.1          |     at loader (/Users/justin/shakacode/react-on-rails/react_on_rails/spec/dummy/client/node_modules/babel-register/lib/node.js:144:5)
21:06:36 hot-assets.1          |     at Object.require.extensions.(anonymous function) [as .js] (/Users/justin/shakacode/react-on-rails/react_on_rails/spec/dummy/client/node_modules/babel-register/lib/node.js:154:7)
21:06:36 hot-assets.1          |     at Module.load (module.js:488:32)
21:06:36 hot-assets.1          |     at tryModuleLoad (module.js:447:12)
21:06:36 hot-assets.1          |     at Function.Module._load (module.js:439:3)
21:06:36 hot-assets.1          |     at Module.require (module.js:498:17)
21:06:36 hot-assets.1          |     at require (internal/module.js:20:19)
21:06:36 hot-assets.1          |     at Object. (/Users/justin/shakacode/react-on-rails/react_on_rails/spec/dummy/client/server-rails-hot.js:20:1)
21:06:36 hot-assets.1          | error Command failed with exit code 1.
21:06:36 hot-assets.1          | info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
21:06:37 hot-assets.1          | error Command failed with exit code 1.
21:06:37 hot-assets.1          | info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
21:06:37 hot-assets.1          | exited with code 1
21:06:37 system                | sending SIGTERM to all processes
21:06:37 rails.1               | Exiting
21:06:37 rails-server-assets.1 | terminated by SIGTERM
21:06:37 rails.1               | terminated by SIGTERM

Might be related: https://github.com/shakacode/react-webpack-rails-tutorial/issues/361

config.module.rules.push

Took out lots of errors!
Still got 6 left.
Please help!

Failures:

Pages/Index All in one page Server Rendered/Cached React Component Without Redux changes name in message according to input
Failure/Error: visit root_path
Capybara::Poltergeist::DeadClient:
PhantomJS client died while processing {"id":"a32319b9-08a8-46b9-8132-88848047fb57","name":"visit","args":["http://<IP_ADDRESS>:61221/",30]}
Shared Example Group: "React Component" called from ./spec/features/integration_spec.rb:35
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/poltergeist-1.12.0/lib/capybara/poltergeist/server.rb:38:in `send'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/poltergeist-1.12.0/lib/capybara/poltergeist/browser.rb:369:in `command'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/poltergeist-1.12.0/lib/capybara/poltergeist/browser.rb:35:in `visit'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/poltergeist-1.12.0/lib/capybara/poltergeist/driver.rb:97:in `visit'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/capybara-2.7.1/lib/capybara/session.rb:233:in `visit'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/capybara-2.7.1/lib/capybara/dsl.rb:52:in `block (2 levels) in module:DSL'
./spec/features/integration_spec.rb:27:in `block (3 levels) in <top (required)>'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/rspec-retry-0.5.2/lib/rspec/retry.rb:112:in `block in run'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/rspec-retry-0.5.2/lib/rspec/retry.rb:101:in `loop'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/rspec-retry-0.5.2/lib/rspec/retry.rb:101:in `run'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/rspec-retry-0.5.2/lib/rspec_ext/rspec_ext.rb:12:in `run_with_retry'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/rspec-retry-0.5.2/lib/rspec/retry.rb:30:in `block (2 levels) in setup'

Pages/Index All in one page Simple Client Rendered Component same component with different props changes name in message according to input
Failure/Error: visit root_path
Capybara::Poltergeist::DeadClient:
PhantomJS client died while processing {"id":"3e03875f-515c-449e-a617-0ba5090b2da5","name":"visit","args":["http://<IP_ADDRESS>:61221/",30]}
Shared Example Group: "React Component" called from ./spec/features/integration_spec.rb:42
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/poltergeist-1.12.0/lib/capybara/poltergeist/server.rb:38:in `send'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/poltergeist-1.12.0/lib/capybara/poltergeist/browser.rb:369:in `command'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/poltergeist-1.12.0/lib/capybara/poltergeist/browser.rb:35:in `visit'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/poltergeist-1.12.0/lib/capybara/poltergeist/driver.rb:97:in `visit'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/capybara-2.7.1/lib/capybara/session.rb:233:in `visit'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/capybara-2.7.1/lib/capybara/dsl.rb:52:in `block (2 levels) in module:DSL'
./spec/features/integration_spec.rb:27:in `block (3 levels) in <top (required)>'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/rspec-retry-0.5.2/lib/rspec/retry.rb:112:in `block in run'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/rspec-retry-0.5.2/lib/rspec/retry.rb:101:in `loop'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/rspec-retry-0.5.2/lib/rspec/retry.rb:101:in `run'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/rspec-retry-0.5.2/lib/rspec_ext/rspec_ext.rb:12:in `run_with_retry'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/rspec-retry-0.5.2/lib/rspec/retry.rb:30:in `block (2 levels) in setup'

Pages/Index All in one page Simple Component Without Redux changes name in message according to input
Failure/Error: visit root_path
Capybara::Poltergeist::DeadClient:
PhantomJS client died while processing {"id":"4651210f-e394-4916-b262-a044b8c436d1","name":"visit","args":["http://<IP_ADDRESS>:61221/",30]}
Shared Example Group: "React Component" called from ./spec/features/integration_spec.rb:48
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/poltergeist-1.12.0/lib/capybara/poltergeist/server.rb:38:in `send'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/poltergeist-1.12.0/lib/capybara/poltergeist/browser.rb:369:in `command'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/poltergeist-1.12.0/lib/capybara/poltergeist/browser.rb:35:in `visit'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/poltergeist-1.12.0/lib/capybara/poltergeist/driver.rb:97:in `visit'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/capybara-2.7.1/lib/capybara/session.rb:233:in `visit'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/capybara-2.7.1/lib/capybara/dsl.rb:52:in `block (2 levels) in module:DSL'
./spec/features/integration_spec.rb:27:in `block (3 levels) in <top (required)>'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/rspec-retry-0.5.2/lib/rspec/retry.rb:112:in `block in run'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/rspec-retry-0.5.2/lib/rspec/retry.rb:101:in `loop'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/rspec-retry-0.5.2/lib/rspec/retry.rb:101:in `run'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/rspec-retry-0.5.2/lib/rspec_ext/rspec_ext.rb:12:in `run_with_retry'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/rspec-retry-0.5.2/lib/rspec/retry.rb:30:in `block (2 levels) in setup'

Code Splitting w/ Server Rendering loading an asyncronous route should not cause a client/server checksum mismatch
Failure/Error: background { visit "/deferred_render_with_server_rendering/async_page" }
Capybara::Poltergeist::DeadClient:
PhantomJS client died while processing {"id":"d6b357b7-74ab-4b20-b144-390a97c1ccf7","name":"visit","args":["http://<IP_ADDRESS>:61221/deferred_render_with_server_rendering/async_page",30]}
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/poltergeist-1.12.0/lib/capybara/poltergeist/server.rb:38:in `send'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/poltergeist-1.12.0/lib/capybara/poltergeist/browser.rb:369:in `command'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/poltergeist-1.12.0/lib/capybara/poltergeist/browser.rb:35:in `visit'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/poltergeist-1.12.0/lib/capybara/poltergeist/driver.rb:97:in `visit'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/capybara-2.7.1/lib/capybara/session.rb:233:in `visit'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/capybara-2.7.1/lib/capybara/dsl.rb:52:in `block (2 levels) in module:DSL'
./spec/features/integration_spec.rb:172:in `block (2 levels) in <top (required)>'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/rspec-retry-0.5.2/lib/rspec/retry.rb:112:in `block in run'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/rspec-retry-0.5.2/lib/rspec/retry.rb:101:in `loop'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/rspec-retry-0.5.2/lib/rspec/retry.rb:101:in `run'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/rspec-retry-0.5.2/lib/rspec_ext/rspec_ext.rb:12:in `run_with_retry'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/rspec-retry-0.5.2/lib/rspec/retry.rb:30:in `block (2 levels) in setup'

2 react components, 1 store, server side, controller setup /server_side_hello_world_shared_store_controller Type in one component changes the other component
Failure/Error: find("input").set new_text2
Capybara::Poltergeist::DeadClient:
PhantomJS client died while processing {"id":"2075109b-1a9f-404d-8e39-ad9f49694d32","name":"set","args":[1,5,"Jane Smith"]}
Shared Example Group: "React Component Shared Store" called from ./spec/features/integration_spec.rb:230
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/poltergeist-1.12.0/lib/capybara/poltergeist/server.rb:38:in `send'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/poltergeist-1.12.0/lib/capybara/poltergeist/browser.rb:369:in `command'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/poltergeist-1.12.0/lib/capybara/poltergeist/browser.rb:100:in `set'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/poltergeist-1.12.0/lib/capybara/poltergeist/node.rb:17:in `command'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/poltergeist-1.12.0/lib/capybara/poltergeist/node.rb:91:in `set'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/capybara-2.7.1/lib/capybara/node/element.rb:108:in `block in set'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/capybara-2.7.1/lib/capybara/node/base.rb:85:in `synchronize'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/capybara-2.7.1/lib/capybara/node/element.rb:104:in `set'
./spec/features/integration_spec.rb:206:in `block (4 levels) in <top (required)>'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/capybara-2.7.1/lib/capybara/session.rb:291:in `within'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/capybara-2.7.1/lib/capybara/dsl.rb:52:in `block (2 levels) in module:DSL'
./spec/features/integration_spec.rb:202:in `block (3 levels) in <top (required)>'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/rspec-retry-0.5.2/lib/rspec/retry.rb:112:in `block in run'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/rspec-retry-0.5.2/lib/rspec/retry.rb:101:in `loop'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/rspec-retry-0.5.2/lib/rspec/retry.rb:101:in `run'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/rspec-retry-0.5.2/lib/rspec_ext/rspec_ext.rb:12:in `run_with_retry'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/rspec-retry-0.5.2/lib/rspec/retry.rb:30:in `block (2 levels) in setup'

2 react components, 1 store, server side, defer /server_side_hello_world_shared_store_defer Type in one component changes the other component
Failure/Error: background { visit url }
Capybara::Poltergeist::DeadClient:
PhantomJS client died while processing {"id":"8bf1fd99-3813-4654-9913-e86630a9fab9","name":"visit","args":["http://<IP_ADDRESS>:61221/server_side_hello_world_shared_store_defer",30]}
Shared Example Group: "React Component Shared Store" called from ./spec/features/integration_spec.rb:238
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/poltergeist-1.12.0/lib/capybara/poltergeist/server.rb:38:in `send'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/poltergeist-1.12.0/lib/capybara/poltergeist/browser.rb:369:in `command'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/poltergeist-1.12.0/lib/capybara/poltergeist/browser.rb:35:in `visit'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/poltergeist-1.12.0/lib/capybara/poltergeist/driver.rb:97:in `visit'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/capybara-2.7.1/lib/capybara/session.rb:233:in `visit'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/capybara-2.7.1/lib/capybara/dsl.rb:52:in `block (2 levels) in module:DSL'
./spec/features/integration_spec.rb:190:in `block (2 levels) in <top (required)>'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/rspec-retry-0.5.2/lib/rspec/retry.rb:112:in `block in run'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/rspec-retry-0.5.2/lib/rspec/retry.rb:101:in `loop'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/rspec-retry-0.5.2/lib/rspec/retry.rb:101:in `run'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/rspec-retry-0.5.2/lib/rspec_ext/rspec_ext.rb:12:in `run_with_retry'
/Users/justin/.rvm/gems/ruby-2.3.1@react_on_rails/gems/rspec-retry-0.5.2/lib/rspec/retry.rb:30:in `block (2 levels) in setup'

Finished in 35.01 seconds (files took 5.03 seconds to load)
75 examples, 6 failures
Failed examples:
rspec './spec/features/integration_spec.rb[1:1:2:2]' # Pages/Index All in one page Server Rendered/Cached React Component Without Redux changes name in message according to input
rspec './spec/features/integration_spec.rb[1:1:3:3:2]' # Pages/Index All in one page Simple Client Rendered Component same component with different props changes name in message according to input
rspec './spec/features/integration_spec.rb[1:1:4:4]' # Pages/Index All in one page Simple Component Without Redux changes name in message according to input
rspec ./spec/features/integration_spec.rb:173 # Code Splitting w/ Server Rendering loading an asyncronous route should not cause a client/server checksum mismatch
rspec './spec/features/integration_spec.rb[16:1:1]' # 2 react components, 1 store, server side, controller setup /server_side_hello_world_shared_store_controller Type in one component changes the other component
rspec './spec/features/integration_spec.rb[18:1:1]' # 2 react components, 1 store, server side, defer /server_side_hello_world_shared_store_defer Type in one component changes the other component

Can anybody tell me why travis is failing? https://travis-ci.org/shakacode/react_on_rails https://travis-ci.org/shakacode/react_on_rails/builds/208035037
but codeship is passing: https://app.codeship.com/projects/187011/builds/23158421

@robwise can you scan  these changes. I'd like to merge soon!

Coverage remained the same at 99.334% when pulling c8848f34cb0303d1d5efe56d8683e32ae154cd2f on update-to-webpack-v2 into 8b13c3beabf1e266c506e840b012b3f00bf417ea on master.

Coverage remained the same at 99.334% when pulling c8848f34cb0303d1d5efe56d8683e32ae154cd2f on update-to-webpack-v2 into 8b13c3beabf1e266c506e840b012b3f00bf417ea on master.

Coverage remained the same at 99.334% when pulling c8848f34cb0303d1d5efe56d8683e32ae154cd2f on update-to-webpack-v2 into 8b13c3beabf1e266c506e840b012b3f00bf417ea on master.

Coverage remained the same at 99.334% when pulling 1ee7df97825674d2594b7ddeb3ab3b77cf4f2619 on update-to-webpack-v2 into 8b13c3beabf1e266c506e840b012b3f00bf417ea on master.

Coverage remained the same at 99.334% when pulling 1ee7df97825674d2594b7ddeb3ab3b77cf4f2619 on update-to-webpack-v2 into 8b13c3beabf1e266c506e840b012b3f00bf417ea on master.


Attach VGA interface

To boot most images (most Linux distros, Windows...) it is needed to attach a VGA on boot.
Consider to render VGA output to serial port, or simply output serial port to stdout, if the guest vm has been configured to do so.

Hi @methadata,
I played around and removed some options (serial, nographic, ...) and get a boot process which ends with "1024 x 768 Graphic mode"
So VGA / serial settings could be the problem.

It seems to boot, but still can't access the VM by exposed ports or container ip (#5).
VGA problem seems to be fixed because container RAM usage increases from ~0 to 725MB. So VM should boot and running now...

Thanks for report @ahoeg
We have noticed that the upgrade to Alpine crashed the network connectivity. We have reverted the changes, and until we make further investigation, we will keep Centos as base image.
Once we test and solve the connectivity issue with Alpine, we will merge it to master. Until the, we will keep the "alpine" branch.


Tilemap scroll

Related to #630
Added shift+click functionality:
Allows the user to continue editing the selection rectangle in the tile palette after un-clicking. This lets the user modify the selection rectangle at will, without the need to constantly select an 'anchor point' if they want to add a row or column.
Added middle mouse scrolling:
Pressing the middle mouse button now allows the user to dynamically pan around the tile palette window.
These two additional functionalities are atomic. One cannot occur while the other is occurring and vice versa. (this also applies to just left clicking and attempting to scroll)

In addition to updating the shift + click to no longer need to move, also fixed a bug that prevented the user from 'clearing' the selection rectangle via a right click.
It should be noted that the shift + click functionality ALWAYS uses the last 'left click' anchor point, even if no rectangle is present. e.g.

select a rectangle normally
right click to clear the selection rectangle
shift + click on a different spot, note that a new selection anchor point is not generated, it uses the one generated on step 1.

I don't know if this qualifies as a bug or something where either behavior would be acceptable, but I would certainly be happy to hear input.

This has been fixed. I realized shift+click prior to ANY selection rectangle used (0,0) as the anchor, which I felt wasn't appropriate.

Thanks for the PR! I'll leave this open for community review and will join in shortly.

I did notice another minor bug w/ the selection rectangle in the tile palette. When resizing, if tiles within the selection are moved, the rectangle does not reset. It appears to use the first item in the next row as whatever it is pasting for the 'blank' rectangles.
This occurs in the master branch, so I don't think it's an issue introduced by me. I'll file an issue when I get a chance to record footage.

@mfep Thanks for reviewing! Sounds like we'll be ready for merge.
I'll have a brief second look, hopefully soon, so we can wrap this up.

This occurs in the master branch, so I don't think it's an issue introduced by me. I'll file an issue when I get a chance to record footage.

👍

Merged as per review by @mfep. Thanks everyone! 🙂


Remove border in point

How can I remove the border from a point?
At this moment I am changing the opacity of the point according to the click of a button, that's fine.
But when the point has opacity 0 you can see the edge of it and that is something I want to eliminate and I still can't find how ...
Do you have any idea ?

Do you find out how to remove this black line yet?

You can change the point shader.  Just set the border color to the same color as the point.

Hi @alex-oko @vutle , I've created a pull request with circle and square borderless shaders. See here: https://github.com/robertleeplummerjr/Leaflet.glify/pull/127 for dotBorderless.glsl and squareBorderless.glsl

Hi @alex-oko @vutle , I created a pull request with circle and square borderless shaders. See here: #127 for dotBorderless.glsl and squareBorderless.glsl
But it's not in the published version.Can you release this version of the dependency？I really need it, too

@alex-oko you can use this option: fragmentShaderSource : L.glify.shader.fragment.simpleCircle


Upgrade selfsigned library from v1.10.7 to v2.0.0

Pull Request Test Coverage Report for Build 6003

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.01%) to 87.808%

Totals

Change from base Build 5994:
0.01%

Covered Lines:
9759

Relevant Lines:
10721

💛  - Coveralls


Aprocter/attribute maps

Collaborator:
Review for this pull request was created. Link to review

I didn't open this PR.


Fix querying PyPI metadata for multiple fields

This fixes printing multiple fields separated by comma.

See https://github.com/myint/yolk for a maintained fork of this project.

Thanks for pointing this out. Hovewer, this patch is tiny and evident. I would still merge this.

Well, look at the age of other simple yet open PRs…


No correct error messages when uploading a release

Description:
When uploading a release with a non-existent channel, only an i18n string is returned instead of a meaningful message.
Steps to reproduce:

Use hangar publish plugin
set channel to something that makes no sense
try to release

Expected behaviour:

a message saying that the channel is not available

Repo+Commit: https://github.com/OneLiteFeatherNET/CoinCoffer/blob/22ba84bea7402230b660bcf75939aad32e033d3e/coincoffer-patches/build.gradle.kts.patch#L70
Images:

meh, idk what we would do here. the backend returns those by design, the frontend does the translation. maybe when we fixed crowdin we can download the english file into the gradle plugin or something, but like, the error is understandable, your channel has no color

The actual error was that I had capitalised it instead of lower case. But I got the error message for colour.

well, "yes". you entered a channel that didnt exist, it tried to create a new channel, that failed because no color.

Wouldn't it make more sense from my point of view to say that the channel must exist instead of displaying the colour error message?

well, creating a new channel on upload is a feature.

Then I would rather ask, is it also possible to specify the colour in the plugin if it is a feature?


Add more device classes to homekit

Home Assistant release with the issue:
0.82.1
Last working Home Assistant release (if known):
None
Operating environment (Hass.io/Docker/Windows/etc.):
Hassio on a raspberry pi 3 B+
Component/platform:
Homekit
Description of problem:
There is a list of supported device classes here:
https://www.home-assistant.io/components/homekit/#supported-components
Would it be possible to add the following items under AirQualitySensor.

particulate_matter
particulate_matter_2.5
particulate_matter_10
volatile_organic_compounds

And the following under CarbonDioxideSensor.

carbon_dioxide

They will be used for the Awair component:
https://github.com/danielsjf/awair_component

Discussion of additional device classes should take place in the architecture repo: https://github.com/home-assistant/architecture/issues
Please open an issue there 👍


lib/systems: add aarch64-windows

Description of changes
Building compiler-rt for aarch64-windows is possible and yield a working LLVM cross-compiler to aarch64-windows.
You
Tested via:
NIXPKGS_ALLOW_UNSUPPORTED_SYSTEM=1 nix-build -E '(import <nixpkgs> { crossSystem = { config = "aarch64-windows"; libc = null; rustc.config = "aarch64-unknown-uefi"; useLLVM = true; }; }).lanzaboote-stub'

(works with any proper UEFI package that you have at your disposal in your tree, note: I said proper UEFI package, not systemd-boot ELF hackery or GNU-EFI.)
and then, you can run the UEFI result using QEMU and AArch64 UEFI binaries.
Some questions remains if this is viable approach on actual hardware.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

This is for building UEFI binaries, right?  Just checking.

Building compiler-rt for aarch64-windows is possible and yield a working LLVM cross-compiler to aarch64-windows.

Won't LLVM accept `aarch64-unknown-uefi"?

This is for building UEFI binaries, right?  Just checking.

Building compiler-rt for aarch64-windows is possible and yield a working LLVM cross-compiler to aarch64-windows.

Won't LLVM accept aarch64-unknown-uefi?

It will, it just doesn't for now. This is a draft because no real intention to go somewhere with this, we can close.


Add to unpacked.cern.ch

Following https://awesome-workshop.github.io/docker-singularity-hats/12-unpacked/index.html
looks like we just have to make a PR to https://gitlab.cern.ch/unpacked/sync to add these images there, which would allow singularity to use these containers directly from cvmfs

Oh, seems nice!!! Why not?

I made a PR https://gitlab.cern.ch/unpacked/sync/-/merge_requests/70

I made a PR https://gitlab.cern.ch/unpacked/sync/-/merge_requests/70

(and Jakob merged it, coool!)

(and Jakob merged it, coool!)

Works for me: singularity shell -B ${PWD}:/work /cvmfs/unpacked.cern.ch/registry.hub.docker.com/coffeateam/coffea-dask:latest
I'd call this closed, though we might want to go back and add all version at some point, instead of just latest.

Works for me: singularity shell -B ${PWD}:/work /cvmfs/unpacked.cern.ch/registry.hub.docker.com/coffeateam/coffea-dask:latest
I'd call this closed, though we might want to go back and add all version at some point, instead of just latest.


Unable to find messages file 'cscui.dll'

Hello,
I am pretty stucked on this compilation problem. I suspect its a problem on the image.
Since i am rebuilding the images, these compilation errors appear.
An error has occurred during compilation. error CS2018: Unable to find messages file 'cscui.dll'
Using latest mcr.microsoft.com/dotnet/framework/sdk:4.8-windowsservercore-ltsc2016
Details:
C:\BuildAgent\work\c560d714056a40bc\packages\Microsoft.CodeDom.Providers.DotNetCompilerPlatform.2.0.1\build\net46\Microsoft.CodeDom.Providers.DotNetCompilerPlatform.props(39, 5): The source file for this compilation can be found at: "C:\BuildAgent\temp\buildTmp\6c1d50b2-d3a1-48eb-9e4e-7833b25b44d9.txt"
C:\BuildAgent\work\c560d714056a40bc\packages\Microsoft.CodeDom.Providers.DotNetCompilerPlatform.2.0.1\build\net46\Microsoft.CodeDom.Providers.DotNetCompilerPlatform.props(39, 5): error MSB3758: An error has occurred during compilation. error CS2018: Unable to find messages file 'cscui.dll'
C:\BuildAgent\work\c560d714056a40bc\packages\Microsoft.CodeDom.Providers.DotNetCompilerPlatform.2.0.1\build\net46\Microsoft.CodeDom.Providers.DotNetCompilerPlatform.props(39, 5): error MSB4175: The task factory "CodeTaskFactory" could not be loaded from the assembly "C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\MSBuild\15.0\bin\Microsoft.Build.Tasks.Core.dll". The task factory must return a value for the "TaskType" property.
The path exists in the container
/Windows/Microsoft.NET/Framework/v4.0.30319/1033/cscui.dll
I don't think the file is corrupt. Because I replaced it after a couple of tests with a working version.
I suspect a problem with the image, but I am not sure.

Greetings Rene

@spriet2000 - Can you please provide a set of steps to reproduce this?

That would be quite hard without sending my code, but I will try by making some custom code.

I playing around with this.
In a container which fails:
The cscui.dll exists in msbuild folder.
But it doesnt exist in windows/system32 folder
In a container which works:
The cscui.dll exists in msbuild folder.
The cscui.dll exists in windows/system32 folder
Copying a cscui.dll from system to the container system32 introduces a new error
Cannot resolve dependency to assembly 'Microsoft.Build.Utilities.Core, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' because it has not been preloaded. When using the ReflectionOnly APIs, dependent assemblies must be pre-loaded or loaded on demand through the ReflectionOnlyAssemblyResolve event.
Probably because its searching for other dependencies.
For now my theory is this cscui.dll is removed from windows image, but the Microsoft.Build.Utilities.Core still depends on it.
When compilation I suspect the error is triggered by [Serializable] attribute.
I have to verify all this. But it sounds logical. Not sure if/how system32/cscui.dll is related to Microsoft.Build.Utilities.Core.

@spriet2000 - Can you clarify which container you are using in which it works?

Closing since a clear set of repro steps are not specified.  Feel free to re-open if you can provide a set of steps to reproduce the issue.


Adapt generated tmux config to new tmux 2.9 syntax

Closes #102
Closes #100
Inspired by @secuvim in #102
I do not know if this is all that is needed, but it worked for me.

This would break the backwards compatibility for users with tmux versions < 1.9.
To keep the backwards compatibility you could wrap your changes in something like:
let tmux_version = system("tmux -V")
    if (tmux_version < 'tmux 1.9')
        let misc_options = ...
        let win_options = ...
    else
        let misc_options = ...
        let win_options = ...
    elseif

This is just a suggestion as I am not the maintainer of this package.
@He-Ro Thanks for implementing a fix.
@edkolev What is your opinion on this?

Some of the presets appear to write into win_options['window-status-activity-attr'] which causes problems if you're using one of those presets:

https://github.com/edkolev/tmuxline.vim/blob/c8a0295eb34bf11447779a5a203fd472147788a7/autoload/tmuxline/presets/powerline.vim#L26
https://github.com/edkolev/tmuxline.vim/blob/c8a0295eb34bf11447779a5a203fd472147788a7/autoload/tmuxline/presets/nightly_fox.vim#L15
https://github.com/edkolev/tmuxline.vim/blob/c8a0295eb34bf11447779a5a203fd472147788a7/autoload/tmuxline/presets/crosshair.vim#L23

@He-Ro amazing work on this, thanks! Could you also:

git grep and change everywhere window-status-activity-attr => window-status-activity-style
add yourself to the CONTRIBUTORS.md in the root of the project

@khalsah good catch!

This would break the backwards compatibility for users with tmux versions < 1.9.
@edkolev What is your opinion on this?

I'm fine with breaking compatibility for tmux <1.9 - it's been more than 5 years since 1.9 was released. Adding a conditional in the vim script would not work when you share the generated tmux conf file between machines with different versions of tmux.

Added the requested changes.
Also found a mention of attr in the README.

Thanks for working on this. Just noting https://github.com/tmux/tmux/wiki/FAQ#how-do-i-translate--fg--bg-and--attr-options-into--style-options and curious if this was a known issue here.

and curious if this was a known issue here

Could you clarify the question? The link is pointing to a wiki entry about migration; the wiki entry isn't a know issue

Gotcha, maybe this issue isn't related. I had to manually fix up some tmuxline generated settings to comply with the Tmux 2.9 Syntax ralated to -style and -attr. If thosed fixes have been merged in, I can try to run a new snapshot and see if that works.

This PR addresses exactly this - the *-fg/bg to *-style migration. And yes, you should be able to create a snapshot which works with the lates tmux.


Indoor Sensor

This is a question not an issue:
Is it possible to get the indoor sensor for Home Assistant usage?

You mean indoor temperature?
You can find it from climate entities, in current_temperature attribute

thanks... and sorry!


feat: utils

Description

Additional context

What is the purpose of this pull request?

[x] Other

Before submitting the PR, please make sure you do the following
There are utility functions such as isObject and isDefined in the utils library of the source code, but many places are not used, and still use typeof xxx === 'object' or typeof xxx === 'undefined' to judge, so this pr organizes these codes and reuses utility functions. In addition, I see that there are a large number of string, number, boolean judgment logic in the source code, so three new utility functions have been added for this type of judgment

Thanks for the PR, but I agree with Anthony. Also, isDefined and isObject are different from the other added functions. isObject implementation is complex enough for being a util. The other one could be argued to be removed.


Functions do not have to be Ref?

const { data, refetch } = useQuery("key", () => Promise.resolve(1), {
      refetchOnWindowFocus: false,
      enabled: false,
    });
refetch.value(); // manual exec

useBaseQuery returns a ref that's why. Check line 45.

Hi @NikitaIT
There is a way to restructure it and extract functions to be returned as functions, not refs. However seeing that more and more people start using the lib, it would be a breaking change.
For now, if you do not like that you have to call .value() on a function you can do something like:
const query = reactive(useQuery())
query.refetch()

If more people would think that this is cumbersome, we can think about improving it in V2.

Just wanted to chime in that this just snagged me, I assumed I could do query.refetch() and couldn't figure out why that wasn't right until I found this thread.


Add Kopia repository connection wrappers

Change Overview
This PR adds wrappers for creating a new Kopia repository or connecting to the respective repository.
TODO: Switch to read location and credentials from a secret
Pull request type
Please check the type of change your PR introduces:

[ ] :construction: Work in Progress
[ ] :rainbow: Refactoring (no functional changes, no api changes)
[ ] :hamster: Trivial/Minor
[ ] :bug: Bugfix
[ ] :sunflower: Feature
[ ] :world_map: Documentation
[ ] :robot: Test

Issues

fixes #issue-number

Test Plan

[ ] :muscle: Manual
[ ] :zap: Unit test
[ ] :green_heart: E2E

The workflow has been changed and separate PRs have been raised. Closing this PR.


Explore variants of the shifted Beta Geometric model

From: Fader, P. S., & Hardie, B. G. (2007). How to project customer retention. Journal of Interactive Marketing, 21(1), 76-90. pdf
They mention this other model derived from the beta-binomial, which is conceptually equivalent:

Their model is based on assumptions simi-
lar to those behind the sBG model: (a) Each person
responds to a direct-mail solicitation with constant
probability p, and (b) p varies across the population
according to a beta distribution. While BM base their
framework on the beta-binomial model, it could have
been derived as an sBG model (e.g., the mailing on
which the prospect responds to the offer is character-
ized by the shifted-geometric distribution). As such, it
is possible to identify clear relationships between
some of the results in this article [e.g., rt and S(t)] and
some quantities of interest in a list-falloff setting.

Then extensions with cohort covariates:

The BM framework was extended by Rao and Steckel
(1995) to incorporate (time-invariant) descriptor
variables such as age, income, and sex. This is accom-
plished using the beta-logistic model (Heckman &
Willis, 1977),

Incorporating the effects of time-
varying covariates (e.g., marketing-mix effects, sea-
sonality) is more complicated. The key is to bring in
all of these factors at the right level; that is, at the
level of the latent parameter of interest (in this case,
) instead of just “jamming” different covariate effects
into a regression-like model (see Schweidel, Fader, &
Bradlow, 2006, for a discussion of how to do this in a
continuous-time contractual setting.)

And extensions with time effets:

Both the sBG model and its continuous-time analog
(i.e., the EG model) are based on the assumption that
the commonly observed phenomenon of increasing
retention rates is due entirely to heterogeneity;
individual-customer-level retention rates are assumed
to be constant. If we wish to allow for the possibility of
time dynamics at the level of the individual customer,
we can no longer characterize the duration of an indi-
vidual’s relationship with the firm using either the
shifted-geometric or exponential distributions, both of
which have the “memoryless” property (i.e., the proba-
bility of survival to s  t, given survival to t , is the
same as the initial probability of survival to s ). In a
continuous-time setting, we can accommodate this
effect by assuming that individual lifetimes can be
characterized by the Weibull distribution, which allows
for an individual’s risk of canceling a contract to
increase or decrease as the length of the relationship
with the firm increases. In a discrete-time contractual
setting, this leads to the beta-discrete-Weibull (BdW)
model (Fader & Hardie, 2006), which is a generaliza-
tion of the sBG model, while in a continuous-time con-
tractual setting, this leads to a generalization of the EG
model, the Weibull-gamma (WG) model (Hardie et al.,
1998; Morrison & Schmittlein, 1980).

There's a PDF related to this in Bruce Hardie's notes:
https://www.brucehardie.com/notes/037/time-varying_covariates_in_BG.pdf


Clear input after each motion

After each motion is parsed, clear the input, and remember the current position.
This way it's not necessary to process the whole input time and time again, especially for long inputs.
Make sure it works with #15 (it should wait until "enter" before the input is consumed)

Done in #18

Done in #18


ISPN-13057 RemoveExpiredCommand ignored by IRAC

The IracLocalInterceptor was ignoring the RemoteExpiredCommand so the
tombstone was not properly recorded for the expired key.
This caused a NullPointerException when sending the remove request to
remote sites.
Other changes somehow related:

Requests from remote site no longer check for expiration since the key
is going to be updated.
Tag Remove request from remote site for expired keys.
New conflict resolution for expiration removals: they always lose in
case of conflict.

Off-topic changes

PutForExternal read was not backup for tx caches and they didn't
generate the IracMetadata
Fixed AsyncBackupExpirationTest random failure
Deprecated org.infinispan.util.ControlledTimeService.

https://issues.redhat.com/browse/ISPN-13057
ps. needs to be backported to 12.1

Integrated into master, thanks @pruivo !


spark2 changes

this represents a significant architectural update, without additional resources it is unlikely to ever occur.