this.coordinator.activate() is async. So, should there be an example of building a dataStore when you need the dataStore to be built

I currently am working with this:
provider.tsx
import * as React from 'react';
import { DataProvider } from 'react-orbitjs';

import { Bucket } from '@orbit/core';
import Orbit, { Source } from '@orbit/data';
import Store from '@orbit/store';

import LocalStorageBucket from '@orbit/local-storage-bucket';
import IndexedDBBucket, { supportsIndexedDB } from '@orbit/indexeddb-bucket';
import Coordinator, { SyncStrategy, RequestStrategy } from '@orbit/coordinator';
import JSONAPISource from '@orbit/jsonapi';
import IndexedDBSource from '@orbit/indexeddb';

import { api as apiEnv, app as appEnv } from '@env';
import { getToken } from '@lib/auth0';
import * as authenticatedFetch from '@lib/fetch';

import { schema } from './schema';

const BucketClass = (supportsIndexedDB ? IndexedDBBucket : LocalStorageBucket);

interface IState {
  store: Store;
};

export default class APIProvider extends React.Component<{}, IState> {
  state = { store: undefined };
  coordinator: Coordinator;

  constructor(props) {
    super(props);

    this.initDataStore();
  }

  async initDataStore() {
    console.debug('Setting up datastore');
    Orbit.fetch = authenticatedFetch;

    const bucket = new BucketClass({ namespace: 'scriptoria-bucket' });
    const inMemory = new Store({ bucket, schema, name: 'inMemory' });

    const remote = new JSONAPISource({
      schema,
      name: 'remote',
      host: `${apiEnv.protocol}${apiEnv.host}/api`,
      defaultFetchHeaders: {
        Accept: 'application/vnd.api+json',
        Authorization: getToken()
      }
    });

    // For later when we want to persist between refreshes
    // or queue offline things
    const backup = new IndexedDBSource({
      bucket,
      schema,
      name: 'backup',
      namespace: 'scriptoria'
    });

    // We don't want to have to query the API everytime we want data
    this.coordinator = new Coordinator({
      sources: [backup, inMemory, remote]
    });

    // TODO: when there is a network error:
    // https://github.com/dgeb/test-ember-orbit/blob/master/app/data-strategies/remote-push-fail.js

    // Pull query results from the server
    this.coordinator.addStrategy(new RequestStrategy({
      name: 'inMemory-remote-query-pessimistic',
      source: 'inMemory',
      on: 'beforeQuery',
      target: 'remote',
      action: 'pull',
      blocking: true
    }));

    // Push updates to the server
    this.coordinator.addStrategy(new RequestStrategy({
      name: 'inMemory-remote-update-pessimistic',
      source: 'inMemory',
      on: 'beforeUpdate',
      target: 'remote',
      action: 'push',
      blocking: true
    }));

    // sync all remote changes with the inMemory store
    this.coordinator.addStrategy(new SyncStrategy({
      source: 'remote',
      target: 'inMemory',
      blocking: true
    }));

    this.coordinator.addStrategy(new SyncStrategy({
      source: 'inMemory',
      target: 'backup',
      blocking: false
    }));

    // If there is data already stored locally, throw it in memory
    // backup.pull(q => q.findRecords())
    //   .then(transform => {
    //     console.log(transform);
    //     return inMemory.sync(transform)
    //   })
    //   .then(() => this.coordinator.activate());

    await this.coordinator.activate();

    this.setState({ store: inMemory }, () => console.debug('datastore is setup'));

    return inMemory;
  }

  render() {
    const { store } = this.state;

    if (!store) return 'Loading...';

    return (
      <DataProvider dataStore={store}>
        {this.props.children}
      </DataProvider>
    );
  }
}

which is used here:
application.tsx
import * as React from 'react';
import { BrowserRouter } from 'react-router-dom';

import { DataProvider } from '../data';
import { ReduxProvider } from '../redux-store';
import RootRoute from './routes/root';

export default class Application extends React.Component {
  render() {
    return (
      <DataProvider>
        <ReduxProvider>
          <BrowserRouter>
            <RootRoute />
          </BrowserRouter>
        </ReduxProvider>
      </DataProvider>
    );
  }
}

and I need the coordinator to activate before I make any queries (which I don't yet have working somehow...)
I know because in my log:

my withCurrentUser hoc is  rendered twice, once before the datastore is setup
though, throwing a console in my render method shows something different:

so I wonder if the callback on setState runs after render. hmm

I think we're missing the withCurrentUser code to see what exactly is going on. Does it render inside the RootRoute component?
Also, where is the APIProvider rendered exactly?
And... what is your question exactly? ;)

withCurrentUser is:
import * as React from 'react';
import { Redirect } from 'react-router-dom';
import { withData, WithDataProps } from 'react-orbitjs';
import { compose } from 'recompose';
import { UserAttributes, TYPE_NAME } from '@data/models/user';
import { MapRecordsToProps } from '../../types/react-orbitjs/index';

type UserPayload = JSONAPI<UserAttributes>;

const mapRecordsToProps = {
  currentUser: q => q.findRecord({ id: 'current-user', type: TYPE_NAME })
}

interface IProps {
  currentUser: UserPayload;
}

interface IState {
  currentUser: UserPayload;
  notFound: boolean;
}

export function withCurrentUser() {
  return InnerComponent => {
    class WrapperClass extends React.Component<IProps & WithDataProps, IState> {
      state = { currentUser: undefined, notFound: false };

      componentDidMount() {
        const { currentUser } = this.props;

        if (currentUser) {
          this.setState({ currentUser });
          return;
        }

        // There is no current user. Redirect to login.
        // NOTE: because the backend does findOrCreate with the
        //     auth0Id, this should never happen.
        //     but it could if the network request fails or
        //     if there is a server error.
        //
        // TODO: store the attempted URL so that after login,
        //     we can navigate back.
        this.setState({ notFound: true });
      }

      render() {
        const { currentUser, notFound } = this.state;

	console.debug('current user: ', this.state);

        if (currentUser) {
          return <InnerComponent {...this.props} />;
        } else if (notFound) {
          return 'User could not be found and/or created....';
          return <Redirect to={'/login'} />;
        }

        return 'Loading? what should we do here before we get the current user?';
      }
    }

    return compose(
      withData(mapRecordsToProps)
    )(WrapperClass);
  }
}

which is then used within:
requireAuth
import * as React from 'react';
import { withRouter, RouterProps, Redirect } from 'react-router';

import { withCurrentUser } from '@data/with-current-user';
import { isLoggedIn } from '@lib/auth0';
import * as toast from '@lib/toast';

import { pathName as loginPath } from '@ui/routes/login';

export function requireAuth(Component) {
  const checkForAuth = (propsWithRouting: RouterProps) => {
    const authenticated = isLoggedIn();

    if (authenticated) {
      const WithUser = withCurrentUser()(Component);

      return <WithUser { ...propsWithRouting } />;
    }

    // toast.error('You must be logged in to do that');

    return <Redirect to={loginPath} />;
  };

  return requireAuthHelper(checkForAuth);
}

export function requireNoAuth(redirectPath = '/') {
  return (Component) => {
    const checkForNoAuth = (propsWithRouting: RouterProps) => {
      const authenticated = isLoggedIn();

      if (!authenticated) {
        return <Component { ...propsWithRouting } />;
      }

      // toast.error('You must be logged out to do that');

      return <Redirect to={redirectPath} />;
    };

    return requireAuthHelper(checkForNoAuth);
  };
}

function requireAuthHelper(authenticationChecker: (props: RouterProps) => any) {
  return (props: any) => {
    if (props.history) {
      return authenticationChecker(props);
    }

    const WrappedWithRouter = withRouter(authenticationChecker);

    return <WrappedWithRouter {...props } />;
  };
}

which is then used here:
import * as React from 'react';
import { compose } from 'recompose';

import { requireAuth } from '@lib/auth';
import { withLayout } from '@ui/components/layout';

export const pathName = '/tasks';

class Tasks extends React.Component {

  state = { data: {}, errors: {} };

  render() {
    return 'hi';
  }
}

export default compose(
  withLayout,
  requireAuth
)(Tasks);

(sorry for the redirection -- lots of abstracting going on here)
The APIProvider? do you mean the DataProvider? -- in application.tsx, which is rendered from here:
import * as React from 'react';
import * as ReactDOM from 'react-dom';

import 'vendor/legacy-support';
import './global-config';

import 'semantic-ui-css/semantic.min.css';

import './ui/styles/app.scss';
// require('public/images/*');

import Application from './ui/application';

ReactDOM.render(
  <Application />,
  document.getElementById('root')
);

(and that's the entrypoint to my app)

And... what is your question exactly? :wink:

I'm just wondering if there should be a more thorough example? since maybe the store's setup requires async behavior? and the readme assumes that the dataStore already exists, which is fine, maybe -- but with react handling async things always requires a placeholder component (at least, I'm pretty sure it does).  Maybe you're looking at the problem described in more detail here: https://github.com/exivity/react-orbitjs/issues/4?

I "think" so? I'm still pretty new to orbit.
In all that mess I have pasted above, this is my only query:
const mapRecordsToProps = {
  currentUser: q => q.findRecord({ id: 'current-user', type: TYPE_NAME })
}

and orbit is printing this warning:

Basically all react-orbitjs does is only ever query the stores cache. This will (intentionally for now, also refer to previously mentioned issue) never invoke any coordinators. This is to prevent unnecessary calls to your API when your component receives new props. Instead, you should specifically query your store directly using store.query (or the passed-down prop queryStore) to invoke a 'regular' query, which in turn will update the stores cache, which in turn will trigger react-orbitjs.
Try adding
inMemory.query(q => q.findRecord({ type: 'user', id: 'current-user' }));

right after await this.coordinator.activate();
There's a small note in the docs, but maybe I should update it:

Please note that withData() passes props received from the store cache. If you want to pull data from external sources, use the injected this.props.queryStore() method.

Also, adding a simple example app using a coordinator and external source would be nice. Who knows about a nice public JSON-API?

thanks!
Also, as far as public JSONAPIs, I found this:
http://thomaxxl.pythonanywhere.com/api/#!/Users/RetrieveaUserobject_0

Thanks, I will have a look.
Closing this now, but feel free to comment here if you need more help!


No output on debug accessory UART (UART2)

I no longer see any UART output on the debug accessory when loading the example.imx
the last one I played with was when it was still using u-boot, so it might be an initialization issue.
Can you reproduce this on your side?

Yes, this is expected.
The UART and USB are both multiplexed on the Type-C receptacle, the default is USB.
When loading with U-Boot the UART is selected, while TamaGo leaves USB as it
does not have the I2C driver, required to switch the from USB to UART.
We plan to add this feature soon.

Fixed by https://github.com/f-secure-foundry/tamago-example/commit/ccc187c2627cc1952301fea78fd2321d0e60c67b#diff-32341fe39054c2d5e2a4e8639e9a84b016d20180cc86b31ba1137f9177ddfe7eR30


Add cycling like org-mode

This PR implements cycling something like org-mode. cycle is like toggle, but it cycles between "Collapse all", "Show headings", and "Show all". cycleall does this globally.
I added tests, but none of the package tests work on my windows machine (probably user error).
Org-mode attaches these functions to TAB and SHIFT-TAB in a DWIM fashion. I didn't attempt that.

Here are the keys I use with vim-mode:
'atom-text-editor.vim-mode.normal-mode':
  'tab': 'markdown-folder:cycle'
  'shift-tab': 'markdown-folder:cycleall'

I've updated this pull request to add a feature to fold and unfold fenced code blocks. I've also included dwim-toggle to toggle or cycle the folding of either headings or code blocks, depending on context. This works well with the TAB key; when you hit TAB at any place but a heading or the first line of a code block, you get standard TAB-key behavior.
The folding of code blocks works well with mdpad, a system I put together to make web apps by mixing Markdown with code and data in fenced code blocks more examples.

The README now includes the following video:

Pinging @melke ...

Thank you @tshort
Accidently, I had "unwatched" this repo in Github, that's why my response is so late.
This looks great! I love org-mode. Actually, the reason for writing this plugin in the first place was to get some org-mode-like behavior for markdown.
I haven't looked at the code and done any tests yet, though. Give me a couple of days and I will get back to you.

Hi @tshort Your cycle addition works (almost) perfectly! Thank you. There is one small thing that is not working when doing cycleall: If there is no H1 headers, the cycling doesn't work. I've added a spec test that tests against a file that does not have a H1 header, but I thought I'd leave the fix to you :) It would also be great if you could add spec tests for toggling code blocks. Maybe in another spec file?
Please have a look at my branch https://github.com/melke/markdown-folder/tree/tshort-master , where I made the changes.

@tshort Oops, it's checked in now


Show question count for each queue

We can use our fancy new websocket infrastructure to make this update in real time, because why not?

@nwalters512 was this resolved with the new homepage, or is this question count meant to be for the actual queue page?

@genevievehelsel I think this should have been closed with another commit in the previous repo - it's not live updating, but it shows counts, which is what matters :tada:


[5.9] Write link file list as a build command

This moves the generation of link file lists into the build system instead of doing it ad-hoc outside of the build. For this, we have a new WriteAuxiliaryFile tool and associated command that should be usable for any kind of writing of auxiliary files during the build.
Note that this change opted to not touch the existing infrastructure for in-process tools, so any inputs that are needed for the file generation will need to be flattened into a generic array of input nodes. The different types of file generation are keyed off a virtual node at the start of that array.
(cherry picked from commit ee7f064d7796533deb5ce4fe2094b72cfd510faf)

Draft because this is introducing test failures that need to be investigated.

@swift-ci please smoke test

Test failures on CI match what I was seeing locally.

I think that we should consider the -debug-info-format and file list support as that will help the VSCode plugin as well as general usability of SPM on Windows.

I think that we should consider the -debug-info-format and file list support as that will help the VSCode plugin as well as general usability of SPM on Windows.

I think we can consider that once we're able to land this. There are a number of more critical bug fixes that I need to get into 5.9 before I can return to this cherry-pick. In case you (or anyone else) has cycles to look into the failures on this PR that would increase the chances of being able to get this into 5.9.

Rebased the branch, but haven't been able to figure out yet what causes the test failures exactly. It seems like in some tests we're evaluating plugins correctly anymore, but I don't know why.
Separately, we also need to figure out what to do about https://github.com/apple/swift-package-manager/issues/6755

Going to close this, at this point it is too late to confidently get this into 5.9


Mobile container 🫙 is broken on mobile again 😬

Found container 🫙 is broken on mobile again 😬 and it's moving, but I guess we can postpone it to another following issue.
https://user-images.githubusercontent.com/5887929/161374871-2edd68c8-ee2e-4395-833a-a5359da66682.mp4
Originally posted by @yangwao in https://github.com/kodadot/nft-gallery/pull/2722#issuecomment-1086590712

I'll check this

@yangwao is this still happening for you? not happening for me

on item is already fixed meanwhile on beta
on landing, it's there, you can move horizontaly.

Is it blank or works?
https://user-images.githubusercontent.com/5887929/161936472-2112e3da-b235-4514-b63a-50e2df2e62aa.mp4

https://photos.app.goo.gl/Z2CzRG5T6RpKJ68D6
Awkward gh app or my phone 📱 is broken

Blank for me

Blank for me too


WIP: Deprecate 'license.enterprise' setting

Summary of the changes / Why this improves CrateDB
Checklist

[ ] User relevant changes are recorded in CHANGES.txt
[ ] Touched code is covered by tests
[ ] Documentation has been updated if necessary
[ ] CLA is signed

Got superseded by https://github.com/crate/crate/pull/8345


Display message when no car images found

@mahdibenromdhane pay attention, you forgot again the pt.json translation file!

@mahdibenromdhane pay attention, you forgot again the pt.json translation file!

Yes, I forgot about it again.
It will be there next time.


New LocationModule model

Based on a specific need in my organization I implemented the LocationModule model to attach documents for Locations objects in NetBox.

New Model "LocationDocument" added.
Site field added in LocationDocument model because the Location name is not unique within NetBox DB.
Validation if Location belogs to Site.

Thanks for the PR!


[HOLD https://github.com/Expensify/App/pull/49038] [NoQA] chore: bump expensify-common to 2.0.89

Details
Bumps expensify-common package to v2.0.89 which contains improvements related to overall package size 👍
Fixed Issues
$ https://github.com/Expensify/App/issues/48978
PROPOSAL: https://github.com/Expensify/App/issues/48978
Tests

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@mountiny Does this PR need a C+ review?

I don't think there will be any specific testing but there are 2 PRs that should come before this one that will bump the common library, the one we should hold on is this one https://github.com/Expensify/App/pull/49038

https://github.com/Expensify/App/pull/49038 was merged, should we processed with this PR? 🤔

We can close this as the version is already above https://github.com/Expensify/App/pull/49856 😅


Can't install

Hello maybe I haven't got the good process but when I want to install the report,
I have this error :
<Integration jmcollin78/versatile-thermostat-ui-card> Repository structure for 0.5.0 is not compliant
Thx

I guess you have succeeded now. You are certainly not in the right place to add the repo. You should go to "Interface" section of HACS.


drag by offset support

Dragging by offset suport at least for a native element. Drag to a position is not possible with poltergeist now

I added tests for dragging ( I did not found a drag_by so I added it too :)
is ok like this?
Also I had to add -5 to the mouseUp event.. I dont understand why, but whitout it it moves by 5 more ( or less if negative direction ). Do you know what can cause it?

Hey, @route is this acceptable? :) I would love to get it to new release if it would be possible.

@phoenixek12 Thanks for pinging me, yeah it looks good to me. You said there were issues with tests, how is it now?

@route yeah, it is ok now, I wrote them and all passing.

I've merged it manually and added CHANGELOG entry. Thanks again!


Update using-jinja.md

Use {{ ref('raw_payments') }} rather than app_data.payments (which does not exist)
Description & motivation

To-do before merge

Prerelease docs
If this change is related to functionality in a prerelease version of dbt (delete if not applicable):

[ ] I've added versioning components, as described in "Versioning Docs"
[ ] I've added a note to the prerelease version's Migration Guide

Checklist
If you added new pages (delete if not applicable):

[ ] The page has been added to website/sidebars.js
[ ] The new page has a unique filename

If you removed existing pages (delete if not applicable):

[ ] The page has been removed from website/sidebars.js
[ ] An entry has been added to _redirects

Thanks, @dlobo !
In reviewing your PR, I discovered this was fixed in PR #2585. Will go ahead and close this.
Thanks so much for contributing to the dbt docs!


[v6] Refactor WafV2 types to recursive

WafV2 module has two problematic resources with massive schemas. Because TF can't represent recursive schema types, they brute-force generated approximations of recursive types a few layers down. Example:
https://github.com/hashicorp/terraform-provider-aws/blob/5c5ab41aad82960be2dc8f0ed201098e260cd07a/internal/service/wafv2/schemas.go#L45
This leads to massive SDK sizes on Pulumi size. However, Pulumi does support recursive types. This PR uses a heuristic to find all references to all Statement types and replace those references with a reference to the single top-level Statement types. It then removes all unneeded types to gain a massive advantage in terms SDKs size.
We still need to finalize how to ship this PR. I opened it against master for review, but I hope we can merge it into v6 instead before the GA is released.
Fix #2276
Fix #1117
Fix #2250
Fix https://github.com/pulumi/pulumi/issues/8950

This LGTM but I need the maintaining team to pipe in.


Rename date into currentYear

Fixes #25.

We need to settle on a naming for this. An offline discussion suggested currentYear might not bee that good, as current year is always the current year so to say.
New suggestions:
Alt 1.

.Parse(int parseYear)
.To10DigitString(int serializationYear)

Alt 2.

.ParseInSpecificYear(int year)
.To10DigitStringInSpecificYear(int year)

I prefer alternative 2. To me it feels better to see the alternatives as separate well-named methods. Instead of maybe seeing that there is an overload and then have to dig into the doc-comments to figure out what the parseYear/serializationYear parameters do.

I prefer alternative 2.

Cool. Would you say the names of the methods an parameters are ok?

Yes. 👍
And I assume the doc-comments would describe why this matters. I.e. that it matters for the delimiter.

I think that's good enough. Do we have any tests which would show the usage?

I think that's good enough. Do we have any tests which would show the usage?

Good! Plenty :) For example:
https://github.com/ActiveLogin/ActiveLogin.Identity/blob/master/test/ActiveLogin.Identity.Swedish.Test/SwedishPersonalIdentityNumber_Parse.cs#L224
https://github.com/ActiveLogin/ActiveLogin.Identity/blob/master/test/ActiveLogin.Identity.Swedish.Test/SwedishPersonalIdentityNumber_To10DigitString.cs#L61

Maybe:

I agree! I will fix the PR tonight,

I was reading through the code and realized that the naming of the parameters propagate down through the code. I think we should use the names parseYear and serializationYear throughout it it’s possible. If it’s only named year it will be harder to understand without going all the way up to the call site to see what it means.

I think we should use the names parseYear and serializationYear throughout it it’s possible

Very good idea! I've now pushed the changes to rename into this:

.ParseInSpecificYear(int parseYear)
.TryParseInSpecificYear(int parseYear)
.To10DigitStringInSpecificYear(int serializationYear)

To10DigitStringInSpecificYear has no references to other methods, but all parsing places should use parseYear now. Please have a look and we can merge.


Load text-encoding for older versions only

Details
Only load the text-encoding library on older versions of RN.
What this fixes

This is a partial requirement for https://github.com/Expensify/App/issues/54096
Checklist

[ ] I have described the bug/issue
[ ] I have provided reproduction in Example App
[ ] I have tested that solution works on Example App on all platforms:

Android
iOS
Web

Screenshots/Videos

I have read the CLA Document and I hereby sign the CLA

recheck


ARROW-11035: [Rust] Improved performance of casting to utf8

cast i64 to string 512  time:   [92.618 us 92.839 us 93.097 us]
                        change: [-14.915% -14.287% -13.743%] (p = 0.00 < 0.05)
                        Performance has improved.
Found 5 outliers among 100 measurements (5.00%)

Codecov Report

Merging #9014 (dcd08eb) into master (a4f7c4a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #9014   +/-   ##
=======================================
  Coverage   82.87%   82.87%
=======================================
  Files         201      201
  Lines       49739    49728   -11
=======================================
- Hits        41220    41213    -7
+ Misses       8519     8515    -4

Impacted Files
Coverage Δ

rust/arrow/src/compute/kernels/cast.rs
97.00% <100.00%> (+0.16%)
:arrow_up:

rust/parquet/src/encodings/encoding.rs
95.43% <0.00%> (+0.19%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4f7c4a...6f9ca05. Read the comment docs.

The full set of Rust CI tests did not run on this PR :(
Can you please rebase this PR against apache/master to pick up the changes in https://github.com/apache/arrow/pull/9056 so that they do?
I apologize for the inconvenience.


'rake console' task for easy dev

Hello @amrrbakry , I saw that you have created a new gem for Fawry and I would like to add things to it.
I thought it would be a good start to me with this little script and I hope we could work on making it a great gem.

merged :tada: :tada: thank you so much, Amr :heart: :+1:


cert and / or sigh fails with error: SSL_connect SYSCALL returned=5 errno=0 state=SSLv2/v3 read server hello A

Issue Description
We've started to get weird SSL errors when running Fastlane via Jenkins:
SSL_connect SYSCALL returned=5 errno=0 state=SSLv2/v3 read server hello A

We use Fastlane with Jenkins for deploying various apps, and all of them exhibit the same problem.
In the log the problem happens in the cert step, but sometimes it happens in the sigh step.
When running Fastlane manually from the command line it works most of the time, but not always.
I've read that this might be related to RVM, but we're not using RVM or any other Ruby environment manager. I also tried updating OpenSSL, as some have suggested as a workaround for similar issues.
Logging in and fetching profiles seems to take extremely long, multiple minutes.
I'm surprised to see Fastlane using SSLv2/v3 to connect to Apples servers. I thought they were TSLv1.2 only?

Complete output when running fastlane, including the stack trace and command used
fastlane hockey --verbose
DEBUG [2016-07-18 12:03:41.72]: Checking if there are any plugins that should be loaded...
INFO [2016-07-18 12:03:41.85]: -------------------------------------------------
INFO [2016-07-18 12:03:41.85]: --- Step: Verifying required fastlane version ---
INFO [2016-07-18 12:03:41.85]: -------------------------------------------------
INFO [2016-07-18 12:03:41.85]: fastlane version valid
INFO [2016-07-18 12:03:41.88]: ------------------------------
INFO [2016-07-18 12:03:41.88]: --- Step: default_platform ---
INFO [2016-07-18 12:03:41.88]: ------------------------------
INFO [2016-07-18 12:03:41.92]: Driving the lane 'ios hockey' 🚀
INFO [2016-07-18 12:03:42.02]: ------------------
INFO [2016-07-18 12:03:42.02]: --- Step: cert ---
INFO [2016-07-18 12:03:42.02]: ------------------

+---------------+--------------------------------------------------------+
|                         Summary for cert 1.4.1                         |
+---------------+--------------------------------------------------------+
| development   | false                                                  |
| force         | false                                                  |
| username      |<EMAIL_ADDRESS>                                   |
| team_id       | RCURWWDFZV                                             |
| keychain_path | /Users/Shared/Jenkins/Library/Keychains/login.keychain |
+---------------+--------------------------------------------------------+

INFO [2016-07-18 12:03:42.91]: Starting login with user<EMAIL_ADDRESS>INFO [2016-07-18 12:04:45.60]: ---------------------
INFO [2016-07-18 12:04:45.60]: --- Step: hipchat ---
INFO [2016-07-18 12:04:45.60]: ---------------------
WARN [2016-07-18 12:04:46.46]: Variable Dump:
INFO [2016-07-18 12:04:46.46]: {:DEFAULT_PLATFORM=>:ios, :PLATFORM_NAME=>:ios, :LANE_NAME=>"ios hockey"}
ERROR [2016-07-18 12:04:46.46]: SSL_connect SYSCALL returned=5 errno=0 state=SSLv2/v3 read server hello A
INFO [2016-07-18 12:04:46.46]: Successfully generated documentation to path '/Users/Shared/Jenkins/slave1/workspace/myApp_hockey/fastlane/README.md'

+------+-------------------------------------+-------------+
|                     fastlane summary                     |
+------+-------------------------------------+-------------+
| Step | Action                              | Time (in s) |
+------+-------------------------------------+-------------+
| 1    | Verifying required fastlane version | 0           |
| 2    | default_platform                    | 0           |
| 3    | cert                                | 63          |
| 4    | hipchat                             | 0           |
+------+-------------------------------------+-------------+

ERROR [2016-07-18 12:04:46.47]: fastlane finished with errors

Looking for related GitHub issues on fastlane/fastlane...
Search query: SSL_connect SYSCALL returned=5 errno=0 state=SSLv2/v3 read server hello A

URL: https://api.github.com/search/issues?q=SSL_connect%20SYSCALL%20returned=5%20errno=0%20state=SSLv2/v3%20read%20server%20hello%20A+repo:fastlane/fastlane
➡  Intermittent SSL errors
   https://github.com/fastlane/fastlane/issues/2075 [closed] 35 💬
   4 weeks ago

/Users/Shared/Jenkins/.rbenv/versions/2.0.0-p481/lib/ruby/2.0.0/net/http.rb:918:in `connect': [!] SSL_connect SYSCALL returned=5 errno=0 state=SSLv2/v3 read server hello A (Faraday::SSLError)
	from /Users/Shared/Jenkins/.rbenv/versions/2.0.0-p481/lib/ruby/2.0.0/net/http.rb:918:in `block in connect'
	from /Users/Shared/Jenkins/.rbenv/versions/2.0.0-p481/lib/ruby/2.0.0/timeout.rb:66:in `timeout'
	from /Users/Shared/Jenkins/.rbenv/versions/2.0.0-p481/lib/ruby/2.0.0/net/http.rb:918:in `connect'
	from /Users/Shared/Jenkins/.rbenv/versions/2.0.0-p481/lib/ruby/2.0.0/net/http.rb:862:in `do_start'
	from /Users/Shared/Jenkins/.rbenv/versions/2.0.0-p481/lib/ruby/2.0.0/net/http.rb:851:in `start'
	from /Users/Shared/Jenkins/.rbenv/versions/2.0.0-p481/lib/ruby/2.0.0/net/http.rb:1367:in `request'
	from /Users/Shared/Jenkins/.rbenv/versions/2.0.0-p481/lib/ruby/gems/2.0.0/gems/faraday-0.9.2/lib/faraday/adapter/net_http.rb:82:in `perform_request'
	from /Users/Shared/Jenkins/.rbenv/versions/2.0.0-p481/lib/ruby/gems/2.0.0/gems/faraday-0.9.2/lib/faraday/adapter/net_http.rb:40:in `block in call'
	from /Users/Shared/Jenkins/.rbenv/versions/2.0.0-p481/lib/ruby/gems/2.0.0/gems/faraday-0.9.2/lib/faraday/adapter/net_http.rb:87:in `with_net_http_connection'
	from /Users/Shared/Jenkins/.rbenv/versions/2.0.0-p481/lib/ruby/gems/2.0.0/gems/faraday-0.9.2/lib/faraday/adapter/net_http.rb:32:in `call'
	from /Users/Shared/Jenkins/.rbenv/versions/2.0.0-p481/lib/ruby/gems/2.0.0/gems/faraday-cookie_jar-0.0.6/lib/faraday/cookie_jar.rb:22:in `call'
	from /Users/Shared/Jenkins/.rbenv/versions/2.0.0-p481/lib/ruby/gems/2.0.0/gems/faraday_middleware-0.10.0/lib/faraday_middleware/response_middleware.rb:30:in `call'
	from /Users/Shared/Jenkins/.rbenv/versions/2.0.0-p481/lib/ruby/gems/2.0.0/gems/faraday_middleware-0.10.0/lib/faraday_middleware/response_middleware.rb:30:in `call'
	from /Users/Shared/Jenkins/.rbenv/versions/2.0.0-p481/lib/ruby/gems/2.0.0/gems/faraday_middleware-0.10.0/lib/faraday_middleware/response_middleware.rb:30:in `call'
	from /Users/Shared/Jenkins/.rbenv/versions/2.0.0-p481/lib/ruby/gems/2.0.0/gems/faraday-0.9.2/lib/faraday/rack_builder.rb:139:in `build_response'
	from /Users/Shared/Jenkins/.rbenv/versions/2.0.0-p481/lib/ruby/gems/2.0.0/gems/faraday-0.9.2/lib/faraday/connection.rb:377:in `run_request'
	from /Users/Shared/Jenkins/.rbenv/versions/2.0.0-p481/lib/ruby/gems/2.0.0/gems/faraday-0.9.2/lib/faraday/connection.rb:177:in `post'
	from /Users/Shared/Jenkins/.rbenv/versions/2.0.0-p481/lib/ruby/gems/2.0.0/gems/spaceship-0.27.2/lib/spaceship/client.rb:411:in `block in send_request'
	from /Users/Shared/Jenkins/.rbenv/versions/2.0.0-p481/lib/ruby/gems/2.0.0/gems/spaceship-0.27.2/lib/spaceship/client.rb:329:in `with_retry'
	from /Users/Shared/Jenkins/.rbenv/versions/2.0.0-p481/lib/ruby/gems/2.0.0/gems/spaceship-0.27.2/lib/spaceship/client.rb:410:in `send_request'
	from /Users/Shared/Jenkins/.rbenv/versions/2.0.0-p481/lib/ruby/gems/2.0.0/gems/spaceship-0.27.2/lib/spaceship/client.rb:386:in `request'
	from /Users/Shared/Jenkins/.rbenv/versions/2.0.0-p481/lib/ruby/gems/2.0.0/gems/spaceship-0.27.2/lib/spaceship/portal/portal_client.rb:51:in `teams'
	from /Users/Shared/Jenkins/.rbenv/versions/2.0.0-p481/lib/ruby/gems/2.0.0/gems/spaceship-0.27.2/lib/spaceship/portal/ui/select_team.rb:35:in `select_team'
	from /Users/Shared/Jenkins/.rbenv/versions/2.0.0-p481/lib/ruby/gems/2.0.0/gems/spaceship-0.27.2/lib/spaceship/portal/portal_client.rb:73:in `select_team'
	from /Users/Shared/Jenkins/.rbenv/versions/2.0.0-p481/lib/ruby/gems/2.0.0/gems/spaceship-0.27.2/lib/spaceship/portal/spaceship.rb:37:in `select_team'
	from /Users/Shared/Jenkins/.rbenv/versions/2.0.0-p481/lib/ruby/gems/2.0.0/gems/spaceship-0.27.2/lib/spaceship/portal/spaceship.rb:81:in `select_team'
	from /Users/Shared/Jenkins/.rbenv/versions/2.0.0-p481/lib/ruby/gems/2.0.0/gems/cert-1.4.1/lib/cert/runner.rb:18:in `login'
	from /Users/Shared/Jenkins/.rbenv/versions/2.0.0-p481/lib/ruby/gems/2.0.0/gems/cert-1.4.1/lib/cert/runner.rb:27:in `run'
	from /Users/Shared/Jenkins/.rbenv/versions/2.0.0-p481/lib/ruby/gems/2.0.0/gems/cert-1.4.1/lib/cert/runner.rb:6:in `launch'
	from /Users/Shared/Jenkins/.rbenv/versions/2.0.0-p481/lib/ruby/gems/2.0.0/gems/fastlane-1.97.2/lib/fastlane/actions/cert.rb:19:in `run'
	from /Users/Shared/Jenkins/.rbenv/versions/2.0.0-p481/lib/ruby/gems/2.0.0/gems/fastlane-1.97.2/lib/fastlane/runner.rb:197:in `block (2 levels) in execute_action'
	from /Users/Shared/Jenkins/.rbenv/versions/2.0.0-p481/lib/ruby/gems/2.0.0/gems/fastlane-1.97.2/lib/fastlane/actions/actions_helper.rb:35:in `execute_action'
	from /Users/Shared/Jenkins/.rbenv/versions/2.0.0-p481/lib/ruby/gems/2.0.0/gems/fastlane-1.97.2/lib/fastlane/runner.rb:182:in `block in execute_action'
	from /Users/Shared/Jenkins/.rbenv/versions/2.0.0-p481/lib/ruby/gems/2.0.0/gems/fastlane-1.97.2/lib/fastlane/runner.rb:181:in `chdir'
	from /Users/Shared/Jenkins/.rbenv/versions/2.0.0-p481/lib/ruby/gems/2.0.0/gems/fastlane-1.97.2/lib/fastlane/runner.rb:181:in `execute_action'
	from /Users/Shared/Jenkins/.rbenv/versions/2.0.0-p481/lib/ruby/gems/2.0.0/gems/fastlane-1.97.2/lib/fastlane/runner.rb:107:in `trigger_action_by_name'
	from /Users/Shared/Jenkins/.rbenv/versions/2.0.0-p481/lib/ruby/gems/2.0.0/gems/fastlane-1.97.2/lib/fastlane/fast_file.rb:140:in `method_missing'
	from Fastfile:94:in `block (2 levels) in parsing_binding'
	from /Users/Shared/Jenkins/.rbenv/versions/2.0.0-p481/lib/ruby/gems/2.0.0/gems/fastlane-1.97.2/lib/fastlane/lane.rb:33:in `call'
	from /Users/Shared/Jenkins/.rbenv/versions/2.0.0-p481/lib/ruby/gems/2.0.0/gems/fastlane-1.97.2/lib/fastlane/lane.rb:33:in `call'
	from /Users/Shared/Jenkins/.rbenv/versions/2.0.0-p481/lib/ruby/gems/2.0.0/gems/fastlane-1.97.2/lib/fastlane/runner.rb:50:in `block in execute'
	from /Users/Shared/Jenkins/.rbenv/versions/2.0.0-p481/lib/ruby/gems/2.0.0/gems/fastlane-1.97.2/lib/fastlane/runner.rb:46:in `chdir'
	from /Users/Shared/Jenkins/.rbenv/versions/2.0.0-p481/lib/ruby/gems/2.0.0/gems/fastlane-1.97.2/lib/fastlane/runner.rb:46:in `execute'
	from /Users/Shared/Jenkins/.rbenv/versions/2.0.0-p481/lib/ruby/gems/2.0.0/gems/fastlane-1.97.2/lib/fastlane/lane_manager.rb:46:in `cruise_lane'
	from /Users/Shared/Jenkins/.rbenv/versions/2.0.0-p481/lib/ruby/gems/2.0.0/gems/fastlane-1.97.2/lib/fastlane/command_line_handler.rb:30:in `handle'
	from /Users/Shared/Jenkins/.rbenv/versions/2.0.0-p481/lib/ruby/gems/2.0.0/gems/fastlane-1.97.2/lib/fastlane/commands_generator.rb:51:in `block (2 levels) in run'
	from /Users/Shared/Jenkins/.rbenv/versions/2.0.0-p481/lib/ruby/gems/2.0.0/gems/commander-4.3.5/lib/commander/command.rb:178:in `call'
	from /Users/Shared/Jenkins/.rbenv/versions/2.0.0-p481/lib/ruby/gems/2.0.0/gems/commander-4.3.5/lib/commander/command.rb:178:in `call'
	from /Users/Shared/Jenkins/.rbenv/versions/2.0.0-p481/lib/ruby/gems/2.0.0/gems/commander-4.3.5/lib/commander/command.rb:153:in `run'
	from /Users/Shared/Jenkins/.rbenv/versions/2.0.0-p481/lib/ruby/gems/2.0.0/gems/commander-4.3.5/lib/commander/runner.rb:428:in `run_active_command'
	from /Users/Shared/Jenkins/.rbenv/versions/2.0.0-p481/lib/ruby/gems/2.0.0/gems/fastlane_core-0.48.1/lib/fastlane_core/ui/fastlane_runner.rb:26:in `run!'
	from /Users/Shared/Jenkins/.rbenv/versions/2.0.0-p481/lib/ruby/gems/2.0.0/gems/commander-4.3.5/lib/commander/delegates.rb:15:in `run!'
	from /Users/Shared/Jenkins/.rbenv/versions/2.0.0-p481/lib/ruby/gems/2.0.0/gems/fastlane-1.97.2/lib/fastlane/commands_generator.rb:244:in `run'
	from /Users/Shared/Jenkins/.rbenv/versions/2.0.0-p481/lib/ruby/gems/2.0.0/gems/fastlane-1.97.2/lib/fastlane/commands_generator.rb:20:in `start'
	from /Users/Shared/Jenkins/.rbenv/versions/2.0.0-p481/lib/ruby/gems/2.0.0/gems/fastlane-1.97.2/lib/fastlane/cli_tools_distributor.rb:47:in `take_off'
	from /Users/Shared/Jenkins/.rbenv/versions/2.0.0-p481/lib/ruby/gems/2.0.0/gems/fastlane-1.97.2/bin/fastlane:5:in `<top (required)>'
	from /Users/Shared/Jenkins/.rbenv/versions/2.0.0-p481/bin/fastlane:22:in `load'
	from /Users/Shared/Jenkins/.rbenv/versions/2.0.0-p481/bin/fastlane:22:in `<main>'

Configuration Files
Please copy the complete content of your Fastfile and any other configuration files you use below:
Fastfile:
def pods
  # change to root directory and install pods
  # needs to be in root dir to successfully run post_install task (copy acknowledgements to app settings)
  system "cd ..;pod install 2<&1"
end

def deploymate
  # run deploymate
  system '/Applications/Deploymate.app/Contents/MacOS/Deploymate --cli -t myApp ../myApp.xcworkspace -x -v'
end

def sign_all_the_things (app_identifier)

    #https://github.com/fastlane/fastlane/blob/master/docs/CodeSigning.md
    sigh(app_identifier: "#{app_identifier}.watchkitapp.watchkitext")
    ENV["PROFILE_WATCHKIT_EXT"] = lane_context[SharedValues::SIGH_UDID]

    sigh(app_identifier: "#{app_identifier}.watchkitapp")
    ENV["PROFILE_WATCHKIT_APP"] = lane_context[SharedValues::SIGH_UDID]

    sigh(app_identifier: "#{app_identifier}")
    ENV["PROFILE_APP"] = lane_context[SharedValues::SIGH_UDID]
end

def config ()
  ENV["HIPCHAT_API_TOKEN"] = "1234"
  ENV["HIPCHAT_API_VERSION"] = "1"

  scheme = "myApp"

  configuration = "Develop"
  hockey_public_id = "1234"

  if ENV["FASTLANE_LANE_NAME"] == "testflight"
    configuration = "Release"
    hockey_public_id = "1234"
  end

  ENV["SCAN_SCHEME"] = scheme
  ENV["SCAN_CONFIGURATION"] = configuration
  ENV["SCAN_CLEAN"] = "true"

  ENV["GYM_SCHEME"] = scheme
  ENV["GYM_CONFIGURATION"] = configuration

  ENV["FL_HOCKEY_API_TOKEN"] = "1234"
  ENV["FL_HOCKEY_PUBLIC_IDENTIFIER"] = hockey_public_id
  ENV["FL_HOCKEY_REPOSITORY_URL"] = `git config --get remote.origin.url`
  ENV["FL_HOCKEY_COMMIT_SHA"] = `git log --format="%H" -n 1`

  ENV["PILOT_SKIP_SUBMISSION"] = "true"
  ENV["DELIVER_ITMSTRANSPORTER_ADDITIONAL_UPLOAD_PARAMETERS"] = "-t DAV"

  build_number = `git rev-list HEAD | wc -l | tr -d ' ' | tr -d '\n'`
  ENV["GIT_TAG"] = "#{ENV['FASTLANE_LANE_NAME']}/#{build_number}"
end

fastlane_version "1.37.0"

default_platform :ios

platform :ios do
  before_all do
    config
  end

  desc "Clean"
  lane :clean do
    `rm -rf "$(getconf DARWIN_USER_CACHE_DIR)/org.llvm.clang/ModuleCache"`
    `rm -rf ~/Library/Developer/Xcode/DerivedData`
    `rm -rf ~/Library/Caches/com.apple.dt.Xcode`
    `git clean -xdf`
  end

  desc "Build"
  lane :build do
    # run pod install
    pods

    # run deploymate
    deploymate

    # run tests
    scan

    # build the ipa
    gym
  end

  desc "Develop: Build, Test, Sign and upload to HockeyApp"
  lane :hockey do
    cert

    sign_all_the_things "de.myCompany.myApp"

    build

    hockey
  end

  desc "Release: Build, Test, Sign and upload to Testflight"
  lane :testflight do
    cert

    sign_all_the_things "com.myApp.myApp"

    build

    pilot

    hockey(upload_dsym_only: true)

    add_git_tag(tag: ENV["GIT_TAG"])
    push_git_tags

  end

  after_all do |lane|
    hipchat({channel: "myApp", message: "#{lane}: Build successful", success: true });
  end

  error do |lane, exception|
    hipchat({channel: "myApp", message: "#{lane}: Build failed with error #{exception}", success: false });
  end
end

Environment
fastlane version (run fastlane -v): 1.97.2
Do you use bundler to execute fastlane (i.e. bundle exec fastlane)? nope
Do you use a Ruby environment manager (e.g. chruby, rbenv, rvm)? nope

Have you tried https://github.com/fastlane/fastlane/blob/master/fastlane/docs/FAQs.md#im-getting-an-ssl-error?

Hi, I'm seeing the same errors since the weekend.
My Jenkins builds are failing, either in cert or sigh, with either the same error listed above -
SSL_connect SYSCALL returned=5 errno=0 state=SSLv2/v3 read server hello A
or occasionally:
SSL_connect SYSCALL returned=5 errno=0 state=SSLv3 read server session ticket A
These builds were successful last week.
I have tried the update steps listed in the FAQ linked by KrauseFX, but everything was already up to date.

The same issue here - sigh download_all fails with the above mentioned error messages. Last successful call on 15 Jul 2016, 4:16:44 PM, first failure on 16 Jul 2016, 9:48:04 PM.

@cargath Thanks for reaching out about this. Can you make sure your keychain is unlocked? That is often the cause of this problem when running on Jenkins. Also, just for a sanity check can you test after running sudo gem update fastlane?
Thanks!

@KrauseFx Yes, updated OpenSSL from 0.9.8 to 1.0.2.
@TKBurner I did update fastlane (i usually run update on everything that seems related when these kind of things happen). Will try the keychain unlock first thing in the morning.

@TKBurner keychain was/is unlocked... anyway, now it is working again without any changes on my side. Maybe this was a temporary issue on Apple's side?

Same as @teeqemm, it magically started working again. I guess it was a problem with Apples servers.
Hm, is it possible to make those error messages more helpful? Or would i have to submit an issue to the faraday (that's the library throwing the error, right?) project?

Thanks for letting me know @teeqemm and @cargath! Really glad you are back up and running. I'll make sure the team looks this over for improving error messages. Thanks!

I'm getting same issue since days ago

@webpolis Have you tried https://github.com/fastlane/fastlane/blob/master/fastlane/docs/FAQs.md#im-getting-an-ssl-error

Experiencing this: ```
SSL_connect SYSCALL returned=5 errno=0 state=SSLv2/v3 read server hello A

Same issue since this morning with Match.
OpenSSL update to date and Fastlane too.

@KrauseFx IIRC, spaceship forces the TLS version to something -- maybe Apple's server is no longer compatible with whatever that is?

@cargath @nicoaldegheri @vbresults Can you share your full input and output?

I am almost certain now that this is an issue caused by having ruby 2.0.0 in combination with Apple recently dropping SSL in favor of TLS.  Testing this now.

@vbresults Have you tried the steps described here: https://github.com/fastlane/fastlane/blob/master/fastlane_core/lib/fastlane_core/ui/fastlane_runner.rb#L90-L116 Thanks!

I have the same issue with cert.
@TKBurner I have executed the brew update && brew install ruby command.
I am using :

fastlane 1.106.2
cert 1.4.3
ruby 2.3.1p112

Don't know if it helps.

@TKBurner I got it resolved by installing ruby 2.3.1 with rbenv.

Installing ruby 2.3.1 with rbenv doesn't help for me.

I have fixed my issue.
The problem happened because I have installed fastlane with the default ruby version installed on Sierra.
Even after installing the last version of ruby, fastlane was using the mac os version of ruby because the path to ruby is hardcoded in the binary.
So I have reinstalled fastlane making sure it was using the right version of ruby and now it is ok.
For those who still have the issue make sure :

you have installed the last version of ruby (2.3.1)
your fastlane binary uses this version of ruby (which fastlane / vim whatever_path_to_fastlane)

@mcapelle Thanks for letting me know. Yes, we've seen some issues with system ruby lately. We are looking into a longer term plan for this. Thanks!

@mcapelle Thanks for following up. Can you run gem install fastlane and share the full output now that you've changed your ruby version? Thanks!


Update reference.md

Replace $watch(cb[, context]) to $watch(cb, [context])

Description

Code sample

Coverage remained the same at 93.852% when pulling e78a44634169aef8560a6c18b5f6f6c80178213a on Vrijraj:patch-1 into b6dca6ea5a81b3edd44230fb1cb6ca62419f1926 on firebase:master.


Changing theme to solarized is opening desktop app in dark mode instead

I have the solarized dark theme installed and in settings have selected that theme as the user default.
Whenever I open the app, it opens it in dark mode instead of the solarized dark theme. Then I have to go to themes and select the solarized dark again, but in settings it shows that my preference is solarized dark.

Could this have something to do with the app only having dark and light as its options [in the main title bar] until a user installs a new profile? So its only opening with dark or light as an option and then just ignoring the user selection until the user selects another theme from the settings menu bar once a notebook is opened.
Note: this happens whether I open jupyterlab-desktop to home or to a new notebook or to the previous session.

@deepspacewrong in your case you need to turn off JupyterLab theme syncing from the Settings dialog (menu on top right of a window -> Settings). Then your theme selection in the Settings dialog will apply only to desktop app dialogs / titlebar etc.


Add installation instructions to the docs

Put installation instructions into their own .rst file. Move the
overview to its own .rst file and use the sphinx design grid for adding
cards, similar to the ones in Harmonica and Verde.
Relevant issues/PRs:
Fixes #34

Would be nice to change Python 3.6 for Python 3.7 in the docs after #29 is merged.


adding funding

Adding funding sources to the readme file, please add yours if any.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.45%. Comparing base (04b085f) to head (f620e34).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #81   +/-   ##
=======================================
  Coverage   77.45%   77.45%
=======================================
  Files          98       98
  Lines        2404     2404
=======================================
  Hits         1862     1862
  Misses        542      542

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Consider implementing actual html5 components for Fabric elements

You guys use the term "component" a lot, which is unfortunately pretty topical right now and has nothing to do with your use of the term. HTML5 components are a real thing, and it would be nice to see Fabric offer support for them; even non-evergreen browsers can support them by way of frameworks and polyfills like https://www.polymer-project.org/1.0/

This is an option we could consider if there's enough demand. Right now most requests are for React and Angular components, and there are some open source projects started: ng-OfficeUIFabric and react-fabric. If you've been implementing Fabric components in Polymer we'd love to take a look.

I've added this to our roadmap as a potential feature.

I am working on Aurelia component gautamsi/aurelia-OfficeUIFabric
Most work is in dev branch for now. Need to write documentation and API information.
Following is working

Button
List
List Item

List Item Action - so that you can add click events

Persona
SearchBox - with optional Search button  which fires search event on mousedown
Spinner
Overlay (needs improvement)

Wow, nice work @gautamsi! We'll call out your project on our documentation site in an update soon.

thank for the appreciation. I have just merged dev to master, adding NavBar and ContextualMenu https://github.com/gautamsi/aurelia-OfficeUIFabric/pull/1. also has sample page (very ugly for now - now that I have NavBar I can crate multiple views for sample soon:)).

Very nice, @gautamsi ! Aurelia is where it's at right now - Rob E. and crew are doing a stellar job.


Update travis.yml

uncomment codecov

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@e721ee4). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #3   +/-   ##
=========================================
  Coverage          ?   94.18%
=========================================
  Files             ?        2
  Lines             ?      258
  Branches          ?        0
=========================================
  Hits              ?      243
  Misses            ?       15
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e721ee4...67520ee. Read the comment docs.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@e721ee4). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #3   +/-   ##
=========================================
  Coverage          ?   94.18%
=========================================
  Files             ?        2
  Lines             ?      258
  Branches          ?        0
=========================================
  Hits              ?      243
  Misses            ?       15
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e721ee4...67520ee. Read the comment docs.


[bug] Document / Nodes aren't compaction friendly

Please describe the bug
xmlNodePtr instances keep a reference to their Ruby wrapper inside the _private member.  You can see the _private member being set to the wrapping Ruby instance here.
After it's been wrapped, the instance is optionally stored in an array that is kept on the associated document.  You can see the array push here.
Ruby arrays are compaction friendly.  When the compactor runs, elements inside the array are allowed to move because the array knows how to update its own references.  However, Nokogiri's XML nodes are not compaction friendly.  They don't know to update their references.  Normally this isn't a problem because objects are required to call rb_gc_mark on their references, and rb_gc_mark will pin the references.  The xmlNodePtr instance references the Ruby wrapper, but since the Ruby wrapper is allowed to move, the _private pointer can go bad when compaction runs.
Help us reproduce what you're seeing
require "nokogiri"

big_doc = "<root>#{("a".."zz").map { |x| "<#{x}>#{x}</#{x}>" }.join}</root>"
doc = Nokogiri.XML(big_doc)
doc.root.children.each do |child|
  child
end

GC.verify_compaction_references(double_heap: true, toward: :empty)

doc.root.children.each do |child|
  p child
end

This script will SEGV because the node objects move, and then we try to reference them.
Expected behavior
It shouldn't segv.
Possible Fixes
I'm not 100% sure how we should go about fixing this.  This patch fixes the above code:
diff --git a/ext/nokogiri/xml_document.c b/ext/nokogiri/xml_document.c
index 134931de..31ddc24d 100644
--- a/ext/nokogiri/xml_document.c
+++ b/ext/nokogiri/xml_document.c
@@ -57,6 +57,9 @@ mark(xmlDocPtr doc)
   if (tuple) {
     rb_gc_mark(tuple->doc);
     rb_gc_mark(tuple->node_cache);
+    for (long i = 0; i < RARRAY_LEN(tuple->node_cache); i++) {
+        rb_gc_mark(rb_ary_entry(tuple->node_cache, i));
+    }
   }
 }

But I don't like this patch.  It means we iterate the array too many times.
I think a better solution is probably to teach Node instances about compaction so that they can update themselves, but that might be a more involved patch.

Ack. I've reproduced. Let's talk tomorrow.

Better patch:
diff --git a/ext/nokogiri/xml_node.c b/ext/nokogiri/xml_node.c
index 14f1a871..aa2c66cb 100644
--- a/ext/nokogiri/xml_node.c
+++ b/ext/nokogiri/xml_node.c
@@ -24,6 +24,20 @@ static void
 _xml_node_mark(xmlNodePtr node)
 {
   xmlDocPtr doc = node->doc;
+
+  // Mark this node's wrapper object.  This is very silly because the mark
+  // callback is only firing because this node has been marked.  Marking
+  // ourselves won't cause an infinite loop (the GC handles that), but the
+  // reason we're calling `rb_gc_mark` is to pin the wrapper object.
+  // These nodes are normally marked via an Array stored on the document,
+  // and since Ruby Arrays allow their contents to move, then the wrapper
+  // object was allowed to move too.  That means the reference in `_private`
+  // could go bad (since we don't update references yet)
+  // Calling `rb_gc_mark` here will pin the wrapper object.  Though really
+  // we should update this object to support compaction and update references
+  // accordingly.
+  rb_gc_mark(node->_private);
+
   if (doc->type == XML_DOCUMENT_NODE || doc->type == XML_HTML_DOCUMENT_NODE) {
     if (DOC_RUBY_OBJECT_TEST(doc)) {
       rb_gc_mark(DOC_RUBY_OBJECT(doc));

Still not ideal, but better than the patch above.  I think ideally we should add compaction support.  The first step toward that would be switching from DataWrapStruct to the typed version so we can provide a compaction callback.

I've been able to reliable track the 1.13.6 -> 1.13.7 update to a segfault whilst using creek 2.5.3  I haven't been able to reproduce is reliably on every run, unfortunately, and the trace is a little different every time.  Would you like me to make an issue? Otherwise, I'm just sticking this comment here in case it helps a future googler.

@bf4 Yes, please open an issue. I also commented on the upstream issue.

@bf4 a script that will reproduce this, even if intermittently, would be extremely valuable. I know nothing about Creek.

Better patch:
diff --git a/ext/nokogiri/xml_node.c b/ext/nokogiri/xml_node.c
index 14f1a871..aa2c66cb 100644
--- a/ext/nokogiri/xml_node.c
+++ b/ext/nokogiri/xml_node.c
@@ -24,6 +24,20 @@ static void
 _xml_node_mark(xmlNodePtr node)
 {
   xmlDocPtr doc = node->doc;
+
+  // Mark this node's wrapper object.  This is very silly because the mark
+  // callback is only firing because this node has been marked.  Marking
+  // ourselves won't cause an infinite loop (the GC handles that), but the
+  // reason we're calling `rb_gc_mark` is to pin the wrapper object.
+  // These nodes are normally marked via an Array stored on the document,
+  // and since Ruby Arrays allow their contents to move, then the wrapper
+  // object was allowed to move too.  That means the reference in `_private`
+  // could go bad (since we don't update references yet)
+  // Calling `rb_gc_mark` here will pin the wrapper object.  Though really
+  // we should update this object to support compaction and update references
+  // accordingly.
+  rb_gc_mark(node->_private);
+
   if (doc->type == XML_DOCUMENT_NODE || doc->type == XML_HTML_DOCUMENT_NODE) {
     if (DOC_RUBY_OBJECT_TEST(doc)) {
       rb_gc_mark(DOC_RUBY_OBJECT(doc));

Still not ideal, but better than the patch above.  I think ideally we should add compaction support.  The first step toward that would be switching from DataWrapStruct to the typed version so we can provide a compaction callback.

X


Move scaffold commands

Fixes #270.
Moves the Scaffolding commands out of Storm, and into the modules that the scaffold generates code for.
As discussed in the issue above, this makes more sense to keep Storm agnostic, and allows for the commands to be hidden if a particular module is not used in a Winter instance.

Thanks @bennothommo!


NFS volume mount causes kernel panic and system reboot.

Description
After updating from flatcar 3227.2.1 (kernel version 5.15.58-flatcar) to flatcar 3227.2.4 (kernel 5.15.70-flatcar) an issue regarding mounting NFS volumes surfaced, where kernel panics in mount and results in a system reboot.
Impact
Node's that mount NFS volumes at startup can fail and keep spinning
Environment and steps to reproduce
We use the following systemd mount unit:
[Unit]
Description=Mounts matchbox's nfs folder
[Mount]
Type=nfs
What=${host}:/matchbox
Where=/var/lib/matchbox

To mount an NFS volume for a matchbox server at boot. After flatcar image update we observed very frequent kernel panics and node reboots with the following trace:
[  OK  ] Stopped CoreOS matchbox Server.[  234.406679] RAX:<PHONE_NUMBER>3c6548 RBX: ffffafe940aefb90 RCX: ffff978d1beb6000
DX: ffff978d1beb6000 RSI:<PHONE_NUMBER>3c6548 RDI: ffff978d043e4c78
[  234.406681] RBP: ffffafe940aefb80 R08:<PHONE_NUMBER>000401 R09: ffff978d2ddd4800
[  234.406682] R10:<PHONE_NUMBER>000000 R11: 61c8864680b583eb R12:<PHONE_NUMBER>000000
[  234.406683] R13:<PHONE_NUMBER>000002 R14:<PHONE_NUMBER>000001 R15: ffff978d043e4c78
[  234.406684] FS:  00007fc005986740(0000) GS:ffff979c41500000(0000) knlGS:0000000000000000
[  234.406704] CS:  0010 DS: 0000 ES: 0000 CR0:<PHONE_NUMBER>050033
[  234.406705] CR2:<PHONE_NUMBER>3c657c CR3:<PHONE_NUMBER>4ea003 CR4:<PHONE_NUMBER>3706e0
[  234.406706] DR0:<PHONE_NUMBER>000000 DR1:<PHONE_NUMBER>000000 DR2:<PHONE_NUMBER>000000
[  234.406707] DR3:<PHONE_NUMBER>000000 DR6: 00000000fffe0ff0 DR7:<PHONE_NUMBER>000400
[  234.406708] Call Trace:
[  234.406709] <TASK>
[  234.406712]  ? nfs4_have_delegation+0x24/0x60 [nfsv4]
[  239.789250]  nfs_scan_commit+0x3a/0xb0 [nfs]
         Starting CoreOS matchbox Serve[  240.011463]  nfs_generic_commit_list+0x1f8/0x270 [nfs]
r...
[  240.277477]  ? nfs_access_get_cached+0x20f/0x400 [nfs]
[  240.277486]  nfs_wb_all+0xae/0xf0 [nfs]
[  240.277515]  nfs4_inode_return_delegation+0x58/0x90 [nfsv4]
[  241.025398]  nfs4_set_rw_stateid+0x32a/0x4670 [nfsv4]
[  241.025428]  nfs_async_rename+0x220/0x2b0 [nfs]
[  241.025458]  nfs_rename+0xb3/0x330 [nfs]
[  241.530984]  ? __cond_resched+0x16/0x50
[  241.530988]  vfs_rename+0x888/0xbe0
[  241.530992]  ? lookup_dcache+0x3e/0x60
[  241.571498]  do_renameat2+0x35d/0x510
[  241.571502]  __x64_sys_renameat+0x45/0x60
[  241.571505]  do_syscall_64+0x38/0x90
[  241.571507]  entry_SYSCALL_64_after_hwframe+0x61/0xcb
[  241.571509] RIP: 0033:0x7fc0059de37a
[  241.571511] Code: 48 8b 15 f1 6a 16 00 f7 d8 64 89 02 b8 ff ff ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 49 89 ca b8 08 01 00 00 0f 05 <48> 3d 00 f0 ff ff 77 06 c3 0f 1f 44 00 00 48 8b 15 b9 6a 16 00 f7
[  241.571513] RSP: 002b:00007ffd779a00c8 EFLAGS: 00000246 ORIG_RAX:<PHONE_NUMBER>000108
[  241.571533] RAX: ffffffffffffffda RBX: 00007ffd779a00e0 RCX: 00007fc0059de37a
[  241.571534] RDX: 00000000ffffff9c RSI: 00007ffd779a00e0 RDI: 00000000ffffff9c
[  241.571535] RBP: 00000000ffffff9c R08:<PHONE_NUMBER>000000 R09: 0000561f83ae0430
[  241.571536] R10: 00007ffd779a1e71 R11:<PHONE_NUMBER>000246 R12: 00007ffd779a1e68
[  241.571537] R13: 00007ffd779a1e71 R14: 00007ffd779a1e68 R15:00007ffd779a00e0
[  241.571539]  </TASK>

Followed by a system reboot:
[  241.775126] Modules linked in: ip_vs nft_chain_nat xt_MASQUERADE nf_nat nf_conntrack_netlink xfrm_user xfrm_algo xt_addrtype rpcsec_gss_krb5 auth_rpcgss nfsv4 nft_counter nfs xt_conntrack nf_conntrack lockd grace nf_defrag_ipv6 nf_defrag_ipv4 nft_compat sunrpc nf_tables nfnetlink fscache netfs coretemp dummy hwmon intel_rapl_msr bonding intel_rapl_common ipmi_ssif iTCO_wdt watchdog x86_pkg_temp_thermal iTCO_vendor_support acpi_ipmi ipmi_si kvm_intel i2c_i801 mei_me ipmi_devintf evdev i2c_smbus kvm i2c_core irqbypass mei hpilo ipmi_msghandler button sch_fq_codel fuse configfs squashfs loop ext4 crc16 mb cache jbd2 mlx4_en uhci_hcd xhci_pci ehci_pci nvme ehci_hcd xhci_hcd ahci aesni_intel libahci nvme_core libaes t10_pi crypto_simd usbcore crc_t10dif crct10dif_generic mlx4_core libata cryptd crct10dif_com mon usb_common btrfs blake2b_generic xor zstd_compress lzo_compress raid6_pq libcrc32c crc32c_generic crc32c_intel dm_mirror dm_region_hash dm_log dm_mod qla4xxx iscsi_boot_sysfs iscsi_tcp
[  OK    241.775216]  libiscsi_tcp libiscsi scsi_transport_iscsi scsi_mod scsi_common br_netfilter bridge stp llc overlay
[  242.429677] CR2:<PHONE_NUMBER>3c657c
[  242.429679] ---[ end trace 8b17567b0c11f3d4 ]---
[  242.434393] RIP: 0010:__mutex_lock.constprop.0+0xb7/0x490
[  243.120117] Code: 41 5c 41 5d 41 5e 41 5f c3 cc cc cc cc 65 48 8b 04 25 c0 bb 01 00 48 8b 00 a8 08 75 1d 49 8b 07 48 83 e0 f8 0f 84 fb 02 00 00 <8b> 50 34 85 d2 0f 85 de 02 00 00 e8 19 38 89 ff 65 48 8b 04 25 c0
[  243.120119] RSP: 0018:ffffafe940aefae8 EFLAGS: 00010206
[  243.120121] RAX:<PHONE_NUMBER>3c6548 RBX: ffffafe940aefb90 RCX: ffff978d1beb6000
[  243.120122] RDX: ffff978d1beb6000 RSI:<PHONE_NUMBER>3c6548 RDI: ffff978d043e4c78
[  243.120123] RBP: ffffafe940aefb80 R08:<PHONE_NUMBER>000401 R09: ffff978d2ddd4800
[  243.120124] R10:<PHONE_NUMBER>000000 R11: 61c8864680b583eb R12:<PHONE_NUMBER>000000
[  243.120125] R13:<PHONE_NUMBER>000002 R14:<PHONE_NUMBER>000001 R15: ffff978d043e4c78
[  243.120126] FS:  00007fc005986740(0000) GS:ffff979c41500000(0000) knlGS:0000000000000000
[  243.120145] CS:  0010 DS: 0000 ES: 0000 CR0:<PHONE_NUMBER>050033
[  243.120146] CR2:<PHONE_NUMBER>3c657c CR3:<PHONE_NUMBER>4ea003 CR4:<PHONE_NUMBER>3706e0
[  243.120147] DR0:<PHONE_NUMBER>000000 DR1:<PHONE_NUMBER>000000 DR2:<PHONE_NUMBER>000000
[  243.120148] DR3:<PHONE_NUMBER>000000 DR6: 00000000fffe0ff0 DR7:<PHONE_NUMBER>000400
[  243.120149] Kernel panic - not syncing: Fatal exception
[  243.158564] Kernel Offset: 0xc000000 from 0xffffffff81000000 (relocation range: 0xffffffff80000000-0xffffffffbfffffff)
[  248.769671] Rebooting in 60 seconds..

Expected behavior
The above did not surface before bumping to the latest flatcar image (3227.2.4) and we should expect simple NFS mounts to work without any issue.
Additional information
The above seems similar with the issue described here<EMAIL_ADDRESS>which should be addressed by the following commit: https://github.com/torvalds/linux/commit/6e176d47160c. This looks available to kernel versions >=5.16.

hi @ffilippopoulos,
would you be able to check beta (3402.1.0 or 3374.1.1)? Beta has an updated kernel, that should contain a backport of that fix. This kernel will be in stable in the next stable release.

@jepio nice! thanks for the quick response. I will have a go with the beta image and report back here

Trying with the latest beta image (3402.1.0) I cannot reproduce it. I will soak it in one of our lower environments for a while. Shall we leave the issue open until the fix is included in the stable channel?

Hi,
Yes, let's keep this issue open until it lands on stable for tracking purposes and references in case other users hit the issue.

I think the fixed stable 3374.2.0 has been released

I can confirm that I've updated affected nodes to 3374.2.3 and cannot see the issue. We can probably close this one now :+1:

Thanks for checking!


ContentDialog occupies space in a StackPanel

Describe the bug
When putting ContentDialog in a StackPanel, it occupies vertical and horizontal space when it shouldn't. This happens exclusively with controls resources version 2
Steps to reproduce the bug

Add WinUI 2.6 to a blank app
Replace the placeholder Grid with the following in MainPage<StackPanel>
    <ContentDialog />
    <Button>This should be at the top-right</Button>
</StackPanel>

Expected behavior
The ContentDialog should not take any vertical space in the StackPanel
Screenshots
Good behavior, no WinUI installed

Good behavior, WinUI 2.6 and controls resource version 1

Bad behavior, WinUI 2.6 and controls resource version 2

Version Info

NuGet package version:
[Microsoft.UI.Xaml 2.6.1]

Windows app type:

UWP
Win32

Yes
Yes (system XAML islands)

Windows version
Saw the problem?

Insider Build (22000.132)
Yes

May 2021 Update (19043)

October 2020 Update (19042)

May 2020 Update (19041)

November 2019 Update (18363)

May 2019 Update (18362)

October 2018 Update (17763)

April 2018 Update (17134)

Fall Creators Update (16299)

Creators Update (15063)

Device form factor
Saw the problem?

Desktop
Yes

Xbox

Surface Hub

IoT

Additional context
Same happens when the StackPanel uses Horizontal layout

Somehow this got lost in the move to the v2 style

@tashatitova looks like that happened here: https://github.com/microsoft/microsoft-ui-xaml/commit/67bb9672e3b0c240b6f6a38045198a4afb4b53b4 do you happen to remember why it was removed?

Unless someone else wants to work on this, I would take this issue.

@StephenLPeters looks accidental, shouldn't have been removed


add more sptp tests

Summary: Improve test coverage for sptp codebase.
Differential Revision: D43465615

Codecov Report
Base: 56.64% // Head: 57.43% // Increases project coverage by +0.79% :tada:

Coverage data is based on head (9c5e650) compared to base (73f207e).
Patch coverage: 74.35% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #260      +/-   ##
==========================================
+ Coverage   56.64%   57.43%   +0.79%
==========================================
  Files         125      125
  Lines       11281    11292      +11
==========================================
+ Hits         6390     6486      +96
+ Misses       4358     4265      -93
- Partials      533      541       +8

Impacted Files
Coverage Δ

ptp/sptp/client/sptp.go
32.68% <71.42%> (+14.94%)
:arrow_up:

ptp/sptp/client/config.go
82.35% <100.00%> (+82.35%)
:arrow_up:

ptp/sptp/client/stats.go
84.61% <0.00%> (+41.53%)
:arrow_up:

ptp/sptp/client/json_stats.go
46.87% <0.00%> (+46.87%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Specification for: Typography

Design tasks

Design is fully specified in Figma
Sizes is defined:

Heading

Font-size
Line-height
Weight

Heading - xlarge (h1)
f5
1.3
Medium

Heading - large (h2)
f4
1.3
Medium

Heading - medium (h3)
f3
1.3
Medium

Heading - small (h4)
f2
1.3
Medium

Heading - xsmall (h5)
f1
1.3
Medium

Heading - xxsmall (h6)
f0
1.3
Medium

Ingress

Font-size
Line-height
Weight

Ingress - medium
f1
1.6
Regular

Paragraph

Font-size
Line-height
Weight

Paragraph - large
f1
1.5
Regular

Paragraph - medium
f0
1.5
Regular

Paragraph - small
f-1
1.5
Regular

Paragraph - xsmall
f-2
1.5
Regular

Label

Font-size
Line-height
Weight

Label - large
f1
1.3
Medium

Label - medium
f0
1.3
Medium

Label - small
f-1
1.3
Medium

Label - xsmall
f-2
1.3
Medium

Error message

Font-size
Line-height
Weight

Error message - medium
f0
1.3
Medium

Error message - small
f-1
1.3
Medium

Development Tasks
### Related tasks
- [ ] https://github.com/digdir/designsystem/issues/364
- [x] Make sure all variants/properties is possible to turn on/off
- [x] Make sure the component is usable across different breakpoints/screen sizes
- [ ] https://github.com/digdir/designsystem/issues/498
- [ ] https://github.com/digdir/designsystem/issues/472

I guess Typography is done then 🎉
Thanks for adding the correct spacings @framitdavid 🙌


Update SDK version to latest

The JS SDK got some major updates in the V6 release which occured right around the time you released this plugin. Additionally, in support of the rebranding mentioned in #8, V7 was released yesterday.
There are a lot of changes in V6 from V5, but the Upgrade guide should cover just about all of them.
Thanks for all your efforts on this plugin!

I think this will be the main focus of the next release - thanks for the link to the upgrade guide @ChristopherJennings.
Once that is done I will likely look to support the latest version of Gridsome, which also dropped recently.


Broccoli Fingerprint Plugin with jquery.mark.es6.js

I am using this with Ember-CLI 2.14.x. Added

app.import('bower_components/mark.js/dist/jquery.mark.es6.js', {type: 'vendor'});

in ember-cli-build development mode $ ember s works fine, but when I compile application for production $ ember b -prod it give following errors

The Broccoli Plugin: [Fingerprint] failed with:
SyntaxError: Invalid assignment
    at JS_Parse_Error.get (eval at <anonymous> (/Users/aamir/Work/htdocs/LP/EmberNew/node_modules/uglify-js/tools/node.js:27:1), <anonymous>:86:23)
    at new BroccoliBuildError (/Users/aamir/Work/htdocs/LP/EmberNew/node_modules/broccoli-builder/lib/broccoli-build-error.js:18:29)
    at /Users/aamir/Work/htdocs/LP/EmberNew/node_modules/broccoli-builder/lib/builder.js:168:19
    at tryCatch (/Users/aamir/Work/htdocs/LP/EmberNew/node_modules/rsvp/dist/rsvp.js:525:12)
    at invokeCallback (/Users/aamir/Work/htdocs/LP/EmberNew/node_modules/rsvp/dist/rsvp.js:538:13)
    at publish (/Users/aamir/Work/htdocs/LP/EmberNew/node_modules/rsvp/dist/rsvp.js:508:7)
    at publishRejection (/Users/aamir/Work/htdocs/LP/EmberNew/node_modules/rsvp/dist/rsvp.js:443:3)
    at flush (/Users/aamir/Work/htdocs/LP/EmberNew/node_modules/rsvp/dist/rsvp.js:2400:5)
    at _combinedTickCallback (internal/process/next_tick.js:95:7)
    at process._tickCallback (internal/process/next_tick.js:161:9)

The broccoli plugin was instantiated at:
    at Fingerprint.Plugin (/Users/aamir/Work/htdocs/LP/EmberNew/node_modules/broccoli-plugin/index.js:7:31)
    at Fingerprint.Filter [as constructor] (/Users/aamir/Work/htdocs/LP/EmberNew/node_modules/broccoli-filter/index.js:34:10)
    at new Fingerprint (/Users/aamir/Work/htdocs/LP/EmberNew/node_modules/broccoli-asset-rev/lib/fingerprint.js:27:10)
    at Fingerprint (/Users/aamir/Work/htdocs/LP/EmberNew/node_modules/broccoli-asset-rev/lib/fingerprint.js:22:12)
    at new AssetRev (/Users/aamir/Work/htdocs/LP/EmberNew/node_modules/broccoli-asset-rev/lib/asset-rev.js:27:25)
    at AssetRev (/Users/aamir/Work/htdocs/LP/EmberNew/node_modules/broccoli-asset-rev/lib/asset-rev.js:7:12)
    at Class.postprocessTree (/Users/aamir/Work/htdocs/LP/EmberNew/node_modules/broccoli-asset-rev/index.js:31:40)
    at projectOrAddon.addons.reduce (/Users/aamir/Work/htdocs/LP/EmberNew/node_modules/ember-cli/lib/utilities/addon-process-tree.js:6:25)
    at Array.reduce (native)
    at addonProcessTree (/Users/aamir/Work/htdocs/LP/EmberNew/node_modules/ember-cli/lib/utilities/addon-process-tree.js:4:32)

Steps to reproduce

$ npm i -g ember-cli
$ ember new dummy-app
$ cd dummy-app
$ bower install mark.js --save-dev

add
  app.import('bower_components/mark.js/dist/jquery.mark.es6.js', {type: 'vendor'});

in ember-cli-build.js on root in module.export to include this file in broccoli
$ ember b -prod

Environment

Chrome Version 60.0.3112.90 (Official Build) (64-bit)
mark.js v8.11.0

Other Feedback
I have changed   app.import('bower_components/mark.js/dist/jquery.mark.es6.js', {type: 'vendor'}); to   app.import('bower_components/mark.js/dist/jquery.mark.js', {type: 'vendor'}); for now and it is working fine

Hi @aalasolutions,
Thanks for submitting.
From what I'm seeing you're importing the ES6 version of mark.js and you're using UglifyJS, probably only in production. You should only use the ES6 version if you're compiling it to ES5 before passing it along to UglifyJS. Otherwise it'll fail, as Uglify only support ES6 in the harmony branch currently (ref).
In summary, using the ES5 version is recommended in your build process, as it seems that you're not transpiling ES6 code.


Add indirect draw example

[x] Added an entry to CHANGELOG_VULKANO.md or CHANGELOG_VK_SYS.md if knowledge of this change could be valuable to users
[x] Updated documentation to reflect any user-facing changes - in this repository
[x] Updated documentation to reflect any user-facing changes - PR to the guide that fixes existing documentation invalidated by this PR.

This PR adds an example of draw_indirect using a simple compute shader to generate vertices.

This looks really useful, and the comments make it very clear as to what's going on - I'd be happy to see this merged :+1:
@rukai I'm a little unsure how the vulkano examples work - should we be merging them here then moving them to vulkano-examples? Or is the vulkano-examples crate deprecated in favour of ./examples?

Vulkano examples repo is a mirror of ./examples at the time of the last crates.io release.
If your happy with this pr then please merge it.


Notebook object has no attribute inspect

When I try to use the --autoinspect swtich, whenever I try to type something I get the following errors.
I'm using the standard ipython kernel.

Hello!
This is a bug - I've fixed it in 6df0830023f31d6d4a0d8b1cec41c1aeded748ce in dev, and it will be in the next release.

Out of interest, which OS are you using? I ask because the rectangle character the error message should be an expander arrow (⮞ ⮟), but it looks like you don't have a font which provides these characters. I might switch to plain triangles for better compatibility.

This is a bug - I've fixed it in 6df0830 in dev, and it will be in the next release.

Thank you! I'm curious to see what that switch achieves!

Out of interest, which OS are you using?

Arch

I ask because the rectangle character the error message should be an expander arrow (⮞ ⮟), but it looks like you don't have a font which provides these characters. I might switch to plain triangles for better compatibility.

My kitty terminal should use Nerd Fonts, and in theory load from Symbols Nerd Fonts.
I don't know what's happening, I'm not very expert with fonts.

The fix for this is now in v2.2.0


Tags not showing up

Tags & Genre aren't showing at all within detail view after the recent update.
Edit: Solved it myself. Something wasn't installed.

Yeah, the new version uses Metadata Utilities to display tags and similar fields. I'll write a quick tutorial on how to use the extended features that come with the change in the next days.

How did you solve it? I have the same problem, I have Metadata Utilities installed, do I need to do anything else?
In the meantime I will continue with 1.6 because I like the option to show the tags as a box.

How did you solve it? I have the same problem, I have Metadata Utilities installed, do I need to do anything else?
In the meantime I will continue with 1.6 because I like the option to show the tags as a box.

I can only get them to show up as a list. I don't think you can change it back to box, unless there is some way I'm unaware of.

I can only get them to show up as a list. I don't think you can change it back to box, unless there is some way I'm unaware of.
I meant that I don't even have them as a list.

I can only get them to show up as a list. I don't think you can change it back to box, unless there is some way I'm unaware of.

I meant that I don't even have them as a list, how did you get them to show?.
Do you have them checked under settings for details view?

Do you have them checked under settings for details view?

of course, they were showing fine before upgrading

Do I have to do anything extra in metadata utilities?

What version of Metadata Utilities are you using? It has to be at least version 1.3. Apart from that you shouldn't need to do anything.
The option to display the items as a box will return, but I'm not sure when and how I'll implement it, however.

Ah, wait a minute. I have an idea, what's wrong. You have Playnite translated. I think I used the field names for the controls, and it could be that I used the already translated string. That wouldn't work anymore, if tags aren't called tags anymore ;) - I'll open the issue again and work on a fix in the addon and the theme.

Ah, wait a minute. I have an idea, what's wrong. You have Playnite translated. I think I used the field names for the controls, and it could be that I used the already translated string. That wouldn't work anymore, if tags aren't called tags anymore ;) - I'll open the issue again and work on a fix in the addon and the theme.

Yeah, It is the language.

I just fixed it in Metadata Utilities. If everything goes to plan, I'll release the new version later today or tomorrow.

I just fixed it in Metadata Utilities. If everything goes to plan, I'll release the new version later today or tomorrow.

Has been fixed with the update. Thank you.


llama fp8 - enable non reuse cache flow for fp8 (#64)

llama fp8 - enable non reuse cache flow for fp8

remove depracted kv cache fp8 flag
Change-Id: Id76f94a127dee202376e8f27de7b28f58affedae

fixing lm eval

Change-Id: I230fa53e7b49d8bb36397b063f652ba3def84600

remove old quantization mode

Change-Id: I538172f29870311349ed79d928cfacc60fb534e8

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@HolyFalafel There is some overlap between this PR and #780, I see the same changes for --const_serialization_path

@HolyFalafel There is some overlap between this PR and #780, I see the same changes for --const_serialization_path

Yes, in order to avoid merge conflicts, I had to base this commit on top of the commit which is relevant to #780.
So we should merge the other one first.

Hi @HolyFalafel ,
I see that "Code check quality" tests are failing. Could you fix formatting with ruff?
Any ETA to have these changes merged?

Hi @HolyFalafel ,
I see that "Code check quality" tests are failing. Could you fix formatting with ruff? Any ETA to have these changes merged?

We need to merge https://github.com/huggingface/optimum-habana/pull/780 first. I'll try it out with Synapse 1.14 but not sure it will work. If it does I'll merge it, ortherwise we'll need to wait for the release of Synapse 1.15.

@HolyFalafel We'll merge this PR in the synapse_1.15 branch but there are merge conflicts. I think it's due to the upgrade to Transformers 4.38, can you check please?


Error while turn off command

Describe the issue
On running on automation - tv don't turn off and there is an error in homeassistant log.
Expected behavior
TV is turned off, but home assistant try to turn it off with this error.
Home Assistant version
0.110.4
Output of HA logs
Traceback (most recent call last):
  File "/srv/homeassistant/lib/python3.7/site-packages/homeassistant/helpers/script.py", line 153, in _async_step
    self, f"_async_{cv.determine_script_action(self._action)}_step"
  File "/srv/homeassistant/lib/python3.7/site-packages/homeassistant/helpers/script.py", line 623, in _async_call_service_step
    *self._prep_call_service_step(), blocking=True, context=self._context
  File "/srv/homeassistant/lib/python3.7/site-packages/homeassistant/core.py", line 1253, in async_call
    task.result()
  File "/srv/homeassistant/lib/python3.7/site-packages/homeassistant/core.py", line 1288, in _execute_service
    await handler.func(service_call)
  File "/srv/homeassistant/lib/python3.7/site-packages/homeassistant/helpers/entity_component.py", line 213, in handle_service
    self._platforms.values(), func, call, required_features
  File "/srv/homeassistant/lib/python3.7/site-packages/homeassistant/helpers/service.py", line 454, in entity_service_call
    future.result()  # pop exception if have
  File "/srv/homeassistant/lib/python3.7/site-packages/homeassistant/helpers/entity.py", line 597, in async_request_call
    await coro
  File "/srv/homeassistant/lib/python3.7/site-packages/homeassistant/helpers/service.py", line 485, in _handle_entity_call
    await result
  File "/srv/homeassistant/lib/python3.7/site-packages/homeassistant/components/media_player/__init__.py", line 530, in async_turn_off
    await self.hass.async_add_job(self.turn_off)
  File "/usr/lib/python3.7/concurrent/futures/thread.py", line 57, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/home/homeassistant/.homeassistant/custom_components/braviatv_psk/media_player.py", line 516, in turn_off
    self._braviarc.turn_off()
  File "/srv/homeassistant/lib/python3.7/site-packages/braviapsk/sony_bravia_psk.py", line 355, in turn_off
    self.send_req_ircc(self.get_command_code('PowerOff'))
  File "/srv/homeassistant/lib/python3.7/site-packages/braviapsk/sony_bravia_psk.py", line 282, in get_command_code
    self._refresh_commands()
  File "/srv/homeassistant/lib/python3.7/site-packages/braviapsk/sony_bravia_psk.py", line 273, in _refresh_commands
    if not resp.get('error'):
AttributeError: 'NoneType' object has no attribute 'get'

Does it work when you turn of the TV with the power button on the Lovelace card?
And please share the automation you are using for this.

I cannot turn it off - cause it is already off ;)
Here is the automation:
`- id: '1590434928904'
alias: Opuszczenie domu
description: ''
trigger:

device_id: fc2850d648524e73baed22699c6c7767
domain: binary_sensor
entity_id: binary_sensor.czujnik_drzwi
platform: device
type: turned_off
condition:
condition: device
device_id: 656548ee624e4edba2868b823f9b5ae9
domain: switch
entity_id: switch.przedpokoj_dol
type: is_on
action:
scene: scene.zamknij_rolety
scene: scene.zgas_swiatla
device_id: 656548ee624e4edba2868b823f9b5ae9
domain: switch
entity_id: switch.przedpokoj_dol
type: turn_off
data: {}
entity_id: media_player.sonysalon
service: media_player.turn_off
data: {}
entity_id: media_player.sonysypialnia
service: media_player.turn_off
data:
option: Poza domem
entity_id: input_select.stan_domu
service: input_select.select_option`

I cannot turn it off - cause it is already off ;)

Not sure what you mean with this? That's not an answer to my question above is it?
And if the TV is on, can you then turn it off using media_player.turn_off in /developer-tools/service of Home Assistant?

You are right, my mistake, misunderstood Your question ;)
Yes, when it is turn on - i can turn it off correctly. I can also correctly turn it on from hass.

I checked and I get the same error when trying to turn of the TV using the media_player.turn_off command when the TV is already off.
I will make a new release which checks if the TV is off and in that case it wont send another off command. That prevents the error from happening.
In the meanhwile you can add a condition to your automation to only switch off the TV when it's actually on.

Will be fixed in #40


react-application-tenant-global-navbar gulp serve not working. Cannot find manifests.js

Category

[ ] Question
[X] Bug
[ ] Enhancement

Expected or Desired Behavior
When appending the query string to a SharePoint site, the react-application-tenant-global-navbar extension being served should render
Observed Behavior
I receive an error that manifests.js is not accessible.

Steps to Reproduce

Clone this repository
cd samples/react-application-tenant-global-navbar
npm i
gulp serve --nobrowser
open a modern SharePoint site (communication site in my instance) append ?loadSPFX=true&debugManifestsFile=https://localhost:4321/temp/manifests.js&customActions={"b1efedb9-b371-4f5c-a90f-3742d1842cf3":{"location":"ClientSideExtension.ApplicationCustomizer","properties":{"TopMenuTermSet":"TenantGlobalNavBar","BottomMenuTermSet":"TenantGlobalFooterBar"}}} to the URL

Node version is: 8.11.3

I often get that - and it's due to either CHROME - or Kaspersky (AV block).
Can you browse to the file on it's own - in another tab :    https://localhost:4321/temp/manifests.js

I have the same error and in the command line the following error apears:
Error: ENOENT: no such file or directory, stat 'C:\Data\Dev\SharePoint Online\react-application-tenant-global-navbar\dist\public\temp\manifests.js'
The path \dist\public\temp\workbench.htm does not exists. The correct path should be only \temp\manifests.js.
Any ideas what's going wrong here?

I often get that - and it's due to either CHROME - or Kaspersky (AV block).
Can you browse to the file on it's own - in another tab : https://localhost:4321/temp/manifests.js

Same error by browse direct to https://localhost:5432/temp/manifest.js. The error disapears if I manuelly copy the temp folder to \dist\public, but this couldn't be the solution and I ran directly into another error.
The serve.json of the repo looks like the following:
 { "$schema": "https://dev.office.com/json-schemas/core-build/serve.schema.json",   "port": 4321,   "initialPage": "https://localhost:5432/workbench",   "https": true,   "api": {     "port": 5432,     "entryPath": "node_modules/@microsoft/sp-webpart-workbench/lib/api/"   } }
I don't understand why @thomasberman tries to use port 4321, but maybe he changed the serve.json config!?

@thomasberman did you ever resolve this issue?
I'll go ahead and close this due to the lack of activity, but feel free to re-open an issue if you still need help.


How to implement multi-client

How to implement multi-client？
If multiple clients are connected at the same time, how can messages be sent to only one client？

SubscriptionInterceptor ，I think I understand


TODO

Development Todo list
UI:

[ ]  Home tab | Make change item image function in a hidden view (enable  via button)
[ ] All tabs | make scan button less
[ ] Login needs to show error messages

Advanced:

[ ] Add function to create and maintain users
[ ] Add database export function
[ ]

Closing as it's obsolete


fix path and performance issues with example notebook

Added 'usecols` option to speed up pandas loading CSV.

Thanks!


Unable to run https://localhost -> The site cannot be reached .

Checklist

Have you pulled and found the error with jc21/nginx-proxy-manager:latest docker image?

Yes

Are you sure you're not using someone else's docker image?

Yes

Have you searched for similar issues (both open and closed)?

Yes

Describe the bug
Unable to access nginx-proxy-manager on 443.
docker-compose up -d

Nginx proxy is running on ports 80, 81 and 443.

however, when you attempt to reach to  https://localhost it timeout.
However, the  http scheme works perfectly fine.
Nginx Proxy Manager Version
latest
To Reproduce
Steps to reproduce the behavior:
as stated in the description
Expected behavior
should be able to access in https port even if it is self-signed cert
Screenshots
screenshot is from viewing from another machine in the same network.

Operating System
Ubuntu
Additional context
N/A

Hi @bluekitedreamer!

Are you able to access the NPM dashboard at :81?

Yes, I could access the NPM dashboad at http://localhost:81

Also have you put in your own self-signed cert?

Oh! I did not do that. I thought NPM would automatically do that for me. Can you point me to the documentation on how could specify the self-signed certs in the docker-compose.yml?

closing this as this is a duplicate of https://github.com/NginxProxyManager/nginx-proxy-manager/issues/2742