[Alerting V2 UI] Basic Configuration

Basic Configuration
General

Header / Label Name
k8s YAML
Description
Input
Default

Deploy AlertManager
alertmanager.enabled
N/A
boolean
true

Configuration
There should be a radio button that says Use Existing Secret for Config (Enabled or Disabled, where the default is Disabled) that exposes the following fields and is tied to the value alertmanager.alertmanagerSpec.useExistingSecret.
There should also be the following help text underneath it:
It is recommended for a user to use an Existing Secret within the namespace `cattle-monitoring-system` for the AlertManager Config in order to avoid having to to manage the Secret via Helm. Using the default Helm managed Secret will require a user to redeploy the chart in order to persist any changes to the AlertManager configuration on a `helm upgrade` while using an existing Secret will allow a user to directly modify the secret to perform live updates on the AlertManager configuration if necessary.

If Enabled is selected (if the namespace does not currently exist, the user should be notified that they need to create the namespace and a secret within it to use this option):

Header / Label Name
k8s YAML
Description
Input
Default

Config Secret
alertmanager.alertmanagerSpec.configSecret
N/A
Ability to select Secret in cattle-monitoring-system namespace
null

If Disabled is selected:

Header / Label Name
k8s YAML
Description
Input
Default

AlertManager Config
alertmanager.config
N/A
YAML
Should be the same as the default on the values.yaml

Template Files
alertmanager.templateFiles
N/A
Ability to supply multiple key-value pairs where the key is a filename and the value is a YAML string
Should be the same as the default on the values.yaml

The following fields should be available regardless of the option selected:

Header / Label Name
k8s YAML
Description
Input
Default

Additional Secrets
 alertmanager.alertmanagerSpec.secrets
Mounted on /etc/alertmanager/secrets/
Ability to supply list of secrets
None

Note: In order to allow users to be able to initially deploy a basic AlertManager Config, this ticket currently allows users to provide the AlertManager Config as YAML directly; however, this will need to be updated to a UI that allows users to easily configure the notifiers / routes (similar to Alerting V1).
This work will be tracked in a separate ticket, which will be later linked to this ticket.

Updated Requirements
Annotation: catalog.rancher.io/ui-component: monitoring
Basic Configuration
General

Header / Label Name
k8s YAML
Description
Input
Default

Deploy AlertManager
alertmanager.enabled
N/A
boolean
true

Configuration
There should also be the following help text:
Provide an Existing Secret within the namespace `cattle-monitoring-system` for the AlertManager Config.

To enable modifying the secret using the Dashboard UI, either create the secret using the Dashboard UI or add the label `alertmanager_config` to the secret.

Header / Label Name
k8s YAML
Description
Input
Default

N/A
alertmanager.alertmanagerSpec.useExistingSecret
N/A
N/A
true

Config Secret
alertmanager.alertmanagerSpec.configSecret
N/A
Ability to select Secret in cattle-monitoring-system namespace
null

Additional Secrets
 alertmanager.alertmanagerSpec.secrets
Mounted on /etc/alertmanager/secrets/
Ability to supply list of secrets
None

All other items are being tracked inthe other ticket so closing this one


Add Ryan and Carrie to PSC

This pull request updates the PSC to add our newest members.

Looks good. Approved.


The ability to load last session if there is no session for the current directory

At the moment, if the session for the current folder was not found, then a new session is started. But this is not always convenient, because Neovim can be launched from the GUI, for example. It would be awesome to load last session if there is no saved session for the current directory.

I think this can be an option to be set for sure.
I personally prefer the current behaviour but I can see why you'd want the behaviour you mentioned too.
I'll cook something up for this. Thanks for bringing it up!


[Q] Analyze Plugin  pes-stream-id forTeletext

When PES carries Teletext, am i wrong or the pes-stream-type at the output of "analyze" plugin should be private_stream_1?

The plugin analyze outputs what the stream contains. Looking at some streams in the repository, Teletext streams have private 1 as stream id, indeed. I do not know if other values are valid or not.

I think the issue was a txt PID declared but with 0 bps.

I think the issue was a txt PID declared but with 0 bps.

The stream id is extracted from the PES header, it cannot be found in the signalisation. So, indeed, 0 pbs = 0 packet = unknown stream id.

Yes of course. Didn't notices there were 0 packets is that PID. Sorry...


Not working on swift 2.0?

I'm using Xcode 7 (Version 7.0.1 (7A1001)) with latest swift but it doesn't seem to want compile.
Using =>     pod 'Formulary', '~>' 0.2

It will totally work if you point your pod at the repositories head. I will try and get a release out in the next couple of days.

What would the line on my pod file look like?
I'll try to get a 0.3.0 out this week and you can revert back to referring to the pod as normal.

I'm leaving this issue open until I make a compatible release.
:dancers:

Thank you! Yeah I only needed that line. I knew I could point pods to branch's but I didn't knew that I could point to a specific commit. It's good to know :)

We now have a lovely v0.3.0 release! :tada:


Tab auto complete Issues

Hello,
First of all I just installed powerline and I'm loving it, works really well and was easy to setup,
I have a big host file and used to use auto complete for ssh and telnet.
SSH works, but telnet doesn't.
Thanks

Just due to the age of this issue (sorry :cry: - my fault) I'm going to close it. If you are still out there having this issue, please re-open and we can try to get to the bottom of it.


feat: bump versions

:tada: This PR is included in version 16.4.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


A babel plugin to simplify the API.

Hi~
GlMatrix is a really high-performance JavaScript matrix library, but its API is not easy to use.
So I wrote a babel-plugin to make the API more friendly to users.

That is amazing! 👍  Should the Readme get edited to have a link to that plugin?

Sure :-)

I quite like this too!

Update to 0.5.0
Add an option "glMatrixArray" to specify Array as glMatrix.ARRAY_TYPE instead of Float32Array.
For [#359].


Issue32 ssh setup.3

Here's a bit more sketched-out version of the idea of a top-level send() and receive() API...This PR also takes out the "just invoke 'wormhole send'" part of the other PR.

whoa, did you really get the full test suite to work on pypy? I thought the C code in pynacl was a blocker for that..

I think it's just building the bundled libsodium and using CFFI to call it.

I like it. I want to nit-pick about the implementation, though :). Could you force-push a new branch with the following changes?

rebased to current trunk
move the setup.py change into it's own commit
move the cli/cli.py traceback/Failure into it's own commit
remove the server/cli.py timing changes (I don't think it's useful to measure import timing on the server side, as it doesn't affect operational latency)
move the wormhole.py send()/receive() changes into a new wormhole/xfer_util.py file, and into it's own commit
last commit should be the changes to cli/cli.py that add the new commands, but the bulk of the code should live in cli/cmd_ssh.py, with just the arg-parsing and dispatch happening in cli/cli.py (the idea is that the unit tests can import cmd_ssh instead of import cli)
also the APPID needs to be something different than wormhole send/receive, since there's no interop between wormhole send and wormhole ssh-add. Maybe lothar.com/wormhole/ssh-add. It must be the same for the two sides, of course.

I haven't looked closely at the actual .ssh/authorized_keys -touching parts yet, but we can land the stuff above and then apply more fixes later if necessary.
thanks!

Okay, I can mess about with git rebase soon :)
Obviously, it would be good to have more eyes on the ~/.ssh/*-touching parts since that's the meat of this thing ;)

Let's see:

we could bikeshed on the existing command names (wormhole ssh-add, wormhole ssh-send) a bit: use a subcommand (wormhole ssh add), use send/receive to make it parallel with file send/receive, maybe find some synonyms (I like "add", but I don't know what the other side should use)
it'd be nice if the ssh commands accepted all the same arguments as send/receive (--verify, -0, etc)
I'm tempted to have the receiving side specify a username, and have it find the matching authorized_keys file. I've got two tentative reasons. 1: if the file doesn't exist already, then .ssh might not exist either, so we need to mkdir that, and we need to set the permissions on the new authorized_keys to make ssh happy, so we need more than just the target filename. 2: there are two main use cases here: either you're logged into your own account (maybe via a temporary password) and you're adding an ssh key from your own machine (so you're the one who will be running ssh-send), or you're logged in as root and you're setting up somebody else's account, in which case we want to make sure it's hard to give root access to your new user by mistake (which would happen if you forgot to provide --auth-file and it defaulted to ~/.ssh/authorized_keys). So if we made username a required positional argument, then that'd make it super-obvious whose shell you're handing out access to
on the sending side, I'd like to find all the .pub files, and have the user choose between them. Or, if there's more than one, then abort. Maybe require a posarg with the right .pub file. I try to use Ed25519 pubkeys, so I don't even have an id_rsa.pub, feels like I don't want that to be hard-coded. I'm not too worried about getting confirmation on the sending side (you aren't giving up any authority by revealing your pubkey), so if there's only one pubkey in the ~/.ssh directory, I'd say send it without confirmation. Not sure whether to have a "select number from list" picker if there's multiple keys, or require a posarg (with the full path to the .pub file) when there are mutiple ones. For sure a bare wormhole send-ssh should Just Work when there's only one pubkey.
the utility function.. should that include a hook to signal an ACK from the far side? making it a send-and-receive utility instead of an unacked send? I don't know if we can use this utility for wormhole send --text, but if so, we'd need an ACK there. (I think wormhole send [file] is going to need much more than this utility, as it grows Transit negotiation and stuff).

As per #32, a name like wormhole ssh copy-id was suggested (to be moar-similar to "ssh copy-id")

--verify is already a top-level option -- should -0 be as well? Should that be re-named something more obviously bad, like --insecure-no-code or something?

I agree about root stuff. How about: if you appear to be root then:

never copy/install keys (or maybe install a key, but only if --allow-root-access or something?)
...unless a --user= option being specified

(Basically I guess that is just "if you're root, you have to specify --user= and it can't be root). Or, just bail out right away with "don't run this as root; switch to the target user first".

For .pub handing, what about:

if there's only one .pub key (and we're not root) send it
if there's more than on .pub key, tell the user to use --auth-file to specify the file to use
if there are zero .pub keys (or no ~/.ssh) tell the user to read about ssh-keygen and try later.

should we consider "invite"/"accept" as the verb pair? something which speaks to the power being granted rather than the (relatively less important) direction of data transfer?
I moved --verify and -0 to be subcommand arguments already (see CommonArgs in src/wormhole/cli/cli.py), along with -c=/--code-length=, --tor, --hide-progress (although that's file-transfer -specific), and --no-listen (which is both file-transfer -specific and is a debug argument that I'd like to hide from the --help output).
I kinda like the "YOLO" brevity implied by -0, but I guess it couldn't hurt to add a long-form name that's more.. discouraging, so if someone is demonstrating it in a slide deck or something, they can point out what it really does. Maybe -0/--unauthenticated? Or -0/--yolo? The help text must explain what is really does, of course.

Re --allow-root-access and --user= .. I guess the question is: what is the majority use case going to be? If we think that "root adds a new account" is the majority, then a mandatory user= positional argument seems promising, so the recommended setup recipe can be:
# adduser --disabled-password warner
# wormhole ssh invite warner
 -> CODE

And if you're logging into your own account and want to add a new key (maybe you used a password the first time, or maybe you logged in from one host and want to add the pubkey of a second host), you do the same:
% wormhole ssh invite warner
 -> CODE

If we think the add-key-to-my-own-account is more likely, then we'd not require the posarg, default to modifying your own .ssh/authorized_keys, add a way to point at the file or the user, and add extra protection against root modifying root's keys.
Re pubkeys: yeah, that plan sounds fine. The only thing I'd add would be to print out the list of discovered pubkeys, if there's more than one. And I think I'd be ok with leaving out a special check to avoid sending root's pubkey (doesn't seem dangerous to me). I might call it -p=/--pub-key= instead of authkey, although I could be swayed otherwise ("pub" matches the source file, "auth" matches the dest file, "key" matches the "ssh-keygen" tool that creates them).
For extra credit we could make it interactive (print a list, assign a number to each, ask the user for the number), but maybe that's too much work.
Unlike text/file sending, the sender doesn't need to confirm the transfer. But the receiver does (at least if --verify is enabled), since it's the receiver who's granting authority by accepting the transfer. Not sure how that might affect the common send/receive utilities.. there might need to be a mode flag that says which direction the verification needs to travel.

Okay, I force-pushed after rebasing and doing the things in https://github.com/warner/magic-wormhole/pull/57#issuecomment-237696556

okay, i made some of the cleanups in the last couple messages from @warner in the last commit on this branch. I moved to "wormhole ssh accept/invite" sub-sub commands, --user, changed method-names, more permissions checks, ask user which key (if there's multiple keys), ...

Current coverage is 86.57% (diff: 46.15%)

Merging #57 into master will decrease coverage by 0.36%

@@             master        #57   diff @@
==========================================
  Files            18         18
  Lines          2694       2718    +24
  Methods           0          0
  Messages          0          0
  Branches        379        380     +1
==========================================
+ Hits           2342       2353    +11
- Misses          257        270    +13
  Partials         95         95

Powered by Codecov. Last update afa123a...fe29b31

Looks good: I made a few tweaks, and I have a list of additional fixes to make later, but I'm going to land this now. Thanks!


[Bug]: Streaming API: Abort functionality not working as expected

🐛 Describe the bug
im encountering an issue with the abort functionality when using streaming from the openai api.
here are the details:
abort requests are not working when streaming is enabled.
even pending requests do not get aborted.
i've added extensive logging, but the abort functionality still fails.
expected behavior: abort requests should work regardless of whether streaming is on or off.
current behavior:
with streaming off: abort functionality works perfectly fine.
with streaming on: abort requests fail to terminate the operation.
additional information:
i've observed code for aborts with its own finish reason.
this code appears to be in place but is not effective when streaming is enabled.
is this a known issue with the streaming api?
thank you. any assistance or insight would be greatly appreciated.

seems that #7111 fixes it


EL-471: Partner results page

Link to the Jira ticket
Adjust results page to show partner fields where relevant
Checklist
Before you ask people to review this PR:
Tests and rubocop should be passing
Github should not be reporting conflicts; you should have recently run git rebase main.
There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
The PR description should say what you changed and why, with a link to the JIRA story.
You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
You should have checked that the commit messages say why the change was made.

As we're now using a lot of functionality that's only available in our fork, I've updated the default CFE URL to our fork, and regenerated all our VCR files accordingly, hence the large number of files here.


DigitalOcean docs use public networking; remove

Per: https://github.com/deislabs/krustlet/pull/497#issuecomment-782246494

Hi @DazWilkin! I appreciate you taking the time to write up a PR for this. However I don't think we should purge all this hard work from the documentation! It's still quite useful for those who want to experiment with Krustlet in a development environment.
What if I wrote some additional documentation around this howto guide explaining it's is a work-in-progress, point out where we need to address some of the security issues, and suggest that community contributions are welcome?

Your earlier feedback was well taken.
I think it's correct (and understandable particularly for Microsoft) that you have the requirement of more stringent security.
I don't mind at all if these are deleted; I think I blogged about running Krustlet on DO and so it's available there.
I agree that it would be better to have someone who's more proficient in DO and Linode to write and maintain (!) these docs.

... and thank you for taking the time to comment.

I agree with @bacongobbler here! I think the work you did is great, we just need to add a bit to clarify that these are completely for development purposes. Someone will surely find these handy


Correct history.js return type annotations

This removes compilation errors related to functions having an "implied any" return type

@jordanpotter thanks mate!

You're very welcome! :smile:


bugfix: regression after feat(#1667): None means None, commit 2569a13…

Description
Fix regression after commit: https://github.com/usebruno/bruno/commit/2569a1389de140a7fdd618bf691ea15b244e7883
It should inherit the auth if auth type is "inherit".
Contribution Checklist:

[X] The pull request only addresses one issue or adds one feature.
[X] The pull request does not introduce any breaking changes
[X] I have added screenshots or gifs to help explain the change if applicable.
[X] I have read the contribution guidelines.
[X] Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.
Publishing to New Package Managers
Please see here for more information.

Duplicate of #2243

Closing due to duplication


Android linking gone

The command react-native link react-native-interactable only links iOS :
rm -fr node_modules
yarn add react-native-interactable
react-native link react-native-interactable

with version 0.1.1

I feel like I have the exact same problem, running on iOS works fine, but Android doesn't work

@Kernael in my case Interactable() wasn't added on getPackages(). Adding that fixed it for me

@lucasstorti @Kernael The issue was the same for me.  I'll add the import so ppl don't have to go look: import com.wix.interactable.Interactable;

doesn't seem to link yet. can someone all the instructions for linking in Android please?

How I solved the react native linking issue. Ensure the following:
In MainApplication.java
import com.wix.interactable.Interactable;
&&
@Override     protected List<ReactPackage> getPackages() {       return Arrays.<ReactPackage>asList(           new Interactable(),           ...
build.gradle (linking on android doesn't add this by default). Add the dependency:
dependencies {     compile project(path: ':react-native-interactable')     ...
setting.gradle (in top level android folder) (the default path when using link isn't correct - need to change it to lib/android)
include ':react-native-interactable' project(':react-native-interactable').projectDir = new File(rootProject.projectDir, '../node_modules/react-native-interactable/lib/android')

Glad I stumbled upon this (after an hour of scratching my head)! Thanks!

Thank you @jamesdyer8

I am closing the issue as a part of an effort to cleanup and revive the project. If this issue persists after v1.0.0, you are more than welcome to reintroduce it.
Thanks for your contribution.

This issue is still existend with RN 0.62.2. Also, since the Package List is Auto-Generated we can not add it there in a convenient way anymore. Any suggestions?


OMJulia not responding with long debug message

When I run the following script
loadModel(Modelica, {"4.0.0"});
getErrorString();

setCommandLineOptions("-d=newinst,backenddaeinfo,dumpSimCode");
getErrorString();

simulate(Modelica.Mechanics.MultiBody.Examples.Systems.RobotR3.FullRobot);
getErrorString();

with omc the total time is around 8 seconds.
When I convert the script to be used in OMJulia it will not finish (at least in an amount I'm willing to wait).
using OMJulia
omc = OMJulia.OMCSession("path/to/omc");
OMJulia.sendExpression(omc, "setCommandLineOptions(\"-d=newInst,dumpSimCode\")")
OMJulia.sendExpression(omc, "loadModel(Modelica)")
msg = OMJulia.sendExpression(omc, "simulate(Modelica.Mechanics.MultiBody.Examples.Systems.RobotR3.FullRobot)");

When I cancle the last command I get
julia> msg = OMJulia.sendExpression(omc, "simulate(Modelica.Mechanics.MultiBody.Examples.Systems.RobotR3.FullRobot)");
^CERROR: InterruptException:
Stacktrace:
 [1] poptask(W::Base.InvasiveLinkedListSynchronized{Task})
   @ Base ./task.jl:827
 [2] wait()
   @ Base ./task.jl:836
 [3] wait(c::Base.GenericCondition{Base.Threads.SpinLock})
   @ Base ./condition.jl:123
 [4] wait(fdw::FileWatching._FDWatcher; readable::Bool, writable::Bool)
   @ FileWatching /opt/julia/julia-1.7.1/share/julia/stdlib/v1.7/FileWatching/src/FileWatching.jl:533
 [5] wait
   @ ~/.julia/packages/ZMQ/R3wSD/src/socket.jl:52 [inlined]
 [6] _recv!(socket::ZMQ.Socket, zmsg::ZMQ.Message)
   @ ZMQ ~/.julia/packages/ZMQ/R3wSD/src/comm.jl:75
 [7] recv
   @ ~/.julia/packages/ZMQ/R3wSD/src/comm.jl:94 [inlined]
 [8] sendExpression(omc::OMJulia.OMCSession, expr::String)
   @ OMJulia ~/.julia/packages/OMJulia/ZLXEs/src/OMJulia.jl:1014
 [9] top-level scope
   @ REPL[7]:1

When I remove dumpSimCode OMJulia simulates fine in around 7 seconds.
My guess is that the debug log is to large to be handled.

@AnHeuermann I could also reproduce the problem and when i remove the dumpSimCode it works fine, As you said the debug log is too large, when i tried with small example it worked fine
julia> OMJulia.sendExpression(omc, "setCommandLineOptions(\"-d=-newInst,dumpSimCode\")")
true
julia> OMJulia.sendExpression(omc, "model a parameter Real x =1; end a;")

julia> OMJulia.sendExpression(omc, "simulate(a)")
Dict{String, Any} with 10 entries:
  "timeCompile"       => 7.54703
  "simulationOptions" => "startTime = 0.0, stopTime = 1.0, numberOfIntervals = 500, tolerance = 1e-06, method = 'dassl', fileNamePrefix = 'a', options = '', outputFormat = 'mat', variableFil…
  "messages"          => "LOG_SUCCESS       | info    | The initialization finished successfully without homotopy method.\nLOG_SUCCESS       | info    | The simulation finished successfully.…
  "timeFrontend"      => 0.0074089
  "timeTotal"         => 7.72618
  "timeTemplates"     => 0.028673
  "timeSimulation"    => 0.135537
  "resultFile"        => "C:/Users/arupa54/a_res.mat"
  "timeSimCode"       => 0.0007035
  "timeBackend"       => 0.0063886

but i could not see the debug log generated from dumpSimCode

The message should be in "messages" of the Dict. With smaller debug flags this does work, for example backenddaeinfo worked.

My guess is that the debug log is to large to be handled.

As a general remark, once a simulation tool has been refined enough to be actually usable for real-life work, small problems work fine, while trouble can arise with large, complicated models, which inevitably generate humongous log files. Sizes of serveral hundreds MB, or even over the GB size, are not unheard of, I had to handle some of them in the past when I had to turn on LOG_NLS_V to figure out what was going wrong in serious simulation problems that were failing for some reason.
The most frustrating situation for an end-user (I say this out of personal experience) is that you can't get this information when you need it most, i.e. when you are trying to get difficult real-life problems to work.
When you have such large log files, there are two potential issues:

if you keep this information in memory, you may run out of memory and crash the entire OS, or freeze it almost to death by disk swapping, which is not nice
if this information is then parsed by GUIs or other structured environments (e.g. OMEdit), they may not be able to scale well to the required size, which is not nice either, if your precious simulation that took 30 minutes to run eventually causes OMEdit or OMJulia to hang or crash, leaving you without a result and without a clue.

As I understand, the only safe scalable way to handle log files is to write them directly to mass storage, and then, only when this is possible (e.g. if the size is below a certain threshold), to read them back into memory for further fancy post-processing. I understand this is what OMEdit does with the C runtime: if the log exceeds 10 MB size, OMEdit doesn't even try to load it in the simulation output window, which is simply not designed to handle such large files effectively. Then one can use other tools, for example I use jEdit (which has very handy grep-like search features) for file size up to a few hundred MB, and PilotEdit, which does not load the entire file in memory for larger files. One could also write small python or julia scripts to look for specific features into those files, grep them, or whatever.
Bottom line: the debug log handling has to be designed with large files in mind from the start! This is not an advanced feature, it is a basic fundamental one. Implementing a log file handling mechanism that relies on data structures in RAM, or string arrays, or stuff like that, only works for toy models, but is inevitably bound to fail when it is needed most, so it is not a sound design and should be avoided.
@JKRT, what do you think?

The message should be in "messages" of the Dict. With smaller debug flags this does work, for example backenddaeinfo worked.

That's exactly what I meant as a questionable design 😃. Guaranteed not to work when you really need it.
I guess this can easily be improved by only using this data structure for sizes up to a certain size, adding a reference to a file on mass storage if that size is exceeded.

@casella
Some bullets. You are right that you might sometimes need to write to file, since in some cases available memory is not enough, and swapping might result in the simulation taking an even longer time to complete. However, even writing to file is not 100% bulletproof. I remember one instance where I managed to overwrite my hard drive when experimenting with the logfiles in the scaleable test suite (For such extreme cases a cloud solution might be needed, or storing the log file in some compressed format.)
Julia has builtin support for (logging)[https://docs.julialang.org/en/v1/stdlib/Logging/]
I guess some heuristic could be implemented to log messages of a certain size say  10 >=MiB
Concerning this particular issue, I guess the issue is twofold. One being with the receive method the other concerns that this particular flag does not save any message at all.
function sendExpression(omc, expr; parsed=true)
    if (process_running(omc.omcprocess))
        ZMQ.send(omc.socket, expr)
        message = ZMQ.recv(omc.socket)
        if parsed
            return Parser.parseOM(unsafe_string(message))
        else
            return unsafe_string(message)
        end
    else
        return "Process Exited, No connection with OMC. Create a new instance of OMCSession"
    end
end

The send(socket, x) and recv(socket, SomeType) functions make an extra copy of the data when converting between ZMQ and Julia. Alternatively, for large data sets (e.g. very large arrays or long strings), it can be preferable to share data, with send(socket, Message(x)) and msg = recv(Message), where the msg::Message object acts like an array of bytes; this involves some overhead so it may not be optimal for short messages.
I guess this is what we do here, but I do not remember to 100% how this works and that we get the result as a very large string (If we get anything at all). Is this an issue in OMMatlab @arun3688 ?

@JKRT, @AnHeuermann This is not an issue in OMMatlab or OMPython , The simulation does not hangs and it works, We get the following message from OMPython and same for OMMatlab, I think the issue is only related to OMJulia, and may be ZMQ package has some problems. But in the message field i don't see any dumps from dumpSimCode but it says end condition reached
>>> from OMPython import OMCSessionZMQ
>>> omc = OMCSessionZMQ()
>>> omc.sendExpression("getVersion()")
'OpenModelica v1.19.0-dev-497-g4c87b752b8 (64-bit)'
>>> omc.sendExpression("setCommandLineOptions(\"-d=newInst,dumpSimCode\")")
True
>>> omc.sendExpression("loadModel(Modelica)")
True
>>> omc.sendExpression("simulate(Modelica.Mechanics.MultiBody.Examples.Systems.RobotR3.FullRobot)")
{'resultFile': 'c:/OPENMODELICAGIT/OpenModelica/testsuite/fmpy/Modelica.Mechanics.MultiBody.Examples.Systems.RobotR3.FullRobot_res.mat', 'simulationOptions': "startTime = 0.0, stopTime = 2.0, numberOfIntervals = 500, tolerance = 1e-06, method = 'dassl', fileNamePrefix = 'Modelica.Mechanics.MultiBody.Examples.Systems.RobotR3.FullRobot', options = '', outputFormat = 'mat', variableFilter = '.*', cflags = '', simflags = ''", 'messages': 'LOG_SUCCESS       | info    | The initialization finished successfully without homotopy method.\n[C:/OPENMODELICAGIT/OpenModelica/build/lib/omlibrary/Modelica 4.0.0/Blocks/Logical.mo:942:7-942:33:writable]\nstdout            | info    | Simulation call terminate() at time 1.856045\n|                 | |       | Message : ... End condition reached\nLOG_SUCCESS       | info    | The simulation finished successfully.\n', 'timeFrontend': 1.3734987, 'timeBackend': 4.7949319, 'timeSimCode': 1.1752712, 'timeTemplates': 0.6500264, 'timeCompile': 13.595949, 'timeSimulation': 1.5467495, 'timeTotal': 23.136971}
>>>

You are right that you might sometimes need to write to file, since in some cases available memory is not enough, and swapping might result in the simulation taking an even longer time to complete. However, even writing to file is not 100% bulletproof.

Of course. But at least you have 1-2 more orders of magnitude of headroom. Setting an upper limit to file size as well seems a good strategy.

I remember one instance where I managed to overwrite my hard drive when experimenting with the logfiles in the scaleable test suite (For such extreme cases a cloud solution might be needed, or storing the log file in some compressed format.)

A full hard disk is in fact even worse than a full RAM, in the sense that the problem doesn't go away when you reboot...

Julia has builtin support for logging I guess some heuristic could be implemented to log messages of a certain size say 10 >=MiB or tie it to the size of the model somehow.

And maybe also do that for the file size, just in case.


Add missing header

Really simple PR. Errors.h references 'abort' which is part of cstdlib but wasn't included explicitly causing this failure on Ubuntu 14.10:
In file included from src/TypeChecker.cpp:3:0:
src/Errors.h: In destructor ‘Bish::ErrorReport::~ErrorReport()’:
src/Errors.h:21:19: error: ‘abort’ was not declared in this scope
             abort();
                   ^
Makefile:23: recipe for target 'obj/TypeChecker.o' failed
make: *** [obj/TypeChecker.o] Error 1

Other commit is just a suggestion.

Thanks!


Generalize spline tax functions to 2D

This PR addresses issue #828 through pyGAM which enables monotonic splines for any number of dimensions. It creates a new method within monotone_spline function alongside new arguments to specify the method and necessary inputs. Also adds a new function avg_by_bin_2d for binning data with any number of x dimensions (maybe the function name should be changed) that's used in the 2d case for the tax data example created in test_txfunc.py. @jdebacker @rickecon

Error is "ModuleNotFoundError: No module named 'pygam'", do new modules/packages need to be added elsewhere?

@prrathi. This looks really good. For the tests to run on the GitHub Action, you need to add the pygam package to the environment.yml and to setup.py. Here is my suggested changes.
Add the following three lines at the end of environment.yml:
- pip
- pip:
  - pygam

Add the following line after "requests", in the install_requires={ section of setup.py:
    "pygam",

After you make these changes, you'll want to update your ogcore-dev environment by doing the following steps:

Delete your current ogcore-dev environment by deactivating it conda deactivate then deleting it conda remove --name ogcore-dev --all.
Create an updated version of the ogcore-dev conda environment by navigating to the main OG-Core directory of your repository and creating the conda environment conda env create -f environment.yml. Then add the ogcore package to the environment by activating the environment conda activate ogcore-dev and typing pip install -e ..

Make sure your test_txfunc.py tests pass locally on your machine in this environment. Once you commit the changes above to your PR, the new test should pass on the GitHub Action CI as well.

@rickecon thanks for the help, think previous issues should be fixed but its giving an error with test_SS_fsolve

@prrathi. You need to do two things to this PR.

Use the black package to update your files format so they will pass the "Check Black formatting" CI test. Make sure you have updated your ogcore-dev conda package to include the changes you made in this PR. Then make sure you are in the master branch of your fork. In your terminal in the OG-Core repository on your machine, type black . -l 79. This will update the files that need to be formatted. You will be able to see which files these are by typing git status. Then add these files git add -A and commit them git commit -m "Black formatted files" and push them to your remote branch git push origin master. This will update your PR and the files will be formatted.
PR #836 should fix the test_SS_fsolve test that is failing in this PR in test_SS.py. Once PR #836 is merged, you should update your branch by doing the following steps.

Make sure you have all your changes that you want in your local OG-Core master branch added and committed and pushed.
Go to your master branch and git fetch upstream the changes to the PSLmodels/OG-Core repo's master branch.
Merge those changes into your master branch by typing git merge upstream/master.
You will likely have merge conflicts that you need to resolve. If so, you'll see which files have conflicts by typing git status and/or by looking at the output after your git merge command from the previous step. Go to those files, choose which changes to keep, add them, commit them, and push them.

After following these steps (1) and (2), I think it is likely that all the CI tests will pass.

Codecov Report

Merging #839 (ffc1617) into master (86b8a3c) will decrease coverage by 1.50%.
The diff coverage is 2.91%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #839      +/-   ##
==========================================
- Coverage   82.24%   80.73%   -1.51%
==========================================
  Files          18       18
  Lines        3981     4060      +79
==========================================
+ Hits         3274     3278       +4
- Misses        707      782      +75

Flag
Coverage Δ

unittests
80.73% <2.91%> (-1.51%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

ogcore/txfunc.py
29.96% <2.91%> (-3.43%)
:arrow_down:

@prrathi. Perfect. All tests are passing. Now I just need to review this. I will try to get this done by the end of this week.

@rickecon sounds good, one thing that is somewhat missing is test cases for the actual interpolated against expected interpolated values analogous to your test case for the other methodology. I wasn't sure how to obtain that expected value so didn't write any cases for that

@rickecon @jdebacker following up if there were any updates on reviewing this, I also should be able to make this Monday's meeting if there is one so can discuss more there

@rickecon I think the only reference here is https://pygam.readthedocs.io/en/latest/. I had experimented with adding a tensor  term in addition to the current spline terms for each dimension but with this specific dataset hadn't seen improvement. There are also some other model classes I didn't explore

@prrathi. Can you merge the most recent updates to OG-Core into your branch? That will be a better foundation for me to work off of.

@rickecon merged

@jdebacker @rickecon did those, also added the option to txfunc.txfunc_est(). Following up on above, not sure if requiring numpy version < 1.24 will be needed in the environment.yml. Also for the given test case the 1d version of this approach seems to have better loss than Eilers, so think it could be used effectively in (1d) mono setting as well

@prrathi
See my PR to your branch with a few changes necessary to make things run.
One thing I wasn't clear on in your changes: can one estimate mono2D with age_specific=True and age_specific=False?

@rickecon @jdebacker Following up on the last meeting and the comments above I was looking more into the code integrating mono and mono2D tax function options. If the goal is to be able to run either of these in the code, I found what I think are a few issues:

in the main [TPI loop](https://github.com/PSLmodels/OG-Core/blob/master/ogcore/TPI.py#:~:text=%23 TPI loop-,while,-(TPIiter%20%3C ) in run_TPI function of TPI.py the ETR, MTRx, and MTRy are all tiled numpy arrays, regardless of p.tax_func_type, and become the etr_params, mtr_params arguments for [ETR_income](https://github.com/PSLmodels/OG-Core/blob/31a0d6652f54b5d7e7549599680042f8ebc17dae/ogcore/tax.py#L169:~:text=def-,ETR_income,-( ), [MTR_income](https://github.com/PSLmodels/OG-Core/blob/31a0d6652f54b5d7e7549599680042f8ebc17dae/ogcore/tax.py#L169:~:text=def-,MTR_income,-( ) functions in tax.py. These in turn become the params parameter in calls to the [get_tax_rates](https://github.com/PSLmodels/OG-Core/blob/31a0d6652f54b5d7e7549599680042f8ebc17dae/ogcore/txfunc.py#L45:~:text=def-,get_tax_rates,-( ) of txfunc.py where the logic for different tax_func_type values is now included. But for the mono and mono2D (being added) options, this params is an array instead of a list whose first entry is function that we want, so the current code wouldn't be compatible and would need changes in TPI.py.
in [tax_func_estimate](https://github.com/PSLmodels/OG-Core/blob/31a0d6652f54b5d7e7549599680042f8ebc17dae/ogcore/txfunc.py#L45:~:text=def-,tax_func_estimate,-( ), beginning here  we have logic based on age_specific and tax_func_type. Currently for the mono case , if S is the right value etrparam_list_adj, mtrxparam_list_adj, mtryparam_list_adj are used as replacement values. But these variables are only declared in the not mono case, so I don't think the code would run if tax_func_type = mono (and by extension mono2D once added). We would need a method to deal with outlier non-parametric tax functions.

I think I should be able to add in the necessary logic for the first issue and maybe some idea like an interpolation of functions can work for the second issue, but wanted to make sure these are actual issues that would need fixing.

@prrathi Thank you for looking through the code to find these issues.
Re the TPI.py file, you are correct that those uses of arrays to store the tax parameters in the TPI_params_to_use arrays won't work with the mono and mono2D functions that must be stored in lists (since Numpy arrays can't be arrays of functions).
Re the age_specific case, I think the code will execute with mono, although in that place outliers are not replaced (see here).  It maybe that all that needed is to set this to:
if age_specific and tax_func_type not in ["mono", "mono2D"]:

One thing I wasn't clear on in your changes: can one estimate mono2D with age_specific=True and age_specific=False?

@jdebacker yes, it only relies on the labor income, capital income, and weight columns so would work with both options

@prrathi Now that PR #861 is merged into the master branch, can you sync that here?  I think those changes might suggest some changes to the mono2D base in txfunc.get_tax_rates().
Once you sync and make those changes, ping me and I'll  run this branch in OG-USA to make sure we can not just estimate the mono2D functions, but pass them through OG model.
We're getting close!  Took a few more changes I didn't anticipate when you set out to do this!

@jdebacker sorry for the delay on this, would the best way to do this be create a branch with my current updates, sync my master with this master, and then work through the two?

@jdebacker sorry for the delay on this, would the best way to do this be create a branch with my current updates, sync my master with this master, and then work through the two?

@prrathi I think you should git fetch upstream and merge upstream/master in to this branch (which I guess is your master branch).  Then sort out any conflicts and then make sure the tests pass as expected.
Let me know if you have questions about any merge conflicts and I can advise.

@rickecon @jdebacker the above changes should be set, just adapting the mono changes to mono2D

@prrathi Thanks for the updates. I just added two comments. With those changes I was able to solve the SS of the OG-USA models using the mono2D functions.

@jdebacker do you mean a review for the code? I don't see anything from my end

@prrathi Sorry about that - I forgot to click to submit my review.  Please see comments now.

@prrathi. I just submitted a PR to your branch that makes the changes that @jdebacker requested in txfunc.py and updates the OG-Core version number in setup.py and ogcore/__init__.py. Once you merge those changes into your branch, everything in this PR to the main OG-Core branch should be ready to merge.

@rickecon @jdebacker sounds good, just merged

@prrathi. Thank you for this excellent PR. And thanks @jdebacker for all the maintenance and testing of this. I think this is ready to merge.


Cross-compile flags should be in get_swiftpm_flags

These flags were only passed for regular builds, but not for testing or other actions.
rdar://problem/68542579

@swift-ci please smoke test


Please add gh-pages branch

Could you please create an empty gh-pages branch as target for documentation pull-requests with something like:
git checkout --orphan gh-pages
git commit --allow-empty -m "empty documentation branch: pull-request target"
git push -u origin gh-pages

I'd ideally like to see the output of godoc (and possibly a code-coverage report) end up in that branch.

In go ecosystem we already have godoc. It is a well known place where packages documentation is centralized.

Perhaps this is more of a CI/CD discussion, but my concern was ability to easily review godoc (tool) output before the resulting changes got merged into master. Similarly, i’d Like to be able to review changes in code coverage before they get merged into master. For released versions, I agree that https://godoc.org/github.com/sirupsen/logrus is the best place for that.


Add EnableNonWdsPxe parameter

Adding documentation for the EnableNonWdsPxe parameter that was introduced in 1806.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: CodyMathis123 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Docs Build status updates of commit 6629855:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sccm-ps/ConfigurationManager/Set-CMDistributionPoint.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit cf3694c:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sccm-ps/ConfigurationManager/Set-CMDistributionPoint.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 0a7e9bb:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sccm-ps/ConfigurationManager/Set-CMDistributionPoint.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@CodyMathis123 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Any word on if this will be merged?

Hi @CodyMathis123, we're working on some backend issues with the ConfigMgr PowerShell content. Once we're done with ConfigMgr version 2002 release soon, I hope to return to this work. Stay tuned.

I finally fixed a backend issue with this repository, so I'm going through the backlog of contributions.
Due to the fixed issue, I can't accept this PR as-is. But I was able to bring our changes over to our private repository (from where we publish). I made a few tweaks, and also added your description to two other cmdlet articles. 😉 Thanks again for the contribution!
So I'm going to close this PR, but your changes should go live with daily publishing tomorrow afternoon (8/25 4pm)


Use block hash as cache key in ExecutionLayerBlockProductionManager

PR Description
alternative to #8773
Fixed Issue(s)
related to https://github.com/Consensys/teku/issues/8625
Documentation

[ ] I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

[ ] I thought about adding a changelog entry, and added one if I deemed necessary.

Closing since this was only an experiment


Restyle threshold details without indent

Remove about-petitions light variation and associated code, because the grey
text version makes less sense alongside the government response and debate
states

Code LGTM. I'm presuming this is how it should look?

Ja :ok_hand:

@henryhadlow, looks like this needs a rebase. I tried myself but there's some CSS conflicts which I couldn't reconcile

Rebased - merging when green.


[Important] Potentially large JAR file

Your current JAR file is about 86 mb. While at the moment it is within the constraint (100mb), by the end of the project you may potentially hit the limit.
Please check if you have packaged possibly unwanted libraries (e.g., javafx-web and javafx-media) within the JAR? If so, please remove it to make the size easier to manage.

Hi Prof, thanks for the issue! We'll definitely keep this in check before submission.
We're including javafx-web and javafx-media as we need to use JavaFX's WebView component to render HTML strings (which is a result of our Markdown -> HTML compiler).
We'll keep this in mind!


Number of lines in "Highlight inner space changes" not always correct?

In the following example, the number of lines for "Highlight inner space changes" is 0, but I'd have expected it to be 1.

If I uncheck the rule for removing lang="en", then the line number is increased to 1.

Is this a bug or this behavior intended?

Hi ConjuringCoffee,
wow, that's well observed… will look into it, my first impression is that this part of the code anyway needs to be reworked a bit. And yes, I can't claim that showing "0 lines" here is an intended feature :-), especially since activating and deactivating the "Highlight inner space changes" option actually changes the orange highlight of the spaces in the right-hand display.
Kind regards,
Jörg-Michael

Hi ConjuringCoffee,
okay, this refactoring has the nice additional effect that you will now be able to deactivate even the last option, now called "Highlight text and line changes" (for text changes and added/deleted lines):

This allows to completely turn off the highlighting and get an overall impression of what the cleaned code looks like.
The above bug should also be fixed now (i.e. in the next release).
Kind regards,
Jörg-Michael

Hi Jörg-Michael, that was fast - thanks!

I can confirm that it works now.


"thiagotalma/yii2-jstree": "*" not working

when i enter this into my composer file, it's not working.
set it to
"thiagotalma/yii2-jstree": "dev-master"

Thanks!


Doesn't work with nvim-scrollview

The scrollbar of https://github.com/dstein64/nvim-scrollview doesn't scroll in zen-mode.

You should report this in scrollview. Nothing I can do about it. They probably don't support floating windows


sbt server does not stay up when sbtn is called from emacs

steps
run
sbtn compile

twice from within emacs.
problem
When called from Emacs the first server dies and the second call starts a new one.
expectation
I expect the first invocation to start the server, and the second one to use it. This works as expected if called from a terminal emulator such as urxvt-unicode.
notes
https://github.com/hvesalai/emacs-scala-mode/pull/165

@fommil Thanks for the report. I wonder if it's somehow failing to create a virtual terminal.

@fommil Thanks for the report. I wonder if it's somehow failing to create a virtual terminal.

that might be the case, the TERM is usually set to dumb and there is the INSIDE_EMACS envvar that can be used to add special handling.

that might be the case, the TERM is usually set to dumb and there is the INSIDE_EMACS envvar that can be used to add special handling.

can you please point me at the code where it's trying to create the virtual terminal? From what I can tell, the server is started (I can see the socket in the .sbt folder), it just gets killed when the process ends. Is there maybe something funny going on where the daemon process is being attached? It's possible that emacs is spinning up a process to start the sbtn process and killing it when sbtn finishes.

can you please point me at the code where it's trying to create the virtual terminal? From what I can tell, the server is started (I can see the socket in the .sbt folder), it just gets killed when the process ends. Is there maybe something funny going on where the daemon process is being attached? It's possible that emacs is spinning up a process to start the sbtn process and killing it when sbtn finishes.

I am not actually super familiar with the underlying terminal IO stuff, but I think

sbtn spawns sbt server as a background process
sbtn sends a query to determine the terminal capability of the sbt server here - https://github.com/sbt/sbt/blob/c0e82677567ad7a6686ed8b60a93b556514d003b/main/src/main/scala/sbt/internal/server/NetworkChannel.scala#L741
sbt server creates sbt.internal.util.Terminal object somewhere in here to determine its capability - https://github.com/sbt/sbt/blob/develop/internal/util-logging/src/main/scala/sbt/internal/util/Terminal.scala

See also https://github.com/sbt/sbt/issues/6186

I am not actually super familiar with the underlying terminal IO stuff, but I think

sbtn spawns sbt server as a background process
sbtn sends a query to determine the terminal capability of the sbt server here - https://github.com/sbt/sbt/blob/c0e82677567ad7a6686ed8b60a93b556514d003b/main/src/main/scala/sbt/internal/server/NetworkChannel.scala#L741
sbt server creates sbt.internal.util.Terminal object somewhere in here to determine its capability - https://github.com/sbt/sbt/blob/develop/internal/util-logging/src/main/scala/sbt/internal/util/Terminal.scala

See also https://github.com/sbt/sbt/issues/6186

It's possible that emacs is spinning up a process to start the sbtn process and killing it when sbtn finishes.

sbtn process is meant to end, but sbt server process should persist in the background. Could it be possible that emacs somehow doesn't like that behavior and tries to kill it?

It's possible that emacs is spinning up a process to start the sbtn process and killing it when sbtn finishes.

sbtn process is meant to end, but sbt server process should persist in the background. Could it be possible that emacs somehow doesn't like that behavior and tries to kill it?

it looks like a lot of the emacs jline customisations @hvesalai added have been lost in sbt's Terminal layer. I think we'll need to add them here. Specifically I think we want ansi colours to be enabled but for the supershell to be disabled when INSIDE_EMACS is set.
I can't see where the spawning of the background process is controlled by the Terminal capabilities, perhaps @eatkins can say more on that? If it's possible to add some more debugging, e.g. writing out to a log file on kill signals, that would be really useful.

it looks like a lot of the emacs jline customisations @hvesalai added have been lost in sbt's Terminal layer. I think we'll need to add them here. Specifically I think we want ansi colours to be enabled but for the supershell to be disabled when INSIDE_EMACS is set.
I can't see where the spawning of the background process is controlled by the Terminal capabilities, perhaps @eatkins can say more on that? If it's possible to add some more debugging, e.g. writing out to a log file on kill signals, that would be really useful.

The server is forked by sbtn (or sbt -client) here: https://github.com/sbt/sbt/blob/844deab78c833b8f59e53051636d218658daa1bf/main-command/src/main/scala/sbt/internal/client/NetworkClient.scala#L340-L347 All of the terminal logic should live in https://github.com/sbt/sbt/blob/develop/internal/util-logging/src/main/scala/sbt/internal/util/Terminal.scala
The server is supposed to disconnect the standard io streams when it launches and maybe it's possible that it isn't? That could potentially cause the server to crash if the spawning process exits. The disconnection happens here: https://github.com/sbt/sbt/blob/2bbbcfae77b53e89cea525e3f7b68da8ea142a96/main/src/main/scala/sbt/internal/CommandExchange.scala#L257-L259

@eatkins I'll try to do some experiments. I think the issue might be with the way that Emacs spawns processes. It spins up a new process in a buffer and then when that process completes it considers it finished. I think it might be analagous to typing sbtn compile in a terminal window and then closing the terminal; would you expect the sbt server to still be running? I'm trying to think about it in terms of parent processes.

@eatkins I'll try to do some experiments. I think the issue might be with the way that Emacs spawns processes. It spins up a new process in a buffer and then when that process completes it considers it finished. I think it might be analagous to typing sbtn compile in a terminal window and then closing the terminal; would you expect the sbt server to still be running? I'm trying to think about it in terms of parent processes.

https://www.emacswiki.org/emacs/PersistentProcesses

https://www.emacswiki.org/emacs/PersistentProcesses

@hvesalai I think you've nailed it there. We need to use nohup on the Emacs side!
I'll send a PR to fix the ansi / colour / super issues.

@hvesalai I think you've nailed it there. We need to use nohup on the Emacs side!
I'll send a PR to fix the ansi / colour / super issues.

or should sbt use nohup when spawning the server? :thinking:

or should sbt use nohup when spawning the server? :thinking:


Path

What does this change do?
This PR adds an implementation of toml::path which represents a path to an arbitrary toml node. It provides utilities for path manipulation by path segment (e.g. parents, truncation), as well as comparisons between paths. toml::path objects may be used as an argument for at_path.
Is it related to an exisiting bug report or feature request?
Fixes #153.
Pre-merge checklist

[x] I've read CONTRIBUTING.md
[ ] I've rebased my changes against the current HEAD of origin/master (if necessary)
[x] I've added new test cases to verify my change
[x] I've regenerated toml.hpp (how-to)
[x] I've updated any affected documentation (comments updated, have not regenerated with poxy)
[x] I've rebuilt and run the tests with at least one of:

[ ] Clang 6 or higher
[ ] GCC 7 or higher
[x] MSVC 19.20 (Visual Studio 2019) or higher

[x] I've added my name to the list of contributors in README.md

Updates!

Fixes pushed!

Yup, looks good to me @jonestristand! There's a few bits-and-pieces I'll want to do post-merge so I won't merge it in until I have time to do that (this weekend mayyyybe, otherwise some weekend soon), so if there's more you think you want to add (any other utility functions etc.) feel free to push to this branch before then :)

Going to look after this tomorrow or Sunday this weekend FYI @jonestristand

Awesome, pumped to have it merged in! I'm just adding a subpath method today so luckily that'll sneak in under the wire ;-)

Thanks @jonestristand! I'll keep it in the paths branch for a bit while I do some additional things, and will try to summarize changes I make in commit descriptions. Since you were interested in learning more and re-familiarizing yourself with C++, please let me know if you would like more detailed information about anything you see - I'll be happy to go into more detail on gitter :)


builds only work on python 2.7

I'm setting up pythonnet builds on both Linux and OSX using Travis CI. Previously the builds were working fine under Linux only, but with tox and tox-travis I'm only able to build on Linux 2.7
ERROR: invocation failed (exit code 1), logfile: /home/travis/build/pythonnet/pythonnet/.tox/py33/log/py33-1.log
ERROR: actionid: py33

Here are the successful and failing builds:
https://travis-ci.org/pythonnet/pythonnet/jobs/163293730
https://travis-ci.org/pythonnet/pythonnet/jobs/163293731
I will start looking into Mac builds later.

Sorry it's taken me so long to respond, this got lost in my inbox.
The problem is that you're not running tox quite right. In particular, you need to get your configuration (in tox.ini) to run properly before you can use tox-travis, because tox-travis just simplifies using tox on travis.
Once you can just run tox to run your tests, then you can work on your .travis.yml. Make sure that your script is tox. It's the same thing that you'd run locally, but tox-travis does a little magic to help it determine which tox envs to run automatically.
Note also that for what you have in the tox:travis section of your tox.ini, you don't need that. Those are all the default mappings anyway. Also remember that those have no effect except on Travis runners.
I hope that helps you figure it out!

Actually the issue turned to be this one, you can see my case at the bottom:
https://github.com/tox-dev/tox/issues/245
So looks like our previous setup in pythonnet with just relying on
virtualenv for Python versions provided on Linux by Travis CI does not work
when tox is handling python versions due to custom files in setup.py.
The only reason why I added tox and pyenv is to handle Mac OSX and Linux
with Travis CI at the same time.
But I think to switch to this setup provided by Matthew Brett and PEP 513
that I found out later:
https://github.com/matthew-brett/multibuild
On Fri, Sep 30, 2016 at 3:34 PM, Ryan Hiebert<EMAIL_ADDRESS>wrote:

Sorry it's taken me so long to respond, this got lost in my inbox.
The problem is that you're not running tox quite right. In particular, you
need to get your configuration (in tox.ini) to run properly before you
can use tox-travis, because tox-travis just simplifies using tox on travis.
Once you can just run tox to run your tests, then you can work on your
.travis.yml. Make sure that your script is tox. It's the same thing that
you'd run locally, but tox-travis does a little magic to help it determine
which tox envs to run automatically.
Note also that for what you have in the tox:travis section of your tox.ini,
you don't need that. Those are all the default mappings anyway. Also
remember that those have no effect except on Travis runners.
I hope that helps you figure it out!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ryanhiebert/tox-travis/issues/29#issuecomment-250845786,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHgZ5Rbku0vleshovprC3IIHl0UHsXrsks5qvXJfgaJpZM4KIYdz
.

OK, cool. If there's something that tox-travis could reasonably do to make this easier, please open a new issue to let me know!


video

Uploading Post - Feed.mp4…

https://github.com/user-attachments/assets/ccd5135b-bb33-43ec-bf2a-e00d51082ed9


Integrate GPT4All to BCRP Metadata

Tie the GPT4All ecosystem to the BCRP's metadata and calls thereof. The idea is to run prompts that search for relations in the metadata and pull and/or document the pertinent data found by the AI.
See:

Script template for gpt4all usage (lang.py)
LLM models directory

I'd like to work on it.

I'd like to work on it.

Great! I just created a lang.py, which is passed directly from the gpt4all langchain site. I thought it'd be good to start to start with a lean model licensed for commercial use, and Falcon meets such characteristics (see README in llm_models for model loading instructions)


Integrated terminal doesn't start bash or any other shell.

There is another issue about this problem, but it was closed before it was solved:
https://github.com/microsoft/vscode/issues/90878
I assume that these are problems with python, but I don’t understand which ones, because I don’t know how to look at the vscode launch logs or integrated terminal launch logs.

VSCode Version: About:
Version: 1.42.1
Commit: c47d83b293181d9be64f27ff093689e8e7aed054
Date: 2020-02-11T14:50:36.977Z
Electron: 6.1.6
Chrome: 76.0.3809.146
Node.js: 12.4.0
V8: 7.6.303.31-electron.0
OS: Linux x64 5.3.0-40-generic

OS Version: Ubuntu 18.04.4 LTS

settings.json file:
{
    "latex-workshop.view.pdf.viewer": "tab",
    "cSpell.language": ",ru",
    "vim.history": 500,
    "editor.wordWrap": "on",
    "workbench.iconTheme": "material-icon-theme",
    "workbench.colorTheme": "Solarized-light",
    "explorer.confirmDelete": false,
    "spellright.language": [
        "en_US",
        "ru_RU"
    ],
    "spellright.documentTypes": [
        "markdown",
        "latex",
        "plaintext"
    ],
    "terminal.integrated.inheritEnv": false,
    "terminal.integrated.shell.linux": "/bin/bash",
    "editor.renderWhitespace": "all",
    "cSpell.userWords": [
        "modelling"
    ]
}

I had the same issue on my Ubuntu machine. Somehow, removing
"terminal.integrated.inheritEnv": false from my settings.json resolved the issue for me.

/duplicate https://github.com/microsoft/vscode/issues/76542
Remove the terminal.integrated.inheritEnv setting to fix this.

It didn't help me =(

Try enabling trace logging and seeing what the logs say when the terminal is created and shutdown https://github.com/microsoft/vscode/wiki/Terminal-Issues#enabling-trace-logging


Update dependency node-fetch to v3

This PR contains the following updates:

Package
Type
Update
Change

node-fetch
dependencies
major
^2.6.7 -> 3.2.10

Release Notes

node-fetch/node-fetch
v3.2.10
Compare Source
Bug Fixes

ReDoS referrer (#1611) (2880238)

v3.2.9
Compare Source
Bug Fixes

Headers: don't forward secure headers on protocol change (#1599) (e87b093)

v3.2.8
Compare Source
Bug Fixes

possibly flaky test (#1523) (11b7033)

v3.2.7
Compare Source
Bug Fixes

always warn Request.data (#1550) (4f43c9e)

v3.2.6
Compare Source
Bug Fixes

undefined reference to response.body when aborted (#1578) (1c5ed6b)

v3.2.5
Compare Source
Bug Fixes

use space in accept-encoding values (#1572) (a92b5d5), closes #1571

v3.2.4
Compare Source
Bug Fixes

don't uppercase unknown methods (#1542) (004b3ac)

v3.2.3
Compare Source
Bug Fixes

handle bom in text and json (#1482) (6425e20)

v3.2.2
Compare Source
Bug Fixes

add missing formdata export to types (#1518) (a4ea5f9), closes #1517

v3.2.1
Compare Source
Bug Fixes

cancel request example import (#1513) (61b3b5a)

v3.2.0
Compare Source
Features

export Blob, File and FormData + utilities (#1463) (81b1378)

v3.1.1
Compare Source
Security patch release
Recommended to upgrade, to not leak sensitive cookie and authentication header information to 3th party host while a redirect occurred
What's Changed

core: update fetch-blob by @jimmywarting in https://github.com/node-fetch/node-fetch/pull/1371
docs: Fix typo around sending a file by @jimmywarting in https://github.com/node-fetch/node-fetch/pull/1381
core: (http.request): Cast URL to string before sending it to NodeJS core by @jimmywarting in https://github.com/node-fetch/node-fetch/pull/1378
core: handle errors from the request body stream by @mdmitry01 in https://github.com/node-fetch/node-fetch/pull/1392
core: Better handle wrong redirect header in a response by @tasinet in https://github.com/node-fetch/node-fetch/pull/1387
core: Don't use buffer to make a blob by @jimmywarting in https://github.com/node-fetch/node-fetch/pull/1402
docs: update readme for TS @types/node-fetch by @adamellsworth in https://github.com/node-fetch/node-fetch/pull/1405
core: Fix logical operator priority to disallow GET/HEAD with non-empty body by @maxshirshin in https://github.com/node-fetch/node-fetch/pull/1369
core: Don't use global buffer by @jimmywarting in https://github.com/node-fetch/node-fetch/pull/1422
ci: fix main branch by @dnalborczyk in https://github.com/node-fetch/node-fetch/pull/1429
core: use more node: protocol imports by @dnalborczyk in https://github.com/node-fetch/node-fetch/pull/1428
core: Warn when using data by @jimmywarting in https://github.com/node-fetch/node-fetch/pull/1421
docs: Create SECURITY.md by @JamieSlome in https://github.com/node-fetch/node-fetch/pull/1445
core: don't forward secure headers to 3th party by @jimmywarting in https://github.com/node-fetch/node-fetch/pull/1449

New Contributors

@mdmitry01 made their first contribution in https://github.com/node-fetch/node-fetch/pull/1392
@tasinet made their first contribution in https://github.com/node-fetch/node-fetch/pull/1387
@adamellsworth made their first contribution in https://github.com/node-fetch/node-fetch/pull/1405
@maxshirshin made their first contribution in https://github.com/node-fetch/node-fetch/pull/1369
@JamieSlome made their first contribution in https://github.com/node-fetch/node-fetch/pull/1445

Full Changelog: https://github.com/node-fetch/node-fetch/compare/v3.1.0...v3.1.1
v3.1.0
Compare Source
What's Changed

fix(Body): Discourage form-data and buffer() by @jimmywarting in https://github.com/node-fetch/node-fetch/pull/1212
fix: Pass url string to http.request by @serverwentdown in https://github.com/node-fetch/node-fetch/pull/1268
Fix octocat image link by @lakuapik in https://github.com/node-fetch/node-fetch/pull/1281
fix(Body.body): Normalize Body.body into a node:stream by @jimmywarting in https://github.com/node-fetch/node-fetch/pull/924
docs(Headers): Add default Host request header to README.md file by @robertoaceves in https://github.com/node-fetch/node-fetch/pull/1316
Update CHANGELOG.md by @jimmywarting in https://github.com/node-fetch/node-fetch/pull/1292
Add highWaterMark to cloned properties by @davesidious in https://github.com/node-fetch/node-fetch/pull/1162
Update README.md to fix HTTPResponseError by @thedanfernandez in https://github.com/node-fetch/node-fetch/pull/1135
docs: switch url to URL by @dhritzkiv in https://github.com/node-fetch/node-fetch/pull/1318
fix(types): declare buffer() deprecated by @dnalborczyk in https://github.com/node-fetch/node-fetch/pull/1345
chore: fix lint by @dnalborczyk in https://github.com/node-fetch/node-fetch/pull/1348
refactor: use node: prefix for imports by @dnalborczyk in https://github.com/node-fetch/node-fetch/pull/1346
Bump data-uri-to-buffer from 3.0.1 to 4.0.0 by @dependabot in https://github.com/node-fetch/node-fetch/pull/1319
Bump mocha from 8.4.0 to 9.1.3 by @dependabot in https://github.com/node-fetch/node-fetch/pull/1339
Referrer and Referrer Policy by @tekwiz in https://github.com/node-fetch/node-fetch/pull/1057
Add typing for Response.redirect(url, status) by @c-w in https://github.com/node-fetch/node-fetch/pull/1169
chore: Correct stuff in README.md by @Jiralite in https://github.com/node-fetch/node-fetch/pull/1361
docs: Improve clarity of "Loading and configuring" by @serverwentdown in https://github.com/node-fetch/node-fetch/pull/1323
feat(Body): Added support for BodyMixin.formData() and constructing bodies with FormData by @jimmywarting in https://github.com/node-fetch/node-fetch/pull/1314
template: Make PR template more task oriented  by @jimmywarting in https://github.com/node-fetch/node-fetch/pull/1224
docs: Update code examples by @jimmywarting in https://github.com/node-fetch/node-fetch/pull/1365

New Contributors

@serverwentdown made their first contribution in https://github.com/node-fetch/node-fetch/pull/1268
@lakuapik made their first contribution in https://github.com/node-fetch/node-fetch/pull/1281
@robertoaceves made their first contribution in https://github.com/node-fetch/node-fetch/pull/1316
@davesidious made their first contribution in https://github.com/node-fetch/node-fetch/pull/1162
@thedanfernandez made their first contribution in https://github.com/node-fetch/node-fetch/pull/1135
@dhritzkiv made their first contribution in https://github.com/node-fetch/node-fetch/pull/1318
@dnalborczyk made their first contribution in https://github.com/node-fetch/node-fetch/pull/1345
@dependabot made their first contribution in https://github.com/node-fetch/node-fetch/pull/1319
@c-w made their first contribution in https://github.com/node-fetch/node-fetch/pull/1169

Full Changelog: https://github.com/node-fetch/node-fetch/compare/v3.0.0...v3.1.0
v3.0.0
Compare Source
version 3 is going out of a long beta period and switches to stable
One major change is that it's now a ESM only package
See changelog for more information about all the changes.

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Renovate Bot.

Renovate Ignore Notification
As this PR has been closed unmerged, Renovate will ignore this upgrade and you will not receive PRs for any future 3.x releases. However, if you upgrade to 3.x manually then Renovate will reenable minor and patch updates automatically.
If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.


⚠ ClamAV has degraded performance

In 1e6fbbe, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 67 ms

Resolved: ClamAV performance has improved in 2c1c796.


support usage of referenced schema as default

Add option to use the referenced schema's type as the default for mandatory fields. Without that, there can be situations with incompatible types for the default value and the field value(mostly when using generateAliasAsMode=true).

Sorry, that commit(03b6e62) was intended for another PR. If ok I would add it to this one.
It adds support for the 'supportsAdditionalPropertiesWithComposedSchema' (see https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/main/java/org/openapitools/codegen/DefaultCodegen.java#L196-L201) option of the default generator. Instead of creating the pojos as subclasses of Map, it adds a class member "Map additionalProperties" with the required json annotations to be flattend on serialization.

@stephanschnabel @rpahli  Thanks for approving. Can one of you merge? I'm not allowed to.


JSON.stringify is converting Float (number) values to strings.

Bug description
I'm using prisma with Typescript in a next.js application and JSON.strinfigy converts fields that are of type number (Float in the schema) to strings.
I did a little debugging and it looks like the Float fields are actually typeof 'object', not number, as I would have expected and what the generated @prisma/client types are telling me. The only thing I can think of is that Prisma is wrapping these values in something funky in the background?
For now my workaround is to do something like this:
export const toRaw = (user: User) => ({
  id: user.id,
  ...
  name: user.name,
  latitude: Number(user.latitude),
  longitude: Number(user.longitude),
});

How to reproduce
When I fetch and try to return json, latitude and longitude are being converted to strings:
const user = await prisma.user.findUnique({
  where: {
    id: req.user.id,
  },
});

JSON.stringify(user);

The output of which is:
{
  "name": "Super Dude",
  "longitude": "-118.235322", // <- STRING, not a number
  "latitude": "34.045148",  // <- STRING, not a number
}

Expected behavior
I'd expect the output to be:
{
  "name": "Super Dude",
  "longitude": -118.235322, // <- NUMBER, not a string
  "latitude": 34.045148,  // <- NUMBER, not a string
}

Prisma information
My schema for a User model is as follows:
// Schema
model User {
  id            String      @id @default(cuid())
  ...
  name          String?
  latitude      Float?
  longitude     Float?
}

// Generated type in @prisma/client
/**
 * Model User
 *
 */
export type User = {
  id: string
  ...
  name: string | null
  latitude: number | null
  longitude: number | null
}

Environment & setup
Next.js with Typescript.
Prisma Version
prisma                  : 3.10.0
@prisma/client          : 3.10.0
Current platform        : debian-openssl-1.1.x
Query Engine (Node-API) : libquery-engine 73e60b76d394f8d37d8ebd1f8918c79029f0db86 (at<EMAIL_ADDRESS>Migration Engine        : migration-engine-cli 73e60b76d394f8d37d8ebd1f8918c79029f0db86 (at<EMAIL_ADDRESS>Introspection Engine    : introspection-core 73e60b76d394f8d37d8ebd1f8918c79029f0db86 (at<EMAIL_ADDRESS>Format Binary           : prisma-fmt 73e60b76d394f8d37d8ebd1f8918c79029f0db86 (at<EMAIL_ADDRESS>Default Engines Hash    : 73e60b76d394f8d37d8ebd1f8918c79029f0db86
Studio                  : 0.458.0

I am unable to reproduce this. I ran the query that you have posted and ran JSON.stringify to the result and output was correct:

I used Postgres as database? Can you please try again with latest version and possibly report which database are you using?

Script used:
import { PrismaClient } from "@prisma/client";

async function main() {
  const prisma = new PrismaClient();

  const user = await prisma.user.findUnique({
    where: {
      id: "cl11yqszv00072311gdwx6vo7",
    },
  });

  console.log(JSON.stringify(user));
  await prisma.$disconnect();
}

main();

Ping @ifightcrime. Can you help us out here a bit? We have no idea how to reproduce this to understand and potentially fix.

@janpio hey yes sorry I missed the first message! At the time I was a number of versions back too so who knows. I'm about to head out for the weekend though, but I will get back to you likely early next week.

Did you have any time to look at this @ifightcrime maybe?

Can you help us out here @ifightcrime? With the current information we unfortunately will need to close the issue as it is not enough to understand what is going on and reproduce it. Thanks!

Might be a duplicate of #6049?
@janpio I encountered similar behavior today and it really turned me around for a minute before I realized that prisma was returning decimal.js objects instead of native JavaScript numbers.
I use SQL Server, for reference. When copying the example from this issue, everything was working as correctly (i.e. JSON.stringify() correctly processing latitude and longitude as numbers). Only once I changed those fields from float to decimal did I notice the behavior return. I'm using decimal data types in my project, so that makes sense as to why I also noticed it originally.
Ultimately I understand why prisma elects to wrap numbers, as I too use decimal.js for important calculations in JavaScript to avoid unexpected floating point issues. That said it definitely surprised me when I was inspecting my objects in the debugger and pre-stringify they were evaluating as numbers and post-stringify they were strings. It took me running typeof to notice it was an object, then check its constructor which made it clear it was decimal.js.
I'll definitely be implementing some kind of workaround in my project. Possibly this solution but I'm hesitant to overwrite the prisma prototype as such.
See below for my schema.prisma and simple script. Happy to share the repo as well if it would help.
index.ts
import { PrismaClient } from "@prisma/client";

async function main() {
  const prisma = new PrismaClient();
  const name = 'foo';
  const latitude = 34.045148;
  const longitude = 118.235322;

  const userResult = await prisma.user.upsert({
    where: { name },
    update: { latitude, longitude },
    create: { name, latitude, longitude },
  });

  const user = await prisma.user.findFirst({
    where: { name },
  });

  if (user) {
    const { latitude, longitude } = JSON.parse(JSON.stringify(user));
    console.log(JSON.stringify(user)); // {"id":"cla369oo40000mfknwyso4l46","name":"foo","latitude":"34.045148","longitude":"118.235322"}
    console.log(typeof latitude); // string
    console.log(typeof longitude); // string
  }

  await prisma.$disconnect();
}

main();

schema.prisma
generator client {
  provider = "prisma-client-js"
}

datasource db {
  provider = "sqlserver"
  url      = env("DATABASE_URL")
}

model User {
  id            String   @id @default(cuid())
  name          String   @unique
  latitude      Decimal? @db.Decimal(15, 6)
  longitude     Decimal? @db.Decimal(15, 6)
}

Environment
OS: macOS Monterey 12.5.1
Database: SQL Server 2014 (not supported by prisma... 🤫)
Node.js version: v16.13.1
prisma -v
Environment variables loaded from .env
prisma                  : 4.5.0
@prisma/client          : 4.5.0
Current platform        : darwin-arm64
Query Engine (Node-API) : libquery-engine 0362da9eebca54d94c8ef5edd3b2e90af99ba452 (at<EMAIL_ADDRESS>Migration Engine        : migration-engine-cli 0362da9eebca54d94c8ef5edd3b2e90af99ba452 (at node_modules/@prisma/engines/migration-engine-darwin-arm64)
Introspection Engine    : introspection-core 0362da9eebca54d94c8ef5edd3b2e90af99ba452 (at node_modules/@prisma/engines/introspection-engine-darwin-arm64)
Format Binary           : prisma-fmt 0362da9eebca54d94c8ef5edd3b2e90af99ba452 (at node_modules/@prisma/engines/prisma-fmt-darwin-arm64)
Format Wasm             : @prisma/prisma-fmt-wasm 4.5.0-43.0362da9eebca54d94c8ef5edd3b2e90af99ba452
Default Engines Hash    : 0362da9eebca54d94c8ef5edd3b2e90af99ba452
Studio                  : 0.476.0

I understand the rationale behind wrapping numbers in Decimal.js objects, but their default treatment as strings is annoying. I ran into the same problem as what @qcom describes, except with Postgres and numeric types (an alias for decimal). What exactly is the best way to deal with this? Am I meant to cast these values with Number() everywhere in my front end? Reluctantly Decimal.js as another dependency?

@ifightcrime Closing as we didn't hear back, we're happy to reopen it if this issue still exists in a recent version of Prisma.


Lua features

These features are needed for the Lua thread:
IPC

[ ] Lua thread is an internal IPC client
[ ] Lua can register its own callbacks to IPC events (i.e. keybindings)
[ ] Accept terminate and restart commands
[ ] Use move semantics/clone-on-write for Arc values from the registry to prevent some copying

Libraries

[ ] Lua called through init script
[ ] Invisible wrapper to registry
[ ] Registry fields with nested names
[ ] JSON support

Most of the value of the Lua thread comes from compatibility with the configuration, commands, keybindings, etc.

Updated to reflect Lua thread being downgraded to an internal IPC client.

What is the status on these features? If they are still open, we should begin to move them into separate issues so that they can be better tracked.

Okay, I'll close this issue and open a couple smaller ones.


Link Looks Malicious!

http://thetechco.in/MicrosoftAIforStudents/index

It doesn't seem to work, although a VirusTotal scan reveals nothing malicious

Seems like a cheeky redirect to a sponsored website

My AV(Kaspersky) Detected Link is malicious, Seems to be Weird and cheeky😀

Best to remove it then.


Unit tests don't release or close open connections.

With every run the number open connections grow.

Hi, I'm new to Voyage but I want to understand this issue. How can I reproduce/check the problem?
I inspected the session pool in VOMongoTestResource current repository and looked at the shared queue of Mongo instances, and they are always 10 (the default pool size). Are the Socket instances in such Mongo objects who need to be closed manually?
I'm interested, this seems related to issue #8.
Thanks.

In windows cmd start mongod
MongoDB starting : pid=10140 port=27017 dbpath=\data\db\ 64-bit host=PRT-TUBA
targetMinOS: Windows 7/Windows Server 2008 R2
db version v2.6.11
...
connections:0
Start with fresh Pharo 4.0 image
With configuration browser, find voyage and load stable version.
Set Pharo and cmd window side by side.
In pharo start "test runner" and find voyage
select all 5 test classes and run.
After the first run observe in cmd window
connection accepted from <IP_ADDRESS>:12194 #10 (10 connections now open)
run the tests again and observe cmd window
connection accepted from <IP_ADDRESS>:12276 #20 (20 connections now open)

Hi @Ironirc
Issue reproduced in Pharo 4 w/stable version, but couldn't reproduce with development version.

I can confirm that the development version indeed resolves this issue.

I confirm that the development version doesn't have the problem.


Added Button hover effect

I am submitting this pull request to propose a new feature for Tkinter-Designer, which is a Button Hover effect. The way it works is very simple. I have added a new element named ButtonHover and a class with the same name to convert the the element into a button with a hover effect.
How does the code work
The main class that generates the code for the hover effect is called ButtonHover. The ButtonHover class is designed to generate code for creating a hover effect on a button. It takes in three parameters: a node, a frame, and an image_path. The node and frame parameters specify the position of the button on the canvas, while the image_path parameter specifies the path to the image that will be displayed when the button is hovered over.
To create the hover effect, the ButtonHover class needs to know the id of the original button element that it is associated with. This is because the hover effect code needs to be bound to the original button's events. To get the id, the ButtonHover class checks whether the (x, y) position of the button is present in a psition_id_map dictionary. The psition_id_map dictionary maps the position of each button on the canvas to a unique id.
If the (x, y) position of the button is present in the psition_id_map, the ButtonHover class generates the code required to create the hover effect. The code first creates a PhotoImage object using the image_path parameter. Then, it defines two functions: button_{id}_hover and button_{id}_leave. The {id} in the function names is the id of the original button that the ButtonHover class is associated with.
The button_{id}_hover function is bound to the  event of the original button. This event is triggered when the mouse cursor enters the button's area. When the event is triggered, the function changes the image of the original button to the image specified by the ButtonHover class.
The button_{id}_leave function is bound to the  event of the original button. This event is triggered when the mouse cursor leaves the button's area. When the event is triggered, the function changes the image of the original button back to its original image.
Finally, the ButtonHover class returns the generated code as a string. This code can then be used to create the hover effect on the original button.
How to create a button hover effect

Duplicate the Button you created following the instruction on the readme

You can duplicate the Button by selecting the button group and pressing CTRL/⌘ + D
Rename the duplicate button to "ButtonHover"
Place the duplicate button above the original button
Make sure it's on the same position as the original button

x and y coordinates should be the same

Make changes to the duplicate button for the hover effect

For example, change the color of the button

I have added this instructions on the instructions.md file. I hope you find it useful. Thank you for considering my pull request.
Here is a video tutorial
https://watch.screencastify.com/v/saDGrNayjwSmxbFbShB1
#316

It's better if you add a video on how to add the button hover effect.

Thank you for the suggestion! I appreciate your feedback. I will definitely add a video tutorial on how to add the button hover effect to make it easier for everyone to follow along.

I have created a simple short video tutorial on how to add button hover effect. You can check it out with this link: https://watch.screencastify.com/v/saDGrNayjwSmxbFbShB1

It's better if you add a video on how to add the button hover effect.

I have created a simple and short video tutorial on how to add button hover effect. You can check it out with this link: https://watch.screencastify.com/v/saDGrNayjwSmxbFbShB1
Let me know if you have any questions!

You can add
#### Refer to [this video](https://watch.screencastify.com/v/saDGrNayjwSmxbFbShB1) if you face any problem
under
9. **Button with Hover Effect**
- Duplicate the Button you created in the previous step
  - You can duplicate the Button by selecting the button group and pressing CTRL/⌘ + D
- Rename the duplicate button to "ButtonHover"
- Place the duplicate button above the original button
- Make sure it's on the same position as the original button
  - x and y coordinates should be the same
- Make changes to the duplicate button for the hover effect
  - For example, change the color

You can add #### Refer to [this video](https://watch.screencastify.com/v/saDGrNayjwSmxbFbShB1) if you face any problem under
9. **Button with Hover Effect**
- Duplicate the Button you created in the previous step
  - You can duplicate the Button by selecting the button group and pressing CTRL/⌘ + D
- Rename the duplicate button to "ButtonHover"
- Place the duplicate button above the original button
- Make sure it's on the same position as the original button
  - x and y coordinates should be the same
- Make changes to the duplicate button for the hover effect
  - For example, change the color

Thank you! I'll add it to the README.

Hey @Adoniyas7 , That's very good work! Thank you for working on this feature. Although i'm not sure about the complexity it adds to the process.
Can you add EXPERIMENTAL Labels to the mentions of Button_Hover so it becomes clear that it's an early feature.

Wow. That was AWESOME.
[https://drive.google.com/file/d/1XUyzRymbE3ypBIOxsvNFGmLuRuZ7w-ZC/view]

I tried this and this was AWESOME.
https://drive.google.com/file/d/1XUyzRymbE3ypBIOxsvNFGmLuRuZ7w-ZC/view?usp=sharing

WOW!
[https://drive.google.com/file/d/1XUyzRymbE3ypBIOxsvNFGmLuRuZ7w-ZC/view?usp=sharing](video with images)

WOW!
https://drive.google.com/file/d/1XUyzRymbE3ypBIOxsvNFGmLuRuZ7w-ZC/view?usp=drive_link

To the people who have write access, can anybody merge this to the main branch?

Hey @Adoniyas7 , That's very good work! Thank you for working on this feature. Although i'm not sure about the complexity it adds to the process.
Can you add EXPERIMENTAL Labels to the mentions of Button_Hover so it becomes clear that it's an early feature.

Hi @ParthJadhav ,
Thank you for your feedback! I'm glad you like the work I've done on the Button_Hover feature. I understand your concern about the complexity it adds to the process. I've added EXPERIMENTAL labels to the mentions of Button_Hover so it becomes clear that it's an early feature.
I'm happy to answer any questions you have about the feature or the code. I'm also open to suggestions for how to improve it.
Thank you again for your feedback!

Radio button with the same effect??
Just by

changing the command to set a intvariable
disable the hover leave effect if not the intvariable is the index of the buttton
initialization by the group like Button Radio1, Button Radio2,ButtonHover Radio1,ButtonHover Radio2 etc.
so whatever named Radio1 will behave like a group.
See the below example

Example.zip
https://github.com/ParthJadhav/Tkinter-Designer/assets/124249760/32e5f33f-491d-47bb-9e73-c28a3e88a863

@ParthJadhav You should probably think about merging this PR.

Thanks for the changes @Adoniyas7 !


Replace DynamoDBLock with MapLock

https://github.com/diggerhq/digger/blob/main/pkg/utils/mocks.go#L17
and
https://github.com/diggerhq/digger/blob/main/pkg/aws/dynamo_mock.go
are identical implementation of map-based lock. We should get rid of one of them in favour of the other as a refactoring step

completed in #46


conversion: Formatting in horizon europe template

Relates to issue 47 in the backend: https://github.com/tuwien-csd/damap-backend/issues/47

Description

What does this PR do?
Updated template to fix formatting errors. Small changes in export to fix formatting issues.
See the commented file for more information:
horizonEuropeTemplate_141_Changes_Commented.docx
Code review focus

Please merge this before https://github.com/tuwien-csd/damap-backend/issues/142 since it might build upon the changes from https://github.com/tuwien-csd/damap-backend/issues/141.
Checks

[ ] Tested with Oracle/PostgreSQL
[ ] Export updated
[ ] Documentation added
[ ] Tests added
[ ] E2e tests created
[ ] Successfully ran e2e tests before merge

closes GH-141

Is it possible to get a before/after picture of the changes for easier comparison? A description of the changes within the template would also be helpful.

I have added a commented version to the PR description.


sphinx: 5.3.0 -> 7.2.6

Description of changes
Diff: https://github.com/sphinx-doc/sphinx/compare/v5.3.0...v7.2.6
Changelog: https://www.sphinx-doc.org/en/master/changes.html#release-7-2-6-released-sep-13-2023
A successor to https://github.com/NixOS/nixpkgs/pull/244625
The commit 1eb8fcf085f39f4ea478b6c3daa707b1df9f6d29 adds pythonNamespaces to all sphinxcontrib-* packages in order to fix the import error reported in the following comment.
https://github.com/NixOS/nixpkgs/pull/210338#issuecomment-1447063024
This is an existing approach that fixes the legacy setuptools namespace issue that @tjni investigated.
I also picked a commit to standardize the pname, as noted in this comment.
https://github.com/NixOS/nixpkgs/pull/244625#issuecomment-1650257767
related PRs

https://github.com/NixOS/nixpkgs/pull/210338
https://github.com/NixOS/nixpkgs/pull/244625
https://github.com/NixOS/nixpkgs/pull/249230

cc @AndersonTorres @mweinelt @ncfavier @SuperSandro2000 @tjni

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@ofborg build python311Packages.wrapt

git bisect says ce209976f569f4e62c406fa3b4344c8e9b23830f sphinx: 5.3.0 -> 7.2.6 caused build failures in staging-next for at least python3.pkgs.breathe, libcamera, ghc.
libcamera fails as:
[153/158] Generating Documentation/documentation with a custom command
FAILED: Documentation/html
/nix/store/dzsd3p2zpvkdq4z72vh1yfqcysyhllim-python3.11-sphinx-7.2.6/bin/sphinx-build -D release=v0.0.5 -q -W -b html /build/libcamera/Documentation Documentation/html
/nix/store/m6b4x4a5dk83rhzf293xq5csjcj4nlgn-python3.11-sphinxcontrib-applehelp-1.0.2/lib/python3.11/site-packages/sphinxcontrib/applehelp/__init__.py:24: RemovedInSphinx80Warning: The alias 'sphinx.util.SkipProgressMessage' is deprecated, use 'sphinx.util.display.SkipProgressMessage' instead. Check CHANGES for Sphinx API modifications.
  from sphinx.util import SkipProgressMessage, progress_message
/nix/store/m6b4x4a5dk83rhzf293xq5csjcj4nlgn-python3.11-sphinxcontrib-applehelp-1.0.2/lib/python3.11/site-packages/sphinxcontrib/applehelp/__init__.py:24: RemovedInSphinx80Warning: The alias 'sphinx.util.progress_message' is deprecated, use 'sphinx.util.display.progress_message' instead. Check CHANGES for Sphinx API modifications.
  from sphinx.util import SkipProgressMessage, progress_message
/nix/store/kbwpk8fvpg3c7xz68cnh9cd46r69jx5c-python3.11-sphinxcontrib-htmlhelp-2.0.0/lib/python3.11/site-packages/sphinxcontrib/htmlhelp/__init__.py:26: RemovedInSphinx80Warning: The alias 'sphinx.util.progress_message' is deprecated, use 'sphinx.util.display.progress_message' instead. Check CHANGES for Sphinx API modifications.
  from sphinx.util import progress_message

Theme error:
An error happened in rendering the page api-html/index.
Reason: UndefinedError("'style' is undefined")

Hydra shows the same log for ghc:
https://hydra.nixos.org/build/239551789/nixlog/1/tail

cc @sternenseemann for ghc
We already had a patch for that iirc.

That's a new issue, I think, the patch was for 6.0 and is either applied in nixpkgs or upstreamed into GHC. I've opened https://gitlab.haskell.org/ghc/ghc/-/issues/24129 for now, since I can't look into it myself atm.

https://github.com/NixOS/nixpkgs/pull/263923


New Failure: py34.test.reflection._reflection_servicer_test.ReflectionServicerTest

Test: py34.test.reflection._reflection_servicer_test.ReflectionServicerTest
Poll Strategy: None
URL: https://kokoro2.corp.google.com/job/grpc/job/ubuntu/job/master/job/grpc_basictests_multilang/850

https://sponge.corp.google.com/target?id=fbe5dee8-9756-4db3-87e1-3425ca0815ac&target=github/grpc/python_linux_opt_native&searchFor=&show=FAILED&sortBy=STATUS

Seems like this was a random socket failure for some reason on that specific run, probably not a fundamental issue. Will leave it open for a week and close if unseen.

I think https://github.com/grpc/grpc/pull/13843 would help alleviate the probability of events like this. Closing.


Handle exceptions in ImportTransitionListColumnSelectDlg.CheckForErrors

Fixed "Unhandled Error" that could happen doing Import Transition List if .skyd file is modified (reported anonymously on Exception Web)

On the other hand, it looks so generic that maybe we ought to have a property on LongWaitDlg that causes it to handle exceptions in this way? Nick has already added ExceptionUtil.IsProgrammingDefect() as a cover for my general unease with handling this generic, which is that it would otherwise show messages to the user about NREs and IndexOutOfBoundsExceptions, and the like.

We are still unlikely to find new cases of programming errors that we are accidentally showing to our users, since they are much less likely to report confusing error messages than they are to post to the exception web when an unexpected exception escapes proper handling. Just noting that. I know it has been difficult to maintain the ideal that I imagined starting this project.


Update docs to show how load differs from Next.js's getStaticProps

Currently the docs say that the load function is the Sveltekit equivalent to Next.js's getStaticProps or getServerSideProps.

load is the SvelteKit equivalent of getStaticProps or getServerSideProps in Next.js or asyncData in Nuxt.js.

This PR reflects the fact that Sveltekit's load function also runs on the client. Here's the new sentence:

load is similar to Next.js's getStaticProps or getServerSideProps or Nuxt.js's asyncData, except that it runs on both the server and the client.

In Next.js, getStaticProps and getServerSideProps both only run on the server. This means it's safe to run privileged code in these functions. However, according the current Sveltekit docs, load runs on both the client and server, meaning that you should not run privileged code in it.
This PR should help prevent Sveltekit users from accidentally creating security vulnerabilities in their apps due to this difference.
Before submitting the PR, please make sure you do the following

[ ] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
[x] This message body should clearly illustrate what problems it solves.
[ ] Ideally, include a test that fails without this PR but passes with it.

Tests

[ ] Run the tests with pnpm test and lint the project with pnpm lint

Changesets

[ ] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts

thanks!