Conditionally change where avatar shows up

Description
Reskins the account button and places it in the left nav when updated layout is used:
Also:

Fixed a TS error
Added aria-* to the button
Put a note for contributors to add aria-label and maybe a tooltip

Category
Enhancement

Check List

[ ] New functionality includes testing
[ ] New functionality has been documented
[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

The unit-test failures are due to OSD's mock of uiSettings incorrectly doesn't mock the start contract. This is fixed in https://github.com/opensearch-project/OpenSearch-Dashboards/pull/7637.

Changes look fine but seems like a unit test is failing


Haraka crash asn check

Since today have this issue
https://gist.github.com/Infern1/8486ad1bbc84fab5d197
#haraka -v
Haraka.js â Version: 2.6.2-toaster
#node -v
v0.10.38

Node version?

What was the resolution?

On May 13, 2015, at 12:43 PM, Matt Simerson<EMAIL_ADDRESS>wrote:
Closed #968.
—
Reply to this email directly or view it on GitHub.

If you view on GitHub, you'll see the linked PR #969

Got it. Just reading emails right now.

On May 13, 2015, at 1:04 PM, Matt Simerson<EMAIL_ADDRESS>wrote:
If you view on GitHub, you'll see the linked PR #969
—
Reply to this email directly or view it on GitHub.


Create an OutputStream from a Device and SupportedStreamConfig

This change adds support for getting an OutputStream and OutputStreamHandle from a specific device with a specific configuration instead of relying on getting the default configuration.
The new function try_from_device_config acts the same as try_from_device but adds an extra spal::SupportedStreamConfig argument. The caller is then responsible for getting a valid configuration from cpal to pass along.

Can you make try_new_output_stream call try_new_output_stream_config?

I've refactored the try_from_device function to call the try_from_device_config function with the default config. I also removed the method try_new_output_stream and replaced it with try_new_output_stream_config instead.


custom layout

I'm trying to use "setContentView" in acivity class and it has my own toolbar design too. Below toolbar i have ScrollView and ListView with id "@android:id/list". Does this library replace list of that id? Since when i use custom layout for activity, it does not scroll.
Default toolbar is ok but i can not change title color and typeface

I had put listView inside ScrollView so why it does not scroll, i fixed that and i can use custom layout now)

You should check the code I've made, to make it fit your needs. Sorry.
BTW, about ScrollView, it's recommended not to put it in a listView or vice
versa. Watch the video "the world of listView" . They talk about it. It's
an old video, but it's still relevant .
On Sun, Jul 12, 2015 at 4:54 PM, Jemshit Iskenderov <
<EMAIL_ADDRESS>wrote:

I'm trying to use "setContentView" in acivity class and it has my own
toolbar design too. Below toolbar i have ScrollView and ListView with id "
@android https://github.com/android:id/list". Does this library replace
list of that id? Since when i use custom layout for activity, it does not
scroll
—
Reply to this email directly or view it on GitHub
https://github.com/AndroidDeveloperLB/MaterialPreferenceLibrary/issues/7
.


property fielddata in Annotations/Mapping

In order to enable fielddata in the mapping-annotations the class Flowpack\ElasticSearch\Annotations\Mapping should have a property 'fielddata' (boolean).

Please add "search_analyzer" also :-)


Default proxyv2 image

remove references to proxy image
looking for feedback on the Dockerfile.proxy_debug file.  The dockerfile has some difference between proxy and proxyv2 dockerfile

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: GregHanson
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: wattli
Assign the PR to them by writing /assign @wattli in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@GregHanson: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
804ec125b891ffce4334f32239ff533730772543
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@GregHanson: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
804ec125b891ffce4334f32239ff533730772543
link
/test istio-unit-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
804ec125b891ffce4334f32239ff533730772543
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@GregHanson: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
804ec125b891ffce4334f32239ff533730772543
link
/test istio-unit-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
804ec125b891ffce4334f32239ff533730772543
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-dashboard.sh
804ec125b891ffce4334f32239ff533730772543
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@GregHanson: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
804ec125b891ffce4334f32239ff533730772543
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-dashboard.sh
804ec125b891ffce4334f32239ff533730772543
link
/test e2e-dashboard

prow/istio-unit-tests.sh
5998e5578994a67410b802914b709797345742ca
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm do you know why there are subtle difference between the proxy_debug and proxyv2 dockerfiles?
https://github.com/istio/istio/blob/master/pilot/docker/Dockerfile.proxy_debug#L16
and
https://github.com/istio/istio/blob/master/pilot/docker/Dockerfile.proxyv2#L16

@GregHanson: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
804ec125b891ffce4334f32239ff533730772543
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-dashboard.sh
804ec125b891ffce4334f32239ff533730772543
link
/test e2e-dashboard

prow/istio-unit-tests.sh
5998e5578994a67410b802914b709797345742ca
link
/test istio-unit-tests

prow/e2e-simpleTests.sh
804ec125b891ffce4334f32239ff533730772543
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@GregHanson: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
804ec125b891ffce4334f32239ff533730772543
link
/test e2e-dashboard

prow/istio-unit-tests.sh
5998e5578994a67410b802914b709797345742ca
link
/test istio-unit-tests

prow/e2e-simpleTests.sh
804ec125b891ffce4334f32239ff533730772543
link
/test e2e-simple

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
5998e5578994a67410b802914b709797345742ca
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@GregHanson: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
5998e5578994a67410b802914b709797345742ca
link
/test istio-unit-tests

prow/e2e-simpleTests.sh
804ec125b891ffce4334f32239ff533730772543
link
/test e2e-simple

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
5998e5578994a67410b802914b709797345742ca
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-dashboard.sh
5998e5578994a67410b802914b709797345742ca
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@GregHanson: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
5998e5578994a67410b802914b709797345742ca
link
/test istio-unit-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
5998e5578994a67410b802914b709797345742ca
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-dashboard.sh
5998e5578994a67410b802914b709797345742ca
link
/test e2e-dashboard

prow/e2e-simpleTests.sh
5998e5578994a67410b802914b709797345742ca
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@GregHanson: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
5998e5578994a67410b802914b709797345742ca
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-dashboard.sh
5998e5578994a67410b802914b709797345742ca
link
/test e2e-dashboard

prow/e2e-simpleTests.sh
5998e5578994a67410b802914b709797345742ca
link
/test e2e-simple

prow/istio-unit-tests.sh
70db9c4ccf7ac4981e160e0b4070a603ddafa0d4
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@GregHanson: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
5998e5578994a67410b802914b709797345742ca
link
/test e2e-dashboard

prow/e2e-simpleTests.sh
5998e5578994a67410b802914b709797345742ca
link
/test e2e-simple

prow/istio-unit-tests.sh
70db9c4ccf7ac4981e160e0b4070a603ddafa0d4
link
/test istio-unit-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
70db9c4ccf7ac4981e160e0b4070a603ddafa0d4
link
/test istio-pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@GregHanson: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests.sh
5998e5578994a67410b802914b709797345742ca
link
/test e2e-simple

prow/istio-unit-tests.sh
70db9c4ccf7ac4981e160e0b4070a603ddafa0d4
link
/test istio-unit-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
70db9c4ccf7ac4981e160e0b4070a603ddafa0d4
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-dashboard.sh
70db9c4ccf7ac4981e160e0b4070a603ddafa0d4
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@GregHanson: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
70db9c4ccf7ac4981e160e0b4070a603ddafa0d4
link
/test istio-unit-tests

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
70db9c4ccf7ac4981e160e0b4070a603ddafa0d4
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-dashboard.sh
70db9c4ccf7ac4981e160e0b4070a603ddafa0d4
link
/test e2e-dashboard

prow/e2e-simpleTests.sh
70db9c4ccf7ac4981e160e0b4070a603ddafa0d4
link
/test e2e-simple

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@GregHanson: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@GregHanson: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
70db9c4ccf7ac4981e160e0b4070a603ddafa0d4
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-dashboard.sh
70db9c4ccf7ac4981e160e0b4070a603ddafa0d4
link
/test e2e-dashboard

prow/e2e-simpleTests.sh
70db9c4ccf7ac4981e160e0b4070a603ddafa0d4
link
/test e2e-simple

prow/istio-unit-tests.sh
c5f9de80e44da835ca229f464c6b59a96dcd24eb
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@GregHanson: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
70db9c4ccf7ac4981e160e0b4070a603ddafa0d4
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-dashboard.sh
70db9c4ccf7ac4981e160e0b4070a603ddafa0d4
link
/test e2e-dashboard

prow/e2e-simpleTests.sh
70db9c4ccf7ac4981e160e0b4070a603ddafa0d4
link
/test e2e-simple

prow/istio-unit-tests.sh
c5f9de80e44da835ca229f464c6b59a96dcd24eb
link
/test istio-unit-tests

prow/istio-presubmit.sh
c5f9de80e44da835ca229f464c6b59a96dcd24eb
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@GregHanson: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-envoyv2-v1alpha3.sh
70db9c4ccf7ac4981e160e0b4070a603ddafa0d4
link
/test istio-pilot-e2e-envoyv2-v1alpha3

prow/e2e-simpleTests.sh
70db9c4ccf7ac4981e160e0b4070a603ddafa0d4
link
/test e2e-simple

prow/e2e-dashboard.sh
7f57462b8553f594b7d2d9f2e3bd53b45ff0e861
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@GregHanson: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
32d7ad9a458bdebca16aa0e0ded031a62293a75b
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: GregHanson, rshriram
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [rshriram]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@GregHanson: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
32d7ad9a458bdebca16aa0e0ded031a62293a75b
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Ug, the merge beat me to it. Is there a reason we renamed to proxyv2 rather than just updating the image of the proxy container to use the v2 APIs (i.e. kill the proxyv2 image and just make it proxy)? That should not break any other users of the proxy image since all Istio YAMLs pin the image to a specific tag.

@GregHanson
This have broken all prow tests apparently...
https://prow.istio.io/?repo=istio%2Fistio&type=postsubmit
https://storage.googleapis.com/istio-prow/e2e-dashboard/298/build-log.txt
Could you take a look?

Sorry it think it might be noise.
The error was W0626 22:18:14.568] package istio.io/test-infra/boskos/cmd/mason_client: unrecognized import path "istio.io/test-infra/boskos/cmd/mason_client" (https fetch: Get https://istio.io/test-infra/boskos/cmd/mason_client?go-get=1: EOF)
which may be a timing issue with https://github.com/istio/istio.github.io/pull/1594
Will monitor for subsequent post submit runs.


HomeRemove some unset/checked environment checks

These will be redundant once environment filtering is on by default in #3529.

What if the user needs to turn off ENV filtering for some reason?  Won't we still want BASH_ENV and GEM_{PATH,HOME} deleted?

What if the user needs to turn off ENV filtering for some reason? Won't we still want BASH_ENV and GEM_{PATH,HOME} deleted?

In that case: no, if things blow up and they have ENV filtering disabled, we won't be helping them with their issues.


chore: using tw default config

Reduces one file to maintain in the repo. However, tailwindcss/stubs/simpleConfig.stub maybe more what the original config was looking for, but importing it seems to be an issue with pnpm (and typescript) - I'm open to suggestions.

Open to get @manniL opinion on this

Makes sense to me as it resembles the current config pretty accurately, so won't introduce a breaking change.  ☺


Posts export with ID, not name

The posts should export with their names instead of IDs, because that will mean the SSG can patch internal links together (hopefully).

Fixed, posts now export with correct filenames and in YYYY/MM folders, so internal links stand more of a chance of working. Fixed in db34578aea71314073ff28c61b20a9755b3568d8.


Support dask dataframe as y for classifier.

Closes #5073 .

@trivialfis The test job at https://xgboost-ci.net/blue/organizations/jenkins/xgboost/detail/PR-5077/2/pipeline/112/ has been hanging for last 3 hours, so I killed it.

@RAMitchell Please review.

Merged as dask doesn't support Windows.


adds still playing

using the 3.3 version
and the ads is still playing on windows 10 google chrome

Still ads were playing on youtube

use Version 2.9. This works.

This was fixed in the latest version


Add 2 more website for General search engine

WolframAlpha: WolframAlpha is a computational search engine that provides answers to factual queries and performs mathematical and scientific calculations. It's particularly useful for educational and research-related searches.
Ecosia: Ecosia is an eco-friendly search engine that uses its advertising revenue to plant trees. It allows you to contribute to reforestation efforts while searching the web.

@edoardottt  need any more changes??

wolphram alpha is useless for an hacker (https://github.com/edoardottt/awesome-hacker-search-engines/pull/139)
ecosia is just a portal for bing (https://github.com/edoardottt/awesome-hacker-search-engines/pull/150)


2to3, workaround breaking changes

Not everyone needs to install pyspeckit.

Looks good.  Did you want to do astropy.log -> logging.log before I merge this?

OK I made the changes:

Just use standard library logging
capitalize HAS_PYSPECKIT variable


FancyWebSocket doesn't work with SSL protocal

Hi,
Now I have an issue with SSL and WebSocket.
I use Xampp on Windows and I created self signed Certificate.
I set the websocket server url as "wss://<IP_ADDRESS>:9300" and add the configuration on http-ssl.conf as same as default_443.(just copy and paste it and changed port as 9300).
And the Jquery part is following.
if ( typeof(MozWebSocket) == 'function' )
this.conn = new MozWebSocket(url);
else
this.conn = new WebSocket(url);
But the send part has an error

InvalidStateError : An attempt was made to use an object that is not, or is no longer, usable.
The code is:
this.send = function(event_name, event_data){      this.conn.send(event_data);      return this; };

So I modified the FancyWebSocket.js file as following:
this.conn = new MozWebSocket(url, { 	protocolVersion: 8, 	origin: 'https://<IP_ADDRESS>:443', 	rejectUnauthorized: false } );
But the browser says :

SyntaxError: An invalid or illegal string was specified

Help me please,,,,
Thanks

We don't know what FancyWebSocket is.
this.conn = new MozWebSocket(url, { protocolVersion: 8, origin: 'https://<IP_ADDRESS>:443', rejectUnauthorized: false } );

No idea why you are using such a wrong API into a browser.
Your issue does not seem to be related to this library.

Hi,
Now I have an issue with SSL and WebSocket.
I use Xampp on Windows and I created self signed Certificate.
I set the websocket server url as "wss://<IP_ADDRESS>:9300" and add the configuration on http-ssl.conf as same as default_443.(just copy and paste it and changed port as 9300).
And the Jquery part is following.
if ( typeof(MozWebSocket) == 'function' )
this.conn = new MozWebSocket(url);
else
this.conn = new WebSocket(url);
But the send part has an error

InvalidStateError : An attempt was made to use an object that is not, or is no longer, usable.
The code is:
this.send = function(event_name, event_data){      this.conn.send(event_data);      return this; };

So I modified the FancyWebSocket.js file as following:
this.conn = new MozWebSocket(url, { protocolVersion: 8, origin: 'https://<IP_ADDRESS>:443', rejectUnauthorized: false } );
But the browser says :

SyntaxError: An invalid or illegal string was specified

Help me please,,,,
Thanks

hello friend, could you solve the problem?


modules-closure.sh: rewrite to use modinfo + small rust program

Motivation for this change
Should fix #60416 (leakage of information from the building system), because modinfo only looks at the dependency information in the modules themselves.
Because modinfo only lists direct dependencies, we have to compute the closure ourselves with this approach.
Same approach as https://github.com/NixOS/nixpkgs/pull/107871, but the closure computation happens in a small rust program.
Based on https://github.com/NixOS/nixpkgs/pull/109050 which should be merged before this!
Things done
This should produce bit-for-bit identical results compared to the old version (unless you have modules / module options on your kernel cmdline of course). You can (and should) check that with diffoscope.

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Out of idle curiosity, is there a reason more of the modules_closure.sh logic wasn't lifted into rust?

Out of idle curiosity, is there a reason more of the modules_closure.sh logic wasn't lifted into rust?

Out of idle curiosity, is there a reason more of the modules_closure.sh logic wasn't lifted into rust?

No reason in particular, I might do more actually.
I wanted to get something out there, to get some feedback first.

Out of idle curiosity, is there a reason more of the modules_closure.sh logic wasn't lifted into rust?

No reason in particular, I might do more actually.
I wanted to get something out there, to get some feedback first.

Before I review this, it puts rustc into the kernel build closure, right? Do we already depend on rustc for that? Do we want to? I’d say it’s okay, but other people might have a different opinion.

Before I review this, it puts rustc into the kernel build closure, right? Do we already depend on rustc for that? Do we want to? I’d say it’s okay, but other people might have a different opinion.

Before I review this, it puts rustc into the kernel build closure, right? Do we already depend on rustc for that? Do we want to? I’d say it’s okay, but other people might have a different opinion.

I think it's not in the closure currently. But it should not be needed for compiling the kernel even with this. The piece of code here should only be needed when assembling an initrd. Maybe the rust program should go in all-packages, so its built by hydra? Then most people will never see rustc anyway, except for those that build everything from scratch.
By the way I just started to learn rust, so if you should review this I am very much interested in opinion on style etc. as well!

Before I review this, it puts rustc into the kernel build closure, right? Do we already depend on rustc for that? Do we want to? I’d say it’s okay, but other people might have a different opinion.

I think it's not in the closure currently. But it should not be needed for compiling the kernel even with this. The piece of code here should only be needed when assembling an initrd. Maybe the rust program should go in all-packages, so its built by hydra? Then most people will never see rustc anyway, except for those that build everything from scratch.
By the way I just started to learn rust, so if you should review this I am very much interested in opinion on style etc. as well!

The use right here is probably fine, it's strictly a "native build input" use case, so no cross-compilation will be required for this feature.
(The following does not really apply for this instance... But this is causing a precedent, so I will say it.)
With that said, adding Rust dependencies to the basic build environment without nix-build -A pkgsCross.aarch64-multiplatform.tests.writers.bin.rust building successfully is, in my opinion, a bad idea.
Adding Rust dependencies as things are currently would be a regression against cross-compiling NixOS, which @flokli had managed to manage without external workarounds for a few generations. (Before a regression in an upstream dep caused new breakage.)

The use right here is probably fine, it's strictly a "native build input" use case, so no cross-compilation will be required for this feature.
(The following does not really apply for this instance... But this is causing a precedent, so I will say it.)
With that said, adding Rust dependencies to the basic build environment without nix-build -A pkgsCross.aarch64-multiplatform.tests.writers.bin.rust building successfully is, in my opinion, a bad idea.
Adding Rust dependencies as things are currently would be a regression against cross-compiling NixOS, which @flokli had managed to manage without external workarounds for a few generations. (Before a regression in an upstream dep caused new breakage.)

The use right here is probably fine, it's strictly a "native build input" use case, so no cross-compilation will be required for this feature.
(The following does not really apply for this instance... But this is causing a precedent, so I will say it.)
With that said, adding Rust dependencies to the basic build environment without nix-build -A pkgsCross.aarch64-multiplatform.tests.writers.bin.rust building successfully is, in my opinion, a bad idea.
Adding Rust dependencies as things are currently would be a regression against cross-compiling NixOS, which @flokli had recently managed to manage without external workarounds for a few generations. (Before a regression in an upstream dep caused new breakage.)

I think our rust infrastructure should be cross-compile ready. I don't know about writers but a fix should not be that complicated.

The use right here is probably fine, it's strictly a "native build input" use case, so no cross-compilation will be required for this feature.
(The following does not really apply for this instance... But this is causing a precedent, so I will say it.)
With that said, adding Rust dependencies to the basic build environment without nix-build -A pkgsCross.aarch64-multiplatform.tests.writers.bin.rust building successfully is, in my opinion, a bad idea.
Adding Rust dependencies as things are currently would be a regression against cross-compiling NixOS, which @flokli had recently managed to manage without external workarounds for a few generations. (Before a regression in an upstream dep caused new breakage.)

I think our rust infrastructure should be cross-compile ready. I don't know about writers but a fix should not be that complicated.

I think our rust infrastructure should be cross-compile ready. I don't know about writers but a fix should not be that complicated. Otherwise just switching to buildRustPackage would be the easy fix.

Hm, I guess I had a wrong commit up when I last tried, yesterday, as it failed to build relatively early. Trying fresh, and the writeRust writer currently doesn't work, but manix cross-compiled fine. So there's some work to do yet, but nothing too concerning as our Rust ecosystem itself proves to be able to manage.
We don't yet have a job in Hydra to look at to guesstimate whether Rust cross-compilation through pkgsCross is consistently working well or not.
Note that the concern is still present: we shouldn't add dependencies (any!) to the base system unless cross-compilation for them is figured out.
Sorry to for the noise right here.

I think our rust infrastructure should be cross-compile ready. I don't know about writers but a fix should not be that complicated. Otherwise just switching to buildRustPackage would be the easy fix.

Hm, I guess I had a wrong commit up when I last tried, yesterday, as it failed to build relatively early. Trying fresh, and the writeRust writer currently doesn't work, but manix cross-compiled fine. So there's some work to do yet, but nothing too concerning as our Rust ecosystem itself proves to be able to manage.
We don't yet have a job in Hydra to look at to guesstimate whether Rust cross-compilation through pkgsCross is consistently working well or not.
Note that the concern is still present: we shouldn't add dependencies (any!) to the base system unless cross-compilation for them is figured out.
Sorry to for the noise right here.

I think our rust infrastructure should be cross-compile ready. I don't know about writers but a fix should not be that complicated. Otherwise just switching to buildRustPackage would be the easy fix.

Hm, I guess I had a wrong commit up when I last tried, yesterday, as it failed to build relatively early. Trying fresh, and the writeRust writer currently doesn't work, but manix cross-compiled fine. So there's some work to do yet, but nothing too concerning as our Rust ecosystem itself proves to be able to manage.
We don't yet have a job in Hydra to look at to guesstimate whether Rust cross-compilation through pkgsCross is consistently working well or not.
Note that the concern is still present: we shouldn't add dependencies (any!) to the base system unless cross-compilation for them is figured out.
Sorry to for the noise right here.

Yeah, this is up to people interested in cross-compilation and not in the scope of this PR. Right now it is too much of a burden to ask contributors to test cross-compilation like this one if it the majority of dependencies to cross-compile NixOS are not cached by hydra.

I think our rust infrastructure should be cross-compile ready. I don't know about writers but a fix should not be that complicated. Otherwise just switching to buildRustPackage would be the easy fix.

Hm, I guess I had a wrong commit up when I last tried, yesterday, as it failed to build relatively early. Trying fresh, and the writeRust writer currently doesn't work, but manix cross-compiled fine. So there's some work to do yet, but nothing too concerning as our Rust ecosystem itself proves to be able to manage.
We don't yet have a job in Hydra to look at to guesstimate whether Rust cross-compilation through pkgsCross is consistently working well or not.
Note that the concern is still present: we shouldn't add dependencies (any!) to the base system unless cross-compilation for them is figured out.
Sorry to for the noise right here.

Yeah, this is up to people interested in cross-compilation and not in the scope of this PR. Right now it is too much of a burden to ask contributors to test cross-compilation like this one if it the majority of dependencies to cross-compile NixOS are not cached by hydra.

Yeah, this is up to people interested in cross-compilation and not in the scope of this PR.

Hm...

Right now it is too much of a burden to ask contributors to test cross-compilation like this one if it the majority of dependencies to cross-compile NixOS are not cached by hydra.

I would agree on a simple change, but this is about introducing a totally new ecosystem as a basic build dependency to NixOS. This is a design decision with broad repercussions.
Yes it is up to the people interested in cross-compilation, and here I am, stating my concerns.
I agree that it is too much of a burden right now to test it. I'm not asking that the change works as it is with cross-compilation. I'm asking that, as a distribution, we properly consider whether it is causing more breakage than it is worth.
In this instance adding Rust is okay, it looks like it does cross-compile with pkgsCross. Sure, writers fail, but at the very least the ecosystem is not completely in a bad state. If it had been in a bad state like it was during last year (not working), then it would have been a different thing.
I will state it again, in case people only skim my message: I am not against the change. I am bringing up concerns that any decisions to greatly affect the build closure of the base system should keep in mind that cross-compilation should be in a good enough state. It's fine if it doesn't work at the moment, things are still in flux, but they have to be in a place where it is known that cross-compilation was working fine recently.

[...] it is up to people interested in cross-compilation

Repeating this from your message again. What is the solution, if not to raise concerns? Should this get merged-in, then someone interested in cross-compilation comes behind, reverts?

Yeah, this is up to people interested in cross-compilation and not in the scope of this PR.

Hm...

Right now it is too much of a burden to ask contributors to test cross-compilation like this one if it the majority of dependencies to cross-compile NixOS are not cached by hydra.

I would agree on a simple change, but this is about introducing a totally new ecosystem as a basic build dependency to NixOS. This is a design decision with broad repercussions.
Yes it is up to the people interested in cross-compilation, and here I am, stating my concerns.
I agree that it is too much of a burden right now to test it. I'm not asking that the change works as it is with cross-compilation. I'm asking that, as a distribution, we properly consider whether it is causing more breakage than it is worth.
In this instance adding Rust is okay, it looks like it does cross-compile with pkgsCross. Sure, writers fail, but at the very least the ecosystem is not completely in a bad state. If it had been in a bad state like it was during last year (not working), then it would have been a different thing.
I will state it again, in case people only skim my message: I am not against the change. I am bringing up concerns that any decisions to greatly affect the build closure of the base system should keep in mind that cross-compilation should be in a good enough state. It's fine if it doesn't work at the moment, things are still in flux, but they have to be in a place where it is known that cross-compilation was working fine recently.

[...] it is up to people interested in cross-compilation

Repeating this from your message again. What is the solution, if not to raise concerns? Should this get merged-in, then someone interested in cross-compilation comes behind, reverts?

Repeating this from your message again. What is the solution, if not to raise concerns? Should this get merged-in, then someone interested in cross-compilation comes behind, reverts?

I was talking about adding rust to pkgsCross not beeing in scope of this PR. Not the other stuff.

Repeating this from your message again. What is the solution, if not to raise concerns? Should this get merged-in, then someone interested in cross-compilation comes behind, reverts?

I was talking about adding rust to pkgsCross not beeing in scope of this PR. Not the other stuff.

wrt. cross compiling, am I correct that putting the rust helper in a proper package and using buildRustPackage will fix the issue (then I will just do that)?

wrt. cross compiling, am I correct that putting the rust helper in a proper package and using buildRustPackage will fix the issue (then I will just do that)?

Or use packages from buildPackages in nativeBuildInputs. Though exposing the tool as a package isn't a bad idea either.

Or use packages from buildPackages in nativeBuildInputs. Though exposing the tool as a package isn't a bad idea either.

wrt. cross compiling, am I correct that putting the rust helper in a proper package and using buildRustPackage will fix the issue (then I will just do that)?

I would prefer this option because than you can also build the tool without having to rebuild nixos.

wrt. cross compiling, am I correct that putting the rust helper in a proper package and using buildRustPackage will fix the issue (then I will just do that)?

I would prefer this option because than you can also build the tool without having to rebuild nixos.

It uses callPackage and buildRustPackage with a proper cargo setup now. The tool is exposed as copy-modules-closure in all-packages.nix. That should hopefully alleviate all cross compilation and bootstrapping concerns.

It uses callPackage and buildRustPackage with a proper cargo setup now. The tool is exposed as copy-modules-closure in all-packages.nix. That should hopefully alleviate all cross compilation and bootstrapping concerns.

$ nix-build copy-modules-closure
...

hash mismatch in fixed-output derivation '/nix/store/0vg9677q2zybiwhmhp7n6aazvy1ay2lp-copy-modules-closure-0.1.0-vendor.tar.gz':
  wanted: sha256:09kfhrsi98d0353zq4xqh9ckvfzg3k7bpn6a1rpyj74qakw2z3m1
  got:    sha256:090ay39k7mapcm78a7dijaprry2h79rpl25pmf79sgi8j7ih748h

With the hash fixed, cross-compiling also works (untested binary). So what you had to do is likely fine. Weird about the hash, I guess one of your earlier hacking session didn't end up with a proper hash change?

$ nix-build copy-modules-closure
...

hash mismatch in fixed-output derivation '/nix/store/0vg9677q2zybiwhmhp7n6aazvy1ay2lp-copy-modules-closure-0.1.0-vendor.tar.gz':
  wanted: sha256:09kfhrsi98d0353zq4xqh9ckvfzg3k7bpn6a1rpyj74qakw2z3m1
  got:    sha256:090ay39k7mapcm78a7dijaprry2h79rpl25pmf79sgi8j7ih748h

With the hash fixed, cross-compiling also works (untested binary). So what you had to do is likely fine. Weird about the hash, I guess one of your earlier hacking session didn't end up with a proper hash change?

With the hash fixed, cross-compiling also works (untested binary). So what you had to do is likely fine. Weird about the hash, I guess one of your earlier hacking session didn't end up with a proper hash change?

Should be fixed now anyway.

With the hash fixed, cross-compiling also works (untested binary). So what you had to do is likely fine. Weird about the hash, I guess one of your earlier hacking session didn't end up with a proper hash change?

Should be fixed now anyway.

I tried this change with nixos-shell using the following
NixOS configuration:
{ pkgs, ... }: {}

<<< NixOS Stage 1 >>>

loading module virtio_balloon...
loading module virtio_console...
loading module virtio_rng...
loading module dm_mod...
running udev...
Starting version 247
kbd_mode: KDSKBMODE: Inappropriate ioctl for device
starting device mapper and LVM...
hwclock: settimeofday: Invalid argument
checking /dev/vda...
fsck (busybox 1.32.1)
[fsck.ext4 (1) -- /mnt-root/] fsck.ext4 -a /dev/vda
/dev/vda: clean, 241/33554432 files, 2391411/134217728 blocks
mounting /dev/vda on /...
[    1.096673] EXT4-fs (vda): Cannot load crc32c driver.
mount: mounting /dev/vda on /mnt-root/ failed: No such file or directory

An error occurred in stage 1 of the boot process, which must mount the
root filesystem on `/mnt-root' and then start stage 2.  Press one
of the following keys:

  r) to reboot immediately
  *) to ignore the error and continue

I tried this change with nixos-shell using the following
NixOS configuration:
{ pkgs, ... }: {}

<<< NixOS Stage 1 >>>

loading module virtio_balloon...
loading module virtio_console...
loading module virtio_rng...
loading module dm_mod...
running udev...
Starting version 247
kbd_mode: KDSKBMODE: Inappropriate ioctl for device
starting device mapper and LVM...
hwclock: settimeofday: Invalid argument
checking /dev/vda...
fsck (busybox 1.32.1)
[fsck.ext4 (1) -- /mnt-root/] fsck.ext4 -a /dev/vda
/dev/vda: clean, 241/33554432 files, 2391411/134217728 blocks
mounting /dev/vda on /...
[    1.096673] EXT4-fs (vda): Cannot load crc32c driver.
mount: mounting /dev/vda on /mnt-root/ failed: No such file or directory

An error occurred in stage 1 of the boot process, which must mount the
root filesystem on `/mnt-root' and then start stage 2.  Press one
of the following keys:

  r) to reboot immediately
  *) to ignore the error and continue

I tried this change with nixos-shell using the following
NixOS configuration:
{ pkgs, ... }: {}

<<< NixOS Stage 1 >>>

loading module virtio_balloon...
loading module virtio_console...
loading module virtio_rng...
loading module dm_mod...
running udev...
Starting version 247
kbd_mode: KDSKBMODE: Inappropriate ioctl for device
starting device mapper and LVM...
hwclock: settimeofday: Invalid argument
checking /dev/vda...
fsck (busybox 1.32.1)
[fsck.ext4 (1) -- /mnt-root/] fsck.ext4 -a /dev/vda
/dev/vda: clean, 241/33554432 files, 2391411/134217728 blocks
mounting /dev/vda on /...
[    1.096673] EXT4-fs (vda): Cannot load crc32c driver.
mount: mounting /dev/vda on /mnt-root/ failed: No such file or directory

An error occurred in stage 1 of the boot process, which must mount the
root filesystem on `/mnt-root' and then start stage 2.  Press one
of the following keys:

  r) to reboot immediately
  *) to ignore the error and continue

Which version did you try? It was quite broken in between, can you retry from the latest version of this pr?

I tried this change with nixos-shell using the following
NixOS configuration:
{ pkgs, ... }: {}

<<< NixOS Stage 1 >>>

loading module virtio_balloon...
loading module virtio_console...
loading module virtio_rng...
loading module dm_mod...
running udev...
Starting version 247
kbd_mode: KDSKBMODE: Inappropriate ioctl for device
starting device mapper and LVM...
hwclock: settimeofday: Invalid argument
checking /dev/vda...
fsck (busybox 1.32.1)
[fsck.ext4 (1) -- /mnt-root/] fsck.ext4 -a /dev/vda
/dev/vda: clean, 241/33554432 files, 2391411/134217728 blocks
mounting /dev/vda on /...
[    1.096673] EXT4-fs (vda): Cannot load crc32c driver.
mount: mounting /dev/vda on /mnt-root/ failed: No such file or directory

An error occurred in stage 1 of the boot process, which must mount the
root filesystem on `/mnt-root' and then start stage 2.  Press one
of the following keys:

  r) to reboot immediately
  *) to ignore the error and continue

Which version did you try? It was quite broken in between, can you retry from the latest version of this pr?

So insmod-list should be correct now. Also it does turn out modinfo sometimes outputs aliases in the deps field.
For example modinfo -F depends raid456 has md-mod which resolved to md_mod.

So insmod-list should be correct now. Also it does turn out modinfo sometimes outputs aliases in the deps field.
For example modinfo -F depends raid456 has md-mod which resolved to md_mod.

Still the same issue. I rebased your branch to master: https://github.com/Mic92/nixpkgs/tree/modules-closure-modinfo-rust
Command the same as above.

Still the same issue. I rebased your branch to master: https://github.com/Mic92/nixpkgs/tree/modules-closure-modinfo-rust
Command the same as above.

Still the same issue. I rebased your branch to master: https://github.com/Mic92/nixpkgs/tree/modules-closure-modinfo-rust
Command the same as above.

I can indeed reproduce this with nixos-shell. I think its because order in insmod-list matters. modprobe used to output the modules in the correct order for insmod (which is called here), and now the order is different. Will have to think about this a bit.

Still the same issue. I rebased your branch to master: https://github.com/Mic92/nixpkgs/tree/modules-closure-modinfo-rust
Command the same as above.

I can indeed reproduce this with nixos-shell. I think its because order in insmod-list matters. modprobe used to output the modules in the correct order for insmod (which is called here), and now the order is different. Will have to think about this a bit.

So the issue was that the code ignored soft dependencies, it should work now.
Now it appears that the new code over approximates slightly though; will have to investigate that..

So the issue was that the code ignored soft dependencies, it should work now.
Now it appears that the new code over approximates slightly though; will have to investigate that..

fwiw I agree with @samueldr that we shouldn’t introduce new compiler toolchains until we are 100% certain they do not degrade bootstrapping and/or cross. These things are hard enough to do as-is, and incredibly worthwhile, so we shouldn’t risk them for small optional improvements. (As opposed to e.g. MacOS support, which should be at most a secondary concern to non MacOS users.)

fwiw I agree with @samueldr that we shouldn’t introduce new compiler toolchains until we are 100% certain they do not degrade bootstrapping and/or cross. These things are hard enough to do as-is, and incredibly worthwhile, so we shouldn’t risk them for small optional improvements. (As opposed to e.g. MacOS support, which should be at most a secondary concern to non MacOS users.)

Rust cross-compilation in nixpkgs was fixed two years ago: https://github.com/NixOS/nixpkgs/pull/56540
And it also seems that this program could be cross-compiled after fixing the issue with native build inputs.

fwiw I agree with @samueldr that we shouldn’t introduce new compiler toolchains until we are 100% certain they do not degrade bootstrapping and/or cross. These things are hard enough to do as-is, and incredibly worthwhile, so we shouldn’t risk them for small optional improvements. (As opposed to e.g. MacOS support, which should be at most a secondary concern to non MacOS users.)

If we could cover more of these parts in hydra jobs (and effectively making them channel blockers), we could ensure they don't break without noticing it.

A related discussion worth looking at, a python package deep in the dependency stack switched to rust and there was quite some fallout: https://github.com/pyca/cryptography/issues/5771

@xaverdh still working on this?

Not currently, but I will have more time for working on this towards the end of this year.

I can pick this up again, if we agree that it is all right to have a rust compiler in the closure?

We also need rust to build the systemd initrd, so this should be fine.

I'm playing around with some code changes and fixing some clippy warnings etc.
What's the best way to test this? :slightly_smiling_face:

I'm playing around with some code changes and fixing some clippy warnings etc. What's the best way to test this? slightly_smiling_face

You want to build the config.system.build.bootStage1.modulesClosure attribute of a nixos configuration.

concerning documentation, should I add a README in pkgs/build-support/kernel/copy-modules-closure?

There already is a short description in pkgs/build-support/kernel/modules-closure.nix. The split between the two is a bit weird, should I make the rust program call depmod as well, or is it good to separate the two steps?


"Full Name" field does not autofocus

Minor suggestion: make the "Full Name" input auto focus, so that as soon as the popup appears, the user can fill the form out without having to click on any of the fields. This might have a slight (probably positive) impact on conversion rate.

It's probably do-able by setting autofocus on the input within the iframe HTML file, though you might also have to call focus() on the iframe too.
Don't feel bad closing this ticket if this suggestion is unwelcome!

if the purpose of this is ease of use, then enlarging the letter box would help a lot.
a lotta people involved with computer's got some kind of sight alteration, and having to do an effort just to read what we're supposed to be sending kinda kills all the intent


Remove special handling for -swift-version

Trying to rely on OTHER_SWIFT_FLAGS as much as possible.

Looks like Xcode applies these settings after OTHER_SWIFT_FLAGS, so this breaks BwX mode, and possibly indexing...

https://github.com/MobileNativeFoundation/rules_xcodeproj/pull/2247


Impossible to create a manyToMany circular reference on GraphQL

Before opening, please confirm:

[X] I have installed the latest version of the Amplify CLI (see above), and confirmed that the issue still persists.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
[X] I have removed any sensitive information from my code snippets and submission.

How did you install the Amplify CLI?
yarn
If applicable, what version of Node.js are you using?
16
Amplify CLI Version
9.2.1
What operating system are you using?
windows
Did you make any manual changes to the cloud resources managed by Amplify? Please describe the changes made.
No manual changes made
Amplify Categories
api
Amplify Commands
push
Describe the bug
There is no way to make a circular manyToMany relationship in a table.
The following error message is presented when I try to do it:
@manyToMany relation 'SubjectContentRequirements' must be used in exactly two locations.
Expected behavior
A table called SubjectRequirements should have been created
Reproduction steps
create a project using amplify
add the api
update the schema.graphql file with the provided schema
execute amplify push
GraphQL schema(s)

type Subject @model @auth(rules: [{allow: public}])  {
    id: ID! @primaryKey
    title: String

    Requires: [Subject] @manyToMany(relationName: "SubjectRequirements")
    Required: [Subject] @manyToMany(relationName: "SubjectRequirements")
}

Project Identifier
No response
Log output

# Put your logs below this line
🛑 An error occurred during the push operation: /
@manyToMany relation 'SubjectContentRequirements' must be used in exactly two locations.
⚠ Review the Amplify CLI troubleshooting guide for potential next steps: https://docs.amplify.aws/cli/project/troubleshooting/
PS C:\source\project\app\myApp> amplify version

Additional information
No response

Hi @JonatasFischer - thank you for reaching out. It looks like the primary reason this is failing today is because the dual manyToMany directives are unwrapping to identical GSIs and queries defined in the generated output, causing a collision. I think you can model this in a more manual way by explicitly defining the join table that you'll be using to connect your various models (which is effectively just a separate model that has indexes on the relevant source ids for easy queryability).
I haven't tested the below end to end, but I think you can achieve a similar outcome w/ a schema something like this.
type Subject @model @auth(rules: [{allow: public}])  {
    id: ID!
    title: String
    requires: [SubjectRequirements] @hasMany(indexName: "byRequires", fields: ["id"])
    required: [SubjectRequirements] @hasMany(indexName: "byRequired", fields: ["id"])
}

type SubjectRequirements @model @auth(rules: [{allow: public}]) {
  id: ID!
  requiresID: ID! @index(name: "byRequires")
  requires: Subject @belongsTo(fields: ["requiresID"])
  requiredID: ID! @index(name: "byRequired")
  required: Subject @belongsTo(fields: ["requiredID"])
}

It's worth noting however, that if you're planning to use Datastore https://docs.amplify.aws/lib/datastore/getting-started/q/platform/js/ then you'll probably want to avoid cyclical relationships in general, because although we can generate apis with cycles in them with AppSync, local database constraints in Datastore mean initialization of the local database will likely fail.

Hello @JonatasFischer, following up on the suggestion provided by @alharris-at. Please do let us know if you require any assistance on this.


Hotswap support

Hi, the project is super interesting. Did you plan to add the hotswap feature in the future and to release the gerber file?

Regarding the gerber files: You can install kicad, open the project and plot the gerber & drill files yourself to then upload it to your favorite pcb manufacturer.
I just did this with JLCPCB. They have a FAQ where they tell you how to configure kicad to get proper gerber files so that they can process them. Not sure if it works properly cause it's my first time doing this but I'm quite confident.
I also had a look at pcbway and they need different settings for the plotting of the gerber files. So I think that might be why he/she/them did not include them in the repository (just guessing).

hey, i uploaded the gerber.zip as release 1.0. Keeping the issue for reference if I make hotswaps for next version.

Thank you very much! I really appreciate it!  :-)

Fixed in 1355b80bf61a885dfb9796597a6b3016640277ef


Feature request

i know how it works but still add example for tools usage, Check and others

added


feat: error out when config file contains invalid options

Closes #22863
Throws an error on server startup if there are values in the config file which do not correspond to a valid configuration option. Also adds debug logging if a config file is loaded.

Example when starting the server with a bad config value - bind-address used instead of http-bind-address:
./bin/darwin/influxd
error: unknown flags from config file at /Users/wbaker/influxdb/cmd/influxd/config.toml (see https://docs.influxdata.com/influxdb/latest/reference/config-options/ for supported flags): bind-address

If a full 1.x config is used, there will be many invalid options:
./bin/darwin/influxd
error: unknown flags from config file at /Users/wbaker/influxdb/cmd/influxd/config.toml (see https://docs.influxdata.com/influxdb/latest/reference/config-options/ for supported flags): coordinator.max-select-buckets,logging.level,http.flux-log-enabled,http.pprof-auth-enabled,http.ping-auth-enabled,http.pprof-enabled,coordinator.write-timeout,data.compact-throughput,http.bind-socket,http.auth-enabled,subscriber.write-concurrency,data.trace-logging-enabled,data.compact-throughput-burst,http.max-row-limit,coordinator.max-select-series,logging.suppress-logo,subscriber.http-timeout,tls.max-version,monitor.store-database,data.tsm-use-madv-willneed,udp,opentsdb,http.realm,http.bind-address,monitor.store-enabled,data.series-id-set-cache-size,data.wal-dir,data.cache-max-memory-size,data.cache-snapshot-memory-size,http.prom-read-auth-enabled,http.max-connection-limit,coordinator.log-queries-after,coordinator.max-concurrent-queries,monitor.store-interval,data.max-concurrent-compactions,data.series-file-max-concurrent-snapshot-compactions,continuous_queries.enabled,http.flux-enabled,data.dir,data.index-version,data.max-index-log-file-size,continuous_queries.run-interval,http.https-private-key,http.write-tracing,data.max-series-per-database,data.strict-error-handling,data.max-values-per-tag,data.cache-snapshot-write-cold-duration,meta.logging-enabled,http.unix-socket-enabled,http.https-enabled,bind-address,coordinator.max-select-point,logging.format,subscriber.enabled,data.validate-keys,shard-precreation.enabled,shard-precreation.check-interval,retention.enabled,meta.retention-autocreate,graphite,http.log-enabled,http.max-enqueued-write-limit,coordinator.query-timeout,http.enqueued-write-timeout,tls.min-version,subscriber.write-buffer-size,collectd,http.unix-socket-permissions,http.max-body-size,subscriber.ca-certs,retention.check-interval,subscriber.insecure-skip-verify,continuous_queries.log-enabled,http.debug-pprof-enabled,http.max-concurrent-write-limit,http.access-log-path,http.enabled,shard-precreation.advance-period,data.wal-fsync-delay,data.compact-full-write-cold-duration,continuous_queries.query-stats-enabled,meta.dir,http.suppress-write-log,http.shared-secret,http.https-certificate,data.query-log-enabled

Updated to check specifically for 1.x config values (and only 1.x config values).


Order is not being completed

Inside commerce.coinbase account, I can confirm that the crypto transaction was completed.
But it is updating on wordpress woocommerce.
I connected 3 websites to one coinbase account.
Can you let me know how to fix?
Thank you!

Hello. Isn't there any news to fix this issue?


Adding Theme/Color Support

I saw in the todo (and HN post) that you'd like to add Color/Theme support. Do you have an idea of how you'd like this to work? I've got some spare time this evening.

Just being able to define the text- and background-color in the settings would be enough for me. I wouldn't want to change anything else but flipping the colors, because the white-on-black is a bit harsh on the eyes.

i'd definitely would like to see this happen.


udev: extend rules for compatibility in SCSI and older NVMe environments

There are multiple combinations of disks depending on instance vm size and configuration:

NVMe-only disks in v6+ families

Mixed disk with SCSI OS & resource disks alongside NVMe local disks e.g. LSv2/3

Mixed disk with SCSI resource disk alongside NVMe OS and data disks e.g. Ebdsv5 with NVMe controller configured

SCSI-only disks with most instances prior to v6

For SCSI OS disk, export as /dev/disk/azure/os similar to NVMe OS disk.
For SCSI resource disk, export as /dev/disk/azure/resource as already done in the existing udev rules implementations. Ideally we'd expose SCSI local disks in the same manner as local NVMe disks, but since we cannot be sure of what environment we're in, /dev/disk/azure/local will be limited to local NVMe disks of any configuration.
For older NVMe local disk implementation such as LSv2/v3 which do not expose identifiers for index, name, etc. export new links for /dev/disk/azure/local/by-serial/.  Based on observation, it is possible this serial contains the equivalent index identifier so this may be revisited in the future if we determine it to be guaranteed to be useful as such.

Note that for this to function with SCSI disks, it will require a separate PR which installs an initramfs hook to get it installed in the ramdisk.


[FLINK-29611][tests] Fix flaky test in CoBroadcastWithNonKeyedOperatorTest and DataStreamBatchExecutionITCase

This PR aims to solve the issue presented here: https://issues.apache.org/jira/browse/FLINK-29611
What is the purpose of the change
The fix is to change the HashMap in HeapBroadcastState to LinkedHashMap to make the tests more stable (less flaky).
Brief change log

Changing the map implementation of HeadBroadcastState
Modifying the tests that depend on this class (Only changing the order of insertion and not the elements or anything else)

Verifying this change
Existing tests already cover this change, and it can pass them successfully.
The tests are:

org.apache.flink.streaming.api.operators.co.CoBroadcastWithNonKeyedOperatorTest.testMultiStateSupport
org.apache.flink.api.datastream.DataStreamBatchExecutionITCase.batchBroadcastExecution
org.apache.flink.api.datastream.DataStreamBatchExecutionITCase.batchKeyedBroadcastExecution

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): No
The public API, i.e., is any changed class annotated with @Public(Evolving): No
The serializers: No
The runtime per-record code paths (performance sensitive): No
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos,, ZooKeeper: No
The S3 file system connector: No

Documentation
Does this pull request introduce a new feature? No

Closing as per JIRA comment.


Request: plugin for selectable posts

The blog is working out nicely but it would be nice to have a list plugin where you can define the number of posts and manually choose a post for each position. So a bit like the latest posts plugin but not filled based on publish-date but manually.

This is something I was just thinking about in the past weeks. I lack time to implement this, but I think that a sorted-m2m enabled plugin that allow to choose posts would be a really nice idea to add

Yeah, that would be great! I'm afraid I lack the skills to write this, but I'll give it a go.

@yakky Should we create a BlogFeaturedPlugin with a sorted-m2m ? I think it would be useful.


Update perl to add extension to man3 files

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

[x] The toolchain has been rebuilt successfully (or no changes were made to it)
[x] The toolchain/worker package manifests are up-to-date
[x] Any updated packages successfully build (or no packages were changed)
[x] Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
[x] Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
[x] All package sources are available
[x] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
[x] LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
[x] All source files have up-to-date hashes in the *.signatures.json files
[x] sudo make go-tidy-all and sudo make go-test-coverage pass
[x] Documentation has been updated to match any changes to the build system
[x] Ready to merge

Summary

What does the PR accomplish, why was it needed?
perl and tcl have a filename collision on /usr/share/man/man3/Thread.3.gz due to differing multi-threading strategies. This can be solved by using perl's built in configuration option to name it's man files with a different extension.
This issue is currently causing the 1.0-dev builds to break.
Change Log

add -Dman3ext=3pm to perl Configure script

Does this affect the toolchain?

YES
Test Methodology

perl build: https://dev.azure.com/mariner-org/mariner/_build/results?buildId=349486&view=results
local toolchain build

Thanks for the fix. This should resolve the 1.0-dev build break:
ERRO[0063] Failed to build SRPM '/tmp/mariner/build/INTERMEDIATE_SRPMS/expect-5.45.4-4.cm1.src.rpm'. For details see log file: /tmp/mariner/build/logs/pkggen/rpmbuilding/expect-5.45.4-4.cm1.src.rpm.log.

file /usr/share/man/man3/Thread.3.gz from install of tcl-devel-8.6.13-1.cm1.x86_64 conflicts with file from package perl-5.30.3-1.cm1.x86_64


clion sync fails due to experimental_repo_remote_exec

Description of the bug:
Clicking on "Sync Project with BUILD files" in Clion gives me the following error.

Command: bazel query --tool_tag=ijwb:CLion --output=label_kind --keep_going same_pkg_direct_rdeps(...
...
ERROR: Traceback (most recent call last):
File "/home/swang/.cache/bazel/_bazel_swang/ff2a6157a8aefe45e3eec5c0d2d5d22c/external/org_tensorflow/third_party/gpus/cuda_configure.bzl", line 1465, column 40, in
remote_cuda_configure = repository_rule(
Error in repository_rule: in call to repository_rule(), parameter 'remotable' is experimental and thus unavailable with the current flags. It may be enabled by setting --experimental_repo_remote_exec
ERROR: Traceback (most recent call last):
File "/home/swang/.cache/bazel/_bazel_swang/ff2a6157a8aefe45e3eec5c0d2d5d22c/external/org_tensorflow/third_party/py/python_configure.bzl", line 41, column 42, in
remote_python_configure = repository_rule(
Error in repository_rule: in call to repository_rule(), parameter 'remotable' is experimental and thus unavailable with the current flags. It may be enabled by setting --experimental_repo_remote_exec
ERROR: Traceback (most recent call last):
File "/home/swang/.cache/bazel/_bazel_swang/ff2a6157a8aefe45e3eec5c0d2d5d22c/external/org_tensorflow/tensorflow/tools/toolchains/cpus/aarch64/aarch64.bzl", line 312, column 43, in
remote_aarch64_configure = repository_rule(
Error in repository_rule: in call to repository_rule(), parameter 'remotable' is experimental and thus unavailable with the current flags. It may be enabled by setting --experimental_repo_remote_exec

The repository_rules with issues mostly comes from tensorflow that I depend on.
bazel build ...:all works.
My .bazelproject file is mostly default.
directories:
  # Add the directories you want added as source here
  # By default, we've added your entire workspace ('.')
  .

targets:
  # Add targets that reach the source code that you want to resolve here
  # By default, we've added all targets in your workspace
  //...

additional_languages:
  # Uncomment any additional languages you want supported
  # dart
  # javascript
  # typescript
  python

# I already has this flag in .bazelrc. Adding this here does not resolve the issue.
build_flags:
  --experimental_repo_remote_exec

Which category does this issue belong to?
CLion
Which Intellij IDE are you using? Please provide the specific version.
clion 2023.3.4 (also has issue at 2023.3.x from which I upgraded when debugging)
What Bazel plugin version are you using?
2<IP_ADDRESS>.1-api-version-233 (also has issue at an earlier version from which I upgraded when debugging)

Hi @cnsgsz, Can you provide sample code to test the same. Thanks!

Adding tensorflow as a external dependency can re-produce this issue. Please see tensorflow serving for an example (.bazelrc, WORKSPACE, etc).

@mai93 suggested adding query --experimental_repo_remote_exec to .bazelrc, which fixed my issue.


In 1.17.1, impossible to open GUI

The curseforge page says that the key "M" opens the GUI. But I tested it and it doesn't do anything. I go into Minecraft's controls to see if I can configure the key, and there is no such option to configure the GUI.

How do I open the GUI?

This feature is a beta feature, available only on last beta version. Older versions doesn't have the same system. See changelog. Current README describes you old versions of the mod.

Any chance you could update the mod for 1.17.1 to have this feature?

No chance I will, sorry. This would take too much of my time, and I already don't have much time to put into modding. But if anyone wants to do the backport, I'll be happy review it

Does biome-specific music work in 1.17.1 as long as I make the resource pack myself? Or is that feature something that only comes with the GUI in later versions of the mod?


Solve the issues of new users not knowing how to use config-ui

Description

New users have to rely entirely on README to use config-ui and cannot get timely and accurate help when obstacles are encountered.
There is a lack of connection between Data Integration, Pipeline and Dashboard sections. New users who are unfamiliar with the entire flow and functions may feel confused about what to do next. For example, there is no tip on what should be done after a connection is saved.

Describe the solution you'd like

Provide help/guide in the config-ui pages, so that users don't need to jump to other external links.
Always tell users what to do next after an action is done. A good example is that the View Dashboards button can navigate users to dashboards.

Design of the solution

Provide more proactive help/guide. On the right side of the page there can be a Help panel that people can display or hide. The content in the Help panel updates with contextually relevant help text when a person clicks one of the Help icons next to each input box.
When an action is completed, provide the user with a link/button to the next step or show the relevant page directly. The homepage can present an introduction consisting of brief descriptions and illustrations of the entire flow (an example as follows).

will be handled in new design

will be handled in new design


Issues with strictly adhering to uri.js

We are upgrading to 0.2.0 which looks great so far, but we are running into an issue with routing due to following the serialization techniques of uri.js. Uri.js serializes an array: bar=["hello", "world"] in the following manner: bar=hello&bar=world. This is problematic because tornado (our server framework) expects multiple arguments to be serialized in the following manner: bar%5B%5D=hello&bar%5B%5D=world, which is an encoding of two brackets [] after the variable name.
I wanted to open a discussion around providing the ability to override the default building of a query string by mithril when calling m.route(String path [, any params]). I understand that this adds complexity to the route object, however I think that because many servers don't conform to the same standard of how uri's should be encoded this is necessary. I can't imagine that we are the only ones experiencing any issues with regards to the uri encoding.
Our entire site uses mithril and if this isn't added to mithril we will have to maintain a side by side implementation of mithril just to augment buildQueryString. This would cause us to not be able to upgrade to newer mithril versions in a timely manner.
I am happy to submit a pr with the necessary code changes - I wanted to open a discussion before doing so.

This isn't really a mithril issue, it's an issue with tornado not being able to parse Uri.js output.
Why not just shim/replace buildQueryString instead of maintaining the whole library? a la: m.route.buildQueryString = myBuildQueryString
As for Uri.js output itself, where I work we decided that it's not the optimal way of transferring data to the server and instead use a json encoded parameter, which is then parsed separately on the server. We discovered that a url encoded json structure takes up (I think it's exponentially) less space than the equivilent Uri.js encoded one.

Thanks for pointing out that buildQueryString is exposed on the route object!! I didn't see that when browsing through the source code, that's a huge help.
And that's really interesting regarding the Json encoded parameter, I'll definitely have to play around with that idea.
Going to close this, as it's not an issue. Thanks again!

Hi @sdalezman, I've been using Mithril with URIjs from day one. It quickly becomes apparent that URIjs is far more complex and configurable when it comes to URI parsing and manipulation than Mithril (as one might expect), often in ways you can't expect Mithril to understand completely.
Because URIjs is far better at constructing URIs than Mithril, I use it to construct fully formed paths before handing them to Mithril, rather than relying on different methods of each. So my route invocations typically look like this:
m.route(
	URI( m.route() )
		.methodX( ... )
		.methodY( ... )
		.methodZ( ... )
)

It's true that m.route( URI( m.route() ) ) looks confusing. Until a recent point release it was possible to override the URI.href constructor, which I used to take m.route() instead of window.location if it was constructed without input.


Error with Twitter bot

Please include the template below to ensure a more accurate response to your issue.

Node Version: v8.11.1
tiny-core-terminal version: 1.4.1
Shell: zsh
Terminal Program: iterm
Operating System: Mac

Thank you!

This is obviously a problem with the twitter feature: https://github.com/notwaldorf/tiny-care-terminal/blob/master/care.js#L147
@HugoLiconV Would you share which twitter feeds you are using?

@mojoaxel I'm using the defaults

@HugoLiconV ok, thanks. Do you still experience this problem or was this a one-time-thing?

Ah I see! The spaces are the problem!
This is obviously a bug,  let me fix that...
Nice catch! Thanks for reporting!

Yes, the spaces were the problem. I removed them and it's working. Thanks 👍


drivers: stepper: adi: trinamic tmc5041

This PR does the following:

Introduce initial structure for trinamic stepper drivers.
TMC5041 driver.

Todos:

[x] Add this driver to build once the file structutre and API changes have been agreed upon
[x] Add invert direction to stepper-controller.yaml

Update:
I have removed the interrupt detection for now. Will introduce that feature in an upcoming PR most probably. However there is a provision to poll the RAMP_STAT register and check for pos_reached or stall event

Update:

Have adjusted the shell to read the newly added stepper async signals

Won't be adding any more features to this PR :-)


Fix theme_override tooltip caching

theme_override properties have some special handling in EditorInspector.  When caching documentation info for properties, the theme_item_name value (used only for theme_overrides) was not being cached, so it would only be included on first use.  This meant that theme_override property tooltips would show up in the editor the first time a node was selected, but not again after selecting something else/reselecting.  Added theme_item_name to caching to fix this.
Fixes #90395

Thanks!


value bug when used with ember-cli-materialize

When using with ember-cli-materialize, e.g.:
{{#md-input
    value=changeset.email
    errors=changeset.error.email.validation
}}

The input value is constantly reset to empty.  If the errors binding is removed everything works.  I dug into both repos and not able to figure out where this is stemming from.

Here is a repo to demonstrate: https://github.com/dustinfarris/ember-changeset_issue-55
Specifically, the commit that reproduces: https://github.com/dustinfarris/ember-changeset_issue-55/commit/73af2895a2c2ed176c2fe78cad46651932609ce2

This is not an ember-changeset issue, it is a bug with ember-cli-materialize.


Inline css seem ignored by uncss

Hi,
I'm trying to use uncss through node code. My environment is Windows 7.
My code is really simple (i'm new to node), i use the example provided on GitHub with a really really simple file save addition.
When i execute the code, i take back an error [Error: UnCSS: no stylesheets found] so, as far as i can understand, seem that i cant parse inline style (

test01

test02

I just create a fork of this repo doing the exact same thing, but does focus on processing the inline CSS only: https://github.com/sparanoid/grunt-uncss-inline
This plugin do the following things:

Search all


Add endpoint for gas prices.

http://www.ob.is/eldsneytisverd/
http://www.orkan.is/eldsneytisverd/
http://www.atlantsolia.is/stodvarverd.aspx
https://www.n1.is/listaverd/
http://www.gsmbensin.is/gsmbensin_web.php

Apparently @daggala is already working on this.

@daggala, still working on this?

Yes @koddsson I am, I'm just on a vacation but I'll get back to it soon. Is there a deadline?

Nope! Just checking in :sweat_smile:

I used some tiny snippet for that, maybe you want to port it ;)
https://gist.github.com/phm3/fd04b03bf92de8d7402c

@phm3 neat!

Voilà
var x = require('x-ray')();
var _ = require('lodash');

x('http://gsmbensin.is/gsmbensin_web.php', {
  okt95: x(['.pricetable[id=okt95] tr:not(.header) td']),
  disel: x(['.pricetable[id=disel] tr:not(.header) td'])
})(function(error,data){

  function clean(n){
    return {
      station: n[0],
      location: n[1],
      price: n[2]
    }
  }

  data.okt95 = _.chunk(data.okt95,3).map(clean);
  data.disel = _.chunk(data.disel,3).map(clean);

  console.log(data);
});

/*
{
	okt95: [{
		station: 'Orkan',
		location: 'Eiðistorg',
		price: '185.50'
	}],
	disel: [{
		station: 'Orkan',
		location: 'Eiðistorg',
		price: '169.50'
	}...]
}
*/

:+1:

do we agree that this has been resolved by https://github.com/apis-is/apis/pull/290 ?
http://docs.apis.is/#endpoint-petrol


ext: simplelink: Restructure CC3220SDK as SimpleLink SDK

The SimpleLink SDK actually encapsulates a family of devices,
of which cc32xx is just one device.  Other devices can fit
under this SDK directory structure.
This expansion will also allow the import of the WiFi
host driver and its driver porting layer in the future,
inserted at the correct levels in the SimpleLink SDK
directory heirarchy.
Follow the URL (ending in "#directory-structure") referenced in
ext/hal/ti/simplelink/README which explains the SDK structure,
and where devices fit in.
Jira: ZEP-1958
Change-Id: I16515d3e3779de0d55d3b1b8e25029609d1f66c3
Signed-off-by: Gil Pitney<EMAIL_ADDRESS>

This change is

Fixed the Makefile to use KBUILD_CFLAGS=-DUSE_CC3220_ROM_DRV_API, tested on Zephyr samples, and re-pushed the commit.

Not sure why getting "Shippable" failures on Mr. Chettimada's commit messages, when my commit has no such error.
Should I close and re-submit (to master branch)?
https://app.shippable.com/github/zephyrproject-rtos/zephyr/runs/200/1/tests

No please leave this, I'm trying to figure out why this happened myself.  Not sure where gitlint is getting run.

It seems the test is running over my commit, plus several others, as if the commit wasn't rebased.
But, I though I rebased before pushing.
Note I did do a forced push to update the commit (which I've done in the past with github, and seems a common method for fix branches).   If there is a different preferred method for modifying the PR, please let me know.

Waiting for Anas to expose the shippable logs so we can get more details if we can reproduce it again.


Update azure-sql-database-troubleshoot.md

added verbiage for Mirroring with terminal errors scenario: To ensure your compute resources are not impacted and to minimize impact on operational Azure SQL database, Mirroring will be disabled on any persistent/terminal error
@WilliamDAssafMSFT  @anagha-todalbagi  @sukanyamsft, please review the verbiage to call out behavior for Mirroring disablement on any persistent/terminal errors.
Thank you for contributing to Microsoft Fabric documentation
Fill out these items before submitting your pull request:
If you are working internally at Microsoft:
Provide a link to an Azure DevOps Boards work item that tracks this feature/update.

Who is your primary Skilling team contact? @mention them individually tag them and let them review the PR before signing off.

For internal Microsoft contributors, check off these quality control items as you go

[ ] 1. Check the Acrolinx report: Make sure your Acrolinx Total score is above 80 minimum (higher is better) and with no spelling issues. Acrolinx ensures we are providing consistent terminology and using an appropriate voice and tone, and helps with localization.

[ ] 2. Successful build with no warnings or suggestions: Review the build status to make sure all files are green (Succeeded).

[ ] 3. Preview the pages:: Click each Preview URL link to view the rendered HTML pages on the review.learn.microsoft.com site to check the formatting and alignment of the page. Scan the page for overall formatting, and look at the parts you edited in detail.

[ ] 4. Check the Table of Contents: If you are adding a new markdown file, make sure it is linked from the table of contents.

[ ] 5. #sign-off to request PR review and merge: Once the pull request is finalized and ready to be merged, indicate so by typing #sign-off in a new comment in the Pull Request. If you need to cancel that sign-off, type #hold-off instead. Signing off means the document can be published at any time. Note, this is a formatting and standards review, not a technical review.

Merge and publish

After you #sign-off, there is a separate PR Review team that will review the PR and describe any necessary feedback before merging.
The review team will use the comments section in the PR to provide feedback if changes are needed. Address any blocking issues and sign off again to request another review.
Once all feedback is resolved, you can #sign-off again. The PR Review team reviews and merges the pull request into the specified branch (usually the main branch or a release- branch).
From the main branch, the change is merged into the live branch several times a day to publish it to the public learn.microsoft.com site.

@WilliamDAssafMSFT
Can you review the proposed changes?
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Moving this to the private repo.
#please-close


Only OWL classes should be labelled as Ontology terms

Currently individuals and properties are labelled with the OntologyTerm label in Neo4J, though only classes should be labelled with OntologyTerm.
The best reference I can find for the meaning of term in the biological community is the OBO flat file spec. This clearly states that only OWL classes are terms.
The use of the word "term" in OLS 3 has been a bit inconsistent. On the frontend OWL classes are terms, properties are properties and individuals are individuals. In the codebase this is a bit more fluid with both OWL classes and OWL properties being referred to as terms. This may have slipped in as part of copying and pasting code.
For completeness the OWL vs OBO spec mapping is as follows:

OWL class --> OBO term
OWL property --> OBO typedef
OWL individual --> OBO instances

In that case I think we should drop the word Term completely. Because it would be on exactly the same objects as Class and therefore of no use to OLS for querying.


Remove WRITE_EXTERNAL_STORAGE permission requirement

Currently we're requesting these permissions:
- android.permission.WRITE_EXTERNAL_STORAGE
- android.permission.READ_EXTERNAL_STORAGE
- android.permission.ACCESS_MEDIA_LOCATION

and I think we shouldn't, at least not WRITE_EXTERNAL_STORAGE.
The others can likely also be avoided if we switch to a file picker (cc @pfcDorn).

Should be fixed by 226e81c5fdd08f01582daeb179c72e3666217eca


change flux to redux

Hi,can you change flux to redux,because it's better than flux as i think.BTW,it's just a advice

The blog post has already been written using Alt library. That in itself has a value. And it would be a lot of work updating the tutorial from Alt to Redux. My last point is just because Redux is available it doesn't make it  "better" and all existing tools are suddenly "worse".


Change nb to enby

The readme lists nb as a short form for non-binary.
I've read from multiple people that it's better to say enby because NB is used by non black people of color and mixups can happen, especially when talking about marginalised communities.
I don't want to start a discussion but from what I've read it's preferred by most people.

Thank you, I think this is a good change.
The conflict most likely comes from me updating the files you renamed. Can you please pull/rebase?

Okay, I’ll do so as soon as I’m on my computer, which might be late since I’ve got some plans today :)

I think the conflict should be resolved now.

Thank you so much for this @DysphoricUnicorn 💯 .


Join operator

Join operator implementation
http://reactivex.io/documentation/operators/join.html

Not implemented


Make listener CLI with --event flag wrong namespace

Using the following:
php artisan module:make-listener SendsEmails Email --event=EmailInitialized --queued

produces the right class, however it is referencing:
use Modules\Email\Listeners\Events\EmailInitialized;

instead of
use Modules\Email\Events\EmailInitialized;

Thanks, this has been fixed in the linked PR. 👍


Operation details page (dashboard)

Blocked by: #1366
Description:
As an External User, given that I have registered in BCIERS, I can view my operation details
Acceptance Criteria:
Given that I am on operations page,
When I click view details on a row
Then I am brought to that operation's operation details page

Figma link
Given that I am on operation details page
When I click operation information
Then I am brought to the operation information page
Figma link
Given that I am on operation information page
When I click edit
Then the fields become editable
Dependencies:

#1366

Development Checklist:

[ ]

Definition of Ready (Note: If any of these points are not applicable, mark N/A)

[ ] User story is included
[ ] User role and type are identified
[ ] Acceptance criteria are included
[ ] Wireframes are included (if required)
[ ] Design / Solution is accepted by Product Owner
[ ] Dependencies are identified (technical, business, regulatory/policy)
[ ] Story has been estimated (under 13 pts)

·Definition of Done (Note: If any of these points are not applicable, mark N/A)

[ ] Acceptance criteria are tested by the CI pipeline
[ ] UI meets accessibility requirements
[ ] Configuration changes are documented, documentation and designs are updated
[ ] Passes code peer-review
[ ] Passes QA of Acceptance Criteria with verification in Dev and Test
[ ] Ticket is ready to be merged to main branch
[ ] Can be demoed in Sprint Review
[ ] Bugs or future work cards are identified and created
[ ] Reviewed and approved by Product Owner

Notes:
Dependencies

Editing being split out into separate ticket


Exception in purchase listener stream

Version of flutter_inapp_purchase
2.1.0
Platforms you faced the error (IOS or Android or both?)
iOS
Expected behavior
No exeption
Actual behavior
Plugin throws exception
Tested environment (Emulator? Real Device?)
Real device
Steps to reproduce the behavior
Run on device without signing in Itunes account
A bit of stacktrace. App can succesfully get prducts for purcahase, but after "Sign in into itunes account" dialog and clicking "Cancel" this happens:
Unhandled Exception: NoSuchMethodError: The getter 'stream' was called on null.
Receiver: null
Tried calling: stream
#0      Object.noSuchMethod (dart:core-patch/object_patch.dart:53:5)
#1      FlutterInappPurchase.purchaseUpdated (package:flutter_inapp_purchase/flutter_inapp_purchase.dart:25:75)
#2      _BasePurchaseWidget.buyProduct (package:wot_flutter/screens/main/settings/inapp/SubscriptionsScreen.dart:129:56)
#3      _AsyncAwaitCompleter.start (dart:async-patch/async_patch.dart:45:6)
#4      _BasePurchaseWidget.buyProduct (package:wot_flutter/screens/main/settings/inapp/SubscriptionsScreen.dart:124:26)
#5      _BasePurchaseWidget.renderPurchases.<anonymous closure> (package:wot_flutter/screens/main/settings/inapp/SubscriptionsScreen.dart:180:32)
#6      _InkResponseState._handleTap (package:flutter/src/material/ink_well.dart:706:14)
....

@AnNEDoMini Did you figured it out? What was the actual issue regarding this?


feat: dynamically get supported locations for resource types

Application should dynamically get supported locations for resource types.
Example PowerShell script for getting all supported locations in Norway and Europe for a resource type:
# Get-AzResourceTypeLocations.ps1

param (
  [string]$ProviderNamespace,
  [string]$ResourceTypeName
)
$Provider = Get-AzResourceProvider -ProviderNamespace $ProviderNamespace
$ResourceType = $Provider.ResourceTypes | Where-Object { $_.ResourceTypeName -eq $ResourceTypeName }
$Locations = $ResourceType.Locations | Where-Object { $_ -like '* Europe' -or $_ -like 'Norway *' }
Write-Output $Locations

Checking supported locations for Storage Accounts:
.\Get-AzResourceTypeLocations.ps1 -ProviderNamespace 'Microsoft.Storage' -ResourceTypeName 'storageAccounts'
Outputs:
West Europe
North Europe
Norway East
Checking supported locations for Virtual Machines:
.\Get-AzResourceTypeLocations.ps1 -ProviderNamespace 'Microsoft.Compute' -ResourceTypeName 'virtualMachines'
Outputs:
North Europe
West Europe
Norway East

Query secondary location: https://larry.claman.net/post/2020-04-09-querying-for-azure-regional-pairs/

@bonyfusbouvet is this in prod?


web dir ,  yarn dev can't run success

ziqiangli@ZiQiangdeMacBook-Pro web$ yarn install
yarn install v1.22.19
warning package-lock.json found. Your project contains lock files generated by tools other than Yarn. It is advised not to mix package managers in order to avoid resolution inconsistencies caused by unsynchronized lock files. To clear this warning, remove package-lock.json.
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
warning "@vue/eslint-config-standard ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>warning " ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>|| ^5.0.0".
warning " ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>|| ^3.0.0 || ^4.0.0".
warning " ><EMAIL_ADDRESS>has unmet peer dependency<EMAIL_ADDRESS>|| ^4.0.0 || ^5.0.0".
warning " ><EMAIL_ADDRESS>has unmet peer dependency "@types/node@*".
[4/4] 🔨  Building fresh packages...
success Saved lockfile.
✨  Done in 117.67s.
ziqiangli@ZiQiangdeMacBook-Pro web$ yarn dev
yarn run v1.22.19
error Command "dev" not found.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

并不是每个项目都是 yarn dev 或者 npm run dev 的，具体要看项目内的 package.json -> scripts 中的命令


Mergedown master again

@camlow325 This PR merges-down master into stable to pick up your recent changes of the Puppet submodule and such.

@camlow325 This now includes your latest changes from master.  It's got 2 merge-down commits but meh.

:+1: Maybe @rlinehan could take a look before we merge?

:+1: from me. diff looks good. (ps version and ezbake version the only difference)

Since we have two :+1:s I'm going to go ahead and merge.


Provide sapnwrfc.dll 32-Bit

Hello,
Thank you for maintaining this project. Is it possible to provide the sapnwrfc.dll for 32 bit? The SAP Marketplace downloads section does not appear to provide a 32 Bit version of the RFC SDK and MAMP on windows only supports 32 bit. This causes the warning message "%s1 is not a valid Win32 Application" as described in issue 37.
It is proving prohibitively difficult to obtain this 32 bit dll file.
Kind Regards,

It appears it would be a license violation if you were to publish that library. So I guess issue closed.

You are right, we cannot provide the SAPNW RFC libraries.
On 12 May 2017 10:09 pm, "Payment Plugins"<EMAIL_ADDRESS>wrote:

It appears it would be a license violation if you were to publish that
library. So I guess issue closed.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/gkralik/php7-sapnwrfc/issues/38#issuecomment-301173934,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEuFNxM_SmQXWgxCt3anP9EnD73L9nyBks5r5LxogaJpZM4NZr3U
.


Enable/ disable revert based on settings attribute

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have run the make format command to format my code
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] I have added my name and/or github handle to AUTHORS.rst
[ ] I have added my change to CHANGES.rst
[ ] All new and existing tests passed.

Codecov Report

Merging #632 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #632      +/-   ##
==========================================
+ Coverage   97.66%   97.69%   +0.02%
==========================================
  Files          17       17
  Lines         900      911      +11
  Branches      132      134       +2
==========================================
+ Hits          879      890      +11
  Misses          9        9
  Partials       12       12

Impacted Files
Coverage Δ

simple_history/admin.py
98.38% <100%> (+0.15%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4648ebf...8e28e5d. Read the comment docs.

@rossmechanic, I've separated this functionality out of the larger PR (#631) as I think you had requested some time ago. The next step, if this is accepted, is to complete #631.

thanks and agreed. using the admin permissions of the history objects,
which give you model level granularity, is the one way to go.
On Thu, Apr 23, 2020 at 8:52 AM Ross Mechanic<EMAIL_ADDRESS>wrote:

@rossmechanic approved this pull request.
This looks good to me. I think I'd like to allow this on a model-level in
the future, but this is great for now. Thanks @erikvw
https://github.com/erikvw . Sorry I took awhile to get to this
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/treyhunner/django-simple-history/pull/632#pullrequestreview-399116818,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAD2TZH3DMAKOUYA54DDMQ3ROBBZRANCNFSM4KYEKF5Q
.


Fix Grafana PV can't be mounted (Patch)

Problem:
Grafana still can't mount PV correctly in Cloud, because there are 2
securityContext and fsGroup only work on Pod spec.
Solution:
Change the securityContext to Pod spec.
Issue:
rancher/rancher#16953

LGTM


Consider support for osx-arm64

Comment:
@h-vetinari Many people are now using arm-based Macs. It would be great if osx-arm64 can be added as a target in conda. Thanks!

Please follow these instructions

To track osx-arm64 migration progress...
Current state:
PR created for osx_arm64.txt: https://github.com/conda-forge/conda-forge-pinning-feedstock/pull/6082

So I fixed this in #16, but you should be aware that https://github.com/miurahr/pykakasi has been archived already ~2 years ago, and from experience it's only a question of time until things start breaking more comprehensively. Not sure if there's a follow-up project or anything else.
CC @miurahr

@h-vetinari Thanks! I think pykakasi has been moved to Codeberg (https://codeberg.org/miurahr/pykakasi) and is still being actively maintained (new stable release 4 days ago). I raised an issue about osx arm64 support there and the author referred me to you.

Ah, that's great to know - I had no idea (there was no indication on the github repo about the move)! Then we definitely need to switch sources, and I'll try to publish 2.3.0


⭐ Min of 1 star rating

Checking on frontend and backend with nice error messages.

what is this?

That shouldnt happen easily unless you click submit over and over again. What are the steps to reproduce that issue?

I clicked the submit button over and over like a maniac!

I clicked the submit button over and over like a maniac!

Is that really a use case we need to worry about though?

Can we make a change directly to the AddReview page so that:
a) if a rate is set to less than 1 star, it is automatically changed onchange to 1 star
b) the option in the Ant Rate component that clears the Rate when clicking it twice is disabled

Can we make a change directly to the AddReview page so that:
a) if a rate is set to less than 1 star, it is automatically changed onchange to 1 star
b) the option in the Ant Rate component that clears the Rate when clicking it twice is disabled

regarding a, do you mean the default value should be 1? Or that when they submit with a rating 0 zero they change to 1 and submit?

Can we make a change directly to the AddReview page so that:
a) if a rate is set to less than 1 star, it is automatically changed onchange to 1 star
b) the option in the Ant Rate component that clears the Rate when clicking it twice is disabled

regarding a, do you mean the default value should be 1? Or that when they submit with a rating 0 zero they change to 1 and submit

I tried this out in staging and I realize that we're currently using 0 for a "blank/not yet rated" state, and the issue is it is was also being accepted as a genuine rating value.
I think we should keep using 0 as a "blank/not yet rated" state and have the error message say "please enter a rating"? or "please enter a rating for all categories"???
so you've convinced me we shouldn't do the onchange to 1 star or default to 1 star
but we should disable the Ant thing that changes the rating value to 0 if you click the component twice

Alright changes made:

The ratings start at 0. But the submit button is disabled until you select a rating above 0 for all of the criterion.
Clicking the same rating no longer clears it.

Im not sure why the checks arent running, maybe because @laurarodgers you requested changes?

Im not sure why the checks arent running, maybe because @laurarodgers you requested changes?

Yeah that's what I suspect, which is weird, I wanted to look at it on staging before accepting but I can't because I haven't accepted? Chicken and egg problem lol

Github Actions are down 😂  https://www.githubstatus.com/

Github Actions are down 😂 https://www.githubstatus.com/

Well at least it isn't just us 😂

Lol worse status now:

kk, leave this PR until the checks run :)

Lets try this again!