Add cmdline tab-completion for setting string options

Add tab-completion for setting string options on the cmdline using :set= (along with :set+= and :set-=).
The existing tab completion for setting options currently only works when nothing is typed yet, and it only fills in with the existing value, e.g. when the user does :set diffopt=<Tab> it will be completed to set diffopt=internal,filler,closeoff and nothing else. This isn't too useful as a user usually wants auto-complete to suggest all the possible values, such as 'iblank', or 'algorithm:patience'.
For set= and set+=, this adds a new optional callback function for each option that can be invoked when doing completion. This allows for each option to have control over how completion works. For example, in 'diffopt', it will suggest the default enumeration, but if algorithm: is selected, it will further suggest different algorithm types like 'meyers' and 'patience'. When using set=, the existing option value will be filled in as the first choice to preserve the existing behavior (this helps doing small edits to the option value). When using set+= this won't happen as it doesn't make sense to append an option by its own value in general.
For flag list options (e.g. 'mouse' and 'guioptions'), completion will take into account existing typed values (and in the case of set+=, the existing option value) to make sure it doesn't suggest duplicates.
For set-=, there is a new ExpandSettingSubtract function which will handle flag list and comma-separated options smartly, by only suggesting values that currently exist in the option so you won't try to subtract the wrong value.
Note that Vim has some existing code that adds special handling for 'filetype', 'syntax', and misc dir options like 'backupdir'. This change preserves them as they already work, instead of converting to the new callback API for each option.

Marking this as draft to gather some feedback first. I still need to do a couple things but would like to the basic feedback before proceeding. The couple things are:

[ ] Implement more options. Currently I only implemented a few as a proof of concept, and I tried to cover the ones that have complicated auto-complete rules like diffopt and spellsuggest to make sure they work.
[ ] Add tests
[ ] Documentation

For the API design, I decided to add a generic function to each option (similar to what we did with opt_did_set_cb_T) that can do any expansion logic they like. I originally thought about an API that just returns a list of completable strings instead of doing the regex matching itself (this is similar to how user functions work when using :command -complete) but I decided it may not provide enough flexibility, as the callback function may want to call other existing expansion functions.
I also decided not to touch 'filetype', 'syntax', 'backupdir' etc for now. Those have special handling and I left them be.
There are also some interesting behaviors I found with commas. E.g. if you have a file with a comma in it (e.g. file,with,comma, auto-complete currently fills the name as-is, which is wrong as it should be file\\,with\\,comma instead), but I don't want to fix that for now. There are other minor existing comma parsing issues. May file PR after this to fix it.

Some example screenshots:
set diffopt=<Tab>:

(special handling for individual algorithms):

set encoding=u<Tab>:

set-=:
(note that these are grabbing the existing values that is set by the user and spit by comma)

(for flags, it also only presents the existing option values only. Example below has :set mouse=vn)

Oh, I really like this

Awesome! Now I wonder if it’s possible to do something like completeopt’s popup for info: that is, when suggesting myers or a shortmess flag, display (a snip of) the relevant help text?
Probably would only be enabled for wop containing pum (bah, nonsense syllables).

Awesome! Now I wonder if it’s possible to do something like completeopt’s popup for info: that is, when suggesting myers or a shortmess flag, display (a snip of) the relevant help text?
Probably would only be enabled for wop containing pum (bah, nonsense syllables).

That's a good idea! It's definitely possible within this framework to be added later. I think the callback can return some info on the opt_expand_cb_T struct which tells Vim what to show in the popup menu (e.g. a help tag).
The more annoying problem is actually figuring out what to show. The 'shortmess' option has individiual help tags for each flag (e.g. shm-i), but not so for most other options (flags or comma-separated). I don't think we want each expansion callback to be overly long or intricate and having to do complicated logic, so I think a generic way to find the correct snippet could be implemented to show the relevant bits given some basic data (e.g. "diffopt" -> "meyers" will find the relevant docs and determine how many lines it is).
I do think if we want to do this (in a later commit), we may as well go all the way. Make it so that we could add popup docs for completing option names (e.g. :set dif<Tab>), or command names (:nno<Tab>), and user-provided completions when they define their own commands. Also, would be nice to expose that to getcompletion(), but I think that is more secondary.

Yep, agreed with all you said, esp. the bits about later :)

Just pushed an update. I have now implemented all the options that I intended to. Among them, most of them are simple enumeration type options, or flags, and just consist of a few lines of additions. Some other options are a little more involved, and I tried to split the commits up to make them easier to review. If it's too much, I could split them into separate PRs to do later.
Among them, highlight is probably the most complicated, but diffopt / previewpopup / completepopup / keyprotocol are non-trivial as well.
Among the remaining options, I think some of them could have auto-complete added to them but I don't feel like adding them for now:

mouseshape / guicursor (possible, just need custom parsing for the dashes)
Misc font options like guifont (platform-dependent)
renderoptions (too niche)
viminfo (complicated to parse)
statusline (just… no)

The following warning messages are displayed in the Appveyor CI build (introduced by this PR):
option.c(7992): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data
optionstr.c(866): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data
optionstr.c(1768): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data
optionstr.c(2453): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data
optionstr.c(2939): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data
optionstr.c(2950): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data
optionstr.c(2961): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data

The following warning messages are displayed in the Appveyor CI build (introduced by this PR):
option.c(7992): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data
optionstr.c(866): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data
optionstr.c(1768): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data
optionstr.c(2453): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data
optionstr.c(2939): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data
optionstr.c(2950): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data
optionstr.c(2961): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data

Ok, I will fix them up in #13237. Found a couple other places that trigger warnings as well if I turn on -Wsign-conversion. I wish warnings like these are turned into errors though (like in the main GitHub CI build). Otherwise it's quite hard to find out.


Fix Get Sequences End Point

Because all of the existing data in metamist do not have multiple external ids, the current get_sequences_by function fails. This PR handles sequences with/without multiple external ids.

Codecov Report
Base: 66.72% // Head: 66.72% // No change to project coverage :thumbsup:

Coverage data is based on head (6529728) compared to base (65bcc85).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #298   +/-   ##
=======================================
  Coverage   66.72%   66.72%
=======================================
  Files          67       67
  Lines        5154     5154
=======================================
  Hits         3439     3439
  Misses       1715     1715

Impacted Files
Coverage Δ

db/python/tables/sequence.py
82.10% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


i2cdev recompiles every time

i2cdev compiles every time I cargo build.  It doesn't appear to be a problem in 0.3.1.
$ cargo build
   Compiling i2c-pca9685 v0.1.9-pre (https://github.com/querry43/i2c-pca9685#4b0ddf24)
   Compiling i2cdev v0.3.2
   Compiling assigato-remote v0.1.0 (file:///home/matt/work/assigato-remote)
    Finished dev [unoptimized + debuginfo] target(s) in 13.9 secs
$ cargo build
   Compiling i2cdev v0.3.2
   Compiling i2c-pca9685 v0.1.9-pre (https://github.com/querry43/i2c-pca9685#4b0ddf24)
   Compiling assigato-remote v0.1.0 (file:///home/matt/work/assigato-remote)
    Finished dev [unoptimized + debuginfo] target(s) in 11.87 secs

[dependencies]
i2cdev = "0.3.2"

rustc 1.24.0 (4d90ac38c 2018-02-12)

Looks like this is a known issue of the skeptic crate that was fixed after the 0.13.2 release. I confirmed that if I add the following to my project's Cargo.toml the issue goes away:
[replace]
"skeptic:0.13.2" = { git = 'https://github.com/budziq/rust-skeptic' }

@querry43 could you please also verify that this addresses the issue in your case?
Obviously the long-term solution is for a new release of skeptic with the fix - I have opened an issue requesting the author to push a new release: https://github.com/budziq/rust-skeptic/issues/75

Oh yea, that works great.  Thanks for finding that.  It fixes a problem I have with another crate too.

Upstream release of rust-skeptic is done: https://github.com/budziq/rust-skeptic/issues/75
Since rust-i2cdev is used as a library, if you have an application with a Cargo.lock you can do cargo update -p skeptic to get the bumped version. I tested it out locally and i2cdev is no longer rebuilding every time cargo build is run.

Yea, I saw the upstream commit.  Thanks.
On Mon, May 14, 2018 at 9:17 AM, Nick Stevens<EMAIL_ADDRESS>wrote:

Upstream release of rust-skeptic is done: budziq/rust-skeptic#75
https://github.com/budziq/rust-skeptic/issues/75
Since rust-i2cdev is used as a library, if you have an application with a
Cargo.lock you can do cargo update -p skeptic to get the bumped version.
I tested it out locally and i2cdev is no longer rebuilding every time cargo
build is run.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/rust-embedded/rust-i2cdev/issues/37#issuecomment-388875529,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABCbYJa8LO5reLYtAG3MRMleTPDmwDAiks5tya4UgaJpZM4SbM6D
.


Add automatic ABI checker from ros-industrial/industrial_ci

If I've understood the documentation correctly this should check against the merge parent

argh, we're hitting timeouts with travis. I think it's right on the 50min limit because it looks to be at the last step when it gets killed:
[build] Runtime: 18 minutes and 16.2 seconds total.
[build] Note: Workspace packages have changed, please re-source setup files to use them.
Detect public symbols
Reading debug-info

< this took 5min in the previous step >

The job exceeded the maximum time limit for jobs, and has been terminated.

@130s did you happen to have any suggestions for speeding up the travis job?

Looks like the job just took too long, this might happen for bigger projects.
How long does it take to run it locally?
However, travis had some problems in this time frame, so a retry might resolve the issue.

Takes 31 min locally. The three jobs so far have been terminated by travis, but in case it was just bad luck I triggered another

Takes 31 min locally

It will be a little bit slower on Travis, so perhaps it's just to much.
To get a baseline time, you could add a normal build/test (only 1 run).

just running the script locally because of the timeout on travis


Doesn't work. Errors out when I use the Python web UI and click "Start Training" , with "cannot import 'packaging' form 'pkg_resources'

This is for bugs only
Did you already ask in the discord?
No
You verified that this is a bug and not a feature request or question by asking in the discord?
Yes
Describe the bug
When I use the Python web UI and set everything up, the click Start Training, I get a python error

pip install setuptools==69.5.1

yes, the exact version solved the issue. now fiddling with config/examples/generate.example.yaml to run a test interference but no luck. any ideas?

what error?

what error?

actually there is no error, looking for a shortcut to run interference after training


pre-training model

Do you have any pre-training models or check-point?
Thanks

Hi there, we have renamed and reconstructed the model for the public release. So previous trained checkpoints will not work for this. If you follow the training setting in our paper, you should get similar results.

Do you have any pre-training models or check-point?
Thanks

Hi there, we have renamed and reconstructed the model for the public release. So previous trained checkpoints will not work for this. If you follow the training setting in our paper, you should get similar results.

Do you have any pre-training models or check-point?
Thanks

Hi there, we have renamed and reconstructed the model for the public release. So previous trained checkpoints will not work for this. If you follow the training setting in our paper, you should get similar results.

Bạn có bất kỳ mô hình đào tạo trước hoặc điểm kiểm tra nào không?
Cảm ơn

Xin chào, chúng tôi đã đổi tên và xây dựng lại mô hình cho bản phát hành công khai. Vì vậy, các trạm kiểm soát được đào tạo trước đó sẽ không hoạt động cho việc này. Nếu bạn tuân theo cài đặt đào tạo trong bài báo của chúng tôi, bạn sẽ nhận được kết quả tương tự.
thanks. I hope it will be coming soon

Thanks. I hope it will be coming soon

Do you have any pre-training models or check-point?
Thanks

Hi there, we have renamed and reconstructed the model for the public release. So previous trained checkpoints will not work for this. If you follow the training setting in our paper, you should get similar results.

Hello! I only have 4 16GB GPU for training with 32batch size,and the test result is 93.6 in egogesture.
Can you give me some advice to get the results in papaer with the small batch size?

Do you have any pre-training models or check-point?
Thanks

Hi there, we have renamed and reconstructed the model for the public release. So previous trained checkpoints will not work for this. If you follow the training setting in our paper, you should get similar results.

Hello! I only have 4 16GB GPU for training with 32batch size,and the test result is 93.6 in egogesture.
Can you give me some advice to get the results in papaer with the small batch size?

Hi there,
Can you try the training setting below for batch size equal to 32? I can reproduce the results from the paper.
python3 train.py --is_train --is_shift \
                 --dataset EgoGesture --clip_len 8 \
                 --shift_div 8 --wd 1e-5 --dropout 0 \
                 --cuda_id $cuda_id --batch_size 32 --lr_steps 10 15 20 \
                 --lr 5e-3 --base_model resnet50 --epochs 25

Do you have any pre-training models or check-point?
Thanks

Hi there, we have renamed and reconstructed the model for the public release. So previous trained checkpoints will not work for this. If you follow the training setting in our paper, you should get similar results.

Hello! I only have 4 16GB GPU for training with 32batch size,and the test result is 93.6 in egogesture.
Can you give me some advice to get the results in papaer with the small batch size?

Hi there,
Can you try the training setting below for batch size equal to 32? I can reproduce the results from the paper.
python3 train.py --is_train --is_shift \
                 --dataset EgoGesture --clip_len 8 \
                 --shift_div 8 --wd 1e-5 --dropout 0 \
                 --cuda_id $cuda_id --batch_size 32 --lr_steps 10 15 20 \
                 --lr 5e-3 --base_model resnet50 --epochs 25

I will try these parameters setting, thanks for your answer.

Do you have any pre-training models or check-point?
Thanks

Hi there, we have renamed and reconstructed the model for the public release. So previous trained checkpoints will not work for this. If you follow the training setting in our paper, you should get similar results.

Hello! I only have 4 16GB GPU for training with 32batch size,and the test result is 93.6 in egogesture.
Can you give me some advice to get the results in papaer with the small batch size?

Hi there,
Can you try the training setting below for batch size equal to 32? I can reproduce the results from the paper.
python3 train.py --is_train --is_shift \
                 --dataset EgoGesture --clip_len 8 \
                 --shift_div 8 --wd 1e-5 --dropout 0 \
                 --cuda_id $cuda_id --batch_size 32 --lr_steps 10 15 20 \
                 --lr 5e-3 --base_model resnet50 --epochs 25

Do you have any pre-training models or check-point?
Thanks

Hi there, we have renamed and reconstructed the model for the public release. So previous trained checkpoints will not work for this. If you follow the training setting in our paper, you should get similar results.

Hello! I only have 4 16GB GPU for training with 32batch size,and the test result is 93.6 in egogesture.
Can you give me some advice to get the results in papaer with the small batch size?

Hi there,
Can you try the training setting below for batch size equal to 32? I can reproduce the results from the paper.
python3 train.py --is_train --is_shift \
                 --dataset EgoGesture --clip_len 8 \
                 --shift_div 8 --wd 1e-5 --dropout 0 \
                 --cuda_id $cuda_id --batch_size 32 --lr_steps 10 15 20 \
                 --lr 5e-3 --base_model resnet50 --epochs 25

Hello, I've successfully reproduce the result in egogesture. I want to do the experiment of 16 clip_len in another dataset. But the accuracy is lower than the result of 8 clip_len. By the way, the batch size is 24 for 8 clip_len and 12 for 16 clip_len. Does the small batch size cause this error? Or other parameters needed to be changed?  If it requires higher batch size, I will rerun the experiment(the GPU memory isn't enough for now).

Hi there, you might consider halving the learning rate for 16 clips. A small batch size may decrease the performance as well. Actually, for the jester and EgoGesture dataset, we found 8 clips are enough to capture the action and 16 clips will give similar results both for our method and other 2D CNN approaches.

Do you have any pre-training models or check-point?
Thanks

Hi there, we have renamed and reconstructed the model for the public release. So previous trained checkpoints will not work for this. If you follow the training setting in our paper, you should get similar results.

Hello! I only have 4 16GB GPU for training with 32batch size,and the test result is 93.6 in egogesture.
Can you give me some advice to get the results in papaer with the small batch size?

Hi there,
Can you try the training setting below for batch size equal to 32? I can reproduce the results from the paper.
python3 train.py --is_train --is_shift \
                 --dataset EgoGesture --clip_len 8 \
                 --shift_div 8 --wd 1e-5 --dropout 0 \
                 --cuda_id $cuda_id --batch_size 32 --lr_steps 10 15 20 \
                 --lr 5e-3 --base_model resnet50 --epochs 25

Do you have any pre-training models or check-point?
Thanks

Hi there, we have renamed and reconstructed the model for the public release. So previous trained checkpoints will not work for this. If you follow the training setting in our paper, you should get similar results.

Hello! I only have 4 16GB GPU for training with 32batch size,and the test result is 93.6 in egogesture.
Can you give me some advice to get the results in papaer with the small batch size?

Hi there,
Can you try the training setting below for batch size equal to 32? I can reproduce the results from the paper.
python3 train.py --is_train --is_shift \
                 --dataset EgoGesture --clip_len 8 \
                 --shift_div 8 --wd 1e-5 --dropout 0 \
                 --cuda_id $cuda_id --batch_size 32 --lr_steps 10 15 20 \
                 --lr 5e-3 --base_model resnet50 --epochs 25

Hello, I've successfully reproduce the result in egogesture. I want to do the experiment of 16 clip_len in another dataset. But the accuracy is lower than the result of 8 clip_len. By the way, the batch size is 24 for 8 clip_len and 12 for 16 clip_len. Does the small batch size cause this error? Or other parameters needed to be changed? If it requires higher batch size, I will rerun the experiment(the GPU memory isn't enough for now).

Hi there, you might consider halving the learning rate for 16 clips. A small batch size may decrease the performance as well. Actually, for the jester and EgoGesture dataset, we found 8 clips are enough to capture the action and 16 clips will give similar results both for our method and other 2D CNN approaches.

Do you have any pre-training models or check-point?
Thanks

Hi there, we have renamed and reconstructed the model for the public release. So previous trained checkpoints will not work for this. If you follow the training setting in our paper, you should get similar results.

Hello! I only have 4 16GB GPU for training with 32batch size,and the test result is 93.6 in egogesture.
Can you give me some advice to get the results in papaer with the small batch size?

Hi there,
Can you try the training setting below for batch size equal to 32? I can reproduce the results from the paper.
python3 train.py --is_train --is_shift \
                 --dataset EgoGesture --clip_len 8 \
                 --shift_div 8 --wd 1e-5 --dropout 0 \
                 --cuda_id $cuda_id --batch_size 32 --lr_steps 10 15 20 \
                 --lr 5e-3 --base_model resnet50 --epochs 25

Do you have any pre-training models or check-point?
Thanks

Hi there, we have renamed and reconstructed the model for the public release. So previous trained checkpoints will not work for this. If you follow the training setting in our paper, you should get similar results.

Hello! I only have 4 16GB GPU for training with 32batch size,and the test result is 93.6 in egogesture.
Can you give me some advice to get the results in papaer with the small batch size?

Hi there,
Can you try the training setting below for batch size equal to 32? I can reproduce the results from the paper.
python3 train.py --is_train --is_shift \
                 --dataset EgoGesture --clip_len 8 \
                 --shift_div 8 --wd 1e-5 --dropout 0 \
                 --cuda_id $cuda_id --batch_size 32 --lr_steps 10 15 20 \
                 --lr 5e-3 --base_model resnet50 --epochs 25

Hello, I've successfully reproduce the result in egogesture. I want to do the experiment of 16 clip_len in another dataset. But the accuracy is lower than the result of 8 clip_len. By the way, the batch size is 24 for 8 clip_len and 12 for 16 clip_len. Does the small batch size cause this error? Or other parameters needed to be changed? If it requires higher batch size, I will rerun the experiment(the GPU memory isn't enough for now).

Hi there, you might consider halving the learning rate for 16 clips. A small batch size may decrease the performance as well. Actually, for the jester and EgoGesture dataset, we found 8 clips are enough to capture the action and 16 clips will give similar results both for our method and other 2D CNN approaches.

The halving means that no matter the batchsize is 24 or 12, I need to set 24e-4 for 16 clip_len model training?

Do you have any pre-training models or check-point?
Thanks

Hi there, we have renamed and reconstructed the model for the public release. So previous trained checkpoints will not work for this. If you follow the training setting in our paper, you should get similar results.

Hello! I only have 4 16GB GPU for training with 32batch size,and the test result is 93.6 in egogesture.
Can you give me some advice to get the results in papaer with the small batch size?

Hi there,
Can you try the training setting below for batch size equal to 32? I can reproduce the results from the paper.
python3 train.py --is_train --is_shift \
                 --dataset EgoGesture --clip_len 8 \
                 --shift_div 8 --wd 1e-5 --dropout 0 \
                 --cuda_id $cuda_id --batch_size 32 --lr_steps 10 15 20 \
                 --lr 5e-3 --base_model resnet50 --epochs 25

Do you have any pre-training models or check-point?
Thanks

Hi there, we have renamed and reconstructed the model for the public release. So previous trained checkpoints will not work for this. If you follow the training setting in our paper, you should get similar results.

Hello! I only have 4 16GB GPU for training with 32batch size,and the test result is 93.6 in egogesture.
Can you give me some advice to get the results in papaer with the small batch size?

Hi there,
Can you try the training setting below for batch size equal to 32? I can reproduce the results from the paper.
python3 train.py --is_train --is_shift \
                 --dataset EgoGesture --clip_len 8 \
                 --shift_div 8 --wd 1e-5 --dropout 0 \
                 --cuda_id $cuda_id --batch_size 32 --lr_steps 10 15 20 \
                 --lr 5e-3 --base_model resnet50 --epochs 25

Hello, I've successfully reproduce the result in egogesture. I want to do the experiment of 16 clip_len in another dataset. But the accuracy is lower than the result of 8 clip_len. By the way, the batch size is 24 for 8 clip_len and 12 for 16 clip_len. Does the small batch size cause this error? Or other parameters needed to be changed? If it requires higher batch size, I will rerun the experiment(the GPU memory isn't enough for now).

Hi there, you might consider halving the learning rate for 16 clips. A small batch size may decrease the performance as well. Actually, for the jester and EgoGesture dataset, we found 8 clips are enough to capture the action and 16 clips will give similar results both for our method and other 2D CNN approaches.

The halving means that no matter the batchsize is 24 or 12, I need to set 24e-4 for 16 clip_len model training?

Halving your learning rate when your batch size is halved. Details can be referred here.


Error message shown in debug mode but crashes in release mode

In a previous post i've asked about catching syntax errors in a previous post :
https://github.com/ThePhD/sol2/issues/910#issuecomment-567110399
the project I'm working on is running on VS2019 and has  SOL_ALL_SAFETIES_ON defined and in which I've used it in such a manner:
C++ side
struct myClass
{
 int haha;
   myClass()
     :haha{0}{};
}
void Raycast(/*some vars*/)
{  /* some code*/   }
int main()
{
   sol::state mLua;
   mLua.open_libraries(sol::lib::base, sol::lib::package,
   				 sol::lib::string, sol::lib::os,
   				 sol::lib::math, sol::lib::table,
   				 sol::lib::io);

   sol::environment& env =sol::environment{ mLua, sol::create, mLua.globals() };
   mLua.script_file("someLua.lua",env);
    mLua["Physics"]= mLua.create_table_with("Raycast", &Raycast);
try{
   sol::protected_function_result res  = env["update"]();
   if (!res.valid() )
   {
   	sol::error err = res;
   	std::cout << err.what() << std::endl;
   }
}
catch(sol::error& err)
  { std::cout << err.what() << std::endl;}
}

lua side:
function update()
    Physics.Raycast()
end

now the issue is that at the moment I'm getting the error messages in debug mode saying somewhat like this:
"failed to run:assets/scripts/test.lua:11: stack index 1, expected userdata, received no value: value is not a valid userdata (bad argument into 'SHE::LuaBinding::RayCastHit(const structSHE::Math::Vector3&, const structSHE::Math::Vector3&, const float&, const structSHE::LuaBinding::collisionMask&)')
stack traceback:
[C]: in field 'Raycast'
assets/scripts/test.lua:11: in function <assets/scripts/test.lua:10>"
which is what i wanted.
However when i build it in release mode this exception was thrown:

which is really weird and has been bugging me for a while.

This was a misconfiguration on my part that applied exclusively to using the function call operator on the proxy returned from lua["whatever"], as you did here.
Pull from latest, it's fixed.

hey dev, I'm still getting the same issues with the current pull, i'm using sol v3.2.0 (revision 43f215c)


Feature: Add option "show only this module" in graph view

Suggestion for the dev working on the new graph view (if this is not already planned):
When working with large netlists where a functional unit (e.g. an FSM) is spread out across the entire graph, it is often hard to figure out how the components interact. I suggest adding a toggle "show only the selected module" that takes all gates and nets in the module (selected in the navigation list) and layouts them in a new, small graph.
This would allow for much easier visual inspection of the connections and you could increase the zoom level without something going off-screen.

Yup, already working on it. You can check out branch feature/new-graph-views if you want to take a look at it, but its obviously WIP code, meaning most of the components are not finished / connected, so dont expect to see much.

@Slowpoke42 Is this still Work in Progress?

Closed in favor of #195


query strings types

the query string field is being used as a way to relay data to third party apps and can leverage a full basic typing system.
Supporting numbers and booleans

@jfayad there is not enough details here , the issue is not clear for me

We to agree on a qs structure to support bool and nbs @jfayad
Similar to the ones we have now {} [] etc..

@jfayad What automated tests can be written for this issue ?

@jfayad there is not enough details here , the issue is not clear for me

No query strings can be sent a full json objects, we need to support booleans and numbers for now (not only strings)

@mahfouzhsein I cannot edit this one but as julien said we need to support sending as well boolean and number query string, not only string
Acceptance testing

[ ] When rendering a section having query strings I must be able to send the query string as number to do it
[ ] When rendering a section having query string, I must be able to send the query string as boolean to do it

@mahfouzhseineweev told me this one is no more valid but I cannot close it myself


Fix CI

Codecov Report

Merging #340 (bd4da97) into master (eabacdb) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #340      +/-   ##
==========================================
- Coverage   54.40%   54.37%   -0.03%
==========================================
  Files          58       58
  Lines        4033     4033
==========================================
- Hits         2194     2193       -1
- Misses       1523     1524       +1
  Partials      316      316

Impacted Files
Coverage Δ

configstack/test_helpers.go
82.41% <0.00%> (-1.10%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62cc8c4...bd4da97. Read the comment docs.


Remove tmpDir.h from OpenEXRUtilTest/OpenEXRFuzzTest CMakeLists.txt

The local files have been replaced by ../OpenEXRTest/tmpDir.h

Good catch, thanks! I'm surprised this wasn't causing an error.

Not sure how I missed it, I overlooked the error, too. This should fix it, thanks!


Unhandled promise rejection when beforeAll returns rejecting promise

Do you want to request a feature or report a bug?
Bug.
What is the current behavior?
When writing a beforeAll function that returns a promise that rejects, the following error is logged:
(node:5611) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 143): TypeError: Cannot read property 'addExpectationResult' of undefined

Then the tests will just timeout with the following error:
Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL.

If the current behavior is a bug, please provide the steps to reproduce.
The following test file will reproduce in v15.1.1. In my configuration browser is false and testEnvironment is “node” (just in case it matters).
beforeAll(() => Promise.reject(new Error('Uh, oh')))

test('always passes', () => {})

What is the expected behavior?
The entire suite will fail and the error from beforeAll will be reported.
Run Jest again with --debug and provide the full configuration it prints. Please mention your node and npm version and operating system.
MacOS
Node.js v6.6.0
npm v3.10.8
Running with debug and the above test file:
jest version = 15.1.1
test framework = jasmine2
config = {
  "browser": false,
  "testEnvironment": "/Users/calebmer/Projects/xyz/node_modules/jest-environment-node/build/index.js",
  "testPathDirs": [
    "/Users/calebmer/Projects/xyz/src"
  ],
  "testRegex": "/__tests__/[^.]+-test.(t|j)s$",
  "rootDir": "/Users/calebmer/Projects/xyz",
  "name": "-Users-calebmer-Projects-xyz",
  "setupFiles": [],
  "testRunner": "/Users/calebmer/Projects/xyz/node_modules/jest-jasmine2/build/index.js",
  "scriptPreprocessor": "/Users/calebmer/Projects/xyz/node_modules/babel-jest/build/index.js",
  "usesBabelJest": true,
  "preprocessorIgnorePatterns": [
    "/node_modules/"
  ],
  "automock": false,
  "bail": false,
  "cacheDirectory": "/var/folders/sv/q94f1jq17pv2f52dhjhzgnwr0000gn/T/jest",
  "colors": false,
  "coveragePathIgnorePatterns": [
    "/node_modules/"
  ],
  "coverageReporters": [
    "json",
    "text",
    "lcov",
    "clover"
  ],
  "globals": {},
  "haste": {
    "providesModuleNodeModules": []
  },
  "mocksPattern": "__mocks__",
  "moduleDirectories": [
    "node_modules"
  ],
  "moduleFileExtensions": [
    "js",
    "json",
    "node"
  ],
  "moduleNameMapper": {},
  "modulePathIgnorePatterns": [],
  "noStackTrace": false,
  "notify": false,
  "preset": null,
  "resetModules": false,
  "testPathIgnorePatterns": [
    "/node_modules/"
  ],
  "testURL": "about:blank",
  "timers": "real",
  "useStderr": false,
  "verbose": null,
  "watch": false,
  "cache": true,
  "watchman": true,
  "testcheckOptions": {
    "times": 100,
    "maxSize": 200
  }
}
Running 1 test suite...(node:6302) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 2): TypeError: Cannot read property 'addExpectationResult' of undefined
 FAIL  src/__tests__/xyz-test.js (9.407s)
  ✕ always passes (2ms)

  ● always passes

    Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL.

      at tryOnTimeout (timers.js:232:11)
      at Timer.listOnTimeout (timers.js:202:5)

Test Summary
 › Ran all tests matching /xyz-test/.
 › 1 test failed, 0 tests passed (1 total in 1 test suite, run time 9.428s)

I believe this should be fixed in Jest 17. Let me know if this is still an issue.

Thanks for all your great work :tada:

Strange - I'm experiencing the same behavior with jest 20. I wonder if it's something I'm doing wrong or if it broke for some reason. In my beforeAll block, which is run via the setupTestFrameworkScriptFile option in the config:
beforeAll(() => {
  return initTestDb().then(makeTestUsers).then(makeTokens).catch(console.err)
});

where initTestDb tries to "handle" a rejected promise like so:
const initTestDb() = () => {
  return dbManager.createDb().catch(err => {
      if (err.code === ER_DB_CREATE_EXISTS) {
        return dbManager.dropDb().then(() => dbManager.createDb());
      }
   }).then(...).then(...);
}

I end up in the same state described in the issue description.. I realize that my description lacks context, but I wonder if its a bug/if it's something I'm doing. The problem is that doesn't occur every time, but it's frequent enough (1/4 times) to bother me a little. I'd be happy to help in any way needed!

@krishnagopinath if this is still an issue, this will be fixed when we replace jasmine with jest-circus.
i found quite a few bugs related to before/after all in jasmine. https://github.com/facebook/jest/issues/3785 this might be related as well

Thanks @aaronabramov , for the reply! :) Thanks for all the hard work 🎉
What would you suggest as a workaround for this till jest-circus is pulled in? Run this inside every test suite separately instead of running it globally?

@krishnagopinath i think the easiest workaround would be to use beforeEach with flag var;
let setupDone = false;
beforeEach(() => {
  if (!setupDone) {
    setupDone = true;
    return doSetup();
  }
};

I have the same issue, but it happens in beforeEach.
In my case it seems that beforeAll runs after beforeEach and latter throws because it relies on data from beforeAll. I think it should be ensured that beforeAll runs first.


Debugger fix

Related to #1247
Seems that the fix got overridden, so applying it again.

test package_version#latest

test package_version#latest


DOC: How to write professional commits

Write how to commit like a pro. Best commit conversations and how they are useful with example.

Okay, Thanks.

 Best commit conversations and how they are useful with example.

We already have the best commit conversations. Just we need to add some examples.

 Best commit conversations and how they are useful with example.

We already have the best commit conversations. Just we need to add some examples.
Hey, I added some extra stuff and restructured some points in my own way, apart from adding some examples. I am really sorry. I did that completely on my own without asking you guys. Just forgot that I am contributing to an open source, really sorry. Do you want to see it first or I will delete those parts.

 Best commit conversations and how they are useful with example.

We already have the best commit conversations. Just we need to add some examples.

Hey, I added some extra stuff and restructured some points in my own way, apart from adding some examples. I am really sorry. I did that completely on my own without asking you guys. Just forgot that I am contributing to an open source, really sorry. Do you want to see it first or I will delete those parts.

If you have already completed the task, please feel free to share the demo with us.

Completed. Thanks for your contributions 🎉 ❤


dash .mpd not supported

i wanna know if you will add the dash files to be supported or not
and if you will how long it will take ?

decode depends on ijkplayer and it not support dash,please using exoplayer

okii thanks


Add other database support like MySQL and No-SQL database like MongoDB?

Many develop use sqlite at local server and MySQL at production environment and MongoDB is also popular if we can use these configurations when we setup, it will be better.

@jarrekk any extra database provider integration would require maintenance efforts from the community, especially when we talk about the project's Core team.
Nevertheless, I think we can work something out should we move one step at a time. Let's give it a try with basic support for MySQL 5.7.x first since Django docs provide a detailed guide on setting this one up.
If you're still onto this I suggest that you deliver a PR addressing the above-mentioned requirements.


Add Florian Tack to UAA approvers

I am already contributing to UAA for several years now as seen here:
https://github.com/cloudfoundry/uaa/commits?author=tack-sap


RepeatedLabelError: 575 Behrs Circle West Drive West

Behrs Circle West Dr. is the name of the street, West is the directional.

Gee! That's a tough one. Thanks!


DS-2583: Quality Control Reporting via REST API (v2)

Extend the REST API to support quality control reports.

GET /reports - Return a list of report tools built on the rest api
GET /reports/{nickname} - Return a redirect to a specific report
GET /filters - Return a list of use case filters available for quality control reporting
GET /filtered-collections - Return collections and item counts based on pre-defined filters
GET /filtered-collections/{collection_id} - Return items and item counts for a collection based on pre-defined filters
GET /filtered-items - Retrieve a set of items based on a metadata query and a set of filters

GET /reports
Configured in dspace/config/modules/rest.cfg
# return report tool html by name
#rest-report-url.collections = ../static/rest/index.html
#rest-report-url.item-query = ../static/rest/query.html

GET /filters
Configured in dspace/config/modules/rest.cfg.
These filters are referenced in the other reporting actions.
Each of these classes contains an enumerated list of useful ways to filter DSpace items.
# configurable filters for filter-collections and filtered-items
plugin.sequence.org.dspace.rest.filter.ItemFilterList = \
        org.dspace.rest.filter.ItemFilterDefs,\
        org.dspace.rest.filter.ItemFilterDefsMisc,\
        org.dspace.rest.filter.ItemFilterDefsPerm

Sample Reporting Application
The following JavaScript application illustrates how these new REST actions can provide quality control reporting to repository managers.
https://github.com/Georgetown-University-Libraries/DSpace-Rest-Reports

@peterdietz , this PR contains the reporting tools that I mentioned.
@helix84 , you had suggested using XSLT to generate the html reports.  I have allowed the user to configure report redirects in the rest.cfg configuration file.

This PR contains a duplication of all of the functionality within https://github.com/DSpace/DSpace/pull/916

@peterdietz , I have made a first attempt to migrate this code to the service api.  Those changes are available in https://github.com/Georgetown-University-Libraries/DSpace/tree/myRestAdd/dspace-rest/src/main/java/org/dspace/rest.  This code needs to construct SQL queries against the metadatavalue table in order to identify items with metadata irregularities.  I am curious to see if this can be done with the service api.

The branch that I have referenced in my prior comment contains code that should be compatible with the new services API.  I was able to construct a complex query on the metadatavalue table: https://github.com/Georgetown-University-Libraries/DSpace/blob/fed7814a23a55ff0f399a18081c00efbbfafe5ee/dspace-api/src/main/java/org/dspace/content/dao/impl/ItemDAOImpl.java#L121-L222
I will update/recreate the pull request once the services code is merged.

Closing, this PR has been replaced with a new one

The source repo that generated this PR has been deleted.  The source can also be found at https://github.com/Georgetown-University-Libraries/DSpace/tree/rest-reports-for-5_x


Expose CSV?

We've had a request from above to expose our json as CSV. Is that quick/easy?

The task here is to have a GCP function that rewrites data.json as data.csv.
I can then create a crontab to pull it over to the webserver.
Then we can link it from the FE UI.

See https://github.com/findthemasks/findthemasks/pull/388

This was closed by @marcuscollins  thanks


Add support for ES Module

I've checked out the source code of acorn, so that decided to use the same bundler(rollup) to generate the ES Module version of acorn-jsx. And use index.mjs as the filename of the ES Module, just like acorn-jsx do.
However, I also noticed that acorn-jsx is zero-dependencies for now. I don't know if it's acceptable to include a new dependency. Actually, the easiest way to do that is RegExp + String replace, but without lexical analysis, it will bring new issues in the future.
At last, if someone wants to use acorn-jsx in Deno, you should configure an imports map like below:
{
    "imports": {
        "acorn"<EMAIL_ADDRESS>    }
}

Because acorn-jsx has a property tokTypes that relies on acorn, in the ES Module of acorn-jsx it is imported by import "acorn";.

Thanks for the PR, this is a great start!

However, I also noticed that acorn-jsx is zero-dependencies for now. I don't know if it's acceptable to include a new dependency.

These are devDependencies, and so perfectly fine since they will be installed only by maintainers.
I think what we might want here instead though is to make ES module the primary source, and auto-generate CommonJS instead.
This would make the code that maintainers actually work with use modern syntax, and CommonJS a production artifact for older versions of Node, which also makes it easier to deprecate it altogether in some far future when everyone migrates.

I've transformed all codes to ES6 import/export syntax, including the test. And use these to generate a CommonJS module.
But there is a problem with tokTypes, if use export { tokTypes } in the ES Module. Rollup will bundle up like below:
exports.default = acronJsx;
export.tokTypes = tokTypes;

That will change the require syntax for the CommonJS users. So, for now,  I'm keeping the Object.defineProperty(acornJsx, "tokTypes", {...}) and commented export { tokTypes }.

But there is a problem with tokTypes, if use export { tokTypes } in the ES Module. Rollup will bundle up like below:

Yeah that makes sense. Note that you couldn't use an export { tokTypes } because it's a getter anyway.
However, that property was added mainly for backwards compatibility and the right way to use it is now via the value returned from the factory function. I wonder if, together with this change, we could just get rid of it and make a major bump...

Okey, all left over comments were removed, and acornJsx is changed to function declaration.
But I'm not very familiar with acorn, I just start to using it recently. 😅

Any update on this?

Thank you both for the hard work!!!
How can I help bring it closer to ready to merge?

@elevatebart  Emm, in this PR, I also changed the test scripts to use import Syntax. So they need esm as devDependencies to run the test scripts. But the travis-ci config didn't install all dependencies, therefore the ci checks have failed.


Removed archived tiers from content api

closes https://github.com/TryGhost/Team/issues/1426
When fetching tiers using the content API, we incorrectly returned all tiers including archived ones unless the active:true filter is passed. Correct behaviour is to always hide archived tiers, so this filter should not be required.

forces active:true filter for tiers content api browse
updates test to check for archived test removal in tiers content api

@matthanley The codecov failure is a bit of red herring as the update to tiers content api test rightly covers the scenario where an archived tier is ignored in the final outcome. We have updated that test to add another tier which is archived to DB, and then we check that we still have actually the same outcome as before, and archived tier is not returned.


Update app-service-app-service-environment-network-architecture-overv…

…iew.md
Added another section covering cross-ASE calls.

Hi @stefsch, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

It looks like you're working at Microsoft (stefsch). If you're full-time, we DON'T require a contribution license agreement.

If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;


Javascript Exception: invalid host

Is this a bug report?
Yes
Have you read the Contributing Guidelines?
Yes
Environment
OS: Windows 10
Node: 8.9.1
Yarn: 1.3.2
npm: 4.6.1
Watchman: Not Found
Xcode: N/A
Android Studio: Version  <IP_ADDRESS> AI-171.4443003
Packages: (wanted => installed)
react: ^16.1.1 => 16.1.1
react-native: ^0.50.4 => 0.50.4
Steps to Reproduce
Expected Behavior
The installed app should launch without crashing
Actual Behavior
When releasing the app for Android, we get this error upon launching it (the app does not even appear and crashes):

Why is this happening? We cannot release unfortunately due to this.
IMOPRTANT NOTES:

The app works perfectly OK in DEBUG mode (react-native run-android)
We are using the latest code-push which seems to be the only package that plays a different role in PRODUCTION mode

Reproducible Demo
Unfortunately this happens when launching our installed app. We cannot share the entire code base of our app.

I have exactly the same issue on ios release, @afilp are you able to fix it now? Thanks

For me, the issue was that I was using Reactotron. Remove any bindings to Reactotron for your release build.
let scriptHostname;
if (__DEV__) {
    const scriptURL = NativeModules.SourceCode.scriptURL;
    scriptHostname = scriptURL.split('://')[1].split(':')[0];
}

Reactotron
    .configure({
        name: 'Soundog',
        host: scriptHostname
    })
    .use(trackGlobalErrors())
    .use(openInEditor())
    .use(overlay())
    .use(asyncStorage())
    .use(networking())
    .use(reactotronRedux())
    .connect()

The host key in the configure method was empty. Giving the 'invalid host' exception.
If that doesn't work for you I reccomend you try to find the exception and work your way back from there.
find node_modules/ -type f -exec grep -H 'invalid host' {} \;

Hope this helps.

@dbader87 save my day. Thank you so much.


Redirect to campaign detail upon entry creation

Description
Closes #500
Once an entry or dm entry is successfully created, the user is now redirected to the campaign detail page instead of the character detail or dm entry index pages respectively..
To test:

Seed database
Create a dm entry for a campaign the signed in user is dm for
(if they are not dm for any campaign, create a campaign and assign them dm)
Observe that you have been redirected to campaign detail page
Create an entry for a campaign the signed in user is participating in with a character
Observe that you have been redirected to campaign detail page

Looks like I have a code smell for having too many redirects in the store function. Each redirect is chosen based on the type of entry being created (invalid gm entry, regular or dm entry with campaign, regular or dm w/o campaign...). The two options are to either ignore it or sacrifice one of the redirects. Thoughts? @m-triassi

@JasonGadoury there's a third option, instead of returning, assign the route name string to a variable that changes based on the conditions, and then pass that variable to the route() function
something like:
if ($x == "Condition A") {
    $redirect = 'campaign.show';
    $extraData = [...];
} elseif ($x == "Condition B") {
    $redirect = 'character.index';
    $extraData = null;
}

return redirect()->route($redirect, $extraData);


add to checkboxgroup and radiobuttongroup docs

Closes issue #4183 in grommet
RadioButtonGroup and CheckBoxGroup are both made from boxes these both have a default gap that is being used. Users can change this so documentation was needed here to let users know that the gap was being set but can be changed.
https://github.com/grommet/grommet/blob/master/src/js/components/CheckBoxGroup/CheckBoxGroup.js#L12
This is the case for both components.
Preview of what page will look like:

Looks great, thank you!! 💟


Empty result of query

Hello,
I'm getting empty results for UAST unexpectedly.
How gitbase was launched:
>>> BBLFSH_ENDPOINT=<IP_ADDRESS>:9432 GITBASE_INDEX_DIR=~/workspace/egorbu/tensorflow_analysis_source_ce/dump/tensorflow_analysis/gitbase_index ./gitbase server -v -d tensorflow_repos

Version:
>>> gitbase version
gitbase (v0.23.1) - build 07-05-2019_14_11_18

Query:
SELECT
    files.repository_id,
    files.file_path,
    UAST(files.blob_content, LANGUAGE(files.file_path, files.blob_content), '//FunctionGroup') as functions
FROM files
NATURAL JOIN commit_files
NATURAL JOIN commits
NATURAL JOIN refs
WHERE
    refs.ref_name= 'HEAD' and functions IS NOT NULL
    AND LANGUAGE(files.file_path,files.blob_content) = 'Java'
LIMIT 10;

But it returns empty results.
Logs from gitbase:
INFO[1820] audit trail                                   action=query address="<IP_ADDRESS>:39288" connection_id=7 duration=32.011312302s pid=7 query="SELECT\n    files.repository_id,\n    files.file_path,\n    UAST(files.blob_content, LANGUAGE(files.file_path, files.blob_content), '//FunctionGroup') as functions\nFROM files\nNATURAL JOIN commit_files\nNATURAL JOIN commits\nNATURAL JOIN refs\nWHERE\n    refs.ref_name= 'HEAD' and functions IS NOT NULL\n    AND LANGUAGE(files.file_path,files.blob_content) = 'Java'\nLIMIT 10;" success=true system=audit user=root
INFO[1820] ConnectionClosed: client 7

Before diving deeper into this, can you try with the latest rc of 0.24.0 and see if this solves your issue?

I will be able to check probably in couple of hours

It works for me if I prefix FunctionGroup by uast: like so:
SELECT
    files.repository_id,
    files.file_path,
    UAST(files.blob_content, LANGUAGE(files.file_path, files.blob_content), '//uast:FunctionGroup') as functions
FROM files
NATURAL JOIN commit_files
NATURAL JOIN commits
NATURAL JOIN refs
WHERE
    refs.ref_name= 'HEAD'
    AND functions IS NOT NULL
    AND LANGUAGE(files.file_path,files.blob_content) = 'Java'
LIMIT 10;

Thanks @erizocosmico @m09 @ajnavarro !
Solution is
'/FunctionGroup -> //uast:FunctionGroup


Fix doc CMakeLists

This is ready to merge, this change will just fix the doc building step but not all of the issues on CI.


Ability to set a Column.Description

Is your feature request related to a problem? Please describe.
When setting of a large quantity of symantec models, often times the Column.Description does not exist from the source. To provide a rich user experience, it is essential to provide them human readable descriptions. But, manually setting thousands of descriptions across hundreds of tables is not a reasonable expectation. So, we really want to script reading the symantec descriptoin from a file and setting it in the symantec model!
Describe the solution you'd like
Similar to the Extended_property functions, need a similar fn() like:  set_column_description(...)
Describe alternatives you've considered
I tried using set_extended_property(... name='description')
The function executes, but the native Description is not set, which is likely expected as it is not actually an 'extended' property but a core property.
Additional context
none

well, turns out that you can just set the Column.Description directly, that seems to work.
tom.model.Tables['email'].Columns['to'].Description = 'zzz 2nd descritpion...'
I'll close this.


Support for Python 3.11rc4

What should we add?
The final release candidate for Python 3.11 was released in July.  Time to start testing!
I am testing this using a modification of the Python Docker image defined here.
Known issues:

aiohttp must be installed using
AIOHTTP_NO_EXTENSIONS=1 python -m pip install aiohttp --no-binary aiohttp
Further discussion about this issue here.
uvloop must be installed using
pip install -e git+https://github.com/MagicStack/uvloop.git@master#egg=uvloop
Further discussion about this issue here.
The following must be removed from tests/requirements.txt

locust
nbconvert
pennylane

Several other packages required by Covalent will need updating

Covalent will be marked semi-stable with Ubuntu 20.04 / Python 3.11rc2 when the full suite of unit and functional tests pass.

related to https://github.com/AgnostiqHQ/covalent/pull/1742

Beautiful! Would love to see this. I'll go ahead and close my issue since I don't have the time to squash these 3.11 bugs, but I look forward to it 😄


Facility to display location of mobile assets of tracked (lat/long – N, and location address – T)

Part of Asset Inventory: Asset Data Requirements


bug: btn-link when button is disabled

What version of daisyUI are you using?
4.10.1
Which browsers are you seeing the problem on?
Chrome
Reproduction URL
https://play.tailwindcss.com/aw6PHLJHuV
Describe your issue
When button is disabled, btn-link render is same as plain button.

It's intentional. Not a bug.
Ideally you wouldn't want to disable a button link because the use case for button link is a navigation link, where takes the user to another page. The use case for a disabled button is an action button which we want the action button to exist but its action is prevented temporary.
On top of that, a button styled as a link can't have an ideal disabled visual. Even if we decreasing the opacity, it wouldn't be obvious that it's supposed to be disabled.
Let me know if you have any questions


Make "@" implicit for GH integration

Problem
Slack tries to be smart with @mentions. If it corresponds to a slack user, the value input in the reviewers rotation is actually their slack user id.
See Travis below for example.

Solution
Only prepend "@" for the GH mentions. There really isn't any meaningful semantic outside that case. Looking forward it might be nice to integrate this more with Lita::User. See #29
Also worth noting this will require me to rebuild the current rotation, but it's not really a big deal since it's such a small set.

:eyes: @kyfast

:+1:


Expose last modified and other metadata fields on blobs

These changes:

enable list_v2 to return blob objects (previously blob keys) via verbose param
add get_last_modified_date to retrieve a blob's last modified field given either: bucket, key or blob. The motivation to support the latter (previous support only for the former) is to minimize the number of network requests we make to retrieve a blob from a bucket, for example when processing a list of blobs retrieved via list_v2.
add read_key to read the key field of a given blob.

The new patterns introduced in points 2 and 3 are intended to provide the client with a single cloud-agnostic interface to read a blob's fields, without incurring unnecessary network requests. Currently, visibility into blobs is supported by field-specific functions that fetch a new blob object every time (e.g. get_content_type). get_last_modified_date and read_key are 2 examples of functions that work directly with blob objects to achieve this.
Related to https://app.zenhub.com/workspace/o/humancellatlas/data-store/issues/1347

tests broken?


Release 1.4.12

Summary
Release contains https://github.com/quarkus-qe/quarkus-test-framework/pull/1317.
Please check the relevant options

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Dependency update
[ ] Refactoring
[x] Release (follows conventions described in the RELEASE.md)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] This change requires a documentation update
[ ] This change requires execution against OCP (use run tests phrase in comment)

Checklist:

[x] Example scenarios has been updated / added
[x] Methods and classes used in PR scenarios are meaningful
[x] Commits are well encapsulated and follow the best practices

Thank you @mjurc


Could not find action, lane or variable 'firebase_app_distribution'

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Issue Description

Complete output when running fastlane, including the stack trace and command used

android git:(master) ✗ fastlane add_plugin firebase_app_distribution
[✔] 🚀
[18:55:11]: fastlane detected a Gemfile in the current directory
[18:55:11]: however it seems like you don't use `bundle exec`
[18:55:11]: to launch fastlane faster, please use
[18:55:11]:
[18:55:11]: $ bundle exec fastlane add_plugin firebase_app_distribution
[18:55:11]:
[18:55:11]: Get started using a Gemfile for fastlane https://docs.fastlane.tools/getting-started/ios/setup/#use-a-gemfile
[18:55:12]: It seems like you wanted to load some plugins, however they couldn't be loaded
[18:55:12]: Please follow the troubleshooting guide: https://docs.fastlane.tools/plugins/plugins-troubleshooting/
[18:55:13]: Plugin 'fastlane-plugin-firebase_app_distribution' was added to './fastlane/Pluginfile'
[18:55:13]: Make sure to commit your Gemfile, Gemfile.lock and Pluginfile to version control
Installing plugin dependencies...
Successfully installed plugins
android git:(master) ✗ fastlane distribute
[✔] 🚀
[18:55:38]: fastlane detected a Gemfile in the current directory
[18:55:38]: however it seems like you don't use bundle exec
[18:55:38]: to launch fastlane faster, please use
[18:55:38]:
[18:55:38]: $ bundle exec fastlane distribute
[18:55:38]:
[18:55:38]: Get started using a Gemfile for fastlane https://docs.fastlane.tools/getting-started/ios/setup/#use-a-gemfile
[18:55:38]: It seems like you wanted to load some plugins, however they couldn't be loaded
[18:55:38]: Please follow the troubleshooting guide: https://docs.fastlane.tools/plugins/plugins-troubleshooting/
[18:55:38]: ------------------------------
[18:55:38]: --- Step: default_platform ---
[18:55:38]: ------------------------------
[18:55:38]: Driving the lane 'android distribute' 🚀
+------------------+--------------------+
|             Lane Context              |
+------------------+--------------------+
| DEFAULT_PLATFORM | android            |
| PLATFORM_NAME    | android            |
| LANE_NAME        | android distribute |
+------------------+--------------------+
[18:55:38]: Could not find action, lane or variable 'firebase_app_distribution'. Check out the documentation for more details: https://docs.fastlane.tools/actions
+------+------------------+-------------+
|           fastlane summary            |
+------+------------------+-------------+
| Step | Action           | Time (in s) |
+------+------------------+-------------+
| 1    | default_platform | 0           |
+------+------------------+-------------+
[18:55:38]: fastlane finished with errors
[!] Could not find action, lane or variable 'firebase_app_distribution'. Check out the documentation for more details: https://docs.fastlane.tools/actions

Environment

🚫 fastlane environment 🚫
Stack

Key
Value

OS
10.14.6

Ruby
2.6.5

Bundler?
false

Git
git version 2.21.0 (Apple Git-122)

Installation Source
~/.rbenv/versions/2.6.5/bin/fastlane

Host
Mac OS X 10.14.6 (18G103)

Ruby Lib Dir
~/.rbenv/versions/2.6.5/lib

OpenSSL Version
OpenSSL 1.1.1d  10 Sep 2019

Is contained
false

Is homebrew
false

Is installed via Fabric.app
false

Xcode Path
/Applications/Xcode.app/Contents/Developer/

Xcode Version
11.0

System Locale

Error

No Locale with UTF8 found 🚫

fastlane files:
`./fastlane/Fastfile`
# This file contains the fastlane.tools configuration
# You can find the documentation at https://docs.fastlane.tools
#
# For a list of all available actions, check out
#
#     https://docs.fastlane.tools/actions
#
# For a list of all available plugins, check out
#
#     https://docs.fastlane.tools/plugins/available-plugins
#

# Uncomment the line if you want fastlane to automatically update itself
# update_fastlane

default_platform(:android)

platform :android do
  desc "Runs all the tests"
  lane :test do
    gradle(task: "test")
  end

  desc "build apk"
  lane :beta do
    # Adjust the `build_type` and `flavor` params as needed to build the right APK for your setup
    gradle(
      task: 'assemble',
      build_type: 'Release'
    )
    # ...
  end

  desc "Submit a new Beta Build to Firebase App Distribution"
  lane :distribute do

      firebase_app_distribution(
          app: "1:************:android:**********************",
          release_notes: "This is CI / CD integration test",
          apk_path:"/Users/apple/StudioProjects/flutter-vendor-admin/build/app/outputs/apk/release/app-release.apk",
          firebase_cli_path: "/usr/local/bin/firebase"
      )

      slack(
            message: 'Successfully distributed a new beta build',
            slack_url: 'https://hooks.slack.com/services/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',
            payload: {
                "Build Date" => Time.new.to_s,
                "Built by" => "Fastlane",
              },
            attachment_properties: {
                       fields: [
                           {
                               title: "Build number",
                               value: ENV["BUILD_NUMBER"],
                           },
                       ]
                   }
      )

  end

  desc "Deploy a new version to the Google Play"
  lane :deploy do
    gradle(task: "clean assembleRelease")
    upload_to_play_store
  end
end

`./fastlane/Appfile`
json_key_file("/Users/apple/StudioProjects/flutter-vendor-admin/config/vendor_admin_service_account.json") # Path to the json secret file - Follow https://docs.fastlane.tools/actions/supply/#setup to get one
package_name("com.******.******. package") # e.g. com.krausefx.app

fastlane gems

Gem
Version
Update-Status

fastlane
2.133.0
✅ Up-To-Date

Loaded fastlane plugins:
No plugins Loaded
Loaded gems

Gem
Version

did_you_mean
1.3.1

slack-notifier
2.3.2

atomos
0.1.3

CFPropertyList
3.0.1

claide
1.0.3

colored2
3.1.2

nanaimo
0.2.6

xcodeproj
1.12.0

rouge
2.0.7

xcpretty
0.3.0

terminal-notifier
2.0.0

unicode-display_width
1.6.0

terminal-table
1.8.0

plist
3.5.0

addressable
2.7.0

multipart-post
2.0.0

word_wrap
1.0.0

public_suffix
2.0.5

tty-screen
0.7.0

tty-cursor
0.7.0

tty-spinner
0.9.1

babosa
1.0.3

colored
1.2

highline
1.7.10

commander-fastlane
4.4.6

excon
0.67.0

faraday
0.15.4

faraday_middleware
0.13.1

unf_ext
<IP_ADDRESS>

unf
0.1.4

domain_name
0.5.20190701

http-cookie
1.0.3

faraday-cookie_jar
0.0.6

fastimage
2.1.7

gh_inspector
1.1.3

mini_magick
4.9.5

multi_xml
0.6.0

rubyzip
1.3.0

security
0.1.3

xcpretty-travis-formatter
1.0.0

dotenv
2.7.5

bundler
1.17.2

naturally
2.2.0

simctl
1.6.6

jwt
2.1.0

uber
0.1.0

declarative
0.0.10

declarative-option
0.1.0

representable
3.0.4

retriable
3.1.2

mime-types-data
3.2019.0904

mime-types
3.3

multi_json
1.13.1

signet
0.11.0

memoist
0.16.0

os
1.0.1

googleauth
0.6.7

httpclient
2.8.3

google-api-client
0.23.9

emoji_regex
1.0.1

json
2.2.0

digest-crc
0.4.1

google-cloud-env
1.2.1

google-cloud-core
1.3.1

google-cloud-storage
1.16.0

forwardable
1.2.0

logger
1.4.1

stringio
0.0.2

ipaddr
1.2.2

openssl
2.1.2

ostruct
0.1.0

strscan
1.0.0

date
2.0.0

fileutils
1.3.0

io-console
0.4.8

zlib
1.0.0

rexml
3.2.2

etc
1.0.1

psych
3.1.0

mutex_m
0.1.0

generated on: 2019-10-03

I'm having the same issue for

firebase_test_lab_ios_xctest

Did you follow the trouble shooting guide that the warning message links to?
Did you run with bundle exec as the warning message tell you?

Yep I did that too but no luck, running with that command executes script some what fast but still it doesn't work.

It was cured after updating fastlane.
Solved by updating from version 2.57.2 to 2.102.0

I'm using most recent version 2.133.0

Also seeing this, 2.133.0.

Having the same issue on 2.134

After executing "fastlane add_plugin firebase_app_distribution" with fastlane "2.134.0" my Pluginfile was updated with new line "gem 'fastlane-plugin-firebase_app_distribution'".
After that, action "firebase_app_distribution" worked as expected.

Same here on astlane 2.28.3, getting

[!] Could not find action, lane or variable 'build_app'. Check out the documentation for more details: https://docs.fastlane.tools/actions```

@MrJune15 @janpio Have we been able to find a solution to the problem yet ?
I'm facing similar issue on MacOS Mojave.
I had installed the firebase_app_distribution plugin successfully via the recommended command
$ fastlane add_plugin firebase_app_distribution
But bundle exec fastlane run firebase_app_distribution fails with error, details below.
$ bundle exec fastlane run firebase_app_distribution
[✔] 🚀
[11:26:43]: It seems like you wanted to load some plugins, however they couldn't be loaded
[11:26:43]: Please follow the troubleshooting guide: https://docs.fastlane.tools/plugins/plugins-troubleshooting/

[!] Action 'firebase_app_distribution' not available, run `fastlane actions` to get a full list

Please suggest a way forward to resolve this.
TIA
Tas

Did you open an issue with the plugin that is not working?
Do other plugins work for you?
The most important thing is always to provide all the information. Your post for example of course makes me wonder if you did run fastlane actions as the output tells you to and what it returns.
What else did you try to fix it? Did you read the docs?

I had the same problem with firebase_app_distribution. In my case It was resolved after ruby update from 2.6.0 to 2.6.3. Then also I reinstall bundler and bundles.
@dipkasyap  I had problem with build_app when used brew to install fastlane. It installs not actual version. Advice to reinstall fastlane using RubyGems to get new version instead of 2.28.3.

@svallex

I had problem with build_app when used brew to install fastlane. It installs not actual version. Advice to reinstall fastlane using RubyGems to get new version instead of 2.28.3.

Thank you, I had the same problem and installing fastlane via RubyGems worked for me.

Having the same issue on 2.138.0.
After executing bundle exec fastlane add_plugin firebase_app_distribution  a plugin is added to Pluginfile, but still nothing works.
[18:09:40]: It seems like you wanted to load some plugins, however they couldn't be loaded
[18:09:40]: Please follow the troubleshooting guide: https://docs.fastlane.tools/plugins/plugins-troubleshooting/
[18:09:40]: Plugin 'fastlane-plugin-firebase_app_distribution' was added to './Pluginfile'
[18:09:40]: Make sure to commit your Gemfile, Gemfile.lock and Pluginfile to version control
Installing plugin dependencies...
[DEPRECATED] `Bundler.with_clean_env` has been deprecated in favor of `Bundler.with_unbundled_env`. If you instead want the environment before bundler was originally loaded, use `Bundler.with_original_env` (called at /Users/gglushkov/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/fastlane-2.138.0/fastlane/lib/fastlane/plugins/plugin_manager.rb:218)
Successfully installed plugins

Same here works outside my Dockerfile but not inside 😢
Using the latest fastlane 2.138.0
The solution was running RUN bundle install && bundle exec fastlane android ${LANE}
Inside the Docker


activate appveyor

fix for #110

Coverage remained the same at 71.02% when pulling 0f65894a101a3bf909dc5c980a89d8faeea4e570 on sd/appveyor into e62f4d25e4bc411bafae45b462595a281e4f5f50 on master.

I've added Reactive to appveyor, but it seems like it doesn't pick it up yet. Maybe this needs to be on master first?

Coverage remained the same at 71.02% when pulling 0f65894a101a3bf909dc5c980a89d8faeea4e570 on sd/appveyor into e62f4d25e4bc411bafae45b462595a281e4f5f50 on master.

Coverage remained the same at 71.02% when pulling 08138dc1db033037680194bf864891e69a5e2496 on sd/appveyor into e62f4d25e4bc411bafae45b462595a281e4f5f50 on master.

Thanks! Let's find out :)


Library not working in macOS Sequoia in Release mode

This library has broke on the current macOS. If you run the tests in debug mode, they all pass. But if you run them in Release mode, they fail.
Not even sure where to start with this. Is the library even maintained?

I seemed to pinpoint this issue to swift optimization in release mode. If you set it to no optimization, the tests pass.

@Joebayld Can you confirm if this issue has been resolved?

@Joebayld Can you confirm if this issue has been resolved?

Yes this is now fixed.


Refactor Supercollider to have Reload and Fire modes for higher burst emission

This change refactors Supercollider to support two different modes: Reload and Fire.
In Reload mode, Supercollider generates a specified number of events as quickly as it can and writes the CBOR to a file. It uses in-memory SQLite for the repo manager and I've benched it at around 2.2k evt/sec for generation.
The static file includes creation of the repos and all the repo appends for lots of Posts. 2 Million events takes around 16 minutes to produce. We call this a loaded magazine.
In Fire mode, Supercollider will fire the magazine of events at any client that connects to the subscribe repos endpoint. Since we're reading from a file, we can go as fast as the socket can handle, though we also accept a flag to limit emission rate if we want to for any reason.
This method allows us to get significantly higher rates (tested at >10k evt/sec) of event emission for benchmarking a repo stream consumer like the BGS.
You need to reload between firing only if the consumer has durable repo state, if you blow away the DB on the consumer between runs, you don't need to reload since we can play the repos over from creation again without issue.

LGTM, though you could use a cborgen.Deferred instead of decoding and re-encoding the objects to write out to the stream

How would you recommend I do that? It would be neat if I could still count the number of events I've emitted so we can track the throughput. Looking at the tests that use Deferred it isn't super clear to me how it functions or how I'd make use of it here.


Error updating plugins

I've only recently installed Hyper, but plugin updates were working for the first few days. Over the past roughly 24 hours, I'm seeing a notification (below) that updates are failing. Further, the referenced log file hasn't and isn't being created.

Hyper 1.2.1
Electron 1.4.7
darwin x64 16.4.0

Just noticed #1513. Closing.


Support for angular>1.4

Hi,
Can you please provide support for angular versions >1.4

+1

Now I must open this library and change darthwade.loading to darthwade.dwLoading, but I can not use $loading.start($key); to start loading and $loading.finish($key); to stop loading; beside that I can not use bower to install this library.

The latest version is not recognized by Bower through the version numbers - 0.1.4 is the newest you can pull in via Bower. You can instead do this to install via the commandline:
bower install angular-loading#e30ad76
or add the following in your project's bower.json:
"angular-loading": "e30ad76"
I successfully use this library in Angular 1.5.x

Hi mattheworres,
Thanks for your help!
When I added your version, then I installed this package into my project, I got the issue: "ECONFLICT Unable to find suitable version for angular".
I think your bower has an issue with angular version requirement.

@jerrybk108 yes, due to the Bower.json of this project being out of date (as per the request of this issue, and a few PRs update it as well I think), Bower can't find a suitable version that matches the constraints, and thus will warn you.
If you resolve the Angular version to the version you're using, in most instances Bower will provide its warning, but will pull the libraries down as needed. As I said, I've been using angular-loading in Angular 1.5 without any issue, so it works. There may be a few edge cases that don't perform as expected, but I haven't found them.


fix(dashboardgrid): 6277-Dashboard-Grid-Tile-Jump

Closes #780
Summary
Dashboard Grid (dashboard,isEditable) : Tiles on dashboard grid is jump (animated) while rending the page.
Change List (commits, features, bugs, etc)
src/components/Dashboard/DashboardGrid.jsx
src/components/Dashboard/snapshots/DashboardGrid.story.storyshot
Acceptance Test (how to verify the PR)
Click on Dashboard (dashboard,isEditable) link, Dashboard tiles should be rendering static without animation

Hi @davidicus @stuckless
Please review the PR #894 related the defect #780 .
Thanks,
P S Dixit

Is this a duplicate of #803? They both have the same graphite issue number.

:tada: This PR is included in version 2.38.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


kubeconfig does not exist on server after successful installation

Environmental Info:
K3s Version:

k3s version v1.25.4+k3s1 (0dc63334)
go version go1.19.3

Node(s) CPU architecture, OS, and Version:

Linux k3s-server 5.15.0-56-generic 62-Ubuntu SMP Tue Nov 22 19:54:14 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Linux k3s-worker-1 5.15.0-56-generic 62-Ubuntu SMP Tue Nov 22 19:54:14 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Ubuntu 22.04 LTS on both machines
Cluster Configuration:
1 server, 1 agent
Describe the bug:
I installed the k3s server following the quick-start guide. Both server and worker node are running fine and kubectl is working on the server.
Now, I wanted to install kubectl locally on my laptop, in order to connect to the cluster server. However, when I check the server, there is no kubeconfig file on the hard disk. The directory ~/.kube does not exist and the directory /root/.kube only contains a subdirectory cache, but no file named config.
Why is that and where do I get my kubeconfig from? I'm new to Kubernetes.
Steps To Reproduce:
Follow the quick-start guide and execute
curl -sfL https://get.k3s.io | sh -

on the server machine. Log in via ssh and check the directories ~/.kube and /root/.kube for config files.
Expected behavior:
There should be a file /root/.kube/config.
Actual behavior:
There is no file /root/.kube/config.
Additional context / logs:
kubectl is only working via sudo kubectl, i.e., the command sudo kubectl get nodes yields the output
NAME           STATUS   ROLES                  AGE   VERSION
k3s-worker-1   Ready    <none>                 44m   v1.25.4+k3s1
k3s-server     Ready    control-plane,master   68m   v1.25.4+k3s1

but the command kubectl get nodes yields
WARN[0000] Unable to read /etc/rancher/k3s/k3s.yaml, please start server with --write-kubeconfig-mode to modify kube config permissions
error: error loading config file "/etc/rancher/k3s/k3s.yaml": open /etc/rancher/k3s/k3s.yaml: permission denied

Hence, I assumed that the kubeconfig should be located at /root/.kube/config.
Also note that there is no directory /etc/kubernetes as some Stackoverflow posts suggest.

you should give the right permission to the file.
sudo chmod +r /etc/rancher/k3s/k3s.yaml or start K3s with the flag --write-kubeconfig-mode 644

There should be a file /root/.kube/config.

Please see the docs at https://docs.k3s.io/cluster-access

@brandond thank you so much. How could I miss that. 🤦🏻♂
I assumed k3s.yaml was just some sort of template file.
Thanks again.


Fix README regarding lossless webp

In the README it says

webp at quality 100 is lossless

However, I noticed that with --encode_quality 100, images are smaller than expected. According to the OpenCV Docs, lossless compression is only used if IMWRITE_WEBP_QUALITY  is above 100. I verified that using --encode_quality 101 generates images with larger file size.
The README should probably be updated to make users aware of this subtle difference.

interesting!
could you PR that please ?


bug: fzf-lua text invisible

Neovim version (nvim -v)
NVIM v0.11.0-dev-358+g6a886a251
Terminal / multiplexer
konsole
Describe the bug
hello
when using fzf lua most of the item listing are invisible

I'm not sure if it's something we can fix in rose pine, but I don't know where to find help otherwise, maybe this can be added as a plugin like some other in the wiki
Repro
vim.o.packpath = "/tmp/nvim/site"

local plugins = {
	rose_pine = "https://github.com/rose-pine/neovim",
	fzf_lua = "https://github.com/ibhagwan/fzf-lua",
}

for name, url in pairs(plugins) do
	local install_path = "/tmp/nvim/site/pack/test/start/" .. name
	if vim.fn.isdirectory(install_path) == 0 then
		vim.fn.system({ "git", "clone", "--depth=1", url, install_path })
	end
end

require("rose-pine").setup({})

vim.cmd("colorscheme rose-pine")

require("fzf-lua").setup({ fzf_colors = true })

-- then do FzfLua files

relevant part in fzf lua docs https://github.com/ibhagwan/fzf-lua?tab=readme-ov-file#fzf-colors

discussion about it on the fzf Lua repo https://github.com/ibhagwan/fzf-lua/discussions/1325#discussioncomment-9993832

the group needing setup is FzfLuaCursorLine

using this highlight group FzfLuaCursorLine = { bg = "#f2e9e1", fg = "text" }, but this is just a hotfix and not a fix, as the current selected line is the same as the other, but color should slightly change (I think it should be a little more bold?)

@mirsella
By any chance does the override you mention above work without you setting a foreground for FzfLuaCursorLine... just only the background?
Because that highlight group links to CursorLine according to FzfLua's documentation about highlight groups here, and CursorLine doesn't normally have a foreground color set.

@mirsella
I think the comment you left for me here --> https://github.com/rose-pine/neovim/issues/277
Was actually in regards to this... if so can you try doing what I asked above. I'd like to try to see if this is something we can fix.

doesn't work, here is the result without fg:

yes the comment you left on the other issue i thought it was for me, because the tag @. mvllow looks like @mirsella lol, but i was answering to the message you left there not this one.
thanks for looking into it !

maybe fzf lua overwrite the fg with this whiter color. it works on dark mode tho

I don't have FzfLua installed (I use Telescope)... so I can't check necessarily what it's doing... I can only go by the documentation.
Let me look into things a bit more.

				CursorLine = { bg = "highlight_med", fg = "text" }, also fix it, but it stil require the fg

@mirsella
I am in the middle of working on a fix for this now hopefully.
Quick question.. do you by any chance use LazyVim?

yes I do !
sorry should have a precised that

Yeah I figured that out.... says right in the one screenshot... shakes head 😆

Do you have any config customization you've done specifically for FzfLua, or are you just using LazyVim's default config for it?

@mirsella
Just submitted the PR that should be a good fix for this.. you can test it, by modifying your rose-pine config with the following:
{
  -- 'rose-pine/neovim',
  'sjclayton/rose-pine',
  branch = 'fix-fzflua-invisible-selection',
  -- rest of your rose-pine config below
},

Let me know how it goes.. 😄

hey ! thanks a lot ! sadly this still doesn't work (yes im on your branch with lazy.nvim)
the issue only happens on light mode !

Wait what, it work when my config is ```
{
-- "rose-pine/neovim",
"sjclayton/rose-pine",
branch = "fix-fzflua-invisible-selection",
name = "rose-pine",
priority = 10000,
opts = {},
},
but

{
	-- "rose-pine/neovim",
	"sjclayton/rose-pine",
	branch = "fix-fzflua-invisible-selection",
	name = "rose-pine",
	priority = 10000,
	-- opts = {},
},

doesn't !

@mirsella
Does it work if you pass in opts in the opts table like normal.... that is weird, I don't know why it wouldn't work if opts was commented out... you shouldn't have to call setup or pass config = true.
Do you have a plugin spec for rose-pine somewhere else in your config or did you just modify the existing one you had?

ok this was really weird, my bad.
i had
return {
	"f-person/auto-dark-mode.nvim",
	dependencies = { "rose-pine/neovim" },
	opts = {
		update_interval = 1000,
		set_dark_mode = function()
			vim.cmd("colorscheme rose-pine-moon")
		end,
		set_light_mode = function()
			vim.cmd("colorscheme rose-pine-dawn")
		end,
	},
}

in another .lua config, but lazy.nvim said it was yours version that was installed and loaded, so i thought it was ok since lazy nvim said the right version was loaded.

the behaviour is weird, in lazy.nvim in this case when opts = {} was commented out the plugin.setup() wasn't called, but when settings opts = {} it would be called.
guess when it wasn't called, the one in the dependencies of the other spec would be used instaed :shrug:
in any case, thanks a lot !

If you change one reference to my fork of rose-pine you have to change all other references to my fork as well or it doesn't know which to prioritize.


[FEATURE] OAuth2 implementation

Is your feature request related to a problem?
Is more often required this type of authentication/authorization.
What solution would you like?
A working solution is provided in the pull request #67
What alternatives have you considered?
A working solution is provided in the pull request #67
Do you have any additional context?

Thanks ! @rupal-bq could you review

Catch All Triage - 1 2 3 4 5 6


create tries to pass invalid arguments to ZFS

root@cube:~ # iohyve create debian 10gb
Creating debian...
too many arguments
usage:
create [-pu] [-o property=value] ...
create [-ps] [-b blocksize] [-o property=value] ... -V
For the property list, run: zfs set|get
For the delegated permission list, run: zfs allow|unallow
too many arguments
usage:
create [-pu] [-o property=value] ...
create [-ps] [-b blocksize] [-o property=value] ... -V
For the property list, run: zfs set|get
For the delegated permission list, run: zfs allow|unallow

Thanks for the report and bug squash!


MInor cleanup and fix for delta xds

Please provide a description of this PR:

merge responseNonce=nil with previousInfo =nil processing
fix con.proxy lock for shouldRespondDelta
cleanup some comments

To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Please check any characteristics that apply to this pull request.

[x] Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

@hzxuzhonghu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
4634200ab3d6a99a6a6471ec6eae1076f9bbeb45
link
true
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
4634200ab3d6a99a6a6471ec6eae1076f9bbeb45
link
true
/test release-notes_istio

unit-tests_istio
4634200ab3d6a99a6a6471ec6eae1076f9bbeb45
link
true
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
4634200ab3d6a99a6a6471ec6eae1076f9bbeb45
link
true
/test release-notes_istio

unit-tests_istio
4634200ab3d6a99a6a6471ec6eae1076f9bbeb45
link
true
/test unit-tests_istio

integ-pilot-istiodremote-tests_istio
4634200ab3d6a99a6a6471ec6eae1076f9bbeb45
link
true
/test integ-pilot-istiodremote-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
4634200ab3d6a99a6a6471ec6eae1076f9bbeb45
link
true
/test unit-tests_istio

integ-pilot-istiodremote-tests_istio
4634200ab3d6a99a6a6471ec6eae1076f9bbeb45
link
true
/test integ-pilot-istiodremote-tests_istio

release-notes_istio
5264ecaa58bb40103a7fd21d74d8ba1e711af783
link
true
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote-tests_istio
4634200ab3d6a99a6a6471ec6eae1076f9bbeb45
link
true
/test integ-pilot-istiodremote-tests_istio

release-notes_istio
5264ecaa58bb40103a7fd21d74d8ba1e711af783
link
true
/test release-notes_istio

unit-tests_istio
5264ecaa58bb40103a7fd21d74d8ba1e711af783
link
true
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
5264ecaa58bb40103a7fd21d74d8ba1e711af783
link
true
/test release-notes_istio

unit-tests_istio
5264ecaa58bb40103a7fd21d74d8ba1e711af783
link
true
/test unit-tests_istio

integ-pilot-istiodremote-tests_istio
5264ecaa58bb40103a7fd21d74d8ba1e711af783
link
true
/test integ-pilot-istiodremote-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
5264ecaa58bb40103a7fd21d74d8ba1e711af783
link
true
/test unit-tests_istio

integ-pilot-istiodremote-tests_istio
5264ecaa58bb40103a7fd21d74d8ba1e711af783
link
true
/test integ-pilot-istiodremote-tests_istio

release-notes_istio
c0637d9443d2d2a104a208a24c31809b3ee0e923
link
true
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
c6594a466b1177a17c63741fcbf6f029bdaab2c2
link
true
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
c6594a466b1177a17c63741fcbf6f029bdaab2c2
link
true
/test release-notes_istio

integ-pilot-multicluster-tests_istio
c6594a466b1177a17c63741fcbf6f029bdaab2c2
link
true
/test integ-pilot-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@hzxuzhonghu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry-mc-k8s-tests_istio
c6594a466b1177a17c63741fcbf6f029bdaab2c2
link
unknown
/test integ-telemetry-mc-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-telemetry-mc-k8s-tests_istio


chore: Enable Comet shuffle for Spark core-1 test

Which issue does this PR close?

Closes #.
Rationale for this change

We disabled Comet shuffle for Spark core-1 test because negative ref count issue reported by Java Arrow. After fixing memory issues and some changes to more follow C Data interface, we may re-enable Comet shuffle for Spark core-1 test in CI.
What changes are included in this PR?

How are these changes tested?

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 54.92%. Comparing base (033fe6f) to head (9fb03f1).
Report is 13 commits behind head on main.

Additional details and impacted files
@@              Coverage Diff              @@
##               main     #924       +/-   ##
=============================================
+ Coverage     34.03%   54.92%   +20.88%
+ Complexity      883      853       -30
=============================================
  Files           113      109        -4
  Lines         43170    10697    -32473
  Branches       9516     2050     -7466
=============================================
- Hits          14693     5875     -8818
+ Misses        25471     3789    -21682
+ Partials       3006     1033     -1973

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Seems negative ref count issue was fixed by previous commits revising array import/export.

lgtm thanks @viirya 1 minor why we have RUST_BACKTRACE enabled for ansi workflow test and disabled for regular one?

Thanks you @comphead
I'm not sure about it. Maybe we have added it for debugging ansi workflow before?


Add Iconsax

Request add new icon package.
iconsax the official icons of the Vuesax framework.
Iconsax WebSite
GitHub Repo
License
https://iconsax.io/#license

Look very good, it is an excellent icon set, but there is a problem with license.
Only open source icon sets are added to Iconify. That icon set has a custom license, even though it is free, it is not a valid open source license.


fix: Enhance error handling in ComputeTablePropertyControlV2 binding methods

Description
Updated the binding methods in ComputeTablePropertyControlV2 to improve error handling. The binding prefix now includes a try-catch block to prevent runtime errors when processing table data, ensuring that null values are returned gracefully in case of exceptions.
Fixes #38157
or
Fixes Issue URL

[!WARNING]
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation
/ok-to-test<EMAIL_ADDRESS>:mag: Cypress test results

[!CAUTION]
If you modify the content in this section, you are likely to disrupt the CI result for your PR.

Communication
Should the DevRel and Marketing teams inform users about this change?

[ ] Yes
[x] No

Summary by CodeRabbit

New Features

Enhanced error handling in the binding logic for improved robustness.
Improved type safety in data transformation processes.

Bug Fixes

Resolved potential runtime errors during binding expression evaluation.

Documentation

Updated method signatures and variable types for clarity and consistency.

/build-deploy-preview skip-tests=true

/build-deploy-preview skip-tests=true


Fix restore issue, add snapshot deletion after backup to s3

You may want to take a look at test_backup and add @patch('cassandras3.util.nodetool.sh') there too, I think that's what the tests are currently breaking on.
You can also fully mock the clearsnapshot call.

Last thing that was missing was an exception test for the clearsnapshot :)

Good job on this project, saved me a ton of time!

available via pip as 0.1.3:
https://pypi.org/project/cassandras3/0.1.3/


brain-score.org submission (user:495) | (public:False)

Plugin-only changes from brain-score.org submission. Generated via Jenkins job create_github_pr, build 273. Plugins added: models: [clip]

Closing; updated version was merged in #910


Show title on activity bar for Stacked Windows

When window is maximized, title is shown on Activy bar, but when it's stacked left|right the App name is shown:

The better is to rewrite Activity Titke also when stacked, since the title bar is hidden.

@deadalnix we could possibly close this issue too.


provide patch for PowerPC where 'vector' is unset

While developing on a PowerPC cluster I discovered an error when including the cl_platform.h file complaining about 'vector' not naming a type.  I discovered in this issue referencing opencv having the same problem.  The following patch fixes this problem.

Can you explain why this needs to be conditional on defined(__powerpc__)? The patch that Debian uses is to rename vector to __vector for all targets, including PowerPC.
Also, I'm afraid we've restructured the repository since you submitted this patch, so it doesn't merge cleanly. All OpenCL versions are now present in a single branch, which means changes like this should be made for every version in a single commit (ideally).

yes , IMHO the Debian patch is the correct patch also used here:  https://github.com/openembedded/meta-openembedded/commit/97dfbbbf6bddbd360638cde98cb53790ccc83059