Feature Request: Add Portable Code Library compatibility

Right now, whenever i generate code for a Portable Code Library type of project, i get this error on the "Contexts.cs":

error CS1061: 'Type' does not contain a definition for 'GetMethods' and no extension method 'GetMethods' accepting a first argument of type 'Type' could be found (are you missing a using directive or an assembly reference?)
error CS0117: 'Attribute' does not contain a definition for 'IsDefined'
error CS1579: foreach statement cannot operate on variables of type '?' because '?' does not contain a public definition for 'GetEnumerator'

I'll try to submit a PR with some flag for the ContextsGenerator.cs

Nowadays i'm replacing:
    ```

var postConstructors = System.Linq.Enumerable.Where(
GetType(),
method => System.Attribute.IsDefined(method, typeof(Entitas.CodeGeneration.Attributes.PostConstructorAttribute))
);

With

var postConstructors = System.Linq.Enumerable.Where(
GetType().GetRuntimeMethods(),
method => method.GetCustomAttribute(typeof(Entitas.CodeGeneration.Attributes.PostConstructorAttribute))!=null
);

I really don't know if this is the best way to do it. but it seems to be working


chore: update docs and TF format examples

Description

Update TF examples and docs
Acceptance tests

[] Have you added an acceptance test for the functionality being added?
[] Have you run the acceptance tests on this branch?

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Release Note
Release note for CHANGELOG:

Update docs
...

References

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi @pbr0ck3r, and thanks for considering contributing for terraform-provider-coralogix!
We are in the middle of implementing the new changes in Coralogix custom dashboards, and also intend to move the coralogix_dashboard to Terraform Plugin Framework, which will allow us to improve schema and validations.

Hi @pbr0ck3r.
I'm going to close this PR since the required changes where merged.


Json acceptance test

Creates an acceptance test for json

Write a acceptance test to check an internal Stratio's project


Bugs in Amuta screen

Phase 1: Hide Amuta screen + menu item from Spark.
Phase 2: Correct according to screen capture below.

information is now fetched from drupal.
this section is now working.


Rust examples

how to use in rust
i wish i saw this lib earlier
i gave up on using Candle for LLMs because we did not have the bandwidth to support structured outputs in https://github.com/mediar-ai/screenpipe and instead just embed ollama atm, would love to be able to run LLMs in pure rust with structured outputs

Unfortunately this library cannot yet be used as a Rust crate, but it should be possible by the end of the year. We will add documentation at this point.


Integration with Connect server

The object created by restify.createServer() cannot be used as middleware in a connect-based server.
The reason that this would be useful would be to mount a restify server at a specific path for an existing server:
// Mount the restify server from ./servers/api.js at the path "/path/to/api"
app.use("/path/to/api", require("./servers/api"));

This approach would allow an application to benefit from connect/express specific advantages for serving templated html pages at the root while leveraging restify's REST api competencies at that specific path.
Note that I have tried the following:
// ./servers/api.js

server = restify.createServer()

// Define routes, etc..

// Export the HttpServer created by Restify for connect to mount as per above
module.exports = server.server

This approach causes connect's /lib/patch.js to spew errors that headers have already been sent (by Restify)

Excellent idea +1

Yeah, I'm sure this doesn't work :)
I'll leave this open and look into it, but I'm pretty confident it won't be trivial (i.e., this is not going to happen in a super short timeframe).
m

+1 on this.
I currently have a connect 2.0 based app that has manually managed rest endpoints. I would love to be able to use restify for the API part while leaving the other code to continue doing it's thing.

Some pretty nice versioning techniques could be done with this feature. For reference, I found a nice article explaining how to do it with express.
http://j-query.blogspot.ca/2013/01/versioned-apis-with-express.html

@cadesalaberry restify already supports route versioning.


Build stuck in NioOioSocketEchoTest

Steps to reproduce the problem

Checked out latest develop (commit 2df35bb70369c8c0)
mvn clean install

Result was hang after the following line was printed out:
Running org.jboss.netty.channel.socket.NioOioSocketEchoTest

Two thread dumps follow, taken a few minutes apart:
org.jboss.netty.channel.socket.NioOioSocketEchoTest.stuckdump2.txt
org.jboss.netty.channel.socket.NioOioSocketEchoTest.stuck.txt

This happened again today.

This happened again today.
Logs


extendTag can redefine an existing tag

extendFunction and extendFilter let you redefine existing functions and filters, but extendTag prevented it, throwing an error.
This patch changes it, so that calling extendTag with the same tag type will just replace the handling function.

@justjohn @evgenius just rebased to current code - does it need anything done before it can be merged? Thanks.

@xavierpriour Thanks for creating this PR.
Currently I'm going to leave it in master.
We'll release a new version after we have some more changes.


html/head/body tags should not be added automatically to an existing file/partial

Describe the bug
I used pwa-asset-generator with --index flag to automatically add all splash image html tags for iOS. It added these tags as expected. However, it also added html, head and body tags which was unexpected:
<html>
  <head>
    <link rel="apple-touch-startup-image" ..>
     ...
  </head>
  <body>
  </body>
</html>

Since my "index" file is not an actual index, but is a separate partial html file, which is included by the html templating language I'm using into an actual "index.html" head tag then this broke my html and PWA (iOS actually doesn't work properly like this).
To Reproduce
Steps to reproduce the behavior:

npx pwa-asset-generator pwa-icon.jpg -i partial-head.html
Open partial-head.html
See additional tags

Expected behavior
pwa-asset-generator should not automatically add/modify any html, head and body tags when it is modifying a file instead of creating a new one. Or there should be a way to disable this behavior with an extra flag.
Anyway, this behavior was unexpected and unnoticed at first and it broke PWA.
System (please complete the following information):

cli version 6.0.8

Hi @jarmo, thanks for reporting this use case and sharing your feedback.
pwa-asset-generator was not designed to make edits to partial html files. I will mark it as a feature request and consider this improvement as part of the roadmap.

This feature would simplify everyone's life a lot. Thanks!


create-react-app not working for lower versionsExpected version "^6.14.0 || ^8.10.0 || >=9.10.0".

Is this a bug report?
it is trying to create project and then throwing error:
error<EMAIL_ADDRESS>The engine "node" is incompatible with this module. Expected version "^6.14.0 || ^8.10.0 || >=9.10.0".

Did you try recovering your dependencies?

(Write your answer here.)
Which terms did you search for in User Guide?

(Write your answer here if relevant.)
Environment

(paste the output of the command here)
Steps to Reproduce

(Write your steps here:)

Expected Behavior

(Write what you thought would happen.)
Actual Behavior

(Write what happened. Please add screenshots!)
Reproducible Demo

(Paste the link to an example project and exact instructions to reproduce the issue.)

trying i  another of creating react app.
create-react-app my-app --scripts-version=react-scripts-ts
:) It works for me


Document ENV

Successfully deployed skydive on kubernetes. I'm looking for documentation on the available ENV variables. Specifically, I'm trying to enable additional topology probes with skydive_topology_probes.

You can take a look in https://github.com/IBM/charts/blob/master/stable/ibm-skydive-dev/templates/deployment-analyzer.yaml you will find nice set of  skydive env. variables that are used as part of the IBM Cloud Private Helm chart

fixed: http://skydive.network/documentation/deployment#configuration-environment-variables


Allow for smaller or larger tab height size

Height of tabs and tab container currently is fixed. It would be nice to allow for the option to have a smaller height size of tab container by possibly having an option to set it in settings. Maybe even offer option for larger as well. One might also be able to have the option of disabling file icons to provide even more of a xsmall option. All this provides more real estate to editor instead.
Current:

Quick modified version of a solution. Line height still needs to be adjusted to be centered though.

VSCode Version: Latest
OS Version: Latest

Is there any easy way to make the tabs of smaller height? Feels like a huge waste of space the way its done currently.

In terminal-based editors, I love that tabs are usually just the height of a buffer line.

Exactly, there's no reason for them to be any higher than a single line. Sometimes it feels that designers who create "pretty" designs like tabs in VS Code never really understood the needs of programmers. I mean sure, it looks pretty at first sight, but then you realize you lose 3 centimeters of your possibly small laptop screen just to a useless menu and tabs.
Comparing this to VIM for example, I don't think I ever used tabs, in the sense that I do keep multiple buffers open (and splits possibly), but don't need to see their names at all times. Kinda unfortunate that the current norm is having 40 tabs open instead of having fast and easy buffer switching.

I would love to have this feature

Options should include: Default, Compact, Manual( need of value in pixels )

I have been searching and searching for this, sad that I cant edit the height/font size of the editor tabs. Only able to change "workbench.editor.tabSizing": "shrink", which makes it take less width.
Id love to be able to specify what font size or to specify at least a small normal and large. or something similar.

Any update on this feature? Is it on the roadmap yet?

I really wish this feature to be launched in near future. The height of tab size waste precious space in editor

+1, would really like for this customisation to be available

For issues where I span the entire stack of a web application, I can have at least 10-15 files open at any given time. Config, dao, html, front end js, back end js, models, etc. This level of customization would make it great for me to be able to easily manage a larger number of open files. Having a two layer tab with adjustable height would be awesome!

Tab titles seem unnecessarily tall (top and bottom padding). This is a BIG issue when working on laptops with no extra monitor as every pixel on the screen is precious real estate. Would LOVE to get some setting that adjusts this padding and make the tab smaller but still functional. As of now it feels like I am getting old and need to have HUGE titles lol.

I'm expecting this feature too. +1

Any update on this feature? Is it on the roadmap yet?

I also want this feature!

For @samrayleung, @wgq2633  and anyone that need that feature, I just got the same effect ajusting the "editor.fontSize" to a bigger size and then zooming out!
(it will also decrease the sidebar font-size)

I would like to see something like this specifically for  zooming in. Using VSCode for presentations is pretty easy by pressing cmd+ a few times. But the issue is that this also causes tabs and breadcrumbs to be too large. I'd like to have tabs visible at normal size for reference so I can cmd+number between "slides"
Alternatively, the option to not zoom in the tab bar with cmd+/- would work. Changing only editor font size is okay, but it also means the command pallet is also small for a presentation.

Would be great to be able to customize editors' tab bar height indeed.

Looking forward to this feature!

We all look to the future with hope, maybe there will be a feedback someday,.. :)

This can be very useful, especially if you are working on a small screen. I hope you will correct it.

This will be very useful if implied in a later update..... those huge tabs are really annoying...

I need this feature too. With such tabs i can't get nice and clean editing area.

Lil workaround in the settings.json:
    "workbench.editor.tabSizing": "shrink"
    "editor.fontSize": "16px",
    "window.zoomLevel": -2,

Zoom affects everything, including tab sizes. Font reverts the code-font-only part of the change.

It's actually not about saving half a codeline, but when you have a small screen (in our company we have 16:9 screens) and you use dense line settings is looks kind of unaesthetic to have such unnecessary high tabs. I would appreciate having this configurable to make it smaller.

I would appreciate some compact UI mode very much. On 13" laptops it gets messy from time to time and makes it hard to focus on code.

Yes please, it would be very helpful to at least know if this is something the VSCode team is considering.

Same here, it would just be awesome to be able to hide this bar completly, especially in zen mode.
But reading this thread from early 2018, in 2020, I couldn't figure if we're getting close to the solution, are we ?  Or should we just use one of the quick/crafty solution ?

What's most frustrating about this issue is how easy it is to fix/implement, and despite so many people wanting it, nobody cares. People praise Microsoft for doing an amazing job with VS Code and how they care about community ... well I'm not going to argue they're doing a great job with VS Code and releasing lots of features, but this issue perfectly shows how they only care about features that are important to them, and not to the community.
I do realize there are almost 5000 issues open here, but at the same time, when someone complained about that Christmas issue, remember how quickly it was resolved? It's just that this is something nobody at Microsoft cares about, and it isn't going to make them any money, so nobody cares. VS Code is just going to slowly turn into one of those projects that will have 5+ year old issues that people constantly comment on and upvote, yet stay unfixed.

What's most frustrating about this issue is how easy it is to fix/implement, and despite so many people wanting it, nobody cares.

Obviously it's either not wanted so badly or not that easy to fix/implement so that someone (from the people wanting this) finally stood up and filed a PR.
I want to have that feature too, but not so badly to justify the efforts it would take to fix it myself (i.e. start with learning typescript).
I'm grateful for getting such a great Editor/IDE for free. I'm grateful for MS sponsoring the main investments and for the community helping and improving this software.

but this issue perfectly shows how they only care about features that are important to them, and not to the community.

Sure, why not, implementing features important to them is naturally more important to them, so they take precedence.

I do realize there are almost 5000 issues open here, but at the same time, when someone complained about that Christmas issue, remember how quickly it was resolved?

That's a strange comparison: the xmas issue made it to the top news of most IT sites, the "size-of-the-tab-bar"-issue surely won't.

VS Code is just going to slowly turn into one of those projects that will have 5+ year old issues that people constantly comment on and upvote, yet stay unfixed.

That's true of nearly all heavily used and bigger software projects. It's a matter of priorities and investmenets of limited resources: not only for MS but also for the community.
I understand being frustrated about old, unfixed, upvoted issues, but I don't get why one would want to blame exactly the one party (MS) that is already investing the highest fraction of resources into this project.

As I'm reading your post @dguendisch, a question came to my mind: could I implement this myself ? I wouldn't really know were to start and I have never participated in any open source project like this one, but could I? Would it get accepted just like this ?

@yanisdb PRs get accepted if they are correct, don't add or change features that contradict the products more global vision, don't change things in incompatible ways, you have signed the respective contributor license agreement and so on.
Making the tab size configurable is most likely not something that needs too much discussion, vscode already allows to tweak & customize its UI in lots of detailed ways. So yes, I don't see why a sound PR for this feature shouldn't get accepted.
Most OS projects typically have some contributors guide, so your start would be https://github.com/microsoft/vscode/wiki/How-to-Contribute
If you are serious about implementing this feature I'd also start getting in touch with more experienced devs, a good place might be https://github.com/Microsoft/vscode/wiki/Feedback-Channels#slack

Any update ?

Since Microsoft not willing to provide an option, you can edit a CSS file to change the height of the tabs.

For Windows; Go to VS Code installation folder, find resources/app/out/vs/workbench/workbench.desktop.main.css file, Linux/Mac probably have identical location for the CSS file.

Backup that file before editing

Search these CSS elements one by one and find height:35px within brackets in the workbench.desktop.main.css and change it to height you want
.monaco-workbench .part.editor>.content .editor-group-container>.title .editor-actions{
.monaco-workbench .part.editor>.content .editor-group-container>.title .tabs-container>.tab{
.monaco-workbench .part.editor>.content .editor-group-container>.title .tabs-container{

Changing VS Code installation files will trigger popup, you can ignore it by clicking "Don't Show Again", also "Unsupported" text will appear in the VS Code window title. Also each update will overwrite the CSS file and you will lose your changes.
Default height:35px (left) vs. 20px edit (right)

So this isn't a real fix - but using this snippet that I just wrote:
.monaco-workbench .part.editor>.content .editor-group-container>.title .monaco-scrollable-element {
    height: 23px !important;
}

.monaco-workbench .part.editor>.content .editor-group-container>.title .tabs-container>.tab {
    height: 23px !important;
}

.monaco-workbench .part.editor>.content .editor-group-container>.title .editor-actions {
    height: 23px !important;
}

.monaco-workbench .part.editor>.content .editor-group-container>.title .editor-actions .action-label, .monaco-workbench .part.editor>.content .editor-group-container>.title .title-actions .action-label {
    height: 23px !important;
}

@sean9keenan
It doesn't change anything in my VSCode. I inserted your code in a file custom.css and added in settings.json the lines:
    "vscode_custom_css.imports": [
        "file:///C:/Program%20Files/Microsoft%20VS%20Code/custom.css"],
    "vscode_custom_css.policy": true

Is it still valid for VSCode 1.45?

@bitagoras try using https://marketplace.visualstudio.com/items?itemName=iocave.monkey-patch css and javascript loader
then put this in your settings.json
"customizeUI.stylesheet": {
        ".monaco-workbench .part.editor > .content .editor-group-container > .title .tabs-container > .tab": "height: 23px !important;",
        ".monaco-workbench .part.editor>.content .editor-group-container>.title .editor-actions": "height: 23px !important;",
        ".monaco-workbench .part.editor>.content .editor-group-container>.title .monaco-scrollable-element": "height: 23px !important;",
        ".monaco-workbench .part.editor>.content .editor-group-container>.title .editor-actions .action-label, .monaco-workbench .part.editor>.content .editor-group-container>.title .title-actions .action-label": "height: 23px !important;",
    },

which would then result into this

@vianneychin @bitagoras - That plugin looks better 😅.
I found that "re-loading" the custom CSS loader plugin was a bit awkward and required restarting the whole VSCode instance (as well as running the "load custom css" command in the command palette).
On a broader note - would the core team even welcome a change where the height of the tabs could be changed via a single setting?

@sean9keenan the third css selector seems to add unwanted extra spacing to the bottom of the editor

@vianneychin Ok - after a bit more digging I figured it out why it's not working. The issue is that the window into the text editor view itself sets fixed width / height values in... many places.
Unfortunately, I don't see an easy pure CSS solution - the correct fix is definitely to make a PR to the repo.
Which means that my above CSS does not save you any vertical space. Using this for a few days I do find that most of the benefit for me personally is in increasing the density of information at the top.

I'm using this extension already to get rid of the top title bar (and the traffic lights):
https://marketplace.visualstudio.com/items?itemName=iocave.customize-ui
And it also allows you to customize the tab row height:

I used this in settings.json:
"customizeUI.stylesheet": {
    ".monaco-workbench .part.editor>.content .editor-group-container>.title .tabs-container>.tab.sizing-shrink>.monaco-icon-label>.monaco-icon-label-container": "line-height: 32px !important",
    ".monaco-workbench .part.editor>.content .editor-group-container>.title": "height: 32px !important"
  }

Thank you guys!

@sean9keenan I've managed to set the sizes of the all divs containing the lines to 100% thinking it would fixe the issue but it did not work. The lines still disappear sooner. The size of the editor or should I say the number of line is not defined by the css code I think.
When the line arrive at the bottom (or near to it) a script removes the div containing the line. Or at least something like that I think.
But I still think we could still get it to work better and that we could win some space. The divs take 100% of the height but the line is still partly hidden (see the last line of the screenshort). The line is still there but nearly completely hidden. I'm not good enough in CSS or HTML to figure what it hidding though. Does anyone have an idea ?

@yanisdb try the approach here - https://github.com/microsoft/vscode/issues/42253#issuecomment-628688080

@yanisdb try the approach here - #42253 (comment)

What do you mean ? I've already used some custom css to make the tab bar disappear but its creates some kind of gap at the bottom. See my screenshot. My question was if someone new how to make disappear @sean9keenan last comment saying it's impossible.
Does the comment help with that ? I think I might be failing to see how ?

@yanisdb the approach I posted doesn't seem to create space at the bottom:

But you've still got the tab bar. We not trying to achieve the same effect. I want only the window bar (which disappear in full screen) and no tab bar.

@yanisdb oh, now I see the problem, I only made my tabs a little bit shorter so I didn't notice but when I looked closer I can see that the code is not taking up the full height of the window. I added the CSS to fix this:
".editor .editor-container": "height: calc(100% - 31px) !important;",
".editor .monaco-editor .overflow-guard": "padding-bottom:6px !important",
".editor .editor-container .monaco-scrollable-element.editor-scrollable": "padding-bottom:6px !important",

I'm only subtracting six pixels from everything (with my shorter tabs) but since you're not showing any tabs you'll need to update calc to not substract anything, and add paddings of 30 something px-

I'm sorry but I don't get it and I can't make it work.
Why are you adding padding to the bottom ? Aren't we trying to make a gap disappear and wouldn't adding some padding my the bottom gap bigger ?
And height I've set it to 100% because I want the editor to fill the screen.
Am I getting everything wrong ?

@yanisdb chris' recent solution only works if you disable the Breadcrumbs: enabled to false in the Settings UI.
chris' solution works great for this particular setup

I've found a solution so easy that it really makes wonder why it's not option in VSCode directly.
In this file https://github.com/microsoft/vscode/blob/master/src/vs/workbench/browser/parts/editor/editor.ts there is at line 19, this constant: export const EDITOR_TITLE_HEIGHT = 35.
Setting it to 0 is exactly what i wanted.

Now, the text gets cutted at the exact edge of the windows.
I had to modify this file : C:\Users\yanis\AppData\Local\Programs\Microsoft VS Code\resources\app\out\vs\workbench\workbench.desktop.main.js but this doesn't seem like a long lasting solution as it will be overidden at each update.

it'd great if there also have a setting to tweak the toolbar size.

it'll be great if there also has a setting to tweak the toolbar size.

I'm sure a shrunk version or a custom setting is needed. I like it to be as small as JetBrains WebStorm tab size is.

I'm kinda baffled it was 2 years of nothing for such basic primitive feature.  Welcome to the software of the future

Googling for this in september 2020 :sob:

"body.inline-title-bar .monaco-workbench .part.editor>.content .editor-group-container>.title .tabs-container, body.inline-title-bar .monaco-workbench .part.editor>.content .editor-group-container>.title .tabs-container>.tab, body.inline-title-bar .monaco-workbench .part.editor>.content .editor-group-container>.title .editor-actions":"height:2.3em !important;line-height:2.3em !important",
".tab .tab-label":"line-height:2.3em !important",
".tabs-and-actions-container":"height:2.3em !important",
"body.inline-title-bar .monaco-workbench .part.editor>.content .editor-group-container>.title .tabs-container>.tab .monaco-icon-label:before":"height:2.28em !important",
".monaco-workbench .part.editor>.content .editor-group-container>.title .editor-actions .action-label:not(span), .monaco-workbench .part.editor>.content .editor-group-container>.title .title-actions .action-label:not(span)":"height:1.9em !important",

this works for me

.monaco-workbench .part.editor>.content .editor-group-container>.title .tabs-container>.tab .tab-label,
.monaco-workbench .part.editor>.content .editor-group-container>.title .tabs-container>.tab.sizing-shrink>.monaco-icon-label>.monaco-icon-label-container {
	line-height: 26px;
}

.monaco-workbench .part.editor>.content .editor-group-container>.title .editor-actions .action-label:not(span), .monaco-workbench .part.editor>.content .editor-group-container>.title .title-actions .action-label:not(span),
.monaco-workbench .part.editor>.content .editor-group-container>.title .editor-actions,
.monaco-workbench .part.editor>.content .editor-group-container>.title .tabs-container,
.monaco-workbench .part.editor>.content .editor-group-container>.title .tabs-container>.tab {
	height: 23px;
}

 .monaco-workbench .part.editor>.content .editor-group-container>.title {
    height: 23px;
    line-height: 23px;
}

.editor-group-container > .editor-container {
	height: calc(100% - 23px)!important;
}

.editor-group-container > .editor-container .monaco-editor,
.editor-group-container > .editor-container .monaco-editor > .overflow-guard,
.editor-group-container > .editor-container .monaco-editor > .overflow-guard > .monaco-scrollable-element
{
	height: 100%!important;
}

Fixed also extra space in text editor after shrinking the tabs. Adjust to your liking.

I'd really like to see this functionality implemented as well, as I'd prefer to avoid the associated maintenance burden of having to hack the VSCodium files

Bumping because this is so annoying, option to hide tabs with name and everything and just leave the actual editor would be great as well.

@Gitleptune, not sure if this is what you mean but you can hide the tabs entirely:
workbench.editor.showTabs

There is also a command that you can bind to toggle tab visibility.

INSTRUCTIONS:

Install the Monkey Patch extension.
Install the Customize UI extension. The Customize UI extension requires the Monkey Patch extension to be installed.
Open your settings.json file and paste the code below at the beginning of the file.

"customizeUI.stylesheet": {
"_comment": "The settings below reduce the height of text block inside tabs",
"body.inline-title-bar .monaco-workbench .part.editor > .content .editor-group-container > .title .tabs-container, body.inline-title-bar .monaco-workbench .part.editor > .content .editor-group-container > .title .tabs-container > .tab, body.inline-title-bar .monaco-workbench .part.editor > .content .editor-group-container > .title .editor-actions": "height: 2.1em !important; line-height: 2.1em !important",
".tab .tab-label": "line-height: 2.1em !important",
    "_comment": "The setting below reduces the height of tabs",
    ".tabs-and-actions-container":"height: 2.1em !important",

    "_comment": "The settings below eliminate the white stripe at bottom of editor caused by reducing the height of tabs",
    "body.inline-title-bar .monaco-workbench .part.editor > .content .editor-group-container > .title .tabs-container > .tab .monaco-icon-label:before": "height: 2.1em !important",
    ".monaco-workbench .part.editor > .content .editor-group-container > .title .editor-actions .action-label:not(span), .monaco-workbench .part.editor > .content .editor-group-container > .title .title-actions .action-label:not(span)": "height: 2.1em !important",
    ".editor .editor-container": "height: calc(100% - 2.1em) !important",
    ".editor .monaco-editor .overflow-guard": "padding-bottom: 2.1em !important",
    ".editor .editor-container .monaco-scrollable-element.editor-scrollable": "padding-bottom: 2.1em !important"

},

Customise tab height to your liking by substituting "2.1" by any other number.
Save the file.

NOTES:

I haven't used the attach-code functionality on this website because it leaves a big chunk of the code outside the code box for some reason unknown to me.
I know bugger-all about CSS. I stumbled upon the code above quite a while ago and then recently I came across this page, so I thought I'd share the code. Everything looks good for me except I get a very thin gray line between the body of the editor and the tab. The line disappears when the file is scrolled all the way up. See pictures below.
Scrolled all the way up

Not scrolled all the way up

If anybody knows how to fix this minor problem, please let us know.

+1 for this feature.

I just wanted to share my current css to achieve this.
Just load it with your custom-css-loader of choice if you want to use it.
:root {
    --size-reduction: 10px;
}

.tabs-container {
    height: calc(35px - var(--size-reduction)) !important;
}

.tabs-container .tab,
.tabs-container .monaco-icon-label,
.tabs-container .monaco-icon-label::before,
.tabs-and-actions-container .editor-actions {
    height: unset !important;
}

.tabs-container .monaco-icon-label {
    line-height: unset !important;
}

.editor-instance > .monaco-editor,
.editor-instance > .monaco-editor .overflow-guard,
.editor-instance > .monaco-editor .monaco-scrollable-element {
    height: 100% !important;
}

.editor-instance,
.editor-instance > .settings-editor .settings-toc-wrapper,
.editor-instance > .settings-editor .settings-editor-tree {
    height: calc(100% + var(--size-reduction)) !important;
}

.editor-instance > .settings-editor {
    height: calc(100% - var(--size-reduction)) !important;
}

You can define how much smaller you want the tab bar to be by changing the --size-reduction value.
It works pretty well I think with all the symbols properly aligned.

Just the height of the minimap is a little bit off since I can't really resize a canvas with css when its size is set inline by VSCode.

Any custom editors from your extensions might be off as well by the same amount since vscode uses a lot of (useless) inline height setting (which could be avoided by just using 100% or not setting it at all).

Is this option being looked at by the VSCode team?
Personally, the tabs take up too much real-estate on the GUI

@Dromantor Your current solution is good but native support would be soooo much better and it seems to be highly sought for.
I removed the tab area completely using a similar solution for the time being.

I have found the (yet another..) solution before I discovered this topic.. Here is what I use:
:root {
  --tab-height: 26px;
}

.tabs-container .tab {
  height: var(--tab-height) !important;
  line-height: var(--tab-height) !important;
}

.tabs-container .monaco-icon-label {
  height: var(--tab-height) !important;
  line-height: var(--tab-height) !important;
}

.tabs-container .monaco-icon-label:before {
  height: var(--tab-height) !important;
  line-height: var(--tab-height) !important;
}

before:

after:

in case if someone is interested on how to display pinned tabs on separate row here's the  other discussion.

Using Monkey Patch + Cusomitze UI extensions, I applied @pavlexander's styles with a few modifications of my own:
    "customizeUI.stylesheet": {
        ":root": "--tab-height: 26px; --font-size-tab-title: 10px;",
        ".tabs-container .tab": "height: var(--tab-height) !important; line-height: var(--tab-height) !important;",
        ".tabs-container .monaco-icon-label": "height: var(--tab-height) !important; line-height: var(--tab-height) !important; font-size: var(--font-size-tab-title); !important",
        ".tabs-container .monaco-icon-label:before": "height: var(--tab-height) !important; line-height: var(--tab-height) !important;",
        ".tabs-container .tab-actions": "display: none; !important",
        ".tabs-container .monaco-icon-description-container": "display: none;",
    }

@donut
I have added a missing style just now. Please check the edit. The .editor-actions class affects the size of the editor action button (if that is what it's called).
Without the proper fix it looks like this:

after:

(p.s. nice nickname)

@pavlexander Thanks on both counts. I've updated the code the comment.

@donut I'm not sure if there's been any editor changes lately, but my tool bar had spacing around it vertically (sometimes). To fix that I removed the static height of the tabs-container class. I also toggled the tab actions back on if anyone else was curious, as it doesn't effect the tab height.
"customizeUI.stylesheet": {
   ":root": "--tab-height: 26px; --font-size-tab-title: 10px;",
   ".editor-actions": "height: var(--tab-height) !important; line-height: var(--tab-height) !important;",
   ".tabs-container": "height: unset !important;",
   ".tabs-container .tab": "height: var(--tab-height) !important; line-height: var(--tab-height) !important;",
   ".tabs-container .monaco-icon-label": "height: var(--tab-height) !important; line-height: var(--tab-height) !important; font-size: var(--font-size-tab-title); !important",
   ".tabs-container .monaco-icon-label:before": "height: var(--tab-height) !important; line-height: var(--tab-height) !important;",
   // ".tabs-container .tab-actions": "display: none; !important",
   ".tabs-container .monaco-icon-description-container": "display: none;"
 },

@donut I'm not sure if there's been any editor changes lately, but my tool bar had spacing around it vertically (sometimes). To fix that I removed the static height of the tabs-container class. I also toggled the tab actions back on if anyone else was curious, as it doesn't effect the tab height.
"customizeUI.stylesheet": {
   ":root": "--tab-height: 26px; --font-size-tab-title: 10px;",
   ".editor-actions": "height: var(--tab-height) !important; line-height: var(--tab-height) !important;",
   ".tabs-container": "height: unset !important;",
   ".tabs-container .tab": "height: var(--tab-height) !important; line-height: var(--tab-height) !important;",
   ".tabs-container .monaco-icon-label": "height: var(--tab-height) !important; line-height: var(--tab-height) !important; font-size: var(--font-size-tab-title); !important",
   ".tabs-container .monaco-icon-label:before": "height: var(--tab-height) !important; line-height: var(--tab-height) !important;",
   ".tabs-container .monaco-icon-description-container": "display: none;"
 },

If you want to hide the tab actions, add this:
   ".tabs-container .tab-actions": "display: none; !important",

Feature not done yet 😢

@TheMFB  The "tabs-container .monaco-icon-label" rule has an incorrect semicolon after font-size

It worded out for me with the "Custom CSS and JS Loader" but it's still a hack.

My tabs are set to "shrinked" mode, close button off, from the regular User.settings pannel, plus the @pavlexander code in the custom.css local file. For some reasons the height didn't applied to .tabs-container with the css variable, so I hard-coded it to 20px at the end of the file.
It was a quick & mindless test, but as it seems to be enough, i'll keep it that way.
Feels good using a minimalist VSCode with gruvbox & Vim keyBinds.

I'm adding this comment to keep this issue alive...I want this feature! It would be nice to have it configurable by themes

There is no reason to update this thread. Take a look at the history of VSCode medium and below-medium "sized" features - if it is not something some popular person tweeted or said, you can expect approximately ~10 years period.
Therefore, I suggest to fallback to user-suggested workarounds.

I am using my own extension for this. It is monkeypatching the javascript code and CSS for sidebar, panel title bars, window title bar and editor tabs to a custom height. It also allows setting background images

The code is up here https://github.com/nidefawl/vscode-custom-loader for anyone interested

I moved from vscode to neovim precisely because of the lack of this feature :

https://github.com/nidefawl/vscode-custom-loader

I don't see documentation for this.

I am using my own extension for this. It is monkeypatching the javascript code and CSS for sidebar, panel title bars, window title bar and editor tabs to a custom height. It also allows setting background images
The code is up here https://github.com/nidefawl/vscode-custom-loader for anyone interested

Great implementation, but you NEED at least a  small documentation on how to use it.

In the newest insider we now support a setting to reduce the editor tab height. The compact option reduces the height to  the same height as breadcrumbs. The setting also applies to the editor title when tabs are not shown.

Is this planned for the next release?

@Kein yes, this will be part of the September release

The current implementation of this doesn't seem to let you configure how high you want your tabs to be, only switch between a preset height of 35 (way too tall) and 22 (way too short for my liking). Is there any way we can define a height manually?
I saw --editor-group-title-height in the commit, but I have no idea how this variable is defined or if it's accessible as a command line flag, or a JSON entry, or what.

Really stupid workaround for those who need it:

Open VSCode/resources/app/out/vs/workbench/workbench.desktop.main.js in a text editor
Search for the text normal:35,compact:22
Change the "compact" value to be something else
Enable compact mode in the settings

This should survive future code changes and be a fairly reliable way of setting a custom value, at the cost of "corrupting" your installation and getting warned about that.

The current implementation of this doesn't seem to let you configure how high you want your tabs to be

Open VSCode/resources/app/out/vs/workbench/workbench.desktop.main.js

I can't stop laughing, we are back to where we started: editing VSCode resources. Everything is implemented in a typical MS fashion 🤣

Because of this M$ wants to obfuscate the code to stop people to mess with their holy code...

@benibenj I want to thank you for allowing the option for compact tabs but I still feel there is need for larger tabs for those who wish to have that. should that be a separate issue then?

@imoby I suggest you make a new issue specifically for this. We can then better see how many users would need this and why. Looking threw the timeline of the current issue, I mostly see people interested in smaller tab heights.

Is there a good reason not to expose the height variable to users and let them set it to whatever they want? I can't see this leading to anything except years of further complaining - "yes I wanted taller tabs but not THAT tall", "no actually I wanted even shorter tabs, this doesn't work for me".
It's a bit like people requesting the ability to use smaller or larger fonts, and then years later adding the ability to use exactly 10pt high text under a "compact" option.


OutOfMemory Exception

I am trying to run ice, but continuously getting OutOfMemory Exception.

I even tried setting JVM options in docker-compose file but still its not working.

How can I resolve this error?

Ice is launched via grails and so the entrypoint isn't java which is why adding the options to the command didn't work.
ENTRYPOINT ["/opt/ice/grailsw"]

The Dockerfile contains ARG JAVA_OPTS. You can pass in options via the JAVA_OPTS environment variable.
 environment:
  - JAVA_OPTS=-Xms4G -Xmx5G

You might need quotes around the actual options.

I was running into the same issue, and had previously tried both of the workarounds listed here.  neither worked.   This did:
  environment:     - GRAILS_OPTS=-server -Xmx4G -Xms1G -Dfile.encoding=UTF-8
Let me know if it helps.

Yes, this worked, thanks a lot


How I can search from multiple models in laravel scout?

In My App i am using laravel scout for searching. For searching from single model i am using
Model::search('absc')->get();

But I want to search from all models how I can do it?
Driver is Elastic search

AFAIK you need to do that using each model class


fixes #771; added 50px right margin when comment contains divs

fixes #771;

Hey!
Thanks for contributing. I've reviewed this PR and it causes other comments (that don't contain code) to resize as well. Ideally we would render text normally (full-width) making code block match its width, without overflowing.
See: https://busy-dev-pr-786.herokuapp.com/cesky/@xlisto/krmeni-kotat#comments
By the way, you can use git config --global user.email YOUR_GITHUB_ACCOUNT_EMAIL so GitHub will connect your commits to your GitHub account.

Thanks @Sekhmet . i'll limit it more so that it won't affect the length the wrapping of other comments.

Work moved to #799

Thanks


Add additional examples of directed rounding

Summary
Added additional examples for directed rounding.
Specifically, examples for 3.5 which exist for Round to nearest, but were missing in directed rounding section.
Fixes (#6744)

Useless PR, opened a real one in main repo.


Changed it so runway commands are run from any repo

Runway is now just a shell, and each of the commands lives in a prospective repo that's defined in the paths for the runway repo itself.
So there will be a few commands in this core repo, there will be some in the active-record repo if you choose to have that repo in your project, and based on the dependencies you add, if they have specific commands for runway (usually saved in the src/commands/ directory), you can now use them automatically! :partying_face:

woa, more dependencies of the dependency..fine :D

So this is only a dev dependency. When you install flightphp/core, it does add the dependency. I had to add it as a dev dependency so it could be properly unit tested.


glyphicon icon not in center

Sorry, I'm using adminlte template, How about this? could you show me the fault of this? please

sources such as bootstrap, jquery, etc. are complete.

Possibly some upper CSS is messing up the centering. Please check the CSS tree for the icons in Firebug or Chrome Developer tools. If you need help with this, please provide a temporary environment with the UI which I can access.
Andre

Closing this as no more information was provided.


Explore and monitor key repository in Power BI by connecting to your GitHub data. Get a Power BI dashboard and reports with insights.

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e0947245-d1c6-486a-94a1-f8622a4f7efc
Version Independent ID: c837d3a1-75f5-ffd4-a32a-541bab72ffa7
Content: Manage data storage in your workspaces - Power BI
Content Source: powerbi-docs/admin/service-admin-manage-your-data-storage-in-power-bi.md
Service: powerbi
Sub-service: powerbi-admin
GitHub Login: @maggiesMSFT
Microsoft Alias: maggies

https://github.com/MicrosoftDocs/powerbi-docs/issues/2792#issue-798192306

Thanks for your submission, @matuhinal - could you provide a bit more context about what issue you've found, here in the Comment area?

Hi, @matuhinal -- closing this issue. Please reopen or create another issue, to provide more context, so we can understand the issue.
Thanks!

Good day!
Please no closing.
Lyudmila

От: Maggie Sparkman<EMAIL_ADDRESS>Отправлено: 12 февраля 2021 г. 8:35
Кому: MicrosoftDocs/powerbi-docs<EMAIL_ADDRESS>Копия: Matuhinal<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Тема: Re: [MicrosoftDocs/powerbi-docs] Explore and monitor key repository in Power BI by connecting to your GitHub data. Get a Power BI dashboard and reports with insights. (#2792)
Hi, @matuhinalhttps://github.com/matuhinal -- closing this issue. Please reopen or create another issue, to provide more context, so we can understand the issue.
Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/powerbi-docs/issues/2792#issuecomment-777929380, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABLBKOIE4TOAGQZQZWLWAALS6SHWDANCNFSM4W4QCXTA.


Table support

Table support (#29) that @giuseppe-santoro made available, with small adjustments to make it run with PDFKIT:master (for my use at least)
All credits belong to @giuseppe-santoro

:+1:

What is the ETA on this? Is it ready to be merged into master?

:+1: :)

@giuseppe-santoro, @sanderboom, do you know what is the status of this PR (and the very wanted table support, by extension)? Any plan to merge, add tests?

@Zopieux I think @devongovett should answer this ;) Personally, I don't use pdfkit anymore

Me too

@sanderboom what are you using instead?

@johannds Actually I've no need now for this functionality right now

+1, could really use this in master quite urgently. Happy to do conflict resolution as long as the maintainers are willing to merge it.

:+1:

:+1:

@johannds I would recommend pdfmake for creating pdf tables or jspdf with the autotable plugin. I would love to see this merged however!

:+1: +1:

:+1:

:+1:

Is this ever going to be merged?

This pull doesn't look like it was ever finished (lots of TODO messages in the code). Also, I think this can be done by a higher level library. Have a look at pdfmake which offers a nice declarative API on top of PDFKit, and supports tables excellently.


Gets agent state

Excuse me, I found in the code that when I get the agent state from the environment, I can only get the state of one agent at a time. Can I get the state of all agents at the same time?

Yes, see example code here: https://github.com/jimmyyhwu/spatial-intention-maps/blob/master/tools_interactive_gui.py#L429


Deck sharing: custom columns

Enhancement request for deck sharing. If a user moves or sorts cards between columns before sharing, we should maintain that in the shared version of the deck.

To me, this sounds like a niche feature with potential downside even.
Different users have different personal preferences - their own style - in how they lay their deck out. Why force others to see a deck their way? One might order by function of a card, others go by good old type. Some put all non-creates in one pile, or have a maybe pile and so on.
Users can freely rearrange cards in columns already when viewing them in logs or the bracket.
As long as their is a known standard on how decks are displayed by default for everybody, the viewer can go from there and adjust as he likes.
If the deck view of a shared deck looks different all the time because it is shown in the way a different person likes it most - you have to understand the logic behind that first before adjusting it to your needs.

I see your point about different people sorting differently, that's definitely true. But I somewhat disagree about the downside, because there's still a button to sort everything by CMC, so if someone disagree with the current columns they can click that and get back to current performance. Does the one-click option to sort by CMC and restore default columns change your mind, @tooomm ?
I think some column-setting approaches are more niche (like putting tricks and removal in their own column, or moving MDFCs with lands to count colored sources more easily). But other things I suspect would have consensus among most players: split cards probably go into the column of the cost you're most likely to use, Roost of Drakes is a 4 drop, Stonecoil Serpent isn't a 0-drop, etc.
Overall, I suspect deck sharing has two primary uses. One is for simulating open decklists before playing matches; in that case this feature is less important, since it'll be on opponents to evaluate your deck the best they can. But the other is reviewing the rest of the pod for learning purposes, either after playing matches or in lieu of matches (e.g. when testing a new set before release or testing team draft strategies); even potentially doing "deck techs" for each other. For this one, saving others time in reviewing your work is a pretty convenient addition, I think.

I see the point for learning, but like @tooomm I still think this is really niche feature. I'm not a fan of tying the log format to its presentation just for that, especially when there's still discussion on how to improve the CardPool component (#145).

True, sorting back to e.g. CMC is not a big deal.
It should be it's own sorting option to switch between for sure. It also doesn't have to be the default view necessarily.
Maybe something for later. 👍

Closing this one as I'm not personally in favor of implementing it.


Enchancement optimization for  vectorized table function

Proposed changes
before
mysql [test]>select sum(k1) from d_table  lateral  view  explode_numbers(20)  tmp1  as  e1;
+-----------+
| sum(`k1`) |
+-----------+
|         0 |
+-----------+
1 row in set (1.12 sec)

after
mysql [test]>select sum(k1) from d_table  lateral  view  explode_numbers(20)  tmp1  as  e1;
+-----------+
| sum(`k1`) |
+-----------+
|         0 |
+-----------+
1 row in set (0.44 sec)

Problem summary
Describe your changes.
Checklist(Required)

[ ] Does it affect the original behavior
[ ] Has unit tests been added
[ ] Has document been added or modified
[ ] Does it need to update dependencies
[ ] Is this PR support rollback (If NO, please explain WHY)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 33.77 seconds
stream load tsv:          455 seconds loaded<PHONE_NUMBER>9 Bytes, about 156 MB/s
stream load json:         23 seconds loaded<PHONE_NUMBER> Bytes, about 97 MB/s
stream load orc:          73 seconds loaded<PHONE_NUMBER> Bytes, about 14 MB/s
stream load parquet:          31 seconds loaded 861443392 Bytes, about 26 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230321210051_clickbench_pr_118158.html

run p0

run buildall

run buildall

run p0

run buildall

run buildall

run p0

run arm

run p0

run buildall

run buildall

run p0

run buildall

run arm


simplify azure test skips

This PR refactors the Azure test skip logic by moving the pytest.skip logic inside the same fixture that is used for a populated Azure container. Now tests just ask for the Azure fixture, and if it isn't installed the test automatically skips. Tested locally (skips correctly) and on CI (runs correctly).
Some other minor changes in support of this, specifically moving reading the Azure config inside the function that needs it to enable the test to mock the environment variables.

This is awesome 👍


THIS BOT STEALS YOUR COINS

DONT USE

Hi, if you read the README you can see how the bot works, its free and open source so if you dont want do donate a small amount on the winning rounds feel free to remove that code, most of the users does and its fine, as i said, its opensource, i provide the code as clean as possible and as easy to remove
im going to close the issue as is not an issue, thanks


Clarify recompilation logic

Clean up recompilation check - specifically the RecompileRequired result returned by checkOldIface only indicates whether we should recompile the object code. In particular, we don't need to pay attention to it if we aren't generating a Linkable.
The Maybe ModIface field being a Just is sufficient to indicate that we don't need to regenerate the ModIface.

The ghcide Github project is becoming archived and merged into https://github.com/haskell/haskell-language-server
This PR will need to be reopened in the HLS repo. To do that, create a new branch from HLS HEAD in your HLS repo and do:
git remote add ghcide https://github.com/georgefst/ghcide.git
git fetch ghcide
git merge ghcide disable-warnings

Thanks!


Crop mask stays present with zero-size crop

After creating a crop selection and then clicking on the crop area to clear the crop, the crop goes away but the background mask stays visible.
In a0cc2a1ea1508be48457452899b2783c591732e7, the crop mask was separated from the crop selection as a separate HTML element, but the styles were not updated.

I published your commit in 11.0.5 please try that


Twitter+Authlib+FastAPI works different than the docs suggest

Describe the bug
The docs describe a process for integrating Authlib, Starlette, and Twitter into an app that needs to be revised. I followed these docs to add Twitter OAuth 1 to my app, but got the following errors.
The example in the docs should also be edited to create a FastAPI instance instead of Starlette instance, because @app.get("/login") decorators don't exist in Starlette. I can start a PR for the docs edit if you agree.
Error Stacks
  File "/home/firescar96/.local/lib/python3.7/site-packages/starlette/routing.py", line 41, in app
    response = await func(request)
  File "/home/firescar96/.local/lib/python3.7/site-packages/fastapi/routing.py", line 133, in app
    raw_response = await dependant.call(**values)
  File "./broken.py", line 31, in auth_via_google
    token = await oauth.twitter.authorize_access_token(request)
  File "/home/firescar96/.local/lib/python3.7/site-packages/authlib/integrations/starlette_client/integration.py", line 58, in authorize_access_token
    return await self.fetch_access_token(**params)
  File "/home/firescar96/.local/lib/python3.7/site-packages/authlib/integrations/base_client/async_app.py", line 97, in fetch_access_token
    token = await client.fetch_access_token(token_endpoint, **kwargs)
  File "/home/firescar96/.local/lib/python3.7/site-packages/authlib/integrations/httpx_client/oauth1_client.py", line 61, in fetch_access_token
    self.handle_error('missing_verifier', 'Missing "verifier" value')
  File "/home/firescar96/.local/lib/python3.7/site-packages/authlib/integrations/httpx_client/oauth1_client.py", line 75, in handle_error
    raise OAuthError(error_type, error_description)
authlib.common.errors.AuthlibBaseError: missing_verifier: Missing "verifier" value

To Reproduce
import os
from starlette.requests import Request
from fastapi import FastAPI
from starlette.middleware.sessions import SessionMiddleware
from ma_http_interface import config
from authlib.integrations.starlette_client import OAuth

app = FastAPI()
app.add_middleware(SessionMiddleware, secret_key="some-random-string")

oauth = OAuth()
oauth.register(
    name='twitter',
    request_token_url='https://api.twitter.com/oauth/request_token',
    access_token_url='https://api.twitter.com/oauth/access_token',
    authorize_url='https://api.twitter.com/oauth/authenticate',
    api_base_url='https://api.twitter.com/1.1/',
    access_token_params={},
    authorize_params={},
    client_id=os.environ['API_KEY'],
    client_secret=os.environ['API_SECRET']
)

@app.get("/login")
async def login_via_google(request: Request):
    redirect_uri = 'https://example.com/auth'
    return await oauth.twitter.authorize_redirect(request, redirect_uri)

@app.get("/auth")
async def auth_via_google(request: Request):
    token = await oauth.twitter.authorize_access_token(request)
    user = await oauth.twitter.parse_id_token(request, token)
    return dict(user)

Expected behavior
I added the /auth route to my twitter app callback routes. I expected the call to not error but it did. After reading the authlib code I found adding this line at the beginning of the /auth route resolved the error.
oauth.twitter.access_token_params['verifier'] = request.query_params.get('oauth_verifier', '')

Do you think is because twitter passes the verifier query parameter in a different place than google does?
Environment:

OS: Debian 10
Python Version: 3.7.3
Authlib==0.14.1
httpx==0.11.1
starlette==0.12.9
fastapi==0.48.0

The documentation section title is "Using FastAPI"

I don't follow, is this library not supposed to work with Twitter? Or are you saying the title should be changed?

@molten-firescar96 oh, I finally got your problem.
Here is a demo of fastapi twitter login: https://github.com/authlib/demo-oauth-client/tree/master/fastapi-twitter-login
Please try with the latest Authlib v0.14.2.

I can confirm v0.14.2 fixes the problem. Cheers.


[Feature] 自定义JSX 支持switch开关

What problem does this feature solve?

What does the proposed API look like?
Switch

https://github.com/VisActor/VRender/pull/1567


Automated check for copyright header on code files

Benefit/Result/Outcome
So that developers are assured that all code files have consistent and correct copyright headers.
Description
We have a requirement to have copyright headers on all code files. We currently do it manually, which can lead to some files missing the required header. We would like to have the headers checked and/or added automatically when a PR is created.
A possible implementation is to add this to the SBOM generation pipeline and rename that pipeline to "code-generation". A separate pipeline is also good.
Acceptance Criteria

PR automation that checks and/or adds the required copyright header.

duplicate


haha nice pr (cpu usage stat in jsk command)

CPU usage is a kind of theatrical statistic, and using psutil in this way means both the result and reference time frame is arbitrary (cpu_percent returns 0 on first call, and every subsequent call is dependent on the time since the last call).
As far as I'm concerned, this is unlikely to be merged.

Maintaining my previous comment, I really don't think this stat is meaningful enough to be worth displaying, so I'm going to close this.


[#282] campaign title covers buttons in mobile view

resolves #282
Motivation and context
my previous PR #259 introduced an overflow bug in mobile when the titles are long
My flexbox magic was unnecessarily complicated, so I made it simpler and allowed the title to grow without overflowing over the next elements.
Screenshots

before
after

mobile

desktop

@ahrGNUts done and done :)


What is the throughput that's allocated to a partition?

The document mention that "Requests to the same partition key can't exceed the throughput that's allocated to a partition" I understand that 100 RU7s is the minimum for a container, but I can not find anything about the throughput allocated to a partition.
I think, here you mean "Requests to the same partition key can't exceed the throughput that's allocated to a container"

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d52f6d2e-f852-45ce-c205-ee4038d5ecd1
Version Independent ID: e45b7f29-4d75-0dda-0f13-38b644213840
Content: Partitioning in Azure Cosmos DB
Content Source: articles/cosmos-db/partitioning-overview.md
Service: cosmos-db
GitHub Login: @rimman
Microsoft Alias: rimman

The throughput provisioned is implicitly divided among the partitions for a container. That's why choosing a good partition key is important to saturate the provisioned throughput and get the best performance and scalability. A good partition key is expected to have the following characteristics:

The data distribution is reasonably even across all the keys, i.e., you don’t want to have a select few keys to have the majority of the data.
The workload is reasonably even across all the keys, i.e., you don’t want the (majority of the) workload to be focused on a few specific keys.
Generally prefer to have more keys. The large the keys the better.
PartitionKey is known and can be provided for CRUD operations and ideally most common queries
If you have the need to be able to update multiple documents within the same atomic transaction (via triggers or Stored Procedures) they need to share the same logical partition key.

With such a choice, partitions can scale ilinearly as much as you need. It’s a key requirement to help you not worry about scale issues.
I hope this helps.

Thanks for the responde, but just to make sure I understand i present an extreme case
If a have 1000 logical partitions, I need to provision at least 1000 RU/s to the collection, and each partition gets 1 RU/s. is that right?

You should not be concerned with the number of partitions and how RUs are allocated to them if you follow the best practices above. You can start with 400RUs (as the min entry).
There are two concepts to clarify:

Logical partitions are controlled by the user – and are bounded by 10GB today. These are represented as partition keys – and users are instructed to choose a partition key that (1) distributes throughput for a given workload as evenly as possible across a high cardinality of values (2) efficiently routes queries – with attention focused on frequently run, high QPS queries and (3) ensures a given partition key value should not exceed size + throughput bounds (10GB and 10K RU/sec per region)

Physical partitions are the underlying infrastructure and are controlled by the service – users do not have any knobs/levers for tuning this – and this is expected to evolve over time as we refresh the underlying hardware. The size of the physical partition is not material – as Cosmos DB will manage and redistribute logical partitions across a dynamic number of physical partitions.

So you can start as low as 400RUs, and the more logical partition keys, the better.

#please-close


Is the training dataset collected from Everyday Robots publicly available?

Yes, it is now public as part of this project: https://robotics-transformer-x.github.io/

@mbreuss ahh got it, thanks!

otherwise, let's close this issue

@lucidrains Sadly, I am not aware of something similar. My guess is that the current high entry barrier for the field (even the cheapest robot arm used the rtx-dataset costs around 3k) contrast to other areas prevent the creation a comparable open source community. But I hope this changes soon with cheaper and more affordable hardware.

@mbreuss did the open sourcing of mujoco by deepmind end up being helpful for the robotic research community?

@lucidrains Yes, I think it was usper helpful. It's still extremely relevant to most of the RL research. Almost all RL papers still use the deepmind control suite in mujoco to validate their new methods and numerous recent important simulations for RL and imitation leraning are based on Mujoco too.  I think this development would not been possible without open sourcing it. However, for real robot manipulation there is still a big gap between simulation and real world. Datasets from other labs are really hard to use since everyone has differnet camera positions, robot setups and lighting conditions. Further, data collection is a lot more tedious and time-consuming. So everyone collected their own small dataset in a different format and one one used other existing one. RT-X is the first push towards a general dataset with an unified format, which is significantly larger than any existing dataset. So I am exciting to see, how people can use it for their work.

@mbreuss thank you Moritz!

@lucidrains  your open source implementations have been also extremely valuable for many robotics researchers, including me, since they allow for easy deployment of sota models from other areas and are helpful in understanding these models too. So thank you for your great work!


complete callback has wrong signature

Describe the bug
The complete callback has the following signature is PapaParseConfig
complete?: (results: PapaParseResult, parser: PapaParseParser) => void;
but Papa Parse actually calls with the results and a File object if parsing a local file.
This causes type errors when using this callback and the only workaround I found was to define a complete callback specifying the type of the second argument as any, e.g.
complete: (results, file: any) => {}
The signature for step looks correct, I'm not sure about chunk.

Hi.
Thanks for the error-report.
Are you using ngx-papaparse 2.x or 3.x?

I'm using 3.0.0-beta.0

Thanks. I'll take a look at it. :-)

I have changed the interface to:
complete?: (results: PapaParseResult, file?: File) => void;.
The change will be included in the next release.


test(instrumentation-aws-sdk): skip failing tests of @aws-sdk/client-sqs ReceiveMessage context handling

Refs: #1477

Tests of @aws-sdk/client-sqs instrumentation are failing for versions >=3.316.0. The issue (https://github.com/open-telemetry/opentelemetry-js-contrib/issues/1477#issuecomment-1836903586) may take a while to resolve. This disables the subset of tests that are failing.
This is an alternative to @pichlermarc's https://github.com/open-telemetry/opentelemetry-js-contrib/pull/1711 that reduces the set of tests being skipped to just the problematic ones.

Woot. aws-sdk tav tests passed.


UIDS-75 remove description prop from FormGroup

Closes #75

This is such a minor change I figured I'd either bump a minor version later or include with the next major update (like adding Card). It's backwards compatible so it doesn't harm anything to wait on this.

Will this not break the release like it did last time we changed this repo w/o updating the version number?

No, that happened because i manually updated the package tarball without updating the refs in the app. You can merge as much stuff as you want safely here without needing to bump the version every time.


Refactor/move to delegated compute

Exploring what was not included

Looks like there were some small changes around database operations and switching the logger to gitcoindev's npm module

@whilefoo @gitcoindev just wanted to know if your changes all look intact. This is being merged sort of out of order and wanted to make sure we are not causing problems with this merge.

@whilefoo @gitcoindev just wanted to know if your changes all look intact. This is being merged sort of out of order and wanted to make sure we are not causing problems with this merge.

I am on it, will review asap.


(maint) Fix bad memoization in default certname

The default_certname method would do the right thing the first time it
was called, and then afterwards fail to get the hostname. This commit
fixes the bad short circuiting logic.

The travis failures are caused by this commit and are not fixed when I roll forward to latest (what this PR is currently pinned to).
@puppetlabs/night-s-watch do you see what might be going on here?
The tests are failing because fqdn is nil here.

These tests all pass for me locally, I don't feel like we need to block merge on getting an updated Facter (given we need a release in order to pull it in here).

@Magisus will our other pipelines pass if we merge this?

The tests on this repo are failing before this change. Our pipelines get Facter in a totally different way than these unit tests, and are passing now. My guess is in that context they have ffi available and are therefore fine.

We have a floating dependency on facter so these tests will fix themselves the next time they release.


Drop support for Scala 2.12.{2-5}.

These were the 2.12.x versions for which we still had some custom code paths, workarounds or exceptions lying around.
Scala 2.12.2 and 2.12.3 exhibited compiler crashes on recent changes in the linker, which triggered this decision.

According to nightly builds, something in #5092 or #5088 started causing compiler crashes with Scala 2.12.2 and Scala 2.12.3. I've been thinking about getting rid of versions <= 2.12.5 for a while, and these recent crashes pushed me to actually make a PR. The crashes were
[error] (linker2_12 / Compile / compileIncremental) scala.reflect.internal.FatalError:
[error]   unrecoverable error
[error]      while compiling: linker/shared/src/main/scala/org/scalajs/linker/backend/emitter/FunctionEmitter.scala
[error]         during phase: globalPhase=erasure, enteringPhase=posterasure
[error]      library version: version 2.12.2
[error]     compiler version: version 2.12.2
[error]   reconstructed args: -encoding utf8 -deprecation -feature -Xfatal-warnings -classpath ...
[error]
[error]   last tree to typer: TypeTree(class Tree)
[error]        tree position: line 1496 of linker/shared/src/main/scala/org/scalajs/linker/backend/emitter/FunctionEmitter.scala
[error]             tree tpe: org.scalajs.linker.backend.javascript.Trees.Tree
[error]               symbol: (sealed abstract) class Tree in object Trees
[error]    symbol definition: sealed abstract class Tree extends Object (a ClassSymbol)
[error]       symbol package: org.scalajs.linker.backend.javascript
[error]        symbol owners: class Tree -> object Trees
[error]            call site: method extractRecordElems in class JSDesugar in package emitter
[error]
[error] == Source file context for tree position ==
[error]
[error]   1493             case SelectStatic(FieldIdent(field))
[error]   1494                 if moduleKind == ModuleKind.NoModule =>
[error]   1495               val mirrors = globalKnowledge.getStaticFieldMirrors(field)
[error]   1496               mirrors.foldLeft(base) { (prev, mirror) =>
[error]   1497                 js.Assign(genGlobalVarRef(mirror), prev)
[error]   1498               }
[error]   1499             case _ =>

Full build for this PR: https://scala-webapps.epfl.ch/sjsjenkins/blue/organizations/jenkins/scalajs-main/detail/PR-5095/2/pipeline


Upgrading to 20.04 Attempts to Install LXD via Snap Store

Originally reported at:
https://bugs.launchpad.net/bugs/1862550
Issue description
Upgrading to 20.04 attempts to install LXD via snap which fails on WSL.
The WSL instance is unable to reach the snap store.
snap is not currently supported on WSL.
Steps to reproduce

Enable and Install WSL on a Windows 10 Insider Preview machine;
Import Ubuntu 18.04 Image using the following method: https://wiki.ubuntu.com/WSL#Installing_Ubuntu_on_WSL_via_rootfs
sudo apt update && sudo apt upgrade -y
sudo do-release-upgrade -d

Closing as not a LXD issue, this is a distro/packaging issue unrelated to LXD itself.
All users on Ubuntu 18.04 will upgrade to the snap upon moving to 20.04, this logic has been in place since 18.10.
The skip option can be used by users that have never used LXD before which includes upgrading WSL1 users, selecting that option should get your upgrade going.

It would be nice if there was a way to suppress this message, to make the upgrade from 18.04 to 20.04 on WSL smoother. Any suggestions?

This sadly makes lxd unusable for us as snaps are banned in our organisation. lxd is used as the base of all our containers and so we need control over how it is updated, this doesn't seem to be possible with snap (e.g. https://askubuntu.com/questions/1131182/how-can-i-disable-automatic-update-for-a-single-snap-in-ubuntu).
Please re-think this.

Seconded. Snap packages (or rather, uncontrollable updates) are forbidden in every government agency in sweden, as well as all municipalities, healthcare and other vital function banks and everyone who wants to connect with either of the above. It's largely the same across all of europe. I can't imagine this was a developer decision, but I can't for the life of me understand why Canonical would want to commit suicide on an antire continent either.
I guess people just fugly-build their own packages and run with that. It's what we're currently doing, while looking for alternatives and spending some time aiding the debian packaging effort.  Whoever thought up that particular insanity must never have actually worked in IT.

We've got an article on the forums that covers some options for managing/delaying automated updates, including the snap proxy which is suitable for larger deployments where updates must only be applied after being approved. https://discuss.linuxcontainers.org/t/managing-the-lxd-snap/8178

@tomponline Sadly that's too little, too late. The net effect of this issue is that I removed Ubuntu completely from my infrastructure and switched to Alpine Linux instead (after 8+ years of running Ubuntu). Switched from LXD to Docker (and soon to Podman). I have concerns with docker and would prefer to use LXD but it's not an option if issues like this are considered EWONTFIX.


Return Url to my website clears the Cart::content()

I am using payment api for payment. After successful payment a return URL hits to my website. But now cart::content() is empty
Why?
How to persist data?
I am using laravel 8.

@Crinsane
Please help
I think the problem is with session. Session destroy after return URL form payment gateway.

@Crinsane
Please help
I think the problem is with session. Session destroy after return URL form payment gateway.

My problem is solved.
I have changed the following in config/session.php file:
'same_site' => 'lax',
To the below value:
'same_site' => null,

Now session are persistent even after return URL from payment gateway!

My problem is solved.
I have changed the following in config/session.php file:
'same_site' => 'lax',
To the below value:
'same_site' => null,

Now session are persistent even after return URL from payment gateway!

hi, if you are in iran you can pay any forign payments via our web site.
سایت EPAY 724 | خدمات ارزی بین الملل (https://bit.ly/3uieWwW) (سایت EPAY 724 | خدمات ارزی بین الملل (https://epay724.com))
online payments for application fees, buying gift cards, international exams fees are easier than ever ….

Check your Callback function.
Because the cart can be cleared when it exists in your callback function.
I hope you understand what I mean by "callback"?


Fixed broken output in option_parser

Separator should be the first argument to #join followed by io, not the other way around.

Thanks for pointing it out @Blacksmoke16, somehow I missed that merge request!


Thrift map syntax highlighting doesn't work

See example:
const map<string,list<string>> SERVER_TYPES_SUPPORTED_BY_OS = {

Linguist only selects the grammar to use for highlighting. For Thrift, GitHub uses textmate/thrift.tmbundle. You should open an issue there if there isn't already one.


[Discussion] ContentModified and request invalidation

Hey, I noticed a few weeks ago there were problems with the semantic highlighting in VSCode+clangd,sometimes the highlighting would just go away.
I traced the issue and found out what happened:

semantic highlighting request
didUpdate notification
clangd cancels the highlighting request
vscode does not re-send another request and just clear the highlighting

IMO the issue is in VSCode/the languageserver-node js plugin, and I submitted a PR to the vscode guys.
See it here: https://github.com/microsoft/vscode/pull/113315
We had a discussing in this PR related to request invalidation and the ContentModified error. Basically they think that clangd should never cancel requests on it own.
Anyway, I got the PR there merged so the issue is solved, vscode will now re-send a request, but the vscode-languageserver-node plugin still needs patching, in the current state, vscode will clear the highlighting, then resend a request, and the highlighting will "blink", which is annoying.

If they patch the JS plugin, it can be worth it to update the extension to use it
Do we want to agree with them and never cancel our requests ? If we do, I've got this commit lying around where I delay the requests instead of cancelling them. This avoids building a useless AST, while not cancelling the request. Let me know if you like this, I'll open a diff in phabricator

A historical note on the cancellation behavior: we designed this after observing dumb clients building huge request backlogs. I actually didn't notice the spec explicitly allowed for it until looking up the right error code to send.
The idea that the spec has this feature that's useful, but it doesn't suit VSCode to use it so they'll change the spec... Frustrating! Anyway...
I don't like:

disabling cancellation of implicit requests entirely, because it fixed real problems
reordering reads with respect to writes, because serving results from the "wrong" version of the file is a slippery slope and may in fact just corrupt the highlightings here

But we could:

disable cancellations of certain requests for certain clients (possibly by client name sniffing if LSP folks aren't willing to add a capability to describe VSCode behavior)
add more conditions to cancellation, e.g. only cancel highlighting there a subsequent edit followed by a highlighting request. This is probably still enough to prevent the pathological cases.
definitely we should pull in a client patch to suppress the clearing behavior if we can

The second option seems nicest to me but I'm pretty terrified of allowing more API/implementation complexity into TUScheduler...

A historical note on the cancellation behavior: we designed this after observing dumb clients building huge request backlogs. I actually didn't notice the spec explicitly allowed for it until looking up the right error code to send.
The idea that the spec has this feature that's useful, but it doesn't suit VSCode to use it so they'll change the spec... Frustrating! Anyway...
I don't like:

disabling cancellation of implicit requests entirely, because it fixed real problems
reordering reads with respect to writes, because serving results from the "wrong" version of the file is a slippery slope and may in fact just corrupt the highlightings here

But we could:

disable cancellations of certain requests for certain clients (possibly by client name sniffing if LSP folks aren't willing to add a capability to describe VSCode behavior)
add more conditions to cancellation, e.g. only cancel highlighting there a subsequent edit followed by a highlighting request. This is probably still enough to prevent the pathological cases.
definitely we should pull in a client patch to suppress the clearing behavior if we can

The second option seems nicest to me but I'm pretty terrified of allowing more API/implementation complexity into TUScheduler...

The best is obviously not to change anything on clangd side. IMO we're doing the sane thing. Also it fits the spec, even though it is "not the recommended behavior" so we should be fine.
We only need the MS guys to update vscode-languageserver-node as the said they would.
I do like their commits on the 13th of January though: https://github.com/microsoft/vscode-languageserver-node/commits/master

The best is obviously not to change anything on clangd side. IMO we're doing the sane thing. Also it fits the spec, even though it is "not the recommended behavior" so we should be fine.
We only need the MS guys to update vscode-languageserver-node as the said they would.
I do like their commits on the 13th of January though: https://github.com/microsoft/vscode-languageserver-node/commits/master


Self-hosting migration fails if not using the default "public" schema

https://github.com/triggerdotdev/trigger.dev/blob/336029b8428a826bfc92932a61653979a0e1fb79/apps/webapp/app/presenters/JobListPresenter.server.ts#L125

code: 'P2010',
clientVersion: '5.4.1',
meta: { code: '42P01', message: 'relation "public.JobRun" does not exist' }
}

and migration which fails if project hosted in custom schema eg "triggerdotdev"
CREATE INDEX idx_jobrun_jobId_createdAt ON "public"."JobRun" ("jobId", "createdAt" DESC);

Good spot, a fix for this has been pushed to main. I'm creating another latest build right now, should be available in 10 mins to use.

 It's already been applied and just editing the file isn't an option as that causes an out-of-sync issue which would wipe everyone's databases when deploying.
There are complicated options Prisma offers but I'm not clear on the best approach at the moment.
I think you can manually resolve for yourself by doing this:

Run this on your database, it will mark that migration as done (even though it isn't):

prisma migrate resolve --applied "20240130165343_add_composite_index_to_job_run_for_job_id_and_created_at"

Manually perform the SQL migration to create the composite index:

CREATE INDEX idx_jobrun_jobId_createdAt ON "JobRun" ("jobId", "createdAt" DESC);

Sorry about this. That migration was auto-generated by Prisma when I used their @@index notation… 😠

@matt-aitken  no problem. i already fix migration. thank you for quick fix

This is and extremely annoying and causing issues with deploying on ECS that:

Make the docs incorrect
Means I need to deploy a separate db

There's a more up to date issue on this with a better temporary fix: https://github.com/triggerdotdev/trigger.dev/issues/1026


Add Petal bot to the Crawler list.

Add the petal bot to the list of crawlers.

I see no reason why this shouldn't be merged once @metrix78 pulls upstream on their branch.

Done

Merged. Thank you!


Custom preprocessor isn't ran in jest 0.9

I upgraded to latest, and since my preprocessor process() method isn't being ran. It does open the file, but doesn't seem to run the actual method.
Here is a super reduced set of code:
// preprocessor.js
console.log('**** This logs TWICE');

module.exports = {
  process(src, filename) {
    console.log('>>>>> This never shows up')
    return src;
  },
};

And this is my package.json jest entry:
  "jest": {
    "scriptPreprocessor": "preprocessor.js",
    "unmockedModulePathPatterns": [
      "react",
      "enzyme"
    ]
  }

can you do rm -rf node_modules/jest-cli/.haste_cache? The preprocessor is not being invoked for files that have not changed. Most of the times the preprocessor is only called once.

Nailed it. Hmm. That's an awkward fix. Is there any smart way we could detect that and inform people to clear that? Or would you rather deal with the one-offs?

 I agree though that it can be made easier. --no-cache also serves this purpose but currently it doesn't clean the old cache, so invocations with --no-cache and without produce different files. That's a bug I'd like to fix soon.

Word. Maybe a note in the documentation about scriptPreprocessor that says something like:
#### NOTE!
When developing your own preprocessor, you'll need to disable the
`preprocessCachingDisabled`. This flag prevents your preprocessor
from being ran on files that have already been cached. Meaning,
changes to your preprocessor while appear to not change anything.

I'm likely going to remove this option soon, however, because it doesn't serve a lot of purpose.
I would recommend adding a note like this:
Note: Jest's preprocessor is only ran once per file unless the file has changed. During development it can be useful to run Jest with --no-cache or to frequently delete Jest's cache.
would you mind sending a PR?

I'm not so sure it's worth removing yet.
I almost ditched my own processor in favor of babel-jest with a babelrc. But it seems there are still some bugs with babel figuring out node_module nested .babelrc files. I've found that If I pass exactly what I want into babel.transform it doesn't have the issues with the nested .babelrc's. And I only imagine those things could keep popping up. I see why you'd want to remove it. It has less and less purpose. But it seems like it could serve better as an undocumented feature for special cases.

--no-cache does the same thing, so why disable it from the config?

I don't know enough about --no-cache to understand. How does that play into the .babelrc? I assumed that just ignored the .haste-cache folder and ran the processor again.

I'm sorry, I thought you were talking about removing the option preprocessCachingDisabled, something that I will do soon. I don't know much about nested babelrc files but it seems out of the scope of Jest to fix this. And yeah, you can obviously always use your own preprocessor :)

Oh. so,

I'm likely going to remove this option soon, however, because it doesn't serve a lot of purpose.

that was in relation to the preprocessCachingDisabled command?

yes.

Word. Yeah, I'll throw up a commit then for the documentation change. :+1:


Widget navigation steals editor focus

Does this issue occur when all extensions are disabled?: Yes/No

2023-12-07 09:49:34.783 [info] [KeybindingService]: \ From 22 keybinding entries, matched widgetNavigation.focusNext, when: inputFocus && navigableContainerFocused || navigableContainerFocused && !listFocus || navigableContainerFocused && listScrollAtBoundary == 'both' || navigableContainerFocused && listScrollAtBoundary == 'bottom', source: built-in.
2023-12-07 09:49:34.784 [info] [KeybindingService]: / Received  keydown event - modifiers: [meta], code: ArrowDown, keyCode: 40, key: ArrowDown
2023-12-07 09:49:34.784 [info] [KeybindingService]: | Converted keydown event - modifiers: [meta], code: ArrowDown, keyCode: 18 ('DownArrow')
2023-12-07 09:49:34.784 [info] [KeybindingService]: | Resolving meta+[ArrowDown]
2023-12-07 09:49:34.784 [info] [KeybindingService]: \ From 22 keybinding entries, matched widgetNavigation.focusNext, when: inputFocus && navigableContainerFocused || navigableContainerFocused && !listFocus || navigableContainerFocused && listScrollAtBoundary == 'both' || navigableContainerFocused && listScrollAtBoundary == 'bottom', source: built-in.
2023-12-07 09:49:34.785 [info] [KeybindingService]: + Invoking command widgetNavigation.focusNext.

Not sure how did I end with this state but often I can't cmd+downanymore in editor and the shortcut is stolen by widgetNavigation

@hsfzxjy would be awesome if you could look into this 🙏🏼

@rebornix any steps to reproduce would be appreciated

@rebornix I will investigate this. Could you provide some reproduction steps or observation on the trigger condition?

I noticed that bug about a month ago, and it has been driving me crazy since. Finally, I found that issue.
I'm not sure how to reliably to reproduce it, though. Everything works for some time after restart, but then ⌘+up/down stops working.

@AlekSi Hi. It'd be great if you could share some information regarding the following questions:

What's your desired behavior of pressing cmd+up/down in editor? Is it for scrolling lines? Sorry if this may seem dumb but I have seldom used this shortcut. The answer would help me troubleshooting.
Did you remember comments/chat or some other panels being opened in the editor when the bug shown up?
Where did the focus go after this bug happened?

From @rebornix , still no repro steps, but:
2023-12-18 12:06:32.748 [info] [KeybindingService]: \ From 22 keybinding entries, matched widgetNavigation.focusNext, when: inputFocus && navigableContainerFocused || navigableContainerFocused && !listFocus || navigableContainerFocused && listScrollAtBoundary == 'both' || navigableContainerFocused && listScrollAtBoundary == 'bottom', source: built-in.
2023-12-18 12:06:32.748 [info] [KeybindingService]: / Received  keydown event - modifiers: [meta], code: ArrowDown, keyCode: 40, key: ArrowDown
2023-12-18 12:06:32.748 [info] [KeybindingService]: | Converted keydown event - modifiers: [meta], code: ArrowDown, keyCode: 18 ('DownArrow')
2023-12-18 12:06:32.749 [info] [KeybindingService]: | Resolving meta+[ArrowDown]
2023-12-18 12:06:32.749 [info] [KeybindingService]: \ From 22 keybinding entries, matched widgetNavigation.focusNext, when: inputFocus && navigableContainerFocused || navigableContainerFocused && !listFocus || navigableContainerFocused && listScrollAtBoundary == 'both' || navigableContainerFocused && listScrollAtBoundary == 'bottom', source: built-in.
2023-12-18 12:06:32.749 [info] [KeybindingService]: + Invoking command widgetNavigation.focusNext.
2023-12-18 12:06:33.046 [info] [KeybindingService]: + Storing single modifier for possible chord meta.
2023-12-18 12:06:33.349 [info] [KeybindingService]: + Clearing single modifier due to 300ms elapsed.

@hsfzxjy sorry that I didn't have a reproduce and I didn't even realize that I already reported it when creating a second issue today.

I inspected the context keys, here is what I found, while the focus is in the editor
inputFocus: true // text editor input is focused
navigableContainerFocused: true

which matches the when clause
inputFocus  && navigableContainerFocused
|| navigableContainerFocused && !listFocus
|| navigableContainerFocused && listScrollAtBoundary == 'both'
|| navigableContainerFocused && listScrollAtBoundary == 'bottom'

navigableContainerFocused: true seems an oversight to me.

@rebornix Sounds like a broken state management of this feature.
Can you remember whether or not you had focus in any of these components before the bug happened? :

Settings Editor
Keyboard Shortcut Editor
Debug Console Panel
Problems Panel
Extensions Panel
Testing Panel
Comments Panel
The in-editor comment thread widget

Also, when the bug happened, you might check whether switching focus to these components and then back to the editor would recover from the problem.

What's your desired behavior of pressing cmd+up/down in editor? Is it for scrolling lines?

⌘+up is mapped to multiple commands by default; the relevant seems to be cursorTop.

For now, I just disabled widgetNavigation.focusPrevious:
	{
		"key": "cmd+up",
		"command": "-widgetNavigation.focusPrevious",
		"when": "inputFocus && navigableContainerFocused || navigableContainerFocused && !listFocus || navigableContainerFocused && listScrollAtBoundary == 'both' || navigableContainerFocused && listScrollAtBoundary == 'top'"
	}

It happened really randomly and I have no clue how it's triggered. Just ran into this again ;(

Adding to this milestone for now as I'm afraid that more users might get to it after Jan release.

@hsfzxjy , @rebornix is often navigating between Jupyter notebook cells, that might be key to reproduce this

Still unable to reproduce. Is it possible that we make a special build for the affected users, where I will add some logging for debug purpose?

{
	"key": "cmd+up",
	"command": "-widgetNavigation.focusPrevious",
	"when": "inputFocus && navigableContainerFocused || navigableContainerFocused && !listFocus || navigableContainerFocused && listScrollAtBoundary == 'both' || navigableContainerFocused && listScrollAtBoundary == 'top'"
}

Where do you add this?

Fix
Step 1

Step 2

I ran into this again, and it's not the first time for the last month ;(
I can anticipate how challenging it is to troubleshoot and fix this problem considering it's flaky, but we need to do something. Here is my suggestion:

Add a setting (can be hidden) to track all focus change relevant to navigableContainerFocused.
Add a troubleshoot command and when this bug reproduces, run the command to get all the logs.

@meganrogge I would recommend we have it on the iteration plan if we couldn't spare time on it.

@hsfzxjy would you be up for creating a PR that accomplishes the above?

Would be glad to. But I am not quite familiar with the logging part. Could you enlight some instructions to log under such a case?

Yes, I'd suggest using the ILogService to log all focus changes. I think you'll just want to use log level of trace when the setting mentioned above is off and use log level of debug when it's enabled.
I don't think we need a command to get all of the logs. Users who repro this frequently can just enable that setting IMO.

@rebornix will the above work for you or can you further explain what you mean here?

run the command to get all the logs.

@meganrogge Hi. I've tried using ILogService. The output of the logging seems to appear in Output - Window and mixed with logging messages from other part of VSCode. Is it what we expect or should I create a separate logging channel for this?

I think logging to Output - Window is fine because we'll only do this when the setting is enabled. Thanks @hsfzxjy

@meganrogge using log service and show them in output channel makes good sense to me

@meganrogge @rebornix Hi. I've implemented the function in #209357 . Please check if this is desired 🙏🏼

@rebornix , this will be in shortly. Could you pls add workbench.navigibleContainer.enableDebug to your settings and set log level for the window to debug?

Thanks, updated the setting and log level and will see what I can get when I reproduce again.


Add reproducer test for KT-55065

See https://youtrack.jetbrains.com/issue/KT-55065

👍

@bot-gradle test and merge

OK, I've already triggered a build for you.


How do you get other animals?

I see in the repo that there are multiple animals besides the cow. How do you choose which animal you want?

There's no way right now to specify a character to use from the command line - it always uses a random one.
You can use a specific one using:
Shell:
ruby -rcowsay -e 'puts Cowsay::Character::Cheese.say "hello"'

Ruby:
require 'cowsay'
puts Cowsay::Character::Cheese.say "hello"

Oh, I see.


Adding stim support to qldpc

This PR creates a pipeline that takes in an instantiated qldpc.codes object (SurfaceCode, CSSCode etc.), creates a syndrome extraction circuit for it in stim, and runs a simulation in stim to produce a threshold plot.

Made some changes so that the pipeline doesn't have an ldpc_v2 dependence. It seems like it's a bit less performant (runs slower). Will pick this up again in a couple of days.