Please mark https://pysal.readthedocs.io/en/dev/ as outdated

I ended up on https://pysal.readthedocs.io/en/dev/ via some deeper Google search and spent way too much time trying to figure out why code examples did not work for me. I am on 2.0.0, the latest release, that page says "dev", so that seems recent enough? I knew that 2.0.0 is fancy and fresh. Trying to change from "dev" to 2.0.0 I only found 1.x.
Only then I realised that this is outdated and that the current documentation is at "latest".
If there is any way to do so, please either update the "dev" pages to 2.0.0 development or somehow mark it is "not latest" :}

Thank you for pointing this out.
We are sorry for sending you down a rabbit hole - that was not our intention.
We have turned off the "dev" pages which were stale.

Thanks! :)


[7.x] New method withSum for sum one or more columns for the relations

Added new method withSum for sum one or more columns for the relations without second sql query.
It's working like withCount. Three type:

Invoice::withSum('items:price,price2')->first(); where price, price2 are columns
$invoices = Invoice::first(); $invoices->loadSum('items:price');
$invoices = Invoice::withSum(['items:price,price2' => function (Builder $query) {
$query->where('id','<', 30);
}])->get();

I often use this in my work and I hope it will be useful to you!

I am closing this pull request because it lacks sufficient explanation, tests, or both. It is difficult for us to merge pull requests without these things because the change may introduce breaking changes to the framework.
Feel free to re-submit your change with a thorough explanation of the feature and tests - integration tests are preferred over unit tests. Please include it's benefit to end users; the reasons it does not break any existing features; how it makes building web applications easier, etc.
Thanks!

@Alexmg86
I am really sorry your PR rejected here. However, I think it should be because it not DRY at all.
You have just copy and pasted the withCount method and its relatives to add withSum and nothing else.

The PRs are not similar at all, they are not even close together.
Your package also https://github.com/Alexmg86/laravel-sub-query
has main differences with my PR (codes-style, naming, method signatures & ...)
But assume if I copied from your unknown package, why I copied only some parts and not everything from there e.g. withMath from yours?!
And in addition to you should know the exact meaning of open-source, apparently you do not!

But you have to be polite and try harder to become a good programmer. Your are far away from both and this is the main reason that your are upset now.

@khalilst I closed that other PR for a reason. Please stop bringing this up.


Handle making sure that two less thans are never converted into >>

Fixes #32068
Should make sure that two < tokens always have whitespace between them.

Alright, fixed - thanks


Delay in send list

Thanks for your work. Could you remove the 100ms limit when sending packets to the sand list? This is important if you want to exploit thread race

Okay, the next version will adjust to a minimum value of 0

Version <IP_ADDRESS> has implemented this modification

Thank you very much for your work


applicationDbContext.Database.BeginTransaction() does not work with Aspnetusers table .

I want to implement transaction with asp .net core identities table. i have two databases for one database it works but for identity database doesn't.
It doesn't throw any exception
This is my code.----
using (var identitydbContextTransaction = applicationDbContext.Database.BeginTransaction()) // for identity database
                        {
                            var user = new ApplicationUser { UserName = model.Email, Email = model.Email, PhoneNumber = model.PhoneNumber };
                            var result = await _userManager.CreateAsync(user, model.Password);
                            if (result.Succeeded)
                            {
                                    try
                                    {
                                        using (IDbContextTransaction transaction = TaskService.GetTransaction()) // TaskService.GetTransaction() Get transaction for another database
                                        {
                                            SaveEntity(savedUser, model);
                                            throw new Exception();
                                            transaction.Commit();
                                        }
                                        identitydbContextTransaction.Commit();
                                    }
                                    catch
                                    {
                                        identitydbContextTransaction.Rollback();
                                        throw;
                                    }
                            }
                        }

Further technical details
EF Core version: 2.0.1
Database Provider: Microsoft.EntityFrameworkCore.SqlServer
Operating system: Windows 7
IDE:  Visual Studio 2017

EF Team Triage: Closing this issue as the requested additional details have not been provided and we have been unable to reproduce it.
BTW this is a canned response and may have info or details that do not directly apply to this particular issue. While we'd like to spend the time to uniquely address every incoming issue, we get a lot traffic on the EF projects and that is not practical. To ensure we maximize the time we have to work on fixing bugs, implementing new features, etc. we use canned responses for common triage decisions.

I fixed it ..... it was my fault . thnx


Document EPT catalog generation

Document EPT catalog generation and updating it from a set of las / laz files. It should be probably a part of a README.md file.
We can use connormanning/entwine docker image for the ept catalog generation decription (see entwine repo).
Catalog builder args description

[ ] Create walk-through document on how to create and update the EPT pyramid
It should use the docker container to provide example commands
1-2 pages ?
[ ] Document the use of "span" parameter on catalog resolution and PDAL performance

This may balance how many points are used to generate a level
Include some benchmarks or illustrations of the effect of span parameter

[ ] Send README with the NRCan

Start conversation, is this really what they wanted

Structure of EPT Hierarchies
An EPT is based on an octree structure. The entire point set has a volumetric extent which
serves as the root of the tree. Each cell of the tree has a corresponding LAZ file in the hierarchy.

Each tree cell also has a logical grid associated with it that uniformly subdivides its spatial
extent. When building the LAZ files, Entwine endeavors to include about one point per logical
grid cell. The logical grid partitioning each axis into equal intervals, with span partitions along
each axis. The choice of span dictates the "cell size" of the various hierarchy levels, and it also
sets the rough size of each constituent LAZ file. All points will be added to a LAZ file somewhere
in the hierarchy, with dense areas being represented by a deeper tree.
Related Entwine documentation: https://entwine.io/entwine-point-tile.html
Creating EPT Hierarchies
Generating a new EPT hierarchy is generally a straightforward affair with little in the way of
tuning. By and large, how the EPT will be used determines the desired grid. An example should
help.
Let's imagine that we want to convert the point data into DEM rasters on demand. Then the grid
parameters for the rasters should guide the layout. Assuming that the DEM rasters will be
requested via some tiled queries in the WebMercator projection in a standard power-of-two
layout, one would find the smallest layout tile (i.e., in the highest possible zoom level) that
entirely contains the point set to be encoded. The bounds of that tile can be passed to
entwine build --bounds "[<xmin>,<ymin>,<zmin>,<xmax>,<ymax>,<zmax>]"

where the limit values will be filled in appropriately (the Z limits should be left unmodified). The
--span parameter in this case should match the size of the request tiles. The default value of
--span 256 will likely work well.
It is possible to use different span parameters, to trade off different performance characteristics.
Smaller span values imply more, smaller files will be accessed in the course of a read at a given
zoom level, but fewer points in total (and bytes) will be streamed when the query region is a
small subset of the whole extent. This difference may become important when balancing the
cost of queries and data transfer over S3, for example; but one may also observe a time penalty
for each new file access, meaning that some benchmarking may be required to assess the
balance point between cost and performance.
In general, the minimal command for creating an EPT hierarchy from a directory is summarized
as
entwine build --bounds "[<xmin>,<ymin>,<zmin>,<xmax>,<ymax>,<zmax>]"
              --span <value>
              --input <directory>
              --output <location>

One may, of course, use additional features of Entwine for this operation; issue entwine build --help for more details.
Related Entwine documentation: https://entwine.io/configuration.html#build


EventbusException

Hello,
I am using greenbot eventbus library 3.0.0 i am getting following error.
org.greenrobot.eventbus.EventBusException: Subscriber class com.xtempo.q2t.request_portal.RequestPortalFragment and its super classes have no public methods with the @Subscribe annotation
Thanks,
Vivian

You need to add event handling methods annotated with @Subscribe to one of your classes. See step 2 of the getting started guide. -ut

Thank a lot


fix: add event to create a connection on web platform

For web in mixin WidgetsBindingObserver  method don't call didChangeAppLifecycleState.
And becouse i initialize our connection in init state.
DidChangeAppLifecycleState - not supported on web

@SERDUN, after a bit of digging, I've found that even on mobile, the signaling connection starts not due to _AppLifecycleStateChanged, but because of _ConnectivityResultChanged. Consequently, it seems more logical to initiate the signaling connection based on the app's connectivity state, rather than its lifecycle state. So, I'm planning on making a few tweaks to your PR. 🙂


Stickers in Lite Mode

Don't render images in Lite Mode.
Examples
https://lite.crimethinc.com/stickers
https://lite.crimethinc.com/stickers/immigrants-welcome
TODO

[ ] cover images
[ ] gallery images


Colorette benchmark results are outdated

Hi! We've made some performance optimizations lately, so I believe that numbers as listed currently in readme are no longer accurate. Would you consider recalculating them with the latest version of Colorette?
Also it would probably be helpful to list versions for all the libraries mentioned in the benchmark for fairness.

Just pushed https://github.com/alexeyraspopov/picocolors/commit/0836f3c59c5ce814c62dec7aa4301505092700ef with the updated numbers I got from the most recent benchmarks job run.


Dev tests

Reorganize and add tests.

Codecov Report

Merging #74 (81d8389) into dev (400a4f5) will increase coverage by 32.65%.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff             @@
##              dev      #74       +/-   ##
===========================================
+ Coverage   44.99%   77.64%   +32.65%
===========================================
  Files          17       15        -2
  Lines        1118      908      -210
===========================================
+ Hits          503      705      +202
+ Misses        615      203      -412

Impacted Files
Coverage Δ

src/BZMeshes.jl
95.60% <ø> (-0.23%)
:arrow_down:

... and 16 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Enahance cookie manager

Allow setting of cookie policy and clearing cookies on each iteration (defaults to standard, true)

Thank you very much for this contribution!
Can you describe when you usually use the non default settings? What scenarios are not covered? This would be interesting to include in the user guide, so users have examples on when does it make sense to change the default values.


Update docs to include MPI info

Pull Request Title
Fixes #483
Changes
The documentation has been updated in the following way

[x]  Split up installation and building instructions.

Previously, the dependency installation and the build command were given under the same heading. This has now been separated.

[x] Add information for MPI builds

Information about dependencies and changes in the cmake command to support MPI have been added

[x] Consider removing conda install information (and potentially do it)

The documentation still gives the option to install the dependencies using a conda environment. Although this might not be the first choice for a C++ code, for some users this might be the preferred way.

Information about Dockerfiles will be added with #482


feat: Add theme support

fixes #4

@khattakdev Please check this out .

@khattakdev I am new to git , so I don't understand how my previously merged commit "feat:  Show error on no selection" got included in this PR. That's what I have done:

I pushed the changes to my github fork from my local repo without realizing that I should sync my fork to include the changes.
Then I see there are merge conflicts so I discarded my commits from the github website itself
Then I sync the fork then I resolve the merge conflicts in my local repo and commit
Then I push to my fork
Created PR and saw previous commit is also included
Can you guide me ?

@coding-cosmos Don't worry about the commit history - as long as you have not modified the code.


Setting levels for multiple crates does not function?

// Show trace and above level messages for this crate and some_other_crate
    android_logger::init_once(
        Config::default().with_min_level(Level::Trace).with_filter(FilterBuilder::default()
            .parse("trace,some_other_crate=trace").build()))

First, I want to make sure the syntax above is correct. Whereas the primary crate displays logs correctly, some_other_crate doesn't show anything at all. Just incase, in some_other_crate, I have this in Cargo.toml:
log = { version = "0.4.8", features = ["std", "max_level_trace", "release_max_level_trace"] }

I'm including the aforementioned line because I don't know if that may cause interference or not

I have no idea how it works, because this feature was submitted by a contributor.


Exact match (=) searches in lookup don't work

Please select the area your bug applies to. (Multiple selections are Possible. You can leave blank if you're not sure.)

[ ] Workspace.  VSCode workspace, vaults, Intellisense/autocomplete, Dendron settings
[x] Lookup.  Dendron's Lookup Command
[ ] Views.  Dendron Preview, Tree View, Side Panels in the UI
[ ] Schema.  Dendron Schemas
[ ] Pod.  Data import from / export to Dendron
[ ] Publish.  External Site Publish
[ ] Markdown.  Markdown features, such as syntax support and features

Describe the bug
Searching for =foo.bar in the lookup does not work despite what the docs say.
To Reproduce
Steps to reproduce the behavior:

Create a note called foo.bar with the title "Foo Bar Baz"
Open lookup and type =foo.bar
Observe that your note does not appear
Type =Foo in the lookup
Observe that yet again your note does not appear
Type `="Foo Bar Baz" in the lookup
Observe that your note still does not appear

Expected behavior
I expect =foo to search for exactly foo at any level of hierarchy. I'd also expect it to match case insensitively any single word in the title.
But at the very least, I expect =foo.bar to match a note called foo.bar.
Additional context
The docs make mention of . having special meaning in searches. The search foo. should match any child of a hierarchy called foo. That might be why there are issues with =foo searches. But it's unclear why the exact match doesn't work against titles.

Thank you for the report. I can reproduce this. We'll let you know when this gets fixed.
As a side note, Dendron doesn't index the notes' frontmatter title for the purpose of lookup. In most cases the frontmatter title is just the hierarchy basename of that note (unless the user changes it after creation), so it's easy to think that lookup will also index them, but it's not the case. I think this is a point that could be clarified in the wiki, so thank you for mentioning.

@hikchoi Ah, yeah, if the titles are not included, that would be good to mention in the docs. The titles are shown in the list which is why I assumed they were also searched.


Fixing hero Section

hero section responsive error done

Waiting for feedback Before Merging

Waiting for feedback Before Merging.


If the lower case version of a category name is not found in the cate…

…gorymap, a second search without using .lower() will be done to try to find it.

This PR resolves #551.


fix: no timezone jump on PanZoom actions

*Issue number of the reported bug or feature request: #617 *
On a start pan and on every zoom action the date is converted to json and back. On the serialization utc is assumed for the date but the timezone information is not put onto the date string that is generated. On the deserialization new Date is invoked manually which makes the browser think the provided date is in the user's browser's timezone (because the json serialization didn't add timezone information). But the json serialization used utc.
Because the serialization uses a set format I just added the timezone information to the date string. This is not super elegant but seems to work. This issue and fix is strongly related to #968
Conversion of dates should maybe be more streamlined throughout the library and possibly use only the d3 conversion functions or maybe use Moment.js
This fix also fixes #865 and likely it fixes #767
Testing performed
I ran the tests in the "tests" directory:
=== 9 passed, 12 warnings in 0.10 seconds ===
I executed my own minimal replicating example given in the bug and confirmed that the behavior is now as expected.

quote from MDN:

It is not recommended to use Date.parse as until ES5, parsing of strings was entirely implementation dependent. There are still many differences in how different hosts parse date strings, therefore date strings should be manually parsed (a library can help if many different formats are to be accommodated).

Closing as superseded by #968


close #127 | Point to a specific version of Rapido in the documentation

The scope of this PR is to point to a specific version in the documentation, this prevents to introduce breaking changes of major releases. Users should switch to a new major release carefully, reading release notes and looking at the final result on their published documents.
In the docs, I used the semver range https://unpkg.com/<EMAIL_ADDRESS>for targeting versions >=3.0.0 <4.0.0.
Moreover, I mentioned how to install Rapido with npm.

Good idea! This makes easier to introduce breaking changes in future


Add restricted.containers.interception to projects

Documentation preview available at: https://linuxcontainers.org/lxd/docs/pr.10008/

As this is a security feature on restricted projects it would be good to get some tests with this if possible?


Adding e2e test case for moving subcluster between sandbox

Use the following setup, create subcluster pri1 as primary with 3 nodes, subcluster sec1 as secondary with 3 nodes, subcluster sec2 as secondary with 3 nodes, subcluster sec3 as secondary with 3 nodes.
(pri1 primary, sec1 secondary, sec2 secondary , sec3 secondary)
And created a sandbox sandbox1, and added sec1 into the sandbox1. created sandbox2, and added sec2 into the sandbox. Add sec2 to sandbox1. Move sec2 from sandbox1 to sandbox2.
(Sandbox1 with sec1, Sandbox2 with sec2 -> Sandbox1 with sec1,sec3 Sandbox2 with sec2 -> Sandbox 1 with sec1, Sandbox2 with sec2, sec3)

This PR is blocking by https://jira.verticacorp.com/jira/browse/VER-94063, there is a server issue on unsandboxing. Gonna change the PR to draft for now.


[Bug]: Pulsing animation remain displayed

Describe the bug
I carried out two operations:

I transferred my money from Spending to Saving. Everything went smoothly. However, the animation is still displayed (even at +3 days). However, the channel has been closed.

After closing my channels, I decided to switch my sats back from Saving to Spending.
Click on '....'
Scroll down to '....'
See error

Screenshots / Recording

https://github.com/synonymdev/bitkit/assets/46056211/7a175be4-6377-4256-baae-fc8422e58e24
Operating system
GrapheneOS
Bitkit version
v59
Log output
No response

it will be probably be fixed by https://github.com/synonymdev/bitkit/issues/1007

I'm reopening this ticket, the pulsing animation remains even though the whole process of creating a channel has been completed.
note: this does not happen every time

Same thing happens when opening a channel from a personal node as well.

Yeah these RN events often get missed for some reason still. What about checking all ldk channels and if there are non pending confirmation then remove the animation?
As for force closed channels ldk.claimableBalances(false) can be used. This will list all the funds waiting to be claimable after a channel close.
confirmation_height  can be used to tell the user when they'll get their funds. Would that work or do you need to be able to specifically query which channels were force closed?


dotnet-sdk on OSX

Issue:
It looks like dotnet is intended to work on macOS, including the hashes being listed in meta.yaml: https://github.com/conda-forge/dotnet-feedstock/blob/master/recipe/meta.yaml#L3. However, when I try to install version 3.1.403, which installs properly on various linux machines, I get the following on macOS Big Sur:
Collecting package metadata (repodata.json): done
Solving environment: failed

ResolvePackageNotFound:
  - dotnet-sdk=3.1.403

It also looks like the badge for OSX/macOS is missing from the installer page (https://anaconda.org/conda-forge/dotnet-sdk):

Thanks for working on the dotnet conda installers! Let me know if you have any thoughts on how to get this installed on macOS.
-Tony
Environment (conda list):
conda_list.txt
Details about  conda and system ( conda info ):
conda_info.txt

Just commenting to follow up shortly...

https://github.com/conda-forge/dotnet-feedstock/pull/17

Sorry for the delay - will get to it this weekend...

No worries!

Fixed by #17


oopsy: don't report share for invulning tanks

uhhh i don't entirely get what that failed test is but looks like it's not on my end?

uhhh i don't entirely get what that failed test is but looks like it's not on my end?

I re-ran it. Just looks like the bot was being weird. idk

Thank you!!


Server crash at /console/logs/ path

Tracking issue for:

[ ] https://github.com/sam4413/AMPLink/security/code-scanning/22

Fixed applied in unstable branch


Identityref predicate values do not contain the module name when the module name is the same as the identityref

Description
With the below YANG model and snippet, the error that we am seeing is "Identityref predicate value 'melt-cdcr' missing module name". This error is being generated in resolve_partial_json_data_nodeid() in resolve.c in libyang. This problem seems to be caused by commit 310bc58 in libyang that requires an identityref value to be in the format ":". The root cause of this problem seems to be the following:

sysrepo sends just value of the identityref if the value of the identityref is in the same module as the identityref itself
sysrepo removes the leaf-list predicate from the xpath in rp_dt_create_xpath_for_node() in rp_dt_xpath.c

resolve_partial_json_data_nodeid() seems to get the identityref value either from the xpath or the identityref value, and neither of these has the module name, so this error is reported
This is the yang model that was used to simulate the error.
module simplified-melt {
  namespace "urn:ietf:params:xml:ns:yang:simplified-melt";
  prefix smelt;
  identity measurement-class;

  identity melt-cdcr {
    base measurement-class;
  }

  container melt {
    list pmd-profile {
      key name;

      leaf name {
        type string;
      }

      leaf-list measurement-class {
        type identityref {
          base measurement-class;
        }
        ordered-by user;
      }
    }
  }
}

Here is the RPC snippet.
<melt xmlns="urn:ietf:params:xml:ns:yang:simplified-melt">
  <pmd-profile>
    <name>melt-pmd-01</name>
    <measurement-class>melt-cdcr</measurement-class>
  </pmd-profile>
</melt>

Lastly, we noticed that some of the test code in netopeer2 that mimics sysrepo was not that same so this error could not be reproduced on netopeer2 without some code changes.
We had  to change test_edit_get_config.c to fully mimic sysrepo.
int
__wrap_sr_get_item_next(sr_session_ctx_t *session, sr_val_iter_t *iter, sr_val_t **value)
{
    ...
        path = lyd_path(ietf_if_set->set.d[0]);
        /* Copied from sysrepo rp_dt_create_xpath_for_node() */

        /* remove leaf-list predicate */
        if (LYS_LEAFLIST & ietf_if_set->set.d[0]->schema->nodetype) {
           char *leaf_list_name = strstr(path, "[.='");
           if (NULL != leaf_list_name) {
               *leaf_list_name = 0;
           } else if (NULL != (leaf_list_name = strstr(path, "[.=\""))) {
               *leaf_list_name = 0;
           }
        }
        /* End copy */

        *value = calloc(1, sizeof **value);
    ...
}

Hi,
it should be fixed now. Nevertheless, if you create a pull request with a new netopeer2 test case, I will be happy to merge it.
Regards,
Michal


added logistic regression model and single-variant tests

support for wald, lr, and score tests
added logreg doc
added LogisticRegressionCommand
added LogisticRegression
added LogisticRegressionModel
added LogisticRegressionSuite including R comparison
added LogisticRegressionModelSuite including Epacts comparison
added supporting resource files regressionLogistic*
added chiSquaredTail function to Utils
added chiSquaredTail teses to UtilsSuite

Timing on profile.vds (1KG, 2535 samples, 25956 variants) using three covariates (isFemale, PC1, PC2) with variant QC and export is 60-63s for wald and lrt, 10-12s for score, on one core locally (with ~2s for read).  Wald example:
hail: info: timing:
  read: 1.922s
  variantqc: 34.869ms
  annotatesamples table: 317.153ms
  annotatesamples fam: 60.988ms
  logreg: 783.904ms
  printschema: 2.034ms
  exportvariants: 1m2.3s

~/hail/build/install/hail/bin/hail \
--master local[1] \
read -i ~/data/profile.vds \
variantqc \
annotatesamples table -i ~/data/profile.ped -e IND_ID -t 'PC1: Double, PC2: Double' -r sa.pc \
annotatesamples fam -i ~/data/profile.fam \
logreg -y sa.fam.isCase -c sa.fam.isFemale,sa.pc.PC1,sa.pc.PC2 -t wald \
printschema \
exportvariants -c 'variant = v, beta = va.logreg.wald.beta, se = va.logreg.wald.se, zstat = va.logreg.wald.zstat, pval = va.logreg.wald.pval, nIter = va.logreg.fit.nIter, converged = va.logreg.fit.converged, exploded = va.logreg.fit.exploded, nNotCalled = va.qc.nNotCalled, nHomRef = va.qc.nHomRef, nHet = va.qc.nHet, nHomVar = va.qc.nHomVar' -o ~/data/profileHail/profile.sex.pc1.pc2.wald.tsv

More timing info and convergence analysis to come.

jenkins

Looks great. Any chance you can add Firth's logistic regression?
Thanks,
Manny
On Sun, Aug 14, 2016 at 12:58 PM, jbloom22<EMAIL_ADDRESS>wrote:

jenkins
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/broadinstitute/hail/pull/585#issuecomment-239684133,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPl2UH8kO3OSrp-6XTXAAacpxxSI9Z2ks5qf0kdgaJpZM4Jje3f
.

In fact I had Firth mixed into this branch but ripped it out when it was making the update too complicated. Whereas Wald, LRT, and score only require fitting the null model once, with the Firth likelihood ratio test you need to fit the null and full models per variant.
So plan is to add Firth, support for subsetting samples per variant (rather than imputing missing genotypes), and better tests by comparing Hail and R results for randomly generated datasets. I'd also like to add more [optional] user control on convergence criteria and on what's returned in annotations (for example, statistics for the other covariates...these are computed anyway). And there are ways to speed up the numerical linear algebra, this is a first pass.
Do you have thoughts on Firth LRT versus Wald? My understanding is that LRT is better calibrated for p-value, but would the Wald standard error for Firth be a useful annotation as well?

Ready for another look. I had to modify the classes some to make it work, particularly for getting the type out of the test. Now the type is with the Test rather than the TestResult, perhaps you see a better way? I'm waiting to squash until we've finalized.
Some related notes, mostly relevant topossible future PRs once we have a sense of performance:
I think LogisticRegressionNullFit should be a separate class, as it plays a conceptually and practically different role. I don't want to attach vectors of length nSamples (like mu) to each LogisticRegressionFit output, even though they would speed up the score test and first iteration of fitting per variant to not recompute them for every variant.  I did put some of this efficiency in the score test (only computing the extra coordinate of score and row / column of fisher per variant).  df would also then go away for LogisticRegressionFit, where it isn't used, but I'd add the diagonal of its inverse for use in Wald (see below). The model fit function would then take a LogisticRegressionNullFit to use to it's hearts content in the first iteration.
The bigger future gains will come from not computing or inverting the Fisher matrix at all in the iteration.
val sqrtW = sqrt(mu :* (1d - mu))
val QR = qr.reduced(X(::, ) : sqrtW)
solve QR.R * deltaB = QR.Q.t * (y - mu) with R upper triangular (need to wrap lapack function)
for Wald: return diagonal of inverse as well, namely diagonal of inv(R)^T * inv(R), rather than inverting fisher again.
for Firth, modify score using:
val QQ = QR.Q :* QR.Q
val h = sum(QQ(*, ::))
for Score, a version of this may be faster:
val sqrtW = sqrt(mu :* (1d - mu))
val Qty0 = qr.reduced.justQ(X(::, ) : sqrtW).t * ((y - mu) :/ sqrtW)
val chi2 = Qty0 dot Qty0

Updated runtime for LRT is about 50s:
~/hail/build/install/hail/bin/hail \
--master local[1] \
read -i ~/data/profile.vds \
annotatesamples table -i ~/data/profile.ped -e IND_ID -t 'PC1: Double, PC2: Double' -r sa.pc \
annotatesamples fam -i ~/data/profile.fam \
logreg -y sa.fam.isCase -c sa.fam.isFemale,sa.pc.PC1,sa.pc.PC2 -t lrt \
exportvariants -c 'variant = v, beta = va.logreg.lrt.beta, chi2 = va.logreg.lrt.chi2, pval = va.logreg.lrt.pval, nIter = va.logreg.fit.nIter, converged = va.logreg.fit.converged, exploded = va.logreg.fit.exploded' -o ~/data/profileHail/temp.profile.sex.pc1.pc2.lrt.tsv

  read: 2.193s
  annotatesamples table: 243.817ms
  annotatesamples fam: 22.080ms
  logreg: 367.098ms
  exportvariants: 50.473s

addressed comments, back to you.


EXP format, fails trim on long jump.

80 80 07 00 is apparently a command that has something to do with it.

EXP format appears to trim, but might be an illusion. Must be rechecked against functional data.


Different sectors in a page does not seem to work

Different sectors in a page does not seem to work

$('.adunit1').dfp({
    'dfpID': '11111111',
    afterEachAdLoaded: function (adUnit) {
        if ($(adUnit).hasClass('display-none')) {
            console.log('Ad not found');
        } else {
            console.log('Ad found');
        }
    },
    afterAllAdsLoaded: function (adUnits) {
        console.log('all ads are loaded'+adUnits);
    }
});

$('.adunit2').dfp({
    'dfpID': '22222222',
    afterEachAdLoaded: function (adUnit) {
        if ($(adUnit).hasClass('display-none')) {
            console.log('Ad2 not found');
         } else {
            console.log('Ad2 found');
         }
     },
     afterAllAdsLoaded: function (adUnits) {
	console.log('all ads2 are loaded'+adUnits);
    }
});

Console.log show:
Ad1 not found
all ads1 are loaded []
Ad2 not found
Seems that afterAllAdsLoaded $('.adunit2') not fired.
And seems that second block the first...

Sometimes I see in logs:
Ad2 not found
all ads2 are loaded
Ad1 not found
And afterAllAdsLoaded $('.adunit1') not fired.


expose cookies in the CookieJar middleware

Hi!
Addresses #6519.
Happy to discuss if I didn't get the point - the feature would be pretty useful for me.

Excited to see this, if you need something that already does this snickerdoodle exposes this via SnCookiePersistence, which also supports several other more advanced features of cookie management such as persistence between runs(if you'd like), supercookie protection, and synchronous or asynchronous persistence behavior.
This may need to target main though as I think this breaks the interface.


Dependencies: prefer git command than go-git to enable authentication through git

For private repositories it is desirable that the git command is used since the credentials are already stored there and don't have to be encoded into the devspace.yaml

Fixed in v3.5.18


Unable to access the software, 401 unauthorized

Does anyone have advice for how to resolve this issue? Am I missing something basic. I am using the academic license provided from the University of Washington that was emailed.
Looking in indexes: https://pypi.org/simple, https://us-python.pkg.dev/colab-wheels/public/simple/
Requirement already satisfied: pyrosettacolabsetup in /usr/local/lib/python3.8/dist-packages (1.0.6)
Drive already mounted at /content/google_drive; to attempt to forcibly remount, call drive.mount("/content/google_drive", force_remount=True).
Looking for compatible PyRosetta wheel file at google-drive/PyRosetta/colab.bin/wheels...
To obtain PyRosetta license please visit https://www.rosettacommons.org/software/license-and-download
Please enter you RC license login:
Please enter you RC license password:
Downloading PyRosetta package...
--2023-01-22 04:08:09--  https://west.rosettacommons.org/pyrosetta/release/release/PyRosetta4.MinSizeRel.python38.ubuntu.wheel/.latest
HTTP request sent, awaiting response... 401 Unauthorized
Authentication selected: Basic realm="Rosetta Repo"
HTTP request sent, awaiting response... 401 Unauthorized
ERROR: Wheel download has not worked correctly, ABORTING...
An exception has occurred, use %tb to see the full traceback.

The PyRosetta download username/password is different from the (command line) Rosetta username/password. Check that you're using the correct one. (You will have to obtain a separate PyRosetta license to get the PyRosetta username/password.)
If you're having issues with the west.rosettacommons.org server, try to see if the east.rosettacommons.org server is having the same issues (and vice versa).


feat: Create trigger when not exists

Makes db.Prepare repeatable by preventing the following error:
ERROR: trigger "public__foo_changesets" for relation "foo" already exists (SQLSTATE 42710)+

I tested this manually and it worked as expected. Can post the output if needed.

Oops not ready!

Oops not ready!


Query Cost Estimation

I'm looking to make a contribution to the project.
@archiewood have you looked into adding the query cost estimation to the plugin?

from google.cloud import bigquery

# Construct a BigQuery client object.
client = bigquery.Client()

# Set your query here
query = """
SELECT name, count
FROM `table`
WHERE state = 'TX'
"""

# Set up the dry run query configuration
job_config = bigquery.QueryJobConfig(dry_run=True, use_query_cache=False)

# API request - dry run query
dry_run_query_job = client.query(query, job_config=job_config)

# A dry run query does not provide a row iterator, only statistics
print(f"This query will process {dry_run_query_job.total_bytes_processed} bytes.")

Hi @Italosayan
I've briefly looked into it, but not extensively. Contributions are  certainly welcomed!
I think calling the dry run function shouldn't be too bad, similar to your example above.
I suspect the hard part is wiring it up into SQLtools, as it does not have inbuilt functionality to support cost estimation.
We need:

a way for the user to initiate the dry run
a way to expose the results of the dry run back to the user

Also I think this is a duplicate of #13 - let's continue over there!


Cop suggestion: CommentedEnd

I find this code frequently:
class MyClassName
  # stuff
end # MyClassName

It'd be nice to have a cop to prevent comments right after the end keyword. The only use case I can think of (pointing out which block the end is closing) usually means that the block is too long or it has too much nesting.

I'm not against it. 🙂


OF-Scraper Announcements:__(1) error, cant get past message.

hello I cant seem to run the scrapper, I cant get past this message and I am not sure why? I set it to keydb and provided an api key. thanks.
OF-Scraper Announcements:(1). For those who use cdrm for cdm; a fix has    logs.py:82
been pushed to handle errors from the CDRM-Project API. Previously FFMPEG would endlessly fail for effected
downloads because of bad inputs being cached. Update to at least [3.12.7](2). cdrm seems to be getting ip
blocked by onlyfans based on error messages, the fix is to use your own keys or switch to keydb or to wait
for the requests to work again

This isn't an error message but just an announcement message I the scraper. To help we would need a screenshot of the issue you are having to try and help.

It's just that message, a screenshot wouldn't show you much different. I launch the scraper with of scraper command, this message appears but then automatically the script finishes before providing me any options to choose.

From: cjb900 @.>
Sent: Saturday, December 28, 2024 8:02:55 PM
To: datawhores/OF-Scraper @.>
Cc: god43 @.>; Author @.>
Subject: Re: [datawhores/OF-Scraper] # OF-Scraper Announcements:__(1) error, cant get past message. (Issue #492)
This isn't an error message but just an announcement message I the scraper. To help we would need a screenshot of the issue you are having to try and help.
—
Reply to this email directly, view it on GitHubhttps://github.com/datawhores/OF-Scraper/issues/492#issuecomment-2564573740, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABVOA2PSKPO7MLUITFNWDJL2H5C37AVCNFSM6AAAAABUKEWNNOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRUGU3TGNZUGA.
You are receiving this because you authored the thread.Message ID: @.***>

If a screenshot wouldn't be helpful then I wouldn't have asked for one.

here you go, thanks.

Ya this shows more information than what you initially posted and tells me exactly what your issue is. You need to have aiolimiter version 1.1.0 installed. Any newer version will not work.

interesting ok thanks ill try that out and let you know.

Ya this shows more information than what you initially posted and tells me exactly what your issue is. You need to have aiolimiter version 1.1.0 installed. Any newer version will not work.

Hi, thanks for your hint, I got the same error message, then I installed “aiolimiter” 1.1.0, it but it seems still not working, could you tell me if I miss anything please?

If you have confirmed to have aiolimiter version 1.1.0 installed you may need to reinstall ofscraper to get it to work.

If you have confirmed to have aiolimiter version 1.1.0 installed you may need to reinstall ofscraper to get it to work.

Yes, ok just tried, still got the identical message of the screenshot above

you need to uninstall the pipx version of ofscraper and install it via pip to get it to work with the way you installed aiolimiter

i installed it using "pip install aiolimiter==1.1.0", and my issue went away. thanks.

you need to uninstall the pipx version of ofscraper and install it via pip to get it to work with the way you installed aiolimiter

Now seems working to me too, thanks a lot

@datawhores can you pin an issue regarding this error?
Symptom: ofscraper closes with no download with "Finished script"
Solution: Pin aiolimiter to version 1.1.0:

if you used pip to install: pip install aiolimiter==1.1.0
if you used pipx to install: pipx inject ofscraper aiolimiter==1.1.0


Fixed install warning when using with angular 4

During install in an angular 4 project warnings are thrown due to semantic versioning. As the package is angular-4 compatible there was an easy way to prevent this.
warning<EMAIL_ADDRESS>has incorrect peer dependency "<EMAIL_ADDRESS>warning<EMAIL_ADDRESS>has incorrect peer dependency "<EMAIL_ADDRESS>

Why won't this be merged :( @shlomiassaf

Thank you for your contribution.
Due to a huge refactor I could not use the commit but I believe the issue is now fixed with version 3.0.0
If not, please feel free to open a new issue.
Version 3 comes with a better build (FESM) and the following changes:
* handle document for angular universal
* refactor: use ng-template instead of template
* refactor: remove defaultOverlayTarget directive
* refactor: replace custom swpCmp with ngComponentOutlet

### BREAKING CHANGES

  - Moving to use <ng-template> will break applications running on < 4
  - Applications using defaultOverlayTarget (all of them) will have to omit it

(2f98e75)


[Enhancement] support bitmap hll percentile type for mv backport 2.5

What type of PR is this：

[ ] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #15731
Problem Summary(Required) ：

support bitmap hll percentile type for mv
Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto backported to target branch

[ ] 2.5
[ ] 2.4
[ ] 2.3
[ ] 2.2

run starrocks_fe_unittest


[master] Upgrade to latest dependencies

Produced via:
./hack/update-deps.sh --upgrade
./hack/update-codegen.sh

Justification, Pushing release branch of knative/hack repo, staging for 0.19 release cuts. -n3wscott
/cc knative/serving-writers knative/eventing-writers
/assign knative/serving-writers knative/eventing-writers

/retest


Docs refactor

The documentation is great, but for a completely new user, there's a lot to read through before they have a good overview of what's possible. To make it more obvious for a user to see how to do all of the common things, I want to refactor the docs into the following sections:
Getting started

Initialization
Adding model views
Overriding the index page

Auth & permissions

Basic auth
Flask-Security

Customizing the builtin model views

Image fields
HTML fields
List view options
Form view options

Adding your own views

Standalone views
Overriding specific model views

Advanced

Enabling localization
Handling foreign key relations inline
Many-to-many relations
Managing files & folders
Managing geographical models
Customizing builtin forms via form rendering rules
Using different model backends
Rolling your own authentication
Usage tips
Adding a Redis console

API

(auto generated from code)

Just created branch docs_refactor for these changes. Any comments/help is welcome!


Remove useless selection feature on shipping prices

1. Why is this change necessary?
You can select pricing items and then have no items to do with that.

I could add a bulk action instead but what should I do?
2. What does this change do, exactly?
Deactivate selections on the pricing table.

3. Checklist

[x] I have rebased my changes to remove merge conflicts
[ ] I have written tests and verified that they fail without my change
[x] I have created a changelog file with all necessary information about my changes
[ ] I have written or adjusted the documentation according to my changes
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-23598
Please use this issue to track the state of your pull request.

Thank you for your contribution @JoshuaBehrens. Your PR is now merged! 🥳

Thank you for merging :)


Document API route limitation

See #78. If you have SvelteKit routes in src/routes/api, they will return a 404 when deployed to Azure. This is because Azure SWA reserves the /api path for individual Azure functions.
We could also issue some sort of warning if/when we detect these routes.

Thought on this: maybe this should be a build error instead. You shouldn't be defining SvelteKit /api routes for Azure SWA because they're just going to get ignored.
Could also provide a flag to ignore the error if needed, but I wouldn't want to add it prematurely.

@geoffrich Is there a solution/workaround for this currently?

We may need to warn/error about the new /data-api route as well.

Thank you, I finally get why my api returned 404.
I guess I'm not the only one setting API related stuff in 'routes/api', maybe this should be stated straight in the main README?

I've opened #142 to throw a build error when this scenario is detected.


[ISSUE-154] Add Watches

Add Watches feature, raised under https://github.com/elastic/terraform-provider-elasticstack/issues/154
ES Watcher API endpoints: https://www.elastic.co/guide/en/elasticsearch/reference/current/watcher-api.html

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

Currently blocked due to basic license on docker-elasticsearch instance:

Will have to look to see if it's possible to uplift to trial license at all

You should be able to start a trial within the test setup. The API is exposed in the Go client too

Hey @tobio! I'm keen to get this one finished before the next version is released of the provider (0.6.0 I'm assuming), did you know when you're planning on rolling out this next version? (just so I know how much time I have to play with!)
Note: Am hoping to get this sorted this week anyway but thought I'd check just in case it was to be rolled out imminently!

Likely 2-3 weeks I think. Would be great to have this one in, thanks @RobsonSutton

Hey again @tobio, Just wondering if you may be able to impart some wisdom on this PR? my head is sore from banging it against the desk currently, and I've been going in circles trying to figure out where I am messing things up...
ISSUE 1
I am struggling a bit with how to best handle the nested "active" field in the GET response... (sorry, probably super elementary!), seem to get an unmarshalling error between the bool type and model but can't quite pin down why this is being thrown currently as the different interactions seem to match up to me (must be missing something though!)...

ISSUE 2
FYI: main.tf I've just left there currently as I was doing some local running to view the trace logs to hopefully get a bit more of an insight into where things are wrong...
From this I can see the PUT being sent is as I'm expecting:

...however for some reason this is failing to create on the elasticsearch side (yet when running the same command via dev tools in another cluster it succeeds without any issues...)

...yet from the subsequent GET being called, I can see this does in fact exist on the cluster now (despite the above response) and is in state too (although it has been tainted...)

Apologies if they're super simple things, I've just been struggling to get my head around them for the past day or so!
Any pointers or advice you have on how to tackle either would be greatly appreciated!

@RobsonSutton I've pushed up a commit which fixes the parsing problem. It looks like the code was expecting a collection of watches, but the GET watch API just returns the requested watch directly.
The tests are still failing because of some defaults being returned in the API response, but this should unblock you. LMK if you need any other help here. This is looking great!

@RobsonSutton I've pushed up a commit which fixes the parsing problem. It looks like the code was expecting a collection of watches, but the GET watch API just returns the requested watch directly.
The tests are still failing because of some defaults being returned in the API response, but this should unblock you. LMK if you need any other help here. This is looking great!

Awesome stuff! 🥳 Thanks for this, now that I have seen the issue I'm kicking myself for not noticing it last week.. was clearly too far down the rabbit hole to see..!
Oh well, live and learn! thanks again for helping with this one, is much appreciated!

@tobio - Please can you review this one when you have a spare min please?
Think it should be nearly there now, just been trying to get the main stuff in place so that it can make it in before the version bump!👍
Things to note:

Have tried to keep as close to how they are defined via the UI (in one large JSON string). Happy to rename body -> json_body in case you ever wanted to have both options of either defining it via json or via TF blocks though?
I have forced the main 4 fields to be required which differs slightly from the API. This is to workaround the issue with these being set to defaults by the API (I played around for quite a while with defining defaults in all manner of ways to try to match this with the API, but figured this would probably just be the best approach in the end since user config will then always match up)
I have not added throttle_period just yet, more due to time than anything else! (this sets throttle_period_in_millis in ES anyway it seems, but just allows for declaration in a more readable format: throttle_period = "10s" == throttle_period_in_millis = 10000)
I have also just added error handling for metadata = {} for the time being, to prevent infinite plan noise due to omitempty. Tried without this being set but just ended up with the reverse error when metadata wasn't being set instead...
Also not sure of the naming standard really for resources so just followed something like this approach: elasticstack_ - Looks a little weird with watcher_watch though... I doubt there will be any other resources added in this package either, so happy to rename if you'd prefer 👍

Any feedback you have for any parts that need to be changed or any potential improvement / better ways of doing things would be greatly appreciated as always!
(Also, forgive the no. of commits... 😆 my local machine couldn't handle running the tests and containers under make docker-testacc so was just having to use make install and running locally to complete most of the validation and testing)

I think we should add the individual properties to this resource eventually, it would help with avoid the issues with applying defaults to the field values. body should be fine though, it won't conflict with any of the field names.

Will look at this one tomorrow 👍 I guess I was approaching this more from a consumer angle when focusing on the full json body approach, so that any watchers being moved to the provider (as opposed to being created from scratch) would need to be decoded, separated and re-encoded to each of the fields, whereas with body you can just point at a file containing the copy and paste of the UI watcher config. Isn't a massive job for consumers to instrument though so if it offers better control from the provider side then will see if I can quickly rework this one to support individual properties instead!

I have not added throttle_period just yet, more due to time than anything else! (this sets throttle_period_in_millis in ES anyway it seems, but just allows for declaration in a more readable format: throttle_period = "10s" == throttle_period_in_millis = 10000)

I'm happy to approve this without it, but if you have time it would be great to support this just to avoid confusion.

Will have another look at this one tomorrow too 👍 it is just be a human readable wrapper for throttle_period_in_millis though so I'm not sure if you wanted to support both in the provider or just one of the two? e.g. if I were to set throttle_period to 5s, when the watcher is created in ES, it will actually set throttle_period_in_millis to the equivalent value (5000) within the watcher as opposed to it being it's own field.

it will actually set throttle_period_in_millis to the equivalent value (5000) within the watcher as opposed to it being it's own field

This sounds like setting throttle_period would also require specifying throttle_period_in_millis to the equivalent value to avoid an endless diff loop. Sorry, I think I misunderstood what you'd said earlier, it sounds like you're right to leave throttle_period out of the provider.

@tobio - Apologies for the delay, body should be split into separate fields now though, please let me know your thoughts! 👍

No problem! 👍 Thanks as always for helping to advise with the Go side of things, is much appreciated!


[Job] restructure single job class to dedicated ones

Currently there is only one job class defined. It might be nice for future extensions, to define a base job class with basic functionality and split the input file and caching functionalities into a dedicated job class which inherits its base functionalities from the base class.

The job as defined by LAPIS is the base job definition that can further be extended. This is what @tfesenbecker did with her caching extension.

The job as defined by LAPIS is the base job definition that can further be extended. This is what @tfesenbecker did with her caching extension.

In this case, this issue is solved and can be closed.


Failed to Run the Example for sts-server

Bug Report
Describe the Bug
Following the example given in launchers/sts-server/README.md gives unexpected output.
After building a runtime and setting up cert and private keycorrectly, I ran the following command as is documented in the README:
curl --request POST \
  --url http://localhost:9292/api/v1/sts/token \
  --header 'Content-Type: application/x-www-form-urlencoded' \
  --data grant_type=client_credentials \
  --data client_id=testClient \
  --data client_secret=clientSecret \
  --data audience=test10

Expected Behavior
I should get the token.
Observed Behavior
Instead it returns :
{"error":"invalid_client","error_description":"Invalid client or Invalid client credentials"}

Steps to Reproduce
Follow the tutorial given in  launchers/sts-server/README.md
Context Information
Add any other context about the problem here.

Used version:  EDC v0.7.0
OS: Debian12
Java version- 17
Gradle- 8.6
...

Possible Cause
By looking at the debug information provided by monitor in Vault, I found the method storeSecret has never been called.
This means the vault in StaClientServiceImpl does not contain sts-vault.properties as expected (it doea not contain any key-value pairs!).
Probably a slight change in -D could fix this issue, but since the project uses injection to create the Service and that I am not familiar with the injection framework, I cannot dig deeper.

Hi @harnvo
thanks for raising this, the main issue is the removal of the filesystem vault that happened in #4202.
The config file sts-vault.properties basically it's not used now. We'd have to change the README and change how to seed the vault.
Thanks

I later tried manually adding vault.storeSecret("secretAlias", "clientSecret"); during initialization of StsClientServiceImpl, but running the example gives me the following output:
DEBUG 2024-06-20T22:31:00.840818906 Resolving secret secretAlias
DEBUG 2024-06-20T22:31:00.844244755 Resolving secret 1
DEBUG 2024-06-20T22:31:00.845082662 [PrivateKeyResolution] Public key not found, fallback to config. Error: Private key with ID '1' not found in Vault
SEVERE 2024-06-20T22:31:00.847577119 JerseyExtension: Unexpected exception caught
java.lang.NullPointerException: Cannot invoke "java.util.function.Function.apply(Object)" because "failureAction" is null
        at org.eclipse.edc.spi.result.AbstractResult.orElse(AbstractResult.java:105)
        at org.eclipse.edc.iam.identitytrust.sts.defaults.StsDefaultServicesExtension.lambda$clientTokenService$1(StsDefaultServicesExtension.java:71)
        at org.eclipse.edc.iam.identitytrust.sts.defaults.service.StsClientTokenGeneratorServiceImpl.lambda$tokenFor$0(StsClientTokenGeneratorServiceImpl.java:58)
        at org.eclipse.edc.token.JwtGenerationService.generate(JwtGenerationService.java:45)
        at org.eclipse.edc.iam.identitytrust.sts.embedded.EmbeddedSecureTokenService.lambda$createToken$1(EmbeddedSecureTokenService.java:74)
        at org.eclipse.edc.spi.result.AbstractResult.compose(AbstractResult.java:185)
        at org.eclipse.edc.iam.identitytrust.sts.embedded.EmbeddedSecureTokenService.createToken(EmbeddedSecureTokenService.java:72)
        at org.eclipse.edc.iam.identitytrust.sts.defaults.service.StsClientTokenGeneratorServiceImpl.tokenFor(StsClientTokenGeneratorServiceImpl.java:73)

......
some other useless stacktrace
......

What Goes Wrong
I understand that this is because there is another Vault in VaultPrivateKeyResolver which is also not properly set, and that changing the way to seed the vault may also solve this one. However, I believe having a NullPointerException is not desired even when I have the wrong config. So I dig a bit deeper.
After debugging I found the root cause comes from line 71 in StsDefaultServiceExtension,
In a word, the parameter failureAction in orElse should not be null, as you would later have failureAction.apply(xxx).

I later tried manually adding vault.storeSecret("secretAlias", "clientSecret"); during initialization of StsClientServiceImpl, but running the example gives me the following output:
DEBUG 2024-06-20T22:31:00.840818906 Resolving secret secretAlias
DEBUG 2024-06-20T22:31:00.844244755 Resolving secret 1
DEBUG 2024-06-20T22:31:00.845082662 [PrivateKeyResolution] Public key not found, fallback to config. Error: Private key with ID '1' not found in Vault
SEVERE 2024-06-20T22:31:00.847577119 JerseyExtension: Unexpected exception caught
java.lang.NullPointerException: Cannot invoke "java.util.function.Function.apply(Object)" because "failureAction" is null
        at org.eclipse.edc.spi.result.AbstractResult.orElse(AbstractResult.java:105)
        at org.eclipse.edc.iam.identitytrust.sts.defaults.StsDefaultServicesExtension.lambda$clientTokenService$1(StsDefaultServicesExtension.java:71)
        at org.eclipse.edc.iam.identitytrust.sts.defaults.service.StsClientTokenGeneratorServiceImpl.lambda$tokenFor$0(StsClientTokenGeneratorServiceImpl.java:58)
        at org.eclipse.edc.token.JwtGenerationService.generate(JwtGenerationService.java:45)
        at org.eclipse.edc.iam.identitytrust.sts.embedded.EmbeddedSecureTokenService.lambda$createToken$1(EmbeddedSecureTokenService.java:74)
        at org.eclipse.edc.spi.result.AbstractResult.compose(AbstractResult.java:185)
        at org.eclipse.edc.iam.identitytrust.sts.embedded.EmbeddedSecureTokenService.createToken(EmbeddedSecureTokenService.java:72)
        at org.eclipse.edc.iam.identitytrust.sts.defaults.service.StsClientTokenGeneratorServiceImpl.tokenFor(StsClientTokenGeneratorServiceImpl.java:73)

......
some other useless stacktrace
......

What Goes Wrong
I understand that this is because there is another Vault in VaultPrivateKeyResolver which is also not properly set, and that changing the way to seed the vault may also solve this one. However, I believe having a NullPointerException is not desired even when I have the wrong config. So I dig a bit deeper.
After debugging I found the root cause comes from line 71 in StsDefaultServiceExtension:
(client) -> privateKeyResolver.resolvePrivateKey(client.getPrivateKeyAlias()).orElse(null),

In a word, the parameter failureAction in orElse should not be null, as you would later have failureAction.apply(xxx).
Quick Fix
A slight change in line 71 works:
(client) -> privateKeyResolver.resolvePrivateKey(client.getPrivateKeyAlias()).orElse( (failure_action)->null ),

Hi @wolf4ood
Thanks your for swift fix of this issue. I wonder if it is still necessary to have this slight modification to prevent potential NullPointerException.


Direct Workload Identity Federation

TL;DR
Hi, does this project support Direct Workload Identity Federation?
https://github.com/google-github-actions/auth#preferred-direct-workload-identity-federation
Without specifying a Service Account?
I tried and failed with
ERROR: (gcloud.compute.ssh) Could not add SSH key to instance metadata:
 - The user does not have access to service account<EMAIL_ADDRESS> User: 'repo:PokeAPI/deploy:ref:refs/heads/gql (projects/XXX/locations/global/workloadIdentityPools/github)'.  Ask a project owner to grant you the iam.serviceAccountUser role on the service account

PS: I also added the public SSH key to my instance but the Github Action still cannot connect.
Expected behavior
No response
Observed behavior
No response
Action YAML
name: update-gql-data
on:
  push:
    branches:
      - gql
jobs:
  update-gql-data:
    runs-on: ubuntu-22.04
    permissions:
      contents: 'read'
      id-token: 'write'
    steps:
    - uses: 'actions/checkout@v4'
    - uses: 'google-github-actions/auth@v2'
      with:
        project_id: 'pokeapi-215911'
        workload_identity_provider: 'projects/XXX/locations/global/workloadIdentityPools/github/providers/deploy'
    - uses: 'google-github-actions/ssh-compute@v1'
      with:
        instance_name: 'graphql5'
        zone: 'us-east1-b'
        ssh_private_key: '${{ secrets.GCP_SSH_PRIVATE_KEY }}'
        user: ga
        command: |-
          sudo -i
          (cd pokeapi && ls)
    - run: |-
        echo '${{ steps.compute-ssh.outputs.stdout }}'
        echo '${{ steps.compute-ssh.outputs.stderr }}'

Log output
No response
Additional information
No response

I believe you need to grant your WIF provider IAM permissions for serviceAccountUser on the Default Compute Engine Service Account.

Many thanks @sethvargo

Do you also happen to know how to display the stream of logs produced by the command executed through SSH? Right know I have a log running task that outputs many lines, but I can't see them in the Github Action task logs.
Or the only option is to run a later task as shown in the README?
    - run: |-
        echo '${{ steps.compute-ssh.outputs.stdout }}'
        echo '${{ steps.compute-ssh.outputs.stderr }}'


Optimized the chat interface (including the chat API after sharing)

What problem does this PR solve?
Optimized the chat interface (including the chat API after sharing)

Change the background color of the dialog box between the assistant and the user (use the theme color of the interface)
Add rounded corners to the dialog box
When the input box is empty, you can't click the send button(because some models will report an error when sending empty data)

Color reference(can be a bit subjective)：

Type of change

[ ] Bug Fix (non-breaking change which fixes an issue)
[ ] New Feature (non-breaking change which adds functionality)
[ ] Documentation Update
[ ] Refactoring
[ ] Performance Improvement
[x] Other (please describe):

and
4、Added text-align: justify to user dialog text


Check the screen for FastBitcoin.

This screen appears when we click on fastbitcoin.

Now no screen is opening on clicking.
Tested on dev app v1.8.0(315)


no popup login in full page

Is it possible to not have a popup login but be redirected to a full page?
thanks

I would like to know this too


Cleanup TestHelper.ts

I did this cleanup in small commits to help explain what I did and why.  Mostly this was based on recommendations made by Visual Studio 2015 & ReSharper.
The commit a5f283c is the most important one, since it was previously always causing compile issue for me in VS.  This fixes it so that it still works like before, it compiles in VS, and it's a little easier to read.

I'll take a look this weekend, thanks!

Looks good. a few comments:

we don't care about having interfaces start with I, so I took that out
each commit should have a passing "grunt all". If not, then squash the commits together until you do (you'll see that I squashed your tslint fixes push into the correct commit)

Also, for this one:

Move functions below so that they don't call a function before it appears

Can this really happen?

I merged it in. Thanks!

@HamletDRC Alright good comments, thanks!
About the functions appearing before they are called, that was just a suggestion made to me by Visual Studio 2015 and/or ReSharper 9.  When opening files I want to get rid of the squiggly underlines, so mostly why I did this was to appease my IDE.  Technically calling a function before it exist could be a problem, but I think that's practically very unlikely.
In my day-to-day typescript coding we don't use a lot of modules with exported members, so I'm not too familiar with good patterns regarding this.Perhaps enforcing the order of exported vs. non-exported members would make for a good TSLint rule!  There's already the member-ordering rule that enforces the order of class members depending on visibility.


[Feature request] Volume setting

Would it be possible to add an option for volume setting in the app? Maybe even with a checkbox to mirror volume % from the streamed audio output device from Windows? Maybe also with a checkbox to match the volume both ways, so if I change the volume on the DLNA device, that would also affect system volume in windows on the output device? I ask as the volume bar works perfectly both ways (from pc to DLNA device and vice versa) in Windows' cast app if I natively stream a file from Windows 10.

I'm very sorry but it won't happen. Swyh-rs only implements the absolute minimum of the DLNA protocol to allow it to stream. Everything else like status report callbacks and commands like set volume etc... are left to the dlna controllers supplied (or not) by the manufacturers of the receivers. Things would be different  if a Rust dlna library were available, but I don't think there is much interest for that. DLNA is not "hot" I'm afraid...

The latest release 1.9.5 now has volume sliders.


filterBy issue with $index in new list

Vue.js version
1.0.23
When I filtering my users (by filterBy), the $index don't move with a user. So, when I editing the user, it's an other user is printing (sorry for my english...).
v-for='personne in personnes |filterBy searchNom'>
                 {{ personne.Nom }}
Thanks your help

Could it be that the method editer is using the index-id without filtering personnes first?
Cause $index is just the row of the current object, you probably should do something like on:clik="editer(personne.ID)" instead and get the user by ID.

Don't work.
It's not possible to use $index with filterBy for select a user ?
I use personne.Id for the back-end, yes. But in html view, i want just use $index of vuejs.
This is my method "editer"
`
	  editer: function(index) {

			this.inputNom = this.personnes[index].Nom;

			this.inputPrenom = this.personnes[index].Prenom;

			this.inputId = this.personnes[index].Id;

			this.vider = true;

			var object = this.$els.modif;

			Vue.nextTick(function() {

				object.focus();

			});

	  },

`

Can you provide a js bin?

If you change
on:click="editer(personne)"
and then
editer: function(pers) {
this.inputNom = pers.Nom;
this.inputPrenom = pers.Prenom;
this.inputId = pers.Id;
....
That should work.
If I'm correct, $index is only the number of the current row, so if you have a list with the people
A, C, B
And you sort it in your list
A = $index 0
B = $index 1
C = $index 2
But in the backside it's
A = $index 0
C = $index 1
B = $index 2
That's why the $index does not correlate.

Yes, it's ok, thanks you artfuld !!

Great, thanks @artfuld. I'm going ahead to close this now.


Sync settings

Description of the new feature / enhancement
Syncing settings via Microsoft Account would be useful
Scenario when this would be used?
Fancy Zones will greatly benefit from this, especially when working with multiple devices
Supporting information
No response

/dup #3381


Fix the call to round_to_quarter

Stop command is failing as the round_to_quarter method is not in Timesheet class
Traceback (most recent call last):   File "/home/r0x73/.local/bin/taxi", line 11, in <module>     sys.exit(cli())   File "/home/r0x73/.local/lib/taxi/lib/python3.6/site-packages/click/core.py", line 722, in __call__     return self.main(*args, **kwargs)   File "/home/r0x73/.local/lib/taxi/lib/python3.6/site-packages/click/core.py", line 697, in main     rv = self.invoke(ctx)   File "/home/r0x73/.local/lib/taxi/lib/python3.6/site-packages/click/core.py", line 1066, in invoke     return _process_result(sub_ctx.command.invoke(sub_ctx))   File "/home/r0x73/.local/lib/taxi/lib/python3.6/site-packages/click/core.py", line 895, in invoke     return ctx.invoke(self.callback, **ctx.params)   File "/home/r0x73/.local/lib/taxi/lib/python3.6/site-packages/click/core.py", line 535, in invoke     return callback(*args, **kwargs)   File "/home/r0x73/.local/lib/taxi/lib/python3.6/site-packages/click/decorators.py", line 17, in new_func     return f(get_current_context(), *args, **kwargs)   File "/home/r0x73/.local/lib/taxi/lib/python3.6/site-packages/taxi/commands/stop.py", line 28, in stop     description   File "/home/r0x73/.local/lib/taxi/lib/python3.6/site-packages/taxi/timesheet/timesheet.py", line 122, in continue_entry     entry.duration = (entry.duration[0], self.round_to_quarter( AttributeError: 'Timesheet' object has no attribute 'round_to_quarter'

All done (tests and changelog)

Thanks! :tada:


TypeError: Cannot read property 'forEach' of undefined

Thank you for reporting a bug! We appreciate it very much. Issues are a big input into the priorities for Pact development
All italic text in this template is safe to remove before submitting
Thanks again!
Software versions
Please provide at least OS and version of pact-js

OS: _e.g. Windows 11 Home Single Language
Pact Node version: 13.13.4
Node Version: v14.18.0
Other Versions: Any other versions you think might be relevant (optional)

Issue Checklist
Please confirm the following:

[X] I have upgraded to the latest
[X] I have the read the FAQs in the Readme
[ ] I have triple checked, that there are no unhandled promises in my code
[ ] I have set my log level to debug and attached a log file showing the complete request/response cycle
[ ] For bonus points and virtual high fives, I have created a reproduceable git repository (see below) to illustrate the problem

Expected behaviour
Provider Verification passed sucessfully
Actual behaviour
TypeError: Cannot read property 'forEach' of undefined
Steps to reproduce
Run the provider file
`import { Verifier } from '@pact-foundation/pact';
import path from 'path';
describe('Pact Verification', () => {
jest.setTimeout(50000);
it('validates the expectations of dynamicApi Service', () => {
const opts = {
log: path.resolve(process.cwd(), 'logs', 'pact.log'),
LogLevel: 'debug',
providerBaseUrl: 'providerBaseUrl',
pactBrokerUrl: 'pactBrokerUrl',
pactBrokerToken: 'pactBrokerToken',
pactUrls: [
'pactUrls',
],
publishVerificationResult: true,
providerVersion: '2.0.0',
provider: 'provider',
tags: ['release'],
};
return new Verifier(opts).verifyProvider().then((output) => {
console.log('Pact Verification Complete!');
console.log(output);
});
});
});
`
Here is the output
`FAIL   contract-testing  apps/contract-testing/provider/dynamicApi.spec.ts
Pact Verification
× validates the expectations of dynamicApi Service (15 ms)
● Pact Verification › validates the expectations of dynamicApi Service
TypeError: Cannot read property 'forEach' of undefined

  at ../../node_modules/@pact-foundation/pact-core/src/verifier/validateOptions.ts:266:15
      at Array.forEach (<anonymous>)
  at ../../node_modules/@pact-foundation/pact-core/src/verifier/validateOptions.ts:265:18
      at Array.forEach (<anonymous>)
  at validateOptions (../../node_modules/@pact-foundation/pact-core/src/verifier/validateOptions.ts:260:5)
  at new Verifier (../../node_modules/@pact-foundation/pact-core/src/verifier/index.ts:16:35)
  at Object.<anonymous>.exports.default (../../node_modules/@pact-foundation/pact-core/src/verifier/index.ts:30:56)
  at Pact.verifyPacts (../../node_modules/@pact-foundation/pact-core/src/pact.ts:158:27)
  at ../../node_modules/@pact-foundation/src/dsl/verifier/verifier.ts:137:29

Test Suites: 1 failed, 1 total
Tests:       1 failed, 1 total
Snapshots:   0 total
Time:        2.036 s, estimated 3 s
Ran all test suites matching /apps\contract-testing\provider\/i.`

For extra bonus points and internet karma, provide a repository, gist or reproducible code snippet so that we can test the problem.
We recommend forking the project and modifying a relevant example in the examples folder
Relevant log files
Please ensure you set logging to DEBUG and attach any relevant log files here (or link to a gist).

PR related: https://github.com/pact-foundation/pact-js-core/pull/432

Can you please re-test with the latest @ghsouza89? This should be fixed now. Thanks again for raising it.

@mefellows here is the result after update the @pact-foundation/pact-core to 13.13.5
Before run I did the follow steps:

rm -rf node_modules
rm -f package-lock.json
npm cache clean --force
npm install

@pact-foundation/pact-core is a dependency. You need to update @pact-foundation/pact

You can do npm ls @pact-foundation/pact-core to see what you have

npm ls @pact-foundation/pact-core

here is the output:
$ npm ls @pact-foundation/pact-core<EMAIL_ADDRESS>C:\markerr-app +--<EMAIL_ADDRESS>| --<EMAIL_ADDRESS>--<EMAIL_ADDRESS>

This illustrates the problem. You need to bump the version of @pact-foundation/pact to the latest (and remove the other pact-core dependency, you don't need to depend on it directly). The latest is 11.0.2, although I believe this was fixed in 11.0.1.
Apologies for not being clear about this the first time.

This illustrates the problem. You need to bump the version of @pact-foundation/pact to the latest (and remove the other pact-core dependency, you don't need to depend on it directly). The latest is 11.0.2, although I believe this was fixed in 11.0.1.
Apologies for not being clear about this the first time.

worked @TimothyJones , thanks a lot for your support, let doc all those steps!


[Fix #3570] avoid if-modifiers on multi-line statements

This implements a Cop to handle multiline if modifiers.
This is my first commit to this project, so I wouldn't mind some extra care before merging ;)
Especially the autocorrect, I've implemented might have some edges I have not foreseen.

Ha! Of course my cop introduced some failures on the rubocop codebase itself. Ideal debugging cases for me. I'm investigating.

I just wonder if this should be a separate cop or part of the existing cop about modifier expressions. @jonas054 @alexdowad Any thoughts?

@bbatsov I don't see any other cop which looks like it overlaps with the intent of this one. IfUnlessModifier is quite different; perhaps it should be given a more descriptive name.
@tessi has some code in there for adjusting the indentation of autocorrected code... I feel like we should have a generic helper method for that somewhere already. Or if we don't, we should.
@tessi Nice work! One thing you still need to do is to squash these commits.

@tessi has some code in there for adjusting the indentation of autocorrected code... I feel like we should have a generic helper method for that somewhere already. Or if we don't, we should.

I am inclined to say that this should be done by another cop (leveraging the inspection loop), or this concern will start to tangle itself into a lot of cops whose primary concerns should be something else. WDYT?

Thanks for your feedback. I'll rebase and squash my commits in a minute.
Regarding the indentation code, I had similar thoughts: First, I assumed some other Cop will take care of indentation -- which is actually the case. Unfortunately, this produced some additional whitespace warnings (when using the auto-correct functionality) -- but those whitespace error were not the users fault (but the fault of my Cop) -- and I felt bad for the user. On top of that, the produced indentation was a little off (the end was not indented properly). The latter could probably be fixed in some whitespace-Cop, the former issue might be harder to fix.
Anyhow, I thought that a cop's autocorrect should produce 'good' code from the start, which is why I decided to implement proper indentation in my Cop.
I assumed there was be a "indent my random piece of code automatically"-helper, but found none. So, I re-used some functions of the AutocorrectAlignment module, which was the closest thing I could find (apparently, implementing indentation has its own pitfalls -- for example that the user can configure the indentation width).
IMO cops should produce 'good' code when auto-correcting (including proper indentation), which is why we should have some helpers to indent code. The question is if those should be written in this PR (I'm willing to try) or not. I'd say it should be done in a later PR and be reviewed separately.

IMO cops should produce 'good' code when auto-correcting (including proper indentation), which is why we should have some helpers to indent code. The question is if those should be written in this PR (I'm willing to try) or not. I'd say it should be done in a later PR and be reviewed separately.

Ideally, yes, but I wouldn't say that's a major issue. Keep in mind that sometimes the proper generated code would be dependent on RuboCop's config.

Ideally, yes, but I wouldn't say that's a major issue. Keep in mind that sometimes the proper generated code would be dependent on RuboCop's config.

That's right. It's probably unfeasible to follow (and maintain) all configs in every cop.
Just to be clear: do you suggest to remove the indentation parts of this PR? If so, I'd remove it and rebase.
Are there any other things I should do before merging?

IMO cops should produce 'good' code when auto-correcting (including proper indentation), which is why we should have some helpers to indent code.

I foresee the helpers would almost immediately become a shortcut to "run all the indentation cops on this code." 😀

Just to be clear: do you suggest to remove the indentation parts of this PR? If so, I'd remove it and rebase.

I guess that's fine.


404

https://www.elastic.co/guide/en/elasticsearch/plugins/master/lang-javascript.html
url 404

This plugin has been removed now.


Database source - mapping with column labels instead of column names

Hi @bjdmeest I am using RML mapper also for transforming in RDF some data included in a mysql database.
I noticed that the mapper does not take column labels but column names. This causes some issues in the case of multilingual tables in multilingual databases. I would suggest using column labels instead (this is possible BTW by R2RML to the best of my knowledge), changing the code as follows
In RDBAccess.java, column names in the result set are retrieved with the getColumnName method of ResultSetMetaData. This does not allow, in the mappings, using "alias" column names that in the SQL queries are defined with as. This also causes issues when the result of a query would produce different columns with the same (unaliased) name.
Using the getColumnLabel method instead of getColumnName would allow using aliased column names and solve the issues reported above.
Currently I am using a local revised version of the mapper with this change but I believe it would be better to include it in the main repo here, if you all agree on the above proposal.

Hi @giorgialodi, thanks for this! On first inspection, this does indeed look like the right way to go (I guess the R2RML spec was a bit unclear in this regard, only using the term 'column name' throughout the spec even though they also rely on column labels, eg https://www.w3.org/2001/sw/rdb2rdf/test-cases/#R2RMLTC0002d).
We'll review this with the team (making sure we don't break anything existing/don't unintentionally diverge from the R2RML spec) and get back to you!

This recommended change was part of the latest release: v4.9.2!
Please let us know in the case you have further related issues


EIP-1167 Clone Factory (#1162)

🚀 Description

Introduced CloneFactory implementation consistent with EIP-1167. Based on example implementation and usage from optionality/clone-factory.

[ +] 📘 I've reviewed the OpenZeppelin Contributor Guidelines
[ +] ✅ I've added tests where applicable to test my new functionality.
[ +] 📖 I've made sure that my contracts are well-documented.
[ +] 🎨 I've run the JS/Solidity linters and fixed any issues (npm run lint:fix).

Hey, let me know if do we need any unit tests which proofs it clone factory is cost efficient.

Hey @nventuro sorry for that, I will double check other tests again and try to stick general style this time.

Hey @nventuro, I've simplified CloneFactory.test.js to use SimpleToken as example. I've left one test case too. I'd like to state with you proper way for this test file. I also stayed with initFactory function but simplified it to be more readable. However I'd like to keep this function as a wrapper that helps to retrieve Truffle contract at clone address and keep this operation capsulated. Let me know your thoughts or ideas. Looking forward to you review! :)

Hi @nventuro, I believe you are busy but could you put any comments here ? As mentioned before I switched to use SimpleToken as example contract in unit test. What is your opinion and acceptable path to follow with this feature? Looking forward to hear your comments here ;)


Crashed when failed to create board images

Creating board image timed out
Creating board image timed out
Creating board image timed out

/media/james.hartig/slack-poker-bot/node_modules/rx/dist/rx.js:579
    throw e;
          ^
TypeError: Cannot call method 'toString' of undefined
    at /media/james.hartig/slack-poker-bot/src/hand-evaluator.js:24:54
    at Array.map (native)
    at Function.evaluateHands (/media/james.hartig/slack-poker-bot/src/hand-evaluator.js:24:37)
    at PotManager.endHandWithShowdown (/media/james.hartig/slack-poker-bot/src/pot-manager.js:184:34)
    at AnonymousObserver._onNext (/media/james.hartig/slack-poker-bot/src/texas-holdem.js:450:27)
    at AnonymousObserver.Rx.AnonymousObserver.AnonymousObserver.next (/media/james.hartig/slack-poker-bot/node_modules/rx/dist/rx.js:1778:12)
    at AnonymousObserver.Rx.internals.AbstractObserver.AbstractObserver.onNext (/media/james.hartig/slack-poker-bot/node_modules/rx/dist/rx.js:1710:35)
    at AnonymousObserver.tryCatcher (/media/james.hartig/slack-poker-bot/node_modules/rx/dist/rx.js:567:29)
    at AutoDetachObserverPrototype.next (/media/james.hartig/slack-poker-bot/node_modules/rx/dist/rx.js:5274:51)
    at AutoDetachObserver.Rx.internals.AbstractObserver.AbstractObserver.onNext (/media/james.hartig/slack-poker-bot/node_modules/rx/dist/rx.js:1710:35)```

I'm getting the same issue. Seems to happen after about 10 hands or so. 2 players only. Was chatting in a separate channel, so only the commands happening in the both's channel.
Welcome to Slack. You are dealer of <snip>
You are in: general
Your open DM's: slackbot, <snip>, <snip>
Creating board image timed out
Creating board image timed out
Creating board image timed out
/sites/slack-poker-bot/node_modules/rx/dist/rx.js:579
    throw e;
          ^
TypeError: Cannot read property 'toString' of undefined
    at /sites/slack-poker-bot/src/hand-evaluator.js:24:53
    at Array.map (native)
    at Function.evaluateHands (/sites/slack-poker-bot/src/hand-evaluator.js:24:37)
    at PotManager.endHandWithShowdown (/sites/slack-poker-bot/src/pot-manager.js:184:34)
    at AnonymousObserver._onNext (/sites/slack-poker-bot/src/texas-holdem.js:450:27)
    at AnonymousObserver.Rx.AnonymousObserver.AnonymousObserver.next (/sites/slack-poker-bot/node_modules/rx/dist/rx.js:1778:12)
    at AnonymousObserver.Rx.internals.AbstractObserver.AbstractObserver.onNext (/sites/slack-poker-bot/node_modules/rx/dist/rx.js:1710:35)
    at AnonymousObserver.tryCatcher (/sites/slack-poker-bot/node_modules/rx/dist/rx.js:567:29)
    at AutoDetachObserverPrototype.next (/sites/slack-poker-bot/node_modules/rx/dist/rx.js:5274:51)
    at AutoDetachObserver.Rx.internals.AbstractObserver.AbstractObserver.onNext (/sites/slack-poker-bot/node_modules/rx/dist/rx.js:1710:35)

Also, the bot was sending messages such as
Your hand is: ,
i.e. no hand
It then put this into the main channel
Dealing the turn:
,,,

dealerBOT [4:12 PM]
Dealing the river:
,,,,

(I also just want to add that this is freaking awesome and thank you so much for putting it together :) )

Had the same problem with Your hand is:  ,  in a room of three players after about 10 hands (other players had the same issue).
And +1 to this is freaking awesome

:sparkling_heart: Thanks for the feedback! I haven't seen this issue yet but I'll fiddle with it tonight. If you're seeing Creating board image timed out a lot it might be a network latency issue; very feasible that there are bugs around this.

Should be fixed with #29.


Some updates to feature/nats-server for streaming.

resolves the current (as of 2019.01.16) merge conflict in feature/nats-server.
fixes a bug where streaming client IDs were being generated with .s in the name. Server was rejecting the client connections & consumers were being blocked. I'm a now able to consume messages off of a stream.

todo

[x] finish up with manual ack pattern.
Just a couple of observations for moving forward:
[x] streaming modules & types could used some docs. I'll let you handle this one, @OtaK.
[x] looks like the streaming_protocol module is private, so accessing the StartPosition variants is not possible. Maybe that is intentional, but it would def be nice to have access to the enum during development.
[x] the MsgProto object (also generated by prost/protobuf)  is in the internal streaming_protocol.rs file and can't be accessed by stream handlers.
[x] also, I see that the derive builder crate is used throughout (in existing code as well). I would recommend using the typed_builder as everything can be verified at compile time. This is super convenient, especially when dealing with futures. We can open another issue for this later.

Going to review it tonight and merge it tomorrow I think! :)
From my quick look, looks like some amazing work! 👍


Remove a dummy domain name set during the deployment

This is to avoid an extra domainname getting attached to the hostname in the powervs systems to keep node entries simple.

@mkumatag is this observed only in a specific region/zone, I see the hostname as the simple VM name in the nodes that I created.
[root@rajalakshmi-workspace /]# hostname
rajalakshmi-workspace
[root@rajalakshmi-workspace /]#

[root@k8s-cluster-master ~]# hostname
k8s-cluster-master
[root@k8s-cluster-master ~]#

@mkumatag is this observed only in a specific region/zone, I see the hostname as the simple VM name in the nodes that I created.
[root@rajalakshmi-workspace /]# hostname
rajalakshmi-workspace
[root@rajalakshmi-workspace /]#

[root@k8s-cluster-master ~]# hostname
k8s-cluster-master
[root@k8s-cluster-master ~]#

I see this behavior at least in the lon04 DC:
[root@rdr-powervs-ipi-helper ~]# hostname
rdr-powervs-ipi-helper.power-iaas.cloud.ibm.com
[root@rdr-powervs-ipi-helper ~]#

@mkumatag is this observed only in a specific region/zone, I see the hostname as the simple VM name in the nodes that I created.
[root@rajalakshmi-workspace /]# hostname
rajalakshmi-workspace
[root@rajalakshmi-workspace /]#

[root@k8s-cluster-master ~]# hostname
k8s-cluster-master
[root@k8s-cluster-master ~]#

I see this behavior at least in the lon04 DC:
[root@rdr-powervs-ipi-helper ~]# hostname
rdr-powervs-ipi-helper.power-iaas.cloud.ibm.com
[root@rdr-powervs-ipi-helper ~]#

yes, I saw it in a VM in upstream-core-lon04 service.
/lgtm


Error 401 uncaught in promise when trying to make a comment on a tournament

Came across this issue when trying to comment on a tournament.

I spoke to @chris-t-li, we thought it might be a JWT token issue. Since I had auto logged in and auto refresh for JWT token was missing, therefore I was getting unauthorized. Logging out and logging back in again did not solve the issue, so I am not sure what the issue might be.

@dovid11564 Can you please expand the error message in the Uncaught promise? What is the data value? {status: 401, data: {...}}?

I havn't actually been able to replicate this. It seems like it might have been JWT or sessions expiring in the end.

@dovid11564 can I close this issue for now? If you can replicate, feel free to create a new issue.


Ticks

The Motivation
Ticks appear in ATXs, as part of the PoET proof. Blocks have "associated ticks" which are the ticks of their associated ATX.
The Requirement
See related issue

Obsolete.


core/extensions/COMServerDemo Server not recognized by Tlbimp or OleView

I have successfully built and executed the core/extensions/COMServerDemo project. The "regsvr32 COMServer.comhost.dll" executed successfully and COMClient.exe ran successfully.
However, "tlbimp COMServer.comhost.dll" produces error: TlbImp : error TI1002 : The input file 'C:\Users\cchessnz\source\DotnetSamples\core\extensions\COMServerDemo\COMServer\bin\x64\Debug\netcoreapp3.1\COMServer.comhost.dll' is not a valid type library.
Similarly, opening it with OleView causes TLB_E_CANTLOADLIBRARY.
I guess the problem is that this DLL does not actually contain a type library at all;  the COMClient is working by extracting GUIDs and interface definitions from the .cs source files that are part of this project. The client doesn't import the DLL.
Is there a way to have the server DLL include the type library, so that it can be deployed for use with general COM clients ? (who will import the type library from the DLL as is normally the case for COM).

I'v got the same problem with PHP, https://www.php.net/manual/en/book.com.php


docs: add a note about installing java dev kit with asdf #trivial

This PR resolves []
Description

Our docs point to the react native docs for android which tell you to install java via brew, but we want it installed via asdf, updating doc to reflect that.
Tangential: these docs are pretty much repeated word for word in energy and are gonna get out of sync. People okay with just linking energies docs here with a note to change eigen values for energy?
#nochangelog
PR Checklist

[ ] I have tested my changes on iOS and Android.
[x] I hid my changes behind a feature flag, or they don't need one.
[x] I have included screenshots or videos, or I have not changed the UI.
[x] I have added tests, or my changes don't require any.
[x] I added an app state migration, or my changes do not require one.
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

Warnings

:warning:

✅ No changelog changes

  Generated by :no_entry_sign: dangerJS against bde44fb402eccdada8963df3509e1345b1dc1349