Fix BuildKit Dockerfile

The BuildKit Dockerfile (used for local development) was broken. Here is a run with the PR on my local machine:
make -f docker.Makefile images                                                                                [19:42:56]
🌟 build docker/kube-compose-dev-controller:latest
[+] Building 62.6s (19/19) FINISHED
 => [internal] load remote build context                                                                                0.0s
 => copy /context /                                                                                0.7s
 => resolve image config for docker.io/docker/dockerfile-upstream:1.0.1-experimental                                                                                1.3s
 => CACHED docker-image://docker.io/docker/dockerfile-upstream:1.0.1-experimental@sha256:2220efe9582e00cd8f6bbee8f4566e34d7f0388c0e10f2b20499cc19ddd140d8                                                                                0.0s
 => CACHED [internal] helper image for file operations                                                                                0.0s
 => [internal] extracting build context                                                                                1.8s
 => [internal] load metadata for docker.io/library/alpine:3.9.4                                                                                0.0s
 => [internal] load metadata for docker.io/library/golang:1.12.5-alpine3.9                                                                                0.0s
 => [build 1/6] FROM docker.io/library/golang:1.12.5-alpine3.9                                                                                0.0s
 => [internal] helper image for file operations                                                                                0.0s
 => [runbase 1/2] FROM docker.io/library/alpine:3.9.4                                                                                0.0s
 => CACHED [build 2/6] RUN apk add --no-cache   coreutils   make   git   curl                                                                                0.0s
 => [build 3/6] COPY . .                                                                                1.4s
 => [build 4/6] RUN --mount=target=/root/.cache,type=cache make bin/compose-controller bin/compose-controller.test e2e-binary bin/installer bin/api-server bin/api-server.test bin/e2e_benchmark                                                                                37.5s
 => [build 5/6] RUN go get github.com/onsi/ginkgo/ginkgo                                                                                12.9s
 => [build 6/6] RUN curl -LO https://storage.googleapis.com/kubernetes-release/release/v1.12.4/bin/linux/amd64/kubectl &&   chmod +x ./kubectl &&   mv ./kubectl /bin/kubectl                                                                                3.1s
 => CACHED [runbase 2/2] RUN apk add ca-certificates --no-cache                                                                                0.0s
 => [stage-8 1/1] COPY --from=build /go/src/github.com/docker/compose-on-kubernetes/bin/compose-controller /compose-controller                                                                                1.8s
 => exporting to image                                                                                0.3s
 => => exporting layers                                                                                0.3s
 => => writing image sha256:a79f27cb58c218dcd4b787f10497eb53c9c7237a849719047a538bc2e9ae6123                                                                                0.0s
 => => naming to docker.io/docker/kube-compose-dev-controller:latest                                                                                0.0s
🌟 build docker/kube-compose-dev-controller-coverage:latest
[+] Building 3.0s (20/20) FINISHED
 => CACHED [internal] load remote build context                                                                                0.0s
 => CACHED copy /context /                                                                                0.0s
 => resolve image config for docker.io/docker/dockerfile-upstream:1.0.1-experimental                                                                                0.7s
 => CACHED docker-image://docker.io/docker/dockerfile-upstream:1.0.1-experimental@sha256:2220efe9582e00cd8f6bbee8f4566e34d7f0388c0e10f2b20499cc19ddd140d8                                                                                0.0s
 => CACHED [internal] helper image for file operations                                                                                0.0s
 => CACHED [internal] extracting build context                                                                                0.0s
 => [internal] load metadata for docker.io/library/golang:1.12.5-alpine3.9                                                                                0.0s
 => [internal] load metadata for docker.io/library/alpine:3.9.4                                                                                0.0s
 => [internal] helper image for file operations                                                                                0.0s
 => [build 1/6] FROM docker.io/library/golang:1.12.5-alpine3.9                                                                                0.0s
 => [runbase 1/2] FROM docker.io/library/alpine:3.9.4                                                                                0.0s
 => CACHED [build 2/6] RUN apk add --no-cache   coreutils   make   git   curl                                                                                0.0s
 => CACHED [build 3/6] COPY . .                                                                                0.0s
 => CACHED [build 4/6] RUN --mount=target=/root/.cache,type=cache make bin/compose-controller bin/compose-controller.test e2e-binary bin/installer bin/api-server bin/api-server.test bin/e2e_benchmark                                                                                0.0s
 => CACHED [build 5/6] RUN go get github.com/onsi/ginkgo/ginkgo                                                                                0.0s
 => CACHED [build 6/6] RUN curl -LO https://storage.googleapis.com/kubernetes-release/release/v1.12.4/bin/linux/amd64/kubectl &&   chmod +x ./kubectl &&   mv ./kubectl /bin/kubectl                                                                                0.0s
 => CACHED [runbase 2/2] RUN apk add ca-certificates --no-cache                                                                                0.0s
 => CACHED [compose-controller-coverage 1/2] ADD e2e/compose-controller-coverage /                                                                                0.0s
 => [compose-controller-coverage 2/2] COPY --from=build /go/src/github.com/docker/compose-on-kubernetes/bin/compose-controller.test /compose-controller.test                                                                                0.8s
 => exporting to image                                                                                0.3s
 => => exporting layers                                                                                0.3s
 => => writing image sha256:cf322a9b08eda37fc4964b4292cd75c1dfdd01de35f953980718bad4af52ed9e                                                                                0.0s
 => => naming to docker.io/docker/kube-compose-dev-controller-coverage:latest                                                                                0.0s
🌟 build docker/kube-compose-dev-e2e-tests:latest
[+] Building 5.5s (23/23) FINISHED
 => CACHED [internal] load remote build context                                                                                0.0s
 => CACHED copy /context /                                                                                0.0s
 => resolve image config for docker.io/docker/dockerfile-upstream:1.0.1-experimental                                                                                0.6s
 => CACHED docker-image://docker.io/docker/dockerfile-upstream:1.0.1-experimental@sha256:2220efe9582e00cd8f6bbee8f4566e34d7f0388c0e10f2b20499cc19ddd140d8                                                                                0.0s
 => CACHED [internal] helper image for file operations                                                                                0.0s
 => CACHED [internal] extracting build context                                                                                0.0s
 => [internal] load metadata for docker.io/library/alpine:3.9.4                                                                                0.0s
 => [internal] load metadata for docker.io/library/golang:1.12.5-alpine3.9                                                                                0.0s
 => [build 1/6] FROM docker.io/library/golang:1.12.5-alpine3.9                                                                                0.0s
 => [internal] helper image for file operations                                                                                0.0s
 => [runbase 1/2] FROM docker.io/library/alpine:3.9.4                                                                                0.0s
 => CACHED [build 2/6] RUN apk add --no-cache   coreutils   make   git   curl                                                                                0.0s
 => CACHED [build 3/6] COPY . .                                                                                0.0s
 => CACHED [build 4/6] RUN --mount=target=/root/.cache,type=cache make bin/compose-controller bin/compose-controller.test e2e-binary bin/installer bin/api-server bin/api-server.test bin/e2e_benchmark                                                                                0.0s
 => CACHED [build 5/6] RUN go get github.com/onsi/ginkgo/ginkgo                                                                                0.0s
 => CACHED [build 6/6] RUN curl -LO https://storage.googleapis.com/kubernetes-release/release/v1.12.4/bin/linux/amd64/kubectl &&   chmod +x ./kubectl &&   mv ./kubectl /bin/kubectl                                                                                0.0s
 => CACHED [runbase 2/2] RUN apk add ca-certificates --no-cache                                                                                0.0s
 => CACHED [compose-e2e-tests 1/5] RUN apk add jq --no-cache                                                                                0.0s
 => CACHED [compose-e2e-tests 2/5] COPY --from=build /go/bin/ginkgo /ginkgo                                                                                0.0s
 => [compose-e2e-tests 3/5] COPY --from=build /go/src/github.com/docker/compose-on-kubernetes/e2e/e2e.test /e2e.test                                                                                0.7s
 => [compose-e2e-tests 4/5] COPY --from=build /go/src/github.com/docker/compose-on-kubernetes/e2e/retrieve-coverage /retrieve-coverage                                                                                0.9s
 => [compose-e2e-tests 5/5] COPY --from=build /bin/kubectl /bin/kubectl                                                                                1.1s
 => exporting to image                                                                                0.5s
 => => exporting layers                                                                                0.5s
 => => writing image sha256:4ccbeda7ab07ea1564f6a86255b1d06932b7d5854e41fc4f68eed9eee99d7423                                                                                0.0s
 => => naming to docker.io/docker/kube-compose-dev-e2e-tests:latest                                                                                0.0s
🌟 build docker/kube-compose-dev-e2e-benchmark:latest
[+] Building 4.0s (20/20) FINISHED
 => CACHED [internal] load remote build context                                                                                0.0s
 => CACHED copy /context /                                                                                0.0s
 => resolve image config for docker.io/docker/dockerfile-upstream:1.0.1-experimental                                                                                0.5s
 => CACHED docker-image://docker.io/docker/dockerfile-upstream:1.0.1-experimental@sha256:2220efe9582e00cd8f6bbee8f4566e34d7f0388c0e10f2b20499cc19ddd140d8                                                                                0.0s
 => CACHED [internal] helper image for file operations                                                                                0.0s
 => CACHED [internal] extracting build context                                                                                0.0s
 => [internal] load metadata for docker.io/library/alpine:3.9.4                                                                                0.0s
 => [internal] load metadata for docker.io/library/golang:1.12.5-alpine3.9                                                                                0.0s
 => [build 1/6] FROM docker.io/library/golang:1.12.5-alpine3.9                                                                                0.0s
 => [internal] helper image for file operations                                                                                0.0s
 => [runbase 1/2] FROM docker.io/library/alpine:3.9.4                                                                                0.0s
 => CACHED [build 2/6] RUN apk add --no-cache   coreutils   make   git   curl                                                                                0.0s
 => CACHED [build 3/6] COPY . .                                                                                0.0s
 => CACHED [build 4/6] RUN --mount=target=/root/.cache,type=cache make bin/compose-controller bin/compose-controller.test e2e-binary bin/installer bin/api-server bin/api-server.test bin/e2e_benchmark                                                                                0.0s
 => CACHED [build 5/6] RUN go get github.com/onsi/ginkgo/ginkgo                                                                                0.0s
 => CACHED [build 6/6] RUN curl -LO https://storage.googleapis.com/kubernetes-release/release/v1.12.4/bin/linux/amd64/kubectl &&   chmod +x ./kubectl &&   mv ./kubectl /bin/kubectl                                                                                0.0s
 => CACHED [runbase 2/2] RUN apk add ca-certificates --no-cache                                                                                0.0s
 => [compose-e2e-benchmark 1/2] COPY --from=build /go/src/github.com/docker/compose-on-kubernetes/bin/e2e_benchmark /e2e_benchmark                                                                                0.6s
 => [compose-e2e-benchmark 2/2] COPY --from=build /bin/kubectl /bin/kubectl                                                                                1.2s
 => exporting to image                                                                                0.4s
 => => exporting layers                                                                                0.4s
 => => writing image sha256:64eec069f535044cee70e66c70d21945731e791d343507f920ebc57900211616                                                                                0.0s
 => => naming to docker.io/docker/kube-compose-dev-e2e-benchmark:latest                                                                                0.0s
🌟 build docker/kube-compose-dev-api-server:latest
[+] Building 3.3s (19/19) FINISHED
 => CACHED [internal] load remote build context                                                                                0.0s
 => CACHED copy /context /                                                                                0.0s
 => resolve image config for docker.io/docker/dockerfile-upstream:1.0.1-experimental                                                                                0.5s
 => CACHED docker-image://docker.io/docker/dockerfile-upstream:1.0.1-experimental@sha256:2220efe9582e00cd8f6bbee8f4566e34d7f0388c0e10f2b20499cc19ddd140d8                                                                                0.0s
 => CACHED [internal] helper image for file operations                                                                                0.0s
 => CACHED [internal] extracting build context                                                                                0.0s
 => [internal] load metadata for docker.io/library/golang:1.12.5-alpine3.9                                                                                0.0s
 => [internal] load metadata for docker.io/library/alpine:3.9.4                                                                                0.0s
 => [internal] helper image for file operations                                                                                0.0s
 => [runbase 1/2] FROM docker.io/library/alpine:3.9.4                                                                                0.0s
 => [build 1/6] FROM docker.io/library/golang:1.12.5-alpine3.9                                                                                0.0s
 => CACHED [build 2/6] RUN apk add --no-cache   coreutils   make   git   curl                                                                                0.0s
 => CACHED [build 3/6] COPY . .                                                                                0.0s
 => CACHED [build 4/6] RUN --mount=target=/root/.cache,type=cache make bin/compose-controller bin/compose-controller.test e2e-binary bin/installer bin/api-server bin/api-server.test bin/e2e_benchmark                                                                                0.0s
 => CACHED [build 5/6] RUN go get github.com/onsi/ginkgo/ginkgo                                                                                0.0s
 => CACHED [build 6/6] RUN curl -LO https://storage.googleapis.com/kubernetes-release/release/v1.12.4/bin/linux/amd64/kubectl &&   chmod +x ./kubectl &&   mv ./kubectl /bin/kubectl                                                                                0.0s
 => CACHED [runbase 2/2] RUN apk add ca-certificates --no-cache                                                                                0.0s
 => [compose-api-server 1/1] COPY --from=build /go/src/github.com/docker/compose-on-kubernetes/bin/api-server /api-server                                                                                0.7s
 => exporting to image                                                                                1.0s
 => => exporting layers                                                                                0.9s
 => => writing image sha256:b66f263a342281712c20307333b4384bfecb9e940a5e1ea7860d56cddbfd2b9e                                                                                0.0s
 => => naming to docker.io/docker/kube-compose-dev-api-server:latest                                                                                0.0s
🌟 build docker/kube-compose-dev-api-server-coverage:latest
[+] Building 3.5s (20/20) FINISHED
 => CACHED [internal] load remote build context                                                                                0.0s
 => CACHED copy /context /                                                                                0.0s
 => resolve image config for docker.io/docker/dockerfile-upstream:1.0.1-experimental                                                                                0.5s
 => CACHED docker-image://docker.io/docker/dockerfile-upstream:1.0.1-experimental@sha256:2220efe9582e00cd8f6bbee8f4566e34d7f0388c0e10f2b20499cc19ddd140d8                                                                                0.0s
 => CACHED [internal] helper image for file operations                                                                                0.0s
 => CACHED [internal] extracting build context                                                                                0.0s
 => [internal] load metadata for docker.io/library/alpine:3.9.4                                                                                0.0s
 => [internal] load metadata for docker.io/library/golang:1.12.5-alpine3.9                                                                                0.0s
 => [build 1/6] FROM docker.io/library/golang:1.12.5-alpine3.9                                                                                0.0s
 => [internal] helper image for file operations                                                                                0.0s
 => [runbase 1/2] FROM docker.io/library/alpine:3.9.4                                                                                0.0s
 => CACHED [runbase 2/2] RUN apk add ca-certificates --no-cache                                                                                0.0s
 => CACHED [build 2/6] RUN apk add --no-cache   coreutils   make   git   curl                                                                                0.0s
 => CACHED [build 3/6] COPY . .                                                                                0.0s
 => CACHED [build 4/6] RUN --mount=target=/root/.cache,type=cache make bin/compose-controller bin/compose-controller.test e2e-binary bin/installer bin/api-server bin/api-server.test bin/e2e_benchmark                                                                                0.0s
 => CACHED [build 5/6] RUN go get github.com/onsi/ginkgo/ginkgo                                                                                0.0s
 => CACHED [build 6/6] RUN curl -LO https://storage.googleapis.com/kubernetes-release/release/v1.12.4/bin/linux/amd64/kubectl &&   chmod +x ./kubectl &&   mv ./kubectl /bin/kubectl                                                                                0.0s
 => [compose-api-server-coverage 1/2] ADD e2e/api-server-coverage /                                                                                0.7s
 => [compose-api-server-coverage 2/2] COPY --from=build /go/src/github.com/docker/compose-on-kubernetes/bin/api-server.test /api-server.test                                                                                1.1s
 => exporting to image                                                                                0.3s
 => => exporting layers                                                                                0.3s
 => => writing image sha256:b15520586b499a9a746d127a21ae0a235523233ebb57a0c0433730b5c11ae73e                                                                                0.0s
 => => naming to docker.io/docker/kube-compose-dev-api-server-coverage:latest                                                                                0.0s
🌟 build docker/kube-compose-dev-installer:latest
[+] Building 2.8s (19/19) FINISHED
 => CACHED [internal] load remote build context                                                                                0.0s
 => CACHED copy /context /                                                                                0.0s
 => resolve image config for docker.io/docker/dockerfile-upstream:1.0.1-experimental                                                                                0.5s
 => CACHED docker-image://docker.io/docker/dockerfile-upstream:1.0.1-experimental@sha256:2220efe9582e00cd8f6bbee8f4566e34d7f0388c0e10f2b20499cc19ddd140d8                                                                                0.0s
 => CACHED [internal] helper image for file operations                                                                                0.0s
 => CACHED [internal] extracting build context                                                                                0.0s
 => [internal] load metadata for docker.io/library/golang:1.12.5-alpine3.9                                                                                0.0s
 => [internal] load metadata for docker.io/library/alpine:3.9.4                                                                                0.0s
 => [build 1/6] FROM docker.io/library/golang:1.12.5-alpine3.9                                                                                0.0s
 => [internal] helper image for file operations                                                                                0.0s
 => [runbase 1/2] FROM docker.io/library/alpine:3.9.4                                                                                0.0s
 => CACHED [build 2/6] RUN apk add --no-cache   coreutils   make   git   curl                                                                                0.0s
 => CACHED [build 3/6] COPY . .                                                                                0.0s
 => CACHED [build 4/6] RUN --mount=target=/root/.cache,type=cache make bin/compose-controller bin/compose-controller.test e2e-binary bin/installer bin/api-server bin/api-server.test bin/e2e_benchmark                                                                                0.0s
 => CACHED [build 5/6] RUN go get github.com/onsi/ginkgo/ginkgo                                                                                0.0s
 => CACHED [build 6/6] RUN curl -LO https://storage.googleapis.com/kubernetes-release/release/v1.12.4/bin/linux/amd64/kubectl &&   chmod +x ./kubectl &&   mv ./kubectl /bin/kubectl                                                                                0.0s
 => CACHED [runbase 2/2] RUN apk add ca-certificates --no-cache                                                                                0.0s
 => [compose-installer 1/1] COPY --from=build /go/src/github.com/docker/compose-on-kubernetes/bin/installer /installer                                                                                0.8s
 => exporting to image                                                                                0.2s
 => => exporting layers                                                                                0.2s
 => => writing image sha256:441fc7b97ca96acb958e90d5889e3f1841a9504c60875b09a4e403badce461bb                                                                                0.0s
 => => naming to docker.io/docker/kube-compose-dev-installer:latest                                                                                0.0s
docker/kube-compose-dev-controller docker/kube-compose-dev-controller-coverage docker/kube-compose-dev-e2e-tests docker/kube-compose-dev-e2e-benchmark docker/kube-compose-dev-api-server docker/kube-compose-dev-api-server-coverage docker/kube-compose-dev-installer

Codecov Report

Merging #112 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #112      +/-   ##
==========================================
- Coverage   64.73%   64.65%   -0.08%
==========================================
  Files          90       90
  Lines       10933    10933
==========================================
- Hits         7077     7069       -8
- Misses       3552     3563      +11
+ Partials      304      301       -3

Impacted Files
Coverage Δ

internal/controller/resourceupdater.go
44.44% <0%> (-5.56%)
:arrow_down:

internal/convert/pod.go
87.55% <0%> (-0.96%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 093fa44...ec2bd5b. Read the comment docs.


Turning on animated physics bone on Skeleton3D is very performance intensive.

Godot version
4.0.3
System information
Windows 10
Issue description
In skeleton 3d nade if we turn on animat physics bones option the editor starts to lagg a lot ( like fps drops 10 to 15 frames i think) but the editor says fps is 150 or higher.
Even with simple ragdoll if i can't use 2 or 3  ragdoll, if i do editor crashes.
There is definately a problem in godot 4.0 godot 3 runs fine.
Steps to reproduce
Create a ragdoll.
Minimal reproduction project
Amimated physics bone.zip

Please add an MRP with your skeleton / ragdoll.
I am creating a ragdoll right now and have none of those performance issues you describe.
Do you have errors from your skeleton? Cause error log / print can do that.

it seems to be the case on my duel core amd a6 processor. if you still didn't face the same issue you can duplicate it few time.
it crashed when i did it 3 times.

https://user-images.githubusercontent.com/132071423/236657468-294074d7-48a9-4b91-9789-6aa812507f62.mp4

https://user-images.githubusercontent.com/132071423/236658619-ba7b01f0-fbdc-4604-bea9-7d9e58e6e45d.mp4

Since so far no one could reproduce this issue you could pick or build one of the recent Godot builds with debug symbols and start Godot in a console to see what actually triggers your crash and print that crash log here.

Closing due to lack of response, if you provide the requested information this can be reopened


Does not appear to respect Environment Variables

Image does not seem to respect the NGROK_AUTH nor the NGROK_SUBDOMAIN environment variables.
$ docker -v
Docker version 1.12.0-rc2, build 906eacd, experimental

$ docker images | grep ngrok
wernight/ngrok      latest              82fbe5dda839        6 days ago          23.73 MB

$ cat environment.list
NGROK_AUTH=AuthTokenAsAppearsInDashBoard
NGROK_SUBDOMAIN=custom-subdomain
NGROK_PROTOCOL=HTTP

$ docker run -it --env-file ./environment.list --rm wernight/ngrok env
PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
HOSTNAME=moby
TERM=xterm
NGROK_AUTH=AuthTokenAsAppearsInDashBoard
NGROK_SUBDOMAIN=custom-subdomain
NGROK_PROTOCOL=HTTP
no_proxy=*.local, 169.254/16
HOME=/home/ngrok

$ docker run -it --env-file ./environment.list -p 4040:4040 --net=host --rm wernight/ngrok ngrok http 1234

...initiates without a custom domain.

$ docker run -it --env-file ./environment.list -p 4040:4040 --net=host --rm wernight/ngrok ngrok http --subdomain=custom-domain 3000

Tunnel session failed: Only paid plans may bind custom subdomains.
Failed to bind the custom subdomain 'heroes-messageboard' for an unauthenticated client.
Sign up at: https://ngrok.com/signup

If you have already signed up, make sure your authtoken is installed.
Your authtoken is available on your dashboard: https://dashboard.ngrok.com

ERR_NGROK_305

I don't have a valid token to fully test this but entrypoint.sh should be using those.
Can you build the command-line manually and see if it helps:
 docker run -it --net=host --rm wernight/ngrok -authtoken=AuthTokenAsAppearsInDashBoard -subdomain=custom-subdomain -log stdout

Oh please do a docker pull first and I've changed the entrypoint to be like most Docker images.

Works, but more importantly, I was not respecting the syntax of entrypoint.sh
#usererror


How to import files to the build directory

I want to import a folder containing images to the build directory.
I dont want to import the files one by one on a js file.
Should I copy the folder through webpack or through express ?

Hi,
This copy-webpack-plugin might interest you.


fix Dynamic type

Summary
Currently, Dynamic can't infer props from component and will fail to type check them
<Dynamic component="a" href={2} />

This PR tries to fix this with Expand
I also didn't format with prettier as I'm not sure it's intentional
trailing comma here, (might help with git diff probably)
https://github.com/solidjs/solid/blob/dcfd8ceeedb3e5d98e548a83cf2063c16b18926a/packages/solid/web/src/index.ts#L15
but not here
https://github.com/solidjs/solid/blob/dcfd8ceeedb3e5d98e548a83cf2063c16b18926a/packages/solid/web/src/index.ts#L29
missing semi
https://github.com/solidjs/solid/blob/dcfd8ceeedb3e5d98e548a83cf2063c16b18926a/packages/solid/web/src/index.ts#L115

While I can't claim to understand exactly how this works, I can confirm it did resolve the issues I was seeing.  With this change in place, Typescript does correctly complain if the props don't match the component passed to

type DynamicProps<T extends ValidComponent, P = ComponentProps<T>> = { [K in keyof P]: P[K] } & {
  component: T | undefined;
};

I'm thinking if inline is better as it doesn't introduce a new type and DynamicProps is also not exported (currently).

Actually the problem is
https://github.com/solidjs/solid/blob/dcfd8ceeedb3e5d98e548a83cf2063c16b18926a/packages/solid/src/render/component.ts#L70

But I believe Component<any> is necessary so that ValidComponent can accept any kind of component e.g Component<SomeInterface>. And the current fix seems to work and no tests failed (locally). I think this can be merged.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 88.997%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1261

Relevant Lines:
1346

💛  - Coveralls

Thank you


[Bug]: Cycle detected when a Datasource references a JSObject returning a Table widget

Is there an existing issue for this?

[X] I have searched the existing issues

Description
I can bind  a GET API request Binance header or parameter to a table property like {{ Table1.sortOrder.column }}. However if I declare a JS object JSObject1 like
export default {
	getTable: () => {
		return Table1
	}
}

and bind the parameter like {{JSObject1.getTable().sortOrder.column }} an error appears:
Cyclical dependency error encountered while parsing relationship [Binance.data : Table1.tableData] where the relationship is denoted as (source : target).

There are workarounds but the code could be simpler if we could use JS methods in API query parameters, particularly useful for building complex query strings.
Steps To Reproduce

Create any API request (example: https://data.binance.com/api/v3/ticker/24hr)
Create a Table Table1
Bind Table1 to the API Request
Create a JS object with the function described above
Add one parameter to the API Request and set the value as  {{JSObject1.getTable().sortOrder.column }}

Public Sample App
No response
Issue video log
No response
Version
appsmith-ce:v1.8.12

@osangenis I agree that JSObject functions are useful for building complex query strings. Returning a cyclic reference to the Table object could be a bad idea. I would suggest running the API using a param instead. Let me know if this works:
JSObject:
export default {
    runApi: (keyword, order) => {
        let queryString = `sortColumn=${Table1.sortOrder.column}&sortOrder=${order}&limit=50&term=${keyword}`
        Api1.run({query: queryString})
    }
}

API:
https://data.binance.com/api/v3/ticker/24hr?query={{this.params.query}}

@bharath31 shouldn't this work since without this pagination wouldn't be possible?

@Druthi could you please run an RCA here?

@morandalex @abeatbeyondlab we'll look into this but the occurrence of this seems fairly rare. You can easily get around fixing this by changing the way you are accessing the code and we'll be happy to suggest changes to your code to unblock you.


[EOSF-716] Update deps, fixes for latest ember-osf

Had to update some dependencies and skip tests to make it work with the latest ember-osf updates
Ticket
https://openscience.atlassian.net/browse/EOSF-716
Purpose
Make preprints work with the latest ember-osf
Changes
Dependency Updates, all developer-facing changes.
Side effects

Notes for QA
Normal regression only, just updating dependencies to get preprints tests working again

Resolved


fix(button): only show focus indicator for keyboard

No longer shows the focus indicator when the button is focused through program. This behavior should be similar across components like slide-toggle, checkbox, radio etc.

Fixes #8420

@crisbeto is this undoing a change you made intentionally. I seem to remember a PR where you changed something like this


chore: bdd-sbhg-1590246227 to 0.0.1

chore: Promote bdd-sbhg-1590246227 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


[Question] - How to cross-build  openssl for ios (arm64 & x86_64) & ios-sim (arm64) on Mac M1?

How to cross-build  openssl for ios (arm64 & x86_64) & ios-sim (arm64) on Mac M1?

aarch64-apple-ios
aarch64-apple-ios-sim
x86_64-apple-ios

Essentially, I am looking to get the libcrypto and libssl  (the binary *.a and the include headers) for the above targets?

I tried the following command:
./Configure iossimulator-xcrun "-arch arm64 -fembed-bitcode" no-asm no-shared no-hw no-async
make

Error:
xcrun -sdk iphonesimulator cc -fPIC  -O3 -arch arm64 -fembed-bitcode -L. -bundle -Wl,-search_paths_first -L/opt/homebrew/opt/llvm/lib \
		-o providers/legacy.dylib \
		providers/legacy-dso-legacyprov.o \
		providers/liblegacy.a providers/libcommon.a -lcrypto
ld: -bundle and -bitcode_bundle (Xcode setting ENABLE_BITCODE=YES) cannot be used together
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[1]: *** [providers/legacy.dylib] Error 1
make: *** [build_sw] Error 2

I assume this is for Kotlin Multiplatform.
The kotlin multiplatform iosX64 target is actually building against iPhoneSimulator{version}.sdk. The only supported architecture for iPhoneOS{version}.sdk is arm64. imo, the kmp target should be named iosSimulatorX64 to match iosSimulatorArm64.
Regardless, I'm using the iossimulator-xcrun configuration target and then specifying either -arch arm64 or -arch x86_64.

Regarding the -fembed-bitcode flag, I am simply changing the darwin-shared configuration from -bundle to -dynamic
https://github.com/openssl/openssl/blob/d59c3febdc5f737bd88086b4c3d40d62238be530/Configurations/shared-info.pl#L50


Add AttributeListValue

This will allows us to set up some of attributes (of the different
models) as Lists of AttributeValue objects.
In addition, add Argument class that will be used by different
attributes of the models, to expose their arguments.

@cescgina thanks for the review! submitted the fixes