Add support for advertising additional routes

Summary
Implement environment variable OBSERVER_ADDITIONAL_ROUTES which can be used to configure additional routes (accepted values: bare IP addresses or prefixes) which are configured as advertised routes on the Tailscale client.
If bare IP addresses are provided, the corresponding /32 (or /128 for IPv6) is configured as the route.
Checklist

[x] Categorize the PR by setting a good title and adding one of the labels:
bug, enhancement, documentation, change, breaking, dependency
as they show up in the changelog
[x] Update tests.

Very cool! :partying_face:


Feature/landing page edits

added a .gitignore

I cannot merge this due to the .DS_Store files that were included in the push but weren't caught by a .gitignore file


osutil: release exit lock after resending terminating signal

The go runtime won't always reinstall the default signal handler on the
SIGTERM path, so it's possible the signal won't terminate the process.
Instead, permit etcd to exit normally after processing a signal.

Codecov Report

Merging #7904 into master will decrease coverage by 0.39%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #7904     +/-   ##
=========================================
- Coverage   76.08%   75.68%   -0.4%
=========================================
  Files         336      337      +1
  Lines       26395    26400      +5
=========================================
- Hits        20083    19982    -101
- Misses       4898     4981     +83
- Partials     1414     1437     +23

Impacted Files
Coverage Δ

pkg/osutil/interrupt_unix.go
92.3% <100%> (+0.3%)
:arrow_up:

pkg/osutil/signal_linux.go
100% <100%> (ø)

proxy/grpcproxy/register.go
69.44% <0%> (-25%)
:arrow_down:

pkg/transport/timeout_conn.go
80% <0%> (-20%)
:arrow_down:

pkg/transport/listener_tls.go
73.91% <0%> (-8.7%)
:arrow_down:

etcdserver/api/v3rpc/lease.go
92.85% <0%> (-7.15%)
:arrow_down:

pkg/adt/interval_tree.go
86.28% <0%> (-6.41%)
:arrow_down:

mvcc/watchable_store.go
81% <0%> (-5.43%)
:arrow_down:

etcdserver/api/v3rpc/watch.go
89.63% <0%> (-4.67%)
:arrow_down:

proxy/grpcproxy/watcher.go
89.58% <0%> (-4.17%)
:arrow_down:

... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f337754...2c0fe9a. Read the comment docs.

lgtm

lgtm. Let's merge before rc release? Thanks!


[Platform] Move model arch check to platform

Part of #11162

Oh, thanks for pointing that. I previously named it verify_madel_arch, but after changing the name, I forgot to modify it here.
Then I will unify this method as verify_madel_arch in the next commit.
---- Replied Message ----
| From | Cyrus @.> |
| Date | 12/26/2024 21:01 |
| To | @.> |
| Cc | Mengqing<EMAIL_ADDRESS>|
| Subject | Re: [vllm-project/vllm] [Platform] Move model arch check to platform (PR #11503) |
@DarkLight1337 commented on this pull request.
In vllm/platforms/rocm.py:

@@ -102,6 +127,18 @@ def check_and_update_config(cls, vllm_config: VllmConfig) -> None:
else:
parallel_config.worker_cls = "vllm.worker.worker.Worker"

@classmethod
def verify_model_arch(cls, model_arch: str) -> None:

(Though personally I prefer verify_model_arch as the method name.)
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>


da.where does not work as expected

What happened: Using da.where on a mask of two dask arrays returned no matches but using np.where on the computation of the mask returned matches.
What you expected to happen: The result of da.where and np.where to be the same.
Minimal Complete Verifiable Example:
from dask import array as da
import numpy as np

a = da.array((0,1,2,3,4))
b = da.array((5,6,7,8,9))

mask = (a == 0) & (b == 5)

# These should return the same result.
print(da.where(mask))
print(np.where(mask.compute()))

Environment:

Dask version: 2022.04.0
Python version: 3.9.10
Operating System: macOS 12.3.1
Install method (conda, pip, source): conda

@johncoxon Welcome to Dask! I'm not able to reproduce this, could you please share the outputs you're seeing?
da.where evaluates lazily, so we see a dask.array, but calling compute gives the same result:
da.where(mask)
# Output: (dask.array<getitem, shape=(nan,), dtype=int64, chunksize=(nan,), chunktype=numpy.ndarray>,)

dask.compute(*da.where(mask))
# Output: (array([0]),)

np.where(mask.compute())
# Output: (array([0]),)

Ahhh, the docs for da.where don't say that it evaluates lazily, so I was expecting it to behave the same as np.where – it might be worth updating the documentation to make that clear?

Thanks for your response!


Strange behaviour when executing seekAndCenter(1) twice

Hello everybody,
I'm facing a strange issue with the seekAndCenter function. I have this javascript function:
$scope.mySeekAndCenter = function (par) {
console.log("initial duration: " + $scope.wavesurfer.getDuration());
$scope.wavesurfer.seekTo(par);
console.log("new position: " + $scope.wavesurfer.getDuration());
console.log("new duration: " + $scope.wavesurfer.getDuration());
}
and I'm playing a file lasting 225.684 s (duration confirmed by ffprobe).
If I run mySeekAndCenter(1) the player position correctly goes to the end of the file. The duration calculated after executing seekAndCenter is still correct. Console log prints
initial duration: 225.684
new position: 225.684
new duration: 225.684
If I suddently run mySeekAndCenter(1) again (without doing anything else in the while) the duration has changed to 225.98316.
initial duration: 225.98316
new position: 225.98316
new duration: 225.98316
Have anyone experienced duration changes while the player is running? I first calculate the duration when the 'ready' event is fired by the player and it matches the one calculated before executing the seekAndCenter function for the first time (225.684 s).
The same behaviuor is exeprienced by using the seekTo function.
Can anyone help me?
Thanks,
Laura

what browser/operating system, version of wavesurfer.js?

Hi!
I'm using wavesurfer version 3.0.
The test browser is Google Chrome running on Windows 10.
Laura

Hi!
Are there any updates about this issue?

Seems related to https://github.com/katspaugh/wavesurfer.js/issues/1485

Today I made some more tests. The problem seems related to preloaded peaks. My mp3 files are generated from a wave file using the following ffmpeg parameters: -acodec libmp3lame -ab 64k -ar 32k.
Preloaded peaks are generated using audiowaveform with the following parameters: --pixels-per-second 25 -b 16.


Use more suitable phrase for sort list

Questions
Answers

Description?
Select isn't the best term when it comes to choosing from the list.

Type?
improvement

BC breaks?
no

Deprecations?
no

Fixed ticket?
no need

How to test?
-

Possible impacts?
-

I approved and merged. We have the translation for other languages, and the previous phrase was too ambiguous in Polish and some other languages.

Thanks @SharakPL


[MINOR] Update report_coverage.sh

Tips

Thank you very much for contributing to Apache Hudi.
Please review https://hudi.apache.org/contributing.html before opening a pull request.

What is the purpose of the pull request
(For example: This pull request adds quick-start document.)
Brief change log
(for example:)

Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end.
Added HoodieClientWriteTest to verify the change.
Manually verified the change by running a job locally.

Committer checklist

[ ] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@yanghua please take a look when free

Codecov Report

Merging #2396 (8e96d16) into master (c6bf952) will decrease coverage by 42.17%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             master    #2396       +/-   ##
=============================================
- Coverage     52.21%   10.04%   -42.18%
+ Complexity     2662       48     -2614
=============================================
  Files           335       52      -283
  Lines         14983     1852    -13131
  Branches       1506      223     -1283
=============================================
- Hits           7824      186     -7638
+ Misses         6535     1653     -4882
+ Partials        624       13      -611

Flag
Coverage Δ
Complexity Δ

hudicli
?
?

hudiclient
100.00% <ø> (ø)
0.00 <ø> (ø)

hudicommon
?
?

hudihadoopmr
?
?

huditimelineservice
?
?

hudiutilities
10.04% <ø> (-59.62%)
0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Remove deprecated std.concurrency.MessageBox.isClosed() const.

Within Phobos, this appears to be the only occurrence of synchronizing on an immutable object. Removal of this deprecated function allows us to resolve Issue 14251. The removal is needed for DMD PR https://github.com/D-Programming-Language/dmd/pull/5564 .
Ping @yebblies and @MartinNowak because you have marked this method as deprecated.

LGTM

Auto-merge toggled on


trying to send message larger than max

hi everybody
I want to call service function with request size about 10mb
so I got error "trying to send message larger than max (9840536 vs. 4194304)"
how to fix that ?

ohh I got it
in client:
c := client.DefaultClient
c.Init(grpc.MaxSendMsgSize(10 * 1024 * 1024))
in server:
service.Server().Init(grpc.MaxMsgSize(10 * 1024 * 1024))


GPS driver keeps publishing even when GPS isn't connected

When no GPS is connected, the driver still keeps spamming the topic with empty messages. Driver in Ashtech mode when this occurs.
Running a UAVCAN-interfaced GPS in parallel then causes weird issues.
@kd0aij Also brought this up.

Indeed, we need to fix that. I don't recall why this would be necessary.

@Zefz I think you introduced this, but I don't recall what the use case was.

@LorenzMeier My GPS check only runs if you have the circuit breaker is disabled (CBRK_GPSFAIL). It is on by default so unless you explicitly requested it, the Preflight GPS check will not run.
My preflight check is here: https://github.com/PX4/Firmware/blob/master/src/modules/commander/PreflightCheck.cpp#L277-L305
This is not the same as messages coming from the GPS driver as @mhkabir is mentioning?
@LorenzMeier Use case: Detect faulty GPS wiring, broken GPS receiver or GPS receivers that are placed too close to the RC receiver (which will kill all reception because of the noise). Without this check the system does not report anything wrong - it will simply never get a fix :)

Its the ashtech driver which returns success for no reason:
https://github.com/PX4/Firmware/blob/master/src/drivers/gps/ashtech.cpp#L647-L661

Closed in d9f0baf on beta.


Add feature to click an issue to have it open the corresponding browser page

Looked into this --> won't be possible without explicitly adding a URL.
There is some support for hyperlinks here: https://gist.github.com/egmontkob/eb114294efbcd5adb1944c9f3cb5feda
But support is limited to only a couple new terminals...


TSA may not respect --bind-port

We had a report in Slack where TSA failed to register a worker when --bind-port had been specified (and ATC was respecting it).

I think this is fine; you need to set --peer-url, which the TSA should then pick up. That flag needs to be set anyway if you set a different port.


[WIP] Configuring packs via datastore

This is a first iteration of the larger story which will allows users  to configure packs via the datastore. It introduces some basic concepts such as config schema (right now it's inferred from the existing config.yaml so it has limitations, especially when multiple levels of object nesting are used inside the config, but that's an anti-pattern anyway) and pack configuration via the datastore.
The main goal of allowing users to configure packs via the datastore is improving our infrastructure as code story around the packs. With this approach, users won't need to edit any files directly inside the pack (eventually we will deprecate config.yaml). This will make it easier for the packs to be version controlled, updated, etc.
TODO

[x] Integration test for running a Python runner action which utilizes some config values from the datastore
[ ] Documentation
[ ] API for managing configuration (get, set, delete)
[ ] CLI commands for managing config values in the datastore (those command will know how to encode the key name, serialize the value, etc.). Keep in mind that this tool will only be provide for the user convenience (it's kinda like packs.install - meant for quick testing, but not a good fit for production deployments). For real life production infrastructure as code deployments, users will be encouraged to manipulate values locally in a JSON file, version control this file and then load this whole JSON file on the servers on deploy. This is the similar to what others (including me) did in the past with the (encrypted) Chef data bags. Chef provides CLI command for locally manipulating databag values. Users use this command to manipulate the version controlled JSON file locally and then deploy it to the servers as part of the deployments process (as opposed to directly manipulating datastore on the servers - this is a bad practice from the infrastructure as code perspective - it's not version controlled, no audit trail, not treated as code, etc.)

Version 2
Second iteration will build on those two existing primitives and introduce two new concepts described below.
Config schema (config.schema.yaml or similar)
User will be able to specify a schema for the config. This schema will be used (and validated against) when populating / loading config values in the datastore.
You can find an example of the proposed schema here - https://gist.github.com/Kami/72e67c6462fb8d2144c0ac0ad7dc9d8b. As you can see, it can get complex quite fast so we should encourage pack authors to use flat config schemas and layouts (e.g. user_api_key vs user.api_key).
Config template (name TBD, suggestions welcome)
Config templates will allow users to specify Jinja expressions for the config key values. Those expressions will be evaluated and used for the key name when retrieving config value from the datastore.
This feature will add more flexibility and allow users to do things such as use different config value depending on the context (e.g. different config based on the user who requested the action execution etc.).
Templates will probably look something like this:
api_key: "system.configs.{{pack}}.api_key.{{api_user}}"
region: "system.pack_configs.{{pack}}.region"

The goal is for those files to be version controlled and stored somewhere outside the pack directory. This will probably be /opt/stackstorm/configs/ (e.g. /opt/stackstorm/configs/<pack name>.yaml), but subject to change and suggestions :)

Closing in favor of #2708.


use AB::MB for configure_requires

This will ensure that Alien::Base::ModuleBuild is (correctly) specified as configure_requires instead of Alien::Base.  For the rationale for this change, please see https://github.com/Perl5-Alien/Alien-Base/issues/157

When you get a chance, can you please do a release to CPAN?

Sorry about that, I put out a dev release, but forgot to follow up after that.  Just uploaded a new version.

np.  Thanks!


Gateway fallback not working

This is an awesome project, I like! ;-)
Gateway fallback is not working for me at all (and I'd really like it to!).
Here is my simple yml config:
hosts:

    hosta:
        HostName: example.org
        User: admin

    hostb:
        HostName: <IP_ADDRESS>
        User: pi
        Gateways: [ direct, hosta ]

ssh to hosta works fine, however when I ssh to hostb which I expect to first try to connect directly to <IP_ADDRESS> and then via hosta on failure I get the following:
DEBU[0000] assh args: [hostb]
DEBU[0000] Loading config file '~/.ssh/assh.yml'
DEBU[0000] Loaded config file '~/.ssh/assh.yml' (0 + 2 => 2 hosts)
DEBU[0000] getHostByName direct matching: "hostb"
INFO[0000] Host hostb
INFO[0000]   Port 22
INFO[0000]   User pi
INFO[0000]   # HostName: <IP_ADDRESS>
DEBU[0000] Host: {"Port":"22","User":"pi","HostName":"<IP_ADDRESS>","Gateways":["direct","hosta"],"Hooks":{}}
DEBU[0000] Proxying
DEBU[0000] Trying gateways: [direct hosta]
DEBU[0000] Preparing host object
DEBU[0000] Calling BeforeConnect hooks
DEBU[0000] Connecting to <IP_ADDRESS>:22
INFO[0000]   # Gateways: [direct, hosta]
Connection timed out during banner exchange

Output of "assh info":
Debug mode (client): false
CLI Path: /usr/local/bin/assh
Go version: go1.10.3
OS/Arch: linux/amd64

RC files:
- ~/.ssh/assh.yml

Statistics:
- 2 hosts
- 0 templates
- 1 included files

This is v2.8.0 (not found in assh info output) running on Fedora 28.
Can someone please tell me what I am doing wrong?
I am trying to achieve the example of hostd from here: https://github.com/moul/advanced-ssh-config#using-gateways-from-configuration-file
Thank you!

Hi @e3eli3h, can you:

rebuild assh
add a GatewayConnectTimeout: 2 in hostb
give a new try?

Using 2.8.0+dev (HEAD)
DEBU[0000] getHostByName direct matching: "hostb"
INFO[0000] Host hostb
INFO[0000]   Port 22
INFO[0000]   User pi
INFO[0000]   # HostName: <IP_ADDRESS>
INFO[0000]   # Gateways: [direct, hosta]
INFO[0000]   # GatewayConnectTimeout: 2
DEBU[0000] Host: {"Port":"22","User":"pi","HostName":"<IP_ADDRESS>","Gateways":["direct","hosta"],"Hooks":{},"GatewayConnectTimeout":2}
DEBU[0000] Proxying
DEBU[0000] Trying gateways: [direct hosta]
2018/09/06 15:29:43 direct
DEBU[0000] Preparing host object
DEBU[0000] Calling BeforeConnect hooks
DEBU[0000] Connecting to <IP_ADDRESS>:22
Connection timed out during banner exchange

I can't reproduce this issue on my host, from what I read, it's an ssh generated message (not an assh one), maybe you have a global ConnectTimeout configured somewhere in your /etc directory?
You should also be able to ocnfigure it directly from assh:
hosts:

    hosta:
        HostName: example.org
        User: admin

    hostb:
        HostName: <IP_ADDRESS>
        User: pi
        Gateways: [ direct, hosta ]

    defaults:
        GatewayConnectionTimeout: 2 # assh gateway connect timeout
        ConnectTimeout: 20          # ssh connect timeout

Hi @moul,
You are totally correct that I had a ConnectTimeout set in a file under my /etc/ssh/ssh_config.d
Removing the entry altogether made everything spring to life.
Trouble is... I don't understand why this would have affected any and all settings I declare in my assh.yml file, including the defaults.
Sorry for the trouble and thanks for the help.
I can now begin creating the config I need.

@moul, btw, only the new dev build works.
The static build does not given what I have said in my previous post.

Can I give you more feedback if it will help this project?
For instance, GatewayConnectTimeout does not work when placed in defaults.
It is only working inside a host definition.

Well it seems that my defaults were not being applied at all due my own stupidity and wrong yml indentation.
Please make it possible to add GatewayConnectTimeout to defaults as this is ignored at present.

Hi @e3eli3h,
GatewayConnectTimeout is inherited from defaults as soon as the current host does not have a GatewayConnectTimeout set, or if it is set as 0
Closing this issue as I can't reproduce it
But feel free to reopen it or reopen a new one if you still have problems


Add more flake8 plugins for testing

Codecov Report

Merging #32 (5d979e5) into master (eb3322f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #32   +/-   ##
=======================================
  Coverage   92.85%   92.85%
=======================================
  Files           2        2
  Lines          28       28
  Branches        4        4
=======================================
  Hits           26       26
  Misses          1        1
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb3322f...5d979e5. Read the comment docs.


SUPPORT

I do not understand how to configure, there is a video how to configure it?

What part of the config is confusing? Most of it is commented on what the config nodes do. We don't currently have a video on how to configure it, but we might work on one in the future.
I would be happy to help you with your configuration if you tell me which part of it is difficult to understand so we can also make it easier for everyone else to understand it aswell.

I can’t understand part 4, 5, 6 of the settings, I generated the code, then I created the authorized_keys file, and my nickname, after rebooting, didn’t do anything in the console, but I didn’t understand part 5, 6.

The contents of the file named your ssh username is the contents of puttygen's Public key for pasting into OpenSSH authorized_keys file. Effectively this is your public key just named as your username.
For example: If you want to login to the console with<EMAIL_ADDRESS>then you would create a new file in the authorized_users directory named exactly Erensisman09 and it would contain the key from puttygen mentioned above.
This works exactly like setting a key up for SSH on any other system but the difference here is that instead of putting the key inside of the ~/.ssh/authorized_keys file on linux, you're putting it in a file that is named your login name as the plugin uses the name of that file for your username and the contents of the file for the public key.
Hope that helped clarify some things! 😊

Thanks!

Hello, it does not work for me.
Photo as configured:
https://sun6-19.userapi.com/whXI2c1IPofbL2qi9PV_-bIg-q_QzpP0FZKwoA/7MWrbuga1Ak.jpg
[https://sun6-13.userapi.com/Nfp7Ud5ZNECx1llhwB63U07XHC3BcMaH6htBfQ/IqCjVseoNEQ.jpg](File keys)
[https://sun6-14.userapi.com/k8cFQ1DL2MH4b7EmwJCRSe63ba5bJoErCDyRkQ/iipuupuEyyw.jpg](The keys public)

Could you please explain in more detail about how it is not working so I can try to help?

Well, I don’t know, I went into the PuttyGen program and then generated the RSA code, then I went to the authorized_keys folder, and created the authorized_keys file but nothing works, I decided to make the test file also not work.

According to your images, what you would have to do is login as<EMAIL_ADDRESS>in putty. The name of the key file is the username for ssh. The test file would mean you would need to login as<EMAIL_ADDRESS>You only need to put files named as the username in the authorized_keys folder, no file named authorized_keys needs to exist like it does with OpenSSH. Hope this helps! 😊

Okay, but I can’t connect.
Config Putty
Error

You should be logging in as the user defined by the file name in the authorized_keys folder.
e.g<EMAIL_ADDRESS>

I can’t connect, the connection is interrupted.

You need to connect on port 1025, did you allow that on your config?

Yes, I connect to this port, but I did not understand on which computer I need to configure Firewall?


Catch access undefined property on sealed objects

Since #3482 has been closed without any further comment, I would like to know how to catch reading non-existent properties on sealed objects. See this example:
https://flowtype.org/try/#0C4TwDgpgBAglC8UDeAoKUCGAuKA7ArgLYBGEATgDRpTE4DOwZAlrgOYoC+KKAZvrgGNgTAPa5MGMAAoWYfMBwwAlKihMeM3HOAA6ASupQBYuiIA2EHWZGtN2vUoDcaLmq3ydAEwRQAzM64UY1wGN21FHyRsAEYKGhwAcgALCDNrBI5nDEk7eScgA
How would we catch the obvious error of reading input.c on the sealed object which has no property c? It can never be intentional to read the property, so it must be an error.

Ok then let's start a bit more generic discussion:
is the sole purpose of flowtype to catch runtime errors, or is its purpose to improve the overall quality of Javascript code?

This gives no errors:
type A = {
  a: number
}

function aap(input: A){
  if(input.a.wtf === 1){
    console.log("Que pasa?");
  }
}

Is there really nobody with an opinion on this? If Flow would have supported this case it would have saved me countless hours of debugging.

The behavior you want used to be the default. But it was decided that you should be able to check for unknown keys on an object in conditionals. That's the behavior you're seeing now. I don't see any problem here.
Also, I'm not exactly sure what your problem is exactly.

@nmn What is the purpose of supplying the type A in the example above then? I expected the input to be a sealed object. And there should absolutely be no use-case for checking unknown keys on a sealed object, there is no way of justifying that in my opinion. I really would like to know a single use-case for somebody who needs the current behavior so I can revise my opinion if needed.
Could the previous default behavior be made optional?

This now correctly errors


ci: run tests upon push, PR and cronjob

If CI fails upon pushing or cronjob, an issue is created
If CI fails upon PR, a comment is created

solve #149

overridden by #157


removed bq uri experimental flag

Thank you for creating this Amandeep. Could you please address the following nit from 153 in this PR:
Rename 'client' to 'dataplex_client': https://github.com/GoogleCloudPlatform/cloud-data-quality/pull/153/files#r816357070
Add integration test for 'dq_entity.DqEntity.from_bq_entity_uri': https://github.com/GoogleCloudPlatform/cloud-data-quality/pull/153#discussion_r825701290
Set "dataplex_*" fields to 'None' in 'from_bq_entity_uri': https://github.com/GoogleCloudPlatform/cloud-data-quality/pull/153#discussion_r825701290https://github.com/GoogleCloudPlatform/cloud-data-quality/pull/153#discussion_r825704916
Add integration test for 'bigquery_client.get_table_schema()': https://github.com/GoogleCloudPlatform/cloud-data-quality/pull/153#discussion_r825708170
Make partition_fields consistently of type ARRAY: https://github.com/GoogleCloudPlatform/cloud-data-quality/pull/153#discussion_r825714186
Add integration test for _PARTITIONTIME time-partitioned tables: https://github.com/GoogleCloudPlatform/cloud-data-quality/pull/153#discussion_r825714892

We also need to figure out what to do with DATE partitioned Hive-external tables https://github.com/GoogleCloudPlatform/cloud-data-quality/pull/153#discussion_r825718166
Right now DATE is not allowed in native BQ tables but allowed in external tables.


Additional caching

In previous impls we also implemented the following caching layers in addition to the current bitmap and size cache:

Renderer caching. Saves the layout managers, and is commonly lighter weight than the bitmaps that came from them.
Attributed string caching. Saves the result of the build steps into a global cache so we avoid re-building attributed strings all the time.

Yaaasss. All of it!


Add new roles

Hi again, I tried add a role between guest and admin, let's say super-member, and I got an error using db configuration.
I figured out where the problem is and I need an advice about solutions I found.
I have following roles records:
id:1;name:guest;
id:2;name:member;
id:3;name:admin;
id:4;name:super-member;
I also have following roles_parents records:
role: member; parent: guest;
role: super-member; parent: member;
role: admin; parent: super-member;
Problem arises because findAll() method of role entity returns records ordered by id: so when AclDb class in CsnAuthorization module calls addRole() it passes first admin role whith its parents, i.e. member and super-member, but while member was already passed because of its lower id, super-member was not because it was added in second time and its id is grater, and this causes a fatal error.
I found two solutions:
1 - use naming convention for roles and then order roles by name asc:
new roles: 000guest , 100member , 200super-member , 300admin
and change AclDb constructor code like this:
old:
$roles = $entityManager->getRepository('CsnUser\Entity\Role')->findAll();
new:
$roles = $entityManager->getRepository('CsnUser\Entity\Role')->findBy(array(), array('name' => 'ASC'));
2 - add "weight" property to role entity and define a custom findAll() method inside entity repository (I foud this solution here: http://goo.gl/rQbWZS ):
roles records:
id:1;name:guest;weight:0;
id:2;name:member;weight:1;
id:3;name:admin;weight:3;
id:4;name:super-member;weight:2;
File RoleRepository.php
...
class RoleRepository extends EntityRepository
{
public function findAll()
{
return $this->findBy(array(), array('weight' => 'ASC'));
}
}
File Role.php
...

@ORM\Entity(repositoryClass="CsnUser\Entity\Repository\RoleRepository")

@ORM\Table(name="role")
*/
class Role
{
...

@var integer

@ORM\Column(name="weight", type="integer", nullable=false)
*/
protected $weight;
...
}

I think second one is better because it is completely transparent to CsnAuthorization module. First one is a kind of hack.
Can you please check these solutions and give me your opinion?
Maybe your modules provides better solutions to add roles in second time, if not I hope this one is useful.
Thanks.
Best regards,
Davide.

Thank you for sharing this with us. I like your second approach for solving the problem, by adding  "weight" property to role entity.


[FEA] Add the Spark 3.1.0 shim layer for GpuWindowInPandasExec

Is your feature request related to a problem? Please describe.
Its parent class WindowExecBase, an abstract class in Spark 3.0.x, becomes a trait in Spark 3.1.0.
Describe the solution you'd like
So need to add a shim layer to support Spark 3.1.0

reference https://issues.apache.org/jira/browse/SPARK-30765


What is the situation of executing a prison escape evacuation?

Unable to perform prison break after modifying the iOS version number，May I ask what I should do？

See #43


Virtualbox machine fails with tls: DialWithDialer timed out when checking certificates

I get the following error after docker-machine start mymachine after it's been stopped some time (hard to pin down exact cause, can't force reproducing it with a machine sleep or network change). Subsequent runs do not have this error:
Starting "99dev"...
(99dev) Check network to re-create if needed...
(99dev) Waiting for an IP...
Machine "99dev" was started.
Waiting for SSH to be available...
Detecting the provisioner...
Started machines may have new IP addresses. You may need to re-run the `docker-machine env` command.
Error checking TLS connection: Error checking and/or regenerating the certs: There was an error validating certificates for host "<IP_ADDRESS>:2376": tls: DialWithDialer timed out
You can attempt to regenerate them using 'docker-machine regenerate-certs [name]'.
Be advised that this will trigger a Docker daemon restart which will stop running containers.

At a guess, is it possible that there is a race condition occurring where the docker daemon is slow to start but the machine is reporting it's ip as ready?
Version
docker-machine version 0.6.0, build e27fb87`

VirtualBox Version
5.0.14r105127

I'm experiencing the same issues, same versions.
Following the advice of regenerating the certs also has no effect.
I have not been able to start my instances since upgrading with DockerToolbox from 1.9.1g to 1.10.1 last night...

Update: After trying the same steps I've tried several times, it now works. I did not machine any other changes, all Id id was: stop default, ensure it was stopped via status, start default, then check env - this time no error and I'm able to connect.

This happened to me too, after upgrading boot2docker image. The workaround is the following:

open VirtualBox and stop the machine (send ACPI Shutdown)
run docker-machine start machine-name in a new shell session. Old ones won't work (I guess there is something left in the environment that breaks even docker-machine env)

I have the same problem, but it doesn't work even if I try to do it in a separate shell after a ACPI shutdown.

After experiencing this problem and trying ACPI shutdown, separate shell, reupgrading to no avail. I removed and recreated the VM which, unsurprisingly, fixed the issue.

@alexander-lazarov: this worked for me!
I am running Docker version 1.11.0, build 4dc5990 on my Mac.

I had to recreate things as @wmcg described to get things going from 1.9.1 => 1.11.1 on my Mac running El Capitan v10.11.23

I had success with doing a docker-machine kill default and then starting normally again.

It happened with me too.
docker-machine version 0.8.2, build e18a919

I am encountering this also.
docker-machine version 0.8.1, build 41b3b25

I'm encountering this too.
docker-machine version 0.9.0, build 15fd4c7

I've since killed my docker-machine, uninstalled docker, reinstalled docker, reinstalled virtualBox, restarted my computer, and tried "docker-machine regenerate-certs" multiple times. I've also tried using different IP addresses and moved my laptop from one network to another. This continues to happen. It's not random either. It happens every time.
Please help. I'm desperate.

Getting the same issue.
docker-machine version 0.10.0, build 76ed2a6


hotfix(admin_api) ensure offset is a string for targets list endpoint

offset is a string on the Admin API for all list endpoints.
This change ensures that /upstreams/:upstream/targets endpoint
conforms to this expectation.
Fix #4043

Manually merged with local edits. Thanks.


fix(463): replace alias links back to relative

It seems like a lot of my ideas that I think would be great and useful seem to not be 😞 The disappointing part was that this is the same as #5 ... Though I am not familiar on how npm decides to release things. I did not figure that it would remove the vite config, designating how to use the alias. Regardless, it should fix any issue relating to using aliases.
I am trying to find a way to have tsconfig include .d.ts files... Since it can be easy to attempt to import a missing file. I checked them all this time, but it would be nice to have error detection in .d.ts files.

If this does get pulled, it would be beneficial to quickly do a new release. As I think 2 current issues pertain to this.


Support slash in layer ID

Description
Fix #56 by creating directories recursively after joining the layers directory with the layer ID. Before this fix, the layers directory was being created, but if the ID contained a slash, it would try to write the file to an nonexistent directory, resulting in an error.
Type of Pull Request

[ ] Adding a feature
[x] Fixing a bug
[ ] Maintaining documents
[ ] Others ()

Verify the followings

[x] Code is up-to-date with the main branch
[x] No build errors after npm run build
[x] No lint errors after npm run lint
[x] No errors on using charites help globally
[x] Make sure all the exsiting features working well
[ ] Have you added at least one unit test if you are going to add new feature?
[ ] Have you updated documentation?

Refer to CONTRIBUTING.MD for more details.

I like this implementation although I am not really sure this works perfectly in Windows environments ;-)

@hfu Ah, that's a good point. If the name of the file isn't stable between UNIX and Windows operating systems, charites projects won't be able to shared between them. I'll double check what happens on Windows and make fixes as necessary. Thanks!

Just for your information. I tried this on a docker container. This is really wonderful.
We can beautifully import JSON style into a series of sub-directory.
https://github.com/ubukawa/cmv-test/tree/main/esri/layers
We can have a long name for a style layer.
When building a JSON style, I found that there would be an error if we use ">(「折り返し形式のブロックスカラー」)" in the layers where we use "!!inc/file"

I wonder we may need to avoid using ">".  This is not directly related to this PR, I will share it at issue.]


Do not suggest npm install lodestar in guides, only dockerhub

NPM dependencies suffer from supply chain attacks. We protect users against those with locked dependencies on repo installs (yarn.lock) + dependabot updates.

See https://github.com/ChainSafe/lodestar/issues/3596

Due to this we should encourage users to only run pre-built docker images since those are guaranteed to install a pre-veted set of safe dependencies.
TODO

[x] Remove instructions to install from npm
[ ] Add warning note to not install from npm

Is the warning note on the documentation itself or are there any other warning methods we should include with NPM installation @dapplion ?


Change GH api to build release notes; plus refactoring

Fixes #11640
Status
ready
Description
Some overall refactoring of this script, it's worth highlighting though:

changed GH API from search issues to commits pulls;
less temp files.

Is it backward compatible (if not, which system it affects?)
YES
Related PRs
None
External dependencies / deployment changes
None

@todor-ivanov I fixed one missing dollar sign that you noted - I think it was in the middle of your review - so you might want to have another look.
Nonetheless, before merging it, I will wait for further commits to get mergeed into the repository and run a final and clean real test before incorporating it.

Now that we have more commits at the HEAD, I could execute the final tests. I had to update 2 lines in the previous code:

the command with sed was not properly expanding the $HASH_ID. Resolved by replacing single quotes with double quotes.
not clear whether it really makes any difference, but when formatting git log to retrieve the author, I switched from %an to %aN. Which is what the script already uses.

Documentation on these log format can be found at: https://devhints.io/git-log-format

This is working fine now. Merging


Simplify some outlines

[why]
The SVG contains groups of paths that were obviously differently colored before resulting in a glyph with very strange outlines.
[how]
Flatten all path to one path.
Simplify the path.
Hand-optimize some points and remove others.
Double points and very sharp tips.
From 511 points to 176.
Reported-by: Aaron Bell <@aaronbell>
Current glyph in font-logos.ttf:

New simplified path:

Old Tux left and optimized Tux right:

Old to new size comparsion (34k -> 5k).
$ ls -l --sort=size vectors
total 648
-rw-rw-r-- 1 fini fini 64358 Nov 18 16:24 openbsd.svg
-rw-rw-r-- 1 fini fini 34033 Nov 18 16:24 tux_old.svg
-rw-rw-r-- 1 fini fini 16595 Nov 18 16:24 illumos.svg
-rw-rw-r-- 1 fini fini 10845 Nov 18 16:24 gnu-guix.svg
-rw-rw-r-- 1 fini fini 10224 Nov 18 16:24 raspberry-pi.svg
-rw-rw-r-- 1 fini fini  7482 Nov 19 18:13 kubuntu.svg
-rw-rw-r-- 1 fini fini  7443 Nov 19 18:13 ferris.svg
-rw-rw-r-- 1 fini fini  7149 Nov 18 16:24 kali-linux.svg
-rw-rw-r-- 1 fini fini  6991 Nov 18 16:24 debian.svg
-rw-rw-r-- 1 fini fini  6628 Nov 18 16:24 docker.svg
-rw-rw-r-- 1 fini fini  6455 Nov 19 18:13 kde-neon.svg
-rw-rw-r-- 1 fini fini  6212 Nov 18 16:24 redhat.svg
-rw-rw-r-- 1 fini fini  6166 Nov 18 16:24 opensuse.svg
-rw-rw-r-- 1 fini fini  5797 Nov 18 16:24 mandriva.svg
-rw-rw-r-- 1 fini fini  5581 Nov 18 16:24 centos.svg
-rw-rw-r-- 1 fini fini  5379 Nov 18 16:24 gentoo.svg
-rw-rw-r-- 1 fini fini  5154 Mär 15 21:55 tux.svg
-rw-rw-r-- 1 fini fini  4910 Nov 19 18:13 codeberg.svg
-rw-rw-r-- 1 fini fini  4768 Nov 18 16:24 elementary.svg

Examining the other big file sized icons...
OH MY

314 to 29 points in 3 seconds :unamused:

10k -> 1k
And this:

218 to 95 points...
16k -> 3.2k
The next in size (raspberry) is already as optimized as possible, point wise:

Sorry I did not mean to ping Lukas specifically...

Thank you for reviewing :-)

Did similar things here

https://github.com/ryanoasis/nerd-fonts/pull/1542
https://github.com/ryanoasis/nerd-fonts/pull/1543

Hope most of the really bad things are now fixed. Well, one PR is pending at MaterialDesign, and Codicons also had two broken glyphs. Do you think we should update Codicons? But then a lot icons changed dramatically to some more modern version. Sigh.

Do you think we should update Codicons? But then a lot icons changed dramatically to some more modern version. Sigh.

Mmm, seems last update was about 3 years ago, could be that some users are expecting to have the same exact icons as in VSCode.
Also the fact that are some "missing" icons (could be instances in other font sets), there are 387 nf-cod-* icons on NF but 457 on https://github.com/microsoft/vscode-codicons/tree/main/src/icons with 35 changes last year.
Maybe is worth a discussion on NF. Personally I won't oppose to the change because pretty much  all the icons for code that arrive to my terminal it's because I'm using fancy plugins on Neovim & other applications, so the maintainers of such plugins are the ones who really control which icons to use, at the end I'm just a final user that uses which arrives from upstream.

Thanks for your thoughts! :green_heart:

there are 387 nf-cod-* icons on NF but 457 on ...

Hmm, that does not look like so many, but I have not counted.
And I was mistaken, it was Material that has changed dramatically, the changes in codicons seem all very acceptable and I see no reason to not do it.
And all (that means 100%) of the users I talked to (n = 1) said an update would be welcome :-)
The problem is that one can not reach 'the Nerd Font users' in any meaningful manner.
I think this will go.
https://www.github.com/ryanoasis/nerd-fonts/pull/1544

https://yaytext.com/blog/mathematical-unicode-letters/ :laughing:


fixed duplicated import of 'core-js/fn/object/assign'

A minor change that removes duplicated import of 'core-js/fn/object/assign' polyfill for 'slim' bundle version.

thanks!


Explain the real purpose of IP range <IP_ADDRESS>/32

Dear Microsoft Documentation Team,
Can you please explain the real purpose of IP range <IP_ADDRESS>/32? We checked our firewalls and there is not a single hit or session to this destination. Is this a real route for the traffic of some kind OR just a marker used by Teams to discover presence of the VPN solution?
Regards,
Serg

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 83a36fa1-0345-87d0-7fea-cca68bfe1915
Version Independent ID: 0eaabf4b-4c4d-06d5-b877-56a7657eceaf
Content: Implementing VPN split tunneling for Office 365
Content Source: Enterprise/office-365-vpn-implement-split-tunnel.md
Service: o365-administration
GitHub Login: @kelleyvice-msft
Microsoft Alias: kvice

@SergGu Thank you for the feedback. We have now removed the IP range added an important note to the doc as the teams update is made available.
Note:- To ensure Teams media traffic is routed via the desired method in all VPN scenarios, please ensure users are running Microsoft Teams client version <IP_ADDRESS>65 or greater. This version includes improvements in how the client detects available network paths.
Thanks
Sri

@SergGu - Thank you for submitting feedback.
From our understanding, the issue you raised has been answered by @msbemba so we will close this issue.
Thank you for your contribution to make the docs better! Much appreciated!


fix grammar mistake in service-admin-azure-ad-b2b.md

fix grammar mistake. change is by<EMAIL_ADDRESS>

Learn Build status updates of commit e36ee80:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

powerbi-docs/enterprise/service-admin-azure-ad-b2b.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

closing as it's a pretty trivial change

I don't know how to merge this :)

Learn Build status updates of commit e36ee80:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

powerbi-docs/enterprise/service-admin-azure-ad-b2b.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Looks good; thanks @andreea-s.


Prebid 1.0 adapter requirements

Hi,
In How to Add a Prebid 1.0 Bidder Adapter http://prebid.org/dev-docs/bidder-adapter-1.html one of the requirements is to put myAdapter.md file into modules/. However when I do so, gulp devpack fails on the .md file as it pulls it in together with the .js files. Either the .md files should go to a different location or should be excluded from the build.
Cheers,
Jozef

It seems this has been fixed already. Closing.


[Font] Update SharpFont library for additional fixes

PR Details

Successor to #2281
Must wait until pull at https://github.com/stride3d/SharpFont/pull/1 is merged and its nuget package has been updated to 1.0.1.
My understanding of Stride's build of SharpFont:

vonderborch's repo, aka SharpFont.NetStandard did not contain any major changes compared to Robmaister's repo- it mainly moved files around (no code changes) and the single code change involved loading/switching 32bit/64bit dll, which Stride already does (I think). So the above pull only merged and modified from the latest of Robmaister's repo.
Stride does not use freetype6 as provided in Robmaister's branch which is only on v2.6 - Stride uses v2.6.3 https://github.com/stride3d/freetype/tree/2.6.3 (and is named freetype), as per this https://github.com/stride3d/stride/blob/master/deps/freetype/checkout.bat

Related Issue

Types of changes

[ ] Docs change / refactoring / dependency upgrade
[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[ ] My change requires a change to the documentation.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[ ] I have built and run the editor to try this change out.

You're a god send, thanks a ton for taking over this one @Basewq and for looking into this further than I had :)

I'll look into publishing the package once teamcity is up

Ready to merge. While there are some fixes within SharpFont, none appears to have impacted Stride at this time, so consider this more of a future proofing update.
Realistically, if there are font bugs that need fixing, consider updating the stride version of freetype repo: https://github.com/stride3d/freetype

Thanks !


Foreldrar Jóns

[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 61e341b7-e840-246c-f045-94a40347aa87
Version Independent ID: 61e341b7-e840-246c-f045-94a40347aa87
Content: Analyze app performance - Windows apps
Content Source: hub/apps/publish/analytics.md
Product: reunion
Technology: apps
GitHub Login: @hickeys
Microsoft Alias: hickeys

Closing. No issue reported.


Verge-qt <IP_ADDRESS> (mac) unable to unlock with proper phrase

Issue Template
Coins originally acquired while on Windows Electrum
I've installed new wallet on Mac back in January 2018 and transferred my coins from windows electrum wallet to mac qt wallet
I've upgraded qt wallet in last 3 months and now I'm on 4.0.2
Wallet is locked
I've tried to unlock it with my passphrase, but it says "The passphrase entered for the wallet was incorrect."
I've tried via console, unlock, change passphrase and nothing help. I know I have a correct passphrase because it was written down and used before when I sent my coins.
Current Wallet
v<IP_ADDRESS>-80de5df-funky-beta
Coins are correctly shown, but I'm unable to send/unlock

Hey there,
did you get any notification which told you that something is incorrect?
And if yes, what did it say?
Have you tried to start it with a debug option? // if not no problem :)

Unfortunately the only message I got is the response "The passphrase entered for the wallet was incorrect." when attempting to unlock, send, or change passphrase. I've tried using console for walletpassphrase 'my passphrase' 900 as well as walletlock with walletpassphrase abc 600, same message with error 14
I've installed windows latest qt and moved the wallet.dat, it took few min to load transactions, but it shows my coins. Obviously wallet is locked and I could't unlock it same as on Mac.
Since I have my 8 word seed, any way I can restore it on a new wallet? If so, what would be the proper steps. I don't have private key and I'm unable to dump it since the wallet is locked.

I've tried to download 4.0 ad 4.0.1 for Windows from https://github.com/vergecurrency/VERGE/releases
but looks like those links are broken. Here is the message I get:

NoSuchKey
The specified key does not exist.
50223128/fae70f02-f4ab-11e7-8e10-0b44ba439dcc
2CAE7284116F36D6

Jp7xuF9IytLJFDfE9bGMKLZzb0diPspnePa2BJgtNS/Rh3snsbaGkwSl/q692fWxUi0ZgUuNj3Y=

Btw Wallet was created on Mac Jan 23rd 2018 using VERGE-Qt-1-30-2018.dmg
I've gone and reentered all my passphrases that I keep written on paper, just in case
I know that during wallet encryption I had to enter the passphrase twice, so fat-fingering would be highly unlikely.
My passphrase is something like P1leOfSh1t so its only alpha-numeric with upper and lower case

I'm running now -rescan, so I'm hoping it will recover all transactions.

Glad to hear it worked out.  If you want extra protection / security, it's a good idea to get your private keys.  However, you need to be extremely safe with your private keys.  If you have a private key, you don't need any password / passphrase.
you can check out my wiki guide on 'dumpprivkey' steps:
https://github.com/vergecurrency/VERGE/wiki/Windows-Verge-QT-Wallet-Beginner's-Guide#optional-getting-your-private-key


Moment.defaultFormat does not affect date parsing

Description of the Issue and Steps to Reproduce:
Moment.defaultFormat affects only format() function and does not affect date parsing
console.log(moment.version) // 2.22.2
moment.defaultFormat = "DD.MM.YYYY HH:mm";
console.log( moment('20.07.2018 09:19').toDate() ) // Invalid date
console.log( moment('20.07.2018 09:19', moment.defaultFormat).toDate() ) // Fri Jul 20 2018 09:19:00 GMT+0300

Is that right?
Environment:
Chrome 67 on Windows 10

Yes, that's correct.

I made a PR to add to the docs about this:  https://github.com/moment/momentjs.com/pull/537

fixed by https://github.com/moment/momentjs.com/pull/537


Change date of DLL in the future cause error with nuget on mono

If I try to restore package on macOS (Nuget CLI) I get the following error.
Errors in packages.config projects
    Error downloading 'WebP.Touch.1.0.2' from 'https://api.nuget.org/v3-flatcontainer/webp.touch/1.0.2/webp.touch.1.0.2.nupkg'.
    Invalid parameter

After search, I found, that a date in the future cause this error with nuget API v3. Your DLL in the package has the change date of 2089-10-7T15:04.

@WebDucer could you try again with the newest version uploaded? (1.0.3)

Yes. Now it is working 👍


Improving results for english

Hi,
First, thanks for this awesome model: two hours using your model solved a scenario of 8 months for me to generate one specific voice :)
I'm creating a personal chatbot (old desire) with the harbinger's voice (main villain of mass effect). Given the fact that I'm always generating the same voice, which is in english, I want to know:

Would be possible to use a BERT / HUBERT specialized in english instead of chinese version?

Do you have any tips to generate or select a good reference audio?

1.Adjust DPO parameters
2.Slow down the speech of generating result by 10-20%

1.Adjust DPO parameters 2.Slow down the speech of generating result by 10-20%

@KamioRinn can you explain more?
I did not understand DPO parameters, what do you mean? (during the inference or training)
And how can I slow down the speech in 10-20%?

adjust top-k, top-p and temperature

Thanks! I'll try the first 1 and send a report. About the DPO, right now I'll not touch this.

You can replace any BERT-like model as you like, such as mHuBERT147, it should be better to match the feature shape.
No good suggestions, try more.

can you explain more? I did not understand DPO parameters, what do you mean? (during the inference or training) And how can I slow down the speech in 10-20%?

The DPO option is selected by a checkbox when you fine-tune the GPT model part.

I tried mhubert-147 as you said, but the results was awful... If I change the hubert it's necessary to do the fine tuning again, right @SapphireLab ?

I tried mhubert-147 as you said, but the results was awful... If I change the hubert it's necessary to do the fine tuning again, right

I think you had better fine-tune the model because the base model uses the different HuBERT model to extract features.
And I only test the Chinese case with the mHuBERT-147 and it sounds not bad.


add support for PHP 8.0

Add support for PHP 8.0
Replace fzaninotto/faker since it has been archived and doesn't support PHP 8.0 and replace it with fakerphp/faker Changes coming to PHP Faker

Thanks @irakan - this is now available in v2.3.0.


Classifier based on Siamese Network to Classify Alzheimer's Disease on ADNI Dataset - 47571840

Name: Adzkia Aisyah Afrah Hardian
Student Number: s4757184
Task Chosen: 7. Create a classifier based on a Siamese network [10] to classify either Alzheimer’s disease (normal and AD) of the ADNI brain data set having an accuracy of around 0.8 on the test set [Hard Difficulty].
Objective: This pull request implements a Siamese Network that will be trained to generate embeddings of images of the ADNI dataset. A classifier (fully connected layers) is added at the end of the trained Siamese Network to classify Alzheimer's Disease on the dataset.
Model: The backbone architecture of the Siamese network is based on PyTorch's ResNet-18 with modifications. The classifier's architecture consists of fully connected layers to do classification tasks. A trained Siamese model sits at the end of the classifier with its weights frozen.
Usage: Dependencies and reproducibility of code are covered in the README.md. Most importantly, the ADNI dataset should already exist in your local repository and modify the data paths in the train.py and predict.py if needed.
Performance: The best classifier reached 0.721 accuracy on the test set.
Files added:

README.md  report of the project consisting of an overview of the Siamese network, description of the ADNI dataset, pre-processing steps, training results, testing results, dependencies, and references.

dataset.py provides functions and classes to load the ADNI dataset for training and testing the Siamese and classifier, including the functions to pre-process data.

modules.py consists of the Siamese and classifier module classes, including the ContrastiveLoss class.

train.py trains the Siamese and classifier models and evaluates the classifier on the test set.

predict.py loads existing trained Siamese and trained classifier and do inference using both models of one input image.

/images_for_readme folder contains images displayed in the README.md

This is an initial inspection, no action is required at this point
Difficulty: Hard
Readme: Very good

Clear flow of information
Algortihm and training details explained well
Relevant plots for loss, accuracy provided
Presents results for several different model combinations and hyperparameter settings

Commit messages: OK
Code:

design is good
sufficiently commented
algorithm seems to be implemented correctly

Functionality/Performance:

siamese seem to perform well
classifier is very unstable and strange on the validation set, but it seems no actions have been taken to resolve it
classifier achieves only 72% on the test set

General comments:

algorithm solves the problem apporpriately although performance is somewhat poor

Marking
Good Practice (Design/Commenting, TF/Torch Usage)
Adequate design and implementation
Good spacing and comments
Header blocks missing -1
Recognition Problem
Solves problem
Driver Script present
File structure present
Shows Usage & Demo & Visualisation & Data usage
Module present
Commenting
No Data leakage
Difficulty: Hard
Commit Log
Meaningful commit messages
Progressive commits used
Documentation
ReadMe acceptable/good
Model/technical explanation
Good Description and Comments
Markdown used and PDF submitted
Pull Request
Successful Pull Request (Working Algorithm Delivered on Time in Correct Branch)
No Feedback required
Request Description good


Compatibility with K8 version

The documentation should contain Compatibility Matrix with K8s.
It is required when we walk through the service impact analysis before upgrading the K8 cluster.
As I look through the doc, I couldn't find one. If there already exists, please let me know.

You just need kubernetes to be over 1.11. Nothing else to consider.
https://github.com/external-secrets/external-secrets/blob/d0a32b6f2dbb1718d862c00915131522b1572c9a/deploy/charts/external-secrets/Chart.yaml#L7

Closing this one, feel free to re-open/comment :)

I think the idea is to have a compatibility matrix in the docs like so (e.g. like external-dns or ingress-nginx):

ESO Version
Kubernetes Version

0.5.x
1.16, 1.17, 1.18, 1.19, 1.20, 1.21, 1.22, 1.23

0.4.x
1.16, 1.17, 1.18, 1.19, 1.20, 1.21, 1.22, 1.23

0.3.x
...

Actually, Kubernetes 1.16+ is required due to the fact that we use admissionregistration.k8s.io/v1 for validation webhook and apiextensions.k8s.io/v1 for CustomResourceDefinitions.

So sorry, that's right! But saying that we need 1.16+ is sufficient anyways and a matrix is just noise, no? Also, we need to update that in the chart then, right?

Sorry to jump in, my intention was what moolen said. But if there's no need for matrix for now, I think you can state that 1.16+ is sufficient in the doc. But as an example of ingress-nginx, if there's an end of support for certain k8s version, it'd be better to use matrix to avoid any confusions.

There they have a matrix because they are showing more than just kubernetes versions (alpine image version and nginx version itself).

Well, I don't think so... if you see external-dns matrix. They had to make breaking changes since extensions/v1beta1 is removed from k8s v1.22.
I'm just worried because there will be k8s API depreciation or even removal in the future that external-secrets uses, so the matrix like external-dns would be better.

That's true! I guess it doesn't hurt to add a table to be prepared for that.
Would you be interested in adding that to the docs? Docs that come from users that found a pain point are usually nice since you can add exactly what you wanted to see there :)
We can reopen, and leave it here until this is added to the docs.

This was fixed with #992, it's now in the docs.


Need to update JSX section to reflect 'IntrinsicAttributes' and 'IntrinsicClassAttributes'

See conversation on https://github.com/Microsoft/TypeScript/issues/4682#issuecomment-207864620. We need to update the section to reflect it.

Shouldn't the JSX.IntrinsicAttributes contain the children property?

@RyanCavanaugh?

Looks like it should be added with type ReactNode.


Another format - sode/na

The readme asked for better formats.
I won't claim mine is a better format, but sode (based on na) does have some similarities to RON.
One of the examples from the readme, in sode:
GameConfig( -- optional struct name
    window_size: (800, 600)
    window_title: 'PAC-MAN'
    fullscreen: false

    mouse_sensitivity: 1.4
    key_bindings: {
        'up': Up
        'down': Down
        'left': Left
        'right': Right

        -- Uncomment to enable WASD controls
        -- 'W': Up
        -- 'A': Down
        -- 'S': Left
        -- 'D': Right
    }

    difficulty_options: (
        start_difficulty: Easy
        adaptive: false
    )
)

Maybe this can serve as inspiration for further simplifying your syntax? Note how commas are optional when multiline.

Thank you for showing this! It looks quite similar.
From a cursory look, some of the differences are: whitespace-sensitivity, lack of native enum support.
I wasn't able to see if it supports arbitrary types in the key position of key/value pairs. I.e. this part of na documentation is concerning:
s-record: [ foo: 42, bar: true ]  -- resembles swift dictionary, elixir keyword list
c-record: { foo: 42, bar: true }  -- resembles javascript object, python dict, go map

It's concerning because in both cases the foo and bar are not strings. So it's either that all key/value pairs have to have keys as strings (which would be sad), or that there is some magic going on allowing strings to be unquoted (which is a misfeature in my eyes).

And thank you for returning feedback!
na does use significant whitespace, but it's opt-in. A colon followed by newline opens a multiline collection where brackets are omitted and indentation is significant. Otherwise, whitespace is ignored. Commas are optional whenever newline is used to separate items, but they are still supported. I have yet to write a parser for na, so I haven't tested these rules for edge cases.
Record keys can be identifiers, strings or numbers (for sparse arrays). How these are mapped to the target language is up to the parser. Languages supporting the types would keep them, others might convert them to strings or identifiers.
It's currently not possible to enforce a more restricted syntax, like disallowing strings/numbers as keys for your enums. However, I could take inspiration from RON extensions, and use hashbang to allow a variant to be specified:
#!ron [enable(implicit_some)]

Parsers that support the variant would parse it as "na-ron" while others would still be able to parse it verbatim. Not that I intend to subsume RON :) It would be a very elegant way to extend na in general.
There's another difference as well. na lacks support for your Map, which allows any value as key, including other maps. na did use to have a Map type with the syntax #(value: value) (or #{ value: value }). I'm still debating whether to include that.
Having looked more closely at RON, I must say it's a very neat format! It's clear that we see things similarly. And I'll openly admit that I've found inspiration in its features.


chore: adapt mobile alpha to develop

Summary
This PR adapt the test/mobile-alpha branch to develop
Changelog
TBD

Relevant Issues
Closes #2614
Closes #2108
Closes #2322
Closes #2602
Closes #2104
Closes #2103
Closes #2555
Closes #2098
Closes #2589
Closes #2601
Closes #2658
Type of Change
Please select any type below that is applicable to your changes, and delete those that are not.

[ ] Breaking - any change that would cause existing functionality to not work as expected
[x] Chore - refactoring, build scripts or anything else that isn't user-facing
[ ] Docs - changes to the documentation
[ ] Fix - a change which fixes an issue
[ ] New - a change which implements a new feature
[ ] Update - a change which updates existing functionality

Testing
Platforms
Please select any platforms where your changes have been tested.

Desktop

[ ] MacOS
[x] Linux
[ ] Windows

Mobile

[x] iOS
[x] Android

Instructions
Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.
Checklist
Please tick all of the following boxes that are relevant to your changes, and delete those that are not.

[x] I have followed the contribution guidelines for this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have verified that new and existing unit tests pass locally with my changes
[x] I have verified that my latest changes pass CI workflows for testing and linting

Hey @Tuditi, thank you for your review efforts 😅! I tried to fix the remaining issues as this PR is a blocker at the moment. Could you check again?

In the case of onCreateAccount, we implement that function in Dashboard.svelte, with specific params: alias: string, color: string, onComplete and endup calling the implementation on CrateAccount.svelte with different params:
onCreate = (alias: string, color: AccountColors, callback: (err: ErrorEvent) => void): void => {}

AccountColor != string
I think here it's better to define this specific types rather than allow any amount of params, as in this case we are preventing a future type error that the  ..._: any[] type can't capture


Add expanding height to plain text fields

Currently with a full classname applied to the panel they are very tall within the CMS. It would be good if the expanded like the rich text field does.

Implemented for StreamField in #1035 - will take this as a request to apply this to non-StreamField text areas too...

Brilliant thanks.


Fix: Parsing of path parameter works with OData style params

fix https://github.com/microsoft/typespec/issues/2834

You can try these changes at https://cadlplayground.z22.web.core.windows.net/prs/2836/
Check the website changes at https://tspwebsitepr.z22.web.core.windows.net/prs/2836/


Javadoc fix for HBase 2.x BigtableConnection

Running mvn -Ddoclint javadoc:javadoc was broken.

LGTM


Implement operation interface for replication rule and job management view

work has been done. Close this issue.


DedupeResponseHeader with String configuration not working (solution added)

Describe the bug
It is not possible to use the deduperesponseheader filter when using yaml-based configuration of routes, because the @Shortcut annotation is missing.
Sample
filters:
  - DedupeResponseHeader=Access-Control-Allow-Credentials Access-Control-Allow-Origin

Does not work.
filters:
  - DedupeResponseHeader=Access-Control-Allow-Credentials Access-Control-Allow-Origin, RETAIN_FIRST

Does work.
I've also added a PR to solve the issue.

Closing in favor of #3536


Switch to LLVM 3.7

This PR adapts Numba for LLVM 3.7. The following llvmlite PR is required: https://github.com/numba/llvmlite/pull/100
CUDA works but HSA probably doesn't. The benchmarks show little significant improvement.

HSA wise I have tested the code as follows:

https://github.com/HSAFoundation/HSAIL-Tools was compiled an installed from https://github.com/HSAFoundation/HSAIL-Tools/commit/8820eb6b6e530fe5084e4f13289e360929c486de
HLC-HSAIL development LLVM was compiled from source https://github.com/HSAFoundation/HLC-HSAIL-Development-LLVM/commit/dc521641f60f8ccf96e568d7439905724baf9871 and built against the HSAIL-Tools.
https://github.com/numba/llvmlite/pull/100 was compiled against the HLC-HSAIL development LLVM (commented out OProfileJIT requirement in makefile, this could be fixed by compiling HLC-HSAIL LLVM with OProfileJIT enabled).
In a new conda env:

numba dependencies were install
The llvmlite build was installed
libhlc was installed from @sklam's channel (so the builtins-hsail.opt.bc code was available)
In the numba source, https://github.com/pitrou/numba/tree/llvm3.7 was merged into https://github.com/stuartarchibald/numba/tree/wip/allocators_3 which is the HEAD of current HSA development. The only change required to the code was the removal of the addition of the metadata type information, here: https://github.com/stuartarchibald/numba/blob/wip/allocators_3/numba/hsa/hlc/utils.py#L61 . Numba was then installed.

The environment variable NUMBA_USE_LIBHLC=0 was set to use the HLC/HSAIL LLVM binaries for compiling and linking the code, normally libhlc would do this but due to the 3.6->3.7 change it needs rewriting.
The unit tests for HSA were run.

Results:
Out of 87 running tests all pass with the exception of:

3 known to be broken anyway
2 with now incorrect LLVM 3.6 IR
3 segfaulting on the finalize pass in llc

OK, going to merge.  We will also need to update our dependencies in the conda recipe in the future, once there is an official llvmlite release for LLVM 3.7 that we can require.


[FEATURE] Create/Edit rule validation on submit and visual-yaml editor switching

Is your feature request related to a problem?
Specific client side validations should be shown inlined on form submit (not only on blur) for both visual and yaml editor.
Additionally, show client side validation messages while switching between editors.
https://user-images.githubusercontent.com/1564068/207249977-5e9a2868-15bf-435b-96f6-8f059573cbad.mov

@kaming @getsaurabh02
We should have same form validation experience as we have on other plugins. Here is an example of Create rollup job form on Snapshot Management plugin.
https://user-images.githubusercontent.com/1564068/209216499-fc901b2c-6da3-4561-9a2b-4cfbb7fd548b.mov
Please notice that even this form is not fully consistent since required message on job name is different depending if user action is clicking submit button vs blur out of input field.
Acceptance Criteria should be:

form has no red flags on initial state
touching the field (blur out) triggering validation on that field and shows eventual inline error message
clicking submit button (create or edit in case of rule forms) triggers all validations on all fields and shows all eventual error messages
generally speaking, server side validation error messages or some unhandled errors should be shown in form of toast notification

I still need to think on switching the editor type behavior in context of validation messages

@djindjic Do we know which fields are required to create a rule?
I am assuming we need the following with requirements:

Rule name
Log type
Detection
Rule level
Author
Rule status

Here are some guidance on validation pattern:
If any of the required fields are empty, we can show validation error onBlur until the issue is fixed, [fieldName] is required.
Like this:

If users attempt to click on Create when there are validation errors, we should show a toast like this:

For dropdowns in this create flow, we should leave them empty by default, with a placeholder text:

When users click on the dropdown, they will select from the selections.

If the user didn't select anything when clicking on Create, it will show the toast above and inline validation error:

I assume the following fields are optional?

Description
Tags
References
False positive cases

Let's add "- optional" in italics to help users identify which fields are required. Like this:

Example from Create rollup job in Index Management.

If users attempt to click on Create when there are validation errors, we should show a toast like this at the bottom right of the screen:

@kamingleung
At the moment I have the only one issue with show toaster if form is already invalid (for submission is blocked). Let me know if I can find this example on playground? I guess this toaster is produces by some backend error or validation outside of the form itself.

I assume the following fields are optional?

Description
Tags
References
False positive cases

Let's add "- optional" in italics to help users identify which fields are required. Like this:  Example from Create rollup job in Index Management.

@kamingleung
This is possible with custom flex group above the form field. Check how it is done in index management:

But I would try to go with some of form layout features defined in docs:
https://eui.elastic.co/v34.6.0/#/forms/form-layouts
Unfortunately, can't find some special flags for required/optional, but maybe help text below the field could be also used?

@kamingleung @amsiglan @getsaurabh02
I've covered all necessary behaviors except this two:

- optional sufix is not gray-italic for now because of no clear directions on https://eui.elastic.co/v34.6.0/#/forms/form-layouts and I wanted to avoid custom layouting of that purpose (still open for discussion about custom layouting)
Action buttons (Cancel, Create/Save changes) are now in the <ContentPanel> together with the form. This is still possible to be outside as it was before, but I've decided to put it on hold since its not "one line fix" and we have few more prio tasks at the moment.

Please check current behavior on the video and compare it to old behavior on playground
https://user-images.githubusercontent.com/1564068/209636858-ed613da5-7db2-491a-9165-26cf8fff5cd0.mov

@djindjic Thanks for your updates.

The - optional isn't a reusable style/component in EUI today, however we can align the style of - optional found in the Create detector flow.
Action buttons - Let's place them underneath the container to align with the placement with other create flows in Dashboards

Follow-up questions from your video:
3.  Are these confirmed as naming restrictions on Rule name and author?

We should show restriction text underneath the form field at all times like this (example from Anomaly Detection):

When, there are invalid naming requirements, we can show error above the restriction text, "Invalid rule name" like this:

@kamingleung
I think I've addressed all you points except:

extended author restriction text with commas (reflecting existing validation in the code)
added similar restriction text underneath description field based on existing validation in the code (including commas and dots)

Since PR for this issue is already merged I've done it in currently active one which is related (https://github.com/opensearch-project/security-analytics-dashboards-plugin/pull/279)
Please check video:
https://user-images.githubusercontent.com/1564068/210109993-25a49a70-ff50-4769-acd3-8bd68d47568e.mov

@djindjic This looks good to me. Thanks for your updates!


f_chown() should not run if group has access

When deploying this image as a pod in kubernetes, some CSI drivers create the mount with permissions root:PGID. All files within the mount are correctly set to PUID:PGID but since the mounting point UID is not of the PUID, the entrypoint script believes all files within do not have proper permissions. Could we add a check to see if the PGID is correct and not force the chown based solely on the PUID?
Thanks!

Can override by specifying RUNAS_UID0=true even when running as non-root. Thanks!


chore: exclude dev config files

Hello,
I recently noticed that the published version of the library included dev configuration files:

.dependency-cruiser.js
.eslintignore
.eslintrc.js
.nvmrc
.prettierignore
.prettierrc

This PR restricts the list of published files to lib only (plus standard files such as LICENSE, package.json and README.md).
WDYT?

thanks @fargito !


Can't load TRP

Greetings I am having issues getting TRP 3 to work. I receive the following every time I log in.
TRP3_API.events.FireEvent::WorkFlow_on_Load
...interface\Addons\TotalRP3\modules\map\map markers.lua:3:Action[SetPoint]failed because[SetPoint would result in anchor family connection]: attempted from: TRP3_ScanLoaderFrame:SetPoint.
Note: If you just recently updated the addon remember that you need to fully relaunch the game client. Updating while the game client is open will not load new files.
I have done as suggested but still I keep getting the error message. What can I do to fix said issue? Thank you in advance for your assistance.

Make sure that TRP3 is updated to the latest version (1.6.2). You should see the version number displayed above that error message.

So when I log into the game it says 1.6.0. However, I have updated it to 1.6.2 through Twitch. However, it won't register the newer version.

Make sure the path where the Twitch client is installing the addons is the right one :
Your WoW folder/_retail_/Interface/AddOns

lol....I have no idea why that was going to my PTR file. Thanks!


Multiple POI types

Please add the ability to create different labels. I want different icons to be displayed for different types of POIs. I think the easiest way would be to give an example of the configuration as I see it:
{
  "marker_types":
  [
    {
      "poiPrefix": "[poi]",
      "icon": "default.png"
    },
    {
      "poiPrefix": "[gate]",
     "icon": "gate.png"
    },
    {
      "poiPrefix": "[spawner]",
      "icon": "spawner.png"
    }
  ],
}

This is a good idea. Thank you!

@Sheridan, current progress in my dev environment is that it can load the configurations and put the markers in different groups on the map. I'm now working on making sure that existing sign configurations correctly load with the new configuration format.

It might be worth doing so (pseudocode):
void loadOldConf() { ... }
void loadNewConf() { ... }
void loadConf()
{
  if(json.exists("marker_types"))
  {
    loadNewConf();
  }
  else
  {
    loadOldConf();
  }
}

@Sheridan, I have released a new version that supports multiple POI types. The solution differs slightly from your example, but that's because I wanted to make sure I left it open for some of the features I want to add in the future. A sample configuration is available in the readme.
The mod will automatically update your configuration files to the new format on the first run.
You can download the release here: https://modrinth.com/mod/bluemap-sign-markers/version/1.20.1-<IP_ADDRESS>
This is a useful feature. Thank you for sharing the idea!


Replace LedgerPlutusVersion with Language type

@michaelpj said we shouldn't be using LedgerPlutusVersion. We can use Cardano.Ledger.Alonzo.Language instead.

Pre-submit checklist:

Branch

[ ] Tests are provided (if possible)
[x] Commit sequence broadly makes sense
[x] Key commits have useful messages
[x] Formatting, PNG optimization, etc. are updated

PR

[x] Self-reviewed the diff
[x] Useful pull request description
[ ] Reference the ADR in the PR and reference the PR in the ADR (if revelant)
[x] Reviewer requested

@michaelpj Yes we do, but the values happen to have exactly the same name so they don't show up in the changes.


Fix race condition when handling plugins packets

There's a race condition in the access of the packets CircularBuffers, between the render thread, which reads the packets from the Server->Client buffer, the Plugin->Client buffer and the Plugins thread which can enqueue new packets to be read by the Client.
Add a lock when appending data to each of the receiving buffers. Remove the lock to the packet handler when the plugin appends new packets.
Fixes #1665
Fixes #1618
This is the second attempt, more info also at https://github.com/ClassicUO/ClassicUO/pull/1670

I've been researching the client lockups when using ClassicUO plugin for a couple weeks now. Circular buffers is in play for sure but in each of my packetdumps the issues begin with an ID: 78 packet. I'm still trying to figure this out. I'm basically code illiterate. a lock might be the answer but the problem lies somewhere in the packethandler for ID: 78 I think

in all my logs the beginning of the issues is either a 78 getting stuck in the middle of a packet
          0  1  2  3  4  5  6  7   8  9  A  B  C  D  E  F
          -- -- -- -- -- -- -- --  -- -- -- -- -- -- -- --
00000000  A1 63 77 BA 01 78 00 66  00                       .cw..x.f.

          Ticks: 2711171 | Server -> Client |  ID: 06   Length: 5
          0  1  2  3  4  5  6  7   8  9  A  B  C  D  E  F
          -- -- -- -- -- -- -- --  -- -- -- -- -- -- -- --
00000000  06 B0 0E 01 90                                    .....

          Ticks: 2711171 | Server -> Client |  ID: 0B   Length: 7
          0  1  2  3  4  5  6  7   8  9  A  B  C  D  E  F
          -- -- -- -- -- -- -- --  -- -- -- -- -- -- -- --
00000000  0B D1 04 4B 00 02 04                              ...K...

          Ticks: 2711171 | Server -> Client |  ID: 0C   Length: 1
          0  1  2  3  4  5  6  7   8  9  A  B  C  D  E  F
          -- -- -- -- -- -- -- --  -- -- -- -- -- -- -- --
00000000  0C                                                .

          Ticks: 2711171 | Server -> Client |  ID: 00   Length: 104
          0  1  2  3  4  5  6  7   8  9  A  B  C  D  E  F
          -- -- -- -- -- -- -- --  -- -- -- -- -- -- -- --
00000000  00 01 40 32 51 2D 97 0B  03 07 3F 40 32 51 2E 93<EMAIL_ADDRESS>00000010  CC 0D 09 74 40 32 51 2F  93 CD 13 09 74 40 32 51  ...t@2Q/....t@2Q
00000020  30 93 CB 04 09 74 40 32  51 31 93 C7 0A 09 74 40<EMAIL_ADDRESS>00000030  32 51 32 B1 66 06 09 74  40 32 51 3D 0E 75 15 7F<EMAIL_ADDRESS>00000040  E5 3B C7 A0 44 0B 04 51  7F E5 3B C6 A0 4D 10 04  .;..D..Q.;..M..
00000050  51 00 00 00 00 17 00 0C  00 06 B0 0E 00 01 00 01  Q...............
00000060  00 17 00 0C 00 06 B0 0E                           ........```

or a ID: 78 packet starts being read halfway through the packet below example is 1st 4 rows are a valid ID: 78 missing like 50 bytes at the beginning

```          Ticks: 4285015 | Server -> Client |  ID: 0C   Length: 1756                #starts with partial ID: 78
          0  1  2  3  4  5  6  7   8  9  A  B  C  D  E  F
          -- -- -- -- -- -- -- --  -- -- -- -- -- -- -- --
00000000  0C 06 DC 40 29 3B 17 4C  FA 08 40 29 50 A2 13 BB  ...@);.L..@)P...
00000010  06 40 29 51 0F 13 EB 07  40 10 C0 DD 97 0D 03 06<EMAIL_ADDRESS>00000020  56 40 3C 6A A5 CC FB 12  0A EA 7F DC E9 B7 A0 45<EMAIL_ADDRESS>00000030  0B 04 6A 7F DC E9 B6 A0  41 10 04 7D 00 00 00 00  ..j....A..}....
00000040  DC 00 08 C4 92 41 B1 EA  9F DF 00 0F 00 08 C4 92  .....A..........
00000050  03 F4 00 00 00 00 00 00  22 4E 01 22 4F 01 73 03  ........"N."O.s.
00000060  22 50 01 6C 00 00 0C AB  57 00 00 00 00 00 00 00  "P.l....W.......
00000070  00 00 00 00 00 00 C1 00  32 FF FF FF FF FF FF 00  ........2.......
00000080  03 B2 00 03 00 07 A2 7D  53 79 73 74 65 6D 00 00  .......}System..
00000090  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  ................
000000A0  00 00 00 00 00 00 00 00  73 04 73 00 77 00 01 3F  ........s.s.w..?
000000B0  6A 01 90 0B 8B 04 51 00  07 03 FA 00 01 77 00 01  j.....Q......w..
000000C0  3F 6A 01 90 0B 8B 04 51  00 07 03 FA 00 01 73 01  ?j.....Q......s.
000000D0  73 02 6C 00 00 00 00 00  03 00 00 00 00 00 00 00  s.l.............
000000E0  00 00 00 00 00 78 00 7E  00 08 C4 92 01 90 0B 8C  .....x.~........
000000F0  04 4D 00 82 03 EA 80 01  40 3F 3C F5 0E 75 15 40  .M......@?<..u.@
00000100  3F 45 80 2D 32 02 40 20  76 88 14 4F 0D 40 28 D5  ?E.-2.@ v..O.@(.
00000110  EF 14 4E 13 40 19 3A 1B  9C 08 04 04 8E 40 19 3A  ..N<EMAIL_ADDRESS>00000120  DF D6 7B 0C 06 DC 40 29  3B 17 4C FA 08 40 29 50  ..{...@);.L..@)P
00000130  A2 13 BB 06 40 29 51 0F  13 EB 07 40 10 C0 DD 97<EMAIL_ADDRESS>00000140  0D 03 06 56 40 3C 6A A5  CC FB 12 0A EA 7F DC E9<EMAIL_ADDRESS>[TRUNCATED]```

that packet ID has a loop in it's read logic and i think its one of the ones that lands in circular buffer.

This looks like it should add stability to packet reads. Helping to alleviate incorrect offsetting of packet data.

I built with this last night and still experienced the issue after a couple hours. I got the endless page flipping book and frozen character. I've been using this script to recreate. still takes a few hours sometimes.
Walk("West")
Walk("West")
Walk("East")
Walk("East")
UseSkill("Arms Lor")
WaitForTarget(2000)
Target("last")
Pause(2000)
UseSkill("Hidin")
Pause(3000)

This looks like it should add stability to packet reads. Helping to alleviate incorrect offsetting of packet data.

I built with this last night and still experienced the issue after a couple hours. I got the endless page flipping book and frozen character. I've been using this script to recreate. still takes a few hours sometimes.
Walk("West")
Walk("West")
Walk("East")
Walk("East")
UseSkill("Arms Lor")
WaitForTarget(2000)
Target("last")
Pause(2000)
UseSkill("Hidin")
Pause(3000)

I think the issue you are experiencing here might be related to: https://github.com/ClassicUO/ClassicUO/issues/1674
There may be some other bug actually unrelated to this that it's now surfaced due to the fix.
But without this fix I was almost unable to use scripts, due to crashes, and so on.
Pauses in the script would alleviate it a little, but those were just a palliatives, and they should not be needed.

This looks like it should add stability to packet reads. Helping to alleviate incorrect offsetting of packet data.

I built with this last night and still experienced the issue after a couple hours. I got the endless page flipping book and frozen character. I've been using this script to recreate. still takes a few hours sometimes.
Walk("West")
Walk("West")
Walk("East")
Walk("East")
UseSkill("Arms Lor")
WaitForTarget(2000)
Target("last")
Pause(2000)
UseSkill("Hidin")
Pause(3000)

I think the issue you are experiencing here might be related to: #1674
There may be some other bug actually unrelated to this that it's now surfaced due to the fix.
But without this fix I was almost unable to use scripts, due to crashes, and so on. Pauses in the script would alleviate it a little, but those were just palliatives, and they should not be needed.

You may be right but I think the condition occurs when compressed packets are sent from the server and irritates the race condition. I'll reply to #1674 with some packet logs snips showing why I feel that way. I was getting the issue both before and after using your pull req. the playerupdate packet ID: 78 is one of the compressed packets as well as ID: AE. both are in my packetdumps from CUO but don't show up in a wireshark trace because they are compressed which shifts the byte data. I think it is the decompression of these packets that is creating the issue you and I are experiencing. It only occurs when a plugin is active in my experience though admittedly it's very difficult to test without macros. I'll stop derailing this thread and add to 1674


some docs updates

[x] Closes #2289 , closes #461, closes #2576

Hello @dcherian! Thanks for submitting the PR.

In the file xarray/core/alignment.py, following are the PEP8 issues :

Line 36:14: W605 invalid escape sequence '*'
Line 49:5: W605 invalid escape sequence '*'
Line 74:23: W605 invalid escape sequence '*'
Line 402:5: W605 invalid escape sequence '*'

In the file xarray/core/common.py, following are the PEP8 issues :

Line 355:62: W605 invalid escape sequence '*'
Line 355:70: W605 invalid escape sequence '*'
Line 355:72: W605 invalid escape sequence '*'
Line 355:80: E501 line too long (81 > 79 characters)
Line 377:26: W605 invalid escape sequence '*'
Line 377:34: W605 invalid escape sequence '*'
Line 377:36: W605 invalid escape sequence '*'

In the file xarray/core/dataarray.py, following are the PEP8 issues :

Line 635:9: W605 invalid escape sequence '*'
Line 635:11: W605 invalid escape sequence '*'
Line 660:9: W605 invalid escape sequence '*'
Line 660:11: W605 invalid escape sequence '*'
Line 679:9: W605 invalid escape sequence '*'
Line 679:11: W605 invalid escape sequence '*'
Line 1000:9: W605 invalid escape sequence '*'
Line 1000:11: W605 invalid escape sequence '*'
Line 1582:30: W605 invalid escape sequence '*'
Line 1582:32: W605 invalid escape sequence '*'
Line 1595:9: W605 invalid escape sequence '*'
Line 1595:11: W605 invalid escape sequence '*'

In the file xarray/core/dataset.py, following are the PEP8 issues :

Line 488:9: W605 invalid escape sequence '*'
Line 488:11: W605 invalid escape sequence '*'
Line 606:9: W605 invalid escape sequence '*'
Line 606:11: W605 invalid escape sequence '*'
Line 643:9: W605 invalid escape sequence '*'
Line 643:11: W605 invalid escape sequence '*'
Line 2904:30: W605 invalid escape sequence '*'
Line 2904:32: W605 invalid escape sequence '*'
Line 2915:9: W605 invalid escape sequence '*'
Line 2915:11: W605 invalid escape sequence '*'

@shoyer I've added a new page for Weather and Climate data. Let me know if this looks good.


Add DeleteGroupCommand

Add DeleteGroupCommand

Codecov Report

Merging #35 (85a8948) into master (f188cc8) will decrease coverage by 1.59%.
The diff coverage is 16.12%.

@@             Coverage Diff              @@
##             master      #35      +/-   ##
============================================
- Coverage     62.41%   60.82%   -1.60%
- Complexity      414      417       +3
============================================
  Files            84       86       +2
  Lines          1490     1529      +39
  Branches        154      163       +9
============================================
  Hits            930      930
- Misses          512      548      +36
- Partials         48       51       +3

Impacted Files
Coverage Δ

...va/seedu/address/logic/commands/AssignCommand.java
0.00% <0.00%> (ø)

...edu/address/logic/commands/DeleteGroupCommand.java
0.00% <0.00%> (ø)

.../seedu/address/logic/parser/AddressBookParser.java
69.56% <0.00%> (-3.17%)
:arrow_down:

.../seedu/address/logic/parser/CreateGroupParser.java
0.00% <0.00%> (ø)

...address/logic/parser/DeleteGroupCommandParser.java
0.00% <0.00%> (ø)

...in/java/seedu/address/logic/parser/ParserUtil.java
81.39% <0.00%> (-6.11%)
:arrow_down:

...c/main/java/seedu/address/model/person/Person.java
70.68% <0.00%> (-5.24%)
:arrow_down:

.../java/seedu/address/model/util/SampleDataUtil.java
23.52% <0.00%> (-1.48%)
:arrow_down:

...a/seedu/address/logic/parser/AddCommandParser.java
57.14% <52.63%> (-6.02%)
:arrow_down:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f188cc8...85a8948. Read the comment docs.


"Data file not found at " keep getting this error.

I was trying your sample, And i keep getting this error for file not found.
PATH - /storage/emulated/0/Pictures/image-ea1f7b95-141a-4d44-bc8f-8b76552833ed.jpg
Timeline: Activity_idle id: android.os.BinderProxy@c792cf time:191950033
25747-25918/com.ammobile D/RNTesseractOcr: Preparing tesseract enviroment
25747-25918/com.ammobile I/RNTesseractOcr: Created directory /storage/emulated/0/com.ammobile/tessdata
25747-25918/com.ammobile D/RNTesseractOcr: Start ocr images
25747-25918/com.ammobile E/RNTesseractOcr: Data file not found at /storage/emulated/0/com.ammobile/tessdata/eng.traineddata
25747-25917/com.ammobile I/ReactNativeJS: 'OCR Error: ', { [Error: Data file not found at /storage/emulated/0/com.ammobile/tessdata/eng.traineddata] framesToPop: 1, code: 'An error occurred' }

Got fixed: By mistake added file to wrong folder.

Hey @anupkale1984 I appreciate your support, that was my mistake because I omitted to mention it on the example section of the README
RNTesseractOcr: Data file not found at /storage/emulated/0/com.ammobile/tessdata/eng.traineddata

Can you please describe where i have to add tessdata files (https://github.com/tesseract-ocr/tessdata/tree/3.04.00) ?


Add short names for dynakube

Description
With this the short names dk and dks are added to the dynakube CRD. They can then be used with the kubectl get command like for example: kubectl get ds for daemonset.
How can this be tested?
Deploy operator with this CRD and try out these commands:

kubectl get dk
kubectl get dks

Checklist

[x] PR is labeled accordingly with a single label
[x] I have read and understood the contribution guidelines

LGTM, should we also add these for EdgeConnect, to be consistent? 🤔 (ec/ecs)

@waodim can you please create a ticket for that? :)


IE8 and earlier broken due to indexOf issue

The line:
return a.ua?0<=U(a.ua,5).indexOf("JS_THIRDEYE"):!1
Fails in IE8 and earlier with the error:
Object doesn't support property or method 'indexOf'
Adding in the usual indexOf polyfill does not fix the issue, maybe this is something handled internally.
Lots of reports of errors over the last 10 days or so on google groups about it.

I understand this is a PHP example, however maybe you can get in touch with the API devs, seems many having the same issue
https://groups.google.com/forum/#!topic/recaptcha/OCZ9LVfOdlo

I'm having this issue and would love to know a work around for my IE8 users.

@colecmc I ended up implementing reCaptcha v1 for <=IE8, and leaving v2 for others

Closing super old issues. Please re-raise if still relevant.


Bundle size increase in v1.4.2

After releasing v.1.4.2 to NPM I notice that the package install size has increased by 75% since v.1.4.1! 😱
See it on bundlephobia.
It might simply be because of the typescript file, but I really want to prevent size regressions if at all possible.
I will try to get to it next week, in the meantime if anyone finds the source of the increase, feel free to submit a PR, or let me know here.

It might simply be because of the typescript file, but I really want to prevent size regressions if at all possible.

Seems like the type definitions is the cause for the increase.  I don't think this has an effect on the bundle size when you build your app.
v.1.4.1

v.1.4.2


Person Details | Assign & Update Roles

Administrators should be able to add, change and remove roles from a Person on the People Details page.
Leverage the existing UI for adding/editing the roles of a Team Member.

Cherry picked to master. Going live now.


MONDO:0012356 glomerulocystic kidney disease with hyperuricemia and isosthenuria [Obsolete]

Mondo term (ID and Label)
MONDO:0012356 glomerulocystic kidney disease with hyperuricemia and isosthenuria
Reason for deprecation
OMIM 609886 MOVED TO 162000 AND 137920
Suggested term to consider
? Since the disease represented by the MIM number is split into two, not sure if there is a clear merge or if this should just be obsoleted. The other OMIM numbers are presumably already in Mondo and the CUI may not be active following the 2021AB release from UMLS.
Your nano-attribution (ORCID)
If you don't have an ORCID, you can sign up for one here

this is already tagged for obsoletion:
https://github.com/monarch-initiative/mondo/issues/1880#issuecomment-909821947
I will close this ticket. This will be obsoleted in the December release.


Improve performance of PDF viewer after hack introduced

See #28
Hack introduced in 0.2.2

The current way of point-and-click relies on forcefully rendering the entire PDF into memory, which, as expected, is very memory and computationally intensive. Further, the PDFs are rendered from page [1..n], meaning that the last page will always render last. This is non-ideal..
Optimisations:

Think of how to incorporate the logic used in Find to do forward PnC
Backward PnC done for every text layer render (this should be trivial)

If the above optimisations fail:

Hack again to forcefully render visible views first.

I tried today concat-ing the hacked getVisiblePages into a non-hacked one, meaning that the visible ones will render before all of them.
Eh, some mysterious exception--too hacky. When the need requires I'll find a way to do

Optimisations:

Think of how to incorporate the logic used in Find to do forward PnC

This is super high-effort, I hate pure JS, and the PDF.js codebase makes me sad, where types :(

Backward PnC done for every text layer render (this should be trivial)


declaration files missing

Current Behavior
no typescript declaration files (.d.ts) are output in the build
Expected behavior
declaration files should be included in build output
Suggested solution(s)
Not sure what the problem is
Additional context
I have a tsdx component library and I swapped it out with dts-cli but the build is missing declaration files. I didn't change anything except the scripts, package.json, and renamed tsdx.config.json to dts.config.json
Your environment

  System:
    OS: macOS 11.6
    CPU: (8) x64 Apple M1
    Memory: 26.42 MB / 16.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 16.13.2 - ~/n/bin/node
    Yarn: 1.22.17 - ~/n/bin/yarn
    npm: 8.1.2 - ~/n/bin/npm
  Browsers:
    Chrome: 97.0.4692.71
    Firefox: 95.0.2
    Safari: 15.0
  npmPackages:
    typescript: ^4.5.4 => 4.5.4
  npmGlobalPackages:
    typescript: 4.3.5

Does your package.json include types or typings entry?
Can you also post your tsconfig.json and dist directory listing after the build?

@aladdin-add this appears to be a regression from #117. I'll get a PR out shortly.


Results grid does not show results

Issue Type: Bug
A select query, nor insert/update/delete does not show results on the results tab. And also not showing in the messages tab
Azure Data Studio version: azuredatastudio-insiders 1.14.0-insider (39e6b9933d98002ce10ffa74f69e7d85d7df130b, 2019-11-27T21:06:43.843Z)
OS version: Windows_NT x64 10.0.18362

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-6700 CPU @ 3.40GHz (8 x 3408)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_offsurface_control: disabled_offsurface_synchronization: enabled_onvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
15.88GB (4.76GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (1)

Extension
Author (truncated)
Version

vim
vsc
1.9.0

Update: just opened a new query and executed the same query - results was shown.
It seems the results isn't shown for scripts being stored on a disk

@anthonydresser this is likely related to the query editor refactor.  I also don't see any results when running a query with a saved .SQL file.  Could you please take a look?
Here is an exception from the dev console.  Not sure if it's related:
Users/karlb/AppData/Local/Programs/Azure Data Studio - Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:6028 Uncaught TypeError: Cannot read property 'onResultSet' of undefined
    at j.set queryRunner [as queryRunner] (Users/karlb/AppData/Local/Programs/Azure Data Studio - Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:6028)
    at S.set queryRunner [as queryRunner] (Users/karlb/AppData/Local/Programs/Azure Data Studio - Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:6049)
    at S.onShow (Users/karlb/AppData/Local/Programs/Azure Data Studio - Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:6049)
    at h.showTab (Users/karlb/AppData/Local/Programs/Azure Data Studio - Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:1213)
    at HTMLDivElement.<anonymous> (Users/karlb/AppData/Local/Programs/Azure Data Studio - Insiders/resources/app/out/vs/workbench/workbench.desktop.main.js:1211)

I found the issue, It's related to the serialization stuff. I'll get a fix out soon and it should be in tonight's insiders.


es6 methods not working

i see that #283 was supposed to have closed this but this is still not working for me at least ..
class Foo {
  constructor(){
  }
  /** <TAB HERE>
  test(a,b){
  }

creates:
class Foo {
  constructor(){
  }
  /**
   * @param  {[type]}
   * @param  {[type]}
   * @return {[type]}
   */
  test(a,b){
  }

This is working for me.

What is the syntax highlighting settings for that file?

+1 since I also saw this issue. It was generating:
/**
 *  @method test
 *  @param  {[type]}
 *  @return {[type]}
 */

But then I saw @spadgos's formatting is Javascript (Babel) so I enabled that and then it worked fine. Try it, @matthiasg?

Same for me - doesn't work for JavaScript Next, works for JavaScript (Babel).