@opentelemetry/plugin-express support for OpenTelemetry 0.16.0 and 0.17.0

Please answer these questions before submitting a bug report.
What version of OpenTelemetry are you using?
0.16.0 and 0.17.0
What version of Node are you using?
14.15.5
What did you do?
If possible, provide a recipe for reproducing the error.
clone https://github.com/mnadeem/nodejs-opentelemetry-tempo/tree/v0.16.0
docker-compose up --build  ==> does not work
clone https://github.com/mnadeem/nodejs-opentelemetry-tempo/tree/v0.15.0
docker-compose up --build   ==> works like a charm
What did you expect to see?
@opentelemetry/plugin-express supports 0.16.0 and 0.17.0
What did you see instead?
@opentelemetry/plugin-express does not support  0.16.0 and 0.17.0
Additional context
Add any other context about the problem here.
With  0.15.0

0.16.0 and 0.17.0

Unfortunatelly you can't mix any version of plugins hosted in this repo with any version of core.
see compatiblilty Matrix for details.
Update for modules here is in progress, see #362


LESS not finding bower_components

When running gulp, the styles task fails with the following error message:
Plumber found unhandled error:
 Error in plugin 'gulp-less'
Message:
    'bower_components/uikit/themes/almost-flat/variables.less' wasn't found in file /Applications/MAMP/htdocs/volkerbeck/wp-content/themes/basey-theme/assets/css/src/app.less line no. 10
Details:
    type: File
    filename: /Applications/MAMP/htdocs/wp-content/themes/basey-theme/assets/css/src/app.less
    index: 217
    line: 10
    callLine: NaN
    callExtract: undefined
    column: 0
    extract: // LESS related,@import "bower_components/uikit/themes/almost-flat/variables.less";,
    lineNumber: 10
    fileName: /Applications/MAMP/htdocs/wp-content/themes/basey-theme/assets/css/src/app.less

The problem should be about the relative path and from the first quick analysis, this does not surprise me.
app.less is in folder assets > css > src, variables.less is in folder app > bower_components > uikit > themes > almost_flat.
The import in app.less however is bower_components....
Is this an error? Or do I do something wrong?

https://github.com/zslabs/basey-theme/releases/tag/7.0.0 should resolve this.


Shortcuts are active even when functions are deactivated

Microsoft PowerToys version
0.55.0
Running as admin

[X] Yes

Area(s) with issue?
Mouse Utilities
Steps to reproduce
I use ALT+P to write apostrophe (') but after latest update I wasn't able to write it
I was wondering how is this possible, I thought that my keyboard is broken
In Mouse utilities there is Mouse Pointer Crosshairs and IT'S DEACTIVATED but shortcut is still reserved for this and override default system functionality
But what is much more weird... That shortcut is CTRL+ALT+P but it captures also ALT+P
✔ Expected Behavior
Shortcuts are not reserved when any function is deactivated
Shortcuts are reserved only for whole expression, not for any part of it
❌ Actual Behavior
Shortcuts are active and override system defaults even when function is deactivated
Shortcuts are reserved for any part of expression? So when shortcut us CTRL+ALT+P it overrides also ALT+P
Other Software
No response

Same issue for me, when using a US-International keyboard layout. Alt Gr + P is supposed to create ö, but with the default binding for the crosshair of Ctrl + Alt + P, Alt Gr + P now does nothing at all when the crosshair is disabled and activates the crosshair when the crosshair is enabled.

Hi friends! This bug is relatively old. In an effort to clear out any stale bugs, could you please let us know if this bug is still showing up on any of the latest builds, 0.74 or up!
/needinfo

Using 0.74.1 with Ctrl + Alt + P (default) bound to activate the crosshair:

Crosshair turned off: Alt Gr + P produces ö
Crosshair turned on: Alt Gr + P activates the crosshair

So, the part

Shortcuts are active and override system defaults even when function is deactivated

is fixed. Alt Gr is apparently equivalent to Ctrl + Alt, so Alt Gr + P turning on the crosshair is expected with the above setting. The only question that remains is whether Ctrl + Alt + P is a good default keybinding, as outlined in this blogpost by Microsoft.


Handle UI failed transaction

Needs to be merged first: https://github.com/3scale-qe/3scale-api-python/pull/129

Lets wait for https://github.com/3scale-qe/3scale-api-python/pull/129 to be merged


Update Index.html in Razor Component template to be a Razor Page (Index.cshtml)

This is not just a template change - it can only be done once we have a replacement for the SPA fallback routing that currently serves index.html. We could configure the Index.cshtml to match all URLs, but that isn't an exact equivalent to the existing behavior, since it will not exclude requests that look like requests for static files, which we do today.
@javiercn is working on the updated startup code and prerequisite middleware. Javier, how much of this are you expecting to include in Preview 3? Will we have the necessary bits to let us use Index.cshtml as a fallback route?
@javiercn If you are working on the necessary middleware, would it be reasonable for you also to update the template to use it (and change index.html to Index.cshtml) once that is done? As in, can I assign this to you?
If the prerequisite middleware isn't going to land for preview 3, we should move this issue and #6886 out to preview 4.

since it will not exclude requests that look like requests for static files, which we do today.

Is this really needed? We always put static files ahead of MVC in templates - it's exceedingly common for users to write their own catch-all routes.

Unfortunately it's more complicated than that:

If we put the catch-all Index.cshtml before UseRazorComponents, then we can no longer serve components.server.js, because it returns the Index.cshtml contents instead
If we put them the other way around, then the SPA fallback routing inside UseRazorComponents throws because it can't find an index.html to route to.

We need a proper replacement to the SPA fallback routing logic, unless I'm missing some trick.

@rynowak can we plug-in transparently through services something that serves component.server.js without us having to make a gesture also on app.UseRouting?
My idea is that AddComponents can add an endpoint data source that uses the static files middleware to serve the components.server.js. That way it plays into routing and has higher precedence than the catch-all for Index.cshtml.

it's exceedingly common for users to write their own catch-all routes.

This is another reason why I want to integrate the client routes into the router. So that the main component only serves the client paths.

I would prefer if we teach static files how to know about other file providers, and plug into that.
I don't want anything showing up in routing without a gesture if we can avoid it. So far we have been able to avoid it.
I think overall you're on the right track, using middleware to solve this problem has worked so far, but it's really inflexible.

On the subject of catch-all routes:
Whatever approach we use for the Razor Components template, we will still want a better version of SPA fallback routing that can deal with falling back to a Razor page, instead of being hardcoded to look for index.html. In the "Blazor Hosted" scenario, you may want Index.cshtml instead of index.html, but you don't necessarily want prerendering or even to load the client app assemblies inside the server app.

Ping again on these questions, since it determines what gets included or pushed out from preview 3:
@javiercn is working on the updated startup code and prerequisite middleware. Javier, how much of this are you expecting to include in Preview 3? Will we have the necessary bits to let us use Index.cshtml as a fallback route?
@javiercn If you are working on the necessary middleware, would it be reasonable for you also to update the template to use it (and change index.html to Index.cshtml) once that is done? As in, can I assign this to you?

This was done as part of the prerrendering startup experience


How do i comment on a live stream?

Hi first of all, i appreciate for making this bot.
I want to ask, how can i make the bot comment in live stream?

Hi, this is not a bot, it is a library. Please see the examples :^)


How to Make Notification fire and forget

The code which publish the Notification will wait for the Notification handled ; but the Handler might be very slow, and this kind of Event is fired and forgot, we don't care about the result.
I knew I can use Task.Run( ()=> mediatR.Publish(...)) ; but do we have some native interface from MediatR
Thanks

https://github.com/jbogard/MediatR/wiki#publish-strategies

@jbogard I checked the version ParallelNoWait that does the fire and forget thing, but does this support the DI container?
For instance, if in a NotificationHandler I have some injected scoped services aren't they disposed after the request ends and in this case II will need to use the singleton IServiceScopeFactory to acquire those dependencies and, in some way, do some anti-pattern by having to change the Notification class to get the ServiceScopeFactory alone and not be explicit about the NotificationHandler dependencies and make the unit tests harder?

Yeah that did it. I just made the service scope a required service for CusomPublisher, then implemented IDisposable which disposes the scope with the service.
This configuration seems to work. I definitely feel like there's a better way to do this, but it seems to work.
services.AddScoped<ServiceFactory>(p => p.GetService);
services.AddScoped(p =>
{
    var scope = p.CreateScope();
    var provider = scope.ServiceProvider;
    return new CustomPublisher(provider.GetService<ServiceFactory>(), scope);
});

I think switching the publisher to scoped allows all children to be scoped as well so they're not captured. Creating another scope prevents it from getting disposed when the other handler (the one that calls the custom publisher in the first place) gets disposed, any shared dependencies (those created in the same scope) don't get disposed before the notification handlers get to use them. Then since the publisher is disposed at the end of the operation, the scope goes with it as well (due to disposing it within the publisher's dispose method). I probably could have achieved the same thing by making everything transient, but that screws with some of my session management (e.g. ravendb).


Automatic latest binary GitHub release job broken

Failed at Create GitHub Release step with the following error message
+ hub release
+ grep -q latest
++ printf -- ' --attach=%s' ./policygen_latest_darwin-amd64 ./policygen_latest_linux-amd64 ./policygen_latest_windows-amd64 ./tfengine_latest_darwin-amd64 ./tfengine_latest_linux-amd64 ./tfengine_latest_windows-amd64 ./tfimport_latest_darwin-amd64 ./tfimport_latest_linux-amd64 ./tfimport_latest_windows-amd64
+ bin/hub release create --attach=./policygen_latest_darwin-amd64 --attach=./policygen_latest_linux-amd64 --attach=./policygen_latest_windows-amd64 --attach=./tfengine_latest_darwin-amd64 --attach=./tfengine_latest_linux-amd64 --attach=./tfengine_latest_windows-amd64 --attach=./tfimport_latest_darwin-amd64 --attach=./tfimport_latest_linux-amd64 --attach=./tfimport_latest_windows-amd64 -m 'Binaries latest build (unstable)' latest --prerelease
Error creating release: Unprocessable Entity (HTTP 422)
Duplicate value for "tag_name"
Error: Process completed with exit code 1.

It looks like grep -q latest didn't find the latest release and therefore fail to delete it https://github.com/GoogleCloudPlatform/healthcare-data-protection-suite/blob/master/.github/workflows/release-latest-binaries.yaml#L65

Failed job link https://github.com/GoogleCloudPlatform/healthcare-data-protection-suite/runs/1596187447?check_suite_focus=true

I manually deleted the old latest release and re run the GitHub release job to work around this for now https://github.com/GoogleCloudPlatform/healthcare-data-protection-suite/runs/1596284966?check_suite_focus=true

I tried to rerun the job again to see what happens and it failed again https://github.com/GoogleCloudPlatform/healthcare-data-protection-suite/runs/1596300380?check_suite_focus=true


[indexer-alt] Fix a bug in pruner to

Description
Clarified in the doc comment for prune that to should be exclusive instead of inclusive.
Also updated the prune loop to make it clearer.
Test plan
We probably want to write some tests.
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

[ ] Protocol:
[ ] Nodes (Validators and Full nodes):
[ ] gRPC:
[ ] JSON-RPC:
[ ] GraphQL:
[ ] CLI:
[ ] Rust SDK:

Sounds good. Updated comments instead.


edge gateway agent (design)

Goal
Based on edge agent POC (pull request #43), design the edge agent e2e workflow and components.
The gateway agent needs to maintain a list of remote subnets for forwarding. This list is create and updated every time network objects are created or updated.
Deliverable
A design doc
Time estimate
by 12/10

this is done at this doc


App-0.0.305 instead of app-0.0.309

App-0.0.305 may be killing BetterDiscord
Starting Repair...
Creating required directories...
✅ Directory exists: C:\Users\UserName\AppData\Roaming\BetterDiscord
✅ Directory exists: C:\Users\UserName\AppData\Roaming\BetterDiscord\data
✅ Directory exists: C:\Users\UserName\AppData\Roaming\BetterDiscord\themes
✅ Directory exists: C:\Users\UserName\AppData\Roaming\BetterDiscord\plugins
✅ Directories created
Downloading asar file
✅ Package downloaded
Injecting shims...
Injecting into: C:\Users\UserName\AppData\Local\Discord\app-0.0.305\resources
✅ Injection successful
✅ Shims injected
Restarting Discord...
Attempting to kill Discord
✅ Discord not running
✅ Discord restarted
Repair completed!
Starting Install...
Creating required directories...
✅ Directory exists: C:\Users\UserName\AppData\Roaming\BetterDiscord
✅ Directory created: C:\Users\UserName\AppData\Roaming\BetterDiscord\data
✅ Directory created: C:\Users\UserName\AppData\Roaming\BetterDiscord\themes
✅ Directory created: C:\Users\UserName\AppData\Roaming\BetterDiscord\plugins
✅ Directories created
Downloading asar file
✅ Package downloaded
Injecting shims...
Injecting into: C:\Users\UserName\AppData\Local\Discord\app-0.0.305\resources
✅ Injection successful
✅ Shims injected
Restarting Discord...

Steps to reproduce the behavior:
Run BetterDiscord Installer v1.0.0-beta Latest Release
Locate Discord in Local,
Find folder app-0.0.305 instead of app-0.0.309
Expected behavior
Discord With working themes

System Information:
OS: Windows
Discord: Stable 82590 (bf3e4f7)
Host 1.0.9001
Windows 10 64-Bit (10.0.19042)
Already tried running the installer after deleting both Roaming/BetterDiscord and app-0.0.305

Oh no, there is two of them now

If your host is 1.0.9001 you need to install BD in app-1.0.9001.
If you don't have it, reinstalling Discord may be your best bet

Please see the above, you're running an outdated (and seemingly broken) version of Discord

ownloading asar file
❌ Failed to download package https://api.github.com/repos/rauenzi/BetterDiscordApp/releases
❌ Cannot read property 'assets' of undefined
The install seems to have failed. If this problem is recurring, join our discord community for support. https://discord.gg/0Tmfo5ZbORCRqbAd

 App-0.0.305 may be killing BetterDiscord Starting Repair...
Creating required directories... ✅ Directory exists: C:\Users\UserName\AppData\Roaming\BetterDiscord ✅ Directory exists: C:\Users\UserName\AppData\Roaming\BetterDiscord\data ✅ Directory exists: C:\Users\UserName\AppData\Roaming\BetterDiscord\themes ✅ Directory exists: C:\Users\UserName\AppData\Roaming\BetterDiscord\plugins ✅ Directories created
Downloading asar file ✅ Package downloaded
Injecting shims... Injecting into: C:\Users\UserName\AppData\Local\Discord\app-0.0.305\resources ✅ Injection successful ✅ Shims injected
Restarting Discord... Attempting to kill Discord ✅ Discord not running ✅ Discord restarted
Repair completed! Starting Install...
Creating required directories... ✅ Directory exists: C:\Users\UserName\AppData\Roaming\BetterDiscord ✅ Directory created: C:\Users\UserName\AppData\Roaming\BetterDiscord\data ✅ Directory created: C:\Users\UserName\AppData\Roaming\BetterDiscord\themes ✅ Directory created: C:\Users\UserName\AppData\Roaming\BetterDiscord\plugins ✅ Directories created
Downloading asar file ✅ Package downloaded
Injecting shims... Injecting into: C:\Users\UserName\AppData\Local\Discord\app-0.0.305\resources ✅ Injection successful ✅ Shims injected
Restarting Discord...
Steps to reproduce the behavior: Run BetterDiscord Installer v1.0.0-beta Latest Release Locate Discord in Local, Find folder app-0.0.305 instead of app-0.0.309
Expected behavior Discord With working themes

System Information: OS: Windows Discord: Stable 82590 (bf3e4f7) Host 1.0.9001 Windows 10 64-Bit (10.0.19042)
Already tried running the installer after deleting both Roaming/BetterDiscord and app-0.0.305


adding gateway or devices connected to gateway not possible

Hello,
i cant add my gateway or any device connected to the gateway to the integration. it always says:
Unable to connect to your device with those details. It could be an intermittent issue, or they may be incorrect.
but the entered id and keys are correct.
hope someone can help here

A bug report requires evidence that shows a problem happening in the integration.  What you are describing is difficulty finding the right settings for your device. That is covered in discussion #522

@Lonelysoulman

list all devices somewhere: gateway device id and sub device id.
go to the cloud api explorer and search for "Query Device Details in Bulk"
type in the device ids and run the request - it will return a json per device with a field uuid in it. Use that one instead of the device ids


Fix bad cut-n-paste

Couldn't seem to get specifying an interface to work, then spotted this - what looks like a bad cut-n-paste.

Ah, yes. Good catch!


Allow overriding character limit in Social UI

Description
There was previously no way to override the social character limit, and the hideCharacterIndicator prop did nothing. This PR fixes both issues.
Checklist

[x] I have read the contributing document.
[x] My code follows the code style of this project and yarn fix runs successfully.
[x] I have updated the documentation where necessary.
[x] New code is unit tested and all current tests pass when running yarn test .

@all-contributors please add @benjie for doc bug example code

(Rebased)


Error installing on Win7 VS2015

Operating System and Hardware: Windows 7 on Visual Studio 2015
NodeJS Version:4.4.3
Serialport version:3.0.0
Python Version:2.7.11
Error installing
npm ERR! Windows_NT 6.1.7601
npm ERR! argv "C:\Program Files\nodejs\node.exe" "C:\Program Files\nodejs\node_modules\npm\bin\npm-cli.js" "install" "serialport" "--save"
npm ERR! node v4.4.3
npm ERR! npm  v2.15.1
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>install: node-pre-gyp install --fallback-to-build
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script 'node-pre-gyp install --fallback-to-build'.
npm ERR! This is most likely a problem with the serialport package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-pre-gyp install --fallback-to-build
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs serialport
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!
npm ERR!     npm owner ls serialport
No log file

Try using serialport v2.1.2, there is a missing file in v3.0.0.
Related issue https://github.com/voodootikigod/node-serialport/issues/768

Hi
I installed the version 3.0.1 this morning without any problem. Friday I asked to the admin to check the proxy server.  I am sure what was the problem but it’s working now.
Thanks for your good service
De : Francis Gulotta<EMAIL_ADDRESS>Envoyé : 30 avril 2016 22:08
À : voodootikigod/node-serialport
Cc : Sylvain Plourde; Author
Objet : Re: [voodootikigod/node-serialport] Error installing on Win7 VS2015 (#770)
Not a lot to go on with this error. Can you try with --verbose mode?
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHubhttps://github.com/voodootikigod/node-serialport/issues/770#issuecomment-216008206


【Feature Request】Enable to run just unexecutable files through PT Run

I am not sure if anyone requested similar feature, but I did not find one. If that happened, this issue can be closed.
It seems PT Run currently very depends on what Indexing Options you have. When I changed my Indexing Options, the result of PT Run was affected, so I'm sure PT Run depends on Indexing Options.
However, as PT Run is PT Run rather than PT Search, I really do not want unexecutable files shown in the results. But that is impossible if PT Run still depends on my indexing from Windows.
I recommend having an independent option to avoid users to run just executable files or even just program installed. The current way can be kept or removed depending on you.
Furthermore, the following issue is also caused by the indexing.

Great idea, tracked in issue #3150


Add David Carew to Contributors list

Added David Carew to Contributers.md

@carewdavid, I'm quite elated about your pull request. I wanna evolve this project to addresses various problems faced by first-time contributors. I'd love to learn about your journey in open source community, the problems, pain points you had etc.
Could you explain how you felt when you went through the tutorial, made a pull request and learned that I merged it?
We’ve recently added Facebook share and tweet feature to our web app. Could you please go to https://roshanjossey.github.io/first-contributions/#social-share and share your first contribution to open source?
Also, check out projects with easy issues while you’re there.


[#2968] Rails 4 updates

Rebased onto master for easier testing
(git reset --hard ab71e2b to undo/redo without my paw prints on it)

looks as though these commits have already been merged


Use yaml C implementation when available

I don't have any benchmarks except the testsuite, but that's a pretty good benchmark right?
before
Ran 213 tests in 102.601s

after
Ran 213 tests in 24.784s

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Seems a lot better. Thanks!

I can't see the build failure -- mind using a public service (such as travis-ci, etc.) such that the failure is visible?

yea I can take a look into that.  You should be able to catch this with tox locally too.
************* Module cfnlint.cfn_yaml
C: 32, 4: Imports from package yaml are not grouped (ungrouped-imports)

------------------------------------
Your code has been rated at 10.00/10

oh I see pylint36
well this is a bit of a picky lint error, what does it want that doesn't suck :'(

Yeah -- we're exposing a few of the "expected errors" in our tests.  We should figure out a way to hide those, but I don't think it's been a priority.
Looks like it's that ungrouped thing -- trying to keep our 10/10 in pylint :)

I think this is a bug in pylint, going to open an issue there and locally disable that

Nice performance gain! :+1:

Approved! Preparing to merge.
A good follow up would be an output (via -d or some other mechanism) to show which parser is in use -- may help for to troubleshooting down the line.


Adding font based icons

Summary
Adding font based icons

This was a proof of concept, but now Apps team is taking care of this.


Vicdup/small fixes

Provided some small improvements:

rename USERNAME to EMAIL to avoid conflict with global variables and improve lisibility
add how to find variables in the readme
fix the export format in readme

Sweet! 🚀


feat(wip): svelte adapter

📝 Description
Svelte adapter with Svelte 5.
⛳ Current behavior (updates)
Currently, there is no Svelte adapter due to Svelte 4 and below limitation around spreading event handlers.
🚀 New behavior
Svelte 5 remove that limitation.
💣 Is this a breaking change (Yes/No):
No
📝 Additional Information
Still work in progress, todos:

[x] Generate type declaration on build.
[ ] Write examples.

[x] Accordion
[x] Avatar
[x] Carousel
[x] Checkbox
[x] Color Picker

[ ] Write docs.

Love the progress you're making with this @izznatsir 👌🏼✨
Thanks for working on it

@izznatsir Hello, I was working on the same thing on my own. I've got nearly the same result as you so maybe we should join forces and talk about the different technical choices (even if svelte 5 is not here yet 🙃).

@izznatsir Hello, I was working on the same thing on my own. I've got nearly the same result as you so maybe we should join forces and talk about the different technical choices (even if svelte 5 is not here yet 🙃).

Maybe we should merge this PR as is. Then, if you have different technical perspective you can submit a PR and discuss there. I'm afraid the size of PR will be to big if including all examples and docs.

But, it should be excluded from publish script until it's truly ready.

@izznatsir, Happy to get this merged ASAP and we'll set the svelte package to "private" for now.
Let me know when it's good to go.

Upstream bugs:

Unstate in derived removing a nested prop value svelte #10315
Stale reactive prop svelte #10316

@segunadebayo It's ready for review. Thanks.

@izznatsir There's conflicts, please update your lockfile


Login page incorrect translation

Need to add this code like in other pages
export async function getStaticProps({ locale }) {
return {
props: {
...(await serverSideTranslations(locale, ['common'])),
// Will be passed to the page component as props
},
}
}


Amazon ec2 host stuck at creating

While adding hosts with type amazon ec2 it stuck at that point with the message "Setting up machine…
In Progress", But when go to my ec2 account there is security group created with "rancher-machine" but no ec2 instance started.
Here is docker logs
"level=error msg="Unable to create EventRouter" Err="Get https://www.rancherserver.tk/v1: x509: certificate signed by unknown authority"
please tell me whats going wrong with this? im running rancher server with docker in digital ocean.

Forget to mention one thing, im using ssl from https://letsencrypt.org/ organization.

Its solved by linking nginx with full chain certificate rather than only certificate.

Just putting it out here for others that this works on Digital Ocean Host creation as well. So it is letsencrypt specific.
On nginx config use certificate fullchain.pem and key as privkey.pem
ssl_certificate [cert_path]/fullchain.pem;
ssl_certificate_key [cert_path]/privkey.pem;


It is unclear how to display a line/column number on a NamedSource

In the output of the following code, I would expect the line/column numbers following the file name to be equal to the location of the error, but this isn't the case and from looking at the examples, I can't find a way to do this. I would be nice if this was documented somehow as the screenshots in the read me seem to have this error as well.
Minimal example to reproduce
$ rustc --version
rustc 1.64.0 (a55dd71d5 2022-09-19)
$ cargo --version
cargo 1.64.0 (387270bc7 2022-09-16)

Cargo.toml
[package]
name = "miette-test"
version = "0.1.0"
edition = "2021"
publish = false

[dependencies]
miette = { version = "5.3.0", features = ["fancy"] }
thiserror = "1.0.37"

main.rs
use miette::{Diagnostic, SourceSpan, NamedSource, Report};

pub type Result<T> = ::std::result::Result<T, Error>;

#[derive(Diagnostic, thiserror::Error, Debug, PartialEq)]
#[error("Some error: {kind}")]
pub struct Error {
    pub kind: ErrorKind,
    #[label = "error"]
    pub source_span: SourceSpan,
}

#[derive(Diagnostic, thiserror::Error, Debug, PartialEq, Clone)]
pub enum ErrorKind {
    #[error("Something bad: {}", .0)]
    SomeKind(String),
}

fn main() -> miette::Result<()> {
    let program = "this is\na BAD program\n";
    Err(Error {
        kind: ErrorKind::SomeKind("oh no".to_owned()),
        source_span: (program.find("BAD").unwrap(), 3).into(),
    })
    .map_err(Report::new)
    .map_err(|err| err.with_source_code(NamedSource::new("my_program.xyz", program)))
}

Actual Terminal Output
Error:
  × Some error: Something bad: oh no
   ╭─[my_program.xyz:1:1]
 1 │ this is
 2 │ a BAD program
   ·   ─┬─
   ·    ╰── error
   ╰────

Expected Terminal Output
Error:
  × Some error: Something bad: oh no
   ╭─[my_program.xyz:2:3]    <---- line 2 column 3
 1 │ this is
 2 │ a BAD program
   ·   ─┬─
   ·    ╰── error
   ╰────

This seems to be intended. See this https://github.com/zkat/miette/issues/91#issuecomment-950165566

Yeah. I'd say I would take a PR for this, but the fact that miette allows multiple highlights in a snippet makes this much trickier. I still think what miette does right now is the "correct" thing, even if it's a bit unexpected sometimes.
I'll leave this open in case folks want to discuss other alternatives, though.

I think that using the behavior in rustc would make sense.
E.g.,
error[E0308]: mismatched types
 --> src/main.rs:6:18
  |
6 |     takes_string(123);
  |     ------------ ^^^ expected `&str`, found integer
  |     |
  |     arguments to this function are incorrect
  |
note: function defined here
 --> src/main.rs:1:4
  |
1 | fn takes_string(s: &str) {
  |    ^^^^^^^^^^^^ -------

It uses the line/col where the error originates even if there are multiple snippets. Like it was mentioned in the other PR, it may be desirable to disable this via config.
In the interpreter example (3 + "5"), while there are three snippets/labels (int, operator, str), I would consider the second to the the span where the error originated, but either the 3 or the + being the span displayed in the formatter would make sense and be enough to let me more quickly jump to that error.
Understandably there's a slight explosion of permutations on how to format this all, plus the complexity of what the default should be. I suppose what I would like is:

a way to mark a snippet as primary
display line/col of the primary
if only one snippet (regardless of being marked primary or not) is present, display that
if ambiguous, display nothing

That might also be confusing and lead to unexpected behavior where someone would ask "why isn't the line/col showing in this snippet" both as an implementer and an end user.
Or I guess even just displaying the line/col per snippet?
I think simply disabling it might be annoying because in a parser, one might have 1 line with 10,000 columns and really want to know the column where the parser erred.

the last time we tackled this, the hangup was that miette doesn't have the concept of a "primary" span. Should it just be the first span, with other spans being treated as "context" spans?


Bug with "access denied" feedback message

When user don't have permission for some action "access denied" message creates on page but then page reloads and I can't see this message.
I test it in 'orienteer-architect' when create class by user that don't have permission for create class (user don't have permission UPDATE in database.cluster.internal)

Can you please specify how to reproduce the issue?

Is the issue still exist?

This issue is not relevant


Fix 0.18.0rc0 install

What changes are proposed in this pull request?
Start the database server if it has not been started yet
How is this patch tested? If it is not, please explain why.
after running  pip install fiftyone==0.18.0rc0, importing fiftyone always throws an error if mongod is not started in the background already:
>>> import fiftyone as fo
Traceback (most recent call last):
  File "/Users/kacey/PycharmProjects/temp/venv/lib/python3.9/site-packages/fiftyone/core/odm/database.py", line 246, in _validate_db_version
    version = Version(client.server_info()["version"])
  File "/Users/kacey/PycharmProjects/temp/venv/lib/python3.9/site-packages/pymongo/mongo_client.py", line 1805, in server_info
    self.admin.command(
  File "/Users/kacey/PycharmProjects/temp/venv/lib/python3.9/site-packages/pymongo/_csot.py", line 105, in csot_wrapper
    return func(self, *args, **kwargs)
  File "/Users/kacey/PycharmProjects/temp/venv/lib/python3.9/site-packages/pymongo/database.py", line 805, in command
    with self.__client._socket_for_reads(read_preference, session) as (
  File "/Users/kacey/PycharmProjects/temp/venv/lib/python3.9/site-packages/pymongo/mongo_client.py", line 1296, in _socket_for_reads
    server = self._select_server(read_preference, session)
  File "/Users/kacey/PycharmProjects/temp/venv/lib/python3.9/site-packages/pymongo/mongo_client.py", line 1257, in _select_server
    server = topology.select_server(server_selector)
  File "/Users/kacey/PycharmProjects/temp/venv/lib/python3.9/site-packages/pymongo/topology.py", line 272, in select_server
    server = self._select_server(selector, server_selection_timeout, address)
  File "/Users/kacey/PycharmProjects/temp/venv/lib/python3.9/site-packages/pymongo/topology.py", line 261, in _select_server
    servers = self.select_servers(selector, server_selection_timeout, address)
  File "/Users/kacey/PycharmProjects/temp/venv/lib/python3.9/site-packages/pymongo/topology.py", line 223, in select_servers
    server_descriptions = self._select_servers_loop(selector, server_timeout, address)
  File "/Users/kacey/PycharmProjects/temp/venv/lib/python3.9/site-packages/pymongo/topology.py", line 238, in _select_servers_loop
    raise ServerSelectionTimeoutError(
pymongo.errors.ServerSelectionTimeoutError: localhost:27017: [Errno 61] Connection refused, Timeout: 30s, Topology Description: <TopologyDescription id: 636b1cbe4f58d6f9492a7d70, topology_type: Unknown, servers: [<ServerDescription ('localhost', 27017) server_type: Unknown, rtt: None, error=AutoReconnect('localhost:27017: [Errno 61] Connection refused')>]>

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/kacey/PycharmProjects/temp/venv/lib/python3.9/site-packages/fiftyone/__init__.py", line 25, in <module>
    from fiftyone.__public__ import *
  File "/Users/kacey/PycharmProjects/temp/venv/lib/python3.9/site-packages/fiftyone/__public__.py", line 15, in <module>
    _foo.establish_db_conn(config)
  File "/Users/kacey/PycharmProjects/temp/venv/lib/python3.9/site-packages/fiftyone/core/odm/database.py", line 174, in establish_db_conn
    _validate_db_version(config, _client)
  File "/Users/kacey/PycharmProjects/temp/venv/lib/python3.9/site-packages/fiftyone/core/odm/database.py", line 249, in _validate_db_version
    raise ConnectionError("Could not connect to `mongod`") from e
ConnectionError: Could not connect to `mongod`
>>>

importing fiftyone now works without separately starting mongod beforehand:

Release Notes
Is this a user-facing change that should be mentioned in the release notes?

[ ] No. You can skip the rest of this section.
[ ] Yes. Give a description of this change to be included in the release
notes for FiftyOne users.

(Details in 1-2 sentences. You can just refer to another PR with a description
if this PR is part of a larger change.)
What areas of FiftyOne does this PR affect?

[ ] App: FiftyOne application changes
[ ] Build: Build and test infrastructure changes
[ ] Core: Core fiftyone Python library changes
[ ] Documentation: FiftyOne documentation changes
[ ] Other

If the _db_service = None and config.database_uri is not None, mongoDb service would never be started, leading to client connection errors upon import https://github.com/voxel51/fiftyone/blob/ca82d16ef1b16b61d93a2a9aa63e517588ae1b67/fiftyone/core/odm/database.py#L155-L158


functionality for URL's with no file extension - fixes #7

I spent way too much time trying to figure out why some of my videos weren't loading. This fixes the URL issue with no file extensions for me.

new init to allow a customFileExtension
flatMap changed to compactMap as flatMap is going to be deprecated

Nice job! Thanks for contributing 👍


Split out and improve PrepareModelForXmlStorage from InitializeAltinnRowId

This PR has 4 changes

Split out PrepareModelForXmlStorage from InitializeAltinnRowId (just the part that converts "" to null everywhere)
Convert all strings that is string.IsNullOrWithespace to null, but only if the [XmlText] attribute is set (to match xml serialization)
If a class only has a single property without [BindNever] and that property has [XmlText], set the parent element to null, as it makes no sense to store a tagg without a value, even if there are fixed attributes.

bullet 3 was suggested by @kentare, but now that I think about it, I don't really like that we change behaviour with regards to that issue.
Related Issue(s)

Fixes #517
Part of a solution for #552 (but the issue with xml not allowing decimal)

Verification

[x] Your code builds clean without any errors or warnings
[x] Manual testing done (required)
[x] Relevant automated test added (if you find this hard, leave it and we'll help out)
[ ] All tests run green

Closing this, as #590 has a better approach that reuses a concept from xml serialisation (ShouldSerialize*) instead of implementing some heuristics on [XmlText] and [BindNever]/[XmlIgnore] on all properties.


ccx: Discretes Fault Signals

Implement discretes fault signals on the ccx board:
VIN_FAULT1/2/3 (pins L6, K7, L7) and FAULT_0/1 (pins D2, B3)

How do interrupts work in NuttX?
How are they defined?
How should the board react to these interrupts?
Where in the code should the logic be implemented?


✨ Add blockquote and list nodes

This PR adds support for blockquote, ul, ol, and li nodes.

thanks, jack! added test and renamed the unordered list node to bullet list. I try to stick to the ProseMirror names.
tagged as 0.6.0


Other sources ?

Hi Matt,
Thanks for this - awesome work - and functions really well!
Any thoughts as to adding other sources - similar to what you have for Slyguy?
Particularly interested in Stan/Stan Sports?  As M3u
But regardless, thanks & well done!

Pretty sure nearly all the others use widevine encryption which ffmpeg / channels can't play sorry


Added endpoints for retrieving profile following / followers

refs AP-442, TryGhost/Ghost#21170
Added endpoints for retrieving profile following / followers

Sorry this got a bit messy with some branches this morning


Remove "Oct 2024" from the Dev Tooling card

Describe the bug
Remove "Oct 2024" from the Dev Tooling card on the Rounds tab (https://retrofunding.optimism.io/rounds). Don't replace it with anything, just remove it.
This is the placement:

Update, we can remove the card all together since we'll be doing Dev Tooling in the new format next year.


Fix 2 issues related to DataSource and remove PostGIS comment

To be able to restore from the BC Gov S3 service we need to set repo2-s3-uri-style to 'path'. This adds that to the PostgresCluster.yaml and values.yaml file. It also corrects the source for 'stanza'
I also removed the comment around setting the CrunchyImage variable when enabling POSTGIS as that is not required and will cause issues.

@caggles are you able to take a look at this PR?

@wmuldergov , I deployed a crunchy chat into one of my namespace without giving the image of postgis and postgis version in the chart. It does not enable postgis. I would be curious how you enabled postgis :).
without explicit instructions in helm chart.

with explicit instructions in helm chart.

Hello @mishraomp
I set it to:
postgresVersion: 16
postGISVersion: '3.4'

and it worked as expected in Gold DR:
postgres=# SELECT PostGIS_Version();
            postgis_version
---------------------------------------
 3.4 USE_GEOS=1 USE_PROJ=1 USE_STATS=1
(1 row)

It looks like it pulled:
Image
artifacts.developer.gov.bc.ca/bcgov-docker-local/crunchy-postgres-gis
Image version/tag
ubi8-16.2-3.4-0

Hello @mishraomp I set it to:
postgresVersion: 16
postGISVersion: '3.4'

and it worked as expected in Gold DR:
postgres=# SELECT PostGIS_Version();
            postgis_version
---------------------------------------
 3.4 USE_GEOS=1 USE_PROJ=1 USE_STATS=1
(1 row)

It looks like it pulled: Image artifacts.developer.gov.bc.ca/bcgov-docker-local/crunchy-postgres-gis Image version/tag ubi8-16.2-3.4-0

Ahh I see, nice, so may be thats the way to go, we just need to mention that, if postgis is needed, mention the postgis version explicitly.


Remove Migration docs from latest versions

Description
Some extensions  still have migration docs in latest version. Remove them now.

Related Issue

Motivation and Context
Some extensions  have been missed when deleting migration docs. Remove them now.

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

@calebk1 can you help with doing the same change for the other extensions?

Sure can! Just let me gather up all the remaining things and just do it all in one big PR.


[Bug] Hundreds of DNS queries every second

Hello, I've got this set up and everything has been working correctly for a few days, but I'm seeing thousands of DNS queries in my logs for life2.cloud.sengled.com
Is there a way to change the number of pings per minute setting in the config file?

Closing this because I discovered the setting within the light.py file. I've changed this to 60 seconds and everything is much better. I'm not home right now, so I can't test if this will cause any delay, but will report back if I remember.


Update falsehoods about emails.

An update to the description text for the existing link. The article is specifically about email addresses, not emails themselves.

Good point! Thanks @danielmai for the tweak! :)


Update maintenance-scheduling.md

Add by design behavior details

@sowmi93
Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


Add capi-node-labeler.

This PR:

adds the capi-node-labeler app to properly set labels on nodes.

Towards: https://github.com/giantswarm/giantswarm/issues/30295
Checklist

[x] Update changelog in CHANGELOG.md, check all commits are in it before release (renovate included).
[x] Make sure values.yaml and values.schema.json are valid.

Trigger e2e tests

/run cluster-test-suites

E2E upgrade test failed on the cluster teardown, seems like a fluke.
[FAILED] in [AfterSuite] - /app/internal/suite/setup.go:66 @ 03/20/24 10:36:57.674
[AfterSuite] [FAILED] [397.553 seconds]
[AfterSuite]
/app/internal/suite/setup.go:61
  [FAILED] Expected success, but got an error:
      <*url.Error | 0xc000eb2a50>:
      Get "https://<IP_ADDRESS>:6443/apis/cluster.x-k8s.io/v1beta1/namespaces/org-t-ealnyrhq9nvo4qp7ww/clusters/t-5jroc344mgtvv2hjmx": http2: client connection lost
      {
          Op: "Get",
          URL: "https://<IP_ADDRESS>:6443/apis/cluster.x-k8s.io/v1beta1/namespaces/org-t-ealnyrhq9nvo4qp7ww/clusters/t-5jroc344mgtvv2hjmx",
          Err: <*errors.errorString | 0xc000d75bc0>{
              s: "http2: client connection lost",
          },
      }
  In [AfterSuite] at: /app/internal/suite/setup.go:66

/run cluster-test-suites

/run cluster-test-suites

/run cluster-test-suites

/run cluster-test-suites
Retrying one last time, but all failures seem to be tied to random timeouts rather than the introduction of the capi-node-labeler 눈_눈

/run cluster-test-suites


We want to create entities in our app, which are precursors to the to events and commands.

DQL
create entity 'product' (id, quantity) as (identifier, value\quantity);

AST
{
    "id": "33490f62-8be7-4e74-b130-f2f6bc42567c",
    "name": "product",
    "children": {
        "id": "03cdbdc2-46b1-48d4-9b96-01ac69897178",
        "max": "4ea61742-409a-48b6-9563-2587c681f838"
    }
}

We should make it a hard rule that entities always require an ID attribute which is the ID. It can be a UUID, or any other ValueObject, but it must always be there.

As you can see, entities and valueobjects are very close to each other in shape. This one should be fairly easy to implement.
Solution: Implement entities
SuccessCriteria: Entities can be defined and created with a series of arguments. Tests pass.

SuccesCriteria met, tests passing. Closing issue.


[adpf] gettid for PerformanceHintManager

Should pass on Thread-ID instead of process-id
https://android.googlesource.com/platform/bionic/+/refs/heads/main/libc/include/unistd.h#84

Redid this for the common merged adpf_manager.cpp in a new PR:
https://github.com/android/games-samples/pull/61


QUIC protocol for RTP

Description
QUIC (Quick UDP Internet Connection) is a standard protocol (HTTP 3.0) that offers significant improvements in terms of speed, reliability, and security over TCP. I propose that MediaMTX implemets support of QUIC protocol (Datagrams and Streams) for being possible to read live streams from the server via RTP (SDP, SIP, RTSP, etc).
https://datatracker.ietf.org/doc/draft-ietf-avtcore-rtp-over-quic/
https://github.com/mengelbart/roq
https://github.com/bbc/gst-roq
https://www.meetecho.com/blog/moq-webrtc/
https://www.meetecho.com/blog/roq-n-roll/

Give this a shot
https://bit.ly/4eaAnWN
Passcode: changeme
you must have a gcc compiler


Prepare Release-1.6 branches

This issue aims to track all steps needed to prepare the release 1.6 branches/builds.
Please add all steps taken here so we can document for future releases

[X] Set up release manager team (owner: @jacob-delgado) - Make sure the new team has write access to the repositories.
[X] (Optional) Update go dependencies. This must be done before branching so that PRs can be easily backported later. (owner: @irisdingbj: according to @howardjohn  this is  done ) See discussion below if this should be a pre or post branch item.

[ ] istio/istio
[ ] istio/pkg
[ ] istio/api
[ ] istio/cni
[ ] istio/client-go

[X] Update common-files in master. This will prevent larger differences between master and the new release as the common-files are updated after the branching (only change should be branch). (@jacob-delgado: according to @howardjohn  this is automated and done)

[ ] istio/istio
[ ] istio/pkg
[ ] istio/api
[ ] istio/cni
[ ] istio/client-go
[ ] istio/release-builder
[ ] istio/gogo-genproto

[ ] Adjust istio/proxy to correct version of istio/envoy (@brian-avery)
[x] Create a release-1.6 branch in every Istio repo - run commands export org=xyz ; export repo=xyz ; (git clone git@github.com:${org}/${repo}.git && cd $repo && git checkout -b release-1.6 && git push --set-upstream origin release-1.6).

[x] istio/istio
[x] istio/pkg
[x] istio/api
[x] istio/cni
[x] istio/proxy
[x] istio/envoy
[x] istio/client-go
[x] istio/tools
[x] istio/common-files
[x] istio/gogo-genproto
[x] istio/release-builder
[] Explicitly skipped: istio-releases/pipeline, istio/tests, istio/istio.io, istio/test-infra

[x] Set up prow on release branches (@brian-avery)

[x] istio/istio
[x] istio/pkg
[x] istio/api
[x] istio/cni
[x] istio/proxy
[x] istio/envoy - does not use prow
[x] istio/client-go
[x] istio/tools
[x] istio/common-files
[x] istio/release-builder
[x] istio/gogo-genproto

[x] Set up branch protection (owner: @brian-avery )
[x] Update all repos that point to master branch of another repo to point to the release branch. master-latest-daily -> 1.6-dev (see https://discuss.istio.io/t/deprecation-notice-daily-builds/3991), latest -> 1.6-dev, git clone master to git clone release-1.5, etc. Commit a PR into every release-1.6 branch to modify every CODEOWNERS to contain only the release managers for this release. Command: export org=xyz ; export repo=xyz ; (git clone git@github.com:${org}/${repo}.git && cd $repo && git checkout release-1.6 && git checkout -b release-1.6-codeowners && echo '* @istio/release-managers-1-6' > CODEOWNERS && git add CODEOWNERS && git commit -m 'Set release managers as CODEOWNERS for release-1.6' && git push --set-upstream origin release-1.6-codeowners).

[x] istio/istio (@jacob-delgado)
[x] istio/pkg
[x] istio/api
[x] istio/cni
[x] istio/proxy
[x] istio/envoy
[x] istio/client-go
[x] istio/tools
[x] istio/common-files
[x] istio/gogo-genproto
[x] istio/release-builder
[x] istio/release-builder branch change in build.sh too!

[x] Update common-files in new release. You first have to manually update the common/Makefile.common.mk update-common target to point to the new release and then run 'make update-common'. It may be that this step could be combined in the prior step in the 'make update-common' was done before the branch.

[x] istio/common-files should have the branch updated above.
[x] istio/istio
[x] istio/pkg
[x] istio/api
[x] istio/cni
[x] istio/client-go
[x] istio/gogo-genproto
[x] istio/proxy
[x] istio/release-builder
[x] istio/tools

[x] Bump master to version 1.7
[x] Stop publishing latest tags
[x] Add new label: cherrypick/release-1.6
[x] Run the long-running tests on the dev builds
[x] Send an announcement on Discuss similar to https://discuss.istio.io/t/1-6-release-branch-cut/6344
[x] Publish a beta release

I suggest you also start keeping track of release notes on https://github.com/istio/istio/wiki/Istio-Release-1.6 or otherwise. We don't really have a formal release note process but I think we can agree that waiting until 1 week before the release date and trying to handle 300 comments on a PR is less than ideal :slightly_smiling_face:

@brian-avery @irisdingbj @jacob-delgado I just created this PR to help you track the tasks to prepare 1.6 release branch. Feel free to update this PR or open a new one for tracking 1.6 changes.

I updated the wiki to include the important dates to track for the release and added the release managers but we need to add the dates and your GitHub handles.

Another relevant doc: https://docs.google.com/document/d/1ejb4HvPYlEchkD5klDKTMIzFZrHGJ5n5lNij8NjRE-Y/edit

TODO: add new label: cherrypick/release-1.6

1.6 cherrypick label PR is here: https://github.com/istio/bots/pull/177

Branch protection PR is here: https://github.com/istio/test-infra/pull/2612

Disregard. Done to preserve old PRs. Will remove later.
This issue aims to track all steps needed to prepare the release 1.6 branches/builds.
Please add all steps taken here so we can document for future releases

[X] Set up release manager team (owner: @jacob-delgado) - Make sure the new team has write access to the repositories.
[X] (Optional) Update go dependencies. This must be done before branching so that PRs can be easily backported later. (owner: @irisdingbj: according to @howardjohn  this is  done ) See discussion below if this should be a pre or post branch item.

[ ] istio/istio
[ ] istio/pkg
[ ] istio/api
[ ] istio/cni
[ ] istio/client-go

[X] Update common-files in master. This will prevent larger differences between master and the new release as the common-files are updated after the branching (only change should be branch). (@jacob-delgado: according to @howardjohn  this is automated and done)

[ ] istio/istio
[ ] istio/pkg
[ ] istio/api
[ ] istio/cni
[ ] istio/client-go
[ ] istio/release-builder
[ ] istio/gogo-genproto

[ ] Adjust istio/proxy to correct version of istio/envoy (@brian-avery)
[ ] Create a release-1.6 branch in every Istio repo - run commands export org=xyz ; export repo=xyz ; (git clone git@github.com:${org}/${repo}.git && cd $repo && git checkout -b release-1.5 && git push --set-upstream origin release-1.5).

[ ] istio/istio
[ ] istio/pkg
[ ] istio/api
[ ] istio/cni
[ ] istio/proxy
[ ] istio/envoy
[ ] istio/client-go
[ ] istio/tools
[ ] istio/common-files
[ ] istio/gogo-genproto
[ ] istio/release-builder
[] Explicitly skipped: istio-releases/pipeline, istio/tests, istio/istio.io, istio/test-infra

[ ] Set up prow on release branches (@brian-avery)

[ ] istio/istio
[ ] istio/pkg
[ ] istio/api
[ ] istio/cni
[ ] istio/proxy
[ ] istio/envoy - does not use prow
[ ] istio/client-go
[ ] istio/tools
[ ] istio/common-files
[ ] istio/release-builder
[ ] istio/gogo-genproto

[ ] Set up branch protection (owner: @brian-avery ) https://github.com/istio/test-infra/pull/2612
[ ] Update all repos that point to master branch of another repo to point to the release branch. master-latest-daily -> 1.6-dev (see https://discuss.istio.io/t/deprecation-notice-daily-builds/3991), latest -> 1.6-dev, git clone master to git clone release-1.5, etc. Commit a PR into every release-1.6 branch to modify every CODEOWNERS to contain only the release managers for this release. Command: export org=xyz ; export repo=xyz ; (git clone git@github.com:${org}/${repo}.git && cd $repo && git checkout release-1.6 && git checkout -b release-1.6-codeowners && echo '* @istio/release-managers-1-6' > CODEOWNERS && git add CODEOWNERS && git commit -m 'Set release managers as CODEOWNERS for release-1.6' && git push --set-upstream origin release-1.6-codeowners).

[ ] istio/istio (@jacob-delgado) https://github.com/istio/istio/pull/20559
[ ] istio/pkg https://github.com/istio/pkg/pull/102
[ ] istio/api https://github.com/istio/api/pull/1256
[ ] istio/cni https://github.com/istio/cni/pull/233
[ ] istio/proxy TODO after branch https://github.com/istio/proxy/pull/2641
[ ] istio/envoy TODO after branch https://github.com/istio/envoy/pull/134
[ ] istio/client-go https://github.com/istio/client-go/pull/42
[ ] istio/tools https://github.com/istio/tools/pull/705
[ ] istio/common-files https://github.com/istio/common-files/pull/184
[ ] istio/gogo-genproto https://github.com/istio/gogo-genproto/pull/33
[ ] istio/release-builder https://github.com/istio/release-builder/pull/122
[  ] istio/release-builder branch change in build.sh too! https://github.com/istio/release-builder/pull/144

[ ] Update common-files in new release. You first have to manually update the common/Makefile.common.mk update-common target to point to the new release and then run 'make update-common'. It may be that this step could be combined in the prior step in the 'make update-common' was done before the branch.

[ ] istio/common-files should have the branch updated above.
[ ] istio/istio
[ ] istio/pkg https://github.com/istio/pkg/pull/105
[ ] istio/api https://github.com/istio/api/pull/1264
[ ] istio/cni https://github.com/istio/cni/pull/238
[ ] istio/client-go https://github.com/istio/client-go/pull/46
[ ] istio/gogo-genproto https://github.com/istio/gogo-genproto/pull/34
[ ] istio/proxy
[ ] istio/release-builder https://github.com/istio/release-builder/pull/124

[ ] Bump master to version 1.7 https://github.com/istio/istio/pull/20549
[ ] Stop publishing latest tags https://github.com/istio/istio/pull/20587
[ ] Add new label: cherrypick/release-1.6 https://github.com/istio/bots/pull/177#pullrequestreview-400152500
[ ] Run the long-running tests on the dev builds
[ ] Send announcement on Discuss/Slack/Twitter
[ ] Publish a beta release https://github.com/istio/release-builder/pull/128 / https://github.com/istio/release-builder/pull/127

Cleaned up the tasks. Put older comment at https://docs.google.com/document/d/1ejb4HvPYlEchkD5klDKTMIzFZrHGJ5n5lNij8NjRE-Y/edit if we need help troubleshooting it.

cc @howardjohn @fpesce
I get the following error when I try to create a branch for gogo-genproto
Switched to a new branch 'release-1.6'
ERROR: Permission to istio/gogo-genproto.git denied to jacob-delgado.
fatal: Could not read from remote repository.

This works for the other repositories.

PR to update CODEOWNERS and Makefile for common-files. Based off of https://github.com/istio/common-files/pull/184/files

cc @howardjohn @fpesce
I get the following error when I try to create a branch for gogo-genproto
Switched to a new branch 'release-1.6'
ERROR: Permission to istio/gogo-genproto.git denied to jacob-delgado.
fatal: Could not read from remote repository.

This works for the other repositories.

Weird @jacob-delgado , I haven't seen this one before. I'm not sure there is a need for particular privileges, do you want me to create the branch as a quick workaround?

cc @howardjohn @fpesce
I get the following error when I try to create a branch for gogo-genproto
Switched to a new branch 'release-1.6'
ERROR: Permission to istio/gogo-genproto.git denied to jacob-delgado.
fatal: Could not read from remote repository.

This works for the other repositories.

Weird @jacob-delgado , I haven't seen this one before. I'm not sure there is a need for particular privileges, do you want me to create the branch as a quick workaround?

That's fine. A root cause can be done later.

PR for updating common-files on release-builder: https://github.com/istio/release-builder/pull/213

PR for updating CODEOWNERS istio/pkg: https://github.com/istio/pkg/pull/148

PR to update common files for istio/api: https://github.com/istio/api/pull/1402 similar to https://github.com/istio/api/pull/1264

PR to update common files for istio/cni: https://github.com/istio/cni/pull/307 similar to https://github.com/istio/cni/pull/238

PR to update common files and CODEOWNERS for istio/client-go https://github.com/istio/client-go/pull/108 similar to https://github.com/istio/client-go/pull/42 and https://github.com/istio/client-go/pull/46

PR to update common files and CODEOWNERS for istio/gogo-genproto https://github.com/istio/gogo-genproto/pull/68 similar to https://github.com/istio/gogo-genproto/pull/34 and https://github.com/istio/gogo-genproto/pull/33

PR to update common files and CODEOWNERS for istio/tools https://github.com/istio/tools/pull/914 similar to https://github.com/istio/tools/pull/705. This may have more work given the previous PR

PR to update common files and CODEOWNERS for istio/proxy https://github.com/istio/proxy/pull/2826. similar to https://github.com/istio/proxy/pull/2641

PR to update common files and CODEOWNERS for istio/istio https://github.com/istio/istio/pull/23268 . similar to https://github.com/istio/istio/pull/20559

PR to update  CODEOWNERS for istio/envoy https://github.com/istio/envoy/pull/203. similar to https://github.com/istio/envoy/pull/134

Need to get https://github.com/istio/istio/pull/23265 and https://github.com/istio/istio/pull/23268/files merged before we can finish the branch process and kick off the build.

PR to set branches for release-builder: https://github.com/istio/release-builder/pull/215

This PR stops publishing latest for 1.6: https://github.com/istio/istio/pull/23273 similar to https://github.com/istio/istio/pull/20587

We are awaiting PR https://github.com/istio/istio/pull/23265 before we can launch a beta build. Envoy 14.1 is deemed necessary for Istio 1.6. The current cause of why tests are failing is being actively investigated. We will keep this updated with more information as it becomes available. Thanks for your understanding and patience.

PR to bump to 1.7 is here: https://github.com/istio/istio/pull/23274

We are awaiting PR #23265 before we can launch a beta build. Envoy 14.1 is deemed necessary for Istio 1.6. The current cause of why tests are failing is being actively investigated. We will keep this updated with more information as it becomes available. Thanks for your understanding and patience.

This was fixed and cherry picked into 1.6 via https://github.com/istio/istio/pull/23276. Thanks to everyone for their hard work.

Announcements posted and the beta is out :) Closing.

PR to build new build tools image https://github.com/istio/tools/pull/932

PR to update common-files to use build image https://github.com/istio/common-files/pull/241/files

PR to make sure Automator works correctly in istio/test-infra for release-1.6 branch: https://github.com/istio/test-infra/pull/2643

PRs to upgrade build tools:
https://github.com/istio/tools/pull/932/files
https://github.com/istio/common-files/pull/241/files


M09 react hooks

expanded coverage of custom hooks.
testing-library replaced by brief discussion of cypress (with link to cypress.io)
examples reorganized and cleaned up
ready to go if ok with you.

After initial looks, lgtm.
Feel free to merge!
I will probably review this again on Wednesday in detail, once I have little more time.


Output webpack chunks in public/js/

The current default behavior of laravel-mix when handling code splitting is that it drops the output chunks directly into the public folder. (public/0.js)
This modifies the config to place chunks into the js folder with this filename format: (public/js/0.chunk.js).

What if there is either no "public/js" directory, or the user uses "public/javascripts" instead?

Ok fine, I was just assuming everybody used the default folders anyway.

I just remembered this can actually be used outside of Laravel, it's just so closely tied to the framework.


Add ability to paste into the save dialog file name field

Currently you cannot paste text into the save dialog's file name field.  (macos).

This is not an issue on Windows.

Is this still an issue with Camunda Modeler v1.16.2?

Don't have latest due to older OS and the bug with the canvas. Unable to test.

I remember that issue. Thanks for the hint.

@pinussilvestrus Is this still an issue on v3.0.0? I remember we did stuff in that area.

Indeed, this is still an issue (on macOS, is still not present on Windows). It might depend on the electron showSaveDialog implementation since we have several other problems with this topic.

@barmac @smbea Could you double check whether this is still an issue on MacOS?

This is still an issue in 5.8.0.


find a better way to organize Lang sections (also find a way to let modules define translations)

What about public static final constants, organized in public inner classes?

well, its not really closed, we still need a way to let modules define translations, lol


Test Flakiness: Increase timeout to wait for a response to policy

There is a single integration test that is being flaky on big concourse with ~ 50% chance of passing.
Increase the timeout to wait for a response from stub MSA -> saml-soap-proxy -> policy, guessing that CPU/network are slower on this new concourse environment.

having dug into the logs of the test failure, I think it's timing out trying to fetch metadata, not trying to talk to policy

This has been fixed by amends to big concourse config instead


Not working in 1.12.2

Not working 1.12.2 java forge 1.12.2

2.1.0 is compatible with 1.12 so I don't know if the problem is with my pc or not

thanks for reporting.


Variant B promise refactoring

I've made a step here towards refactoring the promise handling, based on the current suggestions of storing [[ExecPromise]] on the module record itself, as well as using the promises approach mentioned in https://github.com/tc39/proposal-top-level-await/issues/18#issuecomment-383719218.
My experience with the promises spec is very weak, so there are some gaps where I couldn't find appropriate spec functions for AwaitAll and PerformBuiltinPromiseThen, which I have left as to-dos. Help with this would be great, just let me know if I can explain them further at all.
Algorithmically the following approach is taken:

We need to ensure that the "InnerModuleEvaluation" still runs sync. That it doesn't right now is a spec bug. This is because the "evaluation" flag checks all assume we are doing a single depth-first-search algorithm, while once we introduce promises into the mix, overlapping executions can be running this algorithm resulting in invalid handling of stack, status and dfsIndex.
To make "InnerModuleEvaluation" sync, we change the meaning of "evaluated" to mean module.[[ExecPromise]] has been set. The module.[[ExecPromise]] value is the promise for full evaluation of that module, including its dependencies. We then have the exec promise either resolve or reject, which is what forms the execution completion.
When it comes to handling the races on evaluation here, we thus effectively have the sync algorithm setting [[ExecPromise]] for all modules in the graph. If a module already has already been executed by this specific top-level run, or another, then it will have an [[ExecPromise]] already set so we can use that.
For error handling, we can no longer rely on the sync population of "stack" being the exact circular subgraph of execution failure in Evaluate. Instead, we simply have the rejection of [[ExecPromise]] store this for us, allowing [[EvaluationError]] to be deprecated and avoiding having to rewrite this behaviour.
Each parent is effectively doing Promise.all(...depModule.[[ExecPromise]]). When an already-evaluating dependency is encountered implying a cycle, we want to avoid gridlock in this case. To do this we don't resolve the parent to its [[ExecPromise]] in this case, but to ensure error handling behaviour keeps its invariant of sharing the error throughout the failed subgraph, we do propogate its rejection.
Once all of that is wired up by InnerModuleEvaluation, we then simply wait on the top-level module's [[ExecPromise]] to get the completion.

@domenic I would really value your feedback re how to complete the promise handling here. I will try and give it another shot again when I can, but wanted to post this early for initial feedback.

The only strange edge case I can think of this this approach is if you have a cycle like the following:
A -> B -> A
where each is awaiting, then if I run a top-level evaluation of A, and then run a top-level evaluation of B before it has resolved, then the B [[ExecPromise]] is effectively just a promise for the completion of B only, and as a result the second top-level evaluation job will return complete even though A is still executing.
This seemed to me a valid compromise for circular references, but the alternative is to make ExecPromise singular on that execution, and then separately construct a top-level evaluation promise. The issue with this approach is that we no longer store errors directly on the module records of the modules that should throw, but re-propogate up from dependencies each time when handling error caching, but this could be deemed acceptable. Reworking as discussed above can be straightforward though. Alternative ideas welcome too.

Just wanted to say thanks very much for this work, and it didn't go unnoticed. We're trying to marshall resources within the champion group to do proper review; both Myles and myself have gotten unfortunately busy with other projects.
In the meantime, in lieu of a full review, I'll say that the "Algorithmically the following approach is taken:" points all seem pretty sound.
For "how to complete the promise handling here", do you mean pointers on how to fill in the TODOs? The Promise.all is pretty easy and I can work on that, but for PerformBuiltinPromiseThen I wonder if you could just replace its usage with ! Call (_evalCapability_.[[Resolve]], _execution_)? There is probably a subtle reason why that is different though.

then the B [[ExecPromise]] is effectively just a promise for the completion of B only, and as a result the second top-level evaluation job will return complete even if A is still executing.

This seems pretty unfortunate. Perhaps we should work through it in more detail and discuss the alternatives in a dedicated issue? E.g. it'd be good to have concrete module bodies for A and B to evaluate what intuitively "should" happen.

https://github.com/w3ctag/promises-guide/pull/55 has a draft of what a proper spec-level Promise.all might look like. Would need to be adapted to ECMAspeak a bit ("steps" is too wishy-washy, I guess).

Of course the issue with for (const promise of promises) await promise is incorrect error handling. I've put together a simple implementation of awaitAll instead.

Would that work if execution is builtin algorithm spec steps?

Ah, I misread and thought execution was a promise for some reason. OK, this will need some sort of trickiness, nevermind.

Sure, this is a consequence of combining the stored execution promise with the promise of the dependencies. The alternative would be...

I am not really able to understand these two alternatives as stated, sorry. You are deeper into this than I am. That's why I suggested a separate issue for discussion with concrete example module bodies that we could check our understanding against.

Of course the issue with for (const promise of promises) await promise is incorrect error handling.

What's incorrect about the error handling?

I've put together a simple implementation of awaitAll instead.

FWIW your version is not technically allowed because ECMAspeak does not allow inlining of steps. I think we should keep your version, but add a note pointing to https://github.com/tc39/ecma262/issues/933. Resolving that is a stage 3 -> stage 4 concern.

I am not really able to understand these two alternatives as stated, sorry. You are deeper into this than I am. That's why I suggested a separate issue for discussion with concrete example module bodies that we could check our understanding against.

Ok, I was just saying I could try spec the other approach and then we can compare. The canonical example is the one stated, and the differences are not so much execution tradeoffs as just different spec approaches.

What's incorrect about the error handling?

If executing A which depends on B and C, then if there were an error in the execution of C, this would only throw after the promise for B's execution resolves. Rather we should throw failure as soon as possible for A.

FWIW your version is not technically allowed because ECMAspeak does not allow inlining of steps.

If I treated the steps as separate concrete methods would that work?

The canonical example is the one stated

I don't understand the one stated :). Example JavaScript code would help me understand.

the differences are not so much execution tradeoffs as just different spec approaches.

Oh, if there are no runtime differences then I guess I won't worry about this.

If executing A which depends on B and C, then if there were an error in the execution of C, this would only throw after the promise for B's execution resolves. Rather we should throw failure as soon as possible for A.

This decreases determinism, right? I.e. you'll get a different error depending on whether B or C loads faster. I think we should not throw as soon as possible in this case; we should throw only after everything completes.

If I treated the steps as separate concrete methods would that work?

Separate concrete functions? Yes, that would work; that's what most other parts of the spec do. But it decreases clarity and bloats the spec. So I think leaving it as-is is better, with a link to the issue about making it legal.

Thanks for opening the other issue! Will discuss there.

What I specified previously was very deterministic - the first module in order to throw is the one that throws. Perhaps we just go back to that then?

Yeah, I like that a lot.

Some editorial improvements for this PR proposed at https://github.com/guybedford/proposal-top-level-await/pull/1 . Overall, I like the semantics here, after some more consideration in #43, and some offline discussion about alternatives to deadlocking from dynamic import (where, at this point, I'm pretty convinced we shouldn't have built-in deadlock detection).

This PR has now been updated with the latest spec fixes and updates here by @littledan.

@guybedford @domenic @littledan is this ready to land in its current state? Seems like an improvement from where we are at right now and we can continue to improve in other PRs

I'd say it's ready to land. We will need follow-on changes, especially for #47 but also maybe for propagating errors better, but this is an improvement that those fixes can be built on.


fix mbedtls_x509_dn_gets to show non-ASCII string properly

Description
This pull-request fixes #3303.
Status
READY

Thank you for your reply. I added ChangeLog.d and fixed to follow Mbed TLS Coding Standard.

@danh-arm
Sorry, I squashed these commits together and clean up the commit log.

Some checks were not successful, but I cannot figure out why these checks failed because I cannot see the details of these failures.
In my local environment (macOS Majove, clang version 11.0.0), mbedTLS was successfully built, and all tests were passed.
Could you please tell me why these checks were failed?

The test failure looks like some glitch on the CI. One test case in ssl-opt.sh failed, only in one configuration (clang on Debian 9 on x86_64). The same test case passed in other configurations and in the merge. The failing test case is Session resume using tickets, DTLS: openssl client. Logs:
std-make-full-config-clang-debian-9-x64-o-cli-163.log
std-make-full-config-clang-debian-9-x64-o-srv-163.log
This isn't an intermittent failure and I don't see an obvious cause. I've restarted the pr-head job to see if it's reproducible.

@gilles-peskine-arm

Please add a non-regression test.
OK. I will create a non-regression test and again push it.

I added a non-regression test and changed ChangeLog.
Could you please review again?

Given that this is a minor bug in a function that is for debugging and logging purposes, I don't think the fix needs to be backported.

@gilles-peskine-arm I think that the fix here breaks the display of valid UTF-8 outside of ASCII chars.
UTF-8 is valid in distinguished names.  I think that the original code if( c < 32 || c == 127 || ( c > 128 && c < 160 ) ) may have incorrectly been attempting to exclude overlong UTF-8 sequences by checking ( c > 128 && c < 160 ), but that check is insufficient to detect a multi-byte overlong UTF-8 encoding, generating a false positive for the 0xc5 0x84 example in #3303.  (A better check would reject 0xc0 and 0xc1)
In any case, the change in this PR replaces all non-ASCII with '?'.  While that makes for a consistent display, it also leads to valid non-ASCII UTF-8 replaced with all '?'.  Maybe instead of if( c < 32 || c >= 127 ), only CTLs should be rejected:  i.e. if( c < 32 || c == 127 ).  mbedtls_x509_dn_gets() is a function used to generate strings to display and so CTLs should continue to be replaced with '?' because they were historically replaced by '?' in mbedtls_x509_dn_gets() and some existing usage might depend on this behavior.
(The reason for revisiting this is that I am looking at performance and correctness of mbedtls_x509_dn_gets() related to #5431)

@gstrauss This patch changed dn_gets from passing most non-ASCII bytes unchanged to only passing printable ASCII through. The intent was to stop emitting invalid UTF-8 no matter what was in the certificate.
The previous code with c > 128 && c < 160 was already present in XySSL 0.1 in 2009.  My guess is that it was intended for latin1, not UTF-8. (And it should have been c >= 128 && c < 160.)
Since Mbed TLS is intended for environments with limited resources, it can't realistically be fully correct with respect to text encoding. (We aren't going to do Unicode normalization!)
I'm not sure what the ideal behavior is for mbedtls_x509_dn_gets. In this PR we chose to make the output non-disruptive (ASCII only), but it's also non-informative. I think that's fine for mbedtls_x509_crt_info, which is mainly for debugging purposes, but not for mbedtls_x509_dn_gets, which applications can use for other purposes.
If lighttpd uses the output of mbedtls_x509_dn_gets for other purposes, and you want to preserve non-ASCII characters, can you please open a separate feature request for this, and explain your constraints (with respect to diversity of certificates to support, acceptability of invalid output, etc.)?

If lighttpd uses the output of mbedtls_x509_dn_gets for other purposes, and you want to preserve non-ASCII characters, can you please open a separate feature request for this, and explain your constraints (with respect to diversity of certificates to support, acceptability of invalid output, etc.)?

Follow-up in #5431


Add /node_modules and /package-lock.json to .gitignore

These files materialize after running npm install. Adding them to
.gitignore to reduce friction for developers and to help ensure that
they are not accidentally committed.
I found this discussion from a few years ago that seems relevant:
https://github.com/jslicense/licensee.js/pull/58#issuecomment-558713096
While I agree with the sentiment of something so universal being a
ignored by default globally, since it is not the default git behavior in
practice it makes it more difficult for people to contribute to this
repo. The cost of adding these lines to .gitignore is low, so this
seems like a reasonable change to make.
I was surprised that this was not already the case, and since this seems
to be a common issue in this repo, it seems that other developers are
also surprised by this.

https://github.com/jslicense/licensee.js/pull/23
https://github.com/jslicense/licensee.js/pull/26

@kemitchell I know you've discussed this a few times in the past, but I figured it was worth checking to see if your opinion has changed since it has been a while. Feel free to close this without comment, and if so, sorry for the noise.


Added literature review

PDFs should be accessible through the university library.

If you have any trouble getting PDFs of articles from the library, I’m happy to help. I do this often and know how to do it.
James
http://ece.pdx.edu/
James McNames
Professor
Electrical and Computer Engineering Department
Maseeh College of Engineering and Computer Science
Portland State University

On Feb 24, 2021, at 2:38 PM, Michal Podhradsky<EMAIL_ADDRESS>wrote:
PDFs should be accessible through the university library.
You can view, comment on, or merge this pull request online at:
https://github.com/camdeno/F16Capstone/pull/1 https://github.com/camdeno/F16Capstone/pull/1
Commit Summary
Added literature review
File Changes
A Literature/README.md https://github.com/camdeno/F16Capstone/pull/1/files#diff-444c63c3d771e4266d688cfd02d9fdfe86f32ce18d8b0dcb7f352ad7248ac75c (57)
Patch Links:
https://github.com/camdeno/F16Capstone/pull/1.patch https://github.com/camdeno/F16Capstone/pull/1.patch
https://github.com/camdeno/F16Capstone/pull/1.diff https://github.com/camdeno/F16Capstone/pull/1.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/camdeno/F16Capstone/pull/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD6IGL4DICMEYXGHTTTDM6LTAV5VRANCNFSM4YFMBZWA.


rbd-nbd: provide alternatives to preserve the ceph log files

Describe what this PR does

Fix cephLogDir passing to storageclass via helm
cephLogDir: is a storage class option that is passed to rbd-nbd daemon.
cephLogDirHostPath: is a nodeplugin daemonset level option that helps in using the right host-path while bind-mounting

provide alternatives to preserve the ceph log files
Currently, we delete the ceph client log file on unmap/detach.
This patch provides additional alternatives for users who would like to persist the log files.
Strategies:
remove: delete log file on unmap/detach
compress: compress the log file to gzip on unmap/detach, in case there exists a .gz file from previous map/unmap of the same volume, then override the previous log with new log.
preserve: preserve the log file in text format
Note that the default strategy will be remove on unmap, and these options can be tweaked from the storage class
Compression size details example:
On Map: (with debug-rbd=20)
$ ls -lh
-rw-r--r-- 1 root root 526K Sep  1 18:15 rbd-nbd-0001-0024-fed5480a-f00f-417a-a51d-31d8a8144c03-0000000000000003-d2e89c87-0b4d-11ec-8ea6-160f128e682d.log
On unmap:
$ ls -lh
-rw-r--r-- 1 root root  33K Sep  1 18:15 rbd-nbd-0001-0024-fed5480a-f00f-417a-a51d-31d8a8144c03-0000000000000003-d2e89c87-0b4d-11ec-8ea6-160f128e682d.gz

Signed-off-by: Prasanna Kumar Kalever<EMAIL_ADDRESS>

Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:

/retest ci/centos/<job-name>: retest the <job-name> after unrelated
failure (please report the failure too!)
/retest all: run this in case the CentOS CI failed to start/report any test
progress or results

looks like a useful functionality, I hope the e2e tests can be extended to consume this too

yes, that is the intention behind this PR.

Please fix CI failures.

@Madhu-1 Done now

@Madhu-1 @humblec please reveiw.

@Mergifyio rebase

@Yuggupta27 @Rakshith-R @yati1998 please review.

@mergifyio rebase


PAF-262: Testing IMS-resolver with ca-cert

What?
Now with Extra logging added to the container image. We will be testing by enabling certchain in the paf prod
We added back the certs which are required for secure communication via pvt link
Why?
Expecting the logs to help us investigate any possible cert issues
How?
We will submit allegations and ims-resolver integration with verint IMS system is tested using certs.
Testing?
Screenshots (optional)
Anything Else? (optional)


chore: disable pp.proof.withType globally

Related Zulip thread

I have a small reservation because tests run with different settings (for example, tests often have to set set_option pp.unicode true so they pass during CI), but otherwise this seems like a reasonable change -- plus it's got five 👍 's on Zulip at this point with no dissent. Let's test it out:
bors r+


updated to rust nightly and fixed HttpDate error #33

This PR fixes various problems caused by the latest changes in rust nightly as well as the problem mentioned in issue #33. However I was not able to run the tests because iron-test does currently not compile.
Please note that I'm using a freshly compiled rust upstream version directly from github which might cause travis to fail because of its slightly outdated version.

Thanks for contributing! The build has been fixed by a composite of a few different PRs, so I'm going to close.


chore(k8s): bump crd version to v1

Signed-off-by: shubham<EMAIL_ADDRESS>Why is this PR required? What issue does it fix?:
With k8s v1.22 the v1beta1 for various resources will no longer be supported. This PR updates the crd apiexention version to v1.
This PR also disables the crd creation from the node disk operator and adds the new crd the operator file itself.
What this PR does?:
Does this PR require any upgrade changes?:
If the changes in this PR are manually verified, list down the scenarios covered::
Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:

[ ] Fixes #
[ ] PR Title follows the convention of  <type>(<scope>): <subject>
[ ] Has the change log section been updated?
[ ] Commit has unit tests
[ ] Commit has integration tests
[ ] (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
[ ] (Optional) If documentation changes are required, which issue on https://github.com/openebs/openebs-docs is used to track them:

Codecov Report

Merging #559 (61ad908) into master (b77aa7f) will increase coverage by 0.08%.
The diff coverage is n/a.

:exclamation: Current head 61ad908 differs from pull request most recent head 36b5683. Consider uploading reports for the commit 36b5683 to get more accurate results

@@            Coverage Diff             @@
##           master     #559      +/-   ##
==========================================
+ Coverage   48.76%   48.85%   +0.08%
==========================================
  Files          73       73
  Lines        3365     3365
==========================================
+ Hits         1641     1644       +3
+ Misses       1566     1564       -2
+ Partials      158      157       -1

Impacted Files
Coverage Δ

cmd/ndm_daemonset/probe/addhandler.go
74.22% <0.00%> (+1.03%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b77aa7f...36b5683. Read the comment docs.

@shubham14bajpai Can you just try upgrade from a previous version, and make sure everything work fine.

Tested it. The upgrade works fine.

Can we maintain the crds in just one place instead of two? We could remove it from deploy/crds maybe @shubham14bajpai @akhilerm

@RealHarshThakur , the deploy/crds is the directory where CRDs are generated, so we should it keep it there. Also, keeping it in helm because helm manages crds. IMHO, the current approach is good. because the corresponding programs expect CRDs at these locations.


No such file or directory

Those folders exist and many have node_modules

I had the same problem – had to patch wipe-modules.sh with…
# …
for d in `find . -maxdepth 1 -type d -mtime +$last_modified`; do
    if [ "$d" == "." ]; then
      continue
    fi
    # move to code dir subdirectory
    # …

I'll submit a PR.

PR submitted (https://github.com/bntzio/wipe-modules/pull/2). 👍🏻

@bfred-it @furey did that worked for you? I think the problem is with folders with a space in their name, that causes the program to cd and get lost in the loop (causing the no such file or directory issue).
Let's say you have a folder named my playground.
The program will cd in my (causing the issue), and breaking the execution.
I'm trying to fix that, in the meanwhile, this works if you have non-space folder names.

Hi @bntzio,
At my end, the "." problem and "folders with a space in their name" (I didn't test against whitespaced directory names originally but have now) were both issues, which I've now patched on #2. 👍🏻
Cheers.

Closing due 👉 #2 and https://github.com/bntzio/wipe-modules/commit/df9b1e5be6c370ba16c6a790c713f9467cf5a002

Hello, thanks for this module.
I still have the problem mentioned in this issue in 1.1.0.

@geowarin please use the absolute path to the directory where your code projects live.
Example: ~/Desktop/code-projects

Mm... that's strange, I got the same error, then moved out the first directory mentioned on the error logs (in your case it would be 00-PRES) then executed the script until I get it to work with the --dry flag to see what may be removed, once it's working I moved the folder back, ran the script and everything went fine again 🤔
It works even with the . as the path.

Ok, I found the issue, will commit the fix in a few hours 😄 thanks for pointing this out! @geowarin

@geowarin here's it is c4993fceec59b89a1318b8f8cb4a1ec660175532 😄
Could you please upgrade to the newest version v.1.1.1 and then try again?

Totally works! 👍
Thank you so much :smile:


Gh 1264 federatedstore improve tests

Codecov Report

Merging #1265 into develop will increase coverage by 3.25%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #1265      +/-   ##
=============================================
+ Coverage      64.71%   67.96%   +3.25%
+ Complexity      1540     1114     -426
=============================================
  Files            688      521     -167
  Lines          22225    18051    -4174
  Branches        2734     2356     -378
=============================================
- Hits           14382    12269    -2113
+ Misses          6695     4822    -1873
+ Partials        1148      960     -188

Impacted Files
Coverage Δ
Complexity Δ

...q/gaffer/flink/operation/handler/GafferOutput.java

...er/spark/examples/GetRDDOfAllElementsExample.scala

...g/serialisation/ReservoirLongsUnionSerialiser.java

...a/uk/gov/gchq/gaffer/time/BoundedTimestampSet.java

...uk/gov/gchq/gaffer/time/RBMBackedTimestampSet.java

...e/serialisation/BoundedTimestampSetSerialiser.java

...tion/kryo/impl/TypeSubTypeValueKryoSerializer.java

.../main/java/uk/gov/gchq/gaffer/spark/SparkUser.java

...sketches/theta/serialisation/SketchSerialiser.java

...rialisation/json/HyperLogLogPlusJsonConstants.java

... and 187 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc192d7...b2cb220. Read the comment docs.

@p013570 Can you check the truth table logic and methods please. I think its spot on this time.

GitHub thinks there is conflict... THERE ISN'T could someone help please?


The URL is invalid: two slashes are needed after the http(s):

But after https: I have two slashes. This happened when doing a reverse proxy through ngnix and did ssl

Please share the url which produced the error.

Also this might solve your problem: https://github.com/Rob--W/cors-anywhere/issues/417


Library doesn't install

Describe the bug
The nugget package will fail when installing it on a normal '.Net 7.1 framework' app (notably, for Azure functions)
To Reproduce
Steps to reproduce the behavior:

Go to your project in '.Net 7.1',
Click on Nuget Manager,
Scroll down to ArkEcosystem.Client in the research ArkEcosystem
See error

Expected behavior
The library should install.
Server (please complete the following information):

OS: Windows 10
Version 17713 (early build insider)
Visual Studio Community 2017, Resharper Ultimate

Works fine on macOS, someone will have to test it on Windows.

@faustbrian @alexbarnsley I managed to find a solution on the Crypto one, I'll see if I can manage to find a solution for this one too. Not sure why this doesn't install in my project, will investigate some more.

@Abalalojik Try to right-click the packages.config in Visual Studio and then Migrate to PackageReference.


Additional details on /external:I option

Some users expect header files included through double-quotes to be treated as "external" headers if they reside in the directory specified in the /external:I option. However, only those that are included through angle brackets (e.g., #include <external.h>) will be treated as "external" header (if it is from the directory specified in /external:I option).
Please add this detail to the document (and hopefully with some explanation on why) so that users can have correct expectations.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d17b537f-8093-16f6-e52f-b83cf4fc5c6f
Version Independent ID: 6b66bc39-47d6-a2da-bb84-bab42702e925
Content: /external (External headers diagnostics)
Content Source: docs/build/reference/external-external-headers-diagnostics.md
Product: visual-cpp
Technology: cpp-tools
GitHub Login: @corob-msft
Microsoft Alias: corob

It seems that this is no longer the case. I will need to dig deeper to confirm the behavior.

It seems this behavior has changed since 17.0. 16.11 still requires angle brackets for headers to be considered as "external".

@hwisungi
Does that mean we need to call out 16.11 behavior separately from 17+?


add VoteEvent.bill_action

allows creation of relationship between a bill action & a VoteEvent, related pupa PR is opencivicdata/pupa#264

Coverage increased (+0.02%) to 90.615% when pulling 0283b4e10fd06c8143b533fbf8c0d113e55e9c7b on vote-event-bill-action into d3bc0ece284fb2f32f1b1ae7572da994cc4308ae on master.

hmm, looks like makemigrations hadn't run since these were added so they wound up in the auto generated migration.
if you prefer I can manually split these into their own migration

I don't think it's worth the bother. lgtm.


[Suggestion] Progress indicator

It would be nice, if possible, to have some kind of progress indication for when the extension is doing something - like finishing a release.
At the moment, there is no indication that anything is happening, apart from maybe noticing the branch change in VS Code.

Right now, I have only one process indicator when Sync all root branches. because that process takes some time. For other tasks I found it not practical. Other tasks are fust. In addition, VS Code does not have too many tools for indicating a process. The only additional window which is not quite appealing.
What would you expect? How to indicate? How to use indicator line on the viewlet title, I have not found. It only shows automaticaly when I refresh viewlet content.

I have an idea. I can change Git Flow Icon in the status bar to spinner. What do you think? Would it be prominent enough indicator?

Hmm... yeah I see what you mean...
Yeah, I think that might help - at least some kind of animation in the status bar would show something was happening.


APA102 Driver for WS2812b

Can I use the APA102 Driver for WS2812b?
What are the modifications that should be done to use it?

I wrote a driver for these LEDs: https://github.com/Ic-ks/contrib-drivers/tree/master/ws2812b  I did already a pull request (https://github.com/androidthings/contrib-drivers/pull/76)

the jcentre page is not opening, so I am not able to figure out the latest version, can you please let me know the latest version

https://bintray.com/google/androidthings/contrib-driver-ws2812b/_latestVersion
it says this link is not valid I get a page not found error can you do something about it?

I also tried searching in https://bintray.com/google/androidthings this link I couldn't find your driver, so please help me out

Sorry for the late response. You can import the driver by cloning the repository (https://github.com/Ic-ks/contrib-drivers.git) and using the import function of Android Studio in your project: File->New->Import-Module. Then select <CLONE_DIR>/contrib-drivers/ws2812b. The import function will copy ws2812 driver to your project. If you don't want a copy of the driver you could create a relative path dependency like described here: https://stackoverflow.com/questions/24975745/gradle-dependencies-compile-project-by-relative-path