translate3D preventing ng-gallery to go fullscreen

Hey there! Thanks for the hard work :+1:
I'm using v-Accordion and inside it, I've put a ng-gallery component. When you click on a image, it is supposed to overlay the full screen. The thing is that it only overlays v-pane-content.
I've asked this on ng-gallery issues and StackOverflow.
Given a comment there and another similar issue posted on ng-gallery wiki, I realized it has something to do with v-Accordion's translate3d CSS property.
Do you know any workaround so I can keep ng-gallery inside an accordion, but allowing it to cover the whole body?
Thanks!

Hey! Sorry for late reply.
I never use ng-gallery inside v-accordion, but if this is really an issue with translate3d CSS property, the only workaround that comes to my mind is to simply override v-accordion default styling, like so:
.vAccordion--default v-pane-content > div {
  transform: none;
}

.vAccordion--default v-pane.is-expanded > v-pane-content > div {
  transform: none;
}

Thanks a lot for your response!
I tried it, putting that code in v-acordion.scss. Also tried adding !important to those lines, and even modifying it's other source files where translate3d was to none.
Still the same :(

Try to use the v1.5.0 release, remember to override v-pane-content translate3d property and let me know if this helps.
On 1.4.x I was using will-change property witch (similarly to translate3d) also creates a new compositing layer.

For now, I'll close the issue, but feel free to re-open if you're still having problems.

Fixed with 1.5.1!
Thanks!


[ENHANCEMENT] Refactoring JS code

What would you like to share?
Description
To assure code quality and a good DX (Developer Experience), the JavaScript code has to be refactored
Acceptance Criteria

[ ] no console.log
[ ] no DRY
[ ] each function should stand on its own
[ ] deletion of unused code

💡 Note: comments should stay for learning purpose!
Additional information
No response
### Tasks
- [ ] check of `let` and `const` usage

I love your simple, minimalistic yet very key website for beginners/gaming.
Would love to contribute sometime if possible, as I've just kick-started my Open Source career.

Hi @traez welcome to the Open Source community. This particular repo is mostly updated by staff themselves. Also, YurisCodingClub is focusing on collaborating with women and people with disabilities. Hopefully, you find a community that fits your needs better (check out EddieHub e.g., great way to start your Open Source Career 😉)


change screen position

The screen is moved top when the back screen was clicked.

Thanks for your first PR!!!
You are correctly replacing the view stacks, but you need to re-draw them after replacing the view stacks.
Try this on your zmonitor,

Run two clients,

$ weston-flower

$ weston-terminal

Hung one of them,

$ ps a | grep weston-terminal
$ kill -s SIGSTOP <pid>

Try to move the window of a stopped process.

That may not be possible, but we would like to.
It's hard to notice this bug because most applications send some requests to commit a new drawing immediately after receiving a keyboard focus event. But some clients may not send any request after receiving keyboard focus event, and even so, we need to move the window forward.
So, in conclusion, the framebuffer needs to be updated.

And I recommend you to create a branch on your fork.


Add .clang-format and formatting / typos GitHub workflows

Use the LLVM style unmodified, so that exchanging code between upstream will be less tedious.
We currently don't follow that style. I'm inclined to doing a mass-format soon, though.

Does this repo have GitHub Actions enabled? I think we should see them running in this PR but we don’t.

That looks enabled to me:

Are you aware of any other required settings?

I don’t know any other setting, but it normally works on PRs: https://github.com/Flakebi/llvm-dialects/pull/1
It found a typo :)

Curious, it works now. I don't think I changed any settings on the repository. The only things I can think of are:

Visiting that Settings page for the first time
Submitting a trial PR from a branch in the same repository (#9), which worked
Pushing to the branch of this PR here after fixing that typo


Add generic error that can be used when invalid / unsupported params are passed

The problem
Currently multiple methods seem to use different error messages when it comes to invalid / unsupported parameters that are passed.
Let's introduce a generic error that can be used when invalid / unsupported are passed instead so that the error is always the same and logical.
Example:
export const InputError = new Error('InputError, invalid input: number or type of arguments does not match the requirements for this command')
import InputError from './errors'
throw new InputError()

@christian-bromann : What would the location of 'errors' file be?

duplicate of #9 .. let's continue conversation there


Need to symlink AppRun manually, -e does not work

When I manually symlink AppRun, then it works:
...
( cd AppDir ; ln -s usr/bin/FreeCAD AppRun )
...

./linuxdeploy-x86_64.AppImage --appdir AppDir -i AppDir/usr/conda/data/Mod/Start/StartPage/freecad.png -d AppDir/usr/share/applications/freecad.desktop --output appimage

./FreeCAD-x86_64.AppImage # Works!

When I do not manually symlink AppRun but instead specify -b ... it fails:
./linuxdeploy-x86_64.AppImage --appdir AppDir -i AppDir/usr/conda/data/Mod/Start/StartPage/freecad.png -d AppDir/usr/share/applications/freecad.desktop -e AppDir/usr/bin/FreeCAD --output appimage

# FAILS WITH
# -- Deploying executables --
# Deploying executable AppDir/usr/bin/FreeCAD
# Deploying copyright files for file AppDir/usr/bin/FreeCAD
# Deploying dependencies for ELF file AppDir/usr/bin/FreeCAD
# ERROR: Could not find dependency: libFreeCADGui.so
# Failed to deploy executable: AppDir/usr/bin/FreeCAD

When I do not manually symlink AppRun but instead specify -e ... it fails

That's a known issue. -e shouldn't expect executables to be native binaries, as users might want to use scripts or anything.
However, in this case, only a custom AppRun script should be created, the executable is already in usr/bin/. Please try with --custom-apprun.

It is a native (compiled) binary in this case.

FreeCAD in this case is a symlink to usr/conda/bin/FreeCAD IIRC. Perhaps that confuses linuxdeploy.
By the way, normally when using conda, executables are Python scripts. Seems like the FreeCAD folks have put binaries into their conda package. That's quite uncommon. I made a wrong assumption it seems.
Actually, you're doing it wrong at the moment. Like linuxdeployqt, if an AppRun is supposed to be created by linuxdeploy (as in "doesn't exist yet", linuxdeployqt just overwrote existing files, which annoyed users), it looks into the desktop file for the Exec key, and adds a symlink.
Have you tried to run your command without the -e part?

Great simplification indeed.

Indeed ERROR: Could not find dependency: libFreeCADGui.so it could say -e not needed since already deployed or something like that. So that the user knows he is the problem here :)

Well, it looks like conda doesn't set the rpath properly. And you requested deployment of that library, it's hard to recognize that as a misuse.

Well, it looks like conda doesn't set the rpath properly.

if you can elaborate on that maybe it'd be worth opening a Conda issue.
(Similarly, I'd definitely say let's open a Conda issue asking for an installation mode where they don't write absolute paths into all script's shebangs.)

Well, in your case, you requested the deployment of usr/bin/FreeCAD (which is wrong, because it's already there), which has been created as a symlink to usr/conda/bin/FreeCAD. linuxdeploy calls ldd on the symlink, and ldd couldn't find that library. So, either the rpath wasn't set properly (e.g., because conda uses LD_LIBRARY_PATH or similar stuff), or ldd doesn't like symlinks (which I highly doubt).


Add support for an inline comment after a block

This is a breaking change but we could include it in the next alpha of pug.

Coverage increased (+0.1%) to 95.406% when pulling 3f2dc6db9107cd519a23901f3eec1118182abc47 on inline-block-comment into 58d8ed0968f4204223f63f740572fff944699bd2 on master.


Puppeteer-sharp throws an exception when opening a url pointing to a PDF

Description
Puppeteer-sharp throws an exception (ERR_ABORTED) on GoToAsync when the URL resolves to a PDF
Complete minimal example reproducing the issue
// Arrange
var options = new LaunchOptions { Headless = true };
var chromiumRevision = BrowserFetcher.DefaultRevision;
var browser = await Puppeteer.LaunchAsync(options, chromiumRevision);
var page = browser.NewPageAsync();

// Act
await page.GoToAsync("https://ayotsl.com/wp-content/uploads/2018/06/Code-of-Conduct-2018.pdf");

// Assert
That no exception is thrown
ScreenshotOptions options = new ScreenshotOptions { FullPage = true };
var stream = await page.ScreenshotStreamAsync(options);
Assert stream is not null

Expected behavior:
No Exception
Actual behavior:
Exception thrown
One or more errors occurred. (net::ERR_ABORTED at https://ayotsl.com/wp-content/uploads/2018/06/Code-of-Conduct-2018.pdf at https://ayotsl.com/wp-content/uploads/2018/06/Code-of-Conduct-2018.pdf)
Versions
Latest Stable 1.19.0
.NET Core 2.2

The PDF Viewer you see in Chrome it's not a Page you can act on. It's a plugin.


relation between PhotSystem and PhotometryFilter

I don't understand this sentence in the Readme:
"As there is one file per filter, the PhotometricSystem objects contain only one filter. The merge of several filters in one file is staightforward by the way."
a Photsystem is usually a set of several filters .
The mapping block can be re-organised  so that the PhotSystem appears only once in the mapping with the instance of filters used for the data .

The script, as it is now, generates one file per filter. If you want get serializations with more than one filter you have to either change both template and script or to merge by hand.


Minor fixes

Couple of minor fixes and some logging.

Codecov Report

Merging #954 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #954      +/-   ##
============================================
- Coverage     67.35%   67.29%   -0.06%
+ Complexity     4385     4382       -3
============================================
  Files           365      365
  Lines         28702    28702
  Branches       3653     3653
============================================
- Hits          19332    19316      -16
- Misses         8357     8364       +7
- Partials       1013     1022       +9

Impacted Files
Coverage Δ
Complexity Δ

...github.ambry.rest/AsyncRequestResponseHandler.java
88.59% <0%> (-2.29%)
23% <0%> (ø)

.../java/com.github.ambry.router/DeleteOperation.java
91.91% <0%> (-1.48%)
43% <0%> (-1%)

.../com.github.ambry.router/GetBlobInfoOperation.java
80.6% <0%> (-1.22%)
33% <0%> (-1%)

...in/java/com.github.ambry.store/BlobStoreStats.java
70.33% <0%> (-0.72%)
82% <0%> (ø)

...in/java/com.github.ambry.network/SocketServer.java
82.78% <0%> (-0.41%)
13% <0%> (ø)

...ain/java/com.github.ambry.router/PutOperation.java
89.42% <0%> (-0.2%)
81% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9429adb...8a9eff1. Read the comment docs.


fix(mapleir): fix org.mapleir.app.service.ClassTree#getAllBranches

For example, we have three classes
public class Abst {
    public int apply(int a) {
        return a + 3;
    }
}

public interface Inte {
    int apply(int a);
}

public class Top extends Abst implements Inte {

    public void run() {
        if (((Inte) this).apply(3) == 6) {
            System.out.println("SUCCESS");
        } else {
            System.out.println("FAILURE");
        }
    }
}

If call this with Inte, it should return all these classes and java.lang.Object, but now it won't return Abst
In skidfuscator, ofuscate these code, will throw AbstractMethodError.
this pull request can fix it

For example, we have three classes
public class Abst {
    public int apply(int a) {
        return a + 3;
    }
}

public interface Inte {
    int apply(int a);
}

public class Top extends Abst implements Inte {

    public void run() {
        if (((Inte) this).apply(3) == 6) {
            System.out.println("SUCCESS");
        } else {
            System.out.println("FAILURE");
        }
    }
}

If call this with Inte, it should return all these classes and java.lang.Object, but now it won't return Abst
In skidfuscator, ofuscate these code, will throw AbstractMethodError.
this pull request can fix it

The behaviour is correct. Whilst Top branches to Abst and Inte, Inte and Abst have no correlated branches. Skidfuscator handles this behaviour correctly in the classtree by merging these methods implicitely. If the such is not working, please report it and I'll create a test!
Closed for the time being, lmk if any further design questions :)


Use Discord API version 9

It looks like the package is using Discord API version 8.
For some features (including the creation of threads in channels) the Discord API version 9 is required.

v10 is coming and v8 is being deprecated: https://github.com/discord/discord-api-docs/discussions/4510

I see! There is a MR open for adding threads (https://github.com/bwmarrin/discordgo/pull/1058/files) but indeed upgrading to version 10 might be required soon as well to keep this package up to date (preferably before the April 30th deprecation date for v9).

Thank you for the issue! Upgrade to v10  will follow after the threads PR merge, which will happen soon. So, no worries about the older API version.


tf.gradients returns None in tf.map_fn

GitHub issues are for bugs / installation problems / feature requests.
For general support from the community, see StackOverflow.
To make bugs and feature requests more easy to find and organize, we close issues that are deemed
out of scope for GitHub Issues and point people to StackOverflow.
For bugs or installation issues, please provide the following information.
The more information you provide, the more easily we will be able to offer
help and advice.
Environment info
Operating System:
Mac OS 10.10
Installed version of CUDA and cuDNN:
(please attach the output of ls -l /path/to/cuda/lib/libcud*):
None
If installed from binary pip package, provide:

Which pip package you installed.
The output from python -c "import tensorflow; print(tensorflow.__version__)".
0.10.0rc0

If installed from source, provide

The commit hash (git rev-parse HEAD)
The output of bazel version

Steps to reproduce
I want to evaluate the diagonal of Hessian with tf.map_fn, which takes a function that maps each dimension (scalar) to its Hessian
import tensorflow as tf

def hessian_factory(f):
    def hessian1(x):
        g = tf.gradients(f, x)[0]
        h = tf.gradients(g, x)[0]
        return h

    return hessian1

sess = tf.Session()
x = tf.Variable(1.0)
sess.run(tf.initialize_all_variables())

f = 1. / (1 + tf.exp(-x))
func = hessian_factory(f)
h = tf.map_fn(func, x)

print(sess.run(h))

However, it seems tf.gradients(f, x) produces None.
Even the following statements gives None
import tensorflow as tf

sess = tf.Session()
x = tf.Variable(1.0)
sess.run(tf.initialize_all_variables())

f = 1. / (1 + tf.exp(-x))
h = tf.map_fn(lambda x: tf.gradients(f, x)[0], x)

What have you tried?

Logs or other output that would be helpful
(If logs are large, please upload as attachment).

It is a known issue that tf.gradients() can't be called inside map_fn, due to some tricky problems with TensorArray.  However you can call tf.gradients() inside tf.while_loop so try to use tf.while_loop directly.

Is that still a problem with recent versions?

Nones in Hessians are expected for reasons unrelated to map_fn -- for implementation reasons, TensorFlow returns None instead of 0 when the gradient is not a function of the variable being differentiated against. Hence off-diagonal terms are None's, see discussion here for Hessians -- https://www.google.com/url?hl=en&q=https://groups.google.com/a/tensorflow.org/d/msgid/discuss/d83404b7-793a-4201-ad73-fcecbb83eaac%2540tensorflow.org?utm_medium%3Demail%26utm_source%3Dfooter&source=gmail&ust=1485411137547000&usg=AFQjCNEhO37F5hU6GDwsfv8BBbAariqCFQ
Also see https://github.com/tensorflow/tensorflow/issues/783 for why it's None's instead of 0's

You need to do something like this to get Hessians
def replace_none_with_zero(l):
  return [0 if i==None else i for i in l]

tf.reset_default_graph()

x = tf.Variable(1.)
y = tf.Variable(1.)
loss = tf.square(x) + tf.square(y)
sess = create_session()
grads = tf.gradients([loss], [x, y])
hess0 = replace_none_with_zero(tf.gradients([grads[0]], [x, y]))
hess1 = replace_none_with_zero(tf.gradients([grads[1]], [x, y]))
hessian = tf.pack([tf.pack(hess0), tf.pack(hess1)])
print hessian.eval()

Closing since @yaroslavvb comment seems like a reasonable answer.

@aselle and @drpngx , can something about the interaction between tf.map_fn and gradients be added to the API documentation? I don't think anything is currently mentioned.

So there was a convention where gradients would return none (and not zero)
if integers were involved. Then we changed some case for correctness. That
happened maybe a couple of months ago. Do your computations involve
integers?
On Sun, Jun 10, 2018, 8:52 AM Rylan Schaeffer<EMAIL_ADDRESS>wrote:

@aselle https://github.com/aselle and @drpngx
https://github.com/drpngx , can something about the interaction between
tf.map_fn and gradients be added to the API documentation? I don't think
anything is currently mentioned.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensorflow/issues/3972#issuecomment-396059390,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AT_SbdrH-l10xL1grY_-NXncGFE6JZE8ks5t7UDKgaJpZM4Jqhtc
.

@drpngx , I'm actually dealing with a different use case (I was using tf.map_fn to feed a sequence of 3d images through a few conv2d layers and just discovered that no gradients were reaching my convolutional layers). Was your question intended for me?
Also, as an aside, how is a sequence of images normally fed through convolutional layers?

I created a separate issue for my question/suggestion. https://github.com/tensorflow/tensorflow/issues/19896

I see. I don't really see why map_fn can't propagate the gradients. Maybe file a feature request and CC @skye.

Sounds good! I opened a new feature request.


Support more kube-apiserver metrics

What would you like to be added:
We have a few API server related metrics

api_availability_metrics.go
api_availability_measurement.go
api_responsiveness_prometheus.go

Seems apiserver_request_count and apiserver_request_latencies_bucket are not supported in any measurement yet.
Am I missing something? If we this part is helpful, I can help on this issue.
Why is this needed:

seems kube-controller-manager related metrics are not there as well.

Seems apiserver_request_count and apiserver_request_latencies_bucket are not supported in any measurement yet.

The latter is part of api_responsiveness.
The former - how you would like to use it? What exactly you would like to check?
If you just want visibility to metrics, those are gathered from metrics e2e:
https://github.com/kubernetes/perf-tests/blob/master/clusterloader2/pkg/measurement/common/metrics_for_e2e.go


state is undefined

I see this error. Here the trace from minified code but hope it gives you some clues what the problem is:
#videomail > require<[56]</</Writable.prototype.write@https://videomail.io/js/main-36bb504261.min.js:15125:40
require<[26]</</Duplexify.prototype._write@https://videomail.io/js/main-36bb504261.min.js:9893:169
doWrite@https://videomail.io/js/main-36bb504261.min.js:15019:128
writeOrBuffer@https://videomail.io/js/main-36bb504261.min.js:15015:8
require<[56]</</Writable.prototype.write@https://videomail.io/js/main-36bb504261.min.js:15126:7
writeStream@https://videomail.io/js/main-36bb504261.min.js:18666:188
draw@https://videomail.io/js/main-36bb504261.min.js:18802:27

Taken from latest Firefox

But Chrome tells me a different trace:
collectLogger.js:49 #videomail > TypeError: Cannot read property 'ended' of undefined
    at DestroyableTransform.Writable.write (https://videomail.io/js/main-36bb504261.min.js:15125:45)
    at Duplexify._write (https://videomail.io/js/main-36bb504261.min.js:9893:184)
    at doWrite (https://videomail.io/js/main-36bb504261.min.js:15019:135)
    at writeOrBuffer (https://videomail.io/js/main-36bb504261.min.js:15015:8)
    at Duplexify.Writable.write (https://videomail.io/js/main-36bb504261.min.js:15126:7)
    at writeStream (https://videomail.io/js/main-36bb504261.min.js:18666:195)
    at draw (https://videomail.io/js/main-36bb504261.min.js:18802:27)

Weird

Using latest websocket-stream package, where Duplexify.Writable.write() is triggered

Debugged more in Chrome. Problem is that part of code. state is undefined here.
Writable.prototype.write = function (chunk, encoding, cb) {
  var state = this._writableState;
  var ret = false;

  if (typeof encoding === 'function') {
    cb = encoding;
    encoding = null;
  }

  if (Buffer.isBuffer(chunk)) encoding = 'buffer';else if (!encoding) encoding = state.defaultEncoding;

  if (typeof cb !== 'function') cb = nop;

  if (state.ended) writeAfterEnd(this, cb);else if (validChunk(this, state, chunk, cb)) {
    state.pendingcb++;
    ret = writeOrBuffer(this, state, chunk, encoding, cb);
  }

  return ret;
};

Socket is not destroyed, not ended yet. Using node v6.20 here.

There is another weird thing: if I run my code locally, this does not happen. Only on my remote server upon deployment.

any advice?? would be good because it's breaking my site. thanks

Can you reproduce it? You can try with wireshark to get a capture of the latest packet sent that triggers it.

honestly, i have no idea how to reproduce - only happens on my remote server, not on my local server. and what exactly should i capture on wireshark? you can see it yourself, it's the site www.videomail.io - just hit on the record button and then that error happens every time :(
any quick advice would be very much appreciated - thanks

@mcollina I found out, that this only happens when code is minified. Does not happen when not minified. I am minifying the client side code with gulp uglify like this
        .pipe(plugins.if(settings.server.minify.js, plugins.uglify({
            mangle: false, // because of angularjs :(

            // keep line breaks for easier locating of weird errors (temporary)
            output: {
                "beautify":     true, // Add new lines
                "indent_level": 0,    // Don't add indentation
                "indent_start": 0
            }
        })))

@mcollina to reproduce I guess you try to uglify some code that uses Duplexify and then see how it goes

I'm having the same issue when I use sails and google-storage. If I disable sails, Google Storage works perfectly.
GS uses createWriteStream which is failing


Increase mass threshold to catch actual duplicates only

This will remove duplicates such as the init scripts from duplication reports, as they're expected to be similar code.

This only effects codeclimate. Merging.


Change the direction of the arrows for " Red envelope"

Change the direction of the arrows on the "deposit" and "withdraw" buttons
deposit - up arrow
withdraw all -down arrow

https://app.zeplin.io/project/5b379c2c38cb39e73e5f8889/screen/5f7383de04b8a95feb765610

not fixed
build: 6.0.10414.3740 BeamX

not fixed
build: 6.0.10414.3740 BeamX

checked

checked


Support Bash output for movies-for-hackers.sh

Checklist for submitting a pull request to Movies For Hackers:

[X] I have carefully read and comply with the Contributing Guidelines of this repo.
[X] I have searched the PRs of this repo and believe that this is not a duplicate.

This PR fixes #48. If Bash is the current $SHELL then the additional -e switch (to enable interpretation of escape sequences) is applied and the script will run as normal. Tested with Bash 4.3.48(1).

Hi again. Please read my review on your previous pull-req. Thanks!


[FEATURE] Order of tools in Register Agent Step should be deterministic

Is your feature request related to a problem?
For some agents (Flow Agent), the order of the tools matters.  Currently when creating the list of tools we are using non-deterministic ordering from a HashMap entry set to create the previousNodes list.
List<String> previousNodes = previousNodeInputs.entrySet()
    .stream()
    .filter(e -> TOOLS_FIELD.equals(e.getValue()))
    .map(Map.Entry::getKey)
    .collect(Collectors.toList());

We need a way to (optionally) enforce an ordering of these tools.
What solution would you like?
The AgentStep already has an optional "tools" field in the code but it is never read, instead just iterating over the previous node inputs and looking for "tool" in the value.
If that field is populated with an array of tool ID's (the workflow step ID they were created with), the list should be sorted in that order.
What alternatives have you considered?
Always sort in order of workflow step ID.  However, we may want different agents with different orderings created from the same definition.

We need to decide how to handle (or whether to require) duplicate input.
Current setup:
"previous_node_inputs": {
    "some_step": "some_value",
    "foo_tool": "tools",
    "bar_tool": "tools",
    "baz_tool": "tools"
},

Result:  foo, bar and baz tools in any order.
Possible setup A:
"previous_node_inputs": {
    "some_step": "some_value",
    "foo_tool": "tools",
    "bar_tool": "tools",
    "baz_tool": "tools"
},
"tools": ["foo_tool", "bar_tool", "baz_tool"],

Result:  foo, bar and baz tools in that specific order.
But do we need the redundancy?
Possible setup B:
"previous_node_inputs": {
    "some_step": "some_value"
},
"tools": ["foo_tool", "bar_tool", "baz_tool"],

Result:  foo, bar and baz tools in that specific order.  Input from previous node assumed.
But what if someone does this:
Possible setup C:
"previous_node_inputs": {
    "some_step": "some_value",
    "foo_tool": "tools",
    "bar_tool": "tools",
    "baz_tool": "tools"
},
"tools": ["foo_tool"],

Result option 1:   foo tool only.
Result option 2:  foo tool first, followed by bar and baz in any order.
Possible setup D:
"previous_node_inputs": {
    "some_step": "some_value",
    "bar_tool": "tools",
    "baz_tool": "tools"
},
"tools": ["foo_tool", "bar_tool"],

Result option 1:   foo tool and bar tool in that order.
Result option 2:  foo tool and bar tool first, in that order followed by baz in any order (which is just baz)
Result option 3:  fail validation

Ultimately we need this to be simple and easy to explain. So

Option 1 (my preference, works with A, B, C2, and D2):
 - tools can be specified as previous node inputs OR on a tools field with those inputs assumed
 - all listed tools in either location will be used, with duplicates ignored; those (if any) in tools field will be ordered first

Option 2 (works with A, B, C1, and D1):
 - tools must be specified in only one location, either previous node inputs or tools field.  If tools field exists, entries in previous inputs will be ignored, and they will be ordered.

Option 3 (works with A, C1, and D3):
 - tools must always be specified in previous node inputs
 - if present, tools field will be the only tools used, and will fail validation if not included in inputs

Another idea:
"previous_node_inputs": {
    "some_step": "some_value",
    "foo_tool": "tools.1",
    "bar_tool": "tools.2",
    "baz_tool": "tools.3"
}

I'm implementing Option 1 (tools field, if present, is ordered first followed by anything else in previous node inputs, with duplicates ignored.
// Anything in tools is sorted first, followed by anything else in previous node inputs
List<String> sortedNodes = tools == null
    ? new ArrayList<>()
    : Arrays.stream(tools).filter(previousNodes::contains).collect(Collectors.toList());
previousNodes.removeAll(sortedNodes);
sortedNodes.addAll(previousNodes);
sortedNodes.forEach((node) -> {

I can change this if there's strong opinion either way.

OK, currently going with "Option 1":

Anything in "tools" field is placed first in order, whether or not it exists in previous node inputs
Anything else in previous node inputs is added in nonspecific order

// Anything in tools is sorted first, followed by anything else in previous node inputs
List<String> sortedNodes = tools == null ? new ArrayList<>() : Arrays.asList(tools);
previousNodes.removeAll(sortedNodes);
sortedNodes.addAll(previousNodes);
sortedNodes.forEach((node) -> {

Reasoning for "option 1":

Validation (and front-end tie-in) will be conducted with the "previous node inputs" so it's good to have them
Ordering with the "nodes" field is an optional thing and it's good to allow it when provided but I'm really hesitant to throw a runtime validation failure if it doesn't list all the things.
Doesn't "silently fail" on expected results or throw runtime exceptions following pre-run validation
Can be easily explained in docs


feat: Switch FormattedDate component to Intl.DateTimeFormat

Summary
Use Intl.DateTimeFormat instead of fixed momentjs format in FormattedDate component
This comes from a discussion in i18n - Localization channel in mattermost community where Ian Lui reported bad date formatting for Chinese and Japanese languages. After some digging it appeared there were more problems than that and I suggested to switch from momentjs to Intl.DateTimeFormat
Ticket Link

Checklist

[ ] Added or updated unit tests (required for all new features)
[ ] Has UI changes
[ ] Includes text changes and localization file updates
[ ] Have tested against the 5 core themes to ensure consistency between them.
[ ] Have run E2E tests by adding label E2E iOS tests for PR.

Device Information
This PR was tested on:
Screenshots

Release Note

Hello @KuSh,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Maybe should consider adding an end to end test or unit tests to make sure this does not break again

@KuSh I see many stylistic changes that do not completely conform with our codebase. Do you mind removing the stylistic changes so the PR is clearer?

@KuSh I see many stylistic changes that do not completely conform with our codebase. Do you mind removing the stylistic changes so the PR is clearer?

Sure, I tried to configure prettier to follow you codebase / eslint but it seems I didn't succeed :/

@rahimrahman I've pushed the requested changes!


Adding support for s390x

@fredbi @casualjim please review this PR. I'm trying to enable go-swagger package for s390x platform.


IoT-LTSC-Like: Applications are automatically lunching with ADMINSTRATIVE privilege

Hi There,
I have installed IoT-LTSC-Like Windows 11, but I noticed an issue where every application is running with administrative privilege.
Could please help me on this? Attaching some screenshots.

Found the fix in the discussion thread,
https://github.com/memstechtips/UnattendedWinstall/discussions/22#discussioncomment-9934442


[TEST] Implement Rancher upgrade in Rancher integration test

What's the test to develop? Please describe
Currently, we have a Jenkins job to setup Rancher + Harvester and run rancher integration tests. We need to introduce the Rancher upgrade also so that we can test the Rancher upgrade through automation.
Prerequisite and dependency of test
The Rancher Harvester matrix CI needs to be available on Prod Jenkins.
Describe the items of the test development (DoD, definition of done) you'd like
The test scenarios will look like below

[ ] The guest clusters created in the rancher integration will not be teared off.
[ ] Upgrade Rancher
[ ] Verify the guest cluster are healthy after the upgrade. Node name, number of nodes.
[ ] Scale up the guest clusters. Scale down the guest clusters
[ ] Create new clusters.

cc: @m-ildefons


e2e test results are timeout

Result:
4) [chromium] › e2e\HorizontalRule.spec.mjs:30:3 › HorizontalRule › Can create a horizontal rule and move selection around it
Test timeout of 150000ms exceeded.

Error: page.waitForSelector: Test timeout of 150000ms exceeded.
Call log:
  - waiting for locator('.toolbar-item[aria-label="Insert specialized editor node"]') to be visible

   at utils\index.mjs:539

  537 | export async function click(page, selector, options) {
  538 |   const frame = getPageOrFrame(page);
> 539 |   await frame.waitForSelector(selector, options);
      |               ^
  540 |   await frame.click(selector, options);
  541 | }
  542 |

Steps to reproduce the issue:
cd demos/playground
1 pnpm run dev
in another console :
1 pnpm test-e2e-chromium

Playwright Test Report.zip

Hi @pan2za ,
I am not able to reproduce this issue.
I followed the steps to reproduce exactly and get the following:


Migrate to nextjs

Migrating app from react to nextjs. Nextjs uses react components, but is better when it comes to routes.

Deleted unused files for now. Will refactor and rewrite them as new functionality are added.

/lgtm


Child::status().await without closing stdin?

I'd like to be able to await on a running processes to finish without async-process closing its stdin.  I saw that there is a try_await which doesn't close stdin, but that function isn't async.

Is this the same issue as #19?

Yes, these are related

You can take out stdin and then call Child::status() without dropping stdin.


Added animation on submit button

@fineanmol sir,
Added framer motion library to animate submit button
On submit button i have added bouncing hover effect
Merge this under Hacktoberfest2020 and also add labels for this .

@shubham-1903 There has been conflicts on your MR. Can you please fix the conflict, so I can merge it under the hacktoberfest label.

@fineanmol i am not able see any conflict that's why I am unable to resolve conflicting issue.
I think you only can resolve this issue.
While cloning this repo there is changes in version (version updated to latest) in package-lock.json and yarn.lock that's why conflict occur.
I have used framer-motion so i have to change to  to <motion.div> to apply amination on button

@shubham-1903 Please refer the screenshot , as I am unable to merge.
Can you please rebase and make a fresh PR. We'll be happy to add your contribution in the project.


In interceptor mode, TracingDriver#acceptsURL should accept URLs without "tracing:"

Interceptor mode may not work in some cases. For instance, if another wrapper driver calls Driver#acceptsURL for each registered driver in order to find an underlying driver, it won't see TracingDriver unless the JDBC URL has been rewritten to have the jdbc:tracing: prefix.
Simple fix is to change TracingDriver#acceptsURL to be:
  @Override
  public boolean acceptsURL(String url) throws SQLException {
    return url != null && (
        url.startsWith(getUrlPrefix()) ||
        (interceptorMode && url.startsWith("jdbc:"))
    );
  }

that's not so simple.
acceptsURL(...) is used in TracingDriver.connect(...):
https://github.com/opentracing-contrib/java-jdbc/blob/master/src/main/java/io/opentracing/contrib/jdbc/TracingDriver.java#L153
this if statement also should be modified to explicitly accept urls only with "jdbc:tracing:"

We could modify TracingDriver#connect such that it doesn't try to parse the url if interceptorMode is true. Just need to move around those if branches like this:
if (interceptorMode) {
    withActiveSpanOnly = TracingDriver.withActiveSpanOnly;
    ignoreStatements = TracingDriver.ignoreStatements;
} else if (acceptsURL(url)) {
    withActiveSpanOnly = url.contains(WITH_ACTIVE_SPAN_ONLY);
    ignoreStatements = extractIgnoredStatements(url);
    url = extractRealUrl(url);
} else {
    return null;
}

I think this makes sense. Since in interceptor mode, the driver is supposed to be able to intercept JDBC operations without the need of modifying JDBC URLs, so it should not even try to find traceWithActiveSpanOnly or ignoreForTracing from the URLs.

@yisheng-liang would you like to submit PR?

Are you going to cut a new release soon? Releases were cut in January quite often but nothing in February.

0.2.9 is released


[libiconv:x64-windows] build failure

Host Environment

OS: Microsoft Windows 10 Pro Version 20H2 (Build 19042.928)
Compiler: Visual Studio 2019 Version 16.9.4

To Reproduce
Steps to reproduce the behavior:
./vcpkg.exe install libiconv:x64-windows
Failure logs
Output from PowerShell:
Computing installation plan...
The following packages will be built and installed:
    libiconv[core]:x64-windows -> 1.16#8
Detecting compiler hash for triplet x64-windows...
Could not locate cached archive: C:\Users\Tobias\AppData\Local\vcpkg\archives\26\26d2167072fc54a6fbc6f1af5a41842c0ebde6d6.zip
Starting package 1/1: libiconv:x64-windows
Building package libiconv[core]:x64-windows...
-- Using cached U:/Developer/vcpkg/downloads/libiconv-1.16.tar.gz
-- Cleaning sources at U:/Developer/vcpkg/buildtrees/libiconv/src/1.16-de9101a181.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source U:/Developer/vcpkg/downloads/libiconv-1.16.tar.gz
-- Applying patch 0002-Config-for-MSVC.patch
-- Applying patch 0003-Add-export.patch
-- Using source at U:/Developer/vcpkg/buildtrees/libiconv/src/1.16-de9101a181.clean
-- Configuring x64-windows
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:105 (message):
    Command failed: "C:/Program Files/CMake/bin/cmake.exe" -E tar xzf U:/Developer/vcpkg/downloads/msys-binutils-2.34-4-x86_64.pkg.tar.zst
    Working Directory: U:/Developer/vcpkg/downloads/tools/msys2/d589ebc2087b2b2c.tmp
    Error code: 1
    See logs for more information:
      U:\Developer\vcpkg\buildtrees\libiconv\msys-x64-windows-3-err.log

Call Stack (most recent call first):
  scripts/cmake/vcpkg_acquire_msys.cmake:524 (vcpkg_execute_required_process)
  scripts/cmake/vcpkg_configure_make.cmake:291 (vcpkg_acquire_msys)
  ports/libiconv/portfile.cmake:28 (vcpkg_configure_make)
  scripts/ports.cmake:142 (include)

Error: Building package libiconv:x64-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with `.\vcpkg update`, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
  Package: libiconv:x64-windows
  Vcpkg version: 2021-01-13-d67989bce1043b98092ac45996a8230a059a2d7e

Additionally, attach any relevant sections from the log files above.

Additional context
I ensured that I'm using the latest portfiles.
The added the mentioned log file msys-x64-windows-3-err.log: msys-x64-windows-3-err.log
`

Looks like the downloaded file is broken. Maybe delete the folder U:/Developer/vcpkg/downloads and retry the installation.

Sorry, but that didn't helped.
I deleted the folder U:/Developer/vcpkg/downloads and tried to build again. The build still fails. The output from PowerShell is the following:
Computing installation plan...
The following packages will be built and installed:
    libiconv[core]:x64-windows -> 1.16#8
Detecting compiler hash for triplet x64-windows...
Could not locate cached archive: C:\Users\Tobias\AppData\Local\vcpkg\archives\26\26d2167072fc54a6fbc6f1af5a41842c0ebde6d6.zip
Starting package 1/1: libiconv:x64-windows
Building package libiconv[core]:x64-windows...
-- Downloading https://ftp.gnu.org/gnu/libiconv/libiconv-1.16.tar.gz -> libiconv-1.16.tar.gz...
-- Cleaning sources at U:/Developer/vcpkg/buildtrees/libiconv/src/1.16-de9101a181.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source U:/Developer/vcpkg/downloads/libiconv-1.16.tar.gz
-- Applying patch 0002-Config-for-MSVC.patch
-- Applying patch 0003-Add-export.patch
-- Using source at U:/Developer/vcpkg/buildtrees/libiconv/src/1.16-de9101a181.clean
-- Found external ninja('1.10.2').
-- Configuring x64-windows
-- Downloading https://repo.msys2.org/msys/x86_64/bash-4.4.023-2-x86_64.pkg.tar.xz -> msys-bash-4.4.023-2-x86_64.pkg.tar.xz...
-- Downloading https://repo.msys2.org/msys/x86_64/autoconf-2.69-5-any.pkg.tar.xz -> msys-autoconf-2.69-5-any.pkg.tar.xz...
-- Downloading https://repo.msys2.org/msys/x86_64/diffutils-3.7-1-x86_64.pkg.tar.xz -> msys-diffutils-3.7-1-x86_64.pkg.tar.xz...
-- Downloading https://repo.msys2.org/msys/x86_64/binutils-2.34-4-x86_64.pkg.tar.zst -> msys-binutils-2.34-4-x86_64.pkg.tar.zst...
-- Downloading https://repo.msys2.org/msys/x86_64/libtool-2.4.6-9-x86_64.pkg.tar.xz -> msys-libtool-2.4.6-9-x86_64.pkg.tar.xz...
-- Downloading https://repo.msys2.org/msys/x86_64/file-5.39-1-x86_64.pkg.tar.zst -> msys-file-5.39-1-x86_64.pkg.tar.zst...
-- Downloading https://repo.msys2.org/msys/x86_64/zlib-1.2.11-1-x86_64.pkg.tar.xz -> msys-zlib-1.2.11-1-x86_64.pkg.tar.xz...
-- Downloading https://repo.msys2.org/msys/x86_64/libbz2-1.0.8-2-x86_64.pkg.tar.xz -> msys-libbz2-1.0.8-2-x86_64.pkg.tar.xz...
-- Downloading https://repo.msys2.org/msys/x86_64/coreutils-8.32-1-x86_64.pkg.tar.xz -> msys-coreutils-8.32-1-x86_64.pkg.tar.xz...
-- Downloading https://repo.msys2.org/msys/x86_64/grep-3.0-2-x86_64.pkg.tar.xz -> msys-grep-3.0-2-x86_64.pkg.tar.xz...
-- Downloading https://repo.msys2.org/msys/x86_64/sed-4.8-1-x86_64.pkg.tar.xz -> msys-sed-4.8-1-x86_64.pkg.tar.xz...
-- Downloading https://repo.msys2.org/msys/x86_64/libpcre-8.44-1-x86_64.pkg.tar.xz -> msys-libpcre-8.44-1-x86_64.pkg.tar.xz...
-- Downloading https://repo.msys2.org/msys/x86_64/m4-1.4.18-2-x86_64.pkg.tar.xz -> msys-m4-1.4.18-2-x86_64.pkg.tar.xz...
-- Downloading https://repo.msys2.org/msys/x86_64/automake-wrapper-11-1-any.pkg.tar.xz -> msys-automake-wrapper-11-1-any.pkg.tar.xz...
-- Downloading https://repo.msys2.org/msys/x86_64/gawk-5.1.0-1-x86_64.pkg.tar.xz -> msys-gawk-5.1.0-1-x86_64.pkg.tar.xz...
-- Downloading https://repo.msys2.org/msys/x86_64/mpfr-4.1.0-1-x86_64.pkg.tar.zst -> msys-mpfr-4.1.0-1-x86_64.pkg.tar.zst...
-- Downloading https://repo.msys2.org/msys/x86_64/gmp-6.2.0-1-x86_64.pkg.tar.xz -> msys-gmp-6.2.0-1-x86_64.pkg.tar.xz...
-- Downloading https://repo.msys2.org/msys/x86_64/libreadline-8.0.004-1-x86_64.pkg.tar.xz -> msys-libreadline-8.0.004-1-x86_64.pkg.tar.xz...
-- Downloading https://repo.msys2.org/msys/x86_64/ncurses-6.2-1-x86_64.pkg.tar.xz -> msys-ncurses-6.2-1-x86_64.pkg.tar.xz...
-- Downloading https://repo.msys2.org/msys/x86_64/automake1.16-1.16.2-2-any.pkg.tar.zst -> msys-automake1.16-1.16.2-2-any.pkg.tar.zst...
-- Downloading https://repo.msys2.org/msys/x86_64/perl-5.32.0-2-x86_64.pkg.tar.zst -> msys-perl-5.32.0-2-x86_64.pkg.tar.zst...
-- Downloading https://repo.msys2.org/msys/x86_64/libcrypt-2.1-2-x86_64.pkg.tar.xz -> msys-libcrypt-2.1-2-x86_64.pkg.tar.xz...
-- Downloading https://repo.msys2.org/msys/x86_64/pkg-config-0.29.2-4-x86_64.pkg.tar.zst -> msys-pkg-config-0.29.2-4-x86_64.pkg.tar.zst...
-- Downloading https://repo.msys2.org/msys/x86_64/make-4.3-1-x86_64.pkg.tar.xz -> msys-make-4.3-1-x86_64.pkg.tar.xz...
-- Downloading https://repo.msys2.org/msys/x86_64/findutils-4.7.0-1-x86_64.pkg.tar.xz -> msys-findutils-4.7.0-1-x86_64.pkg.tar.xz...
-- Downloading https://repo.msys2.org/msys/x86_64/libintl-<IP_ADDRESS>-1-x86_64.pkg.tar.xz -> msys-libintl-<IP_ADDRESS>-1-x86_64.pkg.tar.xz...
-- Downloading https://repo.msys2.org/msys/x86_64/libiconv-1.16-2-x86_64.pkg.tar.zst -> msys-libiconv-1.16-2-x86_64.pkg.tar.zst...
-- Downloading https://repo.msys2.org/msys/x86_64/gcc-libs-9.3.0-1-x86_64.pkg.tar.xz -> msys-gcc-libs-9.3.0-1-x86_64.pkg.tar.xz...
-- Downloading https://repo.msys2.org/msys/x86_64/msys2-runtime-3.1.6-3-x86_64.pkg.tar.xz -> msys-msys2-runtime-3.1.6-3-x86_64.pkg.tar.xz...
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:105 (message):
    Command failed: "C:/Program Files/CMake/bin/cmake.exe" -E tar xzf U:/Developer/vcpkg/downloads/msys-binutils-2.34-4-x86_64.pkg.tar.zst
    Working Directory: U:/Developer/vcpkg/downloads/tools/msys2/d589ebc2087b2b2c.tmp
    Error code: 1
    See logs for more information:
      U:\Developer\vcpkg\buildtrees\libiconv\msys-x64-windows-3-err.log

Call Stack (most recent call first):
  scripts/cmake/vcpkg_acquire_msys.cmake:524 (vcpkg_execute_required_process)
  scripts/cmake/vcpkg_configure_make.cmake:291 (vcpkg_acquire_msys)
  ports/libiconv/portfile.cmake:28 (vcpkg_configure_make)
  scripts/ports.cmake:142 (include)

Error: Building package libiconv:x64-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with `.\vcpkg update`, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
  Package: libiconv:x64-windows
  Vcpkg version: 2021-01-13-d67989bce1043b98092ac45996a8230a059a2d7e

Additionally, attach any relevant sections from the log files above.

The text in the mentioned log file is as following:
CMake Error: Problem with archive_write_header(): Can't create '\\?\U:\Developer\vcpkg\downloads\tools\msys2\d589ebc2087b2b2c.tmp\usr\bin\ld.exe'
CMake Error: Current file: usr/bin/ld.exe
CMake Error: Problem extracting tar: U:/Developer/vcpkg/downloads/msys-binutils-2.34-4-x86_64.pkg.tar.zst

Maybe try this: #6059

No, sorry, that didn't work either.
I read the issue you linked and the UTF-8 beta in intl.cpl > Administrative > Change system locale...  was already unticked on my system. I also read the issue that was linked in the issue you mentioned and tried to change the codepage of PowerShell to 437 instead of the 65001 I previously used. But even the changed codepage resulted in the same error.
The error (both the log from the PowerShell and the content of the log file) remains in both cases the same (e. g. I have the same output).

cc @cenit

Maybe it's a permission issue.

I'm not sure if that's the case. I deactivated the controlled folder access in Windows Defender and tried again unsuccessfully (I thought that you meant this when you wrote "permission issue"). I even tried to delete the content of the entire folder U:\Developer\vcpkg and cloned vcpkg in that folder and tried to built libiconv:x64-windows again but still unsuccessfully. Then I did the same but in the path U:\dev\vcpkg but with the same result. After that, I tried the same again in the path C:\dev\vcpkg and it worked and I built successfully libiconv:x64-windows. I don't know why it worked - maybe it's the drive letter U: but I'm not sure.
I'm closing this issue because I found a workaround that works for me. Thank you for your help and your suggesstions.

@JackBoosY No, I didn't solved that issue. I just found a workaround for me.


[Task]: Identify File data type in evaluated value

Is there an existing issue for this?

[X] I have searched the existing issues

SubTasks
Identify file data type in evaluated values.
Analyse all possible boundary conditions. And test for multiple types of file.

Will be handled by server, so closing this issue.
But still couldn’t find logic to identify on client-side, as there can be 2 kinds of input

{type:image/jpeg,data:....,...} - type -js object
data:.... - js type: string
And many more types like blob, File object, URL's.


Background color not exported to PDF

When exporting a diagram, which has a page with a background color set, the color is not exported to the pdf.
Untitled Diagram(2).pdf
green_background.drawio.zip

What are the steps and environment to recreate?

Environment: https://www.draw.io/
Steps:

Create new blank diagram
Create second page
Define different color for the diagram background for that page

Switch back to first page
Export as PDF (all pages) → NOK: All page are white

It seems as the pdf export takes the background color that is defined for the currently displayed/active page and applies it to all pdf pages.

Fixed in 11.1.5.

The problem still exists if Grid is enabled during pdf-export.

@jlnobles please create a new ticket if there are a set of conditions that recreate the problem but vary from the original report.


Reproducing adult dataset numbers (recall problems in my tests)

Hey there again,
I'm trying to build another model with an EBM although I'm running into major recall problems so I thought about trying the adult dataset to see if I'm doing something wrong.
I have tried
import pandas as pd
from sklearn.model_selection import train_test_split

df = pd.read_csv(
    "https://archive.ics.uci.edu/ml/machine-learning-databases/adult/adult.data",
    header=None)
df.columns = [
    "Age", "WorkClass", "fnlwgt", "Education", "EducationNum",
    "MaritalStatus", "Occupation", "Relationship", "Race", "Gender",
    "CapitalGain", "CapitalLoss", "HoursPerWeek", "NativeCountry", "Income"
]
# df = df.sample(frac=0.1, random_state=1)
train_cols = df.columns[0:-1]
label = df.columns[-1]
X = df[train_cols]
y = df[label].apply(lambda x: 0 if x == " <=50K" else 1) #Turning response into 0 and 1

seed = 1
X_train, X_test, y_train, y_test = train_test_split(X, y, test_size=0.20, random_state=seed)

from interpret.glassbox import ExplainableBoostingClassifier, LogisticRegression, ClassificationTree, DecisionListClassifier

ebm = ExplainableBoostingClassifier(random_state=seed, interactions=0)
ebm.fit(X_train, y_train)   #Works on dataframes and numpy arrays

print(classification_report(y_test, ebm.predict(X_test)))

yields
              precision    recall  f1-score   support

           0       0.90      0.93      0.92      5026
           1       0.75      0.66      0.70      1487

    accuracy                           0.87      6513
   macro avg       0.83      0.80      0.81      6513
weighted avg       0.87      0.87      0.87      6513

Which seems like poor results compared to what is posted on the README. Perhaps I'm doing something wrong?
Thanks!
-Matt

Ah! auc_score is what is being used. ok nvm then


Show only identities that are verified

What happened?
i used a fake identity and i stole that name in the top spotlight and it worked.
maybe it will affect my account if i sell NFT and will get profit myself.
because someone will be fooled and unknowingly to buy it, because of the NFT maker of RMRK Official.

Please reproduce in steps
go to profile --> identy --> and then steal the name of a famous identity
Expected Behavior
this shouldn't have happened if that identity was already in use :)
What browsers are you seeing the problem on?

Yes
At which address did you encounter bug?
beta.kodadot.xyz, kodadot.xyz
Screenshots
https://user-images.githubusercontent.com/43703018/159123642-19162b51-1481-451c-a4e4-29ad855bc78a.mp4
Relevant log output
No response
Payment link for reward
https://kodadot.xyz/transfer?target=GF4v68qJmh47eShYNpPs5JNfn5bxG5Kz1U2Y4xC2xAqXqmq&usdamount=10
Code of Conduct

[X] I agree to follow this project's Code of Conduct

I guess identity 🆔 is not unique like ENS, but we're thinking make it more unique.

used a fake identity and i stole that name in the top spotlight and it worked.

Can you post recording from this?

I guess identity 🆔 is not unique like ENS, but we're thinking make it more unique.

used a fake identity and i stole that name in the top spotlight and it worked.

Can you post recording from this?

yeah right i also think so identity is not like ens but can you make it unique in kodadot? so that the name that has been used can not be used again?.
for example I have cloned the official name and nft rmrk :

https://kodadot.xyz/rmrk/detail/11238345-e0b9bdcc456a36497a-RMRKBNNRS-BREACH-0000000000000001 <-- REAL
https://kodadot.xyz/rmrk/gallery/11877427-A2421E1ACB58485A27-BREACH-BREACH-0000000000000001 <--- FAKE
Isn't it almost the same as the original?
someone who is drunk will buy a fake one, so someone who cheats installs fake nft at a lower price and in the name of the RMRK official

The possibility is to show only verified identities:
The second option is that we can probably give the other color (like green for verified addr)

The possibility is to show only verified identities: The second option is that we can probably give the other color (like green for verified addr)

if it's just to give color maybe the new face in kodadot will feel confused.
how to add a blue tick or something.
that if it can be achieved and if you want :)

hey someone has bought this nft and they are selling it for a higher price. @yangwao will you prioritize this issue or not?. :))
I want to thank him for testing this invention, I will buy it if the price will go back to the way it was.
It's a good idea if you create a red flag display like this:

It's a good idea if you create a red flag display like this:
Hey we don't have any centralized DB where we can mark people as plagiators
with upcoming token we can solve this by decentralized way

@yangwao will you prioritize this issue or not?

sure putting in pipe :)

ref: https://github.com/kodadot/rubick/issues/56


Required secret param isn't set (php 7)

When i update my local php from 5.6 to 7 i got this error, because !empty( Yii::$app->reCaptcha->secret;) - rerutns only FALSE

When testing locally, Google doesn't require the sitekey or secret, so that we CAN TEST. This is a flaw in the latest version of this extension.
This extension should check if we are running Yii in dev mode before requiring that we provide the sitekey or secret.

Wade whats up man hit me up on skype.  @WadeShuler

send me your username, I don't have my old skype.

hey its harrismarketing @WadeShuler

ok then, PHP 7 empty() function work really bad when works with magic methods.
therefore we have __isset() in our main(yii2) sevice locator that don't work in php 7.
there is two solutions 1) update all service locator childs adding __isset() method OR
2) don't use yii2 with php 7
And my solution is easy as f*ck just before we check !empty(yii::$app->reCaptcha->siteKey)
put  this magic method in variable yii::$app->reCaptcha->siteKey => $siteKey = yii::$app->reCaptcha->siteKey. Thats it, and all of us will be happy

hey wade add me on skype my username is<EMAIL_ADDRESS>@WadeShuler

hello. when you accept request?

https://github.com/himiklab/yii2-recaptcha-widget/pull/37


[stable/concourse] Bump image tag to 5.4.0

What this PR does / why we need it:
Bumps the image tag to 5.4.0
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Title of the PR starts with chart name (e.g. [stable/chart])

/ok-to-test

Hey @taylorsilva , missed the README.md 😁

Thanks!

@cirocosta Updated!

/lgtm


[google_maps_flutter] Flutter app crash on iPadOS EXC_BAD_ACCESS (code=2, address=0x16da77ff8)

My flutter app displays a screen with Google Map and a list of Item, the List of Item is updating every 30 secs.
The app is running ok on my android devices, but when it runs on my IPad (iPadOS 14.2) it crashes occasionally after running for a while.
I tried to run the app using Xcode and when it crashes. It shows this:

And this is what from Flutter run -verbose when I run with Vscode
Steps to Reproduce
MAKE SURE TO RUN THE APP ON DEBUG MODE. BECAUSE THE ISSUE WILL EASILY HAPPEN
run the code below and let the app being idle for 5-10 mins.(set the screen time out to "never" on your iOS device)
after that time of idle. touch on the app and it will crash
import 'dart:async';
import 'dart:math' show pi;
import 'package:http/http.dart' show Client;
import 'package:flutter/material.dart';
import 'package:google_maps_flutter/google_maps_flutter.dart';

class MapTestScreen extends StatefulWidget {
  static final String routeName = '/map_test';
  @override
  _MapTestScreenState createState() => _MapTestScreenState();
}

class _MapTestScreenState extends State<MapTestScreen>
    with TickerProviderStateMixin {
  GoogleMapController _controller;
  Timer _timer;
  double _val = 0.1;

  @override
  void initState() {
    super.initState();

    // _rotateAnimation = Tween<double>();
    _timer = Timer.periodic(Duration(seconds: 20), (_) async {
      final response =
          await Client().get('https://jsonplaceholder.typicode.com/posts');
      print(response.body);
      if (_val >= 1) {
        setState(() {
          _val = 0.1;
        });
      } else {
        setState(() {
          _val += 0.1;
        });
      }
      _controller.getLatLng(ScreenCoordinate(x: 1, y: 1));
    });
  }

  @override
  void dispose() {
    super.dispose();
    _timer.cancel();
    _controller.dispose();
  }

  @override
  Widget build(BuildContext context) {
    final size = MediaQuery.of(context).size;
    return Scaffold(
      body: Stack(
        children: [
          GoogleMap(
            initialCameraPosition: CameraPosition(
              target: LatLng(75, 74),
              zoom: 4,
            ),
            onMapCreated: (ctl) {
              _controller = ctl;
            },
            onCameraMove: (_) {
              _controller.getLatLng(ScreenCoordinate(x: 1, y: 1));
            },
          ),
          for (double i = 2.1; i < 7.0; i += 0.6)
            Positioned(
              top: 100 * i,
              left: 100 * i,
              child: RotatingBox(),
            )
        ],
      ),
    );
  }
}

class RotatingBox extends StatefulWidget {
  RotatingBox({Key key}) : super(key: key);

  @override
  _RotatingBoxState createState() => _RotatingBoxState();
}

class _RotatingBoxState extends State<RotatingBox>
    with TickerProviderStateMixin {
  AnimationController _rotateCtrl;

  @override
  void initState() {
    super.initState();

    _rotateCtrl = AnimationController(
      vsync: this,
      duration: Duration(milliseconds: 400),
    )..repeat();
  }

  @override
  void dispose() {
    _rotateCtrl.dispose();
    super.dispose();
  }

  @override
  Widget build(BuildContext context) {
    return AnimatedBuilder(
        animation: _rotateCtrl,
        builder: (context, snapshot) {
          return Transform.rotate(
            angle: pi * _rotateCtrl.value * 2,
            child: Container(
              height: 60,
              width: 60,
              color: Colors.green,
            ),
          );
        });
  }
}

[+2194 ms] Service protocol connection closed.
[        ] Lost connection to device.
[   +4 ms] DevFS: Deleting filesystem on the device (file:///private/var/mobile/Containers/Data/Application/2134A5A2-DFE2-47F4-9562-54FD25D9CEE8/tmp/<my-app-name>)
[ +255 ms] Ignored error while cleaning up DevFS: TimeoutException after 0:00:00.250000: Future not completed

Basically, it's running normally, and I let the app idle for a while. As soon as I touch on the app. it crashes

My pubspec.yaml
name: map_test
description: A new Flutter project.

publish_to: 'none' # Remove this line if you wish to publish to pub.dev
version: 1.0.0+1

environment:
  sdk: ">=2.7.0 <3.0.0"

dependencies:
  flutter:
    sdk: flutter
  cupertino_icons: ^1.0.0
  google_maps_flutter: ^1.2.0
  http: ^0.12.2

dev_dependencies:
  flutter_test:
    sdk: flutter
flutter:

  uses-material-design: true

flutter analyze
Analyzing <my_flutter_app_name>...
No issues found! (ran in 4.4s)

[✓] Flutter (Channel stable, 1.22.5, on macOS 11.1 20C69 darwin-x64, locale
    en-CA)
    • Flutter version 1.22.5 at /Users/samderlust/flutter
    • Framework revision<PHONE_NUMBER> (12 days ago), 2020-12-10 11:54:40 -0800
    • Engine revision ae90085a84
    • Dart version 2.10.4

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at /Users/samderlust/Library/Android/sdk
    • Platform android-29, build-tools 29.0.3
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    • CocoaPods version 1.8.3

[!] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)

[!] IntelliJ IDEA Community Edition (version 2020.2)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • For information about installing plugins, see
      https://flutter.dev/intellij-setup/#installing-the-plugins

[✓] VS Code (version 1.52.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.17.0

[✓] Connected device (1 available)
    • iPad (2) (mobile) • 00008027-001D39002E0A002E • ios • iOS 14.2

! Doctor found issues in 2 categories.

Hi @samderlust
Can you please provide flutter run --verbose with crash logs and a minimal complete reproducible code sample?
Thank you

@TahaTesser
I just added it. thanks

Hi @samderlust
To better address the issue, please create a minimal code sample based on your description. Isolate the code that causes the issue and without using the third-party packages.
Thank you

After a while I think the problem come from the Google map plugin since the other screen has the maps crashes as well.
I do a search and think that my problem is the same with  40650

After a while I think the problem come from the Google map plugin since the other screen has the maps crashes as well.
I do a search and think that my problem is the same with  40650

I reopen this issue since I'm able to update the step to reproduce this issue. Please kindly take a look at the first post

Hi @samderlust
Here I created a complete runnable code sample from your snippet, using the latestgoogle_maps_flutter: ^1.2.0 on iPad with iOS 14.4, I can't reproduce any crash in  Xcode or VS Code, ran 10 min, no issues
Please try this code sample with latest google_maps_flutter: ^1.2.0 (you're using an older version) and provide steps to reproduce

code sample
import 'dart:async';
import 'dart:math' show pi;
import 'package:flutter/material.dart';
import 'package:google_maps_flutter/google_maps_flutter.dart';

void main() {
  runApp(MaterialApp(
    title: 'Named Routes Demo',
    initialRoute: '/',
    routes: {
      '/': (context) => FirstScreen(),
      '/map_test': (context) => MapTestScreen(),
    },
  ));
}

class FirstScreen extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text('First Screen'),
      ),
      body: Center(
        child: ElevatedButton(
          child: Text('Launch screen'),
          onPressed: () {
            // Navigate to the second screen using a named route.
            Navigator.pushNamed(context, MapTestScreen.routeName);
          },
        ),
      ),
    );
  }
}

class MapTestScreen extends StatefulWidget {
  static final String routeName = '/map_test';
  @override
  _MapTestScreenState createState() => _MapTestScreenState();
}

class _MapTestScreenState extends State<MapTestScreen>
    with TickerProviderStateMixin {
  GoogleMapController _controller;
  Timer _timer;
  double _val = 0.1;

  @override
  void initState() {
    super.initState();

    // _rotateAnimation = Tween<double>();
    _timer = Timer.periodic(Duration(seconds: 20), (_) {
      if (_val >= 1) {
        setState(() {
          _val = 0.1;
        });
      } else {
        setState(() {
          _val += 0.1;
        });
      }
      _controller.getLatLng(ScreenCoordinate(x: 1, y: 1));
    });
  }

  @override
  void dispose() {
    super.dispose();
    _timer.cancel();
    _controller.dispose();
  }

  @override
  Widget build(BuildContext context) {
    final size = MediaQuery.of(context).size;
    return Scaffold(
      body: Stack(
        children: [
          GoogleMap(
            initialCameraPosition: CameraPosition(
              target: LatLng(75, 74),
              zoom: 4,
            ),
            onMapCreated: (ctl) {
              _controller = ctl;
            },
            onCameraMove: (_) {
              _controller.getLatLng(ScreenCoordinate(x: 1, y: 1));
            },
          ),
          for (double i = 2.1; i < 7.0; i += 0.6)
            Positioned(
              top: 100 * i,
              left: 100 * i,
              child: RotatingBox(),
            )
        ],
      ),
    );
  }
}

class RotatingBox extends StatefulWidget {
  RotatingBox({Key key}) : super(key: key);

  @override
  _RotatingBoxState createState() => _RotatingBoxState();
}

class _RotatingBoxState extends State<RotatingBox>
    with TickerProviderStateMixin {
  AnimationController _rotateCtrl;

  @override
  void initState() {
    super.initState();

    _rotateCtrl = AnimationController(
      vsync: this,
      duration: Duration(milliseconds: 400),
    )..repeat();
  }

  @override
  void dispose() {
    _rotateCtrl.dispose();
    super.dispose();
  }

  @override
  Widget build(BuildContext context) {
    return AnimatedBuilder(
        animation: _rotateCtrl,
        builder: (context, snapshot) {
          return Transform.rotate(
            angle: pi * _rotateCtrl.value * 2,
            child: Container(
              height: 60,
              width: 60,
              color: Colors.green,
            ),
          );
        });
  }
}

flutter doctor -v
[✓] Flutter (Channel stable, 1.22.6, on macOS 11.2 20D64 darwin-x64, locale en-GB)
    • Flutter version 1.22.6 at /Users/tahatesser/Code/flutter_stable
    • Framework revision 9b2d32b605 (3 weeks ago), 2021-01-22 14:36:39 -0800
    • Engine revision 2f0af37152
    • Dart version 2.10.5
[✗] Android toolchain - develop for Android devices
    ✗ Unable to locate Android SDK.
      Install Android Studio from: https://developer.android.com/studio/index.html
      On first launch it will assist you in installing the Android SDK components.
      (or visit https://flutter.dev/docs/get-started/install/macos#android-setup for detailed instructions).
      If the Android SDK has been installed to a custom location, set ANDROID_SDK_ROOT to that location.
      You may also want to add it to your PATH environment variable.
[!] Xcode - develop for iOS and macOS (Xcode 12.4)
    • Xcode at /Volumes/Extreme/Xcode.app/Contents/Developer
    • Xcode 12.4, Build version 12D4e
    ✗ CocoaPods not installed.
        CocoaPods is used to retrieve the iOS and macOS platform side's plugin code that responds to your plugin usage on the Dart side.
        Without CocoaPods, plugins will not work on iOS or macOS.
        For more info, see https://flutter.dev/platform-plugins
      To install:
        sudo gem install cocoapods
[!] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
[✓] VS Code (version 1.53.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.19.0
[✓] Connected device (1 available)
    • Taha’s iPad (mobile) • 00008020-000255113EE8402E • ios • iOS 14.4
! Doctor found issues in 3 categories.

Thank you

Yeah, This issue is not happen all the time. Some time it happen really soon some time it takes a while to happen.
Last time I test this I was using maps_flutter: 1.2.0

I've ran it 2 times this morning and it happened after around 10-15 mins maybe. I added fetching API into the code so it could  happen easier.
In addition, I run on iPad Pro 11. the screen refresh rate could affect this issue to happen more frequently than normal iPad?
Since it doest happen as frequent as on my iPhone Xs

Hi @samderlust
I just doubled the rotating square still has no issue when running on physical iPad on iOS 14.4
Can you please update the example that could reproduce the crash reliably? fetching any open-source test API?
Thank you

Hi, I've created a new app for testing this and still getting same issue even run on Vscode or Xcode.
There's nothing clear for me on how to make it crash. But basically just let the app run for awhile(5,10, 15,.. mins) and then touch the app again. it crashes.
Below is the code
import 'dart:async';
import 'dart:math' show pi;

import 'package:flutter/material.dart';
import 'package:google_maps_flutter/google_maps_flutter.dart';
import 'package:http/http.dart' show Client;

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
        visualDensity: VisualDensity.adaptivePlatformDensity,
      ),
      home: MapTestScreen(),
    );
  }
}

class MapTestScreen extends StatefulWidget {
  @override
  _MapTestScreenState createState() => _MapTestScreenState();
}

class _MapTestScreenState extends State<MapTestScreen>
    with TickerProviderStateMixin {
  GoogleMapController _controller;
  Timer _timer;
  double _val = 0.1;

  @override
  void initState() {
    super.initState();

    // _rotateAnimation = Tween<double>();
    _timer = Timer.periodic(Duration(seconds: 20), (_) async {
      final response =
          await Client().get('https://jsonplaceholder.typicode.com/posts');
      print(response.body);
      if (_val >= 1) {
        setState(() {
          _val = 0.1;
        });
      } else {
        setState(() {
          _val += 0.1;
        });
      }
      _controller.getLatLng(ScreenCoordinate(x: 1, y: 1));
    });
  }

  @override
  void dispose() {
    super.dispose();
    _timer.cancel();
    _controller.dispose();
  }

  @override
  Widget build(BuildContext context) {
    final size = MediaQuery.of(context).size;
    return Scaffold(
      body: Stack(
        children: [
          GoogleMap(
            initialCameraPosition: CameraPosition(
              target: LatLng(75, 74),
              zoom: 4,
            ),
            onMapCreated: (ctl) {
              _controller = ctl;
            },
            onCameraMove: (_) {
              _controller.getLatLng(ScreenCoordinate(x: 1, y: 1));
            },
          ),
          for (double i = 1.1; i < 10.0; i += 0.8)
            Positioned(
              top: 100,
              left: 100 * i,
              child: RotatingBox(),
            )
        ],
      ),
    );
  }
}

class RotatingBox extends StatefulWidget {
  RotatingBox({Key key}) : super(key: key);

  @override
  _RotatingBoxState createState() => _RotatingBoxState();
}

class _RotatingBoxState extends State<RotatingBox>
    with TickerProviderStateMixin {
  AnimationController _rotateCtrl;

  @override
  void initState() {
    super.initState();

    _rotateCtrl = AnimationController(
      vsync: this,
      duration: Duration(milliseconds: 400),
    )..repeat();
  }

  @override
  void dispose() {
    _rotateCtrl.dispose();
    super.dispose();
  }

  @override
  Widget build(BuildContext context) {
    return AnimatedBuilder(
        animation: _rotateCtrl,
        builder: (context, snapshot) {
          return Transform.rotate(
            angle: pi * _rotateCtrl.value * 2,
            child: Container(
              height: 60,
              width: 60,
              color: Colors.green,
            ),
          );
        });
  }
}

App Screenshot

Xcode screenshot

Hi @samderlust
Tried to reproduce again using your updated code sample on iPad 8 running iOS 14.4

flutter doctor -v
[✓] Flutter (Channel stable, 1.22.6, on macOS 11.2.1 20D74 darwin-x64, locale en-GB)
    • Flutter version 1.22.6 at /Users/tahatesser/Code/flutter_stable
    • Framework revision 9b2d32b605 (3 weeks ago), 2021-01-22 14:36:39 -0800
    • Engine revision 2f0af37152
    • Dart version 2.10.5
[✗] Android toolchain - develop for Android devices
    ✗ Unable to locate Android SDK.
      Install Android Studio from: https://developer.android.com/studio/index.html
      On first launch it will assist you in installing the Android SDK components.
      (or visit https://flutter.dev/docs/get-started/install/macos#android-setup for detailed instructions).
      If the Android SDK has been installed to a custom location, set ANDROID_SDK_ROOT to that location.
      You may also want to add it to your PATH environment variable.
[!] Xcode - develop for iOS and macOS (Xcode 12.4)
    • Xcode at /Volumes/Extreme/Xcode.app/Contents/Developer
    • Xcode 12.4, Build version 12D4e
    ✗ CocoaPods not installed.
        CocoaPods is used to retrieve the iOS and macOS platform side's plugin code that responds to your plugin usage on the Dart side.
        Without CocoaPods, plugins will not work on iOS or macOS.
        For more info, see https://flutter.dev/platform-plugins
      To install:
        sudo gem install cocoapods
[!] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
[✓] VS Code (version 1.53.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.19.0
[✓] Connected device (2 available)
    • Taha’s iPad (mobile) • 00008020-000255113EE8402E            • ios • iOS 14.4
    • iPhone 12 (mobile)   • FE087B7C-047B-40A9-AAEF-34B4AB9B4B1B • ios • com.apple.CoreSimulator.SimRuntime.iOS-14-4 (simulator)
! Doctor found issues in 3 categories.

Ran the app for 20 mins (two times, once in VS Code and once in Xcode), no crash
Since it's reproducible for you on iPad, I feel safe to label this
Thank you

Hi @TahaTesser  this happens quite consistently on my iPad Pro. It takes a longer time on my iPhone. I'm thinking if the refresh rate could be an impact? (since iPad Pro has the refresh rate of 120 fps).
When you run the app, could you try to move the map a round at first. and then let the app idle for a while before touching it again. That's how the app crashes every time  on my end.

I'm closing this since https://github.com/flutter/plugins/pull/3426 solved my issue

@samderlust
Let's wait for PR to get merged

The linked PR was merged and there have been no similar reports since, so I will safely close this as resolved.
If anybody still sees a similar issue, please file a new issue with relevant details.


Explicit IPv4 support

Currently, in the case of dual-stack (where v4 and v6 are assigned) dig ip @dns.toys always returns a v6 address. It would be great to have the IP query return the v4 address when mentioned.
I am willing to work on this.

I'm not sure how the net lib behaves with dual stack IPs, but guessing killing the switch{} and splitting the cases to two if conditions should work. I've no way of testing this. Please feel free to send a PR if you're able to test this.
https://github.com/knadh/dns.toys/blob/master/cmd/dnstoys/handlers.go#L110

Hey @knadh, sorry for delay in response. I figured that my DNS server is returning AAAA record for dns.toys and hence my request to dns.toys is always going via IPv6. Hence, there is no way for us to return IPv4 if the request is made over IPv6.
Would love to hear your thoughts and close this issue.

I figured that my DNS server is returning AAAA record for dns.toys and hence my request to dns.toys is always going via IPv6. Hence, there is no way for us to return IPv4 if the request is made over IPv6.

Yep.

For the interested reader who lands here via search:
# IPv4
dig -4 ip @dns.toys

# IPv6
dig -6 ip @dns.toys


keep going when single test runs fail, but exit make signaling error

So far we've been ignoring non-zero exit codes from the two test runs for each of unit and e2e test recipes in GH Action, leading to tests being shown as always passing even if one or both of the test runs failed.
This PR adds --keep-going to avoid stopping the recipe, while propagating error conditions to the make exit code.

@hotzevzl hope this works as the pipeline wasn't triggered in this PR

@hotzevzl hope this works as the pipeline wasn't triggered in this PR

yep, I triggered a manual run to test (https://github.com/Vizzuality/marxan-cloud/runs/2644588837) but it looks like we've only had all-green e2e runs for a while, so we'd need to purposefully break at least a test to check that this works in GH Actions.
Locally this works for me if I break a test on purpose: here is the final excerpt of a local test run showing the API tests failing, the geoprocessing ones running nevertheless, and make eventually terminating after teardown with non-zero exit code:
marxan-test-unit-api | PASS src/modules/scenarios/wdpa-area-calculation.service.spec.ts
marxan-test-unit-api | PASS src/modules/scenarios/dto/update-scenario-planning-unit-lock-status-dto.spec.ts
marxan-test-unit-api | PASS src/modules/ping/ping.controller.spec.ts
marxan-test-unit-api | PASS src/modules/analysis/providers/planning-units/adapters/async-jobs-adapter.spec.ts
marxan-test-unit-api | PASS src/modules/analysis/providers/status/scenario-status.service.spec.ts
marxan-test-unit-api |
marxan-test-unit-api | Snapshot Summary
marxan-test-unit-api |  › 1 snapshot failed from 1 test suite. Inspect your code changes or run `yarn run test:unit:ci -u` to update them.
marxan-test-unit-api |
marxan-test-unit-api | Test Suites: 1 failed, 14 passed, 15 total
marxan-test-unit-api | Tests:       1 failed, 48 passed, 49 total
marxan-test-unit-api | Snapshots:   1 failed, 12 passed, 13 total
marxan-test-unit-api | Time:        16.367 s
marxan-test-unit-api | error Command failed with exit code 1.
marxan-test-unit-api | info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
marxan-test-unit-api exited with code 1
Aborting on container exit...
ERROR: 1
make[1]: *** [Makefile:146: test-unit-api] Error 1
# run unit tests - geoprocessing
docker-compose -f docker-compose-test-unit.yml up --abort-on-container-exit --exit-code-from geoprocessing geoprocessing
Building with native build. Learn about native build in Compose here: https://docs.docker.com/go/compose-native-build/
WARNING: Found orphan containers (marxan-test-e2e-redis, marxan-test-e2e-postgresql-api, marxan-test-e2e-postgresql-geo-api) for this project. If you removed or renamed this service in your compose file, you can run this command with the --remove-orphans flag to clean it up.
Starting marxan-test-unit-geoprocessing ... done
Attaching to marxan-test-unit-geoprocessing
marxan-test-unit-geoprocessing | Running Unit Tests
marxan-test-unit-geoprocessing | yarn run v1.22.5
marxan-test-unit-geoprocessing | $ jest --silent
marxan-test-unit-geoprocessing | PASS src/app.controller.spec.ts
marxan-test-unit-geoprocessing |
marxan-test-unit-geoprocessing | Test Suites: 1 passed, 1 total
marxan-test-unit-geoprocessing | Tests:       1 passed, 1 total
marxan-test-unit-geoprocessing | Snapshots:   0 total
marxan-test-unit-geoprocessing | Time:        1.446 s, estimated 7 s
marxan-test-unit-geoprocessing | Done in 3.83s.
marxan-test-unit-geoprocessing exited with code 0
Aborting on container exit...
make[1]: Target 'test-unit-backend' not remade because of errors.
make[1]: Leaving directory 'marxan-cloud'
make: *** [Makefile:155: run-test-unit] Error 2


1st access, and db creation

hi, i downloaded latest release and created a folder "influxui" under /var/www/html and unzipped the release zip file in there... opening http://ip/influxui gives the main interface, and says "something went wrong"... so i clicked on SETTINGS to add a test server (http://localhost:8086) and it went back to home site http://ip/#/settings, which does not exist (it should be, eventually, http://ip/influxui/#/settings i think)... so running in a subfolder is not working?
then i tried to move all to www root folder, and it worked, i selected the settings, added the server, and it said "no database found"... so, creating a database is not available as option, this ui is only to manage existing db?
thanks

I could not get anywhere either on a Raspberry Pi with NGINX and Buster. I'm sure somewhere it will say how to point to my working influx setup but I cant see it.

to add the server, you need to click the top right link "settings", then i just put in: http://localhost:8086 and gave it a name, but this will ONLY work if the zip file is unzipped in the main folder of the http server you use...
beware @scargill if you do that, it will overwrite your index.html file... better renaming yours to index.php, it will work anyway even if no php code is in there, but pure html

Same issue here.
As far as I can see the query button is not working properly.
Once you added the server, it appears that nothing works.
If you delete the last part of the url (e.g. the #/settings/ part) than it works as expected. The funky thing is that once you did so and you queried the server, afterwards it does work and you can properly flip back and forth

Bump, the latest release still has the same issue when trying to go to settings page.


fix: allow setting the mailer service headers as strings (#1861)

What kind of change does this PR introduce?

Request made to email validation service should be a POST
Update error message when config validation fails

What kind of change does this PR introduce?
Bug fix, feature, docs update, ...
What is the current behavior?
Please link any relevant issues here.
What is the new behavior?
Feel free to include screenshots if it includes visual changes.
Additional context
Add any other context or screenshots.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>6
Details

2 of 4 (50.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.004%) to 57.264%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

internal/conf/configuration.go
0
1
0.0%

internal/mailer/validate.go
2
3
66.67%

Totals

Change from base Build<PHONE_NUMBER>1:
-0.004%

Covered Lines:
9696

Relevant Lines:
16932

💛  - Coveralls


Use last source

This field should be cleared if the user closes an entry and opens a new entry.

should work now


1.3 enhancement

Coverage increased (+0.08%) to 91.263% when pulling 513fe20e4b9f3d49c25777f4e8cd6d4bdb46ce29 on ZhangH795:1.3_Enhancement into f325c00d10b186f0ff9b8fad5c4f2cfd18ce188e on CS2103AUG2017-W09-B3:master.

Coverage increased (+0.08%) to 91.263% when pulling<PHONE_NUMBER>4fc542dfbcf61ebd970d3e00405dc2 on ZhangH795:1.3_Enhancement into f325c00d10b186f0ff9b8fad5c4f2cfd18ce188e on CS2103AUG2017-W09-B3:master.

Coverage decreased (-0.05%) to 91.13% when pulling 56fe63f633a34f25be3478273d02c310ed75a10e on ZhangH795:1.3_Enhancement into f325c00d10b186f0ff9b8fad5c4f2cfd18ce188e on CS2103AUG2017-W09-B3:master.

Coverage increased (+0.4%) to 91.625% when pulling fa6ac7faca20290f53dcd58003648359a95e2b49 on ZhangH795:1.3_Enhancement into f325c00d10b186f0ff9b8fad5c4f2cfd18ce188e on CS2103AUG2017-W09-B3:master.

Coverage increased (+0.4%) to 91.625% when pulling 2e8a7e7379452acff901ea2b1d6a9c199d32ec78 on ZhangH795:1.3_Enhancement into f325c00d10b186f0ff9b8fad5c4f2cfd18ce188e on CS2103AUG2017-W09-B3:master.


Add an autocorrect flag to CupertinoSearchTextField

Use case
When searching content with scientific/technical/uncommon terms, the provided autocorrection suggestions are often unhelpful or wrong, leading to a bad UX.
This is also the case when searching content which is in a different language than the keyboard/OS.
Proposal
Add an autocorrect bool for CupertinoSearchTextField (like CupertinoTextField has it).
Alternatively, it may be worth considering fully exposing the underlying TextField widget by providing an optional textField constructor argument, to which then the appropriate styles would be applied.
This would allow to fully customize the text field behaviour, and resolve issues like #79159

PRs are totally welcome.  It looks like CupertinoSearchTextField only builds a CupertinoTextField, so I'm not clear on how option 2 would work.  I'm not super familiar with CupertinoSearchTextField though.  Option 1 is simple enough if option 2 is not possible.
CC @DanielEdrisian who I think wrote CupertinoSearchTextField.


Capacitor V5 Android incompatibility

This package is causing errors when upgrading to capacitor V5. https://capacitorjs.com/docs/updating/plugins/5-0

Yes indeed it is; For me it worked to still enable Jetifier in the gradle.properties:
android.enableJetifier=true
but this is just a workaround; this library needs to be updated

Been fixed in latest :)


Basic fix validate-connection.ts

I think it can help in some situations, but it wouldn't be something so desperate, I'm just contributing to the library.

Sorry for the duplication. I ended up deleting the new repository instead of the oldest one I had and ended up closing the previous pull request.

I think it can help in some situations, but it wouldn't be something so desperate, I'm just contributing to the library.

why did you change these things?

The code indentation was removed in this PR and a default empty value was added.
I also didn't understand what benefits this PR resolves.


Set env vars for service instead of machine

Description:
On Windows move the environment variables to the service scope. This servers two purposes:

Avoid issues with Splunk instrumentations that use some of the same environment variables as the collector and could end up sending data straight to the backend instead of the sending locally to the collector.
Reduce the scope of visibility of the access token, which should only be visible to the collector

Thanks @pellared for noticing this issue.
Link to Splunk idea:
N/A
Testing:
Local tests and CI.
Documentation:
Updating CHANGELOG.md
cc @RassK @theletterf

Returning to draft until I can look at the test failure.

The msi itself also needs to be updated: https://github.com/signalfx/splunk-otel-collector/blob/main/internal/buildscripts/packaging/msi/splunk-otel-collector.wxs#L42

And we'll have to update our ansible, chef, and puppet modules since they currently only configure HKLM:\SYSTEM\CurrentControlSet\Control\Session Manager\Environment.


Adds support for '--name=true/false' flags.

Required for the dev_appserver automatic_restart flag, which is set to true by default. Setting this flag explicitly to false is required.
Helps in https://github.com/GoogleCloudPlatform/google-cloud-intellij/issues/972

FYI we had an offline discussion where we established that the existing behavior exists because AppCfg only supports existence/omission boolean flag types. We've agreed that we should change the dev appserver flags parser to pass through 'false' flags.  We also decided not to set defaults in the libraries since they are big 'B' and passing null will do the right thing.
These are the affected flags:
smtp_allow_tls
enable_task_running
automatic_restart
We only set automatic_restart in IJ, Eclipse team should review the user of these flags, and I'll also check the Gradle plugin.  Maven leaves unset values as null so is not affected.

Eclipse doesn't set automatic_restart, so we are good. (Seems like the core library doesn't have APIs to set the other two flags.)
I agree we don't have to set the default of automatic_restart in DefaultRunConfiguration, because, as before, the last commit ensures that null will omit the flag entirely.

@patflynn @meltsufin @elharo @chanseokoh PTAL

@meltsufin want to go over this just once more? Didn't need to move any unit tests in the end, since there were none to Args directly.

...or @patflynn ?

@joaoandremartins
looks like you need the lgtm from @elharo

@elharo and I discussed and I think we're on the same page regarding Boolean vs boolean.
The review I'm requesting is regarding the last commit where I extracted the bool generation logic from Args to the other *Args classes.


Share errors counter across components

All errors can now be found from metric "errors_total"
Use error name and exporter as labels

/lgtm

/approve
thx


update money version

Accepted by smnguyen!

Actually I think we might run into the same errors as my PR to upgrade money-rails altogether.
These two things in the changelog for money look like the errors I saw:

Money#== will now raise error for non-zero numeric values
Changed Money#<=> to return nil if the comparison is inappropriate. (#584)

I'm going to try running some of those tests locally with this upgrade

@Karlotcha Running bundle install fails actually, so I think we'll need to do a bit more to upgrade 😭

I pointed my local ZP to use this branch of money-rails and tried running some of the tests that failed when I upgraded money-rails. The tests failed with the same errors, so I think we'd have to make some actual code changes in ZP to be able to upgrade money.


Cannot destructure property 'id' of 'event.state' as it is null.

When using the router with hash: true we get an error if you manually change the URL.
See this video for a demonstration:
https://user-images.githubusercontent.com/215033/123721869-c88a7a80-d8b9-11eb-8c00-d491c2632552.mp4

Thanks for the feedback! Fixed in version 0.4.7.


Use ProfileService

Use ProfileService for commander data store handling. Bye

the benefits for this would be: null

either you can choose to say bs or actually learn the benefits

We aren't going to change the data system anytime soon, until we've come up a "genius" and optimal solution to migrate existing data to the ProfileService.


Use shell=False in subprocess Function Calls

Description
This codemod sets the shell keyword argument to False in subprocess module function calls that have set it to True.
Setting shell=True will execute the provided command through the system shell which can lead to shell injection vulnerabilities.  In most cases using shell=False is sufficient and leads to much safer code.
The changes from this codemod look like this:
 import subprocess
- subprocess.run("echo 'hi'", shell=True)
+ subprocess.run("echo 'hi'", shell=False)

More reading

https://docs.python.org/3/library/subprocess.html#security-considerations
https://en.wikipedia.org/wiki/Code_injection#Shell_injection
https://stackoverflow.com/a/3172488

What is the purpose of this pull request?

[ ] Bug fix
[ ] New Feature
[ ] Documentation update
[X] Other

Before submitting the PR, please make sure you do the following

[X] Read the Contributing Guidelines.
[X] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[X] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[X] Update the corresponding documentation if needed.
[X] Ideally, include relevant tests that fail without this PR but pass with it.

@01Joseph-Hwang10 I believe a bad merge has occurred. I believe it may be easier to just delete fork and rescan, will try this again. Apologies for the confusion.


(3.2.7) unreliable resume after breakpoint encountered

after a resume of a breakpoint ... the process does not finish and no further breakpoints encountered ... A failing tests with a breakpoint set and continued does not fail ... process just disappears ...
When I bring up the process browser there are no extra processes hanging around ,,, when the debugger is up, the 'browse processes' menu is greyed out ...
I CAN step over in a higher-frame, but if I resume at that point the process disappears ... if I run without breakpoints I get a test failure ...
Since I am running in a later version of 3.7.0 than you are developing in, it is possible that I am encountering server bugs ... the debugger and process behavior has changed in 3.7.0 so we should review the calls ...

Okay ... topaz is behaving as expected with respect to continuing after a breakpoint ... and it shouldn't take too long to update the debugger for 3.7 ... some things have paged into my brain and I can guess what might be going on ...

There's a lot that could be going on here but in my simple testing with Jadeite 3.2.9, resume seems to work ok.
The gci all being made in Dolphin to continue is:
self
			gciNbContinueWith: gsProcessOop
			_: anOop
			_: 1 "GCI_PERFORM_FLAG_ENABLE_DEBUG"
			_: nil.

Offhand, I don't know whether that is still correct in the 3.7 world ... we made a number of changes to the debugger api and I will have to research this one to figure out if it is correct or not ... perhaps assign this bug to me and ping me if you grow impatient waiting for an answer or if you are blocked on this issue (other than for this bug :)... since I've got other work that I am trying to get done today ...

This is open for @dalehenrich to have time to confirm it reproduces in recent versions and needs attention.  Presumably not a high priority.


Build and test with Java 17

Draft PR to start building and testing with Java 17
Latest builds

java - core - ci: https://dev.azure.com/azure-sdk/public/_build/results?buildId=1322669&view=results

Test failure: [ERROR] Test mechanism :: Unable to make protected native java.lang.Object java.lang.Object.clone() throws java.lang.CloneNotSupportedException accessible: module java.base does not "opens java.lang" to unnamed module

java - storage - ci: TBD

Issues - Open

JavaDoc fails

Workaround: Disable JavaDoc for now

Issues - Closed

JDK 17 missing from Azure Pipelines Ubuntu images

Issues

https://github.com/actions/virtual-environments/issues/4085
https://github.com/adoptium/installer/issues/330

Workaround: Manually install JDK 17
Pipeline to detect when JDK 17 is available: https://dev.azure.com/azure-sdk/playground/_build?definitionId=3068

Storage tests fail to compile

Issue: https://github.com/Azure/azure-sdk-for-java/issues/6551

SpotBugs error "java.lang.IllegalArgumentException: Unsupported class file major version 61"

Issue: https://github.com/Azure/azure-sdk-for-java/pull/24398

Mockito cannot mock this class: interface com.azure.core.amqp.ClaimsBasedSecurityNode

Issue: https://github.com/Azure/azure-sdk-for-java/pull/24398

/azp where

/azp run java - core - ci

/azp run java - storage - ci

/azp run java - core - ci

To fix the SpotBugs issue, we need to update the following lines in /eng/versioning/external_dependencies.txt:
com.github.spotbugs:spotbugs;4.4.1
com.github.spotbugs:spotbugs-annotations;4.4.1
com.github.spotbugs:spotbugs-maven-plugin;4.4.1

To fix the Mockito issue, we need to update the following lines in /eng/versioning/external_dependencies.txt:
org.powermock:powermock-api-mockito2;2.0.9
org.powermock:powermock-module-junit4;2.0.9

org.mockito:mockito-core;3.12.4
org.mockito:mockito-inline;3.12.4

I am investigating the JavaDoc issue currently. It relates to our codesnippet doclet so my work is taking place in a separate repository.

/azp run java - storage - ci

/azp run java - storage - ci

@kasobol-msft: Manual run: https://dev.azure.com/azure-sdk/public/_build/results?buildId=1124806&view=results

/azp run java - core - ci

/azp run java - storage - ci

Closing in favor of https://github.com/Azure/azure-sdk-for-java/pull/26482


Fix context discovery

Hi,
I found the bash completion script didn't correctly identify the available contexts.
Here's the contexts defined in my ~/.kube/config
▶ kubectl config get-contexts
CURRENT   NAME                  CLUSTER         AUTHINFO          NAMESPACE
          kafka                 k8s-test        admin-test        kafka-cluster
          minikube              minikube        minikube
          k8s-blue-1-admin      k8s-blue-1      admin-blue-1      default
          k8s-bowmank-admin     k8s-bowmank     admin-bowmank     default
          k8s-test-admin        k8s-test        admin-test        default
*         k8s-westcotts-admin   k8s-westcotts   admin-westcotts   default

Contexts reported by kubectx 0.2,
▶ kubectl config get-contexts | awk '{print $2}' | tail -n +2
k8s-blue-1
k8s-bowmank
k8s-test
k8s-westcotts-admin
k8s-test
minikube

After this patch,
▶ kubectl config get-contexts --output='name'
k8s-test-admin
k8s-westcotts-admin
kafka
minikube
k8s-blue-1-admin
k8s-bowmank-admin

I think I forgot the awk|tail hack there accidentally. While I am currently using:
  kubectl config view -o=jsonpath='{range .contexts[*].name}{@}{"\n"}{end}'

in other places yours (kubectl config get-contexts --output=name) certainly looks the same.
Can you unify these all with yours? (I appreciate if you take a look at whether there's any difference in using jsonpath or column name directly here) If you don't have time, I can add more commits to your branch as well.

@ahmetb I get the same output with both,
▶ kubectl config view -o=jsonpath='{range .contexts[*].name}{@}{"\n"}{end}' | sort
k8s-blue-1-admin
k8s-bowmank-admin
k8s-test-admin
k8s-westcotts-admin
kafka
minikube

▶ kubectl config get-contexts --output=name | sort
k8s-blue-1-admin
k8s-bowmank-admin
k8s-test-admin
k8s-westcotts-admin
kafka
minikube

PR updated


Github integration

[x] Github oauth app
[x] WOF editor oauth login
[x] PR making

The deployed app will now determine the GitHub repo to use based on the wof:repo_name property or build the repo name based on wof:placetype and wof:country.
Once it finds a repo name, it will try to make a branch in that repo. If it can't make a branch in that repo because you aren't a contributor, it will create a fork and create the branch there.
Once the branch is created, it will update the file on that branch with a single commit.
Once the commit is made to that branch, it will open a pull request that merges the branch into master on the WOF repo.
Assuming all that is successful, it will redirect the user to that created pull request after clicking the "Propose changes" button on the WOF editor.

Propose changes, nice :)

I added a new button that lets you export the changes without making a PR and some help text below the buttons:

Both of these work for me now, huzzah!
(I'll followup with minor problems in new issues.)


Do you have a time frame for Rest Kit 2.0?

Interested in using it for a project, and not sure if I should start now or wait until 2.0?
Thanks in advance!

Interested in using it for a project, and not sure if I should start now or wait until 2.0?
Thanks in advance!

Hi,
2.0 is almost ready, just requires some brush up and docs update. I think it's a matter of a week or two.

Boom! 2.0 is out. Closing the issue


More JSystem borrowing

Are the inlines that you added part of debug? I know some of the repositories have some inlines that aren't actually there.

Some do. Haven't verified all of them.
On Sat, Jul 22, 2023, 19:36 jdflyer @.***> wrote:

Are the inlines that you added part of debug? I know some of the
repositories have some inlines that aren't actually there.
—
Reply to this email directly, view it on GitHub
https://github.com/zeldaret/tp/pull/383#issuecomment-1646625936, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ACYQXXNB4A6VBRF2TJBROZLXRP6QDANCNFSM6AAAAAA2T4ID7U
.
You are receiving this because you authored the thread.Message ID:
@.***>