R7B3

ICON External Parameter Request
Instructions

Give this issue a meaningful title.
Replace PASTE_YOUR_REQUEST_HERE with your request that you copied to clipboard:

{
  "extpar": {
      "igrid_type": 1,
      "iaot_type": 1,
      "ilu_type": 1,
      "ialb_type": 1,
      "isoil_type": 1,
      "itopo_type": 1,
      "lsgsl": false,
      "lfilter_oro": false,
      "lurban": false
  },
  "icontools": {
    "grid_level": 2,
    "grid_root": 7,
    "centre": 78,
    "subcentre": 255,
    "lspring_dynamics": true,
    "maxit": 1000,
    "beta_spring": 0.95,
    "icorotation": 36,
    "outfile": "ICON-Arctic",
    "domains": [
      {
        "region_type": 2,
        "center_lon": 0.0,
        "center_lat": 90.0,
        "hwidth_lon": 23.0,
        "hwidth_lat": 15.0,
        "lrotate": false
      }
    ]
  }
}

Click on "Preview" to verify that the JSON format of your request is correctly formatted and displayed within a code block.
Click on "Submit new issue".

Extpar Data Request will now process your data based on the request you provided here. Once the processing is successful, it will post a link in this issue.
The processed data will be available under that link for up to 7 days.
If you encounter any problems, please add the label  to the issue. Make sure you post all relevant information from the logfiles in the issue directly.
Status Labels
Labels reflect the current state of your request:
 - Your request is currently under processing. Please wait for further updates.
 - Your request has been successfully processed. You can download your data using the provided link.
 - Unfortunately, your request could not be processed. Please refer to the log files in the zip file at the download link for more details.
 - Your request was aborted. This might be due to a timeout. Please try again or contact support if the problem persists.

Something went wrong. Please check the logfiles for more information.

@jonasjucker The logfile is empty. Could it be related to the circular region (region_type=2)?

gridgen failed:
 Simple icosahedral grid generator

 ---------------------------------

 05/2016 : F. Prill, DWD

 running with 32 thread(s).

 1 domain(s) specified.

 DOM 0:   grid R07B02 approx. resolution  180357.14m (created from scratch)

 DOM 1:   circular region (center lon/lat:   0.000,  0.000; radius:   0.000 deg)

 ----------------

 CREATE BASE GRID

 ----------------

 generate synthetic global base grid R07B02

 base grid R07B01: perform spring dynamics.

   it =    100; ekin =  0.21901E-02; max_ekin =  0.47758E-02

   it =    200; ekin =  0.71389E-04; max_ekin =  0.47758E-02

   it =    300; ekin =  0.13687E-04; max_ekin =  0.47758E-02

   it =    400; ekin =  0.52682E-05; max_ekin =  0.47758E-02

   iterated 413 times.

 base grid R07B02: perform spring dynamics.

   it =    100; ekin =  0.92745E-04; max_ekin =  0.53505E-03

   it =    200; ekin =  0.16217E-05; max_ekin =  0.53505E-03

   it =    300; ekin =  0.79329E-06; max_ekin =  0.53505E-03

   it =    400; ekin =  0.66779E-06; max_ekin =  0.53505E-03

   it =    500; ekin =  0.57407E-06; max_ekin =  0.53505E-03

   iterated 549 times.

 generate UUID for synthetic grid...  "2623e1a8-bf9b-7c46-53ae-1fa5fae92500"

 saving patch to NetCDF file "base_grid.nc"

   ncells = 15680; nedges = 23520; nverts = 7842

 write HTML plot "base_grid.html"

   *** no HTML output written: this is a global grid containing too many cells!

 -------

 DOM  1:   circular region (center lon/lat:   0.000,  0.000; radius:   0.000 deg)

 -------

 build refined patch...

   marked 0 cells for refinement.

  *** No further domains can be processed!

    domains which have been processed so far:  mo_icongridgen::gridgen_main: Circular dependency?

STOP 99

Could it be because the parameter  is set toparent_id=0,1?

Ok good to know.
I will convert this into an issue to keep it in mind for later.


Add check if bun exists and for bun version in PKGBUILD

Maybe needs bunconfig.toml? If exists but is out of date in pkgbuild, maybe run bun upgrade

Closed by https://aur.archlinux.org/cgit/aur.git/commit/?h=ollamamodelupdater&id=554439bb28963503d6404a8d73caf6bfe75eae73 . I wish the AUR package for bun actually worked... :woozy_face:


Zoom not working in bar chart.

You can check this codepen where I can see download toolbar option but not the zoom options.
Kindly check the codepen below
https://codepen.io/anon/pen/pGBbeg

Zoom is not supported in horizontal bar charts as of now.

Any future updates regarding this?


FFT integer is required

Thank you for using and contributing to CuPy!
If your issue is a request for support in using CuPy, please post it on Stack Overflow or Google Groups (en / ja).
Developer team members are monitoring questions on these channels.
If it is a bug report, please include the following information:

Conditions (you can just paste the output of python -c 'import cupy; cupy.show_config()')

CuPy version
OS/Platform Windows 64-bit
CUDA version
cuDNN/NCCL version (if applicable)

In [1]: import cupy
In [2]: cupy.show_config()
CuPy Version          : 5.4.0
CUDA Root             : C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v10.0
CUDA Build Version    : 10000
CUDA Driver Version   : 10010
CUDA Runtime Version  : 10000
cuDNN Build Version   : 7500
cuDNN Version         : 7500
NCCL Build Version    : None
NCCL Runtime Version  : None

Code to reproduce

cupy.fft.fft(np.random.randn(1024))

Error messages, stack traces, or logs

In [3]: import numpy as np

In [4]: cupy.fft.fft(np.random.randn(1024))
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-4-64dc78ec7d65> in <module>
----> 1 cupy.fft.fft(np.random.randn(1024))

c:\users\duke\appdata\local\programs\python\python37\lib\site-packages\cupy\fft\fft.py in fft(a, n, axis, norm)
    153     .. seealso:: :func:`numpy.fft.fft`
    154     """
--> 155     return _fft(a, (n,), (axis,), norm, cupy.cuda.cufft.CUFFT_FORWARD)
    156
    157

c:\users\duke\appdata\local\programs\python\python37\lib\site-packages\cupy\fft\fft.py in _fft(a, s, axes, norm, direction, value_type)
    120
    121     if value_type == 'C2C':
--> 122         a = _fft_c2c(a, direction, norm, axes)
    123     elif value_type == 'R2C':
    124         a = _exec_fft(a, direction, value_type, norm, axes[-1])

c:\users\duke\appdata\local\programs\python\python37\lib\site-packages\cupy\fft\fft.py in _fft_c2c(a, direction, norm, axes)
     92 def _fft_c2c(a, direction, norm, axes):
     93     for axis in axes:
---> 94         a = _exec_fft(a, direction, 'C2C', norm, axis)
     95     return a
     96

c:\users\duke\appdata\local\programs\python\python37\lib\site-packages\cupy\fft\fft.py in _exec_fft(a, direction, value_type, norm, axis, out_size)
     73                         fft_type, a.size // a.shape[-1])
     74     out = plan.get_output_array(a)
---> 75     plan.fft(a, out, direction)
     76
     77     sz = out.shape[-1]

cupy\cuda\cufft.pyx in cupy.cuda.cufft.Plan1d.fft()

TypeError: an integer is required

I also broke a debugger at the plan.fft(a, out, direction) call, and verified the types are cupy arrays for a & out, and a -1 for direction <type 'int'>

verified the types are cupy arrays for a

Are you sure about this? It doesn't look like a would be a CuPy array based on your code above.
If you change from:
cupy.fft.fft(np.random.randn(1024))  # Numpy input (Not supported!)

to
cupy.fft.fft(cupy.random.randn(1024))

it should work. There is no implicit conversion of numpy arrays to cupy arrays within cupy.fft.fft.
I agree that the displayed TypeError is not the most intuitive, though (it is due to differences in the type of the data attribute of Cupy vs. NumPy arrays). I suppose the fft call of the plan object could check that the input is a CuPy array and raise a more informative error if it is not.

Ah I see. Sorry for the noise, I was short on sleep when trying this.  In hindsight I should have rtfm.  Thanks for the kind reply!


Fix #27 NoDataError in parse_influenza_blast_results.py

This bugfix patch PR fixes #27 by catching NoDataError when trying to parse empty BLAST results files in parse_influenza_blast_results.py
PR checklist

[X] This comment contains a description of changes (with reason).
[X] If you've fixed a bug or added code that should be tested, add tests!
[ ] Ensure the test suite passes (nextflow run . -profile test_{illumina,nanopore},docker).
[X] CHANGELOG.md is updated.

@peterk87 Look good to me and testing also passed at my end


Add SKR

@krittamark First stage of verification passed, official domain is skr.ac.th as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@krittamark Pull request merged. Thank you!


Points leaderboard based on percentage

display day to day points leaderboard as a percentage of theoretical max points
even if your leaderboard position does not change, you can see if you are making a progress in your path to the competitor
displays also days without member point change, as the percentage changes anyway
switchable with old cumulative points leaderboard (it stays as default)

I've also added JSDoc comments describing the input data as it greatly helped with the first contribution (no data: any)

Interesting suggestion! I don't have immediate time to review it, but the idea seems solid to me. Thanks for contributing!
Happy puzzling!

By the way, you might be interested in this other plugin by @amochtar, which I believe gives you more or less the same graph (just more discrete with "leaderboard position" instead of cumulative points, but I think that actually looks quite nice). I've been using that plugin next to my own and they complement each other nicely IMHO.

Yes, I'm aware of that plugin and I'm using it too. It has been first place where I would have wanted to do this 'small' modification. But to display the distances you need a graph, not a table. Thus, your plugin has seemed like a better starting point.

I've tried to build on the change in PR and display the potential - what are maximum points reachable for each player if he finishes the remaining stars just now. I'm not really satisfied with the result, both the many lines and the second legend line for almost every player (only 3 players have finished all stars and thus does not need to display the potential) looks really messy.

On the other side, it has a great value - you can easily see (after you make sense to the graph :)) that the third player will be probably knocked down by fourth one, once he finishes all remaining stars, but he is safe from the fifth one.
Any thoughts on this?

Well, it looks very interesting at the least! But I agree it does seem a bit cluttered.
For the current moment I have a slightly different problem: I'm pretty burnt out on December and the projects around AoC for 2021, and I still really want to finish the final few days of puzzles spoiler-free myself in the upcoming time. So I'll likely let this and other PRs and issues sit until about November 2022, just before the next edition. I appreciate all the suggestions and input and will do my utmost best to look at all of them for the next AoC edition, promised!
Hope that sounds reasonable :)

Well, I do not mind longer pause, but since the "potential" feature is far from finished, I'd like to put some more work into it - and restarting it in november seems like there will be 'release' already knocking on the door. Could it be 'summer'? :)
Good luck and clear mind with the puzzles!

I apologize @svatal: my intention truly was to look at this in November already, but life happened this fall, so no big updates to the repo or extensions this year I'm afraid. I do appreciate the submission though and hope to get to it after this AoC'22 at some point. Hope you understand!

Hello @jeroenheijmans, it is fine - I hope I'll be able to run my local build again.
Life is much more important than any coding event and I wish you luck in sorting things out.

I've added the 'potential' as another view to cycle. So it is (header click to change) - cumulative points (the original) -> percentage points -> percentage points with potential -> back to cumulative points. This should solve the issue with too much info in one graph - everyone can pick the one that suits him/her.
So no open issues with this PR from my side .. :)

I've just found the time to check this out, and it's absolutely lovely!
I will be merging this locally into my #79 (2023 updates) branch, because I'll need to juggle some conflicts with other PR's that I've also accepted. But I'll make sure your line of commits gets in there, and it should land in the next edition.
I am planning to tweak a few things on top of your work, including:

A bit less wordy title and a bit more discoverability of the click-on-title thing (using pointer styles and whatnot);
Fixing some minor bugs with persisting the settings for users that have not seen this feature yet
And a couple of tweaks on line styles (some of em clash with other work)

Thanks again so much! 🙏🏻  And expect to see your features in the released addon in the future.

Thank you very much!
But I'd like you to reconsider removing the JSDocs. As you can see, it has been my first commit - I wouldn't be able to even start without knowing what the data consist of. They add an enormous value (well, maybe I'm a little biased since I'm used to writing typescript everyday ;)). There does not need to be much declarations - basicaly just the input JSON. The IStar and IMember (and some in-function typings) could probably be replaced with some restructuralization of the code like not mutating IMemberJson but creating a new object (lines 143-180) or constructs like Math.max(..array) instead of Math.max.apply(Math, array.
My intent in that phase has been exploring the data, not refactorings that would make it more readable for TS language service but may break something I don't yet understand.
I can try out the proposed changes, but it would complicate the merging ...

Ha, no @svatal: thank you very much! 😄
First things first: take care not to add commits to this PR anymore 😅, I've already merged your work into the branch for 2023 updates 🎉 and manually made further changes, and solved tons of conflicts with PRs from others. If you'd add more commits to this PR we'll likely run into nasty merge conflicts. (I welcome further help!! But just want to avoid those git conflicts for both of us.)
Second, I understand your plea for JSDocs. However, I want to keep that discussion separate (and merge this PR separately from JSDocs, if any). I've opened #82 and will give it some more thought.

As notifications may've told you, this PR is now merged into the mainline! Further PR's should probably branch off that, and the JSDocs thing has its own open issue for now. Thanks again for your contribution!


PoC : Tracks management

Goals
Understand that the DefaultTrackSelector  can or can't do without modifications.
Tasks

[ ] Displays audio tracks selections.
[ ] Displays video tracks selections.
[ ] Displays subtitles selections.
[ ] Handle accessibility settings.
[ ] Handle forced subtitles.

Forced subtitles
Forced subtitles have to be selected when user doesn't want subtitles. The selected forced subtitle language have to match the selected audio language.
Problems

DefaultTrackSelector apply track override at the very end of the selection process.
If the user disable the text track with TrackSelectionParameters.setTrackTypeDisabled it would deselect all text track, even forced one.

## Default subtitles
If the playlist have marked a text track with selection flag = auto or/and default. It will automatically selected the default one. Even if the user changes audio language preferences. To change the selected subtitles, you have to override the selection or to set text rack preferred language.
Accessibility
TrackSelector reads the current state of the accessibility settings for subtitles. It will setup the preferred role and preferred language for text tracks.

Implemented.


InvalidArgumentError in 2D GP with Coregionalization

I'm trying to fit a set of coregionalized 2-dimensional GPs with verison 1.3.0, but am running into an input error (apparently) that I cannot diagnose. My X inputs have 2 columns (x and y coordinates) plus a coregion index column (currently trying to fit 3 components to test things):
>>> X[:5]

array([[-0.255,  1.666,  1.   ],
       [-0.488,  1.251,  1.   ],
       [-0.573,  0.749,  1.   ],
       [-1.041,  2.127,  1.   ],
       [-0.535,  1.327,  1.   ]])

and my y response is univariate (plus the coregion column as well). Z is a grid of values chosen using k-nearest-neighbor. Based on the existing examples, the model is:
k1 = gf.kernels.Matern32(input_dim=2, active_dims=[0, 1], lengthscales=0.1)
coreg = gf.kernels.Coregion(input_dim=1, output_dim=3, rank=2, active_dims=[2])
k = k1*coreg

lik = gf.likelihoods.SwitchedLikelihood([gf.likelihoods.StudentT(), gf.likelihoods.StudentT(),
                                     gf.likelihoods.StudentT()])

mu = gf.mean_functions.Constant(y.max())
m = gf.models.SVGP(X, y, kern=k, likelihood=lik, mean_function=mu, num_latent=1, Z=Z)

opt = gf.train.ScipyOptimizer()
opt.minimize(m)

However, I'm getting the following:
InvalidArgumentError: indices[0] = 2 is not in [0, 2)
	 [[node SVGP-0016d7ab-321/conditional/GatherV2_6 (defined at /home/fonnesbeck_gmail_com/anaconda3/envs/dev/lib/python3.7/site-packages/gpflow/kernels.py:129) ]]

I assume this has to do with the active_dims on the Coregion kernel, but I don't see what I've done wrong if this is the case.

Can anyone confirm whether its possible to build a coregionalized model with 2D inputs? I've not been able to get any model running (even trying to generalize from the example notebook) without triggering an error like the one above.

@fonnesbeck did you solve the problem? How?

@fonnesbeck did you manage to solve the issue? I have the same problem, but my kernel has the right active dims.

@fonnesbeck Could you please share more detail on how did you solved it?

This was 2 years ago, so I don't recall how it was solved, and I ended up using a different approach altogether for my analysis. Sorry I can't be more helpful.


feat(Crypto_Org_Chain): Add Crypto.Org Chain Normal Transfer

Add Crypto.org Chain Normal Transfer
Update Coin-tester
Change package names:
Cronos -> coin-cronos
Crypto.org Chain -> coin-cro

Task linked: CW-3641 Implement coin-cro to support normal transfer


Unable to include OpenGL headers in a cc_library on Mac OS X

I am trying to include <OpenGL/OpenGL.h> in a sample cc_library on Mac OS X (10.10.3) but when doing so I am getting missing dependency declarations for OpenGL headers.
Build rule:
cc_library(
    name = "hello-lib",
    srcs = ["hello-lib.cc"],
    hdrs = ["hello-lib.h",],
    linkopts = ["-framework OpenGL"],
)

Program:
#ifndef EXAMPLES_CPP_HELLO_LIB_H_
#define EXAMPLES_CPP_HELLO_LIB_H_

#include <string>
#include <memory>
#include <OpenGL/gl.h>

namespace hello {

class HelloLib {
 public:
  HelloLib();

  explicit HelloLib(const std::string &greeting);

  void greet(const std::string &thing);

 private:
  std::unique_ptr<const std::string> greeting_;
};

}  // namespace hello

#endif  // EXAMPLES_CPP_HELLO_LIB_H_

Bazel output:
bazel build hello-lib
INFO: Found 1 target...
ERROR: /Users/trevorgray/src/github.com/google/bazel/examples/cpp/BUILD:3:1: undeclared inclusion(s) in rule '//examples/cpp:hello-lib':
this rule is missing dependency declarations for the following files included by 'examples/cpp/hello-lib.cc':
  '/System/Library/Frameworks/OpenGL.framework/Headers/gl.h'
  '/System/Library/Frameworks/OpenGL.framework/Headers/gltypes.h'
  '/System/Library/Frameworks/OpenGL.framework/Headers/glext.h'.
Target //examples/cpp:hello-lib failed to build
Use --verbose_failures to see the command lines of failed build steps.
INFO: Elapsed time: 0.512s, Critical Path: 0.42s

@Aragos - maybe we should add /System/Library/Frameworks into the darwin CROSSTOOL entry?

@hanwen: That sounds fine to me but I honestly have no knowledge of c++ compilation on Macs so I'm probably the wrong person to ask. :)

@trevorgray - there is a list of accepted include dirs here:
https://github.com/google/bazel/blob/master/tools/cpp/CROSSTOOL#L78
you could try adding an entry for /System/Library/Frameworks/

We're still discussing how to best pull in dependencies from the local machine; keep in mind that you also need to distinguish between different platforms, and possible different locations on identical platforms (for example: you may have a custom compiled libz on your machine which you want to use, where the headers are in /opt/usr/include, rather than in /usr/include).
For now, changing your CROSSTOOL is the easiest workaround, but keep in mind that bazel will not trigger on changes to those files; it assumes that files are immutable.

Trevor, can you try the suggestion and report back? Thanks!

The proposed fix of adding "/System/Library/Frameworks" to CROSSTOOL works.

Thanks, we'll update the CROSSTOOL then.


test(tooltip): tooltip screenshot test

Updated Tooltip Storybook tests to have a Chromatic-specific test that iterates through all relevant visual variables.
#461
Summary
Structural Element (Base, Gene, DNA, Chromosome or Cell)
Github issue: #461
Permutation dimensions to include

[x] sdsStyle: dark, light
[x] subtitle: "sample text", undefined
[x] arrow: true, false
[x] arrowOffset: [any number between 120 and -120; I will use the following increments to test with : 120, 60, 0, -60, -120]
[x] width: default, wide

Exceptions, notes

[x] sdsType=light Tooltips cannot have subtitle=true
[x] sdsType=dark Tooltips cannot have width=wide
[x] arrowOffset can only apply to arrow=true
Since the tooltip itself is not hoverable, but only appears on hover of another element, the Chromatic test should force that element to always be in hover state in order to show Tooltip

Here's what the new Screenshot Test story looks like:

Checklist

[x] Default Story in Storybook
[x] LivePreview Story in Storybook
[x] Test Story in Storybook
[x] Tests written
[ ] Variables from defaultTheme.ts used wherever possible // liaprins: uncertain...
[ ] If updating an existing component, depreciate flag has been used where necessary // liaprins: N/A
[ ] Chromatic build verified by @chanzuckerberg/sds-design // liaprins: TBD, since this updates the Chromatic build by definition...

I just noticed that in the Chromatic screenshot the Tooltips are in some cases rendering so they have a placement above the parent component (info icon) which means they cover the labels describing which combination of visual variables they represent (especially for the dark-type Tooltips). I think I could try to fix this by assigning them all placement="bottom" like they are rendering by default on my screen, if this matters!


Relaxed Python versions

Codecov Report

Merging #33 (f768df5) into main (604c8a9) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #33   +/-   ##
=======================================
  Coverage   99.32%   99.32%
=======================================
  Files          17       17
  Lines        1186     1186
=======================================
  Hits         1178     1178
  Misses          8        8

Impacted Files
Coverage Δ

src/cofi/_version.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b77dd40...f768df5. Read the comment docs.


Feature request: Multi-gpu conversion

Firstly, thank you for all your amazing work!
For those of us with multiple smaller VRAM cards (eg. 2x 3080s), conversion often gets OOM.
Multi-gpu support for conversion would be amazing in solving this.

It's tough since some of the operations really do just require a large amount of VRAM. I'm not sure where anything could be subdivided any further, and the script already swaps data to system RAM whenever it can.

could the conversion be parallelized into a layer per gpu?
i have five 3090s and 256gb of cpu ram.

Sadly no, the layers have to be processed in order, and a lot of the time is spent just swapping data to system RAM since the calibration state is so large. I've done some experiments trying to split up the process across multiple GPUs but there's only so much splitting you can do due to the nature of the algorithm, and even where you can split (e.g. assigning the Q, K and V matrices to separate GPUs since they are parallel in the model) it's hard to overcome the overhead of moving data between devices. Especially with how weak sauce multithreading is in Python.

how about being able to convert multiple models at once? e.g. tell one instance of convert.py to only use gpu 0, and another instance of convert.py to only use gpu 1?

You can always do CUDA_VISIBLE_DEVICES=0 python convert.py ... and then  CUDA_VISIBLE_DEVICES=1 python convert.py ... in another shell, and so on. That works fine.

You can always do CUDA_VISIBLE_DEVICES=0 python convert.py ... and then CUDA_VISIBLE_DEVICES=1 python convert.py ... in another shell, and so on. That works fine.

This is what I do and it works great. Thanks for all your work on this project, @turboderp!


Search field not visible in Response, Body, Scripts and Tests

I have checked the following:

[X] I use the newest version of bruno.
[X] I've searched existing issues and found nothing related to my issue.

Describe the bug
Steps:
I'm using Bruno v1.34.0 on a MacBook Pro with M1 Pro.
Run a GET request
Click in the Response field and tap command+F keys on your keyboard.
Actual result:
There is no search field visible. Only the top border of the field is visible at the bottom.
When you start typing the value you want to search on and tap the Enter key the search does work.
Expected result:
The search field should be visible so you can correct possible spelling mistakes in case the search doesn't return any result.
Additional info:
The same occurs in Body, Script (Pre Request and Post Response) and Tests.
.bru file to reproduce the bug
No response
Screenshots/Live demo link

Hi @gdekeuster , thanks for reporting, this issue has been resolved and is available on our latest version(1.34.1)!

I downloaded version 1.34.1 and the issue is indeed fixed.
Thanks a lot for the quick fix. Keep up the good work, much appreciated.


Turn off camera on container down and use default compression

When the ros-$ROS_DISTRO-image-transport-plugins is installed every image topic has its compression counterparts.

Status: https://github.com/husarion/astra-docker/actions/runs/5555582356


Bug in needs_render_context documentation

The documentation says that needs_render_context works with functions which return a string.
(By the way it doesn't show how to do that)
But it works fine with functions returning more complex types. Is that intentional?
Here is an example:
def all_relations(needs, need) -> List[Tuple[Any, str, str]]:
    if isinstance(need, str):
        need = needs[need]

    result: List[Tuple[Any, str, str]] = []
    # currently only "uses" relation is supported.
    for id in need["uses"]:
        result.append((needs[id], "uses", "-->"))
    for id in need["uses_back"]:
        result.append((needs[id], "uses", "<--"))
    return result

needs_render_context = {
    "all_relations": all_relations,
}

And in jinja in needarch:
         {% for relation in all_relations(needs, need()) %}
            {% set other_need = relation[0] %}
            {% set text = relation[1] %}
            {% set arrow = relation[2] %}
            {{ need()['id'] }} {{ arrow }} {{ other_need['id'] }} : {{ text }}
         {% endfor %}

Hi Alexander,
it is intended and needed, so it is possible to have more complex implementations. We have to enhance the documentation here.

Thanks for the bug report :+1:
You are right, the function can return anything. There are also no checks for this.
And yes, I see no technical reason why it should not be allowed.
The user is responsible to deal with this data in the right way :)
And our example shows that there are use cases for it.


refactor browser setup

We should design a declarative config file (in JSON) that allows us to specify browser test settings for selenium webdriver. To allow multiple local, remote, or browserstack tests.

The file is called browserprivacy.config and I committed an example. Fixed in a9d36aa81959e7ae2c4b1d34232cb9c8f6f630ac


add @type/mocha in package.json

API change check
API changes are not detected in this pull request.

Thanks for the fix! Do you know why the build started failing?

I don't know, but I will add this dependency in all the package.json in this pr

I don't know, but I will add this dependency in all the package.json in this pr

@kazrael2119 we can merge this now to unblock js - core - ci pipeline, and update other packages later.

I also open a PR to revert my previous change which looks like it broke the build

@jeremymeng  should we merge this one or yours?

should we merge this one or yours?

we can merge this too as @types/mocha should be a dev dependency and not rely on other weird behaviors.  But we can fix the rest of packages later.  I will check whether codegen adds it properly.

@kazrael2119 I will fix the rest of packages and merge into main directly to avoid triggering massive number of build pipelines


willLeave called a lot of times

You can check it on TodoMVC example: http://chenglou.me/react-motion/demos/demo3-todomvc-list-transition/
When animation is running it calls willLeave a lot of times - why? Isn't it just should set the end state once?

Because it's also used as an escape hatch for those who wants to specify a willLeave configuration dynamically, e.g. through side-effects, reading into current state info, etc.
In the next version I'm thinking of exposing the option to allow you to provide an object directly (for willEnter and willLeave). Would that solve your problem?

Why willLeave called a lot of times but willEnter just call once?

We call it many times in order to know what the final destination value is. That value might change dynamically at each function call.
Consider it like react's render; it can be called many times. You shouldn't bank on how many times it's called.


Is it possible to change shape property of object after creation?

I see the documentation says the .tune function can modify any property of the shape object, but can it change the actual shape of the object?
For example, would the following work:
var shape = new mojs.Shape({
    shape:      'circle',
    fill:       'red',
    radius:     '20',
});

// after some timeout or delay
shape.tune({shape: 'rect'});

I'm trying to loop through a few different images of birds to give it the look of flapping its wings and I'm not sure if it's possible to do with mojs.

Hi @curranlipsett! Thanks for the issue!
Nope, It's not possible, the shape probably is the only property you can't change right now.

Thanks @legomushroom that makes sense to me.
I appreciate the feedback!

@curranlipsett you are welcome, we are considering to make it changeable in the future but not sure about it yet.

@legomushroom I could see the value in it, and it might be cool to see the transformation of the shapes as well. I think it is also possible to accomplish a pretty similar effect (at least in my case of trying to make it look like the bird is flapping wings) using path-easing like you have done with the mole example in the tutorial.
It seems like it would be a lot of work to get this to work in all cases, especially if custom shapes are allowed.

@curranlipsett yeah it could be tricky, not just because custom shapes but also because shapes can have deltable parameters like count or radius/radiusX/Y that already can animate shapes. So this will become animation of shape morphing + shape's parameters animation which is tricky to do simultaneously.


Support handling decoding errors

Right now the FrameDecoder typeclass seems to assume that decoding will always be successful, it would be great to have a way to raise errors in cases where it is not.

I've experimented with decode(bytes: Array[Byte]): Either[E, A] a while ago. The main concern is the throughput of the system. The performance degradation with an either-based decoder was ~15%.
I will do a few more measurements again and consider further steps.


Idea: Use case for a VersionInfoIterator?

Situation
For example, if we want to start from a certain version and get the next 3 versions we could do that:
v = VersionInfo.parse("1.2.3-rc.3")
for _ in range(3):
   print(v.next_version(part="prerelease"))

This would work, but maybe we could use the iterator protocol for that.
Proposed Solution
The solution is very rough, but that's on purpose. It's a minimal example to demonstrate the idea and not get distracted by other methods. So I know, this would need fine-tuning (add properties, protect from invalid datatypes etc.).
class VersionInfoIterator:
    """Iterator over VersionInfo objects"""
    def __init__(self, version, part, steps=10):
        self.version = version
        self.part = part
        self._steps = steps

    def __iter__(self):
        return self

    def __repr__(self):
        cls = type(self)
        return "{}(version={!r}, part={!r}, steps={})".format(cls.__name__,
                self.version, self.part, self._steps)

    def __next__(self):
        if not self.steps:
            raise StopIteration
        self._steps -= 1
        self.version = self.version.next_version(self.part)
        return self.version

An implementation could look like this:
from semver import VersionInfo, VersionInfoIterator
>>> v = VersionInfo.parse("1.2.3-rc.3")
>>> vit = VersionInfoIterator(v, "prerelease", steps=3)
>>> next(vit)
VersionInfo(major=1, minor=2, patch=3, prerelease='rc.4', build=None)
>>> next(vit)
VersionInfo(major=1, minor=2, patch=3, prerelease='rc.5', build=None)
>>> vit.part = "minor"
>>> next(vit)
VersionInfo(major=1, minor=3, patch=0, prerelease=None, build=None)
>>> next(vit)
Traceback (most recent call last)
...
StopIteration

# or

>>> vit = VersionInfoIterator(v, "prerelease", steps=3)
>>> list(vit)
[VersionInfo(major=1, minor=2, patch=3, prerelease='rc.4', build=None),
 VersionInfo(major=1, minor=2, patch=3, prerelease='rc.5', build=None),
 VersionInfo(major=1, minor=2, patch=3, prerelease='rc.6', build=None)]

Questions

Would such an iterator be useful?
Is it necessary or is first example above enough when iterating?
If you think it could be useful, would you change something in __init__?

Actually, I'm not sure myself if this is something good or completely unnecessary. I just had this idea when working on issue #222. :wink: Also I thought, it would be helpful to document it, regardless if this will be accepted or not.
@gsakkis, @scls19fr
What do you think? I would like to hear your opinion. :wink:

I kinda like the general idea and had also thought of something similar. Two comments for the specific API:

steps is unnecessary, this can (and should in my opinion) be an infinite iterator. The caller can always use itertools.islice or others to limit/filter the iterable.
Bumping to a different part than the initial one by setting an attribute is not ideal because
(a) it is a 2-step process (vit.part = "minor"; next(vit)) and
(b) it is sticky; all subsequent next calls will use the new part, although in practice I'd guess it would be more common to bump to minor/major once but continue with the original part for subsequent next versions.

Based on these I came up with a simple coroutine approach, where you can send(part) for a single next version but preserve the original:
def iter_versions(version, part, prerelease_token="rc"):
    current_part = part
    while True:
        version = next_version(version, current_part, prerelease_token)
        current_part = (yield version) or part

Usage:
import itertools as it

def test_iter_versions():
    iv = iter_versions("1.2.3-rc.3", "prerelease")
    assert list(it.islice(iv, 3)) == ["1.2.3-rc.4", "1.2.3-rc.5", "1.2.3-rc.6"]
    assert next(iv) == "1.2.3-rc.7"
    assert next(iv) == "1.2.3-rc.8"
    assert iv.send("patch") == "1.2.3"
    assert next(iv) == "1.2.4-rc.1"
    assert iv.send("minor") == "1.3.0"
    assert next(iv) == "1.3.1-rc.1"
    assert iv.send("major") == "2.0.0"
    assert next(iv) == "2.0.1-rc.1"

@gsakkis

I kinda like the general idea and had also thought of something similar.

Haha, cool! :sunglasses: :+1:

Two comments for the specific API:
* `steps` is unnecessary, this can (and should in my opinion) be an infinite iterator. The caller can always use `itertools.islice` or others to limit/filter the iterable.

Yes, I thought about that too. But if we create an infinite iterator, we always have to use itertools.islice when we want to use, let say, 4 items.

* Bumping to a different `part` than the initial one by setting an attribute is not ideal because
  (a) it is a 2-step process (`vit.part = "minor"; next(vit)`) and
  (b) it is sticky; all subsequent `next` calls will use the new part, although in practice I'd guess it would be more common to bump to minor/major once but continue with the original part for subsequent next versions.

Ahh, I see. Good idea! I like your approach, it's much better.

An alternative api is to accept a (finite or infinite) iterable of parts:
def iter_versions(version, parts, prerelease_token="rc"):
    for part in parts:
        version = next_version(version, part, prerelease_token)
        yield version

def test_iter_versions():
    parts = it.chain(
        it.repeat("prerelease", 5),
        ["patch", "prerelease", "minor", "prerelease", "major", "prerelease"],
    )
    iv = iter_versions("1.2.3-rc.3", parts)
    assert list(it.islice(iv, 3)) == ["1.2.3-rc.4", "1.2.3-rc.5", "1.2.3-rc.6"]
    assert next(iv) == "1.2.3-rc.7"
    assert list(iv) == [
        "1.2.3-rc.8",
        "1.2.3",
        "1.2.4-rc.1",
        "1.3.0",
        "1.3.1-rc.1",
        "2.0.0",
        "2.0.1-rc.1",
    ]

I like this idea.
Same here. As in the light of #229, I would suggest to move the iter_versions functions into the VersionInfo class once issue #222 is merged:
class VersionInfo:
    # ...
    def iter_versions(self, parts, prerelease_token="rc"):
        for part in parts:
            yield self.next_version(part, prerelease_token)

Hmn, I'm wondering of the parts argument. Shouldn't it be *parts?

Hmn, I'm wondering about the parts argument. Shouldn't it be *parts?

Not if we want to support arbitrary iterables without expanding them into tuples first.

@gsakkis If you don't mind, I would suggest to add this to the semver3 line.

@tomschr Sure no problem


Strip ++api++ from in-browser location changes

Solves the Volto part of #4800. We're stripping the ++api++ if it is in a location change as we probably don't want to ever navigate directly to a page with ++api++ in it in the browser. Change the action causes the redux store to be correct, but the URL updating occurs earlier in the react-router stack, and so we also manually update the URL to not have ++api++ in it. History is still preserved correctly (++api++ pages aren't in the history stack but we can still go back and forwards normally).
The logic is currently mixed in with the blacklistRoutes middleware while I get some feedback, but this logic should probably be its own middleware for readability.

GitHub bug meant I had to close this PR and re-open it in https://github.com/plone/volto/pull/4854


Wheel dist includes the tests package

This breaks my application's tests since the tests package in site-package will take precedence.
This regression appeared in 3.3 (3.2 is fine). Looks like the cause is this change: https://github.com/jazzband/django-tinymce/commit/9175803df0b41b8d6d8e84b80bdc1da404dec1ed#diff-41d5a52589e0480be9c099d2bba7a8135b8b0d71bcbb8df3582a8df1c2295003
Looks like the intended change there was to include the test in the sdist. A change to find_packages to use exclude or include is also needed.
Similar problem to https://github.com/3YOURMIND/django-migration-linter/issues/147

Hello,
Just a quick note to let you know that this issue is still there.
The 'tests' directory packaged with the application is installed in 'site-packages/tests'.
Thank you

Patch welcome :-)


character shaking when typing Chinese characters

Type: Bug
My VS Code has the vscode.neovim plugin installed, and when I type Chinese characters in insert mode, the Chinese characters in the line I'm typing shake rapidly, which is quite uncomfortable to watch. This issue only occurs on macOS and not on Windows. I have reported this problem to the developers of vscode.neovim, and they said it should be a bug in VS Code and have closed the corresponding issue. This bug appears after version 1.10.1 of vscode.neovim.
VS Code version: Code 1.89.1 (dc96b837cf6bb4af9cd736aa3af08cf8279f7685, 2024-05-07T05:14:32.757Z)
OS version: Darwin arm64 23.4.0
Modes:

System Info

Item
Value

CPUs
Apple M1 Pro (8 x 24)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_graphite: disabled_offvideo_decode: enabledvideo_encode: enabledwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
5, 4, 5

Memory (System)
16.00GB (0.39GB free)

Process Argv
--crash-reporter-id 85b42040-3384-4b8a-9359-d8ca9a96eb2b

Screen Reader
no

VM
0%

Extensions (54)

Extension
Author (truncated)
Version

vscode-neovim
asv
1.10.1

doxdocgen
csc
1.4.0

fastcompare
Dav
1.2.1

EditorConfig
Edi
0.16.4

outline-map
Ger
1.4.0

vscode-pull-request-github
Git
0.88.0

go
gol
0.41.4

latex-workshop
Jam
9.20.1

plantuml
jeb
2.18.1

better-cpp-syntax
jef
1.17.2

cmake-language-support-vscode
jos
0.0.9

vscode-gist
ken
3.0.3

beancount
Len
0.11.0

vscode-clangd
llv
0.1.28

asm-code-lens
maz
2.6.0

rainbow-csv
mec
3.11.0

vscode-docker
ms-
1.29.1

vscode-dotnet-runtime
ms-
2.0.3

black-formatter
ms-
2024.2.0

debugpy
ms-
2024.6.0

isort
ms-
2023.10.1

python
ms-
2024.6.0

vscode-pylance
ms-
2024.5.1

jupyter
ms-
2024.4.0

jupyter-keymap
ms-
1.1.2

jupyter-renderers
ms-
1.0.17

vscode-jupyter-cell-tags
ms-
0.1.9

vscode-jupyter-slideshow
ms-
0.1.6

remote-containers
ms-
0.362.0

remote-ssh
ms-
0.110.1

remote-ssh-edit
ms-
0.86.0

remote-wsl
ms-
0.88.2

cmake-tools
ms-
1.17.17

cpptools-extension-pack
ms-
1.3.0

powershell
ms-
2024.2.1

remote-explorer
ms-
0.4.3

remote-server
ms-
1.5.1

java
red
1.30.0

vscode-yaml
red
1.14.0

partial-diff
ryu
1.4.3

markdown-preview-enhanced
shd
0.8.13

vs-picgo
Spa
2.1.6

even-better-toml
tam
0.19.2

xmake-vscode
tbo
2.3.5

cmake
twx
0.0.17

vscode-lldb
vad
1.10.0

intellicode-api-usage-examples
Vis
0.2.8

vscodeintellicode
Vis
1.3.1

vscode-java-debug
vsc
0.57.0

vscode-java-dependency
vsc
0.23.6

vscode-java-pack
vsc
0.26.0

vscode-java-test
vsc
0.41.1

vscode-maven
vsc
0.44.0

vscode-icons
vsc
12.7.0

(2 theme extensions excluded)

A/B Experiments
vsliv368cf:30146710
vspor879:30202332
vspor708:30202333
vspor363:30204092
tftest:31042121
vscoreces:30445986
vscod805cf:30301675
binariesv615:30325510
vsaa593cf:30376535
py29gd2263:31024239
c4g48928:30535728
azure-dev_surveyone:30548225
vscrp:30673768
2i9eh265:30646982
962ge761:30959799
pythongtdpath:30769146
welcomedialog:30910333
pythonidxpt:30866567
pythonnoceb:30805159
asynctok:30898717
pythontestfixt:30902429
pythonregdiag2:30936856
pythonmypyd1:30879173
pythoncet0:30885854
h48ei257:31000450
pythontbext0:30879054
accentitlementsc:30995553
dsvsc016:30899300
dsvsc017:30899301
dsvsc018:30899302
cppperfnew:31000557
dsvsc020:30976470
pythonait:31006305
showvideoc:31016891
chatpanelc:31048052
dsvsc021:30996838
724cj586:31013169
fchga941:31046352
pythonprc:31047982
dwnewjupyter:31046869

@zwyyy456 Can you please create a screen recording showing the problem? Does the same issue occur after disabling the vscode.neovim extension?

It won't disppear when I disable the vscode.neovim, I have report this problem to the developers of vscode.neovim, but they said it's a problem about vscode and close the issue.
https://github.com/microsoft/vscode/assets/45388797/38dc9fc1-d841-4c0e-8f54-fd99b2dd9497
Here are some issues about this problem:
https://github.com/microsoft/vscode/issues/211856
https://github.com/vscode-neovim/vscode-neovim/issues/1921

Hi I am trying to reproduce this issue but am having a bit of trouble as I don't speak Chinese. You mention I should be able to reproduce this issue without the VS Code Neovim extension installed. First of all, do you still see this issue? If yes could you tell me what keyboard you are using and what exactly you are typing so I can reproduce this issue? Thank you.

What I mean is that when I disable the vscode.neovim extension, this bug no longer occurs, but when I enable the vscode.neovim extension, the bug related to Chinese input appears. This seems to be a bug in the vscode.neovim extension. So, I consulted the developer of the vscode.neovim extension, and their response was that this is actually a bug caused by VSCode itself.

First of all, this issue is actually a problem with vscode. Now vscode-neovim uses default:type correctly.

Currently, only users who need to use composite keys and input CJK characters may encounter this issue. (And just found out that similar issues existed before.) The composite keys refers to the mappings in insert mode, typically 'jj' or 'jk', to return to normal mode.

see vscode.neovim issues

Currently I am trying to reproduce this issue but I am having trouble configuring neovim on my macos. I get the following error 'neovim gets disconnected'. After searching on the neovim repo it would seem that other people are encountering this issue here https://github.com/vscode-neovim/vscode-neovim/issues/2165. Seems like an upstream issue which is preventing from reproducing the bug.
https://github.com/user-attachments/assets/b6cf5d71-f93d-496c-8271-a7aeb6d5bc0f

@aiday-mar Hi, I'm one of the maintainers of vscode-neovim and noticed that you are working on this issue. I believe this issue is consistent with #211856.

Hi thank you for filing this issue. I was able to reproduce this issue with an extension that overrides the type and replacePreviousChar commands as in https://github.com/microsoft/vscode/issues/211856, and I verified that this jittering does not happen with the setting editor.experimentalEditContextEnabled. We will turn on the experimental edit context on by default soon, so I will close this issue.
https://github.com/user-attachments/assets/6f730c2e-fdef-4618-a3c6-9dfd52fe1fd6


Update manage-emergency-call-routing-policies.md

https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/issues/3792

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.


resolve pytest ignoring mark argument

On linux boxes, the command array of ['python', '-m', 'pytest', '-m', '"not cosmosEmulator"'] was dropping the marker argument. Not deselecting properly.
This PR combines them into single execution.

Can one of the admins verify this patch?


fix: intermittent failures in playground/server-origin test

fix #9849

Description
Updates playground/vue-server-origin test to use localhost instead of https://vue-server-origin.test, which causes intermittent failures as the test browser tries to resolve it.
Additional context

What is the purpose of this pull request?

[x] Bug fix
[ ] New Feature
[ ] Documentation update
[ ] Other

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Read the Pull Request Guidelines and follow the Commit Convention.
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[x] Ideally, include relevant tests that fail without this PR but pass with it.

The Mixed content and Redirect rules checks are stuck for some reason. They've been running since 2d ago.

Looks like an issue on Netlify end. Thanks for the fix!


Splash Screen Photoshop Template Missing iPad Pro Sizes

driftyco/ionic-app-lib/pull/88 added new splash resource sizes for iPad Pro, however they are skipped when using the Photoshop template on http://ionicframework.com/docs/cli/icon-splashscreen.html because the PSD is “too small”.
ionic resources --splash output:
splash ios<EMAIL_ADDRESS>(2732x2048) skipped, source image splash.psd (2208x2208) too small
splash ios<EMAIL_ADDRESS>(2048x2732) skipped, source image splash.psd (2208x2208) too small

@bensperry would you be able to bump that up to  2732x2732?

Yep!

Hey @ben, I think there's some confusion, can we get this splash.psd adjusted for the new max size?
https://github.com/driftyco/ionic-code/tree/gh-pages/resources

All Set!


How to enter the OTP automatically

How can I enter OTP automatically when the message is been received to my Mobile Number? I'm using Android 6.0 mobile?

Adding the permission below, in the AndroidManifest.xml, allows Digits to read the SMS pin therefore making the login process easier.

Source: [https://docs.fabric.io/android/digits/sign-in-with-phone-number.html](Digit Docs)

Adding run time permission,

OTP automatically when the message is been received to my Mobile Number.

I have added
uses-permission android:name="android.permission.RECEIVE_SMS" in the manifest.
but I still find that the OTP screen expects me to enter the OTP manually.  What am I doing wrong?

Request permission in activity inside onCreate()

Thank you for posting this issue. As the Digits SDK is evolving into Firebase phone authentication and being deprecated at the end of September, we don't plan on digging into this issue so I'm marking it as closed.
Firebase phone authentication includes the best of Digits plus more power, reliability and new features to drive user growth. Learn more here!


Cannot encode charset, which is supported by the font

What were you trying to do?
I want to write a czech character to a TextField, which is supported by the font.

https://www.alphabet-type.com/tools/charset-checker/
const fontBytes = fs.readFileSync(__dirname + "/MuseoSans_500.otf");
const font = await pdfDoc.embedFont(fontBytes);
console.log(JSON.stringify(font.getCharacterSet()))

returns
[32,33,34,35,36,37,38,39,40,41,42,43,44,45,46,47,48,49,50,51,52,53,54,55,56,57,58,59,60,61,62,63,64,65,66,67,68,69,70,71,72,73,74,75,76,77,78,79,80,81,82,83,84,85,86,87,88,89,90,91,92,93,94,95,96,97,98,99,100,101,102,103,104,105,106,107,108,109,110,111,112,113,114,115,116,117,118,119,120,121,122,123,124,125,126,160,161,162,163,165,167,168,169,170,171,172,173,174,175,176,177,178,179,180,181,182,183,184,185,186,187,188,189,190,191,192,193,194,195,196,197,198,199,200,201,202,203,204,205,206,207,208,209,210,211,212,213,214,215,216,217,218,219,220,221,222,223,224,225,226,227,228,229,230,231,232,233,234,235,236,237,238,239,240,241,242,243,244,245,246,247,248,249,250,251,252,253,254,255,256,257,258,259,260,261,262,263,264,265,266,267,268,269,270,271,272,273,274,275,276,277,278,279,280,281,282,283,284,285,286,287,288,289,290,291,292,293,294,295,296,297,298,299,300,301,302,303,304,305,306,307,308,309,310,311,312,313,314,315,316,317,318,319,320,321,322,323,324,325,326,327,328,329,330,331,332,333,334,335,336,337,338,339,340,341,342,343,344,345,346,347,348,349,350,351,352,353,354,355,356,357,358,359,360,361,362,363,364,365,366,367,368,369,370,371,372,373,374,375,376,377,378,379,380,381,382,383,402,536,537,538,539,710,711,728,729,730,731,732,733,956,7838,8201,8211,8212,8216,8217,8218,8220,8221,8222,8224,8225,8226,8230,8240,8249,8250,8260,8304,8308,8309,8310,8311,8312,8313,8320,8321,8322,8323,8324,8325,8326,8327,8328,8329,8364,8482,8722,8734,8776,8800,8804,8805,64256,64257,64258,64259,64260,65535]

How did you attempt to do it?
form.getTextField("feld").setText("č");
What actually happened?
I am getting this error on the await pdfDoc.save() command.
Error: WinAnsi cannot encode "č" (0x010d)

What did you expect to happen?
It should write the character to the TextField
How can we reproduce the issue?

Download the font https://www.downloadfonts.io/downloads/museo-sans-font/
Embed it
Write "č" to a acro form text field

Version
1.1.1
What environment are you running pdf-lib in?
Node
Checklist

[X] My report includes a Short, Self Contained, Correct (Compilable) Example.
[X] I have attached all PDFs, images, and other files needed to run my SSCCE.

Additional Notes
No response

Hi, I had same problem with czech and characters "č"/"Č" and find way to fix it as mentioned here:
const rawUpdateFieldAppearances = form.updateFieldAppearances.bind(form);
form.updateFieldAppearances = function() {
    return rawUpdateFieldAppearances(serifFont);
};


set default value of status input to false + minor readme update

The update_pull_request_status input is now set to false by default.
This change is not backwards compatible.
Users, who wish to have the status in the PR displayed need to specify
this input explicitly in their yaml configuration file.
Reason for this change is, that there are more possible triggers for
TFaGA than Pull Request and Issue Comment and in those this setting is
not applicable when set to true.
Resolves: https://github.com/sclorg/testing-farm-as-github-action/issues/65

[test]

This PR now removes the pr_head_sha input as it is no longer needed. The information provided by this input is now gathered directly from GitHub metadata.


if_/3 : callable?

I don't get the sense from reading "Indexing dif/2 that the metapredicate if_/3 is meant to be callable. Is it?

Yes, all predicates that library(reif) exports are expected to be callable:
http://www.complang.tuwien.ac.at/ulrich/Prolog-inedit/sicstus/reif.pl


A few fixes to the English content

请保留以下声明。

我已阅读投稿指南并授权云原生社区发布我原创或翻译的文章，我将保留对本文署名的权利。
^ agreed
Correct some English, in particular "有温度的" should not be translated as "with a temperature" as in English this means you are ill with a fever.

Thanks, @oicheryl , your English is particularly authentic. We recently planned to revise our community slogan. When the Chinese version is finished, we'd also like you to review the English version for us.

No problem @rootsongjc, I'm happy to review the new slogan when it's ready.


[WIP] Add support for MongoDB 3.4

This pull request updates pymongo and mongoengine dependencies to latest versions which also support MongoDB 3.4.
In addition to that it also makes various other changes to the code to make it work with newest versions of those libraries (some backward incompatible changes were introduced).
TODO

[ ] Automated tests for 3.2
[ ] Automated tests for 3.4

@enykeev I will probably need to update Circle CI scripts to they support installing and testing with multiple MongoDB versions.
I spent time on that in the past for Travis CI and it worked (we had tests running with MongoDB 2.6 and 3.2), but we introduced a "regression" when moving to Circle CI with regards to that aka we now only test with one version :/

Codecov Report

Merging #3185 into master will increase coverage by -0.04%.

@@            Coverage Diff             @@
##           master    #3185      +/-   ##
==========================================
- Coverage   77.56%   77.51%   -0.04%
==========================================
  Files         432      432
  Lines       22318    22318
==========================================
- Hits        17309    17299      -10
- Misses       5009     5019      +10

Impacted Files
Coverage Δ

st2common/st2common/persistence/db_init.py
73.33% <ø> (ø)
:white_check_mark:

st2common/st2common/models/db/stormbase.py
97.89% <100%> (ø)
:white_check_mark:

...ctions/st2actions/resultstracker/resultstracker.py
72.22% <ø> (-5.56%)
:x:

st2common/st2common/bootstrap/sensorsregistrar.py
80.58% <ø> (-4.85%)
:x:

st2exporter/st2exporter/worker.py
58.82% <ø> (-4.71%)
:x:

st2api/st2api/controllers/v1/triggers.py
72.91% <ø> (-4.43%)
:x:

st2common/st2common/triggers.py
74.42% <ø> (-2.33%)
:x:

st2common/st2common/rbac/decorators.py
85.94% <ø> (-1.56%)
:x:

st2common/st2common/rbac/utils.py
92.25% <ø> (-1.41%)
:x:

st2common/st2common/services/action.py
94.17% <ø> (-0.97%)
:x:

... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bba27a9...0f3f549. Read the comment docs.

I got the builds with two different MongoDB versions working on Circle CI (see diff for corresponding circle.yml and script changes).
Sadly Circle CI user interface is very user-unfriendly and terrible when running multiple things in parallel (it doesn't support build Matrix like Travis CI does which makes it hard to see what is going on).
I will see what I can do to to make it more user-friendly and easier to see which MongoDB version is being used, etc.
In addition to that, it looks like there are still some MongoDB 3.4 related code issues I need to fix (3.4 perform more script index validation, etc. - https://docs.mongodb.com/manual/release-notes/3.4-compatibility/#stricter-validation-of-index-specifications)

All the unit and integration tests are passing with MongoDB 3.2 and 3.4 on CircleCI now.
I will do some more polish and work on a corresponding documentation PR then I will consider this done and ready for the review.
I plan to update the installer scripts to install 3.4 by default in the near future when we have more testing with 3.4 under the belt, but we should still update the blog and release announcement and let people know that since StackStorm v2.2.0 we now also support MongoDB 3.3.


NEXT-8426 - Save user settings in listing views

1. Why is this change necessary?
User settings like compact mode and previews were not saved upon reloading a window containing a listing view.
2. What does this change do, exactly?
Save the user settings in the local storage.

3. Describe each step to reproduce the issue or behaviour.
Navigate to a listing view (e.g. Products), go to list settings and change compact mode or preview settings.
4. Please link to the relevant issues (if any).

https://github.com/shopwareBoostDay/platform/issues/58
NEXT-8426

5. Checklist

[ ] I have written tests and verified that they fail without my change
[x] I have squashed any insignificant commits
[x] I have created a changelog file with all necessary information about my changes
[ ] I have written or adjusted the documentation according to my changes
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

@PaddyS Could you review again after the changes @taltholtmann requested yesterday?


feat(ratelimit): traffic limit models

add traffic limit db models
#647

pls install pre-commit
pip install pre-commit
cd ${w3bstream_repo} && pre-commit install


Set the arguement default value for the send_mail function of django.core.mail.__init__.py.

First, I am always using your library well! :)
I set the arguement default value for the send_mail function of django.core.mail.__init__.py.
The docstring of the send_mail function is shown below.
"""
      If from_email is None, use the DEFAULT_FROM_EMAIL setting.  # this line!
    If auth_user is None, use the EMAIL_HOST_USER setting.
    If auth_password is None, use the EMAIL_HOST_PASSWORD setting.
"""

The accompanying arguments auth_user, auth_password, has default value None, but send_mail has no default value.
I think this approach is inefficient because we have to write down unnecessary from_email when using it.
from django.core.mail import send_mail

send_mail(
	subject="Activate your DoranDoran account.",
	message="Please Activate your account http://localhost:8000",
	from_email=None,
	recipient_list=[user_instance.user.email],
	fail_silently=False,
)

like this code...

This looks related to ticket -- #32633.

Closing per comment.


Filter Criteria Side Nav- 508 issue

Required Fix

[ ] RF-4
[ ] RF-5a
[x] RF-5c
[x] RF-10
[ ] RF-15

Context
See EPA CAMD Accessibility Report  for how to fix and additional details

Issue #
Issue Description

RF-4
A modal dialogue appears that does not receive programmatic focus and is not immediately following that control that caused it to appear and/or focus is not returned when the dialog is closed. This issue is a violation of Section 508 and WCAG 2.0 Success Criterion 2.4.3

RF-5a
Elements are present which are actionable by a mouse but not also actionable with simple keyboard controls (directional arrows, Tab, Enter, Space Bar). This issue is a violation of Section 508 and WCAG 2.0 Success Criterion 2.1.1.

RF-5c
For the filters Program, Unity Type, Unit Fuel Type, and Control Technology, you can tab to all the check boxes, but the content does not scroll. In other words, once you tab past the last visible checkbox on the page, you have no idea what you will be selecting.

RF-10
There is informational content intended for screen reader users that is not intended to be displayed, but also is hidden because Display:none or aria hidden = true was used. This issue is a violation of Section 508 and WCAG 2.0 Success Criterion 1.3.1.

RF-15
Elements on the page that have a state or property are not communicating the state or property to assistive technology. This issue is a violation of WCAG 2.0 Success Criterion 4.1.2

Testing
Tester: @aprematta

Testing complete, please see results:
RF-4 - Most aspects fixed. Only issue is that the user is not trapped in the window until cancel or apply filter is selected. You can still get to the other content on the page.
RF-5a - Keyboard wise this looks good, I think a couple programatic issues were introduced:
ANDI is throwing that the form lacks an accessible name.
All Close buttons are labeled close instead of Close
Getting multiple ARIA errors in Axe
Recommend we go through on a call
RF-15 - Only one button has aria selected = true at a time. Aria selected = true should be set for all buttons where a filter selection has already been made.

Testing complete, closing ticket


How to support json import

Thank you for your plugin.
I am now use the plugin with Typescript 5.
Because there is some '*.json' in my project, so I set
{
  "resolveJsonModule": true,
  "module": "ESNext"
}

in my tsconfig.
but the plugin print error like this:
[!] (plugin flat-dts) RollupError: error TS5071: Option '--resolveJsonModule' can only be specified when module code generation is 'commonjs', 'amd', 'es2015' or 'esNext'.

I saw the plugin over the config module to 'system'，so the error print.
So how can i use the plugin with json import like import './lang.json;' in ts and tsx.
If the json can not support, could over the tsconfig resolveJsonModule to false, because the module: system can not resolve json.

With compilerOptions the resolveJsonModule can be disabled:
flatDts({
  compilerOptions: {
    resolveJsonModule: false,
  }
})

I guess this is yet another flag to disable automatically :(

Thank you for your advise.
Now i use the resolveJsonModule: false in my rollup config.
But the json import print some error when i build my project like this:

Is there some way to support json import?

Ah, I see.
The other options would be to try create tsconfig for .d.ts generation. Something like that:
{
  "extends": "./tsconfig.json",
  "include": [],
  "files": ["src/index.ts"]
}

If src/index.ts exports everything you want and does not import JSON (directly or indirectly), then this should help.
Otherwise, it is unavoidable.

Thank you very much! :)
But in my project, I need to import json in my entry indirectly. (I am using the multi entry mode)
Recently I add declare module '*.json' in my @types file. And now json import not print error.
But also i think you can add resolveJsonModule: false in code to avoid this situation:
const MANDATORY_COMPILER_OPTIONS = {
   // Avoid extra work
   checkJs: false,
   // Ensure ".d.ts" modules are generated
   declaration: true,
   // Prevent output to declaration directory
   declarationDir: undefined,
   // Skip ".js" generation
   emitDeclarationOnly: true,
   // Single file emission is impossible with this flag set
   isolatedModules: false,
   // Generate single file
   // `System`, in contrast to `None`, permits the use of `import.meta`
   module: ts.ModuleKind.System,
   // Always emit
   noEmit: false,
   // Skip code generation when error occurs
   noEmitOnError: true,
   // Ignore errors in library type definitions
   skipLibCheck: true,
   // Always strip internal exports
   stripInternal: true,
   // Unsupported by SystemJS
   verbatimModuleSyntax: false,
};


Help: Method to detect old Cordova db existence?

Hi,
Is there any method to detect old Cordova db existence? Because I need to detect it upfront to give some message to the user. e.g. Please wait while we are migrating your data.
Ref: https://github.com/capacitor-community/sqlite/blob/master/docs/MigratingCordovaDatabases.md
Thanks!
This is my current configuration method:
 async configureSqliteCordovaDatabase(): Promise<void> {
    try {
      const sqliteConnection = new SQLiteConnection(CapacitorSQLite);

      const checkConnectionsConsistency = await sqliteConnection.checkConnectionsConsistency();

      await sqliteConnection.addSQLiteSuffix();

      const isConnection = (await sqliteConnection.isConnection('data'))?.result;

      if (checkConnectionsConsistency?.result && isConnection) {
        this.sqliteCordovaDbConnection = await sqliteConnection.retrieveConnection('data');
      } else {
        this.sqliteCordovaDbConnection = await sqliteConnection.createConnection(
          'data',
          false,
          'no-encryption',
          1
        );
      }

      await this.sqliteCordovaDbConnection.open();

      this.setSqliteCordovaDbConnection(this.sqliteCordovaDbConnection);

      this.setSqliteCordovaConnection(sqliteConnection);
    } catch (error) {
      console.log(error);
    }
  }

@Sampath-Lokuge getMigratableDbList is the method returning the cordova database liste for à given path and addSQLiteSuffix to copy them to the right sqlite path

Yes, it is working fine. Thanks!
  async isOldCordovaDatabaseExist(): Promise<boolean> {
    const migratableDbList = await this.sqliteConnection.getMigratableDbList('databases/');

    const result = find(migratableDbList.values, (d) => d === 'data.db');

    return result !== undefined;
  }


[FLINK-27790][Table SQL / API] Port ADD JAR /SHOW JARS syntax implementation from SqlClient to TableEnvironment side

What is the purpose of the change
Port ADD JAR /SHOW JARS syntax implementation from SqlClient to TableEnvironment side for more common use.
Brief change log

Add methods addJar and listJars to the TableEnvironment.
Call the methods from SessionContext in SQL client.

Verifying this change
This change added tests and can be verified as follows:

Added ITCase AddRemoteJarITCase.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)

@flinkbot run azure

The failed case is tracked by FLINK-28844.
Merging...


RegExp start matching from specified index

Is there any API to start matching from specified index, like lastIndex in JavaScript?
For example, match cd from specify index:
// JavaScript
const r = /cd/g
console.log(r.exec('abcd')) // ['cd']

r.lastIndex = 1
console.log(r.exec('abcd')) // ['cd']

r.lastIndex = 2
console.log(r.exec('abcd')) // ['cd']

r.lastIndex = 3
console.log(r.exec('abcd')) // null

I found matchAsPrefix method but it seems not work as above. It gets result only when the matched result start is exactly equal to specified index.
// Dart
var r = RegExp(r'cd');
print(r.matchAsPrefix('abcd')); // null
print(r.matchAsPrefix('abcd', 1)); // null
print(r.matchAsPrefix('abcd', 2)); // Instance of '_RegExpMatch'
print(r.matchAsPrefix('abcd', 3)); // null

There is no direct API to find a single match after a specific start position.
You can use r.allMatches("abcd", 1).first instead.
If you only need the position of the match, you can use "abcd".indefOf(r, 1).
The matchAsPrefix is deliberately giving you the ability to not search forward for a match.
Together, matchAsPrefix and allMatches allow you to search or not search from any position.
The API of Pattern is very small because it is also implemented by String, so it shouldn't conflict with the string members.

Clear enough. Thanks for the quick reply


change internal object name to "backstage-"

Swapped managed object names from "-backstage" to "backstage-" to make it compatible with 1.1 OOTB
Fixes https://github.com/janus-idp/operator/issues/355

/cc


Add {de,}{voice,op} commands

I don't think this is a pretty approach:
        target = Source.new(room: payload[:room])
        robot.send(:adapter).op(target, payload[:user].name)

What I'd like is to is monkeypatch Lita::Room and add the commands there but I don't know how you feel about that.
        payload[:room].op(payload[:user].name)

is much nicer IMO.
Specs are coming but I wanted to start a discussion first.

Added a spec but it fails in Cinch. Any idea how to fix that?

The way to do this would be to use the "chat service" API introduced in lita 4.6.0, because otherwise there is no way to actually call these methods without accessing the private internals of the adapter.
However, I have since decided that introducing this API was a mistake, precisely because it was not treating adapters as the black box they should be from a user's perspective. Lita's goal is to let you write code that works across all chat services, and that means it must support the lowest common denominator of features in its own API. This doesn't mean that it's "wrong" to write plugins that only work for one chat service—just that it doesn't make sense for Lita libraries themselves to support this use case.
Since I'm planning to deprecate and remove the "chat service" API, I'm not accepting new code that adds features to adapters outside of the Lita::Robot API. Sorry!


ci: Don't release dev versions

With this change, we no longer create releases for all tags, but only for rc- and full versions. Additionally, the binaries are no longer uploaded to GitHub in those cases.

What this PR does / Why we need it:
Special notes for your reviewer:
Does this PR introduce a user-facing change?

looks good to me @Laubi , took the liberty to hit rebase already

I updated the commit by moving the release-id echo a bit above. Now we can see the debug information of the release-id again during the build


Let us change the protocol during php bin/console sales-channel:update:domain

PHP Version
8.1
Shopware Version
6.5
Expected behaviour
sales_channel domain has https://foo.bar.example
php bin/console sales-channel:update:domain --previous-domain="foo.bar.example" "http://foo.bar.example.localdomain"

should be smarter and detect if we want to change the protocol instead of inserting it into the domain
So the sales channel doamin should become http://foo.bar.example.localdomain
Actual behaviour
The domain becomes
https://http://foo.bar.example.localdomain
How to reproduce
See above.
Actually this is a slight feature request, not really a bug.
But I was told a while ago, that we can use GitHub issues for things we would like to provide a pull request and we would do this.
First I would like to have some feedback how the interface to this feature-bug-fix should look like.

Should we just detect if the domain contains a protocol
Or should we add an option

php bin/console sales-channel:update:domain --previous-domain="foo.bar.example" --new-protocol=http "foo.bar.example.localdomain"

We should change the protocol only when given in the new URL 🤔 . In that way it should be backwards compatible

@shyim Thanks for the quick feedback
I looked through the bot's suggestions and the abandoned
https://github.com/shopware/platform/pull/3044/commits/5aed19bad5ab4ee7fd23cf6613bbee3a2e1cb264
might be a good base for implementing this.
On the way we could also allow port changes (basically overwrite everything which was supplied in the CLI)

:thinking:
In 6.6. there is https://developer.shopware.com/docs/guides/hosting/configurations/shopware/staging.html#configuration-1 which allows replacing domains even using regex. but the code is separate:
https://github.com/shopware/shopware/blob/deed7e218d27b05469630dd3a7178d1e2aa35292/src/Core/Maintenance/Staging/Handler/StagingSalesChannelHandler.php#L58
Anyways, the new feature might solve similar problems we tried to solve with this issue.

Hi,
thx for your issue we will put it into our new evaluation process and have a look at it again.

[public] Automated response: This issue is linked to the internal issue https://shopware.atlassian.net/browse/NEXT-37920.
[created from NEXT-37920, comment 488812]


feat(package): support pypy3.8

Change Summary
Closes #273
Checklist

[x] Unit tests for the changes exist
[x] Tests pass without significant drop in coverage
[ ] Documentation reflects changes where applicable
[ ] Test snapshots have been updated if applicable

Agreement
By submitting this pull request, I confirm that you can use, modify, copy and redistribute this contribution, under the terms of your choice.

We are not going to support PyPy yet as it is too slow for us.


[FEATURE] [SDK] chat field support sdk

Description

This PR implements chat field support on the SDK.
Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Refactor (change restructuring the codebase without changing functionality)
Improvement (change adding some improvement to an existing functionality)
Documentation update

How Has This Been Tested

Checklist

I added relevant documentation
I followed the style guidelines of this project
I did a self-review of my code
I made corresponding changes to the documentation
I confirm My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

Hi @burtenshaw, looking good. I think we might want to add this to the from/to/disk/hub methods too.

Sorry @davidberenstein1957 . I don't get this one. How would we add this to those methods?


Test direct-minimal-versions

This builds the crate with direct-minimal-versions checking if the crate actually builds with the minimal dependency versions specified.
Using taiki-e/install-action to install cargo-hack specifically to use --remove-dev-deps to get the actual minimal versions users can use. If these CI dependencies are undesirable, I can make an out-of-workspace sub-crate that can have it's own lockfile without any dev-dependencies.
Cc #271.

Thanks!


drivers: sensor: add sht21, htu21d driver

Add SHT21 and HTU21D support.
This comes from https://github.com/zephyrproject-rtos/zephyr/pull/56227, I rebased it on mainline.  I decided to do this because the other pull request was left pending. I personally tested the driver for the sht2x sensor and it worked correctly.

I've been continuously rebasing my PR to keep it current for over a year.  Why the sudden need to make a new PR?

Duplicate of #56227
There is now an active effort to get the original PR merged.


Fixed links to Governance and Change Plan

This fixes some broken links resulting from the restructuring. Or did you intend to keep Governance and Change Plan outside of the toc folder, @chipchilders ?

Merged pre-meeting as this corrects a miss from the restructuring process.


Update validatable.rb

Before validate password length should check whether the password is required, otherwise, if database_authenticatable was not set, it will throw an exception "undefined method password..".

Thank you but this commit breaks a test which is checking exactly the scenario you want to avoid. In your case, the best scenario is to not use validatable.

How about if: -> { respond_to?(:password) }

There is no need, thanks. One shuold really not use validatable if you are not using database authentication.


Flexible assets

Allows overriding assets location at runtime through the environment variable MWF_DATADIR. If assets.zip is found at that location, it will be mounted. If not, it will try to load the needed files directly from the directory specified.

@EliteTK Please review this and test on Linux. Appears to work fine on Windows. Set MWF_DATADIR to the directory path to load assets from. If assets.zip is in that directory, it will be loaded. Otherwise, raw assets will be loaded directly.
Please try loading with and without zip file.

@EliteTK Please take a look at this again and make sure it works ok before I merge.

Compiles just fine.

@EliteTK Thanks. Merging then to get one of these out the door.


Create deployment webhook and script

As part of #43, we need a webhook that can be triggered via GitHub Actions, and which causes our staging or production deployments to update the Docker image tag they use.
The way we'll do this is to use webhook.  We'll run it on port 8000.  GitHub Actions will do a POST to https://mycustomdomain.senecacollege.ca/hooks/deploy which can trigger a deploy webhook (i.e., that would be its id).  We'd send the new tag to use in the body.  The webhook would then run a shell script that passes the new tag via a variable (e.g., environment variable).
I have a demo of this working.  However, it's not secured at all.  We should add some kind of security token that the server expects to receive, etc.
This issue is about:

Creating the hooks.json file to configure the webhook(s)
Creating the shell script we need to run to update the containers to use new images

We could also consider running this webhook in Docker; but we'd have to mount the system's docker socket file so it can trigger the Docker update in the host from within the container.


Add an option to save a minimum price for an item

What's your suggestion?
This will probably bloat the mod but I was wondering if it were possible to add in a setting so that you could set a minimum sell value for an item so you could still just list an item and click on the current listings to copy the price to your clip board, but if that price is less than your minimum for the specific item it instead copies the minimum.
For example if I wanted to sell a stack of lumber at 100 a piece but the current listings are all 95, when I click on a listing that's at 95 the system would instead copy 100 and use that for the quick list feature instead.

I agree i would like to see this as well.


[WIP] Packaging Pbxplore

Hi,
This is a big step to package pbxplore with setuptools (#21 & #22). See setup.py.
Several things:

A version number have been added. Fee free to change it if it's incorrect.
The scripts have been moved into the  scripts folder and entry_points have been created. Once pbxplore installed, command like PBassign, PBclust, PBcount & PBstat will be available to the user.
The test structure have been moved inside the package so the users can run themselves the tests.
Since they are regression tests which check the scripts, you have to install first the package in order to run those tests. Then, just run the command nosetests pbxplore.
Update travis to reflect the changes.

TODO:

[ ] : Publish it on pypi once this PR is reviewed and merged. Only @pierrepo can do it. I could write a tutorial to help you.
[ ] : add a test for the doc into travis.  @jbarnoud is it easy?

Yeah ! That's exiting !
Regarding the requirements, there could be extra requirements for the analysis so that pip install pbxplore[analysis] requires weblogo and matplotlib, and an extra requirements for trajectories so that pip install pbxplore[trajectries] requires MDAnalysis. Finally, there could be a pip install pbxplore[all] to install all requirements.
Would nosetest find the tests if the test directory is renamed _tests ? Is so it may be nice to have _tests, and _scripts rather than test, and script. Indeed, these two directory are not directly part of the API. Yet, they are not directly exposed either so it is no big deal.
It would be nice to have some input files in the package for the users to play with. The demo files would be ideal for that. I think they could be put in pbxplore/data, see my comment on #97. I'll try to propose something about that soon.

I gave some though to the last paragraph of my last comment. It is a separate issue (in fact it is issue #97, well played @HubLot ). I will continue the discussion about demo files in the corresponding issue.

@HubLot great!
About the version number, can we link it to the tags in git? I already started to use tags.
Yes please, I would be happy to have a quick tuto about setting up pypi.

Good idea @jbarnoud for the requirements, I will amend the PR to have these. We are ok that by default, only numpy will be installed ?
About the _tests and _scripts folder, I'm not sure it's a good idea. It's not a common practice to have a _ if you look other packages.
The data/demo files could be treated in a separated issue (#97).
@pierrepo, I'm not sure I can link the version to the git tags. I'll let you know.
Finally, the publishing on Pypi should be the last thing to do because it only accepts one version of the package at the time. It's not possible to amend a version. I'll wrote you a quick tuto @pierrepo, it's quite easy.

I add the extra_requires in the setup.py to install optional dependencies. Now, you can:

pip install -e . (local) or pip install pbxplore (once it's on pypi): will install pbxplore and numpy
pip install -e .[analysis] or pip install pbxplore[analysis]: will install pbxplore, weblogo and matplotlib
pip install -e .[trajectories] or pip install pbxplore[trajectories]: will install pbxplore and MDAnalysis
pip install -e .[all] or pip install pbxplore[all]: will install all dependencies

@pierrepo, I didn't find documentation about git tags and a possible link. I don't think it's possible but we can do it manually.
I think now the PR can be merged. The demo files will be treated in a separate issue and @jbarnoud is struggling to add the doc on travis and will make a new PR.

@hublot See #98 for the doc. There should be very little conflict; the only one I can see is in the .travis.yml where I did lot of changes and you added the install of the package.

I tried to install the package on a clean virtualenv. The install failed because the setup imports pbxplore that imports numpy. However, at that point, numpy is not installed, and it is not even listed as a requirement yet.
Here is the full traceback:
$pip install -e .[all]
Obtaining file:///Users/jon/dev/PBtest
  Running setup.py (path:/Users/jon/dev/PBtest/setup.py) egg_info for package from file:///Users/jon/dev/PBtest
    Traceback (most recent call last):
      File "<string>", line 17, in <module>
      File "/Users/jon/dev/PBtest/setup.py", line 9, in <module>
        import pbxplore
      File "pbxplore/__init__.py", line 23, in <module>
        from .structure.loader import *
      File "pbxplore/structure/__init__.py", line 43, in <module>
        from .PDB import PDB_EXTENSIONS, PDBx_EXTENSIONS
      File "pbxplore/structure/PDB.py", line 11, in <module>
        from .structure import Atom, Chain
      File "pbxplore/structure/structure.py", line 10, in <module>
        import numpy
    ImportError: No module named numpy
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):

  File "<string>", line 17, in <module>

  File "/Users/jon/dev/PBtest/setup.py", line 9, in <module>

    import pbxplore

  File "pbxplore/__init__.py", line 23, in <module>

    from .structure.loader import *

  File "pbxplore/structure/__init__.py", line 43, in <module>

    from .PDB import PDB_EXTENSIONS, PDBx_EXTENSIONS

  File "pbxplore/structure/PDB.py", line 11, in <module>

    from .structure import Atom, Chain

  File "pbxplore/structure/structure.py", line 10, in <module>

    import numpy

ImportError: No module named numpy

----------------------------------------
Cleaning up...
Command python setup.py egg_info failed with error code 1 in /Users/jon/dev/PBtest
Storing debug log for failure in /Users/jon/.pip/pip.log

I fixed the error had @jbarnoud.
The import pbxplore in the setup.py was just to have the version number from pbxplore.__version__.
The easiest workaround was to remove this import from the setup.py and add a constant VERSION in the setup.py. This implies to have both version (in the setup.py and in pbxplore.__init__.py synced manually. Otherwise, we will need tricks like partial import or automatically generate a version.py.
Note, the command pip install -e .[all] will still fails because MDAnalysis and weblogo require to have numpy installed before installing them.

An other trick would be to have the version number in a file (called VERSION for instance) and to read the version from that file as we read the README.
Note that mdanalysis is working on a fix for their numpy issue. I do not know for weblogo.
Le 21 oct. 2015 11:16 AM, Hub<EMAIL_ADDRESS>a écrit :I fixed the error had @jbarnoud.
The import pbxplore in the setup.py was just to have the version number from pbxplore.version.
The easiest workaround was to remove this import from the setup.py and add a constant VERSION in the setup.py. This implies to have both version (in the setup.py and in pbxplore.init.py synced manually. Otherwise, we will need tricks like partial import or automatically generate a version.py.
Note, the command pip install -e .[all] will still fails because MDAnalysis and weblogo require to have numpy installed before installing them.
—Reply to this email directly or view it on GitHub.

Hi guys, sorry for the delay, things are getting a bit hot here in Congo.
I do not have time to review the entire PR but I trust your choices.
Again thanks for the nice work.


CODE: Negative value

Extend the fixed value trait model to simulate effect sizes from opposing signs.

I just want to quickly add this feature to enable simulation algorithm described by Barton et al. (2023).


Can someone answer the pros and cons of scss generating atomic classes and unocss generating atomic classes?

Can someone answer the pros and cons of scss generating atomic classes and unocss generating atomic classes?
https://www.zhihu.com/question/555550238/answer/2689519487
@antfu

Use discussions to ask questions.


spaces instead of tabs

It appears that your main.py file uses spaces instead of tabs. @jvdoorn

PEP 8 prefers spaces over tabs https://www.python.org/dev/peps/pep-0008/#tabs-or-spaces.


AMBARI-22878. Fix unit tests

What changes were proposed in this pull request?
Fix (most) unit tests broken by #234.
How was this patch tested?
Ran unit tests before the changes.  Ran individual unit tests afterwards.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/827/
Test FAILed.
Test FAILured.

before:
Tests run: 5020, Failures: 29, Errors: 123, Skipped: 37
after:
Tests run: 5023, Failures: 31, Errors: 21, Skipped: 37
(some errors masked previous failures)

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/828/
Test FAILed.
Test FAILured.


June 2022 Recovery 2

[x] Create a milestone June 2022 Recovery 2 @connor4312
[x] Bump the version number @connor4312
[x] 🔖candidate issues
[x] Assign candidate issues to the recovery milestone team
[x] Review the candidate issues, and if they pass the review assign them to the recovery milestone team
[x] All candidate fixes are peer reviewed and pushed to main and then cherry-picked into the release branch team
[x] Initiate insiders build from main
[x] Issues are tested in the insiders team
[x] Build stable for all platforms from release branch @connor4312
[x] Issues are verified on stable build and the verified label is added @connor4312
[x] Check https://github.com/Microsoft/vscode/compare/release/<x.y> to ensure no other commits have been made in the release branch @connor4312
[x] Update the release notes and include a link to a query for the fixed issues @gregvanl
[x] Sanity check of installable bits (server instructions)

[x] Windows 32 bit @connor4312

[x] signed installer 32-bit
[x] signed user installer 32-bit
[x] zip 32-bit
[x] server 32-bit

[x] Windows 64 bit @joyceerhl

[x] signed installer 64-bit
[x] signed user installer 64-bit
[x] zip 64-bit
[x] server 64-bit @connor4312

[x] Windows ARM64 @sbatten

[x] signed installer ARM64
[x] signed user installer ARM64
[x] zip ARM64

[x] macOS @roblourens

[x] Universal
[x] Intel
[x] Intel server
[x] Apple Silicon @kieferrm

[x] Linux x64

[x] deb @connor4312
[x] rpm @rzhao271
[x] archives @rzhao271
[x] snap (sudo snap install --classic --dangerous <file>.snap) @connor4312

[x] Linux server @rzhao271

[x] x64
[x] x64 Alpine
[x] ARM32
[x] ARM64

[x] Publish website @gregvanl
[x] Publish stable build @connor4312
[x] Create an official release @connor4312

[x] Create a tag (make sure you pull the release branch first): git tag <x.y.z> release/<x.y>
[x] Push the tag: git push origin <x.y.z>
[x] Create a GitHub release: Open the GitHub tags, and click far right ... > Create Release. Use the correct title and description from our release notes. Example

[x] Close the milestone on GitHub @connor4312

i still have the same isuess like before the Version: 1.69.2
here is the proof

I'm no longer getting autocomplete suggestions either
ty


Implement moqui login support in 2.0 branch

What is the motivation for adding/enhancing this feature?

Add support to login using moqui for the directed cycle count app
What are the acceptance criteria?

[ ] ...

Can you complete this feature request by yourself?

[ ] YES
[ ] NO

Additional information

Changes verified and working fine. Hence, closing this ticket.


Unable to build 16KB aligned Tensorflow lite library for Android V

Issue type
Support
Have you reproduced the bug with TensorFlow Nightly?
Yes
Source
source
TensorFlow version
tf 2.17
Custom code
No
OS platform and distribution
No response
Mobile device
Android V
Python version
No response
Bazel version
bazel 6.0.1
GCC/compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current behavior?
Currently we are unable to find the right flag needed to be added in bazel build for building 16KB aligned libraries.
Standalone code to reproduce the issue
Currently we are unable to find the right flag needed to be added in bazel build for building 16KB aligned libraries.
16 KB libraries are supposed to give performance benefit in Android V.

Relevant log output
No response

@pallaviNNT,
Could you please share a reproducible code or the colab gist that supports your statement so that the issue can be easily analysed/debugged? Thank you!


[WebSites] Fixes to HTTP response codes, missing enum properties

Description

This change adds some missing HTTP response codes for APIs required by the PowerShell project. It also adds missing SKUs to the AppServicePlans. It is needed to get our new PowerShell commands working. Most of the files have been modified with a small comment due to an Autorest update.

This checklist is used to make sure that common guidelines for a pull request are followed.

[X] I have read the contribution guidelines.
[X] The pull request does not introduce breaking changes.

General Guidelines

[X] Title of the pull request is clear and informative.
[X] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[X] Pull request includes test coverage for the included changes.

SDK Generation Guidelines

[X] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
[X] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
[X] The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@shahabhijeet Can you please review this PR?


ModuleNotFoundError

No module named 'tensorflow' when using from tensorflow.keras.wrappers.scikit_learn import KerasClassifier
Environment: Describe your environment, including:
TensorFlow version ( 2.17.0, 2.18.0)
Python version (3.8.10)
ModuleNotFoundError: No module named 'tensorflow'
Expected Behavior: Should've imported the KerasClassifier from tensorflow.keras.wrappers.scikit_learn

@Harsha7226,
Could please try to install scikeras using pip install scikeras and then import from scikeras.wrappers import KerasClassifier.  Kindly find the gist of it here. Thank you!


Master to Develop

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@dc14e9c). Click here to learn what that means.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             develop       #30   +/-   ##
===========================================
  Coverage           ?   100.00%
  Complexity         ?        14
===========================================
  Files              ?         5
  Lines              ?        47
  Branches           ?         0
===========================================
  Hits               ?        47
  Misses             ?         0
  Partials           ?         0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc14e9c...54906aa. Read the comment docs.


Check Summed Hex

About These Changes

Replaces #1900.
Brings #1557 up to speed with dev.
For more info, see comprehensive issue #1415

LGTM, we just need to get rid of checksum_encode_if_small (since the code always does that now)

Approved but let's hold off merging until we're out of code freeze.


add table node, table example

add table node, table example

This merge is mainly to increase the Table node, there are examples

I'm not sure if disabling an eslint rule is the best way to fix it's violations.

Ok, I am modifying my code. @erickwilder

Hey guys~  I am just looking for a tiptap extension for plain html tables and found this. How is the status of this PR?