Debugging librealsense2 for Galactic Build Fail

The Galactic build of librealsense2 fails with an error message:
"
CMake Error at CMake/lrs_options.cmake:12:
09:02:49   Parse error.  Expected a newline, got identifier with text "option".
"
see example build log
I assume the package described in the distribution.yaml is this. I downloaded the source code.zip but the file CMake/lrs_options.cmake at line 12 seems perfectly ordinary.
Running cmake ../ -DCMAKE_BUILD_TYPE=None -DCMAKE_VERBOSE_MAKEFILE=ON -DCMAKE_AUTOGEN_VERBOSE=ON also seems to work fine.
Am I donwloading a wrong version?
I am pretty sure it has something to do with the patches.
Is there a method to duplicate the process locally so I could see what is the problematic file looks like at the time CMake is called?
Any other ideas or suggestions for starting points for debugging?
Thanks

A short preface: In the future, this type of issue report / question is probably best posted to ROS Answers. I may end up re-creating the issue there so the answer below can serve as a template / case study for investigating strange build issues.
My first thought is to suspect some kind of line-ending tomfoolery like a stray carriage return.
You've got the correct release, but for a more accurate reproduction of what the build farm has collected I would first look at the debian/* tag rather than the release/* tag.  The difference is that the debian/* tag is what the Ubuntu sourcedeb job will fetch in order to build the .deb package as that tag includes the debian metadata overlaid onto the release. Both the release "phase" and debian overlay "phase" in Bloom have the opportunity to patch files so it could be a problem introduced in the Debian phase. However, I downloaded the source at debian/ros-galactic-librealsense2_2.48.0-1_focal and looked at it in xxd and I don't see anything funky about line 12. The next thing to check is if there's different behavior between downloading the archive and a git clone of the repository which is how the sourcedeb job fetches the sources for the first time.
git clone --branch debian/ros-galactic-librealsense2_2.48.0-1_focal --depth 1 --no-single-branch https://github.com/IntelRealSense/librealsense2-release.git

However again, I don't find anything out of the ordinary there.
So let's work backwards from the binarydeb job.
We can reproduce the job itself on a Linux system with Docker configured using the generate_release_script.py command from ros_buildfarm
mkdir /tmp/librealsense2-galactic
generate_release_script.py https://raw.githubusercontent.com/ros2/ros_buildfarm_config/ros2/index.yaml galactic default librealsense2 ubuntu focal amd64 > /tmp/librealsense2-galactic/run.sh
cd /tmp/librealsense2-galactic
sh run.sh

This will run a script which performs both the sourcedeb and binarydeb jobs locally via docker. If it does work then something went wrong on the Jenkins host and we may need to rebuild the debian source tarball.
Building locally worked for me. So let's pull down the orig.tar.gz file packed by the sourcedeb job. And if I untar that I find something very weird indeed!
 diff -u librealsense2-release/CMake/lrs_options.cmake ros-galactic-librealsense2-2.48.0/CMake/lrs_options.cmake
--- librealsense2-release/CMake/lrs_options.cmake       2021-07-13 10:47:21.389278815 -0700
+++ ros-galactic-librealsense2-2.48.0/CMake/lrs_options.cmake   2021-07-01 05:02:24.000000000 -0700
@@ -1,4 +1,15 @@
-option(ENABLE_CCACHE "Build with ccache." OFF)
+option(ENABLE_CCACHE "Build with ccache." ON)
+option(BUILD_WITH_CUDA "Enable CUDA" OFF)
+option(BUILD_GLSL_EXTENSIONS "Build GLSL extensions API" ON)
+option(BUILD_WITH_OPENMP "Use OpenMP" OFF)
+option(ENABLE_ZERO_COPY "Enable zero copy functionality" OFF)
+option(BUILD_WITH_TM2 "Build with support for Intel TM2 tracking device" ON)
+option(BUILD_EASYLOGGINGPP "Build EasyLogging++ as a part of the build" ON)
+option(BUILD_WITH_STATIC_CRT "Build with static link CRT" ON)
+option(HWM_OVER_XU "Send HWM commands over UVC XU control" ON)
+option(COM_MULTITHREADED "Set OFF to initialize COM library with COINIT_APARTMENTTHREADED (Windows only)" ON)
+option(BUILD_SHARED_LIBS "Build shared library" ON)
+option(BUILD_UNIT_TESTS "Build LibCI unit tests. If enabled, additional test data may be downloaded" OFF)option(ENABLE_CCACHE "Build with ccache." OFF)
 option(BUILD_WITH_CUDA "Enable CUDA" OFF)
 option(BUILD_GLSL_EXTENSIONS "Build GLSL extensions API" ON)
 option(BUILD_WITH_OPENMP "Use OpenMP" OFF)
@@ -34,6 +45,41 @@
 option(BUILD_NETWORK_DEVICE "Build Network Device support" OFF)
 option(FORCE_LIBUVC "Explicitly turn-on libuvc backend - deprecated, use FORCE_RSUSB_BACKEND instead" OFF)
 option(FORCE_WINUSB_UVC "Explicitly turn-on winusb_uvc (for win7) backend - deprecated, use FORCE_RSUSB_BACKEND instead" OFF)
+option(ANDROID_USB_HOST_UVC "Build UVC backend for Android - deprecated, use FORCE_RSUSB_BACKEND instead" OFF)
+option(CHECK_FOR_UPDATES "Checks for versions updates" ON)
+option(BUILD_WITH_CPU_EXTENSIONS "Enable compiler optimizations using CPU extensions (such as AVX)" ON)
+set(UNIT_TESTS_ARGS "" CACHE STRING "Command-line arguments to pass to unit-tests-config.py, e.g. '-t <tag> -r <regex>'")
+#Performance improvement with Ubuntu 18/20
+if(UNIX AND (NOT ANDROID_NDK_TOOLCHAIN_INCLUDED))
+    option(ENABLE_EASYLOGGINGPP_ASYNC "Switch Logger to Asynchronous Mode (set OFF for Synchronous Mode)"  ON)
+else()
+    option(ENABLE_EASYLOGGINGPP_ASYNC "Switch Logger to Asynchronous Mode (set OFF for Synchronous Mode)" OFF)
+endif()
+
+option(BUILD_LEGACY_LIVE_TEST "Build the live-test.exe test used in Travis. If enabled, additional test data may be downloaded" OFF)
+option(BUILD_INTERNAL_UNIT_TESTS "Test package for components under librealsense namespace, requires BUILD_SHARED_LIBS=OFF and BUILD_UNIT_TESTS=ON" OFF)
+option(BUILD_EXAMPLES "Build examples (not including graphical examples -- see BUILD_GRAPHICAL_EXAMPLES)" ON)
+option(BUILD_GRAPHICAL_EXAMPLES "Build graphical examples (Viewer & DQT) -- Implies BUILD_GLSL_EXTENSIONS" ON)
+option(BUILD_CV_EXAMPLES "Build OpenCV examples" OFF)
+option(BUILD_DLIB_EXAMPLES "Build DLIB examples - requires DLIB_DIR" OFF)
+option(BUILD_PCL_EXAMPLES "Build PCL examples" OFF)
+option(BUILD_TOOLS "Build tools (fw-updater, etc.) that are not examples" ON)
+option(ENFORCE_METADATA "Require WinSDK with Metadata support during compilation. Windows OS Only" OFF)
+option(BUILD_PYTHON_BINDINGS "Build Python bindings" OFF)
+option(BUILD_PYTHON_DOCS "Build Documentation for Python bindings" OFF)
+option(BUILD_CSHARP_BINDINGS "Build C# bindings" OFF)
+option(BUILD_MATLAB_BINDINGS "Build Matlab bindings" OFF)
+option(BUILD_UNITY_BINDINGS "Copy the unity project to the build folder with the required dependencies" OFF)
+option(BUILD_OPENVINO_EXAMPLES "Build Intel OpenVINO Toolkit examples - requires INTEL_OPENVINO_DIR" OFF)
+option(BUILD_OPEN3D_EXAMPLES "Build Open3D examples" OFF)
+option(BUILD_NODEJS_BINDINGS "Build Node.js bindings" OFF)
+option(BUILD_OPENNI2_BINDINGS "Build OpenNI bindings" OFF)
+option(IMPORT_DEPTH_CAM_FW "Download the latest firmware for the depth cameras" ON)
+option(BUILD_CV_KINFU_EXAMPLE "Build OpenCV KinectFusion example" OFF)
+option(FORCE_RSUSB_BACKEND "Use RS USB backend, mandatory for Win7/MacOS/Android, optional for Linux" OFF)
+option(BUILD_NETWORK_DEVICE "Build Network Device support" OFF)
+option(FORCE_LIBUVC "Explicitly turn-on libuvc backend - deprecated, use FORCE_RSUSB_BACKEND instead" OFF)
+option(FORCE_WINUSB_UVC "Explicitly turn-on winusb_uvc (for win7) backend - deprecated, use FORCE_RSUSB_BACKEND instead" OFF)
 option(ANDROID_USB_HOST_UVC "Build UVC backend for Android - deprecated, use FORCE_RSUSB_BACKEND instead" OFF)
 option(CHECK_FOR_UPDATES "Checks for versions updates" ON)
 option(BUILD_WITH_CPU_EXTENSIONS "Enable compiler optimizations using CPU extensions (such as AVX)" ON)

I cannot explain these file contents with any information I have. Unless the bloom release tags were modified and force pushed this seems like an error during the git fetch and checkout process. Re-running the sourcedeb job fetched the current sources and did properly observe the "correct" state of the file:
11:00:12 dpkg-source: info: building ros-galactic-librealsense2 using existing ./ros-galactic-librealsense2_2.48.0.orig.tar.gz

11:00:13 dpkg-source: info: local changes detected, the modified files are:
11:00:13  source/CMake/lrs_options.cmake

Due to the way debian source packaging works the orig.tar.gz file will remain unchanged and the file will be modified when fetched via the debian source build pipeline.

Thank you so much, both for looking into it so thoroughly and for the excellent description of the different jobs the build farm does. It is a great resource for debugging future releases.
Please let me know if you want me to re-create it in ROS Answers.
If I understand correctly the package will now be built and released, although we are not quite sure how I managed to mess it up so as to confuse git.
Assuming so, the patches of this version may very well be the base for the next version and so I'm afraid the issue will return very soon, with the next librealsense2 release.
The lrs_options.cmake is a file with patches that I tried to migrate from foxy and it is possible I somehow messed it up with the bloom-release process.
I released the same librealsense2 version again at #30152 (this time as 2.48.0-2), hopefully without any patch/code duplications. Is it possible for me to test it using  generate_release_script.py and see if it's worth merging instead of the current version (2.48.0-1)?

although we are not quite sure how I managed to mess it up so as to confuse git.
Assuming so, the patches of this version may very well be the base for the next version and so I'm afraid the issue will return very soon, with the next librealsense2 release.
The lrs_options.cmake is a file with patches that I tried to migrate from foxy and it is possible I somehow messed it up with the bloom-release process.

Can you share the steps that you took to apply patches for Foxy and Galactic with as much detail as you recall?
Did you manually update or manipulate any of the tags in the release repository?
As it happens, updating bloom's docs to better explain the release and platform patch workflows is on my TODO list for this Summer so this could be its own fruitful case study.

If I understand correctly the package will now be built and released

Yes! This was apparently the only build blocker so the package is currently in the ROS 2 Testing repository if you want to set that up and manually test the binary. The next Galactic sync is coming and that will include this release of librealsense2. The status of packages in ROS repositories are viewable on the repository status pages like this one for Galactic on Ubuntu AMD64.

I released the same librealsense2 version again at #30152 (this time as 2.48.0-2), hopefully without any patch/code duplications. Is it possible for me to test it using generate_release_script.py and see if it's worth merging instead of the current version (2.48.0-1)?

Possible: yes. However it is far from straightforward since the generated build script reads a ros_buildfarm_config which references the public rosdistro index so without creating your own custom rosdistro and ros_buildfarm_config there's not an easy way to "mock" a release.
Comparing the two tags locally, the only content differences are the package revision number and changelog date. So the source contents are identical and I don't think releasing 2.48.0-2 is necessary.

I am so frustrated that I already closed the terminals since, so now I need to recreate the steps from memory and personal documentation:
First - I updated the foxy version.
bloom-release --ros-distro foxy --track foxy librealsense2 --edit
I got this message: (As expected because the lrs_options.cmake file was changed and the patches no longer match)
error: CMake/lrs_options.cmake: patch does not apply
>>> Resolve any conflicts and when you have resolved this problem run 'git am --resolved' and then exit the shell using 'exit 0'. <<<

Then I did:
gedit CMake/lrs_options.cmake - Manually modified the file.
Then:
git add CMake/lrs_options.cmake
git am --resolved
exit 0

Second - I moved on to release the galactic version. There is no galactic version at this point so I migrate the patches from foxy:
bloom-release --ros-distro galactic --track galactic librealsense2 --new-track
When asked to migrate patches from another distribution I opened another terminal and did:
cd /tmp/tmp3cAQzd/
git-bloom-release galactic

Here it had some troubles because without patches it is looking for "catkin" but we pressed on. Then:
git checkout patches/release/foxy/librealsense2
mkdir ~/temp/patches
cp *.patch ~/temp/patches
git checkout release/galactic/librealsense2
git am ~/temp/patches/*

I don't remember but I guess the patches didn't apply because the fixed foxy version is not merged at this point, so I probably fixed the lrs_options.cmake, the way I did for foxy:
gedit CMake/lrs_options.cmake
git add CMake/lrs_options.cmake
git am --resolved

Then I carried on according to my list:
git-bloom-patch export

Now I returned to the original terminal and typed "Y" - continue.
Here I just carried on with the process. I don't remember pushing any tags manually.
I hope it helps in the documentation process you are engaged in.

By the way, do you still think these types of questions should be asked in the ROS answers forum? Why?
I asked another release-related question in ROSanswers here Do you think it belongs in this repository instead?

For some reason version 2.48.0-2, from #30152 build is successful: https://build.ros2.org/job/Gsrc_uF__librealsense2__ubuntu_focal__source/
Although we don't really understand what went wrong, I feel like this issue can be closed.
Thanks for all your help.

Based on the last comment, closing this.


Gabriel's suggestions and feedback July 17th 2024

Feedback in July 17th  2024

[x] Website is crashing when dealing with long lists.
[ ]  It would be good to accept files, either lists or tables (less necessary but still could be good).
[ ]  When changing analysis types, don't change the current gene list (atm is suggesting new random genes each time you change).
[x] Running a new search with the same gene dataset from the results page would make it more user friendly.

Implemented POST support for long lists. I'll upload to the server later in the day.

all implemented in https://github.com/lubianat/wikiora/commit/ddf9531500f083172c4b1bebe874562d523999c9


Missing explanation of how to access multiple values in a BPTREE_MULTI

There is an explanation for how to declare a BPTREE_DEF* separately from a BPTREE_MULTI_DEF* and how it affects the storage logic and key uniqueness, but I don't see a way to actually access multiple values under the same key except for iterating over all of the items in the tree (which would defeat the purpose of using a tree for fast lookup).
Is there a separate API for looking up a BPTREE iterator from a key, or some other way of accessing the multiple possible values within a BPTREE_MULTI? There may already be so, I just cant find any documentation or explanation of it.

You can use the following API to iterate on the multiple values associated to a key:

name_it_from
name_it_while_p

(I have fixed the documentation of name_it_from which was incorrect).
See example

Thanks! I thought it was just the docs and not the interface.


add rasterio requirements & fix tests

I think I fixed all these problems in #3 (for instance I switched to memory file in tests as we discussed there). Thanks for sharing this example though!

cool -- I'll close it
I made this as a PR into your branch, so if you'd wanted to, you could have merged this code directly into your branch.


Added error detection

Hello . Please add error detection.
Unfortunately, this plugin does not detect the error.

Thanks for the suggestion.
This topic is being discussed in issue #21


Column selectors: search field is invisible (above the screen) when the number of columns is big

The search functionality itself works, but you cannot see what you are typing.

Fixed in v0.146

Column selectors search field is not visible in some specific cases:
Pie chart
Line chart: split by
Histogram
Bar chart: stack
Network diagram
Box plot: X axis
Tree map: Color
Density plot: X axis

Indeed it was not fixed completely - but now it should all be working.
Fixed in v0.152


Scroll to top button

Implement scroll to top button, which was missing in the new design.
Current live button: https://www.macktrucks.com/

Existing requirements

The button should be displayed in a fixed position on the screen
When clicking the button, the page should smoothly scroll back to the top of the page
The button should only appear when the user has scrolled down a certain distance from the top of the page
The button should be hidden when the user is already at the top of the page or when the page content does not exceed the viewport height

Design requirements

Make use of the button design for the newsletter subscription form in the footer
The arrow would be positioned counter clockwise, pointing upwards
The button should have a shadow like on the 360 view slider
The states of the buttons need to be implemented as on https://www.figma.com/file/URJhT8pkntqc6h6v5wSLqx/Mack-Core-Design-Kit?type=design&node-id=49-4333&mode=design&t=cVDpihR7kqOneqkM-4
Icon to be used can be found here

confirmed as done


Fix #32

Fix #32 based on the parallel algorithm see wikipedia section "Parallel algorithm" and Chan, Tony F.; Golub, Gene H.; LeVeque, Randall J. (1979), "Updating Formulae and a Pairwise Algorithm for Computing Sample Variances.", Technical Report STAN-CS-79-773, Department of Computer Science, Stanford University.

Nice! Could you add a test as well?

Done!

Excellent! I've fixed up the CI config to run tests on PRs as well: https://github.com/entity-neural-network/incubator/pull/35
Could you rebase onto latest main and push the branch again to see if it worked and tests get triggered?

Looks like code formatter is failing, you can fix with pip install black==19.10b0 and running black .. In VSCode, you can also set up format on save to make it automatic.

Perhaps you can add a CONTRIBUTING.md with all the requirement that need to be fulfilled, so there's no need to say "format with black, we use pytest and so on" in each PR?

🎉🎉🎉


ERROR

syntax error line 220, 10
Its where code says:cur = con.cursor()
how to fix it?

I can't reproduce the issue. In case that you have edited the downloaded file it might be a tabbing/space.


Validating an SLD XML string

Feature Request
Is your feature request related to a problem? Please describe.
I've been looking for a js library to validate a SLD XML string.
Describe the solution you'd like
I'd like to a method which takes an xml string and returns a boolean as to whether it's valid or not.
const isValid = geostylerSldParser.isSldValid(xmlString)

Describe alternatives you've considered
Doesn't look like there are any other js libs out there working on SLD stuff :(
Additional context
Add any other context or screenshots about the feature request here.
Thanks for sharing what looks like an interesting library!

Doesn't look like there are any other js libs out there working on SLD stuff

I think jsonix  might be what you are looking for. It's a json-xml parser

Jsonix advantages:

Strongly structured.
Type-safe.
(Optionally) XML Schema-driven.

As you can see, it supports xml schema and the same maintainer also provides some schemas for ogc standards https://github.com/highsource/ogc-schemas
Besides that, I'm not sure if this is a task for geostyler-sld-parser, or rather a dedicated xml validator, as it would work well standalone.
Also this would break the consistent API with our other parsers, which I would like to keep as clean and simple as possible.
@KaiVolland what do you think?

Thanks for sharing what looks like an interesting library!

Happy to hear that there is an interest in our library.

Wow - great find @jansule , that could indeed fill the need. And yeah if there is something already out there that fits the bill then it makes sense to use it rather then pollute this library.


syncthing010 0.10.30 (new formula)

Re: https://github.com/Homebrew/homebrew/pull/38918

==> Applying patch
Applying: syncthing010 0.10.30 (new formula)
==> Patch changed:
 syncthing010.rb | 56 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 56 insertions(+)
brew bottle --merge --write syncthing010-0.10.30.mavericks.bottle.rb syncthing010-0.10.30.mountain_lion.bottle.rb syncthing010-0.10.30.yosemite.bottle.rb --tap=Homebrew/versions
Error: Bottle block addition failed!
==> syncthing010
  bottle do
    root_url "https://homebrew.bintray.com/bottles-versions"
    cellar :any
    sha256 "8c87238e7718732fb27f1dbc3dd00747fb128629b8e273728761ad5202a3650a" => :yosemite
    sha256 "cae892790cf0744cfbe6417572e6dd53f8c429e1dd23ee6d5aae0040a76dec49" => :mavericks
    sha256 "10ef93e025ff25fe37c4c1ba81484678e7c13d9a61d9c9780af4a0b627acbc2a" => :mountain_lion
  end
Error: Failure while executing: brew bottle --merge --write syncthing010-0.10.30.mavericks.bottle.rb syncthing010-0.10.30.mountain_lion.bottle.rb syncthing010-0.10.30.yosemite.bottle.rb --tap=Homebrew/versions
Build step 'Execute shell' marked build as failure

@mikemcquaid Regex error or? :confused:

Apparently not.
  def test_versions_syncthing_style
    assert_version_detected '0.10.30',
      'syncthing010-0.10.30.yosemite.bottle.tar.gz'
  end

Finished in 7.262550s, 76.5571 runs/s, 170.4635 assertions/s.

556 runs, 1238 assertions, 0 failures, 0 errors, 0 skips

For now I'm merging this bottleless. If people want to downgrade back to 0.10.x they only have a limited time to do so, and supporting this in versions is the easiest way. I'll keep looking at the bottle situation as I can - Although if it's not regex I'm a tad stumped.


Supports trailing commas in list definitions.

Apparently, lists can include a trailing comma (at least lists in the section header).
This is an example, in the section header:
[node name="Pit Water Trigger" type="Area2D" parent="Scene/Trial1/Acid Pit" groups=[
"WaterBody",
]]
visible = false
position = Vector2( -8.50171, -130.333 )
collision_layer = 256
collision_mask =<PHONE_NUMBER>
script = ExtResource( 20 )
__meta__ = {
"_edit_group_": true
}

Note how the groups attribute is a list which contains newlines and a trailing separator (a comma). Newlines are not a problem for the parser but the comma was not supported.
This pull request modifies the parser definition to add support for trailing commas in list values.

Looks good to me! Thanks!


RFC: allow before-cd to modify target directory

I started playing with cd hooks, and I can tell it will simplify a lot the code for my dir module.
I was thinking it might be nice if before-chdir hooks had the possibility of modifying the target directory. This would make it trivial to implement things like cd - support, directory aliases, etc., without having to write wrappers for the cd command. The semantics could be discussed, but something like this could work: if any of the before-chdir hooks return any values, use the last returned value as the new target directory, otherwise use the original argument.
What do you think?

No. These hooks are global, meaning that if you are able to modify the directory in a before-chdir hook you can impact how cd behaves in every module. It can break code like:
cd $dir # what if $dir is "-"?

Use a wrapper for cd. Wrappers are functions, and functions are lexically scoped. You will not change the behavior of cd for everyone else.

Fair enough, and good reasoning.


Using AddRedirectToHttpsPermanent on localhost

Hi,
AddRedirectToHttpsPermanent  works ok on Azure, but locally it does not. When I use ISS express I can reach
https://localhost:44388/
but the unsecure url
http://localhost:44388/
keeps hanging for a while until the browser throws 404 after 2 minutes (!).
Is that expected, and if so why or how can I circumvent this?
My code is simple
            app.UseRewriter(new RewriteOptions().AddRedirectToHttpsPermanent());
            app.UseStaticFiles();

            app.UseMvc();

            app.Run(async (context) =>
            {
                var request = context.Request;
                await context.Response.WriteAsync($"{request.Protocol} --- " +
                    $"{request.Method} --- " +
                    $"{request.Scheme} --- " +
                    $"{request.Host} --- " +
                    $"{request.Path} --- " +
                    $"{request.QueryString} --- " +
                    $"{request.IsHttps}");
            });

and I have enabled SSL in VS 2017 RC4
launchSettings.json
{
  "iisSettings": {
    "windowsAuthentication": false,
    "anonymousAuthentication": true,
    "iisExpress": {
      "applicationUrl": "https://localhost:44388/",
      "sslPort": 44388
    }
  },
  "profiles": {
    "IIS Express": {
      "commandName": "IISExpress",
      "launchBrowser": true,
      "environmentVariables": {
        "ASPNETCORE_ENVIRONMENT": "Development"
      }
    },
    "WebBase": {
      "commandName": "Project",
      "launchBrowser": true,
      "environmentVariables": {
        "ASPNETCORE_ENVIRONMENT": "Development"
      },
      "applicationUrl": "http://localhost:51783"
    }
  }
}

Thanks for any hint on how to proceed.

You need to give AddRedirectToHttpsPermanent the SSL port if it is not the default 443.

How do you this? The extension does not accept parameters.

https://github.com/aspnet/BasicMiddleware/blob/dev/src/Microsoft.AspNetCore.Rewrite/RewriteOptionsExtensions.cs#L115

@Tratcher , ok thanks, so you mean I should use another extension. Cheers

@Tratcher , sorry but this does not work
           app.UseRewriter(new RewriteOptions().AddRedirectToHttps(301,44388));

One of the problems with using Permanent during development is that it's heavily cached by browsers. The client is probobly still stuck using your old settings. Try Fiddler to confirm. You may need to clear your browser cache.

Done, but no luck, the browser keeps "Get (pending)"

@Tratcher , I tried again with a minimal web app, cleared cache on browsers, too, and I cannot make it work. I would appreciate if you could have a look. I basically took an empty template (1.0 and 1.1, it does not change) and added this line
app.UseRewriter(new RewriteOptions().AddRedirectToHttps(302,44388));
Fiddler returns a 504 after two minutes

@mikaelm12

@Ponant  Can you send a link to a repro app?

@mikaelm12 https://github.com/Ponant/SSLRedirect


(surge form review) Edits needed to "Evaluation Links" in case form

Inconsistency between case forms on surge and in Strong Draft 10
Case forms:
1 - Label: Evaluation Reports
Instructional text: Upload relevant documents here.
Placeholder: Upload relevant documents
2 - Label: Evaluation Links
Instructional text: evaluation_links_instructional_undefined
Placeholder evaluation_links_placeholder_undefined

Strong Draft 10
Label: Evaluation Report (appears if “yes” selected in question 4 [Formal Evaluation])
Instructional text: Upload or provide a link to the evaluation report here.
Field type A: URL
Field type B: upload from device
@plscully @jesicarson can you advise?

I believe we talked about this with @dethe and decided to make it into 2 questions, one for links, one for documents, because having them both in the same question complicated the data collection. So basically we need to write instructional text and placeholder for evaluation report docs links.
@plscully does this work:
Label - Upload Evaluation Report
Instructional - Upload the evaluation report from your device.
Placeholder - Upload from device
Label - Provide a link to Evaluation Report
Instructional - Provide a link to the evaluation report here.
Placeholder - Add a link

OR labels could be:
Evaluation Report Document
Evaluation Report Link

@jesicarson @dethe Yes, this should be divided into two questions. And I prefer the 2nd, shorter labels.


Option for keeping both normal and mini players open at the same time.

The title is pretty self explanatory,
details about my setup:
I have multiple monitors and multiple virtual desktops on W10,
one of my monitors has only stats stuff, time tracking, pc resource use , etc, I make these stick by right clicking > make this visible in all desktops (in task view), I would like to keep the mini player there for fast skipping, seeing album name/cover etc.
But I would also like to keep the main player open somewhere so that I can switch to that desktop and change the playlist without having to reorganize my windows

Check out #3701 and #701. It would be nice to get some momentum behind getting the micro player released.


Allow serialization on streams

This change allows serializing to a std::ostream and deserializaing from a std::istream. This also fixes some minor docstring issues in the C++ serialization api's.

Thanks for the review @divyegala !

Were there no changes to Python wrappers?

The python wrappers are using the c-api - so don't need updating (and the only python wrapper we have for serialization is  CAGRA which has been updated here, I'll expose the ivf-* methods in a different PR).

/merge


[SPARK-13771][SQL] Eliminate child from project if the project with no references to its child

JIRA: https://issues.apache.org/jira/browse/SPARK-13771
What changes were proposed in this pull request?
This is a corner case that a Project node can have no references to its child. E.g.,
val input = LocalRelation('key.int, 'value.string)
Project(Literal(1).as("1") :: Nil, input)

We can actually replace the input with a dummy OneRowRelation.
This PR is inspired by #11599. The test case is slightly modified from #11599 too.
How was this patch tested?
ColumnPruningSuite.

Test build #52735 has started for PR 11602 at commit 9500b46.

LGTM : )

This is an optimizable case, but I think we need a new relation that can produce n empty rows.

You are right.

Test build #52735 has finished for PR 11602 at commit 9500b46.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52735/
Test FAILed.

Merged build finished. Test FAILed.

And looks like our data source can handle this case, they will take an empty array as requestedColumns before scan the data(not verified yet).

I will change this later. Marked it as WIP now.

Rethink about this. I would like to close it for now.


Bug : Specifying initial state for ConvLSTM2D layers

I encountered an error when try to input the initial_state to the ConvLSTM2D layer.
lstm_input = Input(shape=(None,) + (32, 32, 3))
initial_state_input = Input(shape=(32, 32, 3))
x = ConvLSTM2D(128, (3,3), initial_state=initial_state_input, name='lstm')(lstm_input)

It gives me an error message: TypeError: ('Keyword argument not understood:', 'initial_state')
Probably "initial_state" has not been implemented for ConvLSTM2D layer? If so, what else method I could use to set the hidden state of the ConvLSTM2D layer? #6142
Thanks!

I looked up the code of ConvLSTM2D layer, it seems that there is no place to actually use the init_state variable, am I correct? @fchollet


Turn on network/clock tests on Windows

Issue Number

Overview

7ce72cafa07bff34c49284194625ce06a2b6b760
Turn on network/clock tests on Windows

Comments
:warning: I wasn't able to start cardano-node on Windows somehow (hanging), but verified that the netwotk/clock works on cardano-wallet-jormungnadr

bors r+

bors r+


Response Capacity vs Licenses

The explanation for response capacity vs number of licenses is confusing.   If I have 5 active Forms users, but 24,000 annual capacity is more than enough right now, does that mean we just need to purchase ONE add on with 5 licenses?  Or do we need to buy 5 add ons, one for each license, and have far more responses than we could use in a year?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1eea885c-4244-1721-36f7-6a42baca9411
Version Independent ID: 59ced40c-3cea-298e-ee4e-38c390493c59
Content: Purchase - Microsoft Forms Pro
Content Source: fp-docs/purchase.md
Service: forms-pro
GitHub Login: @sbmjais
Microsoft Alias: shjais

Hi @lundcry - We have published a document update to the response consumption - https://docs.microsoft.com/en-us/forms-pro/purchase#response-capacity-consumption. Please have a look and let us know if this helps.

Thanks for contacting us. As we haven’t heard back from you, I am closing this issue. If you need further help, please reopen the issue or open a new issue.


Ability to use the Node SDK in a browser environment

TBD

For the WM extension, we initially needed a solution to enable running the SDK in a browser environment without having to recreate all its functionalities. However, this approach has now changed. We have opted to use the SDK on a server that functions as a proxy. This server is responsible for generating HTTP signatures and forwarding requests to an ASE's authentication or resource server.
Closing this issue as not planned for now.


Bug: SRE bot timelines glitching out.

We were in an incident and I noticed the timeline generation was glitching out.
I think it started when I 💾 a message containing an image and no text.
 My guess is that it did not like me editing that section.
But maybe there is some other reason. I've removed the section from our doc for this particular incident.
I've dumped the whole section in this doc. Not sure if it might help you find a cause for the glitch.

@amazingphilippe Thanks for raising this issue!! We'll look into it shortly!


Update rollup and move to @rollup/plugin-node-resolve

rollup-plugin-node-resolve is deprecated, so switch to @rollup/plugin-node-resolve

ci failure is due to increased file size of umd bundle


Add documentation for World2

As we already do for World3, it would be good to add to the documentation the list of variables and equations of World2.

Fixed by #126


Token aware fix

We only want to select one replica from each rack to use as a potential choice for token aware routing.

We only want to select one replica from each rack to use as a potential choice for token aware routing.

I think we need more justification for this statement.
Is this what other drivers do?
Is it how cassandra token aware routing is designed to work as per some spec?
Like off the top of my head routing between multiple nodes in a single rack seems like a reasonable thing to do?

Yes the other drivers (scylla at least) will select one replica from each rack. I think it makes more sense to do that so if we don't find one in the same rack we are spreading the load better across the other racks.

How are we placed on resolving this?

Looking into this in the improved routing issue. (best of two random choices algorithm)


Missing tray menu on Linux

I'm using the app on ubuntu, installed via .deb file and I just cannot find the tray menu event selcting the app and trying to find it.
am I doing something wrong or its a bug?

Should be fixed in the version 4.0.0


pciutils: add meta.mainProgram

Signed-off-by: Christina Sørensen<EMAIL_ADDRESS>Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

The recursion should be removed in favour of finalAttrs.

Surely that's best, but a bit too much scope creep. May be better to addressed in some other PR.


Add DrawerView docs

We expose DrawerView as one of the components but it's missing in docs.

the API for this may change in the near future as we're switching over to using react-native-gesture-handler/DrawerLayout


Updating linux HW requirements

changed Ubuntu distributions to 18 and 20
added supported desktop environments and display server

@JohanFreelancer9 Copy editing is needed for this PR. Thanks.

@SerdarSoysal PR has been copyedited and is ready for final review, could you please check and merge? Thanks!


Fix new generics in Python 3.12

This PR changes how we handle TypeVars in generics to make it work in Python 3.12's new syntax 😊
I'm not 100% sure why it wasn't working before, but the issue was due to the fact that two TypeVars with the same name aren't equal:
Python 3.12.0b4 (main, Jul 12 2023, 21:58:01) [Clang 14.0.0 (clang-14<IP_ADDRESS>)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> from typing import TypeVar
>>> TypeVar("T") == TypeVar("T")
False

We weren't encountering this issue previous because we are reusing the TypeVars, but it looks like this isn't the case in Python 3.12's new syntax.
To fix this I've changed the code use the name for the TypeVar (TypeVar("T").name), which seemed to have worked 😊
TODO: I need to skip the 3.12 tests because older versions of Python aren't unable to parse the code, so they'll fail

Thanks for adding the RELEASE.md file!

Here's a preview of the changelog:

This release changes how we handle generic type vars, bringing
support to the new generic syntax in Python 3.12 (which will be out in October).
This now works:
@strawberry.type
class Edge[T]:
    cursor: strawberry.ID
    node_field: T

@strawberry.type
class Query:
    @strawberry.field
    def example(self) -> Edge[int]:
        return Edge(cursor=strawberry.ID("1"), node_field=1)

schema = strawberry.Schema(query=Query)

Here's the preview release card for twitter:

Here's the tweet text:
🆕 Release (next) is out! Thanks to @patrick91 for the PR 👏

Get it here 👉 https://github.com/strawberry-graphql/strawberry/releases/tag/(next)


RichText#to_s crashes in Ruby 2.7 for RichText objects

Because nil.to_s returns a frozen empty string in ruby 2.7: https://bugs.ruby-lang.org/issues/16150
Didn't find a way to create a spec for this I'm afraid.

Fixed in f0ed6a28dd4f5a1b39e64123be6dbfcdee439145


[cli] move cli metrics to cli crate

Overview
These metrics are in the libra-metrics crate right now.  So, I'm moving them to the CLI crate to be more relevant.  In addition, there is a metric that isn't used that was removed.

/land


Add one balloon case to check assigned memory goes down when no pressure

Add one case HotRemoveNoPressure for balloon feature, it mainly tests that  vm assigned memory could go down after sleep about 4-7 minutes without pressure, but not start the other guestB with large memory to make guestA Balloon (assigned memory goes down)
Test case steps:

Config VM as Dynamic memory enabled.
Set up the VM  Startup Memory, MinMem,MaxMem. (set Startup Memory as larger size)
Start VM , sleep about 4-7 minutes till the assigned and demand memory go down.

Expected results:
3.1. VM  assigned memory and demand memory can go down without memory pressure.
3.2. VM assigned memory does not drop lower then minimum memory
3.3. No call trace in the vm.
Thank you so much.

Will add one more case which could cover this test case, remove this pull request.


Adding new codeowners

Change-type: patch
Signed-off-by: Gareth Davies<EMAIL_ADDRESS>

This commit is intended to be used as a review of the docs process so please don't merge until this has happened.

@balena-ci retest


consistent menu presences

competitive lobbies should now show rank throughout queue/pregame states and when away instead of only when idle (plus I think it looks overall nicer)

when you had "show_rank_in_lobby" on false it crashed directly, found a lazy fix for it which works fine

will look for a better way to implement this (i dont like each presence having an if/else just for this one setting), but i like the idea

should i just edit them to just have the other changes ive made then? you can fix on top of that ig

reverted the fix, it just has the consistency edits now

closed to be remade another time


Increase timeouts for camanager test

These timeouts are incredibly aggressive and caused test flakes on my machine when testing unrelated changes.
NB: I'm not 100% confident that these tests are really useful, but rather than ripping them out it seems easier to bump the timeouts

Thanks @SgtCoDFish, let's bump the timeouts so we are not hindered in development.
I'll create an issue to track fixing the underlying issue (if any).
/approve
/lgtm


GetStorage.init Error

void main() async {
  await GetStorage.init();
  runApp(const App());
}

Error: PlatformException (PlatformException(channel-error, Unable to establish connection on channel., null, null))
get_storage: ^2.1.1
flutter doctor
[✓] Flutter (Channel stable, 3.7.10, on macOS 13.3 22E252
    darwin-arm64, locale zh-Hans-CN)
[!] Android toolchain - develop for Android devices (Android SDK
    version 33.0.2)
    ✗ cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more
      details.
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK
      licenses.
      See
      https://flutter.dev/docs/get-started/install/macos#android-setup
      for more details.
[✓] Xcode - develop for iOS and macOS (Xcode 14.3)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2022.1)
[✓] VS Code (version 1.77.1)
[✓] Connected device (3 available)
[✓] HTTP Host Availability

I'll remove the app and reinstall it，It work.

I'll remove the app and reinstall it，It work.

not working


[DOC] README.md > Harvester > Overview > ISO - link reports Page Not Found

[DOC] README.md > Harvester > Overview > ISO - link reports Page Not Found
https://github.com/harvester/harvester?tab=readme-ov-file#overview
The ISO link "https://docs.harvesterhci.io/latest/install/index" in step 1 goes to "Page Not Found".
Page Not Found
We could not find what you were looking for.

Please contact the owner of the site that linked you to the original URL and let them know their link is broken.

Hi @simonfogliato , thank you for contribution.
I think we should modify the harvester/docs instead of README in harvester/harvester. We have a redirection rule in harvester/docs. So, we probably need to add a new rule to redirect from /latest/install/index to /v1.4/install/index.
cc @bk201 @jillian-maroket, do you know why we missed adding a redirection rule  from /latest/install/index to /v1.4/install/index? I'm just curious. If you’re not certain about the reason, we can just add it back.

@Yu-Jack @bk201 Adding redirect rules wasn't part of the process that I learned during project handover. I don't edit the config file unless I'm adding a new doc version or troubleshooting search-related issues.
IMO, the harvester/harvester readme shouldn't contain information that already exists in the doc. That readme is for the repository and not the entire project.

@jillian-maroket Got it, then I think we can modify this description if we need to. We should probably also consider that some users might directly refer to this readme for installation or other usages. Alternatively, even we could remove most of content and guide users to check our documentation first.

Easy to install: Since Harvester ships as a bootable appliance image, you can install it directly on a bare metal server with the ISO(https://github.com/harvester/harvester/releases) image or automatically install it using iPXE scripts(https://docs.harvesterhci.io/latest/install/pxe-boot-install).

Thanks, @simonfogliato, the PR https://github.com/harvester/harvester/pull/7211 is merged.


Tags clickable space area fix

dev
JIRA

Main JIRA ticket

Code reviewers

[ ] @github_username

Second Level Review

[ ] @github_username

Summary of issue
ToDo
Summary of change
ToDo
Testing approach
ToDo
CHECK LIST

[ ]  СI passed
[ ]  Сode coverage >=95%
[ ]  PR is reviewed manually again (to make sure you have 100% ready code)
[ ]  All reviewers agreed to merge the PR
[ ]  I've checked new feature as logged in and logged out user if needed
[ ]  PR meets all conventions

Your slick-slide styles contributed into other sliders behaviour as well))

💀💀💀💀💀


New Example: Adjust viewer window + update viewer + save image

Description
This example creates plots in three dimensions from multiple samples.
The special thing about it:

The window will open with exact frame width and frame height and the sidepanel will always be closed, that makes these plots reproducible.
Every plot will have the same angle, same zoom level and same axes and only needs one napari viewer instance. Here is a screen recording of the script:

https://user-images.githubusercontent.com/44469195/149638466-98d57274-d163-4097-bffc-bd643f1e3d8d.mov
This can be e.g. useful when one has dozens of ct scans and wants to visualize them for a quick overview with napari but does not want to load them one by one.

Type of change

[x] New feature (non-breaking change which adds functionality)

References

Thanks to @haesleinhuepf @tlambert03  in the image.sc forum who helped me today to realize this idea!
https://forum.image.sc/t/hide-layer-controls-panel-from-python/61975
https://forum.image.sc/t/update-refresh-a-layer-in-napari-julia-napari-jl/59728/9
How has this been tested?
Runs properly with macOS, python3.8, napari 0.4.12
Final checklist:

[x] My PR is the minimum possible work for the desired functionality
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] I have added tests that prove my fix is effective or that my feature works
[x] If I included new strings, I have used trans. to make them localizable.
For more information see our translations guide.

Thanks for your review @sofroniewn !

I wonder if we can maybe shorten/ simplify the name

What about adjustwindow_updateviewer_saveimage.py -> update_viewer_loop.py ?

I also was actually unable to run this locally now - i got a vispy error

I am also not able anymore to reproduce this script, a month ago I've also posted this issue here https://forum.image.sc/t/update-refresh-a-layer-in-napari-julia-napari-jl/59728/11
Something must have changed from napari  0.4.12 to napari 0.4.15 that affects the loop_run logic, but I think I won't be able to figure that out, maybe @haesleinhuepf has some ideas there.
Two points from my side:

I just thought it's a fun script to have for reproducible batch processing, but please don't waste too much of your time into it to make it work again, I think it's also totally fine to close this pr, and the discussed points about LayerControls and positioning could be converted into issues.
For anyone who wants to go down the rabbit hole nevertheless:  Please feel free to directly commit to my branch.

RuntimeError: Cannot SIZE object 39 because it does not exist

I've seen this before, and it's one of the least useful errors out there xD Could mean anything, as far as I know :P Often it comes with more errors much higher in the traceback that are more informative. Will take a look!

I just tried locally, and everything is fine; are you sure you pulled main, and updated vispy? It might be an issue related with #4401. Try a new env!
I love this example! Shouyld we make it into a jupyter notebook as well? Cause as it is now, I only see one of the figures pop up (not super familiar with how showing figures behaves in ipython, so I might be doing something wrong...)

I just tried locally, and everything is fine; are you sure you pulled main, and updated vispy? It might be an issue related with https://github.com/napari/napari/pull/4401. Try a new env!

That's magic, just ran the example again, and it works now properly:

I love this example! Shouyld we make it into a jupyter notebook as well? Cause as it is now, I only see one of the figures pop up (not super familiar with how showing figures behaves in ipython, so I might be doing something wrong...)

That is a good idea, should I change this file to a notebook?
When running this as a python script, I also get only the figures pop up.

In the next commit, I'll change it to viewer_loop_reproducible_screenshots.ipynb now clean up the code.

You can find the rendered notebook on my branch: https://github.com/kolibril13/napari/blob/update_window_example/examples/viewer_loop_reproducible_screenshots.ipynb
At this place it's better formatted than in the code diff.

I would like to avoid committing notebooks directly, as they render poorly in diffs and are difficult to edit directly. @kolibril13 would you mind making this a MyST-nb notebook? You need to install jupytext and then follow the instructions on our contributing documentation guide.
Other than this though, I agree with the general sentiments that this is a great thing to add to our docs. My personal preference would be to use the size= preference — though I agree that wysiwyg is valuable, I don't think I want to promote private APIs in our docs. We could instead use size= for now, then make issues to create all the public APIs we need for wysiwyg, including:

viewer.window.position
viewer.controls.visible = False (for example)
viewer.layers.visible = False (for example)

But, at least the private APIs are clearly private, so I'm not too fussed.

@jni: Thanks for your suggestions!
I agree, the notebook diff looks poor, and I'll convert it to MYST-nb.
Note that there is already another notebook in the napari example folder:
https://github.com/napari/napari/blob/main/examples/notebook.ipynb , I can convert this as well and add it to this pull request.
I really like wysiwyg, therefore I will change the parameter to canvas_only=True and then remove the calls from the private API that hides the sidepannel, the size= parameter is not required then. As soon as there will probably be public APIs (I like the syntax that you suggest!)  this example can be updated.
I think I'll find some time to incorporate these changes in a few hours.

I can convert this as well and add it to this pull request.

No, it's best to keep pull requests focused on one thing. Adding extra things can trigger new discussion and block unrelated things from getting merged. Please submit a different PR for that fix, if you like. :blush:

@jni Side Note: One can have a nice diff of Jupyter notebooks in the .ipynb format in the github VSCodeview view, see
https://github.dev/napari/napari/pull/3947

Only drawback: It's not possible to add line comments there.
One issue that I can see with MyST-nb: Everyone who wants to use this notebook in Jupyter has to install jupytext as well.
Therefore: Should I still convert it to MyST-nb?

Yes, I'm happy to suggest to folks that they should install jupytext, it's an awesome library! 😃 And there are configuration options that allow people to download the ipynb from the website.

Yes, I'm happy to suggest to folks that they should install jupytext, it's an awesome library! 😃 And there are configuration options that allow people to download the ipynb from the website.

Nice, then I'll convert it to MyST-nb in a few hours! :)

@sofroniewn

I wonder how you feel about turning this into more of a how-to-guide instead of just an example?

That's a good plan but one that could easily come after merging this, since we've already spent a bunch of time iterating on this.
Having said this I also agree that, given that this is a notebook anyway, we could/should have some cells explaining what's going on. What do you think @kolibril13?

Having said this I also agree that, given that this is a notebook anyway, we could/should have some cells explaining what's going on. What do you think @kolibril13?

Good idea, I've just added some explaining lines to each cell.
@jni : In case that you find typos, or want to rephrase certain lines, feel free to directly commit your changes to this branch.

I wonder how you feel about turning this into more of a how-to-guide instead of just an example?

I think right now I'd like to just have it in the example section, just as @jni suggested.
For making it a How-To-Guide, I don't have the capacity right now, but maybe some time in future I'll come back to this.

If you've not already done so would you also mind creating a new issue with the requested public API calls and tag this PR in it.

I can take care of this!


Emigrate get ctsm instructions

New version of the get-instructions emigrated from the old template.
What do you think about #3 in the context of the given instructions?

Generally, I think this is good :)
As Stephanie already commented, there is quite a lot of platform-specifics in this documentation. As the platform is now moved and getting its own documentation, I think it might be better to make this one more general?


Internal error with emptyArrayString()

Code to reproduce is simple as:
select
  case
    when c1 = 1 then extractURLParameters(url)
    else emptyArrayString()
  end as a1
from (
    select 1 as c1, '/?t=1' as url
  union all
    select 2 as c1, '' as url
)

Expected result:
┌─a1──────┐
│ ['t=1'] │
│ []      │
└─────────┘

Actual result:
┌─a1──────┐
│ ['t=1'] │
└─────────┘
Received exception from server:
Code: 49. DB::Exception: Received from clickhouse-n1.dev:9000, <IP_ADDRESS>. DB::Exception: Internal error.

Stack trace:
0. clickhouse-server(StackTrace::StackTrace()+0x16) [0x1132036]

clickhouse-server(DB::Exception::Exception(std::string const&, int)+0x1f) [0xf293ef]
clickhouse-server(DB::Conditional::StringArrayEvaluator::perform(DB::Block&, std::vector<unsigned long, std::allocator > const&, unsigned long, DB::Conditional::NullMapBuilder&)+0xa41) [0x1e6f201]
clickhouse-server(DB::FunctionMultiIf::perform(DB::Block&, std::vector<unsigned long, std::allocator > const&, unsigned long, DB::Conditional::NullMapBuilder&)+0x73) [0x1acb113]
clickhouse-server(DB::FunctionMultiIf::executeImpl(DB::Block&, std::vector<unsigned long, std::allocator > const&, unsigned long)+0x3db) [0x1acc02b]
clickhouse-server(DB::FunctionCaseWithoutExpr::executeImpl(DB::Block&, std::vector<unsigned long, std::allocator > const&, unsigned long)+0x19)

Hi,
Which ClickHouse version do you use?
Can't reproduce for 1.1.54289 and 1.1.54292

ClickHouse server version 1.1.54164. So we need to update... ok, thank you

Just updated database and recheck -- everything seems fine.


Add dask.bag.from_castra

Allows for loading data from a castra directly into a bag, with tuples for each element.

Periodic test failure is due to https://github.com/blaze/castra/issues/44

I think this should be good to merge.

+1


Fix NPE for nonextant group show

Changes proposed in this PR

Fix bug with NPE on group show of invalid group
Add an integration test for this case

Why are we making these changes?
Apparently we have something against NPEs.

@dposada - I think this is ready to merge.


drivers: usb: add USBIP server device controller driver

Add USB device controller driver which uses USBIP protocol
for the connection to the host. The driver acts as server
and exports USB device to a virtual host controller.
This driver is based on usb_dc_native_posix driver but
uses socket and network stack implementation of Zephyr OS
and therefore not limited to native_posix platform.
usb_dc_native_posix driver will be removed in one of the
subsequent commit in favor of this driver.

outdated, I will resubmit it later for new USB controller driver API.


It is very easy to get M rank on a short level

If you take a level like "Pulling For Bones" and make it 10 seconds -- it is very easy to get "M rank" by making a box or two.
This hints at an underlying problem in the rank algorithm, either not factoring in the blocks which already exist on the level, or not factoring in the end-of-level clear bonus.

Here is the current 'pulling for bones' level I am referring to, in case it changes in the future.


Returning null in transformResponse returns request data

I'm submitting a ...

[X] bug report
[ ] feature request
[ ] other (Please do not submit support requests here (see above))

Current behavior:
This is the method in my service, returning a resource:
sendSMSOTP: {
        method: 'POST',
        url: APIBase.fetch('v1/auth/sendSMSOTP'),
        transformResponse: function (jsonData) {
          var data = null;

          try {
            data = angular.fromJson(jsonData);
          } catch (e) {
            return null;  // <-- Returning null
          }

          return data;
        }
      }

Calling the method:
AuthenticationService.sendSMSOTP({
      ssn: ctrl.credentials.ssn,
      phone: ctrl.credentials.phone,
      entryToken: ctrl.credentials.entryToken
    }, function (success) {
      console.log('success', success);
    }, function (error) {
      console.log('error', error);
    });

... returns the request data to the success (and error) callback when server returns an unexpected response not possible to parse to json, making the transformResponse method return null:
success Resource {ssn: "SSN", phone: "PHONENO", entryToken: "TOKEN", $promise: Promise, $resolved: true}$promise: Promise {$$state: {…}}$resolved: trueentryToken: "TOKEN"phone: "PHONENO"ssn: "SSN"__proto__: Object

Returning an empty object instead of null:
sendSMSOTP: {
        method: 'POST',
        url: APIBase.fetch('v1/auth/sendSMSOTP'),
        transformResponse: function (jsonData) {
          var data = null;

          try {
            data = angular.fromJson(jsonData);
          } catch (e) {
            return {};  // <-- Returning empty object
          }

          return data;
        }
      }

... returns an empty resource:
success Resource {$promise: Promise, $resolved: true}

Expected behavior:
You would expect the service method callbacks to receive an empty resource when returning null from the transformResponse, wouldn't you? Or am I not understanding something? Can't seem to find the behavior documented.
Minimal reproduction of the problem with instructions:
If this is indeed a transformResponse bug, you should be able to reproduce by just returning null from a service method:
sendSMSOTP: {
        method: 'POST',
        url: APIBase.fetch('v1/auth/sendSMSOTP'),
        transformResponse: function (jsonData) {
          return null;
        }
      }

AngularJS version: 1.6.4. Upgraded to 1.6.6, still there.
Browser:
Tested in:

Chrome 60.0.3112.101 (64-bit)
Firefox 54.0.1 (32-bit)
Firefox 55.0.2 (32-bit)
IE 11.540.15063.0
Edge 40.15063.0.0

I tried to reproduce this and couldn't. Please provide a live reproduction (e.g. using CodePen, Plnkr or similar).

That's more than strange to me. I'll come back with a plnkr as soon as I find the time. But with what you've said, I'm thinking it must be a local problem, so I'll try and spin up a brand new angularjs project to see what happens. Thanks for checking it out.

I'm going to close this issue because we have no reproduction of the issue. Feel free to reopen (or ask to reopen) this issue if you can provide a reproduction (ideally a runnable demo in a Plunker or similar. You can use this Plunker Template).


Feature detection?

Does this polyfill first check if the browser supports blend modes?
If not, would be using Modernizr feature detection for
blend mode prior to loading this polyfill a good idea?

Apparently it already checks for browser support:
https://github.com/juanbrujo/js-background-blend-mode/blob/master/src/js-background-blend-mode.js#L16


Feature/add cloudformation integration

Adds a source option to reference cloud formation outputs

:tada: This PR is included in version 1.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Removed - from petc-clinic. Added Skaffold support

Creating this PR almost as more of an FYI....so you can feel free to accept or reject.

Spring-petclinic is the name of the project, so i made that change across the repo.  Makes it more consistent and easier to extend.  The petclinic pet-clinic difference was confusing.
Added needed files to support a skaffold deployment including a skaffold.yaml file.  skaffold dev --default-repo  will sping up the mysql instances in K8s and then spin up the app.  THen, any change made to the code will cause a rebuild and repush.   Note:  This skaffold implementation also leverages Cloud Native Buildpacks to build the containers, so it's consistent with a CI/CD pipeline that leverages Build Service or Paketo.

Hey Dan, thanks for the PR, looks good.
Can you add some information to the README on how to use skaffold during development?
I will merge after SpringOne, I fear messing up @tiffanyfay's demo by mistake :)


Don't Merge! PR real time test for source branch full build

Docs Build status updates of commit 9f84f10:
:clock10: Full build: the average full build time is 7 min(s) 45 sec(s), this is based on the last 30 build(s) for this repository.

Docs Build status updates of commit 9f84f10:
:clock10: Full build: the average full build time is 7 min(s) 45 sec(s), this is based on the last 30 build(s) for this repository.

Docs Build status updates of commit 9f84f10:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docfx.json
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


 It will be really similar to the script you already wrote except it will use some existing fixtures.
PM me.

https://github.com/ApeWorX/ape/blob/a595e8fbb1e7149be16b8036f8ff7b2f9c00c4f9/src/ape/api/providers.py#L392
this line is being hit on the authentic transactions but is not being hit on the impersonated transaction.

@unparalleled-js I also need to

Looks good. Bonus if you write a test making sure we get the IndexError with the expected message when trying this using the normal test provider.
To do this, you look at tests/functions/test_accounts.py.

Grab a contract address using the contract_instance fixture
Use the test_accounts fixture to try and do the thing.
Use with pytest.raises() to verify the exception

Also double bonus if you add the strategy to the docs somewhere!

I think I can just try to send eth from vitalik's address and it will fail with the correct indexerror

@unparalleled-js it looks like that test is already there?
https://github.com/ApeWorX/ape/blob/23d68d7e882629cb6bced35a4f2805c32b981911/tests/functional/test_accounts.py#L160-L169
def test_impersonate_not_implemented(accounts):
    test_address = "0xd8dA6BF26964aF9D7eEd9e03E53415D37aA96045"
    with pytest.raises(IndexError) as err:
        _ = accounts[test_address]

    expected_err_msg = (
        "Your provider does not support impersonating accounts:\n"
        f"No account with address '{test_address}'."
    )
    assert expected_err_msg in str(err.value)

@unparalleled-js it looks like that test is already there?
https://github.com/ApeWorX/ape/blob/23d68d7e882629cb6bced35a4f2805c32b981911/tests/functional/test_accounts.py#L160-L169

I mean a test for the work done in this PR, so like:
def test_contract_as_sender_non_fork_network(contract_instance, test_accounts):
    contract.instance.transfer(test_accounts[0], "1 gwei")

or something.
Sorry, my original comment was misleading! And IDK if this test will work, but just something that at least touches the newly added code

@unparalleled-js it looks like that test is already there?
https://github.com/ApeWorX/ape/blob/23d68d7e882629cb6bced35a4f2805c32b981911/tests/functional/test_accounts.py#L160-L169

I mean a test for the work done in this PR, so like:
def test_contract_as_sender_non_fork_network(contract_instance, test_accounts):
    contract_instance.set_number(5, sender=contract_instance)

or something.
Sorry, my original comment was misleading! And IDK if this test will work, but just something that at least touches the newly added code

I was able to rework that test and get it to pass on my local machine.

Note: (Sounds like Docs update are incoming (talked elsewhere))


Add MCMCDiagnosticTools integration

This PR overloads the recommended diagnostic methods in MCMCDiagnosticTools to take Dataset and InferenceData inputs. This is implemented as a weak extension on Julia v1.9 and as a conditionally loaded module on older Julia versions.
Since these overloads are fundamental for ArviZ, it's a little awkward to bury them in an extension. Still, putting them anywhere else except MCMCDiagnosticTools would technically be type piracy. In the future it might make sense to move these to an MCMCDiagnosticTools extension.
Another bit of awkwardness is that ideally this extension would also contain a summarystats overload, whose default implementation uses MCMCDiagnosticTools, but the default also depends on an hdi function, which is not yet defined and should not live in the extension. For now summarystats will likely continue to live in ArviZ.
We could document the overloads here, but it's perhaps better to document that the overloads are made here and then actually document the overloads in ArviZ.jl itself.

Codecov Report

Merging #50 (5c7cbd0) into main (0081e84) will decrease coverage by 19.01%.
The diff coverage is 1.92%.

@@             Coverage Diff             @@
##             main      #50       +/-   ##
===========================================
- Coverage   97.08%   78.08%   -19.01%
===========================================
  Files          10       15        +5
  Lines         309      292       -17
===========================================
- Hits          300      228       -72
- Misses          9       64       +55

Impacted Files
Coverage Δ

ext/InferenceObjectsMCMCDiagnosticToolsExt/bfmi.jl
0.00% <0.00%> (ø)

...InferenceObjectsMCMCDiagnosticToolsExt/ess_rhat.jl
0.00% <0.00%> (ø)

ext/InferenceObjectsMCMCDiagnosticToolsExt/mcse.jl
0.00% <0.00%> (ø)

...xt/InferenceObjectsMCMCDiagnosticToolsExt/rstar.jl
0.00% <0.00%> (ø)

...xt/InferenceObjectsMCMCDiagnosticToolsExt/utils.jl
0.00% <0.00%> (ø)

src/InferenceObjects.jl
25.00% <0.00%> (-75.00%)
:arrow_down:

...ToolsExt/InferenceObjectsMCMCDiagnosticToolsExt.jl
100.00% <100.00%> (ø)

src/utils.jl
75.86% <0.00%> (-24.14%)
:arrow_down:

...ferenceObjectsNetCDF/src/InferenceObjectsNetCDF.jl

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


[FEAT] Support react-query's useQueries

Is your feature request related to a problem? Please describe.
Trying to implement a "number of comments for a post" column (on simple-rest data provider), I've found there is no built-in way to make multiple requests, which are more or less required for this to work (see also ReferenceManyField from react-admin). See https://discord.com/channels/837692625737613362/906206669787234334/939907409634283570 for a bit of discussion.
Describe the solution you'd like
There is a useQueries in react-admin, which seems to do what's required. It would be nice to have a wrapper of some sort -- maybe separate new hooks, maybe built-in support for arrays in useList etc.
Describe alternatives you've considered
Currently, I'm building a weird loop around dataProvider.getList (see Discord discussion), which feels very low-level and quirky.

Hey @rassie ,
The way we provide this is with the useMany hook. https://refine.dev/docs/api-references/hooks/data/useMany/
If you want to access records filter-based useList can help you. https://refine.dev/docs/api-references/hooks/data/useList/

Hey @omeraplak,
It doesn't look like the useMany hook takes advantage of useQueries, which is the recommended option to gain the benefits of React Suspense.
Here's a quote from the react-query documentation:
"When using React Query in suspense mode, this pattern of parallelism does not work, since the first query would throw a promise internally and would suspend the component before the other queries run. To get around this, you'll either need to use the useQueries hook (which is suggested) or orchestrate your own parallelism with separate components for each useQuery instance (which is lame)."
Does Refine have the ability to take advantage of Suspense?


[Delivers #163877284] Add "observation list" to README_API_HELP_MESSAGES

Commit an update to README_API_HELP_MESSAGES which update is created by the test suite.

Coverage remained the same at 91.375% when pulling 7e146f4a114459c6070adbef2df41db4bb56e070 on JoeCohen:api-obs-list-help into 23b0a40597177304d9f381f9a69ab6e22208fbeb on MushroomObserver:master.


allow commonjs as configs

Hi!
I suggest 'requiring' esdoc configuration via nodejs instead of manually parsing like it is done in webpack. This provides opportunity to specify some values in config dinamically, do some processing etc.
For example I have 'includes' and 'excludes' values configured in my build system, and i want these values imported to esdoc config.
This change does not break current json-format configurations as nodejs supports 'requiring' json out of the box as well as commonjs.

@raveclassic Hi! This is awesome changing :sparkles:
Thanks!


Fix UpdateThread exiting without stop event being set

Codecov Report

Merging #16 (6fa53fa) into master (0cb89ef) will increase coverage by 0.23%.
The diff coverage is 90.00%.

@@            Coverage Diff             @@
##           master      #16      +/-   ##
==========================================
+ Coverage   94.97%   95.21%   +0.23%
==========================================
  Files          55       55
  Lines        3784     3784
==========================================
+ Hits         3594     3603       +9
+ Misses        190      181       -9

Flag
Coverage Δ

unittests
95.21% <90.00%> (+0.23%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

calculate_anything/constants.py
92.00% <87.50%> (-0.31%)
:arrow_down:

calculate_anything/currency/service.py
90.62% <100.00%> (+5.28%)
:arrow_up:

calculate_anything/logging.py
95.76% <100.00%> (ø)

calculate_anything/currency/providers/combined.py
90.69% <0.00%> (-1.17%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cb89ef...6fa53fa. Read the comment docs.


MD029 numbers over "100"

Hi i have a problem with linting:

This happen on VSCode i havent versions but this is the only info that i have:

My guess is that whatever is on line 517 is ending the first ordered list. Text or a comment would do that.

The content in item 100 (and later) needs to be indented an additional space in order to start in the proper column. As written, it's doing the equivalent of this which ends the first list: https://markdown-it.github.io/#md3={"source"%3A"1. Text\n\n   Text\n\n2. Text\n\n  Text"%2C"defaults"%3A{"html"%3Afalse%2C"xhtmlOut"%3Afalse%2C"breaks"%3Afalse%2C"langPrefix"%3A"language-"%2C"linkify"%3Atrue%2C"typographer"%3Atrue%2C"_highlight"%3Atrue%2C"_strict"%3Afalse%2C"_view"%3A"html"}}

Uncomfortable, but pretty simple solution.
Thanks for your support @DavidAnson .
Warms!


Add permission to ReportWidgets

You should create a new permission called view_widgets => 'View dashboard widgets' instead and use that.

Alright. I created a new one: #85

You don't have to create new pull requests, you can just continue to edit on the same branch that you submitted it on and future commits will be pulled into the PR automatically


Preventing EditText to hide behind Soft Keyboard

@opticod The EditText in Launcher activity hides behind the soft keyboard if it is clicked second time i.e. after pressing the back button, if the EditText is clicked again, it hides behind the soft keyboard.
Should we handle the case?

@shikharbhuddi By launcher activity you mean the FirstRunActivity. Ryt??

@octacode Yes. FirstRunActivity.

@shikharbhuddi Refer #240

@codingblazer Thanks but I think I have figured out a solution by extending the EditText and overriding the IME key action.

@shikharbhuddi  Its already been fixed. Maybe you have not fetched recent changes. Nd btw what's IME

@codingblazer Apologies if I have not fetched the recent changes. IME: input method. The already fixed has worked upon the gravity of the widget. I am suggesting a solution by "extending the EditText and overriding the IME key action", in which case the EditText field doesn't hide behind the soft keyboard ever. Please correct me if I am wrong.

@shikharbhuddi The fix I provided also solved it completely (in every case). Actually yours solution nd mine both are just workaround because actual way of doing it is by setting inputtype in manisfest/xml.But it didn't worked  because its a bug in Android which will be solved in next android release. Please refer comments in my PR to see what is the bug.


changing buttons/options on the interface crashes the program and some are not working -Ubuntu

Spectrum does successfully scan initially once the sdr device is selected.
However, changing the settings from its user interface crashes the program on my PC
I'm running it from XUbuntu
Description:	Ubuntu 23.10
Release:	23.10
Codename:	mantic
When the program starts from a Terminal launcher on the desktop, it writes a config.csv file on the descktop.
I found, editing this file on the desktop allows Spektrum settings such as startFreq and stopFreq to be set. My copy of Spectrum appears to read successfully from config.csv file on the desktop during startup.
However. if I change a user option such as startFreq using the Spectrum graphic interface, the scanning hangs very shortly afterwards. The program is apparently looking for a config.csv file located in /usr/share/spektrum/
I suspect there is an issue about which path is used to access the config.csv
The Text is printed to the terminal window when the crash occurs is as follows.
Loading libs from /usr/share/spektrum/lib.
Library rtlsdr file /usr/share/spektrum/lib/librtlsdr.so.
Library rtlpower file /usr/share/spektrum/lib/librtlpower.so.
Generic RTL2832U OEM: 00000001
ControlP5 2.2.6 infos, comments, questions at http://www.sojamo.de/libraries/controlP5
Reached end of setup.
Loading libs from /usr/share/spektrum/lib.
Library rtlsdr file /usr/share/spektrum/lib/librtlsdr.so.
Library rtlpower file /usr/share/spektrum/lib/librtlpower.so.
Found Rafael Micro R820T tuner
File config.csv
/home/stem/Desktop/config.csv
File config.csv exists.
Reached end of makeconfig
loadConfig: Config table config.csv loaded.
startFreq = 24000000 stopFreq = 450000000 binStep = 1000 scaleMin = -60 scaleMax =  0 rfGain = 0 fullRangeMin = 24000000  fullRangeMax =<PHONE_NUMBER> ifOffset = 0 ifType = 0
"ARIAL" is not available, so another font will be used. Use PFont.list() to show available fonts.
setRange exception.
Mode: hopping
setRange: CROP set to 0.0
setRangeButton
offsetToggle
minmaxToggle
sweepToggle
rfGain
RF GAIN CLICKED
avgShow
avgSamples
refShow
refYoffset
refYoffset
perShowMaxToggle
perShowMedToggle
perShowMinToggle
ifMinusToggle
ifPlusToggle
Mode: hopping
setRange: CROP set to 0.0
Reached end of setupControls.
deviceDropdown
RESIZE DETECTED
refShow
avgShow
sweepToggle
Mode: hopping
setRange: CROP set to 0.0
resetMin
saveConfig: Active Configuration 0 with name AutoSave
java.io.FileNotFoundException: /usr/share/spektrum/config.csv (Permission denied)
at java.io.FileOutputStream.open0(Native Method)
at java.io.FileOutputStream.open(FileOutputStream.java:270)
at java.io.FileOutputStream.(FileOutputStream.java:213)
at java.io.FileOutputStream.(FileOutputStream.java:162)
at processing.core.PApplet.createOutput(PApplet.java:7674)
at processing.data.Table.save(Table.java:1175)
at processing.core.PApplet.saveTable(PApplet.java:6299)
at spektrum.saveConfigToIndx(spektrum.java:1989)
at spektrum.saveConfig(spektrum.java:1964)
at spektrum.draw(spektrum.java:1768)
at processing.core.PApplet.handleDraw(PApplet.java:2482)
at processing.awt.PSurfaceAWT$12.callDraw(PSurfaceAWT.java:1547)
at processing.core.PSurfaceNone$AnimationThread.run(PSurfaceNone.java:313)
java.lang.NullPointerException
at java.io.BufferedOutputStream.flushBuffer(BufferedOutputStream.java:82)
at java.io.BufferedOutputStream.flush(BufferedOutputStream.java:140)
at sun.nio.cs.StreamEncoder.implFlush(StreamEncoder.java:297)
at sun.nio.cs.StreamEncoder.flush(StreamEncoder.java:141)
at java.io.OutputStreamWriter.flush(OutputStreamWriter.java:229)
at java.io.PrintWriter.flush(PrintWriter.java:320)
at processing.data.Table.writeCSV(Table.java:1292)
at processing.data.Table.save(Table.java:1203)
at processing.data.Table.save(Table.java:1175)
at processing.core.PApplet.saveTable(PApplet.java:6299)
at spektrum.saveConfigToIndx(spektrum.java:1989)
at spektrum.saveConfig(spektrum.java:1964)
at spektrum.draw(spektrum.java:1768)
at processing.core.PApplet.handleDraw(PApplet.java:2482)
at processing.awt.PSurfaceAWT$12.callDraw(PSurfaceAWT.java:1547)
at processing.core.PSurfaceNone$AnimationThread.run(PSurfaceNone.java:313)
Copying the config.csv file from the desktop to  /usr/share/spektrum/ stops the program crashing but then the program still seems to use the desktop version at start up.
Thanks for all your work making this incredibly handy piece of software.

The code responsible for saving the config is all messed up - i will try to find some time to rework this in near future


remove issue template

Don't believe we need this for this particular repo?

why not? it is nice for getting keep the issues in check just in case right?

Sure let's keep in there for now

Going to remove this for now as I keep having to remove the content for each challenger.
Can always add back in later if we need it.


Duplication of fields when generating for pgx/v5

Version
1.24.0
What happened?
Multiple fields with the same name are generated
It will work correctly if you use enumerations ($1, $2, etc.) or sqlc.arg(number)
Relevant log output
type UpdateParams struct {
	Number int32
	ID     int32
	Number int32
}

Database schema
CREATE TABLE public.demo (
    id INT PRIMARY KEY,
    number integer NOT NULL
);

SQL queries
-- name: Update :one
UPDATE demo
SET number = @number
WHERE id = @id
	AND number = @number - 1
RETURNING true AS updated;

Configuration
{
  "version": "2",
  "sql": [{
    "schema": "schema.sql",
    "queries": "query.sql",
    "engine": "postgresql",
    "gen": {
      "go": {
        "out": "db",
        "sql_package": "pgx/v5"
      }
    }
  }]
}

Playground URL
https://play.sqlc.dev/p/bc917ef4b923f377b2843a77398b3245df8b2c95b8330d1dffd015d4cd355c84
What operating system are you using?
macOS
What database engines are you using?
PostgreSQL
What type of code are you generating?
Go

I looked into it, if you enclose the named parameter in () then it works.
i.e.
UPDATE demo
SET number = @number
WHERE id = @id
	AND number = (@number) - 1
RETURNING true AS updated;

it is parsing the name as -name


Track the navigation document type for all pages

Add a default value for the navigation document type, so that all pages (which include the JS from static) track the page as 'other' rather than a specific navigation type like 'guidance'.
https://trello.com/c/Tkn0P6Fm/532-track-guidance-navigation-supertype-in-google-analytics
Marked as DO NOT MERGE until we've checked that this dimension is giving us the expected results for pages which explicitly add the meta tag for navigation document types.

Vin has confirmed that the 'guidance' tracking is working as expected, so it's fine for us to merge this to add the default value.


Profiling Ajax Requests

Moin,
is it somehow possible to profile AJAX requests like domain.tld/checkout/ajaxCart or loading the emotions? When i am looking at domain.tld/profiler none of the AJAX requests is logged. Another thing is strange. There are always only 10 profiles listed. Although, according to my settings there should be up to 50 profiles.
Here are my settings:

It thought whitelisting my client's ip (in this case localhost, coz i am on my local development machine) should profile this AJAX requests, as there is no toolbar displayed, obviously.
I am using Shopware 5.4.6 and plugin version 1.3.3

Hm? In my installation the emotions are ajax requests and not sub-requests through the {action} view helper.
And what about the ajaxCart requests?

Ajax request will be shown as sub request. Currently real sub requests are not profiled.  Thanks :) Maybe renaming it would be great ;) And is it possible to link the real subrequests with the main request?

Currently not implemented. feel free to create a pull request :)

Will do when I find the time


Cannot read property 'limit' of undefined

if not exist limit in global cofig or Model Config   , show error globalOptions.limit is undefined

Hi @vgrados2,
thanks for your PR! Didn't encounter this issue yet but it sure is one.
I did some refactoring as globalOptions will hold more options in the future instead of only limit.

@vgrados2 I just released 0.9.7 to npm. ;-)


Add inverse Box-Cox transformation

Resolves #119.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

[x] Read, understood, and followed the contributing guidelines, including the relevant style guides.
[x] Read and understand the Code of Conduct.
[x] Read and understood the licensing terms.
[x] Searched for existing issues and pull requests before submitting this pull request.
[x] Filed an issue (or an issue already existed) prior to submitting this pull request.
[x] Rebased onto latest develop.
[x] Submitted against develop branch.

Description

What is the purpose of this pull request?

This pull request:

Implements the inverse of the one-parameter Box-Cox transformation.

Related Issues

Does this pull request have any related issues?

This pull request:

resolves #119

Questions

Any questions for reviewers of this pull request?

No.
Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

@stdlib-js/reviewers

@justin1dennison Awesome! I will review this shortly!

I will try to catch some of those small goofs earlier. Thanks again for the review and guidance. Let me know if there are any other changes that I should make.

@kgryte I don't know the policy on this. However, I found another typo in this package. Should I open an issue or something else? Thank you. I am having a good amount of fun working on these.

@justin1dennison Feel free to open another PR (based on the most recent develop) which fixes the typo. Thanks!
And great! We're glad that you're having a good experience. Your work is certainly helping move the project forward, and we really appreciate all your work!


Pass tokens with Catalog API requests

Refactor the frontend UI calls to the Catalog API so that it uses tokens for authN.

@SmithRWORNL has this working for the ssm-ui-ml calls to the ssm-service-catalog.
We need to do same thing for this UI for calls to ssm-service-catalog

@gecage952 I believe this issue is closed with your work from PR https://github.com/smart-spectral-matching/ssm-ui-catalog/pull/5
Do you care to confirm?
If so, feel free to close this issue.
Thanks

Yeah, I'll close this out now.


Problems about the first step of building

In the README.md file, the first step of building is to Run lrelease calendar.pro, I searched for it but I still can't figure out how to do it. Thank you!

You can just open calendar.pro with Qt Creator :)

i don't why would have such error ":-1: error: dependent '..\calendar\window.ui' does not exist."

why would have such error
1: error: dependent '..\calendar\window.ui' does not exist.
how to solve it ?  thank you @.@


Add a security-manager test/example and clean up permissions

This makes it possible to reduce the tons of permissions needed currently, and only grant them to the test jar.

By the way, I migrated all of our ES code to this snap and removed a ton of permissions and tightened the security and haven't faced any problems. In parallel ryan has done the same thing with gradle.
So I know the "example"/test is not exactly mindblowing but things do work and its simple. See you when you get back from vacation!

This looks awesome, Robert. Thanks! I spotted a few copy/paste things (Lucene in comments, etc.), but I'll clean them up later, it can go in as is.

Hmm... Java 1.6 doesn't like some of the permissions (the link one I guess).
http://builds.carrot2.org/browse/RNDTEST-SOFTWARE-JDK16-67/log
[INFO] java.security.policy: error adding Permission, java.io.FilePermission:
21-Sep-2015 13:30:39	        java.lang.IllegalArgumentException: invalid permission: read,readlink,write,delete,execute
21-Sep-2015 13:30:39	WARN: Exception at main loop level. -> java.security.AccessControlException: access denied (java.io.FilePermission /mnt/work/bamboo-home/xml-data/build-dir/RNDTEST-SOFTWARE-JDK16/examples/security-manager/target/junit4-J0-20150921_133035_792.events read)
21-Sep-2015 13:30:39	        at java.security.AccessControlContext.checkPermission(AccessControlContext.java:399)
21-Sep-2015 13:30:39	        at java.security.AccessController.checkPermission(AccessController.java:557)
21-Sep-2015 13:30:39	        at java.lang.SecurityManager.checkPermission(SecurityManager.java:549)
21-Sep-2015 13:30:39	        at java.lang.SecurityManager.checkRead(SecurityManager.java:888)
21-Sep-2015 13:30:39	        at java.io.File.isFile(File.java:837)
21-Sep-2015 13:30:39	        at com.carrotsearch.ant.tasks.junit4.slave.SlaveMain.main(SlaveMain.java:316)
21-Sep-2015 13:30:39	        at com.carrotsearch.ant.tasks.junit4.slave.SlaveMainSafe.main(SlaveMainSafe.java:10)

I'll just remove readlink, it's an example after all.

Oops, sorry about the readlink mistake!


FormatException: Unfinished UTF-8 octet sequence (at offset 1)

Exception caught by widgets library ═══════════════════════════════════
The following FormatException was thrown building SensorPage(dirty, state: _SensorPageState#0115a):
Unfinished UTF-8 octet sequence (at offset 1)
The relevant error-causing widget was
SensorPage
lib\pages\charts_page.dart:83
When the exception was thrown, this was the stack
#0      _Utf8Decoder.flush  (dart:convert/utf.dart:415:9)
#1      Utf8Decoder.convert  (dart:convert/utf.dart:330:13)
#2      Utf8Codec.decode  (dart:convert/utf.dart:61:56)
#3      _SensorPageState._dataParser
package:project/pages/datadisplay_page.dart:34
#4      _SensorPageState.build
package:project/pages/datadisplay_page.dart:64
...
════════════════════════════════════════════════════════════════════════════════

Hi @aaniish
could you provide your flutter doctor -v and a minimal complete reproducible code sample?

@aaniish
Closing as additional information isn't provided


Client-side validate for Reset password layout

Please add the validate part for Reset password layout

This issue was moved to mgm-interns/teamradio2-frontend#23

This issue was moved to mgm-interns/teamradio2-frontend#24


pull editor image from GHCR

Note that I have not tried deploying this because it looks like @hugotiburtino currently has deployed some test to safe resources that I didn't want to mess with.


Rust Wasm function table hack

I am going to try and see if I can deterministically get the same Rust function table index for two separate Wasm binaries. This would hopefully allow us to get the errors out of an init/post_upgrade.

We are not going to attempt this, instead we will wait for default cross-canister call callbacks or named callbacks


Add manage command - allow users to restart/resume/delete/update old shatter processes

Interruption

Add ability to restart/resume/delete/update previous shatter process

Alteration to shatter config

Add timestamp range for fragment searching
Add done key

If not done, add list of leaves not yet processed

Info command update

Incorporate storage.get_history() into log output, showing all shatter processes that have been run so far

Add manage command
silvimetric 'test_db' manage restart/resume/delete ${run_uuid}

Allow user to resume based on uuid from past shatter runs
Allow user to restart, will delete fragments associated with shatter uuid and then redo the process
Allow user to delete, will delete fragments associated with shatter uuid
Allow user to update values like bbox, crs, associated with shatter uuid? Will delete fragments associated with this. Or maybe user should just delete and recreate process

Addressed in #78


Force fullscreen when options.fullScreen is true

Fixes #402, as electron-window-state does not appear to remember fullscreen in all cases.

Not merging now, see comments at #402.


add possibility to extend dev container configuration to complement user or platform specific configurations

I am looking for a possibility to extend or overload a devcontainer.json file that has been added to the repository / version control.
current
Example project structure (can be replicated with the "Try a Dev Container -> Python3" command in vscode):
.
├── .devcontainer
│   └── devcontainer.json
├── .git
│   ├── FETCH_HEAD
...
├── app.py
├── requirements.txt
...

Now the actual devcontainer.json from that example looks different but to simplify, let's assume it looks like this:
{
	"name": "Python 3",
	"image": "mcr.microsoft.com/devcontainers/python:0-3.11",
	"postCreateCommand": "pip3 install -r requirements.txt"
}

This is fine so far.
Attempt
I would like to keep that configuration file. But for some dev PCs that we use, we also have GPUs available. Now when I add
"runArgs": ["--gpus", "all"],

for a PC that actually has a GPU installed, everything is fine.
But for PCs that have not, an error occurs (do not remember correctly, something about nvidia containers).
Goal / Idea
I am looking for something like a configuration that I can keep in the repository, say the above devcontainer.json file. And something like an extending file, that is additionally considered, say devcontainer.extend.json.
In the end, I would add the devcontainer.extend.json to the .gitignore so that personal, machine-dependent configurations like the "runArgs": ["--gpus", "all"] would be placed in that file.
So the devcontainer.extend.json file would contain nothing else than
"runArgs": ["--gpus", "all"],

which would be laod after the original configuration, so that it overloads the original config (in this case not exactly overloading but extending the configuration by adding another setting)
And to be complete, the full devcontainer configuration, when both files are combined, would look similar to this:
{
    "name": "Python 3",
    "image": "mcr.microsoft.com/devcontainers/python:0-3.11",
    "postCreateCommand": "pip3 install -r requirements.txt",
    "runArgs": ["--gpus", "all"]
}

and the new folder structure containing the extending file could be something like this:
.
├── .devcontainer
│   ├── devcontainer.json
│   └── devcontainer.extend.json
├── .git
│   ├── FETCH_HEAD
...
├── app.py
├── requirements.txt
...

Have you tried adding "hostRequirements": {"gpu": "optional"} to your devcontainer.json? That checks for a GPU and adds --gpu all if it finds one.


⚠ Bofrost.be has degraded performance

In 06b9ac5, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1043 ms

Resolved: Bofrost.be performance has improved in 401d872 after 7 minutes.


Update publish.yml

Codecov Report

Merging #62 (8328f3e) into master (507d6f8) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #62   +/-   ##
=========================================
  Coverage     53.84%   53.84%
  Complexity        7        7
=========================================
  Files             1        1
  Lines            13       13
  Branches          1        1
=========================================
  Hits              7        7
  Misses            3        3
  Partials          3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 507d6f8...8328f3e. Read the comment docs.


Re-introduce pytest-socket

Fixes

Fixes #342 by @AetherUnbound
Description

This PR re-introduces pytest-socket, which ensures that tests don't attempt to reach out to services via a socket unless explicitly allowed.
In attempting to uncover which tests were failing with pytest-socket, I found that the license URL validation makes a request to Creative Commons to ensure the URL is accurate. This was the cause of almost all of our external accessing and was used internally by many tests across the codebase. The only way to mock it in its current form is to auto-use a global fixture that mocks all request.get calls, which has undesirable side effects for other tests. So I opted to alias requests.get within that module specifically, which made the mock much easier to patch (even though the patch still needed to remain as a global fixture).
A few tests required specific care:

The Smithsonian unit code test was making a request to the Smithsonian API that was immediately return with an invalid API key error :joy: Since we don't really care what the response is, I mocked this one.
The single run external DAG sensor test was emitting a warning that had nothing to do with any code we had written and everything to do with Airflow internals. I suppressed that warning for now so we can have cleaner test output.

In addition to making sure our tests don't rely on any external services, a fun side-effect of this is that our tests are now slightly faster!
Testing Instructions

You'll need to rebuild the container in order to test with this new dependency:

just build
just test

Checklist

[x] My pull request has a descriptive title (not a vague title like Update index.md).
[x] My pull request targets the default branch of the repository (main) or a parent feature branch.
[x] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[x] I added or updated tests for the changes I made (if applicable).
[x] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

I'm working on addressing the CI failures. It turns out that:

Docker will use different internal ports depending on what's available on the machine
Boto3 will open a socket with the IP address directly rather than the hostname, for some reason
Trying to get the host from the hostname dynamically isn't working with our S3 bucket fixture

Ah, okay, here's why: https://github.com/pytest-dev/pytest/issues/1368 :upside_down_face:


Added command to spectate on player index

Useful when player entity index is known, e.g. when game is controlled
remotely.

I see you've introduced a command with the same name, I can rename this command and push a new version. Maybe ce_cameratools_spec_entindex?


attendance one key and many values

pairs=[{'ad': 'q_topic_1', 'pos_hist': 'm_interested_topics'},
{'ad': 'q_topic_2', 'pos_hist': 'm_interested_topics'},
{'ad': 'q_topic_3', 'pos_hist': 'm_interested_topics'},
{'ad': 'q_topic_4', 'pos_hist': 'm_interested_topics'},
{'ad': 'q_topic_5', 'pos_hist': 'm_interested_topics'}
],

Thank you very much. I will consider your request this week!

@liuchenailq
Could you give more info about why do you need such feature. What is the situation? If you
can give an example data set, it is very helpful.
From your example, the attention score of m_interested_topics seems need to be summarized
using avg func. Is it right?

thanks very much.
in my scene, a user have some topics, a goods have some topics. So I want to the attention score of goods topics in every user topics.
for example. user have topics [T1, T2, T3], goods have topics [T10, T11, T14]. I want to do
pairs=[{'ad': 'T1', 'pos_hist': 'goods_topics'},
{'ad': 'T2', 'pos_hist': 'goods_topics'},
{'ad': 'T3', 'pos_hist': 'goods_topics'},
],
thanks again