Add support for phpunit testing in Drupal 8

We need to support PHPUnit testing for Drupal 8.

Is PHPUnit unnecessarily slow with grunt or virtual environments?
How can we allow running phpunit for just some packages while also making grunt test run all the tests?

Original Post
On a freshly built GDT project, running the PHPunit tests often takes over a minute, even though there are no tests defined. I suspect that PHPUnit may be unnecessarily scanning folders besides "modules/custom". I tried to alter this behavior by configuring phpunit.xml.dist, but to no effect.
I also see this note from @jhedstrom on #121. I tried using that command to run PHPUnit tests, but got errors related to Simpletest module not being installed.
I should also note that my project runs on Docker containers on a Phase2 devtools managed VM, so perhaps the virtualization could be part of the root issue here.

The slowdown is related to using NFS within the P2 devtools docker container.  It's very possible that there is still a fix to be made to PHPUnit to help with this (similar to recent fixes in Drush and Drupal/core), but the ultimate solution with the P2 devtools is to move away from NFS.
I don't see anything specific that GDT itself is doing that would cause this.

I'm no expert on file systems, but I do know that we moved towards NFS because it was incredibly more stable than what we were using before (vboxFS)


Force headless display

Force the setup of a headless display to allow CI tests to run properly, due to failures on Ubuntu previously.

OK, weird - thanks for trying!


Update markdown documentation and close #23

This adjusts the whole-repo documentation to be up-to-date for subsequent PRs on specific process steps.
This PR closes #23 .

This PR closes #23 .

Thanks!


__dirname is not defined in ES module scope

I am trying to deploy Zen Engine in Typescript Node.js Lambda using ES Modules deployed via Typescript CDK utilizing ESBuild. I am able to deploy the lambda, but get "__dirname is not defined in ES module scope" error upon initialization. How do I address this?
Let me know if you need more details or context.

This might be related to: https://github.com/napi-rs/napi-rs/issues/1948. For now, would you be able to use webpack instead?
If you've managed to find a solution, would you be able to write it down so that we may document it somewhere. Thanks!

Hi @vincent-musto, have you figured out the solution?

@stefan-gorules - I have not found a solution, but a workaround: I have added @gorules/zen-engine and @gorules/zen-engine-linux-x64-gnu to a Lambda Layer, which is attached to the Lambda where I am using the Zen Engine. This avoids the bundling process and allows me to make @gorules/zen-engine and @gorules/zen-engine-linux-x64-gnu External Modules. It has been working fine without much extra overhead, though it would be preferable to remove the Lambda Layer in the future.

@vincent-musto this is how I got __dirname to work, but only on my local machine.
import path from "node:path";
import { fileURLToPath } from "url";

const __filename = fileURLToPath(import.meta.url);
const __dirname = path.dirname(__filename);
const dataRoot = path.join(__dirname, "internal/rater/rules");


BUG: Contact Us page UI issue

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
The contact us form not very user friendly right now with no proper input boxes getting displayed.
Only the place holders are getting displayed but not the input boxes as such. It looks like text on the website and doesn't give any UI experience of the form

i would like to restructure the ui to get a more better form filling experience for the user.
I am a GSSOC'24 contributor , please assign me this issue so i can start the UI design
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

@anuragverma108 please assign me this issue

I am a GSSOC contributor, I humbly request you to please assign this issue to me.

I would like to work on this issue. Pls assign me this !


import data from own data lost some data

I have some shp data. in order to import them to postgre db and use the work flow of osm2vectortiles I transfer the shp data into bj_min.pbf which in the Attach files named bj_min.txt(to use it please rename it to .pbf)
bj_min.txt  <----here's the test data.
This data contains 28 features(ways). the correct display of the data like the picture below

But when I import the data with the osm2vectortiles workflow it display like the picture below

so I checked the database and found there are only 18 features in the osm_road table. what confuse me is the tags of the way which map the ways to osm_road table are the same why lost 10 features.
Could you try my test data?  which in the attach files? or just tell me how should I check the workflow.
Thank you!

That must be something in imposm3 mapping - you could change the mapping.yml to accept all road tags for starting (https://imposm.org/docs/imposm3/latest/mapping.html):
Something like this..
tables:
  highway_linestring:
    type: linestring
    fields:
    - name: osm_id
      type: id
    - name: geometry
      type: geometry
    - name: highway
      key: highway
      type: string
    - key: oneway
      name: oneway
      type: direction
    - key: layer
      name: layer
      type: integer
    - name: z_order
      type: wayzorder
    - key: tunnel
      name: is_tunnel
      type: bool
    - key: bridge
      name: is_bridge
      type: bool
    - key: name
      name: name
      type: string
    - name: name_en
      key: name:en
      type: string
    mapping:
      highway:
      - __any__

I have some shp data.
shp data into bj_min.pbf

if i understand you correctly

you can import    shp to postgresql with  a simple tool, not need to convert to PBF

see code importing water_polygons.shp:  osm2vectortiles/src/import-external/import-water.sh

if i understand you correctly

Ah yes thanks @ImreSamu. So happy to have you helping on the issues :) ❤


How to sample from latent distribution

Hello,
I was wondering how I can generate samples using the decoder network after training. In a VAE, I would just sample from the prior distribution z~N(0,1) and generate a data point using the decoder. In TriangularSylvesterVAE, however, I also have to provide hyperparameters lambda(x) that depend on the input. How can I sample from my latent distribution and generate samples from it?
I am new to normalizing flows in general and would appreciate any help.

I think you can sample from z from N(0, 1) then decode z. The prior distribution is still N(0, 1). The KL in the code is calculated by sampling, because there is closed-form KL when normalizing flow posterior is introduced.
    # ln p(z_k)  (not averaged)
    log_p_zk = log_normal_standard(z_k, dim=1)
    # ln q(z_0)  (not averaged)
    log_q_z0 = log_normal_diag(z_0, mean=z_mu, log_var=z_var.log(), dim=1)
    # N E_q0[ ln q(z_0) - ln p(z_k) ]
    summed_logs = torch.sum(log_q_z0 - log_p_zk)

    # sum over batches
    summed_ldj = torch.sum(ldj)

    # ldj = N E_q_z0[\sum_k log |det dz_k/dz_k-1| ]
    kl = (summed_logs - summed_ldj)

ln p(z_k) is calculated from N(0, 1). The prior is N(0, 1).

I am also curious about this.

Just as in a regular VAE, the latent distribution is conditional on the input. Given an input x, you would obtain a mu and sigma from the encoder, and then draw samples from this latent distribution and feed them through the decoder.
It sounds like what you want is an unconditional prior p(z), which is not possible for a flow-based VAE unless you also define a prior on the flow parameters.


--bail does not work

Do you want to request a feature or report a bug?
bug
What is the current behavior?
All tests are run even though --bail was used.
What is the expected behavior?
No other tests should be run after an error.
See https://github.com/julien-f/issue-jest-bail
Environment
My system is Debian Stretch.
> npm version
{ npm: '4.0.5',
  ares: '1.10.1-DEV',
  http_parser: '2.7.0',
  icu: '57.1',
  modules: '48',
  node: '6.9.4',
  openssl: '1.0.2j',
  uv: '1.9.1',
  v8: '5.1.281.89',
  zlib: '1.2.8' }

Running Jest with --bail will prevent other test suites from executing.
In your case there's only 1 test suite (1 file), that's why it checks all other cases.
@cpojer I think we should stress this better in the documentation, right?

Oh, I see, thanks for the info :)

I have jest v 18.1.0 and have --bail on the command line and "bail":true in my package.json, and Jest still runs all the tests in all the files.

This should be fixed in master, we fixed yet another issue with bail.

Actually, I just realized that this was because a script in my "setupFiles" had an error. It looks like if a test suite fails to run, that doesn't trigger the "bail" and it moves on to the next suite (which will re-run the "setupFiles" scripts and fail for the same reason...)

is there any way to skip current describe and all nested describe on first failure but still run other describes? Like bail-describe for example.

According to documentation https://jestjs.io/docs/en/api#describename-fn, a describe is a test suite.
But --bail is not really working when first test suite fails.
Is there a reason this is still closed?

I'm hitting the same issue. Also, should coverage still be running on a bail? I'd think it'd just halt everything

Maybe, for clarity, we can rename --bail to --politely-back-away-while-still-executing-most-things-people-will-expect-to-not-execute-upon-failure


feat: force retrain

feature: force retrain

Closing this as there are other caveats too include this.


vcmi: 1.6.0 -> 1.6.1

Changes: https://github.com/vcmi/vcmi/releases/tag/1.6.1

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 368753

x86_64-linux

:white_check_mark: 1 package built:

vcmi


autocomplete does not show columns list until i type a character matching the column name

select * from dbo.customers c
where c.
If i try autocomplete on this, it wont show anything.  Not until i type 'f' does it show autocomplete list matching columns that contain 'F'.   i don't usually remember column names that why i refer to this tool to give me a list.

Yes, it is a bug in completion proposals filtering. Thanks for the bug report.


support multiple sub for load balance

as an admin, i would like to have multiple sub instances to register targets from different servers.

giave each sub instance a name
support load balance for sub instances with the same name, round robin, hash, ...
support request with specifiying sub instance

1st and 3rd item: d4a61d5dd2ef525820895424d7bce167df93ccd7
will think about 2nd


Implement backend functionality for rate/buy/... workflows

[x] add rate Facet
[ ] define rate message content -> structure is already implemented in branch "feat_detailstruct_review" but not merged yet due to some picker value update issues
[ ] enable forwarding of messages to other connections

[x] add forward field to message
[x] forward message in node
[ ] add forward authorization grant/revoke by owner
[ ] adapt agreement protocol: forwards can only propose and claim
[x] adapt agreement protocol: add claim

the authorization is not necessary for a POC, the restriction for injects/forwards either. We'll do that later


Is it possible to configure 0pdd bot to fetch issue from all branches (not just master)?

As of now @0pdd creates issues only from the puzzles found in the master branch. I would like it to create issues from all branches.
This would be useful in the following scenario:

Create a puzzle in code.
Commit and push it to a new branch.
Write the code that closes the created issue.
Remove the puzzle from code.
Commit the code (the issue will be closed by the bot).
Merge the created branch with the master branch.
Delete the created branch.

How would it be possible to make @0pdd work in the described fashion?

@yegor256 please, pay attention to this issue

I have moved this issue to the 0pdd repo.
https://github.com/yegor256/0pdd/issues/97

Oops! Job gh:yegor256/pdd#72 was not in scope


support text-only input with llama3.2-11b

This PR enables llama3.2-11b model with text-only input.
Note that this PR is only for CLI pipeline. Will have a separate PR for openai-api update
(torchchat-test) [gasoonjia@server ~/torchchat-32mm (main|REBASE-i|main)]$ python torchchat.py generate llama3.2-11B --prompt "How are you these days"
Using device=cuda NVIDIA PG509-210
Loading model...
Time to load model: 8.88 seconds
-----------------------------------------------------------
How are you these daysI'm just a computer program, so I don't have feelings or emotions like humans do, but thanks for asking! I'm functioning properly and ready to assist with any questions or tasks you may have. How about you? How's your day going?
========================================

      Average tokens/sec (total): 11.66
Average tokens/sec (first token): 1.82
Average tokens/sec (next tokens): 13.04

You can also check for multimodal content like this so you don't have to check the model type explicitly:
https://github.com/pytorch/torchtune/blob/7da96d18dbddbfcf77e045fe149b1efb6866681d/recipes/dev/generate_v2.py#L123

@joecummings thanks for your suggestions!
Just curious how do you guys handle the mismatch between input and model requirements? Like when user forward an image input into a single-modality model?

The failing test is not relevant. Pushing through


"x-www-form-urlencoded" to "json" conversion middleware for gorouter

I am currently working on porting a "x-www-form-urlencoded" to "json" conversion middleware for gorouter: https://github.com/mar1n3r0/go-json-rest-middleware-formjson.
I will open a separate topic about that if you don't mind and think that it will be of significant use to the boilerplate overall.
Originally posted by @mar1n3r0 in https://github.com/vardius/go-api-boilerplate/pull/58#issuecomment-597015340

#60

we should rename it from internal to pkg then
also what do you think if we refactor RespondJSONError a little bit ?
maybe we should make handlers return errors and then handle that error ? I don't know how it would work with router yet or if its good solution ? What do you think ?

Shouldn't this be called somehow differently ? https://github.com/mar1n3r0/gorouter-middleware-formjson/blob/23077ef237c30909047406e789d35af985d8e718/formjson.go#L22
Its more like it does toJson or even multipartFormToJson

https://github.com/vardius/go-api-boilerplate/pull/60#discussion_r391585556

we should rename it from internal to pkg then
also what do you think if we refactor RespondJSONError a little bit ?
maybe we should make handlers return errors and then handle that error ? I don't know how it would work with router yet or if its good solution ? What do you think ?

I think it serves it purpose well for internal CLI error reporting. No complaints about that. For command payload response though I am replacing it with native e.ErrorMessage() since this is the response to the client.

Shouldn't this be called somehow differently ? https://github.com/mar1n3r0/gorouter-middleware-formjson/blob/23077ef237c30909047406e789d35af985d8e718/formjson.go#L22
Its more like it does toJson or even multipartFormToJson

The middleware doesn't handdle multipart as of yet, only urlencoded. Multipart can not be converted to JSON  as it is a blog and depends on the purpose of the whole application so it would be hard to boilerplate that.
multipart-requests-in-go

Multipart form data
Normally, when a form is submitted through the browser, it will use application/x-www-form-urlencoded content-type, which is just a list of keys and values. This is not for uploading files and therefore, that’s where multipart/form-data content-type comes in.

We can create pkg directory and move stuff that can be reused there from https://github.com/vardius/go-api-boilerplate/tree/master/internal
in a new pull request
maybe all of them could be reused ? then we just rename dir ?

For command payload response though I am replacing it with native e.ErrorMessage() since this is the response to the client.

maybe should push that ?

We can create pkg directory and move stuff that can be reused there from https://github.com/vardius/go-api-boilerplate/tree/master/internal
in a new pull request
maybe all of them could be reused ? then we just rename dir ?

That should be the way to go.

For command payload response though I am replacing it with native e.ErrorMessage() since this is the response to the client.

I will try to cherry pick that.

maybe should push that ?

That should be the way to go.
do you want to create a pr for it ?

or if you want me to do it I can do it over the weekend

I will create a PR for it no worries.

Merged


fix rationale introspective explainer visualization issue with bert tokenizer

fix rationale introspective explainer visualization issue with bert tokenizer

Fix looks correct for the start/end, the bug should be left open for the ... characters I think.
Minor styling comment otherwise LGTM

LGTM and I agree with @eedeleon  and @janhavi13.


Fix setting up test connection on iOS 8 simulators

Fix #263
Please let me know if I can improve something. Please see also my comments in #263 about the retrying strategy of Xcode. Once you "listen" to the XPC communication, you'll notice that Xcode is also just trying different methods and ignoring errors.

@plu can you rebase on master and re-try. @marekcirkos recently pushed some commits that fixes the state change for the legacy protocol.

Did a rebase and added some test, so we notice when test execution would break on iOS 8. What @marekcirkos did only fixes part of the issue. You can try executing testInjectsApplicationTestIntoSampleAppOnIOS81Simulator from f877e5d without the changes I did in  d370c69 - it will fail. Only after applying d370c69 it passes. The older Simulator runtime expects _IDE_beginSessionWithIdentifier instead of _IDE_initiateSessionWithIdentifier . We also need to change the early returns in case of an error and just log the error instead.

Cool. We didn't intend to support versions pre iOS 8.0. It is cool ti works with so simple change.

@facebook-github-bot shipit

Thanks for importing. If you are an FB employee go to Phabricator to review.

Thank you for the review & merge!


Unify dialog CRUD on shell action center.

Is your feature request related to a problem? Please describe.
Part of #2312 , to support dialog-driven lg/lu resource maintains. this issue focus on dialog  CRUD interface design.

Describe the solution you'd like

Describe alternatives you've considered

Additional context

Dialog CRUD interface
By splitting dialog operation from one saveData method to servral part. Delta data on dialog change and change type can be traced, operations on related lg/lu resource would be possiable.
Current visual editor handler crud logic exist on file
'Composer/packages/extensions/visual-designer/src/utils/jsonTracker.ts'
we can leverage it and move some implementation to shell dialog action center.
Add
/**

@param id, dialogId, 'addtodo'
@param path, add JsonPath, 'triggers[0].actions[0]'
@paran data, add data, ' {...} '
*/
add(id, path, data) {}

Delete
/**

@param id, dialogId, 'addtodo'
@param path, add JsonPath, 'triggers[0].actions[0]'
*/
delete(id, path) {}

Update
/**

@param id, dialogId, 'addtodo'
@param path, update JsonPath, 'triggers[0].actions[0].activity'
@paran data, update data, '${Hi}'
*/

update(id, path, data) {}
Cut
/**

@param from, {id, path}
@param to, {id, path}

Cut is kind move, move in one dialog or cross dialogs.
One solution is implement it as delete + add.
*/

cut(from, to) {}
Copy
/**

@param id
@param path

Copy is the pre-action of Paste.
One solution is implement it as a get method, return raw data.
if we take this solution, then the copy can have very wide entry, such as copy from a textEditor

Anoter implementation is after get raw data, make some modify, let the paste data be valid. e.g dereference lg, re-generate uniq id.
*/

copy(id, path) {}
Paste
/**

@param id
@param path
@param data

Paste is the post-action of Copy.
The limitation is the Paste data must be vaild, or can convert to be valid.

if we do nothing on data, it act as an add
if the incoming data is raw, we need dereference lg, re-generate uniq id
if the incomming data contains helper property, let's say '_lu', '_lg' (maked up when a copy happen), we need cut this property.
*/

paste(id, path, data) {}

if we keep use saveData, the delta data can be calculated by a JsonDiff method, it works for Add/Delete/Update

It's good to see, we can separate the dialog operation discussion from how dialog\lg\lu work together.
Talking about this specific issue, i get the benefits from have a fine grained dialog API, it would help clarify the change type, perhaps also make undo\redo easier, basically when your interface is more fine-grained, you will have more controls.
But like you also mentioned, it's not the only way to do that, a "json diff" is also a valid approach, and i will prefer "json diff", because of the benefits on architecture wide.
A fine-grained API for dialog operations is creating a new abstraction on top of json file, that all editors will work on. Which

adds one more layer
this layer's position is actually not clear, as you can see in your proposal, it's somewhere between json editing and bot editing
even we somehow be able to find a good position between json<-> bot, this layer will not as stable or json or as bot, in which any editor will have to learn the concepts in this layer

All i listed above are what i called "architectural cost", and this type of cost is usually huge as it may look like now.
Think of if our editor and our shell is only talking through a "saveData" api (which we can expand the json to be a virtual json which joined dialog, lg, lu data).
If the protocol is simple as json editing, it will be very easy to replace or add an json editor than give direct manipulation to json.
I will probably start draft a design doc about how can unify all opertaion and side effects in one plain saveData api, you can continue refine the API design here to a state you feel comfortable, we can compare those two approach's pros and cons then.

addressed in #2718

No longer valid since we handle qna/lu/lg separately


Fix typo wrong language specified

Or maybe it is a wrong link?

@vkaytsanov : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Problems with 434Mhz

Hi!
First, thank you for share!
you did a wonderfull work!
Can you help me with a issue?
For some reason the project don´t work with 434Mhz!!
I have a RF stick (EZRadio 4455Cled-434) in 434 Mhz and like to test it with your Project and my zeta (ZETA-1 ver B).
I read this info from ZETA:
Read IT status:
Chip rev: 17 ,      Part    : 21828    ,  PBuild  : 0 ,      ID      : 3328, Customer: 0,       Rom ID  : 3    ,      Bond    : 0, Rev Ext   : 3 ,       Rev Branch: 0 ,     Rev Int   : 13,   Patch     : 0, Func      : 1 ,        SVN Flags : 0  ,     SVN Rev   :<PHONE_NUMBER>
I believe it´s about config file.... can you help?
I attached the config file to this post.
Thanks in advance.
Besta regards,
Regis
radio_config_fixed_434.zip

Try first hardcoding the required config file instead of relying on compile-time definitions,
edit ZetaRF.cpp and replace  lines 15-30 fom
#ifdef VARIABLE_LENGTH_ON
#ifdef ZETARF_FREQUENCY_433MHZ
    #include "configs/radio_config_vl_crc_pre10_sync4_pay8_433mhz.h"
#else
    #include "configs/radio_config_vl_crc_pre10_sync4_pay8.h"
#endif
    #warning Using variable length packets
#else
// Fixed size packet
#ifdef ZETARF_FREQUENCY_433MHZ
    #include "configs/radio_config_fixed_crc_pre10_sync4_pay8_433mhz.h"
#else
    #include "configs/radio_config_fixed_crc_pre10_sync4_pay8.h"
#endif
#endif

with just the config definition you need e.g. for 433mhz fixed length, try
 #include "configs/radio_config_fixed_crc_pre10_sync4_pay8_433mhz.h"
I presume your config file is created using SiLabs WDStool? If not, then use this tool, load a suitable XML config definition supplied in this repository, then change just the frequency and make a new config header.

Hi,
You can read part details so the issue certainly comes from your config file.
You can try first with the default 433MHz config. Then to get to 434MHz, juste use channel 4... (channels are 250kHz apart).
Or, as @beinnlora said, use one of the 433MHz XML files with WDS and change your settings as needed (careful the lib may not support everything). If both modules have the same config, it should work. begin() returns false if the init failed (can be a debug check for custom configs).

THANK YOU!!!!

HI!
I received some data, only this:
CRC Error
Invalid Preamble
Detected Preamble
Detected Sync
Read IT status
Could you give some directions?
Perhaps I need to work more on config file!

I find the problem!
The word size was not 16, need to be 8!
But a only received "> ⸮⸮⸮⸮⸮⸮⸮⸮⸮⸮⸮⸮⸮⸮⸮⸮" form EzRadio.
It´s normal?!

Are you using the default 433MHz config?

I believe so!
I am use "si4455_revb1_bidir_fixed_crc_pre10_sync4_pay8_433mhz" file that comming with LIB.

But did you use the default header (#include "configs/radio_config_fixed_crc_pre10_sync4_pay8_433mhz.h") and/or the #define ZETARF_FREQUENCY_433MHZ 1 to load the default 433MHz header config?
Or did you used the XML file to create your own config header? If so, I suggest starting as I suggested in my first comment (using the default config).

I follow your suggestion and change the ZetaRF.CPP, as you describe in your first post.
I will double check my project!

I double check all firmware and connections, but I just can't listen the message from EZRadio stick ... :-(

What is your hardware setup? Can you try with two EZRadio sticks, or two Zeta? To be sure that the firmware is working ok.

I have two EZRadio sticks, and they work perfectly.
But I can get communication with ZETA...

Both have a SI4455 chip? Which revision? (Different revisions may need other settings. Print part info for both modules and compare.)
Do you have two Zeta modules to try?
Both modules have a similar antenna? (same polarisation, etc)
I can't really help more than giving you some "clues" to look for, I don't own any 433MHz module. But if the firmware and chips are the same for both EZRadio stick and the Zeta, it should work.
If the revisions are different, you need to cross-check with WDS to get the same config on both modules.

you are a genius!!!  "...Which revision? " ... that's it!!
the zeta is B1 and EZradio is C2.
It's alive, doctor!!  It's alive......
THANK YOU!!!

But... when I send something from ZETA to EZRadio The arduino freezes .... :-(
Any suggestions?

Did you changed something on the config then?
What code are you using? The provided example? Which "side" freeze ?

Yes I change the config. I use WDS to generate a config file compatible with Demo APP "Bidirectional packet". Now I can listen all communication between two EZRadios. But when I send something the code freezes with no response on "zeta.sendPacket((const uint8_t*)data);  // Use channel set with begin()" from your code.
I do not change your code, only the channel to 0. : " zeta.begin(0, ZETARF_PACKET_LENGTH);"

You're not very clear.
Listen & send between two EZRadio works, right?
EZRadio (send) to Zeta (receive) works?
Zeta (send) to EZRadio (receive), Zeta freeze?

Sorry ....
Listen & send between two EZRadio works, right?  Yes,no issues with this.
EZRadio (send) to Zeta (receive) works? Yes, I can read the transmission no matter wich EZRadios transmit.
Zeta (send) to EZRadio (receive), Zeta freeze? YES, this is the problem!

Ok, thanks.
With the Zeta, you're using the default config header provided with the repo, right? Your config for the EZRadio will not work with the Zeta (different chip revision). You're not very clear either with what you did with the config ;)
You need to keep the default Zeta config, and create a new config with WDS for your EZRadio that match the settings of the default 433MHz Zeta XML: load the provided XML with the B2 revision, then load the same XML but with a C2 revision, then compare both configs and make changes on the C2 revision to match settings.
You can also check what changed in the C2 revision.

OK! I will make this verification.
Thanks!

Ok, let me know how it goes. It will be useful for others using later revisions too.

I verify all code without note any difference.
I decided come back to original version.
The result was the same.... this is the results:
Starting Zeta TxRx...
Chip rev: 17
Part    : 21828
PBuild  : 0
ID      : 3328
Init done.
Type AAA and hit "enter"
Sending >aaa
<
.... NOTHING after this point
May be the ZETA is defective?

New result....
with: "wwwwwwwwwwwwwwwwwwwww"
I get this:
Sending >wwwwwwwwwwwwwww
<
msg transmitted
Sending >
<
then freezes again...

When the sending worked, did you received anything on the receiver?
About the freeze, I would say wrong config... you can enable debug by uncommenting the line "#define ZETARF_DEBUG_VERBOSE_ON" in ZetaRF.h, and maybe add debug in the sendPacket() method to check where it stalls exactly. That would help isolate the issue.
There are checks to avoid stalling but it seems like I missed one at least.

OK! I will proceed with tests...

Before freezes I received:
<Read IT status
Invalid Preamble

Add some debug in sendPacket method, something like:
`void ZetaRF::sendPacket(uint8_t channel, const uint8_t *data, uint8_t length)
{
if (!data || length == 0) return;
// Read ITs, clear pending ones
readInterruptStatus(0, 0, 0);
if (m_systemError) return;

Serial.println("check state");
// Wait when not ready
DeviceState s = deviceState();
uint16_t counter = 0xF000;  // Avoid stalling
do {
    --counter;
    s = deviceState();
} while ((s == Tx || s == TxTune) &&
         counter > 0);

Serial.print("state: ");
Serial.print(s);
Serial.print(" / ");
Serial.println("counter");

if (counter == 0)
    return;

Serial.println("write tx");
// Fill the TX fifo with data
writeTxFifo(data, length);

Serial.println("start tx");
// Start sending packet on channel, return to RX after transmit
startTx(channel, 0x80, length);

}`

I will....and post results as soon as possible.
TkS!

HI! Its working!!!
You will not  believe .... I'm so stupid!!
I was using 5V to Arduino and 3.2V for ZETA, because we can't program arduino with 3,2V.
A decide try a change, and apply 3.2V on Arduino...BANG!!!  WORKS like a charm.
Probably some problem with logic levels conversion.
Thank you for the support, and congrats for the code!!!
Best regards,
Regis

Hi, glad you solved the problem! :)
I'll add a warning in the readme about that.
Thanks,
Best regards,
Benjamin

Hi, Benjamin !
I moving forward to a next phase in my project and decide to use a more powerful microcontroller.
I will use a PIC24. Now I will try to port your library to PIC - 'C'.
Do you have any tips and recomendations or "perhaps" an "PIC version" of your code?
Could you help me? Please!
Thank you in advance!
Best regards,
Regis

Hi Regis,
I don't have any advice to give you, and I don't have a C version of the lib. I almost exclusively use C++ and I avoid PICs so I can't help you. You can maybe use the codebase of the Wireless Development Suite, this lib is based on that. Or adapt this lib, whichever you prefer. You'll have to adapt SPI, GPIOs, delays, and maybe some C++ stuff.
Good luck!

Hi, Benjamin ! I hope this message finds you well and happy!
I successful finished that project . THANK YOU!
And ... start a new one!
Do you have any ideas about why an arduino nano + zeta clone (revC1) freezes after 8 minutes of normal operation?
Tks!

Hi Regis ! Nice, great to hear :) I guess you successfully ported the lib to your PIC?
The freeze could come from a lot of things... memory leaks might be one. If it's linked to the Zeta, it may be due to the module resetting or getting non-responsive and failing to communicate, usually caused by power supply issues (the lib times out after a too many tries and sets an error you can get via systemError(). Try calling begin() again in that case).
In any case, try to isolate the problem by removing code gradually ;)

... I guess you successfully ported the lib to your PIC?

Actualy... not! I am add another MCU (328P) to the project, than work like a charm.
I will try call "begin" when freezes using the watch dog and make a deep code study at same.
I will keep you informed about my progress.
Thank you!

@regisaabdalla  Arduino Nanos get their  3.3v via the USB chip - which for cheap clones is a CH340 chip, which are rated to supply just 12mA @ 3.3v. (see https://cdn.sparkfun.com/datasheets/Dev/Arduino/Other/CH340DS1.PDF)
The Zeta module uses 10mA at RX standby, and between 18 and 30mA during TX.
Depending on your duty cycle, you could easily be overstressing the 3.3V supply from the Arduino, which over time cuts out fromoverheating.
You can't really reliably power a Zeta from the 3.3v rail from a Nano. Use a separate 3.3v regulator such as LM1117-3.3

Very good point!!! It Will make the modificativos André repeat the teste.
Thank You!!
Em seg, 2 de jul de 2018 18:39, beinnlora<EMAIL_ADDRESS>escreveu:

@regisaabdalla https://github.com/regisaabdalla Arduino Nanos get their
3.3v via the USB chip - which for cheap clones is a CH340 chip, which are
rated to supply just 12mA @ 3.3v. (see
https://cdn.sparkfun.com/datasheets/Dev/Arduino/Other/CH340DS1.PDF)
The Zeta module uses 10mA at RX standby, and between 18 and 30mA during TX.
Depending on your duty cycle, you could easily be overstressing the 3.3V
supply from the Arduino, which over time cuts out fromoverheating.
You can't really reliably power a Zeta from the 3.3v rail from a Nano. Use
a separate 3.3v regulator such as LM1117-3.3
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/GIPdA/ZetaRF/issues/3#issuecomment-401946110, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AfNOqjk-FONuSG3UrvGilTlXWXG7u72Oks5uCpMugaJpZM4S2UPI
.


Glitchy dark mode

Microsoft PowerToys version
0.63
Installation method
Microsoft Store
Running as admin
No
Area(s) with issue?
General
Steps to reproduce
switched themeto dark mode and its glitchy
✔ Expected Behavior
not glitchy
❌ Actual Behavior
glitchy
Other Software
No response

Hello and thanks for your message. First I can say is that version 0.67 is the latest. Please update and let us know if that does it. If not - could you be a bit more specific on the area?

closing due to inactivity


Add cqlparser crate implemented by nom

So far only implements select and even then still doesnt have full coverage of select.
However it does implement enough demonstrate the feasibility of writing a parser like this.
Some background on parsers
This PR uses nom which is a parser combinator library for rust.
That means it provides a whole bunch of composable functions to easily construct your own parser.
nom is designed around binary protocols but also happens to work well enough for simple programming languages. (I'm considering CQL a simple programming language)
Parser combinators are known to fall short when building a full general purpose programming language because you want more precise control over parsing mostly for error generating reasonable error messages.
However for our use case I think parser combinators should be more than enough.
Error reporting
I am proposing that when given a bad query we just fail parsing with a generic error message.
I do like me some useful errors but in this case for simpler implementation and better performance I think it makes sense for shotover to just say "query {} failed to parse" and leave it at that.
We can of course reevaluate this in the future.
Especially once we have something in place, it will be easier to evaluate the affect on performance of improving the diagnostics.
If we want to go all out in terms of error reporting we can use something like https://github.com/zesterer/chumsky instead of nom
Bytes
I attempted to rewrite the parser in its current state to store Strings as Bytes however this unexpectedly reduced performance by 4x. There might be a way to get parsing with Bytes working performantly but for now I would focus on just using allocating types and then we can investigate a rewrite later if it turns up in benchmarks.
Just a draft
This PR is not to say that this is the way we should do things, its just a draft and one that I only spent a few days on. So im happy for this to go in a completely different direction if we find a better direction.
If we decide this is a good direction and we want to start collaborating on this code then we can land as is and start iterating on it.

Nice! But I'd put it in a separate crate. Someone else will definitely find it useful and it's pretty decoupled from Shotover.

Nice! But I'd put it in a separate crate/repo. Someone else will definitely find it useful and it's pretty decoupled from Shotover.

That is definitely an endgoal!
I think we can iterate on using it in shotover faster if we keep it in the same repo for now and then move to a separate repo when its "finished"

This is now being tracked by https://github.com/shotover/shotover-proxy/pull/542


Error when implementing DKImagePickerControllerDefaultUIDelegate protocol

I am trying to create a CustomUIDelegate class which implements a DKImagePickerControllerDefaultUIDelegate like the following code:
class ImagePickerCustomUIDelegate: DKImagePickerControllerDefaultUIDelegate {

    override func imagePickerControllerCheckedImageTintColor() -> UIColor? {
        return UIColor.black
    }
}

Before adding that code, the project was compiling normally and the basic example of DKImagePickerController was working. After that, I started getting the following error when trying to build:
"direct field offset for DKImagePickerController.DKImagePickerControllerDefaultUIDelegate.(doneButton.storage in _05C026158387582BAD923CF0457DA1FC) : __ObjC.UIButton?", referenced from:
DKImagePickerController.DKImagePickerControllerDefaultUIDelegate.doneButton.setter : __ObjC.UIButton in ViewController.o
DKImagePickerController.DKImagePickerControllerDefaultUIDelegate.(doneButton.materializeForSet : __ObjC.UIButton).(closure #1) in ViewController.o
I am using Carthage and I think maybe it may be related to that, anyone knows anything about this error?

Hi @thacilima
I've updated the code to remove the lazy properties.
Could you please check now using develop branch?
github "zhangao0086/DKImagePickerController" "develop"

@zhangao0086 Now it's working!


Fix 116 - Remove Code Duplication

Don't merge yet, not done. I created this just to have a look.

Ok, this part is done now. Can merge now.

Fixing #116

Ok there are some quite significant problems regarding the error message here. I will fix this.

The error messages have been fixed. I also discovered the problem with one of the previously closed issues. We will need to update documentation.


Should we break before every association in a proxy chain?

So I have the following Ruby code:
  user.created_assets(:asset).optional(:categories, :category).pluck('asset.title', 'collect(category.name)')

Which generates the following Cypher:
  MATCH
    user4865,
    user4865-[rel1:`CREATED`]->(asset:`Asset`)
  OPTIONAL MATCH asset-[has_category_rel:`HAS_CATEGORY`]->(category:`Category`)
  WHERE (ID(user4865) = {ID_user4865})
  RETURN
    asset.title,
    collect(category.name)

Neo4j actually returns all assets and their categories in this case rather than limiting by the user.  I'm not sure if this is a bug in Neo4j, but maybe we should break between each association?  I've made the two small changes and it seems to fix the problem

Closing now that we have #890 890


Double Prompt

This is great little tool that just works. My issue is largely cosmetic. When I create a new shell, I get a double prompt that looks like this.
[user@host ~]$ (environ)[user@host ~]$
Any idea why?

@creese doing some cleanup and I'm going to close this. While I agree it's an annoyance, I don't think it's possible to fix it, as I explained above. Let me know if you have any more questions or ideas!


Scrolling trigged by vertical double finger swipe on Macbook is override

My HTML is

And the Javascript code is:
var carousel;
        $(document).ready(function () {

            carousel = $("#frame ul");

            carousel.itemslide({
                disable_scroll: false,
            }); //initialize itemslide

            $(window).resize(function () {
                carousel.reload();

            }); //Recalculate width and center positions and sizes when window is resized
        });

But no matter what direction I do the double finger swipe, the  will slide. The default scrolling action for div#content is override.

Well you can disable mousewheel sliding on the carousel using the options so that it wont override the default scrolling.

Thanks @nir9 ! But I did not find any options related in the doc: http://itemslide.github.io/docs/. Could you please shed some lights?

You can disable mousewheel sliding using the option disable_scroll

It worked, thanks! The wording in the doc is a bit confusing though. I created a PR to improve the doc here: https://github.com/itemslide/itemslide.github.io/pull/31. Please take a look if that helps.


[e2e]: generic workflow_dispatch branch1 default slsa3

Repo: https://github.com/slsa-framework/example-package/tree/branch1
Run: https://github.com/slsa-framework/example-package/actions/runs/10626095951
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.generic.workflow_dispatch.branch1.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.generic.workflow_dispatch.branch1.default.slsa3.yml
Trigger: workflow_dispatch
Branch: branch1
Date: Fri Aug 30 03:06:45 UTC 2024

Repo: https://github.com/slsa-framework/example-package/tree/branch1
Run: https://github.com/slsa-framework/example-package/actions/runs/10641898853
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.generic.workflow_dispatch.branch1.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.generic.workflow_dispatch.branch1.default.slsa3.yml
Trigger: workflow_dispatch
Branch: branch1
Date: Sat Aug 31 03:07:03 UTC 2024
Tests are passing now. Closing this issue.


Trying to get this to work

Hi @nick-young-gs . @nickyoung-github  I'm trying to get this to generate header files from my pydantic class..  Here's the cmake
cmake_minimum_required(VERSION 3.9)
project(mdata_model)

set(CMAKE_CXX_STANDARD 20)

find_package(Python3 REQUIRED COMPONENTS Interpreter Development)
find_package(pydantic_bind REQUIRED COMPONENTS HINTS "${Python3_SITELIB}")

pydantic_bind_add_package(./)

Here's the error
  10:30 ❯ cmake .
CMake Error at CMakeLists.txt:7 (find_package):
  Could not find a package configuration file provided by "pydantic_bind"
  with any of the following names:

    pydantic_bindConfig.cmake
    pydantic_bind-config.cmake

  Add the installation prefix of "pydantic_bind" to CMAKE_PREFIX_PATH or set
  "pydantic_bind_DIR" to a directory containing one of the above files.  If
  "pydantic_bind" provides a separate development package or SDK, be sure it
  has been installed.

I think you'll need to give it the package root like this:
cmake_minimum_required(VERSION 3.9)
project(fin_data_model)
set(CMAKE_CXX_STANDARD 20)
find_package(Python3 REQUIRED COMPONENTS Interpreter Development)
find_package(pydantic_bind REQUIRED COMPONENTS HINTS "${Python3_SITELIB}")
pydantic_bind_add_package(fin_data_model/v1)
This is how I had it working for this package: https://github.com/nickyoung-github/fin-data-model
(and sorry for missing this question!)


[REVIEW] FIX Install sphinxcontrib-moderncmakedomain in docs script

Installs the pip only package sphinxcontrib-moderncmakedomain using the build script. This dependency is missing in our docker images but also has no conda equivalent currently so we aren't adding it to our docs conda meta package.
If this package is ever added to conda in the future this should be removed and added to rapids-doc-env meta.yaml here: https://github.com/rapidsai/integration/blob/branch-21.10/conda/recipes/rapids-doc-env/meta.yaml

CI failure looks like a problem on the gpuCI side. I don't believe this repo has a python build, just a gpu build.

@dillon-cullinan Is this ready to be merged?

rerun tests

@gpucibot merge


Cleanup tree

Hello @Yomguithereal. Im looking best way to reset all keys in tree to {}. Need your help.

Hello @markuplab. If what you want is to reset the tree completely, you can do tree.set({}). If what you want is to reset every leaf key to {}, then you'll have to create a recursive function that will set the keys one by one, as with a basic JavaScript object.


add plug-in interface

Following use-case:
I'm totally unsatisfied with the feeds provided by GitHub. I've checked their API documentation and I can get nearly every information that I would expect to be available as feed from the API. Even caching headers are supported.
Since this is a special purpose use-case, it's nothing that should be included into miniflux.
What I need for that particular plug-in, are possibilities to:

store plugin configuration
display plugin configurations options within the preferences
trigger for specific events, with the possibility to prevent the default action (here beforeCatchFeed)

Such a plug-in interface could be used for the image proxy (maybe as reference implementation) as well. This would require a onDisplay trigger.
Feature requests like #253 (Possibilities to define filters to mark articles as read) or #254 (Scoring and Starring) could be realized as plug-ins as well.
To deal with plug-in translations and database schema changes of the plug-in store/table could be tricky.
I open this issue as feature request, since I've zero to minimal knowledge regarding plug-in interfaces.

There is maybe another way to do that quickly, it's just an idea, you can generate your own rss feed from the github api, then use this feed through miniflux.
In the same approach, there is many tools that generate a feed from Twitter or Facebook.
Same for #253, pipe your feed through a custom filter: curl http://myfeed | ./my-feed-filter > feed-cleaned.xml.
For the plugins stuff, usually there are hooks/events in the main application, you can alter the content, add content or just listen on events etc...
And for the schema migration, each plugin have a version number, each time you upgrade the plugin you execute a new migration/function, so the plugin db schema version doesn't conflict with the app schema version. Plugin options can be stored in a separate key/value table.
But many changes will be needed to implements that in Miniflux. I started a prototype a while ago but never finish it, since I dropped the branch...

I've found your old commit in a fork: https://github.com/fguillot/miniflux/commit/f230f5166f4ecff9db4eb894afcc7d46357a1e90. May I will create something outside of miniflux first, to see what kind of hooks/events are really needed.
I'm unsure if I'm the right person to write such a plugin interface. I don't have the required knowledge in software designing/architecting.

I'm closing this ticket, after all this time nothing happened.


Reduce document id size from 64bits to 32bits

This is another step towards improving the performances and disk space usage of MeiliSearch.

Yeah, I understand that consfusion, I will introduce the function you propose, that is easier to use!
I was using this DiscoverIds Iterator because this code is a port from the daugt codebase and daugt only support CSVs with unknown length, therefore the function you propose would have been useless.

In fact, no, I will not add this fn discover_internal_ids(len: usize) -> Vec<Id> method that we talk about, this DiscoverIds struct is easy enough to use and help us keep good performances by not searching for too much ids that will not be used (when you replace many documents which already have ids).
I keep it like that, the DiscoverIds Iterator is used in only one place, so... Not that hard to understad how its used.

@MarinPostma Yeah, sorry I already updated all of those lines and changed the user_ids into external_docids it is clear and fits really good! Thank you, but you didn't had to make it yourself :)


runtime: stack traces do not indicate the caller for deferred calls

The stack trace in https://build.golang.org/log/ee6465ff7dc022b6679688af37b7b40211d8521c seems to omit an important line number from the stack trace. It appears to be reporting a panic within a deferred function call.
The start of the call to the deferred function occurs at line 1129:
https://github.com/golang/go/blob/8a5a6f46dc51597174d0044dcd3bdffa950ae65e/src/testing/testing.go#L1129
The parentheses that actually invoke it are at line 1233:
https://github.com/golang/go/blob/8a5a6f46dc51597174d0044dcd3bdffa950ae65e/src/testing/testing.go#L1233
However, neither of those lines is included in any of the frames in the stack trace:
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0x5e2520]

goroutine 3241 [running]:
panic({0x6470a0, 0x7f5d60})
	/tmp/workdir-host-solaris-oracle-amd64-oraclerel/go/src/runtime/panic.go:1147 +0x465 fp=0xc00089f938 sp=0xc00089f860 pc=0x43bba5
testing.tRunner.func1.2({0x6470a0, 0x7f5d60})
	/tmp/workdir-host-solaris-oracle-amd64-oraclerel/go/src/testing/testing.go:1192 +0x339 fp=0xc00089f9f8 sp=0xc00089f938 pc=0x4e1859
testing.tRunner.func1(0xc000291a00)
	/tmp/workdir-host-solaris-oracle-amd64-oraclerel/go/src/testing/testing.go:1195 +0x256 fp=0xc00089faf0 sp=0xc00089f9f8 pc=0x4e1116
runtime.call16(0x0, 0x685890, 0xc000286318, 0x8, 0x8, 0x8, 0xc00089fb40)
	/tmp/workdir-host-solaris-oracle-amd64-oraclerel/go/src/runtime/asm_amd64.s:625 +0x49 fp=0xc00089fb10 sp=0xc00089faf0 pc=0x470289
runtime.reflectcallSave(0xc00089fc68, 0x685890, 0xc000286318, 0x8)
	/tmp/workdir-host-solaris-oracle-amd64-oraclerel/go/src/runtime/panic.go:927 +0xb5 fp=0xc00089fb50 sp=0xc00089fb10 pc=0x43b6f5
runtime.runOpenDeferFrame(0xc0004969c0, 0xc0002862d0)
	/tmp/workdir-host-solaris-oracle-amd64-oraclerel/go/src/runtime/panic.go:891 +0x2bb fp=0xc00089fbd8 sp=0xc00089fb50 pc=0x43b01b
panic({0x6470a0, 0x7f5d60})
	/tmp/workdir-host-solaris-oracle-amd64-oraclerel/go/src/runtime/panic.go:1038 +0x25b fp=0xc00089fcb0 sp=0xc00089fbd8 pc=0x43b99b
runtime.panicmem(...)
	/tmp/workdir-host-solaris-oracle-amd64-oraclerel/go/src/runtime/panic.go:221
runtime.sigpanic()
	/tmp/workdir-host-solaris-oracle-amd64-oraclerel/go/src/runtime/signal_unix.go:735 +0x40e fp=0xc00089fd10 sp=0xc00089fcb0 pc=0x45412e
net.TestUnixAndUnixpacketServer(0xc000291a00)
	/tmp/workdir-host-solaris-oracle-amd64-oraclerel/go/src/net/server_test.go:191 +0xae0 fp=0xc00089ff80 sp=0xc00089fd10 pc=0x5e2520
testing.tRunner(0xc000291a00, 0x684fc0)
	/tmp/workdir-host-solaris-oracle-amd64-oraclerel/go/src/testing/testing.go:1242 +0x102 fp=0xc00089ffd0 sp=0xc00089ff80 pc=0x4e0de2
runtime.goexit()
	/tmp/workdir-host-solaris-oracle-amd64-oraclerel/go/src/runtime/asm_amd64.s:1581 +0x1 fp=0xc00089ffd8 sp=0xc00089ffd0 pc=0x472061
created by testing.(*T).Run
	/tmp/workdir-host-solaris-oracle-amd64-oraclerel/go/src/testing/testing.go:1289 +0x3ab

The non-GOTRACEBACK=system stack trace for this panic is the one found in #34611, I think.

For an illustration of why this matters, consider a user debugging a function that defers multiple calls to the same function (https://play.golang.org/p/Ws12WDC1KuI). Without the stack traces to thread the calls together, it can be much harder to figure out the actual sequence of calls that lead to the panic.

Thinking about this some more...
go and defer share the property of executing the function call non-locally.
For go calls, we have created by lines in the stack trace. Maybe we should have deferred by lines too.
Perhaps:
testing.tRunner.func1
	testing/testing.go:1195
deferred by testing.tRunner
	testing/testing.go:1233
panic
	runtime/panic.go:…
net.TestUnixAndUnixpacketServer
	net/server_test.go
testing.tRunner
	testing/testing.go:1235
created by testing.(*T).Run
	testing/testing.go:1280

Another example in https://build.golang.org/log/1a19e22ad826bedeb5a939c6130f368f9979208a:
panic: close of closed channel

goroutine 476 [running]:
runtime.Goexit()
	C:/workdir/go/src/runtime/panic.go:482 +0x190
testing.(*common).FailNow(0x4000234820)
	C:/workdir/go/src/testing/testing.go:864 +0x48
testing.(*common).Fatalf(0x4000234820, {0x7ff6a835e0c5?, 0x0?}, {0x400033be80?, 0xeda0b3426?, 0x0?})
	C:/workdir/go/src/testing/testing.go:948 +0x64
golang.org/x/crypto/acme/autocert.TestRenewFromCacheAlreadyRenewed.func2(0x2f3c74aa43a?, {0x7ff6a83f1b28?, 0x40001e1740?})
	C:/workdir/gopath/src/golang.org/x/crypto/acme/autocert/renewal_test.go:208 +0x634
golang.org/x/crypto/acme/autocert.(*domainRenewal).renew(0x400011a680)
	C:/workdir/gopath/src/golang.org/x/crypto/acme/autocert/renewal.go:71 +0x1e0
created by time.goFunc
	C:/workdir/go/src/time/sleep.go:176 +0x3c

The top of that goroutine dump is the runtime's own call to runOpenDeferFrame:
https://cs.opensource.google/go/go/+/master:src/runtime/panic.go;l=482;drc=2580d0e08d5e9f979b943758d3c49877fb2324cb
The first frame in actual user code is here:
https://cs.opensource.google/go/x/crypto/+/master:acme/autocert/renewal_test.go;l=208;drc=198e4374d7ed0909af956c010c19ee6bae6a1bc9
But the code at that line does not match the panic message at all. The actual panic is likely from this line:
https://cs.opensource.google/go/x/crypto/+/master:acme/autocert/renewal_test.go;l=166;drc=198e4374d7ed0909af956c010c19ee6bae6a1bc9
which doesn't show up in the stack trace at all.


List the PackageIdentifier of the package to be added to automation
gerardog.gsudo
Details about the application
https://github.com/gerardog/gsudo
I know you are already automating it, but if you wish I can ask him to use winget-releaser

I'm creating a new issue and will post PackageIdentifier and issue URL there. Separate issues for each package will be difficult to track.


Error "Could not send chat". (Mac 16 Intel)

hi! before writing, I looked at all the errors that may be related, completely reinstalled the repository twice, tried what they offer in different messages, but the error remained.I don't have a red Api or other, I wrote everything I need to write in .env files, but the error remains.
Mac, Intel iCore 5, 16Gb, Macos ventura 13.4

Duplicate of #47 - moving conversation there


Assist creating PVC for workspaces [WIP]

Fix: #414

Codecov Report

Merging #426 into master will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #426      +/-   ##
==========================================
+ Coverage   74.46%   74.54%   +0.07%
==========================================
  Files          60       60
  Lines        3913     3913
  Branches      711      711
==========================================
+ Hits         2914     2917       +3
+ Misses        999      996       -3

Impacted Files
Coverage Δ

src/tekton/addtrigger.ts
82.67% <0.00%> (+2.36%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4c8e7b...8d35979. Read the comment docs.


Improvement subject area rest resources

I added request methods for getGlossaryCategories, getGlossaryTerms, getCategoryTerms.

The grade build is failing after the version bump. It is not due to this pr. I have now disabled the mandatory nature of the check and will look at resolving. . The best push or update should be fine. Apologies

@immmus I hope to review this tomorrow

I assume you are looking to do the Client library, FVT and the glossary author View services changes for these APIs in a separate issue.
I have raised the issue that there are no paging options, It would make sense to add paging options to all the get relationship methods.

I can add the Client library and FVT to this pr after review API. Okay?

I can add the Client library and FVT to this pr after review API. Okay?
@immmus Yes of course

@davidradl javadocs changed

I do not think that we should add new APIs, when we know they should have paging. I think the paging options should be added in this pr, so that we do not have 2 versions of the API in the code base, one with and one without paging.

Yes I  am work about it

@davidradl I am wait this merge pr #3493

Hi @immmus, I am wondering when you are thinking of getting to this. If you are not likely to get to this soon - I could finish this for you.

@davidradl I am wait this merge pr #3493

Hi @immmus, I am wondering when you are thinking of getting to this. If you are not likely to get to this soon - I could finish this for you.

Hi! Yes) I unfortunately very busy now...

@immmus OK I am taking over this pr .

@immmus Trying to develop on this pr hasled to my ide becoming corrupted - which took hours to recover. I am going to do this in another pr.

I am using this issue to extend the existing APIs to allow objects to see their "children" or "parents", this includes

terms to return their categorizing categories
glossaries to return their categories, with a flag to return only categories without parents.
glossaries to return their terms
categories to return their children categories
projects to return their terms.
categories to return their terms
The above APIs return multiple artifacts, so these APS need to be paged. Paging in the subject area was incorrectly implemented, it should not be hard coded, server side is should pick up the configured server maxPagesize in the absence of a page size being requested.
Also the InvalidParameterHandler already has standard logic for validating page sizes, this can be used client side and server side. I propose to use this checking.
This means page size could be null meaning pick up the default ( from the server config)
The date was being serialised as a Date object - this can be problematic - I have changed the subject areas Dates to be longs - so they serialise more simply.

I have extended these APIs to the client and added FVTs to test them. I have also added view services for them

I have created another pr to address this issue - which should address the review comments. https://github.com/odpi/egeria/pull/3906


Antvel eCommerce built in laravel 5

This needs to be added under the Codebases for Reference section - https://github.com/chiraggude/awesome-laravel#codebases-for-reference

ok, let me do it. Thanks!


Verify if the current version is the latest when starting up.

Something like:
A new release of action-server is available: 2.40.1 → 2.42.1
To upgrade, run: ...

Note: need to detect how it was installed to provide instructions on how to upgrade.

@fabioz Do we have any resources or indications on how the action-server is installed? 🤔
The action-server can be just an executable which can be downloaded, right? That means we might not be able to detect any installation pattern.

Right now the action server executable (the main one) is a go-program which extracts the actual action server to a given folder and runs it.
I think this would be the best place to tackle that.
@bogdancondurache did the work on that part and he can probably explain better than me.

@fabioz Should this incorporate a question to the user if they want an update and do that for them? 🤔
Not sure what the suggestion should be otherwise. They would need to manually download the executable and place it in the correct paths in order to work. Feels a bit more intuitive to have an auto-updater at user's approval.

@custompointofview I would advise against it. They don’t need to place it in path, they download the go-wrapper and that’s the one doing that. But the problem is the go wrapper would need to download the newer version including itself (in case any logic has been updated there) and replace itself with the new binary, calling that one. I think that’s valuable, but maybe at the moment it’s enough just to let the user know there’s a newer version

Sure. I can only suggest that there is a new version. Still feels a bit like incomplete DX.
The wrapper indeed does the copying, but in the issue the suggestion is that the user should do a specific action and my question was "what would that action be?". As such, I can also add as a suggestion to the user that they can download the executable from this URL based on their platform and run it. Would that suffice for now?


fixed #4259

PR Description 📜
text was not visible in light mode
Fixes #4259

Mark the task you have completed ✅

[x] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[x] I have added screenshot for website preview in assets/images
[x] I have added entries for my game in main README.md
[x] I have added README.md in my folder
[x] I have added working video of the game in README.md (optional)
[x] I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸
before:

after:

Thank you soo much for contributing to our repository 💗

Thank you @dnyandeepchute ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

@kunjgit it was a bug, please review it.

@kunjgit please merge this, thank you.

done please check.

@ishita-43 it was for level3, is it??

@ishita-43 it was for level3, is it??

If its the case we place bugs removal in level1

Thank you  @dnyandeepchute , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀


SMT32: incorrect internal temperature value

Describe the bug
Fix the internal temperature sensor value (Die temp) incorrect when reading internal  temperature from ADC.
This ticket is to fix the incorrect temperature sensor (Die temp) value in the ADC device-tree node for the stm32 series below:

stm32U5
stm32L1
stm32L4
stm32F3
stm32WL

Acquired values seems inconsistent and not compatible. Example for the WL, here is the required configuration of the ADC and the die temp nodes:
	   adc1: adc@40012400 {
		compatible = "st,stm32-adc";
		reg = <0x40012400 0x400>;
		clocks = <&rcc STM32_CLOCK_BUS_APB2 0x00000200>;
		interrupts = <18 0>;
		status = "disabled";
		vref-mv = <3300>;
		#io-channel-cells = <1>;
		has-temp-channel;
		has-vref-channel;
	  };

      die_temp: dietemp {
	compatible = "st,stm32-temp-cal";
	ts-cal1-addr = <0x1FFF75A8>;
	ts-cal2-addr = <0x1FFF75C8>;
	ts-cal1-temp = <30>;
	ts-cal2-temp = <130>;
	ts-cal-vrefanalog = <3300>;
	io-channels = <&adc1 12>;
	status = "disabled";
       };

On running sample we get:
*** Booting Zephyr OS build zephyr-v3.1.0-4551-g411079cf1d88  ***
STM32 Die temperature sensor test
Current temperature: -171.1 �°C
Current temperature: -171.1 �°C
Current temperature: -170.4 �°C
Current temperature: -171.1 �°C
To Reproduce

west build -p auto -b nucleo_wl55jc samples/sensor/stm32_temp_sensor/
west flash
see error

Logs and console output
see description
Environment (please complete the following information):

OS: linux
Toolchain Toolchain Zephry SDK 0.15.0
latest main

Removing STM32WL as this is specific. See #49897

Regarding the stm32F3 disco.
The mcu is stm32F303VCT6 which refman is RM0316 Rev 8.0  and product spec is DS9118 Rev 14


feat: handle bun projects in apheleia-npx

The apheleia-npx script now checks for bun projects and handles them correctly by using the installed bun bin exec the command.

Not sure why the formatter test is failing, as this change shouldn't have any impact on previous formatters.
Would it be useful for me to add in a test case here for bun?

Could be that a newer version of Prettier formats differently by default, breaking the test, or a bug in Prettier being able to find configuration files correctly. Probably the former. I can look into it in a bit.
A new test would be great although the test framework might need to be tweaked a bit to write a good test for this. That is also something I can look at in a bit.
Or you can have a go if you feel up to it earlier.


BUG - Accounts dropdown functionality is incomplete

As implemented:

As designed:

Missing:

Connect multiple accounts
Disconnect single account
Disconnect all accounts
Link to view single account

Dropdown icon is also wrong.

Reference open issue: https://github.com/telosnetwork/open-block-explorer/issues/70


New version: AIHelpMe v0.3.0

Registering package: AIHelpMe
Repository: https://github.com/svilupp/AIHelpMe.jl
Created by: @svilupp
Version: v0.3.0
Commit: a482da0e4f6f17514b7d27ef24cc94fb603fe73b
Reviewed by: @svilupp
Reference: https://github.com/svilupp/AIHelpMe.jl/commit/a482da0e4f6f17514b7d27ef24cc94fb603fe73b#commitcomment-145491234
Description: Harnessing Julia's Rich Documentation for Tailored AI-Assisted Coding Guidance
Release notes:

### Added (thanks to [Splendidbug](https://github.com/splendidbug)!)
- New knowledge packs created by Splendidbug using `DocsScraper.jl` (to be registered soon, created as part of Google Summer of Code).
- Knowledge packs for JuliaData org (DataFrames.jl), Plots org, and SciML org.
- Refreshed knowledge packs for Makie org and Tidier org.
- Golden Q&A sets for new packages to evaluate performance.

### Changed
- Changed default chunk size to 384 based on evaluation results.
- Increased compatibility for PromptingTools to v0.50, enabling the use of the latest chat models.
- Changed const-Ref variables to typed globals to prevent issues encountered in PromptingTools.

### Removed
- Legacy pack "juliaextra".

### Fixed
- Issues related to const-Ref variables by switching to typed globals.
- Fixed `:gold` pipeline inconsistently updating the embedding dimension

### Notes
- The new knowledge packs are currently available only for the OpenAI Text embedding Large 3 model.
- Latest chat models can now be used, but embedding models are restricted for prebuilt knowledge packs.

### Commits

Stop the release


Port forwards don't work

If I try to add a new port forward, it isn't added.
I have to add manually the new port forward editing /etc/config/firewall file.
Test:
config redirect
    option src 'wan'
    option src_dport '777'
    option dest 'lan'
    option dest_ip '<IP_ADDRESS>'
    option name 'testportforward'
    option proto 'tcp'
    option dest_port '777'

Model: BT Home Hub 5A
Firmware Version: LEDE Reboot SNAPSHOT r4426-80d9ec5 / LuCI Master (git-17.174.41033-de2e92a)
Kernel Version	4.4.71

Make sure to use the add button next to the input field row.


Unused parameters warning while reproducing the results

Getting the following warning during training:
[W reducer.cpp:1050] Warning: find_unused_parameters=True was specified in DDP constructor, but did not find any unused parameters. This flag results in an extra traversal of the autograd graph every iteration, which can adversely affect performance. If your model indeed never has any unused parameters, consider turning this flag off. Note that this warning may be a false positive your model has flow control causing later iterations to have unused parameters. (function operator())
is file reducer.cpp a part of back-end network and how to access and modify it ?

Thanks for pointing it out! This flag is used to debug our old codebase, but may not be useful in the current GitHub cleaned codebase. Feel free to turn it off if it hurts performance.


ci: call lightwalletd wallet queries

Motivation
We need to call the tests from #3655 in CI, using the lightwalletd cached state from #4165.
(PR #4267 already added the tests from #3512.)

@gustavovalverde I re-opened this ticket, because we still need to call the lightwalletd_wallet_grpc_tests in CI.


Visual Studio Issue

I have a problem with visual studio 2017 15.3.3 version.
I am trying to use core 2.0 version of this project. clonned and
if i run with F5 then works well, dotnet run works well,
but if i use right click wwwroot and select Wiev In Browser kestrel gives some error that  i could not solve.
Equinox.UI.Site> Now listening on: http://localhost:18888
Equinox.UI.Site> Application started. Press Ctrl+C to shut down.
Equinox.UI.Site> info: Microsoft.AspNetCore.Server.Kestrel[17]
Equinox.UI.Site>       Connection id "0HL7PLV6P81VF" bad request data: "Malformed request: invalid headers."
Equinox.UI.Site> Microsoft.AspNetCore.Server.Kestrel.Core.BadHttpRequestException: Malformed request: invalid headers.
Equinox.UI.Site>    at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.Frame1.<ProcessRequestsAsync>d__2.MoveNext() Equinox.UI.Site> info: Microsoft.AspNetCore.Server.Kestrel[17] Equinox.UI.Site>       Connection id "0HL7PLV6P81VF" bad request data: "Malformed request: invalid headers." Equinox.UI.Site> Microsoft.AspNetCore.Server.Kestrel.Core.BadHttpRequestException: Malformed request: invalid headers. Equinox.UI.Site>    at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.Frame1.d__2.MoveNext()
Equinox.UI.Site> info: Microsoft.AspNetCore.Server.Kestrel[17]
Equinox.UI.Site>       Connection id "0HL7PLV6P81VG" bad request data: "Malformed request: invalid headers."
Equinox.UI.Site> Microsoft.AspNetCore.Server.Kestrel.Core.BadHttpRequestException: Malformed request: invalid headers.
Equinox.UI.Site>    at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.Frame1.<ProcessRequestsAsync>d__2.MoveNext() Equinox.UI.Site> info: Microsoft.AspNetCore.Server.Kestrel[17] Equinox.UI.Site>       Connection id "0HL7PLV6P81VG" bad request data: "Malformed request: invalid headers." Equinox.UI.Site> Microsoft.AspNetCore.Server.Kestrel.Core.BadHttpRequestException: Malformed request: invalid headers. Equinox.UI.Site>    at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.Frame1.d__2.MoveNext()

Hi, have you solved this problem? I'm facing a very similar issue, and I don't know where it is coming from.
Mine happens when it's a nonlocal env, started suddenly

Update your library version in your package.json. It's help for me!

yesterday i discovered that the problem was a cookie(header) that had an invalid char, I'm now trying to figure a way (if it's possible) to make kestrel ignore this invalid cookie(header)

That's work :)

yesterday i discovered that the problem was a cookie(header) that had an invalid char, I'm now trying to figure a way (if it's possible) to make kestrel ignore this invalid cookie(header)

Clearing cookies will solve the issue. Thanks.


all SVProgressHUD use static, why not design it as object

in SVProgressHUD, all method is static, all setters is static, such as setDefaultStyle setInfoImage setMinimumDismissTimeInterval. what if I want it be different in two pages, it will be ugly to implement it. why not design hud as a object!

The HUD is open source so you are welcome to contribute und give new ideas (source-code wise) we can look at.

got it! thank you


modernize macros in intro-to-datetime

Replacing the custom macros XREF and CXREF with a custom REF_SHORT which
has the same syntax as REF and may prove useful generally.
The custom macro FULL_CXREF is replaced with REF.
Replacing raw HTML with MREF in definitions of CORE_TIME, STD_DATETIME, and
STD_FILE.
FULL_XREF does not have a custom definition here. It's going to be replaced
in a repository-wide purge.
sed commands:
XREF -> REF_SHORT:
arg='\s*([^(),]*)'
from='\$\(XREF\s'$arg','$arg'\)'
to='$(REF_SHORT \2, std,\1)'
sed -i -r "s/$from/$to/g" intro-to-datetime.dd

CXREF -> REF_SHORT:
arg='\s*([^(),]*)'
from='\$\(CXREF\s'$arg','$arg'\)'
to='$(REF_SHORT \2, core,\1)'
sed -i -r "s/$from/$to/g" intro-to-datetime.dd

FULL_CXREF -> REF:
arg='\s*([^(),]*)'
from='\$\(FULL_CXREF\s'$arg','$arg'\)'
to='$(REF \2, core,\1)'
sed -i -r "s/$from/$to/g" intro-to-datetime.dd

Looking at the diff, the links should still be in monospace font, I think, to be consistent with the unlinked identifiers.

Looking at the diff, the links should still be in monospace font, I think, to be consistent with the unlinked identifiers.

https://github.com/dlang/dlang.org/pull/1327 takes care of that.

I see, thanks.


Save UI state per Workspace

Description
Save UI state per Workspace.

[x] sidebar width
[x] which files are open
[x] which editor tab is active
[x] order of editor tabs
[ ] the navigator sidebar, inspector sidebar, or debugger drawer

[x] opened/closed state
[ ] active tab,
[ ] tab order in each

[ ] editor layout (when we build split editor layout in - does not need to be done now consequently)

Related Issue

#917

Checklist

[x] I read and understood the contributing guide as well as the code of conduct
[x] My changes generate no new warnings
[x] My code builds and runs on my machine
[x] I documented my code
[x] Review requested

Screenshots

Looks good to me so far

Ready for review. Will create a new PR for remaining items after this one is merged.

My only concern is what happens when the user decides to delete CodeEdit, do these states stay on the machine? Or is UserDefault a thing that is encapsulated in the app itself?

I think it stays back and doesn't get deleted. We need to let macOS cleaner apps also to make money /jk

Yeah, I think @Code-DJ is right. I think this is intentional and by design. If the user wants to get rid of these settings that consume an insignificant amount of space on their disk, they can either do so manually by deleting our folder in Application Support or they can use on of many apps to clean out this kind of data. Unlike Windows, it will not slow down your machine or degrade your experience in any way by that data being there.

Fix failed tests

Rebased the fork which resolved the build issue. A couple of variable definitions were missing from the file in my fork. Verified that it builds correctly.


Fix "@" in FontName

Motivation
Adobe Illustrator fails to load fonts that have the @ sign in FontName.
Example PDF created by PDFKit (snippet):
38 0 obj
<<
  /Ascent 750
  /CapHeight 720
  /Descent -250
  /Flags 4
  /FontBBox [
    -45
    -236
    1749
    997
  ]
  /FontFile2 43 0 R
  /FontName /A@ZZZZ+MetaHeadlinePro
  /ItalicAngle 0
  /StemV 0
  /Type /FontDescriptor
  /XHeight 546
>>
endobj

And this is how the Adobe Illustrator error message looks like:

Problem
The problem is in Embedded.embed(). This function creates font name by translating numbers in the font id to letters. This works well for numbers 1-9, which get translated to A-I, but as soon as there is a 0 in the number, it gets translated to @.
Changes
Change Embedded.embed() to translate 0-9 to A-J.
Checklist

[X] Unit Tests
n/a Documentation -> It's a bug fix
[X] Update CHANGELOG.md
[X] Ready to be merged

Many thanks. Will do a new release soon

FYI i released v0.12 with this change


Godot Editor freezes randomly when a tooltip or a context menu appears, or while building a project

Godot version
4.1.1.stable.mono
System information
Godot v4.1.1.stable.mono - Debian GNU/Linux trixie/sid trixie - Vulkan (Compatibility) - NVIDIA GeForce GTX 1650 (nvidia) - AMD FX-8800P Radeon R7, 12 Compute Cores 4C+8G (4 Threads)
Issue description
I've been using Godot for just three days and I've experimented a lot of freezes with the editor, but sadly it happens randomly.
I've tried to reproduce it on purposefully, but it still happens randomly.
When the editor freezes, it becomes unusable and it can't even be closed via the close button. I have to force the kill process by the KDE System Monitor to close it and open it again to continue working.
Steps to reproduce

Open any project in Godot 4.1.1.mono.build.

Generally, these happen when

a tooltip appears,
when a context menu is opened,
when a value is changed in the inspector,
when the editor tries to close an open window (not the editor itself),
or when the editor is saving the project to build and test (it gets stuck in the saving process).

Minimal reproduction project
N/A

if you use Nvidia to render Editor - I know similar behavior on Nvidia GPUs.
Try - Editor -> Editor Settings -> Interface-Editor-> check Single Window mode
Say if it help/no.

if you use Nvidia to render Editor - I know similar behavior on Nvidia GPUs.
Try - Editor -> Editor Settings -> Interface-Editor-> check Single Window mode
Say if it help/no.

I think it helped because now even the tooltip doesn't lag the engine. But I have a question, wouldn't that be a problem for games that can create new windows?

wouldn't that be a problem for games that can create new windows?

I can be wrong but I think this bug happening because of - problem with how the driver reports the fence completion status - and on Nvidia and some other "lowend/old GPUs" - there is problem with complex Vulkan applications.
Because driver-bugs especially in "old generations GPU".
And Godot editor is complex application and if you make/reach same level of complexity in your application - you need to contact Nvidia/other corpo to force them fix their driver before release of your software - as you know every AAA+ game released with "new drivers" because in many cases it just does not work with old drivers.
In AMD-opensource drivers you can fix them by hands, and project like Godot did help find many driver bugs and ppl fix them.
Answer:
if you targeting "low-end hardware" - most likely you wont make "ultra complex app" - so you dodge this type of problem when design "minimal low-end application".
And if you target mid+ hardware atleast 3+yo - it mostly fine with Vulkan on GPUs.

Can you please check, if this could be a duplicate of #79088 or #74548

Can you please check, if this could be a duplicate of #79088 or #74548

It looks like a duplicate of both because both scenarios happened

Consolidating as a duplicate with the two bug reports as per the comment above.


Equality operator for Simhash

Hi,
Have you considered implementing the __eq__ operator for the Simhash class, to compare two .value() values for two simhashes? That way a simhash is much more easily integrated into comparison flows like Python's unittests.
I could submit a PR if you're interested in this.

That's a good idea, @arryon 👍

The pull request has been merged. Closing this.


Jinja2 - XSS and other vulnerabilities

By default, Jinja 2 will not sanitize or escape input to templates. This leaves rendered templates open to XSS and other vulnerabilities.
Jinja offers the ability to sanitize with the autoescape argument on the Environment or Template initializer, however this is False by default. It could be better to set it True for safety.
As of Jinja 2.4 autoescape can also be a callable that is passed the template name and could return True or False. I believe autoescape can be set to True unconditionally for this cli tool. Thoughts?
Proposing a fix in https://github.com/Snowflake-Labs/schemachange/pull/93

Merged and deployed, thanks!

Merged and deployed, thanks!

I will include the necessary updates(change-logs, version increments...) in my future PRs. Thanks for incorporating with https://github.com/Snowflake-Labs/schemachange/commit/884c2c0b2d007d05e69141c076b132590a122b85

I don't think this is quite the right approach - jinja autoescaping is designed for where the output language is HTML. Here the output language will be SQL, so you don't want to go messing with HTML entities, quote semantics will be different, etc, right?

What do you suggest instead @akdor1154?

Honestly I wouldn't try to go down this path at all - escaping is to protect your templates against untrusted input, and I would hope nobody is passing untrusted input to their db migration scripts :)
For the security aspect, doco  that vars are subbed in directly by string replacement should be sufficient I guess?
Just checking and it doesn't look like DBT, Flyway, even SnowSQL don't go down this path at all (it was a very brief check though..). In theory you could implement an escaping system targeted at SQL, but this would be a pretty big project in itself - because of how SQL works, it would need to be aware of if you're trying to sub in column identifiers, literals, bits of sql code, etc..

@tsingh2k15  in case i'm missing something, what scenario did you have in mind to protect against?

Yeah, I didn't do a careful review here before publishing, but I agree with you @akdor1154. Other than not really being helpful (since we're not dealing with HTML/XML), it will also cause problems with strings which legitimately need to include a <, >, or & (like a password).
Unless there's something I'm missing I'm planning to roll back this change @tsingh2k15.

Enabling autoescape does cause issues. With 3.3.2 using schemachange render R__test.sql
test.sql
SELECT * FROM TABLE WHERE COL {{">"}} 45;
SELECT * FROM TABLE WHERE COL > 45;

becomes
SELECT * FROM TABLE WHERE COL > 45;
SELECT * FROM TABLE WHERE COL > 45

The jinja documentation suggests setting a default so would be good to set autoescape=False.

Just published 3.3.3 with a change from #95, and set the default for autoescape to False.

@saperry @sfc-gh-jhansen
I am okay with reverting back to defaults. Thanks for pointing this out. Sharing my thoughts below.
1) I did not fully consider the scenarios mentioned above earlier that could break with this change, but your concerns are valid. My main thought around this was to prevent the vulnerabilities in general as someone could intentionally inject HTML/XML files in the SQL scripts directory? and then let the tool load it that way trying to simulate XSS?  Seems like the tool allows loading and rendering of HTML/XML templates? I was just trying it to check the behavior via below snippet.
def test_xss():
    processor = JinjaTemplateProcessor("", None)
    templates = {"test.html": " Hello {{person}}"}
    processor.override_loader(DictLoader(templates))
    test_vars = json.loads('{"person": ""}')
    context = processor.render("test.html", test_vars, True)

2) On another thought, if the tool does not prevent loading XML/HTML templates, could it check for a template type and then use a callable(per below doc) to return True or False accordingly? Just a thought. Not sure if this is really worth exploring. Could be explored if security is still a concern per scenario I mentioned.
As of Jinja 2.4 autoescape  can also be a callable that is passed the template name and has to return True or False

@tsingh2k15  correct me if I'm wrong, but wouldn't that require this tool to be executing untrusted inputs?  I'll mirror what someone else said earlier about this:  I would hope no one is passing untrusted inputs to their database migrations.
Regardless, even with auto-escaping, variables that you don't want to get auto-escaped can be marked safe with |safe within the jinja template, so I'm not certain it makes much of a difference either way, as long as this behavior is documented.
I'm currently using v3.3.2 and got burned by this undocumented change, simply because I had no clue that schemachange was using non-default settings for jinja.


Add -Werror and -Wdocumentation

[CMake] Add option LLDB_ENABLE_WERROR
[CMake] Build LLDB.framework with -Wdocumentation

rdar://problem/47921376

Should upstream have -Wdocumentation as well?

Should upstream have -Wdocumentation as well?

Yes, why not. Committed upstream with: https://reviews.llvm.org/rG2c72b4175756
Removed it from the PR and rebased on latest upstream-with-swift.

For more background on why -Werror is not upstream, please see https://reviews.llvm.org/D65939


Add lerna-changelog to devDependencies

lerna-changelog will be used to update the release notes.

I'm second guessing myself here... I kind of want to get into using conventional commits, which requires github to enforce it.
I'm going to close this for now.


fix: nydus-snapshotter can not run cause of failing of postStart hook

nydus-snapshotter can not run cause of failing of postStart hook when containerd config is disabled.
events:
  Warning  FailedPostStartHook  28s (x4 over 2m46s)  kubelet            Exec lifecycle hook ([/bin/sh -c # currently, without host pid in container, we can not nsenter with pid and can not invoke systemctl correctly.
nsenter -t 1 -m systemctl -- restart containerd.service
]) for Container "nydus-snapshotter" in Pod "nydus-snapshotter-kg8fs_nydus-snapshotter(6959e4c6-957e-4065-a7d9-b199c90a6535)" failed - error: command '/bin/sh -c # currently, without host pid in container, we can not nsenter with pid and can not invoke systemctl correctly.
nsenter -t 1 -m systemctl -- restart containerd.service
' exited with 127: nsenter: can't execute 'systemctl': No such file or directory
, message: "nsenter: can't execute 'systemctl': No such file or directory\n"
  Normal  Killing  28s (x4 over 2m46s)  kubelet  FailedPostStartHook

@gaius-qi done

@adamqqqplay I started the nydus daemon pod (with hostPid=true), and configured /etc/containerd/config.toml manually, but still encountered this problem with nydus image:

✅ busybox:1.32 (traditional oci image)
✅ busybox:1.32-esgz (nerdctl -n k8s.io image convert --estargz --oci busybox:1.32 busybox:1.32-esgz)
❌ busybox:1.32-nydus (nerdctl -n k8s.io image convert --nydus --oci busybox:1.32 busybox:1.32-nydus)

nydus-snapshotter version: v0.13.3
nydus inside pod: v2.1.5

@adamqqqplay I started the nydus daemon pod (with hostPid=true), and configured /etc/containerd/config.toml manually, but still encountered this problem with nydus image:

✅ busybox:1.32 (traditional oci image)
✅ busybox:1.32-esgz (nerdctl -n k8s.io image convert --estargz --oci busybox:1.32 busybox:1.32-esgz)
❌ busybox:1.32-nydus (nerdctl -n k8s.io image convert --nydus --oci busybox:1.32 busybox:1.32-nydus)

Event:
Warning  Failed          13m (x12 over 15m)  kubelet  Error: failed to create containerd container: error unpacking image: failed to extract layer sha256:49de949245b76bb0e2451821fb63dfd2c349decfd047e6a158a20a58a47e08c8: failed to get stream processor for application/vnd.oci.image.layer.nydus.blob.v1: no processor for media-type: unknown

nydus-snapshotter version: v0.13.3 nydus inside pod: v2.1.5
[root@worker12 ~]# ctr plugins ls | grep nydus
io.containerd.snapshotter.v1          nydus                    -              ok

@cheriL I think your containerd configuration may be overwritten by /etc/containerd/config.toml in kind. Maybe you can remove the field in extraMounts.
      - hostPath: ./config.toml
        containerPath: /etc/containerd/config.toml

@adamqqqplay My k8s is not set up by kind. The reason is weired that the image converted by nerdctl image convert --nydus didn't work(nerdctl v1.7.0).


@conda-forge-admin, please add python 2.7

This is an attempt to add a python 2.7 version, following instructions at https://conda-forge.org/docs/maintainer/infrastructure.html#conda-forge-admin-please-add-python-2-7

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I added python 2.7 in conda-forge/psrchive-feedstock#9.

Hi! This is the friendly automated conda-forge-webservice.
I just wanted to let you know that I added python 2.7 in conda-forge/psrchive-feedstock#9.

This didn't work, closing since it's probably not worth the effort at this point.


Update container -  Temporary lookup failure

Hey after I have updated my container I get this error:
Temporary lookup failure at the client.
When I want to send a mail (can not reseve also). But I can view all my mails as before...
In the console I get the message:
warning: connect to mysql server mariadb: Unknown MySQL server host 'mariadb'
but if I connect to the container and ping the db there is no problem...
My startparameters:
docker run --name=mail --link mariadb:mariadb --restart=always -p 25:25 -p 143:143 -p 465:465 -p 587:587 -p 993:993 -p 4190:4190 -e DBHOST=mariadb -e DBUSER=mailserver -e DBNAME=mailserver -e DBPASS=mypassword -e ADD_DOMAINS=mail.domain.tld -v /home/mailserver:/var/mail -v /home/mailserver/opendkim:/etc/opendkim/keys -h mail.domain.tld -d hardware/mailserver
did not changed it since first start
Any suggestions ? Thanks :)

Same issues : #14 #27

Can you please retry with docker run AND docker-compose v1 AND v2 ?

oh thanks alot! I have no docker compose but I binded the host file from outside the container read only:
/home/mailserver/hosts:/var/spool/postfix/etc/hosts:ro
so I can restart and update the container.
Its a little workaround but Solved :)

Fix in c2c8a22
Can you confirm ?

Very nice patch! Now its working without any hardcoded config again :tada:


Incompatibility with spring-boot-starter-parent: okhttp3.RequestBody.create not found

Expected behavior
I'm trying to set up rules to filter stream request using the method:
https://github.com/twitterdev/twitter-api-java-sdk/blob/main/docs/TweetsApi.md#addOrDeleteRules
But adding a rules to the AddOrDeleteRulesRequest.
here my code: (simplified to isolate the problem)
@SpringBootApplication
public class DemoApplication implements CommandLineRunner {

  public static void main(String[] args) {
    SpringApplication.run(DemoApplication.class, args);
  }

  @Override
  public void run(String... args) throws Exception {
    TwitterCredentialsBearer credentials = new TwitterCredentialsBearer("*************");
    TwitterApi apiInstance = new TwitterApi();
    apiInstance.setTwitterCredentials(credentials);

    // create new rules from a keywords array
    String[] keywords = {"Java", "Microservices", "Spring", "Kafka", "Elasticseach"};
    AddRulesRequest addRulesRequest = new AddRulesRequest();
    for (String keyword : keywords) {
      addRulesRequest.addAddItem(new RuleNoId().value(keyword).tag(keyword));
    }

    // Set the params values
    AddOrDeleteRulesRequest addOrDeleteRulesRequest = new AddOrDeleteRulesRequest(
        addRulesRequest); // AddOrDeleteRulesRequest |
    Boolean dryRun = true; // Boolean | Dry Run can be used with both the add and delete action, with the expected result given, but without actually taking any action in the system (meaning the end state will always be as it was when the request was submitted). This is particularly useful to validate rule changes.
    try {
      AddOrDeleteRulesResponse result = apiInstance.tweets()
          .addOrDeleteRules(addOrDeleteRulesRequest, dryRun);
      System.out.println(result);
    } catch (ApiException e) {
      System.err.println("Exception when calling TweetsApi#addOrDeleteRules");
      System.err.println("Status code: " + e.getCode());
      System.err.println("Reason: " + e.getResponseBody());
      System.err.println("Response headers: " + e.getResponseHeaders());
      e.printStackTrace();
    }
  }
}

Actual behavior
But when I run the application I received this error:
Exception in thread "main" java.lang.NoSuchMethodError: 'okhttp3.RequestBody okhttp3.RequestBody.create(java.lang.String, okhttp3.MediaType)'
	at com.twitter.clientlib.ApiClient.serialize(ApiClient.java:956)
	at com.twitter.clientlib.ApiClient.buildRequest(ApiClient.java:1227)
	at com.twitter.clientlib.ApiClient.buildCall(ApiClient.java:1173)
	at com.twitter.clientlib.api.TweetsApi.addOrDeleteRulesCall(TweetsApi.java:132)
	at com.twitter.clientlib.api.TweetsApi.addOrDeleteRulesValidateBeforeCall(TweetsApi.java:144)
	at com.twitter.clientlib.api.TweetsApi.addOrDeleteRulesWithHttpInfo(TweetsApi.java:211)
	at com.twitter.clientlib.api.TweetsApi.addOrDeleteRules(TweetsApi.java:166)
	at com.example.demo.Example.main(Example.java:28)

Or if I run inside @SpringBootApplication
APPLICATION FAILED TO START
***************************

Description:

An attempt was made to call a method that does not exist. The attempt was made from the following location:

    com.twitter.clientlib.ApiClient.serialize(ApiClient.java:956)

The following method did not exist:

    'okhttp3.RequestBody okhttp3.RequestBody.create(java.lang.String, okhttp3.MediaType)'

The calling method's class, com.twitter.clientlib.ApiClient, was loaded from the following location:

    jar:file:/Users/gerard.puig/.m2/repository/com/twitter/twitter-api-java-sdk/1.1.3/twitter-api-java-sdk-1.1.3.jar!/com/twitter/clientlib/ApiClient.class

The called method's class, okhttp3.RequestBody, is available from the following locations:

    jar:file:/Users/gerard.puig/.m2/repository/com/squareup/okhttp3/okhttp/3.14.9/okhttp-3.14.9.jar!/okhttp3/RequestBody.class

The called method's class hierarchy was loaded from the following locations:

    okhttp3.RequestBody: file:/Users/gerard.puig/.m2/repository/com/squareup/okhttp3/okhttp/3.14.9/okhttp-3.14.9.jar

Action:

Correct the classpath of your application so that it contains compatible versions of the classes com.twitter.clientlib.ApiClient and okhttp3.RequestBody

I think the problem comes from use spring-boot-starter-parent created with: https://start.spring.io/
I think spring boot starter parent loads a version 4.9.2 of okhttp library and that makes that the ApiClient don't found the okhttp version 3.14.9
Steps to reproduce the behavior
try to execute the  code above with POM.xml from spring Initializr
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
	xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
	<modelVersion>4.0.0</modelVersion>
	<parent>
		<groupId>org.springframework.boot</groupId>
		<artifactId>spring-boot-starter-parent</artifactId>
		<version>2.6.6</version>
		<relativePath/> <!-- lookup parent from repository -->
	</parent>
	<groupId>com.example</groupId>
	<artifactId>demo</artifactId>
	<version>0.0.1-SNAPSHOT</version>
	<name>demo</name>
	<description>Demo project for Spring Boot</description>
	<properties>
		<java.version>17</java.version>
	</properties>
	<dependencies>
		<dependency>
			<groupId>org.springframework.boot</groupId>
			<artifactId>spring-boot-starter</artifactId>
		</dependency>

		<dependency>
			<groupId>org.springframework.boot</groupId>
			<artifactId>spring-boot-starter-test</artifactId>
			<scope>test</scope>
		</dependency>

		<dependency>
			<groupId>com.twitter</groupId>
			<artifactId>twitter-api-java-sdk</artifactId>
			<version>1.1.3</version>
		</dependency>
	</dependencies>

	<build>
		<plugins>
			<plugin>
				<groupId>org.springframework.boot</groupId>
				<artifactId>spring-boot-maven-plugin</artifactId>
			</plugin>
		</plugins>
	</build>

</project>

Solution:
After some investigations I found that the problem was just the opposite, spring-boot-starter loads the version 3.14.9 and the version defined in twitter-api-java-sdk is 4.9.2
Adding the same version to the properties sections it's solved:
<properties>
	<okhttp3.version>4.9.2</okhttp3.version>
</properties>

I don't know if this can be solved in other way but this solutions works for me.
I'm interested to learn more about this kind of incompatibilities as it's the first time I found it. If anyone can aport other point of view it would be very welcome!

I think that you are correct, the method does not exist in https://javadoc.io/doc/com.squareup.okhttp3/okhttp/3.14.9/okhttp3/ResponseBody.html.
Regarding overriding the Spring Boot dependency, I found this https://www.baeldung.com/spring-boot-override-dependency-versions.

Hi zacmos, yes this solution is that I used! I don't know if this can be solved from your dependency when it's loading but this is outside from knowledge!
Thanks for the Api and keep working at you do! :)


Add script type setting to elasticsearch cluster

This PR doesn't appear to be linked to a DevOps/SRE jira ticket

This PR doesn't appear to be linked to a DevOps/SRE jira ticket

This PR doesn't appear to be linked to a DevOps/SRE jira ticket

Reminder to increment version and update changelog.

This PR doesn't appear to be linked to a DevOps/SRE jira ticket

Looks good!
Just curious, if you upgrade to the version with this change, would this be an in-place change?

It should be an in-place change

This PR doesn't appear to be linked to a DevOps/SRE jira ticket

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


pdf origal file form text missing

Attach (recommended) or Link to PDF file here:
http://gongmall-file.oss-cn-hangzhou.aliyuncs.com/gmmanager-test/employeeContract/2_null/[80972577-邵炉琴-33012219930226154X]电签合同.pdf?response-content-type=application/pdf
Configuration:
Web browser and its version: chrome 75.0.3770.100
Operating system and its version: windows10
PDF.js version: 2.0.943
Is a browser extension:
Steps to reproduce the problem: 1. 2.
What is the expected behavior? (add screenshot)

What went wrong? (add screenshot)

form elements didn't show,how can I let the form elements shows

Without all of the information requested in https://github.com/mozilla/pdf.js/blob/master/.github/ISSUE_TEMPLATE.md this issue will be closed as INVALID.

Without all of the information requested in https://github.com/mozilla/pdf.js/blob/master/.github/ISSUE_TEMPLATE.md this issue will be closed as INVALID.

ok

WFM, when using PDF.js version 2.2.207 in Firefox Nightly. (The signature isn't displayed, but that's already tracked elsewhere).

I comment the code in pdf.worker.js, authough, I don't favor this method
// if (data.fieldType === 'Sig') {
// _this2.setFlags(_util.AnnotationFlag.HIDDEN);
// }

Closing since this is now a duplicate of the issues in https://github.com/mozilla/pdf.js/issues?q=is%3Aopen+is%3Aissue+label%3A4-digital-signature.