[SPARK-8119][Scheduler]Do not let Spark set total executors when executor fails

DynamicAllocation will set the total executor to a little number when it wants to kill some executors.
But in no-DynamicAllocation scenario, Spark will also set the total executor.
So it will cause such problem: sometimes an executor fails down, there is no more executor which will be pull up by spark

Merged build triggered.

Merged build started.

Test build #34242 has started for   PR 6662 at commit 610c390.

Merged build triggered.

Merged build started.

Test build #34244 has started for   PR 6662 at commit 016214d.

Test build #34244 has finished for   PR 6662 at commit 016214d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test build #34242 has finished for   PR 6662 at commit 610c390.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

@SaintBacchus can you elaborate on the description a little? I'm not sure if I follow what the symptoms are and how you reproduced them.

@andrewor14  @vanzin I draw a simple call stack, as this:

If the doRequestTotalExecutors logic happened, it reset the total executors of the application.
But there was a prolem: at the monment if other executor also had down, the Spark will never pull it up again.
This simple scenario can reproduce this issue:
There are 2 applications and each wants 2 executor, so total 4 cup cores wanted(every executor wants one core). But the RM only has 3 cores, so when first application(A) gained 2 cores and second applicaiton(B) gained only one core waitting A release the cores.
Then kill one of the A's executor, B will pull up its executor and let A wait the resource.
After the TimeOut logic occures in A  then B application has finished its job and releases its resource.
As the expection, A wil push its anohter other executor again but actually it will never happen.
A may be a Streaming application.

@andrewor14  did I describe the scenario clearly? can you review it again?

I see. The issue is that the AM forgets about the original number of executors it wants after calling sc.killExecutor. Even if dynamic allocation is not enabled, this is still possible because of heartbeat timeouts.
I think the problem is that sc.killExecutor is used incorrectly in HeartbeatReceiver. The intention of the method is to permanently adjust the number of executors the application will get. In HeartbeatReceiver, however, this is used as a best-effort mechanism to ensure that the timed out executor is dead.

I have updated the description on the JIRA. However, this patch is definitely not the correct fix. The user should be able to call sc.requestExecutors (a public developer API) even when dynamic allocation is not enabled. This patch disallows that.
I'll submit a fix to remove the heartbeat logic separately. In the mean time, could you close this PR? Thanks for your work @SaintBacchus.

OK


HI! Is it possible to integrate it with React Native?

No, not easily, there is another discussion with a swift port (if i remember well).
I personally tried to do it but my 'priority' changed and I never finished it. It is not plug and play as most of the dependencies of this package are not compatible with react native...
I let maintainers or other followers put additional comments.

Thanks for the clarification!


Crash on Ship Build

Attached my crash log below. Friend is saying that it's a lack of proper implementation of OpenGL Rendering or something of the sort. Version is 1.10.2, release.
crash-2018-02-01_14.09.56-server.txt

1.10.2 is buggy and unsupported, please update to 1.11.2

Ah, that's sad. Was going with 1.10.2 because of other mods, so I won't be able to update right now. Thanks anyhow.


Created a generic Pi4J OS desktop wallpaper

My first contribution to Pi4J OS ;-)
If you don't mind, I would like to "rebrand" the desktop wallpaper, but still crediting the university ofcourse!

I like the new wallpaper.
But I haven't tested it. If it's working, then let's merge this PR


Update idebugcodecontext2-getdocumentcontext.md

@gregg-miskelly Is the statement I put clearer? Or do you have a suggestion on what we should say to make it more clear?

@pieandcakes : Thanks for your contribution! The author, @madskristensen, has been notified to review your proposed change.

@pieandcakes : Thanks for your contribution! The author, @madskristensen, has been notified to review your proposed change.

#sign-off


🐛 fix posts screen infinite scroll

no issue

changes to layout meant that every page was automatically requested upon loading the content screen, this changes the infinite scroll trigger to match the new scrollable element

Coverage remained the same at 75.126% when pulling 4dcf47c93132b93ad9943f19ca8c38b08ce0a491 on kevinansfield:fix-infinite-scroll into 15f92b2c35a0a0b0dafb7f0d84f6eaf77d4cd655 on TryGhost:master.


Allows MMLU to have the system_prompt provided to it

The MMLU evaluator currently performs MMLU evaluation by calling out to the lm_eval harness. The lm-eval harness itself handles the evaluation by creating its own prompt clientside and then passing it to /v1/completions of whatever OpenAI-compatible API that it's expecting to receive it at the other end.
Certain models however require to have their chat template used to be used during inference in order to get the best results. This PR adjusts the MMLU evaluator by allowing the system prompt to be provided to the model and then will enable the chat template mode to be used when it's present.
Signed-off-by: Oleg S<EMAIL_ADDRESS>

I am currently running a e2e test on granite-8b-starter and still seeing failures (manually brought in patches)

(app-root) /$ cat /opt/app-root/lib/python3.11/site-packages/instructlab/eval/mmlu.py | grep system_prompt
        system_prompt   system prompt to be used when applying the chat template
        system_prompt: Optional[str] = None,
        self.system_prompt = system_prompt
        should_apply_chat_template = self.system_prompt is not None
            system_instruction=self.system_prompt,
        system_prompt   system prompt to be used when applying the chat template
        system_prompt: Optional[str] = None,
            system_prompt=system_prompt,
        system_prompt   system prompt to be used when applying the chat template

(app-root) /$ cat /opt/app-root/lib/python3.11/site-packages/instructlab/model/evaluate.py | grep system_prompt
            system_prompt = get_sysprompt(get_model_arch(model_path))
                system_prompt=system_prompt,
            base_model_system_prompt = get_sysprompt(get_model_arch(base_model_path))
            model_system_prompt = get_sysprompt(get_model_arch(model_path))
                    system_prompt=model_system_prompt,
                    base_model_system_prompt,
                    system_prompt=model_system_prompt,
(app-root) /$

Confirmed my image had patches for both libraries and then proceeded to run mmlu eval

Hit with this same error
Requesting API:   0%|                                                                                | 52/56168 [00:16<2:48:58,  5.54it/s]WARNING 2024-12-12 20:57:37,031 lm-eval:347: API request failed with error message: Internal Server Error. Retrying...
WARNING 2024-12-12 20:57:38,197 lm-eval:347: API request failed with error message: Internal Server Error. Retrying...
WARNING 2024-12-12 20:57:39,361 lm-eval:347: API request failed with error message: Internal Server Error. Retrying...
INFO 2024-12-12 20:57:47,539 instructlab.model.backends.vllm:475: Waiting for GPU VRAM reclamation...
Traceback (most recent call last):
  File "/opt/app-root/bin/ilab", line 8, in <module>
    sys.exit(ilab())
             ^^^^^^
  File "/opt/app-root/lib64/python3.11/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/app-root/lib64/python3.11/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
         ^^^^^^^^^^^^^^^^
  File "/opt/app-root/lib64/python3.11/site-packages/click/core.py", line 1688, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/app-root/lib64/python3.11/site-packages/click/core.py", line 1688, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/app-root/lib64/python3.11/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/app-root/lib64/python3.11/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/app-root/lib64/python3.11/site-packages/click/decorators.py", line 33, in new_func
    return f(get_current_context(), *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/app-root/lib64/python3.11/site-packages/instructlab/clickext.py", line 323, in wrapper
    return f(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^
  File "/opt/app-root/lib64/python3.11/site-packages/instructlab/model/evaluate.py", line 817, in evaluate
    overall_score, individual_scores = evaluator.run(api_base)
                                       ^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/app-root/lib64/python3.11/site-packages/instructlab/eval/mmlu.py", line 147, in run
    results = self._run_mmlu(server_url)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/app-root/lib64/python3.11/site-packages/instructlab/eval/mmlu.py", line 175, in _run_mmlu
    mmlu_output = self._simple_evaluate_with_error_handling(
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/app-root/lib64/python3.11/site-packages/instructlab/eval/mmlu.py", line 193, in _simple_evaluate_with_error_handling
    return simple_evaluate(**kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/app-root/lib64/python3.11/site-packages/lm_eval/utils.py", line 397, in _wrapper
    return fn(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^
  File "/opt/app-root/lib64/python3.11/site-packages/lm_eval/evaluator.py", line 301, in simple_evaluate
    results = evaluate(
              ^^^^^^^^^
  File "/opt/app-root/lib64/python3.11/site-packages/lm_eval/utils.py", line 397, in _wrapper
    return fn(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^
  File "/opt/app-root/lib64/python3.11/site-packages/lm_eval/evaluator.py", line 500, in evaluate
    resps = getattr(lm, reqtype)(cloned_reqs)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/app-root/lib64/python3.11/site-packages/lm_eval/api/model.py", line 378, in loglikelihood
    return self._loglikelihood_tokens(new_reqs, disable_tqdm=disable_tqdm)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/app-root/lib64/python3.11/site-packages/lm_eval/models/api_models.py", line 502, in _loglikelihood_tokens
    outputs = retry(
              ^^^^^^
  File "/opt/app-root/lib64/python3.11/site-packages/tenacity/__init__.py", line 336, in wrapped_f
    return copy(f, *args, **kw)
           ^^^^^^^^^^^^^^^^^^^^
  File "/opt/app-root/lib64/python3.11/site-packages/tenacity/__init__.py", line 475, in __call__
    do = self.iter(retry_state=retry_state)
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/app-root/lib64/python3.11/site-packages/tenacity/__init__.py", line 376, in iter
    result = action(retry_state)
             ^^^^^^^^^^^^^^^^^^^
  File "/opt/app-root/lib64/python3.11/site-packages/tenacity/__init__.py", line 418, in exc_check
    raise retry_exc.reraise()
          ^^^^^^^^^^^^^^^^^^^
  File "/opt/app-root/lib64/python3.11/site-packages/tenacity/__init__.py", line 185, in reraise
    raise self.last_attempt.result()
          ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib64/python3.11/concurrent/futures/_base.py", line 449, in result
    return self.__get_result()
           ^^^^^^^^^^^^^^^^^^^
  File "/usr/lib64/python3.11/concurrent/futures/_base.py", line 401, in __get_result
    raise self._exception
  File "/opt/app-root/lib64/python3.11/site-packages/tenacity/__init__.py", line 478, in __call__
    result = fn(*args, **kwargs)
             ^^^^^^^^^^^^^^^^^^^
  File "/opt/app-root/lib64/python3.11/site-packages/lm_eval/models/api_models.py", line 350, in model_call
    response.raise_for_status()
  File "/opt/app-root/lib64/python3.11/site-packages/requests/models.py", line 1024, in raise_for_status
    raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 500 Server Error: Internal Server Error for url: http://<IP_ADDRESS>:43683/v1/completions
Requesting API:   0%|                                                                                | 52/56168 [00:36<11:00:59,  1.41it/s]

I am happy to bring in patches and do a e2e test to ensure we are at a place that everything is good  on granite-8b-starter

mmluoutputgranite8bwithpatch.txt.zip

@danmcp Yes, we tested these changes last night with @relyt0925 in a production environment and it worked. Now I'm adding a test as well so we can have a more automated way of making sure this is happening since it seems to be important for certain models.

Just for the sake of ensuring y'all don't hit something: few shots from my testing needed to be either 1 or 2: I saw when I used 3 failures on granite-8b-starter

@relyt0925 Yes that's correct. Use --few-shots=2 if you want the model to have an example shown to it. Otherwise, the models for which the chat template applies are instruction-tuned so --few-shots=1 should even be fine.


RuntimeError: The Python version  mismatches

/kind bug
What steps did you take and what happened:
[A clear and concise description of what the bug is.]
DOCKERHUB_USERNAME = 'seedjeffwan'
DOCKER_REGISTRY = '{}'.format(DOCKERHUB_USERNAME)
fairing.config.set_builder('append',base_image='tensorflow/tensorflow:1.13.1-py3', registry=DOCKER_REGISTRY, push=True)
fairing.config.set_deployer('job')

def train():
    hostname = tf.constant(os.environ['HOSTNAME'])
    sess = tf.Session()
    print('Hostname: ', sess.run(hostname).decode('utf-8'))

if __name__ == '__main__':
    remote_train = fairing.config.fn(train)
    remote_train()

and see error message
Finished upload of: seedjeffwan/fairing-job:CBF947AD
Pushed image seedjeffwan/fairing-job:CBF947AD in<PHONE_NUMBER>3900005s.
The job fairing-job-sltq2 launched.
Waiting for fairing-job-sltq2-h4jzb to start...
Waiting for fairing-job-sltq2-h4jzb to start...
Waiting for fairing-job-sltq2-h4jzb to start...
Failed to launch fairing-job-sltq2-h4jzb, reason: Error, message: None
Cleaning up job fairing-job-sltq2...
Traceback (most recent call last):
  File "/app/function_shim.py", line 59, in <module>
    compare_version(args.python_version)
  File "/app/function_shim.py", line 38, in compare_version
    + local_python_version + ' in the local environment.')
RuntimeError: The Python version 3.5.2 mismatches with Python 3.7.3 in the local environment.

I create a notebook locally by running jupyter notebook and my machine python version is 3.7.3. When it schedule job on kubernetes, it encounter this problem.
!python3 -V
Python 3.7.3

I enter tensorflow/tensorflow:1.13.1-py3  and notice python3 version is 3.5.2. That's probably the reason.  By looking at the code, I am not sure if that makes sense to compare full version. To make sure compatibility, I think major (3) version or minor (5,6,7) are necessary, patch version is not helpful here.
https://github.com/kubeflow/fairing/blob/8a350ea2c453e2e06f2b7e534de88a2936f9711a/fairing/functions/function_shim.py#L34-L38
What did you expect to happen:
Not sure why local python environment impacts job running since jobs is on kubernetes and should not be interrupted by other envs.
The guidance only required development environment version > 3.6.5 to use faring if I understand correct?
Environment:

Fairing version: (use python -c "import fairing; print(fairing.__version__)"): 0.5.3
Kubeflow version: (version number can be found at the bottom left corner of the Kubeflow dashboard): 0.6.0
Minikube version:
Kubernetes version: (use kubectl version): 1.13
OS (e.g. from /etc/os-release):

NOTE: If you are using fair from master, please provide us the git commit hash.

I can help on the patch if you think it's reasonable.  Based on the python compatible documentation.
Compatibility Levels

Compatible: Python version x.y is compatible with w.z if x == w and y >= z
Potentially compatible: Python version x.y is potentially compatible to version w.z if x == w and y < z
Incompatible: Python version x.y is incompatible with version w.z if x != w

We only compare major and minor version. Micro version should be ignored.
local development python minor version can be lower or equal to remote python minor version is major version is same.

@Jeffwan That works as design. Pls see discussion in the https://github.com/kubeflow/fairing/issues/288 and https://github.com/kubeflow/fairing/pull/291. Thanks.

Hi Jinchi, sorry for taking long to come back.
I am still a little bit confused, checking design, description in the issue and pr, seems we want to compare major and minor? But in the code implementation, it does compare full version.
In your PR, "In the patch we just compare the Python major and minor version, and igore micro version, for examples, 3.6.5 will mismatch with 3.5.2, but match with 3.6.8."
and in your method annotation, https://github.com/kubeflow/fairing/blob/c5be73f0f6304a37ebea21f9aa1d97156a9e4e8e/kubeflow/fairing/functions/function_shim.py#L41
I made some changes, could you help take a look?
#377

@Jeffwan In my initial thought, we should just compare major and minor verions. but the PR #291 is updated as @karthikv2k comments that we should also conver micro version, you can read details by going though the #291 .
Not sure has problem if the micro version mismatch, yes, we can reconsider that.


allow provider authorizer for http request module

allow provider authorizer for http request module
:heavy_check_mark: Checklist

[ ] Added tests for new functionality and regression tests for bug fixes
[ ] Added changeset (run yarn changeset in the root)
[ ] Screenshots of before and after attached (for UI changes)
[ ] Added or updated documentation (if applicable)

We have decided to take a different approach here.


Implement timetrace edit record command

Just as projects are editable via timetrace edit project, records should be editable using timetrace edit record. The command syntax should look just like the syntax of timetrace get record:
timetrace edit record [options] <YYYY-MM-DD-HH-MM>

Running edit without any options should open the default editor to directly edit the record file (see edit project).
Running edit with options should load the record internally, apply the option values and save the record. The supported options are explained below.

Command options

Flag
Short
Type
Description
Example

--plus
-p
String
Adds the given duration to the end time of the record.
--add 10m

--minus
-m
String
Substracts the given duration of the end time of the record.
--minus 10m

Those options probably aren't too hard to implement if the durations can be parsed as time.Duration. In that case, calling something like record.End.Add(plus) should be sufficient.

An open question would be how --plus operations are handled if the calculated end time lies within the timespan of another record.

Hello, I would like to work on this issue :)

Resolved by #51.


Update Accounts Subtree

Update accounts subtree to match the latest master <1ebe0f1>

@phil-davis we only need the code.
The skeleton from the former accounts repo could be deleted completely
But separate task please, is the same for all the other services. We should do it in one go.

But separate task please, is the same for all the other services. We should do it in one go.

See PR #647

But separate task please, is the same for all the other services. We should do it in one go.

See PR #647

is it ready for review? :D

Since accounts/.drone.star has been removed in https://github.com/owncloud/ocis/pull/647 I guess this PR can be closed, right?
There was code in the old ocis-accounts master that prevented creating duplicate accounts (duplicate as in duplicate preferred_name or duplicate mail). It was my impression that this PR would have been about that. Can we have that feature back? 🤔

Somehow this PR only ended up with .drone.star
If there is other code in the old ocis-accounts then "someone" (tm) needs to make a PR here to apply it.

Somehow this PR only ended up with .drone.star
If there is other code in the old ocis-accounts then "someone" (tm) needs to make a PR here to apply it.

indeed I haven't updated yet :) on it

Since accounts/.drone.star has been removed in #647 I guess this PR can be closed, right?
There was code in the old ocis-accounts master that prevented creating duplicate accounts (duplicate as in duplicate preferred_name or duplicate mail). It was my impression that this PR would have been about that. Can we have that feature back? 🤔

no. we need to update the subtree and merge this PR, basically bring the changes from ocis-accounts master, nothing to do with old features :/

@phil-davis review? https://github.com/owncloud/ocis-accounts/pull/129

This PR has a net zero lines changed. So why are we doing this?
Is there some change in owncloud/ocis-accounts that is not yet in owncloud/ocis/accounts ? And should be in this PR?

This PR has a net zero lines changed. So why are we doing this?
Is there some change in owncloud/ocis-accounts that is not yet in owncloud/ocis/accounts ? And should be in this PR?

well, it should also bring the elapsed git history, but since net changes are 0 we could also drop it, perhaps this got updated at some point along the way and I lost track of it. I'd close the PR and move on, if tests are all okay in ocis master and we're sure the latest set of changes from ocis-accounts is in ocis/accounts 👍

This entire PR is missing ;-) https://github.com/owncloud/ocis-accounts/pull/123

hmm, maybe we try some kind of cherry-pick?

@micbar and I checked the commit history of the old ocis-accounts manually to see what we're missing. It's only that we need to enable webUI tests of the accounts UI in drone + the contents of this PR: owncloud/ocis-accounts#123
Since it doesn't make sense to bring in the duplicate accounts check before the new index is finished, I made a draft PR so that we have something sitting there for rebasing and refactoring: https://github.com/owncloud/ocis/pull/665
IMO this PR can be closed then. We can close the Jira Ticket when the webUI tests are enabled, since the PR has it's own Jira Ticket.


Updated identity-66e and pap-f8d extension files

Fork contains the updated API and test files for identity-66e and pap-f8d. It also contains the pyproject, tox, README, and example files.

Please rename the pap directory as pap-marking-definition-f8d
You need to add code in https://github.com/ghackford-mitre/cti-python-stix2-extensions/blob/main/.github/workflows/tests.yml for your two extensions

Take a closer look at the tests.yml file - you need to add more stuff :-)
When you commit - it should run your tests in your fork

I think: - 'pap-marking-definition-f8d**/' should be - 'pap-marking-definition-f8d/**', which might be why those tests didn't run.


Implement the validation for all the fields on the sign up form

Implement the validation for all the fields on the sign up form according to the issue #127:

"First Name" and "Last Name" fields must receive a string in a range from 2 to 15 symbols.
The email field must be for emails.
Password must contain at least one alphabetic and one numeric character.
The "Confirm Password" field must be connected with the "Password" field.

Pull the branch to test the changes:
git pull origin feature/127/sign-up-form-fields-validation

Validation for all fields works correctly


Allow to choose the job title you like to have as standard under your name

Since you can work for several companies and projects simultanously, it would be nice to set a "standard position". The job title of this standard position would be the one users see under the name.

Good idea! Thanks for the input.


Ignore custom regex in embedded arguments

Using custom regular expressions
Currently, when embedded keyword arguments are declared with custom regular expressions, they are marked with "Variable definition not found" when used.
Example:
*** Keywords ***
I execute "${cmd:[^"]+}"
    Run Process    ${cmd}    shell=True

${cmd} is highlighted as an error: "Variable definition not found".

in this case how does one distinguish between regex and ${x} variables? is it the addition of the special characters?

It looks like if colon is present in the variable declaration, it separates its name from the regex.
My analysis so far:
Because of that, a colon doesn't appear to be a valid character for a variable name:
*** Keywords ***
Repeat After Me   ${x:2}
    Log     ${x:2}

Here, variable x can only match the value of 2. When this keyword is invoked, it throws Resolving variable '${x:2}' failed: SyntaxError: invalid syntax (<string>, line 1). Intellibot currently sees this syntax as valid.
So, colon could be used as an indicator of an end of the variable name. The tricky part would then be to identify the end of the regex (therefore the end of the variable declaration). The closing curly bracket could either be a part of the regex or not. Having escaped backslashes in the regex complicates it even further. See Escaping special characters in the same section of the User's Guide.
*** Keywords ***
Today is ${date:\d{4\}-\d{2\}-\d{2\}}
    Log    ${date}

Intellibot curently highlights only part of the variable, and considers the rest as the continuation of the keyword name: ${date:\d{4}-\d{2}-\d{2}}
To find the proper closing curly bracket, I think you'd have to scan for one that is not preceded by an odd number of backslashes, e.g. a}, b\\}, c\\\\} etc. With an odd number of backslashes, the last one will escape the bracket, making it a part of the regex. Even number of backslashes would be part of the regex, and the bracket immediately following (unescaped) therefore ends the variable declaration.
Hope I've clarified it at least a little bit. At least the first part would be very helpful, e.g. to make a variable match digits only. The part with closing brackets in the regex is just a bonus :)

P.S.: Here is one more kinky test case:
*** Keywords ***
Repeat After Me: ${x:\d\\\};\)\\}
    Log     ${x}

*** Test Cases ***
Example
    Repeat After Me: 6\};)\

It's syntactically valid, and prints 6};)
Something ate the remaining backslashes along the way.


Hangs under WSL2

Im trying to connect the serial port as described in the instructions, but when the script is run, it just hangs and goes no further?

Sometimes I experience a similar issue. I use the npiperelay tool to communicate SSH agents in Windows and WSL2. Usually, it works great, but sometimes SSH commands in WSL2 hang. I'm not sure the npiperelay tool is a genuine reason for this problem, though.
Is there a way to debug such an issue?

I have the same problem as @RomanDanyk. Using npiperelay to communicate from WSL2 with windows native ssh-agent works fine for weeks and then suddenly stops working. All ssh commands in WSL2 just hang forever. I already tried:

restart socat/npiperelay in WSL2
restarting ssh-agent on Windows side
restart WSL2 (wsl -shutdown)

But so far, no success. A reboot fixes the issue, but that seems like overkill. Any ideas on how to debug or fix the issue would be great.

I've been hitting similar issues with git commands hanging as I use SSH key auth and forward key requests to the Windows SSH Agent with npiperelay.
What I noticed is that when this stops working for me, it seems like the WSL -> Windows interop is broken. E.g. running notepad.exe from a shell in the WSL distro also fails. I created an issue in the WSL repo, so it might be worth upvoting that if you're hitting the same issue?

I can confirm the observation of @stuartleeks: starting any (even console executable) windows program from WSL2 just fails. The terminal blocks forever (Ctrl-C doesn't work) - the w32 executable has to be killed from a second terminal.
So the problem doesn't seem to be a npiperelay issue. Still, it might make sense to keep this issue around as a pointer to the WSL2 issue.

I use npiperelay to conenct the SSH_AUTH_SOCK to the ssh-agent running on Windows.
Very recently my ssh connections (logins) started to be very slow (6s), hanging at:
debug1: rekey in after 134217728 blocks
🦗 6s
debug1: get_agent_identities: agent returned 2 keys

Also ssh-add -l in WSL hangs for the same amount of time, as well as:
$ time npiperelay.exe --help
Usage of npiperelay.exe:
...
real    0m5.256s

It was caused by Windows Defender Real-time protection. I was able to resolve it by adding an exclude for the directory where npiperelay.exe is located, like that:
\\wsl.localhost\<dist>\<npiperelay_directory>


Redirect handling and GenericUrl not woriking well together (resulting in 404) when redirected to any URL with a path containing the '+' character

When handling redirects for GET requests, the next request is made with an GenericUrl instance constructed from the value of the Location header like this: new GenericUrl(url.toURL(redirectLocation)). If redirectLocation contains a '+' character in the path it effectively gets converted to a space and encoded as %20 which breaks the URL. This is a rather big issue trying to work Google+. In my opinion the root of the problem is the toPathParts method in GenericUrl which uses CharEscapers.decodeUri on each part despite of its documentation which states it should not be used on path because it replaces '+' with ' '.

+1 this issue. @VICO-Research 's suggestion will cause '+' to be encoded as %2B, as the path encoding in appendRawPathFromParts is also incorrect. The CharEscapers.escapeUriPath method doesn't recognise '+' as an subdelimiter character (see https://tools.ietf.org/html/rfc3986).


Unidentified keyword argument

This is when trying to place an order

Sorry, I had the wrong word in the README. This should be fixed as of e74e2f6fe0ad3c6ad53657af1e6008b11397e772


support nan_to_num

Before submitting

[x] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[x] Did you read the contributor guideline, Pull Request section?
[ ] Did you make sure to update the docs?
[x] Did you write any new necessary tests?

What does this PR do?
Fixes #176.
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
One of the best part of my day!

Cool! Thanks @k223kim!


unexpected results when jobs overlap

I experienced some unexpected results when the job starts and the previous one had not finished yet. I have it schedule to run every 15 min and leave only 1 machine on. When the first job ran after Off-Peak hours started it made a selection on which machines to shut down and which ones to maintain on but it took longer than 15 min closing sessions and shutting servers down. After 15 min, when the next job started (before the first one finished) it chose a different machine to stay on so the result was that after both jobs were completed there was not host online. Subsequent jobs detected no machines online but didn't power any up.
It would be good to include some logic into the jobs to prevent this scenario and/or to power machines on during off peak to comply with the amount of hosts needed to keep online.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 24a6c4e2-702f-2b17-3e2d-c86f33b13beb
Version Independent ID: 1e7811d8-668a-db98-34ca-eaf4d7ee8c1f
Content: Scale session hosts Azure Automation - Azure
Content Source: articles/virtual-desktop/set-up-scaling-script.md
Service: virtual-desktop
GitHub Login: @Heidilohr
Microsoft Alias: helohr

@LeoLopezAtHL Thank you for your feedback! We have assigned this issue to the author to review further and take the right course of action.

Closing as this is a support issue, rather than the article itself.
#please-close


Not able to connect with kubectl X509 unknown authority

Is this a request for help?: Yes
Is this an ISSUE or FEATURE REQUEST? (choose one): Issue
What version of acs-engine?: 0.13.1
Orchestrator and version (e.g. Kubernetes, DC/OS, Swarm)
Kubernetes
What happened:
Following the kubernetes guide, after adding the kubeconfig,centralus.json file to KubeConfig environment variable, when i run kubectl cluster-info I get the following message:
Unable to connect to the server: x509: certificate signed by unknown authority (possibly because of "crypto/rsa: verification error" while trying to verify candidate authority certificate "ca")

What you expected to happen:
To successfully connect to the cluster
How to reproduce it (as minimally and precisely as possible):
https://github.com/Azure/acs-engine/blob/master/docs/kubernetes/deploy.md#acs-engine-the-long-way
Anything else we need to know:
{
    "apiVersion": "vlabs",
    "properties": {
      "orchestratorProfile": {
        "orchestratorType": "Kubernetes",
        "orchestratorVersion": "1.9.1",
        "kubernetesConfig": {
            "dockerEngineVersion": "17.05.*"
        }
      },
      "masterProfile": {
        "count": 1,
        "dnsPrefix": "some-cool-prefix",
        "vmSize": "Standard_D2_v2"
      },
      "agentPoolProfiles": [
        {
          "name": "agentpool1",
          "count": 2,
          "vmSize": "Standard_D2_v2",
          "availabilityProfile": "AvailabilitySet"
        }
      ],
      "linuxProfile": {
        "adminUsername": "azureuser",
        "ssh": {
          "publicKeys": [
            {
              "keyData": "secret!"
            }
          ]
        }
      },
      "servicePrincipalProfile": {
        "clientId": "some-id",
        "secret": "secret!"
      }
    }
  }

FWIW - I had similar trouble from behind a non-transparent proxy on a corporate network. The proxy intercepts traffic and modifies the responses, invalidating the certificate trust between kubectl and apiserver.
Using the ‘—insecure-skip-tls-verify’ flag with kubectl was the workaround.

havin g same issue but getting this
kubectl --insecure-skip-tls-verify="true" get pods error: the server doesn't have a resource type "pods"

Hi, i have a similar problem when writing
kubectl version --short

It show the following
Client Version: v1.11.0
Unable to connect to the server: x509: certificate signed by unknown authority

Then i execute
kubectl config set-cluster gke_my-project --insecure-skip-tls-verify=true

But when performing
kubectl version --short

I get this
Client Version: v1.11.0
error: got '<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">

<!--//////////////////////////////////////////////////////////////////////////
//
//    Copyright (c) 1996 - 2011, Websense, Inc.    All Rights Reserved
//    See WebsenseCopyright.txt for copyright information
//
///////////////////////////////////////////////////////////////////////////-->

<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<title>Blocked by Websense</title>
<!--<link rel="stylesheet" href="/en/Default/master.css" type="text/css">-->
<script type="text/javascript" language="javascript" src="/en/Default/master.js"></script>
<script type="text/javascript" language="javascript" src="/en/Default/base64.js"></script>
<script type="text/javascript" language="javascript" src="/en/Default/security.js"></script>
</head>

<body>
<form>
        <iframe src="http://<IP_ADDRESS>:15871/cgi-bin/block_message.cgi?ws-session=-1902541711" id="test" title="test"
name="ws_block" frameborder="0" scrolling="no"  style="width:100%;" height="600">

        </iframe>
<iframe src="http://<IP_ADDRESS>:15871/cgi-bin/blockOptions.cgi?ws-session=-1902541711" id="option" name="ws_blockoption
" frameborder="0" scrolling="no" style="width:100%;" height="600">

</iframe>
</form>
</body>
</html>
': invalid character '<' looking for beginning of value

Can someone help me, I do it from the windows cmd.
Thank you

Hi, i have a similar problem when writing
kubectl version --short

It show the following
Client Version: v1.11.0
Unable to connect to the server: x509: certificate signed by unknown authority

Then i execute
kubectl config set-cluster gke_my-project --insecure-skip-tls-verify=true

But when performing
kubectl version --short

I get this
Client Version: v1.11.0
error: got '<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">

<!--//////////////////////////////////////////////////////////////////////////
//
//    Copyright (c) 1996 - 2011, Websense, Inc.    All Rights Reserved
//    See WebsenseCopyright.txt for copyright information
//
///////////////////////////////////////////////////////////////////////////-->

<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<title>Blocked by Websense</title>
<!--<link rel="stylesheet" href="/en/Default/master.css" type="text/css">-->
<script type="text/javascript" language="javascript" src="/en/Default/master.js"></script>
<script type="text/javascript" language="javascript" src="/en/Default/base64.js"></script>
<script type="text/javascript" language="javascript" src="/en/Default/security.js"></script>
</head>

<body>
<form>
        <iframe src="http://<ip address>:<port>/cgi-bin/block_message.cgi?ws-session=xxxxxxx" id="test" title="test"
name="ws_block" frameborder="0" scrolling="no"  style="width:100%;" height="600">

        </iframe>
<iframe src="http://<ip address>:<port>/cgi-bin/blockOptions.cgi?ws-session=xxxxxxxxx" id="option" name="ws_blockoption
" frameborder="0" scrolling="no" style="width:100%;" height="600">

</iframe>
</form>
</body>
</html>
': invalid character '<' looking for beginning of value

Can someone help me, I do it from the windows cmd.
Thank you

This is websense response, which possibly says you cannot access your cluster via your company fw. You may want to try from an other network (mobile hotspot maybe?)...

I used the command below to get myself out of this pickle:
az aks get-credentials -g  -n  --overwrite-existing
I watched the ~/.kube/config file and a whole new entry got added in the "users:" section.  The kubectl commands work now.

I used the command below to get myself out of this pickle:
az aks get-credentials -g  -n  --overwrite-existing
I checked the ~/.kube/config file and a whole new entry got added in the "users:" section. The kubectl commands work now.

Can you please mentioned the correct command so I can use the same

Certainly:
az aks get-credentials  -g  -n   --overwrite-existing

Certainly:
az aks get-credentials  -g   -n   --overwrite-existing
For more info: az aks get-credentials  -help

In case your browse does not render my message correctly, this is the image that I'm seeing:

Just Copy kubectl config again
cp /etc/kubernetes/admin.config $home/.kube/config


Make auto-run script feature to take run modes into account

Business background:
AEM publisher ACLs differs than author's.  Sometimes different instances of publisher has different ACL's (solr indexers). The purpose of the instance is reflected in instance run modes.
Enhancement:
The idea is to auto-run scripts when specified run modes are present.
Feature will introduce new property at script content : cqsm:allowedRunModes.
This property would work only when script is run in auto-run mode. Providing that this property will be effective only when set together with cqsm:executionMode. It doesn't matter if it will be scheduled, run on startup or when modified.
Few examples:

Script 1 content:
cqsm:executionMode = ON_STARTUP
cqsm:allowedRunModes = [publish,indexer]
instance run modes: publish
RESULT: script won't be run
Script 2 content:
cqsm:executionMode = ON_STARTUP
cqsm:allowedRunModes = [publish,indexer]
instance run modes: publish,indexer,backup1
RESULT: script will be run

This seems a valid usecase for me. Great idea for an improvement.
I was also thinking about using the convention that Sling follows i.e. adding a runmode within the directory/filename. This may require an additional overhead but should be easier to discovery by new users. WDYT?

Yes, that's good idea. Such structure would be more clear for developers.

This should be handled similar to currently existing property apm:launchEnvironment, So we need to extend editor by adding text field for custom run modes, and new property on script node e.g. apm:launchRunMode.


[v6] Accessing errors

From what i understand errors are not part of the store. Is there a way to "bubble" errors or inject all errors into form prop?
// hasErrors = field1.invalid || field2.invalid;
const SomeFieldset = ({ hasErrors }) => (
  <fieldset className={classNames({'error': hasErrors})}>
    <Field name="field1" component="input" type="text" />
    <Field name="field2" component="input" type="text"/>
  </fieldset>
);

I thought i could work around it by setting some state in validate() but it's not possible since it's called in render()

Similar question, how would one go about showing errors for radio buttons? As it is now it appears each radio would have the error displayed next to it - is there a way to get errors to a "group" level above the radios themselves?  Apologies if I'm missing something here.

@babsonmatt what we've done to solve the issue of radio buttons is create a RadioButtoGroup component that is used as a component for Field. Something like this:
const RadioButtonGroup = ({
	children,
	value,
	display,
	touched,
	invalid,
	error,
	...otherProps,
}) => {
	return (

				{
					Children.toArray(children)
						.filter(c => !!c)
						.map(child => cloneElement(child, {
							...otherProps,
							checked: child.props.value === value,
						})
					)
				}

				{
					touched ? error : null
				}

	)
}

Regarding the original issue:
Starting with v6.2.0, getFormSyncErrors and getFormSubmitErrors selectors got added.
Regarding the problem with checkboxes/radios validation: please try, in your validator function, set an error for the name of the <FieldArray>.
The docs contain some interesting ideas on how to do this.


format-default : The collection has not been initialized. It has not been requested or the request has not been executed

Hi,
When trying to add a content type I get the following error:
format-default : The collection has not been initialized. It has not been requested or the request has not been executed. It may need to be explicitly requested.
+ CategoryInfo          : NotSpecified: (:) [format-default], CollectionNotInitializedException
+ FullyQualifiedErrorId : Microsoft.SharePoint.Client.CollectionNotInitializedException,Microsoft.PowerShell.Commands.FormatDefaultCommand
The content gets added but the script errors out.
The full code is below but what seems to cause the issue is writing out the content to the screen: $ctx
When I comment out that line the script works error free.
Am I doing something wrong?
Thanks,
Joe
######### Full Script #############
Connect-SPOnline –Url https://somesite.onmicrosoft.com/sites/joe
$ctx = Get-SPOContext
#if I comment out the line below I get an error after I add the content type
#$ctx
$group = "My Content Types"
$contentTypeName = "My Page TEST"
$ct = Get-SPOContentType -Identity  $contentTypeName
if($ct -eq $null){
# Parent CT "Article Page"
$parentCT = Get-SPOContentType -Identity "Article Page"
Add-SPOContentType -Name $contentTypeName -Description "This is TEST content type" -Group $group -ParentContentType $parentCT
Write-Host "Created Content Type: " $contentTypeName

}
else{
# any updates
Write-Host "Content Type: " $contentTypeName " already exists"
}

Hello. We have some problems with "initialazation" error messages as well, not with content types though, but when creating lists and views. We get this when we try to run the script top to bottom, all at once - however; when just running bits and pieces in ISE, we do not get these problems. We have added som contextvariables (retrieving all the list from the web),trying to solve the problem, but is has not helped.  A little bit frustrating since we need the list GUIDs in order to populate our .webpart(s), pushing them out on pages. The whole process gets stucked! Maybe I am missing out on something, but a nice cup of coffe while the script runs automatically would not be bad! Maybe someone here has an idea of what to do? Help appreciated of course...

Hi Joe,
For my understanding, if you comment out the line
$ctx

then you receive an error after creating the content type?

Erwin,
Commenting out the $ctx apparently just changed where the error showed in the script.
The underlying problem was adding a taxonomy site column and was fixed with help of your post:
https://github.com/OfficeDev/PnP-PowerShell/issues/120
$field = Add-SPOTaxonomyField -GroupName "Test01" etc. etc.
I needed to have a variable for the returned value – the error was PS trying to display unitialized fields.
Thanks,
Joe
From: Erwin van Hunen<EMAIL_ADDRESS>Sent: Thursday, May 5, 2016 8:31 AM
To: OfficeDev/PnP-PowerShell<EMAIL_ADDRESS>Cc: Joe Dunne<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [OfficeDev/PnP-PowerShell] format-default : The collection has not been initialized. It has not been requested or the request has not been executed (#286)
Hi Joe,
For my understanding, if you comment out the line
$ctx
then you receive an error after creating the content type?
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHubhttps://github.com/OfficeDev/PnP-PowerShell/issues/286#issuecomment-217155081


Return resolution_change once parameter is changed

Improper Commit Message
Tracked on not found in commit message,
make sure Tracked-On: Jira-ticket  is present.

Improper Commit Message
Tracked on not found in commit message,
make sure Tracked-On: Jira-ticket  is present.


className option for marks

className should be optional and have no default value, so you have to decide what names you want to use and there are no implicit classes
Related: #253 #6 #126 #490
(Note: for the general plot there is already a top-level className; we'd initially want this only for marks.)

Going to take a first stab at this

This would make my life a lot easier - when you have to do something outside the bounds of plot, being able to specify a class name would be a big help

I can try to have a pull request up this weekend @llimllib, been meaning to do this

This functionality would be an excellent addition. Are there any updates on the progress? It looks like there is a PR, but it hasn't been updated in some time.

Adding support for this issue—I want to further describe a few scenarios where I found custom styling particularly important:

a single plot is embedded in an article as "an additional chart) and needs to blend in with the existing plots of non-observable origin;
plots rely on Observable Inputs, which can be nearly unusable when mixed with specific CSS rules;
even when published mostly in entirety, it is still important to match the notebook style with the navigation bar, etc, see our blog here so the page doesn't feel alien.


LOG-2273: Remove vendor directory

This PR:

Removes the vendor directory

Ref: https://issues.redhat.com/browse/LOG-2273
cc @alanconway @syedriko @shwetaap

Did the .idea directory slip in by accident or is this on purpose?

Good catch. Removed and updated ignore file

/lgtm

/lgtm


Decide on console IO library

Worth checking out:

https://github.com/ticki/termion
https://github.com/murarth/linefeed
https://github.com/basmith/rust-termios
https://cpjreynolds.github.io/rustty/rustty/index.html
https://github.com/gchp/rustbox

At a quick glance, termion looks like it might be one of the better choices, but I'd like to do more research.

I'm also tempted by the idea of rolling our own, for Extra Fun, but I recognise that could take a lot of extra effort y'all might not be up for.

Some nice things about termion:

written in pure Rust, not a wrapper around another library (like curses or termbox)
supports gay space communism
provides a pretty full API, so we don't need to use multiple quasi-compatible libs for different aspects of term I/O


support bare repositories

closes #25

that doesn't actually work. it doesn't look like it's looking for the right file, hold on.

i'll followup both of those in #29, because it's too annoying to manage conflicts in both, let me know if you want to treat those separate.


Is this necessary ???

https://github.com/orbisgis/poly2tri.java/tree/master/repository/snapshots
@nicolas-f

no. Jar should not be in git repository


Can not get device information

Hi,In the use of this plug-in, I have some problems. Do not know why not get the device information.
The information obtained is as follows:
Device ID: 48562027
Model info: Unknown
Address: <IP_ADDRESS>
Token: ???
Support: Unknown
Device ID: 1097069
Model info: Unknown
Address: <IP_ADDRESS>
Token: ???
Support: Unknown
Device ID: 48395663
Model info: Unknown
Address: <IP_ADDRESS>
Token: ???
Support: Unknown
Device ID: 49371632
Model info: Unknown
Address: <IP_ADDRESS>
Token: ???
Support: Unknown
Device ID: 54965957
Model info: Unknown
Address: <IP_ADDRESS>
Token: b0b89550227b8c3caebe86f1359b16a5 via auto-token
Support: Unknown
Device ID: 48282918
Model info: Unknown
Address: <IP_ADDRESS>
Token: b0b10d0edc28ce80ab1bc4f253a2a96a via auto-token
Support: Unknown
(node:3537) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): TypeError: Cannot set property 'device' of undefined
(node:3537) DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
(node:3537) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 2): TypeError: Cannot set property 'device' of undefined

Thank you for the report. This is related to the library currently using hostnames to resolve models, which are not always available. When I get around to fixing issue #27, this should work better for devices where the token is known.


feat: add local sign/list/verification for OCI layout directory

This PR adds local sign/list/verification for OCI layout directory. For RC.4 it only supports storing the generated signature into the target OCI layout and verify signatures within the target OCI layout. Future releases will cover more options.
This PR is based on the corresponding notation-go PR: https://github.com/notaryproject/notation-go/pull/288.
Please review the notation-go PR first.
Resolves #283.

Codecov Report

Merging #595 (7f8e420) into main (124c6c8) will decrease coverage by 2.48%.
The diff coverage is 4.88%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##             main     #595      +/-   ##
==========================================
- Coverage   34.36%   31.88%   -2.48%
==========================================
  Files          32       32
  Lines        1848     2026     +178
==========================================
+ Hits          635      646      +11
- Misses       1192     1359     +167
  Partials       21       21

Impacted Files
Coverage Δ

cmd/notation/manifest.go
0.00% <0.00%> (ø)

cmd/notation/registry.go
13.52% <0.00%> (-2.67%)
:arrow_down:

internal/osutil/file.go
77.96% <0.00%> (-8.83%)
:arrow_down:

cmd/notation/verify.go
18.67% <3.79%> (-5.47%)
:arrow_down:

cmd/notation/list.go
21.59% <4.16%> (-4.88%)
:arrow_down:

cmd/notation/sign.go
29.76% <9.45%> (-10.43%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

@patrickzheng200 @qweeah, will this flag --oci-layout and --scope be marked as experimental in this PR?

@patrickzheng200 @qweeah, will these flags --oci-layout and --scope be marked as experimental in this PR?

@yizha1 Yes, that's the plan. This PR should be merged after https://github.com/notaryproject/notation/pull/613.


stream needs to be instanceof Readable

Describe the bug
Error source object may only be an instance of Buffer or Readable in this environment when trying to upload a stream which is not directly an instaceof Readable.
To Reproduce
Steps to reproduce the behavior:
yarn add<EMAIL_ADDRESS>into-stream

index.js
const tus = require('tus-js-client')
const intoStream = require('into-stream')

// into-stream returns a stream where instanceof stream !== Readable
const stream = intoStream('my test string')

const tusUpload = new tus.Upload(stream, {
  endpoint: 'http://localhost:1234',
  resume  : true,
  metadata: {
    fieldname: 'field',
  },
  onError: console.error,
  onSuccess: () => console.log('done'),
})

tusUpload.start()

node index.js

Error: source object may only be an instance of Buffer or Readable in this environment
    at getSource (node_modules/tus-js-client/lib.es5/node/source.js:234:12)

Expected behavior
Should upload the stream. I'm not sure if it's a bug but I think so, because other libraries handles these kind of streams without problems. For instance form-data uploads it fine.
I think instanceof Readable is not the best way to determine if an object is a readable stream. See:
https://stackoverflow.com/questions/23885095/nodejs-check-if-variable-is-readable-stream
Maybe we can instead do something like this? https://github.com/sindresorhus/is-stream/blob/master/index.js
https://github.com/transloadit/node-sdk/issues/86
workaround hack
const rawStream = intoStream(str)
const stream = new require('stream').PassThrough();
rawStream.pipe(stream);

Setup details
Please provide following details, if applicable to your situation:

Runtime environment: Node.js
Used tus-js-client version: 1.8.0

A quick hint to begin with: tus-js-client 1.8.0 is a bit outdated and the 1.X releases are not maintained anymore. Please upgrade to 2.2.0, which is the latest release (see https://tus.io/blog/2020/05/04/tus-js-client-200.html for breaking changes). It probably won't solve your issue but at least we are talking about the same code.
To being said, I am open to moving to a check which does not rely on instanceof but instead uses something like is-stream. Would you be willing to open a PR for that?

A quick hint to begin with: tus-js-client 1.8.0 is a bit outdated and the 1.X releases are not maintained anymore. Please upgrade to 2.2.0, which is the latest release (see https://tus.io/blog/2020/05/04/tus-js-client-200.html for breaking changes). It probably won't solve your issue but at least we are talking about the same code.
To being said, I am open to moving to a check which does not rely on instanceof but instead uses something like is-stream. Would you be willing to open a PR for that?

Yea sorry, I just assumed that it was the same issue on the newest version because I found the culprit in master also. I tested with v2.2.0 also and it has the same issue. Sure, I can make a PR for it

Yea sorry, I just assumed that it was the same issue on the newest version because I found the culprit in master also. I tested with v2.2.0 also and it has the same issue. Sure, I can make a PR for it


Player freezes a lot

Hi. i have published game but it freezes a lot, does any one have any idea why.

link of the server ? might be related with the bandwith usage .

Thx for the replay.
The link is www.targ.io . Player freezes only on chrome, firefox,opera but not in internet explorer. I did look in network in browser developer tools and saw a lot of connection on chrome, firefox and not stopping.
I am using windows server iis 8.5

indeed it lags (i use chrome). Did you edit the code and which branch did you use ?
It looks like it is client related (app.js) unless you edited the rate at which the server sends visible entities to the client.
try a deploy in heroku, its fast, simple and free, just to have a second view .

I just tested using Chrome. No lag here. I think you all are going bonkers ;)
LOL. Maybe it's your Chrome version. MAKE SURE IT IS UP TO DATE!

Nahh i changed the server thats why there is no lag now


whisperx_youtube_subtitle

2023-06-10 07:37:12.952758: W tensorflow/compiler/tf2tensorrt/utils/py_utils.cc:38] TF-TRT Warning: Could not find TensorRT
No language specified, language will be first be detected for each audio file (increases inference time).
Lightning automatically upgraded your loaded checkpoint from v1.5.4 to v2.0.3. To apply the upgrade to your files permanently, run python -m pytorch_lightning.utilities.upgrade_checkpoint --file ../root/.cache/torch/whisperx-vad-segmentation.bin
Model was trained with pyannote.audio 0.0.1, yours is 2.1.1. Bad things might happen unless you revert pyannote.audio to 0.x.
Model was trained with torch 1.10.0+cu102, yours is 2.0.1+cu118. Bad things might happen unless you revert torch to 1.x.

Performing transcription...
Detected language: en (1.00) in first 30s of audio...
Performing alignment...
Performing diarization...
Lightning automatically upgraded your loaded checkpoint from v1.5.4 to v2.0.3. To apply the upgrade to your files permanently, run python -m pytorch_lightning.utilities.upgrade_checkpoint --file ../root/.cache/torch/pyannote/models--pyannote--segmentation/snapshots/c4c8ceafcbb3a7a280c2d357aee9fbc9b0be7f9b/pytorch_model.bin
Model was trained with pyannote.audio 0.0.1, yours is 2.1.1. Bad things might happen unless you revert pyannote.audio to 0.x.
Model was trained with torch 1.10.0+cu102, yours is 2.0.1+cu118. Bad things might happen unless you revert torch to 1.x.
^C

去掉  --diarize --hf_token hf_eXXXX 应该就好了


Without incoginto mode browser goes insane and take lot of processor time

If you use incognito mode it will work ok!

We found some ideas: My local storage (Chrome) was having a value  ""  for user object. Some how login process went in eternal loop...
There is something odd with registration etc..

This should be fixed in the latest build. Accessing the user will now make sure the value is formatted properly.

Verified as fixed

Closed now


cpuset: add FreeBSD support

competitor to #42 😛

Looks like we have a veritable Olympics on our hands! Yours is the simpler, more elegant solution, plus I trust that you know what you're doing more than I do, so I'll let you take home the gold. 😉

Any chance of a patch release once this is fixed?

But yours arrived much faster, while mine is still attempting to build deps :). I don't actually know that much about FreeBSD, but just went with what seemed to work. I'm surprised our code diverged this much, since I thought I only saw the pthread_getaffinity_np in one header. I also put this in the public header since I am anticipating julia trying to use the header and needing UV_CPU_SETSIZE. But I still have many deps to build before I can test, and miles to go before I sleep.
Either way, your help will be appreciated in converging on a solution through review of both.

alright, I'm taking 👍 as lgtm

Indeed. Thumbs are the universal language.


Verifyfix

addressing all current verify issues

May be worth setting this PR as a draft until ready to be reviewed/ merged

(in future worth addressing issues in separate PRs, also worth using close #issue_num in descriptions if you want the chosen issue to close when merged)


Make cheat sheet sizing dynamic

Well no. It can absolutely be too wide for some screens. The only solution for that would be to adapt the font size depending on the user screen resolution
Originally posted by @AndreasArvidsson in https://github.com/pokey/cursorless-talon/pull/1#discussion_r666427836

I think the idea would be to render the cheatsheet with width 0 first in order to measure it, then render it with the proper width.  Right @AndreasArvidsson ?

That's one approach I'm going to try. Figuring out the correct font size based on the user screen resolution is more problematic.

@pokey It's tze döne!

weird it didn't auto-close.  Maybe you need to say "closes #15" instead of "issue #15"?  Idk


Training configuration

Hi!
Your project is so interesting and I would like to try to do my own training but I have some doubts regarding the configuration. For how many epochs and iterations per epoch have the models you provide been trained?
Thank you!

Hi,
The pretrained weights we provided have been trained over 400 epochs, with each epoch comprising 10 iterations.


Evaluate Hardware Interface and Zero Gravity URDF tags in Baxter

@rethink-hmalaichamee updated Baxter's URDF to use extra tags to work with baxter_simulator in Indigo/Gazebo 2.0 via PR #57 . He said the following:

I had added the  tag under each link in the URDF to turn off the gravity for those links. Unfortunately, it showed no effects and I had to do the above specified method to disable gravity. Need to remove those tags and test if it works.
In the URDF  tag was added to the joints as required (in Indigo) in addition to those in the actuators. Rob asked me to remove them from the actuators since they are no more mandatory. However, this had an error that caused the simulator to fail when there was no such tag for the actuator. This needs to be removed and tested.

I am merging these tags since I've tested the URDF with them and they work, but I would like to know more about them & make sure they are necessary.

This PR is more or less resolved by the commits in #71

Out of curiosity why was gravity turned off in the URDF? Seems like a nice feature to have in a physics simulator...


pinging the server

Might be good to send PING requests to server every 1 minute or so, and reconnect if it doesn't respond with PONG

[22:55]	ThePhilgrim	Akuli, did you reply before? I didn't notice was disconnected for a long while
[22:55]	Akuli	yeah, mantaray doen't yet ping the server to check if it's still connected


There isn't the ability to justify text left right or centre

Plz add. Thanks you. You're the best ever, @JakeSidSmith. 😊

* There is, but there isn't the ability to justify text.


[release/v1.5] Update terraform provider for VMware Cloud Director

What this PR does / why we need it:
Manual cherry-pick for https://github.com/kubermatic/kubeone/pull/2583.
Which issue(s) this PR fixes:

Fixes #
What type of PR is this?

/kind feature
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:

* Update terraform provider for VMware Cloud Director to v3.8.1
* Support for insecure HTTPS connection to VMware Cloud Director API in the terraform example

Documentation:

NONE

/lgtm
/approve


There is no way to load the the package in angular 6.0

All the time that I try to make an import in angular 6.0 like this:
import * as UltraCartRestApiV2  from 'ultra_cart_rest_api_v2';
I get tons of errors error like this:

Module not found: Error: Can't resolve 'com.ultracart.admin.v2.models/CouponAmountOffSubtotalWithItemsPurchase' in '/Users/bb/Projects/Code/inteliclic/SkinTypeWeb.V2/node_modules/ultra_cart_rest_api_v2/src/com.ultracart.admin.v2.models'
ERROR in ./node_modules/ultra_cart_rest_api_v2/src/com.ultracart.admin.v2/CouponApi.js
Module not found: Error: Can't resolve 'com.ultracart.admin.v2.models/CouponCodesRequest' in '/Users/bb/Projects/Code/inteliclic/SkinTypeWeb.V2/node_modules/ultra_cart_rest_api_v2/src/com.ultracart.admin.v2'

[Perry removed many lines of the same type of error]
The error is bigger, but I really don't know what to do, any suggestions ?

Are you using webpack?  If not, what are you using?

If you're using webpack, you might need this:
module: {
	rules: [
		{
			parser: {
				amd: false,
			},
		},
	],
},

I am just using simple ng serve, but I don´t see any webpack compiler

any idea ?

Sorry, I don't know.  We're not an angular shop.  I hate to see you stonewalled by an issue like this.  Is there any way you can put together a simple skeleton that produces this error and provide us a zip file?  If I can pull it up inside an editor and play with it, I might be able to better advise.  My apologies on the poor support.  We just haven't had the time to work with angular and our sdk.

Yes I can create a small public project to show you the issue, we can both try to fix it. I had to continue with another solution, but it would be awesome to create a solution/integration for upcoming angular developments


0.4 compatibility

With these changes, using ApproxFun works, although the tests still fail and there are many deprecation warnings (WARNING: [a,b] concatenation is deprecated; use [a;b] instead).

Shoot, probably needs to be redone, since I patched the tagged version rather than master

I updated ApproxFun for v0.4 (again).  All the tests now pass.


Sync-01 - 10/30/2022

Final sync-off before a dev workflow change.
Includes:

Apollo (new errata tool)
Misc changes to utils
Deletes secparse
Misc fixes

/retest

/retest

/ok-to-test

/retest all

/test all

/lgtm


Reduce the update frequency if the app is in the background and there are no windows open

Tagging this as a bug as, right now, the app is pretty agressive with checking for build status updates.


feat!: remove New Relic from Makefile & deprecate Travis

Description
Remove New Relic from Makefile
Since New Relic is an edX-specific thing, we have moved to injecting this in code in our internal Dockerfile repos.
This PR removes recipes for generating New Relic Docker builds from edx-cookiecutter Makefile rules, which I neglected to do in a previous PR.
This PR affects recipes in Makefile rules:

docker_build
travis_docker_tag
travis_docker_auth
github_docker_build
github_docker_tag
github_docker_push

Deprecate Travis CI Code
I think we have shifted from supporting Travis CI to GitHub Actions.
This PR proposes to remove Travis-related files and code from our edx-cookiecutter templates.
Additional Information

History: I previously removed New Relic from the edx-cookiecutter Dockerfile in https://github.com/openedx/edx-cookiecutters/pull/173.
Motivation: The presence of these recipes without the Dockerfile code causes a GitHub Action failure. See, e.g., this GitHub Actions run.
See also: @MichaelRoytman's comment on https://github.com/edx/edx-exams/pull/2

Checklist

[ ] All reviewers approved
[ ] CI build is green
[X] Changelog record added
[X] Documentation updated (not only docstrings)
[ ] Commits are squashed

fyi: @MichaelRoytman


The most optimal audio settings for training dataset preparation?

Previously I trained on a small dataset where the speaker was recorded in a single shot (so the volume level and quality never changed for the entire duration of it), the resulting model sounded promising (it was just for testing) so I decided to train on a larger dataset afterwards where the speaker was recorded in mutiple shots on different places and equipment (so the volume levels and quality varied), the resulting model was a disaster, had an insanely high volume, so much that it could ruin your eardrums if you kept your earphones on, clipping and screeching almost all the time. However, none of the training dataset sounded too high or weird at all, the sound levels were pretty much normal to the ear and never hit the red bar, so I guess all these audio files need to be normalized/processed first such as having all the same optimal dB volume level or things can go horribly wrong, what parameters do you suggest using for the audio data to get the best of it? Of course I converted them all at 22050 Hz mono.

Share an image of the training and validation loss such that we can investigate better.

Here's the image of the training and validation loss and the rhythm (alignment map) and the pitch contour (f0) used during inference.
The style transfer results are likely going to get better considering how early the train is (checkpoint at 35500 iterations, I also have it at 36000 but it couldn't generate any sound for some reason), however, the singing voice results are insanely loud and clipping most of the time, which is weird because I don't remember it to be like this with the previous dataset I tested.
I have shared the entire dataset here if you would like to check, thanks!

Set the smoothing factor of your validation loss to 0 and zoom in such that we can take a look at the curve. My suspicion is that your not picking the model with the lowest validation loss.
Also, would love to hear singing samples from donald trump if you have them :-)

I went for a GIF, hope it's clearer now:
No zoom: https://i.imgur.com/NsMzzTO.gif
With zoom: https://i.imgur.com/HmkV5X7.gif

Just zoom in on the long line after the big drop such that we can see the variation on that line.

Alright, I hope it's better now: https://i.imgur.com/VRHpvd9.png
Oh and I'll definitely share some Trump samples as soon as I can get decent results, the ones I made weren't worth keeping, in the past I synthesized some songs using Trump voice but I used a completely different method than the one adopted here, so I'm not sure if this is the place to share them as they're unrelated to this repo, perhaps your email?

The training and validation curves, alignment and other things look fine.
Your data seems to have audio files from multiple speaker. This might be the cause.

Can you share your batch_size and how many steps when you get this good result? @AndroYD84

@daxiangpanda I haven't changed any parameters other than pointing my own dataset and training with the LibriTTS pretrained model provided. However this time I'm using a new dataset (4750 files, total duration 2h 55m) as the old one had a few transcription errors, I manually checked that the audio transcriptions were perfect this time.
The super loud screech I experienced before was still present at the beginning, but disappeared the more I kept training, I'm just beginning to get listenable results at 235000 iters.

Closing due to inactivity.


The toast examples don't work in the docs

Description
Clicking on the toast buttons in the doc examples don't do anything (ref: https://gluestack.io/ui/docs/components/feedback/toast)
CodeSandbox/Snack link
No response
Steps to reproduce

Go to: https://gluestack.io/ui/docs/components/feedback/toast
Click on any of the buttons in the examples
Nothing happens

gluestack-ui Version
N/A
Platform
N/A
Other Platform
No response
Additional Information
This happened on brave browser

Thanks for reporting this @richawo. We're working on it.

Hey @richawo, Issue is fixed.


ci: prepare Jenkins jobs for Kubernetes 1.30

Kubernetes 1.30 is in Alpha state, it should be usable for testing
Ceph-CSI against now.
Signed-off-by: Niels de Vos<EMAIL_ADDRESS>

@mergifyio queue

/test ci/centos/jjb-validate

/test ci/centos/job-validation

/test ci/centos/job-validation

/test ci/centos/job-validation

This is running at https://jenkins-ceph-csi.apps.ocp.cloud.ci.centos.org/job/ci-job-validation/312/console , but no status update in this PR :disappointed:


Server pagination not working

Pagination and Sorting should be handled through the server. To load my data from the backend I´m using the following method:
this.loadData('sortColumn', 'ASC', this.currentPage, this.options.limit)
        .subscribe(ratings => {
        this.rows = [];
        this.rows.push(...ratings.ratings);
        this.endRow = this.options.limit * (this.options.offset + 1);
        this.maxRows = ratings.recordsTotal;
        if (this.maxRows < this.options.limit) {
          this.endRow = this.maxRows;
        } else if (this.maxRows < this.endRow) {
          this.endRow = this.maxRows;
        }
        this.options.count = this.maxRows;
  }, error => this.errorMessage = <any>error);}

this.rows is the variable I´m binding to the data-table-template:
<datatable class="rating_table" [rows]='rows' [options]='options' (onRowClick)='onRowClick($event)' (onPageChange)='onPage($event)'>
My problem is when I´m loading the first page the data binding ( this.rows.push(...ratings.ratings))  works and in the table my ratings are shown, but when I´m loading the second page the new ratings are saved into the this.rows object but the table is not refreshing the ratings from page one are still visible.

Please make a demo in plunkr.

Same problem here, it looks like angular2-data-table is looking for options.offset + 1 in rows, instead of getting a completed new "buffer" starting from 0...

Offset + 1 is because offset is 0 based, for paging there is no 0. :)

I will prepare and post an example tomorrow

I prepared a small example to show the problem:
https://plnkr.co/edit/jTf0ospsvh5TzhOQtdQp?p=preview
I´m setting new rows every time the user switches from one page to another:
this.rows = [];
    if(pageNumber === 0){
      this.rows.push(...this.page1Data);
    }else{
      this.rows.push(...this.page2Data);
    }
    this.options.count = this.page1Data.length + this.page2Data.length;
    console.log(this.rows);`

if you look at the console the rows object is updated with the new data but the page is not refreshing. I hope you can help me.

Could you please help me with my problem

I had a similar problem. The trick is to update the rows Array in a different way. See
https://plnkr.co/QfS4KyU7oNYCFXb2S22A

@amcdnl is there need for more info, yet ?
I think the problem is: the first line of grid must be the first element of array (row[0]) at least in server-side mode.
Thanks @robertbachmann for the workaround !

Same problem here. IMHO the the right behavior should be the out pointed out by Juracy:
"the first line of grid must be the first element of array (row[0]) at least in server-side mode, regardless of the page or offset."

Thanks @robertbachmann for the workaround. @amcdnl  any update on this. I do have the same Issue. Also I would like to have Virtual scrolling from the server pagination. This will be Quite helpful when you browse from mobile (Similar to Gmail .. and others)

+1
I have server-side pagination working but I'm getting 'Cannot read property '$$expanded' of null' when trying to set rows = [].
I'm just realizing that the pagination expects you to insert the rows at the offset. Struggling to figure out how to properly reset the rows and essentially start over. The suggestion from @robertbachmann helped get the initial server-side working.

When is this going to be addressed? It seems to me that server side pagination should not use the offset the way client side pagination does. The entire point of server side paging is to not have to store all results in memory as the workaround does.

Any update on when we can expect real server-side pagination?

I am currently investigating/working on server side pagination & virtual scroll problems (#353), and this seemed related.
The server side pagination does seem to cache all data, so once a page has loaded, it will remain in the rows array unless you manually clear it out like in the described workaround above.
The fix I was going to attempt was to use calculations to get the correct virtual scroll height, but try to continue leaving all of the data already loaded in the rows array because that is what it is doing now. See the conversation in #353.
Are people saying the correct behavior should be when loading new pages, the older pages should no longer be kept in memory and re-fetched when scrolling back to that page?
@java2kus, any thoughts on the discussion in this thread that might weigh into #353? Maybe this is what you were trying to convey from this comment and I just haven't put the pieces together yet.

I think $$index is the problem, when you click the second page or third page, etc. It doesn't add the $$index attribute to the objects on those selected pages. It only adds that attribute to the objects belonging to the first page.

Is there any progress on this? I think this is a critical bug.

@PatrickHuetter, this has not been fixed yet, and I haven't made any more progress on it has I have been busy at work.
There are some existing questions out from my last post. It might be more helpful to give input on those questions, so we can more quickly come to a solution.
@java2kus, I know you are very busy, but would you have a sec to look over the questions I listed above?

Okay I see now there may be two issues.
1. Server side pagination with vertical virtual scroll enabled
This is more the subject of what I was talking about in my previous posts. This is related to #353.
2. Server side pagination without vertical scroll enabled, using the paging mechanism
It seems even when fetching and setting the correct position in the rows array, the new data does not display on the server which is directly a duplicate of #486. It looks like if you mutate the array the change detection does not get fired. If you set the rows property to be a brand new array, then change detection picks up and the data will show correctly.
This is why the demo site for server pagination also sets a new array. I guess this could be considered a bug and when you mutate the array it should also update the data for the table. This would not address the issue of the table keeping more than one page or data in memory when you change pages, but rather all pages which have been loaded before.
@amcdnl, @java2kus, thoughts?

Any development on this issue?
To be honest, i can't use the component until paging works - and i really like the look and the features of this component so i'd love to see it working.

When I show data list thought a Web Service, it only loads data by offset and limit if the Web Service supports pagination.
I think the implementation of this datatable is based giving JSON file.
If we need to call a Web Service to show the data, the this.indexes.first would be always 0, because the data loaded by Web Service always start in index 0.
Then I commented this line of code //first = Math.max(this.offset * this.pageSize, 0);
In my case, I never load the data using JSON file.
Go into the ngx-datatable app and edit updateIndexes()
updateIndexes(): void {
    let first = 0;
    let last = 0;

    if (this.scrollbarV) {
      // Calculation of the first and last indexes will be based on where the
      // scrollY position would be at.  The last index would be the one
      // that shows up inside the view port the last.
      const height = parseInt(this.bodyHeight, 0);
      first = this.rowHeightsCache.getRowIndex(this.offsetY);
      last = this.rowHeightsCache.getRowIndex(height + this.offsetY) + 1;
    } else {
      //first = Math.max(this.offset * this.pageSize, 0); HERE!!!
      last = Math.min((first + this.pageSize), this.rowCount);
    }

    this.indexes = { first, last };
  }

Then in the component add this.
1. Variables
rows = [];
count: number = 0;
offset: number = 0;
limit: number = 10; //Whatever you want

2. ngOnInit()
ngOnInit() {
    this.fetch();
}

3. fetch()
fetch(event?) {
    if(event) this.offset = event.offset;
    this.callService.list('url', this.offset, this.limit).subscribe(
      data => {
        this.count = data.total; //Web Service gives me the total
        this.rows = data.list; //Web Service gives me the data
      },
      null,
      () => {

      }
    );
}

4. ngx-datatable tag
<ngx-datatable
        class="material"
        ...
        (page)='fetch($event)'> <!--Here--> ...
</ngx-datatable>

In my opinion, this datatable should have a flag to identify when we load data from JSON file or Web Services.

@stefmabo, I believe this flag already exists. externalPaging input on the table. If it is false, all of the rows are loaded client side, and if it is true, you are fetching it from a server. Is this what you meant?
@amcdnl, I believe this can be closed.
I think the solution for this specific ticket is just do not mutate the rows array, set a new one.

@deeg client side and server side examples are using JSON files.
What happens when we load data from Web Service?

@stefmabo, I'm confused at what you are trying to do. Are you trying to fetch data from a web server but without pagination?
Just fetch it with a service outside of this library and pass in the data to a rows array. Make server side pagination false. I think this help is better suited for StackOverflow.

Are you trying to fetch data from a web server but without pagination?
No, I need a pagination.
The problem is with indexes.
When I load the data using Web Service and I click second, third page, The rows are empty.
Just in the first page the data shows.

I have been struggling with this issue also, and i found a solution for now. I took the sample code from: https://github.com/swimlane/ngx-datatable/blob/master/demo/paging/paging-server.ts
and found that in case of server side paging with an API, there is actually 1 thing incorrect: where you loop over the rows, the sample uses i as indexer, which is correct in case of a json file with all data, however if you run it against an API, you usually get only the result set of a page, so changing the source code to the snippet below will make your server side paging on an API work
   var j = 0;
   for (let i = start; i < end; i++) {
        rows[i] = results[j];
                j++;
   }

@bc3 That workaround works, but the table jumps when you click next page, producing an visual error.
If you edit body.component.ts > updateIndexes()
And comment a line of code like this
updateIndexes(): void {
    let first = 0;
    let last = 0;

    if (this.scrollbarV) {
      // Calculation of the first and last indexes will be based on where the
      // scrollY position would be at.  The last index would be the one
      // that shows up inside the view port the last.
      const height = parseInt(this.bodyHeight, 0);
      first = this.rowHeightsCache.getRowIndex(this.offsetY);
      last = this.rowHeightsCache.getRowIndex(height + this.offsetY) + 1;
    } else {
      //first = Math.max(this.offset * this.pageSize, 0); HERE!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
      last = Math.min((first + this.pageSize), this.rowCount);
    }

    this.indexes = { first, last };
  }

The effect of jumping dissapears.

@stefmabo - can you PR this?

@stefmabo - that would indeed be a good idea, because i cannot change body.component.ts , because we work in a team with NPM_modules on each developer environment ..

I'm testing before PR this.
I don't know if commenting that affect other components, then I prefer check, after that I will PR.
For now, go into<EMAIL_ADDRESS>a find with ctrl+f updateIndexes()
and the first line of code after else is:
first = Math.max(this.offset * this.pageSize, 0);
Comment that.

@amcdnl Once this is fixed , can you also add this fix to 6.x.x version too? 7.0 version is not working for us, as  we haven't upgraded to angular 4 yet

@amcdnl any update on this?

@stefmabo 's solution (comment) doesn't work with the 7.1.1 version, unfortunately.

Is this actually fixed?  Cause I've spent hours trying to get it working and I'm kinda peeved that I've only just found this thread.  I'm using 7.2.1 with angular v4 and getting the exact same error still.

Apparently it is still in the roadmap, not fixed yet
On Apr 8, 2017 1:57 AM, "Robert Balfre"<EMAIL_ADDRESS>wrote:

Is this actually fixed? Cause I've spent hours trying to get it working
and I'm kinda peeved that I've only just found this thread. I'm using 7.2.1
with angular v4 and getting the exact same error still.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/swimlane/ngx-datatable/issues/138#issuecomment-292695229,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFJqkDe6guOlGX5c8TE47QMg9-z0j9AFks5rtxO0gaJpZM4KC-73
.

Maybe they should drop the demo then, its pretty misleading.

I am using sever side pagination without virtual scroll without problem. I have seen people have the index error when they are not setting the count prop correctly.
Are you having issues with sever side paging without virtual scroll?

Tecnically it is server side, but without pagination. But as everyone else
here, we expected to be 100% server side
On Apr 8, 2017 2:01 AM, "Robert Balfre"<EMAIL_ADDRESS>wrote:

Maybe they should drop the demo then, its pretty misleading.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/swimlane/ngx-datatable/issues/138#issuecomment-292695379,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFJqkMy9XnnbXiGqGbN9DWiRKu4r3Lv0ks5rtxSxgaJpZM4KC-73
.

@deeg what is virtual scroll?  And I sent the count prop to the total count of items in the dataset (not the number of items returned on that page), is that correct?

So I'm correct in thinking there there is currently NO support for server based pagination?  Unless you return the entire dataset (which defeats the entire point of server based pagination for 99% of people).  I'd really suggest making it much clearer on the demo of it's limitations.

@rob-balfre, that is incorrect, it works with server side pagination. You do not have to load all the data from the start, but rather only the first page.
The one issue which still does exist is once a page has been loaded, it is always kept in memory. Those rows are not always rendered in the dom, but once a page is fetched the data is always kept around and never refetched.
I am not at a computer so cannot provide an example tonight, but the sever side pagination demo is a good place to start. You need to make sure you are not mutating the rows array, but rather setting a new instance once you load a new page as the demo code does.
If you are still having issues I suggest you open a new issue with a reproducible plunker so someone can better assist you.
To reiterate, if you are using the footer paging mechanism you should have NO problem doing sever side pagination and not loading all the data at once...

So I'm correct in thinking there there is currently NO support for server based pagination? Unless you return the entire dataset (which defeats the entire point of server based pagination for 99% of people). I'd really suggest making it much clearer on the demo of it's limitations.

There is support for server pagination. My demo uses a JSON file for demonstration purposes, here is an example of server pagination.
  async page(offset, limit) {
    // example: offset = 1, limit = 5
    const nextData = await myService.get({ offset, limit });

    // response from sever
    // nextData = { count: 100, data: [ {}, {}, {}, {}, {} ] }

    // get index to insert
    const start = offset * limit;

    // add new results to rows
    this.myRows.splice(start, 0, ...nextData);
  }

In this demo, I make a request to my server api with the offset ( page number - 1 ) and limit ( page size ). The server responds with that dataset only. Then I calculate the first index of the new data and insert the data into that position. Also, make sure you have externalPaging turned on.
If you want to ensure you don't make a request to your server every time you scroll, you can implement some simple caching like this:
  async page(offset, limit) {
    // example: offset = 1, limit = 5

   // create a cache of limit w/ simple flag
   // cache = { 1: true, 2: true, 3: true }
   if(this.cache[limit]) return;

    // if no data found, go ahead and make request
    const nextData = await myService.get({ offset, limit });

    // response from sever
    // nextData = { count: 100, data: [ {}, {}, {}, {}, {} ] }

    // get index to insert
    const start = offset * limit;

    // add new results to rows
    this.myRows.splice(start, 0, ...nextData);
  }

In this example, I added a cache hash that stores if request has been made or not. If it has been made, do not make the request to the server, otherwise proceed to request and insert into the rows. This allows me to track this myself and implement cache busting if my needs require such.
Does this answer everyone's question regarding this matter? If not, please provide me some details and I'll be happy to help fix!

@amcdnl thanks so much,  really appreciate  it.  I'll give it a go today.

No more error which is great, but only shows results on page one. Even though the new data is in there and correctly ordered.  Even stranger if you just concat the old and new arrays on page change instead of splicing it works but that creates a massive array after a few pages.
Why does it even need the old data in there?  Doesn't make sense for server based data.

@rob-balfre - can you show your implementation of pushing data in?

@amcdnl Afraid not.  I decided to just use my own table / pagination solution.
I wasn't doing anything unusual though. Just followed the example.

I admittedly haven't tried this for a few weeks but last time I checked the server-side pagination wasn't working as expected, at least not with virtual scrolling enabled.  I too had to go with a custom solution as a stop-gap. Feelsbadman :(

@amcdnl , the solution @stefmabo provided above to comment out a certain line in node modules works. The problem is  i cannot change body.component.ts , as we work in a team with npm modules. Can we have this fix in 6.3.0?

The solution from @stefmabo stops the client-side pagination :(.
And in my software, i use both.

@rob-balfre @alexweber - Sorry to hear, would have gladly accepted a PR that we could have shared with the community and others.
@psreeks - As @daibertdiego states that will break client side.
Has anyone tried my suggestions above?

@amcdnl I meant custom solution as in dropping this package entirely... If I had code to contribute on this matter you can be sure I woulda done it 👍

Wish I'd have found this thread before spending two days trying to implement server side pagination :(

I have tried @dcesiel solutions => #714 .
And It works properly.

Both server-side paging via pager and virtualization is released in 9.0!!


native tls vendored feature

small change to enable the use of native-tls-vendored feature in reqwest
was having openssl issues and this was the only way i could build: https://github.com/seanmonstar/reqwest/issues/377

Hey thanks for tue pull request and sorry for the delayed response.
can you please rebase with the master Branche, there are changes in the GitHub workflows to run some limiting and the tests.

@Haennetz I have merged the master branch 👍

Thanks @Haennetz 🚀


Enables running with 0 workers to support assistants

Description
Changes how worker.run works to make it compatible with running 0 workers. This allows scheduler verification of whether the worker needs to stay alive.
Motivation and Context
In order to allow assistants to take care of running all tasks, we need a
way to run scheduling with 0 workers. This adds a slightly tweaked worker
code path to allow a process with 0 workers to stay alive while skipping
any get_work calls to the scheduler. Instead, the worker makes a
count_pending call to see if it's still necessary.
count_pending returns the pending count and unique count as well as a new
pending last scheduled count, which counts the number of pending tasks
which haven't been scheduled by another worker since the current worker
first scheduled it. This last count is important because it allows enough
workers to stay alive to keep all tasks scheduled. If we use unique counts
to keep workers alive, all workers could die at the same time leaving
nothing running. If we use pending counts, all workers will stay alive,
preventing new tasks from being scheduled via locks.
In order to minimize code changes, the pending last scheduled count is
stored into the same variable used for unique pending counts in standard
workers. This makes slightly misleading messages but that can be fixed
later if it bothers anyone.
These workers should be used with keep_alive and count_uniques both set
to true. I'll add documentation about this to the luigi patterns doc once
I've solved more of the issues I'm having with assistant-based workloads.
Have you tested this? If so, how?
I have included unit tests and I've been using this in production for about a month.

A squash merge should be fine, unless there's something you wanted in a separate commit.


Extra Parentheses wrongly generated

class addFinal extends scala.annotation.StaticAnnotation {
  inline def apply(defn: Any): Any = meta {
    defn match {
      case something @ q"..$mods class $tname[..$tparams] ..$ctorMods (...$paramss) extends $template" =>
      val finalMod = collection.immutable.Seq(Final()) ++ mods
      q"..$finalMod class $tname[..$tparams] ..$ctorMods (...$paramss) extends $template"
    }
  }
}

 @addFinal
 case class Person(v: String) extends Human

final case class Person(v: String) extends Human()
The extra parentheses on Human shouldn't be present!
@ q"..$finalMod class $tname[..$tparams] ..$ctorMods (...$paramss) extends $template"
res4: Defn.Class = final case class Person(name: String) extends Human

Are we talking IntelliJ integration here?

The parentheses come from the converter
// original
@Main
object MainExample extends B {
  println("Hello scala.meta macros!")
}
// converted
object MainExample extends B() { println("Hello scala.meta macros!") }

I'm trying to understand why it matters whether the parentheses are there or not. Both alternatives (with and without parentheses) are semantically equivalent. Moreover, macro expansions never get prettyprinted except for IntelliJ support.

From end user perspective, not getting the same thing what was initially present is a bit misleading. Apart from that as previously stated, they are same and compiles fine.

I cannot seem to reproduce this at all.
syntactic("class X extends Y")
syntactic("class X extends Y {}")
syntactic("class X extends Y { println(\"foo\") }")

I'm presuming this was fixed in #144


Docker - Build Context Support

Adding build context support for docker. creates Dockerfiles's as temp files, instead of sending to docker CLI using stdin. this allows the use of commands like ADD and COPY. See PR https://github.com/portertech/kitchen-docker/pull/133 for discussion.

This PR provides required functionality for https://github.com/portertech/kitchen-docker/pull/137 and ability to pass in a Dockerfile via any other means.

Alternate approach that might be a bit nicer:
output = Tempfile.create('Dockerfile', Dir.pwd) do |tempf|
  tempf.write(dockerfile)
  docker_command("#{cmd} -f #{tempf.path} .")
end

That ensures a safe tempfile and that it always gets unlinked even if an exception is raised.

Also issues with symlink redirection attacks and bad umask.

@coderanger whatever you prefer... updated :)

@coderanger bump any chances of getting this merged?

You would have to talk to @portertech, I don't have commit bits.

@coderanger thx, no probs. Fixed a pretty critical bug with this today anyways :)
@portertech - thoughts? Able to merge?

I'd probably update your Gemfile to point to your forked version. PR merges are usually pretty slow on this driver.

Already have :)
Nathan Sullivan
Sent from a mobile device

On 10 Jul 2015, at 3:51 pm, Peter Abbott<EMAIL_ADDRESS>wrote:
I'd probably update your Gemfile to point to your forked version. PR merges are usually pretty slow on this driver.
—
Reply to this email directly or view it on GitHub.

@portertech @coderanger just an FYI - I have been running my branch (which is this PR and https://github.com/portertech/kitchen-docker/pull/137 ) of kitchen-docker since this PR was created, doing about 8-10~ instances on our Jenkins CI server. So far so good.

Tested .close in place of .rewind locally, worked fine. Branch/PR updated.

:+1:


Organize documentation about Application and WindowSpecification objects better

at the root folder and in the OS specific implementations.

As a first step, I can fix the documentation generation in atspi branch


Time series chart fixes

Fix tick formatting (for noleap years?)

Derive date specifically from date_strings

WIP fix to memo-ize chart line computations

Closing as the first fix included here was fixed in this PR and I've opened two issues to track the performance-related improvements.