HBASE-22812 InterfaceAudience annotation in CatalogJanitor uses fully…

…-qualified name

Will merge after the qa.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
78
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1
mvninstall
447
master passed

+1
compile
69
master passed

+1
checkstyle
110
master passed

+1
shadedjars
385
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
48
master passed

0
spotbugs
314
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
312
master passed

_ Patch Compile Tests _

+1
mvninstall
410
the patch passed

+1
compile
70
the patch passed

+1
javac
70
the patch passed

-1
checkstyle
97
hbase-server: The patch generated 1 new + 6 unchanged - 1 fixed = 7 total (was 7)

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
365
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
1199
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
41
the patch passed

+1
findbugs
306
the patch passed

_ Other Tests _

-1
unit
18777
hbase-server in the patch failed.

+1
asflicense
39
The patch does not generate ASF License warnings.

23231

Reason
Tests

Failed junit tests
hadoop.hbase.client.TestSnapshotTemporaryDirectory

hadoop.hbase.master.TestAssignmentManagerMetrics

hadoop.hbase.io.hfile.bucket.TestBucketCache

hadoop.hbase.replication.TestReplicationDisableInactivePeer

hadoop.hbase.replication.TestReplicationSmallTests

hadoop.hbase.regionserver.TestSplitTransactionOnCluster

hadoop.hbase.client.TestFromClientSide

hadoop.hbase.replication.TestReplicationSmallTestsSync

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-462/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/462

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 04844dff8fa1 4.4.0-143-generic #169-Ubuntu SMP Thu Feb 7 07:56:38 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-462/out/precommit/personality/provided.sh

git revision
master / 07c6bb16e7

Default Java
1.8.0_181

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-462/1/artifact/out/diff-checkstyle-hbase-server.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-462/1/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-462/1/testReport/

Max. process+thread count
4939 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-462/1/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

The QA looks fine to me. The test failures are unrelated.

Actually, @syedmurtazahassan the import order is wrong. Could you please rectify it? It's weird that the QA bot didn't point it out as a -1, even though it's pretty obvious here: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-462/1/artifact/out/diff-checkstyle-hbase-server.txt . Will file a separate jira for that.

Yes Stack, I definitely think it should be < +1 or else it can be overlooked easily. (-0 being preferred).

@jatsakthi
should i change the import order?

@syedmurtazahassan Yes, please.

@jatsakthi
Thanks for your comments.
Changed the import order and now the checkstyle issue is gone.

Thanks for the quick fix @syedmurtazahassan . Let's wait for the QA.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
110
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1
mvninstall
360
master passed

+1
compile
62
master passed

+1
checkstyle
91
master passed

+1
shadedjars
301
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
39
master passed

0
spotbugs
293
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
292
master passed

_ Patch Compile Tests _

+1
mvninstall
350
the patch passed

+1
compile
63
the patch passed

+1
javac
63
the patch passed

-1
checkstyle
86
hbase-server: The patch generated 1 new + 6 unchanged - 1 fixed = 7 total (was 7)

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
300
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
1041
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
36
the patch passed

+1
findbugs
285
the patch passed

_ Other Tests _

-1
unit
16235
hbase-server in the patch failed.

+1
asflicense
34
The patch does not generate ASF License warnings.

20119

Reason
Tests

Failed junit tests
hadoop.hbase.master.TestAssignmentManagerMetrics

Subsystem
Report/Notes

Docker
Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-462/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/462

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 9d32fb7609b7 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-462/out/precommit/personality/provided.sh

git revision
master / a9773ec5e8

Default Java
1.8.0_181

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-462/2/artifact/out/diff-checkstyle-hbase-server.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-462/2/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-462/2/testReport/

Max. process+thread count
4626 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-462/2/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
46
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1
mvninstall
418
master passed

+1
compile
76
master passed

+1
checkstyle
106
master passed

+1
shadedjars
340
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
47
master passed

0
spotbugs
336
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
333
master passed

_ Patch Compile Tests _

+1
mvninstall
384
the patch passed

+1
compile
79
the patch passed

+1
javac
79
the patch passed

+1
checkstyle
122
hbase-server: The patch generated 0 new + 6 unchanged - 1 fixed = 6 total (was 7)

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
306
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
1009
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
34
the patch passed

+1
findbugs
254
the patch passed

_ Other Tests _

+1
unit
9282
hbase-server in the patch passed.

+1
asflicense
25
The patch does not generate ASF License warnings.

13288

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-462/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/462

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux ced9debd5fde 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-462/out/precommit/personality/provided.sh

git revision
master / a9773ec5e8

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-462/3/testReport/

Max. process+thread count
4479 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-462/3/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.


Started to migrate to vertx-sql-client.

Codecov Report

Merging #19 into master will decrease coverage by 0.34%.
The diff coverage is 56.25%.

@@             Coverage Diff              @@
##             master      #19      +/-   ##
============================================
- Coverage     82.27%   81.93%   -0.35%
  Complexity       60       60
============================================
  Files             8        8
  Lines           237      238       +1
  Branches          5        5
============================================
  Hits            195      195
- Misses           38       39       +1
  Partials          4        4

Impacted Files
Coverage Δ
Complexity Δ

...postgres/ReactivePostgresSessionConfiguration.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

...upport/ReactivePostgresSessionSchemaPopulator.java
90.9% <100%> (ø)
10 <3> (ø)
:arrow_down:

...on/postgres/ReactivePostgresSessionRepository.java
86.7% <75%> (ø)
39 <5> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e75dd36...db04d1f. Read the comment docs.


Typo "Azure blob"→"Azure Blob"

https://learn.microsoft.com/en-us/javascript/api/@azure/search-documents/indexingparametersconfiguration?view=azure-node-latest
<EMAIL_ADDRESS>#PingMSFTDocs

Learn Build status updates of commit e1cc9ef:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

<EMAIL_ADDRESS>:white_check_mark:Succeeded
View (azure-node-latest)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


Change Fixture name to auto.vars

what

Change the fixture extension to auto.vars

why

New versions of terraform require it

references

https://learn.hashicorp.com/terraform/getting-started/variables.html

@sivarita
thanks for the suggestion.
We explicitly use the file name in the Terratest https://github.com/cloudposse/terraform-aws-eks-cluster/blob/master/test/src/examples_complete_test.go#L65
The example is deployed by the terratest and the outputs are checked.
We use that pattern in all our repos, no need to update that.


Unsovled commitment conflicts found in data preprocessing script

Hello,
I tried to repeat our data preprocessing pipeline but I was disappointed to find there are commitment conflicts existed in the following scripts:

data_analysis/scripts/NHEJ_analysis.py line3 ~ line17
data_analysis/scripts/NHEJ_analysis_mh.py line 134 ~ 235

I tried accepting the incoming update and it works. Hope this can be helpful to anyone who is also trying to reproduce the analysis.

@oZwZo did you manage to reproduce their dataset for training the LR model?


[Feature Request] More contrast for list selections

Hi,
I really love this theme. I use it on both vscode and vim. Thanks for the great work.
For the vscode version, I find the contrast to be really low for list selections. For example, selected file in explorer, selected file in Ctrl-tab tab switcher, etc.
Is it possible to make these have more contrast so that we can easily identify what's selected? May be darker/lighter background or a border?
Example lists:

Done.

Thanks. This is much better.


Remove Primary Scroll Controller for Flutter Desktop apps

Common desktop error: The provided ScrollController is currently attached to more than one ScrollPosition.
From medium article: https://andrewzuo.com/flutter-for-desktop-apps-isnt-ready-yet-663664262dde
For context, desktop apps frequently have multiple vertical scroll areas, e.g. desktop_photo_search has a sidebar and mainn content area, both of which scroll vertically.
This combination results in a runtime error from a cranky primary scroll controller, as mentioned above.  Couple of findings:

The PrimaryScrollController is also used in the NestedScrollView in order to have the inner scroll view inherit the scroll controller that it manipulates to keep the 2 positions in sync.

So we would have to find a way around this or it would break the NestedScrollView for desktop applications.

Default keyboard scroll actions on desktop actually rely on the PrimaryScrollController to work. A PSC is created for each route, and when the user taps the arrow keys, if the current focus is not enclosed by a scrollable, it looks up the PSC as a fallback to automatically have keyboard scrolling shortcuts work.

In this case, I think the same more than one position attached... issue actually applies to scroll actions too, if not I do not think the user would want multiple scroll views to move in response to a key stroke. If we disable the automatic attachment of PSC completely, the user would have to specify which scrollview they want to be the default for scroll actions by setting ScrollView.primary to true. I think this would be an ok trade-off but it is still one to consider carefully.

⭐ ➡  I think for now, the best workaround is to set primary: false on ScrollViews that should not connect to the PSC. I think it is better than setting an individual scroll controller for each.
If anyone has thoughts on this, please do share. I am still investigating a few more options here.


Avoid maybeSonarHome.get

avoid optionality for sonarHome path variable.
allow to set sonar system properties

Would you also be able to update README and mention about system properties? An example of how to run sonarScan with system properties would be great.

That's great, thanks a lot for your contribution @yarosman!
If you can think of any other other improvements, please feel free to open an issue or raise a PR 👍
On a side note, I'm currently working on SonarQube 6.7.1 LTS support in my fork of the sonar-scala plugin, so if you're interested, check out https://github.com/mwz/sonar-scala/tree/sonar-671-lts and https://github.com/mwz/sonarqube-scala-docker in a little while once the new version is ready.


Replace the linked test-case for issue 3879 with a reduced test-case

Re: issue #3879 and PR #3880.
@timvandermeij Do you have time for reviewing/verifying this patch? If not, just un-assign yourself :-)

/botio test

/botio makeref

Thanks again for doing this!

@timvandermeij Thank you for promptly reviewing/merging these kind of PRs!


Ability to change priority on actions of PowerToy run commands.

I can walk through windows and open applications from PowerToy run,
but when I have for eg: chrome open I would like to switch to it, instead of opening new window.
I can see and navigate between both options in menu, but I would like if I could do it more intuitively, without looking and reading all options. I would like to change the order for running apps to be always top priority

@alvin4frnds
Do you know about the Direct activation phrase? In your case, if you want to open running chrome type < chrome.

@alvin4frnds to verify, you want certain plugins to tweak how stuff is ranked, correct?
@mykhailopylyp i read this as additional weight multipliers

@Aaron-Junker what did you want to dup this against?

@Aaron-Junker what did you want to dup this against?

#5962

@Aaron-Junker what did you want to dup this against?

#5962

No!
@Crutkas I don't know. I think it happend by accident


running psn container fails

just tried to run the psn container independently to use update_inits on a machine without psn installed
docker run --rm -v C:\Users\devin\Documents\Repos\manuscript-vancomycin-bayesian\modeling:/data -it --entrypoint bash osmosisfoundation/psn

however from the bash shell get the following error
In PsN configuration file[/usr/local/share/perl/5.22.1/PsN_4_6_0/psn.conf]:File '/usr/local/share/perl/5.22.1/PsN_4_6_0/psn.conf' does not exist at /usr/local/share/perl/5.22.1/PsN_4_6_0/PsN.pm line 56.
BEGIN failed--compilation aborted at /usr/bin/update_inits line 6.

When trying any other commands or even accessing help the following errors persist.

Note - this issue is not present in rocker, which I ended up using just to access psn.

The issue appears to be with the expect script.  Expect an update shortly (pun intended).

Latest commits fix this issue.  See example usage in the updated README.md


Converting state dicts without model creation

Before this PR it was necessary for a model to fit into RAM to be converted to tensor_parallel.
model = tp.TensorParallelPreTrainedModel(
    transformers.AutoModelForCausalLM.from_pretrained("facebook/opt-13b"), # <- tons of RAM
    device_ids=[0, 1, 3, 4]
)

Or you could save a converted model to then efficiently dispatch it. But then again it needed to be converted on a machine with tons of RAM.
This PR adds the option to independently convert parts of a model's state dict using convert_state_dict helper function. Those converted parts can then be efficiently dispatched one by one.

Using config to refer to tensor parallel config conflicted with transformers' model config. Thus the renaming.

Also made it such that nn.Linear in_features and out_features are set automatically after the tensor split.
It's really needed for the demo and we can rethink it later.

ModuleRules is still in use. I just made a distinction that ModuleRules now contain strictly compiled regex and Config inputs are strictly string patterns.
I thought that It wouldn't make sense to have two almost identical type definitions so the latter is explicitly typed.


I can't start scrcpy by intellij IDEA

The error below occurs:

I have the directory configured 'correct' as I return:

Any idea what I'm doing wrong? I have a Mac M1.

In ADB Executable you put the path of scrcpy?

Yes.

So that's not correct. It should point to adb.

Truth. This was my mistake. Putting the directory ..Android/Sdk/Platform-tools/adb worked. I thank.


where is Lesson2 ?

Hello, I have bought this book.
and also with the .zip
file the lesson 2 activities are not present
altho referenced.

nvm, those activities seem to just be about interpreting graphs.


Kanban board setup 📆🗃

Hi! 👋
Here's the link to the Kanban board for the React-Redux Capstone project. We are a team of two: me and @AlucardSanin

STATUS: APPROVED!!!  🎉 🎉 🎉 :champagne: :champagne: :champagne:
Hi Team,
Good job !!!
To Highlight! :clap:  :green_circle:
:heavy_check_mark:  Good job with issues summary
Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉 🎉 🎉 :champagne: :champagne: :champagne:

Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
N/A
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear or you can get to me on slack  using this handle @mihndim.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


TEDEFO-1065 export of various files with the new labels.

This allows to compare the new vs old labels.
Let me know if there are too many files.
I could restrict this to just the:

translations
codelists
view-templates
some of the index mapping files

Let me know if there are too many files.
I could restrict this to just the translations, codelists and some of the index mapping files.

I reexported the translations with the correct filenames after merging the MDC fix.


I cant use openai api

System Info
ghcr.io/huggingface/text-embeddings-inference :cpu-1.2
Information

[X] Docker
[ ] The CLI directly

Tasks

[X] An officially supported command
[ ] My own modifications

Reproduction
main code
from langchain_openai import ChatOpenAI,OpenAIEmbeddings
from langchain_community.embeddings import HuggingFaceHubEmbeddings
from langchain_community.vectorstores.milvus import Milvus

vector = Milvus(
    embedding_function=embedding,   # 使用的向量模型
    collection_name="lukbinx_test_vector_db",  # 使用的向量数据库的名称
    collection_description="lukbinx向量数据库描述",
    index_params="HNSW/AUTOINDEX ",  # 索引参数 https://www.milvus-io.com/overview
    drop_old=False,  # 是否丢弃老的数据
    auto_id=True,
    connection_args={"host": "<IP_ADDRESS>", "port": "19530"},
)

from server import vector
from langchain_community.document_loaders import TextLoader
from langchain.text_splitter import CharacterTextSplitter

text = TextLoader(f"../weekly_report.txt").load()
text_splitter = CharacterTextSplitter(separator="\n", is_separator_regex=False, chunk_size=256, chunk_overlap=0)
documents = text_splitter.split_documents(text)
res_v_add = vector.add_documents(documents)
res_s = vector.search(query="duan", search_type="similarity")
print(res_s)

use HuggingFaceHubEmbeddings  working well
embedding = HuggingFaceHubEmbeddings(
    model="http://<IP_ADDRESS>:7862",
    huggingfacehub_api_token="empty",
    model_kwargs={"truncate": True}
)

When I call the openai-api interface, an error occurs and the container stops running.
embedding = OpenAIEmbeddings(
    model="bge-small-zh-v1.5",
    base_url="http://<IP_ADDRESS>:7862",
    api_key="empty",
    chunk_size=256
)

error log
Intel MKL ERROR: Parameter 13 was incorrect on entry to SGEMM .

Intel MKL ERROR: Parameter 13 was incorrect on entry to SGEMM .

Intel MKL ERROR: Parameter 13 was incorrect on entry to SGEMM .

Intel MKL ERROR: Parameter 13 was incorrect on entry to SGEMM .

Intel MKL ERROR: Parameter 13 was incorrect on entry to SGEMM .

Intel MKL ERROR: Parameter 13 was incorrect on entry to SGEMM .

Intel MKL ERROR: Parameter 13 was incorrect on entry to SGEMM .

Intel MKL ERROR: Parameter 13 was incorrect on entry to SGEMM .
thread '<unnamed>' panicked at /usr/local/cargo/git/checkouts/candle-2c6db576e0f06e81/14a716f/candle-nn/src/ops.rs:122:17:
chunk_size must not be zero
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Expected behavior
working well

Sometimes it happens, sometimes it doesn't happen. It may be a problem with my operating environment.

Sometimes it happens, sometimes it doesn't happen. It may be a problem with my operating environment.

On the same server?

Sometimes it happens, sometimes it doesn't happen. It may be a problem with my operating environment.

On the same server?

yes, It seems to happen when I search for Chinese characters, the file is encoding by utf8


Disable collections folder in robots.txt (bug 1210603)

Example robots.txt output: https://gist.github.com/EnTeQuAk/38e6f08e7ee65b03b18f
This should disable everything under /collections/* as well.

r+


fix: added session.refresh to sqla repository update

I haven't opened an issue for this, but ran into it when updating a model attribute that changes when sent to the db. In my current case, it is a Geography object that uses a WKT formatted string when sent to the db, and comes back as a WKBElement wrapped by GeoAlchemy2 when queried.
By refreshing the instance after merging and flushing, we get the newest values of the updated attributes instead of keeping values sent to the db. This is also done on the sqla repository's add() method.

The summary/fix makes sense, and I believe it was an oversight.  Good catch!
Once the validations are passing, we can merge.

and I believe it was an oversight

@cofin - it looks like the refresh() calls were removed for both update() and upsert() in https://github.com/litestar-org/litestar/commit/aa626eb16e239d43ae797501b6867eaeba73fb4d - DYT just oversight, or might there have been a particular reason given they were both removed at the same time?

@peterschutt  I was actually going to do a separate test with this branch before merging it.  I vaguely remember having some strangeness around this, but I'm thinking it may be an oversight that they weren't added back in.  I can't think of a reason why it shouldn't be there.

@patrickarmengol do you mind adding it there as well?

@patrickarmengol do you mind adding it there as well?

on it

@patrickarmengol do you mind adding it there as well?

on it

Thanks!
Integration tests for the refresh behavior would be nice too, if you have the bandwidth @patrickarmengol? You can check the other repository tests for patterns.

I've tested the update method on this branch against a separate code base and it passes as well.  I've got a large chunk of code that uses the upsert as well, that I'll test once it's pushed.  If both of those pass, I'm pretty comfortable with these changes.

upsert works as well.  I think this is good to go!

I've tested the update method on this branch against a separate code base and it passes as well. I've got a large chunk of code that uses the upsert as well, that I'll test once it's pushed. If both of those pass, I'm pretty comfortable with these changes.

We should have a test for the behavior in the litestar suite to protect against future regressions.

@patrickarmengol do you mind adding it there as well?

on it

Thanks!
Integration tests for the refresh behavior would be nice too, if you have the bandwidth @patrickarmengol? You can check the other repository tests for patterns.

This is a good idea, but sorry, I won't be able to work on it for a few days. I can take a crack at it if nobody else has done it by next week.
Trying to think of a more general case where the refresh is relevant....

Trying to think of a more general case where the refresh is relevant....

Server generated timestamps was my original motivation for adding them

I think i have a case where the refresh may/may not be relevant.  I'll type out my thoughts in the discord channel though.

I think there's one additional place we need to consider adding the refresh:
https://github.com/litestar-org/litestar/blob/main/litestar/contrib/sqlalchemy/repository/_async.py#L239

I think this is ready for a final review.  Thanks @patrickarmengol for the patience and help on this one.


Cannot pass in Core.Bigstring for Rocks.Bigstring becuase rocks_intf.cmi is not installed and it's interface is assumed to be opaque

Fixed by #32


w3m failed to build on Slackware 14.1 and on Ubuntu 14.04 LTS

brew gist-logs w3m output:
https://gist.github.com/28684d820ba446e07e21
Terminal output:
[13:19:58]why@why:~/Desktop$ brew install w3m
==> Downloading https://downloads.sourceforge.net/project/w3m/w3m/w3m-0.5.3/w3m-
Already downloaded: /home/why/.cache/Homebrew/w3m-0.5.3.tar.gz
==> Patching
patching file main.c
==> ./configure --prefix=/home/why/.linuxbrew/Cellar/w3m/0.5.3 --disable-image -
==> make install
Last 15 lines from /home/why/.cache/Homebrew/Logs/w3m/02.make:
                 from fm.h:39,
                 from main.c:3:
istream.h:23:8: error: redefinition of ‘struct file_handle’
 struct file_handle {
        ^
In file included from /usr/include/x86_64-linux-gnu/bits/fcntl.h:61:0,
                 from /usr/include/fcntl.h:35,
                 from istream.h:14,
                 from html.h:10,
                 from fm.h:39,
                 from main.c:3:
/usr/include/x86_64-linux-gnu/bits/fcntl-linux.h:311:8: note: originally defined here
 struct file_handle
        ^
make: *** [main.o] Error 1

READ THIS: https://github.com/Homebrew/linuxbrew/blob/master/share/doc/homebrew/Troubleshooting.md#troubleshooting

[13:20:15]why@why:~/Desktop$

This bug was reported in #159 and fixed in f383493, but was somehow unintentionally reverted, probably in a merge. It's fixed once again. Thanks for the bug report.

I'm seeing the following error. Did you happen to encounter this error?
checking GC library exists... yes
checking gc.h usability... yes
checking gc.h presence... yes
checking for gc.h... yes
checking for GC_init in -lgc... no
checking GC library location... /usr /usr/local /var/tmp/sjackman/w3m20160109-28154-s4gmh8/w3m-0.5.3/.brew_home
checking /usr... checking for GC_init in -lgc... no
checking /usr/local... checking for GC_init in -lgc... no
checking /var/tmp/sjackman/w3m20160109-28154-s4gmh8/w3m-0.5.3/.brew_home... checking for GC_init in -lgc... no
configure: error: libgc not found

Sorry, I cant't check it on Slackware now, but on Ubuntu I have
checking for GC_init in -lgc... yes
followed by
checking for zError in -lz... yes

Neither on a Slackware test machine I do experience «your» error. This part runs well on my side. – Yet I do not longer have a «pure» linuxbrew configuration. I’ll try this afternoon to have some inspiration on the issue. (I’m not feeling well those days, therefore no guarantee. I had a stroke five years ago, and since I’m a… little fragile, as in my picture ;-)

No worries, Reto. It was more of a curiosity question. I suspect that the build script needs a flag to tell it where the gc library is located.

Neither on Slackware I can reproduce that error.
Also this formula is now working well. Thank you again, @sjackman!

No worries. I'm glad that I could help.


conv_mnist model compilation fails

Hi there,
I tried to use ONNX-MLIR to compile a conv_mnist ONNX model but got the following error:
➜ onnx-mlir --EmitJNI conv_mnist.onnx
error: 'onnx.Reshape' op operand #1 must be tensor of 64-bit signless integer values or memref of any type values, but got 'tensor<4xi32>'

The model file:
conv_mnist.tar.gz
Any help would be greatly appreciated, thanks much!

The model is not compliant because the model claims to have onnx opset version 9, and in that version of the spec, ONNX reshape operation must specify shape in int64 (https://github.com/onnx/onnx/blob/master/docs/Changelog.md#Reshape-5). Whereas in the model shape is specified as int32.
However this difference is almost trivial. We should expand our support for data types used to specify shape.
cc @chentong319  @AlexandreEichenberger

@caoimhinuibrian that was my suggestion. We shouldn't care which datatype shapes are specified in.

Can someone look into this one? I am getting a strange error
(onnx-mlir) alexe@pancetta mnist % onnx-mlir conv_mnist.onnx
Assertion failed: (!scopes.back().contain(name) && "Tensor already exists."), function AddMapping, file /Users/alexe/Onnxcode/onnx-mlir/src/Builder/SymbolTable.hpp, line 129.
zsh: abort      onnx-mlir conv_mnist.onnx

Thanks

This error is caused by that the name 'conv2d/bias/read' appears in the input list and value_info list . I do not why this error did not appear previously.
However, the converter generated this error message: [ShapeInferenceError] Inferred shape and existing shape differ in rank: (0) vs (4)
We should give up this model.


TEST ISSUE for Blazor Hybrid

TEST ISSUE
@BethMassi ... Looks like the four issues that I need to open from your list won't be opened using the This page feedback process, so this issue is our test for applying GH metadata.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 0781779e-0e2e-2e6d-53ef-a719ce27fb61
Version Independent ID: 0781779e-0e2e-2e6d-53ef-a719ce27fb61
Content: ASP.NET Core Blazor Hybrid
Content Source: aspnetcore/blazor/hybrid/index.md
Product: aspnet-core
Technology: aspnetcore-blazor
GitHub Login: @guardrex
Microsoft Alias: riande

🍔 Roasted RAT burgers! 🐀
That didn't work. Apparently, the changes can't made in a sequential/cumulative fashion ... at least using the test approach that I thought might work.
I'll try this again with a new ms.technology name for Blazor Hybrid.
@Rick-Anderson ... Can you let me know if the doc bigwigs are going to have a fit if I create a new ms.technology name of "aspnetcore-blazorhybrid" for the Blazor Hybrid docs? I know they care about some metadata entries/behaviors but not others. I'm not sure if this was one that they care about.


System.MissingMethodException

I encountered an issue:

System.MissingMethodException: "Method not found: 'Void Avalonia.IAvaloniaObject.SetValue(Avalonia.AvaloniaProperty`1<!!0>, !!0, Avalonia.Data.BindingPriority)'."

I have installed the following packages:
Avalonia
Elmish
FSharp.Core
Avalonia.FuncUI
Avalonia.FuncUI.DSL
Avalonia.FuncUI.Elmish

I can't check it by myself at this moment but my guess you're using wrong version of Avalonia. Try to set an explicit version starting from 0.10.0 and then updating it one by one if needed until this exception is thrown.

I am using the Version 0.10.7 of Avalonia and the latest version of Avalonia.FuncUI from GitHub.

FuncUI version 4.x requires Avalonia 9.x. If you want to use Avalonia 10.x then you need to use FuncUI 5.x.


hydrogen-web: init at 0.4.0

Description of changes
Closes https://github.com/NixOS/nixpkgs/issues/141586

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

How much is this just copied from element? Can we make this a variant of element without copying all the instructions? Maybe overriding source is already enough?

This is mostly copied from element removing some unused part. But they are two totally different projects so I thought it makes no sense to merge them. They just both use yarn.


main.evaluate does not work with batch_size > 1 and images of different lengths.

predict.predict_file needs a resizing function.

I have opened a PR #437 where in the predict_file function I am updating the image dimensions with 400x400.

Can I work on this issue?

Can I work on this issue?

@das-ankur - there's already an open pull request on this one #439

@ethanwhite okay.

What should be the size of the images when size of the images are different? Does the model always works on 400 x 400 images?

It looks like the initial attempt to fix this was never completed, but we'd welcome help on this one.


Bismuth Feature List

This is an up-to-date list of all features that must be complete before the Bismuth milestone is ready.
Incomplete
This list is sorted in order of highest to lowest priority.
Bismuth is ready!
Complete
This list is in chronological order.
#9 - Reduce input latency
#3 - Complete all UI rendering components
#7 - Compile as a library
#4 - Implement a physics system - all work necessary for Bismuth is complete.
Removed
#2 - Implement a networking library [NOT STARTED] - this would be too complex to complete for Bismuth and therefore should instead be completed afterwards.

All items on this list have been completed; therefore, I am happy to release Bismuth. :)


Belinda_Android_Sprint_1_44_deleting_AddProduct

Resolves: #44
This PR will delete the AddProduct in the Login.kt file

The Add Product button was removed, this looks good to me. Thanks.


import array #61

Issue 61:
I have the following json file:
colors.json
[{ 	"id": 1 },{ 	"id": 2 }]
when I import it in sass, the response is:
$0: (id: 1); $1: (id: 2);
this is because the keys of array are numerical, and variables numerical in sass are invalid.
I propose in these cases that the result is a variable with the name of the file, in my example is $colors.
$colors: ((id: 1),(id:2));

Thanks for the contribution @spernigotti!


Resources for published notebooks are not imported back to Beaker Lab

For published notebooks it's possible to open them in Beaker Lab for edit.
But in this case resources (like images or other files) are not imported back. So, it's impossible to reproduce the notebook in edit mode.
However indirect way is possible: save images from published notebook and add them manually.
For instance, open in Beaker Lab this unlisted published notebook:
https://lab.beakernotebook.com/publications/02f7e8ae-3fc9-11e6-9eef-078c16a175ab?fullscreen=false
Demo image 'demo_image.png' is not imported.

Thanks for the report.
This is the correct behavior for the currently released solution.
We are about to release version 1.0 which will allow you to publish files from your project space together with the notebook and to get them back when you open it in beaker lab.


Should we have a separate language ID for parameter files?

Pros

Easier for people to realize there's special functionality for the file
Consistent with our experience for template files

Cons

We lose the built-in JSON validation and formatting, will need to modify language server to handle those like it handles template validation/formatting
We lose support for any other extensions that are currently working on JSON files (just like we did with template files)

@neilpeterson Unless you disagree, I think the answer to this is no for now.


Minimum Interval set to "days" calculates interval based on hours instead of days

When "Minimum Interval" option is set to "days", the interval is calculated by taking the difference between current and target hours and rounding it down to days.
The optimal behavior (in my case) would be to calculate the difference between the days in the date:

I use this plugin heavily to estimate my deadlines and TODOs and having to add +1d to almost every ETA I encounter is distracting and mentally taxing.
If the current behavior is expected behavior, would there be a possibility to add an option for calculating actual days between dates?

Hi, thanks for your question, and I think it mases sense. It seems this behavior is changed after #3. I will have a fix soon.

Should be fixed in 0.0.7. Please tell me if there's still any problems :)

Thank you so much for responding and fixing this so quickly! Now it works just as one would expect. The only odd thing that caught my eye is getting (past 0d) for timestamps with current date. Other than that, it's perfect:

I just updated past 0d to today 😄

Now it's perfect. Thank you!


Create Intersector unit test from Intersector main

This creates an junit test in the style of BitsTest in gdx/test. Note that this test currently fails at line 28 (test_circle) due to bug in Circle.contains. Fix is in the followup PR. intersectorTest is currently not done yet, because I didn't have the time/tools/smarts yet to compute what should be the correct answer. So it wasn't included as a test yet.

Other than the comment I left, this looks good to me. Good stuff! Moar unit tests, MOAR!

The naming style used in BitsTest sucks. Use the standard java style, e.g. testBoundingBox rather than test_boundingBox.

@antag99 raises a good point.

Agreed, I'll change it in both classes.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Would you mind squashing everything into one commit? We can then verify the patch.

I have changed the test names to have standard java method names and implemented the testSplitTriangle. And by chance, found a bug in Intersector.splitTriangle. See #3299.

Squashed

Do we want to break the tests by merging this or should we wait for the fix for #3299 to be in? What's our policy on this?

And this is it, everything should be working and tested properly now.

Cool stuff, any chance you can squash again? I will add the unit tests it to the gradle build so we can build them on the server.

Shouldn't the unit tests be moved into separate classes based on what classes they test? E.g. testRectangle goes in RectangleTest instead of IntersectorTest.

Yup

Sure, I'll squash, I just wanted somebody to see what was I changing.
So, should I move the tests to their own classes now or will that wait for when there is more of them?

Eh, I'll do it now with the squash.

We could move all the Shape2D tagged classes into a Shape2D test class.

I have been thinking about that as well. I'll do that.

Done.

Thanks!

Hello!
You have a new message, please read http://husband.tv/attract.php?c
<EMAIL_ADDRESS>


[$750] [Violations] Remove violations beta from front-end

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Problem
Violations were implemented under a beta and we're ready to release this functionality to everyone
Solution

Remove all the code in the front end using the violations beta, and run a thorough set of manual tests to make sure everything is working as designed.
The proposal should outline all the places in the code we need to update
The proposed test script is below, and both online and offline tests should be done on every platform

(related https://github.com/Expensify/Expensify/issues/338701)

Tests
Pre-testing steps

Make sure emails sent to the testing email addresses go to an inbox you can access to validate your account(s)
Create a new workspace in new dot and go to the workspace settings

From the members tab, invite an additional user to the policy
From the More Features tab, enable categories and tags
From the Categories tab, add at least 2 categories, click settings, and switch on “Members must categorize all expenses”
From the Tags tab, add at least 2 tags, click settings, and switch on “Members must tag all expenses”

Important Notes

Only the violations related to tags and categories work while offline. That means if you have a missing tag or missing category violation, you’re offline, and you update the tag or category, the violation should disappear. Similarly, if you’re online, the violation should disappear right away.

For other violations, you’ll need to wait for the API to return a response and update the transaction violations.

Some tests ask to verify that the report preview looks correct. If you're on the case of a single-expense report, where we put a money request preview directly in the workspace chat (as oppposed to workspace chat having report previews, and reports having money request previews), you can add a second expense to the report and then verify the report preview, or omit the step and verify the money request preview
If you find any steps need to be updated, please let us know so we can update our testing script

Missing tag and missing category violations
Manual Request

Press big plus sign > submit expense
Select Manual tab (from Manual | Scan | Distance)
Enter amount and press next
Press the workspace from the pre-testing steps (press the row, not the split button in the row)
Press the show more button if it’s there

[ ] Verify there’s a Required label on the Category row
[ ] Verify there’s a Required label on the tag row

Enter a merchant
Press the Request $X.XX button
Repeat steps 1-7

[ ] Verify the report preview in the workspace chat has a red circle

Press the report preview

[ ] Verify the money request previews in the iou report have a red circle

Press the first money request preview

[ ] Verify you see the Missing Category red text under the category row

Press the category row
Press on a category

[ ] Verify you no longer see the Missing Category red text under the category row

Press the Tag row
Press on a tag

[ ] Verify you no longer see the Missing Tag red text under the category row

Press on the IOU chat report link at the top
Press on the second money request view
Repeat steps 11-15
Press on the IOU chat report link at the top

[ ] Verify the money request previews in the iou report no longer have a red circle

Press on the policy expense chat report link at the top

[ ] Verify the report preview in the policy expense chat report no longer has a red circle

🛜 Repeats all these steps while offline

Scan Request

Same as the Manual Request test above, replacing steps 2 and 3 with the following
Select Scan tab (from Manual | Scan | Distance)
Press choose file, select an image
Press the workspace from the pre-testing steps (press the row, not the split button in the row)

[ ] Verify there’s a Required label on the Category row
[ ] Verify there’s a Required label on the tag row

Press the Submit expense button
Continue from the verification of step 8 above, and once done, repeat all these steps while offline 🛜

Distance Request

Same as the Manual Request test above, replacing steps 2 and 3 with the following
Select Distance tab (from Manual | Scan | Distance)
Press Start and enter an address, eg 88 Kearny st. Then Press Finish and enter an address, eg, 1180 jackson st. And press Next
Continue from step 4 above, and once done, repeat all these steps while offline 🛜

Category out of policy, tag out of policy violation, expense over limit, max age, over category limit, receipt required
Manual Request

In old dot, in the workspace editor > expenses tab, set max expense age to 5, max expense amount to $10, receipt required amount to $5
In the workspace editor > categories tab, set the max amount for one of the categories to $3
On new dot, press big plus sign > submit expense
Select Manual tab (from Manual | Scan | Distance)
Enter $15 as the amount amount and press next
Press the workspace from the pre-testing steps
Press the show more button
Press the Date row, and set the date to be more than 5 days ago
Press the category row, select a category that doesn’t have a max amount
Press the tag row, select a tag
Enter a merchant
Press the Submit $15 button
If you have more than one expense

[ ] Confirm the report preview has a red circle

Press the report preview

[ ] Confirm the money request preview has a red circle and shows “Review Required”

Press the report preview or money request preview (depending on the number of expenses)

[ ] Verify you see Receipt required over $5 violation
[ ] Verify you see Amount over $10.00/person limit violation
[ ] Verify you see Date older than 5 days violation

Press the category row, and select the category with max amount set to $3

[ ] Verify you see Receipt required over $3 category limit violation

On a different tab, sign into old dot as an admin of the workspace where the money request was created
Go to the policy editor, and disable the category and the tag you added to the money request
Switch back to new dot, and refresh the page

[ ] Verify you see Category no longer valid violation
[ ] Verify you see Tag no longer valid violation

Switch back to old dot, re-enable the category and tag you had disabled, remove the max amount from the category, and from the expenses tab, remove the values from the Max Expense Age (Days), Max Expense Amount and Receipt Required Amount fields
Switch back to new dot, and refresh the page

[ ] Verify you don’t see Category out of policy violation
[ ] Verify you don’t see Tag out of policy violation
[ ] Verify you don’t see Amount over $10/person limit violation
[ ] Verify you don’t see Date older than 5 days violation
[ ] Verify you don’t see Receipt required over $5 violation

Repeat steps 1-3 in old dot
🛜 Switch to new dot and go offline
Repeat steps 1-14. The report preview, money request preview should be grayed out
Go online, and repeat steps 15-21

Scan Request

Same as the Manual Request test above, replacing steps 4 and 5 with the following
Select Scan tab (from Manual | Scan | Distance)
Press choose file, select an image
Press the workspace from the pre-testing steps

[ ] Verify there’s a Required label on the Category row
[ ] Verify there’s a Required label on the tag row

Press the Request button
Continue from the verification of step 13 above, and once done, repeat all these steps while offline 🛜

Distance Request

Same as the Manual Request test above, replacing steps 4 and 5 with the following
Select Distance tab (from Manual | Scan | Distance)
Press Start and enter an address, eg 88 Kearny st. Then Press Finish and enter an address, eg, 1180 jackson st. And press Next
Continue from step 6 above, and once done, repeat all these steps while offline 🛜

Tag violations on workspace with Independent Tags (multi-level tags)
Manual Request

In old dot, in the workspace editor > tags tab, switch on the Use multiple levels of tags toggle
Click import from spreadsheet, and upload the file in this issue comment
On new dot, press big plus sign > submit expense
Select Manual tab (from Manual | Scan | Distance)
Enter $15 as the amount amount and press next
Press the workspace from the pre-testing steps (press the row, not the split button in the row)
Press the merchant row and enter a merchant
Press the Submit $15 button
Confirm the report preview has a red circle
Press the report preview
If the report has more than 1 expense

[ ] Confirm the money request preview has a red circle and shows “Review Required”

Press the money request preview

[ ] Verify you see Missing Region, Missing Project, and Missing Department violations

Press the Region menu item, and select a region

[ ] Verify that the Missing Region violation disappears right away

Repeat for Department and Project
Press the Region menu item, and unselect the selected region

[ ] Verify that the Missing Region violation appears right away

🛜 Switch to new dot and go offline
Repeat steps 1-16. The report preview, money request preview should be grayed out
Go online, and confirm everything looks the same, except nothing is grayed out
Submit a new expense on the same workspace, and select all the required fields so there are no violation on that expense
Click on the link in the transaction thread header to go back to the expense report if you didn’t land there already

[ ] Verify the money request preview says Missing Region next to the a red circle

Tag violations on workspace with Dependent Tags (multi-level tags)
Manual Request

In old dot, in the workspace editor > tags tab, switch on the Use multiple levels of tags and the People must tag expenses toggles
Click import from spreadsheet, uncheck “Are these independent tags?”, and upload the file in this issue comment
On new dot, press big plus sign > submit expense
Select Manual tab (from Manual | Scan | Distance)
Enter $15 as the amount amount and press next
Press the workspace from the pre-testing steps (press the row, not the split button in the row)
Press the merchant row and enter a merchant

[ ] Confirm the Required label shows on the State, Region, and City rows

Press the Submit $15 button
Confirm the report preview has a red circle
Press the report preview
If the report has more than 1 expense

[ ] Confirm the money request preview has a red circle and shows “Review Required”

Press the money request preview

[ ] Verify you see Missing State, Missing Region, and Missing City violations

Press the Region menu item, and select a region

[ ] Verify that the Missing Region violation disappears right away
[ ] Verify you see All tags required violations under State and City

Select a State

[ ] Verify that the see All tags required violation disappears from under State
[ ] Verify you see All tags required violations under City

Select a City

[ ] Verify that the see All tags required violations are gone

De-select City

[ ] Verify that the All tags required violation appears under City

🛜 Switch to new dot and go offline
Repeat steps 1-16. The report preview, money request preview should be grayed out
Go online, and confirm everything looks the same, except nothing is grayed out
Submit a new expense on the same workspace, and select all the required fields so there are no violation on that expense
Click on the link in the transaction thread header to go back to the expense report if you didn’t land there already

[ ] Verify the money request preview for the first expense says Review Required next to the a red circle
Switch off requirement for tags and categories
For the next tests, stop requiring tags and categories so you can focus on receipt related violations

Go to the workspace settings for the workspace you’re using

From the Categories tab switch off “Members must categorize all expenses”
From the Tags tab switch off “Members must tag all expenses”

Receipt Audit Scan

Press big plus sign > submit expense
Select Scan tab (from Manual | Scan | Distance)
Press choose file and upload the popbagel.pdf file in this issue comment
Select the workspace to submit to
Wait for it to scan, it should be quick since we have a parser for square receipts

[ ] Verify you see “Receipt * Verified √” above the receipt
[ ] Verify amount is set to $21.90, and date to 2020-01-23

Update the amount to $25

[ ] Verify you see “Amount greater than scanned receipt” violation under the amount field
[ ] Verify you see “Receipt * Issue found 🔴” above the receipt

Click the blue link in the report header
If there aren’t any other expenses on the report you added the receipt to, submit another expense on the same workspace
Navigate to the expense report

[ ] Verify you see "Cash * Review required 🔴" in the Request Preview

Receipt Audit Distance

Press big plus sign > submit expense
Select Distance tab (from Manual | Scan | Distance)
Press Start and enter an address, eg 88 Kearny st. Then Press Finish and enter an address, eg, 1180 jackson st. And press Next
Select the workspace to submit to
Click Submit $XX button
Update the amount to $7

[ ] Verify you see “Amount differs from calculated distance” violation under the amount field
[ ] Verify you see “Receipt * Issue found 🔴” above the receipt

Click the blue link in the report header
If there aren’t any other expenses on the report you added the receipt to, submit another expense on the same workspace
Navigate to the expense report

[ ] Verify you see "Distance * Review required 🔴" in the Request Preview
Receipt Audit Card (Amount greater than card transaction)

Import a third party domain control card via OldDot
Find the card transaction in the workspace chat corresponding to the assigned employee, or visit the Search page and find the transaction by date.
Open the card expense
Change the amount of the card transaction to an amount higher than the original charge
Verify that you see “Amount greater than scanned receipt”
Verify that you see “Receipt * Issue found 🔴” above the receipt
Navigate back to the transaction/expense preview.
Verify that you see “Review required 🔴" in the Request Preview

Receipt Audit - Receipt Not Verified

Press big plus sign > submit expense
Select Scan tab (from Manual | Scan | Distance)
Press choose file and upload a bad receipt. You can take a screenshot of a blank space on your screen and upload that
Select the workspace to submit to
Wait for it to scan, it should fail

[ ] Verify you see “Receipt scanning failed. Enter details manually.” violation under the receipt

Add an amount and a merchant

[ ] Verify all violations are gone

cc @JmillsExpensify

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01e029ffdb5d51f383
Upwork Job ID:<PHONE_NUMBER>841290536
Last Price Increase: 2024-07-08
Automatic offers:

ShridharGoel | Contributor | 103067321

Issue OwnerCurrent Issue Owner: @cead22

I'll update the solution in the issue description, but please include all the places in the code we need to update in your proposal

@getusha any thoughts on that proposal?

The task looks pretty straightforward to me. the main part seems to be the testing. we can proceed with @ShridharGoel
I am assuming there aren't other beta futures like https://github.com/Expensify/App/pull/43864 under violations beta
🎀 👀 🎀 C+ Reviewed.

Correct, we can leave that and other betas alone and focus on the violations one

Thanks, let me know if I can help!

Thanks, let me know if I can help!

@ShridharGoel how is the PR coming along? anything I can do to help?

Yes

No I think that's fine because the copy of the violation for the modified amount is Amount greater than scanned receipt, which we'll show under the amount field, and not under the receipt

Yes probably. Which ones are failing?

I will, let me make sure I can get the steps right. Is this the last thing blocking you from submitting the PR for review? If so, let's get started on the review and we can worry about that test later

Payment summary:
Contributor: @ShridharGoel $750
Reviewer: @getusha $750
@getusha I vaguely remember that as part of this issue we'd add a series of new regression tests, is that right or did I misremember that part?

Nice thanks for clarifying. Contributor is paid out via Upwork. @getusha Please submit a request via Newdot and we'll get that processed.

Contributor: @ShridharGoel  paid $750 via Upwork
Contributor+: @getusha owed $750 via NewDot
Do we want a test case for/from this issue specifically or is that being covered more holistically as part of a project?

$750 approved for @getusha


[TC-MC-3.11] Media Input cluster showing status = 0xc3 (UNSUPPORTED_CLUSTER) response

Summary:
As per testplan TC_MC_3.11 TH sends "SelectInput" command to DUT with index value as 0 but got response as status = 0xc3 (UNSUPPORTED_CLUSTER)
endpoint: 1
Cluster: Media Input
Testplan screenshot:

Spec screenshot:

Execution logs:
MC_3_11.txt

Tried in TOT command SelectInput is passing
SHA: https://github.com/project-chip/connectedhomeip/commit/c1e1d018820c0fdd51f124f607b9207f31fae2ff
Client app: Chip tool
Server app: Tv-app
Execution logs:
TC-MC-3.zip


Fusion based 404 handling

Rewrite of the 404 handling to new Neos internal error handling in fusion.
Change is breaking as configuration for it has changed, so a new major version is needed. Lowest supported Neos version is 4.3.
Supports multiple dimensions, also single and no dimensions.

Reviews and feedback is very welcome. Maybe @ComiR @kdambekalns you are interested in reviewing it.


SWU - Update the Proposal status when a Opportunity is Awarded | DM-717

FEATURE: Award the opportunity winner
GIVEN an opportunity with the state "Evaluation Team Scenario"
WHEN I choose the winner proponent and Save
THEN the opportunity state is updated to "Awarded"
AND the winner proponent status is changed to "Awarded"
AND an email is sent to the winner and another to the other proponents
AND the other proponents status are changed for Gov and Vendor to "Not Awarded" <--- this is new
WHEN the proponent status is changed to "Awarded"
THEN ...
WHEN the proponent status is changed to "Not Awarded"
THEN ...

If a SWU proposal does not get screened in through all stages of a SWU opportunity and the opportunity is awarded to another SWU proposal, the unsuccessful proposal's status is not being updated correctly.
For example, a proposal is screened in to the Code Challenge stage of a SWU opportunity, but the proponent fails this stage.  They are not disqualified and the proposal is not withdrawn; therefore, the status remains as “Evaluated (CC)”.  This status should be updated to “Not Awarded” once the opportunity has been awarded to the successful proponent.
Currently, the status is presented as:

"Under Review" for Vendor
"Evaluated (stage)" for Gov

The status should be presented as:

"Not Awarded" for Vendor
"Not Awarded" for Gov

I have attached screenshots for the current state for both Vendor and Gov users.

Original issue with images: https://bcdevex.atlassian.net/browse/DM-717

See PR: https://github.com/button-inc/digital_marketplace/pull/140

This is done and well tested  in Cypress on the Button fork. Today I will be creating a PR on the government repo with only the code that fixes the problem, as the rest of the cypress code only exists on the Button fork.

The code has been merged to button fork, so this will get merged to BCGov repo with the button fork.


Error converting function to class

When I try to convert this function to a class:
const MyComponent: SFC<Props> = props =>
  true && <div />

I get error:
Property body of ClassMethod expected node to be of a type ["BlockStatement"] but instead got null

@OliverJAsh pushed the fix. Look for it in version 4.2.3. Please validate. The logical operator caused trouble :)

Thank you!


dynamic function not resolved in 'description' key in needs.json

I defined a need like this:
.. testneed:: This is a test
    :id: PT_TEST
    :value: ""

    **[[copy("value")]]**

I then used a needextend like this:
.. needextend:: id == "PT_TEST"
    :value: this is a test value

Now when i build a json file, the description is displayed like this:
"description": "**[[copy(\"value\")]]**"
Shouldn't the description say "this is a test value" and not just display the copy function?

Alright, thanks for the info

Ok I will close this for now then, but bear in mind the feedback thanks


wallet: fix sign_tx

#183 refactored the project structure and the line in this PR wasn't updated. It did not fail the type check because it was explicitely ignored for other reasons (see the comment above).

Coverage remained the same at 87.106% when pulling 126ff65d14c67e720ce324e00dfb79f6bf3b563d on fix-sign-tx into 3d82ae6e5e3d93d75f707c3921ae34b7df907632 on master.


Programmers needed for help in translating and optimizing the code inside functions

All contributions are welcome.
For this stage of code reconstruction, the programmings skills needed are:

Moderate knowledge of assembly language,
Knowledge of C# language.
For details see: https://github.com/rajko-horvat/OpenCiv1/wiki/Introduction-to-code-translating

Hello. I will be watching your project. I'm very disappointed that it's C# and not C, but it's the game that piques my interest the most. I'm currently working on https://github.com/1oom-fork/1oom and I invite you to check it out too. There are a huge number of translation errors in 1oom, perhaps you have ideas on how to fix the situation. In any case, I dreamed of one day starting what you are doing now, so we are on the same side

Hello. I will be watching your project. I'm very disappointed that it's C# and not C, but it's the game that piques my interest the most.

Hi, I guess everyone picks the language that they are most proficient at. Saying 'I'm very disappointed that it's C# and not C...' doesn't help your case ;) I could say that a C is a very old and outdated language. To make things work in C on different platforms, a much more work and time has to be invested (I know because I was C/C++ programmer back in the days before C#) than to make things work in modern languages (JavaScript, Rust, C#, etc... comes to mind). And we aren't even talking about C++ which is a much more robust that plain C. Another thing is that if you're not using managed code extensions for C++ there is a huge chance that you'll have problems with arrays and pointers (unless manual checks are in place). But enough of who has the most shiny toy :)
Also I think that you'll have much more trouble finding C/C++ programmers than programmers for modern languages.

I'm currently working on https://github.com/1oom-fork/1oom and I invite you to check it out too. There are a huge number of translation errors in 1oom, perhaps you have ideas on how to fix the situation.

Regarding your project, did you translate assembly by hand, or did you used some automated process?

In any case, I dreamed of one day starting what you are doing now, so we are on the same side.

Many people dreamed and failed (CivOne comes to mind). You could say that I'm the first to offer a most functional and complete rewrite ;)

My project is a fork. I have already fixed more than 100 translation errors. Kilgore T.M. Replicant used IDA5 and manually translated the code into C, but unfortunately did not bring the project to acceptable quality, significantly damaging the original code

My project is a fork. I have already fixed about 100 (i guess) translation errors. Kilgore T.M. Replicant used IDA5 and manually translated the code into C, but unfortunately did not bring the project to acceptable quality, significantly damaging the original code. Your project is the first one I can launch.

Some time ago I learned that directly (automatically) translating assembly to a higher level language and emulating assembly with Virtual CPU is a best starting approach because there is minimal effort required to bring your project to a runnable state.
The hardest thing is accommodating calculated jumps, adding a code blocks that disassembler didn't catch, simulating interrupts and implementing graphics routines the original code uses. It all depends if original programmer used compiler or not, and what features did he/she used.
There is also a https://github.com/OpenRakis/Spice86 project (worth checking out) that has a little bit different approach than my https://github.com/rajko-horvat/Disassembler project (not yet finished).

Moreover, I was surprised how easy it was to build a project for Linux. After such a warm welcome from dotnet, I may reconsider my views on C#

Many people switched to C# because of it's platform independence (especially since .NET foundation took over) and API rich capabilities. The classic .NET MAUI cross-platform approach often doesn't work well (apart from most basic apps, MAUI API capabilities are very lacking). I would recommend Avalonia UI for cross platform development, although start is a little bit challenging due to a very few examples and missing documentation.
I have to warn you that a Sound is still a problematic thing in .NET. There isn't a unified library that supports all platforms. Some people made shortcuts with PortAudio (Platform independent C++ library) + additional libraries, but such approach is far from perfect.

I'm writing a partial translator in Python. It is also far from complete, but it has already helped me restore the copy protection dialog from MOO1.

I'm writing a partial translator in Python. It is also far from complete, but it has already helped me restore the copy protection dialog from MOO1. Have you had success using Ghidra for your projects?

Ghidra is a cool tool, but I din't have a chance to use it yet. Like all such tools it doesn't give you a code that you can compile instantly (Unlike Spice86 and Disassembler).

Your emulation approach is very effective and interested me very much from a practical point of view, but I want to have a program that produces the most human-readable code, even if not the entire program, but in parts. In any case, your disassembler will be useful to many people, perhaps to me too

Your emulation approach is very effective and interested me very much from a practical point of view, but I want to have a program that produces the most human-readable code, even if not the entire program, but in parts. In any case, your disassembler will be useful to many people, perhaps to me too

Yes, it was my plan to produce most human-readable code, but due to intricacies of assembly I gave up because I didn't want to spend too much time on Disassembler since Civilization was my goal ;)
For example just adding local stack variables instead of whole ReadInt16(SS, offset) would make it much more human readable...

The thought comes to mind that these 2 approaches can perfectly complement each other

Off course, at the start of a project I was using IDA all of the time (If I knew Ghidra offered limited C translation I would have used Ghidra intead), along with Disassembler :)

On the contrary, I gave up trying to manually find all the errors and decided to automate the process as much as possible. I hope this approach leads to something in the end.

On the contrary, I gave up trying to manually find all the errors and decided to automate the process as much as possible. I hope this approach leads to something in the end.

Same for me too. I gave up manually translating assembly and automated the process ;) That's what gave me the best and fastest results! ;)

Maybe it is interesting for this discussion:
There is a further impressive example of a reverse engineering project of a DOS game: Bright Eyes It is about the German RPG Das schwarze Auge: Die Schicksalsklinge, the title of the English translation Realms of Arkania: Blade of Destiny.
The approach was to write a modified dosbox, which captures and redirects function calls of the original game (running in dosbox) to newly written C code. In this way, the compiled code was transferred function-by-function to C code, and the game was playable all the time. Moreover, Henne (the head behind the project) managed to reverse engineer all but ~5 functions to C code such that the original Borland C++ 3.1 compiler yields binary identical compiled code. I participated a bit in the project by improving parts of the code (introducing meaningful variable names, commenting the code etc) and fixing bugs of the original game (there are many...).
Unfortunately, the project is stalled since a few years at this state. The next steps would be the introduction of higher C data structures, decoupling the source code from dosbox to have a standalone game, and thereby setting up a modern UI.

Maybe it is interesting for this discussion:
[...]
The approach was to write a modified dosbox, which captures and redirects function calls of the original game (running in dosbox) to newly written C code. In this way, the compiled code was transferred function-by-function to C code, and the game was playable all the time. Moreover, Henne (the head behind the project) managed to reverse engineer all but ~5 functions to C code such that the original Borland C++ 3.1 compiler yields binary identical compiled code. I think he started with automatically disassembled code and then played around hard enough until the compiler gave the desired result. I participated a bit in the project by improving parts of the code (introducing meaningful variable names, commenting the code etc) and fixing bugs of the original game (there are many...).

Hm, but, why would you seek 1:1 Assembly to Compiler generated code. That's a job of a decompiler.
The issue of decompilers was discussed many times, and many projects are daily shut down because of a decompiled code (that violated Copyright rights).
The final (and the best) goal is not to produce exact code, but to rewrite code in a way that the result is your interpretation of a code, and thus your own code (that you have rights upon), not an exact replica of the code (that original Author(s) have Copyright rights upon).
Yes, it's possible to privately use decompiled code in a rewrite process, but you have to be extra careful! And none of it can end in the public!
People, the copyright issues are real, and the best way is not to mess with them!
So why would you even get yourself in a position that you have to fight any Copyright claim?

Hm, but, why would you seek 1:1 Assembly to source code. That's a job of a decompiler.
The final (and the best) goal is not to produce exact code, but to rewrite code in a way that the result is your interpretation of a code, and thus your own code (that you have rights upon), not an exact replica of the code (that original Author(s) have Copyright rights upon).
Yes, it's possible to privately use decompiled code in a rewrite process, but you have to be extra careful! And none of the original source code can end in the public!

Well, I was not involved in this step, I don't know the details, and maybe my description was not completely correct. What I know is that the code on github is C code which has the impressive feature that for ~99.9% of the funtions, the original Borland C++ complier yields a result which is identical on binary level to the original game. The published C code of course is heavily modified by hand and won't be anywhere near the original C code.

A little description of the original creator is found here.

The fact that it was possible to create source code that compiles into identical binary code is proof of authenticity, at a minimum, and at maximum, a great creative achievement. Sounds fantastic

A little description of the original creator is found here.

Sorry, but, this is not a place for such a discussion.
The @1oom-fork simply wanted a advice on how he could proceed with his own project, not for an advice on how to decompile the code.

By the way, I was once advised to open the Discussions section in my Git project. Branching in correspondence is possible there, which simplifies the discussion of several related topics

The fact that it was possible to create source code that compiles into identical binary code is proof of authenticity, at a minimum, and at maximum, a great creative achievement. Sounds fantastic

No one ever created decompiler for 16bit programs. It all on multiple variables such as type of the compiler, was direct assembly involved and so on... Some assembly is impossible to decompile.
Please, no more decompiler stuff in this thread! :)

Kilgore T.M. Replicant used IDA5 and manually translated the code into C, but unfortunately did not bring the project to acceptable quality, significantly damaging the original code.

If you wan't to discuss the code reconstruction issue more you can send me a private message via CivFanatics forum (link is in the readme).


[c++] Minor function-extract in a unit-test helper

Issue and/or context: This is a line-count-reducing under-diff split out from #2785 for issue #2407 / [sc-51048]. It will help reduce distractions on upcoming review of more substantial PRs -- although this PR has a bit more substance than #2908, #2909, and #2910.
The intended Python and R API changes are all agreed on and finalized as described in #2407.
Changes:
This is not strictly necessary -- all is does is remove some code duplication, which is a cosmetic nice-to-have. However, I found it helpful fo help me understand the functions in libtiledbsoma/test/common.cc, since I'll need to add to it.
Specifcally:

In the SOMA data model SparseNDArray and DenseNDArray are always indexed by int64
SOMADataFrame is indexed by default with a single int64 soma_joinid
However, users can have additional indices, of varying types, in addition to the int64 soma_joinid -- or, they can have one or more dims while soma_joinid is merely an attr, not a dim at all.

That third bullet has been unit-tested in TileDB-SOMA-Py for some time now; it hasn't been unit-tested in libtiledbsoma at all. For the changes on #2407 I'd like to rectify that, to increase confidence in PRs such as #2917.
Notes for Reviewer:
Currently this is stacked atop kerl/cpp-resizes which is PR #2917. If this PR can be approved sooner than some of the other ones on #2407 (and I believe it should be) then I can rebase this on top of current main in an attempt to unstack it from #2917.
#2785 is unreviewable as-is: besides being a WIP, it's an all-in-one experimental area. Smaller PRs such as this one are being offered for manageable review.

Rebased onto fresh main just now (as planned)


CSS Color System

We need to develop a color system that uses CSS variables.

Can you assign this to me!

@Mstanic05 Thank you so much for being interested in this project. Rams currently lacks any coherent color system and this has created a couple of problems. I haven't been able to create solution because I been busy working on the typeface Atkinson Hyperlegible Pro which ships with Rams. I been looking for a CSS Variable color system solution which can easily be applied to the PostCSS variables without the need to touch the core files. I have created a couple of color variables in var.css however as you can tell this is not a complete solution. I am curious to know what type of solution you have in mind. Please let me know if you have any questions from me to answer. I am very excited to see your ideas, I will open up a branch just for you.

@Mstanic05 The css-color-system branch is ready

@Mstanic05 Thanks for your support I will now work on my own implementation


Add dumb theme item cache to Control

I've experimented with this a year ago, and in targeted testing it didn't yield any meaningful performance improvements. But there seems to be a benefit to it still in some extreme situations, like mentioned in https://github.com/godotengine/godot/issues/64241. So I'm reviving it, as it shouldn't have any downsides and would be beneficial for cases that abuse theme item fetching without a cache on the user side.
Out of curiosity, I've retested the snippet from https://github.com/godotengine/godot/pull/64271#pullrequestreview-1069952451 again, and got a huge boost, on top of the caching added by @KoBeWi in that PR. From ~5.4s down to ~4.3s in debug builds! There are clearly caches missing in some of the editor log controls. Likely, RichTextLabel is doing something nasty.
This can be backported to 3.x, adjusted for the code structure there.
cc @AaronRecord since you're interested in optimizing theme.

From ~5.4s down to ~4.3s in debug builds!

Our benchmarks in 3.5 here https://github.com/godotengine/godot/pull/64329 on purely the affected get_* control functions show much more than a 20% improvement.  Seeing 600% from a quick and dirty gdscript test in editor, and up to 20X speedup when called natively on release export builds.

Thanks!


ENGINE modules aren't special, so call them MODULES

The only thing that makes an ENGINE module special is its entry
points.  Other than that, it's a normal dynamically loadable module,
nothing special about it.  This change has us stop pretending anything
else.
We retain using ENGINE as a term for installation, because it's
related to a specific installation directory, and we therefore also
mark ENGINE modules specifically as such with an attribute in the
build.info files.

The README files in Configurations/ need a rewrite.  I'm leaving that for another PR

Ping?

I have actually found ENGINE to describe the modules confusing, as it's also used as the API name. I often try to be specific and talk about ENGINE modules

Merged.
1842f369e5541d8ed9b2716cdd7d516005994733 ENGINE modules aren't special, so call them MODULES


Departmental research announcements

About the PR

Allows technologies to specify additional radio channels to announce their unlock on, in addition to the configured channel on the research console.
Additionally made a first pass at identify which technologies would be relevant to which channels.
Why / Balance

Currently the station is generally only aware of the problems research can cause, this will allow the station to also be aware of the results of that work.
Technical details

Added a RadioChannels DataField to the TechnologyPrototype
Added a step to the ResearchSystem.Console OnConsoleUnlock method to send the same radio message to each channel configured on the technology
Updated technology prototypes to include relevant radio channels

Media

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

:cl: tday

add: Science is hoarding fewer of their secrets: Unlocked technologies will now be announced on additional relevant radio channels.

I think its really quite messy to be sending radio channels for things that might not be super relevant (science often may lack the materials to make these objects) and it might just make more sense to have a public noticeboard that has new science unlocks written on it. Its not like the average service player would even know what kinds of things are inside each technology.

I think its really quite messy to be sending radio channels for things that might not be super relevant (science often may lack the materials to make these objects) and it might just make more sense to have a public noticeboard that has new science unlocks written on it. Its not like the average service player would even know what kinds of things are inside each technology.

Wasn't thinking about it as an end-all/be-all solution, more a prompt for folks in relevant departments to ask science about it.
Which as you pointed out could spark the conversation about lack of materials, hopefully sparking a conversation about acquisition of those materials.
I just know when I'm playing in other departments, most shifts I don't even think to ask science if they've unlocked anything I could use. This is just a notification to prompt those additional thoughts + discussions.

Can't say I like it. Disseminating this information is good, but the form of delivery (spamming radio channels)... suboptimal.
This is way too spammy and at the same time kinda irrelevant for a lot of players. This should definitely be a per-character opt-in.
Wanna hear a great idea where putting this would work perfectly? PDA App. Call it station science news bulletin or whatever.
As a PDA App:
* Is opt-in for each individual player (not causing unsolicited chat spam for players who aren't interested)

* Is persistent + works for latejoins (players can reference and check past research unlocks at any point in the round, regardless when they joined; solution in this PR needs people to memorize and causes wanton chat scrolling to find past announcement)

* Powerful tool for antagonists as a way to keep tabs on station research and their defense abilities (potential future mechanic - takes in encryption keys and only shows the unlocks relevant to the departments whose encryption keys you have)

* Pulls PDA from the depths of obscurity

* One more place for hackers / rogue AI to shine (spoof records to make crew believe they have access to technology they don't, or that they don't have access to technology they do)

If the goal is discoverability, tucking it away the announcements in a PDA app isn't great either.
I agree that a PDA app which displayed station research would be great, but that's a much larger scope.
I also have to question the characterization of this as spamming - its a single additional radio message per technology, only on channels that technology is relevant to. It may look like spamming for those with access to multiple of those channels - but even then its only one or two more messages per technology.

this will also mean sci researches anything from arsenal that isnt exclusively available in secfab -> departmental raid in 5s

Might be a headache but what if you could manually ping the relevant department by clicking on it in the Unlocked Technology list? With a cooldown to prevent spamming.

Agreed on the thoughts above, this is too much radio spam.

Where would be the appropriate place for something like this then? Is what science is researching intended to remain secret, or only accessible by those who know a specific way to check?

this will also mean sci researches anything from arsenal that isn't exclusively available in secfab -> departmental raid in 5s

How so? the channels on which the research is announced is configured per-technology. There is no discipline -> channel relationship.

Agreed on the thoughts above, this is too much radio spam.

Also @metalgearsloth, if there are specific changes you'd like I'll make them, but if the requested change is "all of it", please just close.

i've said this before when this gets brought up but sometimes science researches a bunch of shit at once, like say, arsenal tech during nukies or whatever, which can clog important radio channels with useless information. The average service worker doesn't need to know that science has researched lipid extraction, nor does the average engineer need to know science researched all the filler in industrial tier 1.

i've said this before when this gets brought up but sometimes science researches a bunch of shit at once, like say, arsenal tech during nukies or whatever, which can clog important radio channels with useless information. The average service worker doesn't need to know that science has researched lipid extraction, nor does the average engineer need to know science researched all the filler in industrial tier 1.

My apologies if there were previous attempts at something like this -  I tried to look for any and couldn't find any PRs / previous discussions, hence the PR.
For any future PRs I open, is it appropriate for me to respond to gameplay/design comments/concerns? Or should I just close + move on?

Shifting to draft pending possible PDA Notification system.

My apologies if there were previous attempts at something like this - I tried to look for any and couldn't find any PRs / previous discussions, hence the PR.
It was a topic in the discord once or twice.

Bulletin or PDA would be better so researched techs would be permanently visible instead of being fleeting

Letting all fabricator say once that they now have new items to be produced(like how vending machines talk) could be a solution, but it might be easily missed if the fabricator is stowed away somewhere in a corner.

i support this even with it going to radio

Sought maintainer opinion again for a final call and majority opinion was dislike on info spam / oversharing in lieu of potentially something else.


fix ci

as title

@XenoAmess Travis is no longer supported.

@XenoAmess Travis is no longer supported.

good news. it is far slower than github actions.


Add left/right arrow symbols

PR to add left/right arrow symbols

Added this in https://github.com/samwho/symbol.wtf/commit/0052dcf64096b49b2d6d6b2281e8bd089d02d2dd and added you as a co-author to ensure you are credited. Thank you for your contribution! 🙏


arXiv to HF Papers

What does this PR do?
Same as #1870
Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you read the contributor guideline,
Pull Request section?
[ ] Was this discussed/approved via a GitHub issue? Please add a link
to it if that's the case.
[ ] Did you make sure to update the documentation with your changes? Here are the
documentation guidelines.
[ ] Did you write any new necessary tests?

Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


Memory Monitoring Should be Handled Differently for Each OS

See this article:
https://knowledge.ni.com/KnowledgeArticleDetails?id=kA00Z000000P9usSAC&l=en-US
The CD is coded to provide 3 output channels for memory: Total Memory, Available and Largest Free.
FreePhysMem won't be accurate for Linux RT. Since LargestMem would throw an error, it is being filter to only run on Pharlap, which means it will always throw zero for Linux RT.
The CD could be coded to do the next instead:

Check OS from System Explorer code.

Keep current channels for Pharlap.

For Linux RT, generate the channels Total Memory and LVRT Mem Usage.

For Engine code, keep code as it is for Pharlap.

For Engine code, use System Exec call as recommended on the KB to check LVRT process memory usage.

Thanks for reporting this @agomez08!
Unfortunately we aren't actively maintaining this custom device - it was created as a demo by a former team member and there are no current plans to update it. There are obviously some other issues with the custom device as well, such as the CHMs being the default boilerplate.
If you want to make the changes, I would be happy to review and merge them.

There are some technical challenges around the idea of per-target type channels which I'll document here for posterity.
Currently there is no Action VI for handling "target type changed" events - you can create the custom device based on the currently active OS, but there is no direct way to be notified when the target type changes.
You could likely use an "on save" action VI to watch for target type/OS updates - you'd also likely want to add logic to the individual pages to force a refresh if the system definition has not yet been saved since the OS was updated.
It is also possible to change the target type outside of the System Explorer, either using the .NET API or (in new versions) through the right rail of the channel mapping diagram. These would not trigger any of the Action VIs mentioned earlier, and you would likely want to fail the compile/deployment to force the user to update the custom device.

This has effectively been addressed by #28. It removed the unsupported FreePhysMem channel now that the CD only supports Linux targets.
Any desire to add more channel monitoring is not planned for this CD as far as NI R&D is concerned, but this is open source and well-tested contributions are welcome!


Disable or modify buffering/loading bar on image sequences

When dealing with large standalone image sequences, the buffering/loading bar often does more harm than good

Do you mean the bar on the uploads dialog?   You're saying there shouldn't be a visual progress indicator?


add: ObsoleteAttribute for soon to be removed API

Fixes #962
Basically I added some ObsoleteAttribute to the diff API that isn't around in v2 anymore.

I don't think this is the right use of obsolete. My understanding is that you add obsolete attributes to things that have an alternative available. That wont be the case in v1, so these does not make sense.

Fair points - maybe a good documentation is also good enough. We can close that for now.


fix: receive message type

Fix nodex_receive ResponseType because Device should receive VC.

@curry-like
We hope you can resolve the conflict.

@curry-like
Let me just confirm one point.
There are generally no problems, so please just check that comment. 🙇


Lag on video inference with Pi 4 and Coral USB

Hello.  I am using a Pi 4B with the Coral USB.  The screen reports I'm getting around 22fps, which is great, but there is a 1-second lag between action and response.  For instance, I will move my arm up, and the video on screen only responds one second later.  This does not happen normally (for instance when I use raspistill -p the camera operates without the lag).  The one-second lag may not seem like much, but it makes the project unusable for my purposes.  Do you have any recommendations for how I can get rid of that one-second lag, or at least reduce it significantly?  Thank you for your help.

hi @Tylersuard how are you running it?
is it just python3 pose_camera.py or any additional arguments?

Hi @Namburger , thank you for the quick response.  I am pretty sure I just used the command with no arguments, I will double-check for you asap.  Here is a video of someone else having the same issue: https://youtu.be/h8MJpsoge0Q?t=73
Notice how the frame rate is 60 FPS, but the machine takes around 1 second to respond when the user moves his hands... shouldn't it only take 1/60 of a second to respond?  I'm trying to figure out a way to reduce that latency.  Thank you for your help.

@Tylersuard I tested openCV with camera examples and object tracker, performance was being deteriorated with openCV.