[Proposal] Osmdroid alternative provider for Android

Does any other open PR do the same thing?
No
What issue is this PR fixing?
This is not a fix, but is related to various enhancement requests opened from time to time to avoid using/depending on Google Maps and Google Play Services, licensing issues etc.
My motivation is: we started replacing Google maps by osmdroid on my company Android apps, but there is no solution ready to use with react-native, I could develop a new lib, and handle all issues related to multi platform, etc, or enhance an existing lib.
How did you test this PR?
I have apps in production using this code. I also run the example project and could use most of it using the proposed osmdroid provider. Actually, I used the example project to debug and develop various details I didn't use on my apps.
I am using this very code in production, but probably this branch is not in the best option to just merge in master. I hope we can at least start a discussion on how to integrate this officially on the lib.
What is included:

MapView: working with some limitations like no map styles.
Markers: most of it working, except the color for default markers and z-index.
Callouts: working. Needed some hacks as result of how it is implemented on osmdroid vs my lack of knowledge on react-native internals.
Polygons, working except for z-index and geodesic prop.
Polylines, working except for z-index and geodesic prop.

The native code is almost all contained on 'com.airbnb.android.react.maps.osmdroid' package. The only exception is com.airbnb.android.react.maps.MapsPackage that exports this provider classes, but only when osmdroid is included in the classpath. Osmdroid lib is included as a compileOnly dependency.
Cheers

@alvelig 🐽, any thoughts on this, my java-fu is not good at all 😄

Any new thoughts on this?
What you think of integrating this as an experimental feature? I can update the docs an guides adding information on this feature.
I am planning on release a new version soon, an will check for updates on lib and react-native versions. It would be great if I can just reference a new version of this package (or a branch) instead of a feature branch of mine.
Thanks in advance.

@fqborges have a look at https://github.com/react-community/react-native-maps/pull/2396
Additional library support should be looking like that some time soon.

That solution is wonderful for iOS, but for android usually the solution for the same use case are one of: a compileOnly dependency + runtime check; or a second library to be included that injects the dependency and configuration to make optional things available. Remembering that this PR touches Android only on the native side.
I have used the first one in this PR, since it is simpler and more straightforward for users. You can review it on https://github.com/fqborges/react-native-maps/blob/osmdroid/lib/android/build.gradle#L53 and https://github.com/fqborges/react-native-maps/blob/osmdroid/lib/android/src/main/java/com/airbnb/android/react/maps/MapsPackage.java#L65.
An example of using this can be viewed on the example project at https://github.com/fqborges/react-native-maps/blob/osmdroid/example/android/app/build.gradle#L137 where the option dependency is included on build.gradle, making optional things available, and https://github.com/fqborges/react-native-maps/blob/osmdroid/example/App.js#L127 where the provider is set. Simple like that for the user.
Another solution would be setting a project configuration to be read on build.gradle (like this https://github.com/fqborges/react-native-maps/blob/osmdroid/lib/android/build.gradle#L46) and configure some conditional compilation.
Please let me know if I am missing something.
Cheers.

@fqborges can u show me where i can find tutorial step by step to implement openstreetmap in react native use react-native-maps ?

@wresniwahyu To use this pull base on your app do the following steps:

Install using the default tutorial: https://github.com/react-community/react-native-maps/blob/master/docs/installation.md (You can ignore the GoogleMaps API key step, if you want)
On your package.json change the react-native-maps version to "react-native-maps": "git://github.com/fqborges/react-native-maps#osmdroid+hotfix",  (do not forget to run yarn or npm after changing the package.json)
On your android root build.gradle add osmdroidVersion = '6.0.1' to your project-wide properties. See: Installation instructions on Android, step 1
On your android app build.gradle add osmdroid to your project dependencies using the following: implementation "org.osmdroid:osmdroid-android:${project.osmdroidVersion}"
Add provider={'osmdroid'} property to your MapView.

@fqborges can u show me where i can find tutorial step by step to implement openstreetmap in react native use react-native-maps ?

If you mean implement a new provider, I can do that later. But only know the android native side.

@fqborges can u show me where i can find tutorial step by step to implement openstreetmap in react native use react-native-maps ?

If you mean implement a new provider, I can do that later. But only know the android native side.

is it posible if i want to use openstreetmap with react-native-maps in multiple platform (iOS and Android) ?

@wresniwahyu For that you need a iOS map library that supports OSM tiles, and implement a provider for react-native-maps using it. The GoogleMaps iOS provider is a good starting point.

@wresniwahyu To use this pull branch on your app do the following steps:

Install using the default tutorial: https://github.com/react-community/react-native-maps/blob/master/docs/installation.md (You can ignore the GoogleMaps API key step, if you want)
On your package.json change the react-native-maps version to "react-native-maps": "git://github.com/fqborges/react-native-maps#osmdroid+hotfix",  (do not forget to run yarn or npm after changing the package.json)
On your android root build.gradle add osmdroidVersion = '6.0.1' to your project-wide properties. See: Installation instructions on Android, step 1
On your android app build.gradle add osmdroid to your project dependencies using the following: implementation "org.osmdroid:osmdroid-android:${project.osmdroidVersion}"
Add provider={'osmdroid'} property to your MapView.

i've following installation step by step above for android but my map blank like this

i've follow this step too
https://github.com/react-community/react-native-maps/blob/master/docs/installation.md#troubleshooting
but still blank
this is my project wide properties
ext {     buildToolsVersion = "27.0.3"     minSdkVersion = 16     compileSdkVersion = 27     targetSdkVersion = 27     supportLibVersion = "26.1.0"     osmdroidVersion = '6.0.1'     androidMapsUtilsVersion = "0.5+" }
react dependencies
"dependencies": {
"axios": "^0.18.0",
"moment": "^2.22.2",
"native-base": "^2.8.0",
"react": "16.4.1",
"react-moment": "^0.7.9",
"react-native": "0.56.0",
"react-native-ci-tools": "^1.1.0",
"react-native-image-picker": "^0.26.10",
"react-native-loading-spinner-overlay": "^0.5.2",
"react-native-maps": "git://github.com/fqborges/react-native-maps#osmdroid+hotfix",
"react-native-picker-select": "^4.2.0",
"react-navigation": "^2.12.1",
"tcomb-form-native": "^0.6.15"
},
gradle dependencies
dependencies {
implementation project(':react-native-maps')
implementation "org.osmdroid:osmdroid-android:${project.osmdroidVersion}"
implementation project(':react-native-image-picker')
implementation project(':react-native-vector-icons')
implementation fileTree(dir: "libs", include: ["*.jar"])
implementation "com.android.support:appcompat-v7:${rootProject.ext.supportLibVersion}"
implementation "com.facebook.react:react-native:+"  // From node_modules
}
setting gradle
include ':react-native-maps'
project(':react-native-maps').projectDir = new File(rootProject.projectDir, ../node_modules/react-native-maps/lib/android')
MainApplication.java
`
import android.app.Application;
import com.facebook.react.ReactApplication;
import com.imagepicker.ImagePickerPackage;
import com.oblador.vectoricons.VectorIconsPackage;
import com.facebook.react.ReactNativeHost;
import com.facebook.react.ReactPackage;
import com.facebook.react.shell.MainReactPackage;
//import com.facebook.soloader.SoLoader;
import com.airbnb.android.react.maps.MapsPackage;
import java.util.Arrays;
import java.util.List;
public class MainApplication extends Application implements ReactApplication {
private final ReactNativeHost mReactNativeHost = new ReactNativeHost(this) {
@Override
public boolean getUseDeveloperSupport() {
return BuildConfig.DEBUG;
}
@Override
protected List<ReactPackage> getPackages() {
  return Arrays.<ReactPackage>asList(
      new MainReactPackage(),
        new ImagePickerPackage(),
        new VectorIconsPackage(),
          new MapsPackage()
  );
}

@Override
protected String getJSMainModuleName() {
  return "index";
}

};
@Override
public ReactNativeHost getReactNativeHost() {
return mReactNativeHost;
}
@Override
public void onCreate() {
super.onCreate();
//    SoLoader.init(this, /* native exopackage */ false);
}
}
`
MapView
`
import React, { Component } from 'react';
import { Scrollview, View, ActivityIndicator, AsyncStorage } from 'react-native';
import MapView from 'react-native-maps';
const styles = StyleSheet.create({
container: {
...StyleSheet.absoluteFillObject,
height: 400,
width: 400,
justifyContent: 'flex-end',
alignItems: 'center',
},
map: {
...StyleSheet.absoluteFillObject,
},
});
export default class Status extends Component {
constructor() {
super();
this.state = {
    };
}

render() {
    return (
        <View style ={styles.container}>
            <MapView
                style={styles.map}
                provider={'osmdroid'}
                region={{
                latitude: 37.78825,
                longitude: -122.4324,
                latitudeDelta: 0.015,
                longitudeDelta: 0.0121,
                }}
            >
            </MapView>
        </View>
    );
}

}
`
do u know what should i do? @fqborges

@wresniwahyu Please grab a Google Maps API key and make it work on the last release of the lib, following the official tutorial (step 1 above). Then change to this PR an try to make it work.
I am sorry I do not have the time to see this today. I'll try to give a look on the weekend.

will this be aded to IOS builds?

will this be aded to IOS builds?

This PR is Android only, osmdroid is a library only available to android

Any chance to get this PR merged to master? I'd like to have this branch for android and iOS (since one project supports both) and I'm a little shaky on pointing npm at a git branch that may go away at any time.
I would propose we have a new "PROVIDER_OSM" that used the "Default" on iOS and this the osmdroid for Android. I would even go as far as to say this should be the default provider.

@mikepc I am looking forward to have this merged in the master. I am am also not comfortable pointing to a git branch instead of the package version, even more when my apps are already in production with thousand of users.
To minimize your risk, you can fork that branch in a repo of yours, so at least you minimize the risk of it just going away.

I tried to merge this PR with master in my fork. Works great on Android. I used
provider={Platform.OS === 'ios' ? null : 'osmdroid'}
for MapView
And react-native-maps works without Google API key! Hooray!
But when I tried to use UrlTile for custom tile I got this error:
TypeError: TypeError: Cannot read property 'android' of undefined

This error is located at:
    in MapUrlTile (at TaskMap.js:17)
    in OsmMap (at MapView.js:887)

I figured out that happens because there is no info about provider in export in MapUrlTile.js
So I added it to export in this and in some other components for MapView
osmdroid: {
      android: SUPPORTED,
    },

Now this error is fixed and I faced new error:
Invariant Violation: Invariant Violation: requireNativeComponent: "OsmMapUrlTile" was not found in the UIManager.

This error is located at:
    in OsmMapUrlTile (at MapUrlTile.js:58)

@fqborges can you, please, help to resolve the issue?

The thing is: MapUrlTile is not implemented for this provider. It seems stupid, but on the most common case, that happens to be also mine, people just want to use the default OSM tiles.
The solution is relatively simple on native side: create OsmMapUrlTile and OsmMapUrlTileManager class on package package com.airbnb.android.react.maps.osmdroid. On the javascript side, you already have the needed changes, as you just described.
While writing this I started investigating and I have this half done already. I will probably push in a few minutes.

@fqborges thank you very much! You are doing really great job!
I tested your commit. It works, but I had a bug, then zooming. Previous tile appeared over new tile in specific zoom level. I think it happens because previous tile cashed in memory. So I tried to reinstall app and It's gone away!
Also new tile loads on top of default tile (you can see when zooming). It's really strange, but I think It's another question.
So, UrlTile works, thanks again!
@rborn @alvelig hey guys, that about to merge this PR?

I tested map a little more and found that with osmdroid it's unable to use new methods with camera like animateCamera, getCamera etc. Obliviously, all other features based on Google Maps would be unavailable.
Maybe would be better to create new npm package like react-native-maps-osmdroid ? And gradually remove all Google Maps features and implement it with osmdroid's ?

@Peretz30 I am thinking on publish a new package maintaining source compatibility and adding osmdroid as the new default provider and keeping google as optional. It is doable, I already made some tests.
About the animateCamera, getCamera etc, it is als doable. When I implemented this branch I used osmdroid v5, that was missing float point zoom values, and some animations. Version 6 includes most things needed for those animations methods and some currently missing features. As a last resort, it is possible to implement most of those on the provider itself, there are some examples on osdroid repo.

@fqborges very nice branch and work.
Looking at the time to take a decision on merging or not this branch, I see a real positive impact to create a new repository for osmdroid version for react-native.

For all those interested, I published this work as https://www.npmjs.com/package/react-native-maps-osmdroid.
Still experimental though, it works perfectly to my use case, but can have problems for the general use.
I made it to be version-to-version fully compatible with react-native-maps, keeping it compatible for those who wants to use in place of the original, and keeping the possibility to be merged here when the time comes.

Any chance of integrating this on the main line? It would be VERY great not to have to have a Google API key.

I played around with the fork you made and it worked reasonably well for me - I ran into an issue with pin label callouts crashing the app, likely due to changes in react native over the past year or so. I did a local merge of your fork with the master branch on this repo and in general things are working however I still ran into the same callouts crash problem.
I’m willing to dig deeper and help fix some issues here and provide an updated PR that’ll merge with the code as it stands today as I desire to have not depend on a google key - scalability will start to get expensive for the non-profit charity I code for. I just have limited time and don’t want to commit to this if it isn’t going to be merged and have community maintenance.
So I’m throwing my hat in the ring to assist, if others do the same. Thanks,

Closing as being an old issue and not a clear reply. Thanks for all the effort 😻

For all those interested, I published this work as https://www.npmjs.com/package/react-native-maps-osmdroid.
Still experimental though, it works perfectly to my use case, but can have problems for the general use. Still incomplete, so all the help is welcome.
I made it to be version-to-version fully compatible with react-native-maps, keeping it compatible for those who wants to use in place of the original, and keeping the possibility to be merged here when the time comes.

Now does it support iOS ?

@rborn Can you please reopen this ticket? It looks like react-native-maps-osmdroid is really close to being ready to be merged back into react-native-maps. iOS support also seems squared away now (right, @fqborges ?). There hasn't been any activity in the react-native-maps-osmdroid fork in the last 5 months and it's a shame, since a lot of people would still like to have this functionality, I think.
A single library with booth a Google and OSM provider included, without requiring a Google API key when using OSM, that would be great.

@volkert-fastned This fork is used in all map enabled apps, here in my company. It has been running in production since the fork was created, and undergone some updates updates for upgrading react-native.
On iOS side, it works exactly as the original, since it is the exactly same codebase. On android using google it is also the same code. The osmdroid provider works ok, but probably there is more work to be done regarding full compatibility, we do not use all features available. For example, there are some opened issues regarding info windows that stopped working, probably after a version upgrade.

@fqborges Thanks for the info. Does react-native-maps-osmdroid also still have the Google provider included? So a single app can be built with support for both Google Maps and OpenStreetMap?

@volkert-fastned  yes, it includes all the code in this repo (not fully updated yet) and a extra provider to display OpenStreetMap maps.
You can run the example there to get the ideia, it is possible to change the provider on the fly

@fqborges Since you were the one who opened this issue, do you see the option to reopen it? Or do we need to ask @rborn to do so?

@volkert-fastned @fqborges re-opened

I've been very busy, but I will try to solve this in the next days.

Just to ping you all, still busy. I hope I can do something in the next week or two.

this is not stale

@fqborges Any news? Is there any way we can help you get this merged? If you're too busy, perhaps you can hand it over to someone else here? Thanks. :slightly_smiling_face:

@volkert-fastned No good news. I am busy catching up with things that showed up during this pandemics.

If you're too busy, perhaps you can hand it over to someone else here?

Yes, just ping me and I can add people as admin on my fork. There is already a PR there from someone merging upstream/master, maybe that can help. Also, I am available to help or explain things.

@fqborges Thanks for the repository access. However, during the coming Holiday period I won't have time to work on this either. The earliest I can take a look at this will be some time in January.
I wish everyone Happy and Healthy Holidays, despite these challenging times. :heart:

I'm sorry I haven't gotten around to this yet. But I hope to look into it soon. (Any help in the meantime is welcome, of course.)

@volkert-fastned I am going to be closing this PR since it is unlikely we will be adding any more providers to this library. There was a long discussion about adding Google as a provider for iOS years ago. In the end, it was decided to allow it so the map implementation can match 1:1 with Android. However, this did make it a lot harder to maintain this project by having tracking what provider people were having issues with on iOS. I think it's best to take a look at some of the existing projects that have tried to implement OSM and contribute there.


Can I save changes from acro-forms?

No. There is no plans to modify a PDF document.

https://github.com/mozilla/pdf.js/wiki/Frequently-Asked-Questions#is-it-possible-to-add-annotations-to-a-pdf


You might need to add them         to your LD_LIBRARY_PATH

windows system
===================================BUG REPORT===================================
The following directories listed in your path were found to be non-existent: {WindowsPath('H')}
The following directories listed in your path were found to be non-existent: {WindowsPath('vs/workbench/api/node/extensionHostProcess')}
The following directories listed in your path were found to be non-existent: {WindowsPath('/matplotlib_inline.backend_inline'), WindowsPath('module')}
CUDA_SETUP: WARNING! libcudart.so not found in any environmental path. Searching in backup paths...
The following directories listed in your path were found to be non-existent: {WindowsPath('/usr/local/cuda/lib64')}
DEBUG: Possible options found for libcudart.so: set()
CUDA SETUP: PyTorch settings found: CUDA_VERSION=118, Highest Compute Capability: 8.6.
CUDA SETUP: To manually override the PyTorch CUDA version please see:https://github.com/TimDettmers/bitsandbytes/blob/main/how_to_use_nonpytorch_cuda.md
CUDA SETUP: Loading binary h:\Miniconda3\envs\chatGLM\lib\site-packages\bitsandbytes\libbitsandbytes_cuda118.so...
argument of type 'WindowsPath' is not iterable
CUDA SETUP: Problem: The main issue seems to be that the main CUDA runtime library was not detected.
CUDA SETUP: Solution 1: To solve the issue the libcudart.so location needs to be added to the LD_LIBRARY_PATH variable
CUDA SETUP: Solution 1a): Find the cuda runtime library via: find / -name libcudart.so 2>/dev/null
CUDA SETUP: Solution 1b): Once the library is found add it to the LD_LIBRARY_PATH: export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:FOUND_PATH_FROM_1a
CUDA SETUP: Solution 1c): For a permanent solution add the export from 1b into your .bashrc file, located at ~/.bashrc
CUDA SETUP: Solution 2: If no library was found in step 1a) you need to install CUDA.
CUDA SETUP: Solution 2a): Download CUDA install script: wget https://github.com/TimDettmers/bitsandbytes/blob/main/cuda_install.sh
CUDA SETUP: Solution 2b): Install desired CUDA version to desired location. The syntax is bash cuda_install.sh CUDA_VERSION PATH_TO_INSTALL_INTO.
CUDA SETUP: Solution 2b): For example, "bash cuda_install.sh 113 ~/local/" will download CUDA 11.3 and install into the folder ~/local
Output exceeds the size limit. Open the full output data in a text editor
RuntimeError                              Traceback (most recent call last)
Cell In[12], line 2
1 tokenizer = AutoTokenizer.from_pretrained("Baichuan2-7B-Chat-4bits", use_fast=False, trust_remote_code=True)
----> 2 model = AutoModelForCausalLM.from_pretrained("Baichuan2-7B-Chat-4bits", torch_dtype=torch.bfloat16, trust_remote_code=True)
3 model.generation_config = GenerationConfig.from_pretrained("Baichuan2-7B-Chat-4bits")
File h:\Miniconda3\envs\chatGLM\lib\site-packages\transformers\models\auto\auto_factory.py:479, in _BaseAutoModelClass.from_pretrained(cls, pretrained_model_name_or_path, *model_args, **kwargs)
475     model_class = get_class_from_dynamic_module(
476         class_ref, pretrained_model_name_or_path, **hub_kwargs, **kwargs
477     )
478     _ = hub_kwargs.pop("code_revision", None)
--> 479     return model_class.from_pretrained(
480         pretrained_model_name_or_path, *model_args, config=config, **hub_kwargs, **kwargs
481     )
482 elif type(config) in cls._model_mapping.keys():
483     model_class = _get_model_class(config, cls._model_mapping)
File ~/.cache\huggingface\modules\transformers_modules\Baichuan2-7B-Chat-4bits\modeling_baichuan.py:596, in BaichuanForCausalLM.from_pretrained(cls, pretrained_model_name_or_path, config, cache_dir, ignore_mismatched_sizes, force_download, local_files_only, token, revision, use_safetensors, *model_args, **kwargs)
594 if hasattr(config, "quantization_config") and config.quantization_config['load_in_4bit']:
595     try:
--> 596         from .quantizer import init_model_weight_int4
597         from accelerate import init_empty_weights, dispatch_model, infer_auto_device_map
598         from accelerate.utils import CustomDtype
...
python -m bitsandbytes
    Inspect the output of the command and see if you can locate CUDA libraries. You might need to add them
    to your LD_LIBRARY_PATH. If you suspect a bug, please take the information from python -m bitsandbytes
    and open an issue at: https://github.com/TimDettmers/bitsandbytes/issues

+1

I had the same error in a jupyter notebook on a cloud provider and in the end the problem was an pre-installed but outdated torch version. Updating to the latest versions solved the issue for me:
%pip install torch==2.0.1
%pip install accelerate==0.23.0
%pip install transformers==4.33.2
%pip install bitsandbytes==0.41.1

+1

Bitsandbytes was not supported windows before, but my method can support windows.（yuhuang）
1  open folder J:\StableDiffusion\sdwebui，Click the address bar of the folder and enter CMD
or WIN+R, CMD  。enter，cd /d J:\StableDiffusion\sdwebui
2  J:\StableDiffusion\sdwebui\py310\python.exe -m pip uninstall bitsandbytes
3 J:\StableDiffusion\sdwebui\py310\python.exe -m pip uninstall bitsandbytes-windows
4 J:\StableDiffusion\sdwebui\py310\python.exe -m pip install https://github.com/jllllll/bitsandbytes-windows-webui/releases/download/wheels/bitsandbytes-0.41.1-py3-none-win_amd64.whl
Replace your SD venv directory file（python.exe Folder） here（J:\StableDiffusion\sdwebui\py310）

@sigma-andex your solution also worked for me ! thanks!


Initial Sample App commit

Hi @kunal4345 — was this a mistake or is their code you were hoping to merge with the main repository? I will close this pull request for now.

Mistake, sorry about that.
On Tue, 8 Sep, 2020, 4:18 pm Varun Shenoy<EMAIL_ADDRESS>wrote:

Hi @kunal4345 https://github.com/kunal4345 — was this a mistake or is
their code you were hoping to merge with the main repository? I will close
this pull request for now.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/CardinalKit/CardinalKit/pull/26#issuecomment-689185565,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AI6U5QVBRXCE3D4OQDTUYVTSE23UZANCNFSM4Q7LR3LQ
.


feat(TDI-45202): Azure Storage Blob DLS Gen2

What is the current behavior? (You can also link to an open issue here)
https://jira.talendforge.org/browse/TDI-45202
What is the new behavior?
This is the rewriting of Azure Storage Blob management using MS latest SDK version compatible with Azure Storage v1 and v2.
Please check if the PR fulfills these requirements

[X] The commit message follows Talend standard
[X] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features) ?
[X] The code coverage on new code >75%
[ ] The new code does not introduce new technical issues (sonar / eslint)

What kind of change does this PR introduce?

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build / CI related changes
[ ] Other... Please describe:

Does this PR introduce a breaking change?

[ ] Yes
[X] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:

Pull request test result: success :star:

if the code for TDP connectors, don't find any connectors which can works for TDP

if this for TDP, no need for master, as master already not for TDP as we remove all rest-service in master already.

if this for TDP, no need for master, as master already not for TDP as we remove all rest-service in master already.

obsolete


adding previous versions of documentation

Adding the previous-versions directory so that we have a place to keep older versions of the documentation. Our build scripts will update this directory automatically.


In RTL mode panes fly from/to the middle of screen instead of leftside

this is about preview release of iD

That's nice! but in rtl looks a bit odd:

It should fly from/to the leftside. thanks

Fixed. Thanks for posting, @iriman!

many thanks for fixing! :)


Fix a crash that would occur when no multitasking option was selected

Fixes #1961, fixes #1971, fixes #1936, fixes #1939, maybe fixes #1958
Appcenter:<PHONE_NUMBER>u
Sometimes after changing multitasking setting (adaptive, horizontal, vertical) all 3 multitasking options get disabled/deselected.
If this happens, from there on, app crashes with NullPointerException in BaseLayout, with a stacktrace similar to:

2020-09-18 00:24:03.6905|ERROR|Files.App|Object reference not set to an instance of an object.|System.NullReferenceException: Object reference not set to an instance of an object. at Files.BaseLayout.OnNavigatedTo(NavigationEventArgs eventArgs) at System.Threading.WinRTSynchronizationContextBase.Invoker.InvokeCore()

I still face this issue sometimes :/

I still face this issue sometimes :/

Can you please open an issue for this?

Ok, will do


Upgrade orjson to 3.5.3

What does this PR do?
Upgrade orjson to 3.5.3
Motivation
This version adds binary wheels for Python 3.9 on Windows.
Additional Notes
Version 3.0.0 accepts more types in dumps, otherwise should be backwards compatible.
Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] PR title must be written as a CHANGELOG entry (see why)
[ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
[ ] PR must have changelog/ and integration/ labels attached

Hmm, https://gitlab.ddbuild.io/DataDog/datadog-agent/-/pipelines/4773222


Fix weekly rating

This PR should  fix the issue where the rating view was opening every time the app opens during the allowed period. Was not using settingService to keep track of the last time that it was presented.

Should this not be merged into the release branch?


feat(DIA-114): add highlights and achievements to artist about tab

This PR resolves DIA-114
Description
Adds Highlights and Achievements section. Some logic was copied from Force to keep 1:1 behavior consistent among the 2 platforms.
iPhone 14 Pro Max
https://github.com/artsy/eigen/assets/15792853/f31ecd8e-b35e-4f4f-9a1f-57d23438182d
iPad

PR Checklist

[ ] I have tested my changes on iOS and Android.
[ ] I hid my changes behind a feature flag, or they don't need one.
[ ] I have included screenshots or videos, or I have not changed the UI.
[ ] I have added tests, or my changes don't require any.
[ ] I added an app state migration, or my changes do not require one.
[ ] I have documented any follow-up work that this PR will require, or it does not require any.
[ ] I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

add highlights and achievements to artist about tab - araujobarret

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

This PR contains the following changes:

Cross-platform user-facing changes (add highlights and achievements to artist about tab - araujobarret)

  Generated by :no_entry_sign: dangerJS against 39916e97390e192366ad906dffd67790774acc42


Python3

install.sh throws an error when preparing to install
Can't install on this systen. Needs python version >= 3.6
When I run python3 -V the result is
Python 3.10.6

Fixed.


If python is required then python-dev should be as well

I was testing rally on an Linux machine and I hit the following error:
$ ./rally configure
Auto-updating Rally from origin
psutil/_psutil_common.c:9:10: fatal error: Python.h: No such file or directory
 #include <Python.h>
          ^~~~~~~~~~
compilation terminated.
error: Setup script exited with error: command 'gcc' failed with exit status 1

It turns out that I was missing python-dev package. Installing it like yum install python3-devel.x86_64 fixed the issue. May be rally can check for this in advance and not run into error (which does not yield very informative message).

Your observation is correct and this is also covered in the documentation:

If you get errors during installation, it is probably due to the installation of psutil which we use to gather system metrics like CPU utilization. Please check the installation instructions of psutil in this case. Keep in mind that Rally is based on Python 3 and you need to install the Python 3 header files instead of the Python 2 header files on Linux.

You run into this problem while psutil is installed which requires Python headers. While it may be possible to check this, I think the better option is to improve the documentation and provide concrete installation commands for all dependencies (Python + dev package) for major distributions.


blink=True doesn't blink

In your example "colors" you have
click.echo(click.style('I am blinking', blink=True))

Unfortunately, it doesn't blink. I have tried it with different terminals (Hyper and Termination). This are the outputs:

The terminal has the final say in how it displays text. For example, xfce-terminal doesn't blink text, but konsole does.


Document.getElementById() must return Element, not HTMLElement

SVG elements are also reachable through document.getElementById(), see https://developer.mozilla.org/en-US/docs/Web/API/Document/getElementById.
Other methods may need to be adjusted in the same way. Please, review them.

Related discussion in https://github.com/Microsoft/TypeScript/issues/4689

I believe this can be closed in favour of #4689.


[bug?] WelcomeMessage not displaying

Using version 2.1.0
Given the plopfile:
module.exports = function(plop) {
  plop.setWelcomeMessage('this is welcome message')
}

The welcome message will not display. This happens to me as well when I have a generator.
It's strange because the plop example seems to work but I've never managed to get it working on my own plopfiles :(

If you have only 1 generator, the welcome message is skipped and you are sent right into the only generator available. Sounds like this might be what you're seeing?

I agree. I think the welcome message should show if it's specified. This was more of a consequence than a conscious decision. It came out of a request to automatically launch the generator if there is only one available.
However, if someone added their own welcome message... it should be shown regardless of how many generators there are.


[💡 FEATURE] - Show window title in context menu

Open several documents, spreadsheets etc...
Right click on app dock icon like the example below
All windows show as "Google Drive" but the ideal would be to show the titles of each window.

Oh, I think PR #78 solved this issue but the release is still missing/


Incompatibility with Artifacts mod

If the artifacts mod is installed the elytrian is unable to fly with the built in elytra

Can't reproduce - works fine with latest version of Origins and Trinkets.


Doc fixes

Fixes:

kubectl commands in WALKTHROUGH.md
image name in xkcd helm chart

@asw101 I'm going to close this. feel free to re-open if you're interested in continuing with it. if not, feel free to pick up other work if you're interested. there's plenty to do and I'm happy to help you pick something! 🥂


[WIP] Upgrade opentelemetry sdk. Closes #570

Closing this, since this needs to go into the 5.5.x release branch
Covered by #601


One line per char using default Blackberry browser

when using default blackberry browser, only 1 char per line was displayed.
ie: "blue" will be displayed as
b
l
u
e

Blackberry seriously? :)

just trying to be pedantic :) LOL


Fix typo in mk-fipsmodule-cnf.pl

I think I made them broken when editing multiple lines at the same time.
Checklist

[x] documentation is added or updated
[x] tests are added or updated

Agree its urgent to fix other PR's.

Merged, thanks for the fix.

Why couldn't this repository's CI find this issue?

Why couldn't this repository's CI find this issue?

It would have been found very quickly with use strict;, hence my question. But yes, there's also the issue that testing in the CI didn't spot this, but then no CI covers 100%

Why couldn't this repository's CI find this issue?

It would have been found very quickly with use strict;, hence my question. But yes, there's also the issue that testing in the CI didn't spot this, but then no CI covers 100%

I see. With this issue, the broken fipsmodule.cnf, OpenSSL even couldn't load the fips provider, and I reported the issue at https://github.com/openssl/openssl/discussions/24991. So, I thought some test cases were missing in the CI.


Using a script to send transactions deploying contracts and sending ether Not Working on goerli arbitrum

Component
Forge
Have you ensured that all of these are up to date?

[X] Foundry
[X] Foundryup

What version of Foundry are you on?
forge 0.2.0 (df8ab09 2023-03-14T09:58:14.632506Z)
What command(s) is the bug in?
forge script
Operating System
macOS (Intel)
Describe the bug
When I use a script that deploys a contract that uses an external library, forge should be deploying this library ahead of my contract and linking it to my contract before deploying my contract.
This can work. It occasionally does.
But 95% of the time or more, I receive an error about gas estimation or an error about mismatched nonces from the provider.
When it is an error about gas estimation, it can be before it sends any transactions. Or, it can deploy the library first, continuing onto the transactions defined in my script, and error about gas estimation when it reaches the transaction that will deploy my contract - the second out of three script defined transactions.
Right now, I am deploying to Arbitrum Goerli and it is constantly failing although it has occasionally succeeded in the past.

I'm having an impossible time deploying onto Arbitrum Goerli again.
(code: -32000, message: err: max fee per gas less than block base fee: address 0xA600AdFzCB8C750482a828q128495e026446cA96, maxFeePerGas: 101070000 baseFee: 101340000 (supplied gas 309316493),

Still having this awful experience with Arbitrum Goerli. Seems like it is on their side as it works sometimes and does not work at all other times.

@realisation Do you have a deployment repo and script that we can try to reproduce?

I'd appreciate a minimal example that I can use to debug this.

All my stuff is private. It happens when I try to do multiple interactions with Arbitrum Goerli. Potentially even one interaction. It can be for deploying a contract or just calling a contract. The flow that it messes up on mostly for me is interacting with a contract, deploying a contract, then sending ether to that contract with .call(). The contract has an external library so this generates four transactions, with the deployment of the external library prepending before the other three.

When I try to do this flow, a great deal of the time it does not send any transactions, complaining about the gas fee. Maybe about as often it gets the first transaction through, deploying the external library. Very occasionally it gets the second transaction through. Never does it get to the third or fourth transactions.

Make a simple script. Use an arbitrum RPC. Interact with a few contracts in the script with vm.broadcast(). You will see the problem.

It would save me time if I had a minimal repro that I could debug directly

It would save me time if I had a minimal repro that I could debug directly

It's that simple, you can make one. There are no complications. Interact multiple times in a standard foundry script and you will see. I am experiencing the problem again.

Hey @realisation :)
While we could try to make a repro, we are juggling a few different projects and it's hard to prioritize. If you want to get the best service out of us, you can help us by making the EXACT problem you're encountering as simple as "clone this repo, run forge test, the problem is there".
 So it is important that you have exact steps for reproducing, or we won't be able to prioritize it.
Appreciate the understanding, it is part of our culture to have repros and would like everyone to respect that :)

Marking as requires reproduction
Please re-open with a minimal reproduction if you are still facing this issue @mesozoic-technology


4.5.3 regression on Travis CI breaks builds

The failure is Error: ENOENT: no such file or directory, scandir '.../node_modules/node-sass/vendor. Downgrading to version 4.5.2 resolves the issue.
Cannot reproduce locally and as it's a managed environment I can only extract some of the version information from the build log:
$ node --version
v6.10.3
$ npm --version
3.10.10
$ nvm --version
0.33.2
Travis configuration:
https://github.com/miguelcobain/ember-paper/blob/cef52e7638615e44249775b0663ba8f48d7bb8c1/.travis.yml
Failing job:
https://travis-ci.org/miguelcobain/ember-paper/jobs/233735922
Successful job:
https://travis-ci.org/miguelcobain/ember-paper/jobs/233735922
The only difference is the node-sass version.

The only think 4.5.3 added as support for another module version of Node 8 https://github.com/sass/node-sass/compare/v4.5.2...v4.5.3
This looks like another general yarn caching issue https://github.com/sass/node-sass/issues/1804

Sounds like a reasonable explanation but using --force or removing Yarn cache usage in .travis.yml does not appear to help.

Please file an issue with yarn. They're actively trying to address
node-sass incompatibilities
On 18 May 2017 10:13 pm, "Björn Harrtell"<EMAIL_ADDRESS>wrote:

Sounds like a reasonable explanation but using --force or removing Yarn
cache usage in .travis.yml does not appear to help.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/sass/node-sass/issues/1971#issuecomment-302528183,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAjZWO3g-nPKolJ0FEI-thrc-VFdeU4pks5r7KZqgaJpZM4Nfr1h
.

Confirmed to be more or less the same issue as described in https://github.com/yarnpkg/yarn/issues/1981. The workaround npm rebuild node-sass run as the postinstall script works in my case.

Had the same issue but instead of adding it inside the package.json a put the following code in the .travis.yml
before_script: npm rebuild node-sass;

Works great for me.


jib in multi-project-build

Environment:

Jib version: 1.4.0
Build tool: gradle 5.1

Description of the issue:
We have a multi-project gradle built which builds one WAR file and multiple JAR. I am struggling with the fact, that due to the configured WAR plugin, jibExplodedWar seems to be triggered for the JAR subprojects.
e.g.
apply plugin 'war'
...
project ( ':sub1 ){

   jib {
     from {
       image = 'openjdk:8-jre-alpine'
     }
     to {
       image = "${idsDockerRepoURL}/${project.group}.${project.name}".toLowerCase()
       auth {
          ....
       }
       tags = ["${project.version}".toString(), "latest"]
     }
     container {
       mainClass = '...'
       jvmFlags=['-Xms256m','-Xmx512m']
       useCurrentTimestamp = true
     }
   }

   jar {
        baseName = project.name
        archiveName = "sub1.jar"
        from ("${projectDir}/../....") {
            into "...."
        }
    }
}

Is there a possibility to deactivate the jibExplodedWar-Task and revert back to the jar-file jib-build?
regards
Marc

if you do not apply the war plugin on a subproject it wont be triggered.

Problem is - the main project and several subprojects needs the war plugin. I am not very skilled in gradle and dont know how to remove the plugin from the subproject block.
Do you have a hint for me?
thanks & regards
Marc

applying the 'war' plugin on the parent shouldn't apply it to the subprojects so your first line is okay. You just need to selectively apply war to the subprojects correctly
so you can:

move the apply plugin "war" directly into the build.gradle file for the subproject instead of doing everything in the parent build.gradle
filter your projects somehow perhaps using the solutions in here: https://stackoverflow.com/questions/13868177/apply-configuration-to-specific-projects-in-gradle-build-script

Yeah - i found that out the very second: applying in the main project and only those sub-projects that need the war plugin selectively.
Thanks thousand times!


Add ability to specify locale when creating a schema

I can assign a locale to a schema field using the API directly, like this
	 curl "http://localhost:8108/collections" \
       -X POST \
       -H "Content-Type: application/json" \
       -H "X-TYPESENSE-API-KEY: ${TYPESENSE_API_KEY}" \
       -d '{
         "name": "english_thai",
         "fields": [
          {"name": "english", "type": "string" },
          {"name": "thai", "type": "string", "locale": "th" }
         ],
         "default_sorting_field": "num_employees"
       }'

I can't find an equivalent way to specify locale using the dart client.

2.17.0 is fine. Thanks a lot for your quick response.

Hi @keith555
Could you check out this branch?
https://github.com/happy-san/typesense-dart/blob/chores/lib/src/models/field.dart
There are some breaking changes to the models to support the v0.23.0 Typsense. I hope that's acceptable.

That seems to be working now. Thanks a lot for your speedy help.


[SuperIOSTextField] Update text selection handles sizing and layout to match native iOS design spec

SuperIOSTextField text selection handles doesn't follow the native iOS design specs as documented here. This includes the text selection handle bar and the circle that is shown above/below the handle.
Need to update following things to match the native behaviour:

iOS uses handle circle radius of 6px under all circumstances. SuperIOSTextField currently uses 4px. Update that. read
On iOS, the drag handle rectangles are exactly as tall as the selection highlight rectangle for a given line, and the top and bottom of those handle rectangles match the selection rectangle. Update the handle bar layout to match the native behaviour.  read
On iOS, the drag handle circle sits completely above/below the very top/bottom edge of the handle. SuperIOSTextField circle overlaps with the selection area. Update it. read

There are some statements that doesn't seem to be true for iOS 17.5. Screenshot from Safari:

The ball radius looks to be 8px instead of 6px.
There is an overlap between the ball and the selected area, which seems to be approximately half of the ball radius.


Fatal error: Call to undefined function edittown()

Page Causing Issue:  /staff/staff_towns.php?action=edittown
Error Log (Use Pastebin): https://pastebin.com/MQgrA3Q6
Line Errored:  20
What You Expected:  Be able to edit town
What REALLY Happened:  Returned -
Fatal error: Call to undefined function edittown() in C:\xampp\htdocs\staff\staff_towns.php on line 20 as shown in the pastebin log.
Any Other Info:

Not added yet. :P


Spring cleaning of How to section of docs

Update index page
Order guides by decreasing order of importance as much as possible
Rename everything so that it always reads as "How to... do X"
Give space for future ordering changes

Note: I haven't touch the dataloader how-to because it's going to move to Reference in an upcoming PR.

Checklist

[x] I have read and agree to Contributor Guide and the Code of Conduct
[x] I've included a screenshot or gif (if applicable)
[x] I have tested the web demo (if applicable):

Using newly built examples: rerun.io/viewer
Using examples from latest main build: rerun.io/viewer
Using full set of examples from nightly build: rerun.io/viewer

[x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
[x] If applicable, add a new check to the release checklist!

PR Build Summary
Docs preview
Examples preview
Recent benchmark results
Wasm size tracking

any header that ends up being multi-line on the right hand side is super confusing navigationwise imho - it's really hard to see for me on a glance what pages there are and what I can click.
Yes, this is more a problem of the styling than anything else, but for the moment we have to work with that.

We should be able to adjust the line spacing so that wrapped lines are closer than separate headers are

We should be able to adjust the line spacing so that wrapped lines are closer than separate headers are

Yes, this in fact already done -- need some rebasing work on the landing side of things

There it is:


[Test] Updated check lines.

The mangled names and signatures of these functions changed as part of the noncopyable generics work.
rdar://125513719

@swift-ci please test

preset=buildbot,tools=RA,stdlib=RD,test=non_executable
@swift-ci Please test with preset macOS

@swift-ci please test

preset=buildbot,tools=RA,stdlib=RD,test=non_executable
@swift-ci Please test with preset macOS

LGTM. Thanks Nate!

@swift-ci please test linux platform

@swift-ci please test

preset=buildbot,tools=RA,stdlib=RD,test=non_executable
@swift-ci Please test with preset macOS

The test now passes on arm64e:
PASS: Swift(iphoneos-arm64e) :: SILGen/ptrauth_field_fptr_import.swift (6274 of 17613)


Remove Marek as codeowner of circuits

LGTM, I wonder if it would be better to do both of as for * (i.e. one of us)


What is the correct way to reference a :binary field from a Rails schema?

I'm trying to access a Rails table which has fields like this:
    t.string "name", default: "", null: false
    t.string "key", default: "", null: false
    t.binary "secret", null: false
    t.binary "secret_key", null: false
    t.binary "secret_iv", null: false

what's the correct way to reference the :binary fields in a (read-only)  Ecto Schema?
The Ecto docs don't mention :binary
    field(:name, :string, default: "", null: false)
    field(:key, :string, default: "", null: false)
    field(:secret, :binary??, null: false)
    field(:secret_key, :binary??,  null: false)
    field(:secret_iv, :binary??, null: false)

thanks
Environment
Elixir 1.6.6 (compiled with OTP 20)
locked at 2.2.10 (ecto) e7366dc8
locked at 3.3.0 (phoenix_ecto) 702f6e16

never mind - I found the reference, but FYI it's not correctly referenced in the Phoenix docs.
https://hexdocs.pm/ecto/Ecto.Schema.html#content


Add 'rustc-serialize' and 'serde-serialize' features.

This allows users to choose rustc-serialize or serde (or both or none) for serializiation.
'rustc-serialize' is a default feature, serde is activated through the 'serde-serialize' feature.
If there's any interest in it, I'll eventually do the same for ncollide and nphysics.

I'm a bit concerned about this feature-based approach.
If two libraries end up using the same version of nalgebra but with different  serialization methods (i-e, different features), they won't be able to cooperate smoothly (because cargo will identify both nalgebra libraries as different). And I don't feel very comfortable introducing this kind of potential incompatibility for a low level mathematical library like that.

serde serializers and deserializers can live side by side with rustc-serialize encoders and decoders, so I don't think these need to be optional. There is some minor trickiness required to #[derive(Serialize, Deserialize)] in stable rust, but I'd be happy to help out with that if you're interested.

@sebcrozet That's not my impression. Cargo will union the feature flags, and it will be just one compilation of nalgebra.

I'm very interested in serialization support as well!

Now that rust 1.15 is out and rust_derive works on stable this seems like a great idea.

I am also looking for this right now, particularly now that serde_derive is supported on stable. This PR needs to be modified to use it though.

I have an updated version of the pull request in a branch. Tests seem to pass but I haven't tried using the traits yet: https://github.com/robo-hamburger/nalgebra

Thanks for your contributions and sorry I've forgotten about this issue. As part of the massive changes that has been done for #218 (related issue: #207 ), I added the support for serde behind the serde-serialize feature. I've removed rustc-serialize though as it seems to be much less practical.


luci-proto-openfortivpn: cert/key PEM support, persistent option, SHA label fix

Linked packages PR: #16902
Add support for user cert, key and CA cert in luci. This is largely replicated from luci-proto-anyconnect.
Add support for persistent option, to reconnect after timeout (default 5 minutes)
Finally correct the trusted cert SHA label from SHA1 to SHA256.
Signed-off-by: Matthew Hagan<EMAIL_ADDRESS>

ping @aaronjg

There is a progress on this PR?

Lets try it.
Thanks merged!


Entries keep getting re-created in a loop causing SDS warnings

Unexpected behavior from controller-manager that causes re-creation of entries in a loop, generating the following warning when using Envoy SDS API:
2022-07-11T15:36:18.747976Z	warning	envoy config	StreamSecrets gRPC config stream closed: 3, unable to retrieve all requested identities, missing map[default:true]
This leads to a brief state that there is no identities available for attested workloads.

Thanks for reporting this @alexandrealvino! I've identified the bug that resulted in the controller manager recreating all entries on every reconciliation.


Specify support for metric aggregation?

I was curious if it was in the purview of OpenMetrics to specify what kinds of metric aggregation a monitoring system should support? Prometheus, through recording rules, and InfluxDB, through continuous queries, both support arbitrary post-ingestion aggregation. Users can define a query that is continuously evaluated and the result of the query is stored in the monitoring system alongside the data from which the result was calculated. On the other hand, StatsD, and by extension DogStatsD, both support pre-ingestion aggregation, specific metrics are aggregated together before ingestion and only the result of the aggregation is stored in the monitoring system. Given that the latter systems use the type of the metric to determine which aggregation to perform, it seems that the kinds of aggregation supported by a monitoring system are inextricably tied to the metric definitions themselves.
I believe this issue is also related to #67 since if a monitoring system were to support aggregating summaries before ingestion, then Q-Digest is a potential way to do just that. Defining what forms of aggregation should be supported may then guide what types of metrics should be supported as well.

Statsd&friends are based on event logging. The presumption is that that sort of thing happens before they become metrics (usually in a client library), and it's only those metrics that'd then be in scope for OpenMetrics.

Defining what forms of aggregation should be supported may then guide what types of metrics should be supported as well.

This is what counters, summaries and histograms are.

I see, so the metrics supported by a StatsD-style client library aren't considered in scope, only the output of a StatsD-style daemon is relevant, insofar as it produces metrics defined by the OpenMetrics standard?

Yes, however it would be wise to have a statsd-like thingy that things like PHP could integrate with. Presently the advice with Prometheus is to use the statsd protocl with our statsd_exporter, which isn't the most elegant.

Yea, my thought when opening the issue was that an OpenMetrics version of the StatsD spec for aggregating metrics prior to ingestion might be beneficial. It would then be possible to say how StatsD-like event-based metrics can be aggregated into the officially supported metrics types.

Thinking on this, I think it'd be best to have this completely separate from the OpenMetrics spec to avoid confusion. At most a brief reference in the BCP section.
We only really need one implementation of this, and the spec should be very similar to statsd but with labels. The only real change there beyond the obvious that I'd like metrics to be pre-registered on startup by clients, as that's one downside of the statsd approach that we can mitigate.

@brian-brazil Are you referring to the metric names alone or to all metric name label combinations?

Both preferably.

Well, that might be a problem. I'm pretty sure that I can get the metric names at startup, but all possible label combinations might be a bit hard, as it requires a strong coupling between the components and the metric service.
Cases where not all label values can be known at startup time:

Dynamic thread/worker count based on load with the thread/worker being encoded in the metric
HTTP status codes in http responses (I don't want to register all codes for all endpoinds)
Any code that would work like this: micrometer-TimedAspect

@ST-DDT Metric registration and label values are separate issues. OpenMetrics will support creation of new label values on the fly just like Prometheus would.


GH-37268: [C++] adding move in some ctor in fs and dataset

Rationale for this change

Fix some typo and add move in some ctor in fs and dataset.
What changes are included in this PR?

Some minor fix.
Are these changes tested?

No
Are there any user-facing changes?
No

Closes: #37268

I've fixed the comment, would you mind take a look again?


Sourced files cannot access module-level variables

A file -source'd from within a function can access function variables (including arguments) but not module variables.
[~/.elvish]─> cat lib/test.elv
modvar = a

fn test [arg]{
  echo "echo arg=$arg" > /tmp/sourced0.elv
  -source /tmp/sourced0.elv
  fnvar = b
  echo "echo fnvar=$fnvar" > /tmp/sourced1.elv
  -source /tmp/sourced1.elv
  echo "echo modvar=$modvar" > /tmp/sourced2.elv
  -source /tmp/sourced2.elv
}
[~/.elvish]─> use test
[~/.elvish]─> test:test argval
arg=argval
fnvar=b
Exception: Compilation error: variable $modvar not found
/tmp/sourced2.elv, line 1: echo modvar=$modvar
Traceback:
  /Users/taazadi1/.elvish/lib/test.elv, line 10:
      -source /tmp/sourced2.elv
  [tty], line 1:
    test:test argval

Since the experimental -source command has been removed this would seem to no longer be an issue. :smile:

My previous comment should have said the -source command was deprecated by commit ff7c5005 rather than removed. Nonetheless, it seems like this is now a non-issue.
Of course replacing the -source command with eval causes all three uses to fail to compile. Since you can't use eval's &ns option to refer to the namespace being constructed by use test there is no way for any of the equivalent eval statements (e.g., eval (slurp /tmp/sourced0.elv)) to work.

@rdw20170120 as has been mentioned in other issues where you commented, Elvish has all the necessary mechanisms for doing this:

Querying (has-env, get-env) and manipulating (set-env, unset-env) environment variables.
Dynamically adding functions to the interactive environment: edit:add-var.
Hooks which you can set in the interactive environment to check and trigger actions based on certain conditions (e.g. upon entering a given directory). Note: direnv helps with this, and already has Elvish support.

@zzamboni, thank you for your comments!  This is perhaps the most important insight that I have received, despite all the documentation and issues that I have read here.  I think that Elvish desperately needs real-world tutorials that incorporate crucial bits of information like this.  In my research, I did find proposals and discussion of functionality like has-env, but I found nothing that seemed to document and demonstrate its actual use in the Elvish language.
By the way, allow me please to say that I have looked through your published Elvish code, and I found that to be the secret to solving my most basic issues late last night.    Bravo!

Yes, @zzamboni, I am working on joining the community as you suggest.  I have installed Weechat, but now I have to figure out all the steps to get it working...  :)  Meanwhile, questions were burning!

@krader1961 has rightly suggested that I open a new issue for my various questions.

@zzamboni and @xiaq: It seems to me this should be closed since the source command has been removed. In as much as the problem described in the original comment still exists it should probably be reframed in a new issue in terms of the current Elvish capabilities.


Support for "host" lookup key passed as context extension

Adds support for the "host" AuthConfig lookup key to be provided in the payload to the /Check request as Envoy ext-authz per-route "context extension".
Authorino will favor the "host" lookup key whenever passed in the context extensions before the actual "host" HTTP attribute.
This is an alternative approach for enhanced AuthConfig lookups, without changing the lookup structure too much, although relying more on Envoy to set the right payload.
This should be enough to cover use cases such as of path-based AuthConfig lookup and wildcard subdomains AuthConfig lookup.
Closes #222
Closes #171

Verification steps
Path-based AuthConfig lookup use case
In this use case, 2 different APIs are behind the same base domain and differentiated by the path prefix:

pets.com/dogs →  Dogs API
pets.com/cats →  Cats API

Build and deploy this branch:
make local-setup

Edit the sample Envoy config to include the required 'host' context extension that will make Authorino to favour this as lookup key before the actual host of the request:
kubectl -n authorino edit configmap/envoy

[...]
routes:
- match:
    prefix: /dogs
  route:
    cluster: talker-api
  typed_per_filter_config:
    envoy.filters.http.ext_authz:
      \"@type\": type.googleapis.com/envoy.extensions.filters.http.ext_authz.v3.ExtAuthzPerRoute
      check_settings:
        context_extensions:
          host: dogs.pets.com
- match:
    prefix: /cats
  route:
    cluster: talker-api
  typed_per_filter_config:
    envoy.filters.http.ext_authz:
      \"@type\": type.googleapis.com/envoy.extensions.filters.http.ext_authz.v3.ExtAuthzPerRoute
      check_settings:
        context_extensions:
          host: cats.pets.com
[...]

In the above, we've used the same upstream API (i.e. talker-api) for both routes only for demo purposes. In a real-life scenario, "dogs" and "cats" would be 2 different upstream APIs.
Restart Envoy:
kubectl -n authorino rollout restart deployments/envoy

Forward the requests:
kubectl -n authorino port-forward deployment/envoy 8000:8000 &

Apply the AuthConfigs:
kubectl -n authorino apply -f -<<EOF
apiVersion: authorino.kuadrant.io/v1beta1
kind: AuthConfig
metadata:
  name: dogs
spec:
  hosts:
  - dogs.pets.com
  identity:
  - name: friends
    apiKey:
      labelSelectors:
        group: friends
    credentials:
      in: authorization_header
      keySelector: APIKEY
EOF

kubectl -n authorino apply -f -<<EOF
apiVersion: authorino.kuadrant.io/v1beta1
kind: AuthConfig
metadata:
  name: cats
spec:
  hosts:
  - cats.pets.com
  identity:
  - name: friends
    apiKey:
      labelSelectors:
        group: friends
    credentials:
      in: authorization_header
      keySelector: APIKEY
EOF

Create an API key (valid for both APIs):
kubectl -n authorino apply -f -<<EOF
apiVersion: v1
kind: Secret
metadata:
  name: api-key-1
  labels:
    authorino.kuadrant.io/managed-by: authorino
    group: friends
stringData:
  api_key: ndyBzreUzF4zqDQsqSPMHkRhriEOtcRx
type: Opaque
EOF

Consume the APIs under same base domain:
curl -H 'Host: pets.com' -H 'Authorization: APIKEY ndyBzreUzF4zqDQsqSPMHkRhriEOtcRx' http://localhost:8000/dogs -i
# 200

curl -H 'Host: pets.com' -H 'Authorization: APIKEY ndyBzreUzF4zqDQsqSPMHkRhriEOtcRx' http://localhost:8000/cats -i
# 200

Wildcard subdomain AuthConfig lookup use case
In this use case, a single Pets API serves requests for any subdomain that matches *.pets.com, e.g.:

dogs.pets.com →  Pets API
cats.pets.com →  Pets API

Build and deploy this branch:
make local-setup

Edit the sample Envoy config to include the required 'host' context extension that will make Authorino to favour this as lookup key before the actual host of the request:
kubectl -n authorino edit configmap/envoy

[...]
virtual_hosts:
- name: local_service
  domains: ['*.pets.com']
  typed_per_filter_config:
    envoy.filters.http.ext_authz:
      \"@type\": type.googleapis.com/envoy.extensions.filters.http.ext_authz.v3.ExtAuthzPerRoute
      check_settings:
        context_extensions:
          host: pets.com
[...]

The "host" context extension above is any key that matches one of the hosts listed in the targeted AuthConfig.
Restart Envoy:
kubectl -n authorino rollout restart deployments/envoy

Forward the requests:
kubectl -n authorino port-forward deployment/envoy 8000:8000 &

Apply the AuthConfig:
kubectl -n authorino apply -f -<<EOF
apiVersion: authorino.kuadrant.io/v1beta1
kind: AuthConfig
metadata:
  name: pets
spec:
  hosts:
  - pets.com
  identity:
  - name: friends
    apiKey:
      labelSelectors:
        group: friends
    credentials:
      in: authorization_header
      keySelector: APIKEY
EOF

Create an API key:
kubectl -n authorino apply -f -<<EOF
apiVersion: v1
kind: Secret
metadata:
  name: api-key-1
  labels:
    authorino.kuadrant.io/managed-by: authorino
    group: friends
stringData:
  api_key: ndyBzreUzF4zqDQsqSPMHkRhriEOtcRx
type: Opaque
EOF

Consume the API under different subdomains:
curl -H 'Host: dogs.pets.com' -H 'Authorization: APIKEY ndyBzreUzF4zqDQsqSPMHkRhriEOtcRx' http://localhost:8000 -i
# 200

curl -H 'Host: cats.pets.com' -H 'Authorization: APIKEY ndyBzreUzF4zqDQsqSPMHkRhriEOtcRx' http://localhost:8000 -i
# 200

nit: In the verification steps, regarding the "path based routing", how can you tell which configuration is being applied?

We can only tell from the Authorino logs in the case, I'm afraid.

Maybe two api keys would make it clearer.

I'll change in the description of the PR (for whoever checks it in the future).
In the user guide for host overriding via context extensions, I made sure to abstract this detail. What matters is: 2 AuthConfigs, the right one will be used in each request based on path-prefix.
Thanks for pointing out, @eguzki!

I'll change in the description of the PR (for whoever checks it in the future).

Done.


Fix AttributeError: 'GFile' object has no attribute 'tell'

Got this error using tensorflow==0.11.0rc0

Thanks for pointing this out! I actually just had to copy over and make changes to convert_to_records because at the time it was outdated and the one in the tensorflow repo didn't work. Now, the one in the repo has been updated and is better, so I'll actually just switch to that one.


Building an Envoy Docker image fail

Title:  building myself Envoy binary, and putting that in a clean Ubuntu container fail
Description:
I follow this steps to build binary from master branch:
$ pwd
src/envoy
$ ./ci/run_envoy_docker.sh './ci/do_ci.sh bazel.release'
Error logs:

compiling logs
Set "importmap" to different paths in each library.
This will be an error in the future.
GoLink: warning: package "github.com/golang/protobuf/ptypes/timestamp" is provided by more than one rule:
@com_github_golang_protobuf//ptypes/timestamp:go_default_library
@io_bazel_rules_go//proto/wkt:timestamp_go_proto
Set "importmap" to different paths in each library.
This will be an error in the future.
ERROR: /source/source/server/config_validation/BUILD:81:1: C++ compilation of rule '//source/server/config_validation:server_lib' failed (Exit 4): envoy_cc_wrapper failed: error executingcommand
(cd /build/tmp/_bazel_bazel/436badd4919a15958fa3800a4e21074a/execroot/ci &&
exec env -
HOME=/tmp/fake_home
PATH=/bin:/usr/bin:/usr/lib/llvm-7/bin
PWD=/proc/self/cwd
PYTHONUSERBASE=/tmp/fake_home \

finish logs
Execution platform: @bazel_tools//platforms:host_platform
g++: internal compiler error: Killed (program cc1plus)
Please submit a full bug report,
with preprocessed source if appropriate.
See <file:///usr/share/doc/gcc-7/README.Bugs> for instructions.
Target //source/exe:envoy-static failed to build
INFO: Elapsed time: 2368.789s, Critical Path: 113.12s
INFO: 1362 processes: 1362 local.
FAILED: Build did NOT complete successfully

What was the resolution here? I'm seeing this error while trying to build v1.10.0 in an Ubuntu Docker container.

Same here. It would be good to provide more information on the solution.

So to build this locally on my mac I need to increase the memory available to my docker container. By default docker seems to be limited to 2Gb of memory. To be able to compile the release binary and run the tests I had to bump it all the way up to 10GB.
https://stackoverflow.com/questions/44533319/how-to-assign-more-memory-to-docker-container****


Add support for TypedArray, DataView, and ArrayBuffer as body

The Fetch Standard allows BufferSource as a BodyInit, which is defined to include all TypedArray types, DataView, and ArrayBuffer.

I think I run into a problem because of the lack of ArrayBuffer support, with a test that runs in the browser but fails in Node.
Can I work on this? Could you give me pointers on where to start?

@gr2m Seems like you figured it out :)
For any other people interested in this, one could do the same thing in #408, but for the remaining BufferSource types (TypedArray and DataView).


Add $FASTLANE_SNAPSHOT build setting to xcodebuild command

Runtime detection is provided by the launch_argument in the helper.
recreation of https://github.com/fastlane/fastlane/pull/4416

@ohwutup i just updated snapshot and the build settings gets passed:
set -o pipefail && xcodebuild -workspace ./appname.xcworkspace -scheme appname -configuration 'Debug' -derivedDataPath '/var/folders/lt/vgqdj5ls4pjc28h7dfm46jl80000gn/T/snapshot_derived20160801-30367-e5rfkj' -destination 'platform=iOS Simulator,id=A5C3C8DA-EFD4-40F2-8E4E-BEFACB27BF6A,OS=9.3' FASTLANE_SNAPSHOT=YES clean build test | tee /Users/myname/Library/Logs/snapshot/appname-appname.log | xcpretty
I then checked for the flag in code:
#if SNAPSHOT             SDStatusBarManager.sharedInstance().enableOverrides() #endif
I also tried:
#if FASTLANE_SNAPSHOT             SDStatusBarManager.sharedInstance().enableOverrides() #endif
Both dont work. Any ideas?


Junit testing

We should add junit testing to MBD so we can make sure somethings work properly when compiling.

Yes, though only complex blocks will need JUnit testing. Most of the blocks are very basic and can be handled with automated block placement tests.

I've never setup JUnit before though. Do we have any documentation or examples on it?

Look at ve src/test that will help you tho dark can explain it better then I can.
Sent from my iPhone

On Jan 10, 2016, at 3:45 PM, Henry Stabell<EMAIL_ADDRESS>wrote:
I've never setup JUnit before though. Do we have any documentation or examples on it?
―
Reply to this email directly or view it on GitHub.

I see, I'l probably figure it out.

Work on this has now begun with commit: 8b483fc. It still needs a lot more work to provide a high coverage percent.


Make server refresh faster

Because 10 seconds is better than 60 seconds.

You actually did it :D


Use ISO 8601 format for dates

Currently dates are formatted in the %d.%m.%Y format (e.g. 09.04.2021), but it as an international project, it would be better if we used a more well-known format — specifically, ISO 8601. This would mean switching to the %Y-%m-%d format (e.g. 2021-04-09).
I actually tried to dig into the code to find where this change could be made, but got a little lost. I suppose some or all these lines might be relevant:
https://github.com/fossjobs/fossjobs/blob/afc8d8d0288d6113b1d1c274b4f12bc408d90912/public/_templates/bulma/home.tpl#L36
https://github.com/fossjobs/fossjobs/blob/afc8d8d0288d6113b1d1c274b4f12bc408d90912/public/_includes/class.Job.php#L52
https://github.com/fossjobs/fossjobs/blob/afc8d8d0288d6113b1d1c274b4f12bc408d90912/public/_config/config.settings.php#L23
https://github.com/fossjobs/fossjobs/blob/afc8d8d0288d6113b1d1c274b4f12bc408d90912/public/_includes/smarty/libs/plugins/modifier.date_format.php#L31
https://github.com/fossjobs/fossjobs/blob/afc8d8d0288d6113b1d1c274b4f12bc408d90912/db/jobberbase.sql#L531
...but I seem to have reached a dead-end, since none of these specify the DD.MM.YYYY format. Any hints at to where this change would be made?

I suspect it is a system setting? Will have a closer look.

$settings['date_format'] is a configuration option in the admin backend. I changed it to %Y-%m-%d now on the live site. Thanks!


x/tools/gopls: support type parameters for function literal snippet completions

Given the following code:
type Tree[T any] struct{}

func (tree Tree[T]) Do(f func(s T)) {}

func _() {
  var t Tree[string]
  t.Do(fun) // trigger completion
}

The current completion that gopls gives for the func(...) {} snippet option is: func(s T) {}, but that is incorrect as T is not really valid. The correct solution would be whatever type was instantiated at compile time, so the completion in the example above should be func(s string) {}

Does this change above also fix completion for generic type method receivers or is it a different issue? Currently it suggests the structure name but without type parameters so I have to add them manually every time. Same with calling a function with type parameters, placeholders for them would be nice (they can't be guessed of course).

Thanks for the issue and CL, Marwan! Left some comments, and @pjweinb will be looking at completion issues.
@rkfg no I don't think this will fix the problem you describe. I opened https://github.com/golang/go/issues/50684 to track that issue.


Research Page Bug: Image Size Overflow

I would like to work on this issue

Hi @smaranjitghose. Can I work on this issue as part of OSD'21?


Allow volunteers to subscribe to the Green AI Committee White Paper project

Context
We want to allow GSF volunteers to subscribe to the project.
Actions

[x] Setup Google Group - "gaic-whitepaper@"
[ ] Add project to project subscription list

@ash-ara Google Group setup and you are an admin - https://groups.google.com/a/greensoftware.foundation/g/gaic-whitepaper
Subscription list also updated.

I can help with this if it's not yet completed


52145 - Failed to authenticate with APNs

We have two ios applications for driver and customer and we want to make call between these two apps but we are not able to make call between these two apps it is returning following error :
Error - 52145
Failed to authenticate with APNs
Error description for above mentioned error:
Could not authenticate with APNs using the provided credentials.
Please check following information which i have:
DEBUG EVENT SID : NO9a4cadbc7f434943b037123d4dccad02
SERVICE SID : PV5b76bf0835dcee2e6fb40a1d2aaefc4a
We have generated two different APN certificate for both apps.

This seems to be related to #380. Closing this one since we already are investigating.


chore(master): release 1.1.12

:robot: I have created a release beep boop
1.1.12 (2023-04-04)
Miscellaneous

deps: update dependency phpstan/phpstan to v1.10.11 (db6df4d)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/wayofdev/php-cs-fixer-config/releases/tag/v1.1.12 :sunflower:


Flutter Web stream asyncMap is not calling

I am trying to call this function from StreamBuilder, Mobile version(Android & IOS) is working fine but in web version asyncMap function is not calling, what would be the possible reason behind it or is there any alternative to this, please ?
Stream<_TalentDetailsViewModel> getViewModelStream(
      BuildContext context, String matchId) {
    final talents = Provider.of<Talents>(context, listen: false);

            print("Printing properly");

        return Provider.of<Matches>(context, listen: false)
            .getStreamById(matchId).asyncMap((Match? match) async {
              print("Not Printing");
      final talent = await talents.getById(match!.talent!);
      return _TalentDetailsViewModel(match, talent!);
    });
}

flutter doctor -v
[✓] Flutter (Channel stable, 3.0.2, on macOS 12.2.1 21D62 darwin-x64, locale en-DE)
    • Flutter version 3.0.2 at /Users/almamun/Documents/developer/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision cd41fdd495 (4 weeks ago), 2022-06-08 09:52:13 -0700
    • Engine revision f15f824b57
    • Dart version 2.17.3
    • DevTools version 2.12.2

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0-rc2)
    • Android SDK at /Users/almamun/Library/Android/sdk
    • Platform android-33, build-tools 33.0.0-rc2
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.11+0-b60-7590822)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.3.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.11+0-b60-7590822)

[✓] VS Code (version 1.67.2)
    • VS Code at /Users/almamun/Downloads/Visual Studio Code.app/Contents
    • Flutter extension can be installed from:
      🔨 https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[✓] Connected device (3 available)
    • iPhone 13 Pro Max (mobile) • 6E142A64-7195-4799-98CD-3B201D6B79C9 • ios            •
      com.apple.CoreSimulator.SimRuntime.iOS-15-4 (simulator)
    • macOS (desktop)            • macos                                • darwin-x64     • macOS
      12.2.1 21D62 darwin-x64
    • Chrome (web)               • chrome                               • web-javascript • Google
      Chrome 103.0.5060.53

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

Hi @thealmamun,
This issue doesn't seem to describe a bug or a feature request. Please see https://flutter.dev/community#community-grid for resources and asking questions like this. You may also get some help if you post it on Stack Overflow with a minimal and complete code sample that clearly describes your problem.
Closing, as this isn't an issue with Flutter itself. If you disagree, please write in the comments and we will reopen it.
Thank you

@maheshmnj did you checked asyncMap method on web version, is stream event passing on your end?

@thealmamun Can you share a minimal and complete code sample for us to take a look? Also please try not to include any third-party packages.


doc: initial version of dependencies section

Signed-off-by: Michael Dawson<EMAIL_ADDRESS>

In the last Ref arch meeting we agreed this should be pulled out as a separate section from the secure development process section.

probably need to add these 2 packages in npcheck.json?
<EMAIL_ADDRESS>----  package which is under the non-acceptable license "0BSD".
<EMAIL_ADDRESS>---- package which is under the non-acceptable license "CC-BY-4.0".


Add Blog page.

Currently, there was no place to show my blogs. This change adds a blog page where I will be able to show the charts API of my family's DNA. The change also add a side bar navigation to navigate between the other pages.

With Sidebar

Is that comic sans?! LGTM

It is the font family cursive;


[17.12] Added documentation for fluentd plugin sub-second-precision flag.

Proposed changes
Add documentaion for fluentd-sub-second-precision flag in fluentd plugin.

Added a short description for fluentd-sub-second-precision flag in fluentd.md.
Unreleased project version (optional)
Not sure.

Team
area/engine
Related issues (optional)
Closes #5425

LGTM

cc @thaJeztah

LGTM, we just need moby/moby#35529 to get merged before merging the docs.

moby/moby#35529 was merged, so we can merge this 👍
cc @joaofnfernandes @thaJeztah

@joaofnfernandes I noticed this is against master, but will be in the upcoming 17.12 release, so we should merge after release (or reopen against vnext-engine - let me know what you prefer

I think vnext-engine makes more sense. @dungeonmaster18 can you update this PR to be against the vnext-engine branch instead of master?

Yup sure.

@joaofnfernandes I have update

@dungeonmaster18 it seems that you have some conflicts in your PR. Can you rebase your branch on vnext-engine? If that's too much work, you can start a new branch from vnext-engine and submit a new PR instead.

closing this and opening new pr #5471
cc @joaofnfernandes


limit of 500 numbers are seen

the get-csphonenumberassignment command has a limit of 500. Cx has requested an update to reflect this.
heI was able to loop the command and skip the gathered results to retrieve all 2300 results
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 6bfb9351-75be-abb8-c8ac-bf08f51d08a1
Version Independent ID: c7925810-6411-9371-7a04-fc28a4c827ec
Content: Get-CsPhoneNumberAssignment (MicrosoftTeamsPowerShell)
Content Source: teams/teams-ps/teams/Get-CsPhoneNumberAssignment.md
Service: teams-powershell
GitHub Login: @JensTrier
Microsoft Alias: jenstr

It makes sense to add an additional example to the article to demo how to retrieve all results:
Get-CsPhoneNumberAssignment -Top ([int]::MaxValue)

@techbev thanks for providing this feedback to improve the documentation!

The edit to the article is on the approval process

Hi Tina,
When will this update show on public facing Microsoft Doc site?
Thank you for your help.
Bev
Best Regards,
Bev Sebastian
Teams/Skype Support Escalation Engineer (SEE)
Hours: 9am to 6pm PDT
Manager: John Kindt<EMAIL_ADDRESS>From: Tina Burden @.>
Sent: Friday, September 15, 2023 8:16 AM
To: MicrosoftDocs/office-docs-powershell @.>
Cc: Beverly Sebastian @.>; Mention @.>
Subject: Re: [MicrosoftDocs/office-docs-powershell] limit of 500 numbers are seen (Issue #11116)
Closed #11116https://github.com/MicrosoftDocs/office-docs-powershell/issues/11116 as completed via #11156https://github.com/MicrosoftDocs/office-docs-powershell/pull/11156.

Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/office-docs-powershell/issues/11116#event-10384693829, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BARS5WNV6324H7PSTKEOD43X2RWLTANCNFSM6AAAAAA22Y33KM.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>


Config option to split generation paths

What do you want to change?
I use SQLC to generate data storage model, repository interfaces, and their implementations from SQL files (obviously!), and absolutely love what the tool offers. I'm constantly recommending it.
I have recently started the transition towards Clean Architecture in the project I'm work on, using a layered approach to separate concerns (e.g. domain, application, infrastructure, presentation, etc.), and unfortunately have hit a small problem with the generated SQLC files.
The interface definition of repositories (Querier in SQLC) and DSOs should live in the application layer, whereas the implementations of the repositories should live in the infrastructure layer.
At the moment, SQLC generates all files into one folder determined by the path parameter of the config.
My proposal is to allow overrides for each of the generated files. This would fix my problem, as I could generate the Querier and models in application/repository, and the SQL query strings and implementations in infrastructure/repository.
I could wrap SQLC in a custom repository interface, but I really like the fact that the repository interface and models are generated from our SQL. My temporary solution is defining a new interface that embeds the Querier, but the direction of inversion is broken, as my application layer now points to the infrastructure layer, which is incorrect in Clean Architecture. I could also just suck it up and keep SQLC files in the application layer, but then we have infrastructure concerns in the application, which is also incorrect.
Any thoughts on this? If this is something that other want/see a use for, I can take a look at opening a PR (eventually). Any input is appreciated 🙏
What database engines need to be changed?
No response
What programming language backends need to be changed?
No response

Looks like there are two issues that want a similar feature #835 and #1941

mpyw/sqlc-restruct: Post-processor for kyleconroy/sqlc
Post-processing approach

https://github.com/kyleconroy/sqlc/issues/1941#issuecomment-1623408555

I'd like that too!

I hope this is done soon


dev/release: C# version number isn't bumped properly

What happened?
lidavidm@Canon ~/C/arrow-adbc (maint-13)> ./dev/release/post-07-csharp.sh                                                                                (adbc)
============================================================
Config
============================================================
Repository: apache/arrow-adbc
Source Directory: /Users/lidavidm/Code/arrow-adbc
============================================================
Downloading C# packages for 0.13.0
============================================================
error: File does not exist (/var/folders/w5/sk6hn1217f9_1t1nfbflvprw0000gn/T/arrow-post-csharp.XkbCr/Apache.Arrow.Adbc.0.13.0.nupkg).

Usage: dotnet nuget push [arguments] [options]

Arguments:
  [root]  Specify the path to the package and your API key to push the package to the server.

Options:
  -h|--help                      Show help information
  --force-english-output         Forces the application to run using an invariant, English-based culture.
  -s|--source <source>           Package source (URL, UNC/folder path or package source name) to use. Defaults to DefaultPushSource if specified in NuGet.Config.
  -ss|--symbol-source <source>   Symbol server URL to use.
  -t|--timeout <timeout>         Timeout for pushing to a server in seconds. Defaults to 300 seconds (5 minutes).
  -k|--api-key <apiKey>          The API key for the server.
  -sk|--symbol-api-key <apiKey>  The API key for the symbol server.
  -d|--disable-buffering         Disable buffering when pushing to an HTTP(S) server to decrease memory usage.
  -n|--no-symbols                If a symbols package exists, it will not be pushed to a symbols server.
  --no-service-endpoint          Does not append "api/v2/package" to the source URL.
  --interactive                  Allow the command to block and require manual action for operations like authentication.
  --skip-duplicate               If a package and version already exists, skip it and continue with the next package in the push, if any.

lidavidm@Canon ~/C/arrow-adbc (maint-13) [1]> ls /var/folders/w5/sk6hn1217f9_1t1nfbflvprw0000gn/T/arrow-post-csharp.XkbCr/Apache.Arrow.Adbc.0.13.0.nupkg                                                  (adbc)
/var/folders/w5/sk6hn1217f9_1t1nfbflvprw0000gn/T/arrow-post-csharp.XkbCr/Apache.Arrow.Adbc.0.13.0-SNAPSHOT.nupkg
/var/folders/w5/sk6hn1217f9_1t1nfbflvprw0000gn/T/arrow-post-csharp.XkbCr/Apache.Arrow.Adbc.0.13.0-SNAPSHOT.snupkg
/var/folders/w5/sk6hn1217f9_1t1nfbflvprw0000gn/T/arrow-post-csharp.XkbCr/Apache.Arrow.Adbc.Client.0.13.0-SNAPSHOT.nupkg
/var/folders/w5/sk6hn1217f9_1t1nfbflvprw0000gn/T/arrow-post-csharp.XkbCr/Apache.Arrow.Adbc.Client.0.13.0-SNAPSHOT.snupkg
/var/folders/w5/sk6hn1217f9_1t1nfbflvprw0000gn/T/arrow-post-csharp.XkbCr/Apache.Arrow.Adbc.Drivers.Apache.0.13.0-SNAPSHOT.nupkg
/var/folders/w5/sk6hn1217f9_1t1nfbflvprw0000gn/T/arrow-post-csharp.XkbCr/Apache.Arrow.Adbc.Drivers.Apache.0.13.0-SNAPSHOT.snupkg
/var/folders/w5/sk6hn1217f9_1t1nfbflvprw0000gn/T/arrow-post-csharp.XkbCr/Apache.Arrow.Adbc.Drivers.BigQuery.0.13.0-SNAPSHOT.nupkg
/var/folders/w5/sk6hn1217f9_1t1nfbflvprw0000gn/T/arrow-post-csharp.XkbCr/Apache.Arrow.Adbc.Drivers.BigQuery.0.13.0-SNAPSHOT.snupkg
/var/folders/w5/sk6hn1217f9_1t1nfbflvprw0000gn/T/arrow-post-csharp.XkbCr/Apache.Arrow.Adbc.Drivers.FlightSql.0.13.0-SNAPSHOT.nupkg
/var/folders/w5/sk6hn1217f9_1t1nfbflvprw0000gn/T/arrow-post-csharp.XkbCr/Apache.Arrow.Adbc.Drivers.FlightSql.0.13.0-SNAPSHOT.snupkg
/var/folders/w5/sk6hn1217f9_1t1nfbflvprw0000gn/T/arrow-post-csharp.XkbCr/Apache.Arrow.Adbc.Drivers.Interop.Snowflake.0.13.0-SNAPSHOT.nupkg
/var/folders/w5/sk6hn1217f9_1t1nfbflvprw0000gn/T/arrow-post-csharp.XkbCr/Apache.Arrow.Adbc.Drivers.Interop.Snowflake.0.13.0-SNAPSHOT.snupkg

-SNAPSHOT shouldn't be there
Stack Trace
No response
How can we reproduce the bug?
No response
Environment/Setup
No response

It appears at some point we switched from <Version> to <VersionPrefix> and <VersionSuffix> but didn't update the script


Update Landing page

Please do work for this task in a branch called issue-1.
The Landing page should:

[x] Display how the site should be used
[x] Inform the user of the site's features

Initial version complete, may tweak the style a bit more to make it different compared to the Bowfolios landing page. Notify through here or through Discord if you have any suggestions on how to change up the landing page.

May use 024731 as the green, will check if that's fine since I'm going off of https://www.hawaii.edu/offices/eaur/graphicsstandards.pdf. Fallback green is the one in Bowfolios, 376551.

Will close for now so I can start work on NavBar, will reopen if updates need to be made


quote column names

when working with camelcase column names we need to quote them, because otherwise they will be changed to lower case which breaks the query.


Performance platform

Added functionalities to store, update and retrieve Performance Data which is:

going to be transformed to CSV by send-money (see this other twin PR)
ultimately be linked from data.gov.uk

The data in the PerformanceData table is a weekly aggregation of other data stored in other tables:

credits total is calculated by counting the credited Credit records for the weeks
digital take-up data is derived from data in performance.models.DigitalTakeup
user satisfaction data is derived from data in performance.models.UserSatisfaction

This data is updated using the update_performance_data management command (introduced here).
Key principles:

some of this data may not be available so all the fields are optional
client should generate final CSV file with minimal computation/manipulation

Ticket: https://dsdmoj.atlassian.net/browse/MTP-1891

Cheers Igor!


test: Fix perf_annotation_test compilation under gcc 8.1.1

Signed-off-by: Suresh Kumar<EMAIL_ADDRESS>Description: Fixes "unnecessary parentheses" warning/error when compiled in gcc8.1.1
Risk Level: Low
Testing: bazel test //test/...
Docs Changes: N/A
Release Notes: N/A
Fixes #3680

@surki apologies but can you fix DCO? See contributing guide.

Updated.
ci mac check failure doesn't look related to this change?


0.3.10 throws Exception in callback of async function.. same code works in 0.3.9...

0.3.10 throws this exception:
Exception in callback of async function: TypeError: object is not a function
at /Users/sunil/meteor/meteor-boiler/tests/cucumber/features/support/hooks.js:45:7
at runWithEnvironment (/Users/sunil/meteor/meteor-boiler/.meteor/local/build/programs/server/packages/meteor.js:1052:24)
My before hook is fairly simple. This exception happens at callback().
My before hook:
this.Before("@beforeHookLogin", function(callback){
console.log("start @beforeHookLogin");
//always signout before sigingin in
helper.world.browser.
url(helper.world.cucumber.mirror.rootUrl).
waitForExist('#at-nav-button').
waitForVisible('#at-nav-button').
click('#at-nav-button');
// make sure the user is Authenticated
helper.world.browser.
url(helper.world.cucumber.mirror.rootUrl+"sign-in").
waitForExist('.at-pwd-form').
waitForVisible('.at-pwd-form').
setValue('#at-field-email', 'sunil@y.com').
setValue('#at-field-password', 'sunil123').
click('#at-btn');
console.log("End @beforeHookLogin");
callback(); <-- exception happens here
});

it looks like the first param to the before hook is not a function. Could you run a console.log(arguments); right after console.log("start @beforeHookLogin"); to see what the first parameter is?

This is what it spits out Sam.
{ '0': { [Function] pending: [Function: pending], fail: [Function: fail] } }
I am using the following API as described in the cucumberjs github page:
Tagged hooks
Hooks can be conditionally elected for execution based on the tags of the
scenario.
// features/support/hooks.js (this path is just a suggestion)
var myHooks = function () {
this.Before("@foo", "@bar,@baz", function(callback) {
// This hook will be executed before scenarios tagged with @foo and either
// @bar or @baz.
// ...

callback();

});
};
module.exports = myHooks;
On Tue Feb 24 2015 at 2:26:02 PM Sam Hatoum<EMAIL_ADDRESS>wrote:

it looks like the first param to the before hook is not a function. Could
you run a console.log(arguments); right after console.log("start
@beforeHookLogin"); to see what the first parameter is?
—
Reply to this email directly or view it on GitHub
https://github.com/xolvio/meteor-cucumber/issues/48#issuecomment-75826773
.

ok, looks like a bug in meteor-cucumber

@sunkay Please don't send me this, thanks :)

@bar you're getting these message probably because you are subscribed to this thread/repo

@samhatoum not quite... it is because @sunkay summoned me using my GH handle here https://github.com/xolvio/meteor-cucumber/issues/48#issuecomment-75878971

LOL.. just realized that.. no foo bar for you...

Can you please try with meteor add<EMAIL_ADDRESS>please? Please be sure to see the breaking changes section.


pkg/trace/obfuscate: add support for Postgres dollar-quoted strings

This change adds support for a previously unsupported Postgres features.
See https://www.postgresql.org/docs/current/sql-syntax-lexical.html#SQL-SYNTAX-DOLLAR-QUOTING

@gbbr This PR should target 7.29 milestone or get into the codebase asap as we have entered the freeze period for the release.


rm aliasCType

Codecov Report

Merging #68 (4b97a8d) into main (9fd3798) will decrease coverage by 0.54%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #68      +/-   ##
==========================================
- Coverage   86.45%   85.90%   -0.55%
==========================================
  Files          10       10
  Lines        3174     3172       -2
==========================================
- Hits         2744     2725      -19
- Misses        342      355      +13
- Partials       88       92       +4

Impacted Files
Coverage Δ

cl/blockctx.go
79.78% <ø> (+0.56%)
:arrow_up:

cl/pkginfo.go
81.25% <0.00%> (-7.04%)
:arrow_down:

cl/compile.go
92.35% <0.00%> (-2.84%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fd3798...4b97a8d. Read the comment docs.


Deleted RetroActive Marked SVG src files

Like the RetroActive and NeoActive themes, I deleted the SVG source files.  The source files can now be found at https://github.com/baxysquare/baxy-retroarch-themes/tree/master/retroactive_marked.  I also removed the font since RetroActive Marked has been deprecated to be an alternative/replacement icon set for RetroActive, rather than a full-blown theme.  I don't plan on doing any more development of this icon set, but it's primed and ready if someone wants to contribute down the line.

Is there an issue with this pull request?  I'm guessing the removal of the font, reducing this theme to an alternative icon set for RetroActive is controversial.  If that is the case, I'm happy to close the PR and resubmit.

It's OK, as this theme is not listed in RA menus.


Fix invalid HTML code with links in headers.

Hm are you making them empty? that might be a bad idea

I tested this in our docs and seems to be fine. Do you want me to use a  ?

Do you want me to use a  ?

Hm nah, I'll double check...

@vladikoff: just pinging for when you have some time.


Support for Resume/CV Links

Solves #2825

Hey @george-gca,
I see the Prettier check failing, but when I run npx prettier . --check or npx prettier . --write locally, I don't get any issues in any file. Any idea what might be the problem here?

Unfortunately the prettier check is not doing what it was supposed to. It was supposed to add here information about why it failed, but it is not doing it. You can still check it manually though.
Just click on the failed action above, expand the Run peter-evans/repository-dispatch@v2 line and download the generated file:

This is an html diff of what changes must be made. It is a zip file because GitHub doesn't allow to store anything else.

Thanks for that @george-gca,
I downloaded the HTML diff and checked it. It suggests changes to a file that I didn't even touch in this PR. Moreover, the change it suggests have already implemented in my branch, so not sure what the issue is.
On further investigation, I saw the Prettier check being failed on the main branch as well, and the HTML diff also suggests the same change (pasted below).

Thanks for your contribution.


Iss 195

Fixes for #195
The codes to perform in-silico simulation of various controllers (namely SmartROI and WeightedDEW) are quite messy and scattered in different notebooks. I've put them all into a single file scripts/in_silico_optimise.py that can be easily run.
Usage:
$ python in_silico_optimise.py <sample_name> <seed_mzML> <output_folder> <config_file>

where:

<sample_name> could be anything, e.g. 'QCA'
<seed_mzML> and <output_folder> are the paths to the seed mzML and the output folder
<config_file> is the path to the config files. Examples are given in scripts/config/*.txt for the experiments we did in the paper using the SmartROI and WeightedDEW controllers.

Notes:
Only 3 controllers are supported right now (those we use in the paper): TopN, SmartROI and WeightedDEW, although it shouldn't be hard to add more.
Scan times can be fixed in the config file, or if left blank, it will be computed from the seed file.
To save time, the script will try to run the controllers in parallel using ipcluster. If it fails, then it will run them serially.
Peak picking is done using MzMine2 only for now.
Still need to supply that peak_sampler object. That will go away once issue #46 is fixed.
Might be useful to slap some GUI on top of this, so other people can easily upload their own seed mzML file and run different controllers on it?

Unit tests failed due to logging problem, will merge to master after fixing it.


Change custom data tests to return 0 rows on failure, or more than 0 rows on success

Change custom data tests to return 0 rows on failure, or more than 0 rows on success. It's currently the other way around.

Found a way.


How to install?

can you provide instructions on how to install it?

https://github.com/tom10271/pycharm-dbt-plugin/actions/runs/4190677238/jobs/7264326184
I don't think this repo is working


Is it possible to include help_text in form rendering?

I've created longer help_text for some of the fields in my database models. I'd like to have those rendered along with the form fields. Is that possible?

why not use
        {{field.help_text}}

@zodman Thanks! It hadn't occurred to me to try that for some reason! 😬🤦🏼♂