Add a NamespacePhase to Namespace

This is the first step towards implementing #5195 that I am delivering as a set of small PRs.
This PR does the following:

Add a Phase to the Namespace to know if its Active or Terminating
A Namespace is always in the Active phase now.
Updates conversion, default value, and serialization test for new field.
Show the Status of a Namespace in kubectl

Once a Phase is available on a Namespace, I will take the next step to actually enforce behavior at each phase, and the corresponding state transitions.

Any suggestions on who should this be assigned to?

@erictune @bgrant0607 or @thockin

Looks good other than description tags.

@bgrant0607 - added descriptions.  I thought the hooks were catching that now?

They should be. If you run hack/verify-description.sh without the descriptions, does it barf?

Restarted Shippable. Filed issue for the Kubelet test failure.


Update componentWillReceiveProps to UNSAFE_componentWillReceiveProps

In order to prepare for an upgrade to React 17, we need to rename componentWillReceiveProps to UNSAFE_componentWillRecieveProps.
https://reactjs.org/blog/2018/03/27/update-on-async-rendering.html#gradual-migration-path
TODO

[x] Documentation
[ ] Tests

The update to the eslint config failed CI, so in lieu of making this change more complex than it needs to be, I'm reverting back to disabling the rule.


feat: junit cli test report format

WIP: mainly to get the ball rolling and start the discussion.
Schema for Junit XML is at:

https://llg.cubic.org/docs/junit/

Seems that the junit xml report has quite a few fields that our json output doesn't currently support. Not sure how difficult it would be to capture. Then again not all of the junit xml fields are required, so we can probably get pretty far by starting with only the required fields.
Also I'm sure the code organization here is bad. The util function should not depend upon the the core domain class of the SendJsonOutput type but figured we can iterate and figure out where stuff should go in this draft MR.

fantastic work. Thx for your input.

I believe required tags / attributes and core report logic is now in place. I think what remains is cleanup, refactoring and tests. Here is a demo of the feature in action comparing between json and junit xml output.

https://drive.google.com/file/d/17HraIiyccgO3RVaIQVxm5ecmS15_Jype/view?usp=sharing

added execute interceptors to capture the duration of the request using the js performance api.
added to json output format
converted to float seconds for the junit xml report

@mmadson I think we have covered all the necessary cases for the first draft. Do you still notice any problems? Otherwise, I would integrate it like this.

This looks exceptional. Thank you so much for not only being willing to accommodate this feature but being so active in developing it. Truly an remarkable OSS maintainer; thank you! I assume if we overlooked anything with the report generation in terms of integrating the output with gitlab, we can patch it up fairly quick with a follow on MR. So, everything looks good on my end. Excited to give it a try in my test project's functional test pipeline!

I am happy to return the praise and thanks. Thank you for taking the time to read and improve my code. And of course we can react on short notice in case of problems.


Can you please whitelist Belgian EID dylibs

All Belgian Homebrew users would be grateful if these could be added to the whitelist as they affect all Belgian users since we need to have this official software installed to file our taxes
This dylibs are the result of installing this software: https://eid.belgium.be/en
Adding hese three lines to white_list under check_for_stray_dylibs should cover it.
"libbeid*.dylib", # Belgian EID software
"libqt-mt.*.dylib", # Belgian EID software
"libxerces-c-*.dylib", # Belgian EID software

Please always fill out the issue template (as it told you to do).

"libbeid*.dylib", # Belgian EID software

We would accept a PR to whitelist this as it will not be picked up and used by other software.

"libqt-mt.*.dylib", # Belgian EID software

I'm not sure whether we would accept a PR for this given it's a Qt library (albeit with unconventional name) that may be used by other software.

"libxerces-c-*.dylib", # Belgian EID software

We would not accept a PR to whitelist this as this will conflict with out xerces-c formula.
Furthermore, remember that brew doctor says to ignore warnings that aren't causing you problems.


@astrojs/db NPM page links to nonexistent documentation page

📋 Explain your issue
On https://www.npmjs.com/package/@astrojs/db , clicking on Read the @astrojs/db docs leads to https://docs.astro.build/en/guides/integrations-guide/db/ which 404's

Hey @ThatOneCalculator, the docs of astrojs/db aren't ready for prod that's why it sends you to that four-oh-four page. They might be ready for the launch of Astro Studio

Looks like the docs are live now, this issue should be safe to close.


new Chains: must have features

~add auto-painting of "unweighted" vs. regular base~ Done...
add method to access all meta / properties of file metadata on question per key
~auto-paint base text property~ / add as attribute

--------------------------------------------------------------------------------
BUGS:
~* more than 26 letters, reindex() auto-sorts letter index so tests are in an undesired order...~

In self.contents i am missing "is_sum" or "c_pct_sum" to be accurate, not sure if it have to be that specific.

I could really use a boolean attribute: is_painted.
Set to True when method Paint is called and inverted when toggle_labels are called.

ChainManager._chains must allow {'some name': chain(s)} for folder-like structures.


[5.6] Fix ConnectionInterface methods

Declaration of Illuminate\Database\Connection class methods must be compatible with Illuminate\Database\ConnectionInterface
Does not require any change in the tests.
Doesn't break any existing feature.

Probably should just target 5.7 that is due out soon, since your technically changing an interface file...

I came across with an issue on 5.6 while using decorated Connection class where I am overriding a method, and since I noticed my implementation does comply with the interface it however fails to inherit the connection class. The parameter was added to version 5.6 according to this PR https://github.com/laravel/framework/commit/8afc15188a6fd046b485f1c883701ae2863b32cb
🙄

@raftalks Nope, according to that commit https://github.com/laravel/framework/commit/8afc15188a6fd046b485f1c883701ae2863b32cb it was added to 5.3.27 -> https://github.com/laravel/framework/pull/16625

Sorry, my bad, didn’t really check when it was added as I was on mobile. Even though it’s been added and still do exist in 5.6 with a method that contracts to the interface, shouldn’t they comply?

shouldn’t they comply?

No as that it a major breaking change to a contract.


Not working

It seems the only way I can get At to work with remoteFilter option is if I allow it to query on a single character, but then continuing to type does not update the list - despite the network requests continuing.
Why isn't this approach working?
$('#myElement').atwho({
    at: "@",
    callbacks: {
        remoteFilter: function(query, callback) {
            /*
            this doesn't work
            if(query === null || query.length < 3){
                return callback(null);
            }
            */
            $.ajax({
                url: "/api/v1/profiles/findusername/"+query,
                type: 'GET',
                dataType: 'json',
                success: function(data) {
                    callback(data);
                },
                error: function() {
                    alert('boo!');
                },
                beforeSend: function(xhr) {
                    xhr.setRequestHeader('Authorization', localStorageService.get('authToken'));
                }
            });
        }
    },
    displayTpl: "<li>${username}</li>",
    insertTpl: "@${username}"
});

Try adding this option after the insertTpl.
searchKey: "username".

@SparoHawk oh you saved my night!


Bump build number to 2, add traversaro to mantainers and clarify license

I was debugging some strange package conflict that ended up being caused by:
traversaro@IITBMP014LW012:~$ conda create -n test "libzlib==1.3.1" zziplib
Channels:
 - conda-forge
Platform: linux-64
Collecting package metadata (repodata.json): done
Solving environment: failed

LibMambaUnsatisfiableError: Encountered problems while solving:
  - package zziplib-0.13.69-h27826a3_1 requires zlib >=1.2.11,<1.3.0a0, but none of the providers can be installed

Could not solve for environment specs
The following packages are incompatible
├─ libzlib 1.3.1  is installable with the potential options
│  ├─ libzlib 1.3.1 would require
│  │  └─ zlib 1.3.1 *_0, which can be installed;
│  └─ libzlib 1.3.1 would require
│     └─ zlib 1.3.1 *_1, which can be installed;
└─ zziplib is not installable because it requires
   └─ zlib >=1.2.11,<1.3.0a0 , which conflicts with any installable versions previously reported.

Apparently this package has not being built in a long time, and was originally compiled against a version of zlib that had some strange run_exports constraint. In this PR I rebuild the package, clarify the license and add myself as maintainer.
Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

@conda-forge-admin, please rerender

@conda-forge-admin, please rerender

@wolfv the PR is ready for review, thanks!

Thanks!

Thanks!


Don't squeeze DataArray before plotting

As was discussed in #608, we should honor the shape of the DataArray when selecting plot methods.  Currently, we're squeezing the DataArray before plotting.  This ends up plotting a line plot for a DataArray with shape (N, 1). We should find a way to plot a pcolormesh or imshow plot in this case. The trick will be figuring out what to do in _infer_interval_breaks.

I see two options:

Squeeze after the row/col selection logic.
Raise an error if someone attempts to plot a (N, 1) plot as 2D.

1 might actually be preferable to not squeezing at all.

I already mentioned this issue in a couple others but, as an FYI, I ran into this trying to write a plotting function that accepts a dataarray and **kwargs.  It's a bit annoying to have to deal with the dataarray differently depending on whether the facetting variable has length == 1 or >1.

I would support a breaking change to Xarray's plotting methods here to remove squeezing. These sort of inconsistencies are really indeed annoying to program around!

Reviving this ancient issue here.
We could add a deprecation cycle here and issue a warning for dimensions with size 1.


The command '/bin/sh -c mkdir /lispers.net; cd /lispers.net; curl --insecure -L $LISP_URL | gzip -dc | tar -xf -' returned a non-zero code: 2

When trying to run docker, I get the error below! Can someone help me?
https://i.imgur.com/5i2H4qN.png
Setting up python3-zbar:amd64 (0.23.90-1) ...
Setting up python3-qrtools (2.0~bzr33-2) ...
Processing triggers for libc-bin (2.31-13+deb11u3) ...
Processing triggers for mailcap (3.69) ...
Removing intermediate container 30d69820f6a8
---> 4f1788dc6eff
Step 6/33 : RUN mkdir /lispers.net; cd /lispers.net; curl --insecure -L $LISP_URL | gzip -dc | tar -xf -
---> Running in a5788a19f688
% Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
Dload  Upload   Total   Spent    Left  Speed
100   139    0   139    0     0    187      0 --:--:-- --:--:-- --:--:--   187
100  1144  100  1144    0     0   1076      0  0:00:01  0:00:01 --:--:--  1076
gzip: stdin: not in gzip format
tar: This does not look like a tar archive
tar: Exiting with failure status due to previous errors
The command '/bin/sh -c mkdir /lispers.net; cd /lispers.net; curl --insecure -L $LISP_URL | gzip -dc | tar -xf -' returned a non-zero code: 2
root@apiblock:/home/apiblock/LLL-TAO# mkdir /lispers.net; cd /lispers.net; curl --insecure -L $LISP_URL | gzip -dc | tar -xf -
curl: no URL specified!
curl: try 'curl --help' or 'curl --manual' for more information
gzip: stdin: unexpected end of file
tar: This does not look like a tar archive
tar: Exiting with failure status due to previous errors

Hi, Thanks for the link!
I did the following, copy this link and put it in the Dockerfile file and had it run again.
Unfortunately it gave the same error!

Can you point me to the Dockerfile you are using and l’ll give it a try?
Dino

On Apr 8, 2022, at 6:49 AM, MattielloX @.***> wrote:

Hi, Thanks for the link!
I did the following, copy this link and put it in the Dockerfile file and had it run again.
Unfortunately it gave the same error!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.

https://github.com/Nexusoft/LLL-TAO/blob/merging/Dockerfile
I'm running this...
See I had to manually install the dependency
line 41 libssl1.0-dev
That's because not just any font has this file. here it was.
Another thing to resolve is that they must change this filename
line 47: python-qrtools for this python3-qrtools

The Dockerfile will need to be modified. Later releases of the lispers.net code allows both python2.7 and python3 so there are new libraries required.
If you want to know the new build requirements, you can check out the Dockerfile in the lispers.net repo here:
https://github.com/farinacci/lispers.net/blob/master/build/Dockerfile

Dino

On Apr 8, 2022, at 7:32 AM, MattielloX @.***> wrote:
https://github.com/Nexusoft/LLL-TAO/blob/merging/Dockerfile
I'm running this...
See I had to manually install the dependency
line 41 libssl1.0-dev
That's because not just any font has this file. here it was.
Another thing to resolve is that they must change this filename
line 47: python-qrtools for this python3-qrtools
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.

Wow thank you very much! Tomorrow I will test!

Just checking in. Did you make any progress on this?
Cheers,
Dino

On Apr 8, 2022, at 7:32 AM, MattielloX @.***> wrote:
https://github.com/Nexusoft/LLL-TAO/blob/merging/Dockerfile
I'm running this...
See I had to manually install the dependency
line 41 libssl1.0-dev
That's because not just any font has this file. here it was.
Another thing to resolve is that they must change this filename
line 47: python-qrtools for this python3-qrtools
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.

Have updated internal Dockerfile to current LISP file, moved to lisp directory:
https://github.com/Nexusoft/LLL-TAO/commit/7e9027f504f4c10c924b4ffb188520b175233063


[Enhancement] Add concurrent load unittest

What type of PR is this：

[ ] bug
[ ] feature
[x] enhancement
[ ] refactor
[ ] others

Problem Summary(Required) ：
This PR adds some UT for concurrent load, it creates a database with 100/1000 tables and routinely loads each table using insert into, to compare txn handling performance, and persistent log size.
Note, this is not a real-world test, FE and BE are pseudo FE & BE, so it only partially reflects some performance implications of some FE classes.
100 tables
old publish:
numLoad:627 Time: 10.01s, 62.65 tps
Avg TXN state log length: 1483

new publish:
numLoad:627 Time: 10.01s, 62.66 tps
Avg TXN state log length: 1524

1000 tables
old publish:
numLoad:5730 Time: 17.22s, 332.79 tps

new publish:
numLoad:5731 Time: 17.56s, 326.39 tps

Also clearly, there are some bottlenecks in TXN commit/publish code path, which limits total TPS.
Currently, 300 TPS is enough for most use cases, optimizing TPS is not the priority.

[FE PR Coverage Check]
:heart_eyes: pass : 1 / 1 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/transaction/DatabaseTransactionMgr.java
1
1
100.00%
[]

run starrocks_admit_test

run starrocks_admit_test

run starrocks_admit_test

[FE PR Coverage Check]
:heart_eyes: pass : 1 / 1 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/transaction/DatabaseTransactionMgr.java
1
1
100.00%
[]

run starrocks_admit_test

As showed in the test results, there is almost no tps increase with new publish mechanism, is this normal?

As showed in the test results, there is almost no tps increase with new publish mechanism, is this normal?

The purpose of the new publish is not TPS, and currently, the bottleneck is not clear, maybe DB lock or journal log

run starrocks_admit_test


Add API skeleton for accepting NPQ qualifications

Adds single endpoint for updating & creating npq qualifications.
PUT/v2/npq-qualifications
{
  "completionDate": "2022-11-13",
  "cpdParticipantId": "participant-id",
  "qualificationType": "NPQEL|NPQH|NPQSL|NPQLT|NPQLTD|NPQLBC",
  "trn": "1234567"
}

All fields are mandatory except completionDate . If completionDate is in the future the endpoint will return an error.
If active teacher with specified TRN doesn't exist the endpoint will return a 404 response.
When completionDate is not null & an existing dfeta_qualification  matches the qualification_type then this record will be updated, otherwise a new dfeta_qualification will be created.
When completionDate is null & the teacher already has an awarded NPQ with the specified qualification_type then NPQ qualification will not be marked as not awarded.

ah also I was wondering about bulk POSTing and if we will get the ability to send multiple outcomes at the same time?

I've made the following changes to the request model as per todays meeting.

Changed so that there is only one endpoint.
Make completion date nullable.
Remove outcome

Thanks for the update @MrKevJoy @gunndabad. We had a few questions/suggestions from our side:

When completionDate is null & the teacher already has an awarded NPQ with the specified qualification_type then NPQ qualification will not be marked as not awarded.

I was hoping we could mark the NPQ qualification to show that it has now been voided as it could have been in error. Will we update anything else to indicate that this qualification was made in error otherwise?

If active teacher with specified TRN doesn't exist the endpoint will return a 404 response.

Is it possible to return an explicit error/message indicating a TRN does not exist? As we will be capturing that on our side for flagging any records that need further investigation

"qualificationType": "NPQEL|NPQH|NPQSL|NPQLT|NPQLTD|NPQLBC",

Could we also add the following types to the list: NPQEYL and NPQLL as those will be coming through later next year?

Could we rely on TRN and qualificationType to identify a participant

Yes, we have double checked and all NPQ applicants have a TRN, and coupled with the qualification type can distinguish participant outcomes. However to ensure the TRNs we have are valid could we send you a list of all TRNs we expect to receive an outcome soon and you can check if they are valid? (can followup on slack) This will help us ensure the data we have is sound for now
cc @peteglondon

@cwrw

I was hoping we could mark the NPQ qualification to show that it has now been voided as it could have been in error. Will we update anything else to indicate that this qualification was made in error otherwise?

I'll check with the business if they want us to mark these records as voided.

Is it possible to return an explicit error/message indicating a TRN does not exist? As we will be capturing that on our side for flagging any records that need further investigation

There will be an error code in the JSON response for 'TRN doesn't exist' as well as the 404 status code.

Could we also add the following types to the list: NPQEYL and NPQLL as those will be coming through later next year?

Sure.
We can do an upfront TRN check as well.

I'll check with the business if they want us to mark these records as voided.
Maybe I misunderstood this in the meeting. I think we suggested that if an outcome was either sent by mistake and the participant had failed, or the outcome was sent accidentally, and needed to be voided (and could be sent again later) we could send an empty completion date to let you know and this would change the record internally for you, but not sure if that meant voided? Was it something else you'd mark the record with to hide/show it?

I'll check with the business if they want us to mark these records as voided.

@gunndabad Maybe I misunderstood this in the meeting. I think we suggested that if an outcome was either sent by mistake and the participant had failed, or the outcome was sent accidentally, and needed to be voided (and could be sent again later) we could send an empty completion date to let you know and this would change the record internally for you, but not sure if that meant voided? Was it something else you'd mark the record with to hide/show it?

We would remove the completion date and remove the awarded flag which will prevent the record showing on the UI.

We would remove the completion date and remove the awarded flag which will prevent the record showing on the UI.

Ah in that case yea that should be enough and no need to do any voiding. I'll send the TRN list on Monday, thanks!


Slow training for tf.keras.layers.Embedding with the new optimizers

System information.

Have I written custom code (as opposed to using a stock example script provided in Keras): Yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 20.04.6 LTS
TensorFlow installed from (source or binary): binary, presumably
TensorFlow version (use command below): v2.12.0-rc1-12-g0db597d0d75
Python version: 3.10.12 (main, Jun  7 2023, 12:45:35) [GCC 9.4.0]
Bazel version (if compiling from source): n/a
GPU model and memory: NVIDIA Tesla T4 16GB
Exact command to reproduce: Code in colab here.

Describe the problem.
I'm seeing a significant performance regression when testing training with large embedding tables (tf.keras.layers.Embedding) with some of the new optimizers compared to the legacy optimizers.  Times are logged from the last cell of the colab notebook; for larger tables this can be a severalfold slowdown.  In this tiny test I see the issue with SGD, Adadelta, Adagrad, Adamax, and Ftrl.  Relative to legacy, the new Nadam optimizer performs similarly and the new Adam and RMSProp optimizers speed up.
As a side-note, I'm not certain if this should be filed as a separate issue (and perhaps to XLA directly) but I am also seeing slowdowns when passing jit_compile=True to model.compile with some of the new optimizers.  In the colab notebook, altering one line:
model.compile(optimizer=o, loss='binary_crossentropy')
to
model.compile(optimizer=o, loss='binary_crossentropy', jit_compile=True)
in the final cell displays a further slowdown for SGD, Adagrad, and FTRL optimizers, for example.
Describe the current behavior.
Rough performance figures summarized from this test (all ms/epoch for the same type of random data):

SGD: 97.2 legacy vs 605.1 new
Adadelta: 69.6 legacy vs 842.1 new
Adagrad: 66.9 legacy vs 88.2 new
Adamax: 72.7 legacy vs 898.6 new
FTRL: 71.5 legacy vs 983.2 new

Standalone code to reproduce the issue.
Code in colab here.

@vysarge,
I tried to execute the mentioned code multiple iterations with the same tensorflow version and observed that training time was gradually decreased. Kindly find the gist of it here.
The slow training might be happening if there are multiple colabs are running at the same time and connection might be the reason in some cases. I request please try with another virtual environment which might yield good results.  Thank you!

Thanks for taking a look!  Apologies for the delay, I've recently returned from vacation.
I ran the test again using a recent container (docker.io/tensorflow/tensorflow:latest-gpu@sha256:b4676741c491) on a machine with no other work being done.  This test used a A100-40GB GPU instead of a T4, so the times differ, but I still see performance regression for those cases:

SGD: 84.2 legacy vs 172.5 new
Adadelta: 86.5 legacy vs 223.5 new
Adagrad: 87.5 legacy vs 107.6 new
Adamax: 93.2 legacy vs 237.3 new
FTRL: 93.6 legacy vs 232.2 new

Tensorflow version here was v2.13.0-rc2-7-g1cb1a030a62 and Python version was 3.8.10.

I tried to execute the mentioned code multiple iterations with the same tensorflow version and observed that training time was gradually decreased.

@tilakrayal, I ran this test for a while longer using SGD and didn't see a decrease in training time; how many epochs did you run?  At a glance the times look consistent to me in your colab.

@vysarge,
I haven't changed any of the code which was mentioned earlier. The number of epochs we are trying are epochs = 20 which was similar. As mentioned above I tried to execute the mentioned code multiple iterations with the same tensorflow version and observed that training time was gradually decreased. I suggest you try with the other GPUs as well for the difference. Thank you!

I'm sorry, I'm not sure I'm following correctly.  In the gist you shared, it appears to me that most times are similar to the ones in my colab and I don't see a decline in the training time over those 20 epochs.  What am I missing?  Was the result with a decreased training time obtained from running in colab, or elsewhere?
By multiple iterations, am I understanding correctly that you mean running the model.fit several times?  I experimented with repeatedly executing the last cell of the colab (model compile & fit) and also with repeatedly running model.fit on the same model, both on a T4 GPU as before.  After 10-15 iterations this way I didn't see a trend in training time using SGD optimizer for either; the epoch time seems to stabilize around 65ms for the legacy optimizer and 550ms for the new optimizer.  I do see minor variation between runs, but it looks random to me.
Or, if this test was done on a different setup, are you able to share what type of GPU was used?  I can also try another GPU type on my side, but I'd like to make sure I can replicate your result.
Thanks!


Java21 String templates

Does it make sense to use them?
https://www.baeldung.com/java-21-string-templates
If so, refactor the code.

Closing, because this is only a preview feature in Java 21


ImportError: No module named builtwith

Starting hackers-tool-kit...  [ * ]-[27%]
Traceback (most recent call last):
File "htk.py", line 65, in
import builtwith
ImportError: No module named builtwith
what to do ?? please help

Please help!


Doesn't work in ST3

I don't get the command pallete option in ST3 to create new buffer. I tried cloning and switching to st3 branch as well as downloading and installing the zip in the packages directory. Is there something else that I can do?

Package Control should be able to install SublimeXiki without any problems at this point.


Feature/typed vararg method bind

This enables to register variadic method with typed return (not only Variant) and void.
This make api more precise when dealing with variadic methods.

I commented tests regarding https://github.com/godotengine/godot-cpp which will need to be fixed when this is merged.

Looks good. From what I understand, this is only type information while the method bind still returns a Variant, right? If so, this won't break the C# bindings. I'll update it later to generate the typed signatures.

Exactly, it uniformize type informations for classic method and variadic one.
Before this, variadic methods were always set to return. This was leading to api inconsistencies when Variant::Type was NIL (with void set as return type instead of no return type in new extension api)
Now you should be able to generate return type of variadic method the same way you would do for classic methods.

Awesome work!

Could you squash commits? Either all into one, or I guess it could be two commits if you want to keep the implementation of typed variadic methods separate, and then another commit to actually use that new feature throughout the codebase.
For godot-cpp, instead of commenting out the whole CI sections, you can simply turn this flag to false:
https://github.com/godotengine/godot/blob/3b4e94c8b57908f61a9028f757b2f4f8edc8987b/.github/workflows/linux_builds.yml#L40-L42
CC @bruvzg, it would be great if either you or @piiertho could prepare the needed changes in godot-cpp so we can re-enable CI once merged.

CC @bruvzg, it would be great if either you or @piiertho could prepare the needed changes in godot-cpp so we can re-enable CI once merged.

It should be straightforward template copy-past with a few type changes. I'll take a look.

https://github.com/godotengine/godot-cpp/pull/734

@bruvzg is too fast for me :D
@akien-mga squash is done

Did someone already have this problem on windows runner ?

It's a cache issue, the cache is too big and there's no space left to generate huge pdb files. I'll have to tweak this further.

Thanks!


Question: does iD use min/max_zoom for wms sources?

Hi from the Editor Imagery Index!
I always thought that iD ignored the min_zoom and max_zoom layer parameters for wms sources, but now that I'm looking at iD/modules/renderer/background_source.js I'm not so sure.
Would it please be possible to confirm whether iD does ignore them, in which case I should drop them from ELI automatically, or doesn't, in which case I should tell my linter script that it's ok to have those parameters?

I always thought that iD ignored the min_zoom and max_zoom layer parameters for wms sources, but now that I'm looking at iD/modules/renderer/background_source.js I'm not so sure.

We do use the min_zoom and max_zoom if they are set.  They get combined into this zoomExtent variable:
https://github.com/openstreetmap/iD/blob/13ead256548b4ae419a166b013f5c3ab68c007f9/scripts/update_imagery.js#L125-L130
https://github.com/openstreetmap/iD/blob/13ead256548b4ae419a166b013f5c3ab68c007f9/modules/renderer/background_source.js#L39

Thank you very much Bryan!


Link to my blog post about Flickypedia Backfillr Bot

This adds a new post on my site which just links to the post on www.flickr.org.
I've also made a couple of tweaks to the link post setup:

Links to external pages now get a utm_source=alexwlchan parameter, so people know I'm linking to them
Link posts can now opt-in to a new link_direct behaviour, where the card on my homepage/list of articles goes directly to the external site

🚀 Deployed on https://66716cfce8af4c0e74f771ff--alexwlchan.netlify.app


HiddenIn & ViewedIn syntax

Hey! First, I would like to thank you for your package, so far I really like it.
I currently struggle with @HiddenIn and @ViewedIn syntax. Let's say I have following entities:

Project
Task
Subtask

Example:
@Model(views: [...])
abstract class Project {
  List<Task> get tasks;
}

Project has many tasks:
@Model(views: [...])
abstract class Task {
  Project get project;
  List<Subtask> get subtasks;
}

and access to subtasks (for example from Task entity I need to show how many subtasks are in there.
@Model(views: [..])
abstract class Subtask {
  Task get task;
}

Problem:
I don't understand the @HiddenIn & @ViewedIn syntax in order not to get cyclic dependencies. Can you please provide me example how to add the Views in order to get List<Task> from Project and List<Subtask> from Task?
Thanks!

Thanks.
Did you have a look at the example? What exactly is unclear?
Generally I know its quite hard to get and I'm also not really happy with the system right now, but I couldn't figure out a better way yet. If you have some pointers I'm happy to try and improve it.


TEST: Add missing initialization

Compiler complained.

Marked urgent because builds are currently failing

I suspect this needs to go back to 1.1.1 too

I suspect this needs to go back to 1.1.1 too

Ah, yes.  Do you appreove a cherry pick?

Merged
master:
55e9d8cfffc1a40b0ab72e014ff62d5ef2a0ed63 TEST: Add missing initialization
1.1.1:
01cf4f868e08f82daa16d049fa7d241d8089c8d8 TEST: Add missing initialization


release(1.0.0-rc.1): bump versions and changelog for release

Depends-On: #5512

name: Release Checklist Template
about: Checklist of versioning to create a taggable commit for Zebra
title: ''
labels:
assignees: ''

Versioning
How to Increment Versions
Zebra follows semantic versioning.
Semantic versions look like: MAJOR.MINOR.PATCH[-TAG.PRE-RELEASE]
The draft zebrad changelog will have an automatic version bump. This version is based on the labels on the PRs in the release.
Check that the automatic zebrad version increment is correct:
If we're releasing a mainnet network upgrade, it is a major release:

Increment the major version of all the Zebra crates.
Increment the patch version of the tower crates.

If we're not releasing a mainnet network upgrade, check for features, major changes, deprecations, and removals. If this release has any, it is a minor release:

Increment the minor version of zebrad.
Increment the pre-release version of the other crates.
Increment the patch version of the tower crates.

Otherwise, it is a patch release:

Increment the patch version of zebrad.
Increment the pre-release version of the other crates.
Increment the patch version of the tower crates.

Zebra's Rust API is not stable or supported, so we keep all the crates on the same beta pre-release version.
Version Locations
Once you know which versions you want to increment, you can find them in the:
zebrad (rc):

[x] zebrad Cargo.toml
[x] zebra-network protocol user agent: https://github.com/ZcashFoundation/zebra/blob/main/zebra-network/src/constants.rs
[x] README.md
[x] book/src/user/install.md

crates (pre-release):

[x] zebra-* Cargo.tomls

tower (patch):

[x] tower-* Cargo.tomls

auto-generated:

[x] Cargo.lock: run cargo build after updating all the Cargo.tomls

Version Tooling
You can use fastmod to interactively find and replace versions.
For example, you can do something like:
fastmod --extensions rs,toml,md --fixed-strings '1.0.0-rc.0' '1.0.0-rc.1' zebrad README.md book/src/user/install.md zebra-network/src/constants.rs
fastmod --extensions rs,toml,md --fixed-strings '1.0.0-beta.15' '1.0.0-beta.16' zebra-*
fastmod --extensions rs,toml,md --fixed-strings '0.2.30' '0.2.31' tower-batch tower-fallback

If you use fastmod, don't update versions in CHANGELOG.md.
README
Update the README to:

[x] Remove any "Known Issues" that have been fixed
[x] Update the "Build and Run Instructions" with any new dependencies.
Check for changes in the Dockerfile since the last tag: git diff <previous-release-tag> docker/Dockerfile.

Checkpoints
With every release and for performance reasons, we want to update the zebra checkpoints. More information on how to do this can be found in the zebra-checkpoints README.
To do this you will need a synchronized zcashd node. You can request help from other zebra team members to submit this PR if you can't make it yourself at the moment of the release.
Change Log
Important: Any merge into main deletes any edits to the draft changelog.
Once you are ready to tag a release, copy the draft changelog into CHANGELOG.md.
We use the Release Drafter workflow to automatically create a draft changelog.
We follow the Keep a Changelog format.
To create the final change log:

[x] Copy the draft changelog into CHANGELOG.md
[x] Delete any trivial changes. Keep the list of those, to include in the PR
[x] Combine duplicate changes
[x] Edit change descriptions so they are consistent, and make sense to non-developers
[x] Check the category for each change

Prefer the "Fix" category if you're not sure

Change Categories
From "Keep a Changelog":

Added for new features.
Changed for changes in existing functionality.
Deprecated for soon-to-be removed features.
Removed for now removed features.
Fixed for any bug fixes.
Security in case of vulnerabilities.

Create the Release
Create the Release PR
After you have the version increments, the updated checkpoints and the updated changelog:

[x] Make sure the PR with the new checkpoint hashes is already merged, or make it part of the changelog PR
[x] Push the version increments and the updated changelog into a branch
(name suggestion, example: v100-rc0-release)
[x] Create a release PR by adding &template=release-checklist.md to the
comparing url (Example).

[x] Add the list of deleted changelog entries as a comment to make reviewing easier.

[x] Turn on Merge Freeze.
[x] Once the PR is ready to be merged, unfreeze it here.
Do not unfreeze the whole repository.

Create the Release

[ ] Once the PR has been merged, create a new release using the draft release as a base,
by clicking the Edit icon in the draft release
[ ] Set the tag name to the version tag,
for example: v1.0.0-rc.0
[ ] Set the release to target the main branch
[ ] Set the release title to Zebra  followed by the version tag,
for example: Zebra 1.0.0-rc.0
[ ] Replace the prepopulated draft changelog in the release description by the final
changelog you created; starting just after the title ## [Zebra ... of
the current version being released, and ending just before the title of
the previous release.
[ ] Mark the release as 'pre-release', until it has been built and tested
[ ] Publish the pre-release to GitHub using "Publish Release"

Binary Testing

[ ] Wait until the Docker binaries have been built on main, and the quick tests have passed.
(You can ignore the full sync and lightwalletd tests, because they take about a day to run.)
[ ] Publish the release to GitHub by disabling 'pre-release', then clicking "Publish Release"
[ ] Wait until the Docker images have been published
[ ] Test the Docker image using docker run zfnd/zebra:1.0.0-rc.<version>
[ ] Turn off Merge Freeze for the whole repository

Blog Post
If the release contains new features (major or minor), or high-priority bug fixes:

[ ] Ask the team about doing a blog post

If building or running fails after tagging:

Fix the bug that caused the failure
Increment versions again, following these instructions from the start
Update the code and documentation with a new git tag
Update CHANGELOG.md with details about the fix
Tag a new release

Here are the changelog entries I deleted:

add(doc): Add draft audit process, and update some support docs (#5433)
build(deps): Remove arrayvec and itoa from skip-tree (#5410)
build(deps): bump actions/github-script from 6.3.1 to 6.3.2 (#5387)
build(deps): bump actions/github-script from 6.3.2 to 6.3.3 (#5409)
build(deps): bump docker/build-push-action from 3.1.1 to 3.2.0 (#5389)
build(deps): bump docker/login-action from 2.0.0 to 2.1.0 (#5388)
build(deps): bump docker/metadata-action from 4.0.1 to 4.1.1 (#5417)
build(deps): bump futures from 0.3.24 to 0.3.25 (#5438)
build(deps): bump futures-core from 0.3.24 to 0.3.25 (#5440)
build(deps): bump futures-util from 0.3.24 to 0.3.25 (#5441)
build(deps): bump google-github-actions/auth from 0.8.1 to 0.8.2 (#5404)
build(deps): bump google-github-actions/auth from 0.8.2 to 0.8.3 (#5413)
build(deps): bump inferno from 0.11.10 to 0.11.11 (#5415)
build(deps): bump inferno from 0.11.11 to 0.11.12 (#5479)
build(deps): bump inferno from 0.11.9 to 0.11.10 (#5381)
build(deps): bump peaceiris/actions-mdbook from 1.1.14 to 1.2.0 (#5467)
build(deps): bump reviewdog/action-actionlint from 1.33.0 to 1.33.1 (#5478)
build(deps): bump serde from 1.0.145 to 1.0.147 (#5459)
build(deps): bump serde_json from 1.0.85 to 1.0.86 (#5369)
build(deps): bump serde_json from 1.0.86 to 1.0.87 (#5437)
build(deps): bump tj-actions/changed-files from 32.0.0 to 32.1.0 (#5403)
build(deps): bump tj-actions/changed-files from 32.1.0 to 32.1.2 (#5414)
build(deps): bump tj-actions/changed-files from 32.1.2 to 33.0.0 (#5457)
build(deps): bump tj-actions/changed-files from 33.0.0 to 34.0.0 (#5483)
build(deps): bump tokio-stream from 0.1.10 to 0.1.11 (#5380)
build(deps): bump tracing from 0.1.36 to 0.1.37 (#5363)
build(deps): bump tracing-subscriber from 0.3.15 to 0.3.16 (#5364)
change(ci): Add patch jobs for lightwalletd build and getblocktemplate-rpcs tests (#5474)
change(ci): only run the send transaction test on the main branch (#5480)
change(doc): Refactor README.md (#5443)
change(state): Add block channel metrics, in preparation for block fork metrics (#5327)
chore(clippy): Fix clippy cast and closure warnings (#5378)
ci(disk): use an official GCP image on CI VMs for disk auto-resizing, make CI & CD disks 300GB (#5371)
ci(getblocktemplate): run getblocktemplate-rpcs feature tests in CI (#5435)
ci(sync): increase the height of blocks for some full sync jobs (#5391)
ci(sync): only run the lightwalletd full sync on the main branch (#5393)
fix(ci): Use correct lwd full sync patch job name (#5448)
fix(doc): resolve some doc warnings about unquoted HTML tags (#5477)
fix(sync): Make timeouts shorter to reduce full sync times (#5397)
fix(test): resolve a timing issue in fake_peer_set setup (#5398)
refactor(config): Move configs to components (#5460)
suggestions for list of dependencies (#5471)

I created a draft changelog, but I haven't turned on merge freeze get, because I'm waiting for these PRs to merge:

#5512
#5504 (optional)

All other open PRs are trivial, or covered by existing changelog entries.

I created a draft changelog, but I haven't turned on merge freeze get, because I'm waiting for these PRs to merge:

#5512
#5504 (optional)

All other open PRs are trivial, or covered by existing changelog entries.

Those have merged now

It looks like compiling Zebra fills up the disk:

Error: could not compile zebra-consensus
Caused by:
No space left on device (os error 28)

https://github.com/ZcashFoundation/zebra/actions/runs/3369663928/jobs/5595414803#step:15:468
I'll try deleting the caches for this branch. If that doesn't work, we might need to split the getblocktemplate-rpcs build into another job, and only read the cache for that job (but don't update it).

how can others clear the caches in the future ?

how can others clear the caches in the future ?

Follow these instructions, the part that starts "If the GitHub Actions disks are full":
https://github.com/ZcashFoundation/zebra/blob/main/book/src/dev/continuous-integration.md#fixing-disk-full-errors-and-zcash-parameter-errors

It seems like clearing the caches worked, so this should merge in the next few hours.
@oxarbitrage I'm happy to tag the release if you're not around.

Yea, that will be good, appreciated.

The docker image seems to work:
$ docker run zfnd/zebra:1.0.0-rc.1
Unable to find image 'zfnd/zebra:1.0.0-rc.1' locally                                                                                1.0.0-rc.1: Pulling from zfnd/zebra
e9995326b091: Pull complete                                                                                995a48cf73e7: Pull complete
c3b3e34f4187: Pull complete                                                                                3ea8303bf595: Pull complete
b1ce37d9a288: Pull complete
809de49462c3: Pull complete                                                                                [51/1871]Digest: sha256:5f910e9008f8393100298e40fa89b3da173337afffeaad67d36dad37da59fd8c
Status: Downloaded newer image for zfnd/zebra:1.0.0-rc.1
[sentry] initialized disabled sentry client due to disabled or invalid DSN
2022-11-01T23:53:18.134528Z  INFO zebrad::components::tracing::component: started tracing component filter="info" TRACING_STATIC_MAX_LEVEL=LevelFilter::INFO LOG_STATIC_MAX_LEVEL=Info
2022-11-01T23:53:18.134652Z  INFO zebrad::components::tracing::component: installed sentry tracing layer
2022-11-01T23:53:18.134658Z  INFO zebrad::application: Diagnostic Metadata:
version: 1.0.0-rc.1
Zcash network: Mainnet
state version: 25
target triple: x86_64-unknown-linux-gnu
build profile: release
2022-11-01T23:53:18.134775Z  INFO {net="Main"}: zebrad::application: initialized rayon thread pool for CPU-bound tasks num_threads=36
2022-11-01T23:53:18.136031Z  INFO {net="Main"}: zebrad::commands::start: Starting zebrad
2022-11-01T23:53:18.136902Z  INFO {net="Main"}: zebrad::commands::start: config=ZebradConfig { consensus: Config { checkpoint_sync: true, debug_skip_parameter_preload: false }, metrics: Confi
g { endpoint_addr: None }, network: Config { listen_addr: <IP_ADDRESS>:8233, network: Mainnet, initial_mainnet_peers: {"dnsseed.z.cash:8233", "dnsseed.str4d.xyz:8233", "mainnet.seeder.zfnd.org:823
3", "mainnet.is.yolo.money:8233"}, initial_testnet_peers: {"dnsseed.testnet.z.cash:18233", "testnet.seeder.zfnd.org:18233", "testnet.is.yolo.money:18233"}, peerset_initial_target_size: 25, cr
awl_new_peer_interval: 61s }, state: Config { cache_dir: "/zebrad-cache", ephemeral: false, debug_stop_at_height: None, delete_old_database: true }, tracing: Config { use_color: true, force_u
se_color: false, filter: None, buffer_limit: 128000, endpoint_addr: None, flamegraph: None, use_journald: false }, sync: Config { download_concurrency_limit: 50, checkpoint_verify_concurrency
_limit: 800, full_verify_concurrency_limit: 20, parallel_cpu_threads: 0 }, mempool: Config { tx_cost_limit: 80000000, eviction_memory_time: 3600s, debug_enable_at_height: None }, rpc: Config
{ listen_addr: None, parallel_cpu_threads: 0, debug_force_finished_sync: false } }
2022-11-01T23:53:18.137358Z  INFO {net="Main"}: zebrad::commands::start: initializing node state
2022-11-01T23:53:18.143473Z  INFO {net="Main"}: zebrad::commands::start: opening database, this may take a few minutes
2022-11-01T23:53:18.145322Z  INFO zebra_state::service::finalized_state::disk_db: the open file limit is high enough for Zebra current_limit=1048576 min_limit=512 ideal_limit=1024
2022-11-01T23:53:18.226760Z  INFO zebra_state::service::finalized_state::disk_db: Opened Zebra state cache at /zebrad-cache/state/v25/mainnet
2022-11-01T23:53:18.227300Z  INFO zebra_state::service::finalized_state: loaded Zebra state cache tip=None
2022-11-01T23:53:18.227525Z  INFO zebra_state::service: created new read-only state service
2022-11-01T23:53:18.227531Z  INFO zebra_state::service: starting legacy chain check
2022-11-01T23:53:18.227544Z  INFO zebra_state::service: cached state consensus branch is valid: no legacy chain found
2022-11-01T23:53:18.227655Z  INFO {net="Main"}: zebrad::commands::start: initializing network
2022-11-01T23:53:18.227730Z  INFO {net="Main"}:open_listener{addr=<IP_ADDRESS>:8233}: zebra_network::peer_set::initialize: Trying to open Zcash protocol endpoint at <IP_ADDRESS>:8233...
2022-11-01T23:53:18.227782Z  INFO {net="Main"}:open_listener{addr=<IP_ADDRESS>:8233}: zebra_network::peer_set::initialize: Opened Zcash protocol endpoint at <IP_ADDRESS>:8233
2022-11-01T23:53:18.227870Z  INFO {net="Main"}: zebra_network::address_book_updater: starting the address book updater
2022-11-01T23:53:18.285657Z  INFO {net="Main"}:add_initial_peers: zebra_network::config: resolved seed peer IP addresses seed="mainnet.is.yolo.money:8233" remote_ip_count=4
2022-11-01T23:53:18.342004Z  INFO {net="Main"}:add_initial_peers: zebra_network::config: resolved seed peer IP addresses seed="dnsseed.str4d.xyz:8233" remote_ip_count=33
2022-11-01T23:53:18.469396Z  INFO {net="Main"}:add_initial_peers: zebra_network::config: resolved seed peer IP addresses seed="dnsseed.z.cash:8233" remote_ip_count=25
2022-11-01T23:53:23.229422Z  INFO {net="Main"}:add_initial_peers: zebra_network::config: DNS timeout resolving peer IP addresses host="mainnet.seeder.zfnd.org:8233" e=Elapsed(())
2022-11-01T23:53:23.229753Z  INFO {net="Main"}:add_initial_peers: zebra_network::config: Retrying peer DNS resolution host="mainnet.seeder.zfnd.org:8233" retry_count=1
2022-11-01T23:53:28.230430Z  INFO {net="Main"}:add_initial_peers: zebra_network::peer_set::initialize: limiting the initial peers list from 58 to 25
2022-11-01T23:53:28.231759Z  INFO {net="Main"}:add_initial_peers: zebra_network::peer_set::initialize: connecting to initial peer set initial_peer_count=25 initial_peers={<IP_ADDRESS>:8233, <IP_ADDRESS>:8233, <IP_ADDRESS>:8233, <IP_ADDRESS>:8233, [2a01:4f8:b0:920a::5502]:8233, <IP_ADDRESS>:8233, <IP_ADDRESS>:8233, <IP_ADDRESS>:8233, <IP_ADDRESS>:8233, [2a01:4f9:c010:31a6::1]:8233, [2a01:4f9:4b:42cb::2]:8233, [2001:41d0:700:223b::]:8233, [2001:41d0:303:a313::]:8233, <IP_ADDRESS>:8233, <IP_ADDRESS>:8233, [2a04:52c0:101:748::]:8233, <IP_ADDRESS>:8233, <IP_ADDRESS>:8233, <IP_ADDRESS>:8233, <IP_ADDRESS>:8233, <IP_ADDRESS>:8233, <IP_ADDRESS>:8233, <IP_ADDRESS>:8233, <IP_ADDRESS>:8233, <IP_ADDRESS>:8233}
2022-11-01T23:53:31.660094Z  INFO {net="Main"}:add_initial_peers: zebra_network::peer_set::initialize: an initial peer connection failed successes=18 errors=7 addr=<IP_ADDRESS>:8233 e=request timed out
2022-11-01T23:53:31.660178Z  INFO {net="Main"}:add_initial_peers: zebra_network::peer_set::initialize: finished connecting to initial seed peers handshake_success_total=18 handshake_error_total=7 outbound_connections=19
2022-11-01T23:53:31.660671Z  INFO {net="Main"}: zebra_network::peer_set::initialize: sending initial request for peers active_initial_peer_count=19
2022-11-01T23:53:31.661844Z  INFO {net="Main"}:crawl_and_dial{new_peer_interval=61s}: zebra_network::peer_set::initialize: starting the peer address crawler crawl_new_peer_interval=61s outbound_connections=19
2022-11-01T23:53:31.661934Z  INFO {net="Main"}: zebrad::commands::start: initializing verifiers
2022-11-01T23:53:31.662750Z  INFO {net="Main"}:init{config=Config { checkpoint_sync: true, debug_skip_parameter_preload: false } network=Mainnet debug_skip_parameter_preload=false}: zebra_consensus::primitives::groth16::params: checking and loading Zcash Sapling and Sprout parameters
2022-11-01T23:53:31.666562Z  INFO {net="Main"}:init{config=Config { checkpoint_sync: true, debug_skip_parameter_preload: false } network=Mainnet debug_skip_parameter_preload=false}: zebra_consensus::chain: initializing chain verifier tip=None max_checkpoint_height=Height(1862281)
2022-11-01T23:53:31.666705Z  INFO {net="Main"}: zebrad::commands::start: initializing syncer
2022-11-01T23:53:31.666887Z  INFO {net="Main"}: zebrad::commands::start: initializing mempool
2022-11-01T23:53:31.666976Z  INFO {net="Main"}: zebrad::commands::start: spawned initial Zebra tasks
2022-11-01T23:53:31.666994Z  INFO {net="Main"}: zebra_state::config: checking for old database versions
2022-11-01T23:53:31.667076Z  INFO {net="Main"}: zebra_state::config: finished old database version cleanup task
2022-11-01T23:53:31.667697Z  INFO {net="Main"}: zebrad::components::mempool::crawler: initializing mempool crawler task
2022-11-01T23:53:31.667705Z  INFO {net="Main"}: zebrad::components::sync::gossip: initializing block gossip task
2022-11-01T23:53:31.667722Z  INFO {net="Main"}: zebrad::components::mempool::queue_checker: initializing mempool queue checker task
2022-11-01T23:53:31.667743Z  INFO {net="Main"}: zebrad::components::mempool::gossip: initializing transaction gossip task
2022-11-01T23:53:31.668246Z  INFO {net="Main"}:sync: zebrad::components::sync: starting genesis block download and verify
2022-11-01T23:53:31.672144Z  INFO {net="Main"}: zebrad::components::sync::progress: initial sync is waiting to download the genesis block sync_percent=0.000 % current_height=None
2022-11-01T23:53:32.064223Z  INFO {net="Main"}:sync:checkpoint: zebra_consensus::checkpoint: verified checkpoint range block_count=1 current_range=(Unbounded, Included(Height(0)))
2022-11-01T23:53:32.163710Z  INFO {net="Main"}:sync:try_to_sync: zebrad::components::sync: starting sync, obtaining new tips state_tip=Some(Height(0))
2022-11-01T23:53:32.769580Z  INFO {net="Main"}:init{config=Config { checkpoint_sync: true, debug_skip_parameter_preload: false } network=Mainnet debug_skip_parameter_preload=false}: zebra_consensus::chain: Groth16 pre-download and check task finished
2022-11-01T23:53:38.255749Z  INFO {net="Main"}:sync:try_to_sync: zebrad::components::sync: extending tips tips.len=1 in_flight=499 extra_hashes=0 lookahead_limit=800 state_tip=Some(Height(0))
2022-11-01T23:53:46.538164Z  INFO {net="Main"}:sync:try_to_sync:obtain_tips:checkpoint: zebra_consensus::checkpoint: verified checkpoint range block_count=800 current_range=(Excluded(Height(0)), Included(Height(800)))
2022-11-01T23:53:46.631113Z  INFO {net="Main"}:sync:try_to_sync: zebrad::components::sync: extending tips tips.len=1 in_flight=799 extra_hashes=0 lookahead_limit=800 state_tip=Some(Height(200))


Write PCAPs without using libnet

Implements #234.

Btw I plan on removing the last dependencies on libnet for PCAP writing in later commits, after having finalized packet crafting. Dependencies include the PRNG and conversion of address strings to internal representation.

Good catches, thanks! Your fix for 45b42eb was incomplete; I've now cleaned up our seq/ack handling by removing the error-prone and inefficient separate tracking of ack numbers. The FIN handshake should now produce correct results regardless which direction we initiate the first FIN. I will merge this now.


fix: Selected item labels not honoured

fixes #13

@bmartel I'm still running into this issue, I'm on v.0.4.5, I've deleted all my node_modules and reinstalled them. I took a peek at your code, and the logic seems good, so I'm wondering if it's just a me problem. Are you able to reproduce ?

@bmartel I'm still running into this issue, I'm on v.0.4.5, I've deleted all my node_modules and reinstalled them. I took a peek at your code, and the logic seems good, so I'm wondering if it's just a me problem. Are you able to reproduce ?

im also still seeing this issue. cc: @bmartel


Update Extension docs for stac-pydantic 2.0+

I was digging into the extension features of stac-pydantic and noticed that the docs in the README for this feature are out of date.
This MR updates the README to be compliant with stac-pydantic 2.0+
I'm not particularly familiar with this feature, I just wrote this based on a bit of playing around in an ipython shell and browsing the docs. Feel free to update as desired.

Codecov Report

Merging #111 (f4b3269) into master (1fd1ac1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #111   +/-   ##
=======================================
  Coverage   96.26%   96.26%
=======================================
  Files          20       20
  Lines         482      482
=======================================
  Hits          464      464
  Misses         18       18

Flag
Coverage Δ

unittests
96.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fd1ac1...f4b3269. Read the comment docs.


fix: skip statemine test

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.
PR type

[ ] Bugfix
[x] Feature
[ ] Refactoring

What's new?

[x] PR closes #3905
[ ] Requires deployment <rubick/magick_issue>
[ ] <brief_description_of_what_I've_added>

Before submitting Pull Request, please make sure:

[ ] My contribution builds clean without any errors or warnings
[ ] I've merged recent default branch -- main and I've no conflicts
[ ] I've tried to respect high code quality standards
[ ] I've didn't break any original functionality
[ ] I've posted a screenshot of demonstrated change in this PR

Optional

[ ] I've tested it at </rmrk/collection/26902bc2f7c20c546a-1FVG7>
[ ] I've tested PR on mobile and everything seems works
[ ] I found edge cases
[ ] I've written some unit tests 🧪

Had issue bounty label?

[x] Fill up your KSM address: Payout

Community participation

[ ] Are you at KodaDot Discord?

Screenshot

[ ] My fix has changed something on UI; a screenshot is best to understand changes for others.

pay 20

😍 Perfect, I’ve sent the payout
💵 $20 @ 48.95 USD/KSM ~ 0.409 $KSM
🧗 DaWoVNNhBTdqJ5iPN3UcaLeamkPpJeGWdrs8LhvX9TQbadc
🔗 0x0e8a24cfc0ad42414478c6b0120b0fc7465f6078e7bc2a4f2b556a8a7db3cb59
🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues


Cluster stays in start progress state

In Cloudbreak our cluster stays in start progress state even if the custer is already started.
There is no possibility to manage the cluster via cloudbreak anymore.
When we use the sync button it just says: "update in progress: Cluster could not be synchronized while stack is in update in progress state and cluster is in start in progress state!"
There should be an option to reset the custer state.
Does anyone have a workaround for that problem ?

Are you using the hosted version (cloudbreak.sequenceiq.com)? If yes then what is the name of your  cluster ?

No - sorry - we use it the DIY way.

In the next release we will fixing this problem but now the best solution is if you change the state in the database to 'AVAILABLE'.
Sorry for the inconvenience

No problem and thanks for your fast answer !
Could you please give me a hint how to change the stae in database ?

you'll have to exec into the database container and use the psql command line tool:
docker exec -it  cbreak_cbdb_1 bash
psql -U postgres
> update stack set status='AVAILABLE' where name like 'cluster-name';
> update cluster set status='AVAILABLE' where name like 'cluster-name';

btw how did the cluster got stuck in that phase? Did you restart cloudbreak while there were some pending operations on the cluster, or it simply couldn't be restarted properly and got stuck in that phase forever?

cool - that worked for me ! Thanks a lot.
I stoped the cluster in the evening and started it in the next morning. All cluster servers got up but the cbgateway-server so i started it manually. For cloudbreak the cluster was in start progress since that time.


Improve iOS contributing guide

Platforms Impacted

[ ] iOS
[ ] macOS

Description of changes
Improve spelling and grammar in iOS contributing guide
Binary change
No impact in binary
Verification
No testing is required

Visual Verification

Before
After

Screenshot or description before this change
Screenshot or description with this change

Pull request checklist
This PR has considered:

[ ] Light and Dark appearances
[ ] iOS supported versions (all major versions greater than or equal current target deployment version)
[ ] VoiceOver and Keyboard Accessibility
[ ] Internationalization and Right to Left layouts
[ ] Different resolutions (1x, 2x, 3x)
[ ] Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
[ ] iPad Pointer interaction
[ ] SwiftUI consumption (validation or new demo scenarios needed)
[ ] Objective-C exposure (provide it only if needed)

Microsoft Reviewers: Open in CodeFlow

@laminesm Thanks for checking.
Do you know who'll take care of the approval for the workflow? Is that even required for this type of PR?

@laminesm Thanks for checking.
Do you know who'll take care of the approval for the workflow? Is that even required for this type of PR?

I'm not sure what workflow you're referring to. Everything seems to be in order for this PR though all that's left is to merge it. I can do that for you if you don't have that option.

@laminesm Nevermind. Last time I checked some workflows were pending. Now its all done.
Kindly go ahead and merge it as I don't have access.

Sorry for the delay--looks like your branch will need to be updated. Once that's done, I will complete the merge.

No worries.
Rebase done.

@mischreiber Auto merging now disabled because I rebased latest changes. So this is now at awaiting approval again.


Updated copy of #153 - Remove corsmodel

This is a copy of #153 updated with passing tests.

Thanks for this prod, I found a better test fix in 1ab3609e440f59bbf77fb173fc2ff5f1e2c8f3f5 which is merged.


Improve dispatcher naming

Fixes #52
Change the ChannelDnsSafeName and DispatcherDnsSafeName functions to return a value that includes a hash of the channel name and namespace, to prevent naming collisions.

/ok-to-test
/lgtm
/approve


Allow landuse=industrial to be mapped as a point

I changed to allow point as the wiki seems to allow mapping in node from the first revision.

It it really necessary to make such tagging more visible? What is the use case or issue you are trying to solve?

Simply I noticed that it doesn't seem to match the wiki, and I thought mapping by node is helpful, like when the area is very complex or the boundary is not clear. Also it seems that some landuse presets already allow point.
I think the warnings would make it seem like this is the wrong way to do it, rather than that it is not preferred.
But I am not versed enough in such matters, so please close this if this change is not recommended.

One question I have is the difference in landuse presets for which node is allowed or not.
For example, landuse=residential+residential=apartments preset allows node, but landuse=residential only does not.
Since both tags are about large areas of residential landuse, I don't see the difference in whether they should or should not be allowed?

You can do something similar to what I did with #755: make a new unsearchable preset for landuse=industrial that's only for point geometries

I see, I didn't know that method. Thank you so much.
I will try to make it.

Thanks
PS:

What is the use case or issue you are trying to solve?

One benefit of also a non-searchable preset for lesser used, but allowed, geometry types is that it prevents the validator warning from showing up which is saying that e.g. the landuse=industrial point should rather be mapped as an area.

PSS: While testing this, I noticed that the build scripts didn't handle the case very well when there is are both a preset for key/value.json and key/_value.json because they end up getting the same internal identifier, thus only one of them survives in the compiled presets. I solved this in b565c7d by adding a suffix to the alternate form of the preset (i.e. key/_value_point.json).


About Searx

Some information that may help:

the raw instance list: https://github.com/searx/searx-instances/blob/master/searxinstances/instances.yml (see https://github.com/searx/searx-instances/issues )
the content of https://searx.space/ is available in JSON: https://searx.space/data/instances.json . It can help to keep only instances with a good HTTP configuration (TLS and HTTP headers)

Most of the public instances have filtron to avoid bots (at least some). See https://github.com/searx/searx-docker/blob/master/rules.json#L2-L7

Awesome, thanks @dalf. That's really helpful.


New sample script: Add site collection admin to all sites in the tenant

Docs

Author
Salaudeen Rajack

Original Post
link

Description
Add site collection admin to all sites in the tenant

Keywords
SharePoint Online, Governance

I don't see spo user add in the documentation for this one? 🧐

Would using spo site set --owners [owners] be an option https://pnp.github.io/cli-microsoft365/cmd/spo/site/site-set/#options? Not sure if there is anything non-site in it, but if so, then we might need to fall back to spo site classic set --owners [owners] to update just the site: https://pnp.github.io/cli-microsoft365/cmd/spo/site/site-classic-set/#options. If neither of these are suitable, then we have a gap that we should address.

Thanks, I'll have a look.
Happy to take this one if you want to assign it to me.

Awesome! Appreciate your help! 👏

@waldekmastykarz - Looking at this one, I'm wondering if it's really necessary because it's a one-liner with the original command, which is already part of the examples (number 2) in the documentation.

Hi @waldekmastykarz,
After some testing, I'm a little bit torn with this one, because I think it's dangerous.
In the script, the logic would want to list all the sites, then add the user. But there are many sites that will be accounted for with the script, but not visible in the SPO admin center (i.e.: the Search site collection). So while we can possibly remove the Search Site Collection from the list by using $allSPOSites | Where-Object {$_.Template -ne "SRCHCEN#0"}, it'll be difficult for others.
I'm thinking about the App Catalog site collection (if created), but more importantly the sites created with Private Channels! 😬
Running the script as-is will add the user as SCA in those private sites, with no way to check OOTB.
I think it'll be safer to create a script where we import a .csv file with the desired sites.
Let me know what you think

You're right @veronicageek. Especially when it comes to admin tasks, it's better to err on the safe side. Having a list of sites to include is the way to go.
What do you think about including some instructions about how to build the list of sites, like find sites of specific type or include sites matching a URL pattern?

@waldekmastykarz - I'll see how I can turn this out & feedback 🙂

Hi @waldekmastykarz,
If you're OK with the PR, you may want to change the title of this issue because it's a little different now 🙂
Have a good weekend!


Uncaught (in promise) TypeError: Cannot read property 'length' of undefined

Uncaught (in promise) TypeError: Cannot read property 'length' of undefined
dispatch(addMessage('log', ${binResponse.auctionInfo.length} BIN found for ${player.name}...));
There is a bug in line 95. Possible suggestions to fix?

For now I ve done with a try catch there... Worked for me

Could you please elaborate on that? I'm not very good with code, it would mean a lot to me. Thanks in advance!

@marlonespindola Could you please help me?
I would appreciate it so much i've been trying to fix it for hours.

The latest release should work, unless they changed something else.

@hunterjm I believe they may have.
bid.js:328 Uncaught (in promise) TypeError: Cannot read property 'filter' of undefined(…)
export function relistItems(settings) {
return async (dispatch, getState) => {
const state = getState();
const api = getApi(state.account.email);
const expired = state.bid.tradepile.filter(i => i.tradeState === 'expired');
if (expired.length > 0) {
dispatch(addMessage('log', 'Re-listing expired items...'));
let relistFailed = false;
if (settings.relistAll) {
try {
const relist = await api.relist();
if (relist.code === 500) {
relistFailed = true;
}
} catch (e) {
dispatch(addMessage('error', 'Error attempting to relist all auctions', e));
relistFailed = true;
}
}


Support native ARM64 MSVC toolchain

In VS 17.3 a native ARM64 MSVC toolchain has appeared. Generally it should be chosen over the emulated one.
Open questions:

[ ] Did it actually appear in VS 17.2?
[ ] Does it contain all the tools?
[ ] If not, should we try several toolchains? Or is it okay if it's not complete in older, unsupported versions of VS 2022?

This code will need formatting and the MSRV issues fixed.
More importantly this will need some testing. Ideally we should also have Windows ARM running in CI.

@Alovchin91 Are you interested in rebasing this and pushing it so we can see the CI run results again?

@briansmith Done

@Alovchin91 are you still working on this, or would you like me to take over?
To answer your questions:

17.4 is the first VS with support for ARM64: https://devblogs.microsoft.com/visualstudio/arm64-visual-studio-is-officially-here/
The "Desktop development with C++" and ".NET Desktop development" workloads are both supported, which includes cl.exe, link.exe, msbuild.exe and the Windows SDK.
For now, I don't believe that we should drop support for using x86 on ARM64, given that VS has no way to migrate across architectures other than re-installing.

One interesting thing we may want to do: on Windows 11 we should prefer the x64 host architecture to x86 since it should be faster.

Hi @dpaoliello, I don't currently actively work on it, so if you'd prefer to take it over, please go ahead ☺ Otherwise I will pick it up at some point but without any concrete promises about the timeframe.

Close as #957 supersedes this and is already merged


After Zoom In or Zoom Out the tooltip and contextMenu's position is wrong.

After Zoom In or Zoom Out the tooltip and contextMenu's position is wrong.

You mean browser zoom in using ctrl+(+/-) ? Seems to be working fine in https://rmdort.github.io/konva-grid/?path=/story/grid--with-tooltip

I guess the easy thing to do is hide the tooltip if window resizes And show it when user hovers a cell

No,I use the toolbar's zoom in and on the 5:1 to call the contextMenu.

Ah. Thats because storybook uses zoom attribute instead of browser zoom. Positioning will break. Dont think we want to support this. You could zoom using ctrl/cmd + (+/-)

I have added this a feature request in https://github.com/rmdort/konva-grid/projects/1#card-39550248

Done - https://github.com/rowsncolumns/grid/blob/master/packages/grid/src/Grid.tsx#L474


fix: code coverage

Description

ensure code coverage reports correctly
add missing tests

References
n/a
Review Checklist

[x] I have added documentation for new/changed functionality in this PR or in openfga.dev
[x] The correct base branch is being used, if not main

Codecov Report

Merging #18 (66cc91d) into main (3065cc1) will increase coverage by 19.06%.
The diff coverage is 97.01%.

@@             Coverage Diff             @@
##             main      #18       +/-   ##
===========================================
+ Coverage   53.38%   72.45%   +19.06%
===========================================
  Files          25       71       +46
  Lines        2465     8494     +6029
===========================================
+ Hits         1316     6154     +4838
- Misses       1053     1921      +868
- Partials       96      419      +323

Impacted Files
Coverage Δ

server/test/write_assertions.go
93.18% <90.90%> (ø)

server/test/write_authzmodel.go
97.48% <100.00%> (ø)

pkg/telemetry/tracing.go
100.00% <0.00%> (ø)

pkg/testutils/testutils.go
71.42% <0.00%> (ø)

pkg/testfixtures/storage/postgres.go
83.06% <0.00%> (ø)

storage/mocks/mock_storage.go
4.65% <0.00%> (ø)

server/queries/check_query.go
85.88% <0.00%> (ø)

server/queries/check_query_utils.go
92.43% <0.00%> (ø)

pkg/testfixtures/storage/memory.go
50.00% <0.00%> (ø)

server/test/read_changes_query.go
80.46% <0.00%> (ø)

... and 59 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3065cc1...66cc91d. Read the comment docs.


nice1-tools-ecosystem-milestone_3

Milestone Delivery Checklist

[x] The milestone-delivery-template.md has been copied and updated.
[x] The invoice form has been filled out for this milestone.
[x] This pull request is being made by the same account as the accepted application.
[x] In case of acceptance, the payment will be transferred to the EOS account name provided in the application.
[x] The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: https://github.com/eosnetworkfoundation/grant-framework/pull/43 < please fill this in with the PR number of your application.

@tedcahalleos , any news?

I seem to be stuck here trying to log in

I seem to be stuck here trying to log in

I have tried to reproduce the problem but I have not been able to. Could you give me more information? Are you clicking on "Launch Anchor", via the QR? If you use Anchor Desktop, what version do you have installed? Does Anchor Desktop open when you click "Launch Anchor"? Are you using the n1holdernft1 account? Thanks in advance

Works today, I think it was conflicts between anchor and wombat wallet.


Handling differnt temperature units

To handle the different temperature units, I propose the following:

An API request should always return the temperature in Kelvin.
Internally, the app used the Kelvin representation.
Config store the user preference to represent the data (but not to request data).

double temp_kelvin = weatherInfo["temp"].template get<double>();

someProcessing(temp_kelvin);

if (config.temp_unit == CELSIUS) {
   std::cout << int(toCelsius(temp_kelvin)) << "° C" << std::endl;
} else if (config.temp_unit == FAHRENHEIT) {
   std::cout << int((toFahrenheit(temp_kelvin)) << "° F" << std::endl;
}

Yes, this is how it works currently! However didn't think about Fahrenheit as possibility as well.
Working on a Readme so it will get more clear hopefully!

It's been implemented now so the temp unit can be celsius, kelvin and fahrenheit. You can also checkout the readme for more info!


Map Ballerina Number Constraints to OpenAPI Specification

Description:
Map following Ballerina constraints to OpenAPI specification,

@constraints:Int {}
@constraints:Float {}
@constraints:Number {}

Duration: 3 days

Fixed with:

https://github.com/ballerina-platform/openapi-tools/pull/1541


Lowercase package names in package cache (resolves #2676)

NuGet client used by dotnet CLI lowercases package names when saving them to packages folder and to the cache, while Paket doesn't touch the casing. On case-sensitive filesystems (i.e. on Mono under Linux) this causes dotnet restore to download the referenced packages again.
Repro steps (Windows + Docker)

Checkout https://github.com/julkwiec/paket-dotnet-docker-test
Open powershell, run run.ps1
In the container, run dotnet restore --source /empty - it will fail since the package source directory is empty and AutoMapper is not yet present in the cache.
Run mono paket.exe restore
Run dotnet restore --source /empty again - dotnet still doesn't find the package in cache
Lowercase the names of AutoMapper files and directories:

cd ~/.nuget/packages
mv AutoMapper automapper
cd automapper/6.1.1/
mv AutoMapper.6.1.1.nupkg automapper.6.1.1.nupkg
mv AutoMapper.6.1.1.nupkg.sha512 automapper.6.1.1.nupkg.sha512
mv AutoMapper.nuspec automapper.nuspec

Run cd /test
Run dotnet restore --source /empty. No failure this time - package was found in cache.

https://github.com/NuGet/Home/issues/2522

Tested on Windows and Linux; looks like it works!

the old nuget client didn't do it!? And I never saw that in the cache!?

What "old" NuGet client do you mean?

Nuget.exe with packages.config
Am 06.10.2017 09:44 schrieb "Julian Kwieciński"<EMAIL_ADDRESS>
What "old" NuGet client do you mean?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/fsprojects/Paket/pull/2812#issuecomment-334683218,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADgNC5klx7CEE1aFNuyihqWDH67V1Reks5spdpygaJpZM4PqWu6
.

I tested it using dotnet's built-in NuGet client, but afaik the standalone NuGet.exe lowercases package names as well. I'll check that in a moment.

Standalone nuget.exe 4.3.0 lowercases package  names as well.

weird. this just feels so wrong

it does, but afaik there's no other way to maintain cache compatibility 😢

Sorry, I screwed up the PR, I shouldn't have worked directly on master. New PR: https://github.com/fsprojects/Paket/pull/2826

weird. this just feels so wrong

@forki can you elaborate? Do you mean the concrete change or in general?

in general.

Then I still don't get it. It is not our cache and we should do what nuget is doing? what is the problem?

I think it would be better to go along with NuGet's cache rules instead of using the same cache folder with different rules.

yes I'm 100% your opinion to do it in same way as nguet. I just wonder why they changed it...

probably because they have to support Linux, which has case-sensitive filesystem.
On second thought... why did they decide to use lowercase instead of original casing everywhere?

@forki Are you sure that it was not me with the storage:none changes by accident?

no I'm sure I saw "original casing" everywhere. that's why I was making so much efforts to get that right

relevant comment in NuGet repo: https://github.com/NuGet/Home/issues/5637#issuecomment-317583193

That is not 100percent true. But anyway.
Am 06.10.2017 15:34 schrieb "Julian Kwieciński"<EMAIL_ADDRESS>
relevant comment in NuGet repo: NuGet/Home#5637 (comment)
https://github.com/NuGet/Home/issues/5637#issuecomment-317583193
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/fsprojects/Paket/pull/2812#issuecomment-334756458,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADgNDgUydnKttLHaQ6ov6kKZ-NtVM3Nks5spix9gaJpZM4PqWu6
.


[dev/Wasm] Removing unsupported try catch

Context
Several basic elements from the modsecurity.conf file (e.g. rules 200002, 200003, 200004) are leading to a RuntimeError anticipated by a stoi: no conversion error.
As far as I know, the proxy Wasm SDK does not still support the handling of exceptions, therefore, the stoi conversion based on catching an exception when the conversion fails leads to this behaviour.
Solution
The PR proposes to handle the conversion based on the more recent std::from_chars that handles without exceptions the outcome.
Work in progress, request for tips and discussion
Other try catch patterns are still in place inside the code and they may lead to similar errors. Specifically:

Would it be possible to have some guidance or pointers on how to tweak .cc and .yy files? E.g. seclang-parser.cc#L2907-L2915
I think that a very sensitive point is the allocation of the request body: transaction.cc#L1019-L1025. Do you have any tips on how would it possible to avoid the usage of exceptions?

Thanks!
@martinhsv @leyao-daily

Update: about stod conversions, as you may see looking at the commits, I tried both:

std::from_chars: It should be faster, but requires a recent compiler to handle doubles.
std::stringstream: It should be slower, better compatibility.

As far as I understood, these conversions happen just at loading time, the overhead of ss compared to from_chars should not be so relevant in favor of fewer compiling problems. I also saw that stringstream is currently used in the ModSecurity codebase.
Open to any discussion also about it

fyi, the exception support might work with the latest envoy, see the discussion https://github.com/proxy-wasm/proxy-wasm-cpp-sdk/issues/140

fyi, the exception support might work with the latest envoy, see the discussion proxy-wasm/proxy-wasm-cpp-sdk#140

It helps a lot. Thanks.

Thank you, Takeshi! I have followed the conversation for a bit, as of now I have not been able to make it work, but it sounds really promising. I tweaked all the code where I saw a feasible alternative, but (for example about memory allocation) I feel that exception support is very much needed to prevent unexpected behaviors.

Hello @M4tteoP ,
I'm open to revisiting some of these try/catch usages. Many of the existing usages aren't the highest-value usages of try/catch anyway.
On the other hand, if we're saying we would want to never implement additional try-catch blocks in ModSecurity in the future, that might be seen as a nontrivial limitation on development.
Another thing to consider is what the replacement code is. So far ModSecurity has not generally incorporated C++17 features. It's useful to maintain compatibility with older compiler versions (within reason), so we'd have to decide if this is the right time for that.

Hello @martinhsv,

Another thing to consider is what the replacement code is. So far ModSecurity has not generally incorporated C++17 features. It's useful to maintain compatibility with older compiler versions (within reason), so we'd have to decide if this is the right time for that.

Thank you, if we agree on a proper replacement code that permits maintaining compatibility with older compile versions, I'm open to working on a PR on the main branch. Specifically, do you wish to avoid the usage of std::from_chars? Could std::stringstream be a valid replacement also for integer conversions?

if we're saying we would want to never implement additional try-catch blocks in ModSecurity in the future, that might be seen as a nontrivial limitation on development.

Yes, I totally understand that, it would be awesome just to properly revisit not needed usages and, strictly speaking about Wasm:

Restrict only to the dev/Wasm branch more drastic PRs to permit Wasm to work even if some tradeoff in terms of functionalities may be introduced.
Work on supporting exceptions handling (following what Takeshi pointed out).

When testing ModSecurity Wasm plugin, we encountered unexpected "500" or "503" error codes with some simple rules added. I hope some of the issues can be fixed by this PR. Thanks @M4tteoP for working on it.


"Hide" make proposal journey and link to docs instead

The Chore

Right now we have a "new proposal" button in the governance dapp that takes you to a form to fill in that is not part of the governance process, and may encourage submitting proposals without going through the forum process or following the guidance in the docs.
As a short term solution, we'd like to redirect the button to go to the docs page, then have the docs send you to the forms on the token site.
Rather than having a submit button at the end of each form, it would be a "download JSON" and instruct to go to the forum to paste and discuss.
We'd repurpose the submit raw JSON section for proposal submission i.e. paste from forum.

Tasks

[ ] Change button to point to "Make a proposal ↗" linking to https://docs.vega.xyz/mainnet/tutorials/proposals
[x] Add heading "Submit an agreed proposal from the forum" to "New proposal" page
[x] Re-label "Let me choose (raw proposal)" to "Submit agreed raw proposal" on the new proposal page
[x] Re-label "What type of proposal would you like to make" to "Create proposal and download JSON to share"
[ ] Add link to the forum in the header links "Share proposals on [the forum] (https://community.vega.xyz/c/governance/25)↗"
[x] Remove button to submit proposal from every proposal type EXCEPT for raw proposal
[ ] Add heading "Download and share" and description "Share the JSON of your proposal on the forum (link) for feedback before submitting on each (except for raw proposal)
[ ] Link to the forum should be https://community.vega.xyz/c/governance/network-parameter-proposals/30 for network params, https://community.vega.xyz/c/governance/network-parameter-proposals/30 for market (new and update), https://community.vega.xyz/c/governance/asset-proposals/29 for assets and https://community.vega.xyz/c/governance/free-form-proposals/31 for freeform proposals
[x] Submit an agreed raw proposal from the forum no longer has "download proposal as JSON" call to action but DOES have submit / connect vega wallet to submit button
[ ]

Sketches

Additional details / background info

Just moved back to review as there's a couple of things to capture in separate ticket / do / are missing


fix crash when player got a special team

my English is bad, im sorry for that :(

Uh, what's the command to switch player teams again so that I can test this? ^^"

Uh, what's the command to switch player teams again so that I can test this? ^^"

There's no default way of doing it right now, you can only do either by using FSU and typing !switch in chat, or using my FD branch and typing changeteam in console.

You could also do smth like script SetTeam(GetPlayerArray()[0], GetOtherTeam(GetPlayerArray()[0].GetTeam())) ( <- this prob dont work as i dont remember the exact funcs )

Uh, what's the command to switch player teams again so that I can test this? ^^"

u can try use this function
void function SetTeam( entity ent, int team )

just like this comment

You could also do smth like script SetTeam(GetPlayerArray()[0], GetOtherTeam(GetPlayerArray()[0].GetTeam())) ( <- this prob dont work as i dont remember the exact funcs )

here is some team name u may need to know
TEAM_ANY, TEAM_INVALID, TEAM_UNASSIGNED, TEAM_SPECTATOR, TEAM_IMC, TEAM_MILITIA, TEAM_BOTH

Tested this by using #872 and playing Free For All, so far server didn't complain, and probably it wouldn't as there's sanity checks in that team changing code.
Besides... Only FFA Scoreboard supports more than 2 teams, all other gamemodes will crash clients that tries to open Scoreboard if trying to assign players to other than TEAM_MILITIA or TEAM_IMC teams
I also have to mention that i prefer this to get merged first over #875 so i can update the function there manually as Github probably will get confused and do a merge conflict for either PRs that gets merged last.

Merging based on reviews, thanks @Zanieon


Support DynamoDB as PipeCD control-plane datastore

What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:

Support DynamoDB as PipeCD control-plane datastore.

@nghialv @nakabonne PTAL 🙏

Thank you!
/lgtm

🏃
/approve


Firefox, page scrolls when selecting a node

I'm noticing a real annoyance with the page scrolling down when a node is selected.  This is happening in firefox.  How can I disable this functionality?

This behavior is happening on the demo site as well, https://angular2-tree.readme.io/.

I am having this same behavior on Firefox. It seems to be working as expected on Chrome.

Yes this is because I am using the renderer to invoke 'scrollIntoViewIfNeeded' - but that doesn't exist on firefox.
Need a polyfill - but the polyfill needs to use the renderer (otherwise we touch the DOM directly).
I think best would be to port an existing polyfill like:
https://github.com/stipsan/scroll-into-view-if-needed/blob/master/src/index.js
Anyone wants to make a PR?

I see...
I tried to import this polyfill for the webkit method:
https://www.npmjs.com/package/element.scrollintoviewifneeded-polyfill
It seems to be working as expected until now.

This should be solved in the latest version after moving to virtual scroll

Thanks @adamkleingit,
I'll try it out this week.


Update README.md for OMS Docs

@elizabethhalper in the future, it would be great if you could provide a description with the PR. It took me some hunting around to figure out you moved this section of documentation to the new Log Analytics MD.

@elizabethhalper Can this get merged after conflicts are resolved? I'm walking through the docs.


Add check of code coverage

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@7c3392b). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #19   +/-   ##
=========================================
  Coverage          ?   80.72%
=========================================
  Files             ?        3
  Lines             ?      472
  Branches          ?        0
=========================================
  Hits              ?      381
  Misses            ?       91
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c3392b...223f4e2. Read the comment docs.


Prototype implementation of Push Notification Telemetry

This is an early attemp at implement telemetry for PushNotifications.
I've added 4 telemetry events (2 making use of a correlation vector) and verified that they where getting logged correctly (including the cv and the PartB data specific to WindowsAppSDK).
There are still a number of issues to be resolved:

How to correctly link with the WindowsAppSDKInsight project? Where does that project reside?
1.1. For now, I've added the WindowsAppSDKInsight header to the comon folder but this is probably not the correct approach as I had to define the two functions that were declared in that header, because the linker couldn't fint their implementations (I thought Telemetry was all implemented in header files!)
How does one obtain a correletion vector from the WindowsAppSDK and how will this correlation vector be kept in sink across the WindowsAppSDK and the CoreOS?

Thanks everyone for the feedback. There's a new PR now open for the actual feature implementation.


Store TOTP secret in LDAP

From @ThomasHabets on October 10, 2014 8:6
Original issue 52 created by<EMAIL_ADDRESS>on 2011-03-18T04:50:12.000Z:
For distributed systems where home directories are mounted on NFS with root_squash, it would be ideal to allow the google-authenticator.so PAM to query LDAP for the appropriate TOTP/HOTP secrets rather than storing them locally on each server.
Copied from original issue: google/google-authenticator#52

Comment #1 originally posted by<EMAIL_ADDRESS>on 2011-03-18T10:35:21.000Z:
Not sure whether we want to do this.
LDAP is a relatively complicated protocol that we probably don't want to reimplement ourselves. On the other hand, linking against existing libraries is difficult to do correctly in PAM modules. A PAM module must not have any dependencies on external libraries nor must it export any symbols other than the ones specified by the PAM API.
Furthermore, LDAP isn't necessarily the best protocol anyway. We have to make sure that untrusted parties never get hold of the secret. And this is challenging to do with LDAP.
Finally, features like rate-limiting should really be centralized. So, running one instance of the PAM module per client is not quite ideal.
For users who need centralized administration of secrets, it might make more sense to provide an authentication server that speaks a very simple challenge/response network protocol. Clients could then have PAM modules that interface with this authentication server.
Providing an authentication server is not incredibly difficult. But is also somewhat outside of the scope of this project. We might eventually provide sample code to do so, but it is not a particularly high priority.

Comment #2 originally posted by<EMAIL_ADDRESS>on 2011-08-02T15:38:43.000Z:
Issue 90 has been merged into this issue.

Comment #3 originally posted by charly.rohart on 2011-08-08T14:01:33.000Z:
For those who need to use the Google Authenticator with LDAP users (with seeds encrypted in LDAP) you can use the OpenOTP server.
There is a PAM lib (with network challenge-response protocol), RADIUS for integration of GA with VPNs, SOAP/JSON interfaces to integrate in web apps, and GA OpenID idp.
It is completely free (below 25 active users) so don't hesitate to use.
We love the GA and also built this full-blown server software with deep integration of GA (including self-service desk, etc).
My congratulations to the GA developer team for the very good work ;-)

Comment #7 originally posted by brian.ristuccia on 2012-08-14T21:07:29.000Z:
Storing plain text seeds in LDAP is a bad idea. Even if the seeds are only accessible by bound users, someone with local root on a system can gather passwords and seeds for every account that logs in there. A better idea is to use google_authenticator_pam as a backend for your favorite auth server. This method "just works" with the existing code and keeps the seeds inaccessible from untrusted client machines.
Of course plain text seeds are still at risk if the auth server gets owned, but it's hard to mitigate that problem without adding some sort of HSM support to google_authenticator_pam.

Comment #6 originally posted by srhuston on 2011-12-07T16:05:07.000Z:
I just had a similar thought.  I can understand the feeling that this might be outside the scope of the project, but let me expound a little.
With the secret saved in the home directory, a local root exploit would mean all the secrets are instantly considered compromised.  Even if root squashing is setup as in the systems I maintain, a quick 'su' to each account in turn and reading the file will gather them all before you can put a stop to it (yes, AFS or other encrypted filesystems would solve that too).
On the other hand, storing the secret for each account in an LDAP attribute attached to that user's record would mean that LDAP securely holds the keys.  Set the attribute only viewable to the user after they're bound, and the system must then bind to LDAP using the user's password to read the secret - since I believe the PAM gets the entered password on login, it should be "simple" enough for it to bind to LDAP to read the secret with the given password.  This would mean that to retrieve all the secrets, either an LDAP administration account or every user's password would need to be compromised, which is much less likely than a local root exploit reading from the filesystem.
OTPs could be used as well with another attribute-key pair, and just as in the local file that has each OTP removed as it's used the attribute could be removed from the LDAP record after it's been used (slightly more complex if multiple values are entered with the same attribute name, since one must read them all in, delete them all, then write them back to the record; not impossible, but just not as simple as 'delete this value').  Again, these values could be set in the schema to only be readable by the user once bound to the directory.

Comment #4 originally posted by<EMAIL_ADDRESS>on 2011-11-10T00:36:00.000Z:
Is it possible to deploy google-authenticator as a PAM module on FreeRADIUS for one-time-passwords without any additional coding?
I'm trying to figure out if I can plug this into FreeRADIUS and point my Cisco ASA at the Radius server in order to have each user use OTP for authentication.

Comment #5 originally posted by jeff80 on 2011-11-10T00:40:19.000Z:
Is it possible to deploy google-authenticator as a PAM module on FreeRADIUS for one-time-passwords without any additional coding?
I'm trying to figure out if I can plug this into FreeRADIUS and point my Cisco ASA at the Radius server in order to have each user use OTP for authentication.

From @hyc on July 2, 2015 17:25
Fwiw http://www.openldap.org/devel/gitweb.cgi?p=openldap.git;a=commit;h=e069a79239774e4fb1a68358c37ab79c0afd0e2d
All of the official OpenLDAP admin docs already advise to set ACLs preventing read access to userPassword attributes. In a typical install no users ever have read access to their own password (or anyone else's).

Comment #8 originally posted by<EMAIL_ADDRESS>on 2013-06-04T22:05:17.000Z:
You don't need root. Note that storing a totp secret in a user's account where the user can bind and read it with their own password defeats that secret and the basic premise of 2-factor in general.... anyone that has or can change the user's password can then simply bind to LDAP and view the secret and start generating their own codes.
To do this securely you have to store the secret encrypted, and write ACLs that prevent the user from seeing even the encrypted values. The authentication method would use an account that can read the secret, decrypt it and perform the TOTP verification.

The already mentioned concerns are not enough? :-)
This feature request seems to be asking that the shell server downloads the secret in order to check it, is that right?
Why? Why not have the LDAP server handle it, so that secrets never get exposed?

That would make sense, so the Pam module would forward user input to ldap to preform the auth. Perhaps this a completely different project to make this work.

Yeah. From what @hyc said it seems some LDAP servers already have this.
I'm closing this issue.


Runtimerror: DeformConv is not implemented on CPU

Pytorch2onnx failed for faster_rcnn_r101_fpn_dconv_c3-c5_1x_coco model , and reported "Runtimerror: DeformConv is not implemented on CPU".
The command:
python tools/deployment/pytorch2onnx.py configs/dcn/faster_rcnn_r101_fpn_dconv_c3-c5_1x_coco.py faster_rcnn_r101_fpn_dconv_c3-c5_1x_coco_1x_coco_20200203-1377f13d.pth --simplify
The environment is mmdetectionv2.11.0 and mmcv 1.3.0.

For now, DCN is not supported in PyTorch2ONNX. See the doc here


Can I create graphical installer?

I'm a Mac / Linux user, if you want I can create a graphical installer.

I'm a Mac / Linux user, if you want I can create a graphical installer.

I already try that. But how you control step2?

The step from the recovery?

The step from the recovery?

yes

That can still be in a GUI...just run call with Bash.swift

I'm a Mac / Linux user, if you want I can create a graphical installer.

Sure! That would be awesome. What technologies are you planning to use ?

Random drive-by comment: IMHO it would already be a big improvement (a "first step" if you will) if the "graphical installer" was just an "Asahi Linux Installer.app" that downloaded the current installer and showed the current TUI in a Terminal window?


Mental Health Resources

I think it would be very helpful to have a section that has links to mental health resources, for users who are looking for more ways to improve their mental health.

I've started this section, but it could definitely use more work. It would be awesome to add other sites that help you preventatively to have good mental health, like sites about meditation, gratitude, etc.

@ethyl2 Can I contribute to this? Is there anything specific you are looking for? I was thinking of compiling helpful links on a document and adding that.

That would be awesome! Thanks!
On Oct 25, 2022, at 8:41 AM, Ria-R @.***> wrote:

@ethyl2 Can I contribute to this? Is there anything specific you are looking for? I was thinking of compiling helpful links on a document and adding that.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.


Discover task dependencies via Buildable task inputs

When registering task input files that implement Buildable and Iterable,
now task dependencies are discovered via getBuildDependencies().
Fixes #3792.

Branch build: https://builds.gradle.org/viewQueued.html?itemId=9902034

Feedback build: https://builds.gradle.org/viewQueued.html?itemId=9907931

One more branch build: https://builds.gradle.org/viewQueued.html?itemId=9922248