Refactor Artifacts Parser to be Native so it's less brittle with each dbt version change

Problem: Each time a new dbt version is released, it results in running fire drills to fix breaking changes to the dbt integration specifically because of version upgrades to run_results.json and manifest.json. This is pronounced because data-diff relies on a solo-developer maintained package to parse the json docs into python objects. https://github.com/yu-iskw/dbt-artifacts-parser
Solution: Build native json/dictionary parsing within data-diff and focus on stable fields so that new version upgrades are immaterial to how data-diff interacts with dbt.
Technical Approach
I create native pydantic schema enforcers for both the manifest.json and run_results.json with only the fields necessary for data-diff to work properly. The fields data-diff reads in are relatively stable across artifact schema changes and can handle malformed artifact schemas if they're manipulated by a process outside of dbt. This makes this piece of the codebase lighter weight as the dbt-artifacts-parser enforces more artifact schema validation than needed. When future bugs arise because of breaking changes to the artifact schemas, we can simply adjust the native schema validator in data-diff vs. relying on the solo-developer maintained package.

Approach looks great, this will simplify things in an elegant way, appreciate it @sungchun12


[Feature] Resistor color code calculator

Description
I want to add a Resistor color code calculator which calculates the Resistance according to the color
that
Screenshots

Checklist

[X] I have checked the existing issues.
[X] I follow Contributing Guidelines of this project.
[X] I am a IWOC'24 contributor.
[ ] I am a JWOC'24 contributor.
[ ] I am a SWOC'24 contributor.

Code of Conduct

[X] I agree to follow this project's "Code of Conduct".

I suppose this Calculator is already present. Is yours different from this? @JiyaGupta-cs


Disable feature rr

 Disable all features added by #529/559 and #480 specifically for Stage 1 scheduled track submissions in PCI RR


feat: time tests and test methods

Not sure we actually want this to go in (perhaps behind a flag, if that's possible?) but I've noticed that sometimes the tests here on GitHub take a very long time, and I'm curious as to which test is taking up the time.
Coverage might be slowing it too, so perhaps we only want to cover on Ubuntu?

We could add it as a separate workflow that runs on dispatch or whatever the event is that lets you run it on button press

Considering that the tests for this have been stuck on Windows forever, this is timely.
You may be able to answer your question with this run. 😀

I routinely work in Windows booting up a Debian VM if I really have to.
Tests take less than six minutes wall clock time.  I haven't seen anything take more than that since we cleaned up the TokenServer(?  fredg's work) tests.
I just ran this locally.  Still under 6 minutes.  I haven't found where the output went and I didn't have a large enough scroll buffer but the last FightRequest test (Commerce Ghost or the next one) clocks in at about 24 seconds.  There are tests in FileMonitortest that take 15s, 6s, and 22s.  Something in StateCheckWrappersTest taks about 8s.  Doesn't seem to be much else over 5s.
I will look at GitHub output and mine and see if the patterns are similar, probably tomorrow.
I will remind folks that the root cause could be one or more tests or it could be something GitHub is doing with Windows that gives a different environment.

No major investigation but some odd stuff.
For example, PreferencesTest took 231590 ms. Totting up the individual methods gives 62 ms.
So a lot of time must be spent in before and after each (or just by JUnit getting ready to run things, I guess):
  @BeforeEach
  public void initializeCharPrefs() {
    KoLCharacter.reset("fakePrefUser");
    KoLCharacter.reset(true);
    Preferences.saveSettingsToFile = false;
  }

  @AfterEach
  public void resetCharAndPrefs() {
    KoLCharacter.reset("");
    KoLCharacter.reset(true);
    KoLCharacter.setUserId(0);
    Preferences.saveSettingsToFile = false;
  }

Now this resets the character twice while it shouldn't need to, but at 231 seconds for 35 tests, this is about 6 seconds each, which still seems like rather a lot.
I noticed that in FightRequestTest, the nested Lovebugs test sets Preferences.saveSettingsToFile to true for the rest of the tests in that class. I filed https://github.com/kolmafia/kolmafia/pull/1172 thinking it might be slow file system interaction, but some filesystem-heavy tests seem completely fine, so I don't think it's that overall.

All this was done without recent updates.
These tests took more than 5 seconds both locally and on GitHub.
[KoLAdventureValidationTest]
[ModifierExpressionTest]
[RestoreExpressionTest]
[MaximizerTest]
[PreferencesTest]
[FightRequestTest]
[FilesMonitorTest:filesMonitorTest]
[FilesMonitorTest:filesMonitorNewFileTest]
[FilesMonitorTest]
[StateCheckWrappersTest]
There are at least 100 tests that exceeded 5 seconds on GitHub but not locally.  There are also a boatload that were an order of magnitude faster locally than on GitHub.
Not sure what any of this means :-)

I can't see a way to easily make this flaggable. I'm currently using a specific file to apply this to all tests, and I don't think it's possible to either tell JUnit to use a different file under some circumstances or selectively change the contents of the file.
If this always runs, the only effect is that the output fills with messages you're not necessarily interested in.
The outputs should ideally be simply the time and class / method, but I think JUnit wraps the log in a note of where it came from.

The output I would tweak seems to be added by JUnit.  The extra clutter is most likely to matter when a test fails and some work has to be done to see which one.  Gradle puts out an elapsed time and this adds about 2 minutes to the overall test task on my system.
Those are all things I could live with if someone wanted to commit this.  But I could also see capturing this as a patch file and applying it locally or as a new PR if someone wanted to do something with the timing data.
I guess at the moment I can accept someone else's preference/decision.

What's the status here?

I can't see a way to easily make this flaggable.

I think we are waiting to see if anyone can make this flaggable.  I like the idea but would like to be able to turn it on or off because it does take some time locally.
My perfect solution would be to have a flag that allowed me to turn it on or off, locally and on or off on GitHub.  I don't really care if it is always on on GitHub but I do want to toggle whether it runs locally or not.
As it stands not pushing this PR gives us that.  If we want to turn it on for GitHub we update to main and then run.  If I (we?) want it locally I just grab this branch.

If it's not going to be merged in I could close the PR but keep the branch alive, then you can cherry-pick it into your branches, run to check, then delete it after. That's what I've been doing.
The issue with making it flaggable is that I'm using automatic registration and that requires a particular file. I'm wondering if I knew gradle better if I could add something to some test run call that read an environment variable and modified the file to add / remove the line registering this one. But I also want it to run from inside my IDE.

perhaps I could always register the class, but only have it do anything if a particular env var is set?

I just ran locally.  8+ minutes without this and 9+ minutes without.  Close enough that I won't use timing as a reason to insist it be switchable.  It is tremendously verbose but I think that can be adjusted to.

I think, given that switching it on or off is always going to require some change, the easiest thing to do is to delete the registration line in test/resources/META-INF/services/org.junit.jupiter.api.extension.Extension if you don't want it to run.
Options like "create another gradle task for this" don't satisfy my desire to be able to run this on an individual test from my IDE.

I think, given that switching it on or off is always going to require some change, the easiest thing to do is to delete the registration line in test/resources/META-INF/services/org.junit.jupiter.api.extension.Extension if you don't want it to run.

I think this means we are in agreement??


Display the version in the web page.

Is your feature request related to a problem? Please describe.
Right now, you cannot see which version of the diagram converter is used when you open the web page.
Describe the solution you'd like
We should display the version on the web page.
Describe alternatives you've considered
nothing
Additional context
Do we already insert the converter version into the converted diagrams?

@jonathanlukas, I hope you know this out of your head:

Do we already insert the converter version into the converted diagrams?

No, we don't. This is something we could start doing.


Two alarms with overlapping snoozing: one or both alarms not fired again after snooze time

Describe the bug

After snoozing an alarm (via shaking my phone), the alarm sometimes sounds again (after the configured "Snooze length") and sometimes not. In the latter case, some time later (many minutes after the configured "Snooze length" has elapsed) the app displays a notification that the alarm was missed.
I have observed this behaviour only in case of two alarms with overlapping snoozing, i.e. the second alarm being configured to fire while the first alarm is snoozing.
To Reproduce

Not sure if this is enough to reproduce, but here's what happens for me:

"Snooze length" set to 6 minutes.
Alarm 1 set to fire at 06:30 ("Vibrate" off).
Alarm 2 set to fire at 06:32 ("Vibrate" on).
At 06:30:xx, snooze alarm 1.
At 06:32:xx, snooze alarm 2.
If alarm 1 or 2 sounds again, snooze it. Repeat.
Eventually, both alarms won't sound again although expected.
Some time later, a notification says that an alarm or both were missed.

Expected behavior

Screenshots

App version

A while ago, I upgraded to version 2.8; the unexpected behaviour started to appear after the upgrade.
Not sure which version previously was installed, but 2.7 seems likely.
The unexpected behaviour can still be observed in version 2.9.
Device (please complete the following information):

Model:
OS:  GrapheneOS, Android 14, not recently upgraded

Additional context

@mcg-android
I checked all commits between 2.6 and 2.9 and the only change that could cause this bad behavior is commit dba379a but I have doubts because it is impossible to reproduce your bug on my device.
I've repeated both alarms 5 times and each time they go off correctly.
It would be great if the steps to reproduce this possible bug weren't guesswork; that would help me a lot.
As a last resort, delete the application data (don't forget to make a backup first) and check whether the bug is still present on your device.

Here's an extended list of steps, as observed this morning. I tried hard to behave normally but to pay closer attention – early in the morning...

"Snooze length" set to 6 minutes.
Alarm 1 set to fire at 06:30 ("Vibrate" off).
Alarm 2 set to fire at 06:32 ("Vibrate" on).
"Do not disturb" is on.
At 06:30:xx, snooze alarm 1.
At 06:32:xx, snooze alarm 2.
If alarm 1 or 2 sounds again, snooze it; but:

At 06:50:xx, dismiss alarm 2.

At ~07:10, unlock phone and check messages.
At ~07:13, realize that alarm 1 hasn't rung again (due at 07:12:xx) – no sound, no floating notification, no fullscreen thingy, no anything.
There's no notification stating that alarm 1 is snoozing until whenever.
Unchanged at 07:23.
At 07:28 notice there's a new notification stating that alarm 1 was missed at 07:18.

I was able to observe similar behaviour with a newly added, single alarm:

Alarm set for 11:45, rings as expected.
After six snoozes unexpectedly did not ring again at 12:27, when the phone was unlocked and I was using a web browser app.
No "Snoozing until" notification appeared, and no "Missed alarm" notification seen either.
Surprisingly at 12:5x (might have started a few minutes earlier; I was away from the phone), the alarm did ring again.
Snoozed two more times; then the alarm unexpectedly did not ring again, no "Snoozing until" notification, no "Missed alarm" notification seen.
Did not observe closely. Next surprise at 13:33: the alarm is ringing again.
Dismissed the alarm, had to abort the experiment.

So "overlapping snoozing" may have been a wrong track...

@mcg-android
Thank you very much for providing these details.
Unfortunately, I still can't reproduce the bug even after repeating the alarm 10 times.
It may be GrapheneOS that's causing this bug.
For now, I'm classifying this topic as "specific device" until I find out if other people with the same OS as you are experiencing the same problem.
If you're still willing and able to help, it would be great to know exactly which version this bug appears in.

@j-lakeman
As you also use GrapheneOS, can you please tell us if you also encounter this bug?
Thanks in advance.

it would be great to know exactly which version this bug appears in.

In "About phone", the "Build number" is shown as "2024080600".

Another observation:

One afternoon, I missed an alarm; no other alarm involved.
No alarm was expected to fire until late on the following day.
I kept the "Missed alarm" notification as a reminder.
The phone wasn't used a lot.
The next morning, after I had started using the phone, the "Missed alarm" notification disappeared; instead, a "Snoozing until" notification appeared, showing a time-of-day minutes away (can't remember whether past or future; but my feeling is that I've never seen "Snoozing until" with a time-of-day in the past).
Not sure whether that alarm actually did fire again.

@mcg-android
Is the bug still present when using version 2.10.1 or after reinstalling the application?

Still on the same version of GrapheneOS, still using com.best.deskclock in version 2.9.
Using "Backup & Restore", I performed a "Backup" to a file and a "Restore" from that file.
The result was not as expected: The next morning, no alarm rang; no notification appeared; just as if no alarm had been set. Enabling a disabled alarm made the alarms ring again. (So I guess that's a different issue.)
The next day in the morning, alarms rang as expected, and the issue of unexpectedly no-longer-snoozing-later-missed alarms still occurred. ⇒ "Backup" + "Restore" did not fix the issue for me.

Still on the same version of GrapheneOS, still using com.best.deskclock in version 2.9.

or after reinstalling the application?

Uninstalled com.best.deskclock, then reinstalled it (via F-Droid) in version 2.9.
Ran "Restore" using the backup file I had created for the previous test, and: no alarms to be seen. Thought I had made some kind of mistake, ran "Restore" again – still no alarms to be seen. Noticed the text says "Backup or restore settings except alarms, [...]". Well, great, so all my alarms are lost now?
Went back to using the native clock app for a while; it doesn't support shake-to-snooze, but it still had most of my alarms in its config. Observed no occurrence of an alarm unexpectedly not ringing again.
Manually added two alarms to the empty list of alarms in com.best.deskclock, and right on the first day one of the alarms did not ring again after having been snoozed (instead, rather quickly a notification showed it as "missed").
⇒ Uninstalling and re-installing version 2.9 did not fix the issue for me.

When I asked in which version this bug appears, I meant from which version of the app this bug appears for the first time; not the version of your device.
Performing a backup/restore has no influence on the alarms; it only served to prevent you from reconfiguring all the settings.
Honestly, I don't know where it's coming from, as this bug is impossible to reproduce on my 3 devices with 3 different Android versions. What's for sure is that I'm not using any alternative ROMs, so maybe it's GrapheneOS-related.

When I asked in which version this bug appears, I meant from which version of the app this bug appears for the first time; not the version of your device.

A while ago, I upgraded to version 2.8; the unexpected behaviour started to appear after the upgrade.
Not sure which version previously was installed, but 2.7 seems likely.

is the setting App Info>App battery usage>Allow background usage>Unrestricted turned on?

In my case, it is turned on (and always was, pretty sure about that).

I also don't see any testing with another alarm app.

I went back to using the native clock app for a few days. Observed no occurrence of an alarm unexpectedly not ringing again.
Any other suggested app (available on F-Droid)? Should be based on the AOSP clock, I guess. Bonus points if it supports shake-to-snooze. :-)

Is the bug still present when using version 2.10.1

I upgraded com.best.deskclock from version 2.9 to 2.10.1 (via F-Droid).
Still the same unexpected behaviour: Right on the first morning, the second alarm didn't even fire once but was quickly shown as missed (roughly at the same the first alarm rang for the second time?); the first alarm rang fine for a few "Snooze length" intervals, then was shown as "Snoozing until X" until long after X  (many hours; I don't think I had seen that before).
⇒ Upgrading to version 2.10.1 did not fix the issue for me.

Sorry for my late reply ; my free time is currently very limited.
@ltguillaume
I missed your message. When the alarm is snoozed, the same alarm is rescheduled.
@mcg-android

⇒ Upgrading to version 2.10.1 did not fix the issue for me.

I'm not surprised, as I've hardly made any changes to the alarm status.
Despite this, can you please test the LineageOS application below?
DeskClock-LineageOS-release.zip

A few days ago, I uninstalled com.best.deskclock (version 2.10.1) and then restored version 2.6 from a backup.
I haven't seen a missed-after-snooze alarm since then.

Despite this, can you please test the LineageOS application below?

Will try, but most of my usual alarms will be turned off for the coming weeks. :-)
Where does that .apk come from? Is it supposed to have been built from this code? https://github.com/LineageOS/android_packages_apps_DeskClock

Will try, but most of my usual alarms will be turned off for the coming weeks. :-)
Where does that .apk come from? Is it supposed to have been built from this code?

@mcg-android
Don't worry, take your time testing, especially as mine is limited at the moment.
I can confirm that the apk comes from the repository you mentioned.

@mcg-android
Can you please test the apk below?
I rewrote the code added after version 2.6 in the AlarmStateManager.java file and it works on my device. I hope it will work properly on yours otherwise I can't see where it could be coming from.
Clock_2.12_beta-debug.zip

Can you please test the apk below?

I uninstalled com.best.deskclock (version 2.6).
I installed com.best.deskclock.debug version 2.12_beta-debug from 17add5c501f5a8410d9df141d7d634fb Clock_2.12_beta-debug.apk.
I tested around and did not observe the unexpected behaviour.

For a crosscheck:

I installed com.best.deskclock version 2.10.1 again (in addition to com.best.deskclock.debug).
Tested around and unexpectedly did not observe the unexpected behaviour.

Still on the same version of GrapheneOS; not even rebooted, phone's uptime is 125 days.
I'm a bit lost now, looks like something has changed. I don't know how alarms are handled by Android. Maybe some list of alarms got cleaned out, allowing for a faster (thus fast enough) re-scheduling? Does com.best.deskclock.debug have an influence on the alarms of com.best.deskclock?
Since I currently can't reproduce the unexpected behaviour anyway, my plan is to no longer refrain from making changes to the "test environment" but to move forward:

uninstall com.best.deskclock.debug,
uninstall com.best.deskclock,
update the operating system software,
restore com.best.deskclock from backup,
upgrade com.best.deskclock to 2.10.1,
observe for unexpected behaviour.

If we're lucky, the unexpected behaviour occurs again...

@mcg-android
There is no influence on alarm state between the two applications.
The only influence is that when an alarm is set in one application, it appears in the other. This is because alarms are stored in the "Android system".
That's why I only made a small modification to the "AlarmStateManager" file on the beta version I provided you with, deleting some unnecessary code.
FYI: A new release is available (version 2.11) and I'll publish my change soon.


Undefined is not an object

Im trying to use this, but I have absolutely no idea what causes the prop to be undefined. Here is the stack trace.
12-11 23:55:07.601 14408 14500 E ReactNativeJS: TypeError: undefined is not an object (evaluating 'Component.__propTypesSecretDontUseThesePlease')
12-11 23:55:07.601 14408 14500 E ReactNativeJS:
12-11 23:55:07.601 14408 14500 E ReactNativeJS: This error is located at:
12-11 23:55:07.601 14408 14500 E ReactNativeJS:     in Sae (at App.js:24)
12-11 23:55:07.601 14408 14500 E ReactNativeJS:     in RCTView (at View.js:112)
12-11 23:55:07.601 14408 14500 E ReactNativeJS:     in View (at App.js:19)
12-11 23:55:07.601 14408 14500 E ReactNativeJS:     in SignIn (at SceneView.js:31)
12-11 23:55:07.601 14408 14500 E ReactNativeJS:     in SceneView (at CardStack.js:394)
12-11 23:55:07.601 14408 14500 E ReactNativeJS:     in RCTView (at View.js:112)
12-11 23:55:07.601 14408 14500 E ReactNativeJS:     in View (at CardStack.js:393)
12-11 23:55:07.601 14408 14500 E ReactNativeJS:     in RCTView (at View.js:112)
12-11 23:55:07.601 14408 14500 E ReactNativeJS:     in View (at CardStack.js:392)
12-11 23:55:07.601 14408 14500 E ReactNativeJS:     in RCTView (at View.js:112)
12-11 23:55:07.601 14408 14500 E ReactNativeJS:     in View (at createAnimatedComponent.js:134)
12-11 23:55:07.601 14408 14500 E ReactNativeJS:     in AnimatedComponent (at Card.js:26)
12-11 23:55:07.601 14408 14500 E ReactNativeJS:     in Card (at PointerEventsContainer.js:55)
12-11 23:55:07.601 14408 14500 E ReactNativeJS:     in Container (at CardStack.js:436)
12-11 23:55:07.601 14408 14500 E ReactNativeJS:     in RCTView (at View.js:112)
12-11 23:55:07.601 14408 14500 E ReactNativeJS:     in View (at CardStack.js:365)
12-11 23:55:07.601 14408 14500 E ReactNativeJS:     in RCTView (at View.js:112)
12-11 23:55:07.601 14408 14500 E ReactNativeJS:     in View (at CardStack.js:364)
12-11 23:55:07.601 14408 14500 E ReactNativeJS:     in CardStack (at CardStackTransitioner.js:97)
12-11 23:55:07.601 14408 14500 E ReactNativeJS:     in RCTView (at View.js:112)
12-11 23:55:07.601 14408 14500 E ReactNativeJS:     in View (at Transitioner.js:187)
12-11 23:55:07.601 14408 14500 E ReactNativeJS:     in Transitioner (at CardStackTransitioner.js:49)
12-11 23:55:07.601 14408 14500 E ReactNativeJS:     in CardStackTransitioner (at StackNavigator.js:60)
12-11 23:55:07.601 14408 14500 E ReactNativeJS:     in Unknown (at createNavigator.js:52)
12-11 23:55:07.601 14408 14500 E ReactNativeJS:     in Navigator (at createNavigationContainer.js:216)
12-11 23:55:07.601 14408 14500 E ReactNativeJS:     in NavigationContainer (at renderApplication.js:35)
12-11 23:55:07.601 14408 14500 E ReactNativeJS:     in RCTView (at View.js:112)
12-11 23:55:07.601 14408 14500 E ReactNativeJS:     in View (at AppContainer.js:102)
12-11 23:55:07.601 14408 14500 E ReactNativeJS:     in RCTView (at View.js:112)
12-11 23:55:07.601 14408 14500 E ReactNativeJS:     in View (at AppContainer.js:122)
12-11 23:55:07.601 14408 14500 E ReactNativeJS:     in AppContainer (at renderApplication.js:34)

I'm glad you figured it out @Jta26.


No easy way of importing the StarknetMessaging Interface

It's now easy to deploy a StarknetMessaging contract with .spawnVersion(). Great idea!
However, if one wants to interact with it in his own contract (example using sendMessageToL2), then one needs to import the MockStarknetMessaging.sol.
But importing this one implies import a whole bunch of other dependencies.
I'm not sure exactly what is the strict minimum of function that are use from the MockStarknetMessaging.sol contract but it might bebeneficial to have a lean interface for it :)

This part is confusing me:

It's now easy to deploy a StarknetMessaging contract with .spawnVersion(). Great idea!

Are you referring to the spawnVersion method of Devnet from starknet-devnet-js? If so, that one is for spawning Devnet, not deploying a StarknetMessaging contract. Unless you are spawning a Devnet that loads a dumped instance with a previously deployed messaging contract.

Contract dependenc summary

MockStarknetMessaging (defined in MockStarknetMessaging.sol) is an instance of StarknetMessaging (defined in StarknetMessaging.sol).
StarknetMessaging is IStarknetMessaging (defined in IStarknetMessaging.sol) and uses methods of NamedStorage (defined in NamedStorage.sol).
IStarknetMessaging is IStarknetMessagingEvents (defined in IStarknetMessagingEvents.sol)

Simplification proposal
Copied from Discord:

What I had in mind is replicated this cairo storage values into solidity for the mock messaging contract: https://github.com/keep-starknet-strange/piltover/blob/a9c015eada5082076185a7b1413163a3da247009/src/messaging/component.cairo#L58.

And here we extracted only the required interface traits to actually work: https://github.com/keep-starknet-strange/piltover/blob/a9c015eada5082076185a7b1413163a3da247009/src/messaging/interface.cairo#L10.

So mapping this to a solidity code should make the mock way simpler that using the actual inheritance of the Starknet contract.

Hey @pscott I can't understand the following

However, if one wants to interact with it in his own contract

Do you mean that you have a solidity contract and you want to invoke methods of MockStarknetMessaging contract.

This part is confusing me:

It's now easy to deploy a StarknetMessaging contract with .spawnVersion(). Great idea!

Are you referring to the spawnVersion method of Devnet from starknet-devnet-js? If so, that one is for spawning Devnet, not deploying a StarknetMessaging contract. ~Unless you are spawning a Devnet that loads a dumped instance with a previously deployed messaging contract.~

My bad, I wanted to write .loadL1MessagingContract(network) function, not the spawnVersion.

Contract dependency summary

MockStarknetMessaging (defined in MockStarknetMessaging.sol) is an instance of StarknetMessaging (defined in StarknetMessaging.sol).
StarknetMessaging is IStarknetMessaging (defined in IStarknetMessaging.sol) and uses methods of NamedStorage (defined in NamedStorage.sol).
IStarknetMessaging is IStarknetMessagingEvents (defined in IStarknetMessagingEvents.sol)

Simplification proposal
Copied from Discord:

What I had in mind is replicated this cairo storage values into solidity for the mock messaging contract: https://github.com/keep-starknet-strange/piltover/blob/a9c015eada5082076185a7b1413163a3da247009/src/messaging/component.cairo#L58.

And here we extracted only the required interface traits to actually work: https://github.com/keep-starknet-strange/piltover/blob/a9c015eada5082076185a7b1413163a3da247009/src/messaging/interface.cairo#L10.

So mapping this to a solidity code should make the mock way simpler that using the actual inheritance of the Starknet contract.

This would work, or maybe just creating a single file that takes all the external function of:

MockStarknetMessaging
StarknetMessaging
IStarknetMessaging
IStarknetMessagingEvents

By having everything in a single file, it would make interacting with the contract much easier (though I agree it would be a messy file ...)

Hey @pscott I can't understand the following

However, if one wants to interact with it in his own contract

Do you mean that you have a solidity contract and you want to invoke methods of MockStarknetMessaging contract?

Yes this is exactly what I was referring to. Interacting with the MockStarknetMessaging contract requires me to copy paste a whole bunch of other files.

What I can suggest is using IStarknetMessaging interface. When you want to call methods of the messaging contract you can just do IStarknetMessaging(messaging_contract_address).sendMessageToL2

What I can suggest is using IStarknetMessaging interface. When you want to call methods of the messaging contract you can just do IStarknetMessaging(messaging_contract_address).sendMessageToL2

I believe the issue is if I wish to write IStarknetMessaging(messaging_contract_address), I need to first have imported the file.
So I write import "./IStarknetMessaging.sol";.
But since this file starts with
import "./IStarknetMessagingEvents.sol";, I also need to copy the file IStarknetMessagingEvents.sol. So I still need to copy two different files. This clobbers up my repo.
What would be nice is to have a simple, lean, interface file, that one can import and that has all the functions available to interact with the messaging contract

Then you can omit IStarknetMessagingEvents.sol from IStarknetMessaging.sol and you will have 1 file.

In which case I also need to remove is IStarknetMessagingEvent.
I feel like to a beginner, touching the code of a copied file might no be intuitive. I think providing the interface somewhere and say "hey, just copy this and you'll be fine" would be more convenient :D


<EMAIL_ADDRESS>hash check failed

The update command tells me it's going to update to 2.10.24-3, but in fact it is trying to download version 2.10.28. See output below:
C:\Users\me>sudo scoop update -g *
gimp: 2.10.20-1 -> 2.10.24-3 (global)
Updating 1 outdated app:
Updating 'gimp' (2.10.20-1 -> 2.10.24-3)
Downloading new version
gimp-2.10.28-setup.exe (238,1 MB) [===================================================================================================================================================================================================================] 100%
Checking hash of gimp-2.10.28-setup.exe ... ERROR Hash check failed!
App:         extras/gimp
URL:         https://download.gimp.org/mirror/pub/gimp/v2.10/windows/gimp-2.10.28-setup.exe
First bytes: 4D 5A 50 00 02 00 00 00
Expected:    5e9eabe5739523a9fc347b4614d919418f3335e7aab082a65f71705421e85e04
Actual:      2c2e081ce541682be1abdd8bc6df13768ad9482d68000b4a7a60c764d6cec74e

Sorry, just noticed this is a duplicate of #7235


[Bug]: submitting ratings for some papers leads to infinite loading screen

URL of the Page
https://postreview-app.herokuapp.com/articles/2fe810b8-9d30-42a3-9c3e-682e3213e7e8
What happened?
Submitting review for two papers below (only possible with one click due to 400 error thing) leads to an infinite loading.
https://postreview-app.herokuapp.com/articles/2fe810b8-9d30-42a3-9c3e-682e3213e7e8
https://postreview-app.herokuapp.com/articles/b7c3c3ee-26ca-4d34-a4cd-d123acc65d3f
Steps to reproduce

click on the paper
click once on any of the ratings
click submit

What browsers are you seeing the problem on?
Chrome
Code of Conduct

[X] I agree to follow this project's Code of Conduct

I think the cause of this issue can be (a) we are not catching empty/partial ratings, or (b) we are not successfully updating the ratings. Will investigate.

Do we want to let users upload incomplete ratings in the first place? I'm thinking probably yes - especially if we plan to introduce other questions in the future (this would mean that old reviews will get an empty field retrospectively). Perhaps the better solution here would be to allow incomplete ratings and start thinking about how those should be visually displayed? (e.g. grayed out star)

@nsunami will make the mock-up. Do you want me to create a separate issue or continue through #94?

How about this mock-up? The big start for the paper card and the small stars for the rating card just being gray is a little confusing because it might mean that there are no ratings or that all the ratings so far have been zero. To distinguish the two I've also added a "N/A" label in the center of the big start, while I removed the stars entirely in the rating card case and replaced them with "N/A". Curious to hear your thoughts on whether N/A is the appropriate label in these cases and whether you think removing small starts is the way to go to make it the least confusing.

Thanks. Let's go with this design for now. This is a separate issue. I'm closing this for now, let's continue our thread on #95.


training with RGB detections?

Hi, I looked up your code and I notice that you only use RGB detection result for validation. But there is a 'rgb_detection_train.txt' file, which is clearly for training. So could you release the code of generating that file or you do already have released only I did't find it?

Hi @LoFaiTh
That file includes detection results on the training set (yes, we finetuned our 2D detector on the train set). it's not currently used for frustum pointnets training, but could be useful for 3D evaluation on the train set, or other (future) uses to tune the frustum pointnets.
unfortunately we cannot publish the 2D detector part, you can refer to the paper supplementary (https://arxiv.org/abs/1711.08488) for architecture details.


Test packer disconnect config

/test-integration-metal3-dev-tools-centos
//test-integration-metal3-dev-tools-ubuntu

/test-integration-metal3-dev-tools-ubuntu

/test-integration-metal3-dev-tools-ubuntu
/test-integration-metal3-dev-tools-centos

The network issues we're having are not packer issues nor solvable in packer. While we may be able to fix a build sometimes, I don't think this is worth the effort.

The network issues we're having are not packer issues nor solvable in packer. While we may be able to fix a build sometimes, I don't think this is worth the effort.

Agree.

/close


cursorActivity fires on setSelection(-s), origin unclear

Is there a way to find out whether a selection or cursor move was triggered by the user vs. set programmatically?
a) I don't see an .origin on the .ranges object in "beforeSelectionChange" which would help ignore the event
b) Similarly there is no indication of .origin in "cursorActivity"

It fires on every selection change, by design. And cursorActivity is batched by operation, and thus not associated with a specific selection change, so it couldn't pass an origin.
Attached patch passes beforeSelectionChange events an origin field. I'm not sure how useful this will be, since origins aren't always passed to selection changes, but it might help.

Thank you @marijnh !!


Constant jail bug

config.yalm
loop-timeout: 5s
health-check-port: 5757

paloma:
  chain-id: paloma-testnet-10
  call-timeout: 20s
  keyring-dir: ~/.paloma
  keyring-pass-env-name: PALOMA_KEYRING_PASS
  keyring-type: os
  signing-key: ${VALIDATOR}
  base-rpc-url: http://localhost:27657
  gas-adjustment: 1.5
  gas-prices: 0.001ugrain
  account-prefix: paloma

evm:
  eth-main:
    chain-id: 1
    base-rpc-url: https://mainnet.infura.io/v3/bc855d0d365342f38c26921f4974f5ac
    keyring-pass-env-name: ETH_PASSWORD
    signing-key: ${ETH_SIGNING_KEY}
    keyring-dir: ~/.pigeon/keys/evm/eth-main

  bsc-main:
    chain-id: 56
    base-rpc-url: https://bsc-mainnet.gateway.pokt.network/v1/lb/6331f8435bbcf1003b4615d7
    keyring-pass-env-name: "BSC_PASSWORD"
    signing-key: ${BSC_SIGNING_KEY}
    keyring-dir: ~/.pigeon/keys/evm/bsc-main
    gas-adjustment: 1.2

**env.sh**

export PALOMA_KEYRING_PASS=Ataman51
export ETH_RPC_URL=https://mainnet.infura.io/v3/bc855d0d365342f38c26921f4974f5ac
export ETH_PASSWORD=Ataman51
export ETH_SIGNING_KEY=9d5dbf17ed3597fff2a4ab4f4e620f918fe4c372
export VALIDATOR=SECARD
export PIGEON_HEALTHCHECK_PORT=5757
export BSC_SIGNING_KEY=9d5dbf17ed3597fff2a4ab4f4e620f918fe4c372
export BSC_PASSWORD=Ataman51
export BSC_RPC_URL=https://bsc-mainnet.gateway.pokt.network/v1/lb/6331f8435bbcf1003b4615d7

@secard51 will you gist the output of the logs instead of this picture, please?

Are you running a pigeon? The reason for jailing is: reason: validator's pigeon has been inactive.
(palomad q valset get-validator-jail-reason palomavaloper16lez38lgsgu34ka2gq8yee8a862zpgs4vmrksr)

I ran it on system, and added periodic restart to system, problem seems to be solved for now


Add cleanup logic to S3BucketVerticleTest

There is a test.jpx that's created at line 78 in the LoadImageHandlerTest. This PR title says "S3BucketVerticleTest" but the Jira ticket is more general: "Have bucketeer clean up test S3 files that it creates." I think this PR needs the same thing done to the LoadImageHandlerTest so that it's not leaving stray files around.

confirmed with a manual check of our test bucket that no test files are left behind after running mvn test


hubNetworking: Make examples working with WhatIf mode

Overview/Summary
Solving multiple issues with WhatIf mode in Hub Networking.
This PR fixes/adds/changes/removes
Related to hub networking part of #249
However WhatIf test cannot be yet enabled to CI because Microsoft.Network/virtualNetworkGateways does report that it would remove properties.remoteVirtualNetworkPeerings and Microsoft.Network/virtualNetworks reports that it would remove  properties.virtualNetworkPeerings both of those are just noise https://github.com/Azure/arm-template-whatif/issues/233
Breaking Changes
N/A
Testing Evidence
Not yet...
As part of this Pull Request I have

[x] Read the Contribution Guide and ensured this PR is compliant with the guide
[ ] Ensured the resource API versions in .bicep file/s I am adding/editing are using the latest API version possible
[x] Checked for duplicate Pull Requests
[x] Associated it with relevant GitHub Issues
[ ] (ALZ Bicep Core Team Only) Associated it with relevant ADO Items
[ ] Ensured my code/branch is up-to-date with the latest changes in the main branch
[ ] Performed testing and provided evidence.
[ ] Updated one or more of the following tests (if required)

Unit
Linting
E2E (End-To-End)
ValidateAzCloud (Base validation in Azure Cloud)
ValidateMcCloud (Base validation in Azure China Cloud)

[ ] Updated relevant and associated documentation (e.g. Contribution Guide, Module READMEs, Wiki Docs etc.)
[ ] If relevant, created or updated Code Tours here

Looks that version of #252 which finally got merged didn't have conflicts with this one so I rebased it it main branch. However now there looks to be new PR #306 which touches same area.

@jtracey93 I can see that #306 was merged so I updated this one. Can you take first look if this something which can be included here? (assuming that it passes tests and readme is updated).

ping @jtracey93

Is this just laying around? There are multiple issues with hub-spoke peering reported here here that would be fixed by this PR @jtracey93

@Strandfelt as far I understand the challenge is that it is unclear inside of Microsoft that who/where those challenges should be fixed? Options are Azure API's, API clients like Bicep and actual client applications like this repository. And because this PR was not approved, I don't expect to see this solved anytime soon.
If we can find couple of persons who are interested enough about topic, it would be possible quite easily to build custom WhatIf tester which can handle those bugs in API. I once started to build that kind of in https://github.com/olljanat/alz-bicep-ci/blob/ps-whatif/PSAzureAPI/PSAzureAPI.psm1

Closing as stale


⚠ Bofrost.at has degraded performance

In 4662aa7, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 3165 ms

Resolved: Bofrost.at performance has improved in e22dad1.


Language example consists of just a block of comment(s)

I generally would suggest removing all kinds of comments from the shown example pieces, as they typically confuse more than they help.

I would simply take a set of syntax rules defined for every language, and filter out these blocks from any code example.

Another method I can think of, since there's only 1-2 themes we're using, is checking if the start of a line is highlighted with the specific color that comments are highlighted with, and if so, removing them. This would be more maintainable and easier because we wouldn't have to create overrides for every language, although could end up being less maintainable if sometime in the future we introduce a feature to let people customize themes. That crate is something to take note of though, thanks for sharing it :)

Another method I can think of, since there's only 1-2 themes we're using, is checking if the start of a line is highlighted with the specific color that comments are highlighted with, and if so, removing them. This would be more maintainable and easier because we wouldn't have to create overrides for every language, although could end up being less maintainable if sometime in the future we introduce a feature to let people customize themes. That crate is something to take note of though, thanks for sharing it :)

I would put the color-based comment highlighter behind a (maybe default) feature, as it is a rather good idea for the time being.

By "feature", do you mean a cargo feature? If you think it should be optional, wouldn't it be better to use a CLI flag since you can change it per-game?

By "feature", do you mean a cargo feature? If you think it should be optional, wouldn't it be better to use a CLI flag since you can change it per-game?

Sorry yes, should've said flag not feature

Using line.starts_with("\u{1b}[38;2;117;113;94m") I can consistently detect whether the line is a comment for all languages. Refactoring the state to pass around highlighted lines might take some work though.

How about filtering the comment lines before returning the string content.
https://github.com/Lioness100/guess-that-lang/blob/4efb6ce2be468c2d8af28943fc273d5866d879fd/src/github.rs#L156-L165

I think it should be filtered out in trim_text, because that function also limits the code to 10 non-empty lines, and it would be needlessly expensive to highlight and filter 100 lines of code when you get the gist if you're only taking 10 of them anyways.

I decided not to add a CLI flag and just make it mandatory.


I added few more block-level and inline elements

I added few more block-level and inline elements like, ,,,,

Thank you for opening this pull request.
This is a standard message notifying you that we’ve reviewed your pull request and have decided not to merge it. We would welcome future pull requests from you.
Thank you and happy coding.


Add campaign rank retrieval to locking API

Summary
We want to show the rank of a particular address per campaign. This adds the correct mapping to the locking API according to the Locking Service:
GET /api/v1/campaigns/:campaignId/leaderboard/:safeAddress
Changes

Add ILockingApi['getCampaignRank']
Add associated tests

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

5 of 5 (100.0%)  changed or added relevant lines in 1 file are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.09%) to 92.819%

Files with Coverage Reduction
New Missed Lines
%

src/routes/transactions/entities/tests/human-description.builder.ts
3
60.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.09%

Covered Lines:
7115

Relevant Lines:
7371

💛  - Coveralls


"Ghost" footsteps

Sometimes you hear other player's footsteps.
I need to check if this is something I can fix.

I noticed that sometimes I would see a client's walking particles, even when they weren't there.

With the walking particles, I notice that in the Mines, no matter what floor another player is on, you can see their walking particles, or them if they are at a coordinate that happens to be accessible in the floor you are on.  Dropping items/etc does not communicate across floors, only the farmer sprite itself.
The footstep sounds seem to always originate from the current player's sprite, no matter which player's footsteps they are.  Perhaps this could be avoided by not sending movement updates if you are not on the same map, but I'm not sure if it's worth the trouble or not.  Notably, people annoyed by this can lower 'Footsteps Volume' in options, which applies to all players' footsteps.


Introduce isApproved flag in broadcats model. Refactor the resource form so that a new broadcast gets created on successful submission

Refactoring the resource form as per the proposed style.
this issue is part of issue #976
Introduce isApproved flag in broadcats model. Refactor the resource form so that a new broadcast gets created on successful submission, with isApproved set to false.
Have you read the Code of Conduct?
Write your answer here.
yes

@shivamgaur99 flag will get introduced under https://github.com/HITK-TECH-Community/Community-Website/issues/1016, you please focus on resource form refactoring

upgrading the issue level as the changes required is more than expected


chore: run cfn lint on test output

Description of changes:
Runs CFN lint on the output files of the tests to make sure that they are valid CFN syntax.
Also fixes a parameter in Serverless::Application from NotificationArns->NotificationARNs. This was previously broken and was a bug.
Description of how you validated changes:
Tests run and pass.
Checklist:

[x] Write/update tests
[x] make pr passes
[x] Update documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Reviewers: look at the test_translator.py file under the tests directory and anything else not under the tests directory. All other things in the tests directory are changes forced by the changes to test_translator.py.

Codecov Report

Merging #888 into develop will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           develop     #888   +/-   ##
========================================
  Coverage    94.62%   94.62%
========================================
  Files           69       69
  Lines         2997     2997
  Branches       554      554
========================================
  Hits          2836     2836
  Misses          85       85
  Partials        76       76

Impacted Files
Coverage Δ

samtranslator/model/cloudformation.py
85.71% <ø> (ø)
:arrow_up:

samtranslator/model/sam_resources.py
95.5% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92decec...e674b56. Read the comment docs.


Maxouptutlength

Attempt to fix book build failure
The build failed with
The value of "options.maxOutputLength" is out of range. It must be >= 1 and <=<PHONE_NUMBER>. Received 0

even though it builds locally and in the preview. Not sure how to test if this will fix that without merging. Anyone have any insight into what is happening here?
Also confusing that it passes the build step in pages-build-deploy but fails build in publish.

https://github.com/ProjectPythia/projectpythia.github.io/actions/runs/9507448132

Seems to have resolved itself!


Fixed doc

There was a typo in the doc
was showTodayButton instead of todayButton

Thanks!

@martijnrusschen There is the same typo in the website. There is a bundle.js in gh-pages branch, but I'm not sure I should mess with it!

I guess the examples site hasn't been deployed yet. I'll trow a release
today that should update the site too. Thanks!
On do 28 apr. 2016 at 10:48 Dimitris Tsironis<EMAIL_ADDRESS>wrote:

@martijnrusschen https://github.com/martijnrusschen There is the same
typo in the website
http://hacker0x01.github.io/react-datepicker/#example-3. There is a
bundle.js in gh-pages branch, but I'm not sure I should mess with it!
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/Hacker0x01/react-datepicker/pull/450#issuecomment-215355505

No worries! Congrats on the library btw, awesome work.

Should be fixed now!


Fix cypress test failed due to OSD dashboard create button updated

Description
Fix cypress test failed due to OSD dashboard create button updated
Ref: https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3090
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #393 (61b19c3) into main (63d7232) will not change coverage.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@           Coverage Diff           @@
##             main     #393   +/-   ##
=======================================
  Coverage   41.36%   41.36%
=======================================
  Files          53       53
  Lines        1777     1777
  Branches      329      329
=======================================
  Hits          735      735
  Misses       1014     1014
  Partials       28       28

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Add SUTRA module in GEOPHIRES to import and process simulation results from SUTRA simulator

In this linkage, SUTRA is used for reservoir thermal energy storage simulations. GEOPHIRES imports results from stand-alone SUTRA simulation, and calculates annual heating injected, heating produced and auxiliary heating required. GEOPHIRES then estimates CAPEX, OPEX and LCOH. SUTRA simulator is developed by USGS: https://www.usgs.gov/software/sutra-a-model-2d-or-3d-saturated-unsaturated-variable-density-ground-water-flow-solute-or

Note: appears to have been closed in favor of https://github.com/NREL/python-geophires-x/pull/43


Add tracetools package using source

trying to retrigger travis

@tfoote Is it normal that the check is taking so long?

It looks like this has been flagged as an abuse by travis (https://travis-ci.org/ros/rosdistro/requests).
@tfoote I see that you "cleared" the account in #15650, can we do the same here ?

I've requested to clear the abuse flag with Travis Support

All changes are flagged as an abuse by Travis CI. Does anybody have an idea what could cause that?

It looks like your user and organization never logged into travis so they flagged it as abusive automatically. Is it possible for you to login into travis and then push an empty commit in here ? That should solve the issue.
Otherwise, can you contact travis support<EMAIL_ADDRESS>to get your account/organization cleared ?


Environment for Matchfile

Question Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Question Subject
Is that possible to use environment variables for Matchfile?
Question Description
I run comman fastlane match --env Name and getting:
[✔] 🚀
invalid option: --env

But when I change ENV with actual values and run fastlane match everything goes well.
Matchfile:
git_url ENV['GIT_URL']
app_identifier ENV['ALL_BUNDLE_IDENTIFIERS']
username ENV['USERNAME']

.env.Name:
GIT_URL = "rep url"
USERNAME =<EMAIL_ADDRESS>ALL_BUNDLE_IDENTIFIERS = ["first", "second"]

It's very possible that --env is only implemented for lanes and the main fastlane command, not fastlane match, fastlane cert etc.: https://docs.fastlane.tools/advanced/other/#environment-variables
That means you could probably work around that by using the match action instead of the fastlane match CLI command (if that has all the functionality you want to use).


Doen't seem to detect Original Key and Edition on all PCs

On a Dell desktop that had Windows 7 on it and now runs Windows 10 1511, ShowKeyPlus says OEM Key: Windows 7 OEM marker present in firmware and correctly shows me the Original Key and Original Edition.
However on an Acer laptop that also had Windows 7 on it and now runs Windows 10 1607, ShowKeyPlus says OEM Key: Windows 7 OEM marker present in firmware but does not show me either the Original Key or the Original Edition.
Why is this? Is it because the desktop was upgraded from Windows 7 to 10 (using the 1511 ISO), but the laptop was formatted and had Windows 10 clean installed on it (also using the 1511 ISO but then updated to 1607 via Windows Update)?

Yes, that is correct. A clean install erases all traces of the original key. An upgrade stores the previous key in the new registry as well as retaining it in the old (Windows.old)
Thanx, I appreciate your feedback.
Cheers.

Thanks for the explanation. So since Windows 8 onwards there are no more stickers with keys on them and the keys are stored in the BIOS, does that mean that even with a clean install of Windows 10 on a Windows 8/8.1 system ShowKeyPlus will be able to successfully display the Original Key and Original Edition?

Kindof... The Win 8 OEM key will be the 'original' key and it's edition will be displayed there... in ShowKeyPlus land, original means previously installed.
We have seen downgraded Win 8 to Win 7 PC's still having the Win 8 OEM key in the firmware.... so in a way that was the original key...

Got it. Closing this issue now but will continue to monitor the other one I opened. Thanks.


Checks if username exists on sign-up flow

Added method to UserController that checks database whether username is taken; added route to AppConfig
Fixed issue at https://github.com/keepid/keepid_server/issues/36

Codecov Report

Merging #37 into master will increase coverage by 1.02%.
The diff coverage is 13.33%.

@@             Coverage Diff              @@
##             master      #37      +/-   ##
============================================
+ Coverage     46.17%   47.20%   +1.02%
- Complexity      286      294       +8
============================================
  Files            35       35
  Lines          2224     2360     +136
  Branches        243      264      +21
============================================
+ Hits           1027     1114      +87
- Misses         1089     1132      +43
- Partials        108      114       +6

Impacted Files
Coverage Δ
Complexity Δ

src/main/User/UserController.java
30.46% <7.14%> (+6.09%)
12.00 <0.00> (+3.00)

src/main/Config/AppConfig.java
88.18% <100.00%> (+0.08%)
10.00 <0.00> (+3.00)

src/main/Security/SecurityUtils.java
82.60% <0.00%> (+7.24%)
6.00% <0.00%> (+1.00%)

src/main/User/UserType.java
83.33% <0.00%> (+8.33%)
5.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe6b85b...15d7414. Read the comment docs.

@vanessa-hu if you transfer this into a Service class, and add a test, we can merge/close this issue :)

What is the status of this PR?


Support for multi-line .env files

In several projects I encounter environment variables that span several lines. This is not a problem for Docker or other software, but VS Code currently does not support .env variables across multiple lines.
So for example:
MY_ENV_VAR='{
"key":  "value"
}'
Is not supported. This is quite annoying for development.

We plan to use the dotenv syntax long term https://github.com/microsoft/vscode-python/issues/20003, and given it supports this scenario it should be addressed with it. Closing in favor of  https://github.com/microsoft/vscode-python/issues/20003.


mouse cursor get shifted when enabling wayland support

VS Code Version:code-insider 1.56.0
OS Version:Arch Linux with latest updates

Steps to Reproduce:
1.Enable fractional scaling in Gnome(not sure if it works when fractional scaling is disabled)
2.Launch code-insiders with commandline:
code-insiders --enable-features=UseOzonePlatform --ozone-platform=wayland
3.Maximize the window
In my case my cursor could only go this far rightwards

and when I opened the second tab the rightest position my cursor could go is here

For reference, the normal behavior on my system is

What's interesting is that switching to another window restores it to the first status(though still abnormal)

Does this issue occur when all extensions are disabled?: Yes

Btw sometimes the UI elements(like the scrollbar and some button) are located lefter than they are displayed(meaning that I must move my cursor to a button's left side to interact with it)

This sometimes happens even without fraction scaling for me.

I have somewhat similar issue (I don't know if it's the same or not). Sometimes (not always) when I click to position the text cursor or to select some text, the real click happens in some offset from the mouse cursor, so I miss the place where I wanted to position the text cursor. This offset may have both vertical and horizontal components, so the text cursor may be placed one line higher and one character to the left from where the mouse cursor was positioned at the moment of click.
I use Fedora 34 and start vscode with ozone wayland.

Here's the video illustrating the issue:
https://user-images.githubusercontent.com/4847726/123281134-f312b700-d4f8-11eb-9123-71b23a2a3f00.mp4

I am seeing a similar issue on Windows 10, where the mouse interaction location gets offset from the actual mouse location. This behavior is accompanied by a black bar on the left hand side of the window. For me, this happens when I leave a window with an open folder focused for a while (hours). Here is a screenshot (the mouse was held over "Go", but you can see that the menu item "Terminal" is going to be selected if the mouse is clicked):

I have not enabled wayland. I am on version 1.57.1. Is what I am seeing a different issue, or could these be related?

AFAIK, wayland is a linux only protocol. Are you running VSCode through WSL?

No.  I use WSL, but VSCode is not running through WSL.  I suppose my issue must be different, then. In that case, it's strange that these two separate issues both lead to a mouse offset.

I suppose this is an Electron issue? I couldn't find anything in the Electron issue tracker though. Anyone got any idea what's going on? Does Chrome/Chromium 89 (which Electron 12 is based on) have similar issues under Wayland?

I also experience the big scaled cursor using Wayland and KDE Plasma 5.22.5. Additional drop down menus are only partially displayed.
Interestingly the cursor reverts to its normal size when clicking these menus (but still not using the system cursor)

Same problem confirmed on ubuntu 20 wayland,


Make selected Dayview's highlighted color shape square instead of rounded

I want to make selected dayview's highlighted color shape square instead of rounded.
Please help me to sort it out.

Okay, Solved it.
CVShape.swift file is helpful for changing diffrent shapes.
Anyway, Thanks


Possible man in the middle attack

The display was sayning that
The Bitcoind service in not runnig
sos when I tried loggin in to my Raspiblitz today I got this:
apples-MacBook-Pro:~ apple$ ssh<EMAIL_ADDRESS>@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
@    WARNING: REMOTE HOST IDENTIFICATION HAS CHANGED!
Someone could be eavesdropping on you right now (man-in-the-middle attack)!
It is also possible that a host key has just been changed.
The fingerprint for the ECDSA key sent by the remote host is
SHA256:cJgOIKguMNW3Rh6cGcFW20XGswnFF0i0VZur0SNd45Q.
Please contact your system administrator.
Add correct host key in /Users/apple/.ssh/known_hosts to get rid of this message.
Offending ECDSA key in /Users/apple/.ssh/known_hosts:1
ECDSA host key for <IP_ADDRESS> has changed and you have requested strict checking.
Host key verification failed.
apples-MacBook-Pro:~ apple$

See FAQ foe the beginnung: https://github.com/rootzoll/raspiblitz/blob/master/FAQ.md#what-to-do-when-on-ssh-i-see-warning-remote-host-identification-has-changed
If you can login again - check why bitcoind is not running and send debug report:
https://github.com/rootzoll/raspiblitz/blob/master/FAQ.md#how-do-i-generate-a-debug-report

pls close this.


TypeError: '>=' not supported between instances of 'AssertionError' and 'int'

(/home/MimicTalk/venv) [root@aiclip-dfl2 MimicTalk]# **python data_gen/utils/process_video/extract_segment_imgs.py --ds_name=nerf --vid_dir=data/raw/videos/VIDEO_003_cropped_25fps.mp4**
2024-11-29 20:08:29.274455: E external/local_xla/xla/stream_executor/cuda/cuda_fft.cc:477] Unable to register cuFFT factory: Attempting to register factory for plugin cuFFT when one has already been registered
WARNING: All log messages before absl::InitializeLog() is called are written to STDERR
E0000 00:00:1732928909.309845  157782 cuda_dnn.cc:8310] Unable to register cuDNN factory: Attempting to register factory for plugin cuDNN when one has already been registered
E0000 00:00:1732928909.320264  157782 cuda_blas.cc:1418] Unable to register cuBLAS factory: Attempting to register factory for plugin cuBLAS when one has already been registered
todo videos number: 1
WARNING: All log messages before absl::InitializeLog() is called are written to STDERR
I0000 00:00:1732928912.743135  157782 gl_context_egl.cc:85] Successfully initialized EGL. Major : 1 Minor: 5
I0000 00:00:1732928912.856416  157894 gl_context.cc:357] GL version: 3.2 (OpenGL ES 3.2 NVIDIA 565.57.01), renderer: NVIDIA RTX A4000/PCIe/SSE2
INFO: Created TensorFlow Lite XNNPACK delegate for CPU.
W0000 00:00:1732928912.913155  157910 inference_feedback_manager.cc:114] Feedback manager requires a model with a single signature inference. Disabling support for feedback tensors.
/home/MimicTalk/venv/lib/python3.9/site-packages/mediapipe/tasks/python/vision/image_segmenter.py:158: UserWarning: MessageFactory class is deprecated. Please use GetMessageClass() instead of MessageFactory.GetPrototype. MessageFactory class will be removed after 2024.
  graph_config = self._runner.get_graph_config()
| Extracting Segmaps && Saving...
generating segment images in single-process...: 0it [00:00, ?it/s]
| Extracted Segmaps Done.
| Extracting background...
<class 'AssertionError'>
Traceback (most recent call last):
  File "/home/MimicTalk/data_gen/utils/process_video/extract_segment_imgs.py", line 365, in extract_segment_job
    bg_img = extract_background(img_lst, segmap_mask_lst, method=background_method, device=device, mix_bg=mix_bg)
  File "/home/MimicTalk/data_gen/utils/process_video/extract_segment_imgs.py", line 78, in extract_background
    assert len(img_lst) > 0
AssertionError

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/MimicTalk/data_gen/utils/process_video/extract_segment_imgs.py", line 495, in <module>
    extract_job(*fn_args[0])
  File "/home/MimicTalk/data_gen/utils/process_video/extract_segment_imgs.py", line 388, in extract_segment_job
    traceback.print_exc(e)
  File "/home/MimicTalk/venv/lib/python3.9/traceback.py", line 163, in print_exc
    print_exception(*sys.exc_info(), limit=limit, file=file, chain=chain)
  File "/home/MimicTalk/venv/lib/python3.9/traceback.py", line 103, in print_exception
    for line in TracebackException(
  File "/home/MimicTalk/venv/lib/python3.9/traceback.py", line 517, in __init__
    self.stack = StackSummary.extract(
  File "/home/MimicTalk/venv/lib/python3.9/traceback.py", line 340, in extract
    if limit >= 0:
TypeError: '>=' not supported between instances of 'AssertionError' and 'int'

背景图片没有生成成功，可以检查一下你的bg_imgs这个目录有没有成功建立...


Error when connecting Azure Cloud Shell to tenant with domain joined device under conditional access policies

Environment
Windows build number: 10.0.19042.572
Windows Terminal version (if applicable): 1.3.2651.0

Steps to reproduce
Open Azure Cloud shell and attempt to connect with our Azure tenant
Pre-requisite
Our company uses Azure Conditional Access policies and require computers to be domain-joined devices in order to connect with our tenant without multi-factor.
Expected behavior
I would expect the cloud shell to connect once I completed the steps listed in the prompt (i.e. enter pin from device login web site)
https://devblogs.microsoft.com/commandline/the-azure-cloud-shell-connector-in-windows-terminal/
Actual behavior
I receive the following error:
AADSTS53001: Device is not in required device state: domain_joined. Conditional Access policy requires a domain joined device, and the device is not domain joined.
Trace ID: 24bab79e-1e96-4524-abd1-833c53a30d00
Correlation ID: ddbce269-f8ca-41e5-9d92-d9bb4d63320f
Timestamp: 2020-10-30 07:27:02Z
Additional notes
I've been made aware, that we've seen a similar error when using the Azure Storage Explorer.
https://feedback.azure.com/forums/217298-storage/suggestions/36283420-conditional-access-support-for-storage-explorer

Not an expert, but were you performing the Device Code Flow (entering device code into prompt)? Asking this because there is a known limitation in the Conditional Access, where it is not aware of the device state, as described here.

Yes, I believe this was what I was trying to do. I just opened the Azure Cloud Shell tab and wanted to authenticate using the flow suggested in the terminal.
What your suggesting is, that we should adjust our conditional access policies according to the above description? So I should be prompted for a multi-factor control when trying to connect through the Azure Cloud Shell?
I'll try and see if I'm able to test this and report back the results.

If it is OK with the security policies of your company, instead of requiring device state related conditions for the relevant apps, you can require user related conditions like MFA. An example can be found https://docs.microsoft.com/en-us/azure/active-directory/conditional-access/untrusted-networks.
Of course you can provide additional scoping of this policy to specific apps, users, etc.

Thanks. This is, as you astutely note, due to us using device login. We will almost certainly have to rearchitect how login works, but we're not equipped to do so.
I'm going to put this up on the backlog. Let me know if your conditional access policy change helps :smile:

@DHowett - it's more a feature than a bug. IMHO the device login flow is a good choice for terminal, as it is simple and interactive, though it has some limitations with specific Conditional Access requirements. I guess we simply need to add some addition way to authenticate for users that device login doesn't fit their needs (service principal?)

I was able to test this the other day and managed to get a successful verification using Azure Terminal with our tenant.
My IT-department couldn't tell me if they had changed anything. It appeared to just work out of the blue?! (which of course isn't true - something must have changed)
But I don't know whether a conditional Access rule was changed by IT or if something else changed.
Sorry I can't be of better help :-(

At least it works - which is great already!


Removed old testimonial as I can no longer recommend using the open s…

…ource version of Gigablast, and Matt Wells has stopped communicating with users.

Did you stop using gigablast?

We stopped using the original version 2 years ago, and I would not recommend anyone starting a new project using it.
We use a heavily modified version today, and are pretty much stuck with it. Had I known how many problems we would face, I would not have started a project based on Gigablast. Sorry.

I request that you respect my wish to have my testimonial removed from Github and gigablast.com.


Fixed flush issue with buffering print writers

This fixes #18

:+1:

:+1: This also seems to fix the issues I had with using Logbook in a jsp application.
Is it really required to call response.getWriter().flush() in LogbookFilter? I could imagine that could cause problems if the response is already committed. Per the spec you are also not supposed to call getWriter if getOutputStream was called before.

This also seems to fix the issues I had with using Logbook in a jsp application.

That was my hope.

Is it really required to call response.getWriter().flush() in LogbookFilter?

Excellent question. I was kind of puzzled as to why nobody was calling flush on the response ever. I placed a breakpoint on it and called flush manually and that worked. So I'm definitely missing one crucial piece of information here. Who is flushing/closing the response output stream under normal conditions?
I looked at Spring's ContentCachingResponseWrapper and it calles flush on the underlying stream on every write!
@Override
public void write(char buf[], int off, int len) {
    super.write(buf, off, len);
    super.flush();
}

@Override
public void write(String s, int off, int len) {
    super.write(s, off, len);
    super.flush();
}

@Override
public void write(int c) {
    super.write(c);
    super.flush();
}

Per the spec you are also not supposed to call getWriter if getOutputStream was called before.

Correct, but in thise case we are not calling those methods on anyone's response, but on our own class. And since we implemented the stream on top of the writer we can be sure it works either way.


responsive layout

Compatible with different heights and widths of layouts

minimal size:
only show image and right side scrollbar

implement on #36


Dashboard hides empty projects so it's hiding the ones just created

PR includes

[x] Bug Fix

Related issues
Resolve #1380
QA Instructions, Screenshots, Recordings


Dragging dates or objects with dates causes  to break

Due to serializing a date to JSON and deserializing it does not result in a Date object.  This causes angular to complain about models bound to <input type="date" />.
See plunker here

I've never used type=date, but it looks like it works with strings as well. If not you will need to do the conversions yourself, since you can't transfer Date objects with json.


Not able to add and remove scopes from a resource in a single API call.

Scenario/Intent
When I am trying to call patch_resource() implemented for PATCH: /rest/scopes/resources/** in API600, it does not take both add and remove operations simultaneously.
Environment Details

OneView SDK Version: [5.5.0]
OneView Appliance Version: [4.0]
OneView Client API Version: [API 600]
Ruby Version: [2.4.1]
Platform: [Ubuntu 16.04]

Steps to Reproduce
call resource_patch() from scope being implemented for PATCH: /rest/scopes/resources/** in API600.  See here
Expected Result
It should accept both add and remove scopes list.
Actual Result
we can perform one operation in a single call- either adding scopes or removing scopes from a resource

Fixed it and merged the code. So closing the issue


welcome - introduce dedicated top level folders

This PR fixes #140991
@JacksonKearl I pretty much prefixed anything we had with welcome to produce top level folders. The welcome/common thing we had became welcomeViews.
I also noticed that quite often .css files were mixed with .ts files and I have moved them into respective media folders.
@alexdima can you maybe push the change that is needed to remove the TODO@layer in .eslintrc.json?

@alexdima can you maybe push the change that is needed to remove the TODO@layer in .eslintrc.json?

Done.


Document configuration options (pdf export) for other editors

For example in helix you have to add this to the languages.toml:
[[language]]
name = "typst"
scope = "source.typst"
injection-regex = "^typ(st)?$"
file-types = ["typ"]
roots = []
comment-token = "//"
language-server = { command = "typst-lsp" }
config = { exportPdf = "onType"}

Should note specifically what can be passed as a config.
I was able to find this only by looking through https://github.com/nvarner/typst-lsp/blob/5887fe041ef0bdfa15f4a15c76e636ea6265d90a/addons/vscode/package.json#L22-L39
You can just add a reference to that file.

I was also trying to use the lsp in the helix editor, and while it recompiles just fine using the "onType" option, it doesn't if i choose the "onSave" option. Very weird

Yeah, It doesn't work manually with :lsp-workspace-command or on save, it complains about missing file URI, and helix only exposes the doPdfExport command and not the exportCurrentPdf command thats in the VScode extension, aiui??

I'm trying to use the lsp as well in helix, with the configuration mentioned in the opening comment and a cargo installed version of typst-lsp. I'm not getting syntax highlighting though, is that something that should be there?
My languages.toml:

a .typ file:

If I'm not mistaken you also need the grammar to have syntax highlighting. I've just installed that one, but haven't really tried it: https://github.com/frozolotl/tree-sitter-typst

@alxsimon Thank you so much! That worked perfectly. I'll note that I did have to copy over the queries directory as opposed to just symlinking, but the results look pretty good to me.


Removing git conflict markers from the start.sh script

Signed-off-by: Deepak R<EMAIL_ADDRESS>

Hi,
I was playing around with solr-bench and noticed a few conflict markers in the start script which caused problems when starting the script
I did not find the option to raise this as an issue nor found other means to communicate
So decided to raise a pull request with the changes that worked for me instead
Apart from removing the markers, I made sure the zookeeper version is consistent across the script (I found a mix of version 3.6.3 and 3.6.1.  Made sure it is the newer one 3.6.3 everywhere)
Please take a look
Thanks
DeepakR


iOS network connection type in background mode

Hi @katzer,
I love to know the connection type till the application in background mode.
I am using cordova-plugin-network-information for this:
function checkConnection() {
    var networkState = navigator.connection.type;

    var states = {};
    states[Connection.UNKNOWN] = 'Unknown connection';
    states[Connection.ETHERNET] = 'Ethernet connection';
    states[Connection.WIFI] = 'WiFi connection';
    states[Connection.CELL_2G] = 'Cell 2G connection';
    states[Connection.CELL_3G] = 'Cell 3G connection';
    states[Connection.CELL_4G] = 'Cell 4G connection';
    states[Connection.CELL] = 'Cell generic connection';
    states[Connection.NONE] = 'No network connection';

    return states[networkState];
};

var netInterval = setInterval(function() {
console.log(checkConnection());
}, 1000);
It's working at the foreground, but when the app goes to the background Its keep logout on the console the last connection type what was till the app was at the foreground.
for example, if the connection type is wifi when I am at the foreground and I go to the background and change the connection type to 4G or 3G, the console log keep saying: WIFI.....
(The background mode is enabled.)
Thank You :)

@Newlik Thats because some plugins try to optimise themselves in background. Hard/impossible to change that from outside.
Here is the "bad code line" in the network-info plugin.

Thank you!


Preffered Lighting Technology not working?

I have compared it a few times but I see no difference in anything. Lighting stays the same and I can't see anything that would stand out.
Ive used Voxel, Future, ShadowMap.
ShadowMap has worked but is now refusing to work.

Press shift + f2 and check if its being set in the first place

I have done shift + f2, no difference.

On the dropdown? yes

Im asking in game

How do I check that?

I told you, Shift + F2

press shift f2 in a game and send a screenshot please

What lighting technology are you using?

Im using Future

They were already at max

Then they are working

Im comparing and theres 0 differences

The game itself is saying its using future, so it probably is

I'll try a different game then

Got it working, just needed to reinstall roblox for whatever reason.


Some questions about the code

Why is it converted to lowercase here? Can it be ignored?

For the original dataset 'rmanluo/RoG-webqsp', there are instances where the same concept appears in different formats, such as 'gender' and 'Gender'. Converting all instances to lowercase can prevent representing the same concept with two different nodes when constructing a knowledge graph.


ORT squeezenet_qdq support new api

Signed-off-by: yuwenzho<EMAIL_ADDRESS>Type of Change
example
Description
ORT squeezenet_qdq needs to be supported by newapi
JIRA ticket: ILITV-2591
How has this PR been tested?
extension test: squeezenet_qdq
Dependency Change?
no

https://inteltf-jenk.sh.intel.com/job/intel-lpot-validation-top-mr-extension/4001/

pass: https://inteltf-jenk.sh.intel.com/job/intel-lpot-validation-top-mr-extension/4101/


Open in streamlink fails to work

Clicking open in streamlink shows the following in console:

The path seems to be correct, and streamlink works fine otherwise manually opened.
This is on Manjaro Linux, if it matters

did you add anything in "additional arguments"?
and what comes after the last line?

additional args are empty
those are the only 2 lines that are output, nothing comes after them

Hm, on linux it doesn't work at all for me but on windows it does.

I probably fucked up with the position of the additional arguments / didn't handle empty strings - I'll have a look somewhere this week, but shouldn't be too difficult to resolve.

Hmm, I've made a simple bash script:
#!/bin/bash
echo $@
streamlink $@

And changed streamlink path in Chatterino to point to that script, and now it works. And arguments are fine too.
P.S.: Are there any plans on embedding streamlink output directly in chatterino? It would be much more useful :)

fourtf actually added something like that but removed it due to license problems iirc


Get-Command: Returned CommandInfo object does not populate ScriptBlock property when -Name parameter is not used

Steps to reproduce
I created a Pester test for this
Describe "My test" {
    It "works" {
        (Get-Command -CommandType Function | Where-Object { $_.Name -eq 'Install-Module' }).ScriptBlock.Attributes | Should -Not -BeNullOrEmpty
        (Get-Command 'Install-Module').ScriptBlock.Attributes | Should -Not -BeNullOrEmpty
    }
}

Expected behavior
The test passes.
Actual behavior
  Describing My test
    [-] works 84ms
      Expected a value, but got $null or empty.
      3:         (Get-Command -CommandType Function | Where-Object { $_.Name -eq 'Install-Module' }).ScriptBlock.Attributes | Should -Not -BeNullOrEmpty
      at <ScriptBlock>, C:\Users\cberg\Desktop\foo.tests.ps1: line 3

The test passed only once Get-Command 'Install-Module' gets executed once in the current session.
I acknowledge that Get-Command tries to be more efficient when returning all commands but at least when accessing the properties of the object I'd expect them to be lazily evaluated.
Background: In order to improve performance of PSSA, I would like to run  Get-Command in the background once to populate a cached version of the commands instead of individually calling Get-Command -Name for each command, which is much more expensive.
Environment data

Name                           Value
----                           -----
PSVersion                      6.2.0-preview.4
PSEdition                      Core
GitCommitId                    6.2.0-preview.4
OS                             Microsoft Windows 10.0.17763
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

NB: After discussing this issue with members of the PowerShell team, it seems this is not some sort of optimisation but rather a bug that we could look into fixing. Maybe calling the required properties first in the runspace that creates it to pre-populate them could be a workaround


Always Run Pylint/MyPy

Right now failures during test execution will cause Pylint and MyPy to not run. Need to add succeededOrFailed() condition to the two jobs.

Scott has already added SucceededOrFailed condition. Leaving it open for few more days to learn about engineering systems

Scott has already taken care of these changes


Should have a 'zero' option for incomplete dates

Instead of forcing some default day of the month for incomplete dates, it would be very helpful if you could zero out the day so you'd know what part of the date string was missing.
Example:
parse(u'December 2015', settings={'PREFER_DAY_OF_MONTH': 'zero'})
>>> datetime.datetime(2015, 12, 0, 0, 0)

The same behaviour should be available for years, months, etc.

Unfortunately that would be an invalid datetime (if you try to create it, you get "ValueError: day is out of range for month")
There should be another way of signalling whether date, time or both were set in each datetime. I think that with an option in settings one should be able to request an extra member of the output tuples carrying this information.

Just added a PR trying to find a solution for this: https://github.com/scrapinghub/dateparser/pull/729
Please, if you have any feedback let me know.

We can't provide incomplete dates, but we can give more context by using DateDataParser() and get_date_data() as explained in this comment: https://github.com/scrapinghub/dateparser/issues/700#issuecomment-734326956
So I will close this issue in favor of the other as it's pointing to the correct solution we will work on in the future.
Thanks for the feedback :)


Migration from npm to pnpm Causes Build Failures Due to Missing Dependency

Hello,
I am thrilled to have found your library as it is exactly what I needed in my vite-react-ts application. I want to thank all of the maintainers and contributors for creating this neat plugin. It was just what I was looking for!
Issue:
I've noticed that the project is transitioning from npm to pnpm as the package manager. Wishing to contribute by bumping deps (vite), I cloned the repo onto my local machine. However, I encountered an issue where the build fails under pnpm due to a missing module, estree-walker, which isn't listed in the package.json as a dependency. This wasn't a problem with npm, likely due to npm's less strict handling of nested dependencies.
Steps to Reproduce:
I am linking a CodeSandbox for the reviewer's convenience.
To reproduce the issue, simply clone the repo to your machine, install the dependencies, and run the start command:
pnpm install
pnpm start

This produces the following error:
src/literals_compiler.ts:2:21:
    2 │ import { walk } from 'estree-walker'

ESM Build failed
Error: Build failed with 1 error:
src/literals_compiler.ts:2:21: ERROR: Could not resolve "estree-walker"

Additionally, I observed that the script commands in package.json are still prefixed with npm instead of pnpm. This may lead to inconsistencies in dependency management and potential conflicts with lock files.
System Info:

node:  v20.10.0
pnpm: v8.15.6

I would be happy to submit a PR rectifying these issues and bumping the vite dependency.
@KusStar your input would be highly valuable. Thank you.

Issue confirmed, seems like pnpm's peerDependency fetching logic is stricter than before, estree-walker should also be listed in package.json

It would be great if you would like to submit a PR.

@KusStar, thank you for your response! Yep, I added estree-walker in package.json and the build is successful. I have submitted a PR (#11) and would love hear your feedback on it. Please review at your convenience


Right-clicking Ranger's default bandage causes Result Code 10

This issue is happening on the master branch.
When you right click on the bandage in the Ranger's inventory, you will receive a message "Failed to update inventory [Result Code: 10]"
The bandage stays in place (it doesn't get unequipped and transferred to inventory).  Furthermore, if you have any other items unequipped in the Ranger's inventory, then all of those items will be re-equipped.

Fixed in #115. Open a new issue if still occurring.


What implementation of LaTex markdown is used for the math in documentation?

This would be helpful when contributing to ensure that our markdown will render correctly when "built". Thanks!

We use MathJax 2.7.2 to render the output of the OPS build, which is in turn produced by DocFX using Markdig.
This combination of tools is known to sometimes produce weird and unexpected results. For example, we have to use \\\\ instead of \\ to mark new line of table elements because half of the backslashes are interpreted as escape characters. Another example is that sometimes the formulas with sums in them will not render if subscript of \sum is given after the superscript.
Our CI on this repository renders the contents of pull requests, so we can preview them before merging.  For my work, I typically create a branch and preview the changes on it even before opening a PR (that's the only way I was able to verify that the changes in https://github.com/Microsoft/QuantumLibraries/pull/24 make sense!), but you'd need write access to the repo for that.

Closing, as this question has been answered. Thanks for the feedback!


Using {% block %} multiple times in a parent template

I noticed this morning while converting our designer's mockup into Twig templates that the {% block %} syntax can only be used in the parent template once, or you get a Twig_syntax error about the block already being used once.
I think there should be a way to repeat the usage in a template.
This is useful in things like a title block, where you would want to use the same block in a page header.

{% block %} is about defining a block. If you want to display the block another time in the page, there is a block() function for this: http://twig.sensiolabs.org/doc/functions/block.html

Ahh, my fault.  I misunderstood the documentation, thinking that {{ block() }} was just a synonym for {% block %}.


ENH: UI/UX

This PR:

Display last updated as 'unknown' if the corresponding field is empty (previously an empty value was displayed as an ugly 'NaN')
For items in the content tab:

The cloud icon as a means to download a file is removed
filename is turned into a link, if the file has an associated URL
the file size is updated to display correctly (empty string, and not NaN, if the value is empty)
the cursor will only turn into a pointer if the item is a folder or a file with a link.

closes https://github.com/datalad/datalad-catalog/issues/332
addresses one part of https://github.com/datalad/datalad-catalog/issues/361

Codecov Report
All modified lines are covered by tests :white_check_mark:

Comparison is base (a75c06b) 86.19% compared to head (f2a0307) 86.19%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #369   +/-   ##
=======================================
  Coverage   86.19%   86.19%
=======================================
  Files          43       43
  Lines        2709     2709
=======================================
  Hits         2335     2335
  Misses        374      374

Flag
Coverage Δ

unittests
79.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


add profile::ccs::sysctl

@glennmorris I think this would probably be better as part of ccs_profile or other external module but I didn't want to pin down the refactoring you've been doing while learning.  I think we should probably start a new module next week.


IOS setup step missed in Docs

Hi,
It seems that setup steps for IOS verision missed part about inserting ONE_SIGNAL_APP_ID.
I try this package first time, and not very confident is this step is nessesary.
However untill I did modification in AppDelegate.m - pushes did not work.
I found info here https://github.com/OneSignal/react-native-onesignal

There is no information about set APP_ID for IOS on this page https://github.com/geektimecoil/react-native-onesignal

@VBarzionov yes, there is. The readme says where to put the code and also says to replace with your own App ID.
On the application didFinishLaunchingWithOptions method, insert the following code (replace YOUR_ONESIGNAL_APP_ID with your OneSignal app ID):

You are right.
After you point I could finally find the code inside collapsed block.


Added support for Completions, AIO writes IOCtx namespaces, and a Maven option to skip unit tests

Hello @wido ,
I promised you a Pull request some time ago for some miscellaneous librados support.
I created a Completion class to support Completion objects in general, and then implemented support for AIO writes.  No AIO read support as of yet.
I also added support setting the IOCtx namespace.
Lastly, I added a Maven option to suppress unit tests in case the user does not have a Ceph test cluster available to their build machine.
This code has been tested on our Ceph cluster and has been running in our production environment.
Thanks,
Dan Jakubiec

Sorry for missing this one, I didn't get a notification of Github.
I'll review it asap!

No problem, thank you!

On Nov 9, 2016, at 23:52, Wido den Hollander<EMAIL_ADDRESS>wrote:
Sorry for missing this one, I didn't get a notification of Github.
I'll review it asap!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/ceph/rados-java/pull/25#issuecomment-259623708, or mute the thread https://github.com/notifications/unsubscribe-auth/AU8g0pamMmu9l_faR7mFEXMxcTQcXtofks5q8s1UgaJpZM4Kdrj4.

Thank you sir!

On Nov 12, 2016, at 06:48, Wido den Hollander<EMAIL_ADDRESS>wrote:
Merged #25 https://github.com/ceph/rados-java/pull/25.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/ceph/rados-java/pull/25#event-856765247, or mute the thread https://github.com/notifications/unsubscribe-auth/AU8g0lkyUYnayCMm3Qi1nBGmYMQFgJs0ks5q9dHMgaJpZM4Kdrj4.


[AutoDiff] Cross-import overlay for tgmath derivatives.

Move tgmath derivatives to a cross-import overlay _{Darwin|Glibc|CRT}__Differentiation. Make _Differentiation no longer depend on Darwin/Glibc/CRT.
Resolves rdar://69052246.

@compnerd I'm getting some seemingly unrelated errors when compiling stdlib, but I didn't change stdlib's CMakeLists. I'm not super familiar with CMake and wonder if there's any obvious mistakes I made in this change.
/Users/rxwei/Development/Swift/swift-source/swift/stdlib/public/core/ArrayBody.swift:24:26: error: cannot find type '_SwiftArrayBodyStorage' in scope
  internal var _storage: _SwiftArrayBodyStorage
                         ^~~~~~~~~~~~~~~~~~~~~~
/Users/rxwei/Development/Swift/swift-source/swift/stdlib/public/core/ArrayBody.swift:33:16: error: cannot find '_SwiftArrayBodyStorage' in scope
    _storage = _SwiftArrayBodyStorage(
               ^~~~~~~~~~~~~~~~~~~~~~
/Users/rxwei/Development/Swift/swift-source/swift/stdlib/public/core/ArrayBody.swift:46:16: error: cannot find '_SwiftArrayBodyStorage' in scope
    _storage = _SwiftArrayBodyStorage(count: 0, _capacityAndFlags: 0)
               ^~~~~~~~~~~~~~~~~~~~~~
/Users/rxwei/Development/Swift/swift-source/swift/stdlib/public/core/Builtin.swift:115:8: error: cannot find type 'Builtin' in scope
  lhs: Builtin.NativeObject, rhs: Builtin.NativeObject
       ^~~~~~~
/Users/rxwei/Development/Swift/swift-source/swift/stdlib/public/core/Builtin.swift:115:35: error: cannot find type 'Builtin' in scope
  lhs: Builtin.NativeObject, rhs: Builtin.NativeObject
                                  ^~~~~~~

@rxwei - the errors look like you are missing a -parse-as-stdlib flag from the compiler invocation.  Im not sure why that would get dropped (could be related to the change in the import behaviour?)


[Bug] Presets not working at all

I cant get the preset to work anymore
when i add a new preset there is no options at all under it other than changing preset name.
i also cant delete anything the delete preset button is not working at all.
tried to remove the folder in pluginconfig and the plugin itself but that didnt help

for now i have to edit the .json manually to add the presets lol

Strange! I can't re-produce this same issue on my side.
I would try updating the plugin and seeing if that fixes it first, otherwise, I would suggest deleting/renaming your .json and trying to re-config your text to talk plugin. I think there might be something invalid in your .json that could be causing problems.

Strange! I can't re-produce this same issue on my side. I would try updating the plugin and seeing if that fixes it first, otherwise, I would suggest deleting/renaming your .json and trying to re-config your text to talk plugin. I think there might be something invalid in your .json that could be causing problems.

I dont get it i cant get it to fully reset. i have removed the folder and the loose json file in pluginConfigs and the plugin itself in installed plugins but it somehow still remembers some settings. the presets are all reset tho. But it still has the new preset bug.


Fix order of interpolation grids in preproc_ascii_opac.py (sorry).

Background
The testing did not expose a bug in the preproc script, where the ordering of the rho-T grids was wrong in the interpolation function. This was due to testing on an input file that had an equal number of density and temperature points, along with equal opacity at each.
Changes

Fix rho, T grid ordering in SciPy interp2d function.
Add an optional plotting capability, to look at color maps before and after interpolation:

@brryan @Yurlungur - sorry to have not checked this script interpolation more carefully initially.