ruff: 0.5.7 -> 0.6.0

Description of changes

ruff: move to pkgs/by-name
ruff: 0.5.7 -> 0.6.0

Changelog: https://github.com/astral-sh/ruff/releases/tag/0.6.0

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 334856 run on aarch64-linux 1

8 packages marked as broken and skipped:

khoj
khoj.dist
open-webui
open-webui.dist
python311Packages.langchain-chroma
python311Packages.langchain-chroma.dist
python312Packages.langchain-chroma
python312Packages.langchain-chroma.dist

2 packages failed to build:

python312Packages.langgraph
python312Packages.langgraph.dist

75 packages built:

dmarc-metrics-exporter
dmarc-metrics-exporter.dist
marimo (python312Packages.marimo)
marimo.dist (python312Packages.marimo.dist)
nbqa
nbqa.dist
pentestgpt
pentestgpt.dist
python311Packages.instructor
python311Packages.instructor.dist
python311Packages.langchain
python311Packages.langchain-azure-dynamic-sessions
python311Packages.langchain-azure-dynamic-sessions.dist
python311Packages.langchain-community
python311Packages.langchain-community.dist
python311Packages.langchain-core
python311Packages.langchain-core.dist
python311Packages.langchain-huggingface
python311Packages.langchain-huggingface.dist
python311Packages.langchain-mongodb
python311Packages.langchain-mongodb.dist
python311Packages.langchain-openai
python311Packages.langchain-openai.dist
python311Packages.langchain-text-splitters
python311Packages.langchain-text-splitters.dist
python311Packages.langchain.dist
python311Packages.langgraph
python311Packages.langgraph.dist
python311Packages.langsmith
python311Packages.langsmith.dist
python311Packages.marimo
python311Packages.marimo.dist
python311Packages.pyhanko
python311Packages.pyhanko.dist
python311Packages.pytest-examples
python311Packages.pytest-examples.dist
python311Packages.python-lsp-ruff
python311Packages.python-lsp-ruff.dist
python311Packages.xhtml2pdf
python311Packages.xhtml2pdf.dist
python311Packages.xsdata
python311Packages.xsdata.dist
python312Packages.instructor
python312Packages.instructor.dist
python312Packages.langchain
python312Packages.langchain-azure-dynamic-sessions
python312Packages.langchain-azure-dynamic-sessions.dist
python312Packages.langchain-community
python312Packages.langchain-community.dist
python312Packages.langchain-core
python312Packages.langchain-core.dist
python312Packages.langchain-huggingface
python312Packages.langchain-huggingface.dist
python312Packages.langchain-mongodb
python312Packages.langchain-mongodb.dist
python312Packages.langchain-openai
python312Packages.langchain-openai.dist
python312Packages.langchain-text-splitters
python312Packages.langchain-text-splitters.dist
python312Packages.langchain.dist
python312Packages.langsmith
python312Packages.langsmith.dist
python312Packages.pytest-examples
python312Packages.pytest-examples.dist
python312Packages.python-lsp-ruff
python312Packages.python-lsp-ruff.dist
python312Packages.xsdata
python312Packages.xsdata.dist
ruff
ruff-lsp
ruff-lsp.dist
shell-gpt
shell-gpt.dist
vunnel
vunnel.dist

Result of nixpkgs-review pr 334856 run on x86_64-linux 1

2 packages marked as broken and skipped:

khoj
khoj.dist

83 packages built:

dmarc-metrics-exporter
dmarc-metrics-exporter.dist
marimo (python312Packages.marimo)
marimo.dist (python312Packages.marimo.dist)
nbqa
nbqa.dist
open-webui
open-webui.dist
pentestgpt
pentestgpt.dist
python311Packages.instructor
python311Packages.instructor.dist
python311Packages.langchain
python311Packages.langchain-azure-dynamic-sessions
python311Packages.langchain-azure-dynamic-sessions.dist
python311Packages.langchain-chroma
python311Packages.langchain-chroma.dist
python311Packages.langchain-community
python311Packages.langchain-community.dist
python311Packages.langchain-core
python311Packages.langchain-core.dist
python311Packages.langchain-huggingface
python311Packages.langchain-huggingface.dist
python311Packages.langchain-mongodb
python311Packages.langchain-mongodb.dist
python311Packages.langchain-openai
python311Packages.langchain-openai.dist
python311Packages.langchain-text-splitters
python311Packages.langchain-text-splitters.dist
python311Packages.langchain.dist
python311Packages.langgraph
python311Packages.langgraph.dist
python311Packages.langsmith
python311Packages.langsmith.dist
python311Packages.marimo
python311Packages.marimo.dist
python311Packages.pyhanko
python311Packages.pyhanko.dist
python311Packages.pytest-examples
python311Packages.pytest-examples.dist
python311Packages.python-lsp-ruff
python311Packages.python-lsp-ruff.dist
python311Packages.xhtml2pdf
python311Packages.xhtml2pdf.dist
python311Packages.xsdata
python311Packages.xsdata.dist
python312Packages.instructor
python312Packages.instructor.dist
python312Packages.langchain
python312Packages.langchain-azure-dynamic-sessions
python312Packages.langchain-azure-dynamic-sessions.dist
python312Packages.langchain-chroma
python312Packages.langchain-chroma.dist
python312Packages.langchain-community
python312Packages.langchain-community.dist
python312Packages.langchain-core
python312Packages.langchain-core.dist
python312Packages.langchain-huggingface
python312Packages.langchain-huggingface.dist
python312Packages.langchain-mongodb
python312Packages.langchain-mongodb.dist
python312Packages.langchain-openai
python312Packages.langchain-openai.dist
python312Packages.langchain-text-splitters
python312Packages.langchain-text-splitters.dist
python312Packages.langchain.dist
python312Packages.langgraph
python312Packages.langgraph.dist
python312Packages.langsmith
python312Packages.langsmith.dist
python312Packages.pytest-examples
python312Packages.pytest-examples.dist
python312Packages.python-lsp-ruff
python312Packages.python-lsp-ruff.dist
python312Packages.xsdata
python312Packages.xsdata.dist
ruff
ruff-lsp
ruff-lsp.dist
shell-gpt
shell-gpt.dist
vunnel
vunnel.dist

Result of nixpkgs-review pr 334856 run on aarch64-darwin 1

4 packages marked as broken and skipped:

khoj
khoj.dist
nbqa
nbqa.dist

12 packages failed to build:

dmarc-metrics-exporter
dmarc-metrics-exporter.dist
open-webui
open-webui.dist
python311Packages.langchain-chroma
python311Packages.langchain-chroma.dist
python311Packages.pyhanko
python311Packages.pyhanko.dist
python311Packages.xhtml2pdf
python311Packages.xhtml2pdf.dist
ruff-lsp
ruff-lsp.dist

69 packages built:

marimo (python312Packages.marimo)
marimo.dist (python312Packages.marimo.dist)
pentestgpt
pentestgpt.dist
python311Packages.instructor
python311Packages.instructor.dist
python311Packages.langchain
python311Packages.langchain-azure-dynamic-sessions
python311Packages.langchain-azure-dynamic-sessions.dist
python311Packages.langchain-community
python311Packages.langchain-community.dist
python311Packages.langchain-core
python311Packages.langchain-core.dist
python311Packages.langchain-huggingface
python311Packages.langchain-huggingface.dist
python311Packages.langchain-mongodb
python311Packages.langchain-mongodb.dist
python311Packages.langchain-openai
python311Packages.langchain-openai.dist
python311Packages.langchain-text-splitters
python311Packages.langchain-text-splitters.dist
python311Packages.langchain.dist
python311Packages.langgraph
python311Packages.langgraph.dist
python311Packages.langsmith
python311Packages.langsmith.dist
python311Packages.marimo
python311Packages.marimo.dist
python311Packages.pytest-examples
python311Packages.pytest-examples.dist
python311Packages.python-lsp-ruff
python311Packages.python-lsp-ruff.dist
python311Packages.xsdata
python311Packages.xsdata.dist
python312Packages.instructor
python312Packages.instructor.dist
python312Packages.langchain
python312Packages.langchain-azure-dynamic-sessions
python312Packages.langchain-azure-dynamic-sessions.dist
python312Packages.langchain-chroma
python312Packages.langchain-chroma.dist
python312Packages.langchain-community
python312Packages.langchain-community.dist
python312Packages.langchain-core
python312Packages.langchain-core.dist
python312Packages.langchain-huggingface
python312Packages.langchain-huggingface.dist
python312Packages.langchain-mongodb
python312Packages.langchain-mongodb.dist
python312Packages.langchain-openai
python312Packages.langchain-openai.dist
python312Packages.langchain-text-splitters
python312Packages.langchain-text-splitters.dist
python312Packages.langchain.dist
python312Packages.langgraph
python312Packages.langgraph.dist
python312Packages.langsmith
python312Packages.langsmith.dist
python312Packages.pytest-examples
python312Packages.pytest-examples.dist
python312Packages.python-lsp-ruff
python312Packages.python-lsp-ruff.dist
python312Packages.xsdata
python312Packages.xsdata.dist
ruff
shell-gpt
shell-gpt.dist
vunnel
vunnel.dist

Result of nixpkgs-review pr 334856 run on x86_64-darwin 1

4 packages marked as broken and skipped:

khoj
khoj.dist
nbqa
nbqa.dist

66 packages failed to build:

dmarc-metrics-exporter
dmarc-metrics-exporter.dist
open-webui
open-webui.dist
pentestgpt
pentestgpt.dist
python311Packages.instructor
python311Packages.instructor.dist
python311Packages.langchain
python311Packages.langchain-azure-dynamic-sessions
python311Packages.langchain-azure-dynamic-sessions.dist
python311Packages.langchain-chroma
python311Packages.langchain-chroma.dist
python311Packages.langchain-community
python311Packages.langchain-community.dist
python311Packages.langchain-core
python311Packages.langchain-core.dist
python311Packages.langchain-huggingface
python311Packages.langchain-huggingface.dist
python311Packages.langchain-mongodb
python311Packages.langchain-mongodb.dist
python311Packages.langchain-openai
python311Packages.langchain-openai.dist
python311Packages.langchain-text-splitters
python311Packages.langchain-text-splitters.dist
python311Packages.langchain.dist
python311Packages.langgraph
python311Packages.langgraph.dist
python311Packages.langsmith
python311Packages.langsmith.dist
python311Packages.pyhanko
python311Packages.pyhanko.dist
python311Packages.pytest-examples
python311Packages.pytest-examples.dist
python311Packages.xhtml2pdf
python311Packages.xhtml2pdf.dist
python312Packages.instructor
python312Packages.instructor.dist
python312Packages.langchain
python312Packages.langchain-azure-dynamic-sessions
python312Packages.langchain-azure-dynamic-sessions.dist
python312Packages.langchain-chroma
python312Packages.langchain-chroma.dist
python312Packages.langchain-community
python312Packages.langchain-community.dist
python312Packages.langchain-core
python312Packages.langchain-core.dist
python312Packages.langchain-huggingface
python312Packages.langchain-huggingface.dist
python312Packages.langchain-mongodb
python312Packages.langchain-mongodb.dist
python312Packages.langchain-openai
python312Packages.langchain-openai.dist
python312Packages.langchain-text-splitters
python312Packages.langchain-text-splitters.dist
python312Packages.langchain.dist
python312Packages.langgraph
python312Packages.langgraph.dist
python312Packages.langsmith
python312Packages.langsmith.dist
python312Packages.pytest-examples
python312Packages.pytest-examples.dist
python312Packages.python-lsp-ruff
python312Packages.python-lsp-ruff.dist
shell-gpt
shell-gpt.dist

15 packages built:

marimo (python312Packages.marimo)
marimo.dist (python312Packages.marimo.dist)
python311Packages.marimo
python311Packages.marimo.dist
python311Packages.python-lsp-ruff
python311Packages.python-lsp-ruff.dist
python311Packages.xsdata
python311Packages.xsdata.dist
python312Packages.xsdata
python312Packages.xsdata.dist
ruff
ruff-lsp
ruff-lsp.dist
vunnel
vunnel.dist

Result of nixpkgs-review pr 334856 run on x86_64-darwin 1

4 packages marked as broken and skipped:

khoj
khoj.dist
nbqa
nbqa.dist

51 packages failed to build:

dmarc-metrics-exporter
dmarc-metrics-exporter.dist
open-webui
open-webui.dist
pentestgpt
pentestgpt.dist
python311Packages.langchain
python311Packages.langchain-azure-dynamic-sessions
python311Packages.langchain-azure-dynamic-sessions.dist
python311Packages.langchain-chroma
python311Packages.langchain-chroma.dist
python311Packages.langchain-community
python311Packages.langchain-community.dist
python311Packages.langchain-huggingface
python311Packages.langchain-huggingface.dist
python311Packages.langchain-mongodb
python311Packages.langchain-mongodb.dist
python311Packages.langchain-openai
python311Packages.langchain-openai.dist
python311Packages.langchain-text-splitters
python311Packages.langchain-text-splitters.dist
python311Packages.langchain.dist
python311Packages.langgraph
python311Packages.langgraph.dist
python311Packages.pyhanko
python311Packages.pyhanko.dist
python311Packages.xhtml2pdf
python311Packages.xhtml2pdf.dist
python312Packages.langchain
python312Packages.langchain-azure-dynamic-sessions
python312Packages.langchain-azure-dynamic-sessions.dist
python312Packages.langchain-chroma
python312Packages.langchain-chroma.dist
python312Packages.langchain-community
python312Packages.langchain-community.dist
python312Packages.langchain-huggingface
python312Packages.langchain-huggingface.dist
python312Packages.langchain-mongodb
python312Packages.langchain-mongodb.dist
python312Packages.langchain-openai
python312Packages.langchain-openai.dist
python312Packages.langchain-text-splitters
python312Packages.langchain-text-splitters.dist
python312Packages.langchain.dist
python312Packages.langgraph
python312Packages.langgraph.dist
tests.devShellTools.nixos
tests.testers.lycheeLinkCheck.network
tests.testers.nixosTest-example
tests.testers.runNixOSTest-example
tests.trivial-builders.references

35 packages built:

marimo (python312Packages.marimo)
marimo.dist (python312Packages.marimo.dist)
python311Packages.instructor
python311Packages.instructor.dist
python311Packages.langchain-core
python311Packages.langchain-core.dist
python311Packages.langsmith
python311Packages.langsmith.dist
python311Packages.marimo
python311Packages.marimo.dist
python311Packages.pytest-examples
python311Packages.pytest-examples.dist
python311Packages.python-lsp-ruff
python311Packages.python-lsp-ruff.dist
python311Packages.xsdata
python311Packages.xsdata.dist
python312Packages.instructor
python312Packages.instructor.dist
python312Packages.langchain-core
python312Packages.langchain-core.dist
python312Packages.langsmith
python312Packages.langsmith.dist
python312Packages.pytest-examples
python312Packages.pytest-examples.dist
python312Packages.python-lsp-ruff
python312Packages.python-lsp-ruff.dist
python312Packages.xsdata
python312Packages.xsdata.dist
ruff
ruff-lsp
ruff-lsp.dist
shell-gpt
shell-gpt.dist
vunnel
vunnel.dist


news displayed improperly on about page

This should look like the home page.
cc @talumbau

Just looking at this now. What should this section look like? Should there be this "What People are Saying" section? If yes, I guess it would have to pull content from news.ospc.org. That's a bit more involved. To me, it's still a useful page even w/o this "What People are Saying" section.

The analagous section on the home page looks like this ("updates from the field" rather than "what people are saying".):

I remember that @zrisher (i think) had to link manually to get the welcome to ospc post to show, however, and obviously that hasn't been done for the new TaxBrain is live post.
Ideally on both the about page and home page we could pull the last few blog posts (for now two, then three, then six in two rows) automatically. In the meantime, I'd be fine just hiding this section on the about page. Keeping the updates from the field section on the home page seems important.

I've been thinking more about this. Let's just drop this "what people are saying" section and make life easier for ourselves.


Grid system for holes and lava

Scene-Gen
MCS
Unity
Teams thread about a potential other solution

This seems like a pretty big change for holes and lava.  I feel like we should only have one grid system, it seems like this would be extremely confusing for TA1.  Perhaps we should have a design meeting to discuss this at some point.

I think this solution is  going to cause us big headaches.  Sometimes the simplest solutions aren't always the best long term solutions and I think a bigger discussion needs to occur.  We need one grid system throughout our repos I believe as we need to think primarily about the usability it will cause TA1 and not the ease for TA2 to code solutions.  We should strive to make things as ease as possible for TA1.

I think this solution is going to cause us big headaches. Sometimes the simplest solutions aren't always the best long term solutions and I think a bigger discussion needs to occur. We need one grid system throughout our repos I believe as we need to think primarily about the usability it will cause TA1 and not the ease for TA2 to code solutions. We should strive to make things as ease as possible for TA1.

If making the grid system for the holes/lava sync up with the other objects is so important, then maybe we should consider keeping the current behavior, and simply handling the holes/lava-underneath-room-walls case in the plotter code?

I think this solution is going to cause us big headaches. Sometimes the simplest solutions aren't always the best long term solutions and I think a bigger discussion needs to occur. We need one grid system throughout our repos I believe as we need to think primarily about the usability it will cause TA1 and not the ease for TA2 to code solutions. We should strive to make things as ease as possible for TA1.

If making the grid system for the holes/lava sync up with the other objects is so important, then maybe we should consider keeping the current behavior, and simply handling the holes/lava-underneath-room-walls case in the plotter code?

@brianpippin @ThomasSchellenbergNextCentury @deanwetherby Even though i did all this work I would completely support scrapping this implementation and doing the simpler: "handling the holes/lava-underneath-room-walls case in the plotter code" Perhaps we just detect when floor texture or hole it out of bounds and just cut ones off directly under walls to be half drawn while ones outside walls are not drawn at all.


Shape tool not mutually exclusive with other modes

Maybe lean on the type system?
Also, polygon tool seems to sometimes be offset from the mouse position. Triggering a window resize event fixes the problem.

Oops, bug introduced with my recent changes. Try now.

Seems to be working.


How to use streaming data

I guess you were talking about training a streaming ASR system with limited input look-ahead context? The default training config uses a transformer structure with full context, therefore it's not a model that can be used in a streaming system. Later on, we will release a few models that can work in streaming mode.


⚠ T:Riza Roblox Proxy has degraded performance

In 1c16d74, T:Riza Roblox Proxy (https://rprxy.triza.dev) experienced degraded performance:

HTTP code: 200
Response time: 4053 ms

Resolved: T:Riza Roblox Proxy performance has improved in 2b566bf.


Cant pull docker image

There is no official published Docker image; the pull is not expected to work. You can build the image locally using the community-contributed Dockerfile though.


Configuration - nest assemblies and references

At the moment, the config file does not group genome assemblies with e.g. kit targets/baits. Since these are usually relative to a given coordinate system (assembly), these should be grouped. For example:
params {

   genomes {

'hg19' {
		fasta = "/ifs/data/nfs_share/ikmb_repository/references/gatk/bundle/2.8/hg19/ucsc.hg19.fasta"
		dict = "/ifs/data/nfs_share/ikmb_repository/references/gatk/bundle/2.8/hg19/ucsc.hg19.dict"
		dbsnp = "/ifs/data/nfs_share/ikmb_repository/references/gatk/bundle/2.8/hg19/dbsnp_138.hg19.vcf.gz"
		gold = "/ifs/data/nfs_share/ikmb_repository/references/gatk/bundle/2.8/hg19/Mills_and_1000G_gold_standard.indels.hg19.sites.vcf.gz"
		g1k = "/ifs/data/nfs_share/ikmb_repository/references/gatk/bundle/2.8/hg19/1000G_phase1.indels.hg19.sites.vcf.gz"
		omni = "/ifs/data/nfs_share/ikmb_repository/references/gatk/bundle/2.8/hg19/1000G_omni2.5.hg19.sites.vcf.gz"
		hapmap = "/ifs/data/nfs_share/ikmb_repository/references/gatk/bundle/2.8/hg19/hapmap_3.3.hg19.sites.vcf.gz"
		kits {
      			'Nextera' {
         			targets = "/ifs/data/nfs_share/ikmb_repository/references/exomes/nextera_exome_target_2017/nexterarapidcapture_exome_target_v1.2_hg19.interval_list"
         			baits = "/ifs/data/nfs_share/ikmb_repository/references/exomes/nextera_exome_target_2017/nexterarapidcapture_exome_intervals_v1.2_hg19.interval_list"
      			}
      			'xGen' {
        			targets = "/ifs/data/nfs_share/ikmb_repository/references/exomes/idt_xgen/v1.0/xgen-exome-research-panel-targets.interval_list"
        			baits = "/ifs/data/nfs_share/ikmb_repository/references/exomes/idt_xgen/v1.0/xgen-exome-research-panel-probes.interval_list"
      			}
   		}
	}
  }
}

We now have an extra configuration file metafiles.config that is imported in various profiles and allows setting a single path to the required -metafiles and -kitfiles and thus accompensates this :-)


[5.8] Reworked env to allow getenv/putenv to be disabled

It is currently not easily possible to disable putenv and getenv. It is now super easy to disable this by adding Illuminate\Support\Env::disablePutenv(); to your bootstrap/app.php file.
This is particularly important for Lumen apps, where config caching is not available. This PR can be regarded as a security fix affecting Lumen apps running on server shared with any other sites.

I really do think that in Laravel 5.9 we should toggle the default from putenv being enabled to being disabled, in the interest of security. Now that it can easily be turned on in the boostrap file, we no longer have the developer experience issues we had before.

Any tests?

Yes, there are. They're still there.

I don't get why this is still being pushed. From last time it seems there's a very large community relying on the current behavior for thousands of PHP libraries.
I don't think any PHP framework alone will be enough to rollout this change to the PHP community. Perhaps proposing a PSR for a component similar to Laravel's Config Repository and standarizing the flow from environment variable to configuration data would have a higher chance.

From last time it seems there's a very large community relying on the current behavior for thousands of PHP libraries.

And all these library authors are calling a function that is not thread-safe. We have to try and make them aware.
Note that this PR does not change the default behaviour, it just allows people to make their Lumen apps secure by disabling putenv and getenv.

Perhaps proposing a PSR for a component similar to Laravel's Config Repository and standarizing the flow from environment variable to configuration data would have a higher chance.

I disagree. The ONLY problem here is that most people are not aware that getenv and putenv are not the best way to get and set environment variables, because they are not thread-safe. There is no need to force config caching or other patterns and interfaces on people. Just use the proper superglobals instead of the functions.

There is no 'proper' superglobal for library development. They're not reliable[1] for framework agnostic or context-agnostic packages such as AWS SDK or thiusands of similar packages. getenv is the best bet even for people using pthreads, which is also not in the majority.
[1] https://mattallan.me/posts/how-php-environment-variables-actually-work/

Can you send this to master where we already have Illuminate\Support\Env.

@taylorotwell I'd rather we actually brought this in to 5.8, since it's not just a refactoring, it's a security fix for Lumen apps.

I can resolve the merge conflicts 5.8 -> master for you if you'd like.

And all these library authors are calling a function that is not thread-safe.

I would like to remark on the tread-safety here. These methods are totally thread-safe; the problem is that they change a process-wide environment. Threads within the same process will see the side-effects of calling these methods, but they work as intended and are thread-safe.
The problem here seems to be apache users that uses a mpm that executes several requests within the same process, so they share the environment variables. Couldn't we just educate people, tell them to use fastcgi and the php-fpm instead? (I believe setting up different pools in fpm is also the way to have your sites running under different user accounts so that one wordpress site you are being forced to maintain doesn't infect all other sites...)
If we should consider this as a security fix; then the secure mode should be default. The secure mode in this issue is to disable getenv/putenv, which will break existing installations.

It is only a security fix for those not using config caching, or those using Lumen. I don't think we should change any defaults in Laravel 5.8.

Couldn't we just educate people, tell them to use fastcgi and the php-fpm instead? (I believe setting up different pools in fpm is also the way to have your sites running under different user accounts so that one wordpress site you are being forced to maintain doesn't infect all other sites...)

Actually fpm is vulnerable to this too. We have had many, many reports of variables leaking in our issue tracker over the years.

If the fpm has this behavior then I've misunderstood the entire problem. The fpm will boot up a new process for every request, and the different processes should not share the environment space. If the problem is reproducible on fpm, that implies that nginx users are also affected. This makes me slightly worried since I'm using nginx+fpm in production. This also increases the scope of the issue from some apache configurations, to almost all apache+nginx configurations.
Could you point me to an issue or any information on how to reproduce the problem on fpm so that I can verify the problem (and thus the fix) in my production environment?

FPM does not boot up a process for every request. FPM workers can and do handle multiple requests (one at a time per worker). The default setup is that workers live indefinitely but can be changed such that a worker handles at most N requests and then is restarted. This is controllable by the pm.max_requests setting in the FPM config file.

Feel free to send to master and I am fine this functionality. We are just a few weeks from that release.


How can I deploy a shiny app created in R to azure as a web-service...

Is it possible to deploy a shiny dashboard created in R to deploy it as a web-service in azure...I was only able to find the deployment of R ML model to Azure ML studio...But my R script does not have any ML model...So is there a way that could be done?

Duplicate of #27419

@pcchauhan120 Thanks for the feedback. It looks like this issue is a duplicate of 27419
. So, We will go ahead and close this issue.


MyST-Markdown rendering in notebooks (awaiting API release)

Awaiting https://github.com/microsoft/vscode/issues/121256

Also check "best practices" against https://github.com/microsoft/vscode/tree/1.58.0/extensions/markdown-math

Hello, is there already a way to render markdown cells in vscode with the MyST-Markdown extension?

I'm facing the same issue.

@chrisjsewell  it seems the api has since been released from what I can tell
Is there a plan to implement this feature in the near future? I much prefer working with VS Code over jupyterlab for most of my work but suppose I will just use jupyterlab for now when I need MyST markdown

Here is a demo extension I made which enables markdown rendering in vscode notebooks based on microsoft/vscode-extension-samples/tree/main/notebook-extend-markdown-renderer-sample
I've only done very limited testing for the parts of MyST that I use day to day so I have no idea how complete its coverage is, but thought if there are others who want to render it in there notebook cells it could be helpful to them.
jonathanapfeifer/vscode-notebook-myst-extension

any progress on this? please

just had a look at the issue mentioned in the OP, and from what I can see there
https://github.com/microsoft/vscode/issues/121256
and related issues like
https://github.com/microsoft/vscode/issues/153403
it seems like the api that we were waiting for is now available ?
my understanding is this is what prevents MyST markdown in Jupyter notebook cells from being rendered properly, which would be an immense relief if that became available, since it would allow authoring Jupyter Book inputs under vs-code and remove the dependency to Jupyter Lab
please instruct if this matter is better followed in another issue or location


New function Get-ExchangeConnectors

Issue:
Resolve #919
Description:
New function to query Exchange Send-/Receive Connectors. The function is general and can easily be extended (e.g. other use cases).
How does it work?
Get-ExchangeConnectors contains the core functionality of this new function.

ExchangeConnectorObjectFactory generates custom objects with the same set of properties for send and receive connectors
NormalizeTlsCertificateName is used to check and normalize the TlsCertificateName which might be configured for the send-/receive connector
FindMatchingExchangeCertificate is used to find the matching certificated on the Exchange server

ExchangeConnectorObjectFactory is a general function and can be easily adjusted for other connector related scenarios. Just add the properties that you need.
Do not merge yet. Still in development. Feel free to review.
Validation:
Lab / Pester

@lusassl-msft the new CodeFormatter.ps1 script also requires a blank space at the end of the .md files as well.
Let's also discuss the rest of this here today.


wip: Add create-ultra-app to repo

[ ] Test template functionality
[x] Enhance CLI text
[ ] Create imported files locally

Whats the status of this, is it ready to merge?

One tiny request, can we get some color on the questions asked? Maybe the same blue used in the "congrats" message at the end

Will need to update the imports to link to the files in this repo, and some of the templates need to be tested to make sure they work.

Great job Benton! 🚀🚀🚀

I think we should, at least for now, go the route of creating all required files locally.

Is this in reference to the files that are downloaded from the repo?

I think we should, at least for now, go the route of creating all required files locally.

Is this in reference to the files that are downloaded from the repo?

The files in modules that are imported rather than created. For example, useFlushAsyncWhateverTheNameIs

Oh no, right I see what you mean. Yeah I'd like the files to be local, gives developers a chance to modify if they so choose.

Oh no, right I see what you mean. Yeah I'd like the files to be local, gives developers a chance to modify if they so choose.

For the Twind issue that was resolved, was there something in particular that was implemented wrong?

Oh no, right I see what you mean. Yeah I'd like the files to be local, gives developers a chance to modify if they so choose.

For the Twind issue that was resolved, was there something in particular that was implemented wrong?

@mashaal best to answer that

Oh no, right I see what you mean. Yeah I'd like the files to be local, gives developers a chance to modify if they so choose.

For the Twind issue that was resolved, was there something in particular that was implemented wrong?

It seems it was missing the twind.ts Deno block here. https://github.com/exhibitionist-digital/ultra/blob/main/examples/with-twind/twind.ts#L4-L12
And then I got a useDehydratedState issue with react-query. https://github.com/exhibitionist-digital/ultra/blob/main/examples/with-react-query/src/hooks/useDehydrateReactQuery.tsx
That issue raised covered a heap of surface area. react-query, react-router, trpc, twind, helmet -- I was able to get it to work after a few mins of localising the twind and query dependencies, but I'm certain this level of integration could be a bit more elegant. https://github.com/exhibitionist-digital/ultra/issues/153

Oh no, right I see what you mean. Yeah I'd like the files to be local, gives developers a chance to modify if they so choose.

For the Twind issue that was resolved, was there something in particular that was implemented wrong?

It seems it was missing the twind.ts Deno block here. https://github.com/exhibitionist-digital/ultra/blob/main/examples/with-twind/twind.ts#L4-L12
And then I got a useDehydratedState issue with react-query. https://github.com/exhibitionist-digital/ultra/blob/main/examples/with-react-query/src/hooks/useDehydrateReactQuery.tsx
That issue raised covered a heap of surface area. react-query, react-router, trpc, twind, helmet -- I was able to get it to work after a few mins of localising the twind and query dependencies, but I'm certain this level of integration could be a bit more elegant. #153

sheet should have been provided here https://github.com/B3nten/ultra/blob/create/lib/create/modules/twind/content/twind.ts
But regardless it was missing useDehydrateReactQuery which was obviously an issue. I'll try to get something up tonight that should fix those issues. And try to make it more elegant

Okay, I think this is ready to merge. The current create script is broken so this wouldn't be any worse. I've disabled TRPC until I can confirm it works.


yuzu-ea: 3702->3777, yuzu-mainline: 1475 -> 1505

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

This is not the latest version, but we can't bump it to latest without bumping Vulkan first.

@SuperSandro2000 @PedroHLC @Ralith can you please give some feedback?

I'd rather update the Vulkan stuff in nixpkgs, or at least override our derivation and use it as an input. Relying on vendored stuff is not great.

I'd rather update the Vulkan stuff in nixpkgs

We decided not to keep updating Vulkan to match yuzu's requirements because they use non-stable versiona of the Vulkan components.

That's not really the case. The version they're using is stable, there are just some release cadence issues that make updating the rest of the Vulkan SDK difficult sometimes.

That's not really the case. The version they're using is stable, there are just some release cadence issues that make updating the rest of the Vulkan SDK difficult sometimes.

Some context:
https://github.com/NixOS/nixpkgs/issues/243780#issuecomment-1648627379_

On the Vulkan-nixpkgs-side, I previously proposed we “versioning” it, in at least _sdk and _latest: https://github.com/NixOS/nixpkgs/pull/229897. It's easier to update every other package in nixpkgs (one goes through staging, the other directly to master), and we have a fallback in case the latest is borked.
I have a simpler solution in chaotic's nyx nowadays: vulkan-versioned. But I still would prefer all of them in one directory in nixpkgs to help bumping.

On Yuzu-EA-side, we should update Yuzu in separated PRs, always. Yuzu non-ea still depends on 1.3.256, and we can safely update. Meanwhile, the EA it's updated multiple times during the same day, includes non-merged poorly reviewed PRs. Occasionally, EA doesn't even work, e.g., in 3770 they pushed a requirement on QRegExpValidator which doesn't exist in Qt6 and trashed that build (and two tags following it).

IMHO as the dependency on latest commits of Vulkan is not real we shouldn't keep having to update it just for the sake of yuzu. Yuzu builds and runs with the stable SDK (I tested the EA locally before pushing the pr), so it's less work if we just update the SDK when there is a new stable (blessed) release.

(But the mainline one could have been updated earlier on if we did a separate PR.)

Agree, but the script to update bumps both versions, so I just did both, and I think that's what happens most of the time.

Last commit should probably be squashed with the first one

Last commit should probably be squashed with the first one

I think it's better to squash when there is nothing else to fix to keep the changes matching the commentaries here until then.

BTW, there is a new mainline version of yuzu out already (and like 10 -ea) should I update them in this PR?

We should be able to use system Vulkan headers after https://github.com/NixOS/nixpkgs/pull/245954 (hopefully) lands.

We already do it without that PR.

I see the other maintainers are inactive in github, is there any hope of getting this merged?

If we're patching it out anyway, why not just downgrade the requested version here?

I thought about doing it before going this route and ended up with this to avoid having to add regexes / change this by hand every time they change it upstream.

I'd actually prefer a patch here, specifically because it's going to fail in a loud and predictable way next time upstream raises the required version.

If the changes upstream require a new version (for real) it won't compile.

Yes, with a confusing failure mode that doesn't clearly indicate the root cause of the issue.

Are you ok with just skipping the version check (using a hardcoded version)? That will also fail if the version mismatches, I can add a comment to clarify the intention and what to do after.

What do you mean by "using a hardcoded version"?

I mean:
  substituteInPlace    CMakeLists.txt \
    --replace "find_package(Vulkan 1.3.256 REQUIRED)" ""

Just removing the line won't work, we need to replace it with a lower version (or an unversioned specification).

Also, substituteInPlace won't fail if there are no matches in the source file - it will print a warning, but it will not fail the build.

Just removing the line won't work, we need to replace it with a lower version (or an unversioned specification).

You are right, I forgot it was a find_package not a check, but same idea, if that works for you I can try to do it (and see how can I make it fail if not substitution happens).

Honestly, I still think the easiest way is to just write a patch. All we really need is
-find_package(Vulkan 1.3.256 REQUIRED)
+find_package(Vulkan 1.3.250 REQUIRED)

And it's going to fail cleanly, it's going to be very evident what it does, and it's going to be very evident why it's there.

Pretty awkward that this now once again pulls in the vendored Vulkan-Headers' cmake scripts, and perhaps even uses them exclusively. Shouldn't cause any problems, though, so w/e, hopefully upstream will clean it up someday.

@Ralith, this is another reason the patch is a better option, actually.
@leiserfg, could you update to the latest version, squash all the commits and then maybe add a comment to the patch explaining why it was added?

I added the comment in the patch itself, it will be easier to find in the future.

Seems good here. Thanks a lot for investigating this!


Remove hardcode KinD CIDR range from e2e

- What this PR does and why is it needed
we need to be able to run e2e test on any cluster not KinD cluster only
- How to verify it
run make test-e2e on any cluster CIDR range should be calculated based on the nodes IPv4and IPv6 addresses.
- Description for the changelog
drive CIDR value for the rules from node IPv4 and IPv6 addresses

/assign @sabinaaledort

/lgtm


FR: Expose Project ID from ServiceAccountCredential

Similar to http://google.github.io/google-auth-library-java/releases/0.8.0/apidocs/com/google/auth/oauth2/ServiceAccountCredentials.html#getProjectId--
This is available in the service account JSON files issued by Google IAM.

@hiranya911 I'm not sure of the context you're using this in. You've asked about ServiceCredentials here; might this also be required for OAuth and/or compute credentials?

I think it's only available on ServiceAccountCredentials in other languages, which is good enough for our purposes.

This is fixed in #1240, and will go out in the next release. Closing.


Board Review: Attestation - TypeScript

Thank you for submitting this review request. Thorough review of your client library ensures that your APIs are consistent with the guidelines and the consumers of your client library have a consistently good experience when using Azure.
The Architecture Board reviews Track 2 libraries only. If your library does not meet this requirement, please reach out to Architecture Board before creating the issue.
Please reference our review process guidelines to understand what is being asked for in the issue template.
To ensure consistency, all Tier-1 languages (C#, TypeScript, Java, Python) will generally be reviewed together.  In expansive libraries, we will pair dynamic languages (Python, TypeScript) together, and strongly typed languages (C#, Java) together in separate meetings.
For Tier-2 languages (C, C++, Go, Android, iOS), the review will be on an as-needed basis.
Before submitting, ensure you adjust the title of the issue appropriately.
Note that the required material must be included before a meeting can be scheduled.
Contacts and Timeline

Responsible service team: Microsoft Azure Attestation
Main contacts<EMAIL_ADDRESS>Expected code complete date: 7/4/2021
Expected release date: 8/5/2021

About the Service

Link to documentation introducing/describing the service: MAA Service

Link to the service REST APIs:  Attestation REST APIs

Link to GitHub issue for previous review sessions, if applicable:
Board Review C#
Board Review Python

About the client library

Name of the client library: Azure-Security-Attestation
Languages for this review: JavaScript/TypeScript

Artifacts required (per language)
Please read through “API Review” section here to understand how these artifacts are generated. It is critical that these artifacts are present and are in the right format. If not, the language architects cannot review them with the SDK Team’s API review tool.
.NET

APIView Link:
Link to Champion Scenarios/Quickstart samples:

Java

APIView Link:
Link to Champion Scenarios/Quickstart samples:

Python

APIView Link:
Link to Champion Scenarios/Quickstart samples:

TypeScript

APIView Link: https://apiview.dev/Assemblies/Review/abeaab76f52e4c87af52b8f851eba9ea
Link to Champion Scenarios/Quickstart samples: https://github.com/Azure/azure-sdk-for-js/tree/main/sdk/attestation/attestation/samples-dev

For all other languages, send a request to the Architecture Board to discuss the best format on individual basis.
Thank you!

scheduled for 7/22

recording


govcloud enablement, continued

Which issue this PR addresses:
Partially fixes 8644408
What this PR does / why we need it:
Further changes to allow RP to work in multiple clouds.
Todo: Figure out ContainerRegistryDNSSuffix
Test plan for issue:
E2E, unit tests, creating cluster in gov cloud.
Is there any documentation that needs to be updated for this PR?
No

@jim-minter I successfully created a usgov cluster today on the latest commit in this branch


Restructure modules and class names

This PR do some minor cleanups and some major project structuring to use more consistent and shorter modules and class names.

frequenz.client.base.grpc_streaming_helper was renamed to frequenz.client.base.streaming.

The GrpcStreamingHelper class was renamed to GrpcStreamBroadcaster.

The constructor argument retry_spec was renamed to retry_strategy.

frequenz.client.base.retry_strategy was renamed to frequenz.client.base.retry.

The RetryStrategy class was renamed to Strategy.

I'm planning to improve the docs too, but I will wait until this is merged because I can imagine there could be some push back. BTW, I really think we should eventually rename this project frenquenz-grpc or frequenz-grpcutil or something like that, this is not really a base class for clients but just utilities to deal with gRPC/protobuf.

I will update and improve the docs in a followup PR, and then do the v0.2.0 release.

Enabled auto-merge.

do you want to update the commit message also? https://github.com/frequenz-floss/frequenz-client-base-python/pull/25/commits/edab315116c3e0ed9ceb46f876ac6b664abd6163

Good catch, done now!

I updated the PR description also with the new name, and removed and re-enabled auto-merge, so that it uses the updated merge commit message.


End to end stress test

Updated:
Goal
The goal of the stress test is to test Longhorn's long term endurance during various kind of operations. The measurement of the progress is how long can the stress test be run without error out.
Design
The stress test will be run in an infinite loop and checking for errors.

Start N number of pods at the same time, with Longhorn volume.
Write random data with size 100 MB to the volume. Randomly choice of creating new files or rewrite existing files, or delete and create a new file.
Validate the data.
Make a snapshot
Delete a random snapshot once in a while. Run snapshot purge after.
Validate the data.
Go back to step 3, repeat M times.
Detach the pod which completed the progress.
Create a new pod, go back to step 2.

Use N=10, M=3 as a start.
For the future versions, we can add more operations as an alternative to step 5, e.g.:

losing a replica and rebuild.
create/delete a backup
create/delete scheduled backup/snapshot

It seems the stress test's load is too much for the normal nightly test setup. We won't able to run nightly test with it for now.
Close https://github.com/longhorn/longhorn-tests/pull/196

And it doesn't need to be fit in the nightly test framework.

Framework done. We will add more steps/functions to it later.


Write a C program to find perimeter of a rectangle

Description
Write a C program to find perimeter of a rectangle
Perimeter of rectangle = 2 × (Length + Width)
Length : 2
Width  : 3

Perimeter : 10

How to contribute

Save the solution in FindPerimeterOfARectangle.c file
Add FindPerimeterOfARectangle.c file in find-perimeter-of-a-rectangle folder

!assign


Feature request: CPU use as a percentage + Thermal Sensors

Would be great to have some additional sensors that replicate the basic info available in the System Information widget on the OPNsense dashboard:

CPU use as a percentage

Thermal sensors

Thanks!

up

Up

@Snuffy2 I would agree with this, we're missing CPU usage and it seems the API is there, but I don't actually understand from the docs what "stream" means:

For thermal info, this post documents how it is managed.

v0.2.1


Need Browser Support in README

Does it support IE8?

Yeah, I need to know this too.  I guess I need to support IE8 still...

Yes. Ie8 is supported. Browser support can be seen in build status.
However it looks like saucelabs badge has since broken.
Virtual Dom supports ie6 and up. If something does not work, please open an issue reporting the bug.

That's great to know!  Thanks.

@Raynos
IE6+, awsome


Show number of running jobs in the status command

Extend plotman status to include a summary of how many jobs are currently currning
 plot id    k           tmp           dst   wall   phase    tmp      pid   stat    mem   user    sys     io
69d378c6   32   /plot/disk1   /farm/disk1   1:52     1:5   171G   206372    SLP   4.0G   2:04   0:05    16s
0a05cce1   32   /plot/disk2   /farm/disk1   1:53     1:5   172G   206217    SLP   4.0G   2:11   0:05    12s
b125bec7   32   /plot/disk1   /farm/disk1   1:54     1:5   171G   206050    SLP   4.0G   2:05   0:05    21s
8eabd76b   32   /plot/disk2   /farm/disk1   1:55     1:5   172G   205851    SLP   4.1G   2:14   0:05    11s
706fb53f   32   /plot/disk1   /farm/disk1   1:58     1:5   172G   205347    SLP   4.0G   2:12   0:05    11s
55792166   32   /plot/disk2   /farm/disk1   3:26     2:1   169G   191975    RUN   1.3G   3:55   0:10   0:04
88ad605c   32   /plot/disk2   /farm/disk1   4:35     3:1   233G   187863    RUN   4.4G   5:03   0:12   0:09
07af8891   32   /plot/disk2   /farm/disk1   5:06     3:2   226G   187560    RUN   3.7G   5:26   0:13   0:19
4f0a0164   32   /plot/disk2   /farm/disk1   5:08     3:2   225G   187544    RUN   3.8G   5:30   0:14   0:19
78bd0279   32   /plot/disk2   /farm/disk1   5:10     3:2   222G   187520    DSK   3.8G   5:29   0:14   0:19

Total jobs: 10
Jobs in /plot/disk1: 3
Jobs in /plot/disk2: 7

That's just a suggestion to make the PRs more isolated in the future.  No need to change this one at any point.  In other cases it easily happens that you end up holding up some feature that we all like and is implemented well while debating over what some unrelated comment should say.  Isolated PRs just let's us approve the good bits quickly and avoids having to parse out the separate activities when we read the PRs.
Anyways, thanks again for the help.  :]


Requesting to add new language, Myanmar(Burmese)

I would like to contribute Myanmar(Burmese) translation for Hash Checker. How can I contribute, please?

@heptahex Yes. You can do it. I am added Myanmar Language to OneSky, follow this link: https://osbvnmv.oneskyapp.com/collaboration/translate/project/project/353871/language/132

Hey, @fartem  I would like to work on this.

@ManishDait, yes, sure. But right now I don't have access to OneSky. You can add translations from it manually.

@heptahex, done.


Pass Basic Authorization header to OAuth2 access token request

Fixes #143, #175, #205, and #300.

Hello,
I was facing the Basic Authorization issue and your commit solved my problem.
Just a little comment. I think that when using Basic Auth the client_id and client_secret should also be removed from the url params (it's the purpose that they are not sent in clear text in the URL).
But that means that an extra parameter must be passed in the strategy to decide how to pass the client_id and client_secret to the token endpoint.

+1 for this PR. This is the default authentication mode in the RFC, some servers only support this.

Why hasn't this been merged? According to the OAuth 2.0 RFC, servers are only required to support HTTP Basic authentication with the client_credentials grant type. This client does not work with some OAuth 2.0 servers because of this.

Do we have to fork?
Some tests may help!

What's the status on this??

@jdesboeufs @jordanbtucker
So, after digging through the code and considering creating my own PR and such, I decided just to add my authorization as a custom header when I created my OAuth2 instance (and since I'm using passport-oauth2, which supports custom headers, I just passed it through that). See:
// just add your 'Authorization' header here to get the functionality - doesn't make it super smooth and easy, but it works
exports.OAuth2 = function (clientId, clientSecret, baseSite, authorizePath, accessTokenPath, customHeaders) {
...
}

customHeaders needs to be an object where the key is the header's name and the value is the header's value
Of course, it doesn't really solve the provider's use case, which is keeping your client id/secret pairing a true secret, since they're still sent in the url. You may be dealing with the risk of them logging that somewhere, but this PR doesn't solve that, anyway.

@corbfon The last commit to this repository is over two years old. I think it’s time to admit that this project is unmaintained, and this is never getting merged. Use or create a fork if you have to.

@lexi-lambda ah... good point. Sucks that this is a dependency of a library as large as passport. Do you recommend another lib for oauth2 flow?

Sad...


Support for conditional mandatory fields

Package version eg. v8, v9:
v9
Issue, Question or Enhancement:
It would be nice if a field could be validated as required only when another field has a specific value.
In the code example, the FinLength is only mandatory if the Type is fish.
I tried to implement a custom validation but I couldn't end the validation pipeline when the field is not required. I looked into how omitempty was done and it's not a conventional tag.
Code sample, to showcase or reproduce:
type Animal struct {
  Type Type
  LegLength int `validate:"requireIf=mammal@Type,numeric,gte=0"`
  FinLength int `validate:"requireIf=fish@Type,numeric,gte=0"`
}

Hey @DanielDHuynh thanks for the suggestion.
Although this is possible to code, I highly recommend to everyone that once the validation reaches this level of complexity to use struct level validation; it can also be combined with validation via tags(they work together)
If I added this type of logic it would severely clutter the tags and make them hard to read; but beyond that doing it via struct level validation with be much more performance as well.
Hope this answer helps :)

Hi @joeybloggs,
I think this is a good solution, thank you!

@deankarn  is StructLevel Validation possible with v8 version ?


They load just fine your theme is hiding it the text since you use the same color for --primary-text-color and --primary-color

Sorry for the inconvenient, didn't know that!


Implement tab for DIP3 MN list

This implements a new tab that shows deterministic MNs. It also shows a note to inform people that this list is only for informational purposes until spork15 activates. The note will disappear on spork15 activation.
It looks like:

For some reason I only get a note on "All Masternodes" tab. The "DIP Masternodes" tab isn't showing one.

@thephez Sorry for that one, I didn't remove the test code that removes the note after 10 seconds...please retry recently pushed version.

Looks good. It's a helpful screen to have.


Export to chat log does not include check type any more

When exporting the chat log (via the core foundry feature), the resulting log does not contain the type of check any more (which is in the message header)
Example:

will result in
[9/11/2022, 11:10:41 AM] Chomp
17
1d20 + 6 = 11 + 6 = 17

Previously, a perception check looked like this:
[3/13/2022, 5:27:42 PM] Bölefeld Blaumann
15

Perception Check

Wisdom +1Expert +4

1d20 + 5 = 10 + 5 = 15

It would be nice if this could be included again in some way.
FVTT v10 Build 285
System v4.0.1

This is a change to Foundry itself, sorry.


Create custom Controller, View

Laravel Version: 5.5
Voyager Version:latest
PHP Version: 7.1
Database Driver & Version:MySql

Description:
I have images table where I store images(path) and media, gallery, news, brochures table which hold one or more than images via voyager relationship. I created belongs to many relationship for each of media, gallery, news, brochures on images table. When I want add new image I have to go to images table upload image then connect with the appropriate data.
This is totally useless and not user friendly.
-Is there any way that still hold on to the images table to store images in single place but visually change other tables so that when I open that tab on voyager images appear there and still being able to delete edit and add images???
-Could you please suggest some kind of solution or opinion towards solving the issue?
Steps To Reproduce:

Hi! If you want custom view for your bread (table), you need create file like:
resources/views/vendor/voyager/clients/browse.blade.php

where clients is the bread. You can change browse to read or edit-add too.
Custom controller we can set in bread settings.

This would all be custom, not directly possible from within voyager, so I can't provide step-by-step instructions.  However, we're planning to do exactly that for a media manager hook to work with a future release, replacing our current media manager implementation


Dont Come

Hi,
Is there a way to simulate the "Don't Come" bet?

Yes, it got added in the dev branch which hasn't yet been merged (been super busy, sorry). https://github.com/skent259/crapssim/commit/217d34d602f1c7f4c900e8a495e260882fcf8c94
You can add the following lines to any script in which you need to simulate the Don't Come bet:
 class DontCome(DontPass):
     def __init__(self, bet_amount):
         super().__init__(bet_amount)
         self.name = "DontCome"

     def _update_bet(self, table_object, dice_object):
         status, win_amount = super()._update_bet(table_object, dice_object)
         if not self.prepoint and self.subname == "":
             self.subname = "".join(str(e) for e in self.losing_numbers)
         return status, win_amount


Update README.md

fix onBeforeOpen option description

Codecov Report

Merging #169 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #169   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           1      1
  Lines         374    374
=====================================
  Hits          374    374

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5f33b5...f451eda. Read the comment docs.

Thanks!! 👍


testadd create partition and partition scrolling

Proposed changes
testadd create partition and partition scrolling

run buildall

run buildall

There is a conflict. After resolving it, a new pull request has been submitted.


Add the translation authors of the PS1 article to the Russian language

Zerocker had some lines done beforehand, so I added them as well. I'd also like to use my real name here :)

Thanks! but don't worry about signing on behalf of others, it's like signing a portrait, only the author must do it. Zerocker is always welcome to create a PR.


format of connectionstring file

Hi, does the connectionstring file look for keys within a Connection string section eg.
"ConnectionStrings": {
"log4net" : " [The connection string]"
}
or is it just a flat file
{
"log4net" : "[The Connection string]"
}
I'm currently reading from my appsettings.json file, is this ok or should i create a separate file ?

This is the way:
"connectionStrings": {
"log4net" : " [The connection string]"
}

where as the name log4net is set on the ConnectionStringName property in your log4net.config

Thanks,
And is it ok reading from the appsettings.json file, or do i have to create a seperate file with connection strings

Yes, you can specify appsettings.json. The only requirement for the *.json file is a "connectionStrings" section that contains the ConnectionStringName.

Thanks,


Don't re-enable scrollbars after capture

Re-enabling scrollbars may effect the placement of excluded rectangles.
fixes #93

@christian-bromann I've been running with this PR over many repos for the past two weeks, and the only effect I see is that we can actually test IE :)
Any chance of getting this in?

Sure. But we need to refactor this because it affects the state of the website.

Much appreciated!

But we need to refactor this because it affects the state of the website.

Can you give a pointer/ pseudo code do how you think it should be tackled. Also, what's the concern of keeping the state of the page - for chained tests?

Also, what's the concern of keeping the state of the page - for chained tests?

Yes! The purpose of WebdriverCSS is not enhance WebdriverIO with a tool to take relieable screenshots of a website. People should be able to integrate this into their usual e2e tests. That's why I don't want to screw up the page.

Can you give a pointer/ pseudo code do how you think it should be tackled

The main reason why we have the problem is that the screenshot is taken without scrollbars but getPageInfo gets called with scrollbars. One solution could be to remove scrollbars in the getPageInfoCall as well.

gotcha.
btw, could you please publish a new version so I shoov-webdrivercss could go back to using this repo.

done

:smile:


Example fixed: counter

Changed Alignment -> Align. Now it compiles!

master has breaking changes! Alignment is the proper type now :slightly_smiling_face:


Organize structure 📚

Organize the structure of the code, try putting your codebase inside the src folder.

[ ]  Organize font files ( .otf , .ttf)
[ ]  Put database models inside one folder ( try renaming the other one outside source)

this project is kinda dead 😩

imma close this issue since the whole project is dead, will try and revive back by contributing tho! thanks for the enhancement suggestions, will implement these in the next pr / commits I do :)


Release v0.23.8

🤬 That ClientTimeoutSuite is back.  It's happening more than not all of a sudden.

And after all that, the release build failed on ClientTimeoutSuite, on 3.1. :shrug:


Add missing ‘gulp-rename’ to devDependencies

This is required to run gulp demo

Thanks for the PR - gulp-rename isn't actually used, so the best thing would be to remove this line


Support ROS REP 147 Odometry Message

http://www.ros.org/reps/rep-0147.html
I'm going to start work on this. I need it for SLAM on the ROS side.
I've got a corresponding issue in mavlink. I need to add the mavlink message there first, then will add the handler for the px4 firmware.
see https://github.com/mavlink/mavlink/issues/721

@jgoppert should we sync efforts to make this possible soon?

Yes this would really help me out.

Hey, this issue has been closed because the label status/STALE is set and there were no updates for 30 days. Feel free to reopen this issue if you deem it appropriate.
(This is an automated comment from GitMate.io.)

Already implemented.


Added cos/sin tokens to rpc.py

Added cos/sin tokens, particularly useful for calculating wind vectors!
Wind data button example simulates the wind data calculated by G1000 PFD:
  - index: 5
    name: WIND
    label: WIND DATA
    label-color: Black
    label-size: 10
    type: none
    annunciator:
      size: medium
      model: F
      parts:
        F0: # Headwind RPN: [Wind Direction] [Aircraft Heading] - cos [Wind Speed] *
          color: yellow
          text-size: 28
          formula: "${sim/cockpit2/gauges/indicators/wind_heading_deg_mag} ${sim/cockpit2/gauges/indicators/compass_heading_deg_mag} - cos ${sim/cockpit2/gauges/indicators/wind_speed_kts} *"
          text-font: fontawesome.otf
          text: "↓ ${formula}"
          text-format: "{0:.0f}"
        F2: # Tailwind RPN: [Wind Direction] 180 + [Aircraft Heading] - cos [Wind Speed] *
          color: yellow
          text-size: 28
          formula: "${sisim/cockpit2/gauges/indicators/wind_heading_deg_mag} 180 + ${sim/cockpit2/gauges/indicators/compass_heading_deg_mag} - cos ${sim/cockpit2/gauges/indicators/wind_speed_kts} *"
          text-font: fontawesome.otf
          text: "↑ ${formula}"
          text-format: "{0:.0f}"
        F1: # Crosswind L RPN: [Wind Direction] 180 + [Aircraft Heading] - sin [Wind Speed] *
          color: yellow
          text-size: 28
          formula: "${sim/cockpit2/gauges/indicators/wind_heading_deg_mag} 180 + ${sim/cockpit2/gauges/indicators/compass_heading_deg_mag} - sin ${sim/cockpit2/gauges/indicators/wind_speed_kts} *"
          text-font: fontawesome.otf
          text: "→ ${formula}"
          text-format: "{0:.0f}"
        F3: # Crosswind R RPN: [Wind Direction] [Aircraft Heading] - sin [Wind Speed] *
          color: yellow
          text-size: 28
          formula: "${sim/cockpit2/gauges/indicators/wind_heading_deg_mag} ${sim/cockpit2/gauges/indicators/compass_heading_deg_mag} - sin ${sim/cockpit2/gauges/indicators/wind_speed_kts} *"
          text-font: fontawesome.otf
          text: "← ${formula}"
          text-format: "{0:.0f}"

Good idea. Thanks.

In the example button in the comment there was a typo which I have now fixed with update to comment:
formula: "${sisim/cockpit2/g….


Config not optimized for default ec2 machine

The number of gunicorn workers and celery workers is not optimized for the small default machine on ec2. This was because we would always use larger machines for actual experiments but users of the system end up more often than not just using the default machine with not great performance as indicated by the queues backing up on the dashboards
We need to make the default machine beefier and/or optimize the config for the default machine

Still an issue but I upped the number of gunicorn workers with minimum influence on performance


Add WeightInfo to all pallets with benchmarks.

polkadot companion: https://github.com/paritytech/polkadot/pull/1352
This introduces a custom type and trait WeightInfo that exists in each pallet with benchmarked extrinsics weight.
This WeightInfo trait defines the set of functions that need to exist to be able to weigh the extrinsics in the pallet.
This approach moves weight values out of the pallet, and into the runtime definition, allowing any custom blockchain to define custom weights for each pallet based on their specific runtime configuration.
This PR does not actually take advantage of this new WeightInfo trait/type, but that will be incrementally added to Substrate as we migrate from the existing weight system to the new one.
Note that Frame System uses the name SystemWeightInfo because all other pallets inherent the System trait, and if we didn't name it differently, we would run into a name conflict that would need to resolve with extra trait code.

bot merge

This WeightInfo trait defines the set of functions that need to exist to be able to weigh the extrinsics in the pallet.

Does this have any correlation with the Call enum or each function defined in benchmarks!{}? if so, then perhaps it would be better than maintaining a list of function next to Call and benchmarks! {} which has a large portion in common with each.
In other words, I think we can generate the trait WeightInfo of each module somehow out of decl_module! or benchmarks!, I hope.

I found part of my answer here https://github.com/paritytech/substrate/pull/6567/files#diff-9eb528fcc0396bf9e69c2dd4ebb637c5R33
but still not sure: if this cli option is going to write the trait to a new file, what's up with the ones added here? How do we plan to use these together?

@kianenigma the plan is to update decl_module to generate this automatically. We will create some syntax so that we can define the list of functions needed to benchmark that pallet. For now this is just manually written.

Note that Frame System uses the name SystemWeightInfo because all other pallets inherent the System trait, and if we didn't name it differently, we would run into a name conflict that would need to resolve with extra trait code.

Won't this issue re-occur for people that depend on/inherit system::Trait + balances::Trait ?


SAML SSO for Chrome Apps not working with Chrome Update 72.0.3626.97 from 71

We are experiencing issue with the SAML SSO for Chrome Apps extension on Chrome starting this week with version <IP_ADDRESS>.97.
The previous version of 71 was working fine.
Can you confirm that its working ok?
We are using it with chromeboxes, chromebooks(pixelbook).
Any help greatly appreciated.

Can you update to 72.03626.117 and test again? Note that that version won't be released for pixelbook for a few days but may be available on your chromebox).
If the newer 72 version doesn't fix this for you can you try going to chrome://flags#network-service and toggling it off? Does it work with the network service off? Does it work if you set network service to on? (you need to restart Chrome OS after each change).

Thanks for the reply.
Will do, we will test 72.03626.117 when it comes out for the pixelbook.  We
will also try an HP Chromebook, and ChromeBox.
Is there way to turn logging on for SAML SSO for Chrome Apps?  and where
would the log be on a chromebox/chromebook?
Thanks
On Thu, Feb 21, 2019 at 12:47 PM Jay Lee<EMAIL_ADDRESS>wrote:

Can you update to 72.03626.117 and test again? Note that that
version won't be released for pixelbook for a few days but may be available
on your chromebox).
If the newer 72 version doesn't fix this for you can you try going
to chrome://flags#network-service and toggling it off? Does it work with
the network service off? Does it work if you set network service to on?
(you need to restart Chrome OS after each change).

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_googlearchive_chromeos-5Fsaml-5Fapps_issues_1-23issuecomment-2D466160128&d=DwMFaQ&c=vZI7FCk37fZpIpwDI9E_qA&r=G5i84GOr660oBm5C31AjaxgwGeNabEVSCxhqWzPl5ko&m=T8z2qI9NeBGPgSXGh35rZcvMtlimIS6wiPwMMugPjT8&s=n-R4zL2sRLY2O0Q5eoWT2ot9N0hqDl0SC4t6o3Ii-ZU&e=,
or mute the thread
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_Acqq4wMCCmV5eOZJFbgii61iPu-5FyINaAks5vPwXlgaJpZM4bFtnT&d=DwMFaQ&c=vZI7FCk37fZpIpwDI9E_qA&r=G5i84GOr660oBm5C31AjaxgwGeNabEVSCxhqWzPl5ko&m=T8z2qI9NeBGPgSXGh35rZcvMtlimIS6wiPwMMugPjT8&s=wk2D9rZroJyT7CrUeK2DO429glvLdosW-1ITKOfm9Vs&e=
.

--
Notice to recipient: This e-mail is only meant for the intended recipient
of the transmission, and may be a confidential communication or a
communication privileged by law. If you received this e-mail in error, any
review, use, dissemination, distribution, or copying of this e-mail is
strictly prohibited. Please notify us immediately of the error by return
e-mail and please delete this message from your system. Thank you in
advance for your cooperation.

I tried chrome://flags#network-service (enabled and disabled) and it didn't work.
We had about 5 test pixelbooks and noticed that after we upgraded from 71 (when it was working), and updating it to 72, it broke..
Also tried chrome://flags#network-service with 72.  Is broke.
Is there a log file for what saml for chrome is logging to?

Here is the json file for saml for chrome
Looking for a log file if it has the capability, Thanks
"whitelist" : {
    "Value" : [
        {
        "appId" : "haiffjcadagjlijoggckpgfnoeiflnem",
        "domain" : "pingidentity.com"
        }
    ]
 }

}

We are using Ping for the chromeos (pixelbok and chromebox).
Do you think we need to define more?   What does "Secure" do?
What's interesting is that it all worked great with version "71".. and stopped after we upgraded to "72"
properties": {
"appId": {
"title": "Whitelisted App ID",
"description": "ID of the app that the admin wishes to grant a subset of the user's cookies to.",
"type": "string"
},
"domain": {
"title": "Domain for granted cookies",
"description": "A domain for which the helper extension will extract cookies from the user's profile and hand over to requesting appId. This can be further refined by the admin with criteria for cookie name, secure attribute, and path.",
"type": "string"
},
"name": {
"title": "Name for granted cookies",
"description": "A name for which the helper extension will filter the cookies from the user's profile and hand over to requesting appId.",
"type": "string"
},
"path": {
"title": "Path for granted cookies",
"description": "A path for which the helper extension will filter the cookies from the user's profile and hand over to requesting appId.",
"type": "string"
},
"secure": {
"title": "Secure property for granted cookies",
"description": "The secure property for which the helper extension will filter the cookies from the user's profile and hand over to requesting appId.",
"type": "boolean"

73 came out and we tested it.  Still broken.  Works with 71 all day long.. just not 72, and 73.
Can your verify that this extension works with 72, 73?

HA SUCKER

Just wanted to confirm that im noticing the same issue here using enrolled "Acer R13" and Acer "Spin 15" running ChromeOS 73.0.3683.114.
We intended to use this app for forwarding a SAML cookie to the Citrix Workspace App. But so far i can't get it to work properly.

I feel better now that someone else has also observed this.
We are a Google Gsuite / Chrome Pro shop and we are trying to replace our Win7 Wyse terminals with Google Boxes.
With Version 72 before it broke, it was working great on Chromebox's and Chromebooks successfully using the SAML SS for chrome Apps with Citrix Workspace using Citrix FAS (Federated Auth Service).
It was awesome for a end user to authenticate using a 2nd factor on the chromebox/pixelbook, and having the saml authenticate all the way to opening up citrix workspace seemlessly already authenticated showing all the published apps.
But, It's still broken even with the latest updates.
Do you think we can escalate this up the Support Layers at Google?    We will be talking to our Google rep about this also to see if it can be escalated.

@nlochrie i have been using the developpertools from chrome on both the "SAML SSO for chrome apps" and the citrix receiver.
From what i can see, the "SAML SSO for Chrome apps" sends forward the correct cookies, however for some reason, whenever i inspect the web-view in the "citrix workspace"  app. Im just missing one of the cookies used for SAML. Which is the one containing what appears to be a JWT token.
The code for the "citrix  workspace app" is  unfortunately obfuscated to some degree, making debugging it properly a tad difficult. But from what i can see it just leaves out of one of the 3 cookies sent by the "SAML SSO for chrome apps" extension.
I think we shouldn't be looking at google for this, but instead should be looking at Citrix for what changed in their workspace app, unfortunately i dont know a way to set my chromebook back to version 71 to be able to  see what the whole dance is supposed to look like. Do you have a way of doing that?
PS im in a pretty small company ( less than 300 chromebooks, less than 1500 employees)  so we dont have a lot of suction with either Google or Citrix in this regard.

@nlochrie looks like i found the cause.
The issue lies here:

The Citrix Workspace app actually tries to set the cookie on the event specified. Since chrome 72 this is no longer possible and thus it no longer works. When I inspect the Citrix Workspace App i can see it happening in the debugger as well... the cookies are extracted using the "getAllCookies" message provided by this extension. and then are set in the "onHeadersReceived" event on the webview's request property. This doesn't work since chrome 72. I will try contacting Citrix about this.

Awesome!  Great Job.
If you haven't already, mention there are other Citrix customers that are trying to use Chromebooks as endpoints with Workspace Client.  We have 500+ winterminals that are slated to be replaced.
Thanks

@nlochrie
Citrix support came through. you can check the following article:
https://support.citrix.com/article/CTX253863
They have a fix in a private release. This worked for us, it will probably hit production on the next update of citrix workspace app.
i think you can close this issue.


How to get the order of the nodes in a diagram?

I am developing a simple workflow using Blazor Diagrams. I see the list of the nodes and links and its possible to get the order by reading all links and nodes and see which link is connected to what node. It will take me a long time to figure how to do that.
Is there a better way or someone figured out how to get the order of the nodes from the first one to the last connected node?

Hello, this isn't available in the library directly because it's specific to a use case. But you could do it 2 ways:

Looping through all links and figuring out the order, which is what you're doing.
Have Parent/Child node properties in your custom node model. Whenever a link is created (Links.Added event), you set the Parent to either one of the source nodes of the link and the Child to the other. Then when you need your order, you just take your root node, which is the node without a parent but with a child, and you go through the children one by one.

Glad I helped!

Hello, this isn't available in the library directly because it's specific to a use case. But you could do it 2 ways:

Looping through all links and figuring out the order, which is what you're doing.
Have Parent/Child node properties in your custom node model. Whenever a link is created (Links.Added event), you set the Parent to either one of the source nodes of the link and the Child to the other. Then when you need your order, you just take your root node, which is the node without a parent but with a child, and you go through the children one by one.

I'm sorry for reopening this issue , but I've been trying to do this same exact thing to no avail.
I'd like to point out that the LinkAdded event triggers before the link is attached to a port or node. and doesn't get re-triggered whenever the attachment is done (mouse up on the end port).
about the other method of looping through all the links , i'm sure it's possible but whenever the link is connected in the opposite order (end port to start port) the source and target nodes are flipped which make calculating the end path complex. especially when you can reuse nodes in your diagram
I'd love some help! love this library

Hello @MoathTar, check out #344


Provide option to make generated rust code always use fully qualified paths

Before anything, I want to express my gratitude to the authors. I can easily imagine how arduous the project I'm working on would have been without this.
Is your feature request related to a problem? Please describe.
I have a Channel type in my api which breaks the generated code as it's ambiguously resolved with a type from within frb with the same name.
Describe the solution you'd like
An option to allow the codegen to use fully qualified paths in all generated rust code should provide a lasting solution to this and any similar problems.
Describe alternatives you've considered
For now, I'm going to use a rust side wrapper to avoid the clash and a dart side alias to keep using the the Channel name elsewhere.
Additional context
This occurs on v 1.60.0 of frb.

That looks pretty reasonable. Roughly speaking, seems that we only need to modify a few places using things inside flutter_rust_bridge - just add prefix flutter_rust_bridge:: to them. Feel free to PR!

P.S. overall design doc - https://cjycode.com/flutter_rust_bridge/contributing/design.html (may not be needed for this PR but just put it here for reference)


Removed unused test utils

Fixes #2337.
Discovered that these utils weren't used.
Also removing eofLineRuleTests.ts as that rule has regular tests.

@andy-ms thanks!


Merge Bakame/Period-Visualizer codebase to the Period repo

Feature Request

Q
A

New Feature
yes

BC Break
yes

Proposal
An independent visualizer package was created to help visualize Periods and Sequences object. This package is heavily used on development to test the main package. As this package never hit the 1.0.0 milestone I think it's easier to just merge it's codebase to the Period package.
The only drawback is that it's inclusion requires bumping the min. PHP version supported to 7.2. Since 7.1 is already eol this should not be a problem if the library is loaded through composer.

merged done


Make it possible for vf cdpackages to do a pushd instead of cd

Most of the time I'm using vf cdpackages I'm debugging a setup.py or MANIFEST.in, so my workflow is to vf tmp, pip install the wheel or sdist I've built, vf cdpackages to poke around at what got installed, then cd back and repeat.
If, OTOH, we had something that used pushd instead, I could popd back to where I was without having to specify the path.

I've made #145. By using only one cd call, one can go back using cd -. If you prefer using pushd/popd instead, I can change that.


Unity 2021.3 exception

svn:global-ignores ~$*

DirectoryNotFoundException: Could not find a part of the path

I can't reproduce this in any way. This may be due to me not having Chinese localization - I see that the project path includes some Chinese symbols. I tried having such symbols, but this resulted in other problems that I don't see in your screenshots. I see some strange things in your screenshots, but it is really hard for me to debug it without proper setup.
I'm afraid I can't help with this. If you try to debug it yourself and manage to find a good solution, please, let me know. Otherwise I'll close this ticket after some time.

Process. OutputDataReceived returned data will garbled.
I try to modify the ProcessStartInfo StandardOutputEncoding, but no normal results.  I'm at a loss for ideas.
I'm sorry to have delayed your time.
╮(╯▽╰)╭  Very helpless

Sorry I couldn't help. Maybe try naming your folders and files only with English letters.
Closing this ticket for now, if you find a solution, please let me know.


docs: Correct typo on README

Correct npm installation command
npm install react-rough rough

npm uses npm install <package-name> or npm i <package-name> not npm add ...

It was intentional. Not a typo. npm add is an alias for npm install
https://docs.npmjs.com/cli/install


Moves lint and format to make, managed by bingo

This removes a few shell scripts and in the process updates linters to
more current versions. For example, we were using golangci from 2019. To
adjust, some invalid statements were removed.
This also adds goimport formatting, used by some of our other projects.
The main part of this change is using https://github.com/bwplotka/bingo
as the linters we used were go programs anyway. Bingo generates make
entries you can use to on-demang install tools without affecting your
go.mod and without shell scripts.
Fixes #131

@mathetake can you disable circleci? I finished the almost done migration here https://app.circleci.com/settings/project/github/tetratelabs/getenvoy

some kooky stuff in tests like this. I'll get to the bottom of it..
vet: in github.com/containerd/containerd/remotes, can't import facts for package "context": open $WORK/b002/vet.out: no such file or directory
open /tmp/go-build2538038221/b1114/vet.cfg: no such file or directory

I think I have to rollback the circleci -> GH action thing until we can kill ginkgo #130 as normal tests are passing, but then the whole thing crashes. I was hoping I wouldn't have to fix circleci, but seems the case.
I'll summarize the crashing thing in #100

UPDATE: there's a panic in #133, once that's sorted I'll rebase this, eliminating the circleci thing, which I've documented in #100

@codefromthecrypt

I think I have to rollback the circleci -> GH action thing until we can kill ginkgo #130 as normal tests are passing

This statement is simply not true:

here is a CI build (based on this PR) that runs all Go std tests and excludes Ginkgo-based ones - it is failing
here is a CI build (based on this PR) that runs all Ginkgo-based tests and non-problematic Go std tests - it is successful

rebased over the go 1.16 PR and removed the circleci related changes

failure seems to repeat. will look into it..
/home/circleci/.getenvoy/builds/standard/1.11.0/linux_glibc/bin/envoy: text file busy

opened #136 about the strange test dep on a hard-coded envoy version

FYI "Run unit tests on Linux" is stale.. this is a known issue when you have added GH actions then remove it on the same PR. It still shows up in the output.

thanks for helping @mathetake


When are ENV variables or secrets shared with the client / how to wrap external API calls so keys are never exposed to client

Something I'm not clear about is when secrets are exposed to the client.
Let's say we have a SSR or server-based astro instance that might have live React components.
This might include code that fetches from an external API, and the URLs and keys for this API are stored in .env.
In what cases would astro be surfacing those API keys to the client? There's a lot of magic happening so it's not totally obvious how to keep those API keys secret, or how those API calls should be wrapped so the API key is never exposed to the client.
There's the PUBLIC_ idiom as defined here:
https://docs.astro.build/en/guides/environment-variables/
but I seem to be able to build live React components around any ENV vars. I'm assuming those aren't routed through astro in production.

API keys should not be exposed to the client in a client-server architecture, regardless of whether the app is using SSR (Server-Side Rendering) or not. API keys are sensitive information that should be kept private and protected.

Thank you for the issue @braco! As stated in the Environment Variables guide:

Note that while all environment variables are available in server-side code, only environment variables prefixed with PUBLIC_ are available in client-side code for security purposes.

If you are seeing behaviour different from that, that would be a bug, and it would be great if you could open an issue with a reproduction in the main astro repo: https://github.com/withastro/astro