How do we use GenerateSasUri to create a SAS based on a storage access policy?

Library name and version
Azure.Storage.Blobs 12.14.1
Query/Question
We have code in SQL Server Management Studio to set an access policy on a container and generate a SAS based on that access policy. That SAS is then used as a credential by SQL Server to enable backup to/restore from URL.
I am trying to port the code from the old WindowsAzure.Storage SDK to the new Azure.Storage.Blobs SDK and I can't find an equivalent way to generate a SAS based on the access policy.
The old code is below. Note that CloudBlobContainer.GetSharedAccessSignature had a override that accepts the SharedAccessBlobPolicy as a parameter.
In the new SDK I don't see any parameters for BlobContainerClient.GenerateSasUri or BlobSasBuilder that are related to the access policy.
/// <summary>
        /// Create Shared Access Policy for container
        /// Default Accesss permission is Write/List/Read/Delete
        /// </summary>
        /// <param name="container"></param>
        /// <param name="policyName"></param>
        /// <param name="selectedSaredAccessExpiryTime"></param>
        public static string CreateSharedAccessPolicyOnContainer(CloudBlobContainer container, string policyName, DateTime selectedSaredAccessExpiryTime)
        {
            //Create a new stored access policy and define its constraints.
            SharedAccessBlobPolicy sharedAccessPolicyForContainer = new SharedAccessBlobPolicy()
            {
                SharedAccessExpiryTime = selectedSaredAccessExpiryTime,
                Permissions = SharedAccessBlobPermissions.Write | SharedAccessBlobPermissions.List | SharedAccessBlobPermissions.Read | SharedAccessBlobPermissions.Delete
            };

            //Get the container's existing permissions.
            BlobContainerPermissions permissions = container.GetPermissions();
            if (!permissions.SharedAccessPolicies.ContainsKey(policyName))
            {
                //Add the new policy to the container's permissions.
                permissions.SharedAccessPolicies.Add(policyName, sharedAccessPolicyForContainer);
            }
            else
            {
                // if already exists, remove then recreate the policy to get expircy/permission right.
                SharedAccessBlobPolicy existingSharedAccessPolicyForContainer = new SharedAccessBlobPolicy();
                permissions.SharedAccessPolicies.TryGetValue(policyName, out existingSharedAccessPolicyForContainer);

                permissions.SharedAccessPolicies.Remove(policyName);
                container.SetPermissions(permissions);
                permissions.SharedAccessPolicies.Add(policyName, sharedAccessPolicyForContainer);
            }
            container.SetPermissions(permissions);
            permissions = container.GetPermissions();

            // verify access
            string sharedAccessSignatureForContainer = container.GetSharedAccessSignature(sharedAccessPolicyForContainer).TrimStart('?');
            if (string.IsNullOrEmpty(sharedAccessSignatureForContainer))
            {
                throw new InvalidCredentialException(SR.InvalidCredential);
            }
            return sharedAccessSignatureForContainer;
        }

This is what I've got so far for the replacement using the new SDK. What should I replace my container.GenerateSasUri call with to use the access policy I created for the SAS key? As written, this code generates a SAS without the access policy parameter.
        public static string CreateSharedAccessPolicyOnContainer(BlobContainerClient container, string policyName, DateTime selectedSharedAccessExpiryTime)
        {
            //Create a new stored access policy and define its constraints.
            var sharedAccessPolicyForContainer = new BlobSignedIdentifier()
            {
                Id = policyName,
                AccessPolicy = new BlobAccessPolicy()
                {
                    PolicyExpiresOn = selectedSharedAccessExpiryTime,
                    Permissions = "wlrd" // Write | List | Read | Delete
                }
            };

            //Get the container's existing permissions.
            var existingPolicy = container.GetAccessPolicy().Value;
            var permissions = existingPolicy.SignedIdentifiers.ToList();
            var existingPermission = permissions.FindIndex(b => b.Id == policyName);
            if (existingPermission == -1)
            {
                //Add the new policy to the container's permissions.
                permissions.Add(sharedAccessPolicyForContainer);
            }
            else
            {
                permissions[existingPermission] = sharedAccessPolicyForContainer;
            }
            container.SetAccessPolicy(existingPolicy.BlobPublicAccess, permissions);

            // verify access
            string sharedAccessSignatureForContainer = container.GenerateSasUri(Sas.BlobContainerSasPermissions.Write | Sas.BlobContainerSasPermissions.List | Sas.BlobContainerSasPermissions.Delete | Sas.BlobContainerSasPermissions.Read, selectedSharedAccessExpiryTime).Query.TrimStart('?');
            if (string.IsNullOrEmpty(sharedAccessSignatureForContainer))
            {
                throw new InvalidCredentialException(SR.InvalidCredential);
            }
            return sharedAccessSignatureForContainer;
        }

Environment
Visual Studio 2022 with SDK 7 building for .Net 4.7.2

@shueybubbles Thanks for reaching out to us and reporting this issue. We are looking into this issue and we will provide an update.

@shueybubbles Could you please refer the sample code snippet provided in this article ? Hope this helps.

thx I'll give it a try. The API docs and the samples are very scattered about between github and learn.microsoft.com. Also, the nomenclature used in the SDK is not very intuitive. "Signed identifier" is practically meaningless to someone whose experience with Azure storage centers on nouns like "permission" and "access policy".

that works. thx


Disable failing rendertests for Intel GPU

For #1896

Background
Following render tests are failing when run on GPU, blocking engineers in opening PRs.
Add a mechanism so render test can specify GPU name , on which it should be skipped
Disable following render tests on Intel GPU (some of these are failing randomly)

path-lnglat
path-lnglat-64
arc-lnglat
arc-lnglat-64
line-lnglat
geojson-lnglat
geojson-extruded-lnglat
gridcell-lnglat
grid-lnglat
hexagoncell-lnglat
pointcloud-lnglat
pointcloud-lnglat-64

Change List

Disable failing render tests for Intel GPU

I will re-enable these tests once actual problem found and fixed #1902


Fetch additional attributes in show's "after" hook

According to your documentation in that link, you have stated that "after" can be used to fetch additional data after the original handler is being performed. Sorrowfully, if that additional attribute is an array of references, I receive the following error.
Error: Objects are not valid as a React child (found: object with keys {users, _id, match, title, createdAt, updatedAt}). If you meant to render a collection of children, use an array instead. in DefaultPropertyValue (created by Show$2) in div (created by styled.div) in styled.div (created by Show$2) in Show$2 (created by BasePropertyComponent) in section (created by styled.section) in styled.section (created by BasePropertyComponent) in ErrorBoundary (created by BasePropertyComponent) in BasePropertyComponent (created by Show$8) in section (created by styled.section) in styled.section (created by Show$8) in Show$8 (created by BaseActionComponent) in ErrorBoundary (created by BaseActionComponent) in BaseActionComponent (created by RecordAction) in section (created by wrapper__StyledWrapper) in wrapper__StyledWrapper (created by Wrapper$1) in Wrapper$1 (created by RecordAction) in RecordAction (created by Context.Consumer) in Route (created by App) in Switch (created by App) in section (created by styled.section) in styled.section (created by App) in section (created by styled.section) in styled.section (created by App) in App in Router (created by BrowserRouter) in BrowserRouter in ThemeProvider in Provider See development console for more details...
Finally, I want to complain about your documentation because it does not state the whole capabilities of your product! It gives short examples and for the simplest cases.

Hi, @m-nazmi - yes you are right regarding the documentation. Product is much bigger than the documentation describes. We try our best to update it and It is still work in progress (btw here is the latest beta documentation. In the same time, we are looking for any contributors willing to help us with that, so if you like you can participate you can:

write / update tutorial
fix JSDoc in source code

Everything in a regular Pull Requests to either admin-bro repo or admin-bro-dev (there are src for tutorials: https://github.com/SoftwareBrothers/admin-bro-dev/tree/master/docs-src). Also - anyone how reads this issue - you know what to do :)
Regarding the error you have I would need more information. Basically, you have to return originalResponse from the function. Because adminbro actions depends on the data inside inside (i..e list depends that in the response there will be a list of records: Array. So what you can do is to add additional properties to the response.
I've created recently 3 casts about basic things in admin bro as password hasing and file upload - they in http://jscasts.tv/ (3 last screencasts. You check them out to see how to change the response in before/after hooks


Uninformative error when initialising a form with no active pages

If you try and render a form with no active pages (eg: one input set to relevant="false()") the error message you get doesn't help diagnose the issue.
For example, this form:
<?xml version="1.0"?>
<h:html xmlns="http://www.w3.org/2002/xforms" xmlns:ev="http://www.w3.org/2001/xml-events" xmlns:h="http://www.w3.org/1999/xhtml" xmlns:jr="http://openrosa.org/javarosa" xmlns:orx="http://openrosa.org/xforms" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
  <h:head>
    <h:title>Test Issue 4279 A: timer with relevant</h:title>
    <model>
      <instance>
        <issue_4279_a delimiter="#" id="issue_4279_a" prefix="J1!issue_4279_a!" version="2018-03-08 17-42">
          <group>
            <timer/>
          </group>
          <meta>
            <instanceID/>
          </meta>
        </issue_4279_a>
      </instance>
      <instance id="contact-summary"/>
      <bind nodeset="/issue_4279_a/group/timer" readonly="true()" relevant="false()" type="string"/>
      <bind calculate="concat('uuid:', uuid())" nodeset="/issue_4279_a/meta/instanceID" readonly="true()" type="string"/>
    </model>
  </h:head>
  <h:body class="pages">
    <group appearance="field-list" ref="/issue_4279_a/group">
      Testing Timer
      <input appearance="countdown-timer" ref="/issue_4279_a/group/timer">
        Text for timer
      </input>
    </group>
  </h:body>
</h:html>

Causes this stack trace to be logged and returned in load errors:
TypeError: Cannot read property 'scrollIntoView' of undefined
    at Object.focusOnFirstQuestion
    at Object.flipTo
    at Object.flipToFirst
    at Object.init
    at Form.init
    ...

What's happening is the flipToFirst function is passing the 0th element of an empty array (ie: undefined) to the flipTo function which calls the focusOnFirstQuestion. Everything is null safe until the very last line which throws the Error. The Error is caught, logged, and returned in the Form.init.
I can see two ways to make this more useful:

If this form is technically valid but useless, then add a null check to the focusOnFirstQuestion function and allow the empty form to be rendered. The user will then be able to work out what's wrong and fix the issue.
If this form is invalid then when we discover that $activePages is empty create a new Error with a descriptive error message and append this to loadErrors and return without logging. This allows the calling application to handle it gracefully and improves the usefulness of the message shown to the user.

I'm happy to provide a PR to fix this but would appreciate any feedback on what the correct approach is.

I think this issue has been "fixed" (though perhaps unintentionally).  The important thing that has changed between when this issue was logged (4.41.6) and now is how the page.activePages array is filtered.
Previously the old _updateAllActive function would keep a page if this evaluated to true:
$this.find( '.question:not(.disabled)' ).length > 0

The updated _updateAllActive function replaced that check with the following:
el.querySelector( '.question:not(.disabled)' )

When I load the sample form provided above using the latest version of enketo-core, I do not see the error. Debugging into the execution I can see that the page is added to activePages because el.querySelector( '.question:not(.disabled)' ) returns an empty object ({}) that is evaluated as true. (Meaning that pages without enabled questions could still be considered "active".)
Additionally, (and probably more relevant for this issue), the updated _flipTo function only ever calls _focusOnFirstQuestion if either current or pageEl exist (which would be false anyway even if activePages was empty).


think about preference elicitation in ScPo context

at wharton:

choose utility 0-100 for each course
can choose pairwise adjustment for courses that are preferrably taken together (choose 200 if very preferrable to take together, choose -200 if not preferrable at all)

do we need that? what else do we need that is specific to ScPo? may need to look at the ScPo report on coursematch for this.

I completely agree to that, the problem can be broken down into smaller problems, which will make our job easier.
I was wondering if we should allow every student to express preferences on each and every couple.
Moreover I was asking myself a question :

Should we allow student to express preferences on each and every couple of class ? If we do, should we allow student to express preferences only on couples of electives, or can they also express the fact that they want this "Tronc commun" class and this elective ?
Or should we limit the number of cross-preferences they can express ?

Good question concerning how many couples a student should be allowed to define. In general, I'd say that a richer set of information will yield a better fit for the student in question. However, one concern could be that students spend a lot of time on defining a lot of couples. To save them from this work, one could limit it.
Regarding the second question related to cross-complementaries between Tronc commun and CC: I think that the value added of it is marginal and it makes things more complicated.


Adds interoperability with Inventory Profiles Next.

The added annotation disables Inventory Profiles Next handling for all screens and containers.
Unfortunately this also catches the Cabinet which is real container and I guess some player might want to sort and have fast move items from their inventory into it.
This is a limitation of my API on which I will be working to fix :smile:

Hi, thanks for the PR! However adding a new soft-dependency just for an annotation isn't really appealing, I've been wanting to reduce unnecessary APIs for a while. But I'm willing to help you find a new solution, I was thinking maybe you could use the ScreenHandler's IDs which you can specify in a config file for a blacklist.

Hi,
I do have a config file that achieve the same thing. However the efforts needed to maintain such config file will grow exponentially over time.
For example coming up with the current state of the config file took me more then an hour for agap.* because it's not open source and I had to manually go to all their blocks to find all containers.
This is the reason I first try to convince people to include it their mods :smile:
Just as an example for possible solution. The guys from Better End decided to package the annotation class in their mod to avoid the dependency. https://github.com/paulevsGitch/BetterEnd/pull/326
I was also thinking that just having an annotation IPNIgnore even in different package will be sufficient.
Anyway if you decide that you prefer that I include your containers in my config file I would ask if you change something to drop me an issue so I can fix the config.

What about adding support for regex matching in your configs? That'd probably reduce a lot of lines in that config file

People tend to have all of their containers in the same package :smiley: Space Dimensions, the agap from above, also have storage blocks in the same package.
I guess I can have regex and includes or excludes for the it. I'll think about it.


Does the Load checkpoint node support using Flux model?

Or can it only use the specified Realisticvision model?

IC Light currently works with SD1.5 only. Any SD 1.5 checkpoint will do. SDXL, FLUX, etc are not compatible.


Pass nr_class as the number of classes

The architecture softmax_last_hidden does not consider the number of classes when building the final softmax layer. This PR fixes this issue. Together with commit 1adeac6, they would resolve issue #39.

Thanks!


Type hinting ipython_magic.py

The InteractiveShell typing on line 29 was my conclusion of what the type is from my research, but I may be wrong.
Part of the long series of PRs that will work towards #52.

Whoops, thought for sure I'd already used it somewhere else in the file.


Android benchmark refactoring

Here is a series which improves the current support for Android workloads execution to easy the
customisation of their execution as well as the integration with a possible CI back-end.
Main modifications are:

refactoring of libs/utils/android/workloads/* to support both energy sampling and trace events
introduction of a new base class libs/utils/android/benchmark.py which allows to wrap and customise the execution of one of the supported Android worklaods
addition of an initial example of Jankbench benchmark customisation to evaluate how different CPUFreq governors affect energy and performances

The newly introduced benchmark can be executed from a local LISA shell using for example this command:
[LISAShell lisa] \> python tests/benchmarks/android_jankbench.py \
                      --android_home /data/Android/android-sdk \
                      --results_dir MyJankbenchTest \
                      --iio_channel_map "PixelPhone:2"

To check all the supported command line options:
[LISAShell lisa] \> python tests/benchmarks/android_jankbench.py --help

I've added a few commits at https://github.com/ionela-voinescu/lisa/tree/android_benchmarks to support UiBench once we've finished with the proof of concept for Jankbench.

Addressed last comments from @ionela-voinescu:

renaming test to be JankbenchTest
added a delay_after_s parameter to the JankbenchTest, which is set ot 30s for all runs but the last

There are two issues I've seen during the tests last night:

Every other reboot fails with:

2017-02-24 10:12:39,278 WARNING : Benchmark    : Benchmark initialization failed: execution aborted
[snip]
STDERR: /system/bin/sh: cat: /sys/class/power_supply/battery/charging_enabled: Permission denied

If the governor is not available on the target platform the test should be stopped. At the moment it just throws a warning and continues.

Regarding the failures on reboot: can you share a little bit more logging?
Looking at the code I can see that we should force adb in root mode right before touching that file... maybe there are some issues restarting adb in root mode.

Update to:

fix  benchmarkInit to raise exceptions as expected by the base class
catch exceptions to skip tests execution for governors not available
report a test failure if we are not able to run with at least two different governors

@derkling: For the adb root issue, the https://github.com/ARM-software/devlib/pull/92 fix was just merged into devlib (thank you for the suggestion).
Therefore, we're one devlib update and an adb_root(force=True) away from merging :D.

Updated adb root forcing... but NOT tested... could you @ionela-voinescu give it a run before (eventually) merging?

@derkling: Sure! I'm rebasing all my work on top of these changes so I'll merge it when I've tested it.


Enable linux and win

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender

@isuruf -- For the austin build we were discussing on staged-recipes, moving to the feedstock fixed the linux build. I'm still having issues with the windows build.
Originally in staged-recipes, I followed the directions in:
https://github.com/conda-forge/autotools_clang_conda-feedstock/blob/master/recipe/meta.yaml#L35-L68
which said to include the following line, [[ "$target_platform" == "win-64" ]] && patch_libtool in the build.sh, but in the staged-recipes PR, you removed that line (https://github.com/conda-forge/staged-recipes/pull/12199/commits/374b31f48644bc091b71d1e1110943cbab716749).
I tried sticking that back in, but it's still failing. The original message in the logs before I started experimenting with the patch_libtool was:
https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=219066&view=logs&j=5be07ae1-d8ba-5406-47b6-8e3a3a12f825&t=0bf03e01-0bec-5b85-5316-b1633322e895&l=574
. /argparse.h:35:3: error: unknown type name 'pid_t', which I think has something to do with the process id and forking not being available on Windows, but I'm not sure.
Any suggestions would be appreciated.

Hi! This is the friendly automated conda-forge-linting service.
I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.
Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

. /argparse.h:35:3: error: unknown type name 'pid_t', which I think has something to do with the process id and forking not being available on Windows, but I'm not sure.

Yes, you'll have to fix the source code for this


iOS build errors with ExpoSplashScreen

Running into an issue building wallet on iOS, on main.
To reproduce:

rm -rf node_modules
npm install --legacy-peer-deps # (needed for npm 7)
cd ios
pod install

gives the following warning:
Found some duplicated unimodule packages. Installed the ones with the highest version number.
Make sure following dependencies of your project are resolving to one specific version:
 expo-splash-screen

But then, when building in XCode (on iPhone 8+ hardware), gives the following build error:
In file included from ~/code/DCC/learner-credential-wallet/ios/eduwallet/AppDelegate.m:11:
~/code/DCC/learner-credential-wallet/ios/Pods/Headers/Public/EXSplashScreen/EXSplashScreenService.h:5:9: fatal error: 'ExpoModulesCore/EXSingletonModule.h' file not found
#import <ExpoModulesCore/EXSingletonModule.h>

(I'm on cocoapods 1.11.0)

Building the Android app on linux gives something very similar.

* What went wrong:
Execution failed for task ':expo-splash-screen:compileDebugKotlin'.
> Compilation error. See log for more details

I suspect I know what is causing this: expo-app-loading requires expo-splash-screen ~0.14.0 while the version in package.json is ~0.11.2. So 0.14.2 will be used, but according to the expo-app-screen docs here going from < 0.12.0 to above requires code updates and migration from react-native-unimodules to expo-modules-core

I halfway did the migration to expo modules to get the build running: https://github.com/digitalcredentials/learner-credential-wallet/compare/main...dirkcuys:expo-modules?expand=1
But then I got the following error: (I think it's unrelated)
error: Error: Unable to resolve module ./util.js from<EMAIL_ADDRESS>

None of these files exist:
  * node_modules/@digitalcredentials/bnid/dist/util-reactnative.js(.native|.android.ts|.native.ts|.ts|.android.tsx|.native.tsx|.tsx|.android.js|.native.js|.js|.android.jsx|.native.jsx|.jsx|.android.json|.native.json|.json)
  * node_modules/@digitalcredentials/bnid/dist/util-reactnative.js/index(.native|.android.ts|.native.ts|.ts|.android.tsx|.native.tsx|.tsx|.android.js|.native.js|.js|.android.jsx|.native.jsx|.jsx|.android.json|.native.json|.json)
  4 |
  5 | var base58Universal = require('@digitalcredentials/base58-universal');
> 6 | var util = require('./util.js');
    |                     ^
  7 |
  8 | /*!
  9 |  * Copyright (c) 2020 Digital Bazaar, Inc. All rights reserved.
    at ModuleResolver.resolveDependency (/home/dirk/workspace/mit/learner-credential-wallet/node_modules/metro/src/node-haste/DependencyGraph/ModuleResolution.js:211:15)
    at DependencyGraph.resolveDependency (/home/dirk/workspace/mit/learner-credential-wallet/node_modules/metro/src/node-haste/DependencyGraph.js:413:43)
    at Object.resolve (/home/dirk/workspace/mit/learner-credential-wallet/node_modules/metro/src/lib/transformHelpers.js:317:42)
    at resolve (/home/dirk/workspace/mit/learner-credential-wallet/node_modules/metro/src/DeltaBundler/traverseDependencies.js:629:33)
    at /home/dirk/workspace/mit/learner-credential-wallet/node_modules/metro/src/DeltaBundler/traverseDependencies.js:645:26
    at Array.reduce (<anonymous>)
    at resolveDependencies (/home/dirk/workspace/mit/learner-credential-wallet/node_modules/metro/src/DeltaBundler/traverseDependencies.js:644:33)
    at /home/dirk/workspace/mit/learner-credential-wallet/node_modules/metro/src/DeltaBundler/traverseDependencies.js:329:33
    at Generator.next (<anonymous>)
    at asyncGeneratorStep (/home/dirk/workspace/mit/learner-credential-wallet/node_modules/metro/src/DeltaBundler/traverseDependencies.js:137:24)

At some stage I also managed to fix the build by pinning the version of expo-app-loading, but then I tried to delete node_modules again and got stuck

Thanks @dirkcuys, that's great data points!  I'll look into the 'bnid' issue, I think that's unrelated, and I know how to fix it.

@dirkcuys - I published a patch fix to package<EMAIL_ADDRESS>which should fix that 'unable to resolve module' error.

After some debugging, it looks like this issue was introduced in commit 215f61f06830700c41ab7eea3ed23719bd428515 when expo-app-loading was indirectly upgraded from 1.1.2 → 1.3.0 (I imagine we ran npm update).
Luckily, @dirkcuys solution of pinning expo-app-loading to 1.1.2 resolved the build issue for me, so I've submitted PR #115  with this change.
If we still wanted the latest version of expo-app-loading we'd have to do a couple of things:

Migrate from react-native-unimodules to expo-modules (as @dirkcuys noted)
Upgrade to Expo SDK 43 (or 44) - not a major issue but could potentially break a few things
Ensure that none of our dependencies require @unimodules/core (having both causes issues with duplicate symbols for iOS)

Right now, isomorphic-webcrypto includes @unimodules/core in our dependency tree:
<EMAIL_ADDRESS>└─┬<EMAIL_ADDRESS>  └─┬<EMAIL_ADDRESS>    └─┬<EMAIL_ADDRESS>      ├──<EMAIL_ADDRESS>      └──<EMAIL_ADDRESS>
I've opened draft PR #116 with the expo-modules migration, but we would have to wait until isomorphic-webcrypto migrates to expo-modules as well.
There was an issue opened in the repo (https://github.com/kevlened/isomorphic-webcrypto/issues/57), but it has been closed by author.

Fixed in main as of PR #115.
Thank you so much to both @sethduffin and @dirkcuys for working on this!
I suspect that we'll need to continue the approach started in PR #116, but pinning app-loading is a fantastic meantime fix.


Support /oauth2/@me endpoint

When trying out twilight-http-proxy, I found out that /oauth2/@me doesn't work.
I'd like to add it to the OauthApplicationsMe path.
This endpoint is helpful for web apps since it allows you to get info and scopes about a current token.
Update: I aded ["oauth2", "@me"] => OauthApplicationsMe, to Path FromStr, rebuilt twilight-http-ratelimiting, and built the http-proxy crate, and it works.
Mind you, I haven't put any testing in place, not sure I need to.

Duplicate of #1643


Artifactory Identity token

Hi Developers,
We need to use Artifactory Identity token instead of API Key:
https://www.jfrog.com/confluence/display/JFROG/User+Profile#UserProfile-identitytoken
Technically the request on Artifactory should change like so:
https://www.jfrog.com/confluence/display/JFROG/Access+Tokens#AccessTokens-AuthorizationHeaders
# Old: API key:
 curl -H 'X-JFrog-Art-Api:$API_KEY' "https://some.artifactory.com/artifactory/my-repo/my_artifact.bin"
# New: Identity token:
 curl -H 'Authorization: Bearer $USER_TOKEN' "https://some.artifactory.com/artifactory/my-repo/my_artifact.bin"

I was able to monkey patch the _request method like so:
https://github.com/Orange-OpenSource/rtpy/blob/master/rtpy/tools.py#L253
        if self._user_settings["X-JFrog-Art-Api"]:
            # Use Artifactory identity token instead of API key
            #headers = {"X-JFrog-Art-Api": self._user_settings["X-JFrog-Art-Api"]}
            headers = {"Authorization": f"Bearer {self._user_settings['X-JFrog-Art-Api']}"}

This is not very nice. So would you agree to add this feature?
Or do you see another better way without code changes?
I think it is not a big thing. I can also add a pull request if you like.
Best regards,
Adrian

Hi Adrian, I'm no longer maintaining the project as I don't work for the company that released it, you can however open a pull request to discuss and show your suggested changes. I can reach out to some of my former colleagues who could potentially publish a new release.
If you do open the PR, please do run the tests to make sure everything is still working (only run the test on a Artifactory test instance).
Hope that helps!
Guillaume


Member page redirect to rel. location of directory

When moving the member page below another page (i.e. as a child page), this redirect causes a 404. By making it relative to the location of the member page, it becomes possible to move the member page.
This appears to occur on other occassions in the core as well, in various forms, such as when redirecting to the login page using $this->redirect('/login/');. This seems to be a bit more intricate than the situation with the member pages, though, and not as easy to resolve.

I don't seem to get a 404 here on redirect.

I'm going to close this for now since I cannot replicate. @joostrijneveld can you provide before and after urls and maybe a screenshot of what's happening? I can't replicate the issue you describe.

@KorvinSzanto I think he's saying that since the paths are hard coded if you move the members page the redirect will 404, because there's no longer any page available at that path.
That's correct – we don't support moving the members page around. If you need to do something like that you'll have to roll your own single page/controller at the path you want it to be at.

@aembler That's indeed what I'm getting at.
I understand if you choose not to support moving the member page around, and overriding the single page is indeed how I have solved this locally at the moment. The sitemap dashboard page does enable moving the member pages, though, resulting in confusing behaviour when one is unaware that this is in fact not supported all the way through. It would be quite an overhaul to make this work for all system pages, however, and I can understand that consistency is more desirable here.

Could we maybe add something to the config like a pagePaths override which the URL class could handle?

No, this should just be using $this->action() then. I think I'll put in a fix that makes PathUrlResolver return the url if the passed path is a valid URL, then change this to be $this->redirect($this->action('directory')).

@KorvinSzanto ah ya I forgot about $this->action() that makes sense to me

Ah, indeed, that's a much cleaner solution, when $this->action can be used that way. Thanks!


Generate client bundle using url from hoodie host and port config

This would fix #519
The only problem is the hardcoded protocol (http), it would be better if Hoodie constructor accepted an protocol-agnostic url like this new Hoodie('//<IP_ADDRESS>:8080'), but currently it doesn't work, could be tackled on a future PR
Another solution (which I prefer, but would have more impact) would be stop instantiating hoodie on client.js, and let users do the new Hoodie(opts)

You can use the client.url config for that, but I agree we could default that value to 'http://' + config.connection.host + ':' + config.connection.port unless client.url is set.
Would that make sense? If yes, could you adapt your PR? I would suggest to add another test to plugins-client-bundle-test.js

Yeah but right now I can't set this config also, it isn't picked up even if I pass --config.url when starting hoodie

Yeah but right now I can't set this config also, it isn't picked up even if I pass --config.url when starting hoodie

What Hoodie version do you have currently installed in your app? npm ls hoodie will tell you

I’m sorry, it doesn’t seem to work, just tried it myself. Sorry for the confusion. I thought i had it working before ... I’m looking into it

Okay I fear it never got implemented properly. We currently combine the rc options with options from the package.json (on the "hoodie" key), but we don’t set config.client from the options. I’ll look into this today
Your suggestion to default the client URL to config.connection will work on your machine, but once you deploy it the internal IP address will not work, the URL will rather be something like https://myapp.com than <IP_ADDRESS>:8080. So this could also break applications, because if no URL is passed, it will connect to the same host which will always work if you load assets from the the same host, while setting it to config.connection will break it.

Yes, you are correct, I haven't thought about this, so instead we should fix reading the client options, I'll close this PR then 👍

this one should fix the problem: https://github.com/hoodiehq/hoodie/issues/522


Schema in JSON

Describe the bug
this is the first time schema

this is the second time schema

but it report an error

when I revise the ddd field to String type,it can create producer and send message

are you saying to can't add a int field ?

are you saying to can't add a int field ?

it can't add primitive types but it can add boxing field
because it can judge  whether or not the field’s null


Adding Language and style, deprecating voice name

Adding TextToSpeechLanguage and making it a field in both the Talk request and the TalkAction, along with style. Also marking VoiceName as deprecated. Resolves #357
Contribution Checklist

[x] Unit tests!
[ ] Updated CHANGELOG.md
[x] My name is in CONTRIBUTORS.md

Codecov Report

Merging #358 (0db8382) into master (b3651cb) will increase coverage by 0.18%.
The diff coverage is 98.91%.

@@             Coverage Diff              @@
##             master     #358      +/-   ##
============================================
+ Coverage     90.19%   90.38%   +0.18%
- Complexity     1496     1509      +13
============================================
  Files           262      263       +1
  Lines          4102     4191      +89
  Branches        192      192
============================================
+ Hits           3700     3788      +88
- Misses          351      352       +1
  Partials         51       51

Impacted Files
Coverage Δ
Complexity Δ

...main/java/com/vonage/client/voice/VoiceClient.java
93.10% <75.00%> (-2.90%)
21.00 <3.00> (+3.00)
:arrow_down:

...main/java/com/vonage/client/voice/TalkPayload.java
92.30% <100.00%> (+8.97%)
7.00 <3.00> (+2.00)

...main/java/com/vonage/client/voice/TalkRequest.java
93.10% <100.00%> (+4.86%)
10.00 <5.00> (+3.00)

.../com/vonage/client/voice/TextToSpeechLanguage.java
100.00% <100.00%> (ø)
3.00 <3.00> (?)

...c/main/java/com/vonage/client/voice/VoiceName.java
99.07% <100.00%> (ø)
6.00 <2.00> (ø)

.../java/com/vonage/client/voice/ncco/TalkAction.java
100.00% <100.00%> (ø)
10.00 <2.00> (+2.00)


Fixed issue #4181

This is my proposed fix for issue #4181

I created a fix for this f8d896536dfae0a047c008bdcdb9d6d92bf6ad3a


An Event Emitter Example

Thanks for good example and article @valdio
I have a question. I already implement Kotlin module in my React native project. But my need is this:
I have a activity which is written in Kotlin and I am opening it in my RN Project. I want to fire an event from this Kotlin page throught to JS side. I did same part in my MainApplication.java  file. I created EventEmitter module also and I can trigger it. But from Kotlin Activity, I dont have an ReactApplicationContext in Kotlin Activity. Could you please give an idea about, how can I trigger event to JS from Kotlin Activity ? I am not good at Kotlin and I search couple days for event emitter topic but I always find an open Activity example.
Thanks for your time

Hi @fatihayyildiz
Your requirements seem too specific and I cannot think of any solution with the provided information. maybe you can give me a demo of what you are trying to build!
Closing this issue because is not related to the example. You can continue to add comments in this thread.


Summaries: Sequence Number Verification error

eventName = fluid:telemetry:SummaryManager:SummarizerException
error = Load from summary, runtime metadata sequenceNumber !== initialSequenceNumber
Can you please take a look why we are hitting this error in prod?
Is this something to worry about?

This is the telemetry that Arin added for earlier detection of the InitialElectedClientNotFound error that we were getting. We stopped hitting InitialElectedClientNotFound a while ago, probably thanks to an ODSP change, so it's interesting that we're hitting this other error now. I'll see if I can make sense of it.

No activity in a few weeks. Will revisit if it pops up again. The symptom was that ContainerRuntime.load is using a snapshot that is behind the DeltaManager's initialSequenceNumber. The assertion that the 2 sequence numbers must match may not be valid. This is something that seems to crop up every so often when server-side changes are made and to vanish again when other server-side changes are made.

I noticed the following in the documents that have this error:

They summarized with version 0.53 / 0.54 till sequence# X.
Then they summarized with version 0.47.1 from sequence# > X to sequence# Y.
After this, clients running later versions can't load with summaryMetadataMismatch error. The runtime sequence# is X and protocol sequence# is Y.

This is strange. It looks like the client is getting the summary from # 1 but the protocol blob is from summary in # 2.
Alternatively, we could be adding the wrong message to the metadata blob in 0.47.1. This seems unlikely because I would expect the failure to be in clients running 0.47.1 as well. But the failure happens as soon as a client with newer version opens the document.

Also, the loaderVersion for # 2 in the above comment in 0.36.0. This could be due to some incompatibility between the driver / loader versions as well.


Extension appears to be corrupted on Firefox

The add-on downloaded from this site could not be installed because it appears to be corrupted.

Trying to install it from Github gives the same error.
Firefox 47.0
Ubuntu 16.04

I found the same thing.

Bums. It's something I noticed before but saw it working on Firefox nightly (a while ago now). Assumed it would be fixed in an upcoming release.
Feel free to point me in the right direction, otherwise I'll have a look into it when I get a spare weekend.
Thanks for submitting, @anewuser!

I wonder if your extension will still work since Mixcloud has hidden tracklists completely now. It only shows the "now playing" info.
I believe that you just need to fix the ID in https://github.com/adlawson/mixcloud-tracklist/blob/master/manifest.json:
    "applications": {
        "gecko": {
            "id": "com.adlawson.mixcloud-tracklist",
            "strict_min_version": "45.0.0"
        }

id
The ID of the extension, which must be one of the following:
GUID (Firefox 1.0)
A string formatted like so<EMAIL_ADDRESS>
https://developer.mozilla.org/Add-ons/Install_Manifests#id

Ah okay, thanks for having a look. I'll test it out when I get some time.
Regarding whether the extension will still work or not: I made this extension because Mixcloud disabled the tracklists and I wanted the old experience back. The extension uses the same endpoint mixcloud use to display the names in the playerbar.

I meant that when you made the extension, Mixcloud still showed a button with a list of all songs already played from that set, but now you can't even see that anymore.

I found the same issue. I converted the id to<EMAIL_ADDRESS>built xpi, disabled requiring signed add-ons and it now working. Finally I have Mixcloud track lists back!

@adlawson Firefox 48 still won't let me install it. Please merge @djg's commit.

Not sure it will help too much. Firefox requires extensions to be signed
too.
On 7 Sep 2016 07:02, "anewuser"<EMAIL_ADDRESS>wrote:
@adlawson https://github.com/adlawson Firefox 48 still won't let me
install it. Please merge @djg https://github.com/djg's commit.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/adlawson/mixcloud-tracklist/issues/12#issuecomment-245090559,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAJhrSiML2NNXllkUM40mshQnl6O6Gweks5qndUAgaJpZM4JDlIj
.

@djg Github should increase the time delay before sending people emails. You didn't get my edit:  "...and submit the update to Mozilla."

Yeah, sorry, I didn't see that. Mea culpa.
On 7 Sep 2016 10:59, "anewuser"<EMAIL_ADDRESS>wrote:

@djg https://github.com/djg Github should increase the time delay
before sending people emails. You didn't get my edit: "...and submit the
update to Mozilla."
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/adlawson/mixcloud-tracklist/issues/12#issuecomment-245143373,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAJhrdzmUxu1p_oW4t12VkCO2jCmypFBks5qngxsgaJpZM4JDlIj
.

@djg Can you fork it and submit it to Mozilla?

Hi both, sorry for the huge delay on getting this merged in.
I'm sitting down now to go through a bunch of PRs on various projects.
All the changes look good, so I'll just run through them on my local and get a new version published shortly.
I'll let you know when it's available.

It's been stuck "validating" for ages now. I've tried it a couple of times and just hangs.

I'll give it a bit longer but if it doesn't budge I'll try again tomorrow.
In the mean time, if you go to about:debugging in Firefox and temporarily load the mixcloud-tracklist.xpi from the latest release it should work til it's up on MDN.

I could fork, but I'd prefer not to.  I can look into trying to help get
the extension signed but it's probably better for @adlawson to sign with
his key.
On 25 September 2016 at 15:16, anewuser<EMAIL_ADDRESS>wrote:

@djg https://github.com/djg Can you fork it and submit it to Mozilla?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/adlawson/mixcloud-tracklist/issues/12#issuecomment-249403423,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAJhrec-K2PVxnzrJUcpmKzgDQIw4-Lqks5qtgO3gaJpZM4JDlIj
.

--
Dan Glastonbury, Dan dot Glastonbury at gmail dot com
`Pour encourjay lays ortras'

@djg @anewuser It's now submitted to MDN/AMO.
It needs to be reviewed and approved by Mozilla which is a bit of a pain, but hopefully it won't take long. In the mean time, my steps above to install it as a temporary "debug" add on should still work.

Thank you. I assumed that all ways to load unsigned extensions had been blocked, but the debugging page still does work on the stable branch.


working on the line broadening / please pull and help with the test file...

Normally, the linebroadeing is implemented with a test... but I cannot make my lineBroadening.test.js pass! Please have a look!

i fixed the problem


What format does image have to be in?

The example in the README doesn't show how the image variable gets created. And the documentation says

image: anything ctx.drawImage() accepts, usually HTMLImageElement, HTMLCanvasElement or HTMLVideoElement

Can it be changed to accept a string which is a path to an image file (for NodeJS)?

No, I won't handle image decoding in smartcrop. The next version (living in the canvas independence branch) will allow plugin in different image processing libraries so it can be used with gm for instance.


ci: Integrate mypy type checking

Codecov Report
Attention: Patch coverage is 86.66667% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 93.24%. Comparing base (afdec96) to head (1f74bb2).
Report is 1 commits behind head on main.

Files
Patch %
Lines

...rib/autodoc_pydantic/directives/autodocumenters.py
73.52%
9 Missing :warning:

...xcontrib/autodoc_pydantic/directives/directives.py
85.18%
4 Missing :warning:

sphinxcontrib/autodoc_pydantic/__init__.py
91.66%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #259      +/-   ##
==========================================
- Coverage   94.26%   93.24%   -1.02%
==========================================
  Files          12       12
  Lines        1116     1096      -20
==========================================
- Hits         1052     1022      -30
- Misses         64       74      +10

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Can anyone please tell me how to make webrtc call using headless browser ????

Steps to reproduce
Tell us about your environment:

Puppeteer version:
Platform / OS version:
URLs (if applicable):
Node.js version:

What steps will reproduce the problem?
Please include code that reproduces the issue.

What is the expected result?
What happens instead?

@aslushnikov Can you please let me know whether i can run an webrtc call using chrome headless ?
What i am trying here is :
Access the microphone of the machine using the chrome headless browser and join the webrtc meeting.
headless: false -----> works fine
headless: true ----> does not work (Browser is unable to access the microphone)


Made --no-metadata flag working

There is a --no-metadata flag described in readme which was not implemented yet.
With that PR its working.

Sorry, I completely missed this PR, will have a look. Please ping me if you don't hear anything back within a week!

@siprbaum ping

I don't exactly know what motivate the move but in fact the option was removed on purpose. See this commit of PR #283
I don't know if it's a good idea to implement it again as it is mandatory for git-tfs to work.
If you are exporting your history and after hours, for whatever reason it fails, without it, you are unable to continue and have to start again.
And that's not like this little text at the bottom of a commit is annoying...
It's even good to keep the link in case for future reference....
I forecast that some users will find a good idea to use it and in the end they will be beaten by this bad decision...
What is real the purpose you try to achieve by restoring this feature?
My point of view is more that we should clean the documentation of the remaining occurrence.

I want only a move "forward" - away from TFS to Git.
So I dont care about this tfs-id in the comment. Its only disturbing. Useless informations for the future. (ok the people only knows that this is a commit imported from TFS)
Then I searched and found: "Ah, in the documentation there is already this flag mentioned".
By the way: SVN -> GIT also has the same flag.
So I tried to use it ... Nothing happens. Bad.
So I implemented it. Now I'm happy with that & documentation is correct.
If you dont like this feature then update the documentation and stick to it.
But SVN to GIT has it, too: https://git-scm.com/docs/git-svn
And I did a whole SVN to GIT Migration in 2016 with 100+ repositories for a big company.
Even with --no-metadata.
And they working happy since that time with it.
Its not needed to know this ID because the TFS will shutdown few months after success migration.
So the only thing you know is: This is an commit imported by TFS.
Nothing more, nothing less. Because TFS is offline, removed and destroyed you can not do anything with that ID.
Its a feature like the others. You must not use it - but if you want you can.
Few lines of code. Nothing more, nothing less. @pmiossec

By the way: SVN -> GIT also has the same flag.

I didn't know that git-svn has something similar but reading quickly the documentation:

it is not recommended (as of git-tfs)
git-svn store also the mapping in some hidden files so is able to work without it whereas git-tfs can't. So for git-tfs it would be HIGHLY not recommended.

Few lines of code. Nothing more, nothing less

So even if it's only some little lines to maintain, it's probably more time spent on user support because someone used it without really understanding the consequences and come here to request help on fixing it's issue.
I think that I have implemented long ago reading the metadata from a commit git note (not sure and should be verified).
If it's the case, I think that such feature could be accepted only if in the same time this flag write the metadata in a git note that git-tfs is able to read.
And as git notes are not pushed by default, you will have the exact same output for you.

So I dont care about this tfs-id in the comment.

For me, you have a false feeling of not needing it... And even if it's perhaps true for you, I'm pretty sure it won't for the majority of users...
I understand that the more the time pass, the less the information is important but as it is a good practice to keep the TFVC history some months ins case the migration has not been perfect (I know, I maintain git-tfs during years), it could save your life to keep the metadata to be able to compare the changes. And I'm pretty sure that nearly 0% of git-tfs users knows that when doing there migration and finding this option.

Its only disturbing.

:dizzy_face: A little text at the bottom of a commit is disturbing!?!
You don't need much to be disturbed....
In 2 months, you will probably nearly never read these commit messages.
I work in a migrated repository and I don't remember the last time I saw one. In fact, now I know because due to our discussion, I just search of one 😁So it's maybe just a matter of being patient some weeks....


Is it possible to show all panels on mobile?

I really like how the script works but I have a particular situation where the content is getting pretty long and while I like having tabs on desktop I would prefer to have all panels expanded on mobile  to avoid a lot of scrolling up and down. Is this posible?
Thanks,
Gabriela

It's actually
``.r-tabs .r-tabs-panel {
display: block;
}`


'flatMap' is deprecated

Hey, after update to Xcode 9.3, I noticed that the "flatMap" is deprecated(Central.swift, line 169), can you please make a update by using "compactMap(_:) "

Ho shieeet, thanks for letting me know

Fixed on master


[Geolocation] Fix geolocation mock when nextPosition is set

Hey.
When nextPosition is set in geolocation mock, notify is not triggered so I fixed this.

Hey
There is a specific reason to not merge this fix for the moment?
Thanks

At the moment, there are conflicts. not your fault; but please rebase and re-issue this PR.


FIle is not a zip file

You must manually download the URL using gdown because the PyPI package was unable to do so because the link had expired.
Here is a sample of the code. I've included the notebook file in a compressed format as well.

N.B. Use a minimum of 16GB of RAM. Google Collab will crash when the model is loaded.
Attachment: BanglaFastText_issue.zip


Finalize CRA/Hypernova cookiecutter implementation

Just pushed up a partial update, things that remain to be fixed:

[ ] Get SSR working
[ ] Get asset proxy working (from web container to frontend=

I also noticed long install times on the frontend container, I'm considering adding a message to indicate about the install times (current is approx 260 seconds).

Next steps:

[ ] Add info message when node module needs to be installed
[ ] Investigate if we can run frontend outside of the cookiecutter template (to make frontend more portable)


[Program]: Write a GO program to find the maximum sum of a contiguous subarray

Description
Write a GO program to find the maximum sum of a contiguous subarray
Maximum subarray problem is the task of finding the contiguous subarray within a one-dimensional array of numbers which has the largest sum. For example, for the sequence of values −2, 1, −3, 4, −1, 2, 1, −5, 4; the contiguous subarray with the largest sum is 4, −1, 2, 1, with sum 6.
Input  : [-2, -3, 4, -1, -2, 1, 5, -3]
Output : 7

How to contribute

Save the solution in program/program/find-the-maximum-sum-of-a-contiguous-subarray/program/find_the_maximum_sum_of_a_contiguous_subarray.go file

!assign

!assign


add support to generate pulumi code

Hi,
I was wondering if you think adding support for pulumi (https://www.pulumi.com) is interesting for you.
This PR only adds basic support to the code generation. If you think this is something you would like to support, then I'm happy to spend more time on this to add the different features and add-ons to the generator.
/Domi

Thanks @imod this is definitely a very impressive work!
I’ll need to review it in more detail, but here are some first quick comments:

I would probably have coded this the same way as you. But I know this will cause maintenance issues as we grow, and I’d like to discuss/brainstorm on how we could have a more modular approach.
We will need to support Bicep, so anyway we’re going to need to do something similar at some point. Great to have a starting point!

@jdubois great, looking forward to discuss the next steps!

Hey @imod,
Your comment is coming at the right time! I've drafted a RFC about rearchitecting Nubes core generator. Your comments will be much appreciated :) https://github.com/microsoft/NubesGen/discussions/45

I had a talk with Pulumi - @imod I was surprised you didn't work there!
I believe this PR would work fine, and even if we can do something better, it would require a lot of work to have something fully pluggable.
So my main worry is the maintenance burden - having two separate set of templates would add a lot of work (trust me, I have this at a much higher level on JHipster, and that's a nightmare). And as I don't know Pulumi, I won't be able to help much here!
I'm going to spend some time investigating this: if we can handle correctly when an option isn't available in Pulumi (the user selecting the "Key Vault" option, which is only available for Terraform), we need to degrade correctly. Does that mean ignoring the option, or throwing an error? And how do we handle the UI? We could have 2 separate UIs, it's not that much work.

I'm sorry @imod as I did a lot of conflicts with your PR while moving code for GraalVM support (it's basically coding things differently to make GraalVM happy).
On the back-end side, I can't find a better idea than what you did, then I know @cmaneu would like something more automated.
Here's what I'm currently thinking about:

I'm going to copy your architecture to add Azure CLI support. This is because that's easier to do for me, and also as I know in advance that I won't be able to support everything with the Azure CLI.
Then, I'll have a look at refactoring the front-end to read some configuration, so it only displays part of itself depending on what the backend support. When choosing Terraform, you have the "full" front end, but when choosing Azure CLI, you have a partial frontend.

I have refactored the code to be fully generic, so we can support Pulumi and Bicep.
@imod I have added your commit (so you keep the credits) to my PR at #157
Let's keep this opened until #157 is done, but then this should be closed as it would be obsolete.
Thanks a lot @imod for your help here!!!

@jdubois thanks for this! ...and sorry I did not reply before! Yes, you'r right, I do not work at pulumi - but I do like it very much and I hope that maybe some more people get to know it with this effort :)
What do you see as the next steps to go on when this is merged? Just start to add the generation for the other resources?

@imod nothing is really holding this for being merged.... As far as I know everything works fine, I just wanted to do a few more tests.
Once this is merged, I would be super-happy if you can add more Pulumi support (as I don't know it at all), and @cmaneu is going to add some Bicep support.


Added some operations for drafts.

Added some operations for drafts.

Thx for the PR. These new funcs need unit tests and docstring. Please refer to the links below:
https://github.com/offu/WeRoBot/blob/master/tests/test_client.py
https://github.com/offu/WeRoBot/blob/master/werobot/client.py#L253


Be silent on renv.lock file errors until trying to deploy

Intent
This PR aims to stop showing or blocking the user on renv.lock file errors. Only showing the error when proceeding to deploy.
Fixes #2327
Screenshot of the new friendlier message

Type of Change

[x] Bug Fix

[ ] New Feature

[ ] Breaking Change

[ ] Documentation

[ ] Refactor

[ ] Tooling

Approach
Having a more structured and identifiable error to handle better the messaging when R packages cannot be scanned from the existing renv.lock file. Now logging out the errors as needed but not blocking the user until the renv.lock file scanning is absolutely required.
Automated Tests
Updated and added unit tests as needed.
Directions for Reviewers
Having an empty renv.lock, you shouldn't see an renv.lock related error message until trying to deploy.
Checklist

[ ] I have updated CHANGELOG.md to cover notable changes.

Both things are worth improving but might be worth to address in follow-up issues since are not considered blockers

Fantastic choice. Thanks for looking into them to see if they were easy things we could do as part of the PR. Would you mind making the follow-up issues with the information you've gleaned?


Be able to track project status and filter for incomplete projects

My actions before raising this issue

[x ] Read/searched the docs
[x ] Searched past issues

Expected Behaviour

Users will be assigned multiple projects, with each project having multiple tasks. When tasks inside a project are completed, the task status is changed to "completed" and progress bar is filled in green. However, when all tasks in the project completes, the PROJECT status itself has no status change or visual indication.
This makes it difficult to determine the next Project on the project list that has pending tasks.
Current Behaviour

Currently when all tasks in a project is completed, there is no status or progress change. Projects with all tasks completed are indistinguishable from projects with pending tasks. This makes it difficult to filter for the next project with pending tasks.
Possible Solution

When all tasks for a Project is Completed, the Project status should also be updated to Completed, and the same progress bar that is displayed for completed tasks should be displayed for completed projects (with it filled out in green).
Context

Images/Videos are often grouped together into Projects. For example, all images and videos for a patient can be grouped in a project. So users will work through one patient/project at a time, then go to the next. There can be 1000s of patients/projects, so having a way to filter out which projects are pending would be useful (the same way we can filter out tasks which are pending).

@rphila, Hi, please try to use advanced filtration implemented in PR


Better message for rejected promises

When the rejected promise is not an Error, Sentry always received Unhandled Promise error detected (or whatever it has been updated to in the app).
This PR tries to provide a bit more informative message so that when in Sentry, everything does not show up as quoted above.
Note: Using Ember.typeOf is Ember 1.13+ compatible.

Thanks for the PR @xcambar 👍


packit: enable builds on ppc64le

SSIA
Signed-off-by: Tomas Hozza<EMAIL_ADDRESS>

had to amended and force-pushed to restart CI 🤦


Why is log4j added to dependencies?

Running mvn2nix on a pom.xml without any dependencies yields a mvn2nix-lock.json with dependencies I don't understand. @fzakaria Can you please explain, where this dependencies are coming from?
One of this dependencies is "log4j:log4j:jar:1.2.12", you can find it in mvn2nix-lock.json of this repository as well.
For some projects using mvn2nix, this might cause to be vulnerable to Log4Shell :(
I think it should be fixed as soon as possible.

I don't believe that mvn2nix adds anything.
Try
mvn dependency:tree -Dincludes=org.apache.logging.log4j

to see, what requires it. Most possibly it is a transitive build-time dependency for some of your dependencies.

Hey @datakurre,
thanks for your quick reply.
I couldn't believe it either. But please try to reproduce it yourself.
This gist contains a pom.xml without any dependencies: https://gist.github.com/johannesloetzsch/a676a859a5bd4099ac4ae3a8879a5564
Just download it and call mvn2nix on it
nix run github:fzakaria/mvn2nix#mvn2nix

The output does contain log4j :(
As expected the command you suggested,
mvn dependency:tree -Dincludes=org.apache.logging.log4j

doesn't return a dependency.

Mvn2nix needs to include dependencies for Maven itself also!
log4j could be a dependency of Maven for logging. In fact in almost
positive it is.
mvn2nix starts with an empty m2 repository and just walks it after running
Maven in the Nix contest.
Any dependency found there is 100% part of your build.
On Fri, Dec 24, 2021, 10:37 AM Johannes Lötzsch @.***>
wrote:

Hey @datakurre https://github.com/datakurre,
thanks for your quick reply.
I couldn't believe it either. But please try to reproduce it yourself.
This gist contains a pom.xml without any dependencies:
https://gist.github.com/johannesloetzsch/a676a859a5bd4099ac4ae3a8879a5564
Just download it and call mvn2nix on it
nix run github:fzakaria/mvn2nix#mvn2nix
The output does contain log4j :(
As expected the command you suggested,
mvn dependency:tree -Dincludes=org.apache.logging.log4j
doesn't return a dependency.
—
Reply to this email directly, view it on GitHub
https://github.com/fzakaria/mvn2nix/issues/48#issuecomment-1000878525,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAETXDWLXJD6FDHSXRGSIE3USSHT7ANCNFSM5KVZJIRA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>

So, maybe I am using mvn2nix with more recent maven and that’s why I have lock files without vulnerable log4j 🤔
Need to try out the example with different versions…

Using the Flake as described here should give a reproducible result, using the same maven version.
@datakurre @fzakaria Could both of you please try to reproduce it?

Any dependency found there is 100% part of your build.

@fzakaria Please have a look at the example pom.xml, it doesn't contain any dependencies. It's a completely empty project.

@johannesloetzsch I created a minimal project hello world project with your pom and can confirm that lock file contains log4j. But it should be only a build time dependency, mo probably Maven related, which should not appear in the eventual build target (e.g. jar).
That said, I do have mvn2nix created lock files that don't contain log4j. I try to figure out, how they do that.

Closing an issue -- this is a dependency of either Maven itself or one of the many plugins you include by default with maven (compile, release, jar) etc..
Just to see this you can use mvn outside of a Nix context and set your maven repo to a test location.
mvn package -Dmaven.repo.local=/alternate/repo/location

See the wizz of stuff that passes you by that needs to be downloaded for a project with "zero dependencies".
Specifically, I can see:
Downloading from central: https://repo.maven.apache.org/maven2/log4j/log4j/1.2.12/log4j-1.2.12.pom
Downloaded from central: https://repo.maven.apache.org/maven2/log4j/log4j/1.2.12/log4j-1.2.12.pom (145 B at 2.9 kB/s)

You should look into all the plugins and their dependencies. You can try the following command:
mvn org.apache.maven.plugins:maven-dependency-plugin:LATEST:resolve-plugins

Here is the output and you can see log4j
❯ mvn org.apache.maven.plugins:maven-dependency-plugin:LATEST:resolve-plugins | grep log4j -B 300 -A 5
[INFO] Scanning for projects...
 Just upgrade it with
    <plugins>
      <plugin>
        <groupId>org.apache.maven.plugins</groupId>
        <artifactId>maven-compiler-plugin</artifactId>
        <version>3.8.1</version>
        <configuration/>
      </plugin>
    </plugins>

Thanks to both of you for helping to solve this issue :)
Adding maven-compiler-plugin explicitly to pom.xml did it :+1:
mvn org.apache.maven.plugins:maven-dependency-plugin:LATEST:resolve-plugins convinces me, that the Issue is caused by maven itself and should be fixed there by using up to date default plugins.


NAs in "future" data

I have NA for about 6% of the "future" bioclim data and about 2.5% of the NDVI data. Should I just throw those rows out, or is this a red flag we should investigate further?

How are you calculating those?
I count 1193 unique sites in the past/prism data with bio1 as na, compared to 833 in the future/cmip data. Both sources have 5061 unique sites total.
The past/prism data doesn't include any canada sites, while the future/cmip data does include canada data, so I would expect the past data to have more NA.

I'm finding that there are 242 sites that had NAs in 2014 and 2015 (but had at least some non-NAs before). Each of these sites is missing all of its future bioclim data. I've listed them below.
I'm also finding a lot of rows in "future" data that have the year listed as 2051, and none of these have NDVI data.
Can you confirm?
c(2040L, 2041L, 2042L, 2070L, 2140L, 2141L, 2142L, 2217L, 11002L,
11201L, 11210L, 11410L, 14004L, 14019L, 14038L, 14039L, 14045L,
14050L, 14057L, 14075L, 14083L, 14099L, 14120L, 14123L, 14135L,
14193L, 14345L, 18001L, 18006L, 18013L, 21001L, 21002L, 21006L,
21007L, 21009L, 21010L, 21105L, 21107L, 25002L, 25007L, 25009L,
25011L, 25016L, 25018L, 25025L, 25027L, 25032L, 25036L, 25039L,
25051L, 25062L, 25064L, 25070L, 25075L, 25077L, 25078L, 25079L,
25080L, 25083L, 25085L, 25086L, 25087L, 25088L, 25109L, 25116L,
25132L, 25135L, 25170L, 25175L, 25178L, 25180L, 25183L, 25283L,
27001L, 27056L, 27301L, 27305L, 35001L, 35101L, 35201L, 35301L,
42001L, 42002L, 42004L, 42006L, 42008L, 42030L, 42031L, 42051L,
42101L, 42102L, 42105L, 42108L, 42208L, 42311L, 42312L, 42411L,
44002L, 44004L, 44005L, 44017L, 44023L, 44024L, 44025L, 44028L,
44117L, 44308L, 46020L, 46027L, 46035L, 46036L, 46037L, 46041L,
46042L, 46043L, 46048L, 46049L, 46058L, 46149L, 47001L, 47002L,
47003L, 47004L, 47006L, 47007L, 47102L, 47104L, 49001L, 49002L,
49004L, 49006L, 49009L, 49014L, 49015L, 49017L, 49022L, 49023L,
49025L, 49026L, 49029L, 49030L, 49040L, 49041L, 49042L, 49043L,
49059L, 49062L, 49064L, 49070L, 49130L, 49143L, 49162L, 49230L,
50031L, 50032L, 50034L, 50042L, 50047L, 50048L, 51029L, 51229L,
56036L, 59002L, 59004L, 59005L, 59013L, 59025L, 59028L, 59029L,
59030L, 59031L, 59032L, 59104L, 59131L, 59132L, 59204L, 59231L,
61001L, 61002L, 61003L, 61004L, 61005L, 61053L, 61061L, 61063L,
61065L, 61069L, 61070L, 61109L, 61169L, 63002L, 63003L, 63007L,
63029L, 63107L, 63202L, 63204L, 63208L, 63229L, 63306L, 63329L,
66006L, 66007L, 66107L, 66113L, 68004L, 68036L, 68065L, 68253L,
69017L, 69117L, 77001L, 77002L, 80005L, 80022L, 80122L, 83001L,
83006L, 83011L, 83020L, 83021L, 83022L, 83306L, 87022L, 87023L,
88010L, 88029L, 88032L, 88045L, 88048L, 89001L, 89009L, 89027L,
89066L, 89072L, 91005L, 91030L, 91048L, 91049L, 91062L, 91063L,
91301L)

Oh, 2014 and 2015 don't have NDVI data for any of the sites (because that's the default argument to get_env_data). I was hoping that would be diagnostic of where the problem was coming from, but apparently not.

Thanks @davharris. All those sites are along the coast or great lakes area. CMIP data has different edges than PRISM, so some of them are getting NA's because of NA CMIP cells. It's being made worse by the aggregation being done, so I should be able to get most of them back by fixing that.

Thanks @sdtaylor!

❤

I've updated the sqlite data file on the T drive to reflect this.


Change all instances of 'TA Assist' to 'TA-Assist'

Resolves #314

Codecov Report
Base: 67.99% // Head: 67.99% // No change to project coverage :thumbsup:

Coverage data is based on head (a05b0b6) compared to base (c0a00a2).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #338   +/-   ##
=========================================
  Coverage     67.99%   67.99%
  Complexity      703      703
=========================================
  Files           111      111
  Lines          2306     2306
  Branches        241      241
=========================================
  Hits           1568     1568
  Misses          662      662
  Partials         76       76

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Protections on external trigger

External trigger missing M/S/VS/VU enable bits in tmexttrigger CSR. The debugger with S-mode privilege might affect  M-mode by enabling an external trigger and letting it fire in M-mode code to achieve attack (e.g. DoS, side channel).
Mitigation: Add per privilege enable bit in tmexttrigger like other triggers.
External trigger inputs might have resource belongs to M-mode (e.g. interrupts or performance counter etc.). A S-mode debugger might snoop the behavior the M-mode by enable those external trigger.
Mitigation: Since M-Mode is enabled by RoT, external triggers should be enabled by RoT as well .

Firstly there are no external triggers defined currently. When a external trigger facility does get defined - e.g., HPM counters overflow causing an external trigger - those facilities need to have privilege specific enables. M-mode also has control on external triggers not firing in M-mode using MTE control.

closing per above discussion - please move this to the secure ext debug TG github to track.


Add /records/services PUT to the API

Only services can be updated. Functions get updated when the service they belong to is updated.

Closes with pr/#292


How to indicate selected legislator triangles?

Currently, when you select legislator in a box, they slowly grows into larger triangles. This is fine, but I find it a bit unintuitive. The slowness of the growth seems at odds with the expected immediate feedback of selecting something.
I think we want it to be immediately highlighted in some way. This could be fast-growth, if it isn't a performance issue, or perhaps we could replace selected triangles with dark-bordered triangles?

Not sure how much control we have over this without hacking hard on DC.js.

Yes, this is very odd; most of DC's chart types add a .selected class to the selected items, but the scatterplot does not. I agree with Jeff that there is not an obvious way to do this. I can probably hack around it, but I have eliminated the quickest fix. :(

Okay I think the way to do this is:

When a filter change occurs (maybe just on the nominateScatterPlot), intercept it (we do this already for the filter bar)
Iterate through the data, and intercept which items have been filtered.
Now iterate through the path items underneath the chart. For each data point, if the item has been selected, ensure it has the class "selected". If not, ensure it does not have this class. I have already set the style in the CSS so that this class will display an outer stroke.

It's not immediately clear to me how you do the data point -> path svg mapping. nominateScatterChart.chartBodyG().selectAll("path") will give you the SVG paths, nominateScatterChart.chartBodyG().selectAll("path").each(function(n, i) { }) will probably give you the data points, but I don't know how you connect the two. It's really weird. Anyway, I'll pick this up again when I get some more time.

I think that in v2.1 of dc, you will see that it deals with this (if I
understand the issue), by shrinking the points that are not selected.
This might be all that we need without adding the stroke.

Nice. Should the box that appears when you click be a bit smaller? When
guys are densely packed, it's hard to get only the one you want with a
bigger box.
On Mon, Jan 16, 2017 at 5:51 PM, JeffreyBLewis<EMAIL_ADDRESS>wrote:

I think that in v2.1 of dc, you will see that it deals with this (if I
understand the issue), by shrinking the points that are not selected.
This might be all that we need without adding the stroke.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/JeffreyBLewis/WebVoteView/issues/125#issuecomment-273001489,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AS6Qi1IimJgwA8s8J8hm6moujeWsOUW6ks5rTB6fgaJpZM4Lj4ND
.


Saver page is only available at the super tenant.

Describe the issue:
Tenant path

Super Tenant

How to reproduce:

Login to console with tenant
Login to super tenant
Check the server page availability

Expected behavior:
@NipuniBhagya is this should be available on both or is this expected?
Environment information (Please complete the following information; remove  any unnecessary fields) :

Product Version: [e.g., IS 5.10.0, IS 5.9.0]
OS: [e.g., Windows, Linux, Mac]
Database: [e.g., MySQL, H2]
Userstore: [e.g., LDAP, JDBC]

Optional Fields
Related issues:

Suggested labels:

Hi @aaujayasena, this is the expected behavior. Server settings should only be available for the super tenant. Hence closing the issue.


Make quotes optional for URI

Codecov Report

Merging #16 (b73fa2c) into master (04e3a0e) will increase coverage by 2.65%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #16      +/-   ##
==========================================
+ Coverage   72.60%   75.25%   +2.65%
==========================================
  Files           2        2
  Lines         219      194      -25
==========================================
- Hits          159      146      -13
+ Misses         36       29       -7
+ Partials       24       19       -5

Flag
Coverage Δ

unittests
75.25% <ø> (+2.65%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

local.go
90.74% <ø> (+18.40%)
:arrow_up:

external.go
69.28% <0.00%> (-3.52%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04e3a0e...b73fa2c. Read the comment docs.


add meson

Please add the following dependency to the rosdep database.
Package name:
meson
Purpose of using this:
"Meson is an open source build system meant to be both extremely fast, and, even more importantly, as user friendly as possible."

I replaced the distribution packages with pip since this 1) will make it available on all platforms and 2) provides always the latest version.

I think that's not the right format. You'll still have to list the name of the platforms, specifically, ubuntu, debian, fedora, and opensuse are encouraged.

This syntax was suggested for rosdep/base.yaml in https://github.com/ros/rosdistro/pull/31273#discussion_r754589375. I assume it is working in this yaml file too?

Even if that's valid syntax, we definitely cannot use a wildcard for all distros since we don't want pip for Gentoo. Please see other examples with pip packages in the file for reference.

Is pip not supposed to work on Gentoo? In any case, I set this to null. See the above example too for this syntax.

This syntax was suggested for rosdep/base.yaml in #31273 (comment). I assume it is working in this yaml file too?

The wildcards currently only work for releases within an OS. I only just recently updated rosdep to support OS-level wildcards (specifically to make pip easier), but that enhancement hasn't been released yet. Best thing to do for now is list a handful of distros specifically as is done in other examples in this file.

Even if that's valid syntax, we definitely cannot use a wildcard for all distros since we don't want pip for Gentoo.

This is actually handled by rosdep itself, see https://github.com/ros-infrastructure/rep/pull/329#issuecomment-970917324

The wildcards currently only work for releases within an OS.

Right. The comment I mentioned was only for distribution names. I set some distributions manually now.

This is actually handled by rosdep itself, see ros-infrastructure/rep#329 (comment)

Cool. I want that feature :-)

Feel free to squash all my commits into one. I just wanted to preserve the history through the PR discussions.

I replaced the distribution packages with pip since this 1) will make it available on all platforms and 2) provides always the latest version.

In general, if packages are available for a target platform, then the platform package is strongly preferred to pip because it allows the package to be released via the official buildfarm. pip dependencies cannot be used by binary releases on the build farm. Since this package is for a build system that is itself not supported on the build farm, that reasoning lacks some weight.
However, I think it still applies especially if there's community interest in eventual support for meson and ament_meson build types on the build farm, that will only be possible with the platform-packaged distribution of meson.
Lastly, pip-only packages in the official rosdep database use a different package naming convention and the key name should then be python3-meson-pip.

In general, if packages are available for a target platform, then the platform package is strongly preferred to pip because it allows the package to be released via the official buildfarm. pip dependencies cannot be used by binary releases on the build farm. Since this package is for a build system that is itself not supported on the build farm, that reasoning lacks some weight.

This generally makes sense, since the bloomed packages cannot depend on pip.
In this case, meson is just a build dependency. The build farm can check out that pip package to build the ROS package. I am using this in a "cmake wrapper" that checks out a git repo and runs meson on it. There is no runtime dependency that has to be satisfied when the bloomed package
The meson project is moving very fast and Ubuntu LTS is always stuck with 2 year old packages. After 1 year into an LTS, I rarely encounter packages that will build with the Ubuntu supplied version, so I always have to resort to the pip version.

Lastly, pip-only packages in the official rosdep database use a different package naming convention and the key name should then be python3-meson-pip.

In the python.yaml it looks as if python libraries are prefixed with python- but regular applications that are installed via pip are just suffixed with -pip. So in this case it should be meson-pip correct?

In this case, meson is just a build dependency. The build farm can check out that pip package to build the ROS package. I am using this in a "cmake wrapper" that checks out a git repo and runs meson on it. There is no runtime dependency that has to be satisfied when the bloomed package

The build farm builds do not directly use rosdep. All binary package dependencies must be satisfiable with system dependencies. Bloom does the work of using rosdep to generate valid platform build and runtime dependency and the build farm jobs install only the packages resolved by bloom (and their dependencies) in the containers which perform these package builds.
I think my advice on the matter depends heavily on whether the goal is to get packages using meson onto the official ROS build farm or whether they are just meant for personal use. In my strong opinion packages on the ROS build farm need to be reproducible solely with packages from the platform and ROS package repositories. Packages which rely on third party repositories should be subject to additional scrutiny.

In the python.yaml it looks as if python libraries are prefixed with python- but regular applications that are installed via pip are just suffixed with -pip. So in this case it should be meson-pip correct?

My understanding of the current conventions is that the python3- prefix is unconditional on new pip keys but I'll seek second opinions from @tfoote and @cottsay.

The build farm builds do not directly use rosdep.

Is this a technical limitation or is this just not implemented yet? If the pip dependencies are not used at runtime, then building with pip packages should be fine.

I think my advice on the matter depends heavily on whether the goal is to get packages using meson onto the official ROS build farm or whether they are just meant for personal use.

For my immediate need, I want to have packages build in a CI using rosdep for dependency resolution. In the longer term, I also wanted to release the packages via bloom. If the latter is not possible via pip build dependencies, then I will only be able to release for platforms that have a recent enough version of meson packaged. Alternatively, I have to implement an ugly hack that includes all python build dependencies in the package itself, or even more horrifying -- package meson as a ros/bloom package :-)

Is this a technical limitation or is this just not implemented yet? If the pip dependencies are not used at runtime, then building with pip packages should be fine.

It's an explicit objective not to use pip at either build or runtime for the packaged ROS binaries. One of the prime benefits of building our packaging systems on top of the platform's packaging system is our ability to rely on the integration and stability work done by that platform. This comes with the trade-off of not always having access to the latest releases of packages.
Vendoring or embedding dependencies is something that is occasionally done out of necessity but even in that case packages which are available via the base platform, even if in an older form lacking some features, must always be used except in extraordinary circumstances.

@nuclearsandwich @tfoote @cottsay What is the status of this? Can we go on with it?

Two things:

To be clear, this key will not be usable on the buildfarm. Using rosdep to install dependencies locally will work fine, but Bloom will give you an error when it tries to resolve all of the dependencies to system packages (deb/rpm). This is by design, not a bug.
This rule should follow the documented conventions, and as a pip-only package, should be named python3-meson-pip. This is particularly important to distinguish from a possible future key which represents the system's meson package.

I renamed it to python3-meson-pip.
I have no idea how to approach the pip vs. packages problem. The packaged meson would be a separate key, but that means that ROS packages have to decide which version to choose and if they want to support the build server.
IMHO the build server should support pip build dependencies. Since meson is not a runtime dependency, it should not be added as a dependency to the bloomed package.

To make this complete, I am also adding the meson key for the distribution packages.

@cottsay @nuclearsandwich @mabelzhang Are you ok with these changes now? The rosdep key names should now follow conventions.

As a Python package, I think that the rules still belong in python.yaml. Other than that, I think we're good.

As a Python package, I think that the rules still belong in python.yaml. Other than that, I think we're good.

Right. That was an oversight. I think in this case it also has to be called python3-meson, which sounds a bit cumbersome. Is this correct that everything that is implemented in python will have to carry the python3-, python4-, ... prefix?

Is this correct that everything that is implemented in python will have to carry the python3-, python4-, ... prefix?

In general, rosdep keys refer to a "resource" and not necessarily a package. In this case, I believe that the "resource" backed by the key is the meson executable, which may be provided for any interpreter. So IMO, simply calling the key meson to match the Ubuntu package which provides /usr/bin/meson seems appropriate.
That said, python3-meson seems fine too. Thoughts from other @ros/rosdeputies?

Thanks for iterating with us @christianrauch.


Unable to run rs-server command

Not able to run command: rs-server

Required Info

Camera Model
D435i

Firmware Version
<IP_ADDRESS>

Operating System & Version
Raspbian GNU/Linux 10 (buster), Release version 10

Platform
Raspberry Pi 4 4GB

SDK Version
2.40

Language
{python}

Hi,
I am attempting to set up a raspberry pi system similar to the one outlined in this file.  https://dev.intelrealsense.com/docs/open-source-ethernet-networking-for-intel-realsense-depth-cameras. I have already read similar problems described in the following to issues.
https://github.com/IntelRealSense/librealsense/issues/7123
https://github.com/IntelRealSense/librealsense/issues/8021
I have downloaded the pre-built image found on https://dev.intelrealsense.com/docs/open-source-ethernet-networking-for-intel-realsense-depth-cameras
After downloading this image I placed on my sd card I wasn't able to effectively run the command
$ rs-server
I get the result
bash: rs-server: command not found
So I ran the cmds
$ cd librealsense/build/ && cmake ../ -DFORCE_RSUSB_BACKEND=true -DCMAKE_BUILD_TYPE=release -DBUILD_EXAMPLES=true -DBUILD_GRAPHICAL_EXAMPLES=true -DBUILD_NETWORK_DEVICE=ON
Following advice outlined in one of the issues: https://github.com/IntelRealSense/librealsense/issues/7123
This did not work either. So I attempted one of the fixes suggested by the person in https://github.com/IntelRealSense/librealsense/issues/8021
This also did not fix my issue and I reversed the edits I made to the CMake file in librealsense/third-party/live555/
I then attempted to rebuild the entire sdk following the directions in https://github.com/IntelRealSense/librealsense/blob/master/doc/installation.md#building-librealsense2-sdk
I ran the cmake command with the necessary modifications.
So far this is what I have working on the Raspberry pi
-I am able to run commands realsense-viewer
-I am able to record data
-I am able to run command rs-enumerate-devices
-I am able to run the command systemctl restart rs-server.service, and I do not get an error of any sort (or at least no error that prints out to the terminal)
However though I am able to run systemctl restart rs-server.service without any error. When I try to then run rs-server I get the same error as I got before.
I have attempted rebooting and shutdown the system multiple times.
I have also tried this set up on a second raspberry pi 4 4GB and got a similar failure.
I am unsure how to proceed from this point on. Or what I have set up incorrectly. Any help you could provide would be much appreciated.
Please let me know if you need any more details.
Thanks.

Hi @yeric1789   The best way to read the open-source ethernet networking paper is to jump between sections instead of reading it all from beginning to end.  Although I have not performed this project myself, I will offer a sequence of sections that I would suggest for someone who is using the pre-built SD card image.
Section 1
Section 2
For the initial setup, the end of Section 2 should be as far as you need to go if you are using the supplied SD card image.
Make sure that the Pi is connected to the host computer (e,g a laptop) by some means, as described in Section 2.5  First Boot.  After about 30 seconds, the host computer should detect new network named “PI4 USB Device”.
Now use a terminal on the host computer to establish a network connection to the connected Pi board.  On Windows, use Putty to do so.  Input the command below into the terminal.
ssh<EMAIL_ADDRESS>The initial password and username are realsense
Once you are logged into the Pi, proceed to Section 2.6 of the guide and input the commands in this section into the terminal on the host computer to set up a static shell
At the end of this section, once you have restarted the system (using sudo reboot) to apply the new configuration, proceed finally to Section 2.7 of the guide to test the networked camera with the RealSense Viewer program.

I suggest skipping Section 3 completely during initial setup if using the supplied SD card image.  This is because this section contains information on building the project from source code (not relevant for an SD card image user) and what could be considered to be further information to come back to once initial setup is succesfully completed.
Sections 4 to 6 could also be considered Further Information to be read after initial setup.

Hi @yeric1789   Do you require further assistance with this case, please?   Thanks!

No. Thanks for your help. You may close this case.

Thanks very much for the update!


xtask assemble fixes

Closes #284

r? @therealprof
(rust_highfive has picked a reviewer for you, use r? to override)


Link color uses wrong CSS selector

I have the following CSS snippet:
body {
  --link-external-color: #66b1fa;
}

It should only make external links blue, but it makes the internal links in the outline blue too.

fixed in 0.3.15


Bug w/tome of boots recipe.

Found a bug while crafting a tome of boots. Actually recognized as shapeless recipe: result is tome of others.
Tested on Bibliocraft fancy crafting table.

Was this actually a bug? Or was it my fault? (E.g. Mod incompatibility)

This was an actual bug.  The recipe was registered early, and needed to be registered later


Unable to authenticate from decent extension

Describe the bug
Not able to authenticate via the decent extension.
Any combination of username and password always results in: Authentication failed. please check username / password
I am able to successfully authenticate via web with the same credentials that do not work in the extension.
Additionally, as a debugging step I reset my password, tested the login on web, then tested again on the extension with the same result. Not able to authenticate.
To Reproduce
Steps to reproduce the behavior:

Go to settings > Extensions
Enable the "Upload to visualizer" extension
Tap on the settings cog
Enter your username and password

Expected behavior
Should be able to authenticate with correct credentials
Additional context

Extension Version 1.2
Decent DE1PRO
Stable software channel
Firmware up to date

This is the problem with the extension, not Visualizer. Usually it's due to wifi or something wrong with tablet. Best thing to do is to turn wifi off and on again, and/or restart the tablet.
If that doesn't work, please open the issue on Basecamp or de1app github


rubyPackages.ruby-terminfo: 0.1.1 -> 0.2

Motivation for this change
ZHF: #122042
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 123423 at 2fa3730b run on x86_64-linux 1

4 packages built successfully:

rubyPackages.ruby-terminfo (rubyPackages_2_7.ruby-terminfo)
rubyPackages_2_6.ruby-terminfo
rubyPackages_3_0.ruby-terminfo
tests.trivial


Rewrite copy-paste test

I guess custom-box.spec.ts was an accidental commit? I don't remember. It doesn't look finished and it's disabled at the moment. I'll take it over because I'm merging it with parametric-params.js.


Adding unit test for input actions.

Adding unit test for input actions.

Coverage decreased (-0.4%) to 60.789% when pulling 6aa1e205725171988449faa0d7938dfde339f21e on ranch:test/input into 320373de1a444785ac91a1df0afa67dbc810ac7c on knq:master.

Coverage increased (+0.2%) to 61.446% when pulling ca1ae9b64049d59e28975d02f2b7957cf55cb879 on ranch:test/input into 320373de1a444785ac91a1df0afa67dbc810ac7c on knq:master.

Coverage increased (+0.2%) to 61.446% when pulling ca1ae9b64049d59e28975d02f2b7957cf55cb879 on ranch:test/input into 320373de1a444785ac91a1df0afa67dbc810ac7c on knq:master.

Coverage increased (+0.4%) to 61.665% when pulling 3a264ed3ff581574df8613efd10d34981f2bc34d on ranch:test/input into 320373de1a444785ac91a1df0afa67dbc810ac7c on knq:master.


Incorrect imported function this context using ES6 module

Code
// export.ts
export function foo() {
  'use strict'
  console.log(this);
}

foo();

// import.ts
import { foo } from './export';

foo();

expected
$ node import.js
undefined
undefined

actual
$ node import.js
undefined
{ foo: [Function: foo] }

Fix: add 'use strict'

The emitter will need to identify call/new expressions from aliases, and rewrite them using as foo.call(void 0, arg)
A PR would be appreciated.

Thanks for your acceptance.

Babel's implementations:

(0, _assert2['default'])(true); // (A)

Note that the default export is always accessed via the exports object_assert2 (line A), never directly, like this:

var assert = _assert2.default;

The reason for that is support for cyclic dependencies.
http://www.2ality.com/2015/12/babel-commonjs.html

As the current emit does this:
Object.defineProperty(exports, "__esModule", { value: true });
var export_1 = require("./export");
(0, export_1.foo)();

I think that the issue can be closed, cc @jakebailey


ensure we don't compare provenance

Comparing provenance is meaningless, since Wildcard might be any provenance.

@bors r+

:pushpin: Commit b4eff16e0c943ef8250c0d49e1bc5501ee11467b has been approved by RalfJung
It is now in the queue for this repository.

:hourglass: Testing commit b4eff16e0c943ef8250c0d49e1bc5501ee11467b with merge 12907ab4d7aa155aa24600ddba3742d8aaaeba8a...

:sunny: Test successful - checks-actions
Approved by: RalfJung
Pushing 12907ab4d7aa155aa24600ddba3742d8aaaeba8a to master...


feat: Shift+ click on a tab will now open it in the right sidebar

Closes #56

haven't seen that this pull request was not merged yet. My newest checkin also closes #45

Sorry, I am not actively maintaining this project. Will merge it now. Thanks for your contribution!


drop the words "Simple" and "unobtrusive" from marketing copy

I just spent about three hours determining why our tests were returning a 500 server error but the returned error contained no data and our 500 server error framework (the one that we've integrated into Express.js) was not logging anything.
It turns out Passport was rendering an HTML error page (including a stack trace(?) ) and returning immediately. This took a long time to debug because I had to determine on the client why the response was not JSON (and what the response actually was), and then on the server which piece of the response handling stack was executing and then returning without logging anything about what it was doing. Basically the only approach is to do a binary search and a) remove half of the middlewares until you don't see the error, then iteratively add them back until you find it or b) add print lines until you determine which print lines run and don't run, then iterate until you find the error.
In any event, my experience with 'Passport' was not that it was "simple" or "unobtrusive"; I would expect either of these things to let me know when it encountered an error condition instead of hiding it. It's bothersome that the library is being marketed this way.

Perhaps you could point to the exact line inside passport where it is rendering an HTML error page with a stack trace?  I don't believe that passport is responsible for what you describe, but if it is it would be more productive use of an issue to get it fixed than complain about marketing copy. Thanks!
Sent from my iPhone

On Nov 16, 2017, at 11:53 PM, kevinburkeotto<EMAIL_ADDRESS>wrote:
Closed #624.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.