Can't send chat actions..??

I have this code, which I believe is supposed to work, but it doesn't:
_, err := b.Send(m.Sender, tb.Typing)
if err != nil {
	log.Print(err)
}

It prints this: telebot: unsupported what argument
There's no such method as b.SendChatAction so how is one supposed to send chat actions?
I found absolutely nothing in the docs.

Never mind, I completely missed Notify().


Added joining lobbies via short codes

TLDR: Lobbies can be joined via 4 digit codes.
Now each lobby has its own unique 4 digit code. Users can join matches by passing a 4 digit code, if it's not found a toast will pop up, same if the code is invalid
UI changes:

Added Join room section Component

Added in-game lobby-code button

To consider:

I was originally planning on placing the Join room component under the Create Room form but you could barely see it on the screen. I would consider placing it at the bottom since if users were to actually use it, it would mean there are at least +12 ongoing games, which would force them to scroll down to look for the one their looking for.

Sweet! FYI @webdevcody I pulled this in and locally and it's working great.  The only nitpicky thing I would recommend is just running prettier on the changed files to match the format

@heathhenley now it should be ready to merge, just ran prettier on the files I previously modified. Will merge upon approval, thanks!


pull request for e2e test at 01/07/2017 22:26:09

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Data Science with Python : Decision Tree Algorithm

Welcome to 'DSWP' Team, good to see you here.
This issue will helps readers in acquiring all the knowledge to learn about getting involved with Decision Tree Algorithm. Tutorial to Decision Tree Algorithm and how it's applied using sample code.
To get assigned to this issue, add your serial numbers mentioned in the spreadsheet of "Data Science with Python", the approach one would follow and choice you prefer (Documentation, Audio, Video). You can go with all three or any number of options you're interested to work on.
This issue is created for beginners and who aren't assigned to any issues yet.
If you had referred any resources, add them up in "DS Resources". Similarly if you had used datasets, include them in "DS Datasets".
Domain : Machine Learning
Mentors Assigned : Shivang Dubey / Kareem Negm
Points to Note :
The issues will be assigned on a first come first serve basis, 1 Issue == 1 PR.
"Issue Title" and "PR Title should be the same. Include issue number along with it.
Changes should be made inside the Datascience_With_Python/ directory & Datascience_With_Python branch.
Follow Contributing Guidelines & Code of Conduct before start Contributing.
This issue is only for 'GWOC' contributors of 'DSWP' domain.
All the best. Enjoy your open source journey ahead. 😎

Thank you for adding the issue of Decision tree Algorithm
Approach:
Getting a dataset appropriate for the ML model.
Data quality check, i. e : Removal of outliers, Data processing
Data Visualization, graphic implementation
Training of dataset
ML model building
Getting an accuracy score.

Hello, I am Deepthi M with a serial number:172. I would like to do documentation on this issue.
my approach: a detailed explanation and a data set to explain the code.

Issue is assigned to @dev123singh for documentation.
@deepthi1107, if you haven't been assigned to any issue, put up your message in discord thread

ok @prathimacode-hub

I want to contribute to this issue :
Name-Mohit Kumar
Domain-Data Science with Python
Batch-4
Issue Number- 1126
Contribution Approaches-
what is a decision tree,
how to make a Decision Tree approach.
how to tune for better results.

Hello, the mentor here for any help

Hello, I am Deepthi M with serial number:172. I would like to do video on this issue.
My approach: A detail explanation with an example and code.

Hello , I'm Pranjal Mittal
Batch : 19
Type: Documentation
Approach: Explaining decision tree , how to make it with a brief of why it is needed and giving suitable examples for it.

I would be glad to work on this issue.
Name : Shripad Dhopate
Batch : 21
Type : Documentation , Video
Serial No: 930

If you're interested for video, let me know. Documentation is already been assigned. @shripaddhopate

Issue is assigned to @deepthi1107 for video contribution


Log level on apache package not working?

I am getting too much verbosity out of the apache packages when I set the logging level to Level.DEBUG, I tried to disable the logging on the apache stuff, but doesn't seem to work?
    Configurator c = Configurator.currentConfig();
    c.level(Level.DEBUG); // set everything to debug by default
    // Trying to turn off other debug that I don't care
    //c.level("org.apache.http.client", Level.OFF);
    //c.level("org.apache.http.client.*", Level.OFF);
    //c.level("org.apache.http.impl.client", Level.OFF);
    //c.level("org.apache.commons.logging.simplelog.log.org.apache.http", Level.OFF);
    //c.level("org.apache.commons.logging.simplelog.log.org.apache.http.wire", Level.OFF);
    //c.level("org.apache.commons.logging.simplelog.log.org.apache.http.impl.conn", Level.OFF);
    //c.level("org.apache.commons.logging.simplelog.log.org.apache.http.impl.client", Level.OFF);
    //c.level("org.apache.commons.logging.simplelog.log.org.apache.http.client", Level.OFF);
    c.level("org.apache.http.impl.client", Level.OFF);
    c.formatPattern("{date:HH:mm:ss} {level|min-size=8} {message}");
    c.activate();

Is this a bug? Or does the "package" only works for tinylog's package? What is the proper way to make it work?

Apache HttpComponents 4.x uses Commons Logging. Do you have made sure that tinylog's JCL binding is in the classpath and no other binding to another logging framework? Does Apache HttpComponents output any log entries, if you disable logging at all (c.level(Level.OFF))?


Node Properties and phet-io undeferring

Scenery's synchronous-update code (PDOMDisplaysInfo, RendererSummary) makes a hard assumption that it is only handling updates for one change at a time (e.g. one visibility change, all the others are the same as before). It makes the assumption that the one change happening NOW is the only change, and that the rest of the state is consistent.
It wasn't designed to handle cases where an arbitrary number of different things are now out-of-date, and could be notified later and in an arbitrary order. The graph operations are likely to fail if multiple visibleProperties undefer at the same time.
This may be causing https://github.com/phetsims/greenhouse-effect/issues/46.
Possible routes:

Don't undefer multiple of these at a time (seems tricky)
Vet/update the algorithms to handle arbitrary Node-side changes that WILL be notified (sounds trickier but potentially cleaner at the end)
On state-setting or cases where multiple things are undeferred, instead have a path that rebuilds this information to the "correct state" - some duplication, probably easier, but more complicated to maintain.

Geometric optics is now blocked by this as well. https://github.com/phetsims/geometric-optics/issues/318

Discussed in PhET-iO meeting again today. @kathy-phet mentioned that this can take precedence over advancing buoyancy for @jonathanolson.

Fix and simplifications to TinyForwardingProperty made above. We're treating it a bit less in a "forwarding" way, where the value of the forwarding and target Properties can diverge (generally in deferred cases, which keeps things "synchronous" for Scenery). This can also diverge during certain phases of the listener notifications, however not in a way that seems to be happening in practice currently (and is also unlikely to happen in the future).

Thanks @zepumph for the collaboration! Removing my assignment.

I pinged the individual issues about adding their sims back to the state wrapper. I will leave this open, and close in ~1 week if nothing else comes of it. Thanks @jonathanolson for the quick turnaround.

The phet-io-state-fuzz test is not being run very often by CT.  It's only run 3 times for geometric-optics since the fix for https://github.com/phetsims/scenery/issues/1312 was pushed, see screenshot below.  @zepumph do you feel comfortable closing with this kind of CT coverage?

Looking at all testing of the state wrapper, it looks like it get's relatively good coverage. I know there are a lot of tests done for each row, so it doesn't feel horrible to me.

Now I see that GO and basics has been tested at least 20 times. Given how easily it was to reproduce, I'm feeling good about this change. Closing. Thanks again @jonathanolson.


Optimization: attempt to read node_modules/* first

If that fails, fall back to npm ls.

@notlaforge thanks for the PR. I´ve looked into the PR and did some changes, e.g. removed sync fs calls, added some typings. I´ve captured the work in this branch https://github.com/Microsoft/vscode-npm-scripts/tree/fast-npm-ls.
The optimization code looks fine, but I still came to the conclusion that we should not do this optimization here is why:

all the analysis is done in the extension host process. Since the extension host is a node process and single threaded, the analysis will block other extensions from executing code. For a project with lots of module dependencies a lot of analysis has to be done and the extension host will be blocked for a long time. Running ´npm -ls´ in a separate process does not have this blocking issue.
there are no unit tests for the optimization and the ´npm -ls´ approach is easier to maintain
finally, the npm dependency analysis happens only on save of a package.json so it is not on the critical path and the benefits of the optimization is small.

Having said, I´m really sorry that I didn´t look deeper into the optimization when you offered to make a PR.


Too many threads created for DiscoveryClient

We observed that too many threads created with the name DiscoveryClient. PFB the thread counts created for running around 27 microservice instances (eureka clients) in a managed server.

Thread Name
Count

DiscoveryClient-%d
84

DiscoveryClient-CacheRefreshExecutor-%d
28

DiscoveryClient-HeartbeatExecutor-%d
27

DiscoveryClient-InstanceInfoReplicator-%d
27

I have defined the maximumPoolSize for HeartbeatExecutor and CacheRefreshExecutor as 2, however they were created only 1 per microservice instance.

Even though the pool size of DiscoveryClient scheduler is 2, it was always resulted in 3  DiscoveryClient threads per discovery client. I couldn't find any other reference to DiscoveryClient  executor as well.

From an initial analysis looks like it's possible to get rid of DiscoveryClient threads if DiscoveryClient-CacheRefreshExecutor and DiscoveryClient-HeartbeatExecutor are defined as ScheduledThreadPoolExecutor (rather than ThreadPoolExecutor). i.e. similar to the approach followed for InstanceInfoReplicator.

+1

@fahimfarookme thanks for the data, we will take a look at this.


Limit recursion in GroupSpec.from_zarr

Other than cases of symlink-derived infinite recursion, there might be times where you want to get the GroupSpec for the upper levels of a zarr hierarchy without downloading and parsing every metadata document. I'd envision it something like
class GroupSpec(...)
    ...
    items: Optional[dict[str, ...]]

    @classmethod
    def from_zarr(cls, group, depth=-1):
        attrs = ...
        self = cls(attrs, dict())
        self.update_items(group, depth)
        return self

    def update_items(self, group: zarr.Group, depth=-1):
        if depth == 0:
            self.items = None
            return

        self.items = dict()
        for key, obj in group.items():
            if isinstance(obj, zarr.Array):
                items[key] = ArraySpec.from_zarr(obj)
           else:
               items[key] = cls.from_zarr(obj, depth - 1)

items: Optional[dict[str, ...]]

Does this express the semantics of nullability here?
# there definitely are no subarrays or subgroups
GroupSpec(items={})

# have not checked if there are subarrays or subgroups
GroupSpec(items=None)

Yes, that's the intention; if None, it needs populating, if empty, it's empty.

this will be addressed by #25

closed by #25


Enhance code suggestions with summary option and line link generation

type:
enhancement, bug_fix

description:

Added a feature to summarize code suggestions for better readability and compactness.
Implemented line link generation for GitHub and GitLab to directly link to the relevant lines in the PR.
Improved markdown formatting for code feedback sections.
Fixed GitLab capability check for gfm_markdown support.
Updated temporary comment text from "Preparing review..." to "Preparing suggestions..." for clarity.
Added a new configuration option summarize in pr_code_suggestions to toggle summary view of code suggestions.

main_files_walkthrough:
 files:

pr_agent/algo/utils.py: - Refactored the markdown generation for code feedback to support GitHub Flavored Markdown (GFM).
Adjusted the markdown formatting for 'relevant file' and 'sub_key' entries to ensure proper display.
pr_agent/git_providers/git_provider.py: - Added an abstract method get_line_link to generate a URL to the relevant lines in the PR.
pr_agent/git_providers/github_provider.py: - Implemented the get_line_link method to generate GitHub-specific links to code diffs in PRs.
pr_agent/git_providers/gitlab_provider.py: - Corrected the capability check for GitLab to reflect that it does support GFM.
Implemented the get_line_link method to generate GitLab-specific links to code diffs in PRs.
pr_agent/tools/pr_code_suggestions.py: - Changed the temporary comment text to better reflect the action being performed.
Added logic to publish a summary of code suggestions if the summarize configuration is set to true.
pr_agent/tools/pr_reviewer.py: - Fixed markdown formatting for the instructions summary in PR reviews.
pr_agent/settings/configuration.toml: - Introduced a new configuration option summarize to toggle the summary view of code suggestions.

Preparing review...

Persistent review updated to latest commit https://github.com/Codium-ai/pr-agent/commit/8f615e17a3fe0146ea4502d9b1ecf111dc09036d

Preparing suggestions...

Code Suggestions
📌 File:
pr_agent/algo/utils.py (61-62)
Suggestion:
Combine consecutive string concatenations into a single statement to improve readability.
  Example code:

Existing code:
markdown_text += f"\n\n- "
markdown_text += f" { emoji } Code feedback:\n\n"

Improved code:
markdown_text += f"\n\n-  { emoji } Code feedback:\n\n"

📌 File:
pr_agent/git_providers/github_provider.py (507-510)
Suggestion:
Use string interpolation only once by combining the URL into a single f-string to improve performance.
  Example code:

Existing code:
if relevant_line_end:
    link = f"https://github.com/{self.repo}/pull/{self.pr_num}/files#diff-{sha_file}R{relevant_line_start}-R{relevant_line_end}"
else:
    link = f"https://github.com/{self.repo}/pull/{self.pr_num}/files#diff-{sha_file}R{relevant_line_start}"

Improved code:
link = f"https://github.com/{self.repo}/pull/{self.pr_num}/files#diff-{sha_file}R{relevant_line_start}" + (f"-R{relevant_line_end}" if relevant_line_end else "")

📌 File:
pr_agent/git_providers/gitlab_provider.py (46-46)
Suggestion:
Correct the capability list to include 'gfm_markdown' as it is supported in GitLab.
  Example code:

Existing code:
if capability in ['get_issue_comments', 'create_inline_comment', 'publish_inline_comments']: # gfm_markdown is supported in gitlab !
    return False

Improved code:
if capability in ['get_issue_comments', 'create_inline_comment', 'publish_inline_comments', 'gfm_markdown']:
    return False

📌 File:
pr_agent/tools/pr_code_suggestions.py (271-272)
Suggestion:
Refactor the exception handling to log the exception message and stack trace for better debugging.
  Example code:

Existing code:
except Exception as e:
    get_logger().info(f"Failed to publish summarized code suggestions, error: {e}")

Improved code:
except Exception as e:
    get_logger().error("Failed to publish summarized code suggestions", exc_info=True)

Preparing PR description...

Preparing suggestions...

Code Suggestions
📌 Suggestion:
Correct the capability check to return True for 'gfm_markdown' as it is supported in GitLab.
File: pr_agent/git_providers/gitlab_provider.py (46-47)
  Example code:

Existing code:
if capability in ['get_issue_comments', 'create_inline_comment', 'publish_inline_comments']: # gfm_markdown is supported in gitlab !
    return False

Improved code:
if capability in ['get_issue_comments', 'create_inline_comment', 'publish_inline_comments']:
    return True

📌 Suggestion:
Use a more specific exception handling instead of a general one.
File: pr_agent/tools/pr_code_suggestions.py (271-272)
  Example code:

Existing code:
except Exception as e:
    get_logger().info(f"Failed to publish summarized code suggestions, error: {e}")

Improved code:
except SpecificException as e:  # Replace SpecificException with the specific exception you expect
    get_logger().info(f"Failed to publish summarized code suggestions, error: {e}")

📌 Suggestion:
Use a more descriptive variable name instead of sha_file for clarity.
File: pr_agent/git_providers/github_provider.py (506-506)
  Example code:

Existing code:
sha_file = hashlib.sha256(relevant_file.encode('utf-8')).hexdigest()

Improved code:
file_hash = hashlib.sha256(relevant_file.encode('utf-8')).hexdigest()

📌 Suggestion:
Correct the markdown for the details tag to properly format the summary.
File: pr_agent/tools/pr_reviewer.py (253-253)
  Example code:

Existing code:
markdown_text += "\n   Instructions\n\n"

Improved code:
markdown_text += "\nInstructions\n\n"

📌 Suggestion:
Remove unnecessary import of difflib if it's not used in the file.
File: pr_agent/tools/pr_code_suggestions.py (4-4)
  Example code:

Existing code:
import difflib

Improved code:
# import difflib (removed because it's not used)

📌 Suggestion:
Update the log message to match the action being performed.
File: pr_agent/tools/pr_code_suggestions.py (60-60)
  Example code:

Existing code:
get_logger().info('Preparing PR code suggestions...')

Improved code:
get_logger().info('Preparing code suggestions for PR...')

📌 Suggestion:
Ensure consistent indentation for markdown generation.
File: pr_agent/algo/utils.py (103-105)
  Example code:

Existing code:
if "relevant file" in sub_key.lower():
    markdown_text += f"\n  - **{sub_key}:** {sub_value}  \n"
else:
    markdown_text += f"   **{sub_key}:** {sub_value}  \n"

Improved code:
if "relevant file" in sub_key.lower():
    markdown_text += f"\n  - **{sub_key}:** {sub_value}\n"
else:
    markdown_text += f"    **{sub_key}:** {sub_value}\n"

Preparing suggestions...

PR Code Suggestions
💡 Suggestion:
Ensure consistent markdown formatting by adding a space after the hyphen for list items.
File: pr_agent/algo/utils.py (61-62)
  Example code:

Existing code:
markdown_text += f"\n\n- "
markdown_text += f" { emoji } Code feedback:\n\n"

Improved code:
markdown_text += f"\n\n-  { emoji } Code feedback:\n\n"

💡 Suggestion:
The get_line_link method in Bitbucket provider should handle the case when relevant_line_end is provided.
File: pr_agent/git_providers/bitbucket_provider.py (231-233)
  Example code:

Existing code:
def get_line_link(self, relevant_file: str, relevant_line_start: int, relevant_line_end: int = None) -> str:
    link = f"{self.pr_url}/#L{relevant_file}T{relevant_line_start}"
    return link

Improved code:
def get_line_link(self, relevant_file: str, relevant_line_start: int, relevant_line_end: int = None) -> str:
    link = f"{self.pr_url}/#L{relevant_file}T{relevant_line_start}"
    if relevant_line_end:
        link += f"-L{relevant_line_end}"
    return link

💡 Suggestion:
Correct the capability check for GitLab to include 'gfm_markdown' as a supported feature.
File: pr_agent/git_providers/gitlab_provider.py (46-47)
  Example code:

Existing code:
if capability in ['get_issue_comments', 'create_inline_comment', 'publish_inline_comments']: # gfm_markdown is supported in gitlab !
    return False

Improved code:
if capability in ['get_issue_comments', 'create_inline_comment', 'publish_inline_comments', 'gfm_markdown']:
    return True
return False

💡 Suggestion:
Add error logging for the publish_summarizes_suggestions method to provide more detailed information about exceptions.
File: pr_agent/tools/pr_code_suggestions.py (271-271)
  Example code:

Existing code:
except Exception as e:
    get_logger().info(f"Failed to publish summarized code suggestions, error: {e}")

Improved code:
except Exception as e:
    get_logger().error(f"Failed to publish summarized code suggestions, error: {e}", exc_info=True)

Preparing PR description...

/ask where should the images in this PR be stored?


Secure source manager

Checklist

I applicable, I acknowledge that I have:

[X] Read the contributing guide
[X] Ran terraform fmt on all modified files
[X] Regenerated the relevant README.md files using tools/tfdoc.py
[X] Made sure all relevant tests pass

Can you split IAM into variables-iam.tf and iam.tf and implement the full interface?

Yes, whielisting is required


Fixed an undefined method `start_with?' for nil:NilClass

st_prov_type is nil when adding a Catalog Bundle, st_prov_type is only on the initial screen when user selects type of Catalog Item they want to add.
Issue was introduced in commit 2c95dd58ece07628213c471a6aecfad37f3a8a5c
@bzwei please review.

LGTM

@dclarizio @martinpovolny please merge


Tokenizer missing CLS & EOS

I was wondering why I was unable to get results using the OpenClipAdapter, I was getting much better results with implementing & testing open_clip's functions outside of the class.
I checked out the output from the tokenizer and it seems like it's missing CLS and EOS which are added by the original tokenizer.
These tokens seems to be very important since the results improved quite a lot.
Tokenizer outputs:
classifier_free_guidance_pytorch.tokenizer: 4269,
open_clip.get_tokenizer("ViT-B-32"): 49406,  4269, 49407,
I could make changes and insert the CLS and EOS into the tensor but since you can change the model using the kwargs, I don't think that is the best way in case not all the CLIP models uses the exact same tokenizer.
laion400m_e32
Using: open_clip.get_tokenizer("ViT-B-32")
Calling with: return_text_encodings = False

chair & a chair
0.9584068655967712
table & chair
0.7539879083633423
curved table & curved chair
0.8386579155921936
flat table & flat chair
0.8263269662857056
flat table & curved chair
0.6225502490997314

Calling with: return_text_encodings = True

chair & a chair
0.9302060008049011
table & chair
0.7902950048446655
curved table & curved chair
0.8823343515396118
flat table & flat chair
0.8739901781082153
flat table & curved chair
0.6474944353103638

Using: classifier_free_guidance_pytorch.tokenizer
Calling with: return_text_encodings = False

chair & a chair
0.6290445327758789
table & chair
0.9999410510063171
curved table & curved chair
1.0000001192092896
flat table & flat chair
1.000000238418579
flat table & curved chair
0.9999337196350098

Calling with: return_text_encodings = True

chair & a chair
0.8913772106170654
table & chair
0.9999397397041321
curved table & curved chair
0.851962685585022
flat table & flat chair
0.848778486251831
flat table & curved chair
0.8365158438682556

@MarcusLoppe thanks for noting this Marcus! i threw in a quick fix (you should be able to configure this from MeshGPT init now)

Forgot to check the batch embedding but it's fixed now

@MarcusLoppe thanks! 🙏


MODULE_NOT_FOUND

Node-red V3.0.2
With node-red-contrib-stripe  I get the error
"Flows stopped due to missing node types"
MODULE_NOT_FOUND
I run a node-red-log and get the dump:
node-red-contrib-stripe:stripe-config : Error: Cannot find module 'lru-cache'
Require stack:
- /home/ubuntu/.node-red/node_modules/node-red-contrib-stripe/dist/stripe.js
-<EMAIL_ADDRESS>-<EMAIL_ADDRESS>-<EMAIL_ADDRESS>-<EMAIL_ADDRESS>- /usr/lib/node_modules/node-red/lib/red.js
- /usr/lib/node_modules/node-red/red.js

I installed "lru-cache" in node-red palette and still get the error MODULE_NOT_FOUND.
Stop and restarted NR:
25 Aug 22:29:45 - [info] Stopping flows
25 Aug 22:29:45 - [info] Stopped flows
25 Aug 22:29:45 - [info] Updated flows
25 Aug 22:29:45 - [info] Waiting for missing types to be registered:
25 Aug 22:29:45 - [info]  - stripe-config
25 Aug 22:29:45 - [info]  - stripe
25 Aug 22:41:22 - [info] Installing module: @atomic-org/lru-cache, version: 1.0.0
25 Aug 22:41:24 - [info] Installed module: @atomic-org/lru-cache
25 Aug 22:41:24 - [info] Added node types:
25 Aug 22:41:24 - [info]  - @atomic-org/lru-cache:LRU Cache
25 Aug 22:41:24 - [info]  - @atomic-org/lru-cache:LRU Cache Bucket
25 Aug 22:41:29 - [info] Stopping flows
25 Aug 22:41:29 - [info] Stopped flows
25 Aug 22:41:29 - [info] Updated flows
25 Aug 22:41:29 - [info] Waiting for missing types to be registered:
25 Aug 22:41:29 - [info]  - stripe-config
25 Aug 22:41:29 - [info]  - stripe
25 Aug 22:41:45 - [info] Stopping flows
25 Aug 22:41:45 - [info] Stopped flows
25 Aug 22:41:45 - [info] Updated flows
25 Aug 22:41:45 - [info] Waiting for missing types to be registered:
25 Aug 22:41:45 - [info]  - stripe-config
25 Aug 22:41:45 - [info]  - stripe

Still error persists.  Unable to remove node-red-contrib-stripe
This is on a fresh install of NR, and on Ubuntu 20

However much I want to help, Node-RED needs special care when compared with other packages I maintain.
Don't mean to ask for anything, but please read the maintenance notice in README.

OK will check it out thank you for your guidance.

ubuntu@xxxx:~/.node-red/node_modules/node-red-contrib-stripe$ npm update --save-dev --force
Seemed to fix it for now.

Please feel free to make a PR so others could benefit from it.


DuckDB array_element unparsing support

Which issue does this PR close?
DuckDB does not support array_element used by DataFusion and requires array element access by index.
Note: tests will be added when creating upstream PR.

@sgrebnov please make sure to track this in our list of upstream DataFusion changes


Adjust Hived image pull and build

Coverage remained the same at 34.837% when pulling a58923c6cf73c7015746bb990d94d4b096213dce on yqwang/dev into 0d96da5ddb9639b10323000046073272ada74a1b on master.


Paradox problem about getting an App ID: use JWT

Code of Conduct

[X] I have read and agree to the GitHub Docs project's Code of Conduct

What article on docs.github.com is affected?
https://docs.github.com/en/apps/creating-github-apps/authenticating-with-a-github-app/generating-a-json-web-token-jwt-for-a-github-app
What part(s) of the article would you like to see updated?
In the "Issuer" section of the JWT header, it says "You can find your app's ID with the GET /app REST API Endpoint." Unfortunately, you can't use that endpoint without also using JWT (both /app and /app/installations work). So we need another solution to get that App ID. We must do one of these approaches:

Collect it from the GUI
Collect it from the /apps/{app_slug} (if the slug is known)
Grab it at install time during the POST to app-manifests (if our code supports this)

Additional information
No response

Code of Conduct

[X] I have read and agree to the GitHub Docs project's Code of Conduct

What article on docs.github.com is affected?
https://docs.github.com/en/apps/creating-github-apps/authenticating-with-a-github-app/generating-a-json-web-token-jwt-for-a-github-app
What part(s) of the article would you like to see updated?
In the "Issuer" section of the JWT header, it says "You can find your app's ID with the GET /app REST API Endpoint." Unfortunately, you can't use that endpoint without also using JWT (both /app and /app/installations work). So we need another solution to get that App ID. We must do one of these approaches:

Collect it from the GUI
Collect it from the /apps/{app_slug} (if the slug is known)
Grab it at install time during the POST to app-manifests (if our code supports this)

Additional information
No response

Attribution 4.0 International
=======================================================================
Creative Commons Corporation ("Creative Commons") is not a law firm and
does not provide legal services or legal advice. Distribution of
Creative Commons public licenses does not create a lawyer-client or
other relationship. Creative Commons makes its licenses and related
information available on an "as-is" basis. Creative Commons gives no
warranties regarding its licenses, any material licensed under their
terms and conditions, or any related information. Creative Commons
disclaims all liability for damages resulting from their use to the
fullest extent possible.
Using Creative Commons Public Licenses
Creative Commons public licenses provide a standard set of terms and
conditions that creators and other rights holders may use to share
original works of authorship and other material subject to copyright
and certain other rights specified in the public license below. The
following considerations are for informational purposes only, are not
exhaustive, and do not form part of our licenses.
Considerations for licensors: Our public licenses are
intended for use by those authorized to give the public
permission to use material in ways otherwise restricted by
copyright and certain other rights. Our licenses are
irrevocable. Licensors should read and understand the terms
and conditions of the license they choose before applying it.
Licensors should also secure all rights necessary before
applying our licenses so that the public can reuse the
material as expected. Licensors should clearly mark any
material not subject to the license. This includes other CC-
licensed material, or material used under an exception or
limitation to copyright. More considerations for licensors:
wiki.creativecommons.org/Considerations_for_licensors

Considerations for the public: By using one of our public
licenses, a licensor grants the public permission to use the
licensed material under specified terms and conditions. If
the licensor's permission is not necessary for any reason--for
example, because of any applicable exception or limitation to
copyright--then that use is not regulated by the license. Our
licenses grant only permissions under copyright and certain
other rights that a licensor has authority to grant. Use of
the licensed material may still be restricted for other
reasons, including because others have copyright or other
rights in the material. A licensor may make special requests,
such as asking that all changes be marked or described.
Although not required by our licenses, you are encouraged to
respect those requests where reasonable. More considerations
for the public:
wiki.creativecommons.org/Considerations_for_licensees

=======================================================================
Creative Commons Attribution 4.0 International Public License
By exercising the Licensed Rights (defined below), You accept and agree
to be bound by the terms and conditions of this Creative Commons
Attribution 4.0 International Public License ("Public License"). To the
extent this Public License may be interpreted as a contract, You are
granted the Licensed Rights in consideration of Your acceptance of
these terms and conditions, and the Licensor grants You such rights in
consideration of benefits the Licensor receives from making the
Licensed Material available under these terms and conditions.
Section 1 -- Definitions.
a. Adapted Material means material subject to Copyright and Similar
Rights that is derived from or based upon the Licensed Material
and in which the Licensed Material is translated, altered,
arranged, transformed, or otherwise modified in a manner requiring
permission under the Copyright and Similar Rights held by the
Licensor. For purposes of this Public License, where the Licensed
Material is a musical work, performance, or sound recording,
Adapted Material is always produced where the Licensed Material is
synched in timed relation with a moving image.
b. Adapter's License means the license You apply to Your Copyright
and Similar Rights in Your contributions to Adapted Material in
accordance with the terms and conditions of this Public License.
c. Copyright and Similar Rights means copyright and/or similar rights
closely related to copyright including, without limitation,
performance, broadcast, sound recording, and Sui Generis Database
Rights, without regard to how the rights are labeled or
categorized. For purposes of this Public License, the rights
specified in Section 2(b)(1)-(2) are not Copyright and Similar
Rights.
d. Effective Technological Measures means those measures that, in the
absence of proper authority, may not be circumvented under laws
fulfilling obligations under Article 11 of the WIPO Copyright
Treaty adopted on December 20, 1996, and/or similar international
agreements.
e. Exceptions and Limitations means fair use, fair dealing, and/or
any other exception or limitation to Copyright and Similar Rights
that applies to Your use of the Licensed Material.
f. Licensed Material means the artistic or literary work, database,
or other material to which the Licensor applied this Public
License.
g. Licensed Rights means the rights granted to You subject to the
terms and conditions of this Public License, which are limited to
all Copyright and Similar Rights that apply to Your use of the
Licensed Material and that the Licensor has authority to license.
h. Licensor means the individual(s) or entity(ies) granting rights
under this Public License.
i. Share means to provide material to the public by any means or
process that requires permission under the Licensed Rights, such
as reproduction, public display, public performance, distribution,
dissemination, communication, or importation, and to make material
available to the public including in ways that members of the
public may access the material from a place and at a time
individually chosen by them.
j. Sui Generis Database Rights means rights other than copyright
resulting from Directive 96/9/EC of the European Parliament and of
the Council of 11 March 1996 on the legal protection of databases,
as amended and/or succeeded, as well as other essentially
equivalent rights anywhere in the world.
k. You means the individual or entity exercising the Licensed Rights
under this Public License. Your has a corresponding meaning.
Section 2 -- Scope.
a. License grant.
   1. Subject to the terms and conditions of this Public License,
      the Licensor hereby grants You a worldwide, royalty-free,
      non-sublicensable, non-exclusive, irrevocable license to
      exercise the Licensed Rights in the Licensed Material to:

        a. reproduce and Share the Licensed Material, in whole or
           in part; and

        b. produce, reproduce, and Share Adapted Material.

   2. Exceptions and Limitations. For the avoidance of doubt, where
      Exceptions and Limitations apply to Your use, this Public
      License does not apply, and You do not need to comply with
      its terms and conditions.

   3. Term. The term of this Public License is specified in Section
      6(a).

   4. Media and formats; technical modifications allowed. The
      Licensor authorizes You to exercise the Licensed Rights in
      all media and formats whether now known or hereafter created,
      and to make technical modifications necessary to do so. The
      Licensor waives and/or agrees not to assert any right or
      authority to forbid You from making technical modifications
      necessary to exercise the Licensed Rights, including
      technical modifications necessary to circumvent Effective
      Technological Measures. For purposes of this Public License,
      simply making modifications authorized by this Section 2(a)
      (4) never produces Adapted Material.

   5. Downstream recipients.

        a. Offer from the Licensor -- Licensed Material. Every
           recipient of the Licensed Material automatically
           receives an offer from the Licensor to exercise the
           Licensed Rights under the terms and conditions of this
           Public License.

        b. No downstream restrictions. You may not offer or impose
           any additional or different terms or conditions on, or
           apply any Effective Technological Measures to, the
           Licensed Material if doing so restricts exercise of the
           Licensed Rights by any recipient of the Licensed
           Material.

   6. No endorsement. Nothing in this Public License constitutes or
      may be construed as permission to assert or imply that You
      are, or that Your use of the Licensed Material is, connected
      with, or sponsored, endorsed, or granted official status by,
      the Licensor or others designated to receive attribution as
      provided in Section 3(a)(1)(A)(i).

b. Other rights.
   1. Moral rights, such as the right of integrity, are not
      licensed under this Public License, nor are publicity,
      privacy, and/or other similar personality rights; however, to
      the extent possible, the Licensor waives and/or agrees not to
      assert any such rights held by the Licensor to the limited
      extent necessary to allow You to exercise the Licensed
      Rights, but not otherwise.

   2. Patent and trademark rights are not licensed under this
      Public License.

   3. To the extent possible, the Licensor waives any right to
      collect royalties from You for the exercise of the Licensed
      Rights, whether directly or through a collecting society
      under any voluntary or waivable statutory or compulsory
      licensing scheme. In all other cases the Licensor expressly
      reserves any right to collect such royalties.

Section 3 -- License Conditions.
Your exercise of the Licensed Rights is expressly made subject to the
following conditions.
a. Attribution.
   1. If You Share the Licensed Material (including in modified
      form), You must:

        a. retain the following if it is supplied by the Licensor
           with the Licensed Material:

             i. identification of the creator(s) of the Licensed
                Material and any others designated to receive
                attribution, in any reasonable manner requested by
                the Licensor (including by pseudonym if
                designated);

            ii. a copyright notice;

           iii. a notice that refers to this Public License;

            iv. a notice that refers to the disclaimer of
                warranties;

             v. a URI or hyperlink to the Licensed Material to the
                extent reasonably practicable;

        b. indicate if You modified the Licensed Material and
           retain an indication of any previous modifications; and

        c. indicate the Licensed Material is licensed under this
           Public License, and include the text of, or the URI or
           hyperlink to, this Public License.

   2. You may satisfy the conditions in Section 3(a)(1) in any
      reasonable manner based on the medium, means, and context in
      which You Share the Licensed Material. For example, it may be
      reasonable to satisfy the conditions by providing a URI or
      hyperlink to a resource that includes the required
      information.

   3. If requested by the Licensor, You must remove any of the
      information required by Section 3(a)(1)(A) to the extent
      reasonably practicable.

   4. If You Share Adapted Material You produce, the Adapter's
      License You apply must not prevent recipients of the Adapted
      Material from complying with this Public License.

Section 4 -- Sui Generis Database Rights.
Where the Licensed Rights include Sui Generis Database Rights that
apply to Your use of the Licensed Material:
a. for the avoidance of doubt, Section 2(a)(1) grants You the right
to extract, reuse, reproduce, and Share all or a substantial
portion of the contents of the database;
b. if You include all or a substantial portion of the database
contents in a database in which You have Sui Generis Database
Rights, then the database in which You have Sui Generis Database
Rights (but not its individual contents) is Adapted Material; and
c. You must comply with the conditions in Section 3(a) if You Share
all or a substantial portion of the contents of the database.
For the avoidance of doubt, this Section 4 supplements and does not
replace Your obligations under this Public License where the Licensed
Rights include other Copyright and Similar Rights.
Section 5 -- Disclaimer of Warranties and Limitation of Liability.
a. UNLESS OTHERWISE SEPARATELY UNDERTAKEN BY THE LICENSOR, TO THE
EXTENT POSSIBLE, THE LICENSOR OFFERS THE LICENSED MATERIAL AS-IS
AND AS-AVAILABLE, AND MAKES NO REPRESENTATIONS OR WARRANTIES OF
ANY KIND CONCERNING THE LICENSED MATERIAL, WHETHER EXPRESS,
IMPLIED, STATUTORY, OR OTHER. THIS INCLUDES, WITHOUT LIMITATION,
WARRANTIES OF TITLE, MERCHANTABILITY, FITNESS FOR A PARTICULAR
PURPOSE, NON-INFRINGEMENT, ABSENCE OF LATENT OR OTHER DEFECTS,
ACCURACY, OR THE PRESENCE OR ABSENCE OF ERRORS, WHETHER OR NOT
KNOWN OR DISCOVERABLE.  WHERE A LIMITATION OF LIABILITY IS NOT ALLOWED IN FULL OR
IN PART, THIS LIMITATION MAY NOT APPLY TO YOU.
c. The disclaimer of warranties and limitation of liability provided
above shall be interpreted in a manner that, to the extent
possible, most closely approximates an absolute disclaimer and
waiver of all liability.
Section 6 -- Term and Termination.
a. This Public License applies for the term of the Copyright and
Similar Rights licensed here. However, if You fail to comply with
this Public License, then Your rights under this Public License
terminate automatically.
b. Where Your right to use the Licensed Material has terminated under
Section 6(a), it reinstates:
   1. automatically as of the date the violation is cured, provided
      it is cured within 30 days of Your discovery of the
      violation; or

   2. upon express reinstatement by the Licensor.

 For the avoidance of doubt, this Section 6(b) does not affect any
 right the Licensor may have to seek remedies for Your violations
 of this Public License.

c. For the avoidance of doubt, the Licensor may also offer the
Licensed Material under separate terms or conditions or stop
distributing the Licensed Material at any time; however, doing so
will not terminate this Public License.
d. Sections 1, 5, 6, 7, and 8 survive termination of this Public
License.
Section 7 -- Other Terms and Conditions.
a. The Licensor shall not be bound by any additional or different
terms or conditions communicated by You unless expressly agreed.
b. Any arrangements, understandings, or agreements regarding the
Licensed Material not stated herein are separate from and
independent of the terms and conditions of this Public License.
Section 8 -- Interpretation.
a. For the avoidance of doubt, this Public License does not, and
shall not be interpreted to, reduce, limit, restrict, or impose
conditions on any use of the Licensed Material that could lawfully
be made without permission under this Public License.
b. To the extent possible, if any provision of this Public License is
deemed unenforceable, it shall be automatically reformed to the
minimum extent necessary to make it enforceable. If the provision
cannot be reformed, it shall be severed from this Public License
without affecting the enforceability of the remaining terms and
conditions.
c. No term or condition of this Public License will be waived and no
failure to comply consented to unless expressly agreed to by the
Licensor.
d. Nothing in this Public License constitutes or may be interpreted
as a limitation upon, or waiver of, any privileges and immunities
that apply to the Licensor or You, including from the legal
processes of any jurisdiction or authority.
=======================================================================
Creative Commons is not a party to its public
licenses. Notwithstanding, Creative Commons may elect to apply one of
its public licenses to material it publishes and in those instances
will be considered the “Licensor.” The text of the Creative Commons
public licenses is dedicated to the public domain under the CC0 Public
Domain Dedication. Except for the limited purpose of indicating that
material is shared under a Creative Commons public license or as
otherwise permitted by the Creative Commons policies published at
creativecommons.org/policies, Creative Commons does not authorize the
use of the trademark "Creative Commons" or any other trademark or logo
of Creative Commons without its prior written consent including,
without limitation, in connection with any unauthorized modifications
to any of its public licenses or any other arrangements,
understandings, or agreements concerning use of licensed material. For
the avoidance of doubt, this paragraph does not form part of the
public licenses.
Creative Commons may be contacted at creativecommons.org.

@macetw Thank you for opening this issue! I'll get this triaged for review ✨

Thanks for catching this! We can replace that text instead with this text, which we use elsewhere in the docs:

You can find your app's ID on the settings page for your {% data variables.product.prodname_github_app %}. For more information about navigating to the settings page for your {% data variables.product.prodname_github_app %}, see "AUTOTITLE."

You or anyone else is welcome to open a PR to make this change.

Hmm, I expect the best practice for an app is to have a
registration/installation callback. We don't do that best practice, but
would have thought you want to send people down that path.
On Tue, Apr 2, 2024, 3:24 PM Sarah Edwards @.***> wrote:

Thanks for catching this! We can replace that text instead with this text,
which we use elsewhere in the docs:
You can find your app's ID on the settings page for your {% data
variables.product.prodname_github_app %}. For more information about
navigating to the settings page for your {% data
variables.product.prodname_github_app %}, see "AUTOTITLE
http:///apps/maintaining-github-apps/modifying-a-github-app-registration#navigating-to-your-github-app-settings
."
You or anyone else is welcome to open a PR to make this change.
—
Reply to this email directly, view it on GitHub
https://github.com/github/docs/issues/32309#issuecomment-2033028423, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AA2S2BPYXNL62DFNXUGWG6DY3MHYTAVCNFSM6AAAAABFPU7PRWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZTGAZDQNBSGM
.
You are receiving this because you were mentioned.Message ID:
@.***>

@skedwards88 if nobody has made a PR, I would love to make one to close this issue

@ahujaesh Go for it! 💛


feat(uat): added new step for scenario

Issue #, if available:
https://klika-tech.atlassian.net/browse/GGMQ-174
feat(uat): added new step for scenario
Description of changes:

Extend test scenario
Add new step

Why is this change necessary:
In GGMQ-1-T102 we testing ability to subscribe with retain handling
How was this change tested:
Scenarios run manually and on CI
Test results:
            <![CDATA[Given my device is registered as a Thing....................................passed
And my device is running Greengrass.........................................passed
When I create a Greengrass deployment with components.......................passed
And I create client device "publisher"......................................passed
And I create client device "subscriber".....................................passed
When I associate "subscriber" with ggc......................................passed
When I associate "publisher" with ggc.......................................passed
And I update my Greengrass deployment configuration, setting the component aws.greengrass.clientdevices.Auth configuration to:.passed
And I update my Greengrass deployment configuration, setting the component aws.greengrass.client.Mqtt5JavaSdkClient configuration to:.passed
And I deploy the Greengrass deployment configuration........................passed
Then the Greengrass deployment is COMPLETED on the device after 300 seconds.passed
Then I discover core device broker as "localMqttBroker1" from "publisher" in OTF.passed
Then I discover core device broker as "localMqttBroker2" from "subscriber" in OTF.passed
And I connect device "publisher" on aws.greengrass.client.Mqtt5JavaSdkClient to "localMqttBroker1" using mqtt "v5".passed
And I connect device "subscriber" on aws.greengrass.client.Mqtt5JavaSdkClient to "localMqttBroker2" using mqtt "v5".passed
And I set MQTT publish retain flag to true..................................passed
When I publish from "publisher" to "iot_data_001" with qos 0 and message "Old retained message".passed
When I publish from "publisher" to "iot_data_001" with qos 0 and message "New retained message".passed
And I set MQTT subscribe retain handling property to "MQTT5_RETAIN_SEND_AT_SUBSCRIPTION".passed
When I subscribe "subscriber" to "iot_data_001" with qos 0..................passed
And message "Old retained message" received on "subscriber" from "iot_data_001" topic within 5 seconds is false expected.passed
And message "New retained message" received on "subscriber" from "iot_data_001" topic within 5 seconds.passed
And I set MQTT publish retain flag to true..................................passed
When I publish from "publisher" to "iot_data_002" with qos 0 and message "Old retained message 002".passed
And I set MQTT publish retain flag to false.................................passed
When I publish from "publisher" to "iot_data_002" with qos 0 and message "New retained message 002".passed
When I subscribe "subscriber" to "iot_data_002" with qos 0..................passed
And message "New retained message 002" received on "subscriber" from "iot_data_002" topic within 5 seconds is false expected.passed
And message "Old retained message 002" received on "subscriber" from "iot_data_002" topic within 5 seconds.passed
And I set MQTT publish retain flag to true..................................passed
When I publish from "publisher" to "iot_data_0" with qos 0 and message "Hello world0".passed
And I set MQTT subscribe retain handling property to "MQTT5_RETAIN_SEND_AT_SUBSCRIPTION".passed
When I subscribe "subscriber" to "iot_data_0" with qos 0....................passed
And message "Hello world0" received on "subscriber" from "iot_data_0" topic within 5 seconds.passed
And I clear message storage.................................................passed
When I subscribe "subscriber" to "iot_data_0" with qos 0....................passed
And message "Hello world0" received on "subscriber" from "iot_data_0" topic within 5 seconds.passed
When I publish from "publisher" to "retained/iot_data_1" with qos 1 and message "Hello world1" and expect status 16.passed
And I set MQTT subscribe retain handling property to "MQTT5_RETAIN_SEND_AT_NEW_SUBSCRIPTION".passed
When I subscribe "subscriber" to "retained/iot_data_1" with qos 0...........passed
And message "Hello world1" received on "subscriber" from "retained/iot_data_1" topic within 5 seconds.passed
And I clear message storage.................................................passed
When I subscribe "subscriber" to "retained/iot_data_1" with qos 0...........passed
And message "Hello world1" received on "subscriber" from "retained/iot_data_1" topic within 5 seconds is false expected.passed
When I publish from "publisher" to "iot_data_2" with qos 0 and message "Hello world2".passed
And I set MQTT subscribe retain handling property to "MQTT5_RETAIN_DO_NOT_SEND_AT_SUBSCRIPTION".passed
When I subscribe "subscriber" to "iot_data_2" with qos 0....................passed
And message "Hello world2" received on "subscriber" from "iot_data_2" topic within 5 seconds is false expected.passed
And I set MQTT publish retain flag to false.................................passed
When I publish from "publisher" to "iot_data_3" with qos 0 and message "Hello world3".passed
And I set MQTT subscribe retain handling property to "MQTT5_RETAIN_SEND_AT_SUBSCRIPTION".passed
When I subscribe "subscriber" to "iot_data_3" with qos 0....................passed
And message "Hello world3" received on "subscriber" from "iot_data_3" topic within 5 seconds is false expected.passed
When I publish from "publisher" to "iot_data_4" with qos 0 and message "Hello world4".passed
And I set MQTT subscribe retain handling property to "MQTT5_RETAIN_SEND_AT_NEW_SUBSCRIPTION".passed
When I subscribe "subscriber" to "iot_data_4" with qos 0....................passed
And message "Hello world4" received on "subscriber" from "iot_data_4" topic within 5 seconds is false expected.passed
When I publish from "publisher" to "iot_data_5" with qos 0 and message "Hello world5".passed
And I set MQTT subscribe retain handling property to "MQTT5_RETAIN_DO_NOT_SEND_AT_SUBSCRIPTION".passed
When I subscribe "subscriber" to "iot_data_5" with qos 0....................passed
And message "Hello world5" received on "subscriber" from "iot_data_5" topic within 5 seconds is false expected.passed

Any additional information or context required to review the change:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Please remove <![CDATA[ from test results


Declutter text style problem when using style array

Describe the bug
In version 5.3 and  6.0.1 we have a problem with the declutter option.
When we use a text style array with two text styles on it so we can fix the placement of the text within a border. but if w use this with declutter set to true the style is not renderd correctly.
To Reproduce
Steps to reproduce the behavior:

Create a basic map
Add a separate layer for the labels
Add a array of text styles

See this example : https://codesandbox.io/s/vector-label-decluttering-njpsw
Expected behavior
The labels are generated with declutter
without declutter on labelLayer :

with declutter on for labelLayer:

import "ol/ol.css";
import Map from "ol/Map";
import View from "ol/View";
import GeoJSON from "ol/format/GeoJSON";
import VectorLayer from "ol/layer/Vector";
import VectorSource from "ol/source/Vector";
import { Fill, Stroke, Style, Text } from "ol/style";

var map = new Map({
  target: "map",
  view: new View({
    center: [0, 0],
    zoom: 1
  })
});

function stylef(feature, resolution) {
  var text = feature.get("name");
  var boxStyle = new Style({
    text: new Text({
      placement: "point",
      text: text,
      font: "12px Calibri,sans-serif",
      overflow: true,
      fill: new Fill({
        color: "rgba(0,0,0,0)"
      }),
      stroke: new Stroke({
        color: "rgba(0,0,0,0)"
      }),
      backgroundFill: new Fill({
        color: "#fff"
      }),
      backgroundStroke: new Stroke({
        color: "#000"
      })
    })
  });
  var labelStyle = new Style({
    text: new Text({
      placement: "point",
      text: text,
      font: "12px Calibri,sans-serif",
      overflow: true,
      fill: new Fill({
        color: "#000"
      }),
      stroke: new Stroke({
        color: "#fff",
        width: 3
      })
    })
  });

  return [boxStyle, labelStyle];
}

var countryStyle = new Style({
  fill: new Fill({
    color: "rgba(255, 255, 255, 0.6)"
  }),
  stroke: new Stroke({
    color: "#319FD3",
    width: 1
  })
});

var labelLayer = new VectorLayer({
  declutter: false, // <-- this will not work :'(
  source: new VectorSource({
    url: "data/geojson/countries.geojson",
    format: new GeoJSON()
  }),
  style: stylef
});

var vectorLayer = new VectorLayer({
  declutter: false,
  source: new VectorSource({
    url: "data/geojson/countries.geojson",
    format: new GeoJSON()
  }),
  style: countryStyle
});
map.addLayer(vectorLayer);
map.addLayer(labelLayer);

It's not because of an array.  Even with a single layer and the polygon and text parts in a single style the background fill and stroke is only applied to one feature (in the case of the example it looks like the last country visible in alphabetic order) and often the background is empty because the label has been decluttered.  https://codesandbox.io/s/vector-label-decluttering-9jyxf

Shall I update the title ?

Looks like these issues are related, but not the same.


[Bug] Very often I get, for the Table widget; "Oops, Something went wrong"

Description

put an input  on a form
connect the submit to an api call that returns an [{...},{...},...] JSON
add a Table
connect {{Api1.data}} as content of the Table
click on submit -> data appears
put something else in the input and click again -> "Oops, Something went wrong"

the result data is exactly the same...

Important Details

Version: Self-hosted / Docker install.sh
OS: Ubuntu 20
Browser Chrome, latest

Are there any logs which would show me oops errors?

@tluyben could you share an image of the property pane of the widget that is showing this?

Already discussed in Discord, but the issue goes away when the submit button has 'reset form on success' set to off/false.
And to fix my description a bit more ; the table is on the form which I forgot to mention (or rather thought was not relevant).


⚠ Bofrost.hr has degraded performance

In 6ece360, Bofrost.hr (https://www.bofrost.hr) experienced degraded performance:

HTTP code: 200
Response time: 2365 ms

Resolved: Bofrost.hr performance has improved in b3f4bd8 after 15 minutes.


iCal (ICS) support

So I've improved this PR, rebased it etc etc. I added support for insecure iCal parts (when I originally wrote the PR I didn't understand extraParts. I made some slight refactoring to make it clearer what extra parts were). I don't want to show every possible thing in the iCal spec - that's the point of a calendar app. I've just made it usable for the stuff you get in a typical event.
This PR still only supports reading the common iCal events. It doesn't support responding to them inside K-9. Outlook has a nice 'Accept / Tentative / Decline' thing which I'm tempted to implement. But that can be a separate PR - this stands up fine on it's own.
You can still download and open the iCal file corresponding to an event in Google if you want to.

I haven't yet looked at this very closely. But I saw a couple of FIXME comments and that's why I added the "don't merge" label.
@philipwhiuk: Can you please add screenshots to show off the feature.
Small note: There's no need to add a license file for a library whose source code doesn't live inside our repository.

The FIXME comments are mostly marking code that was already commented out. But I'll take a look and see why they were commented out before and fix it.

rebased on current master. I dropped the locked ical events, this is fallback anyways so showing those as locked attachments is fine.
I dislike how much code this adds, but it is a cool feature, especially if we have 1) automatic input into calendar, 2) quick accept/reject replies.

this would be really really nice to have

Love the idea. But I feel a feature like this needs more UI/UX design work upfront.


🐛PBI Viewer - VIM Viewer cannot support all reports

Reports were updated to Viewer 46, which breaks some reports:
We can either user many different versions of the viewer or fix the viewer to work in all instances

Revert to original version that supports two windows

Closing as too old


Add GitHub workflow for config provider to test against device-virtual

This PR's action has run successfully on my local branch: https://github.com/MonicaisHer/edgex-config-provider/actions/runs/3684722814


[theholetv] Add extractor

Before submitting a pull request make sure you have:

[x] At least skimmed through contributing guidelines including yt-dlp coding conventions
[x] Searched the bugtracker for similar pull requests
[x] Checked the code with flake8 and ran relevant tests

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[ ] Fix or improvement to an extractor (Make sure to add/update tests)
[x] New extractor (Piracy websites will not be accepted)
[ ] Core bug fix/improvement
[ ] New feature (It is strongly recommended to open an issue first)

The tests failing is an issue in master. Once you make another push, it'll fix itself


Update README.md to include note on auto start requiring full path.

Added a brief note instead, enough for most users. Thanks for the suggestion.


Setting the SQSRestServer port to something other than 9324 gives consumer error

Setting the elasticmq port to something other than default:
'SQSRestServerBuilder.withPort(elasticMqPort).withInterface("localhost").start();'
During startup it shows the wrong port in the log:
'15:54:00.102 [main] INFO  o.e.rest.sqs.TheSQSRestServerBuilder - Started SQS rest server, bind address localhost:9325, visible server address http://localhost:9324'
Consumer fails with:
'java.net.ConnectException: Connection refused'
Everything works fine when using the default port 9324

You probably mean the visible server address http://localhost:9324 part? That's another setting: how the server is visible form the outside (can be a different host/port). You also need .withServerAddress(new NodeAddress(...). Does this help?

Thanks!


NTPD configuration cleanups

Remove some options for restrict source template that make no sense there.. Also, do not use noselect with pools.

Incomplete, at least would like to make the noselect checkbox no-op in services_ntpd.php for pools in this round.

Well, there goes your daily dose of crappy JS... 🙄
At least it seems to do what's expected, for me at least. 😁


Check for NPM dependency updates

Check for any outstanding update of point version of any outstanding NPM package dependency

[ ] FAIL: npm-update

npm-update in progress on 2-ci-srv-04.
Log: https://<IP_ADDRESS>:8493/logs/npm-update-703-20190617-102828/

npm-update in progress on 4-cockpit-8.
Log: https://<IP_ADDRESS>:8493/logs/npm-update-703-20190617-101818/

npm-update in progress on 3-ci-srv-06.
Log: https://<IP_ADDRESS>:8493/logs/npm-update-703-20190617-103131/

npm-update in progress on 3-ci-srv-02.
Log: https://<IP_ADDRESS>:8493/logs/npm-update-703-20190617-103131/

npm-update in progress on 2-ci-srv-01.
Log: https://<IP_ADDRESS>:8493/logs/npm-update-703-20190617-102222/

npm-update in progress on 4-cockpit-9.
Log: https://<IP_ADDRESS>:8493/logs/npm-update-703-20190617-101818/

npm-update in progress on 1-ci-srv-01.
Log: https://<IP_ADDRESS>:8493/logs/npm-update-703-20190617-102222/

npm-update patternfly done: https://github.com/cockpituous/welder-web/commits/npm-update-patternfly-20190617-102929

npm-update patternfly done: https://github.com/cockpituous/welder-web/commits/npm-update-patternfly-20190617-102323

Error accessing /repos/weldr/cockpit-composer/pulls
Status: 422
Reason: Unprocessable Entity
Response: {"message":"The specified issue is already attached to a pull request.","errors":[{"value"None,"resource":"PullRequest","field":"issue","code":"invalid"}],"documentation_url":"https://developer.github.com/v3/pulls/#create-a-pull-request"}: https://<IP_ADDRESS>:8493/logs/npm-update-703-20190617-102222/

npm-update patternfly done: https://github.com/cockpituous/welder-web/commits/npm-update-patternfly-20190617-101919

Error accessing /repos/weldr/cockpit-composer/pulls
Status: 422
Reason: Unprocessable Entity
Response: {"message":"The specified issue is already attached to a pull request.","errors":[{"value"None,"resource":"PullRequest","field":"issue","code":"invalid"}],"documentation_url":"https://developer.github.com/v3/pulls/#create-a-pull-request"}: https://<IP_ADDRESS>:8493/logs/npm-update-703-20190617-101818/

npm-update patternfly done: https://github.com/cockpituous/welder-web/commits/npm-update-patternfly-20190617-103232

Please manually check features related to these files:
components/EmptyState/EmptyStateInactive.js:import { Alert, Button, OverlayTrigger, Tooltip } from "patternfly-react";
components/ListView/BlueprintContents.js:import { Tabs, Tab } from "patternfly-react";
components/ListView/ComponentDetailsView.js:import { Tabs, Tab } from "patternfly-react";
components/Modal/CreateBlueprint.js:import { Modal } from "patternfly-react";
components/Modal/CreateImage.js:import { Button, OverlayTrigger, Popover, Icon, Alert, Modal } from "patternfly-react";
components/Modal/DeleteBlueprint.js:import { Modal } from "patternfly-react";
components/Modal/ExportBlueprint.js:import { Modal } from "patternfly-react";
components/Modal/ManageSources.js:import { Modal, Alert, Spinner } from "patternfly-react";
components/Modal/PendingChanges.js:import { Button, OverlayTrigger, Popover, Icon, Alert } from "patternfly-react";
components/Toolbar/FilterInput.js:import { Filter } from "patternfly-react";
components/Toolbar/ToolbarLayout.js:import { Filter, Toolbar } from "patternfly-react";
package.json:    "patternfly": "3.59.2",
package.json:    "patternfly-react": "1.19.1",
pages/blueprint/index.js:import { Tab, Tabs } from "patternfly-react";
public/custom.css:/* modifications to patternfly css */
public/index.ejs:    <link rel="stylesheet" href="./css/patternfly.min.css">
public/index.ejs:    <link rel="stylesheet" href="./css/patternfly-additions.min.css">
webpack.config.js:  // copy patternfly assets
webpack.config.js:      from: { glob: "./node_modules/patternfly/dist/fonts/*.*" },
webpack.config.js:      from: "./node_modules/patternfly/dist/css/patternfly.min.css",
webpack.config.js:      from: "./node_modules/patternfly/dist/css/patternfly-additions.min.css",

Codecov Report

Merging #703 into master will decrease coverage by 2.25%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #703      +/-   ##
==========================================
- Coverage   78.67%   76.41%   -2.26%
==========================================
  Files          66       66
  Lines        3324     3324
  Branches      684      684
==========================================
- Hits         2615     2540      -75
- Misses        709      784      +75

Impacted Files
Coverage Δ

core/sagas/modals.js
40% <0%> (-44%)
:arrow_down:

components/ListView/SourcesListItem.js
78.94% <0%> (-21.06%)
:arrow_down:

components/Modal/ManageSources.js
73.59% <0%> (-18.41%)
:arrow_down:

core/reducers/modals.js
59.67% <0%> (-12.91%)
:arrow_down:

core/actions/modals.js
71.42% <0%> (-9.53%)
:arrow_down:

components/Notifications/Notification.js
66.66% <0%> (-6.35%)
:arrow_down:

core/composer.js
86.3% <0%> (-5.48%)
:arrow_down:

components/Form/Password.js
83.33% <0%> (-4.77%)
:arrow_down:

core/reducers/blueprints.js
78.62% <0%> (-3.45%)
:arrow_down:

components/ListView/ComponentInputs.js
80.59% <0%> (-2.99%)
:arrow_down:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 740ecb1...77b3180. Read the comment docs.


set_scroll_position in demo 00 not working

hi @oblomov-dev
recent change for set scroll position in demo 00, not working..
im not getting any error, its just not returning to previous scroll position when navigated back

it seems to work only when V is an integer
like this:

when its like this, its not scrolling to position

i changed now the value transfer to integers. https://github.com/abap2UI5/abap2UI5/pull/450
I hope this solves also your problem. Can you check again?

working


Clean up Model code

The current models are effective, but are using mostly blacklisted columns, rather than an explicit list of whitelisted columns. This is a security fix.
We also need to go through and check all the controllers and clean them up to use explicit collect()->only() or $request->only() methods to avoid any potential field injections. This risk is mitigated on the front-end by the way we do things, but theoretically possible on the back-end.

We should also add some more getters for stuff like hashed IDs, just for good measure.


Exception raised while executing Node synthstrip. (new with  23.0.0 ?)

What happened?
During CI testing of https://github.com/ReproNim/containers/  after some changes (which should not be related but who knows?) and using mriqc 23.0.0 in how we do it the mriqc ran from singularity

 started (https://github.com/ReproNim/containers/actions/runs/4506974074/jobs/7934313945>  to fail with (click to expand)
[INFO] == Command start (output follows) =====
230324-02:00:23,760 cli IMPORTANT:

    Running MRIQC version 23.0.0:
      * BIDS dataset path: /tmp/repro-VaY1i70/ds000003-qc/sourcedata.
      * Output folder: /tmp/repro-VaY1i70/ds000003-qc.
      * Analysis levels: ['participant', 'group'].

230324-02:00:38,526 cli WARNING:
	 IMPORTANT: Anonymized quality metrics (IQMs) will be submitted to MRIQC's metrics repository. Submission of IQMs can be disabled using the ``--no-sub`` argument. Please visit https://mriqc.readthedocs.io/en/latest/dsa.html to revise MRIQC's Data Sharing Agreement.
230324-02:05:38,657 nipype.workflow WARNING:
	 [Node] Error on "mriqc_wf.anatMRIQC.synthstrip_wf.synthstrip" (/tmp/repro-VaY1i70/ds000003-qc/workdir/mriqc_wf/anatMRIQC/synthstrip_wf/_in_file_..tmp..repro-VaY1i70..ds000003-qc..sourcedata..sub-13..anat..sub-13_T1w.nii.gz/synthstrip)
230324-02:05:39,637 nipype.workflow ERROR:
	 Node synthstrip.a1 failed to run on host fv-az1031-255.
230324-02:05:39,646 nipype.workflow ERROR:
	 Saving crash info to /tmp/repro-VaY1i70/ds000003-qc/logs/crash-20230324-020539-runner-synthstrip.a1-93bacc0d-4206-4313-bb94-f258a04c3530.txt
Traceback (most recent call last):
  File "/opt/conda/lib/python3.9/site-packages/mriqc/engine/plugin.py", line 60, in run_node
    result["result"] = node.run(updatehash=updatehash)
  File "/opt/conda/lib/python3.9/site-packages/nipype/pipeline/engine/nodes.py", line 527, in run
    result = self._run_interface(execute=True)
  File "/opt/conda/lib/python3.9/site-packages/nipype/pipeline/engine/nodes.py", line 645, in _run_interface
    return self._run_command(execute)
  File "/opt/conda/lib/python3.9/site-packages/nipype/pipeline/engine/nodes.py", line 771, in _run_command
    raise NodeExecutionError(msg)
nipype.pipeline.engine.nodes.NodeExecutionError: Exception raised while executing Node synthstrip.

Cmdline:
	synthstrip -b 1 -i /tmp/repro-VaY1i70/ds000003-qc/workdir/mriqc_wf/anatMRIQC/synthstrip_wf/_in_file_..tmp..repro-VaY1i70..ds000003-qc..sourcedata..sub-13..anat..sub-13_T1w.nii.gz/pre_n4/clipped_corrected.nii.gz --model /opt/freesurfer/models/synthstrip.1.pt -o clipped_corrected_desc-brain.nii.gz -m clipped_corrected_desc-brain_mask.nii.gz
Stdout:

Stderr:
	Killed
Traceback:
	RuntimeError: subprocess exited with code 137.

Traceback (most recent call last):
  File "/opt/conda/bin/mriqc", line 8, in <module>
    sys.exit(main())
  File "/opt/conda/lib/python3.9/site-packages/mriqc/cli/run.py", line 167, in main
    mriqc_wf.run(**_plugin)
  File "/opt/conda/lib/python3.9/site-packages/nipype/pipeline/engine/workflows.py", line 638, in run
    runner.run(execgraph, updatehash=updatehash, config=self.config)
  File "/opt/conda/lib/python3.9/site-packages/mriqc/engine/plugin.py", line 1[84](https://github.com/ReproNim/containers/actions/runs/4506974074/jobs/7934313945#step:4:85), in run
    self._clean_queue(jobid, graph, result=result)
  File "/opt/conda/lib/python3.9/site-packages/mriqc/engine/plugin.py", line 256, in _clean_queue
    raise RuntimeError("".join(result["traceback"]))
RuntimeError: Traceback (most recent call last):
  File "/opt/conda/lib/python3.9/site-packages/mriqc/engine/plugin.py", line 60, in run_node
    result["result"] = node.run(updatehash=updatehash)
  File "/opt/conda/lib/python3.9/site-packages/nipype/pipeline/engine/nodes.py", line 527, in run
    result = self._run_interface(execute=True)
  File "/opt/conda/lib/python3.9/site-packages/nipype/pipeline/engine/nodes.py", line 645, in _run_interface
    return self._run_command(execute)
  File "/opt/conda/lib/python3.9/site-packages/nipype/pipeline/engine/nodes.py", line 771, in _run_command
    raise NodeExecutionError(msg)
nipype.pipeline.engine.nodes.NodeExecutionError: Exception raised while executing Node synthstrip.

Cmdline:
	synthstrip -b 1 -i /tmp/repro-VaY1i70/ds000003-qc/workdir/mriqc_wf/anatMRIQC/synthstrip_wf/_in_file_..tmp..repro-VaY1i70..ds000003-qc..sourcedata..sub-13..anat..sub-13_T1w.nii.gz/pre_n4/clipped_corrected.nii.gz --model /opt/freesurfer/models/synthstrip.1.pt -o clipped_corrected_desc-brain.nii.gz -m clipped_corrected_desc-brain_mask.nii.gz
Stdout:

Stderr:
	Killed
Traceback:
	RuntimeError: subprocess exited with code 137.

[INFO] == Command exit (modification check follows) =====

Prior successfull run in https://github.com/ReproNim/containers/actions/runs/4496233226/jobs/7910699465 had containers/images/bids/bids-mriqc--0.16.0.sing  so I now suspect new version of mriqc to cause this problem
What command did you use?
Such testing run should be redoable on Linux (with singularity) or OSX (with docker) with datalad-container installed via

git clone https://github.com/ReproNim/containers/
cd containers
bash <(sed -n -e '/^ *#!/,/^```$/p' README.md | grep -v '```')

What version of fMRIPrep are you running?
none
How are you running this software?
Singularity
Is your data BIDS valid?
Yes
Are you reusing any previously computed results?
No
Please copy and paste any relevant log output.
No response
Additional information / screenshots
No response

Duplicate of #1004.

oh cool, I did search for Exception raised while executing Node synthstrip so failed to find that one . hopefully it gets tracked down soon. For now I guess I would need to switch to use some other app  unless you are aware of some workaround? (E.g. generate some large swap file and add it to the instance)

Oscar can clarify, but my understanding is that the plan is to keep on with synthstrip and users will just need to throw bigger machines at the problem until some combination of numpy/pytorch/FreeSurfer take steps to reduce the memory usage.
I don't know of any workarounds, and swap files seem like they'll end up performing worse than just using a pre-SynthStrip version of MRIQC.


Heading attributes should fall in sequential order

h2 element in the footer was changed to h4. all other headings are in order. checked!


selectBox active action demo WIP to address #47749

@Tyriar
@isidorn
@bpasero
Since this is a touchy-feely thing I went ahead and did a quick prototype so you guys can check how it behaves/feels.
NOTE: QUICK AND DIRTY CODE, USED OPTION STRING HACK!  WOULD ADD SOME FORM OF ACTION TAG FOR GENERAL SOLUTION.
New Behavior (Drop-down focused, not expanded):

Navigation keys Up, Down, End, Home, PageUp/Down , First Option character change selection as before matching normal OS behavior
If the selection lands on an "action item" , do not fire event thus causing action eg Add Configuration
If user presses enter, fire event
If user moves focus either mouse or keyboard , restore selection from the point of focus (this matches the behavior we updated when the drop-down is open, user must actively select item, otherwise selection is restored)

@Tyriar @cleidigh since I see the exact same behaviour when using the native dropdown in HTML I would vote for closing this "as designed". To open the dropdown, press Space key instead.

@bpasero here's the problem with the current behavior: if the debug dropdown on Linux (and maybe Windows?) has only one item and you are navigating with the keyboard to the dropdown and then press down, the launch.json will be opened. This is an accessibility issue imo, sending focus away is certainly not what I would expect as I wanted to browse the options.
I want to align with the OS behave also, the native OS behavior would fire the onChange event when enter is pressed or when <select> is unfocused.

@Tyriar
Did you get a chance to try this PR?  I want to see if it matches what you expect.

@cleidigh yep this is pretty much exactly what I expect if the option is going to move focus.

@Tyriar
okay cool.  I think this behavior both matches the native OS behavior and is consistent in that the user has to "actively" choose the option to fire the event.  This would be consistent with the drop-down closed or open.
I am the outsider so it's up to you and @bpasero .

@cleidigh @Tyriar I think this can easily be fixed differently by keeping the current behaviour (which is the native behaviour of dropdowns in HTML). We could just not focus the editor when it opens and keep it in the dropdown, no?

@bpasero the point of the action in debug is that the editor is focused, since I open the suggest widget and the users chooses the snippet by going up / down (thus it being focused)
I suggest to simply not fix this.

@isidorn maybe you could distinguish if the item was picked in the dropdown via keyboard or mouse and not move focus if the keyboard is used to preserve keyboard focus in the element.

@bpasero that makes somewhat sense since the action should not be executed if the focus can not be moved.
So it is either execute the action and move focus, or do not execute it and leave focus.

@bpasero can you please try the action? The point of the action is not to open the launch.json. But to open the suggest box, which does not make sense without focus.

@isidorn I thought this only applies for the last entry "Add configuration..." but not for the other ones?

@bpasero exactly. Daniel's use case is that he has not configurations so this is the only one in his dropdown.

@isidorn I see the issue.
I still think that the custom dropdown is not the one to fix this (if we wanted to fix it) because the previous native dropdown behaviour was exactly the same.

Did we get our final on this?  Close?


fix: macos version to run on xcode13

Checkmarx One – Scan Summary & Details – d37c0009-a6f4-4a7a-bc5e-339f4e686d0d
No New Or Fixed Issues Found


fix: add missing dependency registration

:tada: This PR is included in version 0.61.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Added support for Bearer token

Added support for passing access token value in 'Authorization' header (Bearer token) according to https://tools.ietf.org/html/rfc6750

Codecov Report

Merging #8 into master will increase coverage by 1.17%.
The diff coverage is 96.66%.

@@            Coverage Diff             @@
##           master       #8      +/-   ##
==========================================
+ Coverage   87.08%   88.25%   +1.17%
==========================================
  Files          11       11
  Lines         240      264      +24
==========================================
+ Hits          209      233      +24
  Misses         31       31

Impacted Files
Coverage Δ

tests/test_decorators.py
100% <100%> (ø)
:arrow_up:

flask_graphql_auth/decorators.py
74.28% <91.66%> (+2.41%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0f4ac6...061a259. Read the comment docs.

Thanks for PR!
The purpose of PR is really good, but I think this approach is not beautiful and going to be a little confusing.
If we modifying decorators like this, each decorator will have two responsibilities. verify token from the header and verifying token from the query.
and this is violating the single responsibility principle.
If you really want to add support for bearer token from the header, I think this is would be better to make another decorator named like "header_jwt_required", not to modify existing decorators. to follow the single responsibility principle
like this!
class Query(graphene.ObjectType):
    protected = graphene.Field(type=ProtectedUnion)  # no "token" argument here

    @header_jwt_required
    def resolve_protected(self, info):
        return MessageField(message="Hello World!")

Still, no updates and another PR opened for this topic. so close this.


Implement a Top partitioner

This diff implements a new parittioners module which includes a Top partitioner. Top replicates the combiners.Top behavior.
This is a WIP. I initially implemented this for my particular case which is global-window-only, but I should probably go back through this and add API for Smallest, Largest, PerKey etc. Posting this early though in case anyone has any comments
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

reviewer: @damccorm

Codecov Report

Merging #29106 (206042e) into master (38720a3) will decrease coverage by 33.87%.
Report is 446 commits behind head on master.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           master   #29106       +/-   ##
===========================================
- Coverage   72.22%   38.36%   -33.87%
===========================================
  Files         684      687        +3
  Lines      100856   101693      +837
===========================================
- Hits        72846    39010    -33836
- Misses      26434    61107    +34673
  Partials     1576     1576

Flag	Coverage Δ
python 29.97% <0.00%> (-52.86%)	⬇
Flags with carried forward coverage won't be shown. Click here to find out more.
Files	Coverage Δ
sdks/python/apache_beam/transforms/partitioners.py 0.00% <0.00%> (ø)
... and 316 files with indirect coverage changes
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

How exactly does the codecov bot invoke tests? I suspect that the new module should have ~100% coverage but the new test probably is getting missed somehow by codecov

How exactly does the codecov bot invoke tests? I suspect that the new module should have ~100% coverage but the new test probably is getting missed somehow by codecov

Yeah, the codecov bot is frustratingly wrong sometimes, but especially on new code it seems? Your tests did run - https://ci-beam.apache.org/job/beam_PreCommit_Python_Coverage_Commit/4639/testReport/apache_beam.transforms.partitioners_test/ - so I'm not too worried about the bad signal

Codecov Report
Attention: Patch coverage is 0% with 33 lines in your changes are missing coverage. Please review.

Project coverage is 38.36%. Comparing base (38720a3) to head (206042e).
Report is 1812 commits behind head on master.

Files
Patch %
Lines

sdks/python/apache_beam/transforms/partitioners.py
0.00%
33 Missing :warning:

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #29106       +/-   ##
===========================================
- Coverage   72.22%   38.36%   -33.87%
===========================================
  Files         684      687        +3
  Lines      100856   101693      +837
===========================================
- Hits        72846    39010    -33836
- Misses      26434    61107    +34673
  Partials     1576     1576

Flag
Coverage Δ

python
29.97% <0.00%> (-52.86%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


MILESTONE: Match C++ engine in octopus

[x] https://github.com/simularium/octopus/issues/5
[ ] https://github.com/simularium/octopus/issues/12
[ ] https://github.com/simularium/octopus/issues/29

Use Case
As a developer of the viewer, I want the octopus engine to have all the features I required from the current C++ engine so that it can be used in production with the viewer.
Acceptance Criteria
All the current requests made by the viewer to the C++ backend can be handled by octopus reasonably performantly.

A couple of other things to check:

need to implement secure websockets wss protocol?
automate deployment via gh-actions? - might be much simpler than simularium-engine if we leave out all the k8s stuff and just go straight to an instance
stress test in staging in cloud
have we covered all the websocket messages that the viewer wants to send/receive?

@ascibisz also think about other features needed to bring Octopus to parity with C++ engine


Feature request: "Facade" Segment

Hi,
In my use-case I need to create a "facade" segment to mimic an existing Segment and send subsegment (and only subsegment) to X-Ray.
There is an equivalent in the nodejs package aws-cray-sdk-core
var facadeSegment = function facadeSegment() {
  var segment = new Segment('facade');
  var whitelistFcn = ['addNewSubsegment', 'addSubsegment', 'removeSubsegment', 'toString'];
  var silentFcn = ['incrementCounter', 'decrementCounter', 'isClosed', 'close', 'format', 'flush'];
  //...
  return segment;
}

@lsuss , thank you for reaching out to us. Unfortunately, we haven't implemented similar method in our Go SDK so far. However, we gonna start writing the method and will be added into upcoming release. I will let you know about it when it released.

@luluzhao thank you for your response. Good to hear it's a work in progress. I would be happy to help by testing it as soon as you make it available :+1:

This is working perfectly for me. Thank you!


Soft tab related issue

When soft tab is enabled, cursor moves by arrow-keys will jump sometimes and the content will go strange when save.

#798


Function definitions: highlight first command word

In f() foo bar, highlight foo as a command word.
This should be simpler than #223, which is about highlighting f: that issue requires (arbitrary far) lookahead, this issue does not.
As discussed in #223:

f g h() {} works only when MULTI_FUNC_DEF is set.
The syntax function f [g h…] { } also exists.

Not recognising the word after () as a command position causes definition of (named) functions to highlight their closing braces as errors, due to yesterday's #367 /  (51b9d79c3bb61d3233a67b440f6ef7899d04b8c9.

The logic of the function f g h { } syntax is in par_funcdef.

Test coverage:
brackets-mismatch1.zsh:31:BUFFER='() { echo foo )'
function-named1.zsh:31:BUFFER='f() pwd; f() { balanced braces }'
anonymous-function.zsh:30:BUFFER='() echo hello; () { echo world } "argument"'
function-named2.zsh:31:BUFFER='f g h () pwd'
parameter-star.zsh:30:BUFFER='() { : $* }'

However, function f { pwd } and function { pwd } are not handled yet.


Make compiler support Distributions wihtout parameters

For has_ops, it just check if a Distribution() has optional arguments. It gives true if we have something like Normal(0, 1; :static=true) and gives false if there is no optional arguments. It's my bad not giving comments. I'll add comment to it now.

Previously the compiler gave error to @assume x ~ Binomial() because Binomial() doesn't have any arguments. This PR is to fix this issues.

That makes sense. Thanks!


Fragmented scaffolds - large and repetitive genome

Hi. We have got a 3d-dna output using 30x HiFi data and in-house Hi-C for a large, highly repetitive genome of about 5Gb, shown in a contact map on Juicebox like this.

We see 1) a huge fraction for which we could not retrieve chromatin contact and 2) a number of signals far away from the diagonal line, that is, fragments that failed to be resolved into chromosomal scaffolds. I expect that at least the fractions 2) can be better resolved into chromosomal scaffolds by tweaking with parameters. Any recommendations?
I would really appreciate your response.
Best regards.

Hi,
Closing since this is not a bug report. Please consider reposting in Aidenlab.org/forum.html.
Thanks!
Olga


In-app messaging not working on Android

Hi team,
I'm currently unable to get in-app messages delivered to Android devices. They are working fine on iOS.
As far as I can see, Android is working fine apart from this, tracking events and users. The test user is shown in Mixpanel in the in-app messaging dashboard as being seen recently but the message never gets delivered.
We are running the following:
react-native-cli: 2.0.1
react-native: 0.59.10
react-native-mixpanel: 0.0.16
Appreciate we are a little behind on the react-native-mixpanel version but is there anything we can try here without upgrading (or with)? Looks like<EMAIL_ADDRESS>still uses mixpanel sdk which is 5+ which meets requirements for in-app messaging.
Any help would be hugely appreciated.
Thanks,
Anna

@abeddow91 Did you add <activity android:name="com.mixpanel.android.takeoverinapp.TakeoverInAppActivity"          android:theme="@style/com_mixpanel_android_TakeoverInAppActivityTheme"/> to AndroidManifest.xml file.?
https://developer.mixpanel.com/docs/android-inapp-messages

Hi @abeddow91, did you find a solution? I'm having the same issue.

afraid not!

Have you tried explicitly adding mixpanel SDK in app's build.grade?
dependencies {
    implementation 'com.mixpanel.android:mixpanel-android:5.+'
}


Java is recognised as 2 languages

Describe the bug
Java is recognised as 2 different languages, "Java" and "JAVA". With the same inputs (forwarding through the wakatime integration) wakatime only registers 1 java, combining time of the 2. The bug can be reproduced by coding java in IntelliJ (possibly more ides, have not tested) with the wakatime plugin.
This bug is a problem as the leaderboards only look at one of the java types, making the leaderboards inaccurate.

thanks for reporting this! i'm not going to try and fix this as this is more of a plugin problem


Central Maven Repository

Is there any chance you all will submit an artifact to the central maven repository?

It's a fairly complicated process that I have yet to get started, and it's something I want too.
It would be nice to get Travis CI to build the project as well, as it's possible to make it automatically deploy to Maven Central. I'd still have to go through all of the steps above to be able to publish to that repository.

It's a fairly complicated process that I have yet to get started, and it's something I want too. I'd probably be registering with Sonatype which is yet another lengthy process.
It would be nice to get Travis CI to build the project as well, as it's possible to make it automatically deploy to Maven Central. I'd still have to go through all of the steps above to be able to publish to that repository.

any news?

Sorry, I haven't looked into it due to low demand and other priorities.

Sorry, I haven't looked into it due to low demand and other priorities.

Understood.
If you don't mind I will put it on maven following MIT.

Sure, go ahead.


Native runtime reorganization

Context: https://github.com/dotnet/android/pull/9006
This PR prepares ground for dynamic native runtime linking at application build time.
Changes implemented here can be committed to main and, possibly, released with .NET9
without changing how things currently work.  Thanks to this PR, https://github.com/dotnet/android/pull/9006 is
going to be easier to review once it's ready for it.

I'm going to merge the PR since it contains no substantial functional changes, simply moves code around and tweaks a handful of things.  At the same time, it moves things around enough to make maintenance of other PRs touching the code a bit troublesome.  All tests are green (MAUI tests are known to be broken atm).


Support android-arm64

Please support android-arm64 for future updayes. I have successfully built this and am using it, however it took around 20 minutes of downloading and building on my tablet, and it got rather warm; it would be nice if it could be installed through the cli instead; there are no changes necessary, and github actions should be able to perform the build.

This seems quite reasonable to be done during release similar to the other binaries.
The only issue I see is i'm not sure how one is using gh cli on android. I feel like I would need to understand that to be able to fully support the builds if an issue arises running it.
To that end what method are you using to use the gh cli on android?

I'm using it in termux normally. GH CLI is available through the default termux repo:
❯ apt show gh
Package: gh
Version: 2.33.0
Maintainer: Krishna kanhaiya @kcubeterm
Installed-Size: 47.2 MB
Homepage: https://cli.github.com/
Download-Size: 7036 kB
APT-Manual-Installed: yes
APT-Sources: https://packages.termux.dev/apt/termux-main stable/main aarch64 Packages
Description: GitHub’s official command line tool

~  with 🐏 5GiB/7GiB | 2GiB/4GiB took 47ms
❯ which gh
/data/data/com.termux/files/usr/bin/gh

~  with 🐏 5GiB/7GiB | 2GiB/4GiB took 13ms
❯ gh repo list --limit 5

Showing 5 of 134 repositories in @Efreak                                                                                Efreak/AI-Horde-Styles                 Styles to use to enhan...  public, fork  2h
Efreak/AI_Horde_Discord                A discord bot to inter...  public, fork  17h
Efreak/AI-Horde-image-model-reference                             public, fork  5d
Efreak/artbot-for-stable-diffusion     A front end GUI for in...  public, fork  19d
Efreak/hordelib                        A wrapper around Comfy...  public, fork  26d

~  with 🐏 5GiB/7GiB | 2GiB/4GiB took 842ms
❯

This should be available now via #46


snap failed, tiktok: failed to find roomID

Hello,
since a few days, I get:
TRAC[2024-07-11 14:41:41] snap failed, tiktok: failed to find roomID
is there any update?
Thanks a lot!

is this project dead?


proxy: Avoid sorting endpoints for every request

Description
The endpoints are no longer hashed by path name in the directors map since that made iterating over the endpoints unstable. They are now stored in a slice in the order in which the are defined in the configuration.
This also includes a fix to make the archiver work for public-links (https://github.com/owncloud/ocis/pull/4461#pullrequestreview-1093104888)
Related Issue

Fixes  #4497

:boom: Acceptance test localApiTests-apiArchiver-ocis failed. Further test are cancelled...

I thought about my comment about the archiver again, and actually I'm confused here. oC Web always adds the public-token to the url query (on any public link), so the public token auth provider should be used in the authentication middleware... and fails? Might just be a bug in the auth provider. The route should not be unprotected, as I thought initially. Does that sound reasonable?

Yes. That's what I also found out while looking at the code.  IIUC the  _publicPaths slice contains a list of paths which are enabled for the public token auth provider. I.e. "public token auth" only works for paths listed there. And /archiver was simply missing. (This change does not make the archiver unprotected)

Hm, this seems to break the archiver somehow:-( (https://drone.owncloud.com/owncloud/ocis/15224/42/8)

I thought about my comment about the archiver again, and actually I'm confused here. oC Web always adds the public-token to the url query (on any public link), so the public token auth provider should be used in the authentication middleware... and fails? Might just be a bug in the auth provider. The route should not be unprotected, as I thought initially. Does that sound reasonable?

Yes. That's what I also found out while looking at the code.  IIUC the _publicPaths slice contains a list of paths which are enabled for the public token auth provider. I.e. "public token auth" only works for paths listed there. And /archiver was simply missing. (This change does not make the archiver unprotected)

Ah, makes sense, thanks for explaining :heart:

You need to rebase from master and then the go generate steps should work again.


[WIP] Figwheel

Context
Adding Figwheel support (through figwheel.main). This provides a good default ClojureScript development experience. Figwheel will be included with the clojurescript plugin, but not clojurescript-base.
This involved reworking the configuration approach for compiler options on both Clojure and ClojureScript to use a "builds" concept similar to what you have with lein-cljsbuild (from what I understand).
The reflection warnings config was also simplified from 3 booleans to an enum with 3 options:

silent (default) equivalent of old reflectionWarnings { enabled = false }
warn (default) equivalent of old reflectionWarnings { enabled = true }
fail (default) equivalent of old reflectionWarnings { enabled = true; asErrors=true; projectOnly = true }

Previously, you were allowed to fail your build if your libraries caused a reflection warning. That seemed like a pretty uncommon thing to need, since you don't have much control over that. However, it could be added back as a 4th enum, if needed.
Related issues: #29
Remaining Steps

[ ] Write CLJS builds into the nREPL, so they're available for figwheel
[ ] Update documentation to show new "builds" configuration style

Contributor Checklist

[ ] Review Contributing Guidelines.

[ ] Commits contain discrete changes, messages include context about why the change was made and reference the relevant issues.

[ ] Provide functional tests. (under modules/gradle-clojure-plugin/src/compatTest)

[ ] Update documentation for user-facing changes. (under docs/)

[ ] Ensure all verification tasks pass locally. (./gradlew check)

[ ] Ensure CI builds pass on all Java versions. (watch for commit statuses once the PR is opened)
TIP: If troubleshooting a CI failure, look for the build scan URL near the bottom of the Gradle output.

Very nice :) !
The used EDN Java library is in a pretty abandoned state however.

@aadrian As far as I can tell there aren't any other options for writing edn from Java. Unless maybe Transit (which I haven't looked much into) would be an option for this type of communication.

As far as I can tell there aren't any other options for writing edn from Java.

We had this problem in other projects too (in fact many JVM projects could be greatly simplified by using EDN).
IMHO the best strategy would be just to fork the project, to be able to do some releases and required updates.

What are some of the unresolved issues? So far it seems to be doing the job for our use case.

What are some of the unresolved issues?

In order to be useful in the many JVM projects, the the community offered to fix/improve but it did not worked out.
Few of the outstanding issues:

a more recent release would be required (the changes are in the development branch)
Java 8 support
fully and correctly support the EDN format
documentation/examples
common usage API
groovy wrapper
another test framework would be needed since Caliper was abandoned by Google too.

Just to mention a few

Not sure what you mean by Java 8 support, I'm running it on 8, 9, and 10 for our test suite.
Speaking for myself, I'd rather we didn't start maintaining an EDN library. Until we run into an issue for the plugin's EDN usage, it seems like a moot point though.