Issue with S3 Job UI: Secrets field only pulls first page from Secrets Manager

Describe the bug
As title indicates, when setting up an S3 replication job, the Secret field for both source and destination has broken pagination where it only displays the first page from Secrets Manager.
To Reproduce

Launch stack with the Cloudformation template on this main GitHub page
Login to DTH UI
Navigate to the S3 job UI
Under "Source" or "Destination there is a field to select the Secret to use with the job, which shows Secrets within Secrets Manager as a drop down.
Only the first page of Secrets shows up within the drop down.

Expected behavior
The expectation here is that all Secrets Manager keys should be aggregated to the drop down for selection.
Please complete the following information about the solution:

[ v1.0.0] Version
[us-west-2 ] Region
[Yes and No ] Was the solution modified from the version published on this repository? --- We noticed the behavior on our own modified template (just has some dynamic VPC/Subnet selection). We then launched the template directly from this GIT and it showed the same behavior.
[No] If the answer to the previous question was yes, are the changes available on GitHub?
[Yes] Have you checked your service quotas for the sevices this solution uses?
[No] I didn't see any errors pointing to this problem. It returns Secrets, just not all of them.

Screenshots
Hard to screenshot this. Isn't any errors, just a behavior.
Additional context
I re-ordered the Secrets so that the secret that we want to use with DTH is available on the first page, and then it showed up within S3 Job UI within DTH.
Tried new spinup after creating the Secret, no go.
Tried it in multiple browesers (Firefox, Opera, Safari) same issue.
Tried clearing cache (full purge, + machine restart) no go.

@gderoule Hi, please update the Data Transfer Hub stack by this link: https://www.amazonaws.cn/en/solutions/data-transfer-hub/
After you updated the stack, please don't forget to create invalidation for the Data Transfer Hub Distribution in the CloudFront.


Previous Value not updated

Describe the bug
At midnight, the daily previous value is not updated
To Reproduce
Steps to reproduce the behavior:

Wait midnight

Expected behavior
Perform the update
Additional context
In source code sensor.py, it seems that the current value can be set to None : so if it occurs at midnight, None is recorded

Hi @jugla ,
the issue is back for me, either the refresh stop after 2 hours. You confirm?

Hello
This issue is for the new functionnality to record the previous state.
Normally the issue of 2 hours is solved.
Please can you open an issue if confirm . Thus we  can share the logs !

Have you installed a temporary patch ? It has been removed if you have installed the latest HA version. If it is the case you have to replace it.
If you install keyatome, don't forget to declare integration in configuration.yaml or via UI.
Thanks in advance for your feedback

Hey @jugla ,
thanks for you reply. So, I don't understand but after the last update (version core-2021.12.7) this evening the issue disappeared!
All is okay now, I put in my config folder your last release 3.0.0.
Thank you for your job! 🚀🚀🚀

close with 3.1.0

Thank you very much @Vestarija for your feed back


.NET Ticks (timestamp) converter

What's the Problem?
Feature request: .NET Ticks (timestamp) converter, like https://tickstodatetime.azurewebsites.net/
Solution/Idea
as stated above
Alternatives
Use website, or C# interactive
Priorities

Capability
Priority

This proposal will allow developers to accomplish W
Must

This proposal will allow end users to accomplish X
Should

This proposal will allow developers to accomplish Y
Could

This proposal will allow end users to accomplish Z
Won't

DevToys Version
No response
Comments
No response

Hi @epeshk ,
Thanks for your feedback.
There's already a timestamp converter in DevToys. Does it not do what you are expecting?

Hi @veler ,
Current timestamp converter is UNIX timestamp like "1655263430", but what @epeshk expected is .NET timestamp  like "637908602300000000" which is also what I expected, please consider supporting it.
Thanks,

Oh I see! Thanks for explaining this 😁

Difficult to place UI for settings.

The UI is different from other tools, but I think this UI is easy to understand.

Difficult to place UI for settings.   The UI is different from other tools, but I think this UI is easy to understand.

Hello, when can I use this new function? I still haven't found any options to switch in the latest version. I think this function is more important to me

The input part of Timestamp uses WinUI(muxc:NumberBox).
NumberBox uses Double.
It is unlikely to be changed from Double because it needs to work the same way in various environments.
Converting the NumberBox to ms as it is will result in incorrect calculation results.
For this reason, other methods must be provided.
For example, this is the way to do it.
Prepare a dedicated input field (window will be longer)
Create a dedicated component that "looks exactly the same" as the NumberBox.

I'd be interested in working on this. Would you like the input to be in UTC ticks, or calculated relative to the selected time zone?

Hi,
@btiteux is currently working on it for DevToys 2.0

Hello, I'm currently migrating the timestamp converter.
I plan to support milliseconds and will see about adding the ticks support.


Question: Standalone Publishing

Hi,
I have a general type question on using coworkers.
I'm still a newb with this library, only spent and hour or so tinkering with it.
Is my assumption correct that coworkers is for consuming only?
I can see that while consuming, there is middleware for publishing, or send to queue - but that's part of the consuming process.
What about straight up publishing in it own process?
For example, from this gist, https://gist.github.com/rudijs/185fc162bdd667a91405, it will publish a message to RabbitMQ every 1 second.
Can I use coworkers to do the same thing? Or is coworkers more for just the consumer/processing side?
The gist example will create a new connection for each message (no channel).
Thanks

Coworkers was designed to be a rabbitmq consumer service framework. Currently, it only provides sugar to publishing w/in a consumer.
But the coworkers app easily enables the use of it's underlying amqplib models. If you want to publish outside of consumer, just use app.publisherChannel directly (amqplib channel) after your coworkers app is connected.

There are also, plenty of other amqplib client libraries that provide more sugar with publishing: https://www.npmjs.com/search?q=rabbitmq
From my knowledge there are not many libraries to easily create rabbitmq consumer services.
Btw, feel free to keep the questions coming. I don't mind at all. Your feedback will be valuable as coworkers evolves.
Thanks

Coworkers was designed to be a rabbitmq consumer service framework

OK cool - thanks.
A consumer framework was the impression I had but just wanted to clarify I was on the correct path.
For sure I'll have more questions :-)
I'm a fan of RabbitMQ and intend to explore co-workers more.
I use Koa in my web apps as well.
I have also written and RPC pub/sub on top of amqplib: https://www.npmjs.com/package/amqp-rpc-factory
Thought is RPC only - can be used within Koa (publish) and also standalone.
I need a publish only (non RPC) - coworkers could fit in nicely.
Cheers.

Cool. I've thought about breaking out https://github.com/tjmehta/coworkers#context-methods, request and reply specifically, into a another library. context.publish and context.sendToQueue are just very thin wrappers above amqplib. Maybe I will break them out in the future. Closing this thread for now

Hey @rudijs,
I ended up needing this as well, so I broke out the rpc functionality from coworkers.
It's is not as robust as your module, it just exposes simple rpc helper utilities for amqplib.
https://github.com/tjmehta/amqplib-rpc

Nice one Tejesh.

I ended up needing this as well

I know what you mean, once you start you need them all - rpc, direct,
fanout.
 For example KoaJS server?
I find RabbitMQ creeping into all aspects of my web development - client,
server, scripts, cronjobs, web sockets. End up needing all AMQP has to
offer.
On Thu, Feb 11, 2016 at 6:22 AM, Tejesh Mehta<EMAIL_ADDRESS>wrote:

Hey @rudijs https://github.com/rudijs,
I ended up needing this as well, so I broke out the rpc functionality from
coworkers.
It's is not as robust as your module, it just exposes simple rpc helper
utilities for amqplib.
https://github.com/tjmehta/amqplib-rpc
—
Reply to this email directly or view it on GitHub
https://github.com/tjmehta/coworkers/issues/13#issuecomment-182605284.


Bug in push v2 environment when self.random_init = False

Hey,
I am using push v2 environment from ALL_V2_ENVIRONMENTS_GOAL_OBSERVABLE (single goal env). When random_init is set to False, the following error pops up:
File "debug_metaworld.py", line 50, in step
    obs, reward, done, _ = self._env.step(action)
  File "/mnt/beegfs/home/benedict/code/metaworld/metaworld/envs/mujoco/mujoco_env.py", line 25, in inner
    return func(*args, **kwargs)
  File "/mnt/beegfs/home/benedict/code/metaworld/metaworld/envs/mujoco/sawyer_xyz/sawyer_xyz_env.py", line 439, in step
    reward, info = self.evaluate_state(self._last_stable_obs, action)
  File "/mnt/beegfs/home/benedict/code/metaworld/metaworld/envs/mujoco/mujoco_env.py", line 25, in inner
    return func(*args, **kwargs)
  File "/mnt/beegfs/home/benedict/code/metaworld/metaworld/envs/mujoco/sawyer_xyz/v2/sawyer_push_v2.py", line 78, in evaluate_state
    ) = self.compute_reward(action, obs)
  File "/mnt/beegfs/home/benedict/code/metaworld/metaworld/envs/mujoco/sawyer_xyz/v2/sawyer_push_v2.py", line 153, in compute_reward
    object_grasped = self._gripper_caging_reward(
  File "/mnt/beegfs/home/benedict/code/metaworld/metaworld/envs/mujoco/sawyer_xyz/sawyer_xyz_env.py", line 564, in _gripper_caging_reward
    caging_xz_margin = np.linalg.norm(self.obj_init_pos[xz] - self.init_tcp[xz])
TypeError: list indices must be integers or slices, not list

This is because, when random_init is False, self.obj_init_pos is a list here in the below line. https://github.com/rlworkgroup/metaworld/blob/29fe5d6d95cf9ad86f63eac38db8c0aef3837994/metaworld/envs/mujoco/sawyer_xyz/v2/sawyer_push_v2.py#L122 This gets converted to a numpy array only when random_init is set to True. In the gripper_caging_reward method, therefore numpy-like slicing on a list fails. This doesn't happen in other environments (say pick-place, reach or hammer) because gripper_caging_reward method is not invoked there.
Have opened a PR here: https://github.com/rlworkgroup/metaworld/pull/368

looks like @krzentner closed this via #368


Automated Package Upgrade

:tada: This PR is included in version 9.4.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Linking to FedoraCI

For new we can start with rpminspect. A few changes that need to be made:

Use container instead of install (e.g. quay.io/fedoraci/rpminspect)
Get the tag from an environment variable
Figure out how to connect with FedoraCI
Control which variant runs by context.initiator. Not yet implemented apparently though

rpminspect

Use koji builds

Regarding the initiator it should be possible to tell apart Packit from the others, I’m not sure if you need more than that. Tbf I’m actually not sure why you even need it 👀

This came up w.r.t. CentOS dropping the Jenkins CI so the rpminspect and other CI there would start to diverge from Fedora CI, the idea is to unify FedoraCI (use default koji), CentosCI (use centos koji url) and packit/upstream (use copr builds).

Cannot use context.initiator within the test: https://github.com/teemtee/tmt/issues/2613


How @haul-bundler/babel-preset-react-native and metro-react-native-babel-preset are different?

Ask your Question
I try to update @haul-bundler version to v10 (preset-0.60, cli v10) my application because I want to try Hermes. Then we change  metro-react-native-babel-preset  to<EMAIL_ADDRESS>learned by new ReadMe in my haul.config.js and babel.config.js. After that, our build failed because it seems that react-native-vector-icons doesn't read fonts automatically though metro preset does , so I must add Fonts provided by application config to Info.plist  in iOS when we use @haul-bundler/babel-preset-react-native instead of metro-react-native-babel-preset.
In my curiosity, I want to know whether I can continue to use metro-react-native-babel-preset and what makes the difference between two presets? I try it and it seems to work fine at v10 too, though documents say @haul-bundler/babel-preset-react-native is required.  if it can't, We'll wait to update because we don't have much time to inspect the influences of change presets to our project. If it can, we'll use stay to use metro-react-native-babel-preset though haul version v9 to v10 for smooth hermes migration.
I'm very excited and amazed to wonderful react-native and haul feature and  advancing so rapidly. I'm looking forward to the day of I introduce these feature to my projects.

@tkow Yes you can use metro-react-native-babel-preset - it should work the same (though this may vary from project to project). If it works for you, go ahead and use it.
The main difference between metro-react-native-babel-preset and @haul-bundler/babel-preset-react-native is that we don't include all transforms that metro does, since some syntaxes are supported by the newer JSC, which was introduced in RN 0.59. This results in slightly smaller bundle (10-20KB smaller for initial project bundle) and the gap might be widen for larger project.
As for your issue with react-native-vector-icons feel free to open a separate issue, but to me it looks like an issue with webpack rather than with babel preset.

@zamotany
Thanks a lot to inform that. If I find why new preset doesn't work in my poject I''ll create new issue.


[BUG] JSON not supported?

Based on the README, I see that JSON is a supported extension, however, when I passed a sample JSON to it, I get the following error:
markitdown._markitdown.UnsupportedFormatException: Could not convert '/tmp/SAMPLE-FILE.json' to Markdown.
The formats ['.json', '.json'] are not supported.

Please look into this, thanks!

markitdown._markitdown.UnsupportedFormatException: Could not convert 'qa-1213.csv' to Markdown. The formats ['.csv'] are not supported.
I tried csv, json, and both had the same problem.

After taking a look, I believe there was an assumption that PlainTextConverter class would’ve handled the file extensions mentioned under “Various other text-based formats” in the README.
However, the PlainTextConverter class only handles files that mimetypes identifies as text/*, but JSON text for example has a MIME type of application/json.
Adding converters for these extensions separately would be the best way to go about fixing this.

Would a converter that strips JSON text of its nested syntax delimiters be ok for the purpose of "indexing, text analysis" while keeping some indentation (thus loosing e.g. the distinction between key/values and arrays) or should reformatting it into e.g. tables  be more useful for this project ?

I could be wrong, but in my case, the problem with text formats was solved when I installed the "mime-support" package additionally in the docker container


Enhanced example for table fields

Hi,
the section

If a table is to be removed, then

actually also applies to table fields. I'd find it helpful to mention them as well.
Additionally, when reviewing Microsoft code, the documentation seems to be missing updating the ObsoleteTag when ObsoleteState is updated to Removed.
Example taken from table "Bank Account Posting Group":
        field(2; "G/L Bank Account No."; Code[20])
        {
            Caption = 'G/L Bank Account No.';
            ObsoleteReason = 'Moved to G/L Account No.';
#if SLICE3771430
            ObsoleteState = Removed;
            ObsoleteTag = '18.0';
#else
            ObsoleteState = Pending;
            ObsoleteTag = '15.0';
#endif
        }

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 32f4af45-793f-d017-4e13-c0500d0c3e1c
Version Independent ID: 8c75a083-0380-a12a-f971-2e2988ba986c
Content: Best Practices for Deprecation of Code in the Base App - Business Central
Content Source: dev-itpro/developer/devenv-deprecation-guidelines.md
Service: dynamics365-business-central
GitHub Login: @SusanneWindfeldPedersen
Microsoft Alias: grobyns

Thanks for the feedback, we'll enhance this and it will be available with the next push to live.

Closing this, thanks.


[HACKTOBERFEST 2024] - Basic HTML Quiz

[!IMPORTANT]
This issue is part of our 2024 Hacktoberfest initiative. If you are interested in working on this issue, refer to our top-level tasks to see if this issue is claimed, or to claim it if it is not.

This issue is to create the Basic HTML quiz.
The file you should be working on is found in /curriculum/challenges/english/25-front-end-development/quiz-basic-html.
All quiz questions need to relate to one of these topics:

Topic list coming soon

[!CAUTION]
Questions which do not fall under these topics will be rejected.

You are welcome to include code blocks in your questions, but please keep them short (four lines or less).
Please do NOT open a pull request until you have completed all questions. Your quiz should have exactly 20 questions.

Thank you for your interest in contributing. This issue will be opened for contribution when Hacktoberfest starts on October 1st.

[!CAUTION]
Pull requests which are created before October 1st will not be eligible for Hacktoberfest. We appreciate enthusiasm, but encourage you to hold off on contributing to this issue until the event has begun.

If you wish to be notified when this issue is opened for contribution, subscribe to notifications:

Note: There is a quiz for this already on main 👍

This issue is now open
If you would like to work on this issue, please leave a comment so we can assign it to you.
Be sure to read our contributing guidelines.

Hi, I would like to work on this issue, if it is still available.

@knospe- this issue is closed, that means it is not available

This issue has been assigned a contributor. To prevent extraneous notifications, the issue is now locked. If you have any questions, please reach out to me in our Discord community.


Improved Docs

@caman411 Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

This change is not necessary.


Bluetooth: ascs: Handle ASE control point operations in separate thread

This adds handling of ASE control point operations in separate thread
so that the notifications of ASE state changes are sent from non-BTRX
thread. This ensures bt_gatt_notify_cb to be blocking waiting for
available buffers to send the notifications.

@MariuszSkamra Before I dive too deep into the implementation of this, what is the advantage of using a new thread for this compared to the system workqueue thread?

This adds handling of ASE control point operations in separate thread so that the notifications of ASE state changes are sent from non-BTRX thread. This ensures bt_gatt_notify_cb to be blocking waiting for available buffers to send the notifications.

Being slightly cautious adding to the memory budget, I am wondering if this can be done without a separate thread.  Also, do we have some real life tests/observations where this causes a clear issue (sans thread)?

@MariuszSkamra please rebase


Added npn bipolar transistor,pnp biplolar transistor, Phototranssistor

Issue #39 , #40 & #41

thanks for the contribution!


Adds plugin management for Spine animations

Ok, this one should supersede #134 by placing all Spine-specific code in a plugin that needs to be activated.
The idea is that every plugin activated in Godot is loaded by the main singleton into a list.
An Escoria plugin defines the escoria_plugin_type() function that returns a value defined in esc_types. This is mandatory for Escoria to be able to recognize the plugin (if it doesn't, then it is a "classic" plugin). I currently added one plugin type: Animation (the only one we need for now)
Each plugin has a managed_types() function that returns a list of node types that the plugin is able to deal with (enabling one plugin to deal with multiple types in different manners).
For each animation node, interactive.gd builds a list of sprites. Escoria will first try to find the sprites in AnimationPlayer and AnimatedSprite nodes. Then, it will call each animation plugin's function dedicated for the construction of the sprites list (_find_sprites()).
Then, at needed points in the animation management (in player.gd and item.gd), we call specific plugins functions:

_connect_animation_finished_node(animation_node, manager_node, call_func_name): connects the given animation_node's animation_finished event to the manager_node's call_func_name.
_animation_play(animation_node, last_dir, args): plays the animation defined in animation_node according to given parameters
_plugin_animation_finished_task_is_blocking(task, animation): returns true whether the given task name needs to block the animation. When this is useless, this function should return false.

I've been thinking about this PR while swimming and I've come to the conclusion that the animation plugin design is bad as it currently is:
Currently, the animation management is shared between Escoria scripts global/item.gd and global/player.gd and the plugin script since these 2 scripts call certain plugin functions when required.
This is not good.
The animation of a custom node (Spine and others) should be totally deferred to the plugin.
Thus, an animation plugin shoud only define 2 functions:

_find_sprites() : initialize the animation system with sprites to load.
_animation_play() : plays the animation. This function is called instead of item.gd/player.gd's one if the node is managed by the plugin.

And both functions should define entirely their own way to manage the animation, even if some parts are common with the way Escoria currently does for AnimationPlayer and AnimatedSprite.
I'll try to rework this soon.


Incorrect formatting, missing text and highlighting errors in documentation

Describe the bug
Formatting and highlighting is wrong. It looks really bad on all Deno documents, and has the same bugs on each section of the documents.
To Reproduce
Steps to reproduce the behavior with the minimal config:

... use the Deno language server
... start typing Deno,con to see the docs for Deno.connect

This is how it looks:

This is how it should ideally look from VS Code:

Note:

large empty gap at top
"default is" wrongly colored
"<IP_ADDRESS>" wrongly colored
new line after 'named' that should not be there
entire code block showing ``` when it should instead apply code block coloring
code block ends early and has @@@ inserted wrongly
entire last line starting requires is missing

I am using  treesitter for my syntax highlighting and have the latest Neovim nightly and nvim-compe. It has always done this, it is not a regression.
EDIT: Is https://github.com/hrsh7th/nvim-compe/issues/260#issuecomment-808687046 related to the Markdown problem?

Check the linked PR above to see how you can get better formatting of the documentation window.
I changed both the hover and signature_help rendering to use the fancy_floating_markdown instead of the simple renderer.
Would be great to have these changes applied within compe as well.

@David-Else Please try let g:markdown_fenced_languages = ['ts=typescript']

@hrsh7th it would still be wrong in that case.
I made some PR's upstream that were merged in the meantime that fixes that for the lsp popups.
I'm currently working on a new PR that consolidates all the floating window methods and will make it easier for other plugins like compe to use the special markdown formatting.
Once that one is merged, I'm willing to create a PR for compe

It looks a bit better now, but is still messed up:

@folke A PR to use the new Markdown preview mode would be awesome!

@David-Else PR is ready :)


Another "undefined method fixture_path" error

#1372 fixes one "undefined method fixture_path" error, but created another.
The issues starts here: https://github.com/rspec/rspec-rails/blob/master/lib/rspec/rails/configuration.rb#L50.  Note that this line is 18 lines before we're expecting to load RSpec::Rails::FixtureSupport.
Loading RSpec::Rails::FeatureExampleGroup loads RSpec::Rails::RailsExampleGroup here: https://github.com/rspec/rspec-rails/blob/master/lib/rspec/rails/example/feature_example_group.rb#L6
RSpec::Rails::RailsExampleGroup loads RSpec::Rails::FixtureSupport here: https://github.com/rspec/rspec-rails/blob/master/lib/rspec/rails/example/rails_example_group.rb#L14
And RSpec::Rails::FixtureSupport references RSpec.configuration.fixture_path, here: https://github.com/rspec/rspec-rails/blob/master/lib/rspec/rails/fixture_support.rb#L20, which doesn't exist until here: https://github.com/rspec/rspec-rails/blob/master/lib/rspec/rails/configuration.rb#L67

Thanks for noticing that. Any idea why the spec didn't run into that?


[W6.1d][W15-B1] Hoon Chee Yu

@hooncheeyu
Some comments added. Please ack & close the PR after reading comments.


Broken

Does not seem to work correctly.  I am not in a channel, yet it says I am a member of that channel.  This is broken.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ec48e6b6-c93b-a0f1-0144-978ea434b3f0
Version Independent ID: 28ecb86c-661d-c0ee-6b2c-956c97d02352
Content: Get-TeamChannelUser (teams)
Content Source: teams/teams-ps/teams/Get-TeamChannelUser.md
Service: teams-powershell
GitHub Login: @kenwith
Microsoft Alias: kenwith

@officedocsbot assign @yogkumgit

Hello @kczauz How are you? Hope you are doing good. 👍
Here, we can handle documentation issues, for example, typos or missing information.
For cmdlet-specific issues, I will need to kindly redirect you to create a support ticket directly on your tenant, there, you will receive support about that behavior.
Thank you

@get-itips Thank you very much for the contribution and sharing this explanation. @kczauz
Hope this comment is helpful for you. Considering the nature of the issue, as advised, please open a service ticket in your tenant and follow with them for the resolution. We proceed here to close it.
We will be very happy if you can share the outcome or resolution with us if you see documentation update is required. We will certainly update this documentation with that valuable information. Thanks again, for taking out some time to open the issue. Appreciate and encourage you to do the same in future also


Schematic for Physical UI

[x] after reviewing personas /UX design, draw a schematic of the button systems

ok fine


Update up-core-api/uprotocol/uri.proto to make microuri mandatory and longuri optional.

@stevenhartley, as per our discussion earlier, I think we need to update uri.proto to support mandatory micro and optional long uri formats.
Proposed change:

UEntity. name = currently is required field, should become optional
UEntity.id = currently is optional field, should become required
UEntity.version_major/minor = currently optional, Not sure, do we need to update these too, may be not ?
UResource.name = currently is required field, should become optional
UResource.instance = Not sure ?
UResource.id = currently is optional field, should become required

Note: There is a check corresponding to UResource.name in up-client-zenoh-cpp, which checks for its value to be "rpc", for rpc type messages. Are we planning on doing that still ? If yes then, may be we can't make longuri optional ans that requires UResource.name to be present, thoughts ?

Hi @ruchirchauhan ,
I agree with your proposed changes (for 5 it should be optional). Could you make the corresponding change in up-spec now that I merged up-core-api ?

Based on the changes proposed here (and implemented in #110 already), we also need to change the UUri specification as well. Actually, IMHO we should remove the whole section from the UUri spec and instead add corresponding informtation to the other documents where we actually require UUris to contain certain information, e.g. in a the context of UTransport, where a UUri needs to be resolved. I had already created https://github.com/eclipse-uprotocol/up-rust/issues/78 because the current validation is too restrictive/inappropriate for certain use cases.
@stevenhartley @PLeVasseur WDYT?

@sophokles73 agree.

I guess short-form UUri can always be transformed from micro-form UUri, right?
Want to make sure we don't need to make sure the UUri is short-form in up-client-zenoh.

Note: There is a check corresponding to UResource.name in up-client-zenoh-cpp, which checks for its value to be "rpc", for rpc type messages. Are we planning on doing that still ? If yes then, may be we can't make longuri optional ans that requires UResource.name to be present, thoughts ?

There should be a way to check RPC type messages in micro-form UUri. (id < 0x800)
https://github.com/eclipse-uprotocol/up-spec/blob/main/basics/uri.adoc#3-validators

IMHO, I think keeping a central place for UUri is easier to find (at least for me). Maybe we can put the definition how UUri is valid in the places where it applies, and then link these to a central document.
For the newcomer, they can know: oh, there are three kinds of UUri, and here are the links to how they are used/validated in uProtocol.

Closing this issue as we will address all ourstanding URI topics with #120


[GOBBLIN-1578] do not delete data while dropping a hive table because data is delete…

…d, if needed, separately
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[x] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"

https://issues.apache.org/jira/browse/GOBBLIN-1578

Description

[x] Here are some details about my PR, including screenshots (if applicable):
DeleteFileCommitStep are used separately to decide and execute data deletion
TableDeregisterStep should not be used to delete the data as it violates the configs users set for delete (or no delete) the data

Tests

[x] My PR adds the following unit tests OR does not need testing for this extremely good reason:
trivial changes

Commits

[x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Codecov Report

Merging #3431 (25b22d6) into master (62a4344) will decrease coverage by 3.26%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #3431      +/-   ##
============================================
- Coverage     46.57%   43.30%   -3.27%
+ Complexity    10316     2019    -8297
============================================
  Files          2071      402    -1669
  Lines         80805    17325   -63480
  Branches       9009     2121    -6888
============================================
- Hits          37631     7503   -30128
+ Misses        39694     8983   -30711
+ Partials       3480      839    -2641

Impacted Files
Coverage Δ

...a/org/apache/gobblin/util/limiter/NoopLimiter.java
40.00% <0.00%> (-20.00%)
:arrow_down:

.../org/apache/gobblin/cluster/GobblinTaskRunner.java
63.46% <0.00%> (-0.33%)
:arrow_down:

...lin/util/filesystem/FileSystemInstrumentation.java
92.85% <0.00%> (ø)

...lin/hive/metastore/HiveMetaStoreBasedRegister.java

.../gobblin/configuration/ConfigurationException.java

.../service/modules/orchestration/AzkabanSuccess.java

.../org/apache/gobblin/commit/FsRenameCommitStep.java

...a/org/apache/gobblin/hive/spec/SimpleHiveSpec.java

...service/modules/dataset/HiveDatasetDescriptor.java

.../extractor/filebased/FileBasedHelperException.java

... and 1662 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62a4344...25b22d6. Read the comment docs.


Nick: Watch anainfo.com

Nick requests the watch of the watch_keyword anainfo\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

anainfo\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Makyen in Charcoal HQ


feat(artifacts): Add partial file downloads, via directory prefix

Description

Fixes WB-13672

What does the PR do?
Read: https://wandb.atlassian.net/browse/WB-13672

We allow users to optionally only download files that match the prefix of an input path prefix.
If nothing is specified, the behavior is as before, we download all paths in the artifact. This prefix match only applies to OUR W&B path structure, NOT references or download file path structures.
See the below for examples:

Testing
Download prefix case:

Result:

Basecase (no arg given and we download everything):

Final comments: this method is easier to code but a little off from the 'optimal' way of doing things. Ideally within the graphQL query itself we specific a prefix and in the backend we do the filtering. however for now we will just filter after querying filenames (but importantly BEFORE we actually download the files).
There should be ample communication to clients that this argument is prefix / directory filtering for W&B FILEPATHS, not REFERENCE PATHS! they are not the same

I think the argument name is path_prefix and not dir_path_prefix

I think the argument name is path_prefix and not dir_path_prefix

You're right! Thank you - and apologies since this was misleading!


Bad testing result

i have trained RFRNet on my own dataset, i got great trainng result ,but the test result is terrible, the difference between trainset and testset is different mask , could u help me?

Have you fine-tuned the model?  The testing results might be distorted due to insufficient fine-tuning. Besides, the format of the testing mask might also be important, please ensure that the mask has only 0 and 1 in it.


Enable valid ephemeral source links for preview deploys in framework.dev

Description
Enable preview deploys to properly render internal source links (images, inbound links, etc).
Context
When testing ephemeral sites, images don't work because they point to a resource at a live, previously-deployed site. The ephemeral site's URL is a randomly generated link.
An example of this issue comes from testing social media images in the site's head. These images point to live sites that don't contain the image yet, but the preview has the correct link. Validators fail to render the image because the preview's source is wrong.
Requirements
Follow the work done in starter.dev to create a PR_PREVIEW_REGEXP for serverless to grab the preview deploy URL.
https://github.com/thisdot/starter.dev-github-showcases/pull/432
Inspecting the site should show the preview deploy ephemeral link for site assets.

This is a very low-priority item. Probably won't get done.


Add or rename symbol

I'm in a project which we define entities (or business model, from Hexagonal Architecture) as Interface.
When exported/documented, shows up in the doc.
The trick part is we want to change the name of "Interfaces" by "Entities".
Example:
/**
 * @entity - This tag is something I found how to add/create
 */
interface MyLittleEntity {
    name: string
    country: country
}

And showing up like the screenshot below I've crafted

I'm trying to reverse engineering some plugins and reading the documentation, but looks like "there is no way" to add a new Symbol, or I just didn't find yet.
Is there someone that can help me?
Thanks
Search terms

symbol
plugin
reverse engineering
Question

Can you just use @group Entities ?
/**
 * @group Entities
 */
interface MyLittleEntity {
    name: string
    country: string
}

This generates the following:

@manticorp - Thank you so much!!
Would be nice to have a screenshot on the docs with an example like this, showing what would happen if a specific tag is been used.
I'll open a PR for that :)

Awesome :) Care to close this issue?
I think it will be difficult to include screenshots because their appearance is determined by themes, and by other settings (see #2746).
I guess some screenshots of the default theme couldn't hurt, just bear in mind the navigation options can change this as well.


Training Time

Hello,
thank you for your great work.
How long did it take you to fully train this model on the ycb dataset?
How long does it roughly take you to train for one epoch?
On my setup GTX1080ti + SSD + Intel Xeon it takes for 1000 samples roughly 1 Minute. Given 100.000 training samples * 5 (to get all object in each frame) / 1000 * 60s = 8.3h for one epoch.
Best regards, Jonas

Hi, so in my case with the dataset on HDD, it's about 3h per epoch (also 1080ti but with i9). I think SSD would be faster. There is a way to increase training speed. Basically, you can pre-process the synthetic data of the YCB dataset by adding the background coco image and save them to a new folder. During training, you can directly load the processed data instead of processing them each time during training.


Add a colour-coded on-screen-keyboard in Liedle

Add an on-screen keyboard below the tiles. The keyboard should have the letters A-Z, a delete key and an enter key. Make sure each tile is hoverable.

Each key is initially light-grey
A letter corresponding to a green tile with the same letter should also be green
A letter corresponding to a yellow tile with the same letter should also be yellow
A letter corresponding to a dark-grey tile with the same letter should also be dark-grey
If two tiles with the same are coloured differently (this is possible due to the 8% chance of colouring the tile incorrectly), then colour the tile red.

This will provide an alternative input method for the user to enter the words. It will also be easier to see which letters have already been guessed and which letters have conflicting information.

approved

Approved


m5stack ILI9341 not name a type

Hi,
I am trying to use this library in a M5Stack board. I have configured the ard.h file to the proper options but the compilation failed because ILI9341 does not exist.
It seems like M5Stack headers do not provide this class anymore. I replace the definition with the global display object and it worked.
-  ILI9341 m_disp = ILI9341();
+ #define m_disp m5.Lcd

Is this a bug? Probably the upstream library update broke the symbol.

Thank you, you're right... Looks like I didn't notice the updates to M5Stack. I have made a few changes and released v0.10.3. Let me know if this works for you (as I am not able to test on M5Stack hardware at the moment, though I have tested the compilation).

Looks good to me. Thank you!


Simplify setup, add failing test, code coverage

Just thinking out loud here, and all of this is totally up for discussion.
Two of the biggest changes are:

switching to the name index.js to avoid the two mv commands.  I'm not a huge fan of that name, but I also don't mind it. In this case, it makes life a bit easier.  Thoughts?
making the test fail by default :smiling_imp:.  My thinking is that this forces someone to at least look at it, although, maybe it's too heavy handed?

Added code coverage with isparta.  I'd rather use nyc, but it's coverage reports are broken.  Maybe something like this would work, or we can wait for a fix and then switch.

I don't know anything about code coverage, so I think that if this works for now I'm all for it.

Yeah, agreed.  I say we just go with isparta and keep an eye on nyc.
Any thoughts on index.js and making the test fail by default?
cc @davidchase

The index.js seems like good convention... as it does make life easier we use that in our current project...
I think we can use what works for test coverage... i think nyc was done initially because of ava... could be wrong
what is the idea for failing the test by default? is that for consumer to be a good citizen before submitting their packages?

I think we can use what works for test coverage

:+1:

is that for consumer to be a good citizen before submitting their packages?

Yeah, although now I think it's too heavy-handed :)  Since we'll have test coverage, that's probably enough.

index.js seems okay. That's what I was going to do originally, but it seemed to be of convention to name the 'main' file the same as the package name. e.g. @most/dom-event -> dom-event.js
Regarding the tests, I think having them fail is okay, if someone really doesn't want to write tests they could delete them.

Ok, I tweaked a few things.  Let me know what you think.

Test passes by default now.  I say we just pick pass or fail and run with it.  I picked pass.
Test uses function exported from index.js
Removed reference to @most/core, since it doesn't exist (yet)

I think it all looks good

Any other thoughts, @davidchase?  Good to merge?

yeah i think its good to merge... if you guys dont mind when i have sometime i still would like to tackle the ava and co setup just to see what i can come up with and see if any of that is viable both for curiosity and potential use in the project

I have no issues with at least trying to move to ava in the future. It's always worth trying potentially better things. :+1:
Merge and transfer to the mostjs org?

i still would like to tackle the ava and co setup

Sure :+1:

Merge and transfer to the mostjs org?

:ok_hand: go for it!

Merged and transferred

:boom:


fix broken logger.log() call

first positional argument of logger.log() is supposed to be log level, not message. consequently: had too few positional arguments.
remove the log call in favour of including the message in the raised error instead.

Congrats on the first PR to QLoRA! Thank you for contributing.


macOS fixes

Couple of fixes, mostly related to using the viewer on macOS. I opted to just scale up the rendered images on retina display as this seemed the simplest thing to do, but I can also implement something more generic. Just let me know.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Looks good to me, thanks!


Specify default libvcx feature flags

Codecov Report

Merging #908 (3b55aa1) into testing/remove-mixed-breed (f38fae4) will increase coverage by 0.00%.
The diff coverage is n/a.

@@                     Coverage Diff                     @@
##           testing/remove-mixed-breed     #908   +/-   ##
===========================================================
  Coverage                       43.37%   43.37%
===========================================================
  Files                             438      438
  Lines                           34777    34777
  Branches                         7580     7580
===========================================================
+ Hits                            15083    15086    +3
+ Misses                          15231    15230    -1
+ Partials                         4463     4461    -2

Flag
Coverage Δ

unittests-aries-vcx
43.37% <ø> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.
see 3 files with indirect coverage changes


CoreFoundation: fix incorrect check

The empty string check was accidentally doing an assignment.  Correct
the typo.

@swift-ci please smoke test and merge

@swift-ci please test and merge


Issue with large/complex pedigree

Thank you for providing this!  It is working great for the simple test cases that I am working with but is returning 0 for a complicated pedigree example_dict.py.zip which should have a >0 result.

Thank you for bringing this up. I've been working on a lot recently to try and get it working on more complex pedigrees. When I looked at the maps for the pedigree you provided (mappings.txt) though, I couldn't find where the inbreeding would be. I checked it against an online calculator and it gave me the same result.

I suspect that the inbreeding is actually in one of the parents in which case the inbreeding is not inherited. I keep looking into it to see if I can work out the problem.

In the above screenshot, Son-Mik's Eddie shows up in the last and second to last columns.
Yeah, I had tested their calculator and determined it works only for simple cases but their matching is broken for anything even slightly complicated.  That seems it may be a somewhat common problem too based upon my own attempts and research.  That led me to discovering the tabular method link which seems really promising but I havnt had any luck getting it to work.  (my programming skills are pretty rusty)

According to the source I pulled the pedigree from, Woppers Magic Moment is "Inbreeding 0.6% ( 5 gen., 53 av 63 hundar finns)".  Also in looking at the screenshot again, I noticed some gaps that shouldn't be there.  Im redoing some things with the registry and how the pedigrees are being generated from it and will followup when thats done.  Hopefully I havnt been chasing ghosts all this time :P

I just pushed another update that fixes inheritance from parents. Unfortunately, I still get 0 for your example, but I do see where the inbreeding occurs. I'm going to try and implement the tabular method to see if it yields the correct result.

I tried using the tabular method and got the same results. I ran a smaller pedigree to check to see what was going on. The resulting map here is helpful in giving some insight.
Pedigree
1 0 0
2 1 0
3 1 2
4 3 0

Animal  Inbreeding
1.00000	0.00000
2.00000	0.00000
3.00000	0.25000
4.00000	0.00000

Relationship Matrix
1.00000	0.50000	0.75000	0.37500
0.50000	1.00000	0.75000	0.37500
0.75000	0.75000	1.25000	0.62500
0.37500	0.37500	0.62500	1.00000

Animal 4 is the offspring of 2 and 3. 3 is inbred but 4 does not inherit the 25% coefficient as the inbreeding formula (0.5^(n-1) * p where n is the number of generations and p is the parent coefficient) suggests. I did some more searching and found the reason for this is quite literally in the definition of an inbreeding coefficient: "Inbreeding coefficient (F) refers to the probability that the two alleles, selected at random, in an individual are identical by descent". This means that the inbreeding coefficient is only inherited if it originates from a common ancestor.

fwiw, I got done with stuff sooner than expected so here (pedigree.txt) is a considerably more complete version of that pedigree.  Unfortunately the Nabssar CoI Calculator refused to load it.  I suspect it's way too deep now because my smaller test pedigree loaded fine.

Im on your current version and that large pedigree is generating 'IC': 0.013950824737548828 so obviously something is working.
The part the kinda got me going down this path was that the website this data was sourced from was reporting 0.6% but 1) I dont know if that is accurate and 2) I need more than 5 generations anyways

I'm glad it's working for you now. I'm getting the same results as expected. The pedigree is too large to check by hand completely, but from a quick look it seems to be correct. May I ask what you're working on that you stumbled upon my inbreeding calculator? I originally made this for a genetic simulation project that I made and in the past couple of weeks came back to it for version two of that simulation. I just figured I had a very unique use case.

This all came about because of dog breeding and just want an easy way to find the best pairing.
Prior to turning to python, I had actually laid out the larger 11gen pedigree in a spreadsheet.  This dataset was just the sire's half.  I know that all of those are represented within the registry table I built but it likely goes back a few more in places.
At some point in the process, it was pointed out that calculating IC is the proper method instead of finding common ancestors and that more than 5gens is really necessary.  The website ([link(https://www.sobczyk.eu/inb/?lng=en)) I was  given isnt exactly friendly so I quickly switched to writing a program.  After a while I concluded that I wasnt having much luck with calculating IC on my own and your repo was one of the top hits on DuckDuckGo.  All of the others I tried also seem to have issues (ie this) and/or have been abandoned
At this point I now have the beginnings of a registry based in google sheets (but that could migrate to Big Query easy enough) which likely could then be used for the breed's club as a matchmaking service.  Which wasnt exactly my intent going in but it wouldnt really much difference in effort.

I originally made this for a genetic simulation project

Im curious about this.  Some of the data I have or could get would be useful for that but havnt really looked into how to go about doing it.  Unfortunately, the info I have about traits is kinda spotty so I dunno if Id be able to do much with it

I'm looking to close this issue as complete. Are there any problems you've encountered with the latest implementation?

No, it seems to be working reasonably well and runs at a decent speed too.  thanks!


ci: Update requirements

closes https://github.com/ansys/pyfluent-parametric/issues/264, https://github.com/ansys/pyfluent-parametric/issues/265, https://github.com/ansys/pyfluent-parametric/issues/266

Updated requirements.
Fixed download_file argument. (return_only_filename -> return_without_path)
Fixed CaseReader argument (case_filepath -> case_file_name)

We need the latest aliasing fixes from PyFluent to fix some unittests. I will create a dev release and update the pyfluent version.

The current 24.2 failure is due to a Fluent, I have a PR on Fluent side.

@hpohekar Feel free to merge this PR irrespective of the 24.2 failures. The 24.2 failures would be fixed with Fluent side change.


Requirement for input image size

Hello
How are you?
Thanks for contributing to this project.
Is it possible to use any input size?
If not so, what is the requirement for the input image size?

I tried 360*360 image, got RuntimeError: shape '[1, 1, 3, 360, 360]' is invalid for input of size 371712
I found that 371712 is 3523523, so I resized the image to 352*352.
It works, but I'm not very happy with the results.

but I don't understand where did this 352 or 371712 come from

Maybe It is because that it‘s 11×32


Converting ORCID to wikidata in admin for deceased results in duplicate search item

As in the subject.

Would it not rather make more sense to keep the Bionomia profile based on the ORCID ID -- when a deceased person has both an ORCID ID and a QID?
Example
https://bionomia.net/0000-0003-0398-890X --->
https://bionomia.net/Q15975568

@dagendresen If that once ORCID-base profile was not public it would remain hidden forever – only the ORCID owner can make their profile public. The switch and redirect to QID means anyone may make it publicly available.

Then maybe display the ORCID also on the "new" QID-based Bionomia profile page? (display the ORCID on all QID-based profile pages when an ORCID is available from the Wikidata entry?)

I might be able to do that, though will require some redesign – presently, much of the presentation assumes an either/or. May I ask what might be the use case?

No specific use case - only the principle of an ORCID a "higher level" PID than the QID... (more unique and more persistent)

Fair enough. I'll investigate what this might require though cannot yet say for certain how tricky this might be. Part of me is a bit concerned not for the work on a technical fix, but for how to best communicate what's going on. "ORCID for the living, Wikidata for the deceased" has become somewhat of an entrenched mantra.

Apropos -- a link to the Wikidata entry would be useful also on the ORCID-based Bionomia profile pages ---> Use case: to more easily/quickly describe current (alive) naturalist (many ORCID profiles have few details -- and lack many of the Wikidata-attributes which are useful when assigning Bionomia annotations).
In other words, it might useful to display both the ORCID ID and Wikidata QID when both/either are/is available :-)
PS: At PIDapalooza2021 the topic of an ORCID-like ID for deceased people was a popular topic...
PPS: Maybe (in a much larger scope) the museums might consider a mechanism to manage ISNI IDs for (all?) naturalists (instead of depending on Wikidata QIDs???).


wake-word#porcupine - unnecessary profile updates

https://github.com/rhasspy/rhasspy/blob/master/docs/wake-word.md#porcupine
Raspberry Pi 4
Debian Buster
JabraSpeak 410 USB
The following three lines are completely unnecessary, and only served to cause errors/frustration when I setup my RPi 4 with Rhasspy 2.5.0 this week.  I suggest marking these as completely optional settings.  Thanks!!
    "library_path": "porcupine/libpv_porcupine.so",
    "model_path": "porcupine/porcupine_params.pv",
    "keyword_path": "porcupine/porcupine.ppn",

Good point. I'll update the docs :+1:


Export controller logs as artifacts after e2e test execution

Acceptance Criteria:

[x] export controller logs to github artifacts
[ ] developer docs: where logs are exported and how to get at them

#2432 added this functionality but this issue was improperly linked so automation didn't close this issue when those changes merged.


Hilbert Transform - Instantaneous Trendline

Version: 0.3.14b0
Please add overlap: Hilbert Transform - Instantaneous Trendline

Hey there everyone!
I found this link useful for implementation:
https://c.mql5.com/forextsd/forum/59/023inst.pdf
Is this article a correct representative of Hilbert Transform - Instantaneous Trendline?

Hello @rafalsza
Thank you so much for the code you provided. I checked it, it seems work properly without error, except that it is not making output of between -1 to 1. I think it should be normalized, do you agree with me?
On the other hand, I checked tradingview but I couldn't find Hilbert Transfrom with just one input 'alpha'. Here is a photo I want to share with you from tradingview.

I've already tested only this script:
import yfinance as yf
import numpy as np
import plotly.graph_objects as go

def ehlers_instantaneous_trendline(source, alpha):
    itrend = np.zeros_like(source)
    trigger = np.zeros_like(source)

    for i in range(len(source)):
        if i < 7:
            itrend[i] = (source[i] + (2 * source[i - 1]) + source[i - 2]) / 4
        else:
            itrend[i] = (
                    ((alpha - (alpha ** 2 / 4)) * source[i])
                    + (0.5 * alpha ** 2 * source[i - 1])
                    - ((alpha - (0.75 * alpha ** 2)) * source[i - 2])
                    + (2 * (1 - alpha) * itrend[i - 1])
                    - ((1 - alpha) ** 2 * itrend[i - 2])
            )

        trigger[i] = (2 * itrend[i]) - itrend[i - 2]

    return itrend, trigger

# Define the ticker symbol and time period
ticker = "BTC-USD"
start = "2020-01-01"
end_date = "2022-01-01"
interval = "1d"

# Retrieve the stock data using yfinance
data = yf.download(ticker, start, interval=interval)

# Extract the OHLC data
ohlc_data = data.loc[:, ["Open", "High", "Low", "Close"]]

# Set the alpha value for the Ehlers Instantaneous Trendline V2 indicator
alpha = 0.07

# Calculate the Ehlers Instantaneous Trendline V2 indicator
itrend, trigger = ehlers_instantaneous_trendline(ohlc_data["Close"].values, alpha)

# Create the figure and add Candlestick and Line traces
fig = go.Figure()

fig.add_trace(
    go.Candlestick(
        x=data.index,
        open=ohlc_data["Open"],
        high=ohlc_data["High"],
        low=ohlc_data["Low"],
        close=ohlc_data["Close"],
        name="OHLC",
    )
)

fig.add_trace(go.Scatter(x=data.index, y=itrend, mode="lines", name="ITrend"))

fig.add_trace(go.Scatter(x=data.index, y=trigger, mode="lines", name="Trigger"))

# Set the layout
fig.update_layout(
    title="Ehlers Instantaneous Trendline V2 with Candlestick OHLC",
    xaxis_rangeslider_visible=False,
    xaxis_title="Date",
    yaxis_title="Price",
    legend=dict(x=0.9, y=1, bgcolor="rgba(255, 255, 255, 0.5)", bordercolor="rgba(0, 0, 0, 0.5)"),
    showlegend=True,
    yaxis=dict(type="log"),  # Set the y-axis scale to logarithmic
)

# Show the plot
fig.show()

Hello everyone
@rafalsza thank you so much for providing the whole code,
However unfortunately, I got the same results when I ran new code: The output of the function is a different from the output of TradingView's Hilbert Transform indicator over the same data. And also the inputs are different as mentioned in my previous comment.
@twopirllc can you please provide some hint for us what should we do at this point? Should we care about TradingView's output or not? And if you think we should not care about it and use the current logic, I would be happy to find a pandas way to implement this piece of code with the help of @rafalsza in order to create new PR.
Thank you all for your time and considerations.
Bests Regards,
Ali Gheshlaghi

Hi @rafalsza & @aligheshlaghi97,
Yes. Thanks for providing some sample code to get started with. 😎
Pandas TA's primary purpose is to replicate the indicators from the de facto TA-Lib. If an indicator does not exist in TA-Lib, then the goal is to port it from TradingView (TV); preferably from TV's ta standard library. If an indicator exists in both TA-Lib and TV, the default indicator mode favors TA-Lib over TV.
Furthermore if the indicator is loop based, like TA-Lib, it is preferred to have implementation in numpy/numba to boost calculation speeds.
For an example, see the development version of SMA which has both TA-Lib's call as well as a numpy/numba implementation. There is no TV version of SMA since it is identical to TA-Lib. Other currently implemented indicators in numpy/numba on the development branch include: atrts, ha, mama, pivots, reflex, ssf, ssf3, and trendflex.
For the case of ht_trendline, it is preferred to port TA-Lib's ht_trendline to numpy/numba and/or Ehler's or a TV version if possible.
In short:

If it exists in TA-Lib, port it and make it the default.
If it exists in TV also, include that implementation.
Similarily for other sources...

Hope this makes sense!

@twopirllc Thank you so much Kevin for your complete explanations.
I will start trying to implement as you described, with the help of the sources you mentioned and the code @rafalsza provided. I will sent you feedback about the progress in this issue and hopefully, make a PR asap.

@rafalsza
Finally @aligheshlaghi97 and I were able to complete this indicator. It is now on the develpoment branch.
KJ


Split out windowing and input of SDL2DesktopWindow into partial classes

This mostly moves code around, the only actual code changes are enabling NRT and c760ade059cc852a86b84b05f3c853345fdda5cb.
Hopefully this will make future changes easier, as the relevant code is now closer together.

@frenzibyte how much does this conflict with what you're doing?

Should be fine as the separated code is unrelated to what I have changed in my branch.


remove IbPy requirements from CI

Removed requiements_live_ib from Travis and Appveyor configs
to decouple core from broker-specific requirements.
Signed-off-by: Ed Bartosh<EMAIL_ADDRESS>

The reason it fails is explained here: Nose introspects all the module and tries to import it.
As broker is a module it ends up importing ib broker.
More details could be found here: https://stackoverflow.com/questions/3073259/python-nose-import-error
The reason AppVeyor passed in #12  is because init.py was removed from gens/brokers/.
I believe that's a mistake, brokers is indeed a module, it needs init.py
Removing IbPy from the CI build is just a workaround to support AppVeyor.
I'd rather drop AppVeyor support than remove IbPy installation from CI.
Because of this I'd rather not pull this change in: -1

The reason AppVeyor passed in #12 is because init.py was removed from gens/brokers/
It was not removed. It was made empty.

Anyway, I think it makes sense to fix this or at least work around it. Otherwise we'll end up changing upstream files for no need and installing modules that are not used in our tests.

Just looked at #12 again. you're right - brokers/init.py was removed. I didn't plan to do that though.  I wanted to make it empty. For some reason git decided to remove it.

There should be a way to tell nose not to try importing everything. That doesn't look right to me. I thought nose only cares about test*.py files or test*/ directories. Apparently it was wrong assumption.

I don't see any harm in having the IB module imported in CI.  In fact I don't see any problems with importing modules from random brokers that are supported, they are just imported for the CI tools.  It is not forcing users to install these modules.  Now the builds are breaking.
I'd also rather not pull in this change.

well, I mentioned potential problems - loading modules without any intent to use them and changing upstream files just for that.
I'm not asking you to merge this until I fix both tests. I'm generally against merging any PR that breaks tests.

IbPy is a real requirement, which needs to be installed if one uses IB as a broker.
Similarly, you can find 'blaze' package installed on AppVeyor which is not part of the normal installation.
I believe the only reasonable change is to fix the Appveyor IbPy installation problem, then the rest of the testcases will pass.

IbPy is a real runtime requirement, not a test requirement. blaze is a test requirement as it's used in tests/pipeline/test_blaze.py. The fact that nose tries to import everything is not a reason to install something that is not used in tests when we run tests.

Coverage decreased (-0.1%) to 86.054% when pulling 87bea6260e656677857d44f73784844e208692d6 on ed into d0be2fc458472b241ffaf1dfee15b8bcdbc105f1 on live.

Sorry, but I don't agree with this change.
CI should be able to install our software without any nose-trick.
If AppVeyor is not able to kick off the tests then it is likely that our code does not work on windows platform.

Sorry, I'm not sure I fully understand your statement. How installation of the software is related to nose? My last change stops nose from loading module that's not related to tests. It doesn't do anything with installation I think. Please elaborate.

By 'install our software' I meant dependencies.
My point is that this is an unorthodox workaround to make the build green, even though we know the IB Broker will not function under Windows due to lack of IbPy2 package. CI tools should be able to install our dependencies if we are supporting that platform.

If we ever planning to merge our code upstream (we should in my opinion) we shouldn't make tests depending on the packages that are not used in tests and are optional. I consider broker interfaces as an optional, plugin-like additions that only make sense when particular broker is used. Installing everything that all possible broker interfaces depend on doesn't make much sense and definitely will not be accepted upstream.

"Installing everything that all possible broker interfaces depend on doesn't make much sense and definitely will not be accepted upstream."
I beg to differ on 'install everything' approach, please take a look here: https://github.com/zipline-live/zipline/blob/master/.travis.yml#L55-L60
Also, I don't think we'll ever be merged upstream.
Having ib_broker implemented during test has benefits: it ensures that there are no trivial mistakes made on that file.
What do you think about adding a proper win64 based installation to conda?
It does not seem like a big effort and would resolve our problem cleanly.

I'm still not convinced. Not sure why everything is installed in zipline .travis.yml. May be they have a good reason for that. Even if they don't we should do the same. I'd understand if we install ib because we have tests that use it. Otherwise it's not good to require it without actual reason.

What do you think about adding a proper win64 based installation to conda?
It does not seem like a big effort and would resolve our problem cleanly.

Which problem?

"I'm still not convinced."
That makes the three of us. Neither Peter nor me agrees to your change.
"Which problem?"
AppVeyor builds are failing.
Let us know when you are convinced.

That makes the three of us. Neither Peter nor me agrees to your change.

Yep, I see.

AppVeyor builds are failing.

can you be a bit more specific, please? You mentioned AppVeyor "problem" and failing builds several times, but never pointed out to any evidence:
Here are the latest builds and they're green:

the top of live branch: https://ci.appveyor.com/project/pbharrin/zipline/build/1.0.44
the top of master branch: https://ci.appveyor.com/project/pbharrin/zipline/build/1.0.50

I'm sorry, I did not knew that the AppVeyor build has been fixed by adding pip install.
Previously conda was unable to install this requirement: https://ci.appveyor.com/project/pbharrin/zipline/build/1.0.31/job/us969yt5yivd5hqh
Before I read your comment I made IbPy2 available in Conda for all platforms:
https://anaconda.org/tibkiss/ibpy2


Update template version to 1.0.2-SNAPSHOT

1.0 and 1.0.1 have already been published to maven central to
test out our release pipeline.
cc @Azure/azure-sdk-eng

Can one of the admins verify this patch?


CRM457-1637: Change labels to make more consistent

Description of change
Adjust labels to standardise
Link to relevant ticket

@jogilder yes, there is no mention of the hint text in CRM457-1637 - the screenshots of the desired forms do not contain hint text. There is hint text to be added in the provider app for CRM457-1625, which I believe Imtiaz is currently working on.


Add lintFolder function to TokamakCLI

Codecov Report

Merging #82 into master will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
+ Coverage   57.95%   57.99%   +0.04%
==========================================
  Files          66       66
  Lines        1446     1445       -1
==========================================
  Hits          838      838
+ Misses        608      607       -1

Impacted Files
Coverage Δ

Sources/Tokamak/Components.swift
56.75% <0%> (+1.49%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32c3739...40cdfa9. Read the comment docs.


Make TamperMonkey script for naming files

It's great that Grabber has this feature embedded, but I would like to have it in the browser. Sankaku and rule34.xxx send hash only.
Dumb request, I know.

Also, %сharacter% %copyright% drawn by %artist% %md5%.%ext% is not valid.
"The %сharacter% token doesn't exist..." it says.

I don't really understand what you mean by that.
Grabber is a software, not a browser extension, so it can't name files on your browser. If you want to download files from some website, why not just load them from Grabber and download from there?


CL to AO part_of links

attached: 110 proposed all-some part_of links to Uberon, derived from ZFA (ZFA IDs shown for comparison). Not vetted - it's possible some of these are ZFA specific.
For latest version see http://github.com/cmungall/uberon
cell-to-uberon-via-ZFA.txt
Original comment by: cmungall

There is no longer a cell-to-uberon-via-ZFA.txt in http://github.com/cmungall/uberon (now obophenotype/uberon), or at least I can't spot it. I suspect this may be out of date.

Hi, @cmungall. Are you expecting any other work on this ticket? As noted in the comment above, this ticket may be out of date, and I plan to close it unless additional feedback is provided within the next week.
CC: @dosumis, @matentzn

100% close this.


fix: fix number mask bug with wrong position of thousand separator

PR Checklist
Please check if your PR fulfills the following requirements:

[ ] The commit message follows Conventional Commits
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[X] Bugfix
[ ] Feature
[ ] Refactoring
[ ] Code style update
[ ] Build or CI related changes
[ ] Documentation content changes

What is the current behavior?
https://github.com/TinkoffCreditSystems/taiga-ui/issues/984
What is the new behavior?
fix bug
Does this PR introduce a breaking change?

[] Yes
[X] No

Thank you!


IE11 activate and deactivate event duplication

Hi,
I found a bug after changing names of activate and deactivate events (from onActivate and onDeactivate respectively). The problem occurs in IE11 browser (and probably same issue in earlier versions and MS Edge as well). Simply declaring an event handler:
<tree-root #structureTree [nodes]="finalStructure" [options]="{ childrenField: 'items' }"
           (activate)="treeNodeActivated($event)"
           (deactivate)="treeNodeActivated($event)">
</tree-root>

causes treeNodeActivated event to fire twice - one event comes from IE "DOMActivated" event and second from tree itself. Moreover, every click on the page causes the handler to fire as some DOM node is being activated or deactivated (and event is bubbling - see https://msdn.microsoft.com/en-us/library/ms536787(v=vs.85).aspx)
For now I made a workaround for the issue:
treeNodeActivated(eventArgs: { eventName: string, node: TreeNode }): void {
  if (!eventArgs.eventName || !eventArgs.node) {
    // the event comes from crazy IE "activate" event. Let it just return...
    return;
  }
  // the actual event handling
}

In my opinion the best way to fix will be changing names of events to sth like:

nodeActivate
nodeDeactivate

Same error here.
We had the version 3.2.4 for some times. Recently, we upgraded to 4.0.0.
IE11 users were complaining and after investiguating, the described issue above appeared.
thanks @orkisz for the solution/workaround! Saved my day.

https://github.rds.lexmark.com/common-ui/ui-core/issues/1580

Same here I am using 5.0.0 . its happening in IE11 and edge

I will add nodeActivate and nodeDeactivate to the events list for IE11 in 7.2.0


ignore cursor show/hide so sync does not occur multiple times for screen reader users, causing bugs

fix #233921
I cannot reproduce, so we'll have to wait for JooYoung to test and confirm the fix
Edit: not sure this will fix it

Closing for now as needs more investigation for the proper fix


Middleware is bypassed when get("*") is used

Hello! I'm not sure if this is expected behavior or not, but I'm having an issue with a middleware not executing for a specific path:
app.use("/v1/p/*", async (c, next) => {
  console.log("Middleware called");
  return c.text("OK");
});

app.get("*", async (c) => {
  return c.text("GET called");
})

What happens?

Thank you for the issue. Our expected behaviors are below:

GET / -> GET called
GET /v1/p -> OK + console.log
GET /v1/p/test -> OK + console.log

"2" may be confusing, but the /* in /v1/p/* has a special meaning and is supposed to match /v1/p. So, in your code, "2" and "3" not work well. This is happen when using RegExpRouter which is used in your application. But, if I've tried to use TrieRouter, it works well.
Hi @usualoma !
Could you check this issue for RegExpRouter?

Thank you!
What do I lose for switching to TrieRouter instead of RegExpRouter if I'm not using regex in my routes?

@AlexDicy
RegExpRouter is one of the "routers" which is used inside Hono. It is used whether or not regexp is used in your routes (In some cases, however, StaticRouter or TrieRouter may be used. Sorry for the complication:). This is an internal thing you may not need to know about.

investigating...


Step is missing in enabling previews in Power Platform admin center

Hello,
It would be great if the step to expand Product and select Features is added in the In the Power Platform admin center procedure.

Also, in the In a Unified Interface app procedure, the UI says license terms, while the article refers to it as Supplemental Terms of Use. It causes a slight confusion because the user tends to search for supplemental terms.
Thank you.
Neeraja
Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 483c5e01-d37a-29de-a580-c5614247e95a
Version Independent ID: c492ece3-17f6-1085-e717-401b68032c11
Content: Enable Preview features to get early access - Power Platform
Content Source: power-platform/admin/what-are-preview-features-how-do-i-enable-them.md
Service: power-platform
Sub-service: admin
GitHub Login: @jimholtz
Microsoft Alias: jimholtz

Thanks for your comment, @neeranelli. This issue has been assigned to the doc author for review.

Fixed; will be live shortly.


Delete playlist items via content owner

Coverage decreased (-6.4%) to 86.549% when pulling b44f998cfcd0ddad9da98ba8bfe985792a58d114 on playlist-items-content-owner into d70171d029389ce2373de44e5a29fb86069ad4c8 on master.


GH-15200: [C++] Created benchmarks for round kernels.

The four existing kernel functions Ceil, Floor, Round, and Trunc gain benchmarks with this change.

Closes: #15200

One thought about the number of benchmarks -- there is a benchmark for every type and round mode (10 each).  Some alternatives could be to try to fold the round mode tests into the type (for less visibility) or come up with a "less frequently used" benchmark concept if having less benchmarks is ideal.

One thought about the number of benchmarks -- there is a benchmark for every type and round mode (10 each). Some alternatives could be to try to fold the round mode tests into the type (for less visibility) or come up with a "less frequently used" benchmark concept if having less benchmarks is ideal.

It does looks too many benchmarks are generated. And I guess most of them are similar.
How long will all these cases run? If the round modes don't impact performance, I agree that we can only test one of them. And probably few data types, e.g., int64/uint64/double.

Do you plan to add benchmark for decimal types? It can be in a followup PR.

Do you plan to add benchmark for decimal types? It can be in a followup PR.

Done.

All of the tests together are about 3 minutes.  I've selected 3 of the round modes to run normally and disabled the rest using a command line flag.

I've updated the arithmetic benchmarks to also have labels.  Thanks for the suggestion!

Travis CI error is not related.

Not related to this PR, but the benchmark result is not obvious to me.
Why is double faster than int64? I suppose integer rounding does nothing.
Ceil<Int64Type, RoundMode::DOWN>/size:1048576/inverse_null_proportion:0                      323253 ns       323251 ns
2161 bytes_per_second=3.02107G/s items_per_second=405.481M/s null_percent=0 size=1048.58k

Ceil<DoubleType, RoundMode::DOWN>/size:1048576/inverse_null_proportion:0                      89834 ns        89832 ns
7795 bytes_per_second=10.871G/s items_per_second=1.45908G/s null_percent=0 size=1048.58k


overlay: link resolv.conf to stub resolv.conf

This file is being created by systemd-resolv on initial boot - and DNS settings from kargs being passed there.
Instead of starting from scratch when OKD payload boots we'll start with preserved DNS settings.
Cherry-pick of #66 on release-4.6

/test e2e-vsphere

/test e2e-vsphere

/test e2e-vsphere

/test e2e-vsphere

Needs to happen in MCO

Needs to happen in MCO


Don't convert expression to expression in DCE

as it probably breaks arrowFunctions

(close #130)

Probably an upstream bug too - eg: http://astexplorer.net/#/3Fqc2CIwsu

Fix in babel - https://github.com/babel/babel/pull/3687

Does it need Babel fix first?

No. It doesn't need babel fix. This reapplies the same fix as in Babel. So this can be merged :)

👍


Sending multiple ControlMessage in a single Unix Socket packet fails

This is a continuation of #464 and #473. For some reason, the attached test still fails.
IIRC, there's a problem in the way we encode multiple Control Messages which causes the kernel to only consider the first Control Message sent. The specifics of where the bug is, I have no idea.

The failing test
#[test]
fn test_scm_rights_multiple_cmsg() {
    use std::os::unix::net::UnixDatagram;
    use std::os::unix::io::{RawFd, AsRawFd};
    use std::thread;
    use nix::sys::socket::{CmsgSpace, ControlMessage, MsgFlags, sendmsg, recvmsg};
    use nix::sys::uio::IoVec;

    let (send, receive) = UnixDatagram::pair().unwrap();
    let thread = thread::spawn(move || {
        let mut buf = [0u8; 8];
        let iovec = [IoVec::from_mut_slice(&mut buf)];
        let mut space = CmsgSpace::<([RawFd; 1], CmsgSpace<[RawFd; 1]>)>::new();
        let (data, fds) = match recvmsg(receive.as_raw_fd(), &iovec, Some(&mut space), MsgFlags::empty()) {
            Ok(msg) => {
                let mut iter = msg.cmsgs();
                let fdone;
                let fdtwo;
                if let Some(ControlMessage::ScmRights(fds)) = iter.next() {
                    fdone = fds[0];
                } else {
                    panic!();
                }
                if let Some(ControlMessage::ScmRights(fds)) = iter.next() {
                    fdtwo = fds[0];
                } else {
                    panic!();
                }
                (iovec[0].as_slice(), [fdone, fdtwo])
            },
            Err(_) => {
                panic!();
            }
        };
        assert_eq!(data, [1u8, 2u8, 3u8, 4u8, 5u8, 6u8, 7u8, 8u8]);
        assert_eq!(fds.len(), 2);
    });

    let slice = [1u8, 2u8, 3u8, 4u8, 5u8, 6u8, 7u8, 8u8];
    let iov = [IoVec::from_slice(&slice)];
    let arrone = [0];
    let arrtwo = [1]; // pass stdin and stdout
    let cmsg = [ControlMessage::ScmRights(&arrone), ControlMessage::ScmRights(&arrtwo)];
    sendmsg(send.as_raw_fd(), &iov, &cmsg, MsgFlags::empty(), None).unwrap();
    thread.join().unwrap();
}

I have found out (via experiment) that Linux will merge two control messages of type SCM_RIGHTS that contain one file descriptor each into a single one containing both file descriptors, so this test failing doesn't mean that it's not working, it's just not testing what it should be testing. You can see this in action by running the test above with strace (but I've also verified this with a C++ program):
Check out what the test actually sends over the socket:
strace -f -e 'sendmsg' target/debug/deps/test-e0330ca09d8faf9f --nocapture test_scm_rights_multiple_cmsg

The result should contain exactly one sendmsg occurrence:
[pid 29717] sendmsg(3, {msg_name=NULL, msg_namelen=0, msg_iov=[{iov_base="\1\2\3\4\5\6\7\10", iov_len=8}], msg_iovlen=1, msg_control=[{cmsg_len=20, cmsg_level=SOL_SOCKET, cmsg_type=SCM_RIGHTS, cmsg_data=[0]}, {cmsg_len=20, cmsg_level=SOL_SOCKET, cmsg_type=SCM_RIGHTS, cmsg_data=[1]}], msg_controllen=48, msg_flags=0}, 0) = 8

As you can see, it contains two separate messages, each with only one fd in them (cmsg_data=[0] and cmsg_data=[1]). Now let's check out what's actually received:
strace -f -e 'recvmsg' target/debug/deps/test-e0330ca09d8faf9f --nocapture test_scm_rights_multiple_cmsg

Again, the output should contain exactly one recvmsg:
[pid 29650] recvmsg(4, {msg_name=0x7fa0651fe340, msg_namelen=128->0, msg_iov=[{iov_base="\1\2\3\4\5\6\7\10", iov_len=8}], msg_iovlen=1, msg_control=[{cmsg_len=24, cmsg_level=SOL_SOCKET, cmsg_type=SCM_RIGHTS, cmsg_data=[5, 6]}], msg_controllen=24, msg_flags=0}, 0) = 8

This one contains just a single message, but with two fds: cmsg_data=[5, 6]
(this is on current master, but reproduces with #874 applied)
It's definitely a good idea to check that stuffing N file descriptors into the ancillary data results in N fds coming out on the other end, the test just need to be more permissive and perhaps sum the fd counts in all control messages to be safe.
Additionally, a test should be written that sends two different control messages over the socket so they can't possibly be merged by the kernel. This would properly test decoding of multiple messages.


Use aws-sdk-client-mock

https://github.com/m-radzikowski/aws-sdk-client-mock
Looks much better than our manual mocks.
h/t @elliot-nelson

Yes

Have you taken a look at LocalStack? I've used this in the past as a replacement to mocking external cloud services.

Hi @codyebberson. I would love to give this a try

@Paul-Taiwo Please go right ahead!

Howdy @mattwiller :)

Oh hey @brandonin! 👋

Hey @mattwiller, I see @brandonin has a PR for the remaining manual mocks. Should I go ahead to work on it?

Hi @codyebberson, I've completed all the tasks and updated the mocks. However, I noticed that the issue is still marked as open. Could you please review the changes and let me know if there's anything else I can do to help move this forward? Thank you!

I went ahead and closed it — thanks so much @Paul-Taiwo and @brandonin 🎉🎉


Test Accuracy

Hello,
Sorry for another silly question. While training on s4-lra-cifar (on A100) I get the following final log:
Epoch 94, global step 85499: val/accuracy was not in top 1
Epoch 96:  80% 966/1200 [01:16<00:18, 12.63it/s, loss=0.144, v_num=xyj4, val/accuracy=0.866, val/loss=0.527, test/accuracy=0.865, test/loss=0.533, train/accuracy=0.946, train/loss=0.151]
Epoch 95, global step 86399: val/accuracy reached 0.86580 (best 0.86580), saving model to "blah/checkpoints/val/accuracy.ckpt" as top 1
Epoch 97:  78% 938/1200 [01:15<00:21, 12.38it/s, loss=0.142, v_num=xyj4, val/accuracy=0.864, val/loss=0.536, test/accuracy=0.864, test/loss=0.539, train/accuracy=0.945, train/loss=0.156]
Epoch 96, global step 87299: val/accuracy was not in top 1
Epoch 98:  75% 900/1200 [01:14<00:24, 12.06it/s, loss=0.143, v_num=xyj4, val/accuracy=0.866, val/loss=0.529, test/accuracy=0.865, test/loss=0.535, train/accuracy=0.945, train/loss=0.153]
Epoch 97, global step 88199: val/accuracy was not in top 1
Epoch 99:  79% 945/1200 [01:15<00:20, 12.45it/s, loss=0.137, v_num=xyj4, val/accuracy=0.863, val/loss=0.534, test/accuracy=0.864, test/loss=0.539, train/accuracy=0.946, train/loss=0.151]
Epoch 98, global step 89099: val/accuracy was not in top 1

Epoch 99, global step 89999: val/accuracy was not in top 1
Saving latest checkpoint...

Does this mean that the test accuracy measured at the checkpoint with the best validation accuracy is 86.5?
If no, what command should I use to measure the test accuracy that you report in the paper? (I am assuming that the accuracy you report in the paper is indeed the test acc at the checkpoint with best val acc)
You report 87.26 on lra-cifar - is this normal to get this gap? I hope I'm not making a mistake in interpreting the metrics.

I would be grateful if you could help with these questions and apologize in advance if they seem too basic.
Thank you again for sharing you wonderful repo,
Ankit

Yes, the best validation accuracy was at epoch 95 with 86.5% validation and test accuracy.
A gap like this to the reported 87% is quite normal due to noise. Actually the gap here is probably due to the fact that the model changed very slightly during the SaShiMi code release. You can probably get 87% or even higher with a bit of hyperparameter tuning. I would recommend passing in model.layer.postact=glu model.layer.bidirection=true to start, which should boost performance.

Thank you very much Albert for clarifying this so promptly!
Regards,
Ankit
On Sat, Mar 12, 2022, 5:41 PM albertfgu @.***> wrote:

Yes, the best validation accuracy was at epoch 95 with 86.5% validation
and test accuracy.
A gap like this to the reported 87% is quite normal due to noise. Actually
the gap here is probably due to the fact that the model changed very
slightly during the SaShiMi code release. You can probably get 87% or even
higher with a bit of hyperparameter tuning. I would recommend passing in
model.layer.postact=glu model.layer.bidirection=true to start, which
should boost performance.
—
Reply to this email directly, view it on GitHub
https://github.com/HazyResearch/state-spaces/issues/14#issuecomment-1065977904,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AID3IGC4VNKZ22DB6OY32DTU7UMQRANCNFSM5QSLTKWQ
.
You are receiving this because you authored the thread.Message ID:
@.***>


Error installing AFProfile conda environment

Hi Patrick,
I hope you are having a nice weekend. We got errors that the AFProfile conda environment cannot be installed anymore due to version conflict of the libraries. Conda could not resolve the conflicts in the prescribed versions of the libraries and stopped. We used the latest version of conda. Please let me know your thoughts when you have time.
Thank you,
Franz

Hi Franz,
Can you try this after you activate the env:
pip install --upgrade "jax[cuda12_pip]" -f https://storage.googleapis.com/jax-releases/jax_cuda_releases.html
pip install --upgrade numpy
I think something changed in the new JAX coda_12 version.
Can you provide the error message you get otherwise?
Patrick

Hi Patrick,
I followed what you suggested. I attached a screenshot of the error message. Please let me know what you think when you have time.
Thank you,
Franz

Hi Franz,
Also do:
conda install dm-haiku

Hi Patrick,
I hope you're having a nice weekend so far. I followed your suggestion, but I got another error. I'm not sure what you would recommend. I attached a screenshot of the error. We followed the installation instructions, so hmmer should be installed.
Thank you,
Franz

Hi Franz,
It seems that the pdb_seqres database is not found. It looks like you downloaded it into a temporary directory?
Please make sure that all databases are there and then I think it should work.
Best,
Patrick

Hi Patrick,
We double-checked the pdb_seqres database and AFProfile unfortunately still can't run with the new jax on A40 or A100. I noticed on the A40 there was a FutureWarning "/opt/conda/lib/python3.8/site-packages/jax/_src/ops/scatter.py:87: FutureWarning: scatter inputs have incompatible types: cannot safely cast value from type=float32 to type=bfloat16. In future JAX releases this w ill result in an error." I'll keep thinking about what else to try.
Best,
Franz

Hi,
Please ensure these are not in a tmpdir. I think the current installation should work with cuda12 (it works for me on many different clusters/locally). Can you try to remove the conda env and reinstall it and run the test case? Then provide any error messages here and I can have a look.
Best,
Patrick

Is it possible @patrickbryant1 that you can add a simpler env.yaml file? The one you've mentioned is too stringent and is failing due to very strict dependency issues.

Hi, we will look into this. An issue is that the package requirements are constantly changing, this is why the exact versions are set.
Best,
Patrick


Images not displaying with Tailwindcss JIT

Hi,
I'm experiencing a bit of a trouble with ta-gallery (v.2.0.3) when using tailwindcss JIT (v2.1.2).
When disabling JIT, everything works properly, making me assume that I don't really have an issue with my markup.
Anyone has an idea in which direction I should look to fix this ?
Here is my markup just in case:

                        @foreach ($product->productAttachments as $attachment)

                                    media->url('embedded-product') }}" alt="{{ $attachment->caption }}" class="ta-gallery-image" loading="lazy" x-ref="height" />

                                        {{ $attachment->caption }}

                        @endforeach

                        <button
                            type="button"
                            class="flex items-center justify-center w-10 h-10 bg-opacity-75 border-2 rounded-full shadow-xl hover:text-white hover:border-white text-turquoise border-turquoise bg-gray-dark ta-gallery-button -left-5 sm:left-2 focus:ring focus:ring-primary"
                            x-on:click="previous()"
                            x-show="loaded"
                        ><x-heroicon-o-chevron-left class="w-6 h-6" /></button>
                        <button
                            type="button"
                            class="flex items-center justify-center w-10 h-10 bg-opacity-75 border-2 rounded-full shadow-xl hover:text-white hover:border-white text-turquoise border-turquoise bg-gray-dark ta-gallery-button -right-5 sm:right-2 focus:ring focus:ring-primary"
                            x-on:click="next()"
                            x-show="loaded"
                        ><x-heroicon-o-chevron-right class="w-6 h-6" /></button>

Thanks in advance

@jbajou - Thanks for your issue. I was able to reproduce it and I found the reason for this situation.
The actual JIT compiler does have some known limitations: Advanced PurgeCSS options like safelist aren't supported yet since we aren't actually using PurgeCSS. We'll add a way to safelist classes for sure though. For now, a safelist.txt file somewhere in your project with all the classes you want to safelist will work fine.
https://github.com/tailwindlabs/tailwindcss-jit#known-limitations
Solution
Add a file named "safelist.txt" e.g. in the root of your project and add the following classes into the file:
ta-gallery-element-active ta-gallery-anim-right-in ta-gallery-anim-right-out ta-gallery-anim-left-in ta-gallery-anim-left-out
Safe it and it will work...

@jbajou ... the updated documentation: https://ta-styled-plugins.com/ta-gallery/tailwind-css-plugin/


Generate CEL validation rules not to enforce required fields when ObserveOnly

Description of your changes
This PR generates CEL validation rules not to enforce all the required fields when Observe Only as proposed in the design.
This is achieved by adding the following CEL rule for non-identifier (e.g. region) top level parameters (i.e. spec.forProvider.<param>) after removing the // +kubebuilder:validation:Required marker:
// +kubebuilder:validation:XValidation:rule="self.managementPolicy == 'ObserveOnly' || has(self.forProvider.<parameter>)",message="<parameter> is a required parameter"

I have:

[x] Read and followed Crossplane's contribution process.
[x] Run make reviewable to ensure this PR is ready for review.
[ ] Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested
Tested by re-generating schema for upbound/provider-aws, check this PR to see it in action.

Rebased on latest main.


Trouble installing trunk

Hi,
I am unable to install trunk.
I am using a Windows 64bit machine, Windows 10.  I have rustc 1.60.0 (I've also tried with 1.58.0).  I have several targets and toolchains installed.
I open a Windows PowerShell and enter the command:
cargo install trunk
the PC then does lots of work and the final few lines with the failure are:
   Compiling hyper-staticfile v0.6.0
   Compiling reqwest v0.11.4
   Compiling trunk v0.14.0
error: linking with `i686-w64-mingw32-gcc` failed: exit code: 1
  |
  = note: "i686-w64-mingw32-gcc" "-fno-use-linker-plugin" "-Wl,--dynamicbase" "-Wl,--disable-auto-image-base" "-Wl,--large-address-aware" "C:\\Users\\nocker01\\.rustup\\toolchains\\stable-i686-pc-windows-gnu\\lib\\rustlib\\i686-pc-windows-gnu\\lib\\self-contained\\crt2.o" "C:\\Users\\nocker01\\.rustup\\toolchains\\stable-i686-pc-windows-gnu\\lib\\rustlib\\i686-pc-windows-gnu\\lib\\rsbegin.o" "C:\\Users\\nocker01\\AppData\\Local\\Temp\\cargo-installDei2dV\\release\\deps\\trunk-d0c56760d03632d0.trunk.14fa18e5-cgu.0.rcgu.o" "-L" "C:\\Users\\nocker01\\AppData\\Local\\Temp\\cargo-installDei2dV\\release\\deps" "-L" "C:\\Users\\nocker01\\.cargo\\registry\\src\\github.com-1285ae84e5963aae\\winapi-i686-pc-windows-gnu-0.4.0\\lib" "-L" "C:\\Users\\nocker01\\AppData\\Local\\Temp\\cargo-installDei2dV\\release\\build\\ring-50c47cd63a9a85de\\out" "-L" "C:\\Users\\nocker01\\AppData\\Local\\Temp\\cargo-installDei2dV\\release\\build\\bzip2-sys-24f2a8d5d6d56542\\out\\lib" "-L" "C:\\Users\\nocker01\\.rustup\\toolchains\\stable-i686-pc-windows-gnu\\lib\\rustlib\\i686-pc-windows-gnu\\lib" "-Wl,-Bstatic" "C:\\Users\\nocker01\\AppData\\Local\\Temp\\rustcF3XWyw\\libbzip2_sys-c499ab3cd750dd4b.rlib" "C:\\Users\\nocker01\\AppData\\Local\\Temp\\rustcF3XWyw\\libring-f32965900a2b7425.rlib" "-Wl,--start-group" "-Wl,--end-group" "C:\\Users\\nocker01\\.rustup\\toolchains\\stable-i686-pc-windows-gnu\\lib\\rustlib\\i686-pc-windows-gnu\\lib\\libcompiler_builtins-91bffa0475371c8d.rlib" "-Wl,-Bdynamic" "-liphlpapi" "-lbcrypt" "-lwinapi_ntdll" "-lwinapi_advapi32" "-lwinapi_cfgmgr32" "-lwinapi_credui" "-lwinapi_fwpuclnt" "-lwinapi_gdi32" "-lwinapi_kernel32" "-lwinapi_msimg32" "-lwinapi_mswsock" "-lwinapi_ntdll" "-lwinapi_ole32" "-lwinapi_opengl32" "-lwinapi_secur32" "-lwinapi_shell32" "-lwinapi_shlwapi" "-lwinapi_synchronization" "-lwinapi_user32" "-lwinapi_winspool" "-lwinapi_ws2_32" "-lkernel32" "-lws2_32" "-lbcrypt" "-ladvapi32" "-luserenv" "-lkernel32" "-lgcc_eh" "-l:libpthread.a" "-lmsvcrt" "-lmingwex" "-lmingw32" "-lgcc" "-lmsvcrt" "-luser32" "-lkernel32" "-Wl,--nxcompat" "-nostartfiles" "-L" "C:\\Users\\nocker01\\.rustup\\toolchains\\stable-i686-pc-windows-gnu\\lib\\rustlib\\i686-pc-windows-gnu\\lib" "-L" "C:\\Users\\nocker01\\.rustup\\toolchains\\stable-i686-pc-windows-gnu\\lib\\rustlib\\i686-pc-windows-gnu\\lib\\self-contained" "-o" "C:\\Users\\nocker01\\AppData\\Local\\Temp\\cargo-installDei2dV\\release\\deps\\trunk-d0c56760d03632d0.exe" "-Wl,--gc-sections" "-no-pie" "-Wl,-O1" "-nodefaultlibs" "C:\\Users\\nocker01\\.rustup\\toolchains\\stable-i686-pc-windows-gnu\\lib\\rustlib\\i686-pc-windows-gnu\\lib\\rsend.o"
  = note: C:\Users\nocker01\AppData\Local\Temp\rustcF3XWyw\libbzip2_sys-c499ab3cd750dd4b.rlib(bzlib.o):bzlib.c:(.text$default_bzfree+0xd): undefined reference to `__mingw_free'

  = help: some `extern` functions couldn't be found; some native libraries may need to be installed or have their path specified
  = note: use the `-l` flag to specify native libraries to link
  = note: use the `cargo:rustc-link-lib` directive to specify the native libraries to link with Cargo (see https://doc.rust-lang.org/cargo/reference/build-scripts.html#cargorustc-link-libkindname)

error: failed to compile `trunk v0.14.0`, intermediate artifacts can be found at `C:\Users\nocker01\AppData\Local\Temp\cargo-installDei2dV`

Caused by:
  could not compile `trunk` due to previous error

After Googling and trying to find the solution to why I am unable to install I've also tried to use the following install command without any luck:
cargo install --locked trunk
Can anyone please give me some suggestions of what I might try to resolve this?
TIA

Try using the msvc target instead: rustup target add x86_64-pc-windows-msvc and then set it as default with rustup set default-host x86_64-pc-windows-msvc

Thank you, this has led me to get it to install successfully.  I tried the command rustup set default-host x86_64-pc-windows-msvc but that didn't work for me.  I used rustup default stable-x86_64-pc-windows-msvc and then trunk successfully installed.
Thanks again.


Update pileup script

Resolve npm package & project name conflict in pileup update scripts. Reference
Update comments in scripts
Remove redundant gitignore file.

Coverage remained the same at 71.722% when pulling 20518381e8d90aab13c05fcaaa637468da2c13ef on Georgehe4:pileup_script into 3966c80edca6c31103a71ed2b82fee5825bcb23d on bigdatagenomics:master.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/mango-prb/373/
Test PASSed.


Uncaught ImportError in utils.py line 9

Aider version: 0.56.0
Python version: 3.11.0
Platform: Windows-10-10.0.19045-SP0
Python implementation: CPython
Virtual environment: No
OS: Windows 10 (64bit)
Git version: git version 2.45.2.windows.1
An uncaught exception occurred:
Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "__main__.py", line 7, in <module>
    sys.exit(main())
             ^^^^^^
  File "main.py", line 478, in main
    models.print_matching_models(io, args.list_models)
  File "models.py", line 820, in print_matching_models
    matches = fuzzy_match_models(search)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "models.py", line 784, in fuzzy_match_models
    for model, attrs in litellm.model_cost.items():
                        ^^^^^^^^^^^^^^^^^^
  File "llm.py", line 23, in __getattr__
    self._load_litellm()
  File "llm.py", line 30, in _load_litellm
    self._lazy_module = importlib.import_module("litellm")
                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen importlib._bootstrap>", line 1206, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1178, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1149, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 690, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 940, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "__init__.py", line 9, in <module>
    from litellm.caching import Cache
  File "caching.py", line 28, in <module>
    from litellm.types.utils import all_litellm_params
  File "utils.py", line 9, in <module>
    from openai.types.completion_usage import CompletionTokensDetails, CompletionUsage
ImportError: cannot import name 'CompletionTokensDetails' from 'openai.types.completion_usage' (C:\Users\worke\AppData\Local\Programs\Python\Python311\Lib\site-packages\openai\types\completion_usage.py)

Thank you for filing this issue.
At first glance this looks like you installed aider in an environment with many other Python modules and aider's dependencies got mixed up. Can you please try to install aider in a separate Python environment? Either with venv or pipx?
This document may be helpful -> https://aider.chat/docs/troubleshooting/imports.html

I'm going to close this issue for now, but feel free to add a comment here and I will re-open. Or feel free to file a new issue any time.