Feature request: imports_scope

This option configures in which scopes use statements will be written to.
Options
"Mixed" (Default)
What it is today, respects where users write their use statements.
"Module"
Moves all imports to the top of their module.
"FunctionExclusive"
If an imported item is only used in a single function, its use statement is written inside the function that uses it.
"FunctionAlways"
All use statements are written inside the function that uses them.

@jvcmarcenes thanks for reaching out. I want to be up front and say this isn't a request the team will work on directly. I'll leave the issue open for now in case a motivated contributor comes along and wants to try implementing this.
In the meantime could you share more about your motivation for this feature request?

Of course, sorry for not including it to start with. If the options I presented were available I would personally use "FunctionAlways".
I find that leaving imports inside functions instead of modules in general leads to a better developer experience for the following reasons:

I care more about the dependencies of a function than of a whole module. While working on large projects it's common for modules to accumulate dozens of imports, and some of those imports might only be used once or twice;
It leads to visual clutter. The information of "what functions/modules a function depends on" is often more relevant to me than "what functions/modules do functions inside a module depend on". Leaving the imports in the function means it is closer to where it gets used;
It's easier to move the function during a refactor to a different module. If all imports are at the top you have to go through and add all the necessary imports to the new module and then remove them from the old module;

However now that I think about it "FunctionAlways" probably isn't the best name, we could want to use imported types inside type declarations or function signatures, and these imports would need to be at the module level.
"ItemExclusive" and "ItemAlways" might be a better fit, and the item will either be a module or a function.
I have the habit of depending on RA's code actions for automatic imports (And I have opened an issue on RA about where auto-imports are placed too). And reformatting them closer to their usages would help me avoid manually writing the imports.
I feel "ModuleAlways" is necessary given that it seems to be the norm for import placement.
"ItemExclusive" is a compromise between "ModuleAlways" and "ItemAlways", that would declutter single-usage imports from the module level.
And "ItemAlways" would be the option for users like me (I have not done any research to know if I'm alone here).
The imports-first discussion to me feels very similar to the declarations-first discussion. It was common when writing functions to leave all variable declarations at the beginning and only later initialize/use them. However, nowadays we implicitly agree that declaring variables when we need them is better.
Of course, it's different with imports, since they don't have to deal with initialization, which might have been the biggest issue with declarations-first. But some of the ergonomic benefits of declarations-when-needed are also relevant for imports.
I'd be willing to try and solve this issue, but I have no experience with the rustfmt codebase. I might try picking it up whenever I have some better availability.

I've improved the issue body, it should be easier to understand this feature request now.

I also want to note that some of the requests aren't feasible given the limited information availabe in the AST rustfmt uses to reformat your program. For example, rustfmt doesn't do any name resolution so when it sees the type Vec<T> in a function signature it can't know for sure that you're referring to std::collections::Vec<T>. Trying to make that transformation could cause compilation errors or change the semantics of the code if the user was using a different type also named Vec.

This has been open for a while and there are technical limitations that make this challenging / unfeasible.


fix: give permissions to MWAA start stop to re-add tags to environment on resume

Issue #84
Description of changes:
Added airflow:TagResource to create and update environment role permissions
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Hi @jmflynn81 ! Thank you for your fix! We will get started on PR review soon!

@jmflynn81 Appreciate you contribution! Your fix has been merged.


Introduce new models

There will always be new diffusion models that could be introduced into the specification. The intention is for the framework of the specification to be sufficiently general and extensible to be possible to utilise directly for new models, though precedents such as filename suffix & model parameter dictionary can still be set by introducing that model into the specification.
This issue is intended to serve as a list of prospective models that could be introduced into the specification, and to link to relevant Issues / PRs as necessary. The Issue will additionally be used to stash content from models that have been removed from earlier drafts of the specification.
For each model, we ideally don't want to base the specification off of one specific software implementation; the proposal needs to be compatible with all softwares providing implementations of that model. So proposal for inclusion of any of these models will need to include a search and listing of all relevant softwares.

[] Constant Solid Angle (CSA)
Manuscript

[] Diffusion Kurtosis Imaging (DKI)
Manuscript

[] Diffusion Spectrum Imaging (DSI)
Manuscript

[] Fiber ORientation Estimated using Continuous Axially Symmetric Tensors (FORECAST)
Manuscript

[] Free water DTI
(Unsure whether this should be a "separate model", or whether it should be an integral part of the DTI model, with some instances simply failing to estimate the free water component)

[] Mean Apparent Propagator MRI
Manuscript

[] NODDI
Manuscript

[] Q-Ball Imaging (QBI)
Original manuscript
SH version

[] SHORE

[] White Matter Tract Integrity (WMTI)
Manuscript

Intrinsic model parameters

Model label
Full Name
Data representation

csa
Constant Solid Angle [Aganj2010]
Spherical harmonics image

dki
Diffusion Kurtosis Imaging [Jensen2005]
Single parameter vectors image with parameter name "all" with 21 volumes in the order: Dxx, Dxy, Dxz, Dyy, Dyz, Dzz, Wxxxx, Wyyyy, Wzzzz, Wxxxy, Wxxxz, Wxyyy, Wyyyz, Wxzzz, Wyzzz, Wxxyy, Wxxzz, Wyyzz, Wxxyz, Wxyyz, Wxyzz (D is the diffusion tensor, W is the kurtosis tensor)OR6 diffusion tensor coefficients as parameter vectors image with parameter name "tensor";15 kurtosis tensor coefficients as parameter vectors image with parameter name "kurtosis";Optional: estimated b=0 intensity as scalar image with parameter name "bzero"

dsi
Diffusion Spectrum Imaging [Wedeen2008],[Paquette2017]
Probability distribution functions

forecast
Fiber ORientation Estimated using Continuous Axially Symmetric Tensors [Zuchelli2017]
Spherical harmonics image

fwdti
Free water DTI [Hoy2015]
One parameter vectors image with parameter name "tensor", containing 6 volumes in the order: Dcxx, Dcxy, Dcxz, Dcyy, Dcyz, Dczz (Dc is the free-water-corrected diffusion tensor);One scalar image with parameter name "fwf" corresponding to the estimated free water fraction

mapmri
Mean Apparent Propagator MRI [Ozarslan2013]

noddi
Neurite Orientation Dispersion and Density Imaging [Zhang2012],[Daducci2015]
Three scalar images, with parameter names equal to {"icvf", "isovf", "od"} (ICVF is the “intracellular volume fraction” (also known as NDI); ISOVF is the "isotropic component volume fraction"; OD is the “orientation dispersion” (the variance of the Watson distribution; also known as ODI));One 3-vectors image with parameter name "direction" to provide the estimated fibre orientation

qbi
Q-Ball Imaging [Tuch2004], [Hess2006]
Single amplitudes imageORSingle spherical harmonics image

shore
Simple Harmonic Oscillator-based Re[construction and Estimation [Ozarslan2008]

wmti
White Matter Tract Integrity [Fieremans2011]
One parameter vectors image with parameter name "coeffs", with 33 volumes in the order: Dxx, Dxy, Dxz, Dyy, Dyz, Dzz, Wxxxx, Wyyyy, Wzzzz, Wxxxy, Wxxxz, Wxyyy, Wyyyz, Wxzzz, Wyzzz, Wxxyy, Wxxzz, Wyyzz, Wxxyz, Wxyyz, Wxyzz, Dhxx, Dhxy, Dhxz, Dhyy, Dhyz, Dhzz, Drxx, Drxy, Drxz, Dryy, Dryz, Drzz (D is the diffusion tensor and W is the kurtosis tensor);One scalar image with parameter name "awf", representing the estimated axonal water fraction

Input model parameters

csa :

SphericalHarmonicOrder : value
Smoothing : value
Basis : value

dsi :

GridSize : value
RStart : value
RStep : value
REnd : value
FilterWidth : value

forecast :

Sphere : value
DecAlg : value
LambdaLb : value
SphericalHarmonicsOrder : value

mapmri :

RadialOrder : value
LaplacianRegularization : bool
LaplacianWeighting : value
PositivityConstraint : bool
Tau : value
ConstrainE0 : value
PositiveConstraint : value
PosGrid : value
PosRadius : value
AnisotropicScaling : bool
EigenvalueThreshold : value
PosGrid : value
BvalThreshold : value
DTIScaleEstimation : bool
StaticDiffusivity : value

noddi:

DPar : value
DIso : value
Lambda1 : value
Lambda2 : value

shore :

RadialOrder : value
Zeta : value
LambdaN : value
LambdaL : value
Tau : value
ConstrainE0 : value
PositiveConstraint : value
PosGrid : value
PosRadius : value

Extrinsic model parameters

<parameter> value
Description
Data representation
Possible Model sources
Unit or scale

ak
Axial kurtosis
Scalar
{ dki, wmti }
Unitless

mk
Mean kurtosis
Scalar
{ dki, wmti }
Unitless

msd
Mean-Squared Displacement
Scalar
{ mapmri, shore }

pdf
Diffusion propagator
3-vectors

rk
Radial kurtosis
Scalar
{ dki, wmti }
Unitless

rtap
Return To Axis Probability
Scalar
{ mapmri }
Probability [0.0-1.0]

rtop
Return To Origin Probability
Scalar
{ shore }
Probability [0.0-1.0]

rtpp
Return To Plane Probability
Scalar
{ mapmri }
Probability [0.0-1.0]

tort
Tortuosity of extra-cellular space
Scalar
{ dki }

Demonstrative examples

A NODDI fit:
my_diffusion_pipeline/
    sub-01/
        dwi/
            sub-01_parameter-icvf_noddi.nii.gz
            sub-01_parameter-isovf_noddi.nii.gz
            sub-01_parameter-od_noddi.nii.gz
            sub-01_parameter-direction_noddi.nii.gz
            sub-01_parameter-direction_noddi.json
            sub-01_noddi.json

Dimensions of NIfTI image "sub-01_parameter-icvf_noddi.nii.gz": IxJxK (scalar)
Dimensions of NIfTI image "sub-01_parameter-isovf_noddi.nii.gz": IxJxK (scalar)
Dimensions of NIfTI image "sub-01_parameter-od_noddi.nii.gz": IxJxK (scalar)
Dimensions of NIfTI image "sub-01_parameter-direction_noddi.nii.gz": IxJxKx3 (3-vectors)
Contents of file "sub-01_noddi.json" (common to all intrinsic model parameter images):
{
    "Model": "Neurite Orientation Dispersion and Density Imaging (NODDI)",
    "ModelURL": "https://www.nitrc.org/projects/noddi_toolbox"
}

Contents of JSON file "sub-01_parameter-direction_noddi.json":
{
    "OrientationRepresentation": "3vector",
    "ReferenceAxes": "???"
}


Characters inside plain text urls should not be escaped

Input:
https://text.com/some_page

Current output:
https://text.com/some\_page

Expected:
https://text.com/some_page

Rational
All I can confirm is that the current output is broken when loaded in GitHub (it points to the url with backslash), not to the original url without it.
I can't confirm whether or not escaping is right or if this is a GitHub bug (by design?). And I can assume that GitHub will never change this, considering that amount of content it has already.

Actually this issue is the break-even point where naive iterative escaping can no longer work. That's why we implemented union-replacer and gfm-escape on top of it . Unfortunately, there is no hook allowing to choose it as an alternative to the default escaping atm, so we're using a fork with such a hook introduced.
For more details, see this discussion - it's an older proposal of such hook, but we've used the textReplacement approach instead in the end.

To add to this discussion, let me just point you guys to the solution (hack) we implemented to workaround for this problem:
https://github.com/ckeditor/ckeditor5/blob/92aa0b3c999397c8f87cd29595fe4d9ad9d4c376/packages/ckeditor5-markdown-gfm/src/html2markdown/html2markdown.js#L12-L54

To put @fredck's "hack" in in context - that's in principle the approach where the text escaping is not performed in the iterative way. Some text is matched, the corresponding escape rule is applied and escaping continues after the matched text without escaping the already escaped text again using another rules. My point is that this mechanism should just be provided by default for all the escape rules, as pointed out above. Extended web autolinks are not the only case making it necessary and Fred's hack indeed has side effects, as it changes the context for the regular expressions.
@fredck Sorry for being such a bitch :-), but I should probably explain why I said it is not possible to implement this correctly with current Turndown's hooks. While Turndown's iterative escaping approach can be worked around, the other problem is that this escaping is also Markdown context-dependent. Special chars need to be escaped even in URLs when they are part of a link text. Which cannot be easily hacked now and which is why the hook has to be extended like suggested in #339.
Consider this:

HTML: See http://example.org/_foo_/
If it converts to: [See http://example.org/_foo_/](http://example.org/_foo_/).
then it translates back as: See http://example.org/foo/.
The correct output is: [See http://example.org/\_foo\_/](http://example.org/_foo_/).

The same issue is probably achievable even by just hitting twice edit and save in your wysiwyg, when the original text contains an autolink. :-)
Indeed, it is still better to corrupt only the text and not the URL, but I hope it would be solvable soon.

@fredck Sorry for being such a bitch :-)

@martincizek, I'm with you on that. As said, we implemented a "hack" to solve a very specific problem. As such, it is far from being the right-right way of moving forward here. Thanks for taking care of this ;)


all nodes are offline using public or plantery configurations

no nodes are available to deploy even thought all using the certified hardware or without it

solved after setting up relay in the dashboard

It seems that this is not actually an issue. All new accounts come with a relay by default. If you have an old account, you will need to set up the relay from the dashboard, as you have already done. Therefore, shall we consider this issue resolved and close it?

@khaledyoussef24
https://github.com/threefoldtech/tf_operations/issues/1649


Polymorphic Relationships - Docs Confusing

Hello All,
This is somewhat related to #1159, though not a bug. I find the example for polymorphic relations (http://bookshelfjs.org/#polymorphic) to be very confusing - the example names of Photos and 'imageable' don't fit in with the overall theme of books, and there isn't enough context with this photo theme to be necessarily easy to follow. I would be happy to re-write with a metaphor that better fits the book theme present everywhere else in the docs. Let me know what you think!

Agreed, and somewhat related: #1223
Maybe you have thoughts on that?

Yeah, they're bad. Perhaps one of you guys would like to make some updates to polymorphic.md?

Sure thing, I'll see what I can come up with.

I'm looking at the API and something doesn't make sense to me. For example, this.morphOne has a second argument and doesn't matter if you have a 3rd argument as far as I understand so:
this.morphOne('whatever', 'entity'); //links to entity_type and entity_id
this.morphOne('whatever', 'entity', ['custom_type', 'custom_id']); //links to custom_type and custom_id, so why even use the second argument?
this.morphOne('whatever', 'entity', ['custom_type', 'custom_id'], 'my own type'); //and you have to use it in order to get to the 4th argument

Is there a better way to do this? For instance, "smart" arguments like:
this.morphOne('whatever', 'entity'); //checks entity_type and entity_id
this.morphOne('whatever', ['custom_type', 'custom_id']); //checks custom_type and custom_id
this.morphOne('whatever', ['custom_type', 'custom_id'], 'my own type'); //uses 'my own type' as a morphValue and uses custom_type and custom_id
this.morphOne('whatever', 'entity', 'my own type'); //uses 'my own type' as morphValue and entity_type and entity_id as lookup columns

The project leadership of Bookshelf recently changed. In an effort to advance the project we close all issues older than one year.
If you think this issue needs to be re-evaluated please post a comment on why this is still important and we will re-open it.
We also started an open discussion about the future of Bookshelf.js here https://github.com/bookshelf/bookshelf/issues/1600. Feel free to drop by and give us your opinion.
Let's make Bookshelf great again


Remove: GnuWin32.Grep version 3.5.0

## This sourceforge project is from a different publisher and is not an official GnuWin32 package

Checklist for Pull Requests

[x] Have you signed the Contributor License Agreement?
[x] Is there a linked Issue?

Manifests

[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Resolves #148120

URL: https://sourceforge.net/projects/grep-for-windows/files/grep-3.5_win32.zip/download
Status code: 200
(Automated message - build 635)

Hi @Trenly,
This manifest has the highest version number for this package. Is it available from another location? (This might be in error if the version is switching from semantic to string, or string to semantic.)
(Automated response - build 876.)

@stephengillie - Intentional removal

URL: https://sourceforge.net/projects/grep-for-windows/files/grep-3.5_win32.zip/download
Status code: 200
(Automated message - build 635)


Add error notifications

Implement error notifications on the front page that appear when a user:

Uploads a single file
Uploads a non-supported file type

Use the same method later on the editor page.

Implemented in e159bae.


Dead letters incorrect processed for messages batch

Describe the bug
Producer produces 10 messages. Consumer with set deads letters policy acks 9 messages and 1 nacks. This will lead to all 10 messages coming to dead letters topic.
To Reproduce
I'm testing scenario where producer sents messages using batch. Consumer with enabled dead letters policy acks all messages but nacks one message. Then another consumer receives messages from dead letters topic.
Steps to reproduce the behavior:

Instanciate producer with enabled batching
Instanciate consumer with enabled dead letters policy (maxRedeliverCount should be equals 0)
Instanciate consumer for receiving messages from dead letters topic
Send 10 messages
Receive all messages and ack first 9 but nack for last (10)
Receive messages from dead letters queue

Expected behavior
I expect that only nacked (10) message will be received from dead letters queue.
Screenshots
Here is a screenshot of log messages produced by steps specified above:

In [Step 3] only last (10) message should be received.
Desktop (please complete the following information):

OS: Windows
Environment: docker
Pulsar version: 2.4.1

Additional context
No additional context.

Looking from the code, currently dead letter not support batch messages very well. a batch is handled as a unit. This is more of an enhancement requirements. ping @codelipenghui to confirm.

I also noticed this after reporting essentially the same issue as #5969. I’d argue it’s a bug because the consumer APIs are defined on messages, not batches. At the very least it’s a bug because the documentation does not mention batches at all and suggests only the negatively acknowledged message will be redelivered. Even if the current behavior were correctly documented, though, it makes negative acknowledgements much less useful, as it puts an extra burden on the consumer of tracking duplicates.

Closed as stale. Please create a new issue if it's still relevant to the maintained versions.


"Not  Detected" result  on Quagga.decodeSingle

when i execute Quagga.decodeSingle() on angular 6 project  the image is never detected , did i miss something ?

Try to fill out the config more.  Maybe it helps.
{
size: 800,
},
locator: {
patchSize: 'medium',
halfSample: false,
},
numOfWorkers: 1,
decoder: {
// readers: ['ean_reader', 'code_128_reader', 'ean_8_reader', 'code_39_reader', 'code_39_vin_reader',
//   'codabar_reader', 'upc_reader', 'upc_e_reader', 'i2of5_reader'],
readers: ['code_39_reader'], // To have a better performance, let's just pass only one type of barcode
},
locate: true,
// src: '/test/fixtures/code_128/image-001.jpg' // or 'data:image/jpg;base64,' + data
src: null,
}

I have same issue, the entire Quagga module to me is useless in my opinion, if it can't even read a simple barcode such as this. I tried for hours and hours messing with configurations and etc. Not sure why it has so many people try to use it.

If there is any solution out there, be good to have. all I need is to get the number of the barcode.

What are you trying to read?  This works fine for many people.

What I found is that it can only work for a small image that is almost only the bar code.
Our use case is multipage documents with a bar code on one of the pages.
It failed completely for our documents.
I made a small image file with just a snip of our bar code and it read it successfully.
We looked at quagga a year ago and then again six months later and even now other people are complaining.
I think sometimes a generous person shares a library as open source, but that does not mean it gets support or improvements.
We have completely abandoned our use case.  We could not find any java script library doing what we want.
At least we cannot find anything for free.
{
"name": "Joe Kahl",
"phone": "727-567-5780",
"address": {
"city": "St Pete",
"state": "FL",
"location": "14.BL.64"
}
}
From: Eric Cavazos<EMAIL_ADDRESS>Sent: Wednesday, February 13, 2019 7:01 PM
To: serratus/quaggaJS<EMAIL_ADDRESS>Cc: Joe Kahl<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [serratus/quaggaJS] "Not Detected" result on Quagga.decodeSingle (#331)
If there is any solution out there, be good to have. all I need is to get the number of the barcode.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_serratus_quaggaJS_issues_331-23issuecomment-2D463426607&d=DwMCaQ&c=dqndFQAGz2cg7ln6ll1EqkpBLZllP_GH8-2iqGbTww0&r=8niwtjwUzesMc_pbIuGRHX_fspGg-G1eTIXE268uPtU&m=V-ZMHFHzUOIBzFtSO5_KWCneDDeY8wR5DyluQsou-1U&s=s7rZY09rkk40IJzuc6dLXb99M2rEM8TfFjfczHu5gPs&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AAvDWz-5F-2D3NliWC2cTllnKZveJTLPIhL3ks5vNKcvgaJpZM4XH7vN&d=DwMCaQ&c=dqndFQAGz2cg7ln6ll1EqkpBLZllP_GH8-2iqGbTww0&r=8niwtjwUzesMc_pbIuGRHX_fspGg-G1eTIXE268uPtU&m=V-ZMHFHzUOIBzFtSO5_KWCneDDeY8wR5DyluQsou-1U&s=IWGNrpPvK8UjSN8kwU2InJshAg0KIL6RayjjJdmuO48&e=.

i used this lib https://github.com/EddieLa/JOB and it worked fine for me.

hey @JoeKahl not sure if you intended to blast your phone number out into public, but you did :-)
I've always used the auto-locate to fairly decent success, but i'm also trying it now with auto locate off, and that seems to be working well for use of camera-based live scanning.
Thanks for the link to the other lib, that's cool . . sadly, doesn't seem like either of these libs are getting much in the way of updates.

I don't have muck knowledge about the types of bar codes so I added all the available readers in Quagga.
It worked.
The config looks like this
{
src: "imageName.jpg",
numOfWorkers: 0,
inputStream: {
type : "ImageStream",
size: 800
},
locate : true,
decoder: {
readers:["code_128_reader",
"ean_reader",
"ean_8_reader",
"code_39_reader",
"code_39_vin_reader",
"codabar_reader",
"upc_reader",
"upc_e_reader",
"i2of5_reader",
"2of5_reader",
"code_93_reader"
]
}

@siddharthsingh22 you might want to note the type of barcode returned from the decoder, and then limit your readers to just that, for better efficiency

i have same problem but actually you can add area to you barcode like this i think quagga can't read barcode image is it justify border Sorry for my broken English I Hope tis help you somebody

are you adding area around it programatically? care to share sample code?

are you adding area around it programatically? care to share sample code?

You can used Canvas toadd space around image and get picture from canvas Before use Quagga This my Code draw
i use Reactjs
JS
const canvas = document.getElementById("tools_sketch");
// document.getElementById("tools_sketch").src = 'data:image/jpg;base64,' + list[0].image;
const img = document.getElementById("img1");
const ctx = canvas.getContext("2d")
const image = new Image();
// // console.log(img.width + ' ' + img.height)
// // console.log(width + ' ' + height)
canvas.width = img.width + 40;
canvas.height = img.height + 40;
image.onload = function () {
ctx.imageSmoothingEnabled = true;
// ctx.drawImage(image, 0, 0, 312, 100, 20, 20, img.width, img.height);
ctx.beginPath();
ctx.rect(0, 0, img.width+40, img.height+40);
ctx.fillStyle = 'white';
ctx.fill();
ctx.drawImage(image, 20, 20, img.width, img.height);//, 10, 10, width, height);
// ctx.drawImage(image, 0, 0, widthResize, heightResize, 10, 10, width, height);
// ctx.drawImage(image, 0, 0, width, height, 10, 10, width, height);
// ctx.font = "40px Courier"
// ctx.fillText(this.props.text, 210, 75)
// ctx.imageSmoothingEnabled = false;
}
image.src = 'data:image/jpg;base64,' + list[0].image
canvas.toDataURL();
BODY
<canvas id="tools_sketch"
style={{ width: "500", height: "500", border: "1px solid #000000", position: 'relative' ,backgroundColor:"White"}}
>
Sorry, your browser doesn't support the <canvas> element.

ah, i was under the impression that you were figuring out the area from the quagga box detection, then adding around that.   It's an interesting idea that I've been wanting to try, but I just don't have time to mess with that stuff these days.


No images in my blog

I've done everything written in manual, created an app, cloned it locally, added changes(with images), pushed them but no images appeared
Console says:
"Created persistent images directory"
"Symlinking images directory"
Can you tell me please what else should I do to get images on server?

Uploaded them by sftp to data directory by myself

It seems .openshift folder will work.


x/tools/gopls: autogenerate documentation for supported configurations

gopls has a number of configurations, some of which are meant for users to set manually. The rest are used primarily to "hide" experimental features and are only meant for use by gopls developers and testers.
We should formalize the set of gopls configurations that we want to make public for users, and we should consolidate these configurations with the settings of gopls's clients, such as VSCode-Go, vim-go, govim, etc.
Current settings include:
"gopls": {
    // user-facing
    "env": {}, // the environment to use when loading packages
    "buildFlags": [], // the build flags to use when loading packages
    "usePlaceholders": true, // if the user wants placeholders when they complete an item
    "hoverKind": "FullDocumentation", // the amount of documentation to show on hover, one of NoDocumentation, Synopsis, SingleLine, FullDocumentation

    // experimental configurations
    "wantCompletionDocumentation": true, // if the user wants to see documentation in completion items
    "wantSuggestedFixes": true, // offer fixes to apply along with diagnostics
    "experimentalDisabledAnalyses": [], // list of analyses to disable in diagnostics
    "useDeepCompletions": true, // show completions for symbols in imported packages
}

We should add the settings used by clients to this issue to get a better understanding of how we can provide a more unified experience.
We should autogenerate this documentation from the comments in the internal/lsp/source/options.go.

Just checking if any of these can help with choosing the inferred package root as that would be a workaround for a subset of #32394 where project directory is a step above package root folder (one that has go.mod in it).

@ermik: That is something that will have to be implemented through VS Code Go, so I would recommend filing that issue in that repository.

We should also auto-generate documentation for the commands and code lenses available in gopls.
This command documentation could also be used to generate package.json contents for commands, making it possible to easily expose commands from gopls in VS Code without a code lens.

I guess this is not actually fixed given the above.

I'm still unclear on what extra documentation we want. I believe the result of discussion was that we don't want to automatically connect commands to the extension. @stamblerre, you said that we should document code lenses, but I don't understand where or why. Just so that users can disable them in the codelens setting?

Also, should we enable documentation of the debugging options?

I'm still unclear on what extra documentation we want. I believe the result of discussion was that we don't want to automatically connect commands to the extension. @stamblerre, you said that we should document code lenses, but I don't understand where or why. Just so that users can disable them in the codelens setting?

I had thought that https://github.com/golang/tools/blob/master/internal/lsp/source/command.go was structured in such a way that we could easily generate documentation from it. I think it would be nice to have a page describing our code lenses to make them more discoverable and so that users can understand how to enable/disable them.
Since we've agreed not to expose commands through the VS Code Go command palette, I think this issue is resolved in that there are no more blockers for VS Code Go. I will mention the above in a general issue about documentation.

Also, should we enable documentation of the debugging options?

Yeah, that sounds good.

command.go would indeed be easy to generate documentation from. I think you're saying you want it? So I'll add them to the json and write a documentation page, separate from the settings page since there are no settings that refer to commands.

That would be awesome--thanks! I mentioned it on https://github.com/golang/go/issues/41591 in case you wanted to close this issue.


ModuleNotFoundError: No module named 'dsgn',   Is there a solution?

(xstereolab) root@c792cba59ad3:/mnt/X-StereoLab-master# python3 tools/train_net_disp.py --cfg ./configs/config_disp.py --savemodel ./outputs/MODEL_NAME -btrain 4 -d 0-3 --multiprocessing-distributed
Traceback (most recent call last):
File "tools/train_net_disp.py", line 25, in
from disparity.models import *
File "/mnt/X-StereoLab-master/disparity/models/init.py", line 1, in
from .stereonet import StereoNet
File "/mnt/X-StereoLab-master/disparity/models/stereonet.py", line 11, in
from dsgn.utils.bounding_box import compute_corners, quan_to_angle, \

You can download it from other stereo network.

You can download it from other stereo network.

how to download?what is the model 'dsgn 'please

You can download it from other stereo network.

how to download?what is the model 'dsgn 'please

is there any solutions please?


Incorrect text for cookie help

The help text for the cookies consent on SiteSettings.resx, Key = plCookieMoreLink.Help says:
"In the cookie consent popup a link is shown to explain about cookies to users. If you wish to override this link (by default it points to cookiesandme.com) it will link to this url."
I just tried this domain and does not exist.
This should be corrected to point to a valid page.
Not sure if the error is just on the help text of the system actually links to that page.

What about https://en.wikipedia.org/wiki/HTTP_cookie instead? Opinions?

Looks good to me. Did you check if the keys is actually used somewhere on the code?

sounds like an option, and should be adopted by site admins anyways

Is it supposed to be https://www.cookiesandyou.com/?

@bdukes  but that's available in English language only, right?

I'd suggest not linking to a website that is not publicly recognized a good source of info.
This site belongs to a company (Osano) that I'd suggest we should not depend on. Better us wikipedia if I had to choose.

:+1: works for me

Yeah and wikipedia should have that in most languages too

still an issue. I'll try to submit a PR


chore: Update SaaS serialization

Codecov Report

Merging #1523 (a17d088) into master (65bfc62) will decrease coverage by 0.19%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1523      +/-   ##
==========================================
- Coverage   98.96%   98.76%   -0.20%
==========================================
  Files          91       91
  Lines        7051     7050       -1
  Branches     1246     1212      -34
==========================================
- Hits         6978     6963      -15
- Misses         48       56       +8
- Partials       25       31       +6

Impacted Files
Coverage Δ

src/schemathesis/service/serialization.py
100.00% <100.00%> (ø)

src/schemathesis/specs/openapi/validation.py
76.47% <0.00%> (-11.77%)
:arrow_down:

src/schemathesis/_compat.py
59.25% <0.00%> (-7.41%)
:arrow_down:

src/schemathesis/extra/pytest_plugin.py
95.62% <0.00%> (-4.38%)
:arrow_down:

src/schemathesis/cli/callbacks.py
98.62% <0.00%> (-1.38%)
:arrow_down:

src/schemathesis/cli/cassettes.py
98.87% <0.00%> (-1.13%)
:arrow_down:

src/schemathesis/service/worker.py
100.00% <0.00%> (ø)

src/schemathesis/cli/output/default.py
100.00% <0.00%> (ø)

src/schemathesis/runner/impl/threadpool.py
100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65bfc62...a17d088. Read the comment docs.


<EMAIL_ADDRESS>Add back php8.1-debug

Build<EMAIL_ADDRESS>

:beers: @BrewTestBot has triggered a merge.


There is no ability to replicate the package without building it on the current envitonment

Create a package using backpack, download it
upload the package to another environment
try to replicate the package (with or without installing it first)

Actual result: the logs console shows a small message that the package should be built before replicating it
Expected result: The user can replicate the package without building it, the same way it is done in the Package manager

ERROR: Package by this path /etc/packages/EToolbox_BackPack/content-hpe-base-blueprint-regression-components-global-header-nav-4-0-global-nav-4-0-no-jcr-content-8.zip doesn't exist in the repository.


Separate Variant enums (Type, Operator) to standalone file

As part of going through and trying to split some of the bulkier classes into more managable wholes, and trying to get a feel for overall dependency across files, the single biggest roadblock I've struggled with is how many files/functions rely on Variant::Type that otherwise have nothing to do with Variant. This has led to scenarios where the enum would regularly be substituted with int or uint32_t, with Variant::Type being implicit or specified in documentation, but rarely enforced
This PR aims to solve this by separating that enum (alongside the much less ubiquitous Variant::Operator) into a dedicated file: variant_enums.h. As a lot of files utilized this enum, this PR covers a pretty staggering amount of ground. But due to the nature of the change, I couldn't imagine any easy way to split it up, so it's being proposed as one, big chunk. The overwhelming majority of changes was just a matter of converting Variant::Type to VariantType, but some more nuanced adjustments were made:

Converting the enums to enum classes. Because they're no longer tied to a class, the enum names would've overlapped with several existing keywords & outright conflicted with AABB and RID across all files. While it'd be feasible to apply the double-colon prefix for the latter, the former would've required dramatic changes across the board. Instead making them into enum classes, comparable to the Input enums, means that we introduce simplified names in exchange for a mandatory prefix. This is most obvious with VariantOperator not needing the OP_ prefix anymore (minus OP_IN, which otherwise fails to compile even in an enum class), with VariantType only having one non-simplified name already (VARIANT_MAX → MAX).

AABB() & RID() no longer need double-colon prefixes. The prefixing was primarily (only?) needed in classes/functions nested within Variant, as the non-class enum Type would take precedence over the identically named classes. As this implicit nature is no longer possible with an enum class, the double-colon prefixing workaround has been discarded.

Array now uses VariantType instead of uint32_t where appropriate. While other files/functions exist that can be changed to use VariantType instead of int, godot's array was by far the most obvious one. It was impossible previously because Array had no real means of using an enum from a class it couldn't inherit from, but now it can safely include variant_enums.h without issue.

C#: Rename property Variant.VariantType to Variant.Type. This is perhaps the compatability-breaking change, and one I'm willing to revert if needed. However, there was a long-standing TODO in the C# Variant file to rename "Variant.Type" to "VariantType" and "VariantType" to "Type". As this PR is already doing the former, it seemed like the right time to implement the latter.

My thought process was to gradually adjujst inclusion chains with a new enum system in place, but if there's already precedent for treating enums as ints in the codebase then my initial direction might've been misguided. I would still hope for proper enum assignment support in areas where dependency overlap might be a concern, but it's entirely possible there's a much less destructive means of achieving that

Closing for now. Couldn't think of a wholly justified reason for making this change when exceptions in the implementation are already intentionally in place


Windows10/ghidraRun.bat Causes error: Could not find or load main class LaunchSupport

Running ghidraRun.bat gives me the error Error: Could not find or load main class LaunchSupport regardless of the JDK version I have installed and added to the environment path.
I'm using Ghidra version 9.2.4, but this consists with many 9.X versions. (I haven't tested all 9.X versions)

OS: [Windows 10]
Java Version: [11.0.11]
Ghidra Version: [9.2.4]
Ghidra Origin: [ghidra-sre.org]

There is also a JAVA_HOME path variable, which has the same value as shown above.
Other solutions including changing the JDK version, changing Ghidra version, and modifying the path in different ways have not worked for me. I appreciate all help.

I don't have any sure fire tips for your situation, but until someone else chimes in:

the JAVA_HOME shouldn't have a /bin at the end of it.  But that said, it won't break things as long as the java on the path is good.
there have been issues when the ghidra install directory path contained parts that had spaces in the name.  Could you confirm that the redacted username directory in your screenshot is a simple value without any spaces, etc?  I'm pretty sure this was fixed at some point but I'm not sure the version.
Could you test if running ghidraRun.bat manually from the cmd line does anything different (like in your screen shot above where you ran java --version), instead of double-clicking the bat file?

I think this issue is related: #1726; only 10.x branch contains fixes for the issue.

As noted by both @topia and @dev747368, the issue was due to the path it was under. I used an exclamation point in the name of a folder which causes the error. I appreciate it very much.

Duplicate of #1817


fix: checkbox and radiobutton fontweight

GitHub Issue: #
#11428
PR Type
What kind of change does this PR introduce?

Bugfix

Description

This pr gives the checkbox and the radiobutton text the correct fontfamilly as well as the correct foreground.
From figma:
color: var(--light-on-surface-on-surface-medium-brush, rgba(28, 27, 31, 0.60));
font-feature-settings: 'clig' off, 'liga' off;
/* UNO Semantic/Body Small */
font-family: Roboto;
font-size: 12px;
font-style: normal;
font-weight: 500;
line-height: normal;
letter-spacing: 0.4px;

Fontweight 500 => Medium
and OnSurfaceMediumBrush

PR Checklist
Please check if your PR fulfills the following requirements:

Commits must be following the Conventional Commits specification
[X] Tested UWP
[X] Tested iOS
[X] Tested Android
[X] Tested WASM
[ ] Tested MacOS
[x] Contains No breaking changes

If the pull request contains breaking changes, commit message must contain a detailed description of the action to take for the consumer of this library. As explained by the Conventional Commits specification

Other information

Before:

Figma:

After:

Internal Issue (If applicable):

The surface medium brush seems to have a higher opacity on figma?

I added some comments for @NVLudwig where in the Uno Material Figma file seems that the colors are not correct for Disabled and also I think that it should match for both RadioButton + CheckBox

Additional changes coming to fix RadioButton & CheckBox

Closed this PR and opened https://github.com/unoplatform/Uno.Themes/pull/1167 as it contains more fixes for additional controls in addition to checkbox + radiobutton to match the latest uno material figma file


Add options to decide whether a request should be handled by restc

Relevant to #12 and #24.
Description

If shouldHandle is given and is a function, it would be called for each request. If truthy value is returned, the request will be handled by restc; otherwise, restc will not handle the request.
excludes can be an array or a string or a RegExp. If excludes is given, requests that match with the value will not be handled by restc. The rules of "match with" are described as follow:

If the value is a string and req.url starts with the value, the request is matches with the value.
If the value is a RegExp and req.url matches with it, the request matches with the value.
If the value is an array and req.url matches with at least one of its items, the request matches with the value.
Otherwise, the request does not match with the value.

includes can be an array or a string or a RegExp. If includes is given, only requests that match with the value will be handled by restc. The rules of "match with" are the same as the rules above.

Example 1:
restc.koa2({
  includes: ['/api', /^\/foo/],
  excludes: '/foobar'
})

Example 2:
restc.koa2({
  shouldHandle: req => req.url === '/42'
})

then the 'excludes' option has higher priority than 'includes' option, right?

@Hujun You are right.


Glass shards damage

About the PR

Changed glass shards damage depends on their type, each tier of glass gains 1 more damage, also changed attack rate to 1, because you cant fast swing with weapon that can hurt you
Why / Balance

Why uranium glass shard does the same damage as a normal, but if you wrap it with cloth it starts inflict radiation
Technical details

Media

This PR does not require an ingame showcase

Breaking changes

Changelog

:cl:

tweak: Various types of glass shards now causes diffrent damage

Can you make it so it also deals the appropriate damage when you step on a glass shard?  Ie: trip on uranium glass deal rad damage

Did it

Meeerge!!


Failed to Provision tenant

Hello Team,

I have been this "there has ben an error provisioning your tenant" from the main branch.
What am I missing?

Hi @biglocalcode Sorry about the delayed response. I am checking this

@biglocalcode We have been working on adding new features and some major updates to this project. They are all available in the vnext branch. You will find detailed instructions in the vnext branch on how to get it setup and running. Also, as part of the new update, you wouldn't need to bring a custom domain anymore. And I just tested provisioning a new tenant, and it worked fine. So, please give it a try and let me know, if you still see this issue.
Ranjith


[Bug]: Edge Middleware Functions don't share code, resulting in large bundle sizes

Summary
At the moment, the plugin emits a huge bundle.js file into each of the edge function directories, e.g. .netlify/edge-functions/next_pages_item/bundle.js and .netlify/edge-functions/next_pages_slow/bundle.js. These files are very big (lots of Next.js source code), but are identical. The bundling process doesn't know they're the same, though, and will include each of these bundles in their own namespace, resulting in very big bundles.
We could lower the bundle size by moving the bundle.js file one level up, to .netlify/edge-functions/__next_bundle.js. As long as it doesn't occur in the edge functions declarations, it won't be bundled.
Steps to reproduce

Clone https://github.com/netlify/next-react-server-components
Run ntl build --offline
Check the bundle in .netlify/edge-functions-dist/, it will contain the same code four times (because four edge functions are generated)

A link to a reproduction repository
https://github.com/netlify/next-react-server-components
Plugin version
^4.13.1
More information about your build

[X] I am building using the CLI
[X] I am building using file-based configuration (netlify.toml)

What OS are you using?
Mac OS
Your netlify.toml file

`netlify.toml`
[build]
command = "next build"
base = "."
publish = ".next"

[build.environment]
NEXT_USE_NETLIFY_EDGE = "true"

[[plugins]]
package = "@netlify/plugin-nextjs"

[[redirects]]
from = "/_next/static/*"
to = "/static/:splat"
status = 200

[functions]
included_files = [
  "!node_modules/sharp/vendor/8.12.2/darwin-*/**/*",
  "!node_modules/sharp/build/Release/sharp-darwin-*"
]

Your public/_redirects file

`_redirects`
# Paste content of your `_redirects` file here

Your next.config.js file

`next.config.js`
module.exports = {
  experimental: {
    runtime: 'experimental-edge',
    serverComponents: true,
  },
}

Builds logs (or link to your logs)

Build logs
# Paste logs here

Function logs

Function logs
# Paste logs here

.next JSON files

generated .next JSON files
# Paste file contents here. Please check there isn't any private info in them
# You can either build locally, or download the deploy from Netlify by clicking the arrow next to the deploy time.

The bundle.js files do share a lot of code (the Next.js server code), but they're not identical. Each generates a different page. The have to inline the server code because that's how Next does it. It doesn't export anything, just adds an entry to a global object. There may be a way to get the routes to share the server code, but it's not trivial.

that's unfortunate :/ then i'll go ahead and close this. let's hope this becomes easier in the future!


Remove Alt-< and Alt-> from emacsy keymap.

Based on my research, these don't seem to be bound by default (at least according to this list).
They don't seem to be present in the CM5 emacsy keys list either: https://github.com/codemirror/CodeMirror/blob/master/src/input/keymap.js#L30
We've also gotten reports that this conflicts with inputting some characters.

https://forum.obsidian.md/t/and-key-does-not-work-for-hungarian-keyboard-layout-in-the-new-editor/29293
Seems to be using the Hungarian keyboard for inserting the < and > characters.

M-> and M-< are right there in the list you linked. But yeah, I can imagine these getting in the way in layouts that use alt to pick special characters (and it seems hard to detect that situation in JS), and mod+home/end already provides an easy way to navigate to the start and end of the document. So, at the risk of annoying people who are used to these keys, let's drop them.

M-> and M-< are right there in the list you linked.

I believe we should be looking at the OS X column rather than the Emacs column here which are the actual keybindings in Emacs.

Oh, right, didn't look closely enough. Well, that's good, then no one will miss them I guess.


QIntLayerNorm 讲 self.mode = 'int'

您好，请问我将 QIntLayerNorm 中的 self.mode 设置成了 ‘int’。但是，程序报错，请问可能是哪里出现的问题呢？麻烦了！谢谢您！

Please keep QIntLayerNorm in ln mode during the calibration step.
After the calibration, call model.model_quant() and it will set QIntLayerNorm to int mode.

Ok, sure! That works!
Sorry about another question. I read the code and the function 'def get_MN(self, x)' in QIntLayerNorm. I am a little confused. What does the M and N represent? Does the N represent the 'a' in the Equation (8)? And the function 'def get_MN(self, x)' is the Equantion (11) ?

I appreciate your help. Thanks so much!

No. They are in the Eq. (31) - (32) on the appendix of the paper.

Ok, sure. Many thanks for your help!


Failed to load the native TensorFlow runtime.

Traceback (most recent call last):
File "C:\Users\user\AppData\Local\Programs\Python\Python312\Lib\site-packages\tensorflow\python\pywrap_tensorflow.py", line 70, in
from tensorflow.python._pywrap_tensorflow_internal import *
ImportError: DLL load failed while importing _pywrap_tensorflow_internal: A dynamic link library (DLL) initialization routine failed.
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "C:\Users\user\fer-project\src\train.py", line 3, in
from model import create_cnn_model
File "C:\Users\user\fer-project\src\model.py", line 3, in
import tensorflow as tf
File "C:\Users\user\AppData\Local\Programs\Python\Python312\Lib\site-packages\tensorflow_init_.py", line 38, in
from tensorflow.python import pywrap_tensorflow as _pywrap_tensorflow  # pylint: disable=unused-import
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\user\AppData\Local\Programs\Python\Python312\Lib\site-packages\tensorflow\python\pywrap_tensorflow.py", line 85, in
raise ImportError(
ImportError: Traceback (most recent call last):
File "C:\Users\user\AppData\Local\Programs\Python\Python312\Lib\site-packages\tensorflow\python\pywrap_tensorflow.py", line 70, in
from tensorflow.python._pywrap_tensorflow_internal import *
ImportError: DLL load failed while importing _pywrap_tensorflow_internal: A dynamic link library (DLL) initialization routine failed.
Failed to load the native TensorFlow runtime.

Hi @philipakomolafe ,
Could you please provide the complete steps you followed to install the tensorflow and also please fill issue template from here which helps to debug the issue.
Thank you!


Assertion fails when attempting to read GRIB with data format 5.3/7.3

Simple Description on the Bug
An assertion fails when calling the .dispatch() function on a Grib2SubmessageDecoder that is attempting to read a GRIB2 message of the 5.3/7.3 format. It fails with the error
...
panicked at 'assertion failed: `(left == right)`
    left: `[-45, 45]`,
    right: [6942, 6942]`', .../src/decoders/complex.rs:94:5
...

Steps to Reproduce

Download data from the GFS forecast site (e.g. https://nomads.ncep.noaa.gov/pub/data/nccf/com/gfs/prod/gdas.20230111/12/atmos/gdas.t12z.pgrb2.0p25.f000, Note that this exact URL will become unavailable as the forecast data becomes historical data and will have to be modified accordingly.). I am using the global 0.25 degree forecast data.
Attempt to read and decode the values in the submessages.

// open file
let f = std::fs::File::open("test_grib_file").unwrap();
let rd = std::io::BufReader::new(f);
let gr = grib::from_reader(rd).unwrap();
// set up decoder
let (_, first_submessage) = gr.iter().next().unwrap();
let dc = Grib2SubmessageDecoder::from(first_submessage).unwrap();
let dv = dc.dispatch().unwrap(); // SHOULD PANIC HERE

Expected Behavior
Read the grid values from the file.
Actual Behavior
Assertion panic.
Additional Context
No response

@LafeWessel Thank you very much for reporting with detail descriptions and data!
I have briefly looked into the issue and have identified the problem in question. I believe it is due to the fact that this library does not yet support enough parameter value patterns. I will provide support based on the data you have provided and will update the crate in the near future.

Thanks! I'd love to help and learn more about the GRIB format, so if there's any resources you could point me to, I'd really appreciate it!


Set up perltidy

This repository should be set up with perltidy (or its moral equivalent).
I would expect this to involve the addiction of a .tidyallrc file, and a tidiness-check to the tests.

Does perltidy have any moral equivalents? 😉

Hi @jmacdotorg
Thanks for the great work you have here, I have finally deployed my blog using Plerd :D
So as a token of appreciation to your work, I will try to add the enhancement you had in mind of adding perl tidy :D I will also add perl critic along with it. Hope you like it, however I still need to fix a few tests

@vnealv,
Thank you very much for this work, and congratulations on the launch of Enigma Blog!
I hope to take a look at this pull request soon.


Call animateNextTransition only when activeKey has changed

animateNextTransition was being called everytime Switch component received new props and that’s probably not what we want. What we are doing now is comparing the previous route key with the current one to know if the switch route has changed, and if that’s the case, we call animateNextTransition

@itsjgf I tried this and it doesn't fix #1 for me. Not saying it fixes nothing by the way, just that it doesn't fix the issue I reported.

@RWOverdijk I thought we were experiencing the same issue. I'm going to remove the reference to the issue you created.

i had just made a change that only performs the transition when the index changes, but this solution is better. i'll land it shortly


QAT Openssl Engine compilation issue: ld cannot find -licp_qa_al_s

When running make install I see sh script error /bin/sh: line 103: [: ==: unary operator expected.
Not sure what is failing after that, but when I try to build QAT openssl engine after that I'm getting error:
/usr/bin/ld: cannot find -licp_qa_al_s
Gist with make output for QAT OpenSSL engine: https://gist.github.com/peak-load/30537b7ef8f22c647a62f60a30e3714c#file-gistfile1-txt-L179
I checked Troubleshooting section:

Is the Intel® QAT Driver up and running? Check by running lsmod, icp_qa_al should be in the list. Also check the Intel® QAT Driver software has been started.

According to troubleshooting section above I can say - no I don't have icp_qa_al  in the list, but I don't see why.
qat_dh895xcc           18009  0
intel_qat             212108  2 usdm_drv,qat_dh895xcc
authenc                17776  1 intel_qat
uio                    19338  1 intel_qat

Full output for QAT Driver  ./configure && make && make install is there https://gist.github.com/peak-load/73d241796612e483afe1d7cda3eb73f4#file-gistfile1-txt-L3936
My system
CentOS Linux release 7.5.1804 (Core)
# uname -r
3.10.0-862.14.4.el7.x86_64

# lsmod | grep qa
qat_dh895xcc           18009  0
intel_qat             212108  2 usdm_drv,qat_dh895xcc
authenc                17776  1 intel_qat
uio                    19338  1 intel_qat

# /etc/init.d/qat_service status
Checking status of all devices.
There is 1 QAT acceleration device(s) in the system:
 qat_dev0 - type: dh895xcc,  inst_id: 0,  node_id: 0,  bsf: 09:00.0,  #accel: 6 #engines: 12 state: up

Please advice.

Hi @peak-load,
Looking at your attached traces it appears that you are using the QAT 1.7 Upstream Driver.
It is installing successfully, I think you can safely ignore the error:
/bin/sh: line 103: [: ==: unary operator expected
This is a bug in the QAT Driver install script, but I believe does not affect the installation. Certainly I also see that error flagged on my machine but do not have any problems using the install.
The issue that you are encountering is due to the QAT Engine default configuration being to build against the QAT Legacy Driver with qat_contig_mem memory driver. You need to add some extra options to your configure to correctly configure to build against the QAT Upstream Driver.
The options you need to add are:
--enable-upstream_driver
--enable-usdm

It is the second example within the following section: Build the Intel® Quickassist Technology OpenSSL* Engine
of the README.md.
After everything is built do not forget to change the QAT Driver config files before trying to run the OpenSSL speed tests to verify the QAT Engine is functioning correctly.
Hopefully the above will help resolve your issue,
Steve.

Thank Steve, I will try when will get access to server.
I found that documentation is missing list of tested to be working kernels
compatible and as result on mainline stable kernels on Centos 7 and Ubuntu
18.10 I was not able to compile QAT_Engine.
Is anybody working on this?  I can volunteer to make some tests, but after
that - fixing incompatibility in code is not my speciality and strong side.
BTW, what’s best place to ask questions about QAT hardware and software?
Our main goal is to test it for IPSEC (site to site and endpoint VPV
clients) acceleration using available and compatible Linux implementations.
Can I get any support from Intel too?
On Mon 15. Oct 2018 at 13:11, stevelinsell<EMAIL_ADDRESS>wrote:

Hi @peak-load https://github.com/peak-load,
Looking at your attached traces it appears that you are using the QAT 1.7
Upstream Driver.
It is installing successfully, I think you can safely ignore the error:
/bin/sh: line 103: [: ==: unary operator expected
This is a bug in the QAT Driver install script, but I believe does not
affect the installation. Certainly I also see that error flagged on my
machine but do not have any problems using the install.
The issue that you are encountering is due to the QAT Engine default
configuration being to build against the QAT Legacy Driver with
qat_contig_mem memory driver. You need to add some extra options to your
configure to correctly configure to build against the QAT Upstream Driver.
The options you need to add are:
--enable-upstream_driver
--enable-usdm
It is the second example within the following section: Build the Intel®
Quickassist Technology OpenSSL* Engine
https://github.com/intel/QAT_Engine#build-the-intel-quickassist-technology-openssl-engine
of the README.md.
After everything is built do not forget to change the QAT Driver config
files before trying to run the OpenSSL speed tests to verify the QAT Engine
is functioning correctly.
Hopefully the above will help resolve your issue,
Steve.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/intel/QAT_Engine/issues/90#issuecomment-429808906,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AgnydW1iM4NPPyTPsh57jiH_9jcTdcYxks5ulG1JgaJpZM4XahR_
.

--
With regards,
Eugene Sudyr

Hi Eugene,
When you said you were having trouble compiling on mainline kernels, was it specifically the QAT Engine that was giving the errors or was it the QAT Driver builds?
The QAT Engine whilst not tested on a wide range of Linux Distributions/kernels is generally run with:
Fedora 16 (for the Legacy QAT Driver. We are gradually phasing out the Fed 16 machines).
CentOs 7.4 (majority of our testing).
Fedora 23 (some development systems).
Ubuntu 16.04 (some development systems).
We don't usually see a lot of build issues between Distributions on the QAT Engine side especially with QAT Upstream Driver that uses the USDM Memory Driver.
The biggest issue is with the QAT Driver. This is because some of the API's that the QAT Driver builds against in the kernel are changing a lot over time. New versions of the QAT Driver are fixing the incompatibilities as they come up, but very new Distributions like Ubuntu 18.10 that is still in Beta will not be supported yet. Your mileage will definitely vary between different Distributions with different kernel versions, probably CentOs 7.4 is a particular sweet spot as that is where a lot of testing has been concentrated, but that might not help if you need the latest and greatest!
With regard to QAT HW/SW support, are you talking to Intel already? Usually a Platform Application Engineer would get involved in helping you with your queries.
Kind Regards,
Steve.

Hi Steve, thanks for answering my mail I will get access to my server with
hardware on Sunday, and I will write more, but quick answers are below:
On Thu 18. Oct 2018 at 17:46, stevelinsell<EMAIL_ADDRESS>wrote:

Hi Eugene,
When you said you were having trouble compiling on mainline kernels, was
it specifically the QAT Engine that was giving the errors or was it the QAT
Driver builds?
I had errors with QAT Engine. Driver I was able to build with no issues.

The QAT Engine whilst not tested on a wide range of Linux
Distributions/kernels is generally run with:
Fedora 16 (for the Legacy QAT Driver. We are gradually phasing out the Fed
16 machines).
CentOs 7.4 (majority of our testing).
Fedora 23 (some development systems).
Ubuntu 16.04 (some development systems).
We don't usually see a lot of build issues between Distributions on the
QAT Engine side especially with QAT Upstream Driver that uses the USDM
Memory Driver.

We stick to (popular nowadays) Ubuntu and Debian. All recent versions of
both user land and kernels. Ubuntu 16.04 is too old.
Can you please specify kernel versions too for each tested Linux
distribution?
The biggest issue is with the QAT Driver. This is because some of the API's

that the QAT Driver builds against in the kernel are changing a lot over
time. New versions of the QAT Driver are fixing the incompatibilities as
they come up, but very new Distributions like Ubuntu 18.10 that is still in
Beta will not be supported yet. Your mileage will definitely vary between
different Distributions with different kernel versions, probably CentOs 7.4
is a particular sweet spot as that is where a lot of testing has been
concentrated, but that might not help if you need the latest and greatest!
With regard to QAT HW/SW support, are you talking to Intel already?
Usually a Platform Application Engineer would get involved in helping you
with your queries.

Not yet, I got hardware just couple of days before and since testing failed
I’m out for businesses trip, which don’t allow me make testing until next
week.
Can you suggest someone exactly who can provide support from Intel? Or
where to find right contact.
It was big story on how our supplier (intel platinum partner) was working
to get that card for testing... they have no sales people in EU who have
experience, so they spent 3 weeks to get it for us.
—
With regards,
Peak Load
Kind Regards,

Steve.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/intel/QAT_Engine/issues/90#issuecomment-431060704,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AgnydfDUbErQs_kbh1Pt7hsXVBvT7YURks5umKJygaJpZM4XahR_
.

--
With regards,
Eugene Sudyr

@stevelinsell thanks for helping me before - it works perfect with both CentOS 7 and Ubuntu 18.04 bionic with latest kernel, but not with mainline kernel versions.
Any plans to fix breaking code changes to keep up with mainline kernel?


Return default for empty environment variable

Check environment variables and return default if it is empty
Fixes #5026

thanks for your contribution @roulpriya ! Can you run ./gradlew :testcontainers:spotlessApply, please? that would fix the build

@eddumelendez Yes, I've done.

thank you so much @roulpriya ! this is not merged in main branch.

Thankyou @eddumelendez
Looking forward to contributing more.


golangci: add revive check

Enhance the static-analysis workflow with add some golangci checks.
Signed-off-by: Kay Yan<EMAIL_ADDRESS>

Thanks

Thanks @AkihiroSuda for the PR review :-)


exit with 1 on req -verify failure

This change will make the program exit with 1 on verification failure. My original intention was to process options like -text etc. even after the verification failure however due to the way the code is laid out this is not really possible without extensive change. The debugging information can be gained by re-running the program without the -verify option.

OTC: Is this kind of behavior change (failure exit value and immediate exit) acceptable?

Does returning non-zero value mean something wrong with the program itself? (like memory allocation failure or I/O failure)

Does returning non-zero value mean something wrong with the program itself? (like memory allocation failure or I/O failure)

Why do you ask exactly ? The way the req command is currently coded is that it sets the ret variable to 1 (which as a return code designates error, at least in Unix world) at the top of main() and then sets it to 0 (success) for some cases and at the very end of main(), just before the end label which is used for jumping to when an error occurs. These errors could be both internal errors as well some problems in the input data. If you are asking if there should be some way to distinguish the input data validation (e.g. private key being too short) from internal error (such as failed memory allocation), like returning 2 for the former and 1 for the latter case, then I have no problem with that.

As for whether there are any precedents, the crl command also has -verify which seems it will drive on after verification failure. On the other hand, the cms command will bail on verification failure.

OTC: we agree this can be considered a bug, and we recommend merging this, after the normal review process, for 3.3.0 and master.
Because this is breaking an established behavior, we would require a CHANGES.md entry.

OTC: we agree this can be considered a bug, and we recommend merging this, after the normal review process, for 3.3.0 and master.
Because this is breaking an established behavior, we would require a CHANGES.md entry.

Sounds good. Added the entry.

Note: the CI failure on external-tests is relevant.

Thanks. I filed a new issue in the gost-engine project to adapt the tests. This is all I can do.

As I don't maintain gost-engine anymore, probably it's time to drop this external test.

Why?  Is that project unmaintained?

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set.  Please review the updates and set the label manually.

Btw, thinking about (lack of) backward compatibility, IF a new script is relying on this behavior (of exit status of -verify) it can false positively pass a verification when run on older openssl binary. Isn't this dangerous?
Also, new man page change only explains new behavior never noting about old behavior:
Verifies the self-signature on the request. If the verification fails,
the program will immediately exit, i.e. further option processing
(e.g. B<-text>) is skipped.`

I would add a guard option like -exit-fail with the explanation and suggesting that a new code should use it as a guard measure. If a new code, that is relying solely on new exit status, run -verify with -exit-fail is run on the older openssl binary it will  always get exit code failure and will not get false positive success.

I updated gost-engine tests to pass with this commit so you may try restart CI for it.

I updated gost-engine tests to pass with this commit so you may try restart CI for it.

@vladak needs to update the gost-engine submodule in this PR.
Also, I strongly believe this should NOT go to 3.3 branch at this point and should be done in master only -> 3.4.
@vladak Could you please update the CHANGES.md to add a new 3.4 section and put this in there? Also the modified manual pages should be improved by adding HISTORY section with a note about this change in behavior.

@t8m there was an OTC decision @romen noted of "OTC: we agree this can be considered a bug, and we recommend merging this, after the normal review process, for 3.3.0 and master."

The decision sounds like recommendation and not must. However I won't block merging this to 3.3. My first comment about updating the gost-engine submodule to the latest commit still applies. @vladak could you please do that?

Agree with "urgent" to enable it to make it into the 3.3.0 beta release.
Note do not forget to update the gost-engine submodule

Reconfirm

Reconfirm and agree with urgent

Squashed and merged to the master and 3.3 branches. Thank you for your contribution.


UR5 beigns to move erraticaly using VelocityJointInterface.... Error on change to PositionJoint Interface

Hello Thomas and community,
I am using a UR5 arm, the details of the UR Control Firmware and  ROS details are as
Contro Box:   CB3UR5
User interface:   Polyscope 3.2.18744 (Oct 07 2015)
Robot Controller:    URControl 3.2.18744 (Oct 07 2015)
Safety Processor A:   URSafetyA 476
Safety Processor B:   URSafetyB 216
ROS Version : Kinetic on ubuntu 16 LTS
Installed ROS pakages: ros_control, ur_modern_driver, moveit, universal_robot
I am using the driver from ur_moder_driver package. Previously I was using Moveit to make the arm move. My UR5_bringup.launch file was not including the ros_controller_manager loading. I was just giving poses to Moveit and it seems moveit_controller_manager was taking care of everything and making the arm move. So there was no problem since making use of FollowJointTrajectory to make the arm go to the required poses.
Now we are developing our own motion planner using KDL and not use Moveit. I had to make changes to the UR5_bringup.launch and add the parts for spawn_controller_manager. The launch file was able to load the controllers successfully but there was the same problem with the UR5 as mentioned in #55 #148, and  #114.
As far as I can relate and understand the problem, I am using the updated driver, and also the problem is due to the optional t parameter in the speedj command in ur_realtime_communication.cpp mentioned in #55 by @miguelprada . I did not debug this file yet. Also the explanation given by @miguelprada  in #148 clarifies the problem. There already have been few fixes like #57 for SW > 3.1, and then further #100 for versions 3.3.X.X. due to #92 , but since I am using the updated driver, I do not understand why the driver is not invoking the condition here,since owing to the firmware version I have, there is not time parameter t for speedj.
I did not tweak any PID gains in the controller.yaml or either change the servoj parameter to 0.016 in the launch file yet. I referenced #55 and changed the vel_based_pos_traj_controller to pos_based_pos_traj_controller in the UR5_bringup.launch file as indicated by @miguelprada. Now the problem of oscillation in the robot is no more. The robot is stable but, when I launch the file for loading the controllers I get the error

[ERROR] [1534861867.789062234]: UrDriver::servoj called without a reverse connection present. Keepalive: 1

The detailed message is below...
`
started roslaunch server http://<IP_ADDRESS>:34070/

SUMMARY

PARAMETERS
 * /force_torque_sensor_controller/publish_rate: 125
 * /force_torque_sensor_controller/type: force_torque_sens...
 * /hardware_control_loop/loop_hz: 125
 * /hardware_interface/joints: ['arm_shoulder_pa...
 * /joint_state_controller/publish_rate: 125
 * /joint_state_controller/type: joint_state_contr...
 * /pos_based_pos_traj_controller/action_monitor_rate: 10
 * /pos_based_pos_traj_controller/constraints/arm_elbow_joint/goal: 0.1
 * /pos_based_pos_traj_controller/constraints/arm_elbow_joint/trajectory: 0.1
 * /pos_based_pos_traj_controller/constraints/arm_shoulder_lift_joint/goal: 0.1
 * /pos_based_pos_traj_controller/constraints/arm_shoulder_lift_joint/trajectory: 0.1
 * /pos_based_pos_traj_controller/constraints/arm_shoulder_pan_joint/goal: 0.1
 * /pos_based_pos_traj_controller/constraints/arm_shoulder_pan_joint/trajectory: 0.1
 * /pos_based_pos_traj_controller/constraints/arm_wrist_1_joint/goal: 0.1
 * /pos_based_pos_traj_controller/constraints/arm_wrist_1_joint/trajectory: 0.1
 * /pos_based_pos_traj_controller/constraints/arm_wrist_2_joint/goal: 0.1
 * /pos_based_pos_traj_controller/constraints/arm_wrist_2_joint/trajectory: 0.1
 * /pos_based_pos_traj_controller/constraints/arm_wrist_3_joint/goal: 0.1
 * /pos_based_pos_traj_controller/constraints/arm_wrist_3_joint/trajectory: 0.1
 * /pos_based_pos_traj_controller/constraints/goal_time: 0.6
 * /pos_based_pos_traj_controller/constraints/stopped_velocity_tolerance: 0.05
 * /pos_based_pos_traj_controller/joints: ['arm_shoulder_pa...
 * /pos_based_pos_traj_controller/state_publish_rate: 125
 * /pos_based_pos_traj_controller/stop_trajectory_duration: 0.5
 * /pos_based_pos_traj_controller/type: position_controll...
 * /rosdistro: indigo
 * /rosversion: 1.11.16
 * /ur_driver/base_frame: arm_base
 * /ur_driver/max_payload: 5.0
 * /ur_driver/max_velocity: 3.0
 * /ur_driver/min_payload: 0.0
 * /ur_driver/prefix: arm_
 * /ur_driver/robot_ip_address: <IP_ADDRESS>
 * /ur_driver/servoj_time: 0.008
 * /ur_driver/tool_frame: arm_tool0_controller
 * /ur_driver/use_ros_control: True
 * /vel_based_pos_traj_controller/action_monitor_rate: 10
 * /vel_based_pos_traj_controller/constraints/arm_elbow_joint/goal: 0.1
 * /vel_based_pos_traj_controller/constraints/arm_elbow_joint/trajectory: 0.1
 * /vel_based_pos_traj_controller/constraints/arm_shoulder_lift_joint/goal: 0.1
 * /vel_based_pos_traj_controller/constraints/arm_shoulder_lift_joint/trajectory: 0.1
 * /vel_based_pos_traj_controller/constraints/arm_shoulder_pan_joint/goal: 0.1
 * /vel_based_pos_traj_controller/constraints/arm_shoulder_pan_joint/trajectory: 0.1
 * /vel_based_pos_traj_controller/constraints/arm_wrist_1_joint/goal: 0.1
 * /vel_based_pos_traj_controller/constraints/arm_wrist_1_joint/trajectory: 0.1
 * /vel_based_pos_traj_controller/constraints/arm_wrist_2_joint/goal: 0.1
 * /vel_based_pos_traj_controller/constraints/arm_wrist_2_joint/trajectory: 0.1
 * /vel_based_pos_traj_controller/constraints/arm_wrist_3_joint/goal: 0.1
 * /vel_based_pos_traj_controller/constraints/arm_wrist_3_joint/trajectory: 0.1
 * /vel_based_pos_traj_controller/constraints/goal_time: 0.6
 * /vel_based_pos_traj_controller/constraints/stopped_velocity_tolerance: 0.05
 * /vel_based_pos_traj_controller/gains/arm_elbow_joint/d: 0.1
 * /vel_based_pos_traj_controller/gains/arm_elbow_joint/i: 0.0
 * /vel_based_pos_traj_controller/gains/arm_elbow_joint/i_clamp: 1
 * /vel_based_pos_traj_controller/gains/arm_elbow_joint/p: 1.2
 * /vel_based_pos_traj_controller/gains/arm_shoulder_lift_joint/d: 0.1
 * /vel_based_pos_traj_controller/gains/arm_shoulder_lift_joint/i: 0.0
 * /vel_based_pos_traj_controller/gains/arm_shoulder_lift_joint/i_clamp: 1
 * /vel_based_pos_traj_controller/gains/arm_shoulder_lift_joint/p: 1.2
 * /vel_based_pos_traj_controller/gains/arm_shoulder_pan_joint/d: 0.1
 * /vel_based_pos_traj_controller/gains/arm_shoulder_pan_joint/i: 0.0
 * /vel_based_pos_traj_controller/gains/arm_shoulder_pan_joint/i_clamp: 1
 * /vel_based_pos_traj_controller/gains/arm_shoulder_pan_joint/p: 1.2
 * /vel_based_pos_traj_controller/gains/arm_wrist_1_joint/d: 0.1
 * /vel_based_pos_traj_controller/gains/arm_wrist_1_joint/i: 0.0
 * /vel_based_pos_traj_controller/gains/arm_wrist_1_joint/i_clamp: 1
 * /vel_based_pos_traj_controller/gains/arm_wrist_1_joint/p: 1.2
 * /vel_based_pos_traj_controller/gains/arm_wrist_2_joint/d: 0.1
 * /vel_based_pos_traj_controller/gains/arm_wrist_2_joint/i: 0.0
 * /vel_based_pos_traj_controller/gains/arm_wrist_2_joint/i_clamp: 1
 * /vel_based_pos_traj_controller/gains/arm_wrist_2_joint/p: 1.2
 * /vel_based_pos_traj_controller/gains/arm_wrist_3_joint/d: 0.1
 * /vel_based_pos_traj_controller/gains/arm_wrist_3_joint/i: 0.0
 * /vel_based_pos_traj_controller/gains/arm_wrist_3_joint/i_clamp: 1
 * /vel_based_pos_traj_controller/gains/arm_wrist_3_joint/p: 1.2
 * /vel_based_pos_traj_controller/joints: ['arm_shoulder_pa...
 * /vel_based_pos_traj_controller/state_publish_rate: 125
 * /vel_based_pos_traj_controller/stop_trajectory_duration: 0.5
 * /vel_based_pos_traj_controller/type: velocity_controll...

NODES
  /
    robot_state_publisher (robot_state_publisher/robot_state_publisher)
    ros_control_controller_manager (controller_manager/controller_manager)
    ros_control_controller_spawner (controller_manager/spawner)
    ur_driver (ur_modern_driver/ur_driver)

ROS_MASTER_URI=http://summitB:11311

core service [/rosout] found
process[ur_driver-1]: started with pid [14393]
process[ros_control_controller_spawner-2]: started with pid [14394]
process[ros_control_controller_manager-3]: started with pid [14395]
process[robot_state_publisher-4]: started with pid [14396]
[ INFO] [1534861866.566994765]: Setting prefix to arm_
[ INFO] [1534861866.567610250]: Reading rosparams from namespace: /
[ INFO] [1534861866.568139245]: Loaded ur_hardware_interface.
[INFO] [WallTime:<PHONE_NUMBER>.944667] Controller Spawner: Waiting for service controller_manager/load_controller
[INFO] [WallTime:<PHONE_NUMBER>.945532] Controller Spawner: Waiting for service controller_manager/switch_controller
[INFO] [WallTime:<PHONE_NUMBER>.946328] Controller Spawner: Waiting for service controller_manager/unload_controller
[INFO] [WallTime:<PHONE_NUMBER>.947160] Loading controller: joint_state_controller
Loaded vel_based_pos_traj_controller
[INFO] [WallTime:<PHONE_NUMBER>.620954] Loading controller: force_torque_sensor_controller
[INFO] [WallTime:<PHONE_NUMBER>.677162] Loading controller: pos_based_pos_traj_controller
[INFO] [WallTime:<PHONE_NUMBER>.709284] Controller Spawner: Loaded controllers: joint_state_controller, force_torque_sensor_controller, pos_based_pos_traj_controller
[ERROR] [1534861867.716805472]: UrDriver::servoj called without a reverse connection present. Keepalive: 1
[ERROR] [1534861867.724842879]: UrDriver::servoj called without a reverse connection present. Keepalive: 1
[ERROR] [1534861867.732813491]: UrDriver::servoj called without a reverse connection present. Keepalive: 1
[ERROR] [1534861867.740842784]: UrDriver::servoj called without a reverse connection present. Keepalive: 1
[ros_control_controller_manager-3] process has finished cleanly
log file: /home/summit/.ros/log/e502a92c-a549-11e8-b2cb-003018c564a5/ros_control_controller_manager-3*.log
[ERROR] [1534861867.748836804]: UrDriver::servoj called without a reverse connection present. Keepalive: 1
[ERROR] [1534861867.756993562]: UrDriver::servoj called without a reverse connection present. Keepalive: 1
[ERROR] [1534861867.764944095]: UrDriver::servoj called without a reverse connection present. Keepalive: 1
[ERROR] [1534861867.772898293]: UrDriver::servoj called without a reverse connection present. Keepalive: 1
[ERROR] [1534861867.780999750]: UrDriver::servoj called without a reverse connection present. Keepalive: 1
[ERROR] [1534861867.789062234]: UrDriver::servoj called without a reverse connection present. Keepalive: 1
[ERROR] [1534861867.796749242]: UrDriver::servoj called without a reverse connection present. Keepalive: 1
[ERROR] [1534861867.804888412]: UrDriver::servoj called without a reverse connection present. Keepalive: 1
[ERROR] [1534861867.812771280]: UrDriver::servoj called without a reverse connection present. Keepalive: 1

Now I did publish some joint values to check if the controller works, and the arm moves, but the motion is very jerky at high speeds. When going for a larger position, the speed parameter we give in the launch file, ie . max_velocity no longer takes effect and the arm moves at high speed. For small positions, the motion is ok, and the speed parameter is also effective. I do not understand this behavior. probably the speed parameter is being ignored by the controller for its optimum performance. After some time I then get this message on the terminal and the controller no longer works,
`Wrong length of message on RT interface: 0
Wrong length of message on RT interface:<PHONE_NUMBER>
Wrong length of message on RT interface: 0
Wrong length of message on RT interface:<PHONE_NUMBER>
Wrong length of message on RT interface: 0
Wrong length of message on RT interface:<PHONE_NUMBER>
Wrong length of message on RT interface: 0
Wrong length of message on RT interface:<PHONE_NUMBER>
Wrong length of message on RT interface: 0
[ WARN] [1534864787.041504105]: Realtime port: No connection. Is controller crashed? Will try to reconnect in 10 seconds...
[ WARN] [1534864792.231904200]: Secondary port: No connection. Is controller crashed? Will try to reconnect in 10 seconds...
[ INFO] [1534864797.041888214]: Realtime port: Reconnected
Wrong length of message on RT interface:<PHONE_NUMBER>
Wrong length of message on RT interface: 0
Wrong length of message on RT interface:<PHONE_NUMBER>
Wrong length of message on RT interface:<PHONE_NUMBER>`

I have to restart everything then. I am publishing the joint values via a .cpp file on the topic /pos_based_pos_traj_controller/command.
The probable cause for the error message UrDriver::servoj called, from what i have understood is .. that the driver waits for the motors of the joints to turn on, and when the joints are activated, this message stops. I checked this thing by launching the controller launch file, and the arm was not turned on, there was a long stream of this error message received on the terminal, and when the arm was turned START from the ployscope, the stream stopped and there was the message at the end.
[INFO] [WallTime:<PHONE_NUMBER>.821025] Started controllers: joint_state_controller, force_torque_sensor_controller, pos_based_pos_traj_controller
Is the above guess right.? I cannot debug the code of the cpp file for the moment. Dos this have anything to do with the mentioning of reverse_port in the launch file..? I also don't understand the second WARNING message.
At the moment I am clueless.
@miguelprada ,@gavanderhoorn, @ThomasTimm    your attention in this issue is required please.
Thanking you in advance.

I appreciate you taking the time to write such an extensive post, but could I ask you to please post a comment with a summary of the issue you are encountering? There is so much text and things made bold that it's hard for me to figure out what the issue is.
If you're running into issues with the velocity controller becoming unstable without having changed the pids: that is expected.
For anything else: please provide a clear, to-the-point description of the symptoms, not potentially identified causes.

We're going to need a condensed version of the initial problem description. Without that it's hard to support you.
For now I'm closing this due to inactivity, but if you have a chance, please comment again and then re-open.


Wrong CSS selector

https://github.com/PacktPublishing/Building-AI-Applications-with-ChatGPT-APIs/blob/256dc3d79240a828be6962afc969a432861ca963/Chapter02 ChatGPTClone/templates/index.html#L23
Is most probably
#submit {

Additionally, there is an closing curly brace in excess, at the end of CSS.
And, possibly, the chat id has to be in  tag, not in


Lazy dtype update

Fix for #1287, replaces #1290 and #1291.
Demo notebook:
http://nbviewer.ipython.org/gist/ocefpaf/4c81ca2d4a86c69e2026
@rhattersley Not sure if I merged things correctly.  A quick test with my dataset works :grin: though.

Note to self: this is odd! Why switch? There's already a file for testing build_dimension_coordinate.

@rhattersley Is this just a matter of renaming it back to build_auxilliary_coordinate?  Is there something that I can do here to help?

Question:
In lib/iris/fileformats/_pyke_rules/fc_rules_cf.krb there are build_auxiliary_coordinate (that this PR changed to use biggus) and build_dimension_coordinate (that remains unchanged).
Should both make use of biggus?  I tried copying the same logic and rebase against the latest master (that has the new vertical ocean coordinates)  but failed with MemoryError when loading a ocean_sigma dataset:
Notebook:  http://nbviewer.ipython.org/gist/ocefpaf/4fe047bdaeb4a627d4a0
PR: #1533

Should both make use of biggus?

For now I'd avoid the extra complexity of using biggus for dimension coordinates. If it becomes a problem we can reconsider. But dimension coordinates are limited to 1-dimension, so they don't grow as a large as the auxiliary coordinates.

@rhattersley, pleading for help here.  We can't use the official SciTools  Iris for many of our workflows until this is merged -- it just blows memory.   Here's an example of a notebook that won't run for you, but does run for us with our "custom" Iris version:
http://nbviewer.ipython.org/gist/rsignell-usgs/7eea48ac4124a7071473

@rhattersley, pleading for help here.

I've attempted to pull everything together and fix the weird test issue mentioned above. It's now in #1560. I think that gives us a decent candidate for merging with all the known issues addressed.


Anchor links

I tried to add anchor links on the about page.
It scrolls a little more down then it should. It looks like it scrolls an extra amount equal to the navigation bar height.
How can I solve this? Has anyone had an experience with these?

I have solved this exact problem in a different project. It is a bit messy, but you can use some CSS to work around the problem. If you are doing your anchor links with ids, then this CSS will add a psedu element before it that should do what you need:
    a[id]:before {
        content: '';
        height: 53px;
        margin-top: -53px;
        display: block;
        visibility: hidden;
    }

where 53px is the height of the nav bar. You might need to adjust that if you've changed the styling.
Hope that helps! Let me know if it works and thanks for your input.


Upgrade Duet Display to v1.2.9

Updating Duet Display to version 1.2.9. URL change
reflects the fact that it changes more than just the
version number.

Can you please squash your commits


cargoCheckHook: proof of concept of fix for the test-threads issue

Some tests are failing because an extra arg is being passed to set the amount of threads for cargo test.
This is a proof of concept with the assumption that the arguments passed somehow are stepping on toes of
other argument parsers. Assuming that this amount of threads can also be passed via RUST_TEST_THREADS,
we could achieve the same behaviour and avoid causing this problem.

cargoCheckHook: pass test-threads using an environment variable
treewide: reenable tests of packages affected with the test-threads issue

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-reviewd workflow finished
Status and logs: https://github.com/nixosbrasil/nixpkgs-reviewd/actions/runs/12518855070

nixpkgs-reviewd workflow started
Status and logs: https://github.com/nixosbrasil/nixpkgs-reviewd/actions/runs/12518855612
Extra args: ``

nixpkgs-reviewd workflow finished
Status and logs: https://github.com/nixosbrasil/nixpkgs-reviewd/actions/runs/12518855612

nixpkgs-reviewd workflow started
Status and logs: https://github.com/nixosbrasil/nixpkgs-reviewd/actions/runs/12518895172
Extra args: ``

nixpkgs-reviewd workflow finished
Status and logs: https://github.com/nixosbrasil/nixpkgs-reviewd/actions/runs/12518895172

I plan to first test with the affected packages, and if I get success with them I rebase this PR to staging because of the amount of rebuilds. That way I do not have to run reviewd in rounds because of the amount of packages.

nixpkgs-reviewd workflow finished
Status and logs: https://github.com/nixosbrasil/nixpkgs-reviewd/actions/runs/12519046356
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 368593

x86_64-darwin

:x: 3 packages failed to build:

lsd
pomsky
sonic-server

:white_check_mark: 8 packages built:

carl
glitter
navi
nushell
sfz
tidy-viewer
typst
wasm-tools

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 368593

aarch64-darwin

:x: 3 packages failed to build:

lsd
pomsky
sonic-server

:white_check_mark: 8 packages built:

carl
glitter
navi
nushell
sfz
tidy-viewer
typst
wasm-tools

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 368593

x86_64-linux

:x: 4 packages failed to build:

lsd
nushell
pomsky
sonic-server

:white_check_mark: 7 packages built:

carl
glitter
navi
sfz
tidy-viewer
typst
wasm-tools

The PoC works, but there are failing tests not related to the issue being fixed in this PR.

nixpkgs-reviewd workflow started
Status and logs: https://github.com/nixosbrasil/nixpkgs-reviewd/actions/runs/12522521390
Extra args: -p carl -p glitter -p lsd -p navi -p pomsky -p sfz -p sonic-server -p tidy-viewer -p typst -p wasm-tools -p nushell

nixpkgs-reviewd workflow finished
Status and logs: https://github.com/nixosbrasil/nixpkgs-reviewd/actions/runs/12522521390
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 368593

x86_64-darwin

:x: 2 packages failed to build:

pomsky
sonic-server

:white_check_mark: 9 packages built:

carl
glitter
lsd
navi
nushell
sfz
tidy-viewer
typst
wasm-tools

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 368593

aarch64-darwin

:x: 2 packages failed to build:

pomsky
sonic-server

:white_check_mark: 9 packages built:

carl
glitter
lsd
navi
nushell
sfz
tidy-viewer
typst
wasm-tools

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 368593

x86_64-linux

:x: 3 packages failed to build:

nushell
pomsky
sonic-server

:white_check_mark: 8 packages built:

carl
glitter
lsd
navi
sfz
tidy-viewer
typst
wasm-tools


[Issue]: vertify  Simple Coding Agent Not code save the disk

Describe the issue
I run Simple Codeing Agent example , I can save the code on Jupter, but I can't save it on PyCharm, why is this ?
Steps to reproduce
from pathlib import Path
workdir = Path("coding")
print(workdir)
workdir.mkdir(exist_ok=True)
from autogen.coding import LocalCommandLineCodeExecutor
code_executor = LocalCommandLineCodeExecutor(work_dir=workdir)
from autogen import AssistantAgent, UserProxyAgent
Setting up the agents.
user_proxy_agent = UserProxyAgent(
name="User",
code_execution_config={"executor": code_executor},
is_termination_msg=lambda msg: "TERMINATE" in msg.get("content"),
)
assistant_agent = AssistantAgent(
name="DBRX Assistant",
llm_config=llm_config,
)
chat_result = user_proxy_agent.initiate_chat(
assistant_agent,
message="Count how many prime numbers from 1 to 10000.",
)
Screenshots and logs

empty directory
Additional Information
python 3.11
autogen 0.2.31

@812406210 do you still have this issue? IDE should not affect how the code executes. It's likely that something else is the issue -- the agent didn't specify a file name for the code block. Or you are not looking at the correct path. Please reopen the issue if you have further questions.


test that we support image signatures

xref https://github.com/containers/skopeo/issues/1482
We should validate that we're doing image signatures via the proxy correctly.

In this issue, the great thing about the new ostree-native-container flow is that if you have a setup to sign container images, that exact same setup can be used to sign OS updates.
See https://docs.podman.io/en/latest/markdown/podman-image-sign.1.html and https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux_atomic_host/7/html/managing_containers/signing_container_images for some old-style GPG signatures.  As of recently the containers/image stack gained support for "cosign", see https://github.com/containers/skopeo/pull/1701

To test the recent changes for policy verification:

Modify /etc/containers/policy.json for sigstore/gpg signed images from the remote-registry
Sign an existing fcos image and push to the remore-registry
Try doing an rpm-ostree rebase ${signed-image}
Ensure it fails

Since we do not currently sign fcos or any ostree-based-images, we need to have signed images available.
Initially it was thought this can be done locally by doing skopeo copy docker://quay.io/fedora/fedora-coreos:testing-devel oci:/var/lib/containers/signed-local-registry/sigstore/test.oci --sign-by-sigstore-private-key fcos.key .
But this fails unfortunately, since how sigstore signs images is by pushing the artifacts generated to the remote-registry. Hence, signing an local oci or dir does not work. It instead gives the following error: Cannot determine canonical Docker reference for destination oci:/var/lib/containers/signed-local-registry/sigstore/test.oci.
Instead we need to be able to push this to some ephemeral testing Docker image registry. The perfect candidate was ttl.sh as mentioned in sigstore doumentation, but unfortunately fcos image exceeds the maxiumum image size limit there. Is there any other registry we could push to and verify instead?

So CI on this repository mainly uses GHA, for which there is https://docs.github.com/en/actions/using-containerized-services/about-service-containers
But that's just sugar for running a container...we can run any registry (quay.io, docker/distribution or whatever) inside a GHA job right?


Bower can't find ngDraggable

When I run bower update / bower install is shown this: Package ngDraggable not found.
I saw that the package was renamed to lowercase and back to the old name. And I already tried to rename the package name to lowercase and back to the old name and the bower is still breaking.

Its the same for me.

try
bower cache clean
bower install ngdraggable --save

Sorry, that didn't work. Still the same issue.
Package ngDraggable not found

It worked for me. I just did another command:
bower uninstall ngDraggable --save
then
bower cache clean
bower install ngdraggable --save

its pretty annoying, ill ask bower support if they'll register a 'ngDraggable' alias

bower team renamed the package back to 'ngDraggable'

README.md needs to be updated. There is wrong name in the example of package installation. Should be - 'bower install ngDraggable'

its already been updated

Oops sorry. You are so fast :)

Yup.. works now.. Thanks!


Scala 2.12 milestones support

Hi @analytically
Would it be possible to publish cross-built versions so projects depending on scala-logging can give Scala 2.12 milestones a try, please?
Regards

Thanks!


Doc for Scan seems inconsistent, cf get() and count()?

Scan example on https://github.com/jed/dynamo/wiki/High-level-API is:
table.scan({
        name: "dynamo",
        iq: {">=": 100}
      })
      .get(["name", "iq", "status"])
      .count()
      .fetch(function(err, count){ ... })

But documentation for scan.count() just below this says: "cannot be used if Scan#get() is called"

thanks for the catch, @mhart. fixed.


Log reasons for skipping inlining

Some sort of "Skipping import of /foo/bar because absolute path" would go a long way to providing understanding of the output.

+1 This would be most helpful especially when -v or --verbose is used.  The only way I figured this out was by way of this issue comment.

+1 This would be most helpful especially when -v or --verbose is used.  The only way I figured this out was by way of this issue comment.

This will require configurable logging. @justinfagnani might want to look at this after he figures out logging in polytool.

Sure


[Refactor] updating to the new machine syntax

Reviews
0/1
Message

More info

Reviews
1/1
Message

brad-larson
1
approved

Pull request is reviewed and can be merged to master!
More info


[Backport release-21.11] htop-vim: init at unstable-2021-10-1

Motivation for this change
Manual backport of https://github.com/NixOS/nixpkgs/pull/146730/ since I forgot to tag the original PR with backport release-21.11 label.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 147254 run on x86_64-linux 1

1 package built:

htop-vim


Redesign top bar

Before :

After :

This is a duplicate of #4599 - feel free to subscribe there for updates.
In the future, please completely fill out the provided issue template.