Change default value for ephemral preference

What type of PR is this?

Uncomment only one  /kind line, and delete the rest.
For example, > /kind bug would simply become: /kind bug

/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind failing-test
/kind feature
/kind flake
/kind code-refactoring
Documentation changes: Please include [skip ci] in your commit message as well
/kind documentation
[skip ci]

What does does this PR do / why we need it:
For now, it assumes default value for ephemeral 'false'.
In future releases, we might change it 'true'. But for now, we should
play it safe and keep the old behavior. We are not sure about all the
consequences that this can have.
Which issue(s) this PR fixes:
Fixes #?
PR acceptance criteria:

[ ] Unit test

[x] Integration test

[ ] Documentation

[x] I have read the test guidelines

How to test changes / Special notes to the reviewer:

/test unit

/test unit

@kadel Can we add doc for this as well? I'm asking because it would take the user to set Ephemeral to false in preferences for PVC to actually be used. Simply unsetting it won't suffice. That is, odo set Ephemeral false is required for odo to use a PVC instead of emptyDir.

@kadel Can we add doc for this as well? I'm asking because it would take the user to set Ephemeral to false in preferences for PVC to actually be used. Simply unsetting it won't suffice. That is, odo set Ephemeral false is required for odo to use a PVC instead of emptyDir.

@kadel Can we add doc for this as well? I'm asking because it would take the user to set Ephemeral to false in preferences for PVC to actually be used. Simply unsetting it won't suffice. That is, odo preference set Ephemeral false is required for odo to use a PVC instead of emptyDir.

unsetting (odo preference unset Ephemeral, or if user never did anything with that variable) and odo preference set Ephemeral false both result in using emptyDir.

@kadel Can we add doc for this as well? I'm asking because it would take the user to set Ephemeral to false in preferences for PVC to actually be used. Simply unsetting it won't suffice. That is, odo preference set Ephemeral false is required for odo to use a PVC instead of emptyDir.

unsetting (odo preference unset Ephemeral, or if user never did anything with that variable) and odo preference set Ephemeral false both result in using emptyDir.

unsetting (odo preference unset Ephemeral, or if user never did anything with that variable)

This doesn't work for me. :disappointed:

 without setting any value for Ephemeral
$ odo version
odo v2.0.3 (b8c0bb87d)

$ odo preference view
PARAMETER             CURRENT_VALUE
UpdateNotification
NamePrefix
Timeout
BuildTimeout          3000
PushTimeout           480
Experimental
PushTarget
Ephemeral

$ odo create nodejs nodejs-ex
Validation
 ✓  Checking devfile existence [66493ns]
 ✓  Creating a devfile component from registry: DefaultDevfileRegistry [62813ns]
 ✓  Validating devfile component [252701ns]

Please use `odo push` command to create the component with source deployed

$ odo push

Validation
 ✓  Validating the devfile [38873ns]

Creating Kubernetes resources for component nodejs-ex
 ✓  Waiting for component to start [11s]
 ✓  Waiting for component to start [17ms]

Applying URL changes
 ✓  URL http-3000: http://http-3000-nodejs-ex-newproject.apps-crc.testing/ created

Syncing to component nodejs-ex
 ✓  Checking files for pushing [573362ns]
 ✓  Syncing files to the component [249ms]

Executing devfile commands for component nodejs-ex
 ✓  Waiting for component to start [2ms]
 ✓  Waiting for component to start [3ms]
 ✓  Waiting for component to start [3ms]
 ✓  Executing install command "npm install" [3s]
 ✓  Executing run command "npm start" [1s]

Pushing devfile component nodejs-ex
 ✓  Changes successfully pushed to component

$ kubectl get po,pvc
NAME                                      READY   STATUS    RESTARTS   AGE
pod/cockroach-operator-74bdfd6bf4-p7zjl   1/1     Running   0          3h19m
pod/nodejs-ex-74fd56cd8c-x2lvp            1/1     Running   0          38s

 Explicitly setting Ephemeral to false
$ odo preference view
PARAMETER             CURRENT_VALUE
UpdateNotification
NamePrefix
Timeout
BuildTimeout          3000
PushTimeout           480
Experimental
PushTarget
Ephemeral             false

odo create nodejs nodejs-ex
Validation
 ✓  Checking devfile existence [34051ns]
 ✓  Creating a devfile component from registry: DefaultDevfileRegistry [43657ns]
 ✓  Validating devfile component [241173ns]

Please use `odo push` command to create the component with source deployed

$ odo push

Validation
 ✓  Validating the devfile [54278ns]

Creating Kubernetes resources for component nodejs-ex
 ✓  Waiting for component to start [10s]
 ✓  Waiting for component to start [15ms]

Applying URL changes
 ✓  URL http-3000: http://http-3000-nodejs-ex-newproject.apps-crc.testing/ created

Syncing to component nodejs-ex
 ✓  Checking files for pushing [557761ns]
 ✓  Syncing files to the component [275ms]

Executing devfile commands for component nodejs-ex
 ✓  Waiting for component to start [2ms]
 ✓  Waiting for component to start [2ms]
 ✓  Waiting for component to start [3ms]
 ✓  Executing install command "npm install" [4s]
 ✓  Executing run command "npm start" [1s]

Pushing devfile component nodejs-ex
 ✓  Changes successfully pushed to component

$ kubectl get po,pvc
NAME                                      READY   STATUS    RESTARTS   AGE
pod/cockroach-operator-74bdfd6bf4-p7zjl   1/1     Running   0          3h19m
pod/nodejs-ex-6bf76f657d-2gxb6            1/1     Running   0          17s

NAME                                                STATUS   VOLUME   CAPACITY   ACCESS MODES   STORAGECLASS   AGE
persistentvolumeclaim/odo-projects-nodejs-ex-tzos   Bound    pv0016   100Gi      RWO,ROX,RWX                   17s

unsetting (odo preference unset Ephemeral, or if user never did anything with that variable)

This doesn't work for me. :disappointed:

 without setting any value for Ephemeral
$ odo version
odo v2.0.3 (b8c0bb87d)

$ odo preference view
PARAMETER             CURRENT_VALUE
UpdateNotification
NamePrefix
Timeout
BuildTimeout          3000
PushTimeout           480
Experimental
PushTarget
Ephemeral

$ odo create nodejs nodejs-ex
Validation
 ✓  Checking devfile existence [66493ns]
 ✓  Creating a devfile component from registry: DefaultDevfileRegistry [62813ns]
 ✓  Validating devfile component [252701ns]

Please use `odo push` command to create the component with source deployed

$ odo push

Validation
 ✓  Validating the devfile [38873ns]

Creating Kubernetes resources for component nodejs-ex
 ✓  Waiting for component to start [11s]
 ✓  Waiting for component to start [17ms]

Applying URL changes
 ✓  URL http-3000: http://http-3000-nodejs-ex-newproject.apps-crc.testing/ created

Syncing to component nodejs-ex
 ✓  Checking files for pushing [573362ns]
 ✓  Syncing files to the component [249ms]

Executing devfile commands for component nodejs-ex
 ✓  Waiting for component to start [2ms]
 ✓  Waiting for component to start [3ms]
 ✓  Waiting for component to start [3ms]
 ✓  Executing install command "npm install" [3s]
 ✓  Executing run command "npm start" [1s]

Pushing devfile component nodejs-ex
 ✓  Changes successfully pushed to component

$ kubectl get po,pvc
NAME                                      READY   STATUS    RESTARTS   AGE
pod/cockroach-operator-74bdfd6bf4-p7zjl   1/1     Running   0          3h19m
pod/nodejs-ex-74fd56cd8c-x2lvp            1/1     Running   0          38s

 Explicitly setting Ephemeral to false
$ odo preference view
PARAMETER             CURRENT_VALUE
UpdateNotification
NamePrefix
Timeout
BuildTimeout          3000
PushTimeout           480
Experimental
PushTarget
Ephemeral             false

odo create nodejs nodejs-ex
Validation
 ✓  Checking devfile existence [34051ns]
 ✓  Creating a devfile component from registry: DefaultDevfileRegistry [43657ns]
 ✓  Validating devfile component [241173ns]

Please use `odo push` command to create the component with source deployed

$ odo push

Validation
 ✓  Validating the devfile [54278ns]

Creating Kubernetes resources for component nodejs-ex
 ✓  Waiting for component to start [10s]
 ✓  Waiting for component to start [15ms]

Applying URL changes
 ✓  URL http-3000: http://http-3000-nodejs-ex-newproject.apps-crc.testing/ created

Syncing to component nodejs-ex
 ✓  Checking files for pushing [557761ns]
 ✓  Syncing files to the component [275ms]

Executing devfile commands for component nodejs-ex
 ✓  Waiting for component to start [2ms]
 ✓  Waiting for component to start [2ms]
 ✓  Waiting for component to start [3ms]
 ✓  Executing install command "npm install" [4s]
 ✓  Executing run command "npm start" [1s]

Pushing devfile component nodejs-ex
 ✓  Changes successfully pushed to component

$ kubectl get po,pvc
NAME                                      READY   STATUS    RESTARTS   AGE
pod/cockroach-operator-74bdfd6bf4-p7zjl   1/1     Running   0          3h19m
pod/nodejs-ex-6bf76f657d-2gxb6            1/1     Running   0          17s

NAME                                                STATUS   VOLUME   CAPACITY   ACCESS MODES   STORAGECLASS   AGE
persistentvolumeclaim/odo-projects-nodejs-ex-tzos   Bound    pv0016   100Gi      RWO,ROX,RWX                   17s

That is weird. There is a test to test the default value https://github.com/openshift/odo/pull/4360/files#diff-a22366462d78266515a5177dc92bc1ef5901a1b05d9de4f7825a5a74d6f63a52R274-R292
And I tried the same thing that you did manually and it looks ok.
▶ odo preference unset ephemeral; odo preference view; odo push; oc get po,pvc
 ✗  preference already unset, cannot unset a preference which is not set
PARAMETER             CURRENT_VALUE
UpdateNotification
NamePrefix
Timeout
BuildTimeout
PushTimeout
Experimental
PushTarget
Ephemeral

Validation
 ✓  Validating the devfile [6ms]

Creating Kubernetes resources for component nodejs
 ✓  Waiting for component to start [5s]
 ✓  Waiting for component to start [146ms]

Applying URL changes
 ✓  URL http-3000: http://http-3000-nodejs-tkral-test2.apps.testocp4x.psiodo.net/ created

Syncing to component nodejs
 ✓  Checking files for pushing [3ms]
 ✓  Syncing files to the component [3s]

Executing devfile commands for component nodejs
 ✓  Waiting for component to start [144ms]
 ✓  Waiting for component to start [427ms]
 ✓  Waiting for component to start [146ms]
 ✓  Executing install command "npm install" [7s]
 ✓  Executing run command "npm start" [2s]

Pushing devfile component nodejs
 ✓  Changes successfully pushed to component

NAME                          READY   STATUS    RESTARTS   AGE
pod/nodejs-7dcfc86b4d-h2xm5   1/1     Running   0          19s

▶ odo preference set ephemeral true; odo preference view; odo push; oc get po,pvc
Global preference was successfully updated
PARAMETER             CURRENT_VALUE
UpdateNotification
NamePrefix
Timeout
BuildTimeout
PushTimeout
Experimental
PushTarget
Ephemeral             true

Validation
 ✓  Validating the devfile [53321ns]

Creating Kubernetes resources for component nodejs
 ✓  Waiting for component to start [5s]
 ✓  Waiting for component to start [146ms]

Applying URL changes
 ✓  URL http-3000: http://http-3000-nodejs-tkral-test2.apps.testocp4x.psiodo.net/ created

Syncing to component nodejs
 ✓  Checking files for pushing [3ms]
 ✓  Syncing files to the component [3s]

Executing devfile commands for component nodejs
 ✓  Waiting for component to start [144ms]
 ✓  Waiting for component to start [283ms]
 ✓  Waiting for component to start [276ms]
 ✓  Executing install command "npm install" [7s]
 ✓  Executing run command "npm start" [2s]

Pushing devfile component nodejs
 ✓  Changes successfully pushed to component

NAME                          READY   STATUS    RESTARTS   AGE
pod/nodejs-7dcfc86b4d-nf6cj   1/1     Running   0          19s

▶ odo preference set ephemeral false; odo preference view; odo push; oc get po,pvc
? ephemeral is already set. Do you want to override it in the config Yes
Global preference was successfully updated
PARAMETER             CURRENT_VALUE
UpdateNotification
NamePrefix
Timeout
BuildTimeout
PushTimeout
Experimental
PushTarget
Ephemeral             false

Validation
 ✓  Validating the devfile [205978ns]

Creating Kubernetes resources for component nodejs
 ✓  Waiting for component to start [18s]
 ✓  Waiting for component to start [165ms]

Applying URL changes
 ✓  URL http-3000: http://http-3000-nodejs-tkral-test2.apps.testocp4x.psiodo.net/ created

Syncing to component nodejs
 ✓  Checking files for pushing [3ms]
 ✓  Syncing files to the component [3s]

Executing devfile commands for component nodejs
 ✓  Waiting for component to start [143ms]
 ✓  Waiting for component to start [144ms]
 ✓  Waiting for component to start [439ms]
 ✓  Executing install command "npm install" [7s]
 ✓  Executing run command "npm start" [2s]

Pushing devfile component nodejs
 ✓  Changes successfully pushed to component

NAME                          READY   STATUS    RESTARTS   AGE
pod/nodejs-6c8cb96555-2p5r5   1/1     Running   0          34s

NAME                                             STATUS   VOLUME                                     CAPACITY   ACCESS MODES   STORAGECLASS   AGE
persistentvolumeclaim/odo-projects-nodejs-fzuu   Bound    pvc-bcaabdbe-adb2-4375-9286-ab7466d7102d   2Gi        RWO            standard       35s

That is weird. There is a test to test the default value https://github.com/openshift/odo/pull/4360/files#diff-a22366462d78266515a5177dc92bc1ef5901a1b05d9de4f7825a5a74d6f63a52R274-R292
And I tried the same thing that you did manually and it looks ok.
▶ odo preference unset ephemeral; odo preference view; odo push; oc get po,pvc
 ✗  preference already unset, cannot unset a preference which is not set
PARAMETER             CURRENT_VALUE
UpdateNotification
NamePrefix
Timeout
BuildTimeout
PushTimeout
Experimental
PushTarget
Ephemeral

Validation
 ✓  Validating the devfile [6ms]

Creating Kubernetes resources for component nodejs
 ✓  Waiting for component to start [5s]
 ✓  Waiting for component to start [146ms]

Applying URL changes
 ✓  URL http-3000: http://http-3000-nodejs-tkral-test2.apps.testocp4x.psiodo.net/ created

Syncing to component nodejs
 ✓  Checking files for pushing [3ms]
 ✓  Syncing files to the component [3s]

Executing devfile commands for component nodejs
 ✓  Waiting for component to start [144ms]
 ✓  Waiting for component to start [427ms]
 ✓  Waiting for component to start [146ms]
 ✓  Executing install command "npm install" [7s]
 ✓  Executing run command "npm start" [2s]

Pushing devfile component nodejs
 ✓  Changes successfully pushed to component

NAME                          READY   STATUS    RESTARTS   AGE
pod/nodejs-7dcfc86b4d-h2xm5   1/1     Running   0          19s

▶ odo preference set ephemeral true; odo preference view; odo push; oc get po,pvc
Global preference was successfully updated
PARAMETER             CURRENT_VALUE
UpdateNotification
NamePrefix
Timeout
BuildTimeout
PushTimeout
Experimental
PushTarget
Ephemeral             true

Validation
 ✓  Validating the devfile [53321ns]

Creating Kubernetes resources for component nodejs
 ✓  Waiting for component to start [5s]
 ✓  Waiting for component to start [146ms]

Applying URL changes
 ✓  URL http-3000: http://http-3000-nodejs-tkral-test2.apps.testocp4x.psiodo.net/ created

Syncing to component nodejs
 ✓  Checking files for pushing [3ms]
 ✓  Syncing files to the component [3s]

Executing devfile commands for component nodejs
 ✓  Waiting for component to start [144ms]
 ✓  Waiting for component to start [283ms]
 ✓  Waiting for component to start [276ms]
 ✓  Executing install command "npm install" [7s]
 ✓  Executing run command "npm start" [2s]

Pushing devfile component nodejs
 ✓  Changes successfully pushed to component

NAME                          READY   STATUS    RESTARTS   AGE
pod/nodejs-7dcfc86b4d-nf6cj   1/1     Running   0          19s

▶ odo preference set ephemeral false; odo preference view; odo push; oc get po,pvc
? ephemeral is already set. Do you want to override it in the config Yes
Global preference was successfully updated
PARAMETER             CURRENT_VALUE
UpdateNotification
NamePrefix
Timeout
BuildTimeout
PushTimeout
Experimental
PushTarget
Ephemeral             false

Validation
 ✓  Validating the devfile [205978ns]

Creating Kubernetes resources for component nodejs
 ✓  Waiting for component to start [18s]
 ✓  Waiting for component to start [165ms]

Applying URL changes
 ✓  URL http-3000: http://http-3000-nodejs-tkral-test2.apps.testocp4x.psiodo.net/ created

Syncing to component nodejs
 ✓  Checking files for pushing [3ms]
 ✓  Syncing files to the component [3s]

Executing devfile commands for component nodejs
 ✓  Waiting for component to start [143ms]
 ✓  Waiting for component to start [144ms]
 ✓  Waiting for component to start [439ms]
 ✓  Executing install command "npm install" [7s]
 ✓  Executing run command "npm start" [2s]

Pushing devfile component nodejs
 ✓  Changes successfully pushed to component

NAME                          READY   STATUS    RESTARTS   AGE
pod/nodejs-6c8cb96555-2p5r5   1/1     Running   0          34s

NAME                                             STATUS   VOLUME                                     CAPACITY   ACCESS MODES   STORAGECLASS   AGE
persistentvolumeclaim/odo-projects-nodejs-fzuu   Bound    pvc-bcaabdbe-adb2-4375-9286-ab7466d7102d   2Gi        RWO            standard       35s

And I tried the same thing that you did manually and it looks ok.

Not sure why, but it works for me now. :man_shrugging:

And I tried the same thing that you did manually and it looks ok.

Not sure why, but it works for me now. :man_shrugging:


New reconnection handling implementation. Now we will try to reconnec…

…t with a fully configurable backoff mechanism that supports both fibonacci and exponential.
Buffer will buffer log events from the time the disconnection was detected until it is reconnected. After a successful reconnection, buffer will be flushed.
Broken test after defaulting to secure connection is fixed.

cc: @dtracey-r7
@danilosterrapid7 @pquinn-r7 please review

+1
Agreed to apply guide styles in a separate PR.

+1


why true_score/fake_score have not T as input?  only have image/latent and label?

why true_score/fake_score have not T as input?  only have image/latent and label?

The EDM network takes sigma_t instead of t as its input. They are one-to-one mapped to each other, which means if we know t, we know sigma, and if we know sigma, we also know t.
y_real = true_score(y + n, sigma, labels, augment_labels=augment_labels)
y_fake = fake_score(y + n, sigma, labels, augment_labels=augment_labels)


Potential dereference of null pointer

line 4934: calling function ucvector_init() to initialize 'data'
https://github.com/BinomialLLC/basis_universal/blob/21ab9bebb5b067ccee273d5ce82ad3eb65656ac8/lodepng.cpp#L4934
in function ucvector_init()
line 245, 'data' may be assigned as null pointer.
https://github.com/BinomialLLC/basis_universal/blob/21ab9bebb5b067ccee273d5ce82ad3eb65656ac8/lodepng.cpp#L245
line 4936: 'data' is used as argument while calling function ucvector_push_back()
https://github.com/BinomialLLC/basis_universal/blob/21ab9bebb5b067ccee273d5ce82ad3eb65656ac8/lodepng.cpp#L4936
while calling function ucvector_push_back()
line 263:  dereference 'p->data' without checking whether it is a null pointer.
https://github.com/BinomialLLC/basis_universal/blob/21ab9bebb5b067ccee273d5ce82ad3eb65656ac8/lodepng.cpp#L263
(Our tool also found that in line 220 there is a check for 'data' which is the return value of calling function 'lodepng_realloc()', and assume that the value (data) is null. Even if this case will hardly happen, it is better to add an 'assert(p->data)'  as a better software engineering perspective)

Ok, this is in lodepng:
https://lodev.org/lodepng/
We only use this for PNG reading on the encoder. So this can't affect the transcoder at all, which is good.
I will look at this and see if I can fix it.

Also note that we have not seen any null ptr derefs inside of lodepng, yet.

I've added a check for null to uivector_push_back(). It will appear in the UASTC update in a few hours today.


Improve error when opening C# project on an Apple Silicon M1 machine without Rosetta

Issue Description
During the start of the OmniSharp server a call using the built-in mono command returns a Bad CPU type in executable error.
Steps to Reproduce
On a new Apple Silicon M1 machine:

Download and install the Mac Universal version of Visual Studio Code
Download and install the preview version of .NET 6 (6.0.100-preview.4.21255.9)
Create a new C# console project dotnet new console -n ConsoleApp
Open ConsoleApp folder in Visual Studio Code

Expected Behavior
Project loads and C# language features (e.g. code completion) are available.
Actual Behavior
An error is returned in the OmniSharp log and C# features are unavailable.
Logs
OmniSharp log

Starting OmniSharp server at 6/11/2021, 7:28:11 AM
    Target: /Users/miguellira/Developer/ConsoleApp
OmniSharp server started.
Path: /Users/miguellira/.vscode/extensions/ms-dotnettools.csharp-1.23.12/.omnisharp/1.37.10/run
PID: 10636
/Users/miguellira/.vscode/extensions/ms-dotnettools.csharp-1.23.12/.omnisharp/1.37.10/run: line 27: /Users/miguellira/.vscode/extensions/ms-dotnettools.csharp-1.23.12/.omnisharp/1.37.10/bin/mono: Bad CPU type in executable
[ERROR] Error: OmniSharp server load timed out. Use the 'omnisharp.projectLoadTimeout' setting to override the default delay (one minute).

C# log

Installing C# dependencies...
Platform: darwin, arm64
Downloading package 'OmniSharp for OSX' (37658 KB).................... Done!
Validating download...
Integrity Check succeeded.
Installing package 'OmniSharp for OSX'
Downloading package '.NET Core Debugger (macOS / x64)' (45875 KB).................... Done!
Validating download...
Integrity Check succeeded.
Installing package '.NET Core Debugger (macOS / x64)'
Downloading package '.NET Core Debugger (macOS / arm64)' (47834 KB).................... Done!
Validating download...
Integrity Check succeeded.
Installing package '.NET Core Debugger (macOS / arm64)'
Downloading package 'Razor Language Server (macOS / x64)' (60206 KB).................... Done!
Installing package 'Razor Language Server (macOS / x64)'
Finished
[WARNING]: arm64 macOS is not officially supported by the .NET Core debugger. You may experience unexpected issues when running in this configuration.

Environment information
VSCode version: 1.57.0
C# Extension: 1.23.12
Mono Information
        OmniSharp using built-in mono
Dotnet Information
.NET SDK (reflecting any global.json):
 Version:   6.0.100-preview.4.21255.9
 Commit:    950e4949a7
Runtime Environment:
OS Name:     Mac OS X
OS Version:  11.4
OS Platform: Darwin
RID:         osx.11.0-arm64
Base Path:   /usr/local/share/dotnet/sdk/6.0.100-preview.4.21255.9/
Host (useful for support):
Version: 6.0.0-preview.4.21253.7
Commit:  bfd6048a60
.NET SDKs installed:
6.0.100-preview.4.21255.9 [/usr/local/share/dotnet/sdk]
.NET runtimes installed:
Microsoft.AspNetCore.App 6.0.0-preview.4.21253.5 [/usr/local/share/dotnet/shared/Microsoft.AspNetCore.App]
Microsoft.NETCore.App 6.0.0-preview.4.21253.7 [/usr/local/share/dotnet/shared/Microsoft.NETCore.App]
To install additional .NET runtimes or SDKs:
https://aka.ms/dotnet-download

Visual Studio Code Extensions

Extension
Author
Version

csharp
ms-dotnettools
1.23.12

This is interesting, I have been using OmniSharp on an M1 mac since December without any issues.
There is no ARM64 built of Omnisharp but it works fine with Rosetta. Looks like for some reason Rosetta does not kick in here.

Thanks for the quick follow up @filipw. I think your post cleared things up for me. I have not installed Rosetta on this machine. Looks like VSCode doesn't require it but the C# extension does. Specifically OmniSharp's reliance on mono.

@gregg-miskelly Thanks for updating this issue and pinning it to the announcement.
I have a question... Now that both Visual Studio Code and the latest preview of .NET 6 SDK no longer requires Rosetta will there be an effort to have the C# plugin follow suit? I didn't find an issue to track, should I create one? Thanks!

OmniSharp has a feature branch for .NET 5.0 which will ultimately become .NET 6.0. At that point we can think of providing native builds for Mac ARM64.
With regards to Rosetta, macOS prompts its installation automatically for GUI programs, but not for console applications/utilities, which is why it was not obvious.

Any updates to this issue ?

I won't install rosetta compatibility. I will waiting for a native solution for m1. I also waiting for VS for Mac in m1. I hope that Microsoft be fast with this releases.

There is a native prerelease already here https://github.com/OmniSharp/omnisharp-vscode/releases/tag/v1.24.0-beta1
You need to install it and set omnisharp.useModernNet to true

after install the arm version, it's been also solved the problem that holding dotnet process with 100% CPU without use.

I've just faced with this issue (Bad CPU type) also on v1.24.4 C# Extension and .net 6 on m1 then I downgraded to v1.24.3 and Omnisharp installed correctly problem solved. I also upgraded to v1.24.4 again and working fine right now. Maybe it's good to check v1.24.4 also.

since we have a native build now, closing this issue


Latency Benchmarking / GC Profiling

It would be interesting to benchmark 95%, 99% and worst-case messaging latencies (i.e. with a simple WebSocket echo client/server) at different message sizes, connection numbers etc. and at the same time do GC profiling.
We should at least do above on Linux/epoll, FreeBSD/kqueue, Windows/IOCP, as well as CPython and PyPy.
GC profiling on PyPy:
<oberstet> fijal: is there any tool to measure/profile/analyze GC activity?
<fijal> yeah
<oberstet> with pypy ..
<oberstet> which?
<fijal> PYPYLOG=log pypy ....
<fijal> and then you can analyze the log
<fijal> with pypy/tool/logparser.py
<fijal> or rpython/tool/logparser.py
<oberstet> thx! will try ..

out of scope (moved to CTS)


503 SSL

This would allow users to be routed to a 503 page if they were previously on a site with HTTPS enabled but was taken offline.
Solves https://github.com/ehazlett/interlock/issues/164

I'm not a fan of forcing a default cert in order to use this.  This can be accomplished with the custom templates.  Closing for now.  Please feel to re-open if you think this should be added.  Thanks!


Mention the integrated terminal in readme

(especially since it's the only reason we have this compilation step)
We could also add a new screenshot for that, too

Where do I learn more about that integrated terminal in the meantime?

@rainabba It's in the bottom of the debugger, in a tab next to the console:

Thanks for clarifying. I look forward to checking it out once I can get ndb running on WSL :/

It's not really clear or documented that you need to press Esc to show this terminal


Added a boilerplate generator template

This PR adds a new template that produces a boilerplate generator project.
The project works and re-generates Apex from Apex to show how to use the visitors and convert types.
It includes tests, snapshots, and lint config.

I don't think we need SourceGenerator but we'll see how it resonates.

I get it, but there are too many footguns without it.
It's easy to ^C/^V methods across visitors and end up troubleshooting methods that never get called. For something simple like adding a closing brace, each visitor needs its own visitXAfter for each X.  There's no single way of doing something at the start/end of a visitor run or with the root node a visitor is starting from. I added onContextBefore|After but I didn't add it for every visitor.
Not writing until every node has been visited also makes it easier to track state as nodes are visited vs assessing beforehand.
Example scenario: I need to add a prefix that depends on children nodes (e.g. in rust, #[derive(Copy,Clone)] but only if every field/variant implements Copy). I can't do that without adding type-specific field walking code in every visit(Struct|Enum|Union)Before method. When the final write is deferred, I can track that state with a boolean updated in the type-specific visitors that I'm already visiting and write at the end.
If there are better solutions to these problems that don't add much additional code, I'll change it.


Deflake operator/gardenlet integration test

How to categorize this PR?

/area dev-productivity
/kind flake
What this PR does / why we need it:
Deflakes operator/gardenlet integration test (example run). The gardenlet resource must be checked before, otherwise the seed is created too quickly, an Gardenlet controller drops the event due to the OperatorResponsiblePredicate.
> stress -ignore "unable to grab random port" -p 16 ./gardenlet.test
5s: 24 runs so far, 0 failures
10s: 48 runs so far, 0 failures
15s: 74 runs so far, 0 failures
20s: 98 runs so far, 0 failures
25s: 123 runs so far, 0 failures
30s: 147 runs so far, 0 failures
35s: 173 runs so far, 0 failures
40s: 198 runs so far, 0 failures
45s: 224 runs so far, 0 failures
50s: 249 runs so far, 0 failures
55s: 253 runs so far, 0 failures

Special notes for your reviewer:
/cc @LucaBernstein @tobschli
Release note:

NONE

/retest-required

Uh! Very nice catch!
/lgtm


user name vs user id

this is current registration page
https://user.patricbrc.org/register

and this is coming new reg page,

I saw in mongo db that some user has "username" and some has "userid". Is this related to this?
Should we call "username" or "user id" ?
All i wanted to say is that we need to be consistent.

here is counts

my opinion would be to keep username
since this is an arbitrary name that the user creates
On Tue, May 1, 2018 at 3:37 PM, hyoo<EMAIL_ADDRESS>wrote:

this is current registration page
https://user.patricbrc.org/register
[image: image]
https://user-images.githubusercontent.com/1236467/39489937-c2b2b7d6-4d4c-11e8-85ab-9b2d3d30efac.png
and this is coming new reg page,
[image: image]
https://user-images.githubusercontent.com/1236467/39489959-cfe87850-4d4c-11e8-8dec-a6c979d95dfd.png
I saw in mongo db that some user has "username" and some has "userid". Is
this related to this?
Should we call "username" or "user id" ?
All i wanted to say is that we need to be consistent.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/PATRIC3/patric3_website/issues/1968, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AMuN2GrY80dUbxWz87rd80zXYKG7lmzjks5tuLl1gaJpZM4TuZGT
.

--
Josh Sherman
https://web-jam.com
https://www.linkedin.com/in/joshuavsherman/
540-494-8035


wire up PoolRows to calc Fee APR, liquidity, network, and user balances (#9)

Notice
Before submitting a pull request, please make sure you have answered the following:

[x] Have you followed the guidelines in our Contributing guide?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[x] Do all new and existing tests pass? Does the linter pass?

Pull Request Type

[x] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[x] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[ ] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)
#9
Description
Wired up PoolRows to calculate their own APR, liquidity, network, rewards and user balances.
Testing
Please outline all testing steps

Pull branch locally and run yarn to install new deps
run yarn start to launch server locally
type in browser http://localhost:3000/fox-farming
verify working on your end

Screenshots (if applicable)

closing as we merged in here, thanks for your contribution https://github.com/shapeshift/foxfarm/pull/34

Closing in favor of https://github.com/shapeshift/foxfarm/pull/34

closing as we merged in here, thanks for your contribution #34


Obsolete documentation

This document describes few steps not available on Azure portal. It has to be either removed or at least get a very fast review  . . . actually better try to use an auto-documentation system ;) like OpenSource apps do for instance. What it is described in here cannot be used.
This isn't the only incongruence between the Azure Portal, the Documentation and the $$$ paid Video Tutorials I have found around . . . . I wonder how people can make use of this platform with misleading documentation/tutorials.

@TenZeroOne Thank you for your feedback! Since this channel is for driving improvements towards MS Docs, could you provide the URL of the specific documentation that your feedback is applicable to? That way, we are able to make sure your feedback is addressed by the right team.

@TenZeroOne, Just checking to see if you have had a chance to see our response above. Please provide the Azure Doc URL for which this feedback is applicable to.


[Gssoc23] (Frontend projects) Pizza Corner

Describe the Feature you want to add
I want to a add a footer to this website Pizza Corner

Expected behavior
A footer with aboutUs and contact links

Screenshots (optional)

Additional context (optional )

Hi mentors please assign this issue to me under GSSOC'23. I  want to make footer of this website ,fully responsive with hovering effect.

plz assign this issue to  me I will make the footer fully responsive and attractive with hovering effect``
I  have made this,it is fully responsive

I have made this footer it is fully responsive with hovering effect.Respected mentors plz assign this issue to me


⚠ ClamAV has degraded performance

In 10fe860, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 68 ms

Resolved: ClamAV performance has improved in 99b31bf.


Revert "Delete manifests/a/AList/AList/3.17.0 directory"

Reverts microsoft/winget-pkgs#189443
Microsoft Reviewers: Open in CodeFlow

URL: https://github.com/alist-org/alist/releases/download/v3.17.0/alist-windows-386.zip
Status Code: 200
(Automated message - build 897)


doc: replace variables, universes' syntax in doc comments

It's deprecated in favour of variable; likely a leftover from the port.
Also replace universes, which is invalid now.

Oh, indeed - thanks for pointing this out. I have added them now.
bors r+


Make sure that the disk image exists.

#3 No message at all informed me why the program never opened.
It turned out that I have an old disk image pointing to an external USB that is not connected.
It is not enough to only check if the directory exists.
// I was going to throw the app in the bin but became somewhat curious.

// I was going to throw the app in the bin but became somewhat curious.

Thanks for your contribution and curiosity. I created this tool for my personal usage originally, in a quick and dirty way of course. It definitely didn't handle some corner cases correctly.


Heartbeat on static images

If the display is static, it is hard to tell if everything is functioning.
it would be handy (maybe?) to be able to enable something dynamic that can be checked for.  maybe even 1 pixel, or small block in the corner that pulses.

Fixed.

The HDMI2USB-jahanzeb-firmware is no longer under development.
All active development is now on the HDMI2USB-misoc-firmware which supports both the Atlys and Opsis boards and has loads of other new features!


Reflect dynamic components / type registrations for dynamic types

What problem does this solve or what need does it fill?
Components are not restricted to Rust types, rather they are opaque blobs of data identified in a world via ComponentId.
Reflect is not restricted to Rust type and provides dynamic introspection of otherwise opaque data.
However, TypeRegistration (and TypeInfo) is tied to Rust types. This means it's impossible to register reflection for dynamic components, even when you have a Reflect implementation available.
What solution would you like?
Don't require TypeId for TypeRegistration & TypeInfo.
Type registrations need to be identified by a different id, such as a type path.
What alternative(s) have you considered?
Keep restricting reflection to static components.

This was actually recently discussed to an extent on Discord. Relying on TypeId doesn't just limit our usage of dynamically defined types, it also makes hot-reloading a bit more complicated as well.
We should probably consider relying on TypePath for stable identification, and possibly a pre-computed hash of that value for performance-critical flows.


Found a bug

I'm having a problem with this.

:D

This is me trying out automatically opening up issues when they occur in sentry. I'll be making some more issues to test this so let me know if this bothers you :)


Post: Method's Arguments Part 1

Wow! A lot of information and examples, great! Some spelling and grammar suggestions. Also, what is your plan for presenting this as a series? Since other blogs might come in between? The titles tying it together?

I'll name the 3 posts "Method's Arguments Part X" and when I write a new one I'll edit the previous to add the link of the next one so it's easier to go back and forth between them.


IR Scanner + Slayer fly-wire turns the screen all red

When using the fly-wire rocket on the Slayer, the IR Scanner gets unequipped. This is normal, but the effect won't be disabled and it'll apply to everything, including menus and other levels.
Also unrelated question - should we report all the texture issues we see or are they all expected to be broken due to the mipmap calculation not working?
https://github.com/fgsfdsfgs/perfect_dark/assets/34986384/626daa7a-dbec-481a-b311-73f35cc98987

Confirmed fixed


Dropdown update: class shuffle

Currently, the top-aligned and right-aligned Dropdown components rely on a specific html structure for the css selectors to apply the necessary styles. For example, the following selector requires the menu to be an immediate child of the dropdown wrapper:
.pf-m-align-right > .pf-c-dropdown__menu
But with recent updates to the dropdown (https://github.com/patternfly/patternfly-react/pull/815), the html structure has been modified and breaks this selector.
After chatting on the #css-army channel in slack, the recommendation is to move the modifier classes to the menu element, so that the selector is not dependent on html structure.
For example, if we update the selector to be this:
.pf-m-align-right.pf-c-dropdown__menu
Then we can move the modifier class to this element:
<div class="pf-c-dropdown__menu pf-m-align-right">
These updates should be made for the following classes:

pf-m-align-right
pf-m-align-top

https://github.com/patternfly/patternfly-next/pull/838 merged


Tor Proxy With cloudflare-scrape

Hi,
Can you give me instruction how to user Tor with cloudflare-scrape ?
I had some example PhantomJS with Tor but don't know how to use tor with cloudflare-scrape.
Many thanks for considering my request.

Hey,
From the main readme file:

get_tokens and get_cookie_string both accept Requests' usual keyword arguments (like get_tokens(url, proxies={"http": "socks5://localhost:9050"})). Please read Requests' documentation on request arguments for more information.

The answer to your question is to proxy all requests through Tor before hand, using Python's Requests. From what I can read, Tor provides a Socks5 interface so it should be trivial to do.

I found a more clean way to set proxy.
import cfscrape
import json

scraper = cfscrape.create_scraper()
scraper.proxies = {"http": "socks5://<IP_ADDRESS>:9050", "https": "socks5://<IP_ADDRESS>:9050"}

data = scraper.get("https://httpbin.org/get").content
parsed = json.loads(data)
print(parsed['origin'])


[Snyk] Fix for 1 vulnerabilities

Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.
Changes included in this PR

Changes to the following files to upgrade the vulnerable dependencies to a fixed version:

package.json
package-lock.json

Vulnerabilities that will be fixed
With an upgrade:

Severity
Priority Score (*)
Issue
Breaking Change
Exploit Maturity

44/1000  Why? Confidentiality impact: None, Integrity impact: Low, Availability impact: None, Scope: Unchanged, Exploit Maturity: No data, User Interaction (UI): None, Privileges Required (PR): None, Attack Complexity: High, Attack Vector: Network, EPSS: 0.01055, Social Trends: No, Days since published: 2, Reachable: No, Transitive dependency: Yes, Is Malicious: No, Business Criticality: High, Provider Urgency: Medium, Package Popularity Score: 99, Impact: 2.35, Likelihood: 1.86, Score Version: V5
Cross-site Scripting (XSS) SNYK-JS-COOKIE-8163060
No
No Known Exploit

(*) Note that the real score may have changed since the PR was raised.

Commit messages

Package name: cookie-parser
    The new version differs by 12 commits.

5d61e1e 1.4.7
ccf1f54 deps<EMAIL_ADDRESS>(#116)
429cfd4 ci: Use GITHUB_OUTPUT envvar instead of set-output command (#100)
ca4c97e ci: fix errors in ci pipeline for node 8 and 9 (#104)
97bdf39 ci: add support for OSSF scorecard reporting (#103)
e5862bd build<EMAIL_ADDRESS>f0688d2 build<EMAIL_ADDRESS>44ec541 build<EMAIL_ADDRESS>695435a deps<EMAIL_ADDRESS>f66e7e1 build<EMAIL_ADDRESS>05e40b1 build<EMAIL_ADDRESS>bc1d501 build: use<EMAIL_ADDRESS>for Node.js 6.x

See the full diff

Package name: express
    The new version differs by 219 commits.

8e229f9 4.21.1
a024c8a fix(deps<EMAIL_ADDRESS>7e562c6 4.21.0
1bcde96 fix(deps<EMAIL_ADDRESS>(#5946)
7d36477 fix(deps<EMAIL_ADDRESS>(#5951)
40d2d8f fix(deps<EMAIL_ADDRESS>77ada90 Deprecate `"back"` magic string in redirects (#5935)
21df421 4.20.0
4c9ddc1 feat: upgrade to<EMAIL_ADDRESS>9ebe5d5 feat: upgrade to<EMAIL_ADDRESS>(#5928)
ec4a01b feat: upgrade to<EMAIL_ADDRESS>(#5926)
54271f6 fix: don't render redirect values in anchor href
125bb74<EMAIL_ADDRESS>(#5902)
2a980ad<EMAIL_ADDRESS>(#5781)
a3e7e05 docs: specify new instructions for `question` and `discuss`
c5addb9 deps<EMAIL_ADDRESS>(#5603)
e35380a docs: add @ IamLizu to the triage team (#5836)
f5b6e67 docs: update scorecard link (#5814)
2177f67 docs: add OSSF Scorecard badge (#5436)
f4bd86e Replace Appveyor windows testing with GHA (#5599)
2ec589c Fix Contributor Covenant link definition reference in attribution section (#5762)
4cf7eed remove minor version pinning from ci (#5722)
6d08471 📝 update people, add ctcpip to TC (#5683)
61421a8 skip QUERY tests for Node 21 only, still not supported (#5695)

See the full diff

Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Cross-site Scripting (XSS)

🎉 Snyk hasn't found any issues so far.
✅ security/snyk check is completed. No issues were found. (View Details)
✅ license/snyk check is completed. No issues were found. (View Details)


Icons Don't scale

if you download svg files and use them as icons...

they don't scale down
I basicaly downloaded some svgs from game-icons and well that is how it looks

@pietru2004 this is a Godot bug - icon .svgs need to be 16x16 pixels. Try the same with
@icon("my-icon.svg") on custom scenes and you see a terrible surprise.

Erm
1 is there fix on horizon for that ?
2 can't you use/allow people to use expand icon property?
Example from button

or use
set_icon_region or set_icon_max_width ?
Under and above
https://docs.godotengine.org/en/stable/classes/class_treeitem.html#class-treeitem-method-set-icon-modulate

@pietru2004 feel free to raise a pull request!

I would, but my problem is school year that just started and I am in final class
I can try, but I can't promise anything

I tried it out and well

20 seams as good amount of max pixels

this is 24

I think it could be selectable between 16 and max 28/32 pixels in steps of 4

I think it would be the same level of ease of base implement as
https://github.com/bitbrain/pandora/discussions/107
https://github.com/bitbrain/pandora/issues/110

@pietru2004 you may also need to take editor scale into account.

I guess it could use editor_scale*desired_pixel_size, so .5 would give 8 pixels and 2 would 32 if input is 16... I would ned to look for way to get interface scale

so from what I see there is EditorPlugin.get_editor_interface.
And on that you can run get_editor_scale()

I got once way to use interface to generate mesh preview...

so it could be like ei.get_editor_scale()


Rescue Faraday::ConnectionFailed

Attempts to fix #152

Adds a new error class to re-raise Faraday::ConnectionFailed as OAuth2::ConnectionFailed

I need to figure out why CI isn't running...


SECOPS-2268: Add Gitleaks to CI

Motivation / Implements
This PR adds the necessary files to configure Gitleaks to run on PRs on this repo. The Apollo Security team uses Gitleaks to test our repositories for secrets.
Once this is accepted and merged, the Security team plans to make a passing Gitleaks check a requirement for PRs to merge into this repo. This will prevent secrets from being introduced to our repos.
In the event that a secret is detected on a repo, the CI job will add a comment to the PR associated with the detection to provide instructions on how to properly resolve the detection. Additionally, if a secret is detected, the Apollo Security team will be notified so that we can be available to assist in resolving the detection.
If maintainers reviewing this PR have questions, please see this Apollo-internal Slack link.
Changed

Added .circleci/config.yml to this repo. This file contains appropriate configuration to enable Gitleaks as a CI check.

If this doesn't belong in this repo, please let me know!

@peakematt this repo doesn't see much activity but it doesn't harm to add this. LGTM


Update project edit fields to title case

#2472  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @nickgraz and the rest of your teammates on  Graphite


V2 events

made ghost buttons
event card and event page made
rm updated a bit
2 urls of index page shifted to urls.js

@vinaypuppal can you once check if the implementation of styled components is correct in event-card. Also i am unable to stretch the right column.

@M-ZubairAhmed You need to specify height explicitly for it to stretch.

@M-ZubairAhmed  Did you complete view more button functionality?

its open for review

@M-ZubairAhmed

[ ] Let the Event title be regular weight. And color #374355

[ ] the secondary text(location, date etc) and their icons shall be #8393A7

[ ] The Headings "upcoming events" & "Recent events" shall be bold and same font size of the events title.


Migration ignores new columns when also dropping existing columns (SQLite)

Laravel Version: 7.12.0
PHP Version: 7.4.5
Database Driver & Version: SQLite

Description:
New columns are not added to the table when the migration both creates a new column and drops the existing one. After splitting those changes to separate migrations the problem no longer exists.
This issue seems to be SQLite related as with PostgreSQL it works fine.
Steps To Reproduce:

Create a migration for the table.
Add the second migration with schema change that adds a new column and drops an existing column.
The existing column has been dropped but a new column is not present in the table.

Don't do that with SQLite. It doesn't support a variety of operations.

Workaround (for anyone who finds this):
Just wrap the deletion in a separate block:
e.g. this:
Schema::table('users', function (Blueprint $table) {
    $table->dropColumn('columnToRemove');
    $table->string('columnToAdd');
});

Would become this:
Schema::table('users', function (Blueprint $table) {
    $table->dropColumn('columnToRemove');
});

Schema::table('users', function (Blueprint $table) {
    $table->string('columnToAdd');
});


Origin crashes a server

Greetings. I would like to ask if there is any reason that causes this origin to crash a server?
When the owner put the file in, the server refused to start up, with the connection being reset by peer I believe were the exact words. Would there be any reason this origin would stop a server from starting up? Perhaps another datapack has some of the same words as another which could cause confusion or something similar? I am not very familiar with the code myself so I wondered if you would know what could cause it.
It was a 1.19.2 server with quite a handful of mods however they are not at fault, tried it on a single player world and it worked fine there. In the origins discord someone said they also had the same issue, so I’m guessing something in the code doesn’t like servers, hah.
If you get back, thank you very much! I would really appreciate it since I absolutely love this origin. Have a good day/night!

I have noted that there has been an Apoli update which changes projectile damage to projectile_condition, perhaps that has been used in deflect? Otherwise damage sources have been changed to damage types, so maybe that's it. I hope you find what may cause the issue soon!

I really don't know what could cause this, but it would not be related to the apoli update. I suspect its another datapack on the server causing issues

Well that sounds about right, weird how it affected another person though, coincidence perhaps. Ah well, thanks anyway! Enjoy your day


Improve IDE completion

Hhhmm... I'm not sure the extra dependency is worthwhile considering the few benefits it brings. I really prefer to use $this->assert. I find it clearer and it is more convenient for people familiar with PhpUnit.

As I've mentioned in IRC previously, the trait is to be considered in the context of the class composing it, which means calling assertion methods directly on $this is perfectly valid and readable.
If your IDE is complaining about the file, add an exclusion for it.

My IDE offers autocompletetions and suggestion where before not. Scrutinizer-CI and other type checkers tools are fine with this.
This was already done on zend-inputfilter and there was not problems. I don't understand why reject this.
Both ways are valid but this offers a noticeable gain.

What is the gain? I don't see any expect it makes it confusing because I don't know why this assert is here while it's as easy to type $this-> :)


7zip - [tool] feature build missing?

default 7zip build is [core] and builds only the 7zip.dll
I don't see a way to build the 7zip.exe - no [tool] feature is present

The 7zip under ports is only provided for binary .dll files, and vcpkg itself provides tools through vcpkg_find_acquire_program(7Z).cmake https://github.com/microsoft/vcpkg/blob/70992f64912b9ab0e60e915ab7421faa197524b7/scripts/cmake/vcpkg_find_acquire_program(7Z).cmake


Unknown assertion failed in FStar.Math.Lemmas

Hello all,
Generating the .checked file for FStar.Math.Lemmas in ulib fails with  Unknown assertion failed (SMT solver says: unknown because (resource limits reached). I tried changing the fuel limits in the file but it still fails. I am using the  master branch.

Hello,
Do you have the right version of z3?

@jamesbarne: Where you can get "the right" version of Z3 here: https://github.com/FStarLang/binaries/tree/master/z3-tested

I just updated my Z3 but it still fails.
$ z3 --version
Z3 version 4.8.5 - 64 bit

You seem to be using an old version of F*. Please only report issues if they appear with the master branch of F*, or at least a recent binary releases here: https://github.com/FStarLang/binaries/tree/master/weekly

Hi, I tried a clean build for both z3 and FStar.
z3: z3-4.8.5-x64-win.zip from https://github.com/FStarLang/binaries/tree/master/z3-tested
FStar: fstar_201906260825_f3f7d15cfb_Windows_x64.zip and fstar_201906221639_4a14e6dbff_Windows_x64.zip from https://github.com/FStarLang/binaries/tree/master/weekly
Both failed when verifying FStar.UInt.fst and FStar.Math.Lemmas.fst.

Thanks for checking. I can reproduce this, I think. I suppose you're running F* like this:
./bin/fstar.exe ulib/FStar.Math.Lemmas.fst

which fails for me with:
$ ./bin/fstar.exe ulib/FStar.Math.Lemmas.fst
/home/guido/r/fstar/master/ulib/prims.fst(0,0-0,0): (Warning 241) Unable to load /home/guido/r/fstar/master/ulib/prims.fst.checked since checked file /home/guido/r/fstar/master/ulib/prims.fst.checked does not exist; will recheck /home/guido/r/fstar/master/ulib/prims.fst (suppressing this warning for further modules)
ulib/FStar.Math.Lemmas.fst(361,2-375,4): (Error 16) Unknown assertion failed; The SMT query timed out, you might want to increase the rlimit
Verified module: FStar.Math.Lemmas (27989 milliseconds)
1 error was reported (see above)

and for FStar.UInt.fst:
$ ./bin/fstar.exe ulib/FStar.UInt.fst
/home/guido/r/fstar/master/ulib/prims.fst(0,0-0,0): (Warning 241) Unable to load /home/guido/r/fstar/master/ulib/prims.fst.checked since checked file /home/guido/r/fstar/master/ulib/prims.fst.checked does not exist; will recheck /home/guido/r/fstar/master/ulib/prims.fst (suppressing this warning for further modules)
/home/guido/r/fstar/master/ulib/FStar.List.Tot.Properties.fst(1010,2-1010,136): (Warning 271) Pattern uses these theory symbols or terms that should not be in an smt pattern:  Prims.eq2 Prims.eq2
/home/guido/r/fstar/master/ulib/FStar.Seq.Properties.fst(939,2-939,49): (Warning 271) Pattern uses these theory symbols or terms that should not be in an smt pattern:  Prims.op_Addition 1
/home/guido/r/fstar/master/ulib/FStar.Seq.Properties.fst(958,2-958,33): (Warning 271) Pattern uses these theory symbols or terms that should not be in an smt pattern:  0
ulib/FStar.UInt.fst(632,8-632,66): (Warning 271) Pattern uses these theory symbols or terms that should not be in an smt pattern:  Prims.eq2 Prims.op_Modulus 0
ulib/FStar.UInt.fst(632,8-632,66): (Warning 271) Pattern uses these theory symbols or terms that should not be in an smt pattern:  Prims.eq2 Prims.op_Modulus 0
ulib/FStar.UInt.fst(633,8-633,23): (Warning 271) Pattern uses these theory symbols or terms that should not be in an smt pattern:  Prims.eq2 Prims.op_Modulus 0 (see also ulib/FStar.UInt.fst(632,8-632,66))
ulib/FStar.UInt.fst(633,8-633,23): (Warning 271) Pattern uses these theory symbols or terms that should not be in an smt pattern:  Prims.eq2 Prims.op_Modulus 0 (see also ulib/FStar.UInt.fst(632,8-632,66))
ulib/FStar.UInt.fst(651,8-651,61): (Warning 271) Pattern uses these theory symbols or terms that should not be in an smt pattern:  Prims.op_LessThan
ulib/FStar.UInt.fst(651,8-651,61): (Warning 271) Pattern uses these theory symbols or terms that should not be in an smt pattern:  Prims.op_LessThan
ulib/FStar.UInt.fst(652,8-652,22): (Warning 271) Pattern uses these theory symbols or terms that should not be in an smt pattern:  Prims.op_LessThan (see also ulib/FStar.UInt.fst(651,8-651,61))
ulib/FStar.UInt.fst(652,8-652,22): (Warning 271) Pattern uses these theory symbols or terms that should not be in an smt pattern:  Prims.op_LessThan (see also ulib/FStar.UInt.fst(651,8-651,61))
ulib/FStar.UInt.fst(671,8-671,51): (Warning 271) Pattern uses these theory symbols or terms that should not be in an smt pattern:  Prims.op_Subtraction 1
ulib/FStar.UInt.fst(671,8-671,51): (Warning 271) Pattern uses these theory symbols or terms that should not be in an smt pattern:  Prims.op_Subtraction 1
ulib/FStar.UInt.fst(672,8-672,25): (Warning 271) Pattern uses these theory symbols or terms that should not be in an smt pattern:  Prims.op_Subtraction 1 (see also ulib/FStar.UInt.fst(671,8-671,51))
ulib/FStar.UInt.fst(672,8-672,25): (Warning 271) Pattern uses these theory symbols or terms that should not be in an smt pattern:  Prims.op_Subtraction 1 (see also ulib/FStar.UInt.fst(671,8-671,51))
ulib/FStar.UInt.fst(1071,31-1071,33): (Error 16) Unknown assertion failed; The SMT query timed out, you might want to increase the rlimit
Verified module: FStar.UInt (40913 milliseconds)
1 error was reported (see above)

The reason is proof flakyness, the SMT solver is timing out before finding a proof. We keep these files under CI, but there we run them with a different set of options: most importantly we enable hints (--use_hints) and for UInt, we in fact increase the z3 rlimit factor (--z3rlimit_factor 4). The rlimit_factor actually seems unneeded, so I'll remove it.
So, with --use_hints it should work (and be faster).
IMO, we should increase rlimits within those files so this does not happen. And we should probably resume the idea of having a "no hints" CI.

All of ulib/ should now verify in master without hints. But let's leave this open to track that we should have this under CI.

Many projects already assume that ulib can only be verified by the Makefile present in ulib/, and run with --already_cached FStar.
This is a general pattern: a given project A may have per-file options, some voodoo options required to check some files... so it's not generally true that a client of project A can attempt to verify themselves the files of project A.
What was your use-case?  Were you in interactive mode?
Thanks,

@msprotz is right that one shouldn't assume this will "just work". At the same time, there is no harm in making our important proofs (e.g., ulib) a bit less flaky by making sure they still work without hints, or in removing the amount of voodoo options we pass from Makefiles.

And speaking of voodoo options, I have no clue why some of our main Makefiles add --z3cliopt 'timeout=600000' everywhere. What is this supposed to do? Aren't we using rlimits now? :)

And speaking of voodoo options, I have no clue why some of our main Makefiles add --z3cliopt 'timeout=600000' everywhere. What is this supposed to do? Aren't we using rlimits now? :)

I think that was added when we switched Z3 versions to make sure CI came back if a proof started taking ages. It should be fine to remove it now. The rlimit is still the way to control resources, this is just a fail-safe.
I agree that we should reduce, ideally completely remove, the voodoo options passed throughout Everest.

What was your use-case?  Were you in interactive mode?

I was actually running my own Makefile that is verifying the F* ulib to generate the .checked files for eventual OCaml/C extraction, where it failed with the FStar.Math.Lemma file.


Clear warnings during build

Currently there are 6 warnings during project build. It would be nice if they all got cleared :)

On it!


Atom remote access sometimes only saves to temporary local files without changing the real remote files.

I'm not sure if this is the right place to complain about remote access issues. In general, I really appreciate that if I lost connection to remote or accidentally shut down Atom, it preserves my open tabs. However, there is this issue where if you leave remote files open on Atom when you shut it down, it opens them up from the local temporary files before you specify where you want to remote access, and then do not connect those open local files with the remote ones.
This has been a real problems for me as I have, on several occasions, thought that I was accessing remote files, when I was actually saving to local files, which made debugging programs that frequently crash and require restarting more confusing for me than usual. I also once lost a month of work when I opened a remote file and it overrode the temporary local file I didn't realize I was actually saving to.
I understand that this could be an issue if users modified the remote files through a different remote access in-between remote Atom sessions. However, is there any way to make temporary files sync with identical remote versions, and prevent temporary files from being overridden by remote files if their content differs?

I think this is a duplicate of https://github.com/h3imdall/ftp-remote-edit/issues/60.
In general, that repository is the right to place for these kinds of reports, so I'll close this one here.


Set the version field automatically during serialization

Currently the version field needs to be set explicitly which is a source of potential bugs (as experienced in our product :) )

@wokalski does this mean we should not require to have a version field in the ATD schema?

Good question!!! I was thinking about this. The nice thing about the current setup is that you can use those files in vanilla atd.


x/sys: FreeBSD 11 builders on release-branch.go1.17 broken since CL 415714

CL 415714 regenerated x/sys with compatibility only for FreeBSD 12 and higher.
However, the FreeBSD 11_4 builders are still configured to run the repo on release-branch.go1.17, and are now failing on that branch.
We should either fix x/sys to restore compatibility until release-branch.go1.17 is no longer being maintained, or explicitly disable this repo on those builders.
(attn @golang/freebsd, @golang/release)

FreeBSD 11.4 is EOL since September 30, 2021. release-branch.go1.19 is ws already branched out. I wouldn't like to revert if 1.17 is about to be dropped.

Sounds good. Want to send a CL to disable those builders for the x/sys repo?


Permit WMI Access

Added data source to obtain DC CIDRs from Vault
Added local var to extract CIDRs
Updated SG rules to permit the required access
Above updates performed for these TF groups:
staging-windows-virtual-machines
live-windows-virtual-machines
live-windows-security-groups
Resolves: INC0336618

Hi Wayne,
thanks for that.
Any chance you could have a look at INC0336193
If there's no one in to approve it, I can do the approval ?
Cheers
Aidey
From: Wayne Jenkins @.>
Sent: 21 March 2022 09:27
To: companieshouse/aws-windows-infrastructure-terraform @.>
Cc: Adrian Davey (IAM) @.>; Comment @.>
Subject: Re: [companieshouse/aws-windows-infrastructure-terraform] Permit WMI Access (PR #38)
*** This email came from an external source. Please be cautious. ***
Merged #38https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fcompanieshouse%2Faws-windows-infrastructure-terraform%2Fpull%2F38&data=04|01||da94a3cf32b740f6303408da0b1cf9ab|e6acfe5e7f2a455a9d85ecf93371f601|0|0|637834516322836002|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=a5ad2IRMYdTkAjsA14g0khY3lPc%2BG5NVSZ3slkPiw4M%3D&reserved=0 into main.

Reply to this email directly, view it on GitHubhttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fcompanieshouse%2Faws-windows-infrastructure-terraform%2Fpull%2F38%23event-6273899141&data=04|01||da94a3cf32b740f6303408da0b1cf9ab|e6acfe5e7f2a455a9d85ecf93371f601|0|0|637834516322836002|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=sGAL%2Fuxjnp5yDvza0qvsFSg%2BlX99tbFsaSVz%2Biz4qLs%3D&reserved=0, or unsubscribehttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAUR3YHFNXR2IJBB2Y6FBE23VBA6GTANCNFSM5Q6J5F5Q&data=04|01||da94a3cf32b740f6303408da0b1cf9ab|e6acfe5e7f2a455a9d85ecf93371f601|0|0|637834516322836002|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=lsOQ0CgZBAWa75pG56St4ExAzKZvE0dot05IHbcfOoM%3D&reserved=0.
Triage notifications on the go with GitHub Mobile for iOShttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04|01||da94a3cf32b740f6303408da0b1cf9ab|e6acfe5e7f2a455a9d85ecf93371f601|0|0|637834516322836002|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=757PpOOVntp34EkY5wzfa0EPN96YM3tcOGnbwGfDx3E%3D&reserved=0 or Androidhttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04|01||da94a3cf32b740f6303408da0b1cf9ab|e6acfe5e7f2a455a9d85ecf93371f601|0|0|637834516322836002|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=y5MkwHnlQrVDdJP9oLOA4bdrIhm1gt3g%2Fu1%2BfQnea2s%3D&reserved=0.
You are receiving this because you commented.Message ID<EMAIL_ADDRESS>This message and any attachments are intended for the persons named as addressees only and may contain confidential information. In addition they may be protected by copyright. If you receive it in error, notify us, delete it and do not make use of or copy it. You must not copy, disseminate or otherwise distribute or publish this message, except for the purposes for which this message is intended, without our consent. Please note that this e-mail has been created in the knowledge that Internet e-mail is not a 100% secure communications medium. We advise that you understand and accept this lack of security when e-mailing us. For company information, guidance and how to file documents online, please see our website www.companieshouse.gov.uk. For more details on how your personal data is handled by Companies House, please see our privacy policy: https://www.gov.uk/government/organisations/companies-house/about/personal-information-charter


Add spawn protection in helm chart value

Hello! This PR adds spawn-protection value to be editable on Helm chart.
The original feature is based on https://github.com/itzg/docker-minecraft-server/#set-spawn-protection

Sorry, there was another PR ahead of yours and you'll need a small merge and resolve...and bump the version one more time.

I think it's a better idea to change the release number you update the version tag not on master...

I think it's a better idea to change the release number you update the version tag not on master...

The current strategy is annoying in rare cases like what you experienced, but seems to be standard practice.
@billimek any thoughts to add?

@itzg Hi. I updated the version. Can you merge it?


Update needed to icon sizes

The current icon sizes are:
$pf-global--icon--FontSize--sm: pf-font-prem(10px) !default;
$pf-global--icon--FontSize--md: pf-font-prem(18px) !default;
$pf-global--icon--FontSize--lg: pf-font-prem(24px) !default;
$pf-global--icon--FontSize--xl: pf-font-prem(54px) !default;
source https://github.com/patternfly/patternfly-next/blob/master/src/patternfly/sass-utilities/scss-variables.scss
The are some components that use icon sizes between sm & md, such as the date picker (16px and 14px), chip (12px), popover (11px), etc.
We need to either
a) determine a new sm size (and rename 10px to xs)
b) reduce md to 16px
c) keep existing sm and md sizes and update components to comply
Thank you!
@mceledonia @kybaker @mcarrano @LHinson @rachael-phillips @gdoyle1
Decisions:

[x] textbox icons --> 18px
[x] chips --> 10px, times (no circle)
[x] popovers --> 18px
[x] breadcrumbs --> 10px
[x] modal --> 18px
[x] masthead --> 18px
[x] filters --> 18px
[x] progress bar status icons --> 18px

Thanks for filing! @mceledonia is working on icon sizes right now I believe. Michael, are there any relevant issues already open for this effort?

I think the 18 is a bit big but 10 is too small. This would apply to other icons in a text field like search magnifying glass and the time clock.
@mceledonia  @kybaker

@rachael-phillips This relates directly to what I was working on, our next steps are to adjust any icon sizes that don't match our variables in the sketch library and we will be all set! Sticking with icon font for now rather than worrying about transferring to SVG, as icon font works just fine and the switch would not be worth the time right now.

@ajacobs21e Let's go with 18 for now since we want to try not introducing a fifth variable, and 10 just looks funny 😁

Chip
@mceledonia @kybaker

Popovers

Breadcrumbs
@mceledonia

Modal is already built with an 11px close icon on https://pf4.patternfly.org/components/ModalBox/examples/.
attaching examples with it at 10px and 18px. @mceledonia

Masthead icons are 16px... pics from Gina coming soon

@ajacobs21e  [CHIP]
This is awesome
For the chip - this is actually the same problem the Red Hat logo had from being contained inside a circle. My proposal is we switch the icon to the plain X (no circle) and at 10px it should look the proper size.

@lboehling [MODAL]
I say 18, it feels a little big but it is definitely better than 10

@ajacobs21e [BREADCRUMBS]
10 for sure!

@ajacobs21e [POPOVERS]
This one is tough and I think half the problem is the misalignment with the text. I think 18 will feel better if we can get it to be realigned with the text... Do we know why it is misaligned?

Chip with 10px naked X

It is also a little difficult to get a sense of scale since we aren't seeing these in context. I think we can make general decisions but definitely see how they feel in the larger context of a screen @ajacobs21e @gdoyle1 @lboehling

@mceledonia yeah I zoomed out before taking the screenshot because I though the same thing but it does look much better at 100% zoom instead of 600%.
I also looked at the popover and it has spacers overlapping so I'll chat with you offline about that. But yes I agree that 18px works better there too (and then matches the modal)

@mceledonia Masthead icons

@gdoyle1 [MASTHEAD]
Let's go 18 there!

Updated all icon sizes in current designs and deleted the old random px sized icons out of icons list. I think this should solve everything! Probably can close this out

@gdoyle1 @ajacobs21e @lboehling awesome work! thanks for taking this on and crushing it.

@mceledonia thanks for answering our 400 questions!

@mceledonia @ajacobs21e found another inconsistency while working on progress bars: icons are 16px on https://pf4.patternfly.org/components/Progress/examples/. Updating to 18px in sketch library.

@mceledonia Carets for dropdowns are 16px, but i've been doing them with 10px - thoughts?
Web Example:

Mine:

@mceledonia overflow arrows - seems similar to breadcrumbs situation, they are around 16px on inspect, but i've made them 10px - thoughts?
Example:

Mine:

@mmenestr I think your screenshot looks good! Are you measuring with the icon font size or the true icon size? When I change the icon font to 10px it gets super tiny, a lot smaller than what you have there. I think what you have looks good though.

@mceledonia not sure if you're referring to inspect or on sketch. But for inspect the font size was 16px, but the icon measurements were 8x16px (which is what I was looking at). On sketch, I just chose the icons / small / angle-left and angle-right version of the icon, so 10px sizing and that's what it looks like!

@mceledonia @gdoyle1 @mmenestr Is there still an issue here? Can this one be closed out?

@mcarrano This was mostly solved in the design kit but will also be solved through the larger icon effort so I think we can close this.


interlex uberon deduplication

@tmsincomb
http://uri.interlex.org/base/ilx_0737716 was not mapped to http://uri.interlex.org/base/ilx_0105730 during import of mesh. There are a number of other cases similar to this. The ilx id for the duplicate mesh terms should be the one removed/redirect.

OntId('ILX:0736514')
was not mapped to
OntId('ILX:0109190')

OntId('ILX:0723821')
was not mapped to
OntId('ILX:0100216')
this one is understandable, it is missing the 'duh' synonym


[ZEPPELIN-5946][FOLLOWUP] Use Spark 3.4.1 in default

What is this PR for?
Followup ZEPPELIN-5946, Use Spark 3.4.1 in default
What type of PR is it?
Improvement
Documentation
Todos

[ ] - Task

What is the Jira issue?
ZEPPELIN-5946
How should this be tested?
Pass GA
Screenshots (if appropriate)
Questions:

Does the license files need to update?
Is there breaking changes for older versions?
Does this needs documentation?

Thx for the follow-up.

The failed Kotlin test seems to be https://youtrack.jetbrains.com/issue/KT-38325
I suppose we must upgrade Kotlin first to address it. Unfortunately, the Kotlin interpreter uses a very old version (1.3.x, the latest is 1.9.x), and couple with lots of unstable APIs.

@pan3793
Is this PR ready for review?

@Reamer not yet, I need to revert some changes.
Sorry, I'm quite busy these days, will find the time to finish it ASAP.

The profiles scala-2.11 and scala-2.12 defined at root pom.xml seems only affects the livy module's test, if so, do we really need to maintain such profiles? Why not hardcode in livy/pom.xml(seems livy is not much active, the latest version only support Scala 2.11)

cc @Reamer

The profiles scala-2.11 and scala-2.12 defined at root pom.xml seems only affects the livy module's test, if so, do we really need to maintain such profiles? Why not hardcode in livy/pom.xml(seems livy is not much active, the latest version only support Scala 2.11)

The profiles scala-2.11 and scala-2.12 set the properties scala.version and scala.binary.version.
I see accesses to these properties in the Zeppelin Display Module and Zeppelin Distribution Module. Unfortunately, I don't currently know why Scala dependencies are needed in the Zeppelin Distribution Module.
https://github.com/apache/zeppelin/blob/85bb3b4ca2d4a5c79194f8c12a90b732d777ccc5/zeppelin-display/pom.xml#L34-L55
https://github.com/apache/zeppelin/blob/85bb3b4ca2d4a5c79194f8c12a90b732d777ccc5/zeppelin-distribution/pom.xml#L49-L73

Oh, I missed the Zeppelin Display Module(it does not appear when I do global search using IDEA), it leverages the scala-xml to build AngularElem, that's why scala is required

Emm, is "Zeppelin Display Module" only used by "Zeppelin: Spark Interpreter"? If so, I suppose the Zeppelin core becomes scala free if we can merge this module into "Zeppelin: Spark Interpreter"

As far as I know, the Zeppelin display module is only used by the Spark interpreter.
If it is possible we can merge the Display Module to the Spark Interpreter Module.

As far as I know, the Zeppelin display module is only used by the Spark interpreter.
If it is possible we can merge the Display Module to the Spark Interpreter Module.

Thanks for information, would like a try in another PR.
I limit this PR' scope to the spark related stuffs, CI already passed, and the last commit only touch the docs

I will merge this pull request on Friday as long as no other comment is received.


SyntaxError since last update (25/11/23)

Hi !
Since the last update, i've got an issue on reload.
SyntaxError: unterminated string literal (detected at line 58)
Traceback (most recent call last):
File "/app/main.py", line 10, in
from mqtt.MqttClient import MqttClient
File "/app/mqtt/MqttClient.py", line 13, in
from sensors.Light import Light
File "/app/sensors/Light.py", line 58
'state_value_template: "{{ 'ON' if value | int(0) > 0 else 'OFF

Hello,
Same issue with last update

Hello Dears,
Same, I went back to the previous image

Hello,
There's missing a quote between state_value_template and : in #145 line 58.
See #157

Thanks for the fix; the PR has been merged.

Hello,
Sorry, on my side the issue is still present after pulling latest image :/

Now this is a missing comma 😤 ; I fix it

Thanks for the feedback; I'll build a new release with fixes asap.


Admin Navigation vs. Contributor Navigation

in the footer of every page on OldCantus, I see "Admin Navigation" rather than "Contributor Navigation", which is what I see on NewCantus (On OldCantus, I'm accessing the website using an account with Contributor, Proofreader and Editor permissions; I haven't been able to access the website with an account with different permissions to see whether this changes). Under "Admin Navigation" are listed the following links:

My sources
Add Source
List of indexers
Import feasts from Cantus Index
Update feasts from Cantus Index
Publish unpublished chants
Generate CSV - all published sources
Image links
Source index
Update differentiae

It would be worth someone with access to an account with different permissions trying to verify this; I've not been able to access the accounts that were created for me that should have fewer permissions.

The contents of the navigation have been decided by issues #225 and #226. As for the name: @jwang44 what would you like to call it?

I tested with a single account with all three of Contributor, Proofreader and Editor permissions, not with separate accounts.

isn't an admin a specific category of user (like a Debra) who presumably has different things they should see than a proofreader or an editor? unfortunately I don't remember what this was called when I was a mere Contributor.


[FLINK-2092] Adjust documentation for print()/collect() semantics update

Thanks so much for updating the docs and starting the discussion on the ML. If you don't have time to adress my comments, just give your feedback and I can take care of it. :-)

I addressed all your comments. Thank you for the review.

I've merged the change.


"+n more" buttons are disappeared when shriking the window

Check that this is really a bug

[X] I confirm

Reproduction link
https://codesandbox.io/p/sandbox/react-big-calendar-example-forked-zlsbnv?file=%2Fsrc%2Fevents.js%3A16%2C9
Bug description
When make the browser window with smaller size, some of the "+n more" buttons were dispeared from the window.
Expected Behavior
The  number of "+n more" buttons for each date should be kept as same as when viewing them from a bigger window.
Actual Behavior
When I make the window with a smaller size, some of the "+n more" buttons were disappeared.
react-big-calendar version
1.8.0
React version
16.13.1
Platform/Target and Browser Versions
Chrome Version 114.0.5735.90
Validations

[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
[X] Make sure this is a react-big-calendar issue and not an implementation issue

Would you like to open a PR for this bug?

[ ] I'm willing to open a PR

Here is a video about the issue https://www.loom.com/share/0760ead4df2947b98d9d6955226ad9c6


Add plugin for nixpkgs-review

This adds basic support for nixpkgs-review, a tool for testing nixpkgs changes.
nixpkgs-review simply looks for the GITHUB_TOKEN environment variable, so we don't need to peak into any files.
Not sure if this falls into the "Unofficial CLIs are less likely to get accepted at this moment." category. The official nixpkgs documentation references nixpkgs-review here.

Hey @qbit , thank you for your contribution!
As you pointed out, the current focus area of the 1Password Shell Plugins ecosystem is official CLIs.
We are looking into possibilities for accepting smaller projects or homegrown tools, however, this is not currently on our short roadmap. We'll make sure to let you know once this changes!
In the meantime, we'd like to make sure you have a great experience using your locally built plugin! We would love to hear your feedback here or in the Developer Slack workspace 😄
Thank you!

We are also working towards a direction where you could authenticate your own built tools by re-using credential types defined inside shell plugins.  I've noticed that nixpkgs-review is just re-using the GitHub token for authentication, so this feature we are working on (we recurrently referring to it as 'profiles') could really suit your use case! Unfortunately, we don't have an ETA for that. Stay tuned, though!
For the time being I'll be closing this PR.


Security issue detected: G304 (CWE-22)

[insights-results-aggregator-mock/storage/storage.go:105] - G304 (CWE-22): Potential file inclusion via variable (Confidence: HIGH, Severity: MEDIUM)

Already fixed.


Update Tab.js

Passing a functional component throws a warning to the console. Example:
const listElement = (elementProps) => (
<Route
to={elementProps.to}
exact={elementProps.exact}
children={
<li className={elementProps.className + " wfp--tabs__nav-item"}>
<NavLink
to={elementProps.to}
onClick={(_) => setSelectedTab(elementProps.index)}
>
{elementProps.anchor.label}

}
/>
);
...
renderListElement={listEl}
Changelog
Changed
Tab component PropTypes for renderListElement prop.

Hi @thedevelobear thanks a lot for the pull request!

Hi @thedevelobear thanks a lot for the pull request!

Hi @thedevelobear thanks a lot for the pull request! I've changed the base to next. Can you please take a look at the conflicts? Many thanks!

Hi @thedevelobear thanks a lot for the pull request! I've changed the base to next. Can you please take a look at the conflicts? Many thanks!


Support deleting blobs using the Delete key on keyboard

This is a feature request to support the Delete key on the keyboard. Right now deleting blobs is possible by right clicking on a blob and choosing "Delete"

This issue has become stale and is at risk of being closed. The community has 60 days to upvote the issue. If it receives 5 upvotes we will keep it open and take another look. If not, we will close it. To learn more about how we handle issues, please see our documentation.
Happy Coding!

:slightly_frowning_face: In the last 60 days, this issue has received less than 5 community upvotes and we closed it. Still a big Thank You to you for taking the time to create it! To learn more about how we handle issues, please see our documentation.
Happy Coding!


Create new taps model

We'll need a taps model that looks something like the following:
id
taproom = FK(Taproom)
tap_number
beer = FK(Beer)

This depends on having the Taproom model already set up.

https://github.com/tastybrew/tastytaps/commit/5a719d76f0b038f1baf9c21a8fab15c792fdf8a5


Format-validate/syntax-check an expression before evaluating it

Currently, the interpreter/evaluator performs format-validation/syntax-checking during evaluation of an expression. That turns out to be less desirable, for the following reasons:

It impacts performance negatively (a bit), even when an expression has been format-validated/syntax-checked beforehand.
The evaluator also performs type-checking. Currently, “runtime” type errors are not distinguished explicitly from format/syntax errors. Also, mixing these errors might obscure format/syntax errors, because evaluation is stopped due to a type error before the format/syntax error is issued.

Solution: don't do format-validation/syntax-checking during evaluation, but do that before evaluation is started.
Changes should be propagated across the JS, Kotlin, Dart, and Swift implementations.

Closed per PR #124


Zeta Ssp Bid Adapter: Update adapter docs

@FilipStamenkovic  together with UserIds param in docs I changed some other information, just to update docs to actual state in single PR. Thsnks!

Thanks,!

@patmmccann do this PR need any other changes?


VG-6318 hierarchical filters & taxonomy views

Codecov Report

Merging #161 into master will decrease coverage by 0.48%.
The diff coverage is 81.1%.

@@            Coverage Diff             @@
##           master     #161      +/-   ##
==========================================
- Coverage    71.8%   71.32%   -0.49%
==========================================
  Files         249      249
  Lines       15876    15943      +67
  Branches     1716     1727      +11
==========================================
- Hits        11400    11371      -29
- Misses       4476     4572      +96

Impacted Files
Coverage Δ

app/public/config.js
100% <ø> (ø)
:arrow_up:

app/src/filters/filter-query.js
95.23% <100%> (-0.12%)
:arrow_down:

app/src/search/search-module.js
100% <100%> (ø)
:arrow_up:

app/src/filters/filters-module.js
92.3% <100%> (+0.64%)
:arrow_up:

test/spec/filters/filters-controller-spec.js
100% <100%> (ø)
:arrow_up:

app/src/search/search-controller.js
72.42% <22.22%> (-0.92%)
:arrow_down:

app/src/search/search-input-controller.js
69.79% <25%> (-2.55%)
:arrow_down:

app/common/util/converter.js
44.31% <33.33%> (-0.54%)
:arrow_down:

app/src/config/config-service.js
85.82% <40%> (-0.63%)
:arrow_down:

app/src/filters/filters-controller.js
84.94% <75%> (-2.14%)
:arrow_down:

... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81055e3...1a0a560. Read the comment docs.


Support for newest ue5-main

Hi, thank you for your work on porting this plugin to UE5! I'm trying to compile it for the latest ue5-main changes but it seems to me the engine changes have broken it again. Are you planning further support for this plugin? Thanks!
Most of the messages relate to "Use of undefined type FViewInfo", but I suspect some of the errors are red herrings due to other errors. I've tried looking through it myself but I'm unfortunately very new to the intimidating UE API.

Updated!


New model and default branch has changed from "master" to "main"

The default branch for the RNNoise repository has changed from "master" to "main". Beyond the name change, the new main branch brings a much improved model, which is larger, but also better optimized. Feedback welcome.

Looks like that dump_rnnoise_weights.py from README is missing in repo

Oops, thanks for pointing that out. Will fix

Should be fixed in version 0.2 I just released.


Remove "- Amazon S3" from P4Runtime Spec PDF

Whenever I search for the P4Runtime spec, I get these results on Google with Amazon S3 on the title. Is it possible to remove that?

Are you the expert on this Andy?

I checked the PDF  and it seems there's no mention to "Amazon S3" in the PDF metadata, maybe Amazon appends " - Amazon S3" to every file publicly hosted on S3 and advertised to Googlebot? Possible solutions could be:

Host automatic spec PDF builds somewhere else (e.g. Google Cloud)
Change S3 preferences to NOT export PDF spec builds to Googlebot
Hack things around / do some SEO to make sure the first result when googling for "p4runtime" is either https://p4.org/specs/ or this repo URL.

@konne-google I am most definitely not an expert on this stuff.  Carmelo sounds like he is at least ten steps ahead of me on thoughts of why this could be happening :)

Whichever way we go, let's preserve the ability to visualize the rendered HTML & PDF documents for a PR before merging it.

I believe the issue is that the P4 Runtime specification documents (HTML and PDF) are hosted on S3 rather than on GitHub pages, like the other specs. The P4 Runtime WG preferred it this way.
See here:
https://github.com/p4lang/p4lang.github.io/blob/master/_pages/specs.html
Perhaps we should make our processes more uniform and store the canonical versions for all P4 specifications in GitHub? We can still have the S3 as a mirror.

My home page is p4.org now.  I just click on the "Specifications" link and I am there.  What's the problem? :)

In this specific case (see screenshot above), that result is for the master build (i.e. working copy). Is there a way to automate the upload of working spec PDFs to GitHub pages?
Otherwise, regarding option 2, I'm not an expert on Amazon S3, but maybe there's an ACL rule to make files public but NOT indexed by search engines? https://github.com/p4lang/p4runtime/blob/master/.travis.yml#L24

Let's see if something can be done about this before the P4Runtime v1.1.0 release.

Started working on this for the v1.1.0 release. Here is the PoR:

latest (master) version and all tagged versions will be hosted on Github pages
the new official links (to-be-updated on p4.org) are:

https://p4.org/p4runtime/spec/v1.0.0/P4Runtime-Spec.html for v1.0.0 release
https://p4.org/p4runtime/spec/master/P4Runtime-Spec.html for current working version

the generated specs will still be uploaded to Amazon S3 (in particular for the sake of visualizing the rendered documents for each open PR), but the S3 bucket will no longer be indexable by search engines (using robots.txt file)

I'm closing this. You can still see the "Amazon S3" link in the results but it is slowly getting dethroned by the Github link.


Chinese version？

Would you plan to release Chinese version？

Hi, we don't have the plan because it is difficult to conduct the pre-training task (NLM) for Chinese. Thank you!


chore: Improve CometExchange metrics

Which issue does this PR close?

Closes #625.
Rationale for this change

What changes are included in this PR?

How are these changes tested?

I ran into an issue trying to test this change with TPC-DS q72:
: org.apache.spark.SparkException: Job aborted due to stage failure: Total size of serialized results of 132 tasks (1025.8 MiB) is bigger than spark.driver.maxResultSize (1024.0 MiB)

I increased spark.driver.maxResultSize to 2GB but then the query failed with:
24/08/27 08:02:24 INFO DAGScheduler: ShuffleMapStage 40 (collect at /home/andy/git/apache/datafusion-benchmarks/runners/datafusion-comet/tpcbench.py:87) failed in 23.369 s due to Job aborted due to stage failure: Task 6 in stage 40.0 failed 4 times, most recent failure: Lost task 6.3 in stage 40.0 (TID 374) (<IP_ADDRESS> executor 0): org.apache.comet.CometNativeException: Resources exhausted: Failed to allocate additional 132224 bytes for HashJoinInput[0] with<PHONE_NUMBER> bytes already allocated for this reservation - 68761 bytes remain available for the total pool

I then switched to using the Comet 0.2.0-rc1 jar with the same configs and the query ran without error.

I tested with commit f11679800d2f5461c7b235899ef608584742e8a5 (the upgrade to version 0.3.0) and the query runs without error. I then rebuilt from this PR and I'm back to the query failing with the exact same memory error.
I do not see how the changes in this PR could cause any changes to memory usage though.

I ran into an issue trying to test this change with TPC-DS q72:

@andygrove I added dataSize back. Could you re-test it? Thanks.

Thanks @viirya. That fixed it. Here are the metric for q72 with Spark and Comet.

Thank you @andygrove


0.8.2 is extremely slow

It became extremely slow when I updated babel-plugin-angularjs-annotate from 0.8.1 to 0.8.2.
time babel --presets es2015 --plugins angularjs-annotate app.es6.js > /dev/null

app.es6.js is around 750KB/25,000 lines.
With 0.8.1

real	0m5.835s
user	0m6.075s
sys	0m0.275s

With 0.8.2

real	2m5.533s
user	2m4.816s
sys	0m0.986s

I'm running babel 6.26.0 with node 6.11.4 on Mac OS 10.12.6.

We have similar issues too. Transpilation times went up 30s.
0.8.2
desamis-no-MacBook-Air:cc senheng$ yarn add -D babel-plugin-angularjs-annotate
...
success Saved 1 new dependency.
└─<EMAIL_ADDRESS>...
[11:39:53] Starting 'js'...
[11:40:41] Finished 'js' after 48 s

0.8.0
desamis-no-MacBook-Air:cc senheng$ yarn add -D<EMAIL_ADDRESS>...success Saved 1 new dependency.
└─<EMAIL_ADDRESS>...
[11:41:25] Starting 'js'...
[11:41:35] Finished 'js' after 10 s

Has it been fixed in 0.9.0?

Unlikely.  1.0.0 should be on its way as soon as I have some free time to test it, and may help with this somewhat.  I know where the bottleneck is, but unfortunately need to be careful about any fixes, as the code in question was added to address a number of difficult-to-diagnose edge-cases where we weren't generating the right code.

@schmod Any news on this? I'd be happy to help if you can provide some information about it.


python311Packages.b2sdk: 1.32.0 -> 1.33.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python311Packages.b2sdk is: Client library and utilities for access to B2 Cloud Storage (backblaze)
meta.homepage for python311Packages.b2sdk is: https://github.com/Backblaze/b2-sdk-python
meta.changelog for python311Packages.b2sdk is: https://github.com/Backblaze/b2-sdk-python/blob/v1.33.0/CHANGELOG.md
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.33.0 with grep in /nix/store/mrlzp9hhd2m9x5v2hg4yck2pznfa0ij5-python3.11-b2sdk-1.33.0
found 1.33.0 in filename of file in /nix/store/mrlzp9hhd2m9x5v2hg4yck2pznfa0ij5-python3.11-b2sdk-1.33.0

Rebuild report (if merged into master) (click to expand)

6 total rebuild path(s)

6 package rebuild(s)

First fifty rebuilds by attrpath
backblaze-b2
deja-dup
duplicity
duply
python311Packages.b2sdk
python312Packages.b2sdk

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/mrlzp9hhd2m9x5v2hg4yck2pznfa0ij5-python3.11-b2sdk-1.33.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python311Packages.b2sdk https://github.com/r-ryantm/nixpkgs/archive/e6910fd12dea5c4cfc60e9995027cb01c37b9705.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/e6910fd12dea5c4cfc60e9995027cb01c37b9705#python311Packages.b2sdk

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/mrlzp9hhd2m9x5v2hg4yck2pznfa0ij5-python3.11-b2sdk-1.33.0
ls -la /nix/store/mrlzp9hhd2m9x5v2hg4yck2pznfa0ij5-python3.11-b2sdk-1.33.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

2 packages failed to build:

backblaze-b2
backblaze-b2.dist

8 packages built:

deja-dup
duplicity
duplicity.dist
duply
python311Packages.b2sdk
python311Packages.b2sdk.dist
python312Packages.b2sdk
python312Packages.b2sdk.dist

Maintainer pings

Done in #299757


💫 [FeatureRequest] add text-to-singing 🎤🎵

Feature request
Hello 😀,
I'd like to suggest adding a text-to-singing voice synthesis feature.
https://github.com/topics/singing-voice-synthesis
Thank you -_-

Feature request
Hello 😀,
I'd like to suggest adding a text-to-singing voice synthesis feature.
https://github.com/topics/singing-voice-synthesis
Thank you -_-

Hi friend! Thanks for you suggest. I'll study it today/tomorrow and as soon as I do it, I'll let you know. If you're interested, you can help me test this function in the dev branch before releasing it to main and I'll add you as a tester to contributors☺

Feature request Demande de fonctionnalité
Hello 😀, Bonjour 😀,
I'd like to suggest adding a text-to-singing voice synthesis feature.J'aimerais suggérer d'ajouter une fonctionnalité de synthèse vocale texte-chant.
https://github.com/topics/singing-voice-synthesis
Thank you -- Merci --

Hi friend! Thanks for you suggest. I'll study it today/tomorrow and as soon as I do it, I'll let you know. If you're interested, you can help me test this function in the dev branch before releasing it to main and I'll add you as a tester to contributors☺Salut mon ami! Merci pour votre suggestion. Je vais l'étudier aujourd'hui/demain et dès que je l'aurai fait, je vous le ferai savoir. Si vous êtes intéressé, vous pouvez m'aider à tester cette fonction dans la branche dev avant de la publier sur main et je vous ajouterai en tant que testeur aux contributeurs. ☺

ok 👌 I want to become a contributor tester😀
keep me posted😊

Feature request Demande de fonctionnalité
Hello 😀, Bonjour 😀,
I'd like to suggest adding a text-to-singing voice synthesis feature.J'aimerais suggérer d'ajouter une fonctionnalité de synthèse vocale texte-chant.
https://github.com/topics/singing-voice-synthesis
Thank you -- Merci --

Hi friend! Thanks for you suggest. I'll study it today/tomorrow and as soon as I do it, I'll let you know. If you're interested, you can help me test this function in the dev branch before releasing it to main and I'll add you as a tester to contributors☺Salut mon ami! Merci pour votre suggestion. Je vais l'étudier aujourd'hui/demain et dès que je l'aurai fait, je vous le ferai savoir. Si vous êtes intéressé, vous pouvez m'aider à tester cette fonction dans la branche dev avant de la publier sur main et je vous ajouterai en tant que testeur aux contributeurs. ☺

ok 👌 I want to become a contributor tester😀 keep me posted😊

Hello again. Sorry for taking so long to respond to your suggestion. I was busy with important parts of the project and simultaneously studying what you suggested. I think I'll be able to add DiffSinger. I hope it won't take me too much time. As soon as I add the branch to the test, I'll let you know so you can test it😉

Hello again. Sorry for taking so long to respond to your suggestion. I was busy with important parts of the project and simultaneously studying what you suggested. I think I'll be able to add DiffSinger. I hope it won't take me too much time. As soon as I add the branch to the test, I'll let you know so you can test it😉

Hello 😀 , take your time, let me know when you're done. 😉
Thank You