Update README.md

Adding a new Codacy intro.

Adding a new Codacy intro.

While reviewing your changes I started thinking that the new intro could depend too much on the users having a Codacy account that they use in tandem with the GitHub Action. But the main use case for the GitHub Action (at least for now) doesn't require that users have a Codacy account since it works in a completely standalone mode all within GitHub.
As we talked, I will describe in a more straightforward way the uses cases for the GitHub Action, and this will allow us to better understand what should actually go into the introduction.

@Gsandec, what do you think of the intro now, and how it ties with the remaining page?
https://github.com/codacy/codacy-analysis-cli-action/blob/Gsandec-patch-1/README.md


SwiftOptions: regenerate the swift options

Regenerate the swift options from the C++ driver to pick up changes for the new Windows options that are being introduced to control the SDK and Visual C++ tools that we use.

@swift-ci please test

I like that idea!  I can do that as part of the change that forwards the argument.

Thanks Artem, I guess that's why #1306 is also failing. I will fix that test in that PR but will likely cause merge conflicts over here :/ Sorry, Saleem.

@swift-ci please test macOS platform


Run-LinuxCmd: Introduce second return value exitCode

Return Linux command exit code as second return value
in case of ignoreLinuxExitCode.

I think this will break multiple cases, especially when they use the return value of Run-LinuxCmd for further processing.

Not needed as of now.


Validation Review Changes 1

Description
This PR contains the changes asked in PR #82 for issue #72
Sample Video
https://github.com/subhashis2204/project-annapurna/assets/86224794/eecf63cd-fc2f-4440-bfc8-ee973426aacd
Checklist

[x] Code follows the established coding style guidelines
[x] All tests are passing

@subhashis2204 can you please add gssoc label on this PR?

@AlfiyaSiddique done


Blank Commodity Placeholder

What's the point of this issue? The title & that image doesn't say anything about what you want fixed or changed, or what character sheet this is about.


Add the ability to configure the plugin for only one project

I keep getting an internal error from cppcheck for my project. Can I disable the plugin or suppress files only for that project? In some other plugins, you have the option to configure on a per-project basis. I'd like to have it here too.

This is essentially a duplicate of #52.
Also could you provide some information on the "internal error"? Is it an error from the Cppcheck analysis or from the plugin?

From the Cppcheck analysis. OK, closing then.

Care to share the internal error? That issue is not related to the plugin but it also needs to be resolved.

I've already reported it to the cppcheck team. It's not easy to reproduce it now: more than 2 months have passed + I don't use CLion currently.

Good to know. Could you point me to the report?
The only internalError I am aware of is https://trac.cppcheck.net/ticket/11708 and that is fixed with 2.11. That should not have been visible with 2.10 though.

Could you point me to the report?

No, sorry.


How to prepare data set for training

how i can prepare the dataset for training in my case national id card (egy)
and what is the best practice to enhance the performance

I think you can use data labelling application like labelme for example and it generates the labels as json files


DCOS-29474 Detect leftover frameworks after uninstalls

We're occasionally seeing flakes in test_srv_records which were traced down to frameworks not being correctly unregistered. After uninstall, validate that the framework was correctly unregistered, and throw an exception (triggering log collection) if the check fails.
Other misc fixes:

Also throw if dangling resources are found. We were previously logging them but not throwing, so it's not clear if this is actually a thing. We should check this though, as any issues here imply an uninstall bug.
Fix error produced by linux mktemp when running test.sh, and prettify the timestamp used: mktemp: too few X's in template
Misc python lint fixes, and cleanup of lightly-used functions in sdk_utils.

The detection works!
test_zzzrecovery.test_shutdown_host_teardown:
E           Exception: Found 4 orphaned resources after uninstall of hello-world

Will add a way to not fail the test when remaining resources are expected. Leftover resources are expected in the mesos master's accounting when an agent has recently died.


"Sign up here" link takes you to github when auth is configured for Chef Automate

The "Don't have a Chef Automate account?" section links you to github when auth is configured to Chef Automate

this page is located at BuilderURL/#/sign-in

@ericcalabretta this is actually a tunable value in the habitat.conf.js we use for the front end of builder. You can find the configuration point here: https://github.com/habitat-sh/builder/blob/master/components/builder-web/habitat.conf.sample.js  and The builder-web readme explains a bit of how to do this but generally this can be set in the builder config file. I'll update what we have in the builder repo and the config generation bits here before I close this issue out.

That's great news! Is it just missing from the on-prem builder readme or the bldr.env.sample file?
I read that link but the setting for the redirect wasn't obvious to me.

@ericcalabretta I believe the property can be set via updating the user.toml file for builder-api-proxy service:
[oauth]
signup_url = "..."

ref: https://github.com/habitat-sh/builder/blob/master/components/builder-api-proxy/habitat/config/habitat.conf.js#L20


Wrong order status for cancelled refund

Hi, when a refund is cancelled from Lyra BO, the module sets the order status to "Cancelled". In this case the status should not change and moreover should not change to "Cancelled". Indeed the cancellation may be due to an error or the refund may be made by another means.
Thank you !

Hi, thank you for your report, i agree with you, we will fix this issue in the upcoming version.
Best regards !

Great ! Thanks !


Pixelated blur in Android 9

I'm facing a weird behavior on blur with Android 9, the blurAmount is set to 1 and type light, on emulators this works properly, on Android 9 physical device the blur is pixelated.

Did you check, if this issue occur in https://github.com/500px/500px-android-blur ?

Nope, so I created an https://github.com/500px/500px-android-blur/issues/39 there too as this wraps 500px, to see what happens.

Do you have the property downsampleFactor, in your code? Try removing it or changing its value

@DaniCastel I wasn't using this downsampleFactor, this situation occurs in specific OS Android 9, below that works perfectly.

fixed mine by adding downsampleFactor with low value
Android 9

As I don't have anymore this feature in my project, I can't test it.


Fixes #3058 : Make the requests faster and less network intensive by using fields parameter

Added query fields to speed up brand detail fetch process
Changes made in OpenFoodAPIClient and OpenFoodAPIService

Hi @VaiTon ,
Thanks for reviewing it. I was not quite clear about the other facets. Could you list them?

We need to see which fields we are using, so we need to check every call to the function i think.
@teolemon what do you think?

Normally, the facets show all exactly the same values, which are the ones listed for brands. @VaiTon @Varsha-29

product_name_fr should be product_name_XX where XX is the locale of the app

Thank you!

I'm merging. Congratulations on your first OFF PR @Varsha-29 🎉


Made the most pressing copy updates to the home page.

@knmurphy i'm merging this because i think it's an improvement to the current front page, but tagging you for visibility. at least now we aren't talking about non-existent asset tracking.


🚀[FEA]: Better handling of the icosphere construction/usage in GraphCast

Is this a new feature, an improvement, or a change to existing functionality?
Improvement
How would you describe the priority of this feature request
Medium
Please provide a clear description of problem you would like to solve.
No response
Describe any alternatives you have considered
No response

Addressed in this PR: https://github.com/NVIDIA/modulus/pull/510


YARN-10534 Enable runC container transformations

https://issues.apache.org/jira/browse/YARN-10534
Adding an optional runC container transformer plugin, with an example kerberos transformation and tests.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 32s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
13m 54s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
21m 15s

trunk passed

+1 :green_heart:
compile
9m  2s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
compile
7m 40s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
checkstyle
1m 35s

trunk passed

+1 :green_heart:
mvnsite
1m 52s

trunk passed

+1 :green_heart:
shadedclient
19m  5s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 36s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
1m 30s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+0 :ok:
spotbugs
1m 30s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
3m 29s

trunk passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 26s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 15s

the patch passed

+1 :green_heart:
compile
8m  9s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javac
8m  9s

the patch passed

+1 :green_heart:
compile
7m 33s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
javac
7m 33s

the patch passed

+1 :green_heart:
checkstyle
1m 27s

the patch passed

+1 :green_heart:
mvnsite
1m 42s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
shadedclient
15m  5s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m 30s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
1m 25s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
findbugs
3m 39s

the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m  5s

hadoop-yarn-api in the patch passed.

+1 :green_heart:
unit
22m 49s

hadoop-yarn-server-nodemanager in the patch passed.

+1 :green_heart:
asflicense
0m 50s

The patch does not generate ASF License warnings.

149m 59s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2552/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2552

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux dc4e854451fa 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / df35c7f5199

Default Java
Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2552/1/testReport/

Max. process+thread count
536 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2552/1/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 31s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
13m 42s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
20m 55s

trunk passed

+1 :green_heart:
compile
9m  0s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
compile
7m 45s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
checkstyle
1m 30s

trunk passed

+1 :green_heart:
mvnsite
2m 53s

trunk passed

+1 :green_heart:
shadedclient
20m 22s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
2m 26s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
2m 32s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+0 :ok:
spotbugs
1m 32s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
5m 30s

trunk passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 27s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 56s

the patch passed

+1 :green_heart:
compile
8m 15s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javac
8m 15s

the patch passed

+1 :green_heart:
compile
7m 36s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
javac
7m 36s

the patch passed

+1 :green_heart:
checkstyle
1m 24s

the patch passed

+1 :green_heart:
mvnsite
2m 37s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s

The patch has no ill-formed XML file.

+1 :green_heart:
shadedclient
15m  3s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
2m 18s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
2m 24s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
findbugs
5m 47s

the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m  7s

hadoop-yarn-api in the patch passed.

+1 :green_heart:
unit
4m 20s

hadoop-yarn-common in the patch passed.

+1 :green_heart:
unit
22m 47s

hadoop-yarn-server-nodemanager in the patch passed.

+1 :green_heart:
asflicense
0m 52s

The patch does not generate ASF License warnings.

164m 45s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2552/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2552

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml

uname
Linux d7fabd64c083 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / df35c7f5199

Default Java
Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2552/2/testReport/

Max. process+thread count
736 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2552/2/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 31s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
13m 58s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
21m 16s

trunk passed

+1 :green_heart:
compile
9m 23s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
compile
7m 51s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
checkstyle
1m 26s

trunk passed

+1 :green_heart:
mvnsite
2m 34s

trunk passed

+1 :green_heart:
shadedclient
19m 39s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
2m 19s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
2m 12s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+0 :ok:
spotbugs
1m 32s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
5m 34s

trunk passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 25s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 57s

the patch passed

+1 :green_heart:
compile
8m 37s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javac
8m 37s

the patch passed

+1 :green_heart:
compile
7m 45s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
javac
7m 45s

the patch passed

+1 :green_heart:
checkstyle
1m 21s

the patch passed

+1 :green_heart:
mvnsite
2m 20s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s

The patch has no ill-formed XML file.

+1 :green_heart:
shadedclient
15m 28s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
2m 13s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
2m 13s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
findbugs
5m 43s

the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 56s

hadoop-yarn-api in the patch passed.

+1 :green_heart:
unit
4m 12s

hadoop-yarn-common in the patch passed.

+1 :green_heart:
unit
22m 56s

hadoop-yarn-server-nodemanager in the patch passed.

+1 :green_heart:
asflicense
0m 50s

The patch does not generate ASF License warnings.

164m 30s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2552/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2552

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml

uname
Linux 3ddacde3a65e 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / cfe6e1f7da9

Default Java
Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2552/3/testReport/

Max. process+thread count
534 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2552/3/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 31s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
13m 58s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
21m 16s

trunk passed

+1 :green_heart:
compile
9m 23s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
compile
7m 51s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
checkstyle
1m 26s

trunk passed

+1 :green_heart:
mvnsite
2m 34s

trunk passed

+1 :green_heart:
shadedclient
19m 39s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
2m 19s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
2m 12s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+0 :ok:
spotbugs
1m 32s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
5m 34s

trunk passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 25s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 57s

the patch passed

+1 :green_heart:
compile
8m 37s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javac
8m 37s

the patch passed

+1 :green_heart:
compile
7m 45s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
javac
7m 45s

the patch passed

+1 :green_heart:
checkstyle
1m 21s

the patch passed

+1 :green_heart:
mvnsite
2m 20s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s

The patch has no ill-formed XML file.

+1 :green_heart:
shadedclient
15m 28s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
2m 13s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
2m 13s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
findbugs
5m 43s

the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 56s

hadoop-yarn-api in the patch passed.

+1 :green_heart:
unit
4m 12s

hadoop-yarn-common in the patch passed.

+1 :green_heart:
unit
22m 56s

hadoop-yarn-server-nodemanager in the patch passed.

+1 :green_heart:
asflicense
0m 50s

The patch does not generate ASF License warnings.

164m 30s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2552/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2552

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml

uname
Linux 3ddacde3a65e 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / cfe6e1f7da9

Default Java
Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2552/3/testReport/

Max. process+thread count
534 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2552/3/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 39s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m  1s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
20m 23s

trunk passed

+1 :green_heart:
compile
9m 28s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
8m 16s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m 42s

trunk passed

+1 :green_heart:
mvnsite
2m 57s

trunk passed

+1 :green_heart:
javadoc
2m 42s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
2m 35s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
5m 28s

trunk passed

+1 :green_heart:
shadedclient
15m 11s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 27s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 53s

the patch passed

+1 :green_heart:
compile
8m 54s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javac
8m 54s

the patch passed

+1 :green_heart:
compile
8m  6s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
javac
8m  6s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m 37s

the patch passed

+1 :green_heart:
mvnsite
2m 44s

the patch passed

+1 :green_heart:
xml
0m  1s

The patch has no ill-formed XML file.

+1 :green_heart:
javadoc
2m 25s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
2m 23s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
5m 44s

the patch passed

+1 :green_heart:
shadedclient
15m  4s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
1m  8s

hadoop-yarn-api in the patch passed.

+1 :green_heart:
unit
4m 57s

hadoop-yarn-common in the patch passed.

+1 :green_heart:
unit
23m 18s

hadoop-yarn-server-nodemanager in the patch passed.

+1 :green_heart:
asflicense
0m 54s

The patch does not generate ASF License warnings.

166m  6s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2552/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2552

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell xml

uname
Linux 26f2f32b667b 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / a649de742c66e59bd4a29f7007a0cfbe310be78f

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2552/1/testReport/

Max. process+thread count
614 (vs. ulimit of 5500)

modules
C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2552/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.


Source phase terminology

Renames the proposal to "Module Source Imports", using the terminology of this being a module phase as opposed to using the reflection term.
Syntax is updated from import module x from 'x' to import source x from 'x' using the phase attribute for dynamic import.
Cross-references are updated accordingly.

sorry, can you clarify the term we're using now? I'm a bit confused.

unparsed file: asset
parsed but unlinked module (can link manually): ?
parsed and linked module (can feed to importHook): ?
executed module: normal import


Translation

Hi,
Are you open to translation-only pull requests?

I would like to translate cards too! (I'm italian)


Make searching # symbols better

From @octref on October 6, 2016 22:45

VSCode Version: 1.6 Insider

Currently global symbols search isn't really a good experience, as user can't find anything without typing and then waiting for 3 seconds.
One improvement could be letting Cmd+T cache "recently jumped symbols" like Cmd+P does for "recently opened documents", and show it at Cmd+T even if no input is received yet.
Currently it's blank with no input:

Another idea is to fastly compute all symbols in all open files (or files that have been open since launching) and provide them as # symbols. Which would be much more useful than the current Cmd+T.
Copied from original issue: Microsoft/vscode#13317

From @bpasero on October 7, 2016 5:48
Any caching should go into the language service, not into Code imho. This is something typescript should look into (fast global symbol search).

From @egamma on October 7, 2016 6:22
CC @waderyan

From @bowdenk7 on October 7, 2016 23:31
I'm not aware of anything similar - go ahead and migrate it.

Ping @bowdenk7 is this on your radar? I did a quick scan of the TS repo for similar issues and couldn't find one. I'll plan on migrating this issue to TS unless I hear from you that a duplicate already exists.

The server caches after the first request. so the first request will be slow, but things should be snappy from that point on. there is a limit to what we can pre-cache; it is always a memory/perf trade off.


pull request for e2e test at 01/20/2017 01:26:12

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Remove two HHS Domains

🗣 Description
This pull request removes two HHS domains.
💭 Motivation and context
HHS has requested that we remove the domains ahrq-meps.com and sops-database.org as they are no longer owned or affiliated with AHRQ and may be removed from monitoring/tracking for the purposes of BOD 18-01. I verified that this domain is no longer active or owned by HHS via whois, dig, and nslookup.
🧪 Testing
Eyeballs.
✅ Pre-approval checklist

[x] This PR has an informative and human-readable title.
[x] Changes are limited to a single goal - eschew scope creep!
[x] All relevant type-of-change labels have been added.
[ ] I have read the CONTRIBUTING document.
[x] These code changes follow cisagov code standards.
[x] All new and existing tests pass.

@climber-girl When you have time would you review?

@climber-girl - Can you review this one?

@climber-girl - Can you review this one?

Just learned that @climber-girl is out this week.  I'll go ahead and merge this one.


Implement landing page

As a user of the application
I don't want to be thrown directly into the game on loading the page, but be greeted by a landing page first
Because its a more pleasant use experience
NOTES:

Desing
Add epic background!!!
Consider, that there might not be a user logged in here.

Acceptance Criteria:

[ ] Design has been implemented
[ ] Hero button routes to playerSelect
[ ] Header has been adjusted to be able to display "no user"
[ ] The code is fully tested or a good explanation given why it should not or cannot be tested

Dim Background
Slow down background animation


Package protobuf

Generated protobuf and gRPC stuff now recides in a seperate project
┆Issue is synchronized with this Asana task

That should cover it, @einari. It also reminded me to configure my c# formater extension to put curly braces on the next line :)

Tried replying to a comment inside Teams. Not sure if it got here. But keep the Grpc in the namespace and drop Protobuf

So I should add back .Grpc?

Yup. Protobuf is wrong due to it being a message format. Not super enthusiastic about Grpc in the namespace either, but that makes a lot more sense.

I think we've been misunderstanding each other. The namespace now has Grpc twice, it should only have the first Grpc

But that means that you want it at the time of this commit: https://github.com/dolittle-runtime/Runtime/pull/252/commits/9b3a795fe887626d0db192d29704e56018fa6d44

Sorry about that..  But yeah..   Complete misunderstanding.  That makes sense.

@einari I forced this PR back to the commit I think you wanted, can you see over?


List of potentially problematic upstream commits

73d1d20b46dda54340ad2819b865f47ca25f4850

73d1d20b46dda54340ad2819b865f47ca25f4850

ea7cf2b738c3b103b472547500fb0107b956fc0c

98647e83c733a8a8d36522f71e677367ca8ddd03

20b4b85f7266ef2edbe492829585a14118a85d7a
93150a0d40a6f29907d53bba8a4a44f1c5fb2449

565f590586e89d837db3add08b8c926560f88f8b

582b190764641e5049768da1ba8962c841ec014b

8f86fbfd6c34a4d03f2bd62e9dc1ff59c236b037

https://github.com/micropython/micropython/commit/ef554ef9a2708a8f344f22e586f52fb1343ed524 - Removes fast path for the realistic poll objects, that part should be reverted.

https://github.com/micropython/micropython/commit/9ab816d676543178773928053906fcb2c2c433f7#commitcomment-30083813
https://github.com/micropython/micropython/commit/b8b2525576ccca9c33629de71557e4204abde766#r30083881

GC problems are introduced.

1d6cb6357a2cde40822712211fb51c4a4bbe41cf - Sloppy implementation of retry on lwIP's ERR_MEM on tcp_write().

https://github.com/micropython/micropython/commit/62b00dd5d8cd6207147d37222e1c249ef6381841 - Tabs instead of spaces, breaks Clang.


WorkBench non-responsive

WorkBench 0.1.5 worked for about a day, but now is stuck at initial screen.
Did full uninstall, registry scan-clean, reinstall.  Same issue...

Found the problem.  Can't use private key in "/.ssh" directory.
Backup .ssh dir, "remove all" keys in EON, reinstall WB

Thank you for this information. I'm sure it has helped many in the community!


Update Skim.app to v1.4.13

Thank you for the contribution. It was merged directly as d814f5ae4bbc7991a671f9dedeff84433205353d to keep commit history cleaner. Your contribution is still credited to you.


Design web page layout

fonu changing (size i style)
translation
responsive
Circular, sans-serif

Design aplikacji V.1

Based on this layout, please create tasks (Issues) representing parts of GUI which have to be developed over the time.


build: drop support for Node.js 8.x

This PR moves this project away from building for Node.js v8.x as it reached EOL in December 2019. This also offers the secondary benefit of allowing us to utilize more ECMA2015 features moving forward.
Unblocks #99

I've only found my way here because I submitted some patches today and felt awkward writing var! I don't exactly mean to poke my nose into your tech choices, but it occurs to me that this patch changes the version to node 13. 13 is already end-of-life too -- its support ended in June of this year! The odd-numbered releases are shorter-lived; I imagine it might be better to choose node 12 or 14.

Good call @tremby. To give additional context here, we are working on giving imgix-core-js a significant update, so this won't be an issue for that much longer. After the point where that is published is when we plan to integrate it into our other libraries like react-imgix.

I'm going actually going to close this PR since it will have to be handled as part of the rewrite.


Is it possible to create repositories without project?

If you are reporting a problem, please make sure the following information are provided:
1)Version of docker engine and docker-compose. 1.12.6
2)Harbor version: 0.5.0
I'd like to use Harbor as my default docker registry instead of Docker hub, that is, when I run docker pull nginx:latest, it will pull image myreg.demo.com/nginx:latest, but seems repositories in Harbor should be created under projects, like myreg.demo.com/nginx/nginx:latest, so may I know is it possible to create image like myreg.demo.com/nginx:latest?

No, currently not, very image has be under a namespace which is the equivalent of project.

@reasonerjt Will this be supported in future releases?

@reasonerjt I'm trying to add a Nginx proxy before Harbor, the proxy working for make docker client does not aware of the namespace exist, but I can't make it work ... any suggestion?

@hiscal2015 Currently you can create a project (e.g. dockerhub) to host all images pulled from dockerhub. We will discuss whether to support this feature in future release.


[test-only]ApiTest. added test for uploading zero file with mtime

related https://github.com/owncloud/ocis/issues/1248
see https://github.com/owncloud/ocis/issues/1248#issuecomment-1596932748

:boom: Acceptance test Core-API-Tests-ocis-storage-10 failed. Further test are cancelled...


Display a generic Experimental mode warning message when this mode is enabled

What type of PR is this:
/kind code-refactoring
What does this PR do / why we need it:
This fixes the issue of having this warning message displayed for a specific feature that might not be actually used by the user.
Instead, we are now displaying a more generic and feature-agnostic warning message once we detect that the experimental mode is enabled.
Which issue(s) this PR fixes:
Fixes #6381
PR acceptance criteria:

[ ] Unit test

[x] Integration test

[x] Documentation

How to test changes / Special notes to the reviewer:
The experimental mode warning message should now be more visible, and not dependent on the experimental feature:
Before:
$ ODO_EXPERIMENTAL_MODE=t odo version --client
Experimental mode enabled for flag: --run-on. Use at your own risk. More details on https://odo.dev/docs/user-guides/advanced/experimental-mode
odo v3.4.0 (b8662ef74)

With this PR:
$ ODO_EXPERIMENTAL_MODE=t odo version --client
============================================================================
⚠ Experimental mode enabled. Use at your own risk.
More details on https://odo.dev/docs/user-guides/advanced/experimental-mode
============================================================================

odo v3.4.0 (4bb04d493)

/override ci/prow/v4.11-integration-e2e
IBM cloud passes.


[Question] Usage of package.json

What is the logic behind using package.json which each component?  What advantages does this give?
Thanks

I only use it for specifying an entry point to the component using the main field in package.json. By doing this I can import the component directly from its folder. So instead of import Header from 'components/Header/Header' I can use import Header from 'components/Header'.
Another solution would be to rename Header.js to index.js but then it's hard to see which component is which in my editor tabs.

Nice, I like that idea. Thanks for the response.


Remove rules duplicate .img-fluid from .img-thumbnail

Prerequisites

[X] I have searched for duplicate or closed feature requests
[X] I have read the contributing guidelines

Proposal
Remove
https://github.com/twbs/bootstrap/blob/46bb9e78d74e0c7f4fa6f6fa611f3d9f8f28860b/scss/_images.scss#L22
Motivation and context
<img class="img-fluid img-thumbnail" ...> looks more correct in Bootstrap context

This would be a breaking change, so it'd have to be for v6. That said, I'm not opposed, but I'm not sure how much it saves us vs the developer inconvenience. Labelling and closing for now, thanks!


Example of how to confirm container is working

Do you have an example CURL I can use against this to confirm it is infa

The latest image pushed supports health checks, but if you want to validate that the proxy is proxying, the following should return a not authorized from the UDM.
curl https://localhost/api/auth --insecure -H "Content-Type: application/json; charset=utf-8" -H "Content-Length: 0" -X POST --http1.1

{
  "errors": [
    "Invalid username or password"
  ]
}

Closing for now, feel free to re-open.


Globed causing Lag Spikes in levels

Whenever i play a level with players on it, it causes it to randomly freeze, and then in the end making me die.
Note that my PC is totally capable for online games, as i've played games that use more than globed and GD.

can you try the latest version (v1.1.1) and tell if the issue still occurs? some lagspike issues were fixed in that specific update

can you try the latest version (v1.1.1) and tell if the issue still occurs? some lagspike issues were fixed in that specific update

ok, on it

can you try the latest version (v1.1.1) and tell if the issue still occurs? some lagspike issues were fixed in that specific update

thanks! it's fixed now, i tried it on a couple fast levels, and for now there hasn't been any lag spikes!


Add with_datetime_format to csv WriterBuilder

Which issue does this PR close?
Closes https://github.com/apache/arrow-rs/issues/1272.
Rationale for this change
Users should be able to override the default datetime format.
What changes are included in this PR?
Add with_datetime_format() method to csv WriterBuilder.
Are there any user-facing changes?
Yes, a new method WriterBuilder::with_datetime_format().

Codecov Report

Merging #1347 (0ccd766) into master (ecba7dc) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1347      +/-   ##
==========================================
- Coverage   83.04%   83.03%   -0.01%
==========================================
  Files         181      181
  Lines       52937    52940       +3
==========================================
- Hits        43960    43959       -1
- Misses       8977     8981       +4

Impacted Files
Coverage Δ

arrow/src/csv/writer.rs
71.32% <0.00%> (-0.82%)
:arrow_down:

parquet_derive/src/parquet_field.rs
65.98% <0.00%> (-0.46%)
:arrow_down:

arrow/src/array/transform/mod.rs
84.65% <0.00%> (+0.13%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecba7dc...0ccd766. Read the comment docs.

cc @sum12


Update to fontawesome 5

And while at it, update the Linkedin Icon plus add the strava.com icon.

I will come back later with this :) Need to fix some stuff... also @swanson I'd like to hear if you're in for it? or should I just fork?


METRON-1938 Add Parser Debugger to READMEs

Added documentation and examples for the Parser Debugger to the README.
Testing
Generate the site book and review the documentation for the Management functions.
Pull Request Checklist

[x] Is there a JIRA ticket associated with this PR? If not one needs to be created at Metron Jira.

[x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[x] Has your PR been rebased against the latest commit within the target branch (typically master)?

[x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via site-book/target/site/index.html:
cd site-book
mvn site

Aside from my last comment, I'm +1

Thanks @JonZeolla .  I think everything you mentioned is addressed.  If not, let me know. Thanks for your PR and all the effort in reviewing.

+1 thanks for pulling this together and the upstream work on the features themselves, I will definitely be putting them through their paces =)


Color identification using OpenCV

Script Title : Color identification in images
Suggest an script for this project : Python
YourName : Vishva Rana
✅ DevIncept Participant
✅Contributor
Is your feature request related to a problem? Please describe.
Problem is same as mentioned in title
Describe the solution you'd like...
This will detect color in images and show a pie chart of what different colours are used, also when given colour, it will bring out images that has the given colour
Please assign it to me under DCP'21

Issue assigned. @vishvarana

PR made
#30
Please review and let me know if any changes required


Release new version

HI @elonmallin !
Could you please cut a release of this extension? I would like to use envVars but it is not available in the most recent version on the marketplace.
Thanks in advance 🙇

I second that.

A new version released now, sorry for delay. There's now some tests and pipes to release so should be smoother in the future


Changes for http://jira.baeldung.com/browse/BAEL-2421

JIRA Link:
http://jira.baeldung.com/browse/BAEL-2421
Wordpress post link:
http://inprogress.baeldung.com/wp-admin/post.php?post=122052

I am not sure that a separate main class is necessary here. I think that it would be a lot cleaner if you just had all of your code in your unit test. What do you think?

I am not sure that a separate main class is necessary here. I think that it would be a lot cleaner if you just had all of your code in your unit test. What do you think?

Merged the classes as per your suggestion.

The suggested changes are done.


add option to not flip minimap on reverse camera (default)

this has been bugging me for a while now, the regular gw compass doesn't flip so the mismatch was irritating
I've made it the default behaviour that the minimap does not flip on reverse

this also fixes the Reapply Title behaviour now if Title::title_id gets fixed too

Minimap changes merged


Emit doc nodes with bracketed text from Java. [phab:D960]

Created by zarko at 2016-07-12 23:53:58:
In line with the C++ indexer, this diff emits doc nodes that contain bracketed, UTF-8 encoded comment text for Java code.

schroederc commented inline (context lost during migration) at 2016-07-12 23:57:48:
We can't use Java 8 features yet.

schroederc required changes at 2016-07-12 23:57:48

zarko wrote at 2016-07-13 00:05:09:

Remove Java 8 dependency

schroederc commented inline (context lost during migration) at 2016-07-13 18:00:48:
new ArrayList<>() is the new preferred style.

schroederc commented inline (context lost during migration) at 2016-07-13 18:00:48:
new ArrayList(miniAnchors.size())

schroederc wrote at 2016-07-13 18:00:48:
Summary?
Also, this change is missing the MiniAnchor.java source file.

schroederc required changes at 2016-07-13 18:00:48

zarko wrote at 2016-07-13 19:24:36:

Missing file
Address comments.

schroederc commented inline (context lost during migration) at 2016-07-13 21:10:43:
More Java 8 features to be removed
Test with the following or rebase on top of #1292:
bazel test --javacopt '-source 7' //...

shahms commented inline (context lost during migration) at 2016-07-13 21:31:36:
do we want to record this failure in some fashion?

shahms commented inline (context lost during migration) at 2016-07-13 21:31:36:
are lambdas not Java 8?

schroederc commented inline (context lost during migration) at 2016-07-13 22:11:39:
This would result in the same VName for two copies of the same comment which probably isn't wanted.  Position information could be mixed in to fix this.

zarko wrote at 2016-07-13 23:42:56:

Remove Java 8 dependency
Missing file
Address comments.
More Java 8 dependencies.

zarko commented inline (context lost during migration) at 2016-07-14 17:14:17:
Why isn't this desirable? Note that the params are added to the hash below.

schroederc commented inline (context lost during migration) at 2016-07-14 17:26:06:
params would be the same if the comment is identical.
I just assumed we would always want 1 node per documentation comment.
Likewise, are we going to provide positional information so that UIs can link back to the source location of the documentation?

zarko commented inline (context lost during migration) at 2016-07-14 17:37:40:
There's not necessarily a 1:1 relationship between doc nodes and source-level comments.
params would be different if the same comment appeared in a different context, e.g.
/**
 * Gets {code name}.
 * return {code name}
 */
String getName() { return name; }

That comment is likely to appear in a number of different places, but in each one the name field would be different, so the comments would have distinguishable signatures.

schroederc commented inline (context lost during migration) at 2016-07-14 18:00:55:
Mark all method overrides with Override

schroederc commented inline (context lost during migration) at 2016-07-14 18:00:55:
static

schroederc commented inline (context lost during migration) at 2016-07-14 18:00:55:
static

schroederc commented inline (context lost during migration) at 2016-07-14 18:00:55:
Type variables should usually be a single capital letter.

schroederc commented inline (context lost during migration) at 2016-07-14 18:00:55:
Remove unused import

schroederc commented inline (context lost during migration) at 2016-07-14 18:00:55:
All com.google imports are grouped together.
Or... if you want to use the freshest, latest, and "best" style, there are only two import groups: static and non-static.

schroederc commented inline (context lost during migration) at 2016-07-14 18:00:55:
Actually... those would be the same since you used code rather than link.
I suppose it will only matter if we don't want to provide positional information about the documentation comment, but I think we do.

schroederc commented inline (context lost during migration) at 2016-07-14 18:00:55:
Comment which anchors would match this condition and why we are filtering them.

schroederc commented inline (context lost during migration) at 2016-07-14 18:00:55:
while (!ends.isEmpty() && ends.peek() == sourcePos) {

zarko wrote at 2016-07-14 19:45:33:

Remove Java 8 dependency
Missing file
Address comments.
More Java 8 dependencies.
Address comments.

zarko commented inline (context lost during migration) at 2016-07-14 19:46:22:
~ magic heuristics ~
Since it's conceivable for multiple comment blocks to contribute to the same doc node, this would be better handled with edges, possibly from the documentation anchors we already have.

zarko commented inline (context lost during migration) at 2016-07-14 19:46:22:
This is such a weird rule given how verbose other identifiers are

schroederc commented inline (context lost during migration) at 2016-07-14 19:54:52:
But why are they negative or empty?

schroederc commented inline (context lost during migration) at 2016-07-14 19:54:52:
Static group is still first.

schroederc accepted this revision at 2016-07-14 19:54:52

zarko wrote at 2016-07-14 20:06:32:

Address comments.

zarko closed via commit db02605cb41c3372818411f3a00b19fb1dff5c37 at 2016-07-14 20:28:14


Make periodic checks configurable

Add the ability to toggle individual checks on/off
Granularity node or deployment?

PR #10 tests:
Env value in the helm config sets the periodic tests to run:
$ cat autopilot-config.yml
namespace:
  create: true
  name: autopilot

image:
  repository: quay.io/autopilot/autopilot

pullSecrets:
  create: false
  name: autopilot-pull-secret
  imagePullSecretData:

env:
  - name: "PERIODIC_CHECKS"
    value: "ping"

ping (only)
I0318 15:25:40.412047 9 healthchecks.go:18] Running a periodic check

I0318 15:25:40.412534 9 healthchecks.go:34] Running health check: ping

I0318 15:25:40.412062 9 main.go:52] Serving metrics on :8081

I0318 15:25:40.412090 9 main.go:81] Serving Health Checks on port :3333

I0318 15:25:50.141206 9 healthchecks.go:284] Observation: 1/1 remote nodes are reachable

I0318 15:25:50.141240 9 healthchecks.go:140] Total time (s) for all checks: 9.728706398

pcibw, ping
I0318 15:28:22.772025 9 healthchecks.go:18] Running a periodic check

I0318 15:28:22.772414 9 healthchecks.go:59] Running health check: pciebw

I0318 15:28:22.772067 9 main.go:81] Serving Health Checks on port :3333

I0318 15:28:22.772082 9 main.go:52] Serving metrics on :8081

I0318 15:28:49.811598 9 healthchecks.go:228] GPU PCIe BW test completed:

I0318 15:28:49.811628 9 healthchecks.go:251] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 0 22.7

I0318 15:28:49.811645 9 healthchecks.go:251] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 1 23.3

I0318 15:28:49.811650 9 healthchecks.go:251] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 2 23.3

I0318 15:28:49.811655 9 healthchecks.go:251] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 3 23.3

I0318 15:28:49.811660 9 healthchecks.go:251] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 4 23

I0318 15:28:49.811665 9 healthchecks.go:251] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 5 23

I0318 15:28:49.811678 9 healthchecks.go:251] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 6 22.9

I0318 15:28:49.811687 9 healthchecks.go:251] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 7 22.6

I0318 15:28:49.811693 9 healthchecks.go:34] Running health check: ping

I0318 15:29:00.353877 9 healthchecks.go:284] Observation: 1/1 remote nodes are reachable

I0318 15:29:00.353907 9 healthchecks.go:140] Total time (s) for all checks: 37.581495812

pcibw, remapped, ping
I0318 15:30:48.453562 10 healthchecks.go:18] Running a periodic check

I0318 15:30:48.454061 10 healthchecks.go:59] Running health check: pciebw

I0318 15:30:48.453603 10 main.go:52] Serving metrics on :8081

I0318 15:30:48.453617 10 main.go:81] Serving Health Checks on port :3333

I0318 15:31:20.562214 10 healthchecks.go:228] GPU PCIe BW test completed:

I0318 15:31:20.562252 10 healthchecks.go:251] Observation: gdr-test-6p2kc-gdr-gpu-worker-3-8ftwl 0 9.1

I0318 15:31:20.562279 10 healthchecks.go:251] Observation: gdr-test-6p2kc-gdr-gpu-worker-3-8ftwl 1 3.3

I0318 15:31:20.562287 10 healthchecks.go:251] Observation: gdr-test-6p2kc-gdr-gpu-worker-3-8ftwl 2 9.7

I0318 15:31:20.562303 10 healthchecks.go:251] Observation: gdr-test-6p2kc-gdr-gpu-worker-3-8ftwl 3 10.4

I0318 15:31:20.562312 10 healthchecks.go:251] Observation: gdr-test-6p2kc-gdr-gpu-worker-3-8ftwl 4 10.2

I0318 15:31:20.562318 10 healthchecks.go:251] Observation: gdr-test-6p2kc-gdr-gpu-worker-3-8ftwl 5 10.7

I0318 15:31:20.562325 10 healthchecks.go:251] Observation: gdr-test-6p2kc-gdr-gpu-worker-3-8ftwl 6 9.7

I0318 15:31:20.562331 10 healthchecks.go:251] Observation: gdr-test-6p2kc-gdr-gpu-worker-3-8ftwl 7 9.5

I0318 15:31:20.562344 10 healthchecks.go:68] Running health check: remapped

I0318 15:31:25.319075 10 healthchecks.go:164] Remapped Rows check test completed:

I0318 15:31:25.319139 10 healthchecks.go:186] Observation: gdr-test-6p2kc-gdr-gpu-worker-3-8ftwl 0 0

I0318 15:31:25.319191 10 healthchecks.go:186] Observation: gdr-test-6p2kc-gdr-gpu-worker-3-8ftwl 1 0

I0318 15:31:25.319208 10 healthchecks.go:186] Observation: gdr-test-6p2kc-gdr-gpu-worker-3-8ftwl 2 0

I0318 15:31:25.319217 10 healthchecks.go:186] Observation: gdr-test-6p2kc-gdr-gpu-worker-3-8ftwl 3 0

I0318 15:31:25.319233 10 healthchecks.go:186] Observation: gdr-test-6p2kc-gdr-gpu-worker-3-8ftwl 4 0

I0318 15:31:25.319246 10 healthchecks.go:186] Observation: gdr-test-6p2kc-gdr-gpu-worker-3-8ftwl 5 0

I0318 15:31:25.319257 10 healthchecks.go:186] Observation: gdr-test-6p2kc-gdr-gpu-worker-3-8ftwl 6 0

I0318 15:31:25.319266 10 healthchecks.go:186] Observation: gdr-test-6p2kc-gdr-gpu-worker-3-8ftwl 7 0

I0318 15:31:25.319280 10 healthchecks.go:34] Running health check: ping

I0318 15:31:35.091577 10 healthchecks.go:284] Observation: 1/1 remote nodes are reachable

I0318 15:31:35.091620 10 healthchecks.go:140] Total time (s) for all checks: 46.637565769

pcibw, remapped, dcgm, ping
I0318 15:50:25.260343 9 healthchecks.go:18] Running a periodic check

I0318 15:50:25.260915 9 healthchecks.go:59] Running health check: pciebw

I0318 15:50:25.260372 9 main.go:52] Serving metrics on :8081

I0318 15:50:25.260401 9 main.go:81] Serving Health Checks on port :3333

I0318 15:50:54.877184 9 healthchecks.go:228] GPU PCIe BW test completed:

I0318 15:50:54.877221 9 healthchecks.go:251] Observation: gdr-test-6p2kc-gdr-gpu-worker-3-8ftwl 0 9.4

I0318 15:50:54.877248 9 healthchecks.go:251] Observation: gdr-test-6p2kc-gdr-gpu-worker-3-8ftwl 1 3.3

I0318 15:50:54.877257 9 healthchecks.go:251] Observation: gdr-test-6p2kc-gdr-gpu-worker-3-8ftwl 2 9.8

I0318 15:50:54.877263 9 healthchecks.go:251] Observation: gdr-test-6p2kc-gdr-gpu-worker-3-8ftwl 3 10

I0318 15:50:54.877270 9 healthchecks.go:251] Observation: gdr-test-6p2kc-gdr-gpu-worker-3-8ftwl 4 9.1

I0318 15:50:54.877303 9 healthchecks.go:251] Observation: gdr-test-6p2kc-gdr-gpu-worker-3-8ftwl 5 9.1

I0318 15:50:54.877316 9 healthchecks.go:251] Observation: gdr-test-6p2kc-gdr-gpu-worker-3-8ftwl 6 9.2

I0318 15:50:54.877322 9 healthchecks.go:251] Observation: gdr-test-6p2kc-gdr-gpu-worker-3-8ftwl 7 9.1

I0318 15:50:54.877335 9 healthchecks.go:68] Running health check: remapped

I0318 15:50:59.603320 9 healthchecks.go:164] Remapped Rows check test completed:

I0318 15:50:59.603363 9 healthchecks.go:186] Observation: gdr-test-6p2kc-gdr-gpu-worker-3-8ftwl 0 0

I0318 15:50:59.603406 9 healthchecks.go:186] Observation: gdr-test-6p2kc-gdr-gpu-worker-3-8ftwl 1 0

I0318 15:50:59.603415 9 healthchecks.go:186] Observation: gdr-test-6p2kc-gdr-gpu-worker-3-8ftwl 2 0

I0318 15:50:59.603422 9 healthchecks.go:186] Observation: gdr-test-6p2kc-gdr-gpu-worker-3-8ftwl 3 0

I0318 15:50:59.603428 9 healthchecks.go:186] Observation: gdr-test-6p2kc-gdr-gpu-worker-3-8ftwl 4 0

I0318 15:50:59.603434 9 healthchecks.go:186] Observation: gdr-test-6p2kc-gdr-gpu-worker-3-8ftwl 5 0

I0318 15:50:59.603447 9 healthchecks.go:186] Observation: gdr-test-6p2kc-gdr-gpu-worker-3-8ftwl 6 0

I0318 15:50:59.603462 9 healthchecks.go:186] Observation: gdr-test-6p2kc-gdr-gpu-worker-3-8ftwl 7 0

I0318 15:50:59.603479 9 healthchecks.go:34] Running health check: ping

I0318 15:51:09.402872 9 healthchecks.go:284] Observation: 1/1 remote nodes are reachable

I0318 15:51:09.402916 9 healthchecks.go:50] Running health check: dcgm -r 1

I0318 15:51:25.977614 9 healthchecks.go:344] DCGM test completed:

I0318 15:51:25.977668 9 healthchecks.go:360] Observation: gdr-test-6p2kc-gdr-gpu-worker-3-8ftwl result 0

I0318 15:51:25.977712 9 healthchecks.go:140] Total time (s) for all checks: 60.716811101

pcibw, remapped, dcgm, gpupower, ping
I0318 15:56:48.659969       9 healthchecks.go:18] Running a periodic check
I0318 15:56:48.660293       9 healthchecks.go:59] Running health check: pciebw
I0318 15:56:48.660013       9 main.go:81] Serving Health Checks on port :3333
I0318 15:56:48.660037       9 main.go:52] Serving metrics on :8081
I0318 15:57:15.484367       9 healthchecks.go:228] GPU PCIe BW test completed:
I0318 15:57:15.484397       9 healthchecks.go:251] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 0 22.8
I0318 15:57:15.484413       9 healthchecks.go:251] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 1 22.8
I0318 15:57:15.484418       9 healthchecks.go:251] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 2 22.7
I0318 15:57:15.484423       9 healthchecks.go:251] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 3 22.6
I0318 15:57:15.484428       9 healthchecks.go:251] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 4 22.4
I0318 15:57:15.484433       9 healthchecks.go:251] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 5 22.3
I0318 15:57:15.484437       9 healthchecks.go:251] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 6 22.5
I0318 15:57:15.484442       9 healthchecks.go:251] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 7 22.5
I0318 15:57:15.484449       9 healthchecks.go:68] Running health check: remapped
I0318 15:57:20.061303       9 healthchecks.go:164] Remapped Rows check test completed:
I0318 15:57:20.061332       9 healthchecks.go:186] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 0 0
I0318 15:57:20.061352       9 healthchecks.go:186] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 1 0
I0318 15:57:20.061358       9 healthchecks.go:186] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 2 0
I0318 15:57:20.061363       9 healthchecks.go:186] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 3 0
I0318 15:57:20.061368       9 healthchecks.go:186] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 4 0
I0318 15:57:20.061373       9 healthchecks.go:186] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 5 0
I0318 15:57:20.061379       9 healthchecks.go:186] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 6 0
I0318 15:57:20.061383       9 healthchecks.go:186] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 7 0
I0318 15:57:20.061390       9 healthchecks.go:34] Running health check: ping
I0318 15:57:20.476445       9 healthchecks.go:284] Observation: 0/0 remote nodes are reachable
I0318 15:57:20.476468       9 healthchecks.go:50] Running health check: dcgm -r 1
I0318 15:57:36.823608       9 healthchecks.go:344] DCGM test completed:
I0318 15:57:36.823637       9 healthchecks.go:360] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq result 0
I0318 15:57:36.823663       9 healthchecks.go:77] Running health check: gpupower
I0318 15:57:37.390896       9 healthchecks.go:382] Power Throttle check test completed:
I0318 15:57:37.390922       9 healthchecks.go:404] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 0 0
I0318 15:57:37.390936       9 healthchecks.go:404] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 1 0
I0318 15:57:37.390941       9 healthchecks.go:404] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 2 0
I0318 15:57:37.390946       9 healthchecks.go:404] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 3 0
I0318 15:57:37.390951       9 healthchecks.go:404] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 4 0
I0318 15:57:37.390957       9 healthchecks.go:404] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 5 0
I0318 15:57:37.390961       9 healthchecks.go:404] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 6 0
I0318 15:57:37.390966       9 healthchecks.go:404] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 7 0
I0318 15:57:37.390971       9 healthchecks.go:140] Total time (s) for all checks: 48.730681731

"all"
I0318 15:59:50.131549       9 healthchecks.go:18] Running a periodic check
I0318 15:59:50.131895       9 healthchecks.go:95] Run all health checks
I0318 15:59:50.131600       9 main.go:81] Serving Health Checks on port :3333
I0318 15:59:50.131617       9 main.go:52] Serving metrics on :8081
I0318 16:00:17.367470       9 healthchecks.go:228] GPU PCIe BW test completed:
I0318 16:00:17.367496       9 healthchecks.go:251] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 0 22.5
I0318 16:00:17.367512       9 healthchecks.go:251] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 1 22.4
I0318 16:00:17.367518       9 healthchecks.go:251] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 2 22.4
I0318 16:00:17.367522       9 healthchecks.go:251] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 3 22.5
I0318 16:00:17.367527       9 healthchecks.go:251] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 4 21
I0318 16:00:17.367532       9 healthchecks.go:251] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 5 21
I0318 16:00:17.367536       9 healthchecks.go:251] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 6 21
I0318 16:00:17.367541       9 healthchecks.go:251] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 7 21
I0318 16:00:22.007676       9 healthchecks.go:164] Remapped Rows check test completed:
I0318 16:00:22.007704       9 healthchecks.go:186] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 0 0
I0318 16:00:22.007721       9 healthchecks.go:186] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 1 0
I0318 16:00:22.007727       9 healthchecks.go:186] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 2 0
I0318 16:00:22.007732       9 healthchecks.go:186] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 3 0
I0318 16:00:22.007737       9 healthchecks.go:186] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 4 0
I0318 16:00:22.007773       9 healthchecks.go:186] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 5 0
I0318 16:00:22.007783       9 healthchecks.go:186] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 6 0
I0318 16:00:22.007792       9 healthchecks.go:186] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 7 0
I0318 16:00:41.506178       9 healthchecks.go:344] DCGM test completed:
I0318 16:00:41.506211       9 healthchecks.go:360] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq result 0
I0318 16:00:51.094551       9 healthchecks.go:284] Observation: 1/1 remote nodes are reachable
I0318 16:00:51.560115       9 healthchecks.go:382] Power Throttle check test completed:
I0318 16:00:51.560144       9 healthchecks.go:404] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 0 0
I0318 16:00:51.560158       9 healthchecks.go:404] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 1 0
I0318 16:00:51.560163       9 healthchecks.go:404] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 2 0
I0318 16:00:51.560168       9 healthchecks.go:404] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 3 0
I0318 16:00:51.560173       9 healthchecks.go:404] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 4 0
I0318 16:00:51.560177       9 healthchecks.go:404] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 5 0
I0318 16:00:51.560182       9 healthchecks.go:404] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 6 0
I0318 16:00:51.560186       9 healthchecks.go:404] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 7 0
I0318 16:00:51.560193       9 healthchecks.go:140] Total time (s) for all checks: 61.42829908

@cmisale see the logs above. The all test target did not should any ping output, despite the code clearly intending to...  Is this a bug?

Np. Reading the code, the ping test should run when the user configures the periodic checks value == "all". However, if you look at the output of my final test (value: "all") there's no ping output, which leads me to believe theres a bug in that "all" clause of the switch statement.
So, I wrote a bit of code to remove the all clause all-together: https://github.com/IBM/autopilot/pull/10/commits/b5d5891f93f840613fcd7f04db849f231e885141
Let me know if that makes sense & does the expected behavior

Tested with the new commit and now the ping test output is included
$ cat autopilot-config.yml
namespace:
  create: true
  name: autopilot

image:
  repository: quay.io/autopilot/autopilot

pullSecrets:
  create: false
  name: autopilot-pull-secret
  imagePullSecretData:

env:
  - name: "PERIODIC_CHECKS"
    value: "all"

I0318 17:41:43.113861       9 healthchecks.go:18] Running a periodic check
I0318 17:41:43.114242       9 healthchecks.go:21] Run all health checks
I0318 17:41:43.113920       9 main.go:52] Serving metrics on :8081
I0318 17:41:43.114043       9 main.go:81] Serving Health Checks on port :3333
I0318 17:41:43.114253       9 healthchecks.go:60] Running health check: pciebw
I0318 17:42:10.050256       9 healthchecks.go:190] GPU PCIe BW test completed:
I0318 17:42:10.050281       9 healthchecks.go:213] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 0 23.2
I0318 17:42:10.050296       9 healthchecks.go:213] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 1 23.2
I0318 17:42:10.050302       9 healthchecks.go:213] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 2 23.4
I0318 17:42:10.050307       9 healthchecks.go:213] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 3 23.5
I0318 17:42:10.050312       9 healthchecks.go:213] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 4 21.7
I0318 17:42:10.050326       9 healthchecks.go:213] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 5 23
I0318 17:42:10.050331       9 healthchecks.go:213] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 6 23.2
I0318 17:42:10.050336       9 healthchecks.go:213] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 7 23.3
I0318 17:42:10.050342       9 healthchecks.go:69] Running health check: remapped
I0318 17:42:14.710790       9 healthchecks.go:126] Remapped Rows check test completed:
I0318 17:42:14.710833       9 healthchecks.go:148] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 0 0
I0318 17:42:14.710854       9 healthchecks.go:148] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 1 0
I0318 17:42:14.710860       9 healthchecks.go:148] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 2 0
I0318 17:42:14.710865       9 healthchecks.go:148] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 3 0
I0318 17:42:14.710870       9 healthchecks.go:148] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 4 0
I0318 17:42:14.710874       9 healthchecks.go:148] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 5 0
I0318 17:42:14.710882       9 healthchecks.go:148] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 6 0
I0318 17:42:14.710890       9 healthchecks.go:148] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 7 0
I0318 17:42:14.710902       9 healthchecks.go:51] Running health check: dcgm -r 1
I0318 17:42:31.263319       9 healthchecks.go:306] DCGM test completed:
I0318 17:42:31.263361       9 healthchecks.go:322] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq result 0
I0318 17:42:31.263378       9 healthchecks.go:35] Running health check: ping
I0318 17:42:40.845089       9 healthchecks.go:246] Observation: 1/1 remote nodes are reachable
I0318 17:42:40.845123       9 healthchecks.go:78] Running health check: gpupower
I0318 17:42:41.512994       9 healthchecks.go:340] Power Throttle check test completed:
I0318 17:42:41.513023       9 healthchecks.go:362] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 0 0
I0318 17:42:41.513040       9 healthchecks.go:362] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 1 0
I0318 17:42:41.513046       9 healthchecks.go:362] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 2 0
I0318 17:42:41.513050       9 healthchecks.go:362] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 3 0
I0318 17:42:41.513060       9 healthchecks.go:362] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 4 0
I0318 17:42:41.513069       9 healthchecks.go:362] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 5 0
I0318 17:42:41.513074       9 healthchecks.go:362] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 6 0
I0318 17:42:41.513078       9 healthchecks.go:362] Observation: gdr-test-6p2kc-gdr-gpu-il-worker-3-fccnq 7 0
I0318 17:42:41.513087       9 healthchecks.go:102] Total time (s) for all checks: 58.398833183

I'm not sure really. Also, you're running a code that's not the main branch but it's in your local branch. So you should check what your code is doing because the link to the main branch's code doesn't say anything.
Also, the line was there in the original output, the one with all
I0318 16:00:51.094551       9 healthchecks.go:284] Observation: 1/1 remote nodes are reachable

so there was a problem to begin with.
I understand you fixed the bug in your branch

I'm looking at the change and I am not sure it's gonna work with that entire deletion of the all part.
Can you run a /status with and without a list of checks?

/status
/status?check=all
/status?check=pciebw,whateverelse

LOL, maybe all that was missing from the switch was a print statement. I may be blinded by ambition to remove duplicate code :D

You can let that code where it is and just focus on the env variable, so we merge that and move on

You are right, my previous change broke /status?check=all
But this fixes it https://github.com/jimcadden/autopilot/commit/c82ff4acbe7832f6308160f02aa040b74957a0a0


Fix ring version compatibility for cernan integration

Verified:

Cargo doesn't complain about dependencies when cernan uses this branch as a dependency.
The original repo actually builds.

Now, I may be a bit too reliant on Rust's typing, but as far as I'm concerned, this should be a change good enough?

Oh, another thing: I may want to bump up hyper's version too, perhaps? Can't really tell, unfortunately.

Just came up with a brilliant idea to run tests:
(venv) [dmitrydemeshchuk@local:~/yup-oauth2 (ring-version-compat)]> cargo test
 Downloading open v1.2.1
 Downloading getopts v0.2.15
 Downloading yup-hyper-mock v2.0.0
   Compiling open v1.2.1
   Compiling getopts v0.2.15
   Compiling yup-hyper-mock v2.0.0
   Compiling yup-oauth2 v1.0.5 (file:///Users/dmitrydemeshchuk/yup-oauth2)
error[E0433]: failed to resolve. Could not find `TlsClient` in `hyper_rustls`
   --> src/service_account.rs:297:86
    |
297 |         let client = hyper::Client::with_connector(HttpsConnector::new(hyper_rustls::TlsClient::new()));
    |                                                                                ^^^^^^^^^ Could not find `TlsClient` in `hyper_rustls`

error: aborting due to previous error

error: Could not compile `yup-oauth2`.
warning: build failed, waiting for other jobs to finish...
error: build failed

@doubleyou heh, yeah, the tests do tank some. I think the thing to do here is also upgrade hyper to 0.11 which, uh, will be a bit of a pain. What you have now will get you down the road for cernan since cernan won't run tests on its dependencies. Little more work needs doing to merge this upstream, I guess.


failed to connect to my clickhouse server

use docker-clickhouse-grafana to setup the env
and add my datasource to it,
it can connect to the server inside in same docker-compose.yml file,
but can't connect to my real server
the hint is:
lvl=eror msg="Basic auth failed" logger=context error="User not found"

Hi @tlightsky
Looks like your real server is behind some authentification system (likely basic auth) and datasource should be configured accordingly. So this is more question of configuring datasource in Grafana than datasource issue.
Keep in mind, that Grafana supports two ways of access to datasource: server and proxy. Server means that request to datasource will be send from Grafana backend, from instance where Grafana installed. Proxy means all requests will go through your browser. So if you able to query ClickHouse via your browser, Grafana can do that to.

thanks for reply,
maybe it's about the docker,
i'll try to run it in host and see can i get it work

deployed without docker, seems ok now, not sure why it doesn't inside docker


CrackProjectUsingNewBuildAPI problem

F#-project files have this XML:
  <Choose>
	<When Condition="'$(VisualStudioVersion)' == '11.0'">
	  <PropertyGroup Condition="Exists('$(MSBuildExtensionsPath32)\..\Microsoft SDKs\F#\3.0\Framework\v4.0\Microsoft.FSharp.Targets')">
		<FSharpTargetsPath>$(MSBuildExtensionsPath32)\..\Microsoft SDKs\F#\3.0\Framework\v4.0\Microsoft.FSharp.Targets</FSharpTargetsPath>
	  </PropertyGroup>
	</When>
	<Otherwise>
	  <PropertyGroup Condition="Exists('$(MSBuildExtensionsPath32)\Microsoft\VisualStudio\v$(VisualStudioVersion)\FSharp\Microsoft.FSharp.Targets')">
		<FSharpTargetsPath>$(MSBuildExtensionsPath32)\Microsoft\VisualStudio\v$(VisualStudioVersion)\FSharp\Microsoft.FSharp.Targets</FSharpTargetsPath>
	  </PropertyGroup>
	</Otherwise>
  </Choose>
  <Import Project="$(FSharpTargetsPath)" />

Now, if the condition, Exists('$(MSBuildExtensionsPath32)..., fails for any reason, the FSharpTargetsPath will be empty, and the import is Import Project="" which will cause MSBuild to throw an exception "InvalidProjectFileException" and FSharp.Compiler.Service will rethrow this even if the project-file itself is not invalid at all, it is just what the default F#-Project is: Actually service.fs CrackProjectUsingNewBuildAPI could well parse the information it needs: items, project references, dll-references, etc. So at least the exception name is wrong in this case.
Well, Microsoft.FSharp.Targets would import the projects default target, "Build", so I guess that is needed at some point when the project is compiled. But now when the compiler API is open source, some projects do the API-calls without the actual compilation:
  let projectFile = SourceCodeServices.FSharpProjectFileInfo.Parse(file)

@Thorium the import is actually quite important, because the function SourceCodeServices.FSharpProjectFileInfo.Parse is fully resolving all the assembly references, which is what it uses MSBuild for. These are needed to give the correct compilation context back to the compiler services when requesting type information etc. If you look more at the implementation, you will see that the "Build" target is in fact called, although with a stubbed compiler.
It's interesting to know when this fails, could you give some information on that?

Maybe its similar to my issue where MSBuildExtensionsPath32 is something completely different to what you expect.  Ive been scratching my head over the last few days trying to get to grips with whats going wrong...

I think @Thorium is on Windows though, because he's using the "NewBuildAPI". Hopefully MS aren't messing around with that variable too!

Yes, my environment is Win 8.1 (and VS 2015 RC, so F# 4.0?), but I was opening an F#-file with SublimeText editor which called this Parse-method.

@Thorium I don't have a VS2015 machine myself, so this is rather difficult for me to test, but I don't think that this is supported by the current version of FCS (which is F# 3.1, MSBuild 12).
There is a beta F# 4.0 version at https://www.nuget.org/packages/FSharp.Compiler.Service/1.4.0-beta, but we still do not have a great story for switching MSBuild versions, so I'm not confident this would be easy for you to debug if you had the time to try.

I downloaded the FsAutoComplete source codes and updated the nuget package reference of FSharp.Compiler.Service to this 1.4.0 beta and it seems not to fail.
Also one way to test MSBuildExtensionsPath32 is just to add directly to the projectfile (before the usage) the line:
 <MSBuildExtensionsPath32>C:\Program Files (x86)\MSBuild</MSBuildExtensionsPath32>

Thanks for testing! I will look at doing an official release with that
version if it works on Linux.
On 17 Jul 2015 09:51, "Tuomas Hietanen"<EMAIL_ADDRESS>wrote:

I downloaded the FsAutoComplete source codes and updated the nuget package
reference of FSharp.Compiler.Service to this 1.4.0 beta and it seems not to
fail.
Also one way to test MSBuildExtensionsPath32 is just to add directly to
the projectfile (before the usage) the line:
C:\Program Files (x86)\MSBuild
—
Reply to this email directly or view it on GitHub
https://github.com/fsharp/FSharp.Compiler.Service/issues/379#issuecomment-122207681
.

Now that the FSharp.Compiler.Tools has been released, you could just add that nuget package to the solution and reference something like this in the .fsproj-file:
<FSharpTargetsPath Condition="'$(FSharpTargetsPath)' == ''">..\Packages\FSharp.Compiler.Tools\Microsoft.FSharp.Targets</FSharpTargetsPath>

@Thorium that's a very interesting suggestion, thanks. I wasn't aware of the contents of the FSharp.Compiler.Tools package. Wouldn't this require changing every project file that you wanted to use with FSAC though?

That API call still needs to be done in a separate process, to avoid dll loading pollution, and so that is works with all project types.

On 26 Jul 2015, at 13:11, Robin Neatherway<EMAIL_ADDRESS>wrote:
@Thorium that's a very interesting suggestion, thanks. I wasn't aware of the contents of the FSharp.Compiler.Tools package. Wouldn't this require changing every project file that you wanted to use with FSAC though?
—
Reply to this email directly or view it on GitHub.

Yes, I agree that would be an improvement, but I'm interested in making sure it works with machines that only have VS2015 installed right now, which is a separate problem I think. In fact, I wonder how it works at all right now, because I'm not sure how VisualStudioVersion gets set, and therefore what value for it will be inserted in the path:
<FSharpTargetsPath>$(MSBuildExtensionsPath32)\Microsoft\VisualStudio\v$(VisualStudioVersion)\FSharp\Microsoft.FSharp.Targets</FSharpTargetsPath>


X86 subregister issues

I was working on a project to automatically fill in missing X86 semantics from the output of Strata where such instructions exist (see https://stefanheule.com/s/projects/strata/ if you're curious about Strata). When I got to looking at the semantics of the subregister selection, it seems to me that the current implementation of subregisters in mcsema is ... broken.
In amd64 code, touching the (e.g.), rax register via only eax will clear the top 32 bits of the register, while the other subregisters (ax, ah, al) will preserve all untouched bits. However, mcsema is modelling the subregister loads as subsets of the actual register, which means that the clear of the upper 32 bits isn't happening. For the YMM and ZMM registers, the effect appears to depend on the actual opcode used (the SSE stuff, i.e., the two-address code stuff appears to leave them unchanged while the AVX stuff, with the three-address codes, appears to zero them).

Hmm, so mcsema should do partial regs correctly -- i am having some issues accessing my dev machine or I'd do a test on a real binary, but the code is there to do it:
First, each register is split into subregisters, with a read type and a write type, and the write type for the 32-bit subregisters is 64-bits:
https://github.com/trailofbits/mcsema/blob/2bd02594852e3c54c0e31584d2a30f01c4a6cc7a/mcsema/Arch/X86/Register.cpp#L118-L122
Then during a write,  things eventually filter to GENERIC_MC_WRITEREG which compares the value type to the destination type, and zero extends or truncates as necessary. For 32-bit writes, the destination type should be 64-bits:
https://github.com/trailofbits/mcsema/blob/28666afcb7ecddd27099c406956cb59dde661a86/mcsema/BC/Util.cpp#L182

jcranmer, you may be able to switch to the use_remill_semantics branch. It supports mmx, x87, sse, avx, and can support avx512. It does the proper zero extension for all the various cases.

@jcranmer can you identify a case where the wrong value type is passed to this function? https://github.com/trailofbits/mcsema/blob/28666afcb7ecddd27099c406956cb59dde661a86/mcsema/BC/Util.cpp#L182

Okay, I did do a test to see if the subregister support was working correctly. I didn't see that the Register.cpp defined EAX as a 64-bit register for writes (which is really easy to miss). The test program I used was (this feels like the sort of thing that should be added to the tests just to make sure no one misses it):
#include <stdint.h>
#include <stdio.h>

#define CHECK_ASM(str) \
  do { \
    uint64_t val = 0x0123456789abcdefull; \
    asm("mov %1, %%rax\n" \
        "add $1, %%" str "\n" \
        "mov %%rax, %0" : "=r"(val) : "r"(val) : "rax"); \
    printf(str ": 0x%016llx\n", (unsigned long long)val); \
  } while (0)
int main() {
  CHECK_ASM("al");
  CHECK_ASM("ah");
  CHECK_ASM("ax");
  CHECK_ASM("eax");
  CHECK_ASM("rax");
  return 0;
}

@pgoodman : is the use_remill_semantics branch meant to replace the master branch eventually?

@jcranmer Check out the instruction testing system here: https://github.com/trailofbits/remill/tree/master/tests/X86
There are usually more than one test per encoding of each instruction, where each test will contain several input variants. Each such variant is tested once with all aflags set, and once without. Some instruction tests operate on the stack, where all bytes of the stack are randomized. Instructions using the XMM and YMM registers also benefit from mostly randomized values in those registers, as ways of validating zero-extension, among other things.
It's possible that the set of Remill instruction unit tests would be excellent for automatically inferring the semantics of x86 instructions.
In the medium term, mcsema will be translating over to using Remill's semantics. This is for x86, ARM, and MIPS. This work is scattered about. On the mcsema side, it's in the use_remill_semantics branch. On the Remill side, there are a few working branches that restrict the scope of Remill to focus on instruction translation, and forks of this branch for ARM- and MIPS- specific work.

@jcranmer I am pretty excited about possible integration with Strata. What do you think about using Strata on non-X86 architectures? We could take this to e-mail if you want.

The ideas of Strata could easily be ported to other architectures, but the current implementation relies very heavily on STOKE, which is tied to x86 pretty heavily in implementation. I've been rewriting Strata to build on top of LLVM as much as possible rather than STOKE, but it's so far mostly geared towards taking the existing output to MCSema semantics. What you would need for a new architecture is:

list of instructions (Strata doesn't attempt to deal with memory operands, e.g., or crypto stuff)
list of base instructions, and semantics for these (I've been representing them as LLVM IR)
a register description (LLVM's register list is too general, unfortunately)
an assembler and execution oracle

If you want to avoid STOKE (which you'd definitely need to do for a new architecture), you'd also have to provide some of its features:

The stochastic search
SMT verification of correctness

Given that the goal is decompilation to LLVM, it's probably easiest to frame a replacement not in terms of "find an equivalent assembly program to this assembly instruction" but rather "find an equivalent LLVM program to this assembly instruction." There's definitely some tools somewhere that would convert LLVM IR to SMT expressions for a solver, so the hardest bit would be reimplementing the stochastic search.


feat: Liftover callsets from hg19/GRCh37 to hg38/GRCh38

Still a WIP, just added some code I took from the bcftools liftover plugin.
Edit: We decided to use the Picard Tool!
Open questions include

[ ] using docker since conda not available for plugin
[ ] how to download references, where to store
[ ] when to do the liftover (ideally as first rule?)

(New PR since old one included commits from other feature).

Picard LiftoverVcf works: http://broadinstitute.github.io/picard/command-line-overview.html#LiftoverVcf
Rename contigs beforehand with: https://github.com/dpryan79/ChromosomeMappings/blob/master/GRCh37_UCSC2ensembl.txt
java -jar picard.jar CreateSequenceDictionary  -R genome.fasta -O genome.dict

java -jar picard.jar LiftoverVcf  -I input_renamed.vcf  -O lifted_over.vcf  --CHAIN GRCh37_to_GRCh38.chain.gz      --REJECT rejected_variants.vcf -R genome.fasta

Chain: wget http://ftp.ensembl.org/pub/assembly_mapping/homo_sapiens/GRCh37_to_GRCh38.chain.gz

Liftover works for the hg19 callsets from Heidelberg


Per RFC 2822, emails should not contain consecutive dots. Resolves part of #279.

Emails should not contain consecutive dots. I have updated the treetrop grammar and fixed the spec.
Cheers,
Poet

Thanks for this.


Auto GEMM tuning with rocBLAS

Implements a new feature in the rocBLAS API to tune GEMM solutions automatically.  The finalize() method calls a new tune() method which simply iterates through the list of available solutions, timing them all and choosing the fastest.
This PR is incomplete at this time--changes are still in progress.
  It is enabled with the preprocessor value ROCBLAS_BETA_FEATURES_API, which is set by CMakeLists.txt if the needed rocBLAS version is installed at compile time.
Update: verified that the PR can be built using the Rocm ver 5.5 API and the internal_testing image is no longer needed.  Set the following line in Dockerfile: RUN sh -c 'echo deb [arch=amd64 trusted=yes] http://repo.radeon.com/rocm/apt/.apt_5.5/ ubuntu main > /etc/apt/sources.list.d/rocm.list'
See issue 1553

These are the tidy warnings I get using make tidy-target-migraphx_gpu-gemm_impl_cpp(which will only run tidy on the gemm_impl.cpp):
/data/src/targets/gpu/gemm_impl.cpp:421:16: error: invalid case style for local variable 'bestTime' [readability-identifier-naming,-warnings-as-errors]
        double bestTime   = std::numeric_limits<double>::max();
               ^~~~~~~~
               best_time
/data/src/targets/gpu/gemm_impl.cpp:424:21: error: invalid case style for local variable 'bestSol' [readability-identifier-naming,-warnings-as-errors]
        rocblas_int bestSol = 0;
                    ^~~~~~~
                    best_sol

Closed because of corrupted merge; replaced by PR 1668


Memory Issues

I am having some memory (RAM) issues with bedrock worlds when modifying a large number of chunks. It fills up between 5 and 10GB modifying 10,000 chunks which is not ideal. The data in memory then persists even after the world is saved to disk.
I want to do some debugging to find where the large variables are but I can't find anything particular large. Are there any easy ways I can find where these large variables are?

It mostly depends on how we are storing the various information. I know for Anvil Worlds we use a numpy array of Chunk objects for chunks and then another numpy array for blocks in that specified Chunk object, not sure how we store if for Bedrock/LevelDB, that'd be a question for @LaChal.

The Bedrock/LevelDB implementation work also like Anvil/Java worls.
Data is stored in numpy arrays (sort of data structures).
The fact is these operations are done in memory, so, bigger the area you want to change is, bigger the amount RAM is.
When you close MCEdit, the RAM shall be released.
Yo can use a "hidden" command line parameter to get a huge amount of information about PE support, but be warned it can create a monstrous log file: --debug-pe

I see similar RAM usage between MCPE and PC versions. Is there maybe a specific operation that takes a lot of RAM for PE and less for PC? If that happens, please tell us the specific operation which causes this issue since just opening the map does not show big RAM usage, for me, at least.


Update MimaPreviousArtifacts with newest versions

Some versions were missing in the list that are currently released.

Codecov Report

Merging #301 (35010d0) into master (65997c0) will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #301      +/-   ##
==========================================
- Coverage   95.31%   95.23%   -0.08%
==========================================
  Files           6        5       -1
  Lines          64       63       -1
==========================================
- Hits           61       60       -1
  Misses          3        3

Impacted Files
Coverage Δ

...3-/main/scala/io.circe.config/compat/package.scala

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65997c0...35010d0. Read the comment docs.


CSCETSIN-96: Call reindex or delete

When RabbitMQ receives a message, it calls either ElasticSearch reindex or delete.

There seems to be conflicts which git is unable to resolve before merging can be done


Issue 6316 replace logo

Fixes #6316
Changes proposed in this pull request:

use logo-gem-126.svg replace logo-gem-126.png

@Sophia3287 thanks for this! It looks like you have used the same branch to submit two different pull requests (this one and #6618), meaning that both PRs contain unrelated changes. You can see that with the list of commits on this page, as well as in the "Files changed" tab of each PR. Could you try again and submit PRs that only contain the changes they describe?

Hi, thank you for pointing this out, we are really sorry about that. Right now I tried to revert the unrelated commits under these two pull requests, is that okay or we better create the new pull requests again? Thanks for your help.

I think it's probably better to create new pull requests. In general, the workflow I would recommend would be to:

don't push any of your own commits to the master branch of your fork
create one branch for each PR, branching off from the master branch of your fork
from time to time, you can use the "Sync" button in GitHub to update your master branch to the master branch of the upstream repository

Ok I got this, thank you for your help

Superseded by #6620.


Where possible use SQL functions over plpsql

SQL functions are faster to execute, can be inlined, and report more errors at compile time instead of run time.

+1

SQL functions are faster to execute, can be inlined, and report more errors at compile time instead of run time.
👍 1

Always wondered whether pgsql or SQL is faster...thanks for clearing this up.
So as rule of thumb - as long as you can get away with SQL don't resort the pgsql?
We also have a lot generated code of functions that just map many values to one that are all pgsql that I can easily switch over to SQL.

So as rule of thumb - as long as you can get away with SQL don't resort the pgsql

As a general rule, use SQL when possible, not just for execution cost, but you tend to write in a way better suited for SQL. There are exceptions to this when a plpgsql function that consists only of a single SQL statement is faster.
For function calling costs, c < plpgsql < other languages


DynamicTexture: add sanity check in dispose

See https://forum.babylonjs.com/t/detached-element-memory-leak-when-disposing-dynamic-textures/46668/4

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Snapshot stored with reference name:
refs/pull/14657/merge
Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14657/merge/index.html
To test a playground add it to the URL, for example:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14657/merge/index.html#WGZLGJ#4600
Links to test babylon tools with this snapshot:
https://playground.babylonjs.com/?snapshot=refs/pull/14657/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/14657/merge
https://gui.babylonjs.com/?snapshot=refs/pull/14657/merge
https://nme.babylonjs.com/?snapshot=refs/pull/14657/merge
To test the snapshot in the playground with a playground ID add it after the snapshot query string:
https://playground.babylonjs.com/?snapshot=refs/pull/14657/merge#BCU1XR#0


add some tests, fix steam folder issue

Bugs include:

allowing the user to create games with no name
icon not refreshing sometimes in sidebar on change

also fixes issue in #92


Query: Cast should cause materialization so we can actually compute r…

…esults
Issue: Since we were doing Count, we did not mark QS for materialization. So we were effectively doing casting of ValueBuffer.
This worked fine for Sync pipeline since Cast on Enumerable takes non generic Enumerable so we were able to pass Enumerable
But for async Cast takes IAsyncEnumerable hence parameter type mismatch.
Since we need to generate correct result from casting, Cast causes materialization. If casting is to same type then it won't cause client eval.
Resolves #11596

@dotnet-bot test windows release x64 build


The value of "version" in "pyproject.toml" is inconsistent with the GitHub tag

The version in pyproject.toml is inconsistent with the tag on Github, with former being 0.0.1 and the latter 1.0.0. They should be consistent.

solved via GitHub action


Replace Box::pin to futures_enum::Stream

depend on: #1102

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

8 of 8 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.0001%) to 98.796%

Totals

Change from base Build<PHONE_NUMBER>:
-0.0001%

Covered Lines:
39719

Relevant Lines:
40203

💛  - Coveralls


Xrdp pcsc1

Thanks for this @last1284
I agree that the PCSC situation isn't ideal at the moment. However, this area still needs a lot of work before it's production ready.
I think what I'll do before we drop the next major release is pull in @zorgluf's changes, but place all the PCSC code under an --enable flag. That should let people at least us it, and we can start looking into ironing out some of the issues.
Can I ask you to separate out your keyboard change into a separate PR? That's not at all contentious, and we can merge it quickly.


⚠ Jenkins Plugins Artifactory has degraded performance

In 1821795, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1127 ms

Resolved: Jenkins Plugins Artifactory performance has improved in 3ac2f81 after 12 minutes.