Access just the types of the handlers

Kiota opted for it's own HttpClientFactory, which is fine. But I would like to integrate with dependency injection and start using Microsoft.Extensions.Http as a source for the HttpClient. To keep all the Kiota goodies like (header inspection) I need to register all the Kiota handlers as well.
For that I only need the types of the handlers, and not the instances. Would it be possible to have an extra static method just for that?
Instead of this:
https://github.com/microsoft/kiota-http-dotnet/blob/0212e818931b31a2d9e0ab4d768b31f23fe5f386/src/KiotaClientFactory.cs#L50-L62
I would like to see, as this does not initialize those classes.
 public static IList<Type> DefaultHandlerTypes()
 {
     return new List<Type>
     {
         //add the default middlewares as they are ready
         typeof(UriReplacementHandler<UriReplacementHandlerOption>),
         typeof(RetryHandler),
         typeof(RedirectHandler),
         typeof(ParametersNameDecodingHandler),
         typeof(UserAgentHandler),
         typeof(HeadersInspectionHandler),
     };
 }

For other readers, this is the context this request comes from
I think this is a reasonable request, especially if we collocate the new method next to the create one.
From a naming convention perspective, it should be prefixed with a Get.
Is this something you'd be willing to submit a pull request for @svrooij ?

Love this idea!

And related to this, do you ever expect the UriReplacementHandler<UriReplacementHandlerOption> to have other options @sebastienlevert? The generic is a bit in the way to make this happen. And the constructor for this one is using = default while all the others use = null. The first one doesn't play nice with dependency injection, but that could also because of the generic.

@calebkiage might be able to add more context on why the option is a generic type parameter and what scenarios he was trying to enable making it generic here. #158

@svrooj, the IUriReplacementHandlerOption is an extensibility point. For example, a user could decide to implement it and then change IsEnabled to be conditional on different circumstances. The default implementation of UriReplacementHandlerOption has a fixed value for IsEnabled for each instance passed to the constructor. It's also possible to change the Replace function's logic through a different implementation. The UriReplacementHandler is generic to allow swapping out the type of IUriReplacementHandlerOption. What problems are you having with the DI setup?

@calebkiage I'm trying to document how you can use Microsoft.Extensions.Http and dependency injection in general with Kiota. @baywet suggested that it was a bad idea to document a static list of handlers. So I tried injecting the types, from CreateDefaultHandlers() using .Select(x => x.GetType()).
https://github.com/MicrosoftDocs/openapi-docs/pull/89/files#diff-cb6707ca7707710dabba9df2adea67478eb3301978ebd9f451e539ba99a98a60R160-R178
But it does not take it, won't resolve the UriReplacementHandler<UriReplacementHandlerOption>, not sure if it has to do with the constructor having = default instead of = null or with the generic being in the way.
Without the generic type and with =null constructor, it could resolve the handler without options unless the developer explicitly added the UriReplacementHandlerOption to the DI container as well.

I suspect the root cause here might be the UriReplacementHandlerOption not having a default constructor. The dependency graph of UriReplacementHandler would be:
                          UriReplacementHandler
                                   |
                     UriReplacementHandlerOption
                                   |
            ----------------------------------------------
            |                                            |
          bool                              IEnumerable<KeyValuePair<string, string>>

The DI library won't know how to create an instance of UriReplacementHandlerOption because it can't resolve the constructor parameters.
I'd need to create a project to reproduce this and investigate. @svrooij, if you have a project on GitHub, I can just use that to quickly reproduce the issue and provide my suggestions.
@baywet, your idea would work, but we also need the derived handler to provide a default value for the option type

Right, we could start with the constructor and see if that fixes things by just adding another constructor
public UriReplacementHandlerOption(bool isEnabled = true):this(isEnabled, new Dictionary<string, string>())


Adding Actions to the Toast

HI Sebastian,
You might remember you helped me last week. I've been able to overcome that issue with your guidance, thank you.
I am now trying to implement buttons/actions on the toast.
In the component, I call the service
customer.component.ts
this.toastService.actionToast("Test", "Test");
Then in the service,  I've adapted your code to take Action EventType and showButtons parameter:
toast.service.ts
  actionToast(title: string, message: string) {
    this._toastEvents.next({
      title: title,
      message: message,
      type: EventTypes.Action,
      icon: "../../../../assets/img/action-toast.png",
      errorCode: "",
      showButtons: true
    });
  }

I have also added the two buttons to the toast, with *ngIf
toast.component.html

    {{title}}
    <button type="button" class="btn-close" aria-label="Close" (click)="hide()"></button>

{{message}}

 {{errorCode}}

    <button type="button" *ngIf="showButtons" (click)="yes()">Yes</button>
    <button type="button" *ngIf="showButtons" (click)="no()">No</button>

I would like to emit the Yes and No events back to the original calling component via the ToastService. I have added
toast.component.ts
@Output() onYes: EventEmitter<any> = new EventEmitter();
.
.
.
  yes() {
    this.onYes.emit();
    this.hide();
  }
.
.
.

But I am not sure how to "listen" to the emitter from the ToastService. Any suggestions?
Thanks!
Shai

Hi, glad I could help you with your last question. However, I think this is a bit beyond the scope of my original project. Nevertheless, if you want to send the events not only to the toaster parent component, like for "dispose" of the individual toasts, but to the original component that created the toast initially, then you have to do it differently. For example, take a close look at how this was done with the toast events in the toast service and how the toaster component subscribed to those. There are good ways to solve this with rxjs. But that's all I would give you at this point, since it's not directly a functionality or bug of this repo, I hope you understand that.

Perfect, thank you!


Wagtail: Error Update

This pull request is to replace an older validation error with its newer version for when we update wagtail. The point is to make sure when new page previews are being made incorrectly the error is still reported correctly.

Changes
instead of using ValidationError in atoms molecules and organisms, we will now use StructBlockValidationError. It functions more or less the same, the big differences is the removal of the first string and changing params into block_errors
How to test this PR
1.go to the admin wagtail page
2.click add a new page
3. create an error in the page like adding a red header with no header and click preview
4. there should be an error on the header now saying a header is required
Screenshots
Notes and todos

Checklist

[ ] PR has an informative and human-readable title

PR titles are used to generate the change log in releases; good ones make that easier to scan.
Consider prefixing, e.g., "Mega Menu: fix layout bug", or "Docs: Update Docker installation instructions".

[ ] Changes are limited to a single goal (no scope creep)
[ ] Code follows the standards laid out in the CFPB development guidelines
[ ] Future todos are captured in comments and/or tickets
[ ] Project documentation has been updated, potentially one or more of:

This repo’s docs (edit the files in the /docs folder) – for basic, close-to-the-code docs on working with this repo
CFGOV/platform wiki on GHE – for internal CFPB developer guidance
CFPB/hubcap wiki on GHE – for internal CFPB design and content guidance

Front-end testing

Browser testing
Visually tested in the following supported browsers:

[ ] Firefox
[ ] Chrome
[ ] Safari
[ ] Edge 18 (the last Edge prior to it switching to Chromium)
[ ] Internet Explorer 11 and 8 (via emulation in 11's dev tools)
[ ] Safari on iOS
[ ] Chrome on Android

Accessibility

[ ] Keyboard friendly (navigable with tab, space, enter, arrow keys, etc.)
[ ] Screen reader friendly
[ ] Does not introduce new errors or warnings in WAVE

Other

[ ] Is useable without CSS
[ ] Is useable without JS
[ ] Does not introduce new lint warnings
[ ] Flexible from small to large screens

I think we should drop 2cce3ff, 844c9c5, 5b8e5bd, 7f37468, 1a16068 from this branch. Let me know if you need any help with that!


Docs-openstack-unsupported

Add OpenStack unsupported for VXLAN and IP-in-IP

Approved by Neil (https://tigera.slack.com/archives/CC08CBB43/p1668797414425539)
Moved other limitation to align with standards

@bmckercher123 & @nelljerram -- can we have some more context about why this is marked as "unsupported"?  AFAIK, OpenStack can carry ipip traffic just fine and we use it to deploy Calico with the Cluster API and Magnum.

Hi @mnaser .  I just reviewed our discussions from the time, and they went like this:

me: I feel embarrassed for asking this, but can anyone remind me if we support VXLAN or IPIP encaps with OpenStack? (and if so, how does that work without IPPools?)
colleague1:
I don't think so, we never tied our IPAM to OpenStack's.  Maybe IPIP would "just work" if you created an IPPool that overlapped the OpenStack network?  I don't remember either!
colleague2:
I thought we added encap after we changed to k8s. I.e openstack doesn't support encap. The way to check is to look at calico-test - if we don't have a way to set it up in there, it's not an openstack feature.

In other words, the concerns were:

Primarily, that we don't system test Calico with OpenStack and IPIP (or VXLAN) ourselves, and hence can't immediately be sure that it works like that, and doesn't accidentally regress when we make a new Calico release.  (Whereas we absolutely do cover this for Kubernetes.)

Secondly, uncertainties about how the IPAM would work.

I'm not sure precisely what the (2) concerns were, but thinking it through a bit now...

OpenStack allocates an IP for each VM.

Suppose VM A communicates with VM B, on a different compute host.  On A's host something needs to set up a routing rule like <VM B IP> via <VM B's host's tunnel IP> dev tunl0 onlink (and vice versa).  Our BIRD fork can do that, but in our Kubernetes product it involves BIRD configuration that is generated by another part of the calico-node pod (confd), and that in turn depends on an IPPool having been configured with ipipMode: Always or ipipMode: CrossSubnet.  That all just works with Kubernetes, but (as far as I recall) we've never documented how someone would need to put together an equivalent solution for OpenStack.

Does that help?  How does it mesh with your experience?

Thank you for your response. There would be two ways that this can work:

Without encap (not really recommended): you can disable port security on the network or ports assigned to the VM (if you own the network the VMs are connected to).  By doing this, it will allow traffic to egress/ingress over the server with any src/dst IP which would allow native IP routing.  There is also an allowed address pairs settings which allows you to configure pairs of MAC addresses and CIDRs allowed on the host (a stricter version of disabling port security pretty much). I don't recommend/like this too much because you are opening up for other potential issues.

Encap: OpenStack can transport encap traffic (in this case I know for a fact ipip traffic works). With this setup, everything works out of the box if we just allow ipip traffic. I suspect vxlan allowing the UDP port for it would also work.

We deploy as part of our CI: Kubernetes with CAPI on top of OpenStack, install Calico and run Sonobuoy and everything passes all the time.

Hang on, it it possible that you are talking at cross purposes?  @nelljerram is talking about Calico being an neutron plugin for Openstack itself, while (IIUC) you are talking about running a kubernetes cluster using Calico CNI on Openstack VMs.
Those are quite different scenarios.

@lwr20 I am talking about a Kuberentes cluster using Calico CNI for Kubernetes running inside OpenStack VMs.
https://docs.tigera.io/calico/latest/networking/configuring/vxlan-ipip
Under the "Before you begin" section, it lists OpenStack as not supported.  Could that maybe be revised to say "Calico for OpenStack" since that seems to imply that you cannot run Calico on top of OpenStack VMs running Kubernetes.

Could that maybe be revised to say "Calico for OpenStack" since that seems to imply that you cannot run Calico on top of OpenStack VMs running Kubernetes.

That would seem sensible, if @nelljerram confirms that I've interpreted what they're talking about correctly.

Sorry for the delay.  Yes, my comments above were only for OpenStack in its own right.  As things stand, we don't have any documentation that specifically covers Calico CNI for Kubernetes inside OpenStack VMs

either where we are just treating the OpenStack layer as generic infrastructure
or in the special case where Calico is also being used as the Neutron plugin.

@mnaser I'll post a PR for your suggested clarification.


Use this plugin with SASS @include and @extend

Hi, thanks for this plugin! Maybe you'll help me, how I can use this plugin with SASS @include and @extend?
@mixin mixin {
  font-size: 15px;
}

.class {
  @include mixin();

  position: absolute;
  display: block;
  margin: 0;
}

In this case stylint will throw an error. Is there a way to avoid it?

Are you also using stylelint-config-sass-guidelines or something similar?


artik710 - generate a sd fuse image fails with "recipe for target 'drivers/gpu/arm/mali400' failed"

I am running this command - ./release.sh -c config/artik710_ubuntu.cfg and the build fails with error:
 CC [M]  drivers/gpu/arm/mali400/common/mali_pm.o   CC [M]  drivers/gpu/arm/mali400/common/mali_pmu.o   CC [M]  drivers/gpu/arm/mali400/common/mali_user_settings_db.o   CC [M]  drivers/gpu/arm/mali400/common/mali_kernel_utilization.o   CC [M]  drivers/gpu/arm/mali400/common/mali_control_timer.o   CC [M]  drivers/gpu/arm/mali400/common/mali_l2_cache.o   CC [M]  drivers/gpu/arm/mali400/common/mali_timeline.o   CC [M]  drivers/gpu/arm/mali400/common/mali_timeline_fence_wait.o   CC [M]  drivers/gpu/arm/mali400/common/mali_timeline_sync_fence.o   CC [M]  drivers/gpu/arm/mali400/common/mali_spinlock_reentrant.o   CC [M]  drivers/gpu/arm/mali400/common/mali_pm_domain.o   CC [M]  drivers/gpu/arm/mali400/linux/mali_osk_pm.o   CC [M]  drivers/gpu/arm/mali400/linux/mali_pmu_power_up_down.o /bin/sh: 1: Syntax error: Unterminated quoted string drivers/gpu/arm/mali400/Kbuild:261: recipe for target 'drivers/gpu/arm/mali400/__malidrv_build_info.c' failed make[4]: *** [drivers/gpu/arm/mali400/__malidrv_build_info.c] Error 2 scripts/Makefile.build:403: recipe for target 'drivers/gpu/arm/mali400' failed make[3]: *** [drivers/gpu/arm/mali400] Error 2 scripts/Makefile.build:403: recipe for target 'drivers/gpu/arm' failed make[2]: *** [drivers/gpu/arm] Error 2 scripts/Makefile.build:403: recipe for target 'drivers/gpu' failed make[1]: *** [drivers/gpu] Error 2 Makefile:961: recipe for target 'drivers' failed make: *** [drivers] Error 2 ERROR in ./release.sh : line 195 with exit code 2
It happens on A710_os_3.0.0 branch and on A710_os_2.2.0 branch as well.
The issue occurs after following the Build guide, and without any changes to the repository.

Hi,
Please describe your development environment.
It seemed shell environment error or somethings missing.
Could you try again after changing the ubuntu shell script to bash.
sudo dpkg-reconfigure dash
-> select bash

I get the same error after changing to bash.
Can you tell me exactly what you want to know about my environment ?
The error comes from this line :
@echo 'const char *__malidrv_build_info(void) { return "malidrv: $(VERSION_STRINGS)";}' > $(srctree)/$(src)/__malidrv_build_info.c
VERSION_STRINGS includes VERSION_STRINGS += BUILD_DATE=$(shell date) . When i run date in my shell i get local date with Hebrew characters "ב' אוק  9 09:29:43 IDT 2017",  could this be the issue?

Hi,
I think "svn" command has a potential problem. Could you try again after you remove the subversion?
sudo apt-get remove subversion

Sorry for the delayed response.
I Removed svn as you suggested and i got this error :

CC [M]  drivers/gpu/arm/mali400/common/mali_spinlock_reentrant.o
CC [M]  drivers/gpu/arm/mali400/common/mali_pm_domain.o
CC [M]  drivers/gpu/arm/mali400/linux/mali_osk_pm.o
CC [M]  fs/nfs/nfs3client.o
CC [M]  drivers/gpu/arm/mali400/linux/mali_pmu_power_up_down.o
/bin/sh: -c: line 0: unexpected EOF while looking for matching `"'
/bin/sh: -c: line 1: syntax error: unexpected end of file
drivers/gpu/arm/mali400/Kbuild:261: recipe for target 'drivers/gpu/arm/mali400/__malidrv_build_info.c' failed
make[4]: *** [drivers/gpu/arm/mali400/__malidrv_build_info.c] Error 1
make[4]: *** Waiting for unfinished jobs....

CC [M]  net/bridge/br_stp_if.o
CC [M]  fs/nfs/nfs3xdr.o
CC [M]  fs/nfs/nfs4proc.o
CC [M]  net/bridge/br_stp_timer.o
CC [M]  net/bridge/br_netlink.o
CC [M]  fs/nfs/nfs4xdr.o

Could you try it after installint the 'bc' package?
sudo apt-get install bc


[SMALLFIX] Java 8 Improvement: replace anonymous type with lambda in alluxio.worker.block.BlockMasterClient#heartbeat #289

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/623/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/625/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/627/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/628/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/629/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/631/
Test FAILed.


add some feature

full multi language support in user interface(test zh-cn only, use i18next)
add/edit/delete task(already test by myself, but still has some small bug and css style problems)
css style improvement.

Recently, I fix some problem in styles.css and edit task.this pr may not the latest version i want to submit.
i request a new pr for this.


[bug] After switching to other pipette, current pipette fails to home if other was just homed.

I'm using the Jupyter notebook to test movement commands on API v2.9.
The following code creates unexpected (at least to me) and dangerous behaviour, that is the previously used pipette stays at its current Z height instead of homing before movement.
import opentrons.execute
from opentrons.types import Point, Location
protocol_context = opentrons.execute.get_protocol_api('2.9')

pipette_20 = protocol_context.load_instrument(
        "p20_single_gen2", mount='left', tip_racks=[])
pipette_300 = protocol_context.load_instrument(
        "p300_single_gen2", mount='right', tip_racks=[])

protocol_context.home()
pipette_20.move_to(Location(Point(224,230,139.9), None), speed=100, minimum_z_height=130)

# this line is causing the erroneous behaviour during the next line
pipette_300.home()

# This line normally would first home the "20 ul pipette" before moving, however due to the .home() previously, it forgets to do so
pipette_300.move_to(Location(Point(224,230,139.9), None), speed=100, minimum_z_height=130)

At the end of this, both pipettes are at a "low" position, which as far as I understand should never happen.
Server version: 4.1.1
Firmware Version: v1.1.0-25e5cea
As a related feature request, it would be great if during normal behaviour, instead of fully "homing" the "other" pipette (which takes forever to check with the limit switches), it would simply raise it - I understand it's better to check everything from hardware instead of software, but it would be great to have a "dangerous" mode for people who like to go fast :)

Thanks for reporting this! I'm labeling this ticket for our own internal tracking purposes, but we haven't taken a close look at this yet.

After playing around a bit more, I think the reason for the bug is that the "instrument_context.home()" command likely sets a "homed" flag for both instruments (instead of just the one), and instruments that are already homed (correctly) do not need to re-home before another instrument is being used.

Confirmed that this is still a problem on v6.0.0-beta.1.

Unintentionally closed

Fix will be present in the upcoming v6.1.0 release. You will need to update your protocol to use Protocol API version 2.13 to start using the corrected behavior


[SUPPORT]Flink 1.16

Use the Flink 1.16 SQL getway feature and expect to support Flink 1.16
@danny0405

filed https://issues.apache.org/jira/browse/HUDI-5205

Cool, would support that if the 1.16.1 released.


Createfile fails with error code 5 in test application

Can you suggest why createfile fails for testvmulti.exe ?
Any help appreciated.!

Try running it as admin
On 1/11/2017 11:43 PM, "taral lokhande"<EMAIL_ADDRESS>wrote:

Can you suggest why createfile fails for testvmulti.exe ?
Any help appreciated.!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/djpnewton/vmulti/issues/28, or mute the thread
https://github.com/notifications/unsubscribe-auth/AACl296DlSNHS8kmfWoe4lmHmcSbu2eWks5syEttgaJpZM4QOBp2
.

done...ran application as admin ..also i tried to open visual studio 2010 in administrator and run it in ..same error.
OS- Windows 10
IDE - Visual Studio 2010
Any help appreciated!

Any other OS/Application settings do you recommend.?

code 5 is "access denied"
what filename is createfile using?

Thanks for the prompt reply
Even after giving this error program works which i didnt knew.
Sorry for the trouble.
One last question are game controller and other HIDs required if i intent to use only touch functionality as all the HIDs (touch,gamecontroller,digitizer etc ) get installed while installing this driver.?
Thanks.

No they would not be required
On Thu, Nov 2, 2017 at 6:49 PM, taral lokhande<EMAIL_ADDRESS>wrote:

Thanks for the prompt reply
Even after giving this error program works which i didnt knew.
Sorry for the trouble.
One last question are game controller and other HIDs required if i intent
to use only touch functionality as all the HIDs (touch,gamecontroller,digitizer
etc ) get installed while installing this driver.?
Thanks.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/djpnewton/vmulti/issues/28#issuecomment-341324208,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AACl2-px59Dud-oHnuD1_W7nQ6mOcGRkks5syVfwgaJpZM4QOBp2
.

for removing that should i just remove its entry from DefaultReportDescriptor[] in sys/vmulti.h ? and rebuilt
or do i have to remove something else as well.?and in which files.?

I have some error. Filename is
\?\hid#vid_0458&pid_003a#6&34d31b6e&1&0000#{4d1e55b2-f16f-11cf-88cb-001111000030}


Which data to show in Meta message ?

This is linked to what is on progress in #1002
Currently, the library provides the same information than the latest releases of fake-cucumber, cucumber-jvm and cucumber-ruby, being:

the version of cucumber-messages
the implementation (eg: 'cucumber jvm v1.2.3')
the runtime (example: java v9)
the OS
the CPU

Ideally, this message will end up in tools used to provide Living documentations (like CucumberStudio, Cucumber4Jira and others), sos some extra informations would be nice. What I'm thinking of right now is:

the CVS informations:

CVS name (git, mercurial, svn (I'm sure they're still lots hanging around))
remote
branch
commit ID/hash
commit message
author

the CI system informations is available:

name of the CI (Jenkins, Travis, Circle, GitHub actions etc)
the build ID (I need to check if all CI system provide it)
a link to the build (same than previously, if available)

Those changes will imply a new major release of cucumber-messages (and gherkin and other ones relying on messages), so it would be interesting to list as much as possible here and avoid doing multiple major releases of the library :)

I think the system ENV information would be really valuable meta information and would cover a bunch of that stuff.
There might be things in there that people don't want to send to a remote system though. So we could potentially remove or blank out any thing with _PASSWORD, _TOKEN, _SECRET.

@tooky I'd suggest using an explicit whitelist. So we only include well known values that we know to be safe.
I tried to do something similar with a blacklist a while ago and it was a never ending amount of pain. The blacklist is never complete and every miss is immediately a problem.

@vincent-psarga for a first selection I believe we can use whatever the pro plug-in was doing. I thought we were going to copy that intact.

@mpkorstanje I think a whitelist is a nice idea - it would be big and might need to expanded with new build envs.
If I remember the pro-plugin had a blacklist but allowed for additional matchers to be specified in a config file so users can add more if needed.
@vincent-psarga It makes me wonder if we should have a way for users to check what would be sent?

Mmh. I like the whitelist + matchers idea but that also sounds complicated and like a good idea for the next version.
Getting the build and source coordinates first would already be useful on it's own.

Agreed - simple first.

Ok, so the Metamessage might look like this:
message Meta {
  /**
   * The [SEMVER](https://semver.org/) version number of the protocol
   */
  string protocol_version = 1;

  // SpecFlow, Cucumber-JVM, Cucumber.js, Cucumber-Ruby, Behat etc.
  Product implementation = 2;

  // Java, Ruby, Node.js etc
  Product runtime = 3;

  // Windows, Linux, MacOS etc
  Product os = 4;

  // 386, arm, amd64 etc
  Product cpu = 5;

  CVS cvs = 6;
  repeated ENV envs = 7;

  // A product has a name and a version
  message Product {
    // The product name
    string name = 1;
    // The product version
    string version = 2;
  }

  message CVS {
    // Git, Mercurial ...
    string name = 1;
    // Remote servers urls
    repeated string remotes = 2;
    // Branch used
    string branch = 3;
    // Current commit
    Commit commit = 4;
    // Status of the repo
    repeated Staging = 5;

    message Commit {
      // ID or hash
      string id = 1;
      string author = 2;
      string text = 3;
    }

    message Staging {
      // Path to the file
      string path = 1;
      FileStatus statuss

      enum FileStatus {
        MODIFIED = 0
        ADDED = 1
        DELETED = 2
        UNTRACKED = 3
      }
    }
  }

  // Environment variable name and value
  message ENV {
    string name = 1;
    string value = 2;
  }
}

I've added a suggestion from @cbliard to all list the status of the git repository.

Can we get at the status of the git repo without using libraries? What purpose would it serve for the report?

Can we get at the status of the git repo without using libraries? What purpose would it serve for the report?

Not sure to be honest if that's doable without an external lib (I haven't checked). That said, I'd like to see if there's simple libs to extract some informations to avoid re-inventing the wheel (especially if they've already handled weird cases).
Normally with a CI system pushing the messages this would be empty (although I would not be surprised seeing files modified for the CI to work :D ) but it could be interesting in local dev'.

That doesn't sound like it is very useful. If possible I'd like to avoid the complexity of dealing with the git status al together -- extracting the existing CI variables for all the different CI systems will be complex enough as is already. Can we leave the git status out until we have a good use case for it?

ok works for me, I'll start with the ENV variable first :) and we'll see how long that takes before considering git informations :)

Rather then using all environment variables, please look at old pro plugin. It gives us `
CIEnvironment(String ciName, String revision, String branch, String tag, String projectName)

I think most of that is pretty good. Though either or both tag and branch may need to be list of strings. A single commit can have multiple tags and branches.

indeed that seems like a better idea, I'll change that a bit.

I ran into a rather interesting one in slack. The code below may throw an NPE when shaded into a different jar.
Messages.Meta.newBuilder()
                        .setProtocolVersion(Messages.class.getPackage().getImplementationVersion())

When using shading maven will repackage all the class files into a new jar. This removes the information from the manifest. Or worse it may replace it with some other information.
This means that to get a hold of the implementation version we can not use Messages.class.getPackage().getImplementationVersion(). Rather we have to use a resource bundle that contains the version. e.g:
    private static final String VERSION = ResourceBundle.getBundle("io.cucumber.core.version")
            .getString("cucumber-jvm.version");

src/main/resource/io/cucumber/core/version.properties
cucumber-jvm.version=${parent.version}
gherkin.version=${gherkin.version}

So that means that this would tighly couple tjis library with cucumber-jvm (or expect that this file with the property exists).
Would it be ok if I added a second entry point: createMeta(String toolName, String toolVersion, String messagesVersion) so in cucumber-jvm you specify the messages version like you currently fixed it ?

Not necessarily, we can also include a resources bundle in messages. But only for the version of messages. The version of Cucumber JVM and the fact that it is JVM will have to be provided externally.

The version (and name) of the message emitter (cucumber-jvm, fake-cucumber...) was already not included in the lin but provided by the emitter.


await keyword on function parameters

🔍 Search Terms
await function parameters
✅ Viability Checklist

[X] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[X] This wouldn't change the runtime behavior of existing JavaScript code
[X] This could be implemented without emitting different JS based on the types of the expressions
[X] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
[X] This isn't a request to add a new utility type: https://github.com/microsoft/TypeScript/wiki/No-New-Utility-Types
[X] This feature would agree with the rest of our Design Goals: https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals

⭐ Suggestion
Similar to the public/private keywords on object constructors, it would be helpful to add an await keyword to function parameters that automatically awaits the parameter so that the parameter is the awaited value rather than a promise
📃 Motivating Example
It's a frequent pattern that a parameter to an async function can be a promise or a value , and then it's immediately awaited at the top of the function:
async function awaitParamsInBody(
  paramA: Promise<string[]> | string[],
  paramB: Promise<string> | string,
) {
  const [awaitedParamA, awaitedParamB] = await Promise.all([paramA, paramB]);
  return awaitedParamA.includes(awaitedParamB);
}

The below is more concise and easier to read:
async function awaitKeyword(await paramA: string[], await paramB: string) {
  return paramA.includes(paramB);
}

awaitKeyword(Promise.resolve(['foo', 'bar']), 'foo');

💻 Use Cases

What do you want to use this for?

Some syntactic sugar to avoid names like paramPromise/awaitedParam

What shortcomings exist with current approaches?

It's a bit more verbose to pass in a promise to a function to only immediate await it. It becomes even more so when there are multiple params that are promises.

What workarounds are you using in the meantime?

The proposal is also similar to the for await...of syntax

You checked

[x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)

but yet this is clearly

Some syntactic sugar to avoid names like paramPromise/awaitedParam

This will be declined for that reason.  TC39 is the place to go for JS stuff.

[x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)

I don't see how this is the case. Want to elaborate?

This violates a necessary condition listed in the template:

This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)

Triple jinx???

Could have been a quadruple jinx, but I wasn't near a computer a 35 minutes ago.

Ah, I misunderstood runtime feature.


show no-image.jpeg if image were undefined or null

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #
Test URLs:

Before: https://main--danaher-ls-aem--hlxsites.hlx.page/
After: https://--danaher-ls-aem--hlxsites.hlx.page/

@Raja-danaher , Please issue ID and after URL to validate. Thanks.
CC - @dave-nichols

this PR not required as Dave fixed the spelling error for image not found jpeg.


Localized error

Description
Some types are not available when importing the package. These changes allow:
Creating a Session.Event so it can be sent to the peer.
Displaying a localized error message for WalletConnectError

lgtm!


Css modules for Next.js

@IharKrasnik @anorsich Please, review

@IharKrasnik Please, review latest commit


Give the user a little more info how to make a vswitch

Signed-off-by: Sven Dowideit<EMAIL_ADDRESS>

LGTM


Support more syntax highlighting triggers

Inspired by Atom language-babel package:
https://github.com/gandm/language-babel/blob/f1bcd82d1f0f8f151b64daf331fb017ce6540c72/grammars/Babel Language.json#L1112
Closes https://github.com/kumarharsh/graphql-for-vscode/issues/69

I wonder if this regex would work, which would be a more minimal change:
"(Relay\\.QL|gql|graphql(\\.experimental)?|/\\* GraphQL \\*/)\\s*(`)"

Let's see what @kumarharsh suggests. I also thought of making RegExp shorted but then leaned towards keeping the regexps in both extensions in sync. Makes future updates easier.

Thanks @kachkaev. That regex looks a little too complicated so i'll verify on my end if we really need the extra stuff there before merging this PR. 👍🏼

This has been merged in master in 91917f0


Reorder Tags

In Presets Menu, it would be very useful to be able to reorder tags, because this is the order the user show them in the edition form

Hi @GuillaumeAmat,
Is it something difficult to make tags reordable by the admin as you did for the nodes? If we use many tags, it takes lot of time to think of the order before having them all registered.

No it is not so difficult, are you willing to do it? I can help you in the process if you want but I don't have enough time to continue improving MapContrib...

I'm not familiar at all with JS ecosystem, but I'll try. Could you help me giving a list of the files to modify (I'm not sure to have seen them all)?
I would really like also to work on the template engine to have more than search and replace of tags on nodes description.
And thank you for that great work btw :)

If you're not a JS developer it will be hard to do that IMO. And the poor quality of some parts of the code does not help. You have to know JS, Backbone and Marionette by the way.
We had several ideas to improve the template engine too but I don't have the time to do that anymore. Feel free to put your ideas in new issues, hoping that someone will take care of them eventually :)


Add new lines at end of some files

Simple stuff, there are some files that doesn't respect UNIX file layout - actually just new line at end of file 😄

From what I see there are some problems with rubinius cc @indirect

thanks!


Check servicestandard branch and prep to release

I've made various changes to the service standard (from the work started by Adrian).
Approved by Georgina.
Task:

prep for release
do what's new
get it proofread
publish

Ready to merge into master: https://github.com/nhsuk/nhsuk-service-manual/pull/1242#partial-pull-merging. For @karlgoldstraw's attention.
Once it's on staging, I'll ask a content designer to double-check it.
I still need to do the CHANGELOG but am hoping to release on Tuesday. (I'm off work on Monday.)


Why I'm getting this error?

Confused, why I'm getting this error :(
ERROR in /services/firebase.service.ts (10,26): Cannot find name 'AngrularFire'.)

Hi @arnobferdous. We have a required issue template to troubleshoot errors. However, I'd check the spelling of your service as AngularFire is misspelled as AngrularFire.


awqint4 to gguf ,ModuleNotFoundError: No module named 'awq.apply_awq'

I want to use awq quantize a model, and use llama.cpp convert to gguf. but  I followed the tutorial but got an error：Traceback (most recent call last):
File "/root/ld/ld_project/llama.cpp/convert_minicpm.py", line 2516, in
main()
File "/root/ld/ld_project/llama.cpp/convert_minicpm.py", line 2460, in main
from awq.apply_awq import add_scale_weights  # type: ignore[import-not-found]
ModuleNotFoundError: No module named 'awq.apply_awq'
my awq version is
autoawq                           0.2.5+cu121
autoawq_kernels                   0.0.6

mport os
import subprocess
from awq import AutoAWQForCausalLM
from transformers import AutoTokenizer
model_path = 'mistralai/Mistral-7B-v0.1'
quant_path = 'mistral-awq'
llama_cpp_path = '/workspace/llama.cpp'
quant_config = { "zero_point": True, "q_group_size": 128, "w_bit": 6, "version": "GEMM" }
Load model
NOTE: pass safetensors=True to load safetensors
model = AutoAWQForCausalLM.from_pretrained(
model_path, **{"low_cpu_mem_usage": True, "use_cache": False}
)
tokenizer = AutoTokenizer.from_pretrained(model_path, trust_remote_code=True)
Quantize
NOTE: We avoid packing weights, so you cannot use this model in AutoAWQ
after quantizing. The saved model is FP16 but has the AWQ scales applied.
model.quantize(
tokenizer,
quant_config=quant_config,
export_compatible=True
)
Save quantized model
model.save_quantized(quant_path)
tokenizer.save_pretrained(quant_path)
print(f'Model is quantized and saved at "{quant_path}"')
GGUF conversion
print('Converting model to GGUF...')
llama_cpp_method = "q4_K_M"
convert_cmd_path = os.path.join(llama_cpp_path, "convert.py")
quantize_cmd_path = os.path.join(llama_cpp_path, "quantize")
if not os.path.exists(llama_cpp_path):
cmd = f"git clone https://github.com/ggerganov/llama.cpp.git {llama_cpp_path} && cd {llama_cpp_path} && make LLAMA_CUBLAS=1 LLAMA_CUDA_F16=1"
subprocess.run([cmd], shell=True, check=True)
subprocess.run([
f"python {convert_cmd_path} {quant_path} --outfile {quant_path}/model.gguf"
], shell=True, check=True)
subprocess.run([
f"{quantize_cmd_path} {quant_path}/model.gguf {quant_path}/model_{llama_cpp_method}.gguf {llama_cpp_method}"
], shell=True, check=True)

Hi @LDLINGLINGLING. This seems to be a llama.cpp package in your first message. Have you tried the GGUF export from the AutoAWQ documentation and did it succeed?
https://casper-hansen.github.io/AutoAWQ/examples/#gguf-export

I didn't succeed，I followed the instructions in this link https://casper-hansen.github.io/AutoAWQ/examples/#gguf-export, but the error at the top appeared

I now think this operation is meaningless, because I originally thought that awq has high quantization accuracy. Whether converting to gguf can maintain this accuracy, but it should be impossible


Move handle_options_request into ApiController

Moves this action into the ApiController (since it is only matched
against OPTIONS /api/) and renames to simply options, making it
polymorphic with other API controllers' options actions.
@miq-bot add-label api, refactoring
@miq-bot assign @abellotti

This LGTM!! 🎵
will merge when green.

Euwe Backport details:
$ git log
commit da2be362213b6351fd2bfcc4b27d51e0b13e387e
Author: Alberto Bellotti<EMAIL_ADDRESS>Date:   Fri Sep 30 14:26:17 2016 -0400

    Merge pull request #11615 from imtayadeway/refactor/api/handle-options-request

    Move handle_options_request into ApiController
    (cherry picked from commit 64d9a28a9be398aa5d62f644a8e803b662624ada)


Many features, including production queue, are broken in Hot Seat

The Production Queue is not working well in Hot Seat.
Bug1 (production queue related):
The queue seems to be saved per city (order they are built) without taking the ownership into account.
Meaning Player 1 first city will have the same production queue as Player 2 first city, etc..
This is a known bug of that mod but since this mod is now part of cqui, it's might be interesting to report it here.
Bug2 (cqui settings related):
The option to disable this mod through the cqui settings page is also not working great in Hot Seat.
ie: If Player1 is building a trader then Player 2 won't be able to build one until it's done for Player 1. My guess is that the trader is in the Production Queue (hidden and limited to 1 item) and the game believe player 2 has already a trader in queue !

The first bug is an issue with how the Production Queue mod was originally implemented (see here). It's on my todo list, but the amount of refactoring it involves could be rather intense, so I don't plan to try tackling it until I have the time
The second bug you describe is the design working as intended. Ultimately, I want construction orders to follow the same path instead of splitting the code and increasing complexity for no good reason.

#271 merged into this issue

While I merged the Spring 2017 Patch into CQUI I saw that some multiplayer parts are missing in the CQUI files (mainly reset variables when playerID changed).
I haven't dona a full search for this multiplayer stuff but I have started a Hot Seat game and some issues arisen. e.g.: selecting settler as player 1 - change - settler-lens is active for player 2


Don't Merge! PR real time test for source branch full build

Docs Build status updates of commit eb6671b:
:clock10: Pending: waiting for processors (50 builds ahead of you)
:warning: Docs Build is busy, currently there are 50 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit eb6671b:
:clock10: Full build: the average full build time is 7 min(s) 48 sec(s), this is based on the last 30 build(s) for this repository.

Docs Build status updates of commit eb6671b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docfx.json
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


/doc/put throws 500 error (even though it works)

/doc/put throws 500 error (even though the data is updated)

Failed to reproduce with v0.9.3. Closing it for now. Please feel free to re-open it if the issue still persists.


feat: add options for UID and GID

Have you read the Contributing Guidelines?
Changes description
Added options for setting UID and GID for rstudio-connect user. With that it's possible to have the consistent user, even if there's an upgrade, migration or reinstall (sometimes there's a change with UID and/or GID, and Connect has to change permissions on its files, which consumes time)

Task linked: CU-862k1p486 Adjust our Connect Ansible role


fix: spelling and grammatical errors

Overview
This pull request addresses minor grammatical and typographical issues across several files. The changes focus on improving clarity and correctness in documentation, comments, and variable descriptions without affecting functionality.

Changes in this PR:

Fixed typos and grammatical errors:

Corrected phrases like "to write access" to "write access," "slightly over estimated" to "slightly overestimated," and others.
Replaced redundant or awkward phrasing with clearer alternatives.

Improved documentation:

Refined comments in auto_request_review.yml, pr-review-requester.yml, and code files for better readability.
Clarified descriptions in benchmarking results and error messages.

Consistency improvements:

Standardized terminology such as "minimum gas price" instead of "min gas price" across multiple files.

Files Updated:

.github/auto_request_review.yml
.github/workflows/pr-review-requester.yml
app/ante/tx_size_gas.go
app/benchmarks/benchmark_msg_send_test.go
app/benchmarks/results.md
app/errors/insufficient_gas_price.go
app/module/configurator.go
app/module/manager.go

Key Changes:

Standardized error messages and comments.
Enhanced code documentation for better understanding of intent and logic.
No changes to the logic or functionality of the application.

Testing:

Changes are limited to comments and documentation, so no additional tests are required.
Verified that the build process and existing tests remain unaffected.

Complete Before Merge:

[x] Review updated comments for consistency and accuracy.
[x] Confirm no functional changes are introduced by this PR.

Allow edits by maintainers.

I used ChatGPT to identify these issues and I can agree that setting up CI for spelling and grammar checks would be a great idea.


Info API

Hue has an info api. Not sure how valuable this is, but we should add support for it eventually.
This is likely lower priority

I think this can be closed: Info API is now deprecated
https://developers.meethue.com/develop/hue-api/8-info-api-deprecated-as-of-1-15/

I think this can be closed: Info API is now deprecated
https://developers.meethue.com/develop/hue-api/8-info-api-deprecated-as-of-1-15/


Update MD file on new branch 2017-11-21_23-31-38

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestRef1.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


add an option to connect via URL string

instead of passing all the URL parts separately
ex.
r = require('rethinkdb')({
  url: 'rethinkdb://username:password@somewhereonamazon:123412'
})

Want to send a pull request? :)

Pull request sent: https://github.com/neumino/rethinkdbdash/pull/349 😉


perf: avoid recreating excessive empty objects

Avoids some memory churn by not recreating empty objects and arrays in several places.
This introduces some risk in that we might leak these objects outside of the picker/database, and if people mutate them, then they could change the behavior. But people might already have a bad time if they mutate the objects returned from the database/picker – it's not something I've tested in the past.

Adds complexity and code for unclear benefit


Returning IServiceProvider from WebHostBuilder.ConfigureServices

Is there any way to return an IServiceProvider instance via ConfigureServices on WebHostBuilder? I'm trying to replicate the functionality that used to be available in RC1 on Microsoft.AspNetCore.TestHost.TestServer.Create() but with the API change in RC2 does not seem to be.

Nope, it's not possible without a Startup class. There's separation between the hosting services and the application container.

Thanks for response


Add bc to the list of dependencies for the interactive image builder

Running interactive-image-builder.sh without bc results in various errors, including:
Try 'sleep --help' for more information.
helper-functions: line 154: bc: command not found

@harshad16 100% agree with this, just ran into this today on a fresh Linux system. In my view, we can merge this.

strictly speaking, make is also necessary.
i.e. for a new own release with a later scl centos python case image
https://github.com/opendatahub-io-contrib/workbench-images/issues/50#issuecomment-1931400157
we might also want to document in this section "Building a base image locally to use in interactive image builder for a given release name and release date"
cd base
make all RELEASE=2024a DATE=20240513

will produce two base images python 3.9 and python 3.11 with said release and date.

@koep Sorry, took me a long time to review this, but I will gradually start working again on this project.


Fixed bug with tip in VM Dialog

@mareklibra Please review.
Tooltip body was hidden cause of overflow in parent component.

This change is

LGTM, just the commit message

@mareklibra @jniederm Done.


Uncaught SecurityError when cookie settings block localStorage

Chrome throws a SecurityError when accessing window.localStorage with cookie settings set to "Block sites from setting any data":
Uncaught SecurityError: Failed to read the 'localStorage' property from 'Window': Access is denied for this document. in leaflet.restoreview.js:3
The Pale Moon browser (and probably older Firefox) is also throwing a SecurityError with restrictive cookie settings.
See also:

MDN: Using the Web Storage API - Testing for support vs availability
Modernizr localstorage.js feature detect

Thanks for this issue.
I had a verification and a warning message in the console. Maybe we could think to add something more robust to polyfill localStorage if access is not allowed. Or maybe throwing a warning is enough.
@SBats what do you thing?

I think this is fine, wouldn't expect anything else, maybe not even a warning.
Perhaps a comment in the readme that it doesn't work when the Browser settings deny storing local data.

@enguerran I like the idea of a warning, simple and efficient in our case. Your pull request does the trick.
@nrenner Thanks for reporting this issue by the way !


Don't allow upload of weak SSH keys

If a SSH key is RSA/DSA, we should reject it if it is less than 2048 bits. We should also consider checking against the Debian weak key blacklist.

This is now irrelevant, we don't use SSH keys.


Function Modules not imported

Hi @larshp ,
seems like there is an issue with importing FM. I was importing now 2 zips (abapgit & falv) to the S/4 system and although the files for FM are visible on the list, they are not created as an object later on.
They are always visible as something new, but you cannot install them.
Is this something known?

Cheers
Łukasz

are you using the offline zip feature?

yes I do

I have a suspicion that offline imports does not show errors, see https://github.com/larshp/abapGit/issues/2793

could be, because there was no info at all, just comparison of the files once the pull was done

any clue which class should I debug?

PR https://github.com/larshp/abapGit/pull/2729 added the feature that the log is shown when importing online repos
^ still just a guess

class ZCL_ABAPGIT_SERVICES_REPO, method GUI_DESERIALIZE, try setting a breakpoint in the last statement and checking the log object

Ok, so the log is created and filled but not shown. The issues is my case are authorizations. But would be good that the log is shown or the menu appears also for the offline mode.

yea, offline and online should work similar in this case

If this will work I'll create PR

ZCL_ABAPGIT_GUI_VIEW_REPO->BUILD_HEAD_MENU

above will show the "Log" button, but I guess we also need to issue a MESSAGE somewhere?

looks good to me

works but I have now #1491 and I cannot stage it..... Will try on other machine later.

@fidley Did you update the *.github.com certificate lately? It expired last week and now there is a new one.

@flaiker yes, I've updated it but didn't worked for me.

guess this can be closed?

yes, sorry forgot about


feat(optim): add search latest events and search plan by api ids

Closes gravitee-io/issues#5615

Closing this PR because it has been moved to another repository.


[FLINK-36491][TABLE API] Remove the deprecated method in DataStreamSinkProvider

What is the purpose of the change
This is a subtask of [FLINK-36476](https://issues.apache.org/jira/browse/FLINK-36476) Remove all deprecated methods under public APIs in table modules
Brief change log
Remove deprecated method
Verifying this change
Please make sure both new and modified tests in this PR follow the conventions for tests defined in our code quality guide.
(Please pick either of the following options)
This change is already covered by existing tests, such as (please describe tests).
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): ( no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)

Failing test is unrelated to this change.


added a recommended read

PR Summary

PR Checklist

[x] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[x] Summarized changes
[x] Change is not breaking
[x] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[x] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

User-facing changes

[x] Not Applicable
OR
[ ] User-facing Documentation needed

[ ] Issue filed - Issue link:

Testing - New and feature

[x] Not Applicable or can only be tested interactively
OR
[ ] Make sure you've added a new test if existing tests do not effectively test the code changed

[ ] Add [feature] if the change is significant or affects feature tests

There is a duplicate PR:  https://github.com/PowerShell/PowerShell/pull/8067

Closing this PR as the README now has a link to the 3rd edition of the book.


[Suggestion]: Wormhole painting

General Info

[X] I would like to propose new content
[ ] I would like to propose changes
[ ] I would like to propose another thing

Suggestion Description
This painting wouldn't look like a dimension but more like a wormhole, since it's one. By placing two wormhole paintings in the same dimension, they will link eachother and you will be able to go from point A to point B.

It would look something like this

Adding such feature would open a can of worms of "what if you're playing on a multiplayer server? will you not be able to have more than 2?" And it doesn't fit the idea of the mod.


chore(nodebuilder): Elevate perms for certain endpoints

TODO:

[ ] should perms be elevated for share endpoints like GetEDS ? IMO yes.

Resolves #2406

Codecov Report

Merging #2759 (3ccc8bc) into main (8602d6e) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2759      +/-   ##
==========================================
- Coverage   51.73%   51.70%   -0.03%
==========================================
  Files         161      161
  Lines       10826    10826
==========================================
- Hits         5601     5598       -3
- Misses       4731     4733       +2
- Partials      494      495       +1

Files Changed
Coverage Δ

nodebuilder/header/header.go
0.00% <ø> (ø)

... and 1 file with indirect coverage changes

@Wondertan actually we should at least elevate perms of SharesAvailable as there is a sanity check there that could cause node to panic in case of malformed root -- I also elevated perms of the other calls as i don't think calls that require node to do work should be public.

Read permissions are sufficient, even for SharesAvailable with the panic. Public methods are endpoints you can give anyone access to, read perms are next level up and should only be given to people who are not using with ill intent anyways

@distractedm1nd i made the comment re SharesAvailable before i elevated the perm to read

Please mark as breaking

already implemented


Feature/1066 downloads

Changes to comply with the changes from Becky

In Downloads.vue should we remove the v-if="false" block of code now? (on line 88)
https://github.com/jac-uk/admin/pull/1115/files#diff-b272b487729b1b17e0efdfd28ab87e3f5e854836027eea33e946ca0396b35492L88-L92

this is done.

In Downloads.vue should we remove the v-if="false" block of code now? (on line 88)
https://github.com/jac-uk/admin/pull/1115/files#diff-b272b487729b1b17e0efdfd28ab87e3f5e854836027eea33e946ca0396b35492L88-L92

this is done.


desc query string arg incorrectly preserved when setting filters

If you do descending order on a column, the URL will have ?desc=1. If you then apply a filter, this part of the url becomes desc=True, which breaks the ViewArgs parsing, resulting in the sorting going back to ascending.
One possible fix (I think..) is to remove the bool casting of the sort_desc argument to ViewArgs

You May Make PR for this

Steps to reproduce

Go to model list view (with data)
Sort by descending (e.g. click a column row twice) -- ensure that desc=1 is in the url
Apply a filter or search
Resulting url/view will have desc=True (instead of desc=1)

Cause
The jinja template renders sort_desc directly. Since it's a boolean, this becomes True in the html.
{# flask_admin/templates/bootstrap3/admin/model/layout.html #}
...
{% if sort_desc %}
    <input type="hidden" name="desc" value="{{ sort_desc }}">
{% endif %}
...

PR coming soon


Restaurant Menus

As seen in: https://www.caesars.com/eldorado-reno/restaurants/brew-brothers/menu
Side-note: it would be nice to be able to enforce formating during authoring (especially for prices).

Menu Content: comes from Excel files
Restaurants in Caesars Palace have two options:

Menu in PDF format
Menu in Excel format (JSON consumed by /menu page that will display the data like as shown in the example above from a different site)

Preference goes to Excel for authoring experience

Initially plan is to migrate what they have today. We can then convert the menus to excel in the next phase.


Update to log duration without unit for plotting

@aslakknutsen snapshot fabric8-wit image is available for testing.  docker pull docker.io/fabric8/fabric8-wit:SNAPSHOT-PR-1560-1


Feature: Develop Login, Signup and Forget password pages. Multiple Developers Required.

Please refer #1 for details
Develop:

Login page
Signup page
Forget password page

Use your creativity for development 🧠
Let's make it a big one 🚀

@namansharma3007 I would like to work on it . can you please assign me this issue.

@Karan1962
Mission has begun 🚀

@namansharma3007 Can you please assign this issue to me.

@namansharma3007 Can you please assign this issue to me.

@Rossville Done!
Now start the mission 🚀


(Prostreet) Controller UI icon not showing

Hello need help, when I change the controllericonmode to Xbox 360 = 2, the icon didn't show up in game even Xbox one = 0, keyboard icon only are showing, is theres a way to fix it?? I'm using windows 10

Yes it's on the Global file folder


fix(storybook): theme doesn't import properly

Hey, I just made a Pull Request!
this PR fixed theme import https://github.com/spotify/backstage/issues/530.
Previously i can't run storybook in my local and got error like this.

And i add aliases for theme, and it can run normal again.
:heavy_check_mark: Checklist

[ ] All tests are passing yarn test
[ ] Screenshots attached (for UI changes)
[ ] Relevant documentation updated
[ ] Prettier run on changed files
[ ] Tests added for new functionality
[ ] Regression tests added for bug fixes

From what I can see the theme is still not properly applied ^ . Also getting an error in #540 which indicates the same.

I wonder if we need to do something like this https://medium.com/encode/setting-up-storybook-with-material-ui-and-styled-components-5bdacb6db866


Density / Anti-Density plates affect spectator players

Players in spectator mode should be freely able to travel around and look at things. These plates make that much more difficult, as they add an enormous amount of velocity on any entity that enters their range. Spectators should not be affected by this, as they are not pushed by mobs or explosions, either.

Good catch! Thank you


feature request: I would like to automatically update all development and ad hoc profiles in an account to include every certificate and device

I have for device but not for every cert
Why would you want more then I developer cert
It a nightmare to maintain and train the developers
Just have one development cert
Much better
Look at my github sfransen
You can also download then all too
Sent from my iPhone5

On Oct 26, 2015, at 4:42 PM, Brad Anderson Smith<EMAIL_ADDRESS>wrote:
—
Reply to this email directly or view it on GitHub.

Thanks sfransen!
I just pulled for for and that gets me halfway there.  Truthfully I have considered sharing a cert across the whole development team and that may be what I end up doing.
For now, I'm going to use your fork, but if this work is desired by the maintainer, I would be interested in seeing this become a mainline feature.

I will push some change tomorrow that will speed thing up if you have lots of provision profiles
Note I look for AppStore and different name to limit what I try to apply the devices to provision profiles
Note when the developer portal gets slow it off line the script breaks
I been trying to get a work around for that but it been hard
I created a website that developers and qe and managers and such can get all from and add a device to license
That way only 1 person need admin access
Control the person that have no idea what they doing
Sent from my iPhone5

On Oct 26, 2015, at 7:08 PM, Brad Anderson Smith<EMAIL_ADDRESS>wrote:
Thanks sfransen!
I just pulled for for and that gets me halfway there. Truthfully I have considered sharing a cert across the whole development team and that may be what I end up doing.
For now, I'm going to use your fork, but if this work is desired by the maintainer, I would be interested in seeing this become a mainline feature.
—
Reply to this email directly or view it on GitHub.

I think the owner has stop looking at this code. it been a really long time now since it was changed.


[IOTDB-2214] InfluxDB-Connect write point time error format

see https://issues.apache.org/jira/browse/IOTDB-2214

Hi @GOptimistic, nice to see u here!
Let's add some tests for the PR?

@GOptimistic Great! Thanks a lot for your contribution!

@GOptimistic Great! Thanks a lot for your contribution!


chore: add more logging

Summary
As promised in #273, this PR adds more logging in an attempt to narrow down the issue.

Published in the latest pre-release


Mysql query silently failing

Laravel Version: v6.18.7
PHP Version: 7.2.30
Database Driver & Version: mysql 8

Description:
A query that fails when using DBeaver, doesn't trigger exception when using Laravel.
Steps To Reproduce:
1 - Execute the following code:
try{
$data = DB::select( DB::raw ("select ( select 1 as a union all select 2 as a ) b"));
var_dump($data);
} catch (\Exception $e){
die( 'error' );
}

It would be expected to see the 'error' message, but system returns array(0) { }
Please note that executing the same query throws exception in DBeaver:

This is not a Laravel issue but a PHP bug.
It only occurs when PDO::ATTR_EMULATE_PREPARES is set to false.
You can reproduce it with a native PDO connection:
$pdo = new PDO('mysql:host=<IP_ADDRESS>;port=3306;dbname=homestead', 'homestead', 'secret');
$pdo->setAttribute(PDO::ATTR_EMULATE_PREPARES, false);
$pdo->query('select ( select 1 as a union all select 2 as a ) x');
dump($pdo->errorInfo());

You get the expected error when removing the second line or setting the attribute to true.

Please see the answer above.
@staudenmeir thanks for helping out 👍

Hello. Thanks for the answer.
However it does not explains why is laravel using the PDO::ATTR_EMULATE_PREPARES as false, and if we can make it work as expected in Laravel.
Thank you.

Laravel has always been using false because it's the recommended setting nowadays.
You can override it for your application's MySQL connection in config/database.php:
'mysql' => [
    ...
    'options' => [
        PDO::ATTR_EMULATE_PREPARES => true,
    ],
],

I wouldn't recommend that because it can have side effects.
What's your use case that you are running invalid queries?

Hello @staudenmeir , you're saying it's a PHP bug, can you share the link of this PHP bug?
The use case is a BI system ( it generates the SQL dynamically ), we can't really ensure that query will not be invalid, that's why we want an exception being trowed so we can notify user about mistake.

https://bugs.php.net/bug.php?id=72076


Missing dots

Constants need to be -
Roam.startTracking(Roam.TrackingMode.ACTIVE);
Roam.startTracking(Roam.TrackingMode.BALANCED);
Roam.startTracking(Roam.TrackingMode.PASSIVE);

Yes, https://github.com/roam-ai/roam-reactnative/blob/master/js/index.ts#L11

Thanks for sharing this! 🔥

Thanks @tejas456sawant for your contribution. We have updated the Readme.md with more clear content.

Hello,
I am adding roam.ai to my react native project, but it shows location hits
as 0.
[image: image.png]
Also, location listers are not printing anything and if I hit the insights
API, it shows the following response.
[image: image.png]
My Code -
import Roam from "roam-reactnative";
Roam.checkLocationPermission((status: any) => {
if (status === "DENIED") {
Roam.requestLocationPermission();
}
});
Roam.checkLocationServices((status: any) => {
if (status === "DENIED") {
Roam.requestLocationServices();
}
});
Roam.checkBackgroundLocationPermission((status: any) => {
if (status === "DENIED") {
Roam.requestBackgroundLocationPermission();
}
});
Roam.startTracking("PASSIVE");
Roam.updateLocationWhenStationary(10);
Roam.allowMockLocation(true);
Roam.createUser(
"TEST_USER",
(success: any) => {
console.log("User created: ", success);
},
(error: any) => {
console.log("User creation error: ", error);
},
);
Roam.startListener("location", (location) => {
console.log("Location", location);
});
On Mon, Apr 4, 2022 at 10:46 AM Jothi Priyadharshan <
@.***> wrote:

Closed #11 https://github.com/roam-ai/roam-reactnative/pull/11.
—
Reply to this email directly, view it on GitHub
https://github.com/roam-ai/roam-reactnative/pull/11#event-6359897699,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJDSQZX4B7XGJXZXEQ2LI43VDJ3MDANCNFSM5SLQTN6Q
.
You are receiving this because you were mentioned.Message ID:
@.***>

Looping JOE
On Sat, 9 Apr 2022 at 22:26, Tejas Sawant @.***> wrote:

Hello,
I am adding roam.ai to my react native project, but it shows location hits
as 0.
[image: image.png]
Also, location listers are not printing anything and if I hit the insights
API, it shows the following response.
[image: image.png]
My Code -
import Roam from "roam-reactnative";
Roam.checkLocationPermission((status: any) => {
if (status === "DENIED") {
Roam.requestLocationPermission();
}
});
Roam.checkLocationServices((status: any) => {
if (status === "DENIED") {
Roam.requestLocationServices();
}
});
Roam.checkBackgroundLocationPermission((status: any) => {
if (status === "DENIED") {
Roam.requestBackgroundLocationPermission();
}
});
Roam.startTracking("PASSIVE");
Roam.updateLocationWhenStationary(10);
Roam.allowMockLocation(true);
Roam.createUser(
"TEST_USER",
(success: any) => {
console.log("User created: ", success);
},
(error: any) => {
console.log("User creation error: ", error);
},
);
Roam.startListener("location", (location) => {
console.log("Location", location);
});
On Mon, Apr 4, 2022 at 10:46 AM Jothi Priyadharshan <
@.***> wrote:

Closed #11 https://github.com/roam-ai/roam-reactnative/pull/11.
—
Reply to this email directly, view it on GitHub
https://github.com/roam-ai/roam-reactnative/pull/11#event-6359897699,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AJDSQZX4B7XGJXZXEQ2LI43VDJ3MDANCNFSM5SLQTN6Q
.
You are receiving this because you were mentioned.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
https://github.com/roam-ai/roam-reactnative/pull/11#issuecomment-1094119363,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA7RPNPEEKAWFT6SPRNNXFDVEHRXBANCNFSM5SLQTN6Q
.
You are receiving this because you commented.Message ID:
@.***>


Update Report Reasons

Updates the wording for some report reasons.
Adds text requesting additional details for trademark/copyright requests.
Addresses https://github.com/NuGet/NuGetGallery/issues/4716
@joelverhagen @karann-msft @skofman1

:shipit:


Replace node mutation by WeakMap

As discussed there it would be better to use a WeakMap to keep track of SimpleBar instances instead of mutating the nodes elements.
We also need to add a static helper to retrieve the SimpleBar instance (that will now sits at SimpleBar.instances.get(el)).
cc @andersk

Sounds good to me. Let's give the static helper a short name since Simplebar.instances.get(el).getScrollElement() is quite a mouthful. Maybe SimpleBar.of?

Yeah definitely.
I liked the SimpleBar.ofElement that you proposed before. Makes it clear what type of parameter it's expecting.

ofElement is more explicit, but I’m trying to imagine typical use cases like
SimpleBar.ofElement(document.getElementById("pane")).getScrollElement().addEventListener("scroll", () => {
    …
})

and wondering whether the extra word is actually worth the extra horizontal space, when there’s not really anything else that you could take the SimpleBar of. Your call though.


Lambda Layer Update: Update OTel Collector to v0.82.0

Created to update the OTel collector to v0.82.0 and collector-contrib deps to v0.82.0
Collector log -
{"level":"info","ts":1692081358.776955,"msg":"Launching OpenTelemetry Lambda extension","version":"v0.82.0"}
{"level":"info","ts":1692081358.7813704,"logger":"telemetryAPI.Listener","msg":"Listening for requests","address":"sandbox:53612"}
{"level":"info","ts":1692081358.7815187,"logger":"telemetryAPI.Client","msg":"Subscribing","baseURL":"http://<IP_ADDRESS>:9001/2022-07-01/telemetry"}
TELEMETRY	Name: collector	State: Subscribed	Types: [Platform]
{"level":"info","ts":1692081358.7835898,"logger":"telemetryAPI.Client","msg":"Subscription success","response":"\"OK\""}
{"level":"info","ts":1692081358.7958255,"caller":"service/telemetry.go:84","msg":"Setting up own telemetry..."}
{"level":"info","ts":1692081358.7967937,"caller":"service/telemetry.go:201","msg":"Serving Prometheus metrics","address":"localhost:8888","level":"Basic"}
{"level":"info","ts":1692081358.7979102,"caller":"exporter@v0.82.0/exporter.go:275","msg":"Development component. May change in the future.","kind":"exporter","data_type":"traces","name":"logging"}
{"level":"warn","ts":1692081358.797972,"caller":"loggingexporter@v0.82.0/factory.go:98","msg":"'loglevel' option is deprecated in favor of 'verbosity'. Set 'verbosity' to equivalent value to preserve behavior.","kind":"exporter","data_type":"traces","name":"logging","loglevel":"debug","equivalent verbosity level":"Detailed"}
{"level":"info","ts":1692081358.7984672,"caller":"exporter@v0.82.0/exporter.go:275","msg":"Development component. May change in the future.","kind":"exporter","data_type":"metrics","name":"logging"}
{"level":"info","ts":1692081358.8159559,"caller":"service/service.go:132","msg":"Starting otelcol-lambda...","Version":"v0.82.0","NumCPU":2}
{"level":"info","ts":1692081358.8159838,"caller":"extensions/extensions.go:30","msg":"Starting extensions..."}
{"level":"info","ts":1692081358.8161306,"caller":"otlpreceiver@v0.82.0/otlp.go:83","msg":"Starting GRPC server","kind":"receiver","name":"otlp","data_type":"metrics","endpoint":"localhost:4317"}
{"level":"info","ts":1692081358.816274,"caller":"otlpreceiver@v0.82.0/otlp.go:101","msg":"Starting HTTP server","kind":"receiver","name":"otlp","data_type":"metrics","endpoint":"localhost:4318"}
{"level":"info","ts":1692081358.816339,"caller":"service/service.go:149","msg":"Everything is ready. Begin running and processing data."}

@rapphil wasn't #829 supposed to enable dependabot to handle this?


Bug found in EndSpanResponse.scala

Please note that method:
private def end(
      tracing: Tracing,
      response: HttpResponse,
      span: Span,
      responseAnnotation: String
  ): HttpResponse = {

    HttpAttributes.setAttributesForResponse(span, response)
    span.addAnnotation(responseAnnotation)

    // todo use new setStatus method here when merged
    response.copy(
      entity = response.entity.transformDataBytes(
        EndSpanFlow(
          span,
          tracing,
          StatusTranslator.translate(response.status.intValue())
        )
      )
    )
  }
}

will fail when response status code is 204 (No Content). In order to avoid this, I suggest modify the above code to:
private def end(
      tracing: Tracing,
      response: HttpResponse,
      span: Span,
      responseAnnotation: String
  ): HttpResponse = {

    HttpAttributes.setAttributesForResponse(span, response)
    span.addAnnotation(responseAnnotation)

    // todo use new setStatus method here when merged
    response.copy(
      entity =
        if (response.status.allowsEntity)
          response.entity.transformDataBytes(EndSpanFlow(span, tracing, StatusTranslator.translate(response.status.intValue())))
        else
          HttpEntity.Empty
      )
    )
  }
}

Thanks, do you want to create a pr for that change? Otherwise I can also integrate it.

If I understand correctly this snippet would cause traces for  HTTP 204 would never end, right?

Right, it seems to me
tracing.endSpan(span, status)

is missing in the else case, as there is no entity, there is no reason to wait to end the span for the end of the entity consumption.