Problem running theme watch after upgrade to 0.7.2

What I expected to happen
When I run theme watch from my Shopify themes I expect it to watch for changes in the directory and upload them as they are changed. This was working fine prior to upgrade.
What actually happened
Running theme watch works just fine, and it correctly observes changes to files in the directory. Where the problem lies is that it does not upload the file and instead gives me this message:
[development] No collection name provided
This happens consistently for all my themes.
Steps to reproduce

Configure a theme using the command line per the instructions: theme configure --password=[your-password] --store=[you-store.myshopify.com] --themeid=[your-theme-id]
Change into the theme directory and run theme download and then theme watch
Make a change to any of the theme files.

My Environment
OS (including version): macOS 10.12.6
Themekit version: 0.7.2 (I'm unsure what i was previously using, but I first installed it a few months ago)
Ignore Files(if any): None
General Notes
I can still run theme replace and theme upload just fine, along with all the other commands as far as I know. I've tried deleting the configuration file and recreating it using the new version, but it looks exactly the same.
Any guesses?

Can you try deleting your theme.lock file and see if this fixes your issue. This isn't a solution but rather helping me see if your lock file is in a bad format.

Also what is the exact output. You see the Received message but do you see the message that the event failed or succeeded?

Thanks for the quick response. I did try deleting theme.lock but it made not difference. Here's the full message copy-and-pasted:
12:35:07 [development] Watching for file changes on host ______.myshopify.com
12:35:17 [development] Received Update event on
[development] No collection name provided

I don't see any indication if the event failed or succeeded, but I can confirm the changes I make don't get uploaded to the host. I've tried running this with the --verbose tag but I don't get any additional information.

Yeah it is really bizarre, the problem is that there is no filename there. That  Received Update event on _______ is missing a filename so the error comes from the lock file trying to set a entry without a filename. I am not sure why this would only happen to you in watch since all of these things use the same mechanisms. By the way if this is blocking you the original version that you most likely were using is 0.6.12 and you can revert to that by using the command theme update --version=v0.6.12 I will try and get this sorted soon though.

I'm sorry — I should have clarified. the _____ part was the correct subdomain.
One other detail maybe worth mentioning: I'm using Go 1.7.1. I don't do much with Go and have no idea if this would be a factor.
I'll probably downgrade for now but maybe leave this open in case others experience the same problem?

I knew that is what you meant I was saying that there was also a file name missing from the Received event message.

Can you please give me full details about how you are doing this and information about your setup? For instance are you providing it with a directory config? I ask this because in the steps to reproduce you said this:

Change into the theme directory and run theme download and then theme watch

When theme configure creates the config in the current directory you shouldn't have to change directories after that command.
Any more information you can provide me would be a great help because I cannot reproduce this.

Hi! I've the same probelm. I've updated to the new version, and when I run theme watch and change any file in the directory,  and I get:
$ theme watch
11:41:59 [development] Watching for file changes on host xxx-xxxxx.myshopify.com
11:42:22 [development] Received Update event on
[development] No collection name provided

Do you know what's going on? Thanks!

@mmaauu If you could give me more information I could probably help you.

@tanema, what more info do you need? How can I get it? Thanks!

Please provide me with

OS (including version)
Steps to reproduce and please paste the whole commands (with private data omitted) that you ran.
An example of your configuration.

OS: Win7 Professional Ver 6.1 (Build 7601, SP 1)
The whole commands are the same I've posted before:
$ theme watch
11:41:59 [development] Watching for file changes on host vaja-custom.myshopify.com
11:42:22 [development] Received Update event on
[development] No collection name provided

What I was trying to do is copyng some files to assets folder while theme watch.
Until the recent update it was working perfectly.
My config file:
development:
 password: XXXXXXXXXXX
 theme_id: "154769475"
 store: XXXXXXXX.myshopify.com

Plase let me know if you need anything else. Thanks!

Hi @tanema — my note where I said "Change into the theme directory..." was misleading. When I created the configuration file, downloaded the current theme and ran theme watch that was all within the same directory.
My config file looks identical to @mmaauu, for what it's worth.
I'll try to relay more information later.

Do either of you have a THEMEKIT_DIRECTORY environment variable or pass in a directory config through your config file?

@tanema, yes, I have webkit directory in the path enviroment variable.

is it named THEMEKIT_DIRECTORY and what is it's value?

Can you please update to a patched version for this issue by running theme update  --version=v0.0.0-issue447 and then try to run theme watch again. It should at least output a better error for us to work with.

Sorry, I didn't understand your previous question, I don't have THEMEKIT_DIRECTORY variable, I just have the path to the themekit installation in the PATH envioronment variable.
I've updated to the version you sent, this is the output of watching a created file:
$ theme watch
14:12:27 [development] Watching for file changes on host XXXXX.myshopify.com
[development] loadAsset: File is a directory

Well that is bizarre, I did not expect that error message. I have no idea how that is happening. What text editor are you using?

I've copied a image file ( png ) from one directory to the one that is being watched by themekit. I also used command line touch to create a file. Both the same result.

What is the full path to your working directory? Change you name if you need to I just want to see if it contains special characters or something.

The full path is C:\Program Files\Theme Kit

Sorry no I meant your working directory. The directory that you are editing your theme.

Sorry, working directory is C:\Shopify Themes\site-custom

I want to chime-in and say that I also updated to patched version v0.0.0-issue447 and saw the exact same message @mmaauu saw.
I'm using TextMate on macOS.

Hey @mmaauu you will want to re-upload assets/73ag_AD_cuerpo_GG.png  while running my tests I corrupted that file. I am really very sorry about that.
I still cannot re-produce this issue on windows or OSX even with your exact config and your theme files. There has to be some detail I am missing.

Also as a side

Hi @tanema! Is there any solution for this? Can I rollback to the previous version, it was working good, how can I do?
Don't worry about the theme, this is a development and testing site, by the way, how could you get to access this theme and files?
Thank you very much for your help!

Hey @mmaauu, thanks for being understanding I felt really bad about that. As for access to you shop, I am a shopify employee and you had your domain in the command output above. I am able to access some data for support reasons.
You can roll back your command to the last completely stable version by running theme update --version=v0.6.12

Hey @mmaauu and @georgemandis
Can you once again install this patched version and see the error outputted by running this: theme update --version=v0.0.0-issue447
And again to rollback to the previous version you can run theme update --version=v0.6.12
This will most likely not fix it but at least give me a clear error message with file paths to compare and narrow down this issue.

Here's the message I now see:
Watching for file changes on host _____.myshopify.com
[development] Could not locate asset /Users/georgemandis/Projects/clients/client-project/shopify-theme/templates/collection.liquid in the directory /Users/georgemandis/clients/client-project/shopify-theme
I can confirm that /Users/georgemandis/Projects/clients/client-project/shopify-theme/templates/collection.liquid exists though.

Wait though, there is a difference between where the file event is happening and where the config root folder is
Config root: /Users/georgemandis/clients/client-project/shopify-theme
File Event: /Users/georgemandis/Projects/clients/client-project/shopify-theme
Are you using a sym-linked directory maybe?

Yeah I have confirmed that if I try to run theme watch in a symlinked directory I get the same errors, however I cannot run upload and replace but you said that those run fine still.

Okay I just updated the v0.0.0-issue447 version to eval symlinks before everything else so if you run  theme update --version=v0.0.0-issue447 again and I hope we have figured this out.

Hi @tanema, sorry for the delay... this version works right for me! Great!! Thank you very much for all your help!

Working for me as well! It must have been the symlinks. Good catch.

In my case, I think that there are no symlinks involved, but anyway it worked fine

I'm having a similar issue but instead of telling me it's watching for changes, it just gives me an "Access Denied" error. Could these be related? #454


[5.1] Fix Str::studly method for UTF-8 strings

Similar issue at #12923. Because of this bug, some of migrations file can't convert correctly. I fix it with adding a Str::ucwords method that can convert correctly utf-8 strings.
For example, 2016_03_13_134252_create_food_ingredients_table.php migration file is converted to CreateFoodingredientsTable instead of CreateFoodIngredientsTable. So when i run migration, this error throws:
[Symfony\Component\Debug\Exception\FatalThrowableError]
Fatal error: Class 'CreateFoodingredientsTable' not found

This issue occurs on PHP 7 setup when PHP locale is tr_TR.UTF-8

A lot of tests now fail.


build: Remove seaborn upper limit

Seaborn 0.13 fixes an issue with annotating heatmaps and I'd like to be able to use ydata-profiling in a repository that needs this fix.
I checked git blame and didn't see a reason for the upper-bound pin. I tested on 0.13.2 with Python 3.10 and all unit tests passed.

Would you be okay with upper pin on latest (0.13.2) provided tests pass?

Yes totally! That would do.

Thank you for approving! Is there any chance this could be included in the next release?

@fabclmnt pode fazer o merge o erro do lint message era um erro do actions que jah foi corrigido

@ggydush yes this will be included for the next release. Probably either this week or beginning of the next.
Thank you for your contribution.


corrected typos

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Chandan Rai seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


SBOM of Go modules missing entries for vendored dependencies

These test assertions in the Go language family are commented out because the version of syft that packit relies on has a bug that causes it to exclude vendored dependencies. This means SBOMs that are supposed to enumerate modules built into Go binaries contain no entries.
A fix for this bug has been released in syft. This buildpack's version of packit should be upgraded to one that uses a patched version of syft.

Blocked on https://github.com/paketo-buildpacks/packit/pull/299


MySQL not starting, rc.local causes crash

chronos@localhost / $ sudo edit-chroot -all
name: trusty
encrypted: no
Entering /mnt/stateful_partition/crouton/chroots/trusty...
crouton: version 1-20170315143304~master:95589555
release: trusty
architecture: armhf
xmethod: xorg
targets: lxde
host: version 9202.64.0 (Official Build) stable-channel daisy
kernel: Linux localhost 3.8.11 #1 SMP Wed Apr 5 12:57:09 PDT 2017 armv7l armv7l armv7l GNU/Linux
freon: yes
Not unmounting /mnt/stateful_partition/crouton/chroots/trusty as another instance is using it.
chronos@localhost / $

Please describe your issue:
I can't get MySQL to work in any version or environment of crouton. I followed the instructions here: Running-servers-in-crouton
...but that gives the following errors:
chronos@localhost / $ sudo startlxde -b
Entering /mnt/stateful_partition/crouton/chroots/trusty...
WARNING: starting chroot system dbus daemon failed with code 1
chronos@localhost / $ sudo startlxde
Entering /mnt/stateful_partition/crouton/chroots/trusty...
/usr/local/bin/xinit: 32: /usr/local/bin/xinit: cannot create /dev/null: Permission denied

/etc/X11/xinit/xserverrc: 1: /etc/crouton/xserverrc-xorg: cannot create /dev/null: Permission denied
Error, do this: mount -t proc proc /proc
/etc/X11/xinit/xserverrc: 20: [: Illegal number:
_XSERVTransmkdir: Owner of /tmp/.X11-unix should be set to root

X.Org X Server 1.15.1
Release Date: 2014-04-13
X Protocol Version 11, Revision 0
Build Operating System: Linux 3.2.0-67-highbank armv7l Ubuntu
Current Operating System: Linux localhost 3.8.11 #1 SMP Wed Apr 5 12:57:09 PDT 2017 armv7l
Build Date: 12 February 2015  02:55:07PM
xorg-server 2:1.15.1-0ubuntu2.7 (For technical support please see http://www.ubuntu.com/support)
Current version of pixman: 0.30.2
        Before reporting problems, check http://wiki.x.org
        to make sure that you have the latest version.
Markers: (--) probed, (**) from config file, (==) default setting,
        (++) from command line, (!!) notice, (II) informational,
        (WW) warning, (EE) error, (NI) not implemented, (??) unknown.
(++) Log file: "/tmp/Xorg.crouton.1.log", Time: Wed Apr 19 09:09:57 2017
(==) Using system config directory "/usr/share/X11/xorg.conf.d"
Initializing built-in extension Generic Event Extension
Initializing built-in extension SHAPE
Initializing built-in extension MIT-SHM
Initializing built-in extension XInputExtension
Initializing built-in extension XTEST
Initializing built-in extension BIG-REQUESTS
Initializing built-in extension SYNC
Initializing built-in extension XKEYBOARD
Initializing built-in extension XC-MISC
Initializing built-in extension SECURITY
Initializing built-in extension XINERAMA
Initializing built-in extension XFIXES
Initializing built-in extension RENDER
Initializing built-in extension RANDR
Initializing built-in extension COMPOSITE
Initializing built-in extension DAMAGE
Initializing built-in extension MIT-SCREEN-SAVER
Initializing built-in extension DOUBLE-BUFFER
Initializing built-in extension RECORD
Initializing built-in extension DPMS
Initializing built-in extension Present
Initializing built-in extension DRI3
Initializing built-in extension X-Resource
Initializing built-in extension XVideo
Initializing built-in extension XVideo-MotionCompensation
Initializing built-in extension SELinux
Initializing built-in extension XFree86-VidModeExtension
Initializing built-in extension XFree86-DGA
Initializing built-in extension XFree86-DRI
Initializing built-in extension DRI2
Loading extension GLX
(EE)
(EE) Backtrace:
(EE)
(EE) Segmentation fault at address 0x4
(EE)
Fatal server error:
(EE) Caught signal 11 (Segmentation fault). Server aborting
(EE)
(EE)
Please consult the The X.Org Foundation support
         at http://wiki.x.org
 for help.
(EE) Please also check the log file at "/tmp/Xorg.crouton.1.log" for additional information.
(EE)
(EE) Server terminated with error (1). Closing log file.
^C
Session terminated, terminating shell.../usr/bin/xinit: giving up
/usr/bin/xinit: unable to connect to X server: Connection refused
/usr/bin/xinit: unexpected signal 2
 ...terminated.
Unmounting /mnt/stateful_partition/crouton/chroots/trusty...
Sending SIGTERM to processes under /mnt/stateful_partition/crouton/chroots/trusty...

I also tried a 16.04 cli-extra environment, but that was giving me a message like 'you're in a chroot, ignoring request'
I tried 16.04 -t e17, but that gave similar errors to all the other 16.04 environments i've tried (xfce, and i think LXDE too).
chronos@localhost ~/Downloads $ sudo starte17
Entering /mnt/stateful_partition/crouton/chroots/xenial...

_XSERVTransmkdir: Owner of /tmp/.X11-unix should be set to root

X.Org X Server 1.18.4
Release Date: 2016-07-19
X Protocol Version 11, Revision 0
Build Operating System: Linux 4.4.0-59-generic armv7l Ubuntu
Current Operating System: Linux localhost 3.8.11 #1 SMP Wed Apr 5 12:57:09 PDT 2017 armv7l
Kernel command line: cros_secure console= console= loglevel=7 init=/sbin/init cros_secure oops=panic panic=-1 root=/dev/dm-0 rootwait ro dm_verity.error_behavior=3 dm_verity.max_bios=-1 dm_verity.dev_wait=1 dm="1 vroot none ro 1,0 2539520 verity payload=PARTUUID=687a75b4-10fc-4542-8c95-bf6fac6fb14a/PARTNROFF=1 hashtree=PARTUUID=687a75b4-10fc-4542-8c95-bf6fac6fb14a/PARTNROFF=1 hashstart=2539520 alg=sha1 root_hexdigest=3a76006bc9fffd4a760c466ba765430814efd24b salt=07e353a4a23a7dae21a29a5d5cbacc32f6ff67fea8acfa6fb3b0af38fd249035" noinitrd vt.global_cursor_default=0 kern_guid=687a75b4-10fc-4542-8c95-bf6fac6fb14a
Build Date: 26 January 2017  12:27:19AM
xorg-server 2:1.18.4-1ubuntu6.1~16.04.1 (For technical support please see http://www.ubuntu.com/support)
Current version of pixman: 0.33.6
        Before reporting problems, check http://wiki.x.org
        to make sure that you have the latest version.
Markers: (--) probed, (**) from config file, (==) default setting,
        (++) from command line, (!!) notice, (II) informational,
        (WW) warning, (EE) error, (NI) not implemented, (??) unknown.
(++) Log file: "/tmp/Xorg.crouton.1.log", Time: Mon Apr 17 01:32:33 2017
(==) Using system config directory "/usr/share/X11/xorg.conf.d"
gbm: failed to open any driver (search paths /usr/lib/arm-linux-gnueabihf/dri:${ORIGIN}/dri:/usr/lib/dri)
gbm: Last dlopen error: /usr/lib/dri/exynos_dri.so: cannot open shared object file: No such file or directory
failed to load driver: exynos
EGL_MESA_drm_image required.
(EE)
Fatal server error:
(EE) AddScreen/ScreenInit failed for driver 1
(EE)
(EE)
Please consult the The X.Org Foundation support
         at http://wiki.x.org
 for help.
(EE) Please also check the log file at "/tmp/Xorg.crouton.1.log" for additional information.
(EE)
(EE) Server terminated with error (1). Closing log file.
/usr/bin/xinit: giving up
/usr/bin/xinit: unable to connect to X server: Connection refused
/usr/bin/xinit: server error
Unmounting /mnt/stateful_partition/crouton/chroots/xenial...
chronos@localhost ~/Downloads $

I really care about getting MySQL working. The fact that I can't get any Xenial GUI environment to work, and don't know how to deal with the issues I'm getting in Xenial cli-extra, are other problems worthy of their own bug report.
If known, describe the steps to reproduce the issue:
Use an XE303C12 (1st Gen, ARMv7) Chromebook, with ChromeOS stable, updated recently.
Set up crouton Trusty with LXDE.
sudo apt-get install mysql-server-5.6 (or mysql-server which is 5.5)
Try to start the server, or do anything with it...
Notes:
I had PostgreSQL working fully with PHP 5 and Apache2 on crouton with Ubuntu 12.04 and LXDE. But I need MySQL (preferrably MariaDB) for specific testing.
I'm trying to set up a LAMP server, but it's not a dedicated server. I still need to use the chroot for everyday computing. So I doubt I really want HOME=/etc/mysql

A Quick Solution
sudo /etc/init.d/mysql start
A Better Solution

Add /etc/mysql/my.cnf:
Visit: MySQL 5.6 Official Docs - Option Files
Copy "Typical Global Option File" text to new file: my.cnf
Move that file to /etc/mysql/

Give the "mysql" user a home, and make it theirs:

sudo mkdir /home/mysql
sudo usermod -d /home/mysql mysql
sudo chown mysql /home/mysql
sudo chgrp mysql /home/mysql

Start MySQL properly:
sudo /etc/init.d/mysql start

Stop MySQL properly, then kill it:

sudo /etc/init.d/mysql stop
sudo killall mysqld

Notes:
When starting MySQL, it still says [FAIL]. I'm not sure where that's coming from. That text isn't in the /etc/init.d/mysql script. Regardless, the service does start.
When I installed mysql-server-5.6, in Ubuntu 14.04, there were several errors, namely:

runlevel:/var/run/utmp: No such file or directory
invoke-rc.d: policy-rc.d denied execution of start.


fix #1314 - limit doesn't work properly with more than one digit

the suggestions where sliced with:
rendered += suggestions.length;
suggestions.slice(0, that.limit - rendered)
which is fine as long as  limit < suggestions.length  because slicing with a negative index works
but if limit = suggestions.length then no element is rendered.
if limit > suggestions.length then the results are truncated.

I just ran into the same issue. If limit == suggestions it shows no results.

@PierreAnctil Could you please re-submit this PR to github:corejavascript/typeahead.js. This project pretty much has been abandoned, and we continue now on a new fork. For more information please see #1320

Looks like a duplicate of #1212, has been fixed over at corejavascript/typeahead.js#8

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


dashboard: access config through context

We used to have a single global config variable and access it
throughout the whole dashboard application.
However, this approach has been more and more complicated test writing
-- sometimes we want the config to be only slightly different, so that
it's not worth it adding new namespaces, sometimes we have to test how
dashboard handles config changes over time.
This has already led to a number of hacky contextWithXXX methods that
mocked various parts of the global variable. The rest of the code had to
sometimes still use config directly and sometimes invoke getXXX(c)
methods. This is very inconsistent and prone to errors.
With more and more situations where we need to patch the config
appearing (see https://github.com/google/syzkaller/issues/4118), let's refactor the application to always access
config via the getConfig(c) method. This allows us to uniformly patch
the config and be sure that the non-patched copy is not accessible from
anywhere else.
Closes #4118

The last bit we need is a check somewhere that we don't modify the global config accidentially. It's still possible to do directly, or if there is a subtle bug in replace*Config functions (they don't do a deep copy, so it's easy to make a bug that will modify something shared with the global config).
Instead of finding these the hard way via races, it would be better to add some bullet-proof wholesale check that the global config is not modified in tests. E.g. make a copy of the global config and then check at some points that it's not changed. There is no deep copy in the standard library unfortunatly, but one simple solution is to serialize it to json and compare these strings.


[WIP] App settings on a top-level “Umbrella” container

This is a much simplified take on app settings compared to https://github.com/dry-rb/dry-web/pull/25, and I like it a lot more.
It automatically loads the settings onto the umbrella container, which I like, and it applies some sensible defaults while still allowing the developer to replace the whole settings object with something of their own choosing, if they want.
It also will nicely support integration with dry-types for people who want to make their settings stricter (or coerce stuff coming in from the ENV into richer Ruby types).
This is feeling like a decent path for us to include in the near term.

Looks like a really good direction. It's great you extracted an explicit "umbrella" concept :)

@solnic better still, the umbrella will keep you DRY :joy:

This is ready to go now. You happy with how this looks?
Here's how it'd work in a real dry-web app: https://github.com/icelab/berg/pull/80/files
Basically, inside the umbrella component we'd have a component/my_app/settings.rb file with something like this:
module MyApp
  class Settings < Dry::Web::Settings
    setting :foo
    setting :bar
  end
end

And then inside the umbrella component:
require_relative "settings"

module MyApp
  class Container < Dry::Web::Umbrella
    configure do |config|
      config.settings_loader = MyApp::Settings
    end
  end
end

For new apps, we'd have this all put into place for us via an app generator, of course.

I left a couple of comments, and don't forget that:

Now that it's raining more than ever
Know that we'll still have each other
You can stand under my umbrella

😆 ❤

Merging this! I'll probably see if I can make a release once the app generator is in place.


Fix Azure Monitor Checkstyle Suppressions

This PR fixes Azure Monitor Checkstyle suppressions that weren't updated when the artifact and packages were renamed.

/azp run java - monitor

/azp run java - monitor


Revert "fix: vim.eval('v:true') should return python bool #506"

This reverts commit d549371b6fb647304cff5f88a71e2bc42d2ed30a. This fixes #523 and make UltiSnips usable. As mentioned by @jsr-p, the extra check is redundant and is not worth the slower performance.

The checks are failing even without the changes that I made (when the fork is identical to the current upstream) (https://github.com/samuelqp/pynvim/actions/runs/8304465825).

Thanks for the PR!
The tests are broken because they refer to a (internal) function that was removed in https://github.com/neovim/neovim/commit/eb5d15e3838f53e2fcd25989c88db87458e9f984
Fixed in https://github.com/neovim/pynvim/pull/563 , would you mind rebasing ?

Thanks! Seems good now.

One more ask: can you add a "Known issues" section after this section which explains this quirk? So that we don't get repeat reports of https://github.com/neovim/pynvim/pull/506


Identify the first round of React components we will build

We should create a running list of React components we will build for the transition. We can do this as a meeting like a bug bash, or we can just create an issue in ZenHub and start listing out what we think, and do that discussion asynchronously to start. @drew-usds this is your area of expertise, so you should definitely guide this.

This is OBE
We will create the same components as in the older eleventy site


Notebooks: Save connection information in metadata

This PR adds the ability to save a connection name (alias) in the notebook metadata.
If a notebook with a saved connection name is opened, the attach to dropdown is updated to show the connection name. When the first cell is run, we search for the connection profile that matches the connection name. If a valid connection profile is found, we use that, otherwise we show the connection dialog as usual. For now, if there is no connection name, nothing is saved and the behavior is the same as before.
I added a setting for this feature (by default, connection name saving is off and attachTo dropdown won't be updated).
Note: There was more discussion around saving an alias vs data source name. For now I am using alias and if we decide to save something different in the future, it will be an easy change since the functionality of saving and reading connection information from metadata will be the same.

Looks like some of the new unit tests are failing.

Pull Request Test Coverage Report for Build 337909761

15 of 24 (62.5%)  changed or added relevant lines in 2 files are covered.
2353 unchanged lines in 68 files lost coverage.
Overall coverage decreased (-0.2%) to 39.575%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/sql/workbench/services/notebook/browser/models/notebookModel.ts
14
16
87.5%

src/sql/workbench/contrib/notebook/browser/notebookActions.ts
1
8
12.5%

Files with Coverage Reduction
New Missed Lines
%

extensions/machine-learning/src/views/models/manageModels/currentModelsComponent.ts
1
83.67%

extensions/machine-learning/src/views/models/prediction/columnsSelectionPage.ts
1
65.93%

extensions/resource-deployment/src/ui/deployClusterWizard/pages/azureSettingsPage.ts
1
23.68%

extensions/resource-deployment/src/ui/deployClusterWizard/pages/deploymentProfilePage.ts
1
9.23%

extensions/resource-deployment/src/ui/deployClusterWizard/pages/targetClusterPage.ts
1
9.28%

src/sql/workbench/contrib/notebook/browser/models/untitledNotebookInput.ts
1
85.71%

extensions/azurecore/src/azureResource/providers/database/databaseService.ts
2
0%

extensions/machine-learning/src/common/constants.ts
2
89.93%

src/sql/platform/accounts/common/accountViewModel.ts
2
90.91%

extensions/machine-learning/src/views/models/modelSourcePage.ts
3
72.73%

Totals

Change from base Build 324620759:
-0.2%

Covered Lines:
20670

Relevant Lines:
47962

💛  - Coveralls

@Charles-Gagnon Since we haven't fully decided on saving only the connection name in metadata, I won't be handling that scenario in this PR. If we do decide on saving the connection name we will have to think about what the best way to handle that scenario is (ex. prompting the user to enter an alias), as well as what to do with connection names that are not unique.


implement user alias management

Adds several methods to enable management of user cloud aliases:
users add-alias
users remove-alias
users bulk add-alias
users bulk remove-alias

Also updates tests and changelog appropriately.

Hey Cecilia!
Thanks for putting this up, made a couple notes but overall looks great! If you want me to push some unit test commits just let me know.

Hey Cecilia!
Thanks for putting this up, made a couple notes but overall looks great! If you want me to push some unit test commits just let me know. (I'm also working on fixing the github actions integration tests Update: These should be fixed now, you'll just have to catch up to main)

I'll add the additional tests you mention when I get a chance, but if you get to them before I do please feel free to push.

Updated error handling again; it turns out the character limit is enforced by the UI, so I added a test for that so that we don't end up adding aliases that are longer than other parts of the system expect. Additionally, updated the error text to clarify that a request has failed specifically because the user already has more than two aliases.

Doing some final reviewing on this PR and turns out the error handling around exceeding the number of cloud aliases on the py42 side for add_cloud_alias() isn't correct, so I'll be fixing that on the py42 side before we merge this one.


[Do not merge][CIRCLE-11050] Open port 8125

Problem
We need to expose UDP port 8125 on the Services Box to Nomad clients.
Solution
Port 8125 is now exposed to Nomad clients with an ingress rule added in circleci.tf.

Notes
Changed client_security_group_name to client_security_group_id, as no one was using the variable anyway 🤷♀

Thank you for the contribution!
Before we merge this we would like to make sure we know why port 8125 is required to be opened. Do you mind adding additional details about this port for us to review? Also the title of the PR suggests that this should not be merged, is that still the case?


fix autocomplete wind preset input text size is hard coded as sm:text-sm

converting same to text-base as in lara

Hi, thank you for your PR, but the small text size is a design choice for the wind preset. Also, the wind preset will be replaced with the upcoming Aura preset. I will continue to maintain wind but will be on the gallery and will be unofficial.


api-supported-version does not honor actions, only controllers

The api-supported-version does not honor actions, it is generated according to controller aggregation.
For example, assuming we have two versions v2021-07-01-preview and v2021-08-01-preview, and the below structure.
As you can see below, [GET] /test/Bar exists only in v2021-08-01-preview, and when I try to call it with API Version v2021-07-01-preview I get UnsupportedApiVersion as expected, but in the response headers, in api-supported-versions I get also 2021-07-1-preview which does not support this action.
allow: GET
 api-supported-versions: 2021-07-01-preview2021-08-01-preview
 content-type: application/json; charset=utf-8
 date: Thu08 Jul 2021 12:11:33 GMT
 server: Kestrel

Am I doing something wrong? Can we change this behavior?
Project structure and classes:
Project
|
\Controllers
    |
    \v2021_07
         |
         ./TestController.cs
    |\v2021_08
        |
        ./TestController.cs

The older controller:
namespace ApiVersioningTest.Controllers.v2021_07
{
    [ApiController]
    [ApiVersion("2021-07-01-preview")]
    [Route("test")]
    public class TestController : ControllerBase
    {
        [HttpGet]
        [Route("Foo")]
        public IActionResult Foo()
            => Ok("This is Foo: 2021-07-01-preview");
    }
}

The newer version:
namespace ApiVersioningTest.Controllers.v2021_08
{
    [ApiController]
    [ApiVersion("2021-08-01-preview")]
    [Route("test")]
    public class TestController : ControllerBase
    {
        [HttpGet]
        [Route("Foo")]
        public IActionResult Foo()
            => Ok("This is Foo: 2021-08-01-preview");

        [HttpGet]
        [Route("Bar")]
        public IActionResult Bar()
            => Ok("This is Bar: 2021-08-01-preview");
    }
}

public class Startup
    {
        public Startup(IConfiguration configuration)
        {
            Configuration = configuration;
        }

        public IConfiguration Configuration { get; }

        public void ConfigureServices(IServiceCollection services)
        {

            services.AddMvc();

            services.AddControllers();

            services.AddApiVersioning(options => {
                options.ReportApiVersions = true;
            });

            services.AddVersionedApiExplorer();

            services.AddSwaggerGen(c =>
            {
                c.SwaggerDoc("2021-08-01-preview", new OpenApiInfo { Title = "2021-08-01-preview", Version = "2021-08-01-preview" });
                c.SwaggerDoc("2021-07-01-preview", new OpenApiInfo { Title = "2021-07-01-preview", Version = "2021-07-01-preview" });
            });
        }

        public void Configure(IApplicationBuilder app, IWebHostEnvironment env)
        {
            if (env.IsDevelopment())
            {
                app.UseDeveloperExceptionPage();
                app.UseSwagger();
                app.UseSwaggerUI(options =>
                {
                    options.SwaggerEndpoint("/swagger/2021-08-01-preview/swagger.json", "2021-08-01-preview");
                    options.SwaggerEndpoint("/swagger/2021-07-01-preview/swagger.json", "2021-07-01-preview");
                });
            }

            app.UseHttpsRedirection();

            app.UseRouting();

            app.UseAuthorization();

            app.UseEndpoints(endpoints =>
            {
                endpoints.MapControllers();
            });
        }
    }

Currently, this is by design. While I agree that it's not unreasonable to group by action, it's much more complicated than it appears. Grouping test/bar is pretty simple, but things quickly get much more complex. Consider that values/{id} and values/{id:int} are semantically equivalent (e.g. equal). They should be grouped together, but it requires a much deeper evaluation of the route template.
Now consider something more elaborate such as values/{id}/subvalues. If grouping is purely on action, then all actions are treated as root-level APIs when they might not be. RESTful APIs are typically resource-based, but they don't have to be. Containment around those resources aren't necessarily separate APIs. More importantly, there isn't a clear way to determine what a developer means by route template alone. This could lead to a situation where API versions for actions are incongruent with each other unintentionally. Another issue will be how APIs are collated for OpenAPI/Swagger. Versioned APIs are bucketized by API version and then by controller/resource name.
Today, the only reliable and sensible way to group logical sets of APIs together is by controller name. I've been thinking about new ways to facilitate this so developers have more control over that grouping; for example, what if there is no controller? You still need to group, but I don't think that route template alone will ever be enough. This will mean that some new facility will need to be added so you can specify the logical name of an endpoint to decide which APIs should be grouped together.
The api-supported-versions and api-deprecated-versions was never meant to define the API versions for a specific action, although they could. Detailed API information can be comprehensive and is better supported by OpenAPI documents. Two useful things that these values can provide are:

Which API versions are supported and deprecated?

OpenAPI doesn't tell you this
You could implement OPTIONS, which would return the aggregated set to choose an OpenAPI document

Is the API version I'm using deprecated?

This provides an automated communication path to clients who honor it to let them know their API will be going away at some point

That's probably not the answer you were looking or hoping for, but I hope it clears things up - if not a little.
TL;DR
A couple of side notes...
You don't have to declare actions as separate routes. In classic Web API, you had [RoutePrefix] and [Route], where [Route] on the action mapped the endpoint. This is almost backward in ASP.NET Core. Adding the suffix to the HTTP method route constraint will suffice. You can also use the [controller] and [action] tokens. [action] uses the name of the method for the path segment. You could also use nameof(Foo). This helps avoid a class of mistakes if you refactor the method name. For example:
[ApiController]
[ApiVersion("2021-08-01-preview")]
[Route("[controller]")]
public class TestController : ControllerBase
{
    // GET test/foo
    [HttpGet("[action]")]
    public IActionResult Foo()
        => Ok("This is Foo: 2021-08-01-preview");

    // GET test/bar
    [HttpGet("[action]")]
    public IActionResult Bar()
        => Ok("This is Bar: 2021-08-01-preview");
}

If you follow the Swagger Sample, you'll see that you don't need to list the documents manually. You can build them with simple loops based on the collated set of API versions. This is a big part of the feature support for the API Explorer extensions so you don't have to keep changing that code when versions are added or removed. Startup.cs will show you how to map the endpoints and ConfigureSwaggerOptions.cs will show you how to create new document information for each API version.

Thank you @commonsensesoftware for your prompt and elaborate response. I really appreciate the effort and that you shared the cause, thoughts, and design for this behavior with us 😊
Also thank you for the tips regarding the route and swagger. I will take them into account!

I'm running into this problem now, trying to make the client log useful info when versions are mismatched.
Example code:
[ApiController]
[ApiVersion("1.0")]
[Route("[controller]")]
public class TestController : ControllerBase
{
    // GET test/foo
    [HttpGet("[action]")]
    [ApiVersion("1.0")]
    public IActionResult Foo()
        => Ok("This is Foo: 1");

    // GET test/bar
    [HttpGet("[action]")]
    [ApiVersion("2.0")]
    public IActionResult Bar()
        => Ok("This is Bar: 2");

    // GET test/xyz
    [HttpGet("[action]")]
    [ApiVersion("3.0")]
    public IActionResult Xyz()
        => Ok("This is Xyz: 3");
}

When calling the method "Xyz" with version "2", you will get "Unsupported API version" with "api-supported-versions: 1.0, 2.0, 3.0". Looking at such info in logs will seem strange, like why would the method fail, when it clearly supports the requested version?!
Is there some workaround for that, other than creating a new controller for each method?

@Sirozha1337 The issue isn't so much about a new controller or action. An API is more than a single endpoint. An API often has several different endpoints. The Orders API, for example, might have a GET, POST, and DELETE method endpoint. In your example, you have defined the Test API. Collation occurs at the API level, which is its logical name. If you are using controllers, then it will be the controller name. There really is no other way that collation can be done.
As mentioned above, a set of API versions alone cannot fully describe what endpoint may be available for a particular version. Other tools such as OpenAPI are better suited for that. What api-supported-versions tells you is what versions of an API, the entire API, are supported. This may seem unintuitive when you interpolate versions on a single controller, but it becomes more apparent when you split versions into different controller types, which is the more common approach. There is a lot of fragility in trying to collate by action template, name, etc.
Exactly how a client would even get into this situation varies. This would mostly likely occur if a client bound to an older API version updates without OpenAPI and just assumes the same endpoints are supported in the next version. There isn't a clear way to indicate the list of supported endpoints so the message is a little misleading. The message should be interpreted to be read as "The endpoint you requested has a supported version - possibly several, but not the one you asked for."
There are likely some workarounds, but they are non-trivial and would be very specific to the way you implemented versioning on the server side. For example, you might collate by full route template because you know and have control over those templates. Implementing that in a generic way for every possible application is much more difficult.
If you were not aware, there is a client-side, API version-aware library to facilitate both including the API version in requests automatically and logging scenarios such as when you are using a deprecated version or when a new version becomes available. If you use the newer Sunset Policy feature, a client may even know exactly when a particular version will sunset for good.

@commonsensesoftware thanks for the detailed answer. While I understand why it was done this way, I think it should be a customizable feature. I tried replacing the services in DI with my own implementations, but it feels hacky and doesn't seem to work correctly for my case. If you can share some of the known workarounds, that would be great. My action templates do not contain path parameters, so it should be easy to group by endpoint's path. Also my API is an internal one and I do not intend to support multiple versions for longer than a week or so, just until I update my other services, that are consuming the API.

@Sirozha1337,
"I knew you'd say that!" 🤣
Changing the way things are aggregated is not trivial and is deeply involved. Save for a few basic tweaks, there aren't a lot of hooks at that level. I probably could do it, but I'm not sure it's worth it. Fortunately, there should be an easier way.
You're not the first person to ask this. I baked in a change some time back that should get you want you want. You likely don't need to change how aggregation is done, but rather how reporting is done. Every endpoint has an ApiVersioningMetadata that consists of an optional, logical name, an ApiVersionModel for the overall API, and an ApiVersionModel for a specific endpoint. The ApiVersionModel for the endpoint is referred to as the explicit model, while the overall API variant is the implicit model. You can ask for either or a union of both via the ApiVersionMapping enumeration.
The IReportApiVersions service is what reports API versions in responses. It now has a Mapping property for the ApiVersionMapping enumeration so that consumers know which mapping to use to generate the model before reporting it. The default service registration will include both implicit and explicit mappings. You can reconfigure and reregister the service without having to create a custom implementation like so:
services.Replace(ServiceDescriptor.Singleton<IReportApiVersions>(sp =>
  new DefaultApiVersionReporter(
    sp.GetRequiredService<ISunsetPolicyManager>(),
    mapping: ApiVersionMapping.Explicit)));

If your APIs are interleaved on a single controller with explicit [ApiVersion]s declared on your actions, then this configuration should work for you. If you start trying to split things apart into different types, this will probably not work because the API versions defined by different actions will be considered implicit, even though they have the same route template.
Let's start with that and see if it works for you. I have some ideas about how you might break things apart without having to completely change the default aggregation, but it's going to be quite involved.

Thanks! Sadly, I'm still on the .NET 6 (sorry for not mentioning that earlier). I changed it like this, but it still didn't work:
services.Replace(ServiceDescriptor.Singleton<IReportApiVersions>(sp =>
    new DefaultApiVersionReporter(
        mapping: ApiVersionMapping.Explicit)))

It reports all the versions available in the controller as supported by the endpoint.
Guess, I'll just have to live with that and do not include those versions when handling errors in client code.

@Sirozha1337 Ah - yes - there is a slight difference between the 6.x and 7.0+ setup, but it looks like you figured it out.
Actually, I got ahead of myself. You're correct; this won't work. In fact, I'm not sure that it can be made to work. The reason that it can't work (easily) is that you want to report the supported versions when an request does not match back to the client. That is extremely challenging. How can you report any API versions if you don't know the target endpoint? The endpoint is unmatched.
There was actually no way to initially do this at all when 6.0 was released. This was a breaking behavior change from days gone by. This happened because changes to routing itself were required to get the proper responses for 405, 406, and 415; the API version has to be mapped earlier in the route tree. Then some people wanted the reporting functionality back.
I had to think long and hard about it, but I was finally able to restore parity with the <= 5.x behavior. I effectively rely on the routing system building up the tree mapping using similar route templates. This feels brittle, but so far it seems work out, even though it's technically best effort. For 6.x, you can take a peek here:
https://github.com/dotnet/aspnet-api-versioning/blob/e9242d65295f2e9d18ab324d0776c85e75321ab6/src/AspNetCore/WebApi/src/Asp.Versioning.Http/Routing/ApiVersionMatcherPolicy.cs#L120
and here:
https://github.com/dotnet/aspnet-api-versioning/blob/e9242d65295f2e9d18ab324d0776c85e75321ab6/src/AspNetCore/WebApi/src/Asp.Versioning.Http/Routing/ApiVersionMatcherPolicy.cs#L355
It would probably technically be possible to add a service that could control aggregation, but I'm still not sure it helps. Assuming you could bucketize by route template and API versions, the challenge is that you still don't have a match. You'd have to determine the best non-match, which seems really complex and brittle.
This is an area where I wouldn't mind improving things. If you have some ideas about how that may be possible, I'm willing to explore it a bit further. It should probably be queued up a new enhancement or feature request.

@commonsensesoftware ah, I see. So it routes by both the version and route at the same time? I guess, aggregation won't help there at all then...
Thanks a lot for the pointers, though! I'll look into the code.

@Sirozha1337 If you're really that brave to dive down to that level, then you will likely find the DAG generated in acceptance tests useful:
https://github.com/dotnet/aspnet-api-versioning/blob/2292fbe6a1598d944cd5cbca918cb79da7339116/src/AspNetCore/Acceptance/Asp.Versioning.Mvc.Acceptance.Tests/HttpServerFixture.cs#L38
When you run any of the acceptance tests, this link will be generated for the fixture. Fixture setup is expensive, so expect that there is probably only one DAG, even if the link is generated many times (at the test level). You can take the link generated and paste it into a browser. That will provide a visualization of the routing tree as a DAG. More than anything, it will provide a visualization as to how routing decisions are made. I found this little gem to be very useful for debugging.

It is ApiVersionMetadata, not ApiVersioningMetadata.


MORAY-326: node fast connection timeout not cleared on close

Fixes MORAY-326.
The newly added test currently uses process._getActiveHandles(), which is far from ideal. The only other way to test that I could think of was to add an option to createClient to not suppress errors on close and check that the 'connectError' event is not emitted.
The previous test 'socket properly hangs up via close' was updated so that it would end when the timeout's callback runs, so that no active handle is left and process._getActiveHandles can be used in the newly added test.

/cc @pfmooney

Merged in 8a1d3eeb4aebb49c5160b4725989e0df13def2d2.
Thanks


Integration Test - Release - 2018/06/07 09:39:42

Auto create for integration test. AnotherAuthorUpdatedArticleFlow

@PRMergerTest2 : Thanks for your contribution! The author, @v-caxian, has been notified to review your proposed change.


[App]: Images rendered way too small

Current Behavior
No matter how I try to shape images (i.e., pngs with wandb.Image), they are rendered horribly in the web-app. Either being far too small or far too large.
Expected Behavior
It would be nice if the web-app could dynamically adjust the stretch (with fixed aspect-ratio that is) the panel to give a better view of logged images.
Steps To Reproduce
import matplotlib.pyplot as plt
import wandb

# Initialize wandb etc.

plt.plot ...

wandb.log({'my_plot': plt}  # Doesn't matter how I scale plt with figsize, as the app doesn't nicely render this anyway...

Screenshots
Currently I get this:

I would like this to stretch so I can actually see the image (which I did right now manually in Paint as an example...):

Environment
OS: Mac/ OSx and Windows 10/ 11
Browsers: Google Chrome
Version:
Additional Context
No response

WandB Internal User commented:
ArtsiomWB commented:
Hi @joeryjoery ! Thank you for writing in! Could you please send a link to the workspace where you are seeing this behavior?

The workspace I took the image from is private, but this is the link: https://wandb.ai/joery/AXME/runs/qifajder?workspace=user-joery
The plot is under the category: EvaluationService/sample_plots/gridworld.SquareGrid/0/plots.
I also edited my issue to include the OS and browser.

Apologies for wasting your time, turns out I swapped the matplotlib figure sizes (swapped height and width) accidentally.
Now it works fine.

WandB Internal User commented:
joeryjoery commented:
Apologies for wasting your time, turns out I swapped the matplotlib figure sizes (swapped height and width) accidentally.
Now it works fine.


Fix(duplication):fix some nodes can not send dup message cause by combine raw write message

What problem does this PR solve?
#1840
What is changed and how does it work?
1.read the config of  max_allowed_write_size
2.judge if current duplication batch_bytes greater than  max_allowed_write_size
So that we can prevent master cluster send some message that backup cluster can not receive.
Side effects

master cluster send message by batch or not

What's the relationship between the newly added config and duplicate_log_batch_bytes?

What's the relationship between the newly added config and duplicate_log_batch_bytes?

duplicate_log_batch_bytes is the batch size you can set,always set to 4096.
The 'newly' added config max_allowed_write_size is the max size of a write mutation that a cluter could received. Not only duplication write,normal write will be limit by this config also.
If we only consider duplicate_log_batch_bytes,master will send some mutations that backup cluster can not receive. Backup cluster will log:
E2024-01-04 11:42:02.88<PHONE_NUMBER>088300009 6004) replica.replica7.0400174218c587bd: replica_stub.cpp:1645:response_client(): 22.53@xx.xx.xx.xx:42801: write fail: client = xx.xx.xx.xxx:42801, code = RPC_RRDB_RRDB_DUPLICATE, timeout = 236, status = replication::partition_status::PS_PRIMARY, error = ERR_INVALID_DATA

60992:W2024-01-04 11:47:33.656<PHONE_NUMBER>656585710 6004) replica.replica7.0400174218c58cd1: replica_2pc.cpp:77:on_client_write(): [22.53@xxxx:42801] client from xxxx:42801 write request body size exceed threshold, request = [default], request_body_size = 1048716, max_allowed_write_size = 1048576, it will be rejected!

We can see it clear that request_body_size(master cluster send to backup cluster) is greater than max_allowed_write_size.

What's the relationship between the newly added config and duplicate_log_batch_bytes?

duplicate_log_batch_bytes is the batch size you can set,always set to 4096. The 'newly' added config max_allowed_write_size is the max size of a write mutation that a cluster could received. Not only duplication write,normal write will be limit by this config also.
If we only consider duplicate_log_batch_bytes,master will send some mutations that backup cluster can not receive. Backup cluster will log:
E2024-01-04 11:42:02.88<PHONE_NUMBER>088300009 6004) replica.replica7.0400174218c587bd: replica_stub.cpp:1645:response_client(): 22.53@xx.xx.xx.xx:42801: write fail: client = xx.xx.xx.xxx:42801, code = RPC_RRDB_RRDB_DUPLICATE, timeout = 236, status = replication::partition_status::PS_PRIMARY, error = ERR_INVALID_DATA

W2024-01-04 11:47:33.656<PHONE_NUMBER>656585710 6004) replica.replica7.0400174218c58cd1: replica_2pc.cpp:77:on_client_write(): [22.53@xxxx:42801] client from xxxx:42801 write request body size exceed threshold, request = [default], request_body_size = 1048716, max_allowed_write_size = 1048576, it will be rejected!

We can see it clearly that request_body_size(master cluster send to backup cluster) is greater than max_allowed_write_size.

What's the relationship between the newly added config and duplicate_log_batch_bytes?

duplicate_log_batch_bytes is the batch size you can set,always set to 4096. The 'newly' added config max_allowed_write_size is the max size of a write mutation that a cluster could received. Not only duplication write,normal write will be limit by this config also.
If we only consider duplicate_log_batch_bytes,master will send some mutations that backup cluster can not receive. Backup cluster will log:
E2024-01-04 11:42:02.88<PHONE_NUMBER>088300009 6004) replica.replica7.0400174218c587bd: replica_stub.cpp:1645:response_client(): 22.53@xx.xx.xx.xx:42801: write fail: client = xx.xx.xx.xxx:42801, code = RPC_RRDB_RRDB_DUPLICATE, timeout = 236, status = replication::partition_status::PS_PRIMARY, error = ERR_INVALID_DATA

W2024-01-04 11:47:33.656<PHONE_NUMBER>656585710 6004) replica.replica7.0400174218c58cd1: replica_2pc.cpp:77:on_client_write(): [22.53@xxxx:42801] client from xxxx:42801 write request body size exceed threshold, request = [default], request_body_size = 1048716, max_allowed_write_size = 1048576, it will be rejected!

We can see it clearly that request_body_size(master cluster send to backup cluster) is greater than max_allowed_write_size.

duplicate_log_batch_bytes is optional, how to comprehend "always" set to 4096?
I only saw max_allowed_write_size is used in duplication module, how it take effect on "normal write"?
What's the config value of duplicate_log_batch_bytes in your environment, if it's less than the config value of max_allowed_write_size in backup cluster (i.e. 1048576), how can this situaction happen?

What's the relationship between the newly added config and duplicate_log_batch_bytes?

duplicate_log_batch_bytes is the batch size you can set,always set to 4096. The 'newly' added config max_allowed_write_size is the max size of a write mutation that a cluster could received. Not only duplication write,normal write will be limit by this config also.
If we only consider duplicate_log_batch_bytes,master will send some mutations that backup cluster can not receive. Backup cluster will log:
E2024-01-04 11:42:02.88<PHONE_NUMBER>088300009 6004) replica.replica7.0400174218c587bd: replica_stub.cpp:1645:response_client(): 22.53@xx.xx.xx.xx:42801: write fail: client = xx.xx.xx.xxx:42801, code = RPC_RRDB_RRDB_DUPLICATE, timeout = 236, status = replication::partition_status::PS_PRIMARY, error = ERR_INVALID_DATA

W2024-01-04 11:47:33.656<PHONE_NUMBER>656585710 6004) replica.replica7.0400174218c58cd1: replica_2pc.cpp:77:on_client_write(): [22.53@xxxx:42801] client from xxxx:42801 write request body size exceed threshold, request = [default], request_body_size = 1048716, max_allowed_write_size = 1048576, it will be rejected!

We can see it clearly that request_body_size(master cluster send to backup cluster) is greater than max_allowed_write_size.

duplicate_log_batch_bytes is optional, how to comprehend "always" set to 4096?
I only saw dup_max_allowed_write_size is used in duplication module, how it take effect on "normal write"?
What's the config value of duplicate_log_batch_bytes in your environment, if it's less than the config value of max_allowed_write_size in backup cluster (i.e. 1048576), how can this situaction happen?

1.Becauseduplicate_log_batch_bytes default value is 4096
2.I saw  max_allowed_write_size in replica_2pc_cpp.Here it can effect on "normal write"
3.It's not easy for master cluster get the value of duplicate_log_batch_bytes config by backup cluster. I don't think it's necessary for master cluster to get this value,because when we doing duplication ,we usually keep the similarity config between two clusters.
I'm sorry that what I said above caused ambiguity.

Is it necessary to add the new config? Can the issue be resolved by adjust duplicate_log_batch_bytes on master cluster or max_allowed_write_size on backup cluster?

3.It's not easy for master cluster get the value of duplicate_log_batch_bytes config by backup cluster. I don't think it's necessary for master cluster to get this value,because when we doing duplication ,we usually keep the similarity config between two clusters.

I'm sorry that what I said above caused ambiguity.

In this patch, a new config dup_max_allowed_write_size is added, it face the same issue.
An alternative way is to set DSN_TAG_VARIABLE(max_allowed_write_size, FT_MUTABLE), then you can change the value by HTTP (e.g. ip:port/updateConfig?max_allowed_write_size=2097152) without restart the server.

Is it necessary to add the new config? Can the issue be resolved by adjust duplicate_log_batch_bytes on master cluster or max_allowed_write_size on backup cluster?

If the maintainer of the duplication clusters config max_allowed_write_size  to zero , the problem will be resolved. However , if maintainer config it to zero for every duplication cluster , when dup service send mutatioin, packaging functionality will no longer supported . I think it's a unsuitable design.

Is it necessary to add the new config? Can the issue be resolved by adjust duplicate_log_batch_bytes on master cluster or max_allowed_write_size on backup cluster?

If the maintainer of the duplication clusters config max_allowed_write_size to zero , the problem will be resolved. However , if maintainer config it to zero for every duplication cluster , when dup service send mutatioin, packaging functionality will no longer supported . I think it's a unsuitable design.

How about limiting the message size separately for common client write operations and duplication write operations, you can distinguish them by rpc code, then use corresponding limits?

Is it necessary to add the new config? Can the issue be resolved by adjust duplicate_log_batch_bytes on master cluster or max_allowed_write_size on backup cluster?

The same purpose can be achieved through the configuration of operation and maintenance personnel. But I think it is better to provide some support on the Pegasus server side.

@ninsmiracle Please try to rebase the master branch.


Sheet title no longer exporting in XML

Previously this app would export the XML file with the following format:
<rootElement>

    <sheetTitle>

        <element>

        </element>

    </sheetTitle>

</rootElement>

Now the app skips appending the sheet title, why is this?

The previous format was actually an oversight with XML exporting. Using "Current sheet only" will unwrap the current sheet as there would be an unneeded extra layer to the exported data. If you would like the sheet's name as an extra wrapping element, you can use the "Custom" option and select only the sheet you desire to export. That should give you the formatting you are looking for.

Perfect, thanks for your help!
On Wed, 1 Mar 2017 at 17:38 Synthoid<EMAIL_ADDRESS>wrote:

The previous format was actually an oversight with XML exporting. Using
"Current sheet only" will unwrap the current sheet as there would be an
unneeded extra layer to the exported data. If you would like the sheet's
name as an extra wrapping element, you can use the "Custom" option and
select only the sheet you desire to export. That should give you the
formatting you are looking for.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Synthoid/ExportSheetData/issues/21#issuecomment-283258119,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIpPZGOJ_WQouZInjtLPDZlQvk2YeEgOks5rhRJngaJpZM4MPNmG
.


Add ability to pre-compile scripts

Since version 3.X Beta the following modules of the JavaScript Engine Switcher support a script pre-compilation: JavaScriptEngineSwitcher.Msie (only in the Chakra JsRT modes), JavaScriptEngineSwitcher.V8,
JavaScriptEngineSwitcher.Jurassic, JavaScriptEngineSwitcher.Jint and JavaScriptEngineSwitcher.ChakraCore. This feature allows you to once pre-compile the script and many times use it for initialization of engine instances. Due the fact that the pre-compiled script does not require parsing, you can significantly speed up the initialization of engines.
This PR adds this feature to the ReactJS.NET library. Pre-compilation is enabled by using the AllowJavaScriptPrecompilation property (default false). Also, pre-compilation requires the using of the caching provider is different from the NullCache type.

Cool! I’ll try to look at this in the next few days
On Wed, Aug 29, 2018 at 13:22, Andrey Taritsyn<EMAIL_ADDRESS>wrote:

Since version 3.X Beta the following modules of the JavaScript Engine
Switcher support a script pre-compilation: JavaScriptEngineSwitcher.Msie
(only in the Chakra JsRT modes), JavaScriptEngineSwitcher.V8,
JavaScriptEngineSwitcher.Jurassic, JavaScriptEngineSwitcher.Jint and
JavaScriptEngineSwitcher.ChakraCore. This feature allows you to once
pre-compile the script and many times use it for initialization of engine
instances. Due the fact that the pre-compiled script does not require
parsing, you can significantly speed up the initialization of engines.
This PR adds this feature to the ReactJS.NET library. Pre-compilation is
enabled by using the AllowJavaScriptPrecompilation property (default false).
Also, pre-compilation requires the using of the caching provider is
different from the NullCache type.
You can view, comment on, or merge this pull request online at:
https://github.com/reactjs/React.NET/pull/592
Commit Summary

Add ability to pre-compile scripts

File Changes

M src/React.Core/IReactSiteConfiguration.cs
https://github.com/reactjs/React.NET/pull/592/files#diff-0 (12)
M src/React.Core/JavaScriptEngineFactory.cs
https://github.com/reactjs/React.NET/pull/592/files#diff-1 (43)
M src/React.Core/JavaScriptEngineUtils.cs
https://github.com/reactjs/React.NET/pull/592/files#diff-2 (161)
M src/React.Core/React.Core.csproj
https://github.com/reactjs/React.NET/pull/592/files#diff-3 (2)
M src/React.Core/ReactEnvironment.cs
https://github.com/reactjs/React.NET/pull/592/files#diff-4 (24)
M src/React.Core/ReactSiteConfiguration.cs
https://github.com/reactjs/React.NET/pull/592/files#diff-5 (14)
M src/React.Sample.Cassette/React.Sample.Cassette.csproj
https://github.com/reactjs/React.NET/pull/592/files#diff-6 (4)
M src/React.Sample.Cassette/packages.config
https://github.com/reactjs/React.NET/pull/592/files#diff-7 (4)
M src/React.Sample.ConsoleApp/React.Sample.ConsoleApp.csproj
https://github.com/reactjs/React.NET/pull/592/files#diff-8 (8)
M src/React.Sample.CoreMvc/React.Sample.CoreMvc.csproj
https://github.com/reactjs/React.NET/pull/592/files#diff-9 (8)
M src/React.Sample.CoreMvc/Startup.cs
https://github.com/reactjs/React.NET/pull/592/files#diff-10 (1)
M src/React.Sample.Mvc4/App_Start/ReactConfig.cs
https://github.com/reactjs/React.NET/pull/592/files#diff-11 (1)
M src/React.Sample.Mvc4/React.Sample.Mvc4.csproj
https://github.com/reactjs/React.NET/pull/592/files#diff-12 (15)
M src/React.Sample.Mvc4/packages.config
https://github.com/reactjs/React.NET/pull/592/files#diff-13 (7)
M src/React.Sample.Owin/React.Sample.Owin.csproj
https://github.com/reactjs/React.NET/pull/592/files#diff-14 (4)
M
src/React.Sample.Router.CoreMvc/React.Sample.Router.CoreMvc.csproj
https://github.com/reactjs/React.NET/pull/592/files#diff-15 (10)
M src/React.Sample.Webpack/App_Start/ReactConfig.cs
https://github.com/reactjs/React.NET/pull/592/files#diff-16 (1)
M src/React.Sample.Webpack/React.Sample.Webpack.csproj
https://github.com/reactjs/React.NET/pull/592/files#diff-17 (12)
M src/React.Sample.Webpack/packages.config
https://github.com/reactjs/React.NET/pull/592/files#diff-18 (6)
M src/React.sln
https://github.com/reactjs/React.NET/pull/592/files#diff-19 (6)
M tests/React.Tests.Benchmarks/React.Tests.Benchmarks.csproj
https://github.com/reactjs/React.NET/pull/592/files#diff-20 (4)
M tests/React.Tests.Integration/React.Tests.Integration.csproj
https://github.com/reactjs/React.NET/pull/592/files#diff-21 (22)
M tests/React.Tests.Integration/ServerRenderTests.cs
https://github.com/reactjs/React.NET/pull/592/files#diff-22 (68)
M tests/React.Tests/Core/JavaScriptEngineFactoryTest.cs
https://github.com/reactjs/React.NET/pull/592/files#diff-23 (267)

Patch Links:

https://github.com/reactjs/React.NET/pull/592.patch
https://github.com/reactjs/React.NET/pull/592.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/reactjs/React.NET/pull/592, or mute the thread
https://github.com/notifications/unsubscribe-auth/AA5hFvpt3GlKek5LVfamUp8uLZYICrvTks5uVvf7gaJpZM4WSQw5
.

The benchmarks run fine on OS X but crash on Windows only when script precompilation is enabled. Going to investigate this further..

The benchmarks run fine on OS X but crash on Windows only when script precompilation is enabled.

In ChakraCore .NET wrapper for Windows and Unix uses different code:
if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
{
	…
}
else
{
	…
}

This is concerning - it looks like within benchmarkdotnet, enabling script precompilation causes the entire process to die. Not sure why this would be limited to chakracore...

I think that we can do without the InProcessToolchain. Updating the BenchmarkDotNet to version 0.11.1 fixes the previously described errors.
However, if we assign to ReuseJavaScriptEngines property value equal to true, the errors return back.

To fix this error:
// * Warnings *
Environment
  Summary -> Detected error exit code from one of the benchmarks. It might be caused by following antivirus software:
        - Windows Defender (windowsdefender://)
        - Norton Security (C:\Program Files\Norton Security\Engine\<IP_ADDRESS>\WSCStub.exe)
Use InProcessToolchain to avoid new process creation.

I had to completely abandon usage of the old ChakraCore API for Windows (Internet Explorer-like API).

Yeah, the memory file cache is for tests only. I can add a comment to that
file to make that clearer.
On Sat, Sep 15, 2018 at 12:32, Daniel Lo Nigro<EMAIL_ADDRESS>wrote:

@Daniel15 commented on this pull request.
This looks pretty good to me!
In src/React.Core/JavaScriptEngineUtils.cs
https://github.com/reactjs/React.NET/pull/592#discussion_r217893482:

	if (!engine.SupportsScriptPrecompilation)

	{

		Trace.WriteLine(string.Format("The {0} version {1} does not support the script pre-compilation.",

			engine.Name, engine.Version));

		return false;

	}

	if (cache is NullCache)

	{

		Trace.WriteLine("Usage of script pre-compilation without caching does not make sense.");

		return false;

	}

	return true;

}

It'd be good to put all this code into a separate file (eg.
JavaScriptPrecompilation.cs) to keep things organized.
In src/React.Core/ReactSiteConfiguration.cs
https://github.com/reactjs/React.NET/pull/592#discussion_r217893506:

  /// </summary>

public bool AllowMsieEngine { get; set; }

public bool AllowJavaScriptPrecompilation { get; set; }

This is a breaking change (removing a field from the public API) so we
need to ensure we do a major version bump for this. However, I think we are
already bumping the major version due to using the latest beta
JavaScriptEngineSwitcher, so it should be fine.
In tests/React.Tests.Common/MemoryFileCacheCore.cs
https://github.com/reactjs/React.NET/pull/592#discussion_r217893550:

	{

		_cache.Remove(key);

		return;

	}

	var options = new MemoryCacheEntryOptions

	{

		SlidingExpiration = slidingExpiration,

	};

	_cache.Set(key, data, options);

}

}
+}

+#endif
Is this code specific to tests?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/reactjs/React.NET/pull/592#pullrequestreview-155722999,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA5hFoLRhkfY0APDWdDsFXmpz_6n0tCtks5ubVXdgaJpZM4WSQw5
.

🚀 Works great for .JS files (AddScriptWithoutTransform), however I discovered that it does not work at all for files that Babel has to process (AddScript). It would be very cool if that was supported, but if that's not straight forward to do before merge, we'll need to add a comment indicating this behavior.
Benchmarks for AddScriptWithoutTransform:

BenchmarkDotNet=v0.10.14, OS=macOS High Sierra 10.13.6 (17G65) [Darwin 17.7.0]
Intel Core i7-4980HQ CPU 2.80GHz (Haswell), 1 CPU, 8 logical and 4 physical cores
.NET Core SDK=2.0.0
  [Host]     : .NET Core 2.0.0 (CoreCLR 4.6.00001.0, CoreFX 4.6.25519.03), 64bit RyuJIT
  DefaultJob : .NET Core 2.0.0 (CoreCLR 4.6.00001.0, CoreFX 4.6.25519.03), 64bit RyuJIT

Method
withPrecompilation
Mean
Error
StdDev
Gen 0
Allocated

Environment_CreateComponent
False
48.49 ms
0.3031 ms
0.2687 ms
62.5000
1.54 MB

Environment_CreateComponent
True
41.63 ms
0.2408 ms
0.2134 ms
62.5000
1.27 MB

Also is there any reason not to enable this by default?

Hello, Dustin!

…, however I discovered that it does not work at all for files that Babel has to process (AddScript). It would be very cool if that was supported, but if that's not straight forward to do before merge, we'll need to add a comment indicating this behavior.

For several days I'm working on a new version of the JavaScriptEngineSwitcher.ChakraCore module. If run the latest version of benchmarks together with new version of the JavaScriptEngineSwitcher.ChakraCore module (891da69) on Windows, can get the following results:
BenchmarkDotNet=v0.10.14, OS=Windows 10.0.17134
Intel Core i7 CPU 870 2.93GHz (Nehalem), 1 CPU, 8 logical and 4 physical cores
Frequency=2857588 Hz, Resolution=349.9455 ns, Timer=TSC
.NET Core SDK=2.0.0
  [Host]     : .NET Core 2.0.7 (CoreCLR 4.6.26328.01, CoreFX 4.6.26403.03), 32bit RyuJIT
  DefaultJob : .NET Core 2.0.7 (CoreCLR 4.6.26328.01, CoreFX 4.6.26403.03), 32bit RyuJIT

ComponentRenderWithBabelBenchmarks

Method
withPrecompilation
Mean
Error
StdDev
Gen 0
Allocated

Environment_CreateComponent
False
58.40 ms
1.0167 ms
0.9510 ms
62.5000
2.86 MB

Environment_CreateComponent
True
57.38 ms
0.8534 ms
0.7983 ms
62.5000
2.86 MB

ComponentRenderWithoutBabelBenchmarks

Method
withPrecompilation
Mean
Error
StdDev
Gen 0
Allocated

Environment_CreateComponent
False
56.98 ms
1.065 ms
0.9959 ms
125.0000
1.53 MB

Environment_CreateComponent
True
47.03 ms
1.097 ms
1.0260 ms
62.5000
1.26 MB

If change configuration settings in the ComponentRenderWIthBabelBenchmarks.cs file to the following:
…
public ComponentRenderWithoutBabelBenchmarks()
{
	…
	ReactSiteConfiguration.Configuration
		.SetReuseJavaScriptEngines(true)
		.SetStartEngines(2)
		.SetMaxEngines(2)
		.SetMaxUsagesPerEngine(2)
		.AddScript("Sample.jsx");
}
…

Then get the following results:
ComponentRenderWithBabelBenchmarks

Method
withPrecompilation
Mean
Error
StdDev
Gen 0
Allocated

Environment_CreateComponent
False
74.69 ms
1.250 ms
1.169 ms
125.0000
3.12 MB

Environment_CreateComponent
True
64.34 ms
1.245 ms
1.165 ms
62.5000
2.86 MB

I will release a new version of the JavaScript Engine Switcher in next few days.

Normally I'd do a squash but in this case the individual commits are pretty clean. Thanks so much!! I'm going to wrap up the styled components work and then we can cut a release.

Excellent!


Move rand_* to dq.rand.*

Closes https://linear.app/dynamiqs/issue/DYN-232/move-dqrand-to-dqrand

Unfortunately complex is a reserved keyword of python, so I had to come up with something else. I get your point though, and any better name is welcome

Great 😁


Backend cicd-setup- Self-Sprint-1

@dcchi3 you can use this issue to setup the required workflow and other things.

ok thank you


Fix precip amount error

Codecov Report

Merging #16 (d32b1d9) into main (7d27488) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #16   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            8         8
  Lines          432       433    +1
=========================================
+ Hits           432       433    +1

Impacted Files
Coverage Δ

weather_command/_builder.py
100.00% <ø> (ø)

weather_command/models/weather.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d27488...d32b1d9. Read the comment docs.


Bug duel in spawn

Expected behavior
That when dueling it appears on the map that corresponds to it
Observed/Actual behavior
When he enters the game, whatever (It happened to me in Notch and Bridges), they appear in the spawn (With the armor and everything necessary for the duel), that is, it is as if they were dueling in the spawn

How to Recreate (if known)
It's random
Stack trace
(https://hastebin.com/share/popavamuvi.makefile)
Plugin list

Frost version

Agreements

[X] I have searched for and ensured there isn't already an open issue regarding this.

Other
No response

And update has been released to address these clientside issues and hopefully fix them. Please test the new version and let me know if it's working as intended.

Issue solved.


Version 3.0 not compiling

I just checked to switch to the component change made in v3.0 but for whatever reason the I cannot compile. I first had the time definition in my yaml which ultimately fail but also when being as close as possible to the example provided the compilation fails. I attached the log for the error. Couldn't figure out what went wrong here.
logs_klima-eg_run.txt
Thanks and please let me know if anything else is needed to be provided from my end. Gladly willing to help here.

Try cleaning up your build files

I have seen some duplicate definition errors when writing the code, and all of the cases it was duplicate / remaining files, so maybe double check the esphome folder for lingering old versions of the cpp and h files, which should no longer be placed in the folder manually. You can also try building it as a new entity in esphome to prevent old files lingering around in the build directories

Thanks for all your tips and willingness to help. I just checked that the esphome folder does not contain any remaining file whatsoever. Unfortunately the error remains. Checked again after that and cleaned everything again. Am I missing another folder which might contain files other than the esphome one?

I checked today on another device after upgrading to the new Esphome version and it seems that it's working now. Nothing changed though, but it went through. So I'm closing this one. Thanks a lot for your help. Don't know what fixed it but it is working. 🤷♂

Getting the exact same error here.
I run a Home Assistant Green with the ESP Addon, how can I check on a file level that the cached versions of these files are gone? A "clean" in ESPHome does not resolve this issue.

Did a local commandline build. And that compiles fine, so that is in line with @RobertJansen1's statement on left over files being on my ESPHome instance. Question is, do these files expire by themselves if clean does not work?

I had this exact same issue and I could solve it like this:

Do the "Clean Build Files" on the device in Home Assistant ESPHome.
Use SSH or console or some way to login onto the device running Home Assistant.

Go to ESPHome data folder for the device: cd /mnt/data/supervisor/addons/data/*_esphome/build/_devicename_/
Check folder content: ls -l
Make sure you are in the correct folder for your device and there is a scr folder! Rename the folder: mv src src.old

Now try to install / build / update the device in Home Assistant ESPHome again.

https://github.com/esphome/issues/issues/6312

Just ran into the same problem, cleaning all files manually through SSH resolved the issue.
💡 Should we pin this issue to the top of the issue list? I guess more people will run into this issue....

I added this issue to the changelog (the comment from @ervee as that one seems to have the most complete steps to resolve the issue. sorry for the inconvenience everyone!

When using Homeassistant OS you need to SSH into your installation:

Install ssh addon (Advanced SSH & Web Terminal)
Set password in configuration
Connect to SSH
docker exec -it addon_5c53de3b_esphome sh
cd /data/build/

Then follow above comment (https://github.com/ginkage/MHI-AC-Ctrl-ESPHome/issues/100#issuecomment-2395388853)


[1.21] After Installing mod on latest version the game ccrash

Installed the mod on latest MC version and the game crash
Minecraftr 1.21
Forge 51.0.8
customizableelytra-forge-2.2.3+1.21
Crash Log
crash-2024-06-15_12.06.06-client.txt

Wow, I can't believe I missed that, should be fixed in the new version. Thanks for reporting it!


Enhancement: PSR-2 style named migrations.

Problem:

Migration classes are named using a different convention than other classes in the framework

Example:
yii migrate/mark 150101_185401                      # using timestamp to specify the migration
yii migrate/mark "2015-01-01 18:54:01"              # using a string that can be parsed by strtotime()
yii migrate/mark m150101_185401_create_news_table   # using full name
yii migrate/mark<PHONE_NUMBER>                         # using UNIX timestamp

Suggestion is to allow PSR2 style names:
yii migration/mark m150101185401CreateNewsTable   # PSR2 compliant file and class name

Impact:

Linters will not fail when encountering migration classes
Global consistency in class naming convention

I think I can do this change, PSR2 should be the new default naming format, right?

Yes.

Thank you both very much!

Will use "M" instead of "m" as the prefix to follow the upper-camel convention.
Also, should the create command raise a warning/error if the name does not met the convention?
Thanks!

I still think its better  to have the migration names to be something like console\migrations\CreatePost and have a dependency property to know which migrations should be executed first.
namespace common\migrations;

class CreatePost extends Migration
{
    public function up()
    {
    }

    public function down()
    {
    }

    $depends = [
        'common\\migrations\\Init';
        'common\\migrations\\CreatePostCategory';
    ];
}

@Faryshta this way last migration out of 100 will have 99 dependencies. That's no good.

@cesarnicola yes, a warning would be good. Also don't forget namespaces.

Thanks, working on it.

this way last migration out of 100 will have 99 dependencies.

Nested migrations like in a fixture or an asset. If migration Z depends on Y and X, then it will check the dependencies of Y and X.
The last migration might depend on a 100 migrations but the code will be much simplier.

Solution proposed at #12511

Resolved by commit 8aa0e85


Content on the landing page?

I've trying add content to the main/landing page. If I add markup to the bottom of exampleSite/content/en/_index.md it doesn't show up anywhere. Is there a way to get content on the main/landing page? Thanks.

I've trying add content to the main/landing page. If I add markup to the bottom of exampleSite/content/en/_index.md it doesn't show up anywhere. Is there a way to get content on the main/landing page? Thanks.

Same here!

Hi,
In case you still have that issue. check this closed issue #3.
You can  replace the  /content/en/_index.md  file with the example code mentioned in here.
Your landing page should look like in here https://zzodocs.netlify.com/ .

This needs to be documented in the README.md

Cant get the landing page to work at all. Ditching this theme for something that works.

Sorry for late.
I have documented it in doc site - https://zzo-docs.vercel.app/zdoc/pages/home/
Check the full code in the file at exampleSite/content/en/_index.md file.


new version: tencent.qq <IP_ADDRESS>778

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

[x] Does your manifest conform to the 1.1 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

 So there will be conflicts. The file specially for qq 9.6.5 is correct.


IMAP Connection works only sporadically 365

I set up the proxy, smtp works without problem, when when trying to receive mails, most of the time i only get server disconnected and client disconnected.
2023-10-12 10:24:13: New incoming connection to IMAP server at ipv4:1993 (unsecured) proxying outlook.office365.com:993 (SSL/TLS)
2023-10-12 10:24:13: Accepting new connection to IMAP server at ipv4:1993 (unsecured) proxying outlook.office365.com:993 (SSL/TLS) via ('ipv4', 53767)
2023-10-12 10:24:34: IMAP (ipv4; ipv4:53767->outlook.office365.com:993) <-- [ Server disconnected ]
2023-10-12 10:24:34: IMAP (ipv4:1993; ipv4:53767->outlook.office365.com:993) --> [ Client disconnected ]
has anyone ever encountered something like this?
my config:
[IMAP-1993]
server_address = outlook.office365.com
server_port = 993
local_address = <IP_ADDRESS>
<EMAIL_ADDRESS>permission_url = https://login.microsoftonline.com/xxx/oauth2/v2.0/authorize
token_url = https://login.microsoftonline.com/xxx/oauth2/v2.0/token
oauth2_scope = https://outlook.office365.com/IMAP.AccessAsUser.All https://outlook.office365.com/POP.AccessAsUser.All https://outlook.office365.com/SMTP.Send offline_access
redirect_uri = http://localhost
client_id = xxx
client_secret = xxx
last_activity =<PHONE_NUMBER>
token_salt = xxx
access_token = xxx
access_token_expiry = xxx
refresh_token = xxx
[emailproxy]
delete_account_token_on_password_error = True
encrypt_client_secret_on_first_use = False

What happens if you try to connect directly to the O365 server via telnet? (i.e. without the proxy)
Do you have the same issue with:

A different O365 account
A different email client
A different OAuth 2.0 client ID/secret
A different email server (e.g.; Gmail)

i cant connect to the o365 server via telnet,.
I used the proxy with same settings in another network with no issues, maybe something is getting blocked in the original network, i´ll investigate.

I should have been clearer: you'll need to use, e.g.; openssl s_client -crlf -connect localhost:1993 to connect to an encrypted remote server such as O365. But if this doesn't work then the error you get might help debug the proxy issue you're facing.

Were you able to resolve this?

Yes i was.  Firewall blocked connections to the imap server.


annotateMarkAsync, 403

Hello, I tried to use annotateMarkAsync in example respondToEvents.html, but it told me that it Failed to load resource: the server responded with a status of 403 (), as shown in the figure. Is there any way to solve this problem？

Strange. Is the dashboard url published? Or are you able to replicate this issue on a public dashboard?
Some code would be helpful as well

Closing due to age. If this is still an issue, please reopen with comments.


Import using snap on Ubuntu 23.04 does has encoding issues

When using the snap version of Beaver notes the installation on Ubuntu 23.04 works.
Application is usable but importing notes dialog show the following:

Either the font that used is substituted by a WingDing like variant or a wrong encoding is used.
OS:
Ubuntu 23.04
Uname -a: Linux QSD 6.2.0-26-generic #26-Ubuntu SMP PREEMPT_DYNAMIC Mon Jul 10 23:39:54 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Machine:
Dell Inc. XPS 15 9570
NVIDIA GeForce GTX 1050 Ti with Max-Q Design / Intel® UHD Graphics 630 (CFL GT2)
Windowing system: Wayland
GNOME version: 44.3

I appreciate your understanding. As soon as I have access to a Linux machine, I'll look into this. I apologize for any inconvenience, and I assure you that I'll fix it, while also introducing the sync feature in version 0.0.7.


Provide more detailed error message when env-script fails

There is limited information given in the error output when an
env-script return a non-zero exit code, which can be quite confusing as
there is no context of where it failed (unless verbose output is turned
on).
Avoid confusion by providing more context about the environment when the
script fails.
BEFORE:

cargo make
[cargo-make] INFO - cargo make 0.32.5
[cargo-make] ERROR - Error while executing command, exit code: 128
[cargo-make] WARN - Build Failed.

AFTER:

cargo make
[cargo-make] INFO - cargo make 0.32.5
[cargo-make] ERROR - Error while evaluating script for env: GIT_ROOT, exit code: 128
script: [
"git rev-parse --show-toplevel",
]
stdout: ""
stderr: "fatal: not a git repository (or any of the parent directories): .git
"
[cargo-make] WARN - Build Failed.

That's really great. Let me check the code out.

Codecov Report

Merging #463 into 0.32.6 will decrease coverage by 27.96%.
The diff coverage is 83.33%.

@@             Coverage Diff             @@
##           0.32.6     #463       +/-   ##
===========================================
- Coverage   92.58%   64.62%   -27.97%
===========================================
  Files          92       92
  Lines       17957    17862       -95
===========================================
- Hits        16626    11543     -5083
- Misses       1331     6319     +4988

Impacted Files
Coverage Δ

src/lib/environment/mod.rs
28.29% <83.33%> (-60.74%)
:arrow_down:

src/lib/environment/mod_test.rs
12.91% <83.33%> (-83.16%)
:arrow_down:

src/lib/storage_test.rs
0.00% <0.00%> (-100.00%)
:arrow_down:

src/lib/recursion_level_test.rs
0.00% <0.00%> (-100.00%)
:arrow_down:

src/lib/cli_test.rs
2.04% <0.00%> (-94.54%)
:arrow_down:

src/lib/scriptengine/rsscript.rs
0.00% <0.00%> (-92.31%)
:arrow_down:

src/lib/scriptengine/rsscript_test.rs
0.00% <0.00%> (-90.09%)
:arrow_down:

src/lib/time_summary.rs
11.42% <0.00%> (-83.02%)
:arrow_down:

src/lib/legacy_test.rs
17.64% <0.00%> (-82.36%)
:arrow_down:

... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b5cb81...1bea729. Read the comment docs.

Looks great @epontan
thanks a lot for the PR


Some comments about the pip installable package

I tried installing scope_ml from test.pypi.org, and here are some of the problems I ran into:

I know this is only temporary, but just so you know, when installing from test.pypi.org with the command they provide: pip install -i https://test.pypi.org/simple/ scope-ml, it can't manage to install the dependencies because it tries to also grab them from the testing instance of pypi. Might be work looking into whether or not there's a way to install scope-ml without the dependencies, and then install them seperately from normal pypi.
So I ended up installing them manually (which is not too bad), but it told me I had to install pre-commit and sphinx-press-theme. These 2 should definitely just be dev dependencies, installable separately for those who want to contribute.

Other than that, it's great! I was able to run scope.initialize and I can see the config files and scripts :)

(1) is not a big problem, I just wanted to make sure you knew. Probably not worth the effort to get around it if a pypi release is approaching! But yes moving the dev deps out of the proper deps would be super nice.
Thanks!


Clean out test data from live site

There is test data chocolate in the live site peanut butter.

Make sure no test data is being written to the DB from migrations.
Reset the database for prod.

I think this is done, and we can hide items now, closing


Scratch buffers are left after hover evaluation.

In https://github.com/przepompownia/dap-ui-test please run make test-close-hover-window then close, select and evaluate the same expression again (gv, ,de) more than one time. With ls! observe new scratch buffers.

On the screenshot we can see the buffer 4 (:sb 4).
I was hoping that the 72f6020 can resolve it so I deferred creation of this issue.

Should be fixed in latest commit!

I see no orphan buffers on the test environment, thanks!


Unexpected exception on fast interpreter mode

Subject of the issue
WAMR on fast interpreter mode raises an exception indicating "invalid local type" on a valid case.
Test case
f64.const_6LLPBLPP_856_1714940342309342.zip
Your environment

Host OS: Ubuntu 20.04
Commit Id: 1c2a8fca4e9bf969ae27240a0918ee8164dfd598

Steps to reproduce

build WAMR on fast interpreter mode
execute the command

iwasm --heap-size=0 -f "to_test" <test_case>

Expected behavior
No exception
-0.5392354:f64

Actual behavior
An exception
Exception: invalid local type

@erxiaozhou thanks for reporting the issue, please try #3434.

Close the issue since it was fixed.


Cocoapods 1.9.0 and xCode 11.3.1 Conflicts

Bug
Ran into the following issue when updating to Cocoapods 1.9.0
NameError - uninitialized constant Pod::Target::BuildType
Seems that Pod::Target::BuildType is deprecated and update should be Pod::BuildType. Figured to post it here since Readme is giving different instuctions
Environment info
React native info output:
System:
    OS: macOS 10.15.3
    CPU: (12) x64 Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz
    Memory: 947.76 MB / 16.00 GB
    Shell: 3.2.57 - /bin/bash
  Binaries:
    Node: 10.15.3 - /usr/local/bin/node
    Yarn: 1.19.1 - /usr/local/bin/yarn
    npm: 6.4.1 - /usr/local/bin/npm
  SDKs:
    iOS SDK:
      Platforms: iOS 13.2, DriverKit 19.0, macOS 10.15, tvOS 13.2, watchOS 6.1
    Android SDK:
      API Levels: 28
      Build Tools: 28.0.3
      System Images: android-28 | Google APIs Intel x86 Atom, android-28 | Google Play Intel x86 Atom, android-29 | Google Play Intel x86 Atom
  IDEs:
    Android Studio: 3.5 AI-191.8<IP_ADDRESS>91312
    Xcode: 11.3.1/11C504 - /usr/bin/xcodebuild
  npmPackages:
    react: 16.9.0 => 16.9.0
    react-native: ^0.61.5 => 0.61.5

Library version: 2.0.9
Prerequisites:
Pod file includes use_frameworks
Use the pre_install method provided from Readme to use static frameworks
Steps To Reproduce

Update Cocoapods to 1.9.0
Install fails
...

Describe what you expected to happen:

Install succeeds

@kyytiPetteri Did you tried
use_frameworks! :linkage => :static

As seen in: http://blog.cocoapods.org/CocoaPods-1.9.0-beta/

@kyytiPetteri Ok, I tried it with CocoaPods 1.9. We should edit the README / example project Podfile to:
$dynamic_frameworks = []

pre_install do |installer|
  installer.pod_targets.each do |pod|
    if !$dynamic_frameworks.include?(pod.name)
      puts "Link #{pod.name} as static_library"
      def pod.build_type;
        # Uncomment one line depending on your CocoaPods version
        # Pod::BuildType.static_library # >= 1.9
        # Pod::Target::BuildType.static_library # < 1.9
      end
    end
  end
end

Done! Thanks 🙂 https://github.com/react-native-community/react-native-permissions#-if-you-encounter-the-error-invalid-rnpermission-x-should-be-one-of-


https://github.com/intuit/karate#logging logback-test.xml seems wrong

I followed https://github.com/intuit/karate#logging and added a logback-test.xml to my jar - no change.
I then noticed there seem to be zero ref in karate code for logback-test.xml so I tried using logback.xml and voila, now I can configure the logging.
Is the docs wrong or is there a bug ?
Here is the jbang script I use (needs logback.xml to go with it in the same dir):
///usr/bin/env jbang "$0" "$@" ; exit $?
//DEPS com.intuit.karate:karate-core:0.9.9.RC2
//FILES logback.xml

class karate {

    public static void main(String... args) {
        com.intuit.karate.Main.main(args);
    }

 }

the docs are fine IMO because karate is used as a test scope dependency by 99.9 % of users (well until now anyway) and then logback-test.xml works, also this is a logback convention, refer: http://logback.qos.ch/manual/configuration.html - BTW I also noticed this: https://github.com/ptrthomas/karate-showcase - and I don't know why logback-test.xml does not work
I can add a note somewhere in the docs

the docs are fine IMO because karate is used as a test scope dependency by 99.9 % of users (well until now anyway) and then logback-test.xml works, also this is a logback convention, refer: http://logback.qos.ch/manual/configuration.html - BTW I also noticed this: https://github.com/ptrthomas/karate-showcase - and I don't know why logback-test.xml does not work
I can add a note somewhere in the docs

Ab, didn't realise it was logback convention.
But yeah; doesn't seem to work for me :)

Ab, didn't realise it was logback convention.
But yeah; doesn't seem to work for me :)


Callback once workflow completed

Hi Team,
I need to know whether we can have a callback to client who triggered the workflow for execution with the final response of the last task executed ??
Please help me on this , I am just started working for requirement with netflix conductor
thanks in advance

you can use EVENT system task to send messages
you can do it as a last task to call something else using any protocol you need

Thanks for response..., but I need to be synchronous response once called the work flow

callbacks are not synchronous by nature. what is the difference of callback and of calling your client from the latest task in workflow?

If its not synchronous then client needs a implementation of polling for responses and update them accordingly
Means Once workflow triggered by client , need an acknowledgement in same thread towards client ,
Is that way its possible ? just asking in curiosity

Hi
Ignore the last query
The point what I need is , if a callback is written as last task in the workflow towards client
then in case intermediate stage of workflow some task got failed , the control wont go to last task untill its success
In this scenario how the callback to client can be achieved ?
Hope I didn't confused on the requirement

Hello @Rangadhama , I'm not sure if this is what you need but we faced a similar issue here where we needed a callback from a workflow execution and didn't want to poll any of the conductor's services to know the outcome. So we came up with a solution by adding a custom implementation of the WorkflowStatusListener interface  (the default implementation just logs) which is has methods invoked on a workflow execution termination or completion events.
I added a contrib where the listener simply publishes a workflowSummary in a dynoQueue when any of the events above occurs, if the solution is suitable to you, you'd need just to add a queue poller on your client application. However if you need a more customized approach you can implement your own listener and make it call your client somehow to provide the information you need about the execution.
Hope it helps somehow.

Thanks @Ismaley for the response
Do you have any sample of dynoQueue based handling for above situation which you stated , will be really helpful to understand more deeper.
Thanks in advance

Yeah, I've made a simple application that just publishes and consumes messages from a dynoqueue, the concept is similar to what we use on our client application. You can find it here and this wiki can also help a bit.
Also, take a look on the PR GH-905 I opened here on conductor to see how the publisher works and the queues you can configure and use.
Tell me later if you have any doubts and if it helped or not :)

Thanks a lot @Ismaley , I was out of town
Let me check your suggestions and get back to you shortly

You can implement WorkflowStatusListener interface and use the ObservableQueue implementations to publish messages to specific external queue implementations. You can configure the queue details in system.properties and use to publish the messages on completion and termination.

Hi Guys,
Our requirement getting agile everyday
Is it possible to send synchronous response to start workflow API call  instead of WorkflowInstance Id ?

I know you can run all tasks synchronously but to return the output directly after the execution request I believe you'd need to make a new endpoint for that.

Hi jkaipa,
Could you please help me in getting link for implementation of WorkflowStatusListener. My requirement is simple. I should be able to get call back to my particular java class once workflow execution is completed or terminated.

You can implement WorkflowStatusListener interface and use the ObservableQueue implementations to publish messages to specific external queue implementations. You can configure the queue details in system.properties and use to publish the messages on completion and termination.

@hanumantharao18 Please check out this reply above from @Ismaley where you can have a simple application to consume messages from the dynoqueue and can callback to your class.


Make generic audio stats and check stats before ffmpeg filters

Add stats function so that all audio formats can be handled.
Check conditions before processing audio with ffmpeg

#36 Please refer to this


Catalog - Games class

This update is meant to complete the features for the game class.
Changes

Addressed issues:

#14
#21
#29
#31

Add improvements to menu format

The project is complete you can go ahead and merge it