Morthal and Winterhold prevent progression

that's all he says now i can't get my new orders

regain the rift has been there since beating falkreaths pre siege missions
would love to give a pic of the debugger but

it won't load so i can't progress
there may be some issues with winterhold and morthal since they are the last holds before the capital and this could still be interfering when Tullius randomly gives you holds

Update reloading an earlier save prior to taking winterhold fixed this. i still don't know what caused it

UPDATE: also occurs with morthal
this happens when you talk to tullius

note: reloading a save before the battle of morthal and winterhold solves this issue however why it occurs in the first place is what needs to be investigated

So this one is scary.
So not to get too technical, CWO is crashing. Some part of Skyrim's scripting engine is causing the CWCampaign (unused vanilla quest) to stall. This has happened to me twice. I know that one time it was because I entered bleedout and CWO tried to determine the outcome but at the same our side ran out of troops.
I put in a fix to prevent that from happening at the same time and I added yet another potential fix to https://github.com/schofida/CWORR/releases/tag/v1.0.7a. Unfortunately this is a sneaky bug because it happens once the siege quest finishes. So you might not know for a while until you try to do any more Civil War interaction (like talking to Tullius). A sure fire way to know that you have this bug is when you pull up the MCM and it doesn't load. I haven't seen this issue since for about a week but please let me know if you come across this issue again.


FileUtils - methods like rm should have equivalent that does not raise when the file does not exist.

Feature Request
I am using FileUtils to delete a file made by another process. I don't want to care if the file is not found; Much as I would in Ruby, I am using Crystal as a better alternative to scripting here.
Because I am accessing these functions through FileUtils, these are providing a more shell-like wrapper around the underlying File::delete implementations. For this reason, I think it will be common for users in some cases not to be bothered if they try to delete a file that does not already exist.
I'd like to propose that methods like rm and friends have parallel versions with a question mark appended (i.e. FileUtils::rm?), that will not throw an exception if the file does not exist, but instead will silently continue.
A basic implementation I have inserted into my own code to demonstrate is like so:
module FileUtils
	def rm?(path)
		FileUtils.rm(path) if File.exists? path
	end
end

I think utilising the question mark is a brief, nice, and idiomatic way of achieving this, that won't e.g. break any previous API compatibility.

Any reason to not just use File.delete?? E.g.
File.write("foo", "")
File.delete?("./foo") # => true
File.delete?("./bar") # => false

Related: https://github.com/crystal-lang/crystal/issues/5231

Only that I didn't see it documented:
https://crystal-lang.org/api/1.4.1/File.html#delete%3ANil-instance-method
Looks like it's new in the master branch, so my apologies.
It feels odd to me for rm and friends to throw an exception (and in my case, terminate the application) when the entries don't exist - it makes more intuitive sense that it comes from File::delete, but in any case, I'm happy to leave it open if this is worth adding quickly.
Also, an aside that ought to be a new FR, but there may be some other utilities that would be nice  to add to FIleUtils. cat would be very neat for me - i.e. FileUtils::cat as a one-liner to read in the contents of a file as a string. head and tail could also then take lines as usual.

Looks like it's new in the master branch, so my apologies.

Ahh, oops. Cons of using master API docs all the time :sweat_smile:. My Bad. Was added in https://github.com/crystal-lang/crystal/pull/11887.

Also, an aside that ought to be a new FR, but there may be some other utilities that would be nice to add to FIleUtils

I'm pretty sure, based on some discussion in that ticket I linked, we don't want to add new things to that module, which is essentially just full of aliases. Like you don't need cat when you can just do File.read "./foo.txt".

I'm happy to leave it open if this is worth adding quickly.

I don't see a reason to keep this open. Going to close it given there is nothing actional left since an equivalent method was already added.


Sonar generic reporter

Add support for sonar source generic coverage http://docs.sonarqube.org/display/PLUG/Generic+Test+Coverage so tests are picked up

This is to allow protractor tests be picked by sonar
here is a snippet of protractor.conf.js
The modifySuiteName is where I change the location in the describe to path for sonar
describe('src.test.e2e.spec1.js', function() {...}
framework: 'jasmine2',
onPrepare: function() {
var jasmineReporters = require('jasmine-reporters');
jasmine.getEnv().addReporter(new jasmineReporters.SonarXmlReporter({
consolidateAll: true,
savePath: 'target/js',
filePrefix: 'protractor',
modifySuiteName: function(nextPath) {
var pathSplit = nextPath.split('.');
var path = ''
if (pathSplit.length > 2) {
for (i = 0; i < pathSplit.length - 2; i++) {
path = path +  pathSplit[i] + "/"
}
path = path + pathSplit[pathSplit.length - 2] + "." + pathSplit[pathSplit.length - 1]
} else {
path = nextPath
}
return path
}
}
This is used in a maven build with entries in pom
<sonar.tests>src/test/javascript,src/test/e2e,src/test/java</sonar.tests>
<sonar.genericcoverage.unitTestReportPaths>target/js/protractor.xml,target/js/TESTS.xml</sonar.genericcoverage.unitTestReportPaths>

I use this branch in my project it works as expected. Thanks @PloughingAByteField

@PloughingAByteField This PR is really cool and hasn't been merged in over a year, are you inclined to roll this one out as a standalone reporter project? Probably Sonar/Protractor is too niche for jasmine-reporters.

It possibly should be standalone, particularly as sonarqube have changed so much around integration tests in 6.x. Unfort

It would have been a really handy thing to have this also this reporter. Not much has changed on SonarQube side since then...


Visualise Output in RViz

This is similar to #33. But it was left unanswered so opened similar issue.
Please explain how to visualise the output clusters. All the topics are appearing in RViz and only /filtered_cloud topic's data is  visible, how to see the final output(clusters)?

I don't see anything after adding MarkerArray and viz topic.

Please add screenshots to debug.
If the markers are not in the view, make sure your TF tree is setup correctly. Does the tracked cluster centroid values make sense in terms of relative position to the origin of your point clouds?

I will check TR tree setup.

ll the links are being displayed, does that confirm TF tree is correctly setup?

From your screenshot in this: https://github.com/praveen-palanisamy/multiple-object-tracking-lidar/issues/42#issuecomment-793403873
There seems to be an error as shown on your RViz window (left panel): The MarkerArray Status: Error
Could you fix the error on your end and try?
Also try using base_link as the fixed frame instead of velo_view

Sure, I will try to resolve: The MarkerArray Status: Error.

The /cluster_x topic is sending information to '/map' frame.

Such frame does not exist as shown below. Is this the problem?

Available frames are:
base_link
camera_color_left
camera_color_right
camera_gray_left
camera_gray_right
imu_link
velo_link


UI - Test 1.5.4 operator for rancher 2.9.0 release

[x] Basic test using marketplace automation

[x] Operator installation

[x] Manually add the repo https://github.com/rancher/charts.git to get 1.5.4 chart
[x] Install the chart

[x] Install the latest elemental dev UI using https://github.com/rancher/elemental-ui.git gh-pages
It must be released at the same time as rancher 2.9.0 because it's the only version compatible so far.

[x] Check channel

[x] Create machine registration, build and download ISO

[x] Build ISO using OS version 2.0.4

[x] Boot nodes and check machine inventory

[x] Create a 3 nodes cluster:

k3s 1.30.2 ✅  / 1.29.6 ✅

rke2 1.30.2 ✅  / 1.29.6 ✅

[x] Reset the nodes by deleting the cluster
Machine inventories back after reset:

Raw images not available yet

[x] Deploy an application

Upgrade tests:

[ ] from 1.5.3 to 1.5.4 with OS 2.0.4 and an existing 3 nodes cluster


Integrations logos not showing on /integrations/ page.

  It sorta looks like some of the static assets aren't installed properly.  The installer should copy all these files from the release tarball into the prod-static/ directory in the installation.

Can you try spelunking a bit to see what's going on in that directory?

@timabbott contents of the directory, looks like it has all the .svg files but not all the .pngs:
-rw-r--r--  1 zulip zulip    601 Oct 15 20:13 airbrake.ed4ab219a137.svg
-rw-r--r--  1 zulip zulip    601 Oct 15 20:13 airbrake.svg
-rw-r--r--  1 zulip zulip  14506 Oct 15 20:13 appfollow.8dcfc15ba164.svg
-rw-r--r--  1 zulip zulip  14506 Oct 15 20:13 appfollow.svg
-rw-r--r--  1 zulip zulip   1002 Oct 15 20:13 asana.524c52ffd211.svg
-rw-r--r--  1 zulip zulip   1002 Oct 15 20:13 asana.svg
-rw-r--r--  1 zulip zulip   1036 Oct 15 20:13 assembla.fa4634b4585f.svg
-rw-r--r--  1 zulip zulip   1036 Oct 15 20:13 assembla.svg
-rw-r--r--  1 zulip zulip    858 Oct 15 20:13 basecamp.e798903c95eb.svg
-rw-r--r--  1 zulip zulip    858 Oct 15 20:13 basecamp.svg
-rw-r--r--  1 zulip zulip  83636 Oct 15 20:13 beanstalk.26140167851b.png
-rw-r--r--  1 zulip zulip  83636 Oct 15 20:13 beanstalk.png
-rw-r--r--  1 zulip zulip   1379 Oct 15 20:13 bitbucket.338b83918d78.svg
-rw-r--r--  1 zulip zulip   1379 Oct 15 20:13 bitbucket.svg
-rw-r--r--  1 zulip zulip    516 Oct 15 20:13 bonusly.a2ad3477a02c.svg
-rw-r--r--  1 zulip zulip    516 Oct 15 20:13 bonusly.svg
-rw-r--r--  1 zulip zulip  12319 Oct 15 20:13 capistrano.eea25ee109ed.svg
-rw-r--r--  1 zulip zulip  12319 Oct 15 20:13 capistrano.svg
-rw-r--r--  1 zulip zulip   1516 Oct 15 20:13 chartbeat.3b996fb8889a.svg
-rw-r--r--  1 zulip zulip   1516 Oct 15 20:13 chartbeat.svg
-rw-r--r--  1 zulip zulip    542 Oct 15 20:13 circleci.92ab09776461.svg
-rw-r--r--  1 zulip zulip    542 Oct 15 20:13 circleci.svg
-rw-r--r--  1 zulip zulip  30202 Oct 15 20:13 codebase.9ea770d08922.svg
-rw-r--r--  1 zulip zulip  30202 Oct 15 20:13 codebase.svg
-rw-r--r--  1 zulip zulip   2904 Oct 15 20:13 codeship.e63ebb6defeb.svg
-rw-r--r--  1 zulip zulip   2904 Oct 15 20:13 codeship.svg
-rw-r--r--  1 zulip zulip   1583 Oct 15 20:13 crashlytics.f059e3cea562.svg
-rw-r--r--  1 zulip zulip   1583 Oct 15 20:13 crashlytics.svg
-rw-r--r--  1 zulip zulip  14022 Oct 15 20:13 darksky.f4161759eaca.png
-rw-r--r--  1 zulip zulip  14022 Oct 15 20:13 darksky.png
-rw-r--r--  1 zulip zulip    964 Oct 15 20:13 delighted.0d60da728a1f.svg
-rw-r--r--  1 zulip zulip    964 Oct 15 20:13 delighted.svg
-rw-r--r--  1 zulip zulip  18087 Oct 15 20:13 deskcom.7fc882cd09da.png
-rw-r--r--  1 zulip zulip  18087 Oct 15 20:13 deskcom.png
-rw-r--r--  1 zulip zulip    694 Oct 15 20:13 email.569eed650f93.svg
-rw-r--r--  1 zulip zulip    694 Oct 15 20:13 email.svg
-rw-r--r--  1 zulip zulip 197889 Oct 15 20:13 freshdesk.5606ecb3ae21.svg
-rw-r--r--  1 zulip zulip 197889 Oct 15 20:13 freshdesk.svg
-rw-r--r--  1 zulip zulip   1101 Oct 15 20:13 git.63f5f0ed0289.svg
-rw-r--r--  1 zulip zulip   1998 Oct 15 20:13 github.6d17f8202f54.svg
-rw-r--r--  1 zulip zulip   1998 Oct 15 20:13 github.svg
-rw-r--r--  1 zulip zulip   1161 Oct 15 20:13 gitlab.e4ca60892e64.svg
-rw-r--r--  1 zulip zulip   1161 Oct 15 20:13 gitlab.svg
-rw-r--r--  1 zulip zulip   1101 Oct 15 20:13 git.svg
-rw-r--r--  1 zulip zulip   4270 Oct 15 20:13 gogs.1d863355c5bf.svg
-rw-r--r--  1 zulip zulip   4270 Oct 15 20:13 gogs.svg
-rw-r--r--  1 zulip zulip   5914 Oct 15 20:13 google-calendar.baee3db9039d.svg
-rw-r--r--  1 zulip zulip   5914 Oct 15 20:13 google-calendar.svg
-rw-r--r--  1 zulip zulip  77611 Oct 15 20:13 google-hangouts.03f7743814ec.svg
-rw-r--r--  1 zulip zulip  77611 Oct 15 20:13 google-hangouts.svg
-rw-r--r--  1 zulip zulip   2297 Oct 15 20:13 google-translate.895dbe7baf7c.svg
-rw-r--r--  1 zulip zulip   2297 Oct 15 20:13 google-translate.svg
-rw-r--r--  1 zulip zulip   9021 Oct 15 20:13 gosquared.685eebf4a02c.svg
-rw-r--r--  1 zulip zulip   9021 Oct 15 20:13 gosquared.svg
-rw-r--r--  1 zulip zulip  11744 Oct 15 20:13 greenhouse.3141464ee78d.svg
-rw-r--r--  1 zulip zulip  11744 Oct 15 20:13 greenhouse.svg
-rw-r--r--  1 zulip zulip    876 Oct 15 20:13 hellosign.fd71bdf5e651.svg
-rw-r--r--  1 zulip zulip    876 Oct 15 20:13 hellosign.svg
-rw-r--r--  1 zulip zulip  26576 Oct 15 20:13 helloworld.93e14227a79c.svg
-rw-r--r--  1 zulip zulip  26576 Oct 15 20:13 helloworld.svg
-rw-r--r--  1 zulip zulip    597 Oct 15 20:13 heroku.e85ed02d91dd.svg
-rw-r--r--  1 zulip zulip    597 Oct 15 20:13 heroku.svg
-rw-r--r--  1 zulip zulip 215004 Oct 15 20:13 homeassistant.b2ff0e00ab45.svg
-rw-r--r--  1 zulip zulip 215004 Oct 15 20:13 homeassistant.svg
-rw-r--r--  1 zulip zulip  12230 Oct 15 20:13 hubot.97c5f6a28a3a.png
-rw-r--r--  1 zulip zulip  12230 Oct 15 20:13 hubot.png
-rw-r--r--  1 zulip zulip    314 Oct 15 20:13 ifttt.e61920cc3ea5.svg
-rw-r--r--  1 zulip zulip    314 Oct 15 20:13 ifttt.svg
-rw-r--r--  1 zulip zulip 125150 Oct 15 20:13 instagram.30129480e943.png
-rw-r--r--  1 zulip zulip 125150 Oct 15 20:13 instagram.png
-rw-r--r--  1 zulip zulip  17279 Oct 15 20:13 jenkins.6dbe2646d7c0.svg
-rw-r--r--  1 zulip zulip  17279 Oct 15 20:13 jenkins.svg
-rw-r--r--  1 zulip zulip   1980 Oct 15 20:13 jira.357243042d16.svg
-rw-r--r--  1 zulip zulip   1980 Oct 15 20:13 jira.svg
-rw-r--r--  1 zulip zulip    570 Oct 15 20:13 librato.6e5c7c58db12.svg
-rw-r--r--  1 zulip zulip    570 Oct 15 20:13 librato.svg
-rw-r--r--  1 zulip zulip  11060 Oct 15 20:13 mailchimp.b931ca43680d.svg
-rw-r--r--  1 zulip zulip  11060 Oct 15 20:13 mailchimp.svg
-rw-r--r--  1 zulip zulip   5300 Oct 15 20:13 mention.78f9c42b8017.svg
-rw-r--r--  1 zulip zulip   5300 Oct 15 20:13 mention.svg
-rw-r--r--  1 zulip zulip   4229 Oct 15 20:13 mercurial.080ce615e925.svg
-rw-r--r--  1 zulip zulip   4229 Oct 15 20:13 mercurial.svg
-rw-r--r--  1 zulip zulip   2223 Oct 15 20:13 nagios.5c7469ba13c5.svg
-rw-r--r--  1 zulip zulip   2223 Oct 15 20:13 nagios.svg
-rw-r--r--  1 zulip zulip   1037 Oct 15 20:13 newrelic.e3c93df41724.svg
-rw-r--r--  1 zulip zulip   1037 Oct 15 20:13 newrelic.svg
-rw-r--r--  1 zulip zulip   2480 Oct 15 20:13 openshift.ccd8dc610462.svg
-rw-r--r--  1 zulip zulip   2480 Oct 15 20:13 openshift.svg
-rw-r--r--  1 zulip zulip   1581 Oct 15 20:13 pagerduty.6f40d8b8dda2.svg
-rw-r--r--  1 zulip zulip   1581 Oct 15 20:13 pagerduty.svg
-rw-r--r--  1 zulip zulip   1056 Oct 15 20:13 papertrail.6be32921370d.svg
-rw-r--r--  1 zulip zulip   1056 Oct 15 20:13 papertrail.svg
-rw-r--r--  1 zulip zulip   1144 Oct 15 20:13 perforce.fc37206a917c.svg
-rw-r--r--  1 zulip zulip   1144 Oct 15 20:13 perforce.svg
-rw-r--r--  1 zulip zulip    606 Oct 15 20:13 phabricator.19d3160662ea.svg
-rw-r--r--  1 zulip zulip    606 Oct 15 20:13 phabricator.svg
-rw-r--r--  1 zulip zulip   1329 Oct 15 20:13 pingdom.554a1dd91070.svg
-rw-r--r--  1 zulip zulip   1329 Oct 15 20:13 pingdom.svg
-rw-r--r--  1 zulip zulip   2822 Oct 15 20:13 pivotal.b494cfea05fc.svg
-rw-r--r--  1 zulip zulip   2822 Oct 15 20:13 pivotal.svg
-rw-r--r--  1 zulip zulip    344 Oct 15 20:13 puppet.3af6834c421a.svg
-rw-r--r--  1 zulip zulip    344 Oct 15 20:13 puppet.svg
-rw-r--r--  1 zulip zulip   5164 Oct 15 20:13 redmine.147828de95b0.svg
-rw-r--r--  1 zulip zulip   5164 Oct 15 20:13 redmine.svg
-rw-r--r--  1 zulip zulip   1580 Oct 15 20:13 rss.8d1b3b14bf63.svg
-rw-r--r--  1 zulip zulip   1580 Oct 15 20:13 rss.svg
-rw-r--r--  1 zulip zulip   2540 Oct 15 20:13 semaphore.2a52315d0685.svg
-rw-r--r--  1 zulip zulip   2540 Oct 15 20:13 semaphore.svg
-rw-r--r--  1 zulip zulip   1203 Oct 15 20:13 sentry.9f797865a713.svg
-rw-r--r--  1 zulip zulip   1203 Oct 15 20:13 sentry.svg
-rw-r--r--  1 zulip zulip   1626 Oct 15 20:13 slack.4ccf20bcf3c3.svg
-rw-r--r--  1 zulip zulip   1626 Oct 15 20:13 slack.svg
-rw-r--r--  1 zulip zulip    898 Oct 15 20:13 solano.35b9720c6a14.svg
-rw-r--r--  1 zulip zulip    898 Oct 15 20:13 solano.svg
-rw-r--r--  1 zulip zulip    458 Oct 15 20:13 splunk.dfc847928efd.svg
-rw-r--r--  1 zulip zulip    458 Oct 15 20:13 splunk.svg
-rw-r--r--  1 zulip zulip  17254 Oct 15 20:13 stripe.e5203c099061.png
-rw-r--r--  1 zulip zulip  17254 Oct 15 20:13 stripe.png
-rw-r--r--  1 zulip zulip  12836 Oct 15 20:13 subversion.743d49870a3a.svg
-rw-r--r--  1 zulip zulip  12836 Oct 15 20:13 subversion.svg
-rw-r--r--  1 zulip zulip    997 Oct 15 20:13 taiga.6e1146815859.svg
-rw-r--r--  1 zulip zulip    997 Oct 15 20:13 taiga.svg
-rw-r--r--  1 zulip zulip   2959 Oct 15 20:13 teamcity.22ccf206591f.svg
-rw-r--r--  1 zulip zulip   2959 Oct 15 20:13 teamcity.svg
-rw-r--r--  1 zulip zulip   1732 Oct 15 20:13 trac.8ddec3903822.svg
-rw-r--r--  1 zulip zulip   1732 Oct 15 20:13 trac.svg
-rw-r--r--  1 zulip zulip   1819 Oct 15 20:13 transifex.68ac329ecbfe.svg
-rw-r--r--  1 zulip zulip   1819 Oct 15 20:13 transifex.svg
-rw-r--r--  1 zulip zulip  23860 Oct 15 20:13 travis.1791de5d4fc7.svg
-rw-r--r--  1 zulip zulip  23860 Oct 15 20:13 travis.svg
-rw-r--r--  1 zulip zulip    523 Oct 15 20:13 trello.ee6cab6b0217.svg
-rw-r--r--  1 zulip zulip    523 Oct 15 20:13 trello.svg
-rw-r--r--  1 zulip zulip    968 Oct 15 20:13 twitter.62c31aa60e04.svg
-rw-r--r--  1 zulip zulip    968 Oct 15 20:13 twitter.svg
-rw-r--r--  1 zulip zulip   1295 Oct 15 20:13 updown.34761e88b52b.svg
-rw-r--r--  1 zulip zulip   1295 Oct 15 20:13 updown.svg
-rw-r--r--  1 zulip zulip   1596 Oct 15 20:13 wordpress.ef3bc75c6cf2.svg
-rw-r--r--  1 zulip zulip   1596 Oct 15 20:13 wordpress.svg
-rw-r--r--  1 zulip zulip   1242 Oct 15 20:13 yo.bfc2eb1e59ea.svg
-rw-r--r--  1 zulip zulip   1242 Oct 15 20:13 yo.svg
-rw-r--r--  1 zulip zulip   1726 Oct 15 20:13 youtube.a651e168b703.svg
-rw-r--r--  1 zulip zulip   1726 Oct 15 20:13 youtube.svg
-rw-r--r--  1 zulip zulip   1408 Oct 15 20:13 zapier.703d6c706efc.svg
-rw-r--r--  1 zulip zulip   1408 Oct 15 20:13 zapier.svg
-rw-r--r--  1 zulip zulip  51880 Oct 15 20:13 zendesk.3b7f5aadb5df.svg
-rw-r--r--  1 zulip zulip  51880 Oct 15 20:13 zendesk.svg
root@chat:/home/zulip/prod-static/images/integrations/logos# pwd
/home/zulip/prod-static/images/integrations/logos

I believe these files should be .svg, so my guess is that in @adambirds's installation, the problem is in zerver/lib/integrations.py.
I guess the code is this:
    DEFAULT_LOGO_STATIC_PATH_PNG = 'static/images/integrations/logos/{name}.png'
    DEFAULT_LOGO_STATIC_PATH_SVG = 'static/images/integrations/logos/{name}.svg'

...
        if logo is None:
            if os.path.isfile(self.DEFAULT_LOGO_STATIC_PATH_SVG.format(name=name)):
                logo = self.DEFAULT_LOGO_STATIC_PATH_SVG.format(name=name)
            else:
                logo = self.DEFAULT_LOGO_STATIC_PATH_PNG.format(name=name)

So we would expect if something were wrong with the paths involved.
Oh, I bet I see the problem: those DEFAULT_... paths don't correctly use STATIC_ROOT to find the files.  So if a machine has never been upgraded with upgrade-zulip-from-git, this is busted.

@eeshangarg can you fix this ASAP?  We'll definitely want the fix in the 1.7 release.  I believe we just need to replace the static/ at the start of these paths with settings.STATIC_ROOT.

(@adambirds thanks for the report, as this is a release-critical issue that we were very unlikely to find in any of our testing environments, since we usually use the from-git upgrade code path)

Thanks again for reporting this @adambirds; it should be fixed in master.  If you want do an upgrade-zulip-from-git from master to confirm the fix on your system, that'd be awesome.

@timabbott when I did my upgrade from git earlier as part of #7017 all of the logos where showing fine. But I believe you said when upgrading from git, you get the files, so it wouldn't error anyway. Think it's only an issue when installing from a tar ball. Or is there any specific way I can check the new way is working? Thanks.

@adambirds You make a great point.  I'll get this verified another way.

OK, verified the fix with one of our production systems by just moving aside static/.  Thanks again for the report @adambirds!


Messaging metrics: clarify it's about client-side

Looking at https://github.com/open-telemetry/semantic-conventions/blob/main/docs/messaging/messaging-metrics.md, it's not immediately obvious they cover client-side only.
We should document it in the title, but also update metric names to emphasize it.
We should consider messaging.producer.publish.duration and  messaging.consumer.process|receive.duration.
Besides being more descriptive, it would leave space for broker metrics (if they ever come to messaging namespace).

This is a good idea. It also keeps consistency with HTTP, RPC, and databases, where the pattern always is <area>.<span-kind>.

Closing in favor of #937 which seems to be broader and has more context


[feature request] request-response logging

This is to have an issue to track the discussion we've already started.
kf-serving's use of knative makes the knative observability stack available to use in a straightforward way. This includes a lot of telemetry out of the box but request-response logging can be a bit more subtle, especially for machine learning. The simplest case is if one just wants an audit trail of traffic. This can be handled by getting raw payloads (possibly via an istio configuration) and outputting to stdout for fluentd/fluentbit collection. Where complexity grows is if one wants to make the data searchable, say to make it easy to link the request-response pairs, search by a business-relevant identifier (say customerId or orderId), search by a particular feature value, distinguish individual requests vs batch requests or handle image/binary data differently (e.g. send images to different storage and perhaps label them for retrieval).
This has been discussed with the knative team. In the seldon-core project we faced the same challenge and decided to use a sidecar that sends the request-response pairs to a configurable request logging step which sits behind a knative broker (using knative eventing).
@animeshsingh put together https://docs.google.com/document/d/1MBl5frM9l_wyQkYEaDeHOP6Mrsuz9YOob7276AAN9_c/edit to summarise research on what could be done for kf-serving. The discussion is on-going - raising this issue to track the on-going work.

Thanks @ryandawsonuk. @ellis-bigelow fyi - we intend to revisit this post v0.1
https://docs.google.com/document/d/1MBl5frM9l_wyQkYEaDeHOP6Mrsuz9YOob7276AAN9_c/edit to s

/area ml-feature

Should this be added to https://github.com/kubeflow/kfserving/blob/master/ROADMAP.md ?

Thanks @ryandawsonuk. I have added it in the PR as one of the items
https://github.com/kubeflow/kfserving/pull/230

@animeshsingh I remember some work was done to log from a custom lua filter in the istio sidecar. Is that work or a snippet from it available anywhere to look at?

Implemented by https://github.com/kubeflow/kfserving/pull/467


Allow CVCache subclasses

This PR allows classes inheriting from DaskBaseSearchCV to pass a CVCache-like instance as the cache_cv keyword.
This PR replaces #61 - responding to feedback there from @mrocklin / @TomAugspurger  on reducing impact to dask-searchcv associated with elm's wrapping of scikit-learn.
I'll add a test for passing in a CVCache-like instance.

Added tests of passing CVCache-like instance as cache_cv argument to one of the dask_searchcv.model_selection classes.
If cache_cv is not passed as a boolean, then it is expected that refit=False or refit=X or refit=(X, y), with the latter two cases useful when passing CVCache-like instance as cache_cv If refit=True and cache_cv is CVCache-like, then model selection fails in refitting. Explained in docstrings here:

refit : boolean, array-like or (X, y) tuple, default=True,
    Refit the best estimator with the entire dataset.
    If "False", it is impossible to make predictions using
    this GridSearchCV instance after fitting.  If passing
    cache_cv as a CVCache-like instance, then refit
    must be "False" or a feature matrix X or an X, y tuple.

cache_cv : bool or object with ``extract`` method, default=True
    If boolean, ``cache_cv`` indicates whether to extract each train/test
    subset at most once in each worker process, or every time that subset
    is needed. Caching the splits can speedup computation at the cost of
    increased memory usage per worker process.

    If True, worst case memory usage is ``(n_splits + 1) * (X.nbytes +
    y.nbytes)`` per worker. If False, worst case memory usage is
    ``(n_threads_per_worker + 1) * (X.nbytes + y.nbytes)`` per worker.

    If ``cache_cv`` is not True/False it should be an instance with an
     ``extract(self, X, y, n, is_x=True, is_train=True)`` (
    similar to ``dask_searchcv.methods.CVCache``)

@TomAugspurger Can you let me know what you think of this PR's approach?

Sorry for hopping in here late, I've been a bit swamped. While this looks less invasive than #61, it makes use of an internal component that isn't meant to really be exposed. cache_cv is intended to help manage memory usage across processes, and shouldn't affect the internal workings of the search at this level (at least when exposed to the users).
What I'd rather prefer is to expose the bits that you need as private methods/attributes on our cv classes, and have you subclass and override. This keeps our interface the same as that in scikit-learn, while also supporting your needs.
This could be as simple as removing your changes to the public cache_cv kwarg, and instead storing the CVCache class to use internally as a private attribute on subclasses. Keeps the user interface clean (users don't need this option), while allowing your stuff to work. There may be better ways as well.
To this end, do you have an example of how elm will use the things exposed in this PR? Both what your cache_cv classes might look like, and how the alternate refit arguments may be used is a bit opaque to me.

@PeterDSteinberg and I just chatted offline about this. The consensus on a best path forward was:

Revert all public facing interface changes here. Both the cache_cv and refit kwargs stay the same as before.

Add a _do_refit (or a better name) method to the *SearchCV classes to override how refitting is done. Elm can then override this to handle whatever behavior is needed. The default implementation would be the current behavior.

Add a _get_cv_cache (or a better name) method to the *SearchCV classes to allow Elm access to implement sampling as needed. This could be done a few ways:

Return a function like dask_searchcv.methods.cv_split, to be used instead of this function?
Return a CVCache-like class, to be used instead of CVCache?
Some other interface?

The interface here would depend on what exactly Elm needs exposed to make this work.

This approach allows Elm access to the needed internals without changing the user-facing interface in a way that we're bound to for future releases (we can evolve the internals as Elm's needs evolve).

FYI, further development of dask-searchcv is happening in dask-ml.


fix: add cookies route to middleware config

Summary
The middleware demo isn't setting a cookie on the /cookies route currently because we forgot to add it to the config.
Fixes #1639
Test plan

Visit the middleware Deploy Preview
Click the "Cookies API" link, or visit /cookies
See that the "netlifyCookie" has been set.

Relevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal

Standard checks:

[ ] Check the Deploy Preview's Demo site for your PR's functionality
[ ] Add docs when necessary

🧪 Once merged, make sure to update the version if needed and that it was published correctly.

What a handsome hound.
Do we have a test that would have caught this?

@ascorbic Good point! Added a cypress test to check for the cookie.


Change redirect opt-out to x-ipfs-companion-no-redirect

This is a tweak of https://github.com/ipfs-shipyard/ipfs-companion/pull/505, as suggested in https://github.com/ipfs-shipyard/ipfs-companion/pull/505#issuecomment-401723828

Landed in v<IP_ADDRESS>20 (Beta)


add imenu and imenu-list support.

add imenu and imenu-list support
fix the call of (define-derived-mode)

Hey @ericprud started playing with FHIR and imenu is a great help in jumping between them gazillion shapes. imenu-list gives a nice overview and shows where you are (the right pane is synced with the point in the main pane).
It's for a FHIR RFI in a EU country and if it moves forward, I'd like to talk to you: how can I reach you?


Some tests from tests\test_private_api.py FAILED

Please follow the guide below

Issues submitted without this template format will be ignored.
Please read the questions carefully and answer completely.
Do not post screenshots of error messages or code.
Put an x into all the boxes [ ] relevant to your issue (==> [x] NO spaces).
Use the Preview tab to see how your issue will actually look like.
Issues about reverse engineering is out of scope and will be closed without response.
Any mention of spam-like actions or spam-related tools/libs/etc is strictly not allowed.

Before submitting an issue, make sure you have:

[x] Updated to the lastest version v1.5.7
[x] Read the README and docs
[x] Searched the bugtracker for similar issues including closed ones
[x] Reviewed the sample code in tests and examples

Which client are you using?

[x] app (instagram_private_api/)
[ ] web (instagram_web_api/)

Describe the Bug/Error:
I try to run tests and see errors.

Paste the output of python -V here:
python -V
Python 3.6.0
Code:
D:\....\instagram_private_api>python -m tests.test_private_api -settings settings.txt -u mil****2 -p Go****0
Client version: 1.5.7

Error/Debug Log:
======================================================================
ERROR: test_post_video_mock (tests.private.upload.UploadTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\....\instagram_private_api\tests\private\upload.py", line 699, in test_post_video_mock
    with open(sample_video, 'rb') as video_fp, \
FileNotFoundError: [Errno 2] No such file or directory: 'D:\\....\\instagram_private_api\\tests\\private\\../media/test.mp4'

======================================================================
ERROR: test_search_users (tests.private.users.UsersTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\....\instagram_private_api\tests\private\users.py", line 89, in test_search_users
    results = self.api.search_users('maruhanamogu', rank_token)
TypeError: search_users() takes 2 positional arguments but 3 were given

======================================================================
FAIL: test_collection_feed (tests.private.collections.CollectionsTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\....\instagram_private_api\tests\private\collections.py", line 47, in test_collection_feed
    self.assertTrue(results.get('items'), 'No collection')
AssertionError: [] is not true : No collection

======================================================================
FAIL: test_self_feed (tests.private.feed.FeedTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\....\instagram_private_api\tests\private\feed.py", line 103, in test_self_feed
    self.assertGreater(len(results.get('items', [])), 0, 'No items returned.')
AssertionError: 0 not greater than 0 : No items returned.

======================================================================
FAIL: test_stories_archive (tests.private.highlights.HighlightsTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\....\instagram_private_api\tests\private\highlights.py", line 39, in test_stories_archive
    self.assertIn('items', results)
AssertionError: 'items' not found in {'reel_auto_archive': 'unset', 'status': 'ok'}

----------------------------------------------------------------------
Ran 203 tests in 296.861s

FAILED (failures=3, errors=2, skipped=40)

What am I wrong ?

First test can't succeed as the test video isn't included in the repo. I don't think including it is a good idea, so you either need to just ignore that one or supply your own properly formatted video.
search_users was updated 5 days ago and all arguments besides query were moved to kwargs. This test needs to be updated.
For the others I'd guess the results in the tests depend on ping's test account, and yours differs (e.g. it no collections or posts.)

Thank you for reply. But what about this?
D:\....\instagram_private_api\instagram_private_api\client.py:172: UserWarning: Proxy support is alpha .   warnings.warn('Proxy support is alpha.', UserWarning) Exception: 'HTTPError' object has no attribute 'reason'

Which test is throwing that error?

This is not a test, but what does it change?
I use the library. Error inside the library.
What's wrong?
PS: I use instagram_private_api for connect IG by proxy.

That is a different problem. This issue is about failing tests. Please submit a new issue with the required technical info (code to reproduce the error, full error stack, etc.)


Fix link example default jasmine2 test runner package.

Summary

Test plan

Codecov Report

Merging #8290 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #8290   +/-   ##
======================================
  Coverage    62.2%   62.2%
======================================
  Files         266     266
  Lines       10673   10673
  Branches     2595    2596    +1
======================================
  Hits         6639    6639
  Misses       3445    3445
  Partials      589     589

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fc468c...4017b0f. Read the comment docs.

Thanks! Could you fix the versioned docs as well?

@SimenB

Could you fix the versioned docs as well?

I fixed. Please help me check it. Thank you!


Another FMA implementation

Since you are comparing soft FMAs of MUSL and BSD, I thought you would find interesting another implementation by Fabrice Bellard in his SoftFP, see softfp_template.h/fma_sf().

This is indeed very interesting. I will take a crack at the implementation and compare it with the others. Thanks!

4ef5b87c251d4224e3f3fef4fcc731462d1a6720 implements Bellard's version. Preliminary benchmarking reveals it to run at the same speed as MUSL's, but the Bellard translation uses ~50 more lines of code.
This is unfair, since Bellard reimplements basic operations like NaN checking and normalization on the integer representation of the float. MUSL however, makes use of the standard library and underlying FPU implementation more, but there may be room for refactoring.

Thank you for the thorough comparative analysis! Very interesting, indeed.


Run-time error '13': type mismatch

Hi,
I am trying to convert a json string into a dictionary using your library but unfortunately I get a Run-time error '13': type mismatch:
My code looks like this:
Dim jsonStr As String
' jsonStr = "[ [ 1, "label1" ], [ 2, "label2" ] ]"
jsonStr  = "[  [ 1, " + """" + "label1" + """" + " ], [ 2, " + """" + "label2" + """" + " ] ]"

Dim Parsed As Dictionary
' Run-time error '13': type mismatch
Set Parsed = JsonConverter.ParseJson(jsonStr)

This my second day into Visual Basic so it is likely I am doing something silly...

I have now succeeded in making it work using the json example string from your README.md:
Dim Json As Object
Set Json = JsonConverter.ParseJson("{""a"":1,""b"":2,""c"":3}")

For Each Value In Json.Items
    MsgBox ("Value: " + CStr(Value))
Next Value

But I still need to figure out how to parse an array of arrays json string like "[ [ 1, "label1" ], [ 2, "label2" ] ]".

When parsing an object use Dictionary and an array use Collection.
Dim Parsed As Collection
Set Parsed = JsonConverter.ParseJson("[[1, ""label1""], [2, ""label2""]]")

For Each Value In Parsed
  ' Note: Collections are 1-based
  Debug.Print Value(1) & ", " & Value(2)' -> "1, label1" or "2, label2"
Next Value

This my second day into Visual Basic

Welcome!

@timhall
Hello Tim,
I installed your JSON converter and I am willing to use it to import git issues from a file in json format. The json file is generated using a curl command on a git repo. I checked the json file is correct (I am able to convert it with online tools, also I can maniulate it using JQ). However, my project needs to import issues into Excel so I am highly interested in your JSON converter :-)
Using your advanced example on my issues file, I get the same type mismatch error on the ParseJson statement. Any hint?
`Sub example2()
Dim FSO As New FileSystemObject
Dim JsonTS As TextStream
Dim JsonText As String
Dim Parsed As Dictionary
' Read .json file
Set JsonTS = FSO.OpenTextFile("issues.json", ForReading)
JsonText = JsonTS.ReadAll
JsonTS.Close

Debug.Print JsonText, Len(JsonText)

' Parse json to Dictionary
' "values" is parsed as Collection
' each item in "values" is parsed as Dictionary
Set Parsed = JsonConverter.ParseJson(JsonText)`

Without seeing issues.json I suspect it's an array of objects, e.g., [ { ... }, { ... } ]. Therefore:
Dim Parsed as Collection
Set Parsed = JsonConverter.ParseJson(JsonText)

From: michelreyrolle<EMAIL_ADDRESS>Sent: Friday, May 1, 2020, 2:29 PM
To: VBA-tools/VBA-JSON
Cc: Subscribed
Subject: Re: [VBA-tools/VBA-JSON] Run-time error '13': type mismatch (#126)
@timhallhttps://github.com/timhall
Hello Tim,
I installed your JSON converter and I am willing to use it to import git issues from a file in json format. The json file is generated using a curl command on a git repo. I checked the json file is correct (I am able to convert it with online tools, also I can maniulate it using JQ). However, my project needs to import issues into Excel so I am highly interested in your JSON converter :-)
Using your advanced example on my issues file, I get the same type mismatch error on the ParseJson statement. Any hint?
`Sub example2()
Dim FSO As New FileSystemObject
Dim JsonTS As TextStream
Dim JsonText As String
Dim Parsed As Dictionary
' Read .json file
Set JsonTS = FSO.OpenTextFile("issues.json", ForReading)
JsonText = JsonTS.ReadAll
JsonTS.Close
Debug.Print JsonText, Len(JsonText)
' Parse json to Dictionary
' "values" is parsed as Collection
' each item in "values" is parsed as Dictionary
Set Parsed = JsonConverter.ParseJson(JsonText)`
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/VBA-tools/VBA-JSON/issues/126#issuecomment-622506236, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AIKTRAYN2IFNMPYUI37FMQLRPMIIDANCNFSM4GWYGE4A.

@houghtonap Yep it works with collection.
Now I am looking at iterating issues in the collection and finds the following structure of the Parsed object. Now I need to figure out how to get jason values from this.

   Set Parsed = JsonConverter.ParseJson(JsonText)     Debug.Print Parsed.Count     Dim p, pp As Long     For p = 1 To Parsed.Count         Debug.Print Parsed(p).Count         For pp = 1 To Parsed(p).Count             Debug.Print Parsed(p).Item(pp)         Next pp     Next p

You need to look at the Collection object and Dictionary object on Microsoft's website to determine what methods to use. I posted to someone else's issue that gave transversal code. See issue #131.

From: michelreyrolle<EMAIL_ADDRESS>Sent: Friday, May 1, 2020 3:16:00 PM
To: VBA-tools/VBA-JSON<EMAIL_ADDRESS>Cc: Andrew Houghton<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [VBA-tools/VBA-JSON] Run-time error '13': type mismatch (#126)
@houghtonaphttps://github.com/houghtonap Yep it works with collection.
Now I am looking at iterating issues in the collection and finds the following structure of the Parsed object. Now I need to figure out how to get jason values from this.
[image]https://user-images.githubusercontent.com/25659991/80834358-d7f83000-8bf0-11ea-853c-4f5923e9084f.png
Set Parsed = JsonConverter.ParseJson(JsonText) Debug.Print Parsed.Count Dim p, pp As Long For p = 1 To Parsed.Count Debug.Print Parsed(p).Count For pp = 1 To Parsed(p).Count Debug.Print Parsed(p).Item(pp) Next pp Next p
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/VBA-tools/VBA-JSON/issues/126#issuecomment-622524167, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AIKTRA3I4VS2WMEX625KH5DRPMNXBANCNFSM4GWYGE4A.

From: michelreyrolle<EMAIL_ADDRESS>Sent: Friday, May 1, 2020 3:16:00 PM
To: VBA-tools/VBA-JSON<EMAIL_ADDRESS>Cc: Andrew Houghton<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [VBA-tools/VBA-JSON] Run-time error '13': type mismatch (#126)
@houghtonaphttps://github.com/houghtonap Yep it works with collection.
Now I am looking at iterating issues in the collection and finds the following structure of the Parsed object. Now I need to figure out how to get jason values from this.
[image]https://user-images.githubusercontent.com/25659991/80834358-d7f83000-8bf0-11ea-853c-4f5923e9084f.png
Set Parsed = JsonConverter.ParseJson(JsonText) Debug.Print Parsed.Count Dim p, pp As Long For p = 1 To Parsed.Count Debug.Print Parsed(p).Count For pp = 1 To Parsed(p).Count Debug.Print Parsed(p).Item(pp) Next pp Next p
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/VBA-tools/VBA-JSON/issues/126#issuecomment-622524167, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AIKTRA3I4VS2WMEX625KH5DRPMNXBANCNFSM4GWYGE4A.

You need to look at the Collection object and Dictionary object on Microsoft's website to determine what methods to use. I posted to someone else's issue that gave transversal code. See issue #131.
…

Before going further I would like to understand why the collection only shows item labels and no values (See watch window screenshot) above where values of items in the collection are only json labels. I am wondering if values were actually parsed. The structure of my json file is attached.
sample-issues.zip

The collection object is used to hold an array. Array items in JavaScript are numbered. Thus, the key in the Collection object is a number and the value is the JavaScript primitive, Array or Object. Therefore, given your JSON:
Dim Parsed as Collection
Dim Obj as Dictionary
Set Parsed = JsonConverter.ParseJson(JsonText)
Set Obj = Parsed(0)
Obj now contains the first JSON Object in the Array which becomes a Scripting.Dictionary object in VBA. You then need to use it's methods to access properties in the JSON Object.
Again I'll refer you to read the documentation on Microsoft's website to see what methods are available on both the Collection object and the Scripting.Dictionary object and to understand how they work.
See also the code in issue #131 in my posts.

From: michelreyrolle<EMAIL_ADDRESS>Sent: Friday, May 1, 2020, 4:19 PM
To: VBA-tools/VBA-JSON
Cc: Andrew Houghton; Mention
Subject: Re: [VBA-tools/VBA-JSON] Run-time error '13': type mismatch (#126)
You need to look at the Collection object and Dictionary object on Microsoft's website to determine what methods to use. I posted to someone else's issue that gave transversal code. See issue #131https://github.com/VBA-tools/VBA-JSON/issues/131.
…
Before going further I would like to understand why the collection only shows item labels and no values (See watch window screenshot) above where values of items in the collection are only json labels. I am wondering if values were actually parsed. The structure of my json file is attached.
sample-issues.ziphttps://github.com/VBA-tools/VBA-JSON/files/4566145/sample-issues.zip
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/VBA-tools/VBA-JSON/issues/126#issuecomment-622549663, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AIKTRAZ522WDGFEIN4SRIUTRPMVELANCNFSM4GWYGE4A.

@houghtonap This was my first JSON parsing with VBA. I think I've now understood the mapping logic of JSON elements onto Dictionnary and Collection objects. Thanks again.


API tidy up - FrameworkAgreements

Now that FrameworkAgreements are updated directly by the frontend apps the API should no longer allow setting and unsetting agreement details through the SupplierFramework update route, so that functionality is removed here.
This also means that we should no longer include "draft" agreements in the SupplierFramework response - only signed/on-hold/countersigned agreements are counted as possible "current framework agreements".  This also means that there is no need to order FAs by id, as that was only used for selecting the "most recent" draft to include.
Three now-unused fields have been removed from the SupplierFramework model - database migration to come in separate PR.  These code changes will need to go in before the migration though.
I have replaced the current_framework_agreement property with a db.relationship, but I haven't been able to get it to order SupplierFrameworks by current_framework_agreement date.
We have agreed that for now we will not order the SupplierFrameworks returned from the list endpoint, and will instead do the ordering in the Admin frontend where the list response is used.
I have added TODOs as it would be nice to get this working at some point in the near future.

I'm currently reading the sql output of this new relationship to check it does the right thing. It uses a more complex sql construction than I was expecting which is why it's taking a bit of time.

Ok I've posted the working, non_primary mapper approach to the branch ris-framework-agreement-final-final-really-final-api-changes though I suggest possibly squashing some of the dead-end approaches out might be better than using that branch as-is so we don't have too much dirty misleading history lying around.

Also note I'm now pushing a bunch more things to that branch, not all of which you may want to stick in this PR, so take note & be selective...

OK I've pulled in changes from @risicle to get the current_framework_agreement relationship working properly and rebased to remove the old broken version.  Think this should be good to go now.

Ahem cough :+1: cough


add wordpress site for register.freezingsaddles.org

It would be valuable to have the WordPress registration site hosted on the freezingsaddles.org domain - we can secure it with SSL via LetsEncrypt easily, and it would let us do more direct integration with the database of registrants eventually.
It's possible to run WordPress via Docker and Docker Compose. The current registration site. http://s94971567.onlinehome.us , administered by Carol C., uses Updraft Plus as a backup solution. I did a proof of concept migration of this in November, 2021.
To do this I installed Wordpress via Docker (see #19 ) and then attempted to do a restoration of backups. I first tried to use the https://wordpress.org/plugins/all-in-one-wp-migration/ plugin, but I could not get it to restore, so I did a second pass of restoration using the Updraft Plus backup plugin, where I restored the backups from Dropbox from the other site. I edited the database backup file to replace http://s94971567.onlinehome.us with https://register.freezingsaddles.org and then put the backup files in place in /opt/compose/wordpress/wp-content/updraft, and I was able to do a restoration. Without editing the database files the Updraft restore complained that this was a migration not a restore and I had to get a premium license. No thanks!
The resulting installation had Ninja Forms in place and looks like it is at least partially functioning. To prevent confusion, I disabled automatic backups on the register.freezingsaddles.org site since it looks like the restore put the configuration of Updraft Plus that includes the Dropbox token into place.
There were some issues though that we would need to resolve before making a switch:

[ ] Resolve issue with MailPoet requiring a PDO MYSQL PHP Extension:  “MailPoet Error: MailPoet requires a PDO_MYSQL PHP extension. Please read our instructions on how to resolve this issue.”
[ ] Test whether mail is working - this may require fixes to MailPoet and possibly to the WP Mail SMTP plugin - this is configured with SendGrid currently
[ ] Test whether backups are working and going to Dropbox - and re-enable automatic daily backups - I set them to manual.
[ ] Fix up WordFence configuration for .htaccess - see below
[ ] Get any changes to .htaccess and wp-config.php into version control, without compromising credentials
[x] Have Carol do some exploratory testing to make sure that essential site functions are working.

Carol investigated and expanded on the list:

In general, it seems to be working well—thanks for all your work on this!  It will need a few tweaks before it is ready for use.  Given that you’re dealing with a much more serious issue right now (getting the site to read the Strava data), and we won’t be using the new site this year anyway, we can defer action on these.  However, just noting for later:

[ ] Something is messed up in the theme.  My site works off of the Twenty Thirteen Child theme, which is basically Twenty Thirteen with some tweaks that set the header image and some styling.  It looks like maybe that theme did not make it over, so the site is just using Twenty Thirteen.
[ ] We’ll need to do some stuff to get the mail working, because I have to set up a new API key and verify the domain with SendGrid.
[ ] I’ll need to update the Recaptcha so it works with a different domain.

MailPoet requires PDO MYSQL PHP Extension
MailPoet Error: MailPoet requires a PDO_MYSQL PHP extension. Please read our  instructions on how to resolve this issue. We should probably use a Dockerfile and docker-compose to do this.
WordFence .htaccess fixes
WordFence is complaining:

To make your site as secure as possible, take a moment to optimize the Wordfence Web Application Firewall: https://register.freezingsaddles.org/wp-admin/admin.php?page=WordfenceWAF&subpage=waf_options#configureAutoPrepend

Changes to .htaccess and wp-config.php
I used the advice in  https://help.servmask.com/2018/10/27/how-to-increase-maximum-upload-file-size-in-wordpress/ to increase the maximum upload file size and processing times. Those changes are just in the .htaccess and wp-config.php files on the server currently though., If we need those we should save them in version control and put at least a note in the README for a runbook, or script the care and feeding of those files.

This is not really fully resolved, we still need to do testing and integration.


listen to multiple xmlrpc packages in the same socket data event

Sometimes multiple xmlrpc calls happen in the same data event of the nodejs net.Socket. This causes the gbx client to miss some callbacks for example.

Thanks for the PR! Seems good, so will merge.

When ist the next release planned. I depend on this library in a side project of mine.

Should be updated already at npm!

On npm is version 1.2.0, but i does not include any changes., I made. Can you check that you pushed the new version with the changes to npm?

I unpublished 1.2.0 on npmjs since i could confirm it didn't include the changes. @reaby will probably push a new version later.

yep, my bad, for some reason i forgot to git pull locally the changes or git didn't merge or something. I published version 1.2.1 just a minute ago which contains the PR. Sorry for the hassle.


Curric/landing page header CUR-166

Description

Adds Header to Curriculum Landing Page
Adds SVG to Sanity
Removes unused previous code
Add breadcrumb and underline

Issue(s)
Fixes #CUR-166
How to test

Go to https://deploy-preview-1868--oak-web-application.netlify.thenational.academy/beta/teachers-2023/curriculum

Screenshots
How it used to look (delete if n/a):

How it should now look:

Checklist

[ ] Added or updated tests where appropriate
[ ] Manually tested across browsers / devices
[ ] Considered impact on accessibility
[ ] Design sign-off
[ ] Approved by product owner

blah

@k-huggs Thanks for adding Screenshots for @HelenHarlow

This may relate to a different ticket but I notice that with the lot picker component, when it is resized the button is also resized, which cuts off the copy. I think we should aim to have it so the button width stays fixed so this doesn’t happen. Other than that, all looks good to me

This may relate to a different ticket but I notice that with the lot picker component, when it is resized the button is also resized, which cuts off the copy. I think we should aim to have it so the button width stays fixed so this doesn’t happen. Other than that, all looks good to me

Noticed this, it's a regression on the button and what happens when it gets reduced in size. It'll be present across the OWA so will need to be ticketed up too

:tada: This PR is included in version 1.233.4 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Add Jenkinsfile for s390x

Add Jenkinsfile for s390x
https://issues.apache.org/jira/browse/AMQ-8133

@mattrpav @jbonofre
Could you please setup/create a job for s390x ? I have created jenkinsfile for s390x in this PR.

@srajmane do you have any stats of build times on s390x? on the x86 stuff the build can run for several hours.
I'm thinking step 1 re s390x may be to have weekly schedule vs build on-every-PR

@mattrpav Build time is 6-6.5 Hrs on s390x. For now, it is okay to have weekly schedule.

@mattrpav Could you please have a look?  Thanks !!

I guess it won't work on Apache Jenkins right ? Is it for a fork you have on your side ?

@jbonofre the Jenkins error is on the buggy test that fails on other CI runs as well.
@srajmane is there a way to merge the change so we have one JenkinsFile? That way we would inherit pipeline changes without having to keep two files in sync (things like JDK LTS runs, mvn verify, etc)

@mattrpav Thank you for the update. Sure, I will check and will try to keep one Jenkinsfile.

My point is that we don't have all executors available on Apache Jenkins.

My point is that we don't have all executors available on Apache Jenkins.

Apache Infra added a couple for s390

My point is that we don't have all executors available on Apache Jenkins.

Apache Infra added a couple for s390

OK, last time I asked it was in discussion because it's hard to manage. Fair enough then ;)

@jbonofre @mattrpav Added s390x node in Jenkinsfile. Please have a look.
Thanks !!

@jbonofre @mattrpav
Could you please have a look? Thanks !!

@srajmane I opened #956 which uses parameters (manual execution) as a first step. Need to understand how long the build runs on Apache's s390x. If we get quick turn-around times, we can add it to all PRs moving forward.


Building new archive makes EML errors - missing eml.ftl

Using IPT VERSION: IPT Version 2.3.1-rb916964
When building a new archive, we are getting an EML file error. Please advise.
ERROR java.io.FileNotFoundException: Template "eml.ftl" not found. The quoted name was interpreted by this template loader: ClassTemplateLoader(baseClass=org.gbif.file.FreemarkerWriter, packagePath="/templates/").
ERROR Publishing version #11.14of resource but_herbfailed:IO exception when writing eml for Resource but_herb
org.gbif.ipt.service.InvalidConfigException: IO exception when writing eml for Resource but_herb
at org.gbif.ipt.utils.EmlUtils.writeWithLocale(EmlUtils.java:106)
at org.gbif.ipt.service.manage.impl.ResourceManagerImpl.saveEml(ResourceManagerImpl.java:1976)
at org.gbif.ipt.service.manage.impl.ResourceManagerImpl.updateAlternateIdentifierForIPTURLToResource(ResourceManagerImpl.java:1600)
at org.gbif.ipt.service.manage.impl.ResourceManagerImpl.publishEml(ResourceManagerImpl.java:1639)
at org.gbif.ipt.service.manage.impl.ResourceManagerImpl.publish(ResourceManagerImpl.java:1215)
at org.gbif.ipt.config.PublishingMonitor$QueueMonitor.run(PublishingMonitor.java:95)
at java.lang.Thread.run(Thread.java:745)
ERROR java.io.FileNotFoundException: Template "eml.ftl" not found. The quoted name was interpreted by this template loader: ClassTemplateLoader(baseClass=org.gbif.file.FreemarkerWriter, packagePath="/templates/").
ERROR Publishing version #7.14of resource usf_herbfailed:IO exception when writing eml for Resource usf_herb
org.gbif.ipt.service.InvalidConfigException: IO exception when writing eml for Resource usf_herb
at org.gbif.ipt.utils.EmlUtils.writeWithLocale(EmlUtils.java:106)
at org.gbif.ipt.service.manage.impl.ResourceManagerImpl.saveEml(ResourceManagerImpl.java:1976)
at org.gbif.ipt.service.manage.impl.ResourceManagerImpl.updateAlternateIdentifierForIPTURLToResource(ResourceManagerImpl.java:1600)
at org.gbif.ipt.service.manage.impl.ResourceManagerImpl.publishEml(ResourceManagerImpl.java:1639)
at org.gbif.ipt.service.manage.impl.ResourceManagerImpl.publish(ResourceManagerImpl.java:1215)
at org.gbif.ipt.config.PublishingMonitor$QueueMonitor.run(PublishingMonitor.java:95)
at java.lang.Thread.run(Thread.java:745)

It should be noted that this installation was upgraded from version 2.2 to 2.3 on September 21st, and the archive hasn't built successfully since September 15th. The archive was probably last configured on version 2.1 however.

Thanks for reporting this issue Joanna. I see two resources in the logs: but_herb and usf_herb. What kind of resources are these? Can you successfully edit/save their metadata?
Can you please describe the steps you took to (re)produce this error? Did you press the publish all button for example?

Hi Kyle - I've asked Andrea to reply if she has time. If she is not able, I'll get back to you after my next trip (beginning tomorrow), after I've tried to re-construct the path to the errors. Note: a couple of other achieves have been built since the update and they are fine.

It also looks like the date are out of kilter. The Friesner Herbarium's next publish date is earlier than the actual 'Last Modified' and 'Last Publication' dates. It is likely that I don't understand the sequence of the the dates.

Kyle, these resources are connecting directly to a MSSQL database, and mappings exist for both specimen occurrences and simple multimedia extension. Thus, they have been configured to be auto-published on a weekly basis, and we did not have any problems with the auto-publish until the upgrade. In the first upgrade, the auto-publishing continued to work, but I was not able to change any metadata (since IPT required the instance to be registered, and our IPT is not registered). After the latest upgrade to an IPT version that would remove this constraint, we found that the auto-publishing stopped working with the error above. I experimented changing the name of the resource and it succeeded. So, I'm able to save/edit metadata.

Thanks for the additional information.
Next, can you please try to re-publish "but_herb" by itself (not using auto-publishing) and confirm that you get the same error? Afterwards, can you locate its resource directory ($IPT data directory/resources/but_herb) and ensure the user running Tomcat has permissions to write to this directory? Easiest is probably to compare its permissions with the directory of another resource that re-publishes successfully for example.

It looks like the above error messages were caused by not having restarted Tomcat after the upgrade. Now we're running into #1205, but it looks like we can workaround that until the fix is released.

Thanks for reporting back.
Please note a new minor release 2.3.2 including the fix for #1205 will be made available shortly.


added Southern Connecticut State University (SCSU)

@AGV21 Thank you for your patience while waiting for a review and processing your request. Pull request merged. Please start applying for JetBrains educational subscription at https://www.jetbrains.com/shop/eform/students in an hour, to allow the changes to propagate through JetBrains systems.


Revert "lscolors: init at 0.7.1 (#114091)"

This reverts commit 4494db2d900a696331c1e5bc34b0a8d5540f1f3e.

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

What's the reason for revert?

This seems like a malicious PR. Closing.

I suppose this was closed since you did not check the check boxes?


Authorization Code Grant still not redirecting to custom protocols.

I'm sure I have reported this before, but not on its own issue... I can't seem to find it now.
I'm doing tests and I have set the Client Redirect Uri to be alckitsampleuri://. Anilist is supposed to call this custom protocol directly with the authorization code. But it looks like Anilist thinks I want to redirect somewhere alckitsampleuri:// within Anilist itself and so it 404's and sends me to the senpai page. The generated URL (that works fine) looks like this.
https://anilist.co/api/auth/authorize?grant_type=authorization_code&response_type=code&redirect_uri=alckitsampleuri://&client_id=CLIENT_ID
but approving the client will make it 404.
I have tried escaping the "://" characters, but at that point I get an error saying that the client is invalid.

Yeah you mentioned it on the forums, its something I did fix but then had to revert while I was fixing a bunch of the other oAuth issues. I'll looking to add this back again.

Hm, it looks like it's more broken than before.
Before I could add a generic .com website and it would try to redirect to that one. Now everything seems to 404 there.

I got a workaround, which is to specify any random hostname after the custom scheme.
alckitsampleuri://arandomhost.com
This should ideally get fixed, but I will use this is a workaround for now (I had a more complicated workaround before which involved my own server, so I'm glad I got this to work this way).


[refactor] nuxt.config.js

https://codeclimate.com/github/kodadot/nft-gallery/nuxt.config.js
now or later? I think maybb now?

👋

hmm i think this one is not urgent, and hence there's roadmap to upgrade nuxt in the near future this config file is not worth refactor. wdyt?

hence there's roadmap to upgrade nuxt in the near future this config file

I guess if nuxt3 is not being merged like this Sunday, we will be going through this step anyway

#6917

Preparing it for future nuxt3 structure makes sense as semantically we would need to split it as well, at least those things which don't need to be there.
https://nuxt.com/docs/getting-started/configuration#external-configuration-files

maybe now it's time, 431 lines 👀

https://github.com/kodadot/nft-gallery/blob/main/nuxt.config.js#L431


add ImaginAIryNFTs

What changed? Why?
{
"name": "ImaginAIryNFTs",
"tags": [
"NFT"
],
"description": "Unleash creativity with AI-generated art. Mint unique NFTs from your AI-dreamed designs.  Thanks for this PR. Could you please update the landing page so that Base is already selected as a network when creating an NFT, and resubmit?


Factor variance

closes #43

Variance should usually be a Float, no?

Yes, noticed already, working on it :D

Added an extractor for factor variance. Still a lot more needed for other arguments, will update them bit by bit


Added new command

Type
[x] New Feature
What is in this Pull Request ?
Added new command to Get PowerPlatform Solutions. This command would help to get the PowerPlatform solution for the given enviorment.

hi @gautamdsheth - did you get a chance to review the updated comments?

If I may anothe review comment as well, could you rename the cmdlet to Get-PnPPowerPlatformCustomConnector? It only returns the custom connectors, not the out of the box ones. I find the current name confusing in this sense.

If I may anothe review comment as well, could you rename the cmdlet to Get-PnPPowerPlatformCustomConnector? It only returns the custom connectors, not the out of the box ones. I find the current name confusing in this sense.

This is very good observation, changed the cmdlet to have custom word in it...


2.0.0

The Settings module/class seems unnecessary - value ranges and number of employers can be handed to the ABC when it's initialized, minimize can be a @property with setter methods, and best score/values can be @properties.
If you want to specify the number of employers and you don't already have a settings file, you need to initialize the ABC, call a method that calls _verify_ready() (which either start processing with default number of employers, 50, or rely on some processing to already be completed), call save_settings(), edit the file, re-initialize the object, and call import_settings(). This adds a lot of complexity when trying to change run-time parameters.

In sample_abc.py, executions must be wrapped in "if name == 'main':" to avoid multiprocessing errors

README has two sections for Installation

In check_positions(), bees abandon their food sources if their fitness is below the population's average fitness. It's possible that, even though those bees are below the average, through discovering neighboring food sources they can improve. The ABC has the potential to converge on a local minimum instead of a global one. For example if a local minimum is discovered, its fitness could be better than the "edge" or "slope" of a global minimum, causing the bee around the global minimum to abandon it.
From http://www.scholarpedia.org/article/Artificial_bee_colony_algorithm:
"Employed bees whose solutions cannot be improved through a predetermined number of trials, specified by the user of the ABC algorithm and called “limit” or “abandonment criteria” herein, become scouts and their solutions are abandoned." TL;DR, a bee only abandon a food source if that food source cannot be improved.

Pep8 styling could use a bit of work:

79 character maximum line length (somewhat subjective, but makes reading code on GitHub much easier)
No "==" for booleans or "None", use "is"
DocStrings for classes should be under init(), and should outline arguments, return values, etc.
There's unnecessary white space at the end of lines, between lines
Spaces are needed between arguments: "np.random.uniform(0,1)" to "np.random.uniform(0, 1)"
Spaces are needed around operators: "len(self._onlooker.best_employers) -1" to "len(self._onlooker.best_employers) - 1"

For methods only used by the ABC (e.g. _verify_ready, _gen_probability_values, etc.), use double-underscore naming scheme (especially if these methods are not meant to be called by the user).
Variables should use the double-underscore naming scheme if they should not be accessed by the user. If only the value of the variable should be accessed by the user, an @property method should be used. If the variable should be editable by the user, no underscoring is necessary. See this site for a better explanation of @property methods and setters: https://www.python-course.eu/python3_properties.php

Having the methods "create_employers" and "calc_new_positions" separate is a good idea - this allows the user to determine a cutoff point for whatever criteria they use, ultimately giving them more control over run-time 👍


create-react-class should be dependency instead of devDependency

The create-react-class class was introduced in 0.12.0, which is then used in index.js (source).
This causes issues when react-lorem-component is installed without devDependencies, because create-react-class cannot be found:
ERROR in ./packages/modal-dialog/~/react-lorem-component/index.js
Module not found: Error: Cannot resolve module 'create-react-class' in /Users/ben/Repos/atlassian/atlaskit/packages/modal-dialog/node_modules/react-lorem-component
 @ ./packages/modal-dialog/~/react-lorem-component/index.js 4:23-52

Moving the create-react-class line in package.json from devDependencies to dependencies should fix this.

Let me know if a PR would be useful, happy to help although just a 1 line change 😄

Hi @bengummer,
Thanks for reporting! It's fixed in v0.12.1.

Thanks @martinandert :)


Paper vs Code

Please elaborate upon these:

In both v1 and v3 archive versions of the paper the KL divergence is being mentioned as the loss in equation (3) (either directly (V3) or indirectly (V1: Cross-Entropy - Entropy (CE - H)), but in the code the CE itself is being considered. (There is a comment in the code that says # CE = KL + H as it clarifies CE itself has been used)

The paper says a GRU cell will be considered for the variational estimator q_\xi. I cannot find that GRU cell. As far as I can see there is a sequential (two layered feedforward) for the task. I see a GRU cell but that focuses on producing the agent q-values similar to some other MARL methods.

As mentioned in another closed issue, inference_net is not involved in the calculation of mi and dissimilarity because latent_dis and latent_move are cloned from latent (not latent_infer) and mi has gaussian_embed instead of gaussian_infer in its formula. I am wondering what is the role of inference_net then?

are these differences significant specially for the ablation studies done in the paper?

Another small question about the code:

Why did you change the function _build_inputs in the separate_controller module compare with the one written in the basic_controller. I see the appending orders changed. inputs.append(batch["obs"][:, t])  is in the middle in your function.

I appreciate your time and effort.

Hi,
Thanks for your interests in our work!

KL is expected when computing L_I. We use the entropy term to encourage exploration in the role space. As an entropy regularization is a commonly used trick in the RL community, we didn't stress it as a main contribution in our paper.

We share a GRU cell for q_\xi and the local Q function (Line. 107 in src/modules/agents/latent_ce_dis_rnn_agent.py. The input to q_\xi contains h_in, which is the output of the GRU cell) to accelerate training.

Yes, in our implementation, we did not use inference_net when calculating mi and dissimilarity. As shown in Appendix A (the derivation of Eq. 14 and Eq. 20), q_\xi in Eq. 6 can be replaced by any distribution of roles. In our code, we use the distribution generated by the role encoder. Both of them are mathematically correct, and in our repo, we select the one with more robust learning performance. There is a discrepancy between our code and paper. We are sorry for that.

The inference_net is used to produce a Gaussian distribution, gaussian_infer, which is then used to calculated the KL term. (Line. 113 in src/modules/agents/latent_ce_dis_rnn_agent.py)
As for the _build_inputs function, the order is slightly different, and we think this will not influence learning. :)

Hi!
When I use ”episode_runner“ to reproduce the code, the following error is always reported. How should I solve it?
"AssertionError: #labels should equal with #data points"
Thanks!


enableWithArtifact and enableWithClasspath

closes #57

Would you mind updating README as well?

OK, let me add a new section and then update the Motivation section.

This PR seems inconsistent with existing annotations, as the existing annotations enableMembersIf applies on all members, while this PR did not provide such ability.

Let me made another PR later.

This pr is ready, see the updated README here: https://github.com/darcy-shen/enableIf.scala/tree/feature/enableWithClasspath

This PR seems inconsistent with existing annotations, as the existing annotations enableMembersIf applies on all members, while this PR did not provide such ability.

Let me check if there is any possibility of merging enableMembersIf into enableIf? Wish to receive some help from you if any.

Let me check if there is any possibility of merging enableMembersIf into enableIf? Wish to receive some help from you if any.

It does not sound like a good idea because you are essentially trying to do different things in a single function.
How about this:
def hasArtifactInClasspath(artifactId: String, version: String)(context: Context): Boolean

Then the user will be able to use it either like this
@enableMembersIf(hasArtifactInClasspath("scala-library", scala.util.Properties.versionNumberString))

or
@enableIf(hasArtifactInClasspath("scala-library", scala.util.Properties.versionNumberString))

I tried in #70 , the syntax does not compile:
@enableIf(hasArtifactInClasspath("scala-library", scala.util.Properties.versionNumberString))


Other extensions making hiding verified accounts not work

https://twitter.com/rebelrealcanon/status/1421206879947083783

Aha, found them in case you're curious: Facebook Container and Privacy Badger both cause that to break--though all the other settings work fine. I don't know enough about how extensions interact to guess why.
https://github.com/mozilla/contain-facebook
https://privacybadger.org

This isn't a core feature, so not worried about edge cases with it


ImportError: No module named color_printer

Installing gcalcli from git into /usr/local/gcalcli and executing ./gcalcli/gcalcli.py results in
Traceback (most recent call last):
File "./gcalcli/gcalcli.py", line 120, in
from gcalcli.color_printer import ColorPrinter, valid_color_name
File "/usr/local/gcalcli/gcalcli/gcalcli.py", line 120, in
from gcalcli.color_printer import ColorPrinter, valid_color_name
ImportError: No module named color_printer

Do you also have this issue when you pip install?

Joshua Crowgey<EMAIL_ADDRESS>writes:

Do you also have this issue when you pip install?

I never used pip, I just run it from a git clone. Are there more steps
to be done if just using git? If so, can I manual do them?
Thanks,
Dieter Deyke
<EMAIL_ADDRESS>Get my Gnupg key:
gpg --keyserver keys.gnupg.net --recv-keys B116EA20

It should be as easy as:
$ git clone https://github.com/insanum/gcalcli
$ cd gcalcli
$ pip install .

Of course if you don't want to install in your system's libraries, you're encouraged to use a virtualenvironment.  Especially if you're doing git clone of master in this repo, as it's currently undergoing a bit of refactoring.
If you get a change to properly install gcalcli master and are still having errors, I'd love to know!

Joshua Crowgey<EMAIL_ADDRESS>writes:

It should be as easy as:
$ git clone https://github.com/insanum/gcalcli
$ cd gcalcli
$ pip install .
Of course if you don't want to install in your system's libraries, you're encouraged to use a virtualenvironment.
Especially if you're doing git clone of master in this repo, as it's currently undergoing a bit of refactoring.
If you get a change to properly install gcalcli master and are still having errors, I'd love to know!

Thanks for your reply. I tries your steps but still failed:
deyke@deyke2> cd tmp                                                          ~
deyke@deyke2>  git clone https://github.com/insanum/gcalcli               ~/tmp
Cloning into 'gcalcli'...
remote: Counting objects: 1223, done.
remote: Compressing objects: 100% (97/97), done.
remote: Total 1223 (delta 85), reused 129 (delta 59), pack-reused 1063
Receiving objects: 100% (1223/1223), 2.29 MiB | 25.00 KiB/s, done.
  It's odd that the result would be 'invalid command' from setuptools, so I'm curious which version of python you're running.
You might just create a virtualenv and test pip install there.
Alternatively, you might try
python setup.py install

(as suggested in the README), I still think you'll need elevated privileges if you're installing to a system location.  I believe that you can use setuptools with --prefix to install to a specific directory, but you probably need to look up the specific flag, it may not be --prefix
In any case, once you install it, you'll find a man page and a command line tool gcalcli, just like in earlier versions.  Ie, you don't need to call gcalcli/gcalcli.py, you can just use the command line tool on your $PATH.
Let me know if you're able to install.

Joshua Crowgey<EMAIL_ADDRESS>writes:

So, I think that if you want to pip install into your system's python, you'll probably have to sudo (or the equivalent
on your OS). It's odd that the result would be 'invalid command' from setuptools, so I'm curious which version of python
you're running.
You might just create a virtualenv and test pip install there.
Alternatively, you might try
python setup.py install
(as suggested in the README), I still think you'll need elevated privileges if you're installing to a system location. I
believe that you can use setuptools with --prefix to install to a specific directory, but you probably need to look up
the specific flag, it may not be --prefix
In any case, once you install it, you'll find a man page and a command line tool gcalcli, just like in earlier versions.
Ie, you don't need to call gcalcli/gcalcli.py, you can just use the command line tool on your $PATH.
Let me know if you're able to install.

My system is Debian testing, running python 2.7.15. Since debian is
using apt for all package management, I do not like the idea of using
pip or any other additional package management system, or installing
anything into system locations. But finally I got successful doing
python setup.py install --prefix ...
So thank you again for your help, and please close the issue.
Dieter Deyke
<EMAIL_ADDRESS>Get my Gnupg key:
gpg --keyserver keys.gnupg.net --recv-keys B116EA20

Great!
And, fwiw, gcacli is in debian already so you can just apt-get install debian (and you'll get a more stable version than what's going on in master right now).
If you want to help test my changes in master, you can use a virtual environment.  On debian, you can apt-get installl python-venv and then you'll be able to create a virtual envionment with
python -m venv venv


Changes to use httpxx in a CMake super project

HI @eile , thanks for taking the time to contribute this!  Looks like your build is failing, can you check the Travis-CI log?  If it passes, I'll merge it :-)

Working on it. Seems due to an old cmake version on the Travis node - any chance you upgrade to Ubuntu 14.04 from the current 12.04?

Btw, in https://github.com/eile/CMake/blob/master/Findhttpxx.cmake is a find script for downstreams. The right solution would be to use the cmake EXPORT magic, but for this to work smoothly cmake 3 is required, and both httpxx and http-parser have to be tweaked, which I could not be bothered with.

ping

Thanks for contributing this :-)

Thanks - FYI we will start using it soon for HBPVIS/zeq#115


Evidence Count and Belief Filters

This PR was originally the implementation of the weighted ORA but I did a couple other things that need less work so I've renamed this PR for it. This PR does the following:

Enable choosing which dataset you want (e.g., GO, Reactome WikiPathways, INDRA-upstream, INDRA-downstream) in the continuous GSEA page
Add minimum evidence count field to all three analyses
Add minimum belief field to all three analyses

@bgyori we got a sigkill on the tests :/ probably not related to this PR though

I just checked all of the tests are passing locally so I'm going to start the merge train


[nz-input] textarea can't use undo/redo , but basic nz-input can at firefox

Reproduction link
https://stackblitz.com/edit/ng-zorro-antd-ivy-vknmbx?file=src/app/app.component.ts
Steps to reproduce
use minimal reproduction link.
What is expected?
nz-input box can use undo/redo normally.
What is actually happening?
nz-input box can't use undo/redo normally.

Environment
Info

ng-zorro-antd
12.0.2

Browser
Firefox 94.0.1(64 bit)

Thanks for your report, it's caused by nzAutosize, we will fix it and feel free to contribute code if you wish :)


Fixed text annotation comb input box

I have tried to address issue #12865. Please look at it and suggest changes if any.

So basically a CSS focus event style was modifying the input box width whenever the input box got focus. It modified the width from 100% to 115%. According to a comment in there, it was done to adjust the letter spacing of the characters in that input box. I have reduced the expanded width from 115% to 103% and it works fine now and passes all the test unit tests/reference image test.

/botio-linux preview

I did a quick check with my original PDF file and so far it looks like this works. Note that this is dynamic behavior that the tests can't cover, so because we have to rely on manual testing here I'd like to take some more time to play with more PDFs later to make sure it works in all scenarios.

I get your point

I did a quick check with my original PDF file and so far it looks like this works. Note that this is dynamic behavior that the tests can't cover, so because we have to rely on manual testing here I'd like to take some more time to play with more PDFs later to make sure it works in all scenarios.

I get your point. I have checked in some sample PDFs from my side as well, seems fine. Let me know if you find any malfunction.

Hey, any updates?

Thank you for your contribution!


test-branch/execute-job/wrong-commit-sha-on-pr/d6295f0e-b002-4d68-b80c-97618678d1ea

PR for testing ff56b9a50cb22a1dcf603277550c66e6e82ef08b

/canonical/self-hosted-runners/run-workflows 931ad21dd9ace68aaa0a7d341e94de96ad93fa6b


Fix for looking up bucket locations in S3 Acceleration endpoints

Attempting to lookup a bucket via the s3-accelerate.amazonaws.com host
returns an Error 400. Fall back to looking up with the us-east-1 endpoint.
Closes #576

LGTM.

Thanks! Could you release a new version soon?

This only work if the accelerate bucket is located in us-east-1.
Can we make minio respect aws environment variables? e.g. AWS_REGION

This only work if the accelerate bucket is located in us-east-1.
Can we make minio respect aws environment variables? e.g. AWS_REGION

There is no reason we need to do that you can initialize with the correct region yourself
minio.NewWithRegion(...., os.Getenv("AWS_REGION"))


Remove cyclic dependency among cloud-api-adaptor and peerpod-ctrl

As explained by @yoheiueda in https://github.com/confidential-containers/cloud-api-adaptor/pull/1110#issuecomment-1603914981 currently we have a cyclic dependency among the cloud-api-adaptor and peerpod-ctl go modules. He also suggest the creating of a cloud module could break the cycle.
Usually cyclic dependency signals something is wrong with API design.
Cc @stevenhorsman

Hi @bpradipt, I'll take this up.

So will we have separate repositories called controllers?

@surajssd My original intention was to create a new Go sub module under the same cloud-api-adaptor GitHub repo.
So, the list of the Go modules will look like this. Each module has  its own go.mod file.

github.com/confidential-containers/cloud-api-adaptor
github.com/confidential-containers/cloud-api-adaptor/cloud ← New module
github.com/confidential-containers/cloud-api-adaptor/peerpod-ctrl
github.com/confidential-containers/cloud-api-adaptor/peerpodconfig-ctrl
github.com/confidential-containers/cloud-api-adaptor/volumes/csi-wrapper
github.com/confidential-containers/cloud-api-adaptor/webhook

I think separating controller code into other repositories is another topic, but I also think it is an reasonable option to consider.

So will we have separate repositories called controllers?
What will make release process easier ?

So if we have the following structure, will it help with release and ongoing maintenance ?
github.com/confidential-containers/cloud-api-adaptor
github.com/confidential-containers/cloud-api-adaptor/cloud ← New module
github.com/confidential-containers/cloud-api-adaptor/volumes/csi-wrapper
github.com/confidential-containers/cloud-api-adaptor/webhook
and
github.com/confidential-containers//{peerpodconfig-ctrl, peerpod-ctrl}
Both peerpodconfig and peerpod controllers are independent of each other, so can be in one repo. But should we keep this in their own repo for ease of release management and maintenance ?

@bpradipt I think it will work in the perspectives from Go modules
Please note that the repositories will still have mutual dependencies, since the first repo contains both cloud-api-adaptor and cloud-api-adaptor/cloud modules, and there are dependencies below.
peerpod-ctrl → cloud-api-adaptor/cloud
cloud-api-adaptor → peerpod-ctrl
This means that we will still need to be careful when we prepare release tags.

This dep will still create issues
peerpod-ctrl → cloud-api-adaptor/cloud
cloud-api-adaptor → peerpod-ctrl

Do you have any thoughts on how this cyclic dep between CAA and peerpod-ctr be avoided ?
Should we look at a extracting out the cloud module in a separate repo which then gets imported in CAA and peerpod-ctrl ?

@bpradipt
We can create a Git tag per Go modules in a single repository as described in https://github.com/confidential-containers/cloud-api-adaptor/issues/852 and here https://github.com/confidential-containers/cloud-api-adaptor/blob/main/docs/Release-Process.md#tags-and-update-go-submodules
For example, we can create two tags v0.8.0 and cloud/v0.8.0. The first one is used to specify the version of the Go pacakge github.com/confidential-containers/cloud-api-adaptor, and the second one is used to specify the version of github.com/confidential-containers/cloud-api-adaptor/cloud.
Each tag can refer to a different commit, so we can create Git tags and update go.mod in the following order.

cloud-api-adaptor/cloud
peerpod-ctrl
cloud-api-adaptor

Another possible solution is to move the peerpod-ctrl/api/v1alpha1 pacakge from peerpod-ctrl to cloud-api-adaptor. This package is generated one, and referenced from both the cloud-api-adaptor binary and the controller binary.

This issue come up over and over again every time we make a release, and that is the case for v0.8.0.
Let's see if I understood yoheiueda's proposal below and maybe we can reach on a consensus to finally fix it.

@bpradipt
We can create a Git tag per Go modules in a single repository as described in #852 and here https://github.com/confidential-containers/cloud-api-adaptor/blob/main/docs/Release-Process.md#tags-and-update-go-submodules
For example, we can create two tags v0.8.0 and cloud/v0.8.0. The first one is used to specify the version of the Go pacakge github.com/confidential-containers/cloud-api-adaptor, and the second one is used to specify the version of github.com/confidential-containers/cloud-api-adaptor/cloud.
Each tag can refer to a different commit, so we can create Git tags and update go.mod in the following order.
1. cloud-api-adaptor/cloud

Step 1. Create the cloud/v0.8.0 tag

2. peerpod-ctrl

Step 2. peerpod-ctrl -><EMAIL_ADDRESS>cd peerpod-ctrl
go get<EMAIL_ADDRESS>
Open a PR and merge.

3. cloud-api-adaptor

Step 3. cloud-api-adaptor -><EMAIL_ADDRESS>go get<EMAIL_ADDRESS>
Open a PR and merge.
step 4. Would be cloud-api-adaptor -> peerpod-ctrl IIUC. Here I got confused. What tag to use?
Step N. There is also the volumes/csi-wrapper -> cloud-api-adaptor

Another possible solution is to move the peerpod-ctrl/api/v1alpha1 pacakge from peerpod-ctrl to cloud-api-adaptor. This package is generated one, and referenced from both the cloud-api-adaptor binary and the controller binary.

JT has suggested that we might be able to do some of the cloud module separation in #1508

This issue blocked #1706 I will work on this item and try to work out a fix.

@liudalibj can we move peerpod-ctrl peerpodconfig-ctrl to separate repo as it'll fix the cycling dep issues ?

@liudalibj can we move peerpod-ctrl peerpodconfig-ctrl to separate repo as it'll fix the cycling dep issues ?

Move peerpod-ctrl peerpodconfig-ctrl to separate repo won't fix the cycling dep issue.
the root cause for the cycling dep issue:

cloud-api-adaptor -> peerpod-ctrl https://github.com/confidential-containers/cloud-api-adaptor/blob/main/pkg/adaptor/k8sops/peerpod.go, caa need "github.com/confidential-containers/cloud-api-adaptor/peerpod-ctrl/api/v1alpha1"

peerpod-ctrl ->  cloud-api-adaptor https://github.com/confidential-containers/cloud-api-adaptor/blob/main/peerpod-ctrl/controllers/peerpod_controller.go, peerpod-ctrl need "github.com/confidential-containers/cloud-api-adaptor/pkg/adaptor/cloud"

So the possible two fixes from @yoheiueda :

New a module: "github.com/confidential-containers/cloud-api-adaptor/cloud",
Then the dep will looks like:

1. peerpod-ctrl → cloud
2. cloud-api-adaptor → peerpod-ctrl (→ cloud)
3. csi-wrapper → cloud-api-adaptor (→ peerpod-ctrl → cloud)

move the peerpod-ctrl/api/v1alpha1 pacakge from peerpod-ctrl to cloud-api-adaptor.
Then the dep will looks like:

1. cloud-api-adaptor
2. peerpod-ctrl → cloud-api-adaptor
3. csi-wrapper → cloud-api-adaptor

After we break the cycling dep, I agree we move peerpod-ctrl peerpodconfig-ctrl to separate repo.
If we choose option 1, then we will have three new repos:

github.com/confidential-containers/peerpod-ctrl
github.com/confidential-containers/peerpodconfig-ctrl
github.com/confidential-containers/cloud(peerpod-providers maybe is better?)

New repos are fine as it will help us with dev and release cadence imho.

I will try to prepare fix codes base on new repos.

@liudalibj - in case it ins useful JT created an draft PR to try and help with this: https://github.com/confidential-containers/cloud-api-adaptor/pull/1583

@liudalibj - Do you think this can be closed now that #1719 has merged?

Yeah, we can close this.


add code coverage banner in readme

Just add the code coverage banner in README page as well as travis ci one. See what it will like in my Azkaban README page at https://github.com/kunkun-tang/azkaban/blob/master/README.md

Pull Request Test Coverage Report for Build 3816

0 of 0   changed or added relevant lines in 0 files are covered.
6 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.02%) to 35.696%

Files with Coverage Reduction
New Missed Lines
%

azkaban-exec-server/src/main/java/azkaban/execapp/JobRunner.java
6
76.67%

Totals

Change from base Build 3815:
-0.02%

Covered Lines:
10117

Relevant Lines:
28342

💛  - Coveralls


Get user outside a service

How to get current connected user outside a service ?
I have this code :
app.configure(hooks())
  .configure(rest())
  .configure(socketio())
  .use(actionsHandler)
  .configure(services)
  .configure(middleware);

And in my actionsHandler after login req.feathers = only { provider: 'rest' } and req.isAuthenticated() = false
My auth config is the following:
{
  auth: {
    idField: 'id'
  }
}

And I connect like this:
    app.authenticate({
      type: 'local',
      email: data.email,
      password: data.password
    }).then(result => {
      console.log(app.get('token')); // -> the JWT
      console.log(app.get('user')); // -> the user

      return result;
    })

ps: The cookie is never after login

I am not sure what you mean? app.get('user') on the client seems to do what you are asking right?
On the server for each method call the user that makes it is stored in params.user (when the authentication hooks are set).

I have 2 parts, one with feathers and another before that manages other actions (not REST), and I wish I could have access to the user connected when I am not in service and I do not have access to the hooks.
After login I have the current user, my goal is to be able to recover after a refresh of the page and the server side rendering which is enabled

This will be possible in the next version but for now you should be able to use the decode-token and populate-user Express middleware from that version.

I saw decode-token Express middleware but I don't have  req.feathers.token, so I also looked in token-parser and set-cookie middleware and I had not seen the option cookie.enable, I try it as soon as possible and put my back here

@bertho-zero, If you're feeling brave, you can also try installing the pre-release version of<EMAIL_ADDRESS>and check out the example folder in the 0.8.0 branch to see how to implement it.

It works well in real-time but not in rest, I don't understand..
I have :
app.authenticate({
      type: 'local',
      email: data.email,
      password: data.password
    }).then(result => {
      console.log(app.get('token')); // -> the JWT
      console.log(app.get('user')); // -> the user

      return result;
    })

and both console.log write null.
I continued to seek the cause

I solved the problem with the following authentication config :
...
local: {
  successHandler: authConfig => (req, res, next) => {
    delete res.data.user.password;
    next();
  }
...
}

Otherwise I lose the user and the token during the redirect, then I set the cookie with js-cookie in client side for remember session after page refresh, this is maybe due to node-http-proxy, I tested this:
cookies: {
  enable: true,
  'feathers-jwt': {
    maxAge: 60 * 60 * 24 * 1000 // One day
  }
}

I use it in this repo: https://github.com/bertho-zero/react-redux-universal-hot-example/

I can connect, edit a client-side cookie and remain connected to refresh the page, but the socket that reconnects, he is not identified with the user.
Would you know how to reconnect the socket to the current user?

@bertho-zero I think this is what you need: https://github.com/feathersjs/feathers-authentication/issues/272#issuecomment-240937322

Thanks, what I would like is not on a basic connection but a new connection after refresh the page.
I tried the same thing at on.('connect', ...) in vain, I've the following log in client:
socket.io-client:manager writing packet {"type":2,"data":["authenticate",{"type":"token","token":"eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpZCI6MSwiaWF0IjoxNDcxOTY3NTg4LCJleHAiOjE0NzIwNTM5ODgsImlzcyI6ImZlYXRoZXJzIiwic3ViIjoiYXV0aCJ9.EqkOQp5W62d1hHv7jRvlW1BICiA5UvQ91AfRiynhTw4"}],"options":{"compress":true},"nsp":"/"} +10ms
socket.io-parser encoding packet {"type":2,"data":["authenticate",{"type":"token","token":"eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpZCI6MSwiaWF0IjoxNDcxOTY3NTg4LCJleHAiOjE0NzIwNTM5ODgsImlzcyI6ImZlYXRoZXJzIiwic3ViIjoiYXV0aCJ9.EqkOQp5W62d1hHv7jRvlW1BICiA5UvQ91AfRiynhTw4"}],"options":{"compress":true},"nsp":"/"} +1ms
socket.io-parser encoded {"type":2,"data":["authenticate",{"type":"token","token":"eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpZCI6MSwiaWF0IjoxNDcxOTY3NTg4LCJleHAiOjE0NzIwNTM5ODgsImlzcyI6ImZlYXRoZXJzIiwic3ViIjoiYXV0aCJ9.EqkOQp5W62d1hHv7jRvlW1BICiA5UvQ91AfRiynhTw4"}],"options":{"compress":true},"nsp":"/"} as 2["authenticate",{"type":"token","token":"eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpZCI6MSwiaWF0IjoxNDcxOTY3NTg4LCJleHAiOjE0NzIwNTM5ODgsImlzcyI6ImZlYXRoZXJzIiwic3ViIjoiYXV0aCJ9.EqkOQp5W62d1hHv7jRvlW1BICiA5UvQ91AfRiynhTw4"}] +1ms
...
engine.io-client:socket socket receive: type "message", data "20["unauthorized",{}]" +11ms
socket.io-parser decoded 20["unauthorized",{}] as {"type":2,"nsp":"/","id":0,"data":["unauthorized",{}]} +1ms
socket.io-client:socket emitting event ["unauthorized",{}] +1ms

Yet this is the same token for the http connection when retrieve the page, I do this in the client:
socket.on('connect', () => {
  app.authenticate();
});

And I've the following configuration:
auth: {
  user: {
    idField: 'id'
  },
  local: {
    successHandler: () => (req, res, next) => next // for login with rest provider, jump redirection
  },
  token: {
    secret: 'super secret'
  },
  cookies: {
    enable: true
  }
}


Add MiniMagick v5.0

Since MiniMagick v5.0 has been released, add types.
https://github.com/minimagick/minimagick/tree/v5.0.1
The README includes the following usage example,
but methods such as resize and format do not exist and there are hacked by method_missing.
image = MiniMagick::Image.open("input.jpg")
image.path
image.resize "100x100"
image.format "png"
image.write "output.png"

Since it is not possible to determine whether a method can be used or not depending on the version of ImageMagick being used, methods that are hacked with method_missing are not defined in the collection.

/merge


fix: typo in fund_bots

PR https://github.com/delvtech/elf-simulations/pull/825 incorporates this change. Nice catch!


spin-2 SHTs

Preliminary support for QU to EB map2alm.

Codecov Report

Merging #30 (efd6006) into main (685ef18) will decrease coverage by 3.04%.
The diff coverage is 40.81%.

@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
- Coverage   68.57%   65.52%   -3.05%
==========================================
  Files           4        4
  Lines         420      467      +47
==========================================
+ Hits          288      306      +18
- Misses        132      161      +29

Impacted Files
Coverage Δ

src/transforms.jl
69.52% <40.81%> (-25.31%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 685ef18...efd6006. Read the comment docs.