Update dev dependency "rollup"

Our repo is currently using<EMAIL_ADDRESS> A new major version<EMAIL_ADDRESS>was released on 3/6/2020.  The upgrade may require significant changes.
https://github.com/rollup/rollup/blob/master/CHANGELOG.md#200

(CC @bterlson for discussing Node 8 support)
Major blocker here is

Rollup now requires at least Node 10 to run, or a sufficiently modern browser (#3346)

In order to make the migration to Rollup 2 we'd need to move the Linux pipeline build off of Node 8. Nothing else in the changelog really sticks out at me, but there's always a chance there would be other complications too.
@mikeharder @praveenkuttappan One thing that could work here is if we could do all the builds in CI with Node 12 and then only do test runs with our different node versions. Is this something we can do easily or is everything in the pipeline run with the same base node configuration.

@mikeharder @praveenkuttappan One thing that could work here is if we could do all the builds in CI with Node 12 and then only do test runs with our different node versions. Is this something we can do easily or is everything in the pipeline run with the same base node configuration.

This is already done: https://github.com/Azure/azure-sdk-for-js/pull/8804

Currently blocked on an upstream bug in @rollup/plugin-commonjs: https://github.com/rollup/plugins/issues/743
Migrating to rollup 2 and the newer versions of plugin-commonjs will ease the transition to the shared rollup configuration, so this is related to that as well.

Currently blocked on an upstream bug in @rollup/plugin-commonjs: https://github.com/rollup/plugins/issues/743
Migrating to rollup 2 and the newer versions of plugin-commonjs will ease the transition to the shared rollup configuration, so this is related to that as well.

Spoke to @witemple-msft - he's looking into this so he OK'd assigning it to him for now

closing in favor of bot-auto-created #19235.


A question on the usage of TwistPublisher.cs

Hi all,
May I please ask how to use TwistPublisher.cs to publish data from Unity to ROS? It's not demonstrated in any of the tutorial videos. I did check out the code and I take a guess that I first create a game object in unity and then use its transform component(in the beginning of this code I see  public Transform PublishedTransform;) as an input to TwistPublisher.cs. Finally, the linear and angular velocity of this game object is converted into twist message by using TwistPublisher.cs. Am I right? If not, can you please kindly show me the right way to use this snippet of code? thx a lot
Could you please explain a bit about the following two lines of the code? I think that is where I get stuck. Thank you so much.
            message.linear = GetGeometryVector3(linearVelocity.Unity2Ros()); ;
            message.angular = GetGeometryVector3(- angularVelocity.Unity2Ros());
```why minus before angularVelocity and what exactly does Unity2ROS do？Thanks

Problem solved. What I expected is right the way how you can use TwistPublisher.cs


feat(chore): generate detailed and informative changelog

Using Customizable npm package to generate changelog
GH-85
Description
Using Customizable npm package to generate changelog
The changelog will be more detailed
Fixes #85
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Intermediate change (work in progress)

Checklist:

[x] Performed a self-review of my own code
[x] npm test passes on your machine
[ ] New tests added or existing tests modified to cover all changes
[ ] Code conforms with the style guide
[ ] API Documentation in code was updated
[ ] Any dependent changes have been merged and published in downstream modules

:tada: This PR is included in version 4.2.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Versions issue when using RollupWithDependencies

Hi all,
After struggling with this issue for a while I was finally able to understand what it was about. Every time I tried to use commonjs as described in the guides I got the following error:
Build Error (RollupWithDependencies)

parse is not a function in /Users/jorgelainfiesta/my-app/tmp/rollup_with_dependencies-cache_path-NNQTQ4qh.tmp/src/index.js

Stack Trace and Error Report: /var/folders/lg/7k9tn7x55k1_g2prg29r9ptw0000gn/T/error.dump.6a6e7c7fe5a7df21234c91b87e937fef.log

I found an analogue issue in ng-packager from last year (https://github.com/dherges/ng-packagr/issues/657).
It seems like glimmer-application-pipeline version for rollup causes conflicts when installing the most recent rollup-plugin-commonjs.
As a reference, this project uses rollup 0.41.6 and the current version at the time of posting this 0.57.1. For rollup-plugin-commonjs the latest version is 9.1.0; downgrading to 8.3.0 makes the build work.

Thanks for the solution. Downgrading to 8.3.0 also fixed it for us.


Can't execute 'run' task with retrolambda

I have a root project which uses the application plugin and sub-projects as dependencies. When I try to execute the run task, I got the following error:

09:37:21: Executing external task 'run'...
FAILURE: Build failed with an exception.

What went wrong:
Could not determine the dependencies of task ':run'.

Task with path 'compileRetrolambda' not found in root project 'dte-desktop'.

My plugins block (in root project):
plugins {
    id 'java'
    id 'application'
    id 'com.github.johnrengelman.shadow' version '1.2.3'
    id 'me.tatarka.retrolambda' version '3.2.5'
}

I don't know if it's a bug or an issue on my side, do you have any clue ?

When I look at source code, I can see this :
project.plugins.withType(ApplicationPlugin) {
    project.tasks.findByName('run').dependsOn('compileRetrolambda')
}

But I don't see any task with that name. Instead tasks are named from their source sets name. I have a compileRetrolambdaMain task for example. Do you know how to fix this ?

There used to be a "compileRetrolamba" task. It was removed in https://github.com/evant/gradle-retrolambda/commit/99ec75680167dc02782965ce2c81a805d13e3d81#diff-5f7ee02bd827ee69b5f8dc3c5e5ce70f looks like the run task wasn't updated.

I don't think we need a special behavior for the application plugin, it depends on the java plugin.

Probably not any more. Originally the task dependency graph was set up a bit differently making that line required.


Typing indicator Info

I don't see anything typing indicator related in the docs.
My program is sending a tying indicator for every character typed, but that's not right, so I was thinking maybe it should be as long as you have something in the input bar, send it once.
Is there a need for untyping function ? if so any way to do it?
Another question is, yes great we can say we're typing, but what about someone else typing to us?

did you read documentation?
https://github.com/Schmavery/facebook-chat-api/blob/master/DOCS.md#sendTypingIndicator
sendTypingIndicator returns function that will hide typing indicator when called
e.g.
var end = api.sendTypingIndicator("0000000000", () => { ... });
setTimeout(end, 2000);

but AFAIK we can't (yet!) check other people's indicators

update:
if you use api.setOptions({listenEvents: true}); before api.listen(); you will get event of type typ

@ravkr that's what it is, thanks, there was nothing about api.setOptions()
Thanks again 🥇


Implement Docker build and push functions

User Story
Developers build their own applications and store them in the repository. The repository is prepared in advance.
Acceptance Criteria

Simple implementation of the artifact plugin mechanism through the Go language interface.
Plugins for Docker builds to be implemented.
NOT require jobs and plugins to run on Docker.
NOT require separation of CLI, job, and plugin source code.

Design & Specification
The dacrane.yaml file should read as follows
kind: artifact
name: api
provider: docker
parameters:
  image: sample-api
  tag: latest
  dockerfile: ./Dockerfile
  repository:
    url: url
    user: user
    password: password

The build command builds a container image with local docker.
$ dacrane build [artifact]

The “publish" command publishes a container image to the specific registry. Container images must be built.
$ dacrane publish [artifact]

The “list” command displays a list of container image versions.
$ dacrane search versions [artifact]

The “unpublish” command removes the specific container image version from the local and remote registry.
$ dacrane unpublish [artifact]

implemented.


Can't build iOS, using version 1.2.4

Hi @whitedogg13,
I'm using expo (ejected to expokit) sdk-33.0.0 and using "react-native-nfc-manager": "^1.2.4", I can't build in iOS, getting multiple errors. the first one is:
Semantic Issue Group
~/node_modules/react-native-nfc-manager/ios/NfcManager.h:17:31: Unknown type name 'NFCTagReaderSession'; did you mean 'NFCReaderSession'?
There are several more build errors but they all pretty much relate to a similar issue.
It does build without a problem in Android though.
Tried using "react-native-nfc-manager": "^2.0.0-beta.1" and it does build in iOS but stops working in Android because of Androidx dependencies.
Please help!

@marioelt Thanks for reporting.
Looks like I have accidentally put some iOS 13 related code into that release. Please use 1.2.2 instead for now before I fix it. Otherwise, you will need to use XCode 11 beta to pass the build.
Thanks!


ENH: Bèzier Fitting  Usability Improvements

This closes #206
This closes #207
This closes #209
This closes #211

There have been some conflicts with Qt ui files in #develop when ALive-research/Slicer-Liver#218 was integrated. I have created a new branch with a tentative solution in the #Slicer-Liver:feature/updating_fitting branch.
@dalbenzioG, @RuoyanMeng, please give it a check to that branch to make sure that none of your latest changes was broken by it and let me know how that worked out.

This is superseded by ALive-research/Slicer-Liver#234

Due to git conflicts, this is superseded by ALive-research/Slicer-Liver#234


Not working on Real World Image

I tried this network on real world image but it didn't worked. I am attaching the gist and link to image also attached in the colab notebook itself. Did I missed something or model failed?

hi! how to add Gaussian blurring in the process()? @ zzxvictor

hi! how to add Gaussian blurring in the process()? @ zzxvictor

You can add it to the data processing pipeline. Here's the documentation for Gaussian Blurring by OpenCV: https://docs.opencv.org/master/d4/d13/tutorial_py_filtering.html

You can add it to the data processing pipeline. Here's the documentation for Gaussian Blurring by OpenCV: https://docs.opencv.org/master/d4/d13/tutorial_py_filtering.html

There are any news on this aspect? @tulasiram58827

It seems like it is definitely over-fitting because there is no way a model can extract characters from a jumbeled mess of pixels that even no human could...
Most likely there must have been some train/test leakage.


Default to case-insensitive filtering and searching (MongoEngine)

The ability to do case-insensitive filtering and searching with MongoEngine was added with pull request #177. Preceding the search term with an asterisk made the query case insensitive.
This change is to make case insensitive the default. The aim is to match the usual behavior of search boxes on web sites and operating systems.
In order to do this while keeping case-sensitive capability, the asterisk now means the opposite: case sensitive.

seems bad to change default behavior after all these years, but it should have been case insensitive by default. however, using asterisk to mean the query is case sensitive is really weird to me... surely we should have used something else as a flag, so as to remain backwards compatible instead if literally inverting the expected behavior.


Convert JavaGrpcClientPipeline to use Packman

[Current coverage][cc-pull] is 68.14%

Merging [#38][cc-pull] into [master][cc-base-branch] will decrease coverage by 2.22%

@@             master        #38   diff @@
==========================================
  Files            28         28
  Lines           854        854
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits            601        582    -19
- Misses          253        272    +19
  Partials          0          0

Powered by Codecov. Last updated by [51d1a32...3551fde][cc-compare]
[cc-base-branch]: https://codecov.io/gh/googleapis/artman/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/googleapis/artman/compare/51d1a32cd0484bd8f3c240672565492abf631272...3551fde8a25d89a0805dcdeb5726fbf9994c7ae6
[cc-pull]: https://codecov.io/gh/googleapis/artman/pull/38?src=pr

Nice!
Is the real output of running the the pipeline the same as the old pipeline?

Hm... I'd expect the packman command to generate additional metadata files, but at least the compiled proto files should be the same. Let's confirm that the differences are expected before merging this.

@geigerj @ethanbao PTAL. Shin confirmed that running uploadArchives with the build.gradle generated by packman with the "experimental_alt_java" flag produces a maven package that works with gcloud-java. You will need to pull the latest version of packman for this to work.

LGTM

I don't see any issues in dev mode but it would be nice if we don't change the path. I think /src/main is a convention to put source code in java.

Actually switching from src/main/ to other directory may cause some compile issues in maven.

@shinfan maven building is actually fine because we point the source set to /build/generated directory (https://github.com/googleapis/packman/blob/master/templates/java/build-alt.gradle.mustache)

LGTM

@ethanbao PTAL. removed package_dir task.

LGTM
Thanks!


Ctrl shortcuts no longer work in editor after an error is raised

Godot version:
3.0 >
OS/device including version:
Windows 10 64 bit
Issue description:
After some work the editor doesn't recognise key combination with ctrl. (ctrl+c, ctrl+v, ctrl+s etc)
Steps to reproduce:
I don't know how to reproducing, it's like casual problem after any of this key combination.
After closing and reopening godot work for some time and then the problem reappear.
EDIT: it seems to fail recognising ctrl after the ide show you an error (red background on line with error)

EDIT: it seems to fail recognising ctrl after the ide show you an error (red background on line with error)

what's the error   it gives before it the ctrl shortcuts stop?

I've experienced this as well. I'm also not sure what causes it. If it happens again, I'll check the engine output for an error.

@girng i have no erro in the console

Has this issue been resolved?

Closing due to lack of update. Please comment if you can still reproduce this issue in the latest stable version of Godot.


Inventory GUI looks wrong with ServerUtilities/FTB Utilities and with custom texture pack

Satchels renders serverutilities/ftb utilities icons far away from the inventory when the satchels aren't equipped:

and when satchels are equipped it messes up the texture of my inventory

as you can see, the custom texture pack textures are messed up and some are even on the satchel gui

ServerUtilities added the ability to move around the icons freely, however the texture of the inventory bug is still a problem.


Fix up danger runner

Fix up danger runner
Summary:
Danger fixed the issue we were working around with a command line option
to control behavior. Get rid of hack (which no longer worked anyway)
Test Plan:
This is the test!

I think this MAY be because I'm using sapling. Imma try with git.


Adding commands to close or sleep assistant

if close or exit in command it should stop the execution of the program
and sleep in command it should sleep for 2 minutes.

I would like to work on this.

Go ahead @BAHETIHARSH


The doctrine annotation space fixer should not add spaces before colons for assignments

while adding spaces on both sides of = may make sense (but why space around equals in arrays and no spaces around assignments ? this is a weird rule), I think that : in arrays should have a space only after it, not before, to match common JSON conventions (the syntax using : is inspired by JSON after all)

why space around equals in arrays and no spaces around assignments ?

I couldn't find official conventions about this so I looked at Doctrine Annotation documentation and Symfony documention. Most of the time, they have no space for argument assignments but spaces before and after array assignment. I applied the same rule for array assignments using a colon

I think that : in arrays should have a space only after it, not before, to match common JSON conventions

This behavior could be tweaked by introducing new configuration options to the fixer.

Then OK for spaces around = in arrays. But none of these documentation pages are using : (because it was added only after they were written). And the PR adding support for it was precisely about making it more similar to JSON.

I wasn't aware of that, makes perfect sense.

Closing as #2770 was merged.


update ports for quickstart 6

What issue does this PR address?
update https ports like other quickstarts
Does this PR introduce a breaking change?
no
Please check if the PR fulfills these requirements

[x] The commit follows our guidelines
[ ] Unit Tests for the changes have been added (for bug fixes / features)
n/a

Other information:

thanks!


Only create new virtualenv when explicitly requested

Currently I can't find a way to turn on confirmation prompt before creating a new virtualenv. I often call pipenv shell from the wrong directory and stop it right away, cause it starts to create a new environment. Then I need to remove Pipfile by hand. This is not  convenient. How about adding a confirmation prompt before creating a new venv for some commands like shell or run? Or maybe a --create flag?

If nothing else, it'd be really nice if pipenv required some sort of confirmation before creating a virtualenv for a parent directory since this can be really confusing

@kennethreitz - any chance you could give some background on why you've closed this ticket?

I think the best practice would be to do like npm, and separate the two actions:

pipenv init to create the virtualenv
pipenv install to install

If you pipenv install outside of a virtualenv, we can give a warning, and look for near directory with linked virtualenv to offer as suggestion.
Another bonus with this approach is that it makes adding option to the virtualenv creation much more clean.
E.G: doing pipenv install --python=version is very weird.
You can also more easily add features that are specific to env creation, such as: https://github.com/pypa/pipenv/issues/1472

the current workflow isn't changing, it's designed intentionally.
init was the original design, and it was removed based on user feedback.

In that case considering adding a prompt (#1471) is an nice alternative. I have at least 6 occurrences of wrongly created virtualenv in the last 3 weeks.

not happening

Ok, let's find another to help that problem no occurs then. What do you suggest ?

i suggest you use other software if you're unhappy with the way this software is designed

Well, you said that when I suggested months and months ago we should add an option to choose the python version precisely instead of just --tree/--two and you changed your mind apparently. But I recall you were less rude at the time.
Actually I recalled a humble kenneth I've saw at conferences talking about love and help, and offering explanation or requesting PR, not telling people to go to hell.
But maybe you're having a bad day.

@kennethreitz didn't expect such an attitude from a human.

You're complaining about the more core design feature of the package. Please don't.

Alright. Sorry about that. You have a lot of work and there is not need to eat more of your energy.
Thanks for taking the time to answer the issue anyway.

previously @kennethreitz wrote:

init was the original design, and it was removed based on user feedback.

It sounds as if the user base may be changing from "early adopters" to "typical users".
I never thought I'd say this, but git got this UX right (well, all VCS systems, actually). In most workflows, it is an extremely rare event to create a new pipenv environment. About as often as creating a new repository. Not having a way to express user intention, either by a different command (init), or an option (--create) can lead to confusing behavior for newcomers to the tool.
Would you be open to a PR that cleanly implemented a way for users to express their intention, assuming it did not break the core architecture?

It frustrates the hell out of me, too, when I accidentally run pipenv from the wrong folder.  In lieu of a proper solution, I've added this to my shell RC file:
function pipenv() { python3 -m pipenv --venv 1> /dev/null && python3 -m pipenv "$@"; }

It could no doubt be improved, but I find that creating a new environment is uncommon enough that I don't mind typing python3 -m pipenv sync ... or whatever.  It's not something you can easily offer when teaching students either.  But it improves my life a tiny bit, and it may help others.


[Feature Request] Support for Vue 3

Existing Component
Yes
Component Name
All Element UI
Description
Current Version of Element UI 2.13.2 doesn't work on Vue 3
It is very important for Element UI to be first Library to support Vue 3 and for companies that would like to get benefits of new Vue 3 features

还没看到相关计划，感觉element-ui维护有点玄

https://github.com/kkbjs/element3

看了一下维护人员 已经离职啦

YES!  🎉🎉🎉 Element Plus - A Vue.js 3.0 UI library 🎉🎉🎉
https://github.com/element-plus/element-plus/issues/147


fix(doc): update search url for documentation

Passes wrong query parameter when open documentation.
Fixes #2731

Oh, it turns out this was already fixed in https://github.com/angular/angular-cli/pull/3383, thanks for helping out though!


Question: Default_scope?

Hey, do you think is possible to integrate the default_scope of active record?
Thanks
ps: I can try to make a PR

I think we're always open to PR's like this


Merge multi_arg extensions

This has a few conflicts, but I should be able to fix them; basically we simply want to take the version from the branch.

Conflicts fixed.


private network by pnet

https://github.com/libp2p/js-libp2p-examples/tree/main/examples/js-libp2p-example-pnet

https://github.com/cyberfly-io/cyberfly-node/commit/e47a536369a98f4cc46a1f2f2be3579f14bc54f8


Add package-to-file location evidence relationships

Each package tracks which files contributed to syft being able to detect the package's existence via the pkg.Package.Locations field. This PR exposes these locations as package-to-file relationships to show that package X is "evident by" file Y. This is made possible with the new evident-by relationship type, which maps to the OTHER SPDX relationship type and depends on a comment value to support decoding effectively.
The current implementation blindly takes all pkg.Package.Location values and makes relationships for them. This is nice since there is a single, downstream point in the code that would be responsible for creating these relationships. One possible downside of this is files that played a minor role in understanding some data about the package (say a LICENSE file to determine the license on the package) are even-keel to files that played a major role about the majority of the package's data (such as the RPM DB location, or package-lock.json file).
This PR also:

Fixes a small problem where decoding SPDX relationships of the type OTHER meant for "ownership-by-file-overlap" was interpreted as "dependency-of" instead
Fixes #1534 since this PR adds file nodes to the SBOM which would not be able to be interpreted on multiple encode-decode-encode cycles) which would fail the encode-decode-encode integration test (specifically for the syft json format).

CC: @jedevc @cdupuis

For interested folks, this PR will be refactored to use location annotations being introduced in #1723 and allow for expressing only primary evidence.

JSON schema diff for reviewers:
# ❯ diff schema/json/schema-7.1.3.json schema/json/schema-7.1.4.json
571a572,574
>         },
>         "size": {
>           "type": "integer"
580c583,584
<         "mimeType"
---
>         "mimeType",
>         "size"


X570 w/5900X - fatal boot loop on install

About 5 seconds into the installer booting up it gets stuck on the following:
[AHCI][PRT][0900050] Abort Commands::5381:Port 5 - called, deviceWithError 0, errcode = 0xe0030005
I note when I compare the config.plist generated by OpCore-Simplify to the current Dortania guide the generated config closely follows the guide, but not entirely.
Any guidance of where to start troubleshooting this problem would be much appreciated!

CPU:

AMD Ryzen 9 5900X 12-Core Processor: Up to macOS Sequoia 15

GPU:

AMD Radeon RX 6800 XT: Up to macOS Sequoia 15

Connected Monitors: LG ULTRAWIDE (DP), Beyond TV (HDMI)

Sound:

Logitech G933 Gaming Headset: Up to macOS Sequoia 15

Audio Endpoints: Speakers, Microphone

Realtek(R) Audio: Up to macOS Sequoia 15

Audio Endpoint: Speakers

Steinberg UR28M: Up to macOS Sequoia 15

Audio Endpoints: Line, Line

AMD High Definition Audio Device: Up to macOS Sequoia 15

Audio Endpoints: 5 - LG ULTRAWIDE, 4 - Beyond TV

Network:

Intel(R) I211 Gigabit Network Connection: Up to macOS Sequoia 15

Storage Controllers:

FCH SATA Controller [AHCI mode]: Up to macOS Sequoia 15
FCH SATA Controller [AHCI mode]_#1: Up to macOS Sequoia 15
P5 Plus NVMe PCIe SSD: Up to macOS Sequoia 15

Press Enter to continue...

Provide an image showing the error


bugfix: missing "self" in nanodump module

for the error message the object variable should be used

fixed by #578


add website views widget #376

Pull Request Checklist
Solves issue #376
Here is the image of the proposed work:
Before

After

[x] I have added screenshots and videos to show before and after the working of my code.
[x] I have ensured that the screen size is set to 100% while making the video.
[x] I have synced the latest fork with my local repository and resolved any conflicts.
[x] I have mentioned the issue number which I created before making this PR .
[x] I understand that if any the above conditions are not met , my PR will not be MERGED .

@ANSHIKA-26 Please do let me know if the work needs any changes or update.

decrease the size of the widget

Before :

After :

@ANSHIKA-26 , is this fine?

resync your fork , no need for new pr  , this works

@ANSHIKA-26 , updated, pls check


Added support for https and http/2

I added support of HTTPS and HTTP/2 to my server. As far as I can see existing branch for http here does not have options to configure it, so I push my implementation for general use.
HTTP/2 will be only used on HTTPS, because no browser is supporting it over HTTP. Nevertheless we could always use spdy as server, because it will fall back to HTTP/1.1 in case browser does not support HTTP/2. Because of this fallback I don't know if we really need option --disableHTTP2.

Thanks @SunBlack. There's also some work towards HTTP/2 here https://github.com/AnalyticalGraphicsInc/cesium/pull/5317, but the configuration is more basic.
Since this area is still new to me would someone else like to do the first pass here?

I think Austin's stuff is based on my branch here: https://github.com/AnalyticalGraphicsInc/cesium/tree/http2.  To be honest, I'm not sure of the benefit of running http2 locally for Cesium development (which is why I didn't take it further), but maybe it's worth having it as an option.  That being said, we would probably want some keys available so it can be used out of the box without having to pass command line arguments.
I haven't looked at this yet, but I'll try to carve out some time next week.

Well locally you don't need currently http/2. But in some cases you need https for local development if you are working e.g. with GPS and device motions (chrome gives already a warning that using this sensor over HTTP is deprecated and will be not possible in future versions). And if you are using https you can also switch to http/2, because I don't see any contra by using http/2.
Btw.: We are using the server script as base for our public server with some advantage (e.g. http authentification, blocking access to server.js), because I have no preference which server I'm using for static content (and apache2 & http/2 is ugly ;-) ). Even if you are using a server script not basing on example server script it is a good example to other developers what a server could support (not all developers know http/2 and if they take a look into this script they will see that there exists a new version of HTTP protocol)

Sounds like this or some variation of it will be useful.
Once we converge, please also

Update CHANGES.md
Add doc for each option to a new section in https://github.com/AnalyticalGraphicsInc/cesium/blob/master/Documentation/Contributors/BuildGuide/README.md#build-scripts

Makes it really sense to add a new section to Readme.md? Because are already getting help with option -h. If we extend this readme we have two documentation which need to be always synchronized.

@SunBlack for the doc, users need to be able to discover it, and they probably will not with the -h option.  If updating the .md is too much, don't worry about it, and we'll find someone to do it.

I have modified Changed.md now.
@Readme: There is a hint in Reade.md that you can see more options if you enter --help. If someother want to add a documentation for server options there it would be nice - currently I have to many open task, so I have other priorities ;)

Thanks again for your contribution @SunBlack!
No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?
I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.
:earth_africa: :earth_americas: :earth_asia:

Thanks for opening this PR @SunBlack, but unfortunately this isn't a priority for us right now.  We'll revisit something like this when we get back to working on http2 related changes.


question about sbu dataset

I encounter such error when loading sbu_caption dataset.
FileNotFoundError: [Errno 2] No such file or directory: '/root/autodl-tmp/VPG/data/sbu_captions/images/3966232087_47199040c4.jpg'
I guess that some image tags are in the JSON file, but not in image files . Did you encounter this problem when traing? How did you solve it？
Thank you!

I just remove the items in the json files that can not be downloaded successfully.
The code may be like:
import os
import json
l = json.load(open("path/to/json"))
l = [x for x in l if os.path.exists(f"/root/autodl-tmp/VPG/data/sbu_captions/images/{x['image']}")]
json.dump(l, open("path/to/json", "w"))


Neofetch installed in Powershell through scoop: special character apostrophe/single quote in username causes neofetch to fail to run

Description
Due to unfortunate reasons, I have an apostrophe/single quote (') in my username, which is a valid username in Windows even though it is a special character.
OS Version: Windows 11
Powershell version: 5.1.22000.65
I installed neofetch by running scoop install neofetch .  Lets say my Windows username is Jack's. However, after I type neofetch, it says:
/usr/bin/bash: C:\Users\Jacks\scoop\shims\apps\neofetch\current\neofetch: No such file or directory
Notice how it dropped the apostrophe from my username? I am pretty sure this is the reason why it says No such file or directory because the username is wrong.
This is not a problem with scoop, as I also installed git through scoop and it runs fine.

[x] Does this issue still occur in the master branch? (Required if issue)

Neofetch version
7.1.0
Screenshot

Config file
Defaults
Verbose log
https://pastebin.com/r1Z9Jpd0

Okay so I fixed this by  changing the neofetch.ps1 file which is generated in ~\scoop\shims\apps\neofetch\current\neofetch.ps1
Basically I concatenated the double-quote symbol (") at the beginning and the end of the argument passed as argument to bash.exe in ~/scoop/shimps/apps/git/current/bin/bash.exe
Edited code: https://pastebin.com/J0zTeNAw
Previous code: https://pastebin.com/Z25PPRat
I don't know where to exactly edit the code in the neofetch script file in master branch, which is why I didn't create a pull request

Okay so I don't think this is necessarily the right place for pull request. Who maintains the scoop package for neofetch? I cannot find this info anywhere. Or does this involve the scoop repo?


Pipeline log result in Azure DevOps

Hello,
I don't know if it's the right place to answer, but has anyone struggled with this?
I have a NBi test integrated in Azure DevOps pipeline where I compare 2 queries.
In the pipline logs I get the message: "x (of y) rows have been skipped for display purpose" and I get only 10 rows to view the differences, even if I have maybe more than 100. I don't find any solution to view all rows.
Thank you!

That's the default option when you have more than 25 rows in error only the 10 first are displayed. You can override this setting as explained in the doc about settings.

This page could also help.

Thank you, I already made those changes. I only have the .trx file with test results in DevOps and from the documentation I understand that I need the TestResult.xml where I can find all rows. I couldn’t find it yet.

Updates not very productive :(
In documentation, at "Setup for Data Quality Rules engine" it says "These two settings will enable NBi to always add to the result file some information about the tests in a JSON format. The JSON content is embedded in the element message of the xml file containing the results." How and where this xml file is generated? Because I don't find it anywhere.
I have a pipeline like this one with VsTest assemblies: https://github.com/Seddryck/NBi/issues/399
Thank you for your answers!

Hello , can you provide please provide the method to run the test on azure pipelines


Edgemesh Gateway and Edgemesh Agent x509: certificate signed by unknown authority error

What happened:
Background on system, even though there is a section for it later on:
Running the K8s master node on a VM on a server run by my institution so it has its MASTER_IP which we use to ssh into it and its LOCAL_IP which is the address produced when running "ip route get <IP_ADDRESS>"
The edgenode is run on my laptop which is running windows 10, so I am using a virtualbox VM with NAT network to connect to the institutions' VM.

Created K8s cluster with sudo kubeadm init --flags, etc
Installed Calico network addon
Created the cloudcore pod with helm
Installed CRDs
Created edgemesh agent and edgemesh gateway with helm (same psk)
Joined the edgenode to the master node with sudo keadm join

Followed the steps on the edgemesh guide to deploy edgemesh agent and gateway, created psk cipher, enabled Edge Kube-Api Endpoint and setup Edgemesh HA features.
The problems started to arise when I went to test edgemesh with the test cases, as none of the services or pods were able to communicate between the cloud vm and edge device.
When getting the logs for the edgemesh gateway pod on the master node, it produced x509 certificate signed by unknown authority, even though I did not create any self signed certs.
Environment:

EdgeMesh version:  v1.13.1-dirty

Kubernetes version (use kubectl version): Client Version: v1.23.15, Server Version: v1.23.15

KubeEdge version(e.g. cloudcore --version and edgecore --version): v1.13.1

Cloud nodes Environment:
  - Hardware configuration (e.g. `lscpu`): virtual machine with Intel(R) Xeon(R) Platinum 8160 CPU @ 2.10GHz
  - OS (e.g. `cat /etc/os-release`): Ubuntu 22.04.3 LTS
  - Kernel (e.g. `uname -a`): 5.15.0-78-generic
  - Go version (e.g. `go version`): go1.18.1 linux/amd64
  - Others: Calico network addon v3.25.0

Edge nodes Environment (virtual machine):
  - edgecore version (e.g. `edgecore --version`): 1.23.15-kubeedge-v1.13.1
  - Hardware configuration (e.g. `lscpu`):
  - OS (e.g. `cat /etc/os-release`): Ubuntu 22.04.3 LTS
  - Kernel (e.g. `uname -a`):  6.2.0-26-generic
  - Go version (e.g. `go version`):
  - Others:

Any help/insight will be very much appreciated, as I have been pulling my hair out over this for the last week

I'm anlysis your logs:

istio.io/client-go/pkg/informers/externalversions/factory.gen.go:118: Failed to watch *v1alpha3.DestinationRule: failed to list *v1alpha3.DestinationRule: Get "https://MASTER_IP:6443/apis/networking.istio.io/v1alpha3/destinationrules?limit=500&resourceVersion=0": dial tcp MASTER_IP:6443: connect: no route to host

Is MASTER_IP an env var? Maybe MASTER_IP can not parse a valid IP address.

I'm anlysis your logs:

istio.io/client-go/pkg/informers/externalversions/factory.gen.go:118: Failed to watch *v1alpha3.DestinationRule: failed to list *v1alpha3.DestinationRule: Get "https://MASTER_IP:6443/apis/networking.istio.io/v1alpha3/destinationrules?limit=500&resourceVersion=0": dial tcp MASTER_IP:6443: connect: no route to host

Is MASTER_IP an env var? Maybe MASTER_IP can not parse a valid IP address.

I substituted my node's IP address with "MASTER_IP" before uploading the logs so I don't think it is that. Further down in the logs is when I start getting the x509 error so I think what you've found is the initial pod starting up and not immediately establishing a connection.

If your node and kube-apiserver are not in the same subnet, you need to use the edge Kube-API server function of kubeedge. For details, see: https://edgemesh.netlify.app/guide/edge-kube-api.html

Even after following the steps from the page mentioned above (https://edgemesh.netlify.app/guide/edge-kube-api.html) I am still getting the same error
I have also renewed the certs with sudo kubeadm certs renew all, deleted all the pods and no luck.
I finally setup a cluster on my laptop with only the master node, followed the kubeedge setup and edgemesh setup with it resulting in the same x509 error

--set kubeAPIConfig.master=https://$MASTER_IP:6443 \

no need to special kubeAPIConfig.master.

edgemesh-agent or edgemesh-gateway on cloud, will use k8s serviceAccount and RBAC to access kube-apiserver
edgemesh-agent or edgemesh-gateway on cloud, will use edgecore metaServer to access k8s metadata.

@Poorunga that fixed it!!!
Thank you heaps!!!
My team and I are relatively new to Kubernetes  so it has been interesting learning about the nuances along the way.


multiple-value uuid.NewV4() in single-value context

When I try to build caduceus master branch in a centOS 7 machine with go build, the go compiler gives the following error:
./outboundSender.go:495:27: multiple-value uuid.NewV4() in single-value context
This seems to be related with the following issue: https://github.com/hlandau/acme/issues/293
This issue is due to an upstream API change in the github.com/satori/go.uuid package, specifically the change for satori/go.uuid#18. (https://godoc.org/github.com/satori/go.uuid#NewV4)
A simple fix would be:
if "" == tid {
randUuid, err: = uuid.NewV4()
if err != nil {
logging.Error(obs.logger).Log(logging.MessageKey(), "New Post request", "url", obs.listener.Config.URL,
logging.ErrorKey(), err)
// Handle error
} else {
tid = randUuid.String()
}
}

To get the dependencies, are you using glide install or go get?
I've got caduceus pinned to f58768cc1a7a7e77a3bd49e98cdd21419399b6a3 of satori/go.uuid (latest release 1.2).
I'm not opposed to moving the revision we're building with, but noticed that my build failed due to it being pinned to the older release of the uuid.

To build, I do the following:
cd ~/Projects/caduceus
export GOPATH=`pwd`
cd src
glide install
cd caduceus
go build

I was using "go get" to install the project dependencies. With "glide install" the error is fixed. Thanks for your help.


Strip off leading/remaing spaces

Question:
is there a possibility to strip off leading/remaining spaces similiar to Go1.6 templates, see:
https://tip.golang.org/pkg/text/template/#hdr-Text_and_spaces  ?

There isn't any standard TAL command that would do this and I'm not aware of any extensions to the language in other implementations that would achieve the same effect.
I'm curious as to what scenario this would be useful in.  The Go template example given doesn't really have a strong analogy in TAL.  As the tal package implements only for HTML5, removing stray whitespace is of no real value due to the whitespace handling rules in HTML.
Text substitutions of the kind shown in the Go template example are usually handled with a string: TALES expression.  As the string needs to be contained in a valid attribute, spreading it over multiple lines as shown in the Go example is not something that is normally done.

Closing as it's unclear what is being requested.


ReactiveList.AddRange throws "Range actions are not supported" given a list of length 2<=n<=10, under certain circumstances

Do you want to request a feature or report a bug?
Bug
What is the current behavior?
ReactiveList.AddRange and ReactiveList.InsertRange throw a System.NotSupportedException "Range actions are not supported." when passing them a list with at least 2, but at most 10 number of elements, under certain circumstances that are still not entirely clear to me (see below examples).
RxApp.SupportsRangeNotifications is true.
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem
The "cleanest" yet oddest example I came up with was this specimen:
ViewModel
public class MainViewModel : ReactiveObject
{
    public MainViewModel()
    {
        // This works for any number of elements
        SearchResults.AddRange(Create(5));

        Observable.Start(() => { })
            .Do(_ =>
            {
                // This also works for any number of elements
                SearchResults.AddRange(Create(5));
            })
            .ObserveOn(RxApp.MainThreadScheduler)
            .Subscribe(_ =>
            {
                // This fails for [2..10] elements
                SearchResults.AddRange(Create(5));
            });

        IEnumerable<string> Create(int numElements)
            => Enumerable.Range(1, numElements).Select(i => $"item_{i}");
    }

    public ReactiveList<string> SearchResults { get; } = new ReactiveList<string>();
}

View
<Grid>
    <ListView ItemsSource="{Binding SearchResults}"></ListView>
</Grid>

... which manifests itself in a more realistic scenario, like the following:
ViewModel
public class MainViewModel : ReactiveObject
{
    public MainViewModel()
    {
        // This works for any number of elements
        SearchResults.AddRange(Create(5));

        Search = ReactiveCommand.Create(() => { });
        Search.Subscribe(_ =>
        {
            // This fails for [2..10] elements
            SearchResults.AddRange(Create(5));
        });
    }

    private static IEnumerable<string> Create(int numElements)
        => Enumerable.Range(1, numElements).Select(i => $"item_{i}");

    public ReactiveCommand<Unit, Unit> Search { get; }

    public ReactiveList<string> SearchResults { get; } = new ReactiveList<string>();
}

View
<Grid>
    <Grid.RowDefinitions>
        <RowDefinition Height="Auto"></RowDefinition>
        <RowDefinition Height="*"></RowDefinition>
    </Grid.RowDefinitions>
    <Button Command="{Binding Search}" Content="Search" Grid.Row="0"></Button>
    <ListView ItemsSource="{Binding SearchResults}" Grid.Row="1"></ListView>
</Grid>

Code-behind of the above two examples:
public partial class MainWindow : Window
{
    public MainWindow()
    {
        InitializeComponent();
        DataContext = new MainViewModel();
    }
}

However, the following Button.Click based example also triggers the error:
ViewModel
public class MainViewModel : ReactiveObject
{
    public MainViewModel()
    {
        // This works for any number of elements
        SearchResults.AddRange(Create(5));
    }

    public static IEnumerable<string> Create(int numElements)
        => Enumerable.Range(1, numElements).Select(i => $"item_{i}");

    public ReactiveList<string> SearchResults { get; } = new ReactiveList<string>();
}

View
<Grid>
    <Grid.RowDefinitions>
        <RowDefinition Height="Auto"></RowDefinition>
        <RowDefinition Height="*"></RowDefinition>
    </Grid.RowDefinitions>
    <Button Click="ButtonBase_OnClick" Content="Search" Grid.Row="0"></Button>
    <ListView ItemsSource="{Binding SearchResults}" Grid.Row="1"></ListView>
</Grid>

public partial class MainWindow : Window
{
    public MainWindow()
    {
        InitializeComponent();
        DataContext = new MainViewModel();
    }

    private void ButtonBase_OnClick(object sender, RoutedEventArgs e)
    {
        // This fails for [2..10] elements
        (DataContext as MainViewModel).SearchResults.AddRange(MainViewModel.Create(5));
    }
}

What is the expected behavior?
For ReactiveList.AddRange and ReactiveList.InsertRange to not throw "Range actions are not supported" in a NET45 application, for any non-null list, like, ever.
Which versions of ReactiveUI, and which platform / OS are affected by this issue? Did this work in previous versions of ReativeUI?

OS is Windows 10 version 1703 (Creator's Update) with VS 2017 Update 2.
Platform is WPF/.NET Framework 4.5.2 and 4.7 (likely any .NET Framework >= 4.5, but I only tested those two).
ReactiveUI 7.*, 6.5.2, 6.0.0, 5.2.0 and 5.1.2 definitely exhibit this issue. Version 5.0.2 works as expected! So I guess it's safe to assume this bug exists since 5.1.2.

Other information (e.g. stacktraces, related issues, suggestions how to fix)
ReactiveList.cs, line 357 is the one that throws the Exception in the latest release (7.4.0).
#363 appears to be about the same problem, and indeed it works fine using the SixReactiveList<T> posted in that issue. It looks like it should be fixed, yet here I am ... 😕

Thank-you for the comprehensive issue 💯

I'm having the same issue and I'm not sure if it's related to this issue https://github.com/reactiveui/ReactiveUI/issues/363. After I added RxApp.SupportsRangeNotifications = false; as suggested by the PR of https://github.com/reactiveui/ReactiveUI/pull/593, I can use AddRange without any problem.

Yeah, if I recall correctly, ReactiveList will simply do an Add for each item if RxApp.SupportsRangeNotifications = false. The underlying issue, though, is that WPF inherently doesn't support range notifications, yet ReactiveList issues them.
However, now that WPF has been split into a separate package (right?), there might be a better way of solving this than in my PR.

I'm having the same issue.  Output bound to Listbox ItemSource property.
Buggy version
ReactiveList<T> Output { get; }
...
this.Output.AddRange(data);

Workaround
using (this.Output.SuppressChangeNotifications())
{
  foreach (T expression in data)
  {
     this.Output.Add(expression);
   }
}

Looking into it right now.

Sorry for this weird commit feed. Was trying to remove corporative email from GIT_COMMITER_NAME and this resulted in several forced pushes. Could someone take a look at this?

We have dropped ReactiveList and ReactiveDerivedList in the next version of ReactiveUI and latest. Closing.


how to show date and time?

I was trying to change the mode prop to 'datetime' but it is not working, how I can show date and time, and I am talking about both iphone and ios.
Thank you

Hi!
What do mean by 'not working'? Let me know :)

I want datetime both for selection, it looks like it shows the date and time but with this:
ExceptionsManager.js:78 Warning: Failed prop type: Invalid prop mode of value datetime supplied to CustomDatePickerIOS, expected one of ["date","time"].

I just tried It and it is working correctly for me.
Please make sure you're using the latest version: npm install --save<EMAIL_ADDRESS>Let me know if it works :)

@mmazzarolo Thank you so much I was accidentally using a lot older version.
Thank you

@mmazzarolo  i have use this but it only pick the date not the time its a datepicker only??

@mubashiralisiddiqui
you should check the mode prop in the readme

@mmazzarolo  thanks it was my mistake


Bumps widestring to v1 and makes sure we pass it an aligned ptr

Hey there!
Following up after https://github.com/arcnmx/ddc-winapi-rs/pull/1, this time I kept the changes to a minimum, so just the dep bump (this time to v1 🎉) and now properly checking the ptr we pass to WideCStr::from_ptr_str is aligned.

thanks for the review! I'll get to it soonish :)

comments should be addressed now 👍

Perfect, thanks!


Getting started with this package is unclear.

I saw your talk today and very interested in using this in my first rust project. I am new to rust as well as cargo and have found the readme for this repo unclear.
I figured out that I can add the following to my Cargo.toml
[dependencies.rustfmt]
git = "https://github.com/nrc/rustfmt"

But in your presentation you quick ran a command to lint your file (similar to how GOLANG has fmt), what was that?
Thanks for the presentation and this your work in this repo.

Unfortunately I haven't seen @nrc's talk yet, but I may be able to give you some pointers. If you want to format your project's code, you have to compile rustfmt as a binary. To do that, first clone the repository:
$ git clone https://github.com/nrc/rustfmt.git
and then run it on the root of your project, usually src/lib.rs:
$ cd rustfmt
$ cargo run -- /path/to/your/project/src/lib.rs

Thanks @marcusklaas, I attended RustCamp, I believe the talk will be available to watch within a few weeks.
You explanation was very clear and helpful!


Discourse.topic_url_valid is too fussy

In discourse.py there is a method which checks if Discourse URLs are valid:
https://github.com/canonical/upload-charm-docs/blob/bdaf92b7d6f42b95be3ede01596ec55985a1b4cc/src/discourse.py#L86
A Discourse URL must have the form /t/topic-slug/<id-num> to pass validation here, e.g.
https://discourse.charmhub.io/t/get-started-with-the-juju-olm/6559
However, either the slug or topic ID can be omitted, as it can be deduced from the other one. e.g.
https://discourse.charmhub.io/t/6559
https://discourse.charmhub.io/t/get-started-with-the-juju-olm
are both valid URLs, redirecting to the first URL.
This is causing the action to fail when trying to migrate our docs to GitHub. The navigation table contains a link to /t/6559, which is failing validation, raising an exception and causing the action to fail.
I would question the need for URL validation at all. When migrating, we should assume that the URLs provided on Discourse are valid, since they already work for existing docs. If a URL really is invalid, then this will be caught later when trying to make a request to it.

Makes sense, maybe instead of complaining the action should try to resolve the URL and fix it up. If that fails, it can complain. How does that sound?

Also, the migration currently has a bug #41 which we're working to resolve

Makes sense, maybe instead of complaining the action should try to resolve the URL and fix it up. If that fails, it can complain. How does that sound?

Better, but that would still result in extra (unnecessary?) API calls.
IINM, the Discourse.topic_url_valid method is only used in Discourse._url_to_topic_info:
https://github.com/canonical/upload-charm-docs/blob/bdaf92b7d6f42b95be3ede01596ec55985a1b4cc/src/discourse.py#L140
to try and retrieve "topic info" (slug and topic ID). But I'm not sure if both the slug and topic ID are really necessary. Discourse seems to be happy with just one of them.

The API call is quite useful because the user will be alerted much earlier that there is a problem with the URL rather than having to wait until that URL is retrieved which will result in an error later.
It is important that the URLs have both the slug and topic id when they are handled because things like the path in the navigation table depend on reading the path. With the PR, the action will now automatically fix up any URLs that have either the topic id or the slug missing. If there is a significant performance impact, we can consider making changes to only require the HEAD request, for example, if the slug or topic id is missing.


InvalidOperationException handling

InvalidOperationException handling for games that use new Input System instead of UnityEngine.Input to prevent console log spam

Resolved by #531


Essence Pouch doesn't display Normal Essence

Type
Incorrect behavior
Operating System
Windows
OS Version
Windows 11
Bug description
When adding Rune Essence rather than Pure Essence to an Essence Pouch, the counter stays at 0 regardless of how many are added.
Screenshots or videos

RuneLite version
RuneLite version: <IP_ADDRESS>
Launcher version: 2.4.5
Logs
No response

Issues and suggestions for hub plugins must be made on that plugin's repository; they are not maintained by us. The repo is usually accessible from the Support link on the plugin.

Oh apologies, I thought this was a native plugin.


Inconsistency on floating badge on .list-group-item

When I'm trying to float an badgeon a .list-group-item (in this case into a .card) the badge only float adding a viewport modifier .float-xs-right and not with the plain .float-right
Here an example.
https://jsfiddle.net/8aLskrzy/3/
edit:
i'm using 4.0.0-alpha.5

I detected that the bug occurs where $enable-flex: true because float inside a flex 🤔

According to the documentation .float-right has been removed because it is redudant to .float-xs-right.

Utilities
Added .float-{xs,sm,md,lg,xl}-{left,right,none} classes for responsive floats and removed .pull-left and .pull-right since they’re redundant to .float-xs-left and .float-xs-right.

@j0an - And also there is no class called .float-right . @lhirales is right

.float-right is back in v4-dev, but this isn't reflected on the hosted docs as we haven't done a release since those changes were made. @j0an's comment is accurate—you'll need to switch from a float to a flex-based implementation. The docs in v4-dev branch include a special callout for moving from the default layouts to flexbox.
From the list-group.md docs page:
## Badge

Add badges to any list group item to show unread counts, activity, etc.

{% example html %}

    14
    Cras justo odio

    2
    Dapibus ac facilisis in

    1
    Morbi leo risus

{% endexample %}

When in flexbox mode, you'll need to rearrange the contents of your list group items. To replicate the right-aligned badges as shown above, use the following example's code. Note the [`flex-items-xs-between` utility class]({{ site.baseurl }}/layout/flexbox-grid/#horizontal-alignment), the badge's placement, and the lack of a float utility on the badges.

{% highlight html %}

    Cras justo odio
    14

    Dapibus ac facilisis in
    2

    Morbi leo risus
    1

{% endhighlight %}

Thanks @mdo I will check this out :)

🎉 Works fine @mdo
thanks for the insight :)

+1 to this flexbox solution :)


[$250] Scan - "Delete" and "Replace" options are displayed for an admin which causes an error

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.43-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5035807
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Issue reported by: Applause - Internal Team
Action Performed:
Prerequisite
Create a workspace and invite an employee to the workspace
Login as an owner and employee

As the employee navigate to the workspace chat and click on the + icon > Submit expense > Scan
Upload a receipt and finish the flow
After the expense is created navigate to the tab where you are logged in as the admin/owner
Click on the receipt thumbnail
Here notice that the "Delete" and "Replace" options are displayed
Click on "Replace" > Choose another receipt or take a photo of it > Upload
Click on "Delete" > Confirm > Notice that an error is thrown

Expected Result:
The workspace admin cannot edit the receipt file so there should not be "Delete" and "Replace" options
Actual Result:
The ‘Delete’ and ‘Replace’ options are displayed, but when ‘Delete’ is executed, an error occurs and when ‘Replace’ is executed, the receipt is replaced
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/user-attachments/assets/164a7d6d-600e-43b3-929c-a6811ec8c88a
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021843656533685450338
Upwork Job ID:<PHONE_NUMBER>685450338
Last Price Increase: 2024-11-05

Issue OwnerCurrent Issue Owner: @Ollyws

@OfstadC  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

We think that this bug might be related to #wave-collect - Release 1

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

I've asked for retesting in #qa

Waiting on QA to retest

@kavimuru any update? 😃

Still reproduced, sorry I missed this one.
https://github.com/user-attachments/assets/12f469d3-397e-47da-a8c0-6d70154c5892

Friendly bump @Ollyws 😃

@lanitochka17 I confirmed that the frontend functionality is correct. Can you please update this issue to only focus on fixing the errors that happen? If this needs to be handled internally, that's fine, but I'd like to get some more information for this such as the logs for the delete/replace requests that have the errors.
@OfstadC If you're able to reproduce this, could you please try to get the requestID for me following this SO?

Bump @lanitochka17 @OfstadC

Sorry @tgolen ! Was OoO - looking now 😃

@tgolen I was able to reproduce today

jsonCode
:
405
message
:
"405 Cannot detach receipt from unowned transaction"
onyxData
:
[]
requestID
:
"8e109b54d92daccc-MSP"

Awesome! Here are the logs for that request.
It looks like that error is a very old error (at least 7 years old). So, it looks like in order for us to allow that operation, we need to make an update to Auth.
Can you please go here and open up a new issue using the "Open an internal issue for a backend fix" template with all the relevant info? Then it will get assigned to an engineer to fix.

Done! Thanks @tgolen for your help!

Jules is assigned to E/E issue 😃

No update - E/E issue is waiting on a volunteer


Feature/nihdb the voyage home

Closes #2174.

@drostron had to re-open the PR to get the github diff to show up correctly. Pending travis, this is ready for you to look at.


duplicated modules: json specified in json and yaws

Hi,
Could src/json.erl  be removed? I get the above when trying to generate a release.
Errors generating release
Duplicated modules:
json specified in json and yaws
I am using https://github.com/talentdeficit/json that has a json module.
How to deal with it?

Can you exclude the yaws json.erl from your release?

BTW I agree that it's likely time to remove json.erl. @klacke what do you think? It's been marked deprecated for quite awhile now.

That would be great! We manually remove json.erl every time we upgrade yaws.

Fine by me, remove.


Refactor acme-shopping with React / Typescript

Description of the PR:
Mainly to replace the static web page with a React Front End
Updated the E2E test to point to the new react application as needed.


Remove template package from docs.ms

Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
Template package depends on unrelease core version which failed the docs.ms step. Exclude version updates for these packages.
https://apidrop.visualstudio.com/Content CI/_build/results?buildId=310532&view=logs&s=96ac2280-8cb4-5df5-99de-dd2da759617d
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:

[ ] The pull request does not introduce [breaking changes]
[ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
[ ] I have read the contribution guidelines.

General Guidelines and Best Practices

[ ] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

Don't forget to remove these from onboarding in package.json

/azp run java - template - ci

/azp run java - core - ci

/check-enforcer override


TypeError: undefined is not an object (evaluating '_AppState$addEventLis.remove')

Hello, thanks for the component that you developed. I am getting this error when I run the app:
TypeError: undefined is not an object (evaluating '_AppState$addEventLis.remove')
I warped my app.js using export default withPreventScreenshots(App) and then receive the error.
react native 64.0.1
platform iOS
Can you please help me?

I think I detected the problem, I'll be working on it today.

Solved the issue in v1.1.0, you can update the package to get it fixed.

Thanks for the feedback, I tried the package again and it's working perfectly with React Native 0.64. Please make sure the package is updated properly and try clearing the React Native/Metro cache.

@a7med-mahmoud : Thank you I try it today, by the way is working with simulator or I should use a real device?

You have to use a real device as the Simulator's screenshot feature is not the same as a on-device screenshot


Changes the modulo operator to act like the python one

Following the discussion in #12035, I open a new PR to discuss replacing the behaviour of modulo by its more pythonic version. With this PR we will have -20 % 100 returning 80 instead of -20.
To understand the problem a little bit more, you can read this thread in stackoverflow.
I think this deserves a review from @reduz. ;)

I'd like @tagcup's opinion too :)

This is mostly about conventions.
In integer math, modulo division is meant to be used with integer division. If you're using signed integers, you'd be using signed versions of the division instructions, and they'd satisfy n = m q + r.
-20/100 gives m = 0, and with your change, we'd get r = 80, resulting in -20 = 80.
You can argue that this equation holds in mod 100 of course, but so does the current behavior which also holds in non-mod integer arihtmetic therefore comes with less assumptions (which means less surprises). Not to mention it's faster.
Also, anyone who wants python-like behavior can trivially implement it.

And this'll probably get ignored again but once again, GDScript is a programming language, so rather than adding random trivial one-liner operations to the core library or to GDScript itself ("because language X has it"), I'd rather ask people to write their own functions to implement those and use autoload.

I have to agree with @tagcup about this one.

So I guess I have to explicit a little bit more for the PR monday, as I wont be there. :)
Regarding the modulo we have two conventions. Considering n % m = r with n = mq + r, we have either:

C++: If n >= 0, we have 0 <= r < q and if n < 0, we haveq < r <= 0. Thus when n is negative, the result is negative and if n if positive the result is positive
Python: whatever the sign of n, we have  0 <= r < q. Thus n%m is always  positive.

I think the second one is more expected. Especially as Godot's syntax is mainly inspired from python.
Also, I think that would avoid having to discuss #12035, as this modulo would work as a "wrap" operator, in which I see much more usage that with the C++ one. That would avoid adding wrap and fwrap to the core I guess (if this is ever decided).
That being said, this would make modulo inconsistent with fmod, I haven't checked what Python does with that.
And once again, we're making a game engine, as people from different horizon might use it we should provide a lot of functions working out of the box for the people that are not programmers. Letting people code everything by themselves if not a good idea. That's what make python powerful, it has a lot of utility functions out of the box, that make prototyping easy.
That being said, I'm not against moving some functions out of the core, provided we find a way to package them with the engine. Maybe some sort of standard library, but that's another issue. :)

How about something like MathEx static class where algorithms like (eg. wrapping, gaussisan) can be placed by fellow users ? :) And with quick access from visual script as separated "extended built-in functions" tab.

How about something like MathEx static class where algorithms like wrapping or gaussisan can be placed by fellow users ?

If the goal is to move classes out of the core, it is not desired. I was more thinking about something like that (for a standard library).
var Math = preload("Math")
Like for loading other gdscripts classes but without the ".gd".

If the goal is to move classes out of the core, it is not desired. I was more thinking about something like that (for a standard library).
var Math = preload("Math")
Like for loading other gdscripts classes but without the ".gd".

I don't see much use for that, if there's a built-in Math library, we don't have to hide it behind the need to preload it.
On the other hand, if people continue wanting to add many math helpers to the core library, we could indeed consider having a Math or MathExt autoload script that could be distributed on the AssetLib and contributed to outside of the main Godot repo. It could be used as a staging area with less strict requirements on use cases than in core, and if usage shows that a big proportion of Godot users use this addon for some specific methods, they could be moved in the core.

On the other hand, if people continue wanting to add many math helpers to the core library, we could indeed consider having a Math or MathExt autoload script that could be distributed on the AssetLib and contributed to outside of the main Godot repo. It could be used as a staging area with less strict requirements on use cases than in core, and if usage shows that a big proportion of Godot users use this addon for some specific methods, they could be moved in the core.

I totally agree on that :)

Just to add my opinion, I expect % to behave as defined in Euclidean division (a = bq + r with 0 ≤ r < |b|). This definition is also used in modular arithmetic. I think other languages adopted other conventions to slightly speed up the algorithm.
Also to index an array with python's % you can write index = (index - 1) % size, while with the current operator you have to write index = (((index - 1) % size) + size) % size which is not straightforward.

Well, having dedicated Math module is nice but what you would do for things
which are required to be impllemented in C++
like spline functions and other simple algorithms like A*?
On Wed, Oct 18, 2017 at 8:08 PM, Elia Argentieri<EMAIL_ADDRESS>wrote:

Just to add my opinion, I expect % to behave as defined in Euclidean
division https://en.wikipedia.org/wiki/Euclidean_division (a = bq + r
with 0 ≤ r < |b|). This definition is also used in modular arithmetic
https://en.wikipedia.org/wiki/Modular_arithmetic#Residue_systems. I
think other languages adopted other conventions to slightly speed up the
algorithm.
Also to index an array with python's % you can write index = (index - 1)
% size, while with the current operator you have to write index =
(((index - 1) % size) + size) % size which is not straightforward.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/pull/12099#issuecomment-337660343,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAX04Mx81pJTvywu9c4C_bjfVqswk_Mks5stjCCgaJpZM4P5fjP
.

So, the discussion stalled a bit here. It's now or never to make this change, but I'm still not convinced that it's really wanted.

Well me neither, but if I wanted to sum up the debate I would say it is just about choosing between python style modulo or c++ style :)
But i guess that because we have a wrap function it is less useful than before, feel free to close when a consensus is found

If this is ever be merged, we need to change the content of wrapi to '''return (x-min) % (max-min) + min''' just a mark, nothing more

I'd say that there haven't been enough voices raises for or against the change to really reach a consensus, so I'd advocate for keeping the current behaviour. Nobody complained about it, so no real reason to change IMO.


Add n_bifurcations and n_terminations to morphtree functions

Current coverage is 100.00%

Merging #120 into master will not affect coverage as of aa3ecd8

@@            master    #120   diff @@
======================================
  Files           30      30
  Stmts          973     977     +4
  Branches         0       0
  Methods
======================================
+ Hit            973     977     +4
  Partial          0       0
  Missed           0       0

Review entire Coverage Diff as of aa3ecd8

Powered by Codecov. Updated on successful CI builds.


phpsh: migrate from php

Goes together with https://github.com/Homebrew/homebrew-php/pull/3869.

Is there anything preventing a merge of this submission ?


Wlox Project Group

Wlox have been out of date for a while now, mbassan took over the updates with some changes that where never told to the people, so we all had to manage to discover it ourselves.
Despite the movements from some people to privatize it, we still want to keep WLOX as an open-software project.
www.github.com/wlox-project
Everyone interested in collaborating please send an email to:
<EMAIL_ADDRESS>Let's build it

please add me in slack.

@cuncode
Hi, How are you.
Your wlox branch looks good, I wanna disucss your project. Can we discuss over chat?
Let me know your chat id.

My email is<EMAIL_ADDRESS>

@cuncode Thanks. I sent skype contact request also. If you want, i can discuss with Hangout.

Can you add me to the slack workspace<EMAIL_ADDRESS>I can contribute.

Can you add me to the slack workspace<EMAIL_ADDRESS>

Here is the link, sending you invitations
https://join.slack.com/t/wlox/shared_invite/enQtMjgzMjY2NzI3NzM1LWM2ODZlYmYzZmRjZTZmYjBjMjNlYWJjOGY5MDE5NmZiOGRlYTZkMmQzYWFlYTA2YjhiNzE3OTY0MmZjYTQ0NTY

please add my slack<EMAIL_ADDRESS>

Hello All !  What a great day.  Thank you everybody for taking the time to care about humanity and looking out for your neighbor just as you did yourself.  While this message goes out without any real programming language, no java script, no C++, it is not without content that can be read by humans [:|].
I started wlox/wlox with real hopes of bettering humanity.  I deserve none of the credit.  It goes to all of you who have contributed your time and knowledge in efforts to better the github community to help make programming software better, and this makes the rest of the world a better place for that matter!

// Hello World!                   Wlox/wlox:  The main project has not          been released to open source software          program development, it remains private          since 2006
         There is hope, you all pulled together for         wlox/wlox support.  I could have never            pulled this together all by myself... It          takes a whole list of programmers to roll            the credits at the end of a video game:
         This could be just the beginning, please           keep wlox/wlox open source as was           intended;                     *Sourceforge.net [:|]            I am a newbie; '2006'. Does that make             me an old bee yet? //

You did the work, you deserve all of the credit.I can only hope for another invite to help further knowledge of wlox/wlox area of purpose
🐝 👻 JP 👾
<EMAIL_ADDRESS>Sent from Yahoo Mail on Android
On Tue, Dec 5, 2017 at 7:56 AM, Wlox<EMAIL_ADDRESS>wrote:
Wlox have been out of date for a while now, mbassan took over the updates with some changes that where never told to the people, so we all had to manage to discover it ourselves.
Despite the movements from some people to privatize it, we still want to keep WLOX as an open-software project.
Everyone interested in collaborating please send an email to:
<EMAIL_ADDRESS>Let's build it
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Hello Bitify,
I created repository wlox/wlox... but a bunch of hard working athletes kept it going.  With an ICO scheduled for sometime in April this year, I can only hope a few major issues are taken into consideration.  Prioritizing these developments in consideration for my plans of future ICO deployments, please consider the following;  Fixed Supply Contract;  Original Exchange Platform; and ERC20 Token Standards although I suggest making said coin compatible to ERC20 standard interface and considering majority consensus voting, My hopes were that the open source software program wlox/wlox would ( "I am looking for the right words here, perhaps you can help me...been up all day and night..." )  Legacy and ledger comparability and compatability should be also taken into consideration... my hopes were for asset wlox/wlox or whatever you are now calling it, to be not only comparable with 2009 Bitcoin and then transferable to Ethereum and gas, but that coin consideration be given exclusive rights willable only by me in consideration to legacy project of wlox/wlox in regards to 1)African Water Project, Save the Children (although we could say save the kids, I also created helpmehelpu.org to keep kids off of the streets... Syria looks real bad guys,
But in regards to legacy, the wlox/wlox true origin would be of the program languages taken into consideration for chance of one day legacy conversion from the recovery of pre 2008 Bitcoin data held on only by the thread of it's iresputable existence and creation remaining on a hard drive created just before Early 2006.  Yes, there should be still a chance for recovery and conversion of legacy data to be converted by contract to post 2009 Bitcoin Network.  That's Capital B not lowercase b, symbolizing that most commonly, Bitcoin is known to be a cryptocurrency.  But, Bitcoin is many things.  Bitcoin with a capital 'B' appears to be peer to peer payment network.  On the other hand, bitcoin with a lowercase 'b' Is the unit of account within this network.
     Bitcoin
|
|
|
|   |    |
|
|
|
|   |
Bitcoin
Bitcoins are created as a reward for a process known as mining. They can be exchanged for other currencies,[14] products, and services. As of February 2015, over 100,000 merchants and vendors accepted bitcoin as payment.[15] Research produced by the
|   |
|
|
What is Bitcoin?
The Largest Cryptocurrency B  bitcoin.
How cool would it be to be the only coin on the market with admittedly pre Bitcoin bitcoin legacy data created in 2006 before the 2009 bitcoin revolution written into it's open source code project wlox/wlox
The real JP... aka Juliet Papa 🤖
The real Jason Lee Prill,
Be an International Banker since 2006, always playing by the rules, this is a great start.
<EMAIL_ADDRESS>Sent from Yahoo Mail for iPhone
On Sunday, January 7, 2018, 9:28 AM, Bitify-Developers<EMAIL_ADDRESS>wrote:
Hey everyone, been following Wlox for about 3 years now. Worked with Mbassan and updated and added alot more features ect. I've built Android apps for Wlox and implemented many different Altcoins and fixed many security flaws. Visit https://bitify.co.za for a working exchange that accepts many different coins based on many different algos. my e-mail is<EMAIL_ADDRESS>and i am available for hire. Bitify is currently crowdfunding and launches April 2018.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Anyone working on this project 20APRIL18?

незнай над этим никто помоему неработает. все скачивают и сами пытаются чтото поднять. можешь сомной связаться может вместе будем делать<EMAIL_ADDRESS>

Привет, niko117.
Напиши мне<EMAIL_ADDRESS> поговорим.


Fixed leaf_rotation and leaf_font_size in Python 3

The arguments leaf_rotation and leaf_font_size in scipy.cluster.hierarchy.dendrogram() did not apply their values to the final plot in Python 3 since map() now returns a generator instead of a list. This change forces the lambda function to be applied by converting the generator to a list.
I also added a check for this problem in the dendrogram plotting test.

Tests all pass, merging. Thank you!

@fredrikw you may be interested in checking out gh-5164. I had this fix there plus a number of other ones.
I'd also be interested in getting one or some larger real-world dendrograms to more rigorously exercise dendrogram if you have any. (background: I'm not a user of dendrogram myself and neither are any of the other Scipy core devs, but given the large user base and lots of issues / Stackoverflow questions I dug in and want to fix it as well as I can).

Sorry for the delay @rgommers but now I have tested the latest dev and it looks very good. Unfortunately, I don't have a good large dendrogram to use (mine is only ~55 items large).

@fredrikw thanks for checking, and good to hear things work as expected for you now. And no worries, I got an example from someone else.


(PE-32930) Load task dependency files from the scripts directory

Signed-off-by: Enis Inan<EMAIL_ADDRESS>

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Don't know if I should be referencing the GH issue in the first commit.

I've also verified that this is all we'll need on the bolt-server side to get the load scripts bit working for projects. (Verification involved manually scp'ing the changed files in Puppet containing the scripts work over to the primary then restarting bolt-server).

This PR's blocked on https://tickets.puppetlabs.com/browse/PE-32938

Looks like https://github.com/puppetlabs/puppet-runtime/pull/496 has been merged so I think this should be unblocked?


Fix auto passwd prompt

Hi,
On Linux, with Python 3.4.2 and psycopg2 2.5.4, I have this error when I try to connect to a database with a password:
(pyvenv) lg@steroids:~/Documents/IDEA/LGbo$ pgcli -h localhost -p 5432 -U asterisk asterisk
'OperationalError' object has no attribute 'message'
With this commit, I have no more issues.
I've quickly tested with Python 2.7.6, it continues to work.
Regards.

Works as expected!
Thank you for fixing the issue. :birthday:

You're welcome :-)


Add support for APS 2.3.7

Released in 2.3.7:
https://github.com/OpenPj/aps-2x-client/releases/tag/v2.3.7


Limit world.step function to just a list of bodies.

I'd like to be able to use world.step to only update/step certain entities/bodies. By like passing in a 4th parameter or something as an array that tells world.step what to only update.

Sorry, I missed this. Have you tries body.setActive(false) for bodies that you want to exclude from simulation? Please see doc here.

Does it still loop through it?

What do you mean by "loop through it"?


spirv-llvm-translator: fix duplicate makeFlags merge

See
https://github.com/NixOS/nixpkgs/pull/171656#issuecomment-1119263828
there was a conflict with #162603 and a GitHub Action did a bad merge in 4cab9ae#diff-1aeab0da45b3afb6688d321042021a2ebad96758fc495d92aaadb50cc9aa22c7R28, adding a second makeFlags and breaking the build.

Hm, i figured this should probably go into staging-next

ofborg evals the base branch first so we can probably ignore those CI failures (example is #170193).
(Actually I guess staging is the correct branch, https://nixpk.gs/pr-tracker.html?pr=162603)


Update Set-AzRoleAssignmentRestMethod.ps1

Fixes issue #677

@microsoft-github-policy-service agree

No longer required - I did it through another PR - thanks for your help.


fix(render/ids): misconfigs for ad detector names

Description

For PR author

[ ] Tests for change.
[ ] If changing pkg/apis/, run make gen-files
[ ] If changing versions, run make gen-versions

For PR reviewers
A note for code reviewers - all pull requests must have the following:

[ ] Milestone set according to targeted release.
[ ] Appropriate labels:

kind/bug if this is a bugfix.
kind/enhancement if this is a a new feature.
enterprise if this PR applies to Calico Enterprise only.

closing for https://github.com/tigera/operator/pull/2216


Recommend to get promtool from a binary distribution.

Rather than compile it yourself, which doesn't work as shown anymore
because of Go Modules.

Thanks!

Should we cherry-pick it in release-2.25?

I think it's just a minor annoyance, but your call.

Please cherry pick. It is not minor since it happens at the moment we remove the vendor directory.

Good point.

#8493


Reachable slices + Bug fixes

[ ] Support for generating call stack evidence based on reachables (aka evidence of reachable components)
[ ] Improved yarn.lock v1 parsing to deal with aliases
[ ] Fixes #653 #649
[ ] Improves support for docker library images by retrying without the library prefix
[ ] Reliably disable any db updates from trivy by creating a fake cache dir and excluding jar files. Workaround for https://github.com/CycloneDX/cdxgen-plugins-bin/issues/9

How to test?
See the delta in repotests.

cdxgen must be invoked with the --deep argument, and bom.json must be placed within the same application directory
run evinse using the --with-reachables argument

https://github.com/CycloneDX/cdxgen/blob/feature/reachable-slice/.github/workflows/repotests.yml#L158-L159

@setchy, do you have any IDE configured to do automatic merges? Can you avoid using automatic push/pull since it is affecting the history.

Let's merge this and continue on part 2.


where is the TSN arkitechture?

Do you mean the architecture?
In our design, a recognizer model architecture is separated into two parts, backbone and heads
like TSN:
It is a recognizer2D network,
backbone is ResNet50 architecture https://github.com/PaddlePaddle/PaddleVideo/blob/develop/paddlevideo/modeling/backbones/resnet.py
and its head is tsn_head
https://github.com/PaddlePaddle/PaddleVideo/blob/develop/paddlevideo/modeling/heads/tsn_head.py

thank you


Upmerge "fix cares resolution with default authority" to master

Upmerge https://github.com/grpc/grpc/pull/15073 from v1.11.x

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[trickle] No significant performance differences

Actually, let's close this and upmerge the entire 1.11.x branch. I'll make an upmerge PR.

[microbenchmarks] No significant performance differences


Release: hwc-buildpack 3.1.17

Dependency Changes:
No dependency changes

New Commits on Develop:
501ef0b Update libbuildpack
59ea704 Update libbuildpack
ce24114 Update libbuildpack
ffd4469 Update libbuildpack
Refer to release instructions.

No major changes in libbuildpack to warrant a release.


Question: How to handle multiple entities in same domain

If i have situation, when some 'Entity1' has relation with 'Entity2', but 'Entity2' are related and work only with 'Entity1' logic, so separating it to another Module it seems overhead. Should i just add Entity2 to Entity1 domain and add separate Repository for it ?

Yes, just put it into the same module. Each module can have multiple entities if needed.