Search request with "AND" argument instead of "OR"

Q
A

Bug report?
[ ]

Feature request?
[ ]

Support request?
[ x ]

Hi everyone, I have been working on a cocorico for several day only, so big newby here. Sorry if my question has been answered but i couldn't find any clue...
For my project I would like to make a search that takes into account the categories selected with a AND style condition.
Ex: I have the following listings :
list1 ClassA / ClassB
list2 ClassA
list3 Class B
If I search ClassA I want 1 and 2 but if I search A&B i just want just and today it's coded so that I have 1/2/3 as results.
I did my best to dig into the code but I m stuck.
So far I have understood that it begins in listingsearchcontrol.php
  `public function searchAction(Request $request)
     {
        //For drag map mode
         $isXmlHttpRequest = $request->isXmlHttpRequest() ? true : false;

    $markers = array('listingsIds' => array(), 'markers' => array());
    $listings = new \ArrayIterator();
    $nbListings = 0;

    /** @var ListingSearchRequest $listingSearchRequest */
    $listingSearchRequest = $this->get('cocorico.listing_search_request');
    $isXmlHttpRequest ? $listingSearchRequest->setSortBy('distance') : null;
    $form = $this->createSearchResultForm($listingSearchRequest);

    $form->handleRequest($request);

    if ($form->isSubmitted() && $form->isValid()) {
        $listingSearchRequest = $form->getData();

        $results = $this->get("cocorico.listing_search.manager")->search(
            $listingSearchRequest,
            $request->getLocale()
        );
        $nbListings = $results->count();
        $listings = $results->getIterator();
        $markers = $this->getMarkers($request, $results, $listings);

        //Persist similar listings id
        $listingSearchRequest->setSimilarListings($markers['listingsIds']);

        //Persist listing search request in session
        !$isXmlHttpRequest ? $this->get('session')->set('listing_search_request', $listingSearchRequest) : null;
    } else {
        foreach ($form->getErrors(true) as $error) {
            $this->get('session')->getFlashBag()->add(
                'error',
                /** @Ignore */
                $this->get('translator')->trans($error->getMessage(), $error->getMessageParameters(), 'cocorico')
            );
        }
    }`

I have watched in the listingsearchmanage.php with the function search
` public function search(ListingSearchRequest $listingSearchRequest, $locale)
{
//Select
$queryBuilder = $this->getRepository()->getFindQueryBuilder();
    //Geo location
    $queryBuilder = $this->getSearchByGeoLocationQueryBuilder($listingSearchRequest, $queryBuilder);

    $queryBuilder
        ->andWhere('t.locale = :locale')
        ->andWhere('l.status = :listingStatus')
        ->setParameter('locale', $locale)
        ->setParameter('listingStatus', Listing::STATUS_PUBLISHED);

    //Dates
    $queryBuilder = $this->getSearchByDateQueryBuilder($listingSearchRequest, $queryBuilder);

    //Prices
    $priceRange = $listingSearchRequest->getPriceRange();
    if ($priceRange->getMin() && $priceRange->getMax()) {
        $queryBuilder
            ->andWhere('l.price BETWEEN :minPrice AND :maxPrice')
            ->setParameter('minPrice', $priceRange->getMin())
            ->setParameter('maxPrice', $priceRange->getMax());
    }

    //Categories
    $categories = $listingSearchRequest->getCategories();
    if (count($categories)) {
        $queryBuilder
          ->andWhere("llcat.category IN (:categories)")
            ->setParameter("categories", $categories);
    }

    //Characteristics
    $queryBuilder = $this->getSearchByCharacteristicsQueryBuilder($listingSearchRequest, $queryBuilder);

    //Order
    switch ($listingSearchRequest->getSortBy()) {
        case 'price':
            $queryBuilder->orderBy("l.price", "ASC");
            break;
        case 'distance':
            $queryBuilder->orderBy("distance", "ASC");
            break;
        default:
            $queryBuilder->orderBy("distance", "ASC");
            break;
    }
    $queryBuilder->addOrderBy("l.averageRating", "DESC");
    $queryBuilder->addOrderBy("l.adminNotation", "DESC");

    if (!$listingSearchRequest->getIsXmlHttpRequest()) {
        $event = new ListingSearchEvent($listingSearchRequest, $queryBuilder);
        $this->dispatcher->dispatch(ListingSearchEvents::LISTING_SEARCH, $event);
        $queryBuilder = $event->getQueryBuilder();
    }

    //Pagination
    if ($listingSearchRequest->getMaxPerPage()) {
        $queryBuilder
            ->setFirstResult(($listingSearchRequest->getPage() - 1) * $listingSearchRequest->getMaxPerPage())
            ->setMaxResults($listingSearchRequest->getMaxPerPage());
    }

    //Query
    $query = $queryBuilder->getQuery();
    $query->setHydrationMode(Query::HYDRATE_ARRAY);

    return new Paginator($query);`

And finally the listingrepository.php that gives the initial construction of the sql query :
      `class ListingRepository extends EntityRepository
                   {
                   /**
                   *
                   * @return \Doctrine\ORM\QueryBuilder
                   */
                  public function getFindQueryBuilder()
                 {
        $queryBuilder = $this->_em->createQueryBuilder()
        //Select
        ->select("partial l.{id, price, averageRating, certified, createdAt, commentCount}")
        ->addSelect("partial t.{id, locale, slug, title, description}")
        ->addSelect("partial llcat.{id, listing, category}")
        ->addSelect("partial ca.{id, lft, lvl, rgt, root}")
        ->addSelect("partial cat.{id, locale, name}")
        ->addSelect("partial i.{id, name}")
        ->addSelect("partial u.{id, firstName}")
        //->addSelect("partial ln.{id}")
        ->addSelect("partial ln.{id, city, route, country}")
        ->addSelect("partial co.{id, lat, lng}")
        ->addSelect("partial ui.{id, name}")
        ->addSelect("'' AS DUMMY")//

        //From
        ->from('CocoricoCoreBundle:Listing', 'l')
        ->leftJoin('l.translations', 't')
        ->leftJoin('l.listingListingCategories', 'llcat')
        ->leftJoin('llcat.category', 'ca')
        //Join::WITH: Avoid exclusion of listings with no categories (disable inner join)
        ->leftJoin('ca.translations', 'cat', Query\Expr\Join::WITH, 'cat.locale = :locale')
        ->leftJoin('l.images', 'i')
        ->leftJoin('l.user', 'u')
        ->leftJoin('u.images', 'ui', Query\Expr\Join::WITH, 'ui.position = 1')
        ->leftJoin('l.location', 'ln')
        ->leftJoin('ln.coordinate', 'co');
        // ->leftJoin('co.country', 'cy');

        //  $queryBuilder
       // ->addGroupBy('l.id');

       return $queryBuilder;`

But from all of this I cannot find a way to execute the way I want the research. I have watched in a lot of other files but I might have missed a step in the process. Could you please help me with this  ?
thanks very much,
JR

Ok, it seems to be clearly here in the searchmanager
`        //Categories
$categories = $listingSearchRequest->getCategories();
if (count($categories)) {
$queryBuilder
->andWhere("llcat.category = (:categories)")
->setParameter("categories", $categories);
However I know SQl but in this case with the mixe of codes I am a bit lost ! `

Basically I want to do this

in the function Search but I am lost now with the syntax ...

Finally, the raw sql code I would like to  transfer into the querybuilder is this :
select l.id, llcat.listing_category_id, allcat.categories from (Select l2.id id, group_concat(ll2.listing_category_id) categories from listing l2 left join listing_listing_category ll2 ON l2.id=ll2.listing_id group by l2.id) allcat , listing l  left join listing_listing_category llcat ON l.id=llcat.listing_id  where allcat.id=l.id;

The result would add me a concatenation of categories on every line that I would be able to use in the searchcontroller. However the doctrine syntax is obscure so a little help would be much appriciated....
Thanks,
JR

So I think I have the right way to implemetn it now but I am sturggling with syntax.
So the SQL query could look like this in the repository finqueryBuilder :

And I would add a "andwhere" clause in the searchmanager with the $categories implode in a string.
I think it should work but I can't find how to write it. Could you indicate me how to add the group_concat in the select, and to build a new andwhre condition ?
Much appriciated.
JR

Hi everyone, I ended with a solution (not the best but still) so I give it here if it can help some lost soul.
I used a having clause + a group_concat function.
In the listingsearchmanager.php I added :
        $categories = $listingSearchRequest->getCategories();         asort($categories);         $strgcategories = implode(',',$categories);         if (count($categories)) {             $queryBuilder              ->andWhere('llcat.category IN (:categories)')              ->having("group_concat(llcat.listingcategoryid order by llcat.listingcategoryid asc) = :strgcategories")                ->setParameter('categories', $categories)                ->setParameter('strgcategories',$strgcategories);
And in the listingRepository.php I added :
$queryBuilder             ->addGroupBy('l.id');
I also added the DQL class GroupConcat and the update the config.yml
This is not perfect, I would have prefered to modify the entities in order to add a field in the listinglistingcategory containing the concatenation and then be able to use a where clause on this field, but too complicated for me...
Now the behavoir is as wished. Only the listing with all the categories requested are showed.
Hope It will spare time for people wanting the same results ;)


Error when opening files

Version confirmation

[X] Confirm

Following prerequisites

[X] Confirm

Neovim version
Latest Nvim stable version with this configs purely.
Operating system/version
Archlinux
Terminal name/version
Alacritty/konsole latest versions
$TERM environment variable
No response
Branch info
main (Default/Latest)
Fetch Preferences
SSH (use_ssh = true)
How to reproduce the issue
When I open Neovim, I get no error.
However let's say I open a file with nvim I get the error attached in the screenshot. still works but would love to get it working.

Expected behavior
No error when opening a file via neovim
Actual behavior
No response
Additional information
No response

your config is not up-to-date, we add a new setting in core/settings.lua.
also u should use the 0.9 branch.

True, I had not updated the .nvim configs but only nvim lazy plugins. Thank you. All works fine now. And yes, my version is 0.9.0-1. Thank you and I truly enjoy this setup.


fix(datahub-upgrade): Fix Spring injection issue with datahub-upgrade

Addition of auth caused an injection failure in datahub-upgrade. This PR aims to fix this while also making sure all entity clients refer to the RestliEntityClient and not the JavaEntityClient
Checklist

[ ] The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
[ ] Links to related issues (if applicable)
[ ] Tests for the changes have been added/updated (if applicable)
[ ] Docs related to the changes have been added/updated (if applicable)

@jjoyce0510 Can you rerun that build for me? I see no reason why that action would fail.


There is not an image in clipboard! - Windows 10

Trying to paste an image and got an error.
There is not an image in the clipboard

Windows 10

I believe it is somehow connected with restrictions on my work laptop, which is in Active Directory (AD).
On my personal laptop, the extension works fine. Do we have any tutorials on how to debug such issues? Is there a console log we can look at? Are there any specific logs I can check? What specific permissions does the extension need?


Rendering multiple entities OnWorldObjectStreamIn/Out callback gets called multiple times

Description of the problem
When rendering multiple entities OnWorldObjectStreamIn/Out gets called multiple times for the second entity.
Two entities in the same range (doesn't work fine)
https://github.com/FabianTerhorst/coreclr-module/assets/46943169/68a6d58b-0af2-43c4-8693-290c86b58964
Single entity in the same range (works fine)
https://github.com/FabianTerhorst/coreclr-module/assets/46943169/cddcffff-9078-4abd-8446-f0c77323e5f9
Reproduction steps
Example;
There are within the same range two virtual entities.
Steps =>

Render the first virtual entity, it gets rendered correctly,
Render the second virtual entity and go toward the area of the second virtual entity

OnWorldObjectStreamIn/Out will be get called multiple times on the second virtual entity.
namespace Armonia.Client.Handler.House;

public class HouseMarkerHandler
{
    private Hashtable _markers;
    private readonly ChatService _chatService;

    public HouseMarkerHandler(ChatService chatService)
    {
        _chatService = chatService;
        _markers = new();
        Alt.OnWorldObjectStreamIn += OnWorldObjectStreamIn;
        Alt.OnWorldObjectStreamOut += OnWorldObjectStreamOut;
    }

    private void OnWorldObjectStreamIn(IWorldObject target)
    {
        if (worldObject is not IVirtualEntity entity)
            return;

        var entity = (IVirtualEntity) target;
        var position = entity.Position;

        position.Z -= 1.0f;

        entity.GetStreamSyncedMetaData<string>("id", out var id);

        _chatService.SendMessage($"Debug: Called OnStreamedIn with id {id}");
        if (_markers.Contains(id))
        {
            _chatService.SendMessage("Debug: Called OnStreamedIn but marker already exists");
            return;
        }

        var marker = Alt.CreateMarker(MarkerType.MarkerCylinder, position, new Rgba(247, 2, 1, 255), false, 0);
        _markers.Add(id, marker);
        marker.Scale = new Vector3(1.5f, 1.5f, 1.5f);
    }

    private void OnWorldObjectStreamOut(IWorldObject target)
    {
        if (worldObject is not IVirtualEntity entity)
            return;

        var entity = (IVirtualEntity) target;
        entity.GetStreamSyncedMetaData<string>("id", out var id);
        _chatService.SendMessage($"Debug: Called OnStreamedOut with id {id}");

        if (!_markers.Contains(id))
        {
            _chatService.SendMessage("Debug: Called OnStreamedOut but marker not found");
            return;
        }

        IMarker marker = (IMarker)_markers[id]!;

        _markers.Remove(id);
        marker.Destroy();
    }
}

Expected behaviour
OnWorldObjectStreamIn/Out with multiple entities should be called once when entering that area and once when leaving that area
(the actual behaviour of the single area)
Additional context
JS TEST
import * as alt from "alt-client";

const _streamedMarkers = new Map();

alt.on("worldObjectStreamIn", (worldObject) => {
    const id = worldObject.getStreamSyncedMeta("id");
    var position = new alt.Vector3(worldObject.pos.x, worldObject.pos.y, worldObject.pos.z - 1.0);

    alt.log(`Debug: Called OnStreamedIn with id ${id}}`);
    if(_streamedMarkers.has(id)) {
        alt.log("Debug: Called OnStreamedIn but marker already exists");
        return;
    }

    const marker = new alt.Marker(id, position, new alt.RGBA(247, 2, 1, 255), false, 0);
    _streamedMarkers.set(id, marker);
});

alt.on("worldObjectStreamOut", (worldObject) => {
    const id = worldObject.getStreamSyncedMeta("id");

    alt.log(`Debug: Called OnStreamedOut with id ${id}}`);

    if(!_streamedMarkers.has(id)) {
        alt.log("Debug: Called OnStreamedOut but marker not found");
        return;
    }

    const marker = _streamedMarkers.get(id);
    marker.destroy();
    _streamedMarkers.delete(id);
});

https://github.com/FabianTerhorst/coreclr-module/assets/46943169/63be72f7-7935-4e21-b2fd-57e389d110cc
Operating system
Windows 11 (10.0.22621 build 22621)
Version
15.0-dev683 (dev)
Crashdump ID
No response
Reproduction tested

[X] I confirm that I have made sure that this issue is also present on the newest dev version

your C# Code is not the same like JS
U Create Marker by OnWorldObjectStreamOut and delete on OnWorldObjectStreamIn

my bad i edited a little bit the code cause i wrote a wrapper on top of it

       Dictionary<string, object> marker1 = new()
        {
            {"id", "650f552569330d6c234bef88"},
        };

        Dictionary<string, object> marker2 = new()
        {
            {"id", "650f554669330d6c234bef8d"},
        };

        _pickupGroup = Alt.CreateVirtualEntityGroup(500);
        var virtualEntity1 = Alt.CreateVirtualEntity(_pickupGroup, new Position(-274.1802062988281f, -674.8087768554688f, 33.087890625f), 5, marker1);
        var virtualEntity2 = Alt.CreateVirtualEntity(_pickupGroup, new Position(-289.002197265625f, -672.5538330078125f, 33.037353515625f), 5, marker2);

@Doxoh

dear @kyro95 maybe dont write spaghetti code?


Android: There was an error with this build.

Always fails to build...
https://exp.host/@cadas/invest-crypto

[exp] Building...
[exp] Build started, it may take a few minutes to complete.
[exp] Build ID: 006ab65a-c0c4-4802-8968-fb3b1dafaf44
[exp] Run `exp build:status` to monitor it.

$ exp build:status
[exp] Making sure project is set up correctly...
/[exp] Warning: Not using the Expo fork of react-native. See https://docs.expo.io/.
[exp] Your project looks good!
[exp] Checking if current build exists...

[exp] ============
[exp] Build Status
[exp] ============

[exp] Android: There was an error with this build.

Is there a way to at least debug it?

We are maintaining all issues at https://github.com/expo/expo (common for all our tools) so please post there, as indicated in the issue template. Thank you. :)


Improve unpackString performance

This is an alternative approach to #1009.
I'm not convinced this is really worth doing, because it does add a decent amount of complexity no matter how you approach it. That being said, it does show a performance improvement and reduces the allocations when there is escaping.
name                       old time/op    new time/op    delta
UnpackString/Escaped-12      83.7ns ± 7%    78.2ns ± 3%   -6.50%  (p=0.000 n=10+9)
UnpackString/Unescaped-12    57.8ns ± 9%    50.4ns ±13%  -12.74%  (p=0.000 n=10+10)

name                       old alloc/op   new alloc/op   delta
UnpackString/Escaped-12       48.0B ± 0%     32.0B ± 0%  -33.33%  (p=0.000 n=10+10)
UnpackString/Unescaped-12     32.0B ± 0%     32.0B ± 0%     ~     (all equal)

name                       old allocs/op  new allocs/op  delta
UnpackString/Escaped-12        2.00 ± 0%      1.00 ± 0%  -50.00%  (p=0.000 n=10+10)
UnpackString/Unescaped-12      1.00 ± 0%      1.00 ± 0%     ~     (all equal)

/cc @charlievieth

Codecov Report

Merging #1011 into master will increase coverage by 0.04%.
The diff coverage is 92.85%.

@@            Coverage Diff            @@
##           master   #1011      +/-   ##
=========================================
+ Coverage   54.66%   54.7%   +0.04%
=========================================
  Files          41      41
  Lines        9844    9854      +10
=========================================
+ Hits         5381    5391      +10
  Misses       3437    3437
  Partials     1026    1026

Impacted Files
Coverage Δ

msg_helpers.go
58.46% <92.85%> (+0.95%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba5bfd0...bb8072a. Read the comment docs.

Escapes are relatively rare as well, so might be the wrong target to
optimize for
On Sat, 21 Sep 2019, 09:33 Codecov<EMAIL_ADDRESS>wrote:

Codecov https://codecov.io/gh/miekg/dns/pull/1011?src=pr&el=h1 Report
Merging #1011 https://codecov.io/gh/miekg/dns/pull/1011?src=pr&el=desc
into master
https://codecov.io/gh/miekg/dns/commit/ba5bfd029554f8f9c5215e84160d49fd02b8a397?src=pr&el=desc
will increase coverage by 0.04%.
The diff coverage is 92.85%.
[image: Impacted file tree graph]
https://codecov.io/gh/miekg/dns/pull/1011?src=pr&el=tree
@@            Coverage Diff            @@
master   #1011      +/-
=========================================

Coverage   54.66%   54.7%   +0.04%

=========================================
Files          41      41
Lines        9844    9854      +10
=========================================

Hits         5381    5391      +10
Misses       3437    3437
Partials     1026    1026

Impacted Files https://codecov.io/gh/miekg/dns/pull/1011?src=pr&el=tree Coverage
Δ
msg_helpers.go
https://codecov.io/gh/miekg/dns/pull/1011/diff?src=pr&el=tree#diff-bXNnX2hlbHBlcnMuZ28= 58.46%
<92.85%> (+0.95%) ⬆
Continue to review full report at Codecov
https://codecov.io/gh/miekg/dns/pull/1011?src=pr&el=continue.
Legend - Click here to learn more
https://docs.codecov.io/docs/codecov-delta
Δ = absolute  (impact), ø = not affected, ? = missing data
Powered by Codecov
https://codecov.io/gh/miekg/dns/pull/1011?src=pr&el=footer. Last update
ba5bfd0...bb8072a
https://codecov.io/gh/miekg/dns/pull/1011?src=pr&el=lastupdated. Read
the comment docs https://docs.codecov.io/docs/pull-request-comments.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/miekg/dns/pull/1011?email_source=notifications&email_token=AACWIW6ETHPDFCTGSNCRK7LQKXL5NA5CNFSM4IY5OLLKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7INL3Q#issuecomment-533779950,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AACWIWZG4OLQOCYKCBVITGDQKXL5NANCNFSM4IY5OLLA
.

~6- 10 % faster is nothing to sneeze at, /lgtm

LGTM


add function to disable item if they have a perm

items that grant permissions, should have an easy function to prevent repeat use.

never used gardle, and its not letting me build,
please add:
if (!itemDefinition.getAlreadyUsed().equals("") && event.getPlayer().hasPermission(itemDefinition.getAlreadyUsed())){
event.getPlayer().sendMessage(ChatColor.RED + "You have used this item!");
return;
}
after line 118 "if (!event.getPlayer().hasPermission("cmdi.item." + command))"
of CommandItemManager.java
also add:
@JsonProperty
private String alreadyUsed;
public String getAlreadyUsed() {
return alreadyUsed;
}
to ItemDefinition please <3

Modern permissions plugins allow you to give players and groups "negated permissions", i.e. take away permissions that they would usually inherit.


Add Windows build support

This commit adds Windows build support by utilizing vcpkg to build
dependencies, and CMake for the build system.
These changes rely on vcpkg to be built and located in the VCPKG_ROOT
environment variable, along with having Visual Studio 2019 installed.
These changes should not regress Linux compilation.

Much appreciated contribution! Thank you
(and also for spotting that memory leak)


Add support for Linux & MacOS

Graphics library will be a big pain.


Use Generics in testdatacontainer

@boris779 please review. according to effective java, this is the way to do.


Created university of Pisa fork

Hi, i made a fork to work with the university of Pisa portal. You can find all here: https://github.com/Guray00/destreamer-unipi
If you can i would like to be added to the list of avaiable versions!
Ps: I have done a credentials.txt to allow users to don't have to re-enter their credentials each time... It is not really safe but it works.

Will add a link to your fork in the README. I strongly suggest you implement keytar for storing passwords securely. It's very simple to use.
https://www.npmjs.com/package/keytar

All right! Thanks so much!


Add simple unit tests for quint exp conversion

followup to #2351
adds simple unit tests, following @gabrielamafra's suggestion to illustrate and validate basic logic

Codecov Report

Merging #2386 (a8c8af5) into main (c117f5c) will increase coverage by 0.20%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2386      +/-   ##
==========================================
+ Coverage   78.25%   78.46%   +0.20%
==========================================
  Files         441      441
  Lines       15093    15093
  Branches     2120     2120
==========================================
+ Hits        11811    11842      +31
+ Misses       3282     3251      -31

Impacted Files
Coverage Δ

...n/scala/at/forsyte/apalache/io/quint/QuintIR.scala
100.00% <ø> (ø)

...he/io/annotations/parser/CommentPreprocessor.scala
95.60% <0.00%> (-2.20%)
:arrow_down:

.../forsyte/apalache/tla/pp/ConstSimplifierBase.scala
96.55% <0.00%> (-1.15%)
:arrow_down:

.../forsyte/apalache/tla/typecomp/ScopedBuilder.scala
83.54% <0.00%> (+6.32%)
:arrow_up:

...ain/scala/at/forsyte/apalache/io/quint/Quint.scala
87.14% <0.00%> (+41.42%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


"editor.experimentalEditContextEnabled": true breaks new line indentation

Set "editor.experimentalEditContextEnabled": true
Open a file with some indented lines. Ex:

export function activate(context: vscode.ExtensionContext) {
	context.subscriptions.push(vscode.commands.registerCommand('mywiki.replyNote', (reply: vscode.CommentReply) => {
		replyNote(reply); // Put your cursor here
	}));

Put your cursor at the end of an indented line
Hit <enter>
🐛 instead of maintaining the indentation on the next line, the cursor is at the very beginning of the line

Hi, I am trying to reproduce the issue and currently not able to. Do you still this happening? Perhaps you have some other setting that could be changing your indentation level?
https://github.com/user-attachments/assets/fe1c4913-f630-4152-99f5-ba0f7fc8e218

Yep, it's still happening! It only happens when I set "editor.experimentalEditContextEnabled": true

Maybe it only happens on Windows?

Can confirm on Windows (latest Insiders, clean portable install).
Note how I need to add line break, go up and add indentation first, and then other lines still miss indentation.
https://github.com/user-attachments/assets/28489268-22bd-480b-b89c-b1fbd12a5774
If it helps I guess I first noticed something similar on Oct 14-15, not sure if it was earlier.

This seems to happen also on mac os on files where the return symbol is the carriage return, not the line feed. Looking into this.

Works on my machine™
Version: 1.96.0-insider
Commit: 50a2adc65b8bf6ba353c6927c2f1f19ce6701c4d
Date: 2024-10-29T19:03:58.958Z (4 hrs ago)

Same!


[CELEBORN-70][FOLLOWUP] Add epoch for each commitFiles request.

What changes were proposed in this pull request?

Fix the wrong logic of check if shuffle is regsitered
Add the same logic to pushMergedData about checking if a partition location has been hard split

Why are the changes needed?

What are the items that need reviewer attention?
Related issues.
Related pull requests.
How was this patch tested?
/cc @related-reviewer
/assign @main-reviewer

cc @AngersZhuuuu I have refined some logic, plz have a look

cc @AngersZhuuuu I have refined some logic, plz have a look.


build: Improve caching

What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Changelog

Please update the CHANGELOG.md under next version with high level changes in this PR.

Usage

You can potentially add a usage example below

# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"
Pre checks:

[ ] Make sure you read and followed Contributor guidelines
[ ] Did you write any new necessary tests?
[ ] Did you add or update any necessary documentation? Make sure to also update the NeMo Framework User Guide which contains the tutorials

Checklist when contributing a new algorithm

[ ] Does the trainer resume and restore model state all states?
[ ] Does the trainer support all parallelism techniques(PP, TP, DP)?
[ ] Does the trainer support max_steps=-1 and validation?
[ ] Does the trainer only call APIs defined in alignable_interface.py?
[ ] Does the trainer have proper logging?

Additional Information

Related to # (issue)

Hey @terrykong, this fixes the last issues to help with reliable caching. Unfortunately, it doesn't help super much as TRTLLM is the most expensive part (and follows Aligner). Let's still merge it since it's the right way of ensuring caching


Transaction handler

This pull request is to solve multi-statements in a transaction issue. In the previous implement, each query will implicitly begin a new transaction handler and implicitly aborts or commits itself. Compared to previous one, after you 'BEGIN' a transaction and before you 'COMMIT' that transaction, queries that you input will have same transaction handler. In addition, after 'BEGIN' a transaction, when a query in a transaction aborted, the whole transaction will be aborted and unless you input 'COMMIT' or 'ROLLBACK' in the terminal, any following queries cannot be executed.
The main update is in tcop.cpp. Transaction begins when traffic cop firstly receive a statement(TrafficCop::ExecuteStatement) and I push this transaction handler(concurrency::Transaction *) into a stack(tcop_txn_state) in order to pass required transaction handler when prepare statement(PrepareStatement), execute statement(ExecuteStatementPlan), commit transaction and so on.
Another important change is I declare a member variable (concurrency:: Transaction *) in SqlNodeVisitor. It is convenient to pass transaction handler in binder and insertQueryTree.
I also change some code in catalog.cpp, for example, GetTableWithName. If you cannot find that table, you won't abort that query on catalog level and only throw an exception on that level.
I also modified 10 test cases. In some cases, I replaced simple optimizer by optimizer and I changed other cases to apply to new version tcop.cpp.

Changes Unknown when pulling 901f5a3051b99e7ac9a3b0cfd948135ec4b2bc56 on haoxianghua:transaction_handler into ** on cmu-db:master**.

Changes Unknown when pulling 1b18fe02cc6372212778f078912124289feadcfd on haoxianghua:transaction_handler into ** on cmu-db:master**.

E: Failed to fetch http://ppa.launchpad.net/boost-latest/ppa/ubuntu/dists/trusty/main/binary-amd64/Packages  404  Not Found
E: Failed to fetch http://ppa.launchpad.net/boost-latest/ppa/ubuntu/dists/trusty/main/binary-i386/Packages  404  Not Found
E: Some index files failed to download. They have been ignored, or old ones used instead
Can you give me some hints how to solve this issue?
plus:
When I run 'CXX=g++-5 PELOTON_BUILD_TYPE=Release COVERALLS=Off', 3 test cases cannot pass, but these test cases can pass other 3 config.
Thank you very much!!!
@apavlo @yingjunwu @pmenon

Changes Unknown when pulling e066f84362a70d331fc05480b048bad01a9417b4 on haoxianghua:transaction_handler into ** on cmu-db:master**.

Changes Unknown when pulling 22d14ba2cfee28df20a07453ab58bcc100d60242 on haoxianghua:transaction_handler into ** on cmu-db:master**.

Changes Unknown when pulling 1bf39a491a1a354c2b7ac299f5c0eae2535cbdec on haoxianghua:transaction_handler into ** on cmu-db:master**.

Coverage decreased (-72.5%) to 0.0% when pulling 1a750c6865174ffaefb8fc6a63db664bc1f9c11a on haoxianghua:transaction_handler into 05fa4e123edb68d7e184ec6b75d9bfcf022421aa on cmu-db:master.

Coverage decreased (-0.2%) to 72.254% when pulling 32292195f3626dd790af500700ae268216a24588 on haoxianghua:transaction_handler into 05fa4e123edb68d7e184ec6b75d9bfcf022421aa on cmu-db:master.

@haoxianghua I will pass through the code again once you have addressed all the raised comments.

Coverage decreased (-0.2%) to 72.281% when pulling bf2402c1090a840a95b0ce5649a7a65056b864ad on haoxianghua:transaction_handler into 9ec5d87d212cc562337f7612feee13f825e87335 on cmu-db:master.

Coverage decreased (-72.5%) to 0.0% when pulling a264ab77ce24e9d9a81d216f37a5b18f96eb9b93 on haoxianghua:transaction_handler into 9ec5d87d212cc562337f7612feee13f825e87335 on cmu-db:master.

Coverage decreased (-0.2%) to 72.276% when pulling be754fdc96f5523ad857946c877ff36794d021f4 on haoxianghua:transaction_handler into 9ec5d87d212cc562337f7612feee13f825e87335 on cmu-db:master.

Coverage decreased (-0.2%) to 72.282% when pulling d057180ad6d2890adffe3e11116cae8330bb706a on haoxianghua:transaction_handler into 9ec5d87d212cc562337f7612feee13f825e87335 on cmu-db:master.

Coverage decreased (-0.2%) to 72.277% when pulling d057180ad6d2890adffe3e11116cae8330bb706a on haoxianghua:transaction_handler into 9ec5d87d212cc562337f7612feee13f825e87335 on cmu-db:master.

Coverage decreased (-0.2%) to 72.28% when pulling 0ed988f23468caf0cf68d02c01a64622a5a246a9 on haoxianghua:transaction_handler into 9ec5d87d212cc562337f7612feee13f825e87335 on cmu-db:master.

After talking to @haoxianghua, we find there exists some bugs in JDBC. So let's have a discussion in tmr's group meeting. @apavlo

@haoxianghua Run TPC-C on this PR to make sure that it doesn't crash and then we can merge this.

Coverage decreased (-0.2%) to 72.282% when pulling a1f2f1188170e3d8f335c85ef1765dfdcc5b5355 on haoxianghua:transaction_handler into bf6035938ccd895415a7b06cedb19a09df277fa0 on cmu-db:master.

Coverage decreased (-0.2%) to 72.266% when pulling 6488fdffcfb06cbad12900cfdcf533bbecb522e4 on haoxianghua:transaction_handler into 7e68bbd84bc781e2dd85771c95577eeb730cb52a on cmu-db:master.

Coverage decreased (-72.5%) to 0.0% when pulling c100f6a5c8f9faabe86c3bbdc4121c551946c67b on haoxianghua:transaction_handler into 7dc10d41fade8aee46517e7a89f8a200a79b68b4 on cmu-db:master.

Coverage decreased (-0.2%) to 72.267% when pulling b5aa2247a7fbf98bc5731285e41d3bafac46a135 on haoxianghua:transaction_handler into 7dc10d41fade8aee46517e7a89f8a200a79b68b4 on cmu-db:master.

Coverage decreased (-0.08%) to 72.389% when pulling 26d47244eb63de1ac7fbe8cd00d5d25642624278 on haoxianghua:transaction_handler into fed8d6ae15dc56368e6046132db788aad612ac4f on cmu-db:master.

Coverage decreased (-0.08%) to 72.393% when pulling 1f7709ec00263a1a3e94b2f3eed80519681687e2 on haoxianghua:transaction_handler into fed8d6ae15dc56368e6046132db788aad612ac4f on cmu-db:master.

Coverage decreased (-0.09%) to 72.381% when pulling cadd902c77049801a179c3925fe126f58630b91b on haoxianghua:transaction_handler into fed8d6ae15dc56368e6046132db788aad612ac4f on cmu-db:master.

Coverage decreased (-0.08%) to 72.389% when pulling 03f4180f8800af8393a2ed5c286f7d37316cb014 on haoxianghua:transaction_handler into fed8d6ae15dc56368e6046132db788aad612ac4f on cmu-db:master.

Coverage decreased (-0.03%) to 72.492% when pulling a7d6fb1da2ab710bc2af1b14152b462c7846eac8 on haoxianghua:transaction_handler into 4bf2d2a23ce3c065992f9c372cf6a88365df360a on cmu-db:master.

Coverage decreased (-0.04%) to 72.484% when pulling c14f3a16cdf6fe478c00823515ae5f4ea6e04f4c on haoxianghua:transaction_handler into 4bf2d2a23ce3c065992f9c372cf6a88365df360a on cmu-db:master.

Coverage decreased (-0.04%) to 72.537% when pulling c9cb5205b60ecc4da7268b1eb3b153a6b2fcc16a on haoxianghua:transaction_handler into 0f3ba1cb4f800580c699111b415d7fb05846e334 on cmu-db:master.

Coverage decreased (-0.05%) to 72.525% when pulling 1b66de0a0dbf9efd8bd44d2e1d0ec97a5a481fff on haoxianghua:transaction_handler into 0f3ba1cb4f800580c699111b415d7fb05846e334 on cmu-db:master.


Why the type ReactFlowStore's edges attribution been set to Edges instead of EdgeType

What platform were you using when you found the bug?

React Flow / Svelte Flow version:
Browser and version:
OS and version:

Live code example
No response
Describe the Bug
Why the type ReactFlowStore's edges attribution been set to Edges instead of EdgeType
Source Code
Steps to reproduce the bug or issue
Just confused  about a type
Expected behavior
I expected this
export type ReactFlowStore<NodeType extends Node = Node, EdgeType extends Edge = Edge> = {
    edges: EdgeType[];
}

Screenshots or Videos
No response
Additional context
No response

Thanks for bringing this up!  It should be EdgeType.


chore: migrate permission group class to bridge API

Description
Migrate the mongo criteria to bridge class API
Automation
/ok-to-test tags="tag.NewAction"
:mag: Cypress test results

[!TIP]
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/8357644945
Commit: f57eea5e174a3b97b2d2e68d41a0cae87f918596
Workflow: PR Automation test suite
Tags: tag.NewAction

Summary by CodeRabbit

Refactor

Improved query building logic in the server for enhanced performance and control flow.

PageServiceTest#createPageWithNullName passes locally. Triggered a rerun.


ByteSize() does not add the suffix for (0)

In non-zero cases, people know what the unit is. In zero-size cases, they don't.
In non-zero cases, printing will align one way. In zero-size cases, they'll align the other way:

    NAME    | UNCOMP SIZE | COMP SIZE | MODE |         MIME TYPE         |          MODIFIED AT          | ENCODING |   CRC    | METADATA?
+-----------+-------------+-----------+------+---------------------------+-------------------------------+----------+----------+-----------+
  .aa       |           0 |         0 | 0644 | application/octet-stream  | Sun, 28 Jul 2019 04:10:36 EDT | bzip2    | 811c9dc5 | false
  bb        |           0 |         0 | 0644 | application/octet-stream  | Sun, 28 Jul 2019 04:10:40 EDT | bzip2    | 811c9dc5 | false
  child/.dd | 29B         | 78B       | 0644 | text/plain; charset=utf-8 | Sun, 28 Jul 2019 04:10:58 EDT | bzip2    | b7b3c503 | false
  child/cc  | 29B         | 82B       | 0644 | text/plain; charset=utf-8 | Sun, 28 Jul 2019 04:10:56 EDT | bzip2    | 30eb8ad8 | false

So, I'll have to hack something together because this corner case isn't handled.
Seems related to #20

Thanks for pointing this out @dsoprea - we're pretty jammed at the moment and wondering if you'd be willing the make a PR for this?


Publish builds and toolchains to repo.saltproject.io

https://github.com/MKLeb/relative-environment-for-python/actions/runs/5326011082
Example test release

@dwoz , this isn't necessarily a code change, but I'm wondering if this might need a changelog?


[SuperEditor][SuperTextField] - Control IME character conversion

In running super_text_editor_testing on iOS I notice that iOS automagically converts " to opening double quote “. It'd be a nice feature to be able to turn off this conversion for specific usecases (like editing code, say).

In this sample interaction, the attribute value "123" should be syntax highlighted, but isn't because of the double quote mark replacement.

@angelosilvestre can you check whether this conversion is a Flutter IME configuration or not?

@matthew-carroll It doesn't seem that there is a conversion happening. On iOS, only the opening double quote is displayed on the software keyboard. To insert a normal double quote we need to press and hold the key.
https://github.com/superlistapp/super_editor/assets/7597082/819b0d45-b82b-4051-b27a-61203975af7b

@domesticmouse would you like to comment on Angelo's finding up above?

Ugh, user error strikes again


Remove mismatched placeholder in log

A simple change: the placeholder {} is mismatched (and misleading) as there is no argument for that. The next argument is a Throwable . I.e. the logger.warn here is of prototype:
void warn(String var1, Throwable var2);

it is already fixed in trunk.


After set completion, the round completion dialogue and the halfway point dialogue infinitely shows up.

The cause of this issue is me incorrectly checking if the remaining list is empty. Will be fixed soon.

I have pushed a fix to this bug. Let's hope the fix actually works.

I applied the same exact fix to setSettings().


Store encoding metadata

Currently, hypercore-fetch assumes that all text files are UTF-8 when returning a Content-Type header:
function getMimeType (path) {
  let mimeType = mime.getType(path) || 'text/plain; charset=utf-8'
  if (mimeType.startsWith('text/')) mimeType = `${mimeType}; charset=utf-8`
  return mimeType
}

In order to return the actual coding system for a file, we'd need to know how the file was encoded when it was written to the hyperdrive.
IIUC, the standard way to specify a file's encoding in a PUT request is in the Content-Type header, e.g., Content-Type: text/plain; charset=ISO-8859-1.
Once hypercore-fetch receives the file and its coding system, where should the encoding metadata be stored?
We could put it alongside the mtime metadata in entry.value.metadata.encoding.  WDYT?

On the topic, it looks like the python requests library uses latin-1 (not UTF-8) as the fallback for text/ media type files:
    if "charset" in params:
        return params["charset"].strip("'\"")

    if "text" in content_type:
        return "ISO-8859-1"

    if "application/json" in content_type:
        # Assume UTF-8 based on RFC 4627: https://www.ietf.org/rfc/rfc4627.txt since the charset was unset
        return "utf-8"


add working datascraping file

@dtomc I put the code I wrote yesterday into an ipython notebook and pushed it. Will you review my pull request?

@dtomc Thanks!


Yesno combine

More details to come, I just like draft PRs.
Currently stuck on the fact that questions is marked as not having any other elements because len(fields) == 0, which I guess is happening because I'm reassigning to fields. Don't remember what DA likes to do, I'll have to figure that out.

If you want to set up a time to chat on the blocker you raised today--some of the messy code--we can talk about how to refactor to get this finished a neat way. This will definitely be a big help for new developers as it comes up on many forms.

If you want to set up a time to chat on the blocker you raised today--some of the messy code--we can talk about how to refactor to get this finished a neat way. This will definitely be a big help for new developers as it comes up on many forms.


[ConstraintSystem] Relax the left-over information check in ComponentStep

Instead of crashing in release builds, let's simplify fail the
step and let type-checker produce a fallback diagnostic. Maintain
a trap in debug builds to make it easier to investigate the root
cause of the issue.
Resolves: rdar://56167233

@hamishknight I have removed redundant check you mentioned and added InvalidState flag to make sure that solving is aborted early and solutions are never produced, this should make sure that solving in release mode always ends up with a fallback diagnostic.

@swift-ci please smoke test

@hamishknight @hborla After thinking about this some more I think we can drop abort blocks all together because there it would be impossible now to miscompile, WDYT?

@xedin Yeah, I think it's fine to always report the error message instead of aborting. If we still want it to crash in this part of the code in a debug build, we could just put in an assert

@swift-ci please smoke test

Adjusted that, for debugging it would print the constraints in question so I just removed NDEBUG blocks.

I'd prefer if we crashed in a debug build to make it loud and obvious that we have a logic error, but yeah that could be done with an assert.

I think asking to file a bug is loud enough, that would also indicate where the error is better than crash report because not all tools capture stacktraces.

Hmm, won't we emit "type of expression is ambiguous without more context" for an expression with no solutions?

 I have completely forgot about that message assuming that forUndiagnosedError would always result in failed to produce a diagnostic ... message. Fixed now.

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please smoke test


The Secret "slack_hook" is invalid: metadata.name

Chart version:
Kubernetes version:
v1.18.6
Kubernetes provider: E.g. GKE (Google Kubernetes Engine)
bare-metal
Describe the bug:
Followning the official example results in error about DNS-1123
kubectl create secret generic slack_hook --from-literal=xpack.notification.slack.account.monitoring.secure_url='https://hooks.slack.com/services/asdasdasd/asdasdas/asdasd'
The Secret "slack_hook" is invalid: metadata.name: Invalid value: "slack_hook": a DNS-1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*')

Steps to reproduce:

create a secret with an underscore in it's name
view the error

Expected behavior:
To be able to create secrets for the snapshotting plugins (many of which have an underscore in their name) as in here:
https://discuss.elastic.co/t/adding-credentials-to-helm-chart/242420/2
Provide logs and/or server output (if relevant):
This can also be duplicated in under three minutes here:
https://labs.play-with-k8s.com/
and here:
https://www.katacoda.com/thoth/scenarios/duplicatednserror

Is there anyone out there who can help on this issue?  Surely I'm not the only one trying to do backups/snapshots.

bump

Hi @joshuacox,
Thanks for reporting this issue.
It seems that k8s don't accept _ in secrets name.
I guess this was working in previous k8s versions when we added this example to the doc, but k8s behavior changed since.
You can fix it by naming your secret slack-hook instead of slack_hook:
$ kubectl create secret generic slack_hook --from-literal=xpack.notification.slack.account.monitoring.secure_url='https://hooks.slack.com/services/asdasdasd/asdasdas/asdasd'
The Secret "slack_hook" is invalid: metadata.name: Invalid value: "slack_hook": a DNS-1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*')
$ kubectl create secret generic slack-hook --from-literal=xpack.notification.slack.account.monitoring.secure_url='https://hooks.slack.com/services/asdasdasd/asdasdas/asdasd'
secret/slack-hook created

#811 should fix the examples.


Move chaining todo item to "completed"

Should we also add "Move loaders off thread" and "Convert resolve from async to sync" (and perhaps an accompanying "Add async resolve to module module"?) to the Upcoming list?

Do you think, with the chaining being merged, it's worth discussing ambient loaders (and perhaps "should ambient loaders just be loaders", as I recall @cspotcode suggested it and we didn't recall why it'd be best avoided)? I would like to try to make a prototype soonish, if there's consensus on the general design.


Should pub-sub delivers events concurrently?

In what area(s)?

/area runtime

/area operator
/area placement
/area docs
/area test-and-release

Ask your question here
I started using Dapr pub-sub in one of my projects and I have noticed that for couple of pubsub message bus I used (redis and azure service bus ) It always process messages sequentially. Should it be changed to concurrently or at least have configuration to decide whether to use in concurrent event processing or sequential ?
@yaron2 might be able to answer that considering the fact that I have already raised it to him on Dapr community

I think we should enforce implementations in contrib to deliver asynchronously with the option of setting concurrency via config.
Today, this is done on a per implementation basis, but we can (and should IMO) treat concurrency in the runtime and remove that burden from individual implementations.

I think we should enforce implementations in contrib to deliver asynchronously with the option of setting concurrency via config.
Today, this is done on a per implementation basis, but we can (and should IMO) treat concurrency in the runtime and remove that burden from individual implementations.

Sound correct to me.


Timeout on second request

I'm using a dell r610 with ipmi 2.0 support. First off, the library doesn't work in a few areas because the rmcp protocol specified all fields need to be big endian encoded. IPMI spec says fields need to be little endian.
I'm not super familiar with the session management which is why I appreciated your library handling that for me. However, I'm not sure if the session is working fully either. Once I'm able to establish a session (had to tweak the endianess) I can only send 1 command. When I send the next command the rmcp endpoint times out. I assume this is session related since that would be the only thing that would change between requests. Would definitely appreciate some guidance here.
Do you have a link to the spec docs you used when writing this library?

I actually figured it out.
According to the spec until a session is established the sequence number should be set to 0. In the library [here] (https://github.com/datdenkikniet/ipmi-rs/blob/9bc9f9e4fb711fe37feaeb38ce321a9d7d7cf172/src/connection/impls/rmcp/mod.rs#L300), you increment the sequence number on every request even before a session is established like here and then here.
A simple solution was to increment the sequence number if the session_id was no longer 0. Something simple like this will work (mind the sloppiness).
let session_sequence = match self.state.session_id {
  0 => self.state.request_sequence,
  _ => {
    // we want to increment first because when we established
    // the session id during the challenge that's the initial sequence number of 0
    self.state.request_sequence = self.state.request_sequence.wrapping_add(1);
    self.state.request_sequence
  }
};

I have now merged #3 which should address this issue. Please re-open if that is not the case :)


KDE: update Plasma and Applications

Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] OS X
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

This PR updates Plasma to 5.6.4 and Applications to 16.04.1. I've tested the desktop and several applications.
cc @ttuegel

note that it didn't fix #15450 for me.

Did you build everything, i.e.
$ nix-build -A kde5.plasma
$ nix-build -A kde5.applications

or just test the updated desktop?

BTW, KDE Frameworks 5.22 is due to be released today, so I will probably merge this PR at the same time as I update Frameworks, just to avoid Hydra doing a lot of pointless work.

Ah, nice. No, didn't build everything.

Did you mean to close this?
Everything builds for me. Also, it looks like upstream is going to drop the ball on this release date, so I will just merge this, if closing it really was accidental. (I do that all the time, the comment/close buttons are in the wrong order.)

@ttuegel yes and no, I had misread your e-mail.


Job City Field is empty in the API Response for c4media

ENVIRONMENT: production
URL: https://peviitor.ro
Browser: Brave
Version: 120
Device: Desktop
OS: Windows 10
STEPS TO REPRODUCE:

Make an API request for the c4media jobs on peviitor API
Pay attention to the missing job cities from the APIresponse

EXPECTED RESULTS:
The job city is displayed for every job in the job city field within the API response for the c4media
ACTUAL RESULTS:
The job city field is empty for every job within the API response
Attachments:

@RaresCode hello! Please retest

Retested, it seems fine


Copy package.json to esdoc output breaks the application

Hi,
I relly like the esdoc project and I am happy that i found this project.
But while using it in my react native application the compile process always copies the whole package.json.
So my package.json is in the root and in the subfolder out/esdoc. When i now use yarn start this breaks because yarn finds multiple definitions.
My current esdoc config is:
{
  "source": "./app",
  "destination": "./out/esdoc",
  "package": "./package.json",
  "includes": ["\\.(js|jsx|es6)$"],
  "excludes": ["(node_modules|bower_components|./package.json)"],
  "includeSource": false,
  "lint": false
}

Thanks, maybe it is my fault.

I have similar problems with ReactNative projects.
This workaround works for me (my documentation generated in ./doc folder):
rn-cli.config.js
'use strict'

const blacklist = require('react-native/packager/blacklist')

const config = {
  getBlacklistRE() {
    return blacklist([
      /doc\/.*/
    ])
  }
}

module.exports = config

Plus .eslintignore for eslint, because *.js files also copied. Probably better way to deal with this is renaming copied files in generated documentation folder. For ex. package.json can be package.json.source, index.js -> index.js.source etc...

Hmm it does not work for me. Is a registration of th ern-cli.config.js file required? Sorry never used this configuration to blacklist something.
But thanks for the hint :)

Format of rn-cli.config.js depends on version of react-native, you can see default config (node_modules/react-native/local-cli/default.config.js for react-native 0.39.2) and track required parameters format from here. Teretically react-native should automatically find this file in project root.

You can use a plugin to remove the package.json.
The plugin rough code.
remove-package-json-plugin.js
exports.onComplete = function(ev) {
  fs.unlinkSync(yourPackageJSONPath);
};

esdoc.json
{
  "source": "./src",
  "destination": "./doc",
  "plugins": [
    {"name": "./remove-package-json-plugin.js"}
  ]
}

Please see here for more info.

reopen if is problem.


feat(function): switch to function, add renovate, bump providers

Description of your changes

enable renovate
bump configurations
bump up

Fixes #
I have:

[x] Read and followed Upbound's contribution process.
[x] Run make reviewable to ensure this PR is ready for review.
[x] Added backport release-x.y labels to auto-backport this PR, as appropriate.

How has this code been tested
--- PASS: kuttl (1005.69s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/case (1005.20s)
PASS
17:18:41 [ OK ] running automated tests

/test-examples


Integrate CKeditor

Integrate http://ckeditor.com/ as a main text editor instead of TinyMCE. Main reasons are support of copy-paste image uploads and better mobile support. Also development of the editor is more dynamic than TinyMCE.
Upload of images via clipboard paste should also add them to the Trident's attached images list (trident file-manager), for cases when it needs to be used as post  thumbnail, or re-used via future file-manager.

https://github.com/unaio/una/issues/479


[Registration] No Automatic Sign In after Sign Up

I've seen a solution where the RegistrationsController was overridden (specifically, the create action) and a single line (https://github.com/plataformatec/devise/blob/master/app/controllers/devise/registrations_controller.rb#L19) should be changed. There were other similar solutions on the net, but I didn't find any clear/working one.
Help?

Well, I did what Carlos said before, but now I also commented the alert message (it was not logging in, but it was showing something like "success logging in!"). Anyway, thanks Carlos (and sorry about posting here). And by the way, is the mailing list you're talking about http://groups.google.com/group/plataformatec-devise?pli=1 ?
Jose, I just wanted the user not to sign in automatically after sign up, but now it's working. Thank you anyway :)

@fabioquixada great! Glad to know it's working. And yeah, the mailing list is that one you've sent, please feel free to send any question there..

I have got same issue, i wouldn't like that user isn't sign in when he makes sign up, i'm using confirm token with gmail, so i would like that user has to go into his email and to make click in confirm link and then that user can make sign in.


(fix) disable GPU crashes on Windows 10 LTSC since 3.5.2

Describe the bug
If "Disable GPU" is enabled, Rocket.Chat won't start until you terminate the process and start the exe.
What operating system and which version?
Windows 10 LTSC
Which version of Rocket.Chat.Electron (Electron/Desktop)?
3.5.2 upwards
Is there any setting relevant changed?
Disable GPU setting
To Reproduce
Steps to reproduce the behavior:

Run 3.5.2 (or higher)
Click on 'File'
Click on 'Disable GPU'
See error

Expected behavior
Rocket.Chat Client should restart in disabled GPU mode
Additional context
The problem was introduced with changes in the main.ts file in 3.5.2
(https://github.com/RocketChat/Rocket.Chat.Electron/pull/2153)
The line "await app.whenReady();" was moved from line 41 to 35.
If I revert this change in Visual Studio it works again.

Please test if the lastest release (3.7.0) has solved this issue.

Please test if the lastest release (3.7.0) has solved this issue.

It's not fixed yet, app stays on background and need to be ended using task manager, rerunning the app would not disable GPU.

I can confirm what YvvkiRika said. The problem still persists.


add mean calculation function

Hi,
I have added the function for calculating the mean of a csv file with two columns (x,y) as mentioned in issue #11.

great job @AAnirudh07


What's the best way of doing conditional joins?

Hey,
I've found the docs on relations that suggest to do joins like this:
const persons = await db
  .selectFrom('person')
  .selectAll('person')
  .select((eb) => [
    withPets(eb),
    withMom(eb)
  ])
  .execute()

I'm wondering, what would be the best way to do the joins conditionally?
Basically, I only want to join X if the matching param is provided. Sorry if that's super simple and I've missed it in the docs somewhere :)

Those don't actually create joins, but subqueries. But I'm guessing by joins, you mean fetching related items as nested objects/lists? Probably the easiest way to do that conditionally is to use the $if method. https://kyse.link/?p=s&i=plFcR0KGGRDlhtcHpOjt

There's a recipe on the subject https://kysely.dev/docs/recipes/conditional-selects.

Ahhh I see! That makes sense thanks :)


[BUG] Vault changes after rename

Describe the bug
When changing vault name, the vault changes.
Expected behavior
After rename, the amended vault is still selected in Home View
-version 35

https://github.com/vultisig/vultisig-ios/assets/1700699/8b306b61-680b-4098-99f6-2850533eca3e
@realpaaao can you show me what are you expecting?

@enriquesouza It happens when going directly from home view into settings.
https://github.com/vultisig/vultisig-ios/assets/167348323/a472eed8-3eec-441e-990e-f81c9db4f4a8

It does not happen to me, maybe it is because I don't have as many wallets as you do.

Found it, if you have more than 2 wallets it happens

This is because the selected vault's name has been saved , but since the name get changed , so it doesn't match with the saved vault name


#550 set default name when creating dataset

Description

Set default name when creating dataset
Related Issue :

#550
How Has This Been Tested?

Check default name when creating dataset (last step in creation)

create dataset with csv file ->  filename (CSV)
create dataset with excel file ->  filename - sheetname (EXCEL)
create dataset with staging -> tablename (STAGING)
create dataset with db -> tablename (TYPE OF DATABASE eg. MYSQL)

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My code follows the code style of this project. it will be added soon
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document. it will be added soon
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Additional Context

run build
deploy to 4


adds support for uploading HTML & version to 'root' as well as version dir

We want to have a version.json and the html page be both in the specific version's directory as well as in the 'root' directory. This allows for easy access to the latest version, but also have a version-specific download page.
This would change the behavior of anyone using html_in_folder: true since we'll be uploading to the root dir now unless they set html_in_root: false

Hi @joshdholtz, are there any plans for merging this PR? This is a feature I would find useful, and I would be happy to take over and bring this PR to where it needs to be to get merged.

+1 I would also find this useful.


Document the need for an IAM user/credentials

The README doesn't mention the need for a user, or which permissions to assign to a user. I've assigned admin permissions. But it'd also be nice if the README taught me how to do those things.

Thanks very much for this feedback @luan, we're marking this repo as being under heavy re-construction, and we'll incorporate this information in the new incarnation. (I'll copy-paste this message to the other issues you opened, for anyone in the future coming across any of them).


Orientation, forced portrait mode, HDMI output landscape fail

I'm trying to Output portrait mode so that I can rotate my larger monitor vertically while mirroring. However the HDMI output always shows portrait output. I need the HDMI output to remain in landscape mode while displaying and unrotated version of portrait orientation. So that I may manually rotate the monitor myself resulting in a vertical full-screen picture. Please let me know how to fix the issue

In other words I need to disable rotation for HDMI output in portrait orientation.  the results should be a full screen version of portrait mode rotated at 90 degrees.

In other words I need to disable rotation for HDMI output in portrait orientation. the results should output a full screen version of portrait mode rotated at 90 degrees.

Same problem here！I want to use my monitor vertically and have my phone projected on it. The hdmi output rotation is disabled in the latest version, so the issue 2 yrs ago still persist. Can anyone fix this?

Any updates on this? Why is the HDMI output option greyed out?


go-controller: use exec interface to run external binaries to help unit-testing

@shettyg @rajatchopra this is the first bit.  An alternate approach is to make all exec commands filter through a central file that has a global for the runner, but that makes it a bit harder to manage unit testing.
Follow-on PR will more extensively test pkg/cluster.

This would also help if/when we move to Go bindings for OVN DB since that'll likely need a context object passed around too.

Will take a look.

@shettyg how about this approach instead?

@shettyg yeah, haven't tested with Vagrant but I will do that today and fix.

@shettyg for the unit test, FakeExec is an object that represents all shell commands that the code will run, along with the output (or error) that command should return.  The commands are expected to be run in exactly the order they are added to the FakeExec. This way we can verify that changes we make to the code produce the expected result. It does mean more maintenance of the testcases when we change the other code, but this forces us to be sure that the nbctl/vsctl commands are exactly what we want them to be and that they are in the right sequence.
		fakeCmds := ovntest.AddFakeCmd(nil, &ovntest.ExpectedCmd{
				Cmd:  "ovs-vsctl",
				Args: fmt.Sprintf("--timeout=5 set Open_vSwitch . external_ids:ovn-encap-type=geneve external_ids:ovn-encap-ip=%s external_ids:k8s-api-server=\"%s\" external_ids:k8s-api-token=\"%s\" external_ids:k8s-ca-certificate=\"%s\"", nodeName, apiserver, token, cacert),
			})

Each command we expect the ovnkube code to run for a given testcase should get an ExpectedCmd object added to the FakeExec. The ExpectedCmd should give the expected command-line args that ovnkube will run the program with, and also the response that the command should provide back to ovnkube.  That also lets us test error handling.
			fexec := &fakeexec.FakeExec{
				CommandScript: fakeCmds,
				LookPathFunc: func(file string) (string, error) {
					return fmt.Sprintf("/fake-bin/%s", file), nil
				},
			}

All the ExpectedCmds then get added as a list to the FakeExec, along with a find-the-executable function which we just fake out.

@dcbw
In config.go, since we pass "exec" to InitConfig(), why not just store it a config variable in there and re-use it whenever needed?

For the unit test, if the following is written:
fakeCmds = ovntest.AddFakeCmd(fakeCmds, &ovntest.ExpectedCmd{
           Cmd:    "ovs-vsctl",
            Args:   "--timeout=5 --if-exists get Open_vSwitch . external_ids:ovn-nb",
            Output: "tcp:<IP_ADDRESS>:6441",
})

The test framework will verify that the first shell command called will be ovs-vsctl and it will have Args as mentioned in the "Args" variable? And once this is verified, the test framework will return ""tcp:<IP_ADDRESS>:6441" as the output?

In config.go, since we pass "exec" to InitConfig(), why not just store it a config variable in there and re-use it whenever needed?

@shettyg good idea, that solves the SetDBAuth()/GetExec() problem too.  Done.

For the unit test, if the following is written:
fakeCmds = ovntest.AddFakeCmd(fakeCmds, &ovntest.ExpectedCmd{
Cmd:    "ovs-vsctl",
Args:   "--timeout=5 --if-exists get Open_vSwitch . external_ids:ovn-nb",
Output: "tcp:<IP_ADDRESS>:6441",
})
The test framework will verify that the first shell command called will be ovs-vsctl and it will have Args as mentioned in the "Args" variable? And once this is verified, the test framework will return ""tcp:<IP_ADDRESS>:6441" as the output?

@shettyg correct.  fakeCmds is the array of all shell commands that the testcase expects to be called, along with their arguments, output, and any any error to return (to test our error-handling paths).  Then at the end the testcase verifies that no more commands exist in fakeCmds.

@dcbw
Vagrant still does not work.
vagrant@k8smaster:~$ sudo cat /var/log/openvswitch/ovnkube.log
time="2018-06-16T00:06:16Z" level=warning msg="bootstrapping /etc/openvswitch/ovnnb-ca.cert CA certificate failed"
time="2018-06-16T00:06:17Z" level=warning msg="bootstrapping /etc/openvswitch/ovnsb-ca.cert CA certificate failed"
time="2018-06-16T00:06:17Z" level=error msg="Failed to create a single common distributed router for the cluster, stdout: \"\", stderr: \"ovn-nbctl: ssl:<IP_ADDRESS>:6641: database connection failed (Protocol error)\\n\", error: exit status 1"
time="2018-06-16T00:06:17Z" level=error msg="Failed to setup master (exit status 1)"
time="2018-06-16T00:06:17Z" level=error msg="exit status 1"

@shettyg vagrant works for me after https://github.com/openvswitch/ovn-kubernetes/pull/368

@dcbw
I did not have the keyerror. But even with today's updates in this pull request, vagrant does not work for me. I am using ssl.

@shettyg are you just doing "vagrant up --provider=virtualbox"?  That's all I'm doing.

@dcbw
I am modifying the vagrant's 'git clone'  with your branch.  I don't think there is any base image issue here. (A vagrant destroy followed by 'vagrant up k8s-master')

@shettyg nope, still doesn't happen after update of the box image.  Can you share your full "vagrant up" output with me?  It looks like the OVN databases are failing to start...  Also maybe /var/log/openvswitch/ovsdb-server-nb.log

@shettyg got the error finally, looking into it.

@shettyg updated with unit tests for OVN setup now.

@dcbw
What was the problem?

What was the problem?

@shettyg a mistaken removal of "list nb_global" args in the ensureCACert() function to bootstrap the CA cert.  I added unit tests for all that code in the lastest push from Monday.

@shettyg thanks!

This PR has broken the windows cluster. We probably need to revert to see what all is broken.

Nevermind the revert. Fixed by #373


SameSite option document is not updated

On the flask document page, it writes,
SameSite restricts how cookies are sent with requests from external sites. Can be set to 'Lax' (recommended) or 'Strict'. Lax prevents sending cookies with CSRF-prone requests from external sites, such as submitting a form. Strict prevents sending cookies with all external requests, including following regular links.
However, it has supported 'None' as a valid value.

It will be updated the next time the Flask docs are rebuilt.


Provide non-minimized dist CSS file

There is non-minimized js file, but not CSS file. This makes it hard to include it into systems like Meteor which does its own minimization in production, but during development you get nice non-minimized CSS.

Hey @mitar , if it's helpful for you, the project does include its un-minified SCSS here, which is then used to produce the minified CSS.
I would argue that it would be a bit of a mistake to provide the un-minified CSS as it is the SCSS which is developed and maintained, not the CSS (so if you were to do some great work with the styles, it would be way more helpful to submit a pull request for the SCSS than for a new and unmaintained CSS file).

Of course, this is why CSS would be in dist directory, make it clear it is an output. Pull requests should be still against SCSS, of course. You write that also in the readme or contribution guide. But providing CSS allows one to directly use it in websites, and have debugging to understand where something is happening.

We can include that within the next build

Thanks!


Very critical bug in javascript parser 2.0.0+

Buffers are corrupted after sending one more command. Example:
var redis  = require('redis'),
    client = redis.createClient({return_buffers: true});

client.set('s1', 'a'.repeat(65527));
client.set('s2', 'b'.repeat(65527));

client.get('s1', function(err, buf) {
	console.log(buf[0]); //prints 97, it's OK

	client.get('s2', function() {
		console.log(buf[0]); //prints 98, but must print 97
	});
});

This is starting with javascript parser 2.0.0. The bug occurs when buffer.length >= 65527 (and in 50% cases when buffer.length >= 65517).
Example 2:
var redis  = require('redis'),
    client = redis.createClient({return_buffers: true});

client.set('s1', 'a'.repeat(65527));
client.set('s2', 'b'.repeat(65527));

client.get('s1', function(err, buf) {
	setImmediate(function() {
		console.log(buf[0]); //prints 98, but must print 97
	});
});
client.get('s2');

In the second example bug occurs only in javascript parser 2.0.1+ (not 2.0.0).

I'm also facing problems in reading buffer with { return_buffers: true } It looks like corrupted.

Fixed with v.2.0.2.
I'm very sorry for this :unamused:


doom sync does not run when literate is enabled on FreeBSD

What did you expect to happen?
doom sync to sync the changes made in config.org
What actually happened?
doom sync successfully tangles config.org, reports that it is restarting and then silently returns to the shell prompt.
Output:
$ doom sync --debug
> Compiling your literate config...
  - Tangled 1 code block from config.org.oTysjf
  - Restarting...
$

Additional details:

Latest Doom Emacs e3750dbf66896eb4a88aa39789e48f9cb5d690ab
Emacs version 27.1
FreeBSD 12.1 Operating System

Steps to reproduce:
1 Login to a FreeBSD system, install emacs-devel-27.1 package
2. Clone latest version of doom emacs
3. Enable literate in the init.el file
4. Create config.org
5. Run doom sync
System information:

((emacs
  (version . "27.1")
  (features . "XPM JPEG TIFF GIF PNG RSVG CAIRO SOUND DBUS GSETTINGS GLIB NOTIFY KQUEUE ACL GNUTLS LIBXML2 FREETYPE HARFBUZZ M17N_FLT LIBOTF ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS JSON PDUMPER LCMS2 GMP")
  (build . "Aug 24, 2020")
  (buildopts "--disable-build-details --localstatedir=/var --with-x --enable-acl --with-cairo --with-dbus --without-gconf --with-gif --with-gnutls --with-gsettings --with-x-toolkit=gtk3 --with-harfbuzz --with-jpeg --with-json --with-file-notification=kqueue --with-lcms2 --with-m17n-flt --without-imagemagick --with-mailutils --with-modules --with-sound=oss --with-libotf --with-png --with-toolkit-scroll-bars --with-rsvg --with-threads --with-tiff --with-xft --with-xim --with-xml2 --with-xpm --without-xwidgets --x-libraries=/usr/local/lib --x-includes=/usr/local/include --prefix=/usr/local --mandir=/usr/local/man --disable-silent-rules --infodir=/usr/local/share/emacs/info/ --build=amd64-portbld-freebsd12.1 'CFLAGS=-O2 -pipe  -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing ' 'CPPFLAGS=-isystem /usr/local/include' 'LDFLAGS= -fstack-protector-strong -L/usr/local/lib '")
  (windowsys . batch)
  (daemonp . server-running))
 (doom
  (version . "2.0.9")
  (build . "HEAD -> develop, origin/develop, origin/HEAD e3750dbf6 2020-08-23 18:48:50 -0400")
  (dir . "/usr/home/thawes/.config/testdoom/"))
 (system
  (type . berkeley-unix)
  (config . "amd64-portbld-freebsd12.1")
  (shell . "/usr/local/bin/bash")
  (uname . "FreeBSD 12.1-RELEASE FreeBSD 12.1-RELEASE r354233 GENERIC  amd64")
  (path "~/.local/bin" "~/.cargo/bin" "~/programs/share/golang/bin" "~/programs/golang/current/bin" "~/programs/sbin" "~/programs/bin" "~/.roswell/bin" "~/.local/bin" "~/perl5/bin" "~/.local/bin" "/usr/local/gerbil/bin" "/sbin" "/bin" "/usr/sbin" "/usr/bin" "/usr/local/sbin" "/usr/local/bin" "~/bin" "/usr/local/libexec/emacs/27.1/amd64-portbld-freebsd12.1"))
 (config
  (envfile . envvar-file)
  (elc-files . 0)
  (modules :completion company ivy :ui doom doom-dashboard doom-quit hl-todo modeline ophints (popup +defaults) vc-gutter vi-tilde-fringe workspaces :editor (evil +everywhere) file-templates fold snippets :emacs dired electric undo vc :checkers syntax :tools (eval +overlay) lookup magit :lang emacs-lisp markdown org sh :config (default +bindings +smartparens))
  (packages "n/a")
  (unpin "n/a")
  (elpa "n/a")))

This is a duplicate of #3746


Timezone handling in V2 differs from V1 and does not always work with pandas

Initial Checks

[X] I confirm that I'm using Pydantic V2

Description
I've updated my code to V2 and found an unexpected behaviour when working with pydantic objects (timezone-aware timestamps/datetimes) and pandas. I have a list of pydantic objects and I have to convert it to pandas DataFrame. When you run minimal reproducible example, both should work in V1 and V2. But both use different tzinfo and the final DataFrame is not able to handle it (lose the original data type).
Is it expected change of behavior? Or is it issue on pandas side?
Details of running the code
V1 version
Output of m1 (note tzinfo=datetime.timezone.utc)
MyModel(ts=datetime.datetime(2023, 7, 1, 10, 0, tzinfo=datetime.timezone.utc))
Everything preserve type:
d1.dtypes
# ts    datetime64[ns, UTC]
# dtype: object

d1.ts.dt.tz
# datetime.timezone.utc

df_concat.dtypes
# ts    datetime64[ns, UTC]
# dtype: object

df_concat.ts.dt.tz
# datetime.timezone.utc

V2 version
Output of m1 (note tzinfo=TzInfo(UTC))
MyModel(ts=datetime.datetime(2023, 7, 1, 10, 0, tzinfo=TzInfo(UTC)))
d1 pandas type is correct, although the tz is different compared to results in V1. Concatenation does not preserve datetime type:
d1.dtypes
# ts    datetime64[ns, UTC]
# dtype: object

d1.ts.dt.tz
# TzInfo(UTC)

df_concat.dtypes
# ts    object
# dtype: object

Example Code
import pandas as pd
from datetime import datetime
from pydantic import BaseModel

class MyModel(BaseModel):
    ts: datetime

m1 = MyModel(ts="2023-07-01T10:00:00Z")
m2 = MyModel(ts="2023-07-02T10:00:00Z")

# note: dict is used here instead of newer model_dump so this example runs in V1 as well
d1 = pd.DataFrame([m1.dict()])
d2 = pd.DataFrame([m2.dict()])

df_concat = pd.concat([d1, d2])

Python, Pydantic & OS Version
V1:
pydantic version: 1.10.9
python version: 3.10.9 (main, Mar  8 2023, 10:47:38) [GCC 11.2.0]
platform: Linux-<IP_ADDRESS>-microsoft-standard-WSL2-x86_64-with-glibc2.35
optional deps. installed: ['typing-extensions']

V2:
pydantic version: 2.0.2
pydantic-core version: 2.1.2 release build profile
python version: 3.10.9 (main, Mar  8 2023, 10:47:38) [GCC 11.2.0]
platform: Linux-<IP_ADDRESS>-microsoft-standard-WSL2-x86_64-with-glibc2.35
optional deps. installed: ['typing-extensions']

Selected Assignee: @Kludex

This is not reproducible on the latest Pydantic version. We must have fixed it on https://github.com/pydantic/speedate at some point.


How to cite sherpa-ncnn in my conference paper?

I want to cite sherpa-ncnn in my new conference paper. How to cite this in IEEE reference format?

How about the following one?
@software{sherpa-ncnn-2022,
  author = {the Next-gen Kaldi team},
  title = {sherpa-ncnn},
  url = {https://github.com/k2-fsa/sherpa-ncnn},
  version = {0.0},
  year = {2022},
}


Add optional config entries for my.cnf variables

federated: enable accessing tables on other mysql server instances
read_rnd_buffer_size: used for some sorts to optimally read rows after the sort

@n3bulous thank you very much for this! I have rebased it on top of the latest master and merged it in as #262.


bug: Gradual slowdown when reading signals in callbacks passed as props

I have tested this in https://github.com/DioxusLabs/dioxus/pull/1791, but I don't know if it also affects develop.
It seems to be caused because of reading in L29, and somehow L18 "fixes" temporarily the issue until it starts slowing down again
Code:
#![allow(non_snake_case)]
use std::{rc::Rc, time::Duration};

use dioxus::prelude::*;
use dioxus_core::NoOpMutations;
use tokio::time::{sleep, Instant};

fn main() -> Result<(), Box<dyn std::error::Error>> {
    fn app() -> Element {
        let values = use_signal(|| ["Hello, World!"].repeat(800));
        let schedule_update = schedule_update();

        use_hook(|| {
            spawn(async move {
                loop {
                    // This "fixes" the slowdown temporarily
                    sleep(Duration::from_secs(10)).await;
                    schedule_update();
                    println!("Again!");
                }
            });
        });

        rsx!(VirtualScrollView {
            length: values.read().len(),
            builder: Rc::new(move |index| {
                // Uncomment the L28 and comment the L29 and it will not lag
                // let value = "Hello, World";
                let value = values.peek()[index];
                rsx!(
                    p {
                        key: "{index}",
                        height: "25",
                        width: "100%",
                        "{index} {value}"
                    }
                )
            })
        })
    }

    #[derive(Props, Clone)]
    pub struct VirtualScrollViewProps {
        pub length: usize,
        pub builder: Rc<dyn Fn(usize) -> Element>,
    }

    impl PartialEq for VirtualScrollViewProps {
        fn eq(&self, other: &Self) -> bool {
            self.length == other.length && Rc::ptr_eq(&self.builder, &other.builder)
        }
    }

    #[allow(non_snake_case)]
    pub fn VirtualScrollView(props: VirtualScrollViewProps) -> Element {
        let mut window = use_signal(|| (0..50));

        if window.read().end >= props.length {
            window.set(0..50);
        } else {
            spawn(async move {
                sleep(Duration::from_millis(1)).await;
                window.with_mut(|v| *v = v.start + 50..v.end + 50);
            });
        }

        let children = window.read().clone().map(|i| (props.builder)(i));

        rsx!({ children })
    }

    tokio::runtime::Builder::new_current_thread()
        .enable_all()
        .build()?
        .block_on(async {
            let mut vdom = VirtualDom::new(app);

            let _ = vdom.rebuild(&mut NoOpMutations);
            loop {
                let mut now = Instant::now();
                // wait for the vdom to update
                vdom.wait_for_work().await;

                // get the mutations from the vdom
                let mutations = vdom.render_immediate(&mut NoOpMutations);

                println!("{}", now.elapsed().as_millis());
            }
        })
}

Thanks for the bug report. This should be fixed now. We were not properly removing the borrow location when dropping a ref from read/peek.
Fixed by https://github.com/DioxusLabs/dioxus/pull/1791/commits/93adb35cfa9b6e9f006c028803d801b871e7236b


Added ContainerState to the TaskStatus message

As we move to a N-container world, we need some way to
report how each container is running.
This expands the Titus API to include the analogous API to the
k8s container status:
https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.19/#containerstatus-v1-core
We don't need everything here, I'm just getting started with
name and health status.
The actually k8s ContainerStatus via the pod object will still
be the transport for this data! It is just the control plane
needs a way to bubble it up, and eventually show it to things
like the Titus UI and Spinnaker.

@amitaekbote / @corindwyer can you take a look at this one?
It should be safe to ship as-is, and if shipit, I would volunteer to do the control-plane work to take in the existing pod/container status messages and enrich them with more info here (for N-container status stuff.)


How to Register Novel Dataset ?

Hi
I am trying to use my own dataset to fine tune the pipeline on, but it gives me the error of 'KeyError: "Dataset 'equipment_imgs' is not registered!' , how do I register this dataset to to fine tune the algorithm on this ?

Hello,
You should register your dataset here first: https://github.com/ucbdrive/few-shot-object-detection/blob/master/fsdet/data/datasets/builtin.py.  Follow how the other datasets are registered to register your own dataset. Let us know if you have any questions about this.
Hope that helps!

@thomasehuang  thank you for your response
I registered the dataset in the builtin.py
_PREDEFINED_SPLITS_COCO["coco"] = {
    "coco_2014_train": ("coco/train2014", "coco/annotations/instances_train2014.json"),
    "custom": ("custom", "custom//custom_37_54_Pro.json"),
}

as follows
but I get the error -
 DatasetCatalog.register(name, lambda: load_coco_json(json_file, image_root, name))
  File "/home/Desktop/FSOD/few-shot-object-detection/fsdet/data/datasets/coco.py", line 65, in load_coco_json
    cat_ids = sorted(coco_api.getCatIds())
  File "/home/.local/lib/python3.6/site-packages/pycocotools/coco.py", line 170, in getCatIds
    cats = self.dataset['categories']
KeyError: 'categories'

Do you know where am I going wrong ? Is the way I am registering the dataset incorrect ?

@raghavgurbaxani do you solve the issue?

@raghavgurbaxani Were you using the COCO format for your novel annotations? It looks like the error comes from your new annotation file.  Hope it helps!

close the issue for now and feel free to reopen it if you have any other issues. Thanks!


Cross replicate internal users and roles database

Is your feature request related to a problem? Please describe.
I'm doing a multi-region AWS setup where each region has an OpenSearch cluster. I enabled cross-region replication so only one region acts as the leader. The problem is I don't see a way to replicate internal users, which forces me to define them manually through the security plugin. I'd also like to periodically rotate user passwords (for example with a lambda-based secret rotation). This means the lambda has to issue a PUT request to each and every cluster. This work seems unnecessarily complex and error-prone.
Describe the solution you'd like
We should be able to cross-replicate the internal users and roles database across clusters.

[Security Triage] This feels out of scope for the security plugin, while there might be features / asks to support cross cluster scenarios, the security plugin is focused on administration of a single OpenSearch instance, transferring this to cross cluster repo where there might be better traction.

Any update on this ?

This is not planned as of now as it requires significant changes.


Arch Linux Compile

Hi, can someone help me compile this under Arch linux, Thanks

I also tried to install but wasted to much time.
Because I couldn't find any complete instructions in READMEs yet.
Would be nice, if you'll maintain PKGBUILD files or AUR packages. With one rocm metapackage which will install full ROCm platform

Looking through our backlog of issues -- this appears to be a duplicate of #294. I understand that this one was opened earlier, but there are more posts over there. So I'm going to close this one and say that the feature request for Arch support should be centralized into #294.


[Bug] getAssetListPaged empty

Version
2.6.0
Platforms
iOS
Device Model
Iphone 5 (ios 13.6.1)
flutter info
Flutter (Channel stable, 3.7.7, on macOS 13.0 22A380 darwin-arm64, locale en)
    • Flutter version 3.7.7 on channel stable at /opt/homebrew/Caskroom/flutter/2.10.3/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 2ad6cd72c0 (5 weeks ago), 2023-03-08 09:41:59 -0800
    • Engine revision 1837b5be5f
    • Dart version 2.19.4
    • DevTools version 2.20.1

How to reproduce?
final result = await albums.first.getAssetListPaged(page: 0, size: 100);

albums is list data but when i call function getAssetListPaged. it return empty
But OS > 15 it work fine
if i used albums[1] it work well too.

Logs
No response
Example code (optional)
No response
Contact
No response

I get empty results only for following albums:

Selfies
Live Photos
Protraits
Long Exposure
Panoramas
Time-lapse
Slo-mo

Looking at the names, it seems like the issues affect only some special albums. Please notice Im using a fake thumb for the corrupted results.

I also don't get correct assetCount for "all" albums.

Should have I to file a different PR to report issue with assetCount?

i fixed this bug like:
final List<AssetEntity> results =
    await albums.first.getAssetListPaged(page: page, size: 100);
final firstName = albums.first.name;
const recentName = AppParamConstants.albumRecent;
const rollName = AppParamConstants.albumCameraRoll;
final notRecentAlbum = firstName != recentName && firstName != rollName;
if (GetPlatform.isIOS && (results.isEmpty || notRecentAlbum)) {
  for (int index = 0; index < albums.length; index++) {
    final item =
        await albums[index].getAssetListPaged(page: page, size: 100);
    if (albums[index].name == recentName) {
      results.addAll(item);
      break;
    }
    if (albums[index].name == rollName) {
      results.addAll(item);
      break;
    }
  }
}

@delfme
Maybe, you should set following option.
imageOption: const FilterOption(
      sizeConstraint: SizeConstraint(ignoreSize: true), // If you get large size Image, you should ignore.
      onlyLivePhotos: false, // default false, but maybe you set true.
    ),

Or, maybe your RequestType is wrong.
If you wanna obtain image, you should set it.
  final RequestType requestType = RequestType.image;

I would appreciate it if you could help me.

HI @tomoyukitanaka1171 thx for the kind attention.
My function is meant to just fetch the thumbnail of each album and this is the code
Map<AssetPathEntity, Uint8List?> albums = {};

// Get thumb for album
Future<Uint8List?> _getFirstThumb(AssetPathEntity album) async {
  var assetList;
  assetList = await album.getAssetListRange(
    start: 0,
    end: 1,
  );
  return assetList.first
      .thumbnailDataWithSize(const ThumbnailSize(500, 500), quality: 25);
}

/// Load all the albums in the device
Future<Map<AssetPathEntity, Uint8List?>> loadAlbums() async {
  // ignore: no_leading_underscores_for_local_identifiers
  final _albums = await PhotoManager.getAssetPathList(type: RequestType.common);

  _albums.sort((a, b) {
    if (a.isAll) return -1;
    if (b.isAll) return 1;
    return 0;
  });

  final result = <AssetPathEntity, Uint8List?>{};

  for (final album in _albums) {
    final thumb = await _getFirstThumb(album);
    result.addAll({album: thumb});
  }

  albums = result;

  if (medias.isEmpty) {
    await getPhotos(
      _albums.first,
      pageIndex: 0,
    ).toList().then((photos) {
      if (medias.isEmpty) {
        medias.addAll(photos);
        return;
      }
    });
  }

  return result;
}

It has always worked fine.  Can you suggest how to change it for a try?

Log issue point here coz for some album it return nothing.
  assetList = await album.getAssetListRange(
    start: 0,
    end: 1,
  );
  return assetList.first
      .thumbnailDataWithSize(const ThumbnailSize(500, 500), quality: 25);

@delfme
You're welcome.
Thanks for the information.
I don't know, but Maybe Images size that you wanna get are over 100000pixel ( width or height ).
Default, SizeConstraint set maxWidth and maxHeight it.
  const SizeConstraint({
    this.minWidth = 0,
    this.maxWidth = 100000,
    this.minHeight = 0,
    this.maxHeight = 100000,
    this.ignoreSize = false,
  });

So, in that case, you should set ignoreSize = true.
Can you try following ?
final FilterOptionGroup _filterOption = FilterOptionGroup(
    imageOption: const FilterOption(
      sizeConstraint: SizeConstraint(ignoreSize: true),
    ),
  );

final _albums = await PhotoManager.getAssetPathList(type: RequestType.common, filterOption: _filterOption);

I hope you will find it useful.

@tomoyukitanaka1171 just tried it. This is error stack:
[VERBOSE-2:dart_vm_initializer.cc(41)] Unhandled Exception: Bad state: No element
#0      List.first (dart:core-patch/growable_array.dart:343:5)
#1      _getFirstThumb (package:presence/screens/story_media_selector/album_selector.dart:50:20)
<asynchronous suspension>
#2      loadAlbums (package:presence/screens/story_media_selector/album_selector.dart:87:19)
<asynchronous suspension>

The error points to this line from above func _getFirstThumb(AssetPathEntity album)
 return assetList.first
      .thumbnailDataWithSize(const ThumbnailSize(500, 500), quality: 25);

If you can add logs to a 'debug-branch' I will try again with it and revert.
I'm using ios15.5 and ios16.1, both emulator and physical device

@CaiJingLong @tomoyukitanaka1171 just noticed this fix is planned for 2.6.1.  Is there a workaround I could use mentime or do I just have to downgrade?

I can workaround this issue by using photo_manager: 2.1.2 , but only on physical device (emulator stalls with no errors).
It looks like issue is caused by await album.assetCountAsync that never return a value.
On 2.1.2 we have old album.assetCount which works fine.
I have 41.490 images in Recents album and I think this might play a role in the issue.
Idk why 2.1.2 doesn't work on emulator. But it looks like some iOS special album crashes PhotoManager.getAssetPathList()
Tested on iphone ios 16.1 and emulator 16 and 15.5

It also looks like on emulator the methods to get thumbnail (thumbnailDataWithSize, thumbnailDataWithOption and thumbnailData) fail to return a value and throw no errors.

From the above comments, there're multiple issues that are not all related to getAssetListPaged.

albums is list data but when i call function getAssetListPaged. it return empty
But OS > 15 it work fine if i used albums[1] it work well too.

@scuti-dai The first album is Animated, which might not contain any assets. albums[1] is another album that is different from albums.first, it's reasonable that your first album has empty assets but the second one has some.

I also don't get correct assetCount for "all" albums.

@delfme The assetCount has already been deprecated so you'll need to move on to the assetCountAsync.

just noticed this fix is planned for 2.6.1. Is there a workaround I could use mentime or do I just have to downgrade?

The relevant exception should not occur in 2.6.0, which means you should avoid using the main branch of our code unless you're intended to.

On 2.1.2 we have old album.assetCount which works fine.
I have 41.490 images in Recents album and I think this might play a role in the issue.
Idk why 2.1.2 doesn't work on emulator. But it looks like some iOS special album crashes PhotoManager.getAssetPathList()

@iosephmagno Please provide logs and your question is out of the scope of the current issue, consider submitting a new one with the full info provided.

Hi @AlexV525 got to fix my issue

@CaiJingLong @tomoyukitanaka1171 just noticed this fix is planned for 2.6.1...

@delfme
If it can be reproduced, it can be planned to fix it in 2.6.1, but if no more information can be provided, the plan needs to be postponed.
If possible, you need to provide the following information:

The complete code to reproduce, preferably a Widget, with no references to other files except photo_manager.
The complete environment to reproduce, a brand new iOS simulator, and then I need how to add albums or pictures to reproduce your environment.

No more information to help reproduce, so remove it from milestone.


Timeline Search Bar + Functionality

Description
Fixes #92.

No new dependencies added
Implemented the search bar on the bottom for the timeline component (confirmed logic requirements with designers)
Minor style tweaks and refactoring

Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[ ] I have run npm run lint:fix
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation (if required)
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works (Delete if frontend)

Style looks great!


Fixed critical failure of pre-commit pipeline

My last PR called the len function on a generator 🤦♂ so I've replaced the generator with a list to fix the code.

Thanks for the fix! I must admit I didn't check either 🤦♂

Seems to work fine now 🚀


[Mod Support Request] - Terra Incognita: The Unknown Land

https://www.curseforge.com/minecraft/mc-mods/terraincognita

There are currently six variants of butterflies:
Peacock
Brimstone
Cabbage White
Orange Tip
Common Blue
Monarch

Will get this done tomorrow!

Added support for Terra Incognita.


create pr0

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign rafaelcalleja
You can assign the PR to them by writing /assign @rafaelcalleja in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rafaelcalleja: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pr-build
0cc663cf44eca95b48443b34e6a9c043db21c966
link
/test this

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.


Images based in FOR cycle

I'm generating word document, which has several images (quantity of them is not known until last step). Is there any possibility, I could use FOR cycle to generate images?
For example.:
{ FOR image in imagesArray } { INS IMAGE image() } { END-FOR imagesArray }
The imagesArray would look something like this:
[     {         image: 'someKindOfBase64Url-2'     },      {         image: 'someKindOfBase64Url-1     } ]

Yes something like that should be possible, but make sure to read the docs (README) first. Each image should be provided as { width: 6, height: 6, data, extension: '.gif' } and the INS and IMAGE commands should not be combined. You should only use IMAGE for your use case.

I was thinking something like this:
     const data = {         template,         data: {           name,           code         },         cmdDelimiter: ['{', '}'],         additionalJsContext: {           imageTest: () => {             arrayOfImages.map((img) => ({               width: 1,               height: 1,               data: img.buffer,               extension: '.jpg'             }));           }         }       };
And in template something like this:

Okay, I got it, thanks :) It worked :)

Ok great! I'll close the issue then.


Stop faster on test failures?

The standard cargo test invocation has two layers:

cargo test runs various test binaries in series, stopping if any of them fail: starting with lib tests, then binaries, etc, and on to doc tests. https://doc.rust-lang.org/cargo/commands/cargo-test.html
the rust test harness internal to each binary runs each test one after the other but does not stop if any of them fail. (This is the default behavior but crates can override it.)

cargo-mutants only wants to know if any tests fail; once one of them has failed it's a waste of time to continue.
I think the cleanest place to fix this would be in the stdlib test harness, but unless/until that's fixed it would be possible for cargo-mutants to do what a human would do: ctrl-c the tests once it notices that anything has failed.
To notice that one test has failed we could

scrape the text output, though that might be prone to false positives, which would be quite disruptive
ask for --format json though that apparently is not stable yet
...?

Alternatively there is cargo-nextest, https://nexte.st/, which does seem to support --fail-fast and might be faster in general on crates where it works.
Or, perhaps it's better to look at adding fail-fast support into Rust's standard runner? I wonder why it's not there already?
See also:

https://rust-lang.github.io/rfcs/2318-custom-test-frameworks.html

I now think this is too far out of scope for cargo-mutants itself, so I'll close. It might be nice if the cargo test runner itself supported this.


Generate fancy markdown docs directly from the source-code files

Is your feature request related to a specific problem?
We're adding as much documentation as we possible can to the pydantic models themselves for fideslang, and it's only going to get harder and more cumbersome to try to manage updating two separate places whenever we make a fideslang model change.
Describe the solution you'd like
I'd like each of the data types to have a nice markdown table generated purely from the pydantic sauce and included as part of our docs
Describe alternatives you've considered, if any
Using some kind of automated docs builder, it may exist

FastAPI kind of does this with generating the open API docs. I wonder if there is some way for us to hook into that to also generate markdown.

yeah i used to include the raw JSON schemas as part of our docs, but it was just a bit too unwieldy...
I figure worst-case scenario we use a python script to generate some markdown for the docs. Wouldn't be too painful and I've seen other projects out there with much more elaborate docs build processes