Refactor general weight DPD potential

pre-commit.ci autofix

pre-commit.ci autofix

I noticed that DPDGeneralWeight needs to be added to the sphinx doc pages too. It isn't rendering on RTD currently.

What is our reasoning behind having a separate test_pair_dpd.py file with tests being split between it and test_pair.py? Would it be clearer to have all these tests consolidated into one file like we did for aniso?

No particular reason other than it was that way before, and it may be slightly more readable separated out. The aniso pair tests are in a separate file for a similar reason. But, it can be moved if you think that’s better!

The code looks good to me. I made a couple of comments on the documentation above.

What is our reasoning behind having a separate test_pair_dpd.py file with tests being split between it and test_pair.py? Would it be clearer to have all these tests consolidated into one file like we did for aniso?

No particular reason other than it was that way before, and it may be slightly more readable separated out. The aniso pair tests are in a separate file for a similar reason. But, it can be moved if you think that’s better!

Gotcha! I see pros and cons to both options, but ultimately, I don't have a strong preference. I'm good with whatever you all think is best!

Lacking a preference either way, let's leave as is then.

Hi all, the documentation should be cleaned up on this, so please give it a final review before merging!


[BUG] Get-PnPClientSidePage cmdlet always throw 'does not exist' error in some tenants' root site collection

If possible please send email to me and I can share the credentials to let you triage.
Expected behavior
Get-PnPClientSidePage should return the modern page object for all sites. instead of in some tenants' root site collection, the modern pages exists, but Get-PnPClientSidePage will always throw not exist error.
Actual behavior
Page 'XXX.aspx' does not exist in root site collection.
Note: We have three SharePoint Environments, the two tenants met not exists error in root site collection. For non-root site collection it works well.
Steps to reproduce behavior

What is the version of the Cmdlet module you are running?
Tested in both 1.12.0 and latest version  2.3.0
Which operating system/environment are you running PnP PowerShell on?

[ ] Windows

Closed the issue as found the root cause and submit issue in PnPCore https://github.com/pnp/pnpcore/issues/1343


Fix ExpressionChangedAfterItHasBeenCheckedError

Dynamic change in label of mat-option gives ExpressionChangedAfterItHasBeenCheckedError.
Read more:
#14793

@googlebot I signed it!

@googlebot I fixed it.

@googlebot I fixed it.


Emitted metrics constantly growing

Hi!
We started testing Druid 0.10.0 on our dev cluster and found a possible bug.
We are using the Http Emitter Module to log the metrics. Since 0.10.0 the messages sent to our HTTP API are constantly growing the longer the single nodes are running. There seems to be a problem with the "namespace/deltaTasksStarted" metric which is multiple times in the JSON with different timestamps. The longer the node runs (broker in this case but happens on historical nodes too) the more deltaTasksStarted entries there are per emitted message. See attached a sample JSON.
druid_broker_metrics.json.txt
Please let me know if you need further details.

Thanks for the report @cesure. It looks like this is due to NamespaceLookupExtractorFactory accepting CacheScheduler when instantiated, which is not a singleton and so it's created each time a "cachedNamespace" is deserialized.
@leventov this changed in #3697, where NamespaceLookupExtractorFactory used to take a (singleton) NamespaceExtractionCacheManager but now takes a (not singleton) CacheScheduler. Would it make sense to make CacheScheduler a singleton or is some other approach warranted?

https://github.com/metamx/druid/tree/cacheScheduler-singleton might fix this

Thank you @leventov!
I just backported this single commit locally into 0.10.0 will try it on our dev cluster.

Making CacheScheduler a singleton fixed the problem for us!
I can't comment on any side effects this change eventually brings in for now, though.

@cesure thanks for testing. The fix should be available in Druid 0.10.1.


Improvement - Retrieve device phone number?

Hello all,
I was wondering if you could pull the connected device's phone number as well? Real Devices and Simulators. This would be beneficial for testing when phone numbers need to be used to register accounts. Normally people will create pools of numbers to use and reuse but if you could just use the number of the connected device (because you know that number cannot already be in use), it would be really beneficial.
Let me know what you think.
Thanks,
Mark.

It appears you may need root access for this unfortunately

Hey, Mark.
As you said, we cannot access this data because it requires root operation.
The purpose of this library is to dynamically capture the features for real devices.
If necessary, the "getIntegratedCircuitCardIdentity" command returns the ID number of the SIM card installed on the device.
Because this value is constant, you can keep a list and match it with phone numbers.

Thanks for the response, really appreciate it 👍


Switch Icon library

Describe the feature

Remove react-native-vector-icons, which bundles icons individually, and install Ionicons, since we use it the most.
Additional comments

npm site
Icon list

Can't be done, stick with react-native-vector-icons. Instead add custom options for collection of icons


For example, a child that is horizontally/vertically centered in its parent:

  <ScaleText>
    Hello
  </ScaleText>

From testing, it looks best if we handle scaling for position: absolute children using css transform: translate(-50%, -50%) scale(<factor>), where the factor is the minimum of the difference between parent/child width and parent/child height.
Ideas on keeping this scale transition smooth are appreciated.

Upon further testing, I think using CSS transform/scale is making too many assumptions about the child content.  I don't want to start adding dynamic styling that makes assumptions about content or mistakenly modifies the content in a way that breaks the page or module.
I think sticking to just modifying font-size and determining overflow using getBoundingClientRect() for absolutely positioned child elements is the simplest and best route.

Does this even make sense, in the case of absolute positioned elements within a static positioned parent?  At that point, the abs positioned element is no longer considered a child of the parent from a flow standpoint and the concept of 'scale to parent' doesn't really make sense, since the parent is not the uppermost 'relative' positioned parent or the window.
Thoughts?


Perl Package: Spreadsheet::Read{,SXC}

Motivation for this change
I need these two modules for the build process of the codebase I work on in my masters thesis, so why not submitting them to nixpkgs? :smile:
I left out the maintainer for the packages because I am no perl guy and I will probably not need them anymore in half a year...
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Better use nix-generate-from-cpan for Perl packages:
$ nix-generate-from-cpan Spreadsheet::Read
…
  SpreadsheetRead = buildPerlPackage rec {
    name = "Spreadsheet-Read-0.74";
    src = fetchurl {
      url = "mirror://cpan/authors/id/H/HM/HMBRAND/${name}.tgz";
      sha256 = "b95e2100a2f30c6b8c8f9b399c55446a7c56d30c37f80748e6a141eb07a4cb80";
    };
    buildInputs = [ TestNoWarnings ];
    propagatedBuildInputs = [ DataPeek ];
    meta = {
      description = "Meta-Wrapper for reading spreadsheet data";
      license = with stdenv.lib.licenses; [ artistic1 gpl1Plus ];
    };
  };

Unfortunately, the Spreadsheet::ReadSXC package is not having correct meta data so need a bit of tweaking:
$ nix-generate-from-cpan Spreadsheet::ReadSXC
…
  SpreadsheetReadSXC = buildPerlPackage rec {
    name = "Spreadsheet-ReadSXC-0.20";
    src = fetchurl {
      url = "mirror://cpan/authors/id/T/TE/TERHECHTE/${name}.tar.gz";
      sha256 = "b2e4dd1c46453b3844be4bc8e069ea688d3882ea7818bf97cb53caa0c2b235b6";
    };
    propagatedBuildInputs = [ ArchiveZip XMLParser ];
    meta = {
      license = stdenv.lib.licenses.unknown;
    };
  };

E.g., need license = with stdenv.lib.licenses; [ artistic1 gpl1Plus ];, the description you wrote, and perhaps buildInputs = [ TestMore ];.


Should transport files require authorization?

Where a transport file is advertised via the IS-04 manifest_href (whether this is SDP or other), this file may or may not be hosted by the same hostname/port, and may or may not be under the 'x-nmos' namespace as the same file path could be shared by multiple control protocols.
The resulting question is whether a client should be expected to include an authorization token in requests to fetch a transport file?

A similar issue applies to IS-05 /transportfile I think because it may return a 307 Temporary Redirect. Whether the same or different auth mechanism applies to the redirect request isn't clear.
There's a general issue with authorization and 3xx codes, that we probably want to think about. I think many HTTP client implementations will do redirection automatically, but in the process, strip off auth request headers. So this may even apply to redirects within the same API (e.g. relating to trailing slashes...).

W.r.t. whether a manifest_href requires auth, there's no manifest_authorization boolean along side, but potentially the Manifest Base URL Device control would provide a means to advertise that reliably?

Discussed on today's call. It's not clear what is the best option, but the manifest base URL idea.
Other suggestions

if using secured IS-05 then must auth
have null IS-04 manifest_href
require manifest_href to point to same as IS-05 reference

We will review over next week and if consensus make PR

The first issue is to clarify whether or not the manifest_href requires authentication at all.
The second is what scopes and claims are required if so.
The third is what happens if the response is a 3xx redirect.

We could require that if using authentication and IS-05, then any access via IS-04 manifest_href must also be authenticated.

It would seem a bit strange to tie these together unless the manifest_href actually was an IS-05 Connection API address?

Or we could require that manifest_href is null

That seems like a backward step.

Or that manifest_href must redirect to the same place as IS-05 /transportfile

If this means that the manifest_href must be a  Connection API address like .../x-nmos/connection/{version}/single/sender/{senderId}/transportfile, that's clear, but there could be some issues to think about in the presence of multiple network interfaces and multiple API version support.
However, if this means that both the manifest_href and the Connection API /transportfile address may respond with a 3xx status and if so must have the same Location, I'm not sure that helps. Authorization applies to each request I believe, so if the request to the first address in each case isn't successfully authorized, the client gets a 4xx not the redirect 3xx. If they provide the correct auth for the first request, the client still needs to know what auth is required on the redirect request.

We will review over next week and if consensus make PR

👍

I'm not sure if the comments fully represent what was discussed on the call. Given an assumption that we would like these files to require authorization (as the easiest option is to just not require it), we discussed how that could be achieved.
We don't want one implementation to use a path for a manifest_href which requires one set of claims, with another implementation requiring a totally different set of claims as this will just result in granting of wider reaching access to work around the complication. In order to reduce this complexity we discussed either using the null option to ensure we only have to solve the problem in IS-05, or requiring that the manifest_href is an IS-05 transportfile href, again moving the problem to IS-05. The key note here would be that in authorised mode an implementation would be required not to use a random non-NMOS file path for the manifest_href. The Manifest Base spec could still be used here for its original purpose, allowing multiple IS-05 API endpoints to be hinted at where multiple network interfaces are in use. If we envisaged that implementations may run IS-04 in authorized mode but IS-05 without authorization then the Manifest Base spec may also provide the way to signal that.
Having required that the issue is then handled by IS-05, I believe you're right that if IS-05 responds with a 3xx we could have exactly the same problem again. The suggestion here was to deny redirects, requiring that the /transportfile resource responds with a 2xx, ensuring that the private claims match up. Again this would be a BCP-003-02 constraint upon implementations running in authorised mode.
If an implementation still chose to run another control API exposing a copy of the same SDP file from another URL then that would be up to them, but this at least ensures that it is possible to keep the file behind an authorised path where desired.

Thanks, @andrewbonney, that's extremely helpful.

I was curious about one item you guys have mentioned. I'll paraphrase it as "redirects by pass authorization" where by an API can return a 3xx without considering the access token.
I could not find anything in the RFCs about redirects. Would you be so kind to point out where that is from?
I was under the impression protected endpoint before anything else should verify authorization. I would have expected /transportfile to return 3xx only if the valid access token had the correct permission.

My understanding is exactly the same as yours, @prince-chrismc!


Analytics: Add Yandex domain

Hello!
I found this domain while browsing using DuckDuckGo Web Browser. It was blocked by them under analytics category.
mc.webvisor.org

I'm attaching a screenshot:

The first one in the screenshot is already included but the second one is not.
So you might want to look into that.
Regards.

Included in many other lists:
Exact matches for mc.webvisor.org found in:
  - https://raw.githubusercontent.com/d43m0nhLInt3r/socialblocklists/master/Tracking/trackingblocklist.txt
  - https://raw.githubusercontent.com/d43m0nhLInt3r/socialblocklists/master/Tracking/trackingblocklist.txt
  - https://raw.githubusercontent.com/llacb47/mischosts/master/blacklist
  - https://v.firebog.net/hosts/AdguardDNS.txt
  - https://raw.githubusercontent.com/bigdargon/hostsVN/master/hosts
  - https://v.firebog.net/hosts/Easyprivacy.txt
  - https://raw.githubusercontent.com/r-a-y/mobile-hosts/master/EasyPrivacy3rdParty.txt
  - https://raw.githubusercontent.com/r-a-y/mobile-hosts/master/AdguardDNS.txt
  - https://raw.githubusercontent.com/hl2guide/DNS-Sinkhole-Lists-A2/master/TESTING%202020/dns_sinkhole_list.txt
  - https://raw.githubusercontent.com/pengelana/blocklist/master/domain.txt
  - https://web.archive.org/web/2if_/http://cdn.raletag.gq/rueasyhosts.txt
  - https://block.energized.pro/ultimate/formats/hosts
  - https://raw.githubusercontent.com/MajkiIT/polish-ads-filter/master/polish-pihole-filters/all_ads_filters.txt
  - https://raw.githubusercontent.com/privacy-protection-tools/anti-AD/master/anti-ad-domains.txt
  - https://raw.githubusercontent.com/badmojr/1Hosts/master/Pro/hosts.txt
  - https://raw.githubusercontent.com/xorcan/hosts/master/xhosts.txt
  - https://sebsauvage.net/hosts/hosts
  - https://any.andryou.com/oisddbl.txt
  - https://raw.githubusercontent.com/notracking/hosts-blocklists/master/hostnames.txt
  - https://raw.githubusercontent.com/notracking/hosts-blocklists/master/hostnames.txt
  - https://raw.githubusercontent.com/jerryn70/GoodbyeAds/master/Hosts/GoodbyeAds.txt

Thank you Dhaval @dhavalgoti24.  This is added to my list.


[charts/newrelic-logging] Add namespace to all namespaced resources

Is this a new chart
No.
What this PR does / why we need it:
Uses .Release.Namespace to explicitly set the namespace on every namespaced resource.
Special notes for your reviewer:
This should allow us to properly deploy this chart to a specific namespace.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [mychartname])

@douglascamata does this do the same thing as #185 ?

@arvdias no. In fact, that PR puts all the Logging chart resources in the newrelic namespace. Here I make it respect the namespace that can be sent through the Helm CLI.
In #185 we also have the unification of the global cluster name variable: this chart currently uses clusterName, where all the other charts for infra products use cluster. There's still value in this and we should contact the author to update the PR there.

@arvdias let's use that PR as it does other valuable things.


Centralize configuration settings

I’m 👍 on the intention but we have a conflicting PR #101 that we’d like to get in first.
Let’s revisit any refactorings after it.

I’ll close for now because we can do stylistic refactoring later, after (or as part of) shipping features.
Thanks for the PR though, and we’d love to see you contribute in the future.


RGB only color picker

Hi, is it possible to use the default color picker field, but without the alpha channel? If not, would it be possible to add it?

Hi @wkrasnicki,
Kindly note that form_builder_extra_fields makes use of flutter_colorpicker which has different modes to choose from.
Since flutter_form_builder allows you to convert any widget into a FormBuilderField, I'd suggest you make use of this feature if you can't find a field that you prefer in the packages provided.
The reason for this is that there are literally thousands of widgets we could include in the package, which would be a lot of work - hence the API to make any field work with FormBuilder.


Add ability to handle levels and times in netCDF files

Closes #231
This PR implements some support for netCDF files with levels and times in them. By default, it'll always take index 0 of time and index 0 of levels. It also assumes the time dimension is named "time". Maybe this is a bad assumption?
I also made it so that add_velocity could work too because, well, it's cool.

@mathomp4 Looks great! Thank you for your contribution.


Add support for skin-toned emojis

This plugin MUST support skin-toned emojis (👍👍🏻👍🏼👍🏽👍🏾👍🏿) since they're a fundamental part of Unicode emojis.
Quick thoughts:

Maybe it can use neutral-toned emojis (👍) + Unicode general skin tone codes (🏻🏼🏽🏾🏿) // Is this possible?
It can be accessed like this:

ctx.emoji`${"like:medium-dark"}` // 👍🏾
ctx.emoji`${"punch:light"}` // 👊🏻
ctx.emoji`${"raised_hands"}` // 🙌

With further investigation, I discovered that it is possible to have emoji modifiers to change it's skin tones. Tone modifier goes from range U+1F3FB to U+1F3FF. The next step now is to split emojis list into two lists, emojis.json and skin-emojis.json. That way, it is possible to apply modifiers in a simple way.


Misleading documentation

Bits.toIntUnsigned8s says it pads with zeroes on the right, but it encodes [ I ] as [ 1 ], whereas with right padding it should be [ 128 ].
Either the documentation or the function need to be fixed

Thanks! Should be fixed now (was away for a bit).


return an IActionResult over HttpResponse in azure functions handler

a way to address https://github.com/SaturnFramework/Saturn/issues/135 by creating a noop action result and returning it instead of the context.Response

LGTM, thanks a lot!


Referenced File Names Do Not Match Generated File Names

iconizr: {
  svg2sprites: {
    src: ['<%= conf.bg.images %>/svg'],
    dest: '<%= conf.bg.styles %>/_iconizr',
    options: {
      prefix: 'bg',
      verbose: 3,
      render: {
        css: false,
        scss: '.',
      } // render
    } // options
  } // svg2sprites
} // iconizr

Result:
<script type="text/javascript">!function(){var e=window,t=e.document,a=arguments,n="createElementNS",s="http://www.w3.org/",A="svg",r=function(e){var r=t.getElementsByTagName("script")[0],g=t.createElement("link");g.rel="stylesheet",g.type="text/css",g.href=a[4]+a[1*e|2*(t[n]&&t[n](s+"2000/"+A,A).createSVGRect&&t.implementation.hasFeature(s+"TR/SVG11/feature#Image","1.1"))],r.parentNode.insertBefore(g,r)},g=new e.Image;g.onerror=function(){r(0)},g.onload=function(){r(1===g.width&&1===g.height)},g.src="data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///ywAAAAAAQABAAACAUwAOw=="}("bg-png-sprite.css","bg-png-data.css","bg-svg-sprite.css","bg-svg-data.css","/eomdb/SysConfig/WebPortal/BostonGlobe/Framework/styles/_iconizr/");</script><noscript><link href="/eomdb/SysConfig/WebPortal/BostonGlobe/Framework/styles/_iconizr/bg-png-sprite.css" rel="stylesheet" type="text/css" media="all"></noscript>

Note the file names in the tester are bg-png-sprite.css, etc. based on the specified prefix. But the actual source files are called _iconizr-png-sprite.scss, etc. which seem to get their prefix from the parent directory. Also, with the leading underscore, they wouldn't get turned into individual files.
Additionally, all of the scss files get placed one level behind the one specified in dest. So _iconizr-png-sprite.scss gets put under styles, with the background values set to url(icons/icons.png);. But the icons folder is within _iconizr, not styles.

Hi @hguiney,
as you didn't respond to this any further, I assume you solved your name translation troubles and close this issue for now. Please feel free to re-open in case you still have problems.
Cheers,
Joschi


Calendar template accessibility improvements

An icon isn't enough for a lot of screenreaders to infer what an action does so introduced captions for screenreaders to the table header previous/next buttons. Included internationalisation support taking the locale code from Moment.
Tests to exercise the text across various languages/datepicker types.

I just had a brief scan of this, and it looks great! Thanks!
Where did you get the translations?  The Chinese is correct so I know it wasn't Google translate. =)

I'm not seeing any changes to the scss files in this PR - are those changes no longer needed?

Good stuff!
The translations came from a pagination gem which I've used before. Figured better to use something with open contributions rather than risking a translation service.
When I ran the tests/demo on a clean develop branch, the style for the class was already included (it's a basic Bootstrap one), so I figured it could be missed out.


Runtime error: OOM for vanilla UNet conv configuration

Describe the bug
Facing OOM issue for Vanilla UNet convolution configuration.
To Reproduce
Steps to reproduce the behavior:

Checkout to punith/vanilla_unet_conv_issue.
Run command pytest tests/ttnn/unit_tests/operations/test_new_conv2d.py::test_conv_for_vanilla_unet

Expected behavior
It should pass without any issue.
Screenshots
E       RuntimeError: TT_THROW @ ../tt_metal/impl/allocator/allocator.cpp:143: tt::exception
E       info:
E       Out of Memory: Not enough space to allocate 49971200 B L1 buffer across 64 banks, where each bank needs to store 780800 B

Please complete the following environment information:

OS: Ubuntu 20.04
Device - WH-n150

fyi @saichandax

I've double checked this on main these convs are still too big to fit :(
I think that as we workaround we can split the input on input channels.
Currently input tensor is [1, 64, 480, 640]. If we split the tensor to two [1, 32, 480, 640].
Convs would fit and we just need to run conv twice and than concat results on the last dim.
@punithsekar Does this sound reasonable to you?

@pavlejosipovic thanks for the workaround, let's try it and update you. First we'll check on the accuracy of results, then the overall perf impact, because that model is mainly for a customer perf benchmarking.

I tried reducing the input channels to 32 for the conv from the branch and stills fails with OOM. currently, rebasing to main and building again is in progress. Will update here if it works.


How to do time series classification?

Hi all,
Thanks for open sourcing this library.
I am working on the task of classifying numeric, multivariate series. I wanted to know how I use chronos to achieve that?
Thanks!

Hi @shivin9! Thanks for your interest. The Chronos project currently focuses on forecasting. What's the best way to use Chronos for tasks such as classification, clustering and anomaly detection is an open research question. You can check the README for an example of extracting Chronos' encoder embeddings. You should be able to use these embeddings for a downstream task like classification.
Someone tried to give it a go for classification. Please check their example here (also read the comments for the complete context). Note that this is a quick attempt and there should definitely be better ways to approach this.

Thanks!

I am trying to do classification as well from the example given,
however, I am having an error when I try to run using it GPU..
I use the same code as in the README to extract the embeddings and the input tensor is using GPU aswell however, I get the error
  File ".../envs/digidogs/lib/python3.8/site-packages/chronos/chronos.py", line 150, in input_transform
    torch.bucketize(
RuntimeError: Expected all tensors to be on the same device, but found at least two devices, cuda:0 and cpu! (when checking argument for argument boundaries in method wrapper_CUDA_Tensor_bucketize)

@mshooter could you include a self-contained snippet that reproduces the issue?

Here's my idea, leveraging HuggingFace's transformer API. It's perhaps too hacky to follow along. Requires basic understanding of PyTorch, e.g, setting up data loaders etc.
import transformers
from tqdm import tqdm

dataset = ... # dataset of some kind
train_loader = ... # a data loader of some kind
num_epochs = 1

# use the HuggingFace transformer API to attach a new head
# NOTE: setting 'num_labels = 1' means regression
num_labels = 2
checkpoint = "amazon/chronos-t5-tiny"
model = AutoModelForSequenceClassification.from_pretrained(checkpoint, num_labels=num_labels)

# not really interested in the pipeline...
pipeline = ChronosPipeline.from_pretrained(
    checkpoint,
    device_map=model_config.device,
    torch_dtype=torch.float16,
)

# ... but I snatch the tokenizer 🦹🏼♂
tokenizer = pipeline.tokenizer

model.train()
num_training_steps = num_epochs * len(train_loader)
progress_bar = tqdm(total=num_training_steps, desc=f"Training on {domain}")

for epoch in range(num_epochs):
    losses = []
    for i, batch in enumerate(data_loader):
        x, y = batch

        # tokenize and move to device
        token_ids, attention_mask, scale = tokenizer.input_transform(x)

        # NOTE: setting y to torch.int64, the HF API understand it's a label. Required for classification!
        y = y.to(device).to(torch.int64)
        token_ids = token_ids.to(device)
        attention_mask = attention_mask.to(device)

        outputs = model(
            input_ids=token_ids, attention_mask=attention_mask, labels=y
        )
        loss = outputs.loss
        loss.backward()


Create PMAP doc including architecture

TL;DR
Create PMAP doc including architecture
Detailed design
No response
Alternatives considered
No response
Additional information
No response

fixed by https://github.com/abcxyz/pmap/pull/178


Circleci yarn

Setup circleci to use yarn https://circleci.com/docs/install-and-use-yarn/

Coverage remained the same at 90.0% when pulling ab26d3832012a2f71a8649041d1151a8ff57b28c on circleci-yarn into 5d2086f1cf61d37de381a65171af2dbeea3cd8cf on devel.

Coverage remained the same at 90.0% when pulling 7b1b578e97e8fdb93eb9b3b812d83e34ddc2bcdf on circleci-yarn into 5d2086f1cf61d37de381a65171af2dbeea3cd8cf on devel.


optimise e2e tests

Codecov Report
All modified lines are covered by tests :white_check_mark:

Comparison is base (39e3df4) 94.78% compared to head (231af55) 94.78%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #508      +/-   ##
==========================================
- Coverage   94.78%   94.78%   -0.01%
==========================================
  Files         117      116       -1
  Lines        6275     6272       -3
==========================================
- Hits         5948     5945       -3
  Misses        327      327

Files
Coverage Δ

...vices/create_batch_collection_materialised_view.py
100.00% <100.00%> (ø)

...ices/create_notice_collection_materialised_view.py
100.00% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Failed to import - cli-color

Failing module

GitHub: https://github.com/medikoo/cli-color
npm: https://www.npmjs.com/package/cli-color

import cliColor from 'https://esm.sh/cli-color';

Error message
After running deno run I get this:
Download https://esm.sh/cli-color
error: Expected ,, got # at https://cdn.esm.sh/v51/cli-color@2.0.0/deno/cli-color.js:2:107

Additional info

esm.sh version: v51
Deno version: 1.13.2

I get similar errors on:

json-schema-to-typescript
es5-ext
es6-iterator

From what I can tell, it looks like there's sometimes a # that ends up on a variable name that is imported. Here's an import statement which fails, this one from es6-iterator.js. The others seem similar: the importing URL seems to always have a # as well:
import __es5_ext_array_#_clear$ from<EMAIL_ADDRESS>
This one appears to come from https://github.com/medikoo/es5-ext/tree/master/array/%23
Let me know if you need more info.

@cscheid thanks 🙏 as we know, in browser, including deno, a module is a standard URL that means the content after # will be treated as hash of the URL object. it's wired about the # dir. anyway i will fix this later, thanks for the useful info.


Spectrogram implementation

Reorder things to make the code tidier and add a spectrogram implementation. This is essentially taking the stft magnitude spectrum and applying a power to it. Also made the FrequencyComponent trait more generic.
This needs some tests so I'll fill them in but I don't expect the code to change. I might also add an example for getting the spectrogram from an audio file and saving the image!

Only src/spectrum.rs, src/metrics.rs and tests/equivalence.rs need reviewing


⚠ Bofrost.at has degraded performance

In 3bb90de, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 837 ms

Resolved: Bofrost.at performance has improved in 629e5bd.


Add import readMigrations function in the Database class

Hi, the main point is to import the readMigrations function but for the minor changes, it was updated to remove the comments mechanism and wrote tests!
Can you have a look?
It's better to update early for me because I'm creating a project based on this module.
But if it needs time to check and update this module it's okay)
I agree to apply your suggesting in the Pull Request so I'll update the code
Thank you!

Hi, I just moved all the staff to the Migrations class and have updated for prettier-standard.
Can you have a look at the code?
I'll fix what's needed. And I'll use your code structure.
Do we need to bump the versions of the packages in dev dependencies?
Do you know if we need to add editorconfig? And I somehow cannot format the file with Eslint, only with prettier, but it adds unnecessary commas to the end of the line

Just briefly looking at the changes, there's too many things going on.

You have a ton of file changes due to the reformatting. It's fine to want to do this, but it should be done in its own PR. The point of this PR is to create the migration class and doing this makes code review really difficult to see what is the main thing that has changed
You removed the migrate call from the database class. This creates breaking changes as it's not backwards compatible with people who may use the method in their code
The migration class itself is using arrow functions to define the methods. This is inefficient memory-wise as when someone creates multiple new instances of the migration class, it will create an instance of each method, where if you don't so arrow functions it will be on the class prototype instead.

So here's what we need to do here. Let's close this PR and create another one. Don't bother with linting if you can't get it to work, I can do that for you.
Make a PR that only makes the changes necessary for your Migration class to work.

The methods should not use arrow functions (read more about arrow functions vs prototype inheritance in classes)
The database migration method should remain and do what it did before. This might mean you create a new migration instance in that method itself and then execute migrate.
Include the new tests into the PR
Assuming there are no breaking changes (there should be none), a minor version bump would be appropriate.

Thank you for your kind explanation 😊
I'll check about arrow functions. And I agree to your comments. Let's do the best practice!
Do I need to leave readMigrations function exported in this PR or move to another one?
Do you know a resource where I can read shortly about PRs best practices?
Features:

Migrations class (functions read, run, down and migrate (both down and run) Migrations)
Commander to control run, show, reverse
bump versions of the devDependecies

I see that we need 3 PRs from points above
Notes:

I had some issues with reading sql files and split up and down code. I've used ts file with exports of down and up. But in this code it's working fine. Maybe some difference in versions?
I plan to add a documentations of this work to Readme. Do I need to do it every PR with new changes?

Thank you for your kind explanation 😊
I'll check about arrow functions. And I agree to your comments. Let's do the best practice!
Do I need to leave readMigrations function exported in this PR or move to another one?

I couldn't really understand what you mean, but I might be able to when I see the new PR where it's easier to read the changes and can give you guidance from then.

Do you know a resource where I can read shortly about PRs best practices?

I think this falls under the topic of general software engineering practices. I did try looking up best practices around PRs and feature branches, but they seem to be focused on documentation and formatting.
I think I learned via just code reviews from other peers over time.

Features:

Migrations class (functions read, run, down and migrate (both down and run) Migrations)
Commander to control run, show, reverse
bump versions of the devDependecies

I see that we need 3 PRs from points above

That sounds almost right, although the version bump would happen during the CI process or in the PR itself depending on the project. I don't know what this commander is, but looking forward to knowing more about it!

Notes:

I had some issues with reading sql files and split up and down code. I've used ts file with exports of down and up. But in this code it's working fine. Maybe some difference in versions?

Assuming you mainly copy/pasted the original merge code into your new class, the existing SQL files should work-as-is without modifications. If it's not working, then your new code may have bugs in it.
When you create a new PR for this feature, I can get a better look / understanding of it.

I plan to add a documentations of this work to Readme. Do I need to do it every PR with new changes?

If you're introducing a new feature and it's something developers would access, then the readme would have to be updated with usage and example information.

#180

Let's move to another PR to not remove all. And for clear goal purpose


Pressing continue on "Live bidding has started" payoff screen should redirect to the LAI interface

This PR addresses: https://artsyproduct.atlassian.net/browse/PURCHASE-261
The actual change is quite small-- instead of linking to /auction/sale-id, we link to live.artsy.net/sale-id (or staging) when you click the continue button on the "Live bidding has started" interface.
This did involve adding a new variable to emission (which @orta helped me out with). Since we're setting defaults depending on whether you're in staging or not, I don't think this needs any follow-ups? But you would know better. 😄

Fails

:no_entry_sign:

No CHANGELOG added.

:no_entry_sign:

This PR includes changes to the Emission Pod's native code but does not have a package.json
change for the update to the "native-code-version". If this is fine, add #native_no_changes to your PR message.

  Generated by :no_entry_sign: dangerJS

Merge on green.

Oh, actually Sarah, this is a breaking change from the Objective-C perspective. Can you increment the native-code-version in package.json?

I've up'd the native code version in #1169, we only need one of them.

Updated PR body to include #native_no_changes and restarted CI.


Add Datablend Connector

When submitting a connector, please make sure that you follow the requirements below, otherwise your PR might be rejected. We want to make you have a well-built connector, a smooth certification experience, and your users are happy :)
If this is your first time submitting to GitHub and you need some help, please sign up for this session.

[x] I attest that the connector doesn't exist on the Power Platform today. I've verified by checking the pull requests in GitHub and by searching for the connector on the platform or in the documentation.
[x] I attest that the connector works and I verified by deploying and testing all the operations.
[x] I attest that I have added detailed descriptions for all operations and parameters in the swagger file.
[x] I attest that I have added response schemas to my actions, unless the response schema is dynamic.
[x] I validated the swagger file, apiDefinition.swagger.json, by running paconn validate command.
[x] If this is a certified connector, I confirm that apiProperties.json has a valid brand color and doesn't use an invalid brand color, #007ee5 or #ffffff. If this is an independent publisher connector, I confirm that I am not submitting a connector icon.

If you are an Independent Publisher, you must also attest to the following to ensure a smooth publishing process:

[ ] I have named this PR after the pattern of "Connector Name (Independent Publisher)" ex: HubSpot Marketing (Independent Publisher)
[ ] Within this PR markdown file, I have pasted screenshots that show: 3 unique operations (actions/triggers) working within a Flow. This can be in one flow or part of multiple flows. For each one of those flows, I have pasted in screenshots of the Flow succeeding.
[ ] Within this PR markdown file, I have pasted in a screenshot from the Test operations section within the Custom Connector UI.
[ ] If the connector uses OAuth, I have provided detailed steps on how to create an app in the readme.md.

Hi @bmp02050 Thank you so much for your submission. In this pull request you are affecting other connectors' files.

can you please fix this? Thank you very much.

Had to revert e350e062 and undo the changes in that to get this to work.

Thank you so much for fixing that. Please expect a review from our certification engineers soon. Thank you so much again for your hard work.

Is there anything left besides waiting for a code review?

Hi @bmp02050,
I hope you are doing well.
Congratulations, your pull request is approved and merged. Please submit the files to ISV Studio using your latest commit id, please allow us up to 1-2 weeks to review your submission, and our Engineers will notify you in the “Activity Control” area in ISV Studio.
Please Create an environment in the Preview region. You will use this environment later to test your connector after Microsoft is done with the functional verification for your connector.
We expect all tests to be completed within 1-2 weeks.
If your connector passes all tests, the deployment process begins, and it typically takes up to 3 to 4 weeks to deploy your connector to all of our regions.
Please let me know if you have any questions.
Thank you very much for working with us.


[Event Request] page 343 "Check Credit Limit" - OnAfterCalcOverdueBalanceLCY

Can we please get the following event?
local procedure CalcOverdueBalanceLCY()
begin
    if GetFilter("Date Filter") = '' then
        SetFilter("Date Filter", '..%1', WorkDate);
    OnCalcOverdueBalanceLCYAfterSetFilter(Rec);
    CalcFields("Balance Due (LCY)");
    OnAfterCalcOverdueBalanceLCY(Rec); // New Event
end;

[IntegrationEvent(true, false)]
local procedure OnAfterCalcOverdueBalanceLCY(var Customer: Record Customer);
begin
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Run visualization using dev user

@KishPatel1996 can you pls redeploy using the dev user (I think the user under which the app is running should be www-data eventually). This is a convention for web accessed content.

What is the status on this. I will work on this tomorrow but need probably some guidance. I am planning to run your code off supervisor.

Before I deploy in on the dev user, I just want to add one more chart to it to graph temperature from the pressure sensor.  I am mostly done, just have to test it. I will be in BIDS around 3 tomorrow.
The code that is on Github right now in the data-reflector repository should run perfectly fine.

Ok, see you there. I will work on this deployment stuff most of the day.
On Sun, May 3, 2015 at 2:34 PM, Kishan Patel<EMAIL_ADDRESS>wrote:

Before I deploy in on the dev user, I just want to add one more chart to
it to graph temperature from the pressure sensor. I am mostly done, just
have to test it. I will be in BIDS around 3 tomorrow.
The code that is on Github right now in the data-reflector repository
should run perfectly fine.
—
Reply to this email directly or view it on GitHub
https://github.com/glass-bead-labs/data-reflector/issues/7#issuecomment-98546789
.

--
Falk Schuetzenmeister, PhD
Web Application Developer
Geospatial Innovation Facility http://gif.berkeley.edu/
University of California Berkeley
111 Mulford Hall
94720 Berkeley, CA
<EMAIL_ADDRESS>1-510-642-4897

What is the status on this. Would it be possible to run the visualization during data science faire life of the sensor? I tried to connect the pieces yesterday but could not find all of them in part due to not committed work.


Track KnownTypes per file

Having one global KnownTypes is prone to collision errors, triggering a very hard to debug panic in
CodeGenerationVisitor::generate_code_for_operation.
By tracking KnownTypes on a per-file basis, those panics no longer occur.

Wow, good catch! Thanks!


⚠ Bofrost.es has degraded performance

In 64b6ff5, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1670 ms

Resolved: Bofrost.es performance has improved in bf3b795 after 6 minutes.


experiment: attempt to resolve build errors

Not intending to merge this, but just as a good place for experimentation and discussion!

Closing as you've already figured it out!


SEED-714: Template menu

@peterp can you please review :)

@Mitso can you add screenshots?

I don't know the font used on the designs but looks something close to Open Sans to me.
There's a lot of variation in font, font-weight which affects padding I think.
Footer Links

Section links and search form

👍


Bump nikic/fast-route to 0.8

Other than the one problem with the version number, this looks good to me.
@equip/contributors anyone have thoughts?

:+1:


After using contour, how to observe whether knative enters serve mode?

After using contour, I saw that knative is always in proxy mode. Is this related to the implementation of net-contour?
Ref: https://knative.dev/docs/serving/architecture/#networking-layer-and-ingress

If you're looking at the internal resources (ServerlessService) and seeing Proxy/Serve mode then that's configuring whether the activator is in the path. This is unrelated to Contour.
Details are here:
https://knative.dev/docs/serving/load-balancing/
https://knative.dev/docs/serving/load-balancing/target-burst-capacity/
Going to close this out - feel free to re-open on the knative/serving repo  if you have further questions about the activator etc.


add gyro bmi160 and fix gyro i2c address

esp32 bmi160 on spi

esp32 bmi160 on i2c

rp2040 bmi160 on spi

fix i2c address detect 0x76 and 0x77
https://github.com/rtlopez/esp-fc/issues/81

Hi @AutoPlantBali Thanks for your contribution. I'd like to ask, that did you build any craft with this gyro? can you confirm that this code works "in the air"? Can you show any blacbox recording?
Fix for alternative i2c address looks fine.
Cheers

I made a board that supports mpu6500, mpu9250, bmi160, lsm6ds and bmp280. Next month I will order the PCB and start assembling it. I will show the results of testing using this sensor

Hi @AutoPlantBali, I merged your changes to develop branch, as I want to do some tests first. Next time It would be better if you put different features and fixes in separate PRs. Thanks again.

Hi @AutoPlantBali I've connected brand new BMI160 gyro, and calibration not passed. It seems that gyro has stored inaccurate offset values in NVM, this caused that gyro bias for x and y axis was around 10 deg/s. If I turn off applying offset, then bias is about 1 deg/s. Can you test these changes from develop branch with your device?
https://github.com/rtlopez/esp-fc/commit/19ed00762bfc078fb22ebd4b02da8aeaf1280efb
Thanks


WIll you support finetuning deepseek-coder?

Reminder

[X] I have read the README and searched the existing issues.

Reproduction
I am glad to see the project is supporting finetuning deepseek-moe as well as starcoder2 models. Given the popularity of code language model task, will you consider support deepseek-coder-(1.3b, 7b, 33b)-instruct models as these models are among the top models of code LLM?
Expected behavior
No response
System Info
No response
Others
No response

the deepseek coder models have been supported

the deepseek coder models have been supported
https://github.com/hiyouga/LLaMA-Factory/blob/d1587c80de2e3191952a952116039b719d8613d4/src/llmtuner/extras/constants.py#L266-L292

建议在Readme文档中补充一下deepseekcoder的template说明，因为可能会有人认为deepseek-coder相关的模型使用的template也是deepseek（比如我🙈）；
It is recommended to supplement the template description of deepseekcoder in the Readme document, because some people may think that the Template used by DeepSeek-Coder-related models is also deepseek (for example, I am);


fix submodule size early return

This PR closes #26. It places a placeholder for submodules.

Thank you for the PR, looks sound. Will review tomorrow.

I'm submitting the new version to shortly Google, usually takes between 1 hour - 2 days to get approved.


Consistency of API names surfaced by each SDK

Currently there are API names that are not consistent with other SDKs. Its worth reviewing the differences
For example in
https://github.com/dapr/python-sdk/blob/master/dapr/clients/grpc/client.py
execute_transaction and ExecuteStateTransactionAsync in .NET
get_states and GetBulkStateAsync in .NET

This is mainly terminology... however the SDK method/parameters are not "the API". I've renamed the Go SDK issue but I see we still refer to the APIs in .NET.


Organization of Dataset files for running Supplementary Codes

Dear Team,
I am trying to run Supplementary codes provided in the repository but am failing to execute the scripts due to some kind of expected folder structure mis-match. I tried to make modifications in the folder structure of my dataset to better suit the scripts but it still does not function.
Could you please provide a default expected folder structure of for eg. the following path to kemocon-root -
python preprocess.py --root '/path/to/kemocon_root'
In the path, I supply the location where my kemocon dataset is located, with a specific subfolder, but this does not seem to work.

@mihirmk Can you provide the error message you are seeing?

FileNotFoundError: [Errno 2] No such file or directory: '../../K_Emocon_dataset/metadata/subjects.csv'


Add descriptions about systemd-resolved option

Since https://github.com/prometheus-community/systemd_exporter/pull/119 has been merged, add descriptions for this feature and new flag.

I tried to follow current manner to write all metrics and expected cardinality for each metrics.
Though it could be a bit burden for future documentation, and these information(metrics type, cardinality) is not important as users can retrieve from metrics itself.
So may be we should keep this level's documentation only for core systemd metrics, and less description about additional collector would be there(e.g. add more section like Additional Collectors and add one line systemd_resolved: per exporter metrics with prefix sytemd_resolved .

@SuperQ
Hi, I think at least I need to add a description about new flag option for future release.
Should I fix the conflict and keep metrics description like watchdog metrics for now?
I'm going to fix it if needed.

@SuperQ
Hi, sorry for bother you again.
I have noticed your recent active work.. so could you release a new version after some updates finished?
There seems to be  some other people waiting for new release.
I'm not sure how to do that, though I'm also interested in maintaining some community based exporters like this, so please let me know if anything I can do for that.
Thanks.


Main

update Psr18Client in client

@maina-david Could you please provide some background information why this change is needed?

@gehrisandro HttpDiscovery is not an HTTP client itself but rather a library that helps one discover available PSR-18 client implementations in the environment. It allows the package to be more flexible and not tied to a specific HTTP client implementation like Symfony HttpClient.

Thank you for clarification. This sounds like a reasonable decision.
Will check if everything is compatible with the other packages and then going to merge it.


feat: Add greetings handler

Closes: #46
Signed-off-by: Michael Gasch<EMAIL_ADDRESS>

Codecov Report

Merging #47 (afd7402) into main (8ad38e8) will increase coverage by 9.63%.
The diff coverage is 84.61%.

@@            Coverage Diff             @@
##             main      #47      +/-   ##
==========================================
+ Coverage   26.98%   36.61%   +9.63%
==========================================
  Files           1        1
  Lines          63       71       +8
==========================================
+ Hits           17       26       +9
  Misses         43       43
+ Partials        3        2       -1

Impacted Files
Coverage Δ

main.go
36.61% <84.61%> (+9.63%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ad38e8...afd7402. Read the comment docs.


Deprecation warnings in test-app workflow log

Problem description
The workflow .github/workflows/test-app.yml produces deprecation warnings:

"Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: actions/checkout@v2, cypress-io/github-action@v2"

"The set-output command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/"

Steps to reproduce

Fork repository
Push to fork
View Actions log

Suggested fix
In .github/workflows/test-app.yml update:

actions/checkout@v2 to @v3
cypress-io/github-action@v2 to @v5

Additional suggestions
Update other dependencies to latest versions including updating Cypress to latest v9 legacy configuration version.
In a further step update Cypress to latest version (currently 12.x).

PR #12 submitted to resolve this issue

https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ has a deadline of May 31, 2023.

This issue is resolved by PR #15


PlugInstall returns immediately with no error message without installing anything

This is on a CentOS 6.4 machine, with a fairly recent vim 7.4.582 compiled with +ruby support (:echo has('ruby') shows 1; :ruby puts RUBY_VERSION shows 1.9.3.
I copied my .vimrc from an Ubuntu 12.04 box, so :PlugStatus shows all the "Not found. Try PlugInstall". But :PlugInstall returns immediately without installing anything and no error message:
Updated. Elapsed time: 0.068371 sec.

Finishing ... Done!

Is there a verbose mode that I can turn on to troubleshoot the problem?

Seems like the same problem as #170. Could you upgrade vim-plug and try again?

Confirmed that it's currently fixed and I extended Travis CI build so that these problems can be detected early. Sorry for the trouble.


Touch ID doesn’t work!!

After jailbreak b33 Touch ID doesnt catch finger, only passcode works
iPhone 8+ 10,5 , iOS 12.1

This should be related to futurerstore . Did you use it?

No, I didnt use it

@snuk0 Share diags please, a friend of mine reported this bug to me today too.
If you have blobs you can restore back to 12.1 later.

@clarityzzz https://drive.google.com/file/d/1xI1mjw97F0Gv-XEvxRrDYQYjR5yk7fxH/view?usp=drivesdk
unfortunately I dont have saved blobs for 12.1 :(

@snuk0 you can downgrade to 12.1.1 b3 if a jailbreak is really important to you.
If you have any 12.x blobs below 12.1.3, they're all usable for future-restoring.
I'll be taking a look into your logs.

I used only previous unc0ver beta versions

I don't believe it's related to root-fs since looking at your logs, it didn't get restored.

Fixed:
I rebooted my device(then Touch ID start working again) and jailbreaked again with enabled option „Restore RootFS (rec0ver)” and now its all good.

That's great to hear!


TCP/IP Fix

When try to get data via TCP/IP from Gateway the readed data was not received correctly.
Fixed it by looking for "\r\n" before using  the datahandler(data)

nice catch my friend, I happily accept your pull :P


max_pool works with anon variable

Added test failed before change.
https://groups.google.com/forum/#!topic/pylearn-dev/RxGwmSvuqtg

Thanks for the fix, sorry about the delay.


kiss: make the install prompt only appear when extra dependencies

The prompt used to appear when more than 1 packages were to be installed, but
this also happened when they all were specified on the commandline (even when
no extra dependencies were resolved). This is kind of redundant behaviour.
Now it will only appear when the number of packages explicitly supplied to
it and number of packages after dependency resolution are unequal (because
dependencies were found on resolution). I assume this was meant to be the
original intent for the behaviour but was left behind even after pkg_install()
gained the ability to receive multiple arguments.
Signed-off-by: FriendlyNeighborhoodShane<EMAIL_ADDRESS>

PS shellcheck seems to be complaining about the incorrect quoting in line 1307.

Also pushed my fix for the shellcheck error. Thanks for the reminder :)

Uh-oh, whoops, I totally forgot to make the same change in line (749)[https://github.com/kiss-community/kiss/blob/master/kiss#L749] in this proposal.
That prompt is a little different, but I think the same rules should apply to it. Was the original intention of it to prevent having to write the entire list of packages again? Because you can just press the up key and replace the b with an i)
Or alternatively, the conditional could be removed altogether, making the prompt appear in all cases, whether there's single or multiple packages, resolved dependencies or not. I'd dare say that'd be a lot more efficient and consistent. Since:

There have been very few cases where I wanted to build something but not immediately install it
And when I did want that, it was definitely not because of the number of packages or whether dependencies were there.

So I'd propose removing the last "run kiss i *" message branch altogether, because it's pretty useless.

    if [ "$pkg_update" ]; then
        return
    else
        prompt "Install built packages? [$*]"
        args i "$@
    fi

Dylan had at some point (prior to the 6.0.0 cherry picks) changed the behavior to not prompt at all; when I asked for the old behavior back he kindly obliged.
I'm fine with prompting always.

Thanks!

Thanks for making the change!


Addon no longer functional in v2.1.0

Hi,
The addon is prompting to sell items, but after pressing the confirm button it does not actually post anything. it keeps asking to post with no result.

I have released 2.1.1 which hopefully fixes this.

Hey Sanjo - jump on this issue, as I'm not sure it's fixed. Running /run CommodityBuyerAndSellerData.doConfigured() is not firing it up. Here is my CommodityBuyerAndSellerData.lua - which was working on 2.0.0:
CommodityBuyerAndSellerData = {}

function CommodityBuyerAndSellerData.doConfigured()
	CommodityBuyerAndSeller.sell(193243, 1000, 30, 200)
	CommodityBuyerAndSeller.sell(193244, 1000, 30, 550)
endaq

Prices on AH are above the minimums for both items. Just doesn't do anything when I fire off the /run command.


Not working - JS Error

Uncaught TypeError: Cannot read property 'trim' of undefined
    at trim (Util.js:121)
    at splitWords (Util.js:127)
    at NewClass.on (Events.js:49)
    at NewClass.initialize (leaflet.markercluster-src.js:51)
    at new NewClass (Class.js:22)
    at Object.L.markerClusterGroup (leaflet.markercluster-src.js:1080)
    at map_init (map:678)
    at HTMLDocument.<anonymous> (map:683)
    at fire (jquery.js:3187)
    at Object.fireWith [as resolveWith] (jquery.js:3317)

Followed the documentation on readme, it looks like outdated tho

Same error after install

@nfacha @kxxxo Big apologies... I do not have much time to fix the bug my self right now, but I'll fix it as soon as i can.

Same error...
I need to change
$cluster = new MarkerCluster([
'jsonUrl' =>   Yii::$app->controller->createUrl('projects/json')
]);
for this:
$cluster = new MarkerCluster([
'url' =>   Yii::$app->urlManager->createUrl('projects/json')
]);
Because jsonUrl isn't throws this exception:
Setting unknown property: dosamigos\leaflet\plugins\markercluster\MarkerCluster::jsonUrl
and
Yii::$app->controller->createUrl('projects/json')  throws: Calling unknown method: app\controllers\ProjectsController::createUrl()
but the error (Uncaught TypeError: Cannot read property 'trim' of undefined) don't fixed


fix: Remove "purpose" column, show purpose as badge

Fixes #5711

The only downside of the proposal is that it removes the ability to sort by the column


[BUG] Inserting images/videos scrolls user to top of text area

Incredible editor, fast to setup and simple! TY FOR CREATING IT!
Now let's head to the bug:
Jodit Version:  3.6.1 CDN
Browser: Chrome
OS:  Windows
Is React App:  False
Explanation
Same thing that was happening here: https://github.com/xdan/jodit/issues/519 but when inserting images and videos.
It can be tested here:

https://tetreum.github.io/brickcraft/?/blog-editor
Select as entry to edit Devblog 1 ....
Scroll down and add an image or a video at the end of the post.
BOOM it will scroll up.

Any news about that?


Installation page not accessible if behind (ssl-)proxy?

I try to run hubzilla in an http-only apache, which is proxied with a nginx (who serves the ssl and "connects the dots" to the actual domain name).
From within the local "net" (its all VMs, really) I can access the installation-check page via the machines IP adress. The script itself complains about .htaccess rewrite rules which have to do with ssl I think.
From "outside" however I can only access some static files and fail to find any helpful log message anywhere. I suspect it has to do with my setup. Anybody can give me pointers to whether this should work?
Base is a vanilla ubuntu16.04 VM. The actual proxy is using dokku and its nginx-templating. I am happy to provide any configuration details if that helps. thanks.
Edit I manage to see the default Apache accessed from outside via https and the domain name (if I reset the apache config). But the installation page is only accessible from within, without domain name.

Okay, small progress:
sudo hostname myhost.mydomain,
edit /etc/hostname and /etc/hosts accordingly. But now the installation check does not understand that no .htaccess ssl-redirection is necessary anymore (and resolves to localhost i guess):
Url rewrite in .htaccess is not working. Check your server configuration.Test: array ( 'return_code' => 0, 'success' => false, 'header' => '', 'body' => '', 'error' => 'Failed to connect to myhost.mydomain port 443: Connection refused', 'debug' => array ( 'url' => 'https://myhost.mydomain/setup/testrewrite', 'content_type' => NULL, 'http_code' => 0, 'header_size' => 0, 'request_size' => 0, 'filetime' => -1, 'ssl_verify_result' => 0, 'redirect_count' => 0, 'total_time' => 0.0042620000000000002, 'namelookup_time' => 0.004215, 'connect_time' => 0.0, 'pretransfer_time' => 0.0, 'size_upload' => 0.0, 'size_download' => 0.0, 'speed_download' => 0.0, 'speed_upload' => 0.0, 'download_content_length' => -1.0, 'upload_content_length' => -1.0, 'starttransfer_time' => 0.0, 'redirect_time' => 0.0, 'redirect_url' => '', 'primary_ip' => '', 'certinfo' => array ( ), 'primary_port' => 0, 'local_ip' => '', 'local_port' => 0, ), )
Have to fake or uncomment that somehow.

This is the relevant issue:
Failed to connect to myhost.mydomain port 443: Connection refused

Yes. But when in production will the hubzilla instance have to speak with itself via 443? Afaiu this check is for making sure that htaccess redirection works and ssl is set up.

Not often, but yes - it will. Some message deliveries are done locally, but for channel discovery and "friending" we don't distinguish whether it is a remote or local channel and connect via the web in both cases.

Oh damn. Okay, thanks for the info! I will keep this issue open until I resolved my case (or gave up :) ).
And I guess the certificate used has to be "browser-valid" also where hubzilla talks to itself?

So, doing a local port forward of 443 to the proxy changes the situation, but the rewrite test (Zotlabs/Module/Setup.php) fails. I am not an .htaccess pro, but which is the rewrite rule that should make this work (path is setup/testrewrite)? I do not see it in the distributed .htaccess file.

So, the basic setup seems to work fine. There was confusion because the address typed in into the web-installer does not end up as base-url (I believe, at least), so that I had to manually change it to https.
I believe my aim is kind of achieved (way more complicated than I'd wish to). Only thing I'd like to make sure is that self-messages arrive. @zotlabs Any way to test that? Which messages are delivered to the same hub via https://? Channel discovery? That would mean to test I add two channels, two accounts and try to find the other?

Simplest thing would be to visit /probe (a channel discovery tool) and enter the nickname of a local channel.  It also reports on the first line or two if it had to fallback from https to http in order to discover something.

Seems to work


DP-1.10 - Mixed strict priority and WRR traffic test - Adding required vendor specific queue name change and interface-ref definition

DP-1.10 - Mixed strict priority and WRR traffic test - Adding required vendor specific queue name change and interface-ref definition

Added Queue ID as required by Juniper.
Other pull request containing such changes: https://github.com/openconfig/featureprofiles/pull/1087.
Related OC model change: https://github.com/openconfig/public/pull/772
Included existing deviation ExplicitInterfaceRefDefinition for interface configuration under QoS(classifier and scheduler)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 56.88%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1236

Relevant Lines:
2173

💛  - Coveralls

/gcbrun

/gcbrun

/gcbrun


Version 2.7.0 still reporting 2.6.0

I've installed 2.7.0 with the latest KiCad 7.0.6
When running IHB it's showing 2.6.0 in the title. Is this due to version.py still showing 2.6.0?
LAST_TAG = 'v2.6.0'

Downloading InteractiveHtmlBom_v2.7.0_pcm.zip or InteractiveHtmlBom.zip shows 2.6.0 in the version.py file as well.

Yes, I forgot to bump version there. It's does not affect functionality.

2.8.0 should report correctly.


1.28.0 BeatUpServer lobbies don't alias to 1.22.0+

BeatUpServer lobbies are cross compatible between 1.28.0 and older versions since this commit, which both public instances are now updated to.

I'm expecting BeatTogether to make a decision today, or at least before the end of the week, as to how they're handling 1.28. There's a chance they're doing a hard compatibility break, so some custom logic per server type may be needed.
I'll wait for that decision and then figure out the best way to handle this on BSSB.

Just to follow up: BeatTogether is making a clean break on 1.28 with no backwards compatibility, following official servers. MultiplayerCore needs to be updated as well for unrelated reasons (SongCore compatibility).
I'll have to figure out per-server-type logic for aliasing.


Image to composite must have same dimensions or smaller.

Hi, we're struggling with this issue long time ago. Couldn't find any answer besides that the issue is more or less known. We use different tricks to bypass it, but would be great to find a permanent solution within Sharp.
The problem occurs when we want to watermark different images. For that we're using the composite function which works great except when the overlaying layer's height is bigger than the original image. Even one pixel of difference makes crush the process, however didn't experience the same problem with widths. I think it would be a solution if the overlaying image would be cropped whenever it's necessary.
Any chance anyone has a proper solution (without changing the ratio)? Or the developers would consider to fix this problem?
Thank you in advance.

@tmihalik We will discuss this and get back to you

Hey, is there anything about this question? I have found a different solution for myself but I think this bug should be important for others.

@tmihalik We are adding this to our backlog now and will let you know when we have a version that supports it.
Thanks for your report.

@tmihalik Could you provide the following information about this issue

version deployed
an example request including the image dimensions where you are experiencing the problem

@tmihalik We discussed automatically cropping the overlay image down to the base image dimensions when it was larger and decided that would be a behavior change. Instead, we changed the error response to be more specific and indicate that it was a bad request and that the failure was due to the overlay image dimensions. The request in this case will still fail but it will note the actual cause.


Updates Core version to 1.4.0

https://github.com/arquillian/arquillian-extension-persistence/pull/99


Fix Jython download link in README

This PR fixes the broken download link to download Jython

@codingo fyi, the link is still broken in the README.


Add Control+Shift+U (rebindable) action for Unicode input, show hex as it is entered.

Implements https://github.com/godotengine/godot-proposals/issues/10654

Adds ui_unicode_start action (set to Control+Shift+U by default) start Unicode hex input (code submitted/canceled by ui_text_submit/ui_cancel actions).
Adds hex code display (for both Alt+ and new action).

https://github.com/user-attachments/assets/ceff8455-33dc-4a61-8e78-5920c9b0b680

It remains stuck after you press other keys such as arrow keys:

Is it supposed to do something until you press Enter/Esc to commit/cancel it? (Video seems to only show static frame with Ctrl+R visible, not sure if it's an issue with recording or Firefox)

It remains stuck after you press other keys such as arrow keys:

Is it supposed to do something until you press Enter/Esc to commit/cancel it? (Video seems to only show static frame with Ctrl+R visible, not sure if it's an issue with recording or Firefox, and downloaded video refuse to open at all).

For the record, I tested the same feature in Firefox, and it seems to accept the following keys to end the edit mode and process the character:

Enter/Return
Space
Ctrl
Shift

Ctrl and Shift are maybe a bit far fetched, but in our implementation I'd feel natural for Space to work too. Or we could support the same keys as Firefox for convenience. That being said I see merit in using ui_text_submit over ui_accept, so maybe it's fine as is.

Tested locally on Fedora 40 KDE X11, there are some issues when you use Shift + home row keys to enter numbers on a French AZERTY (fr-oss) keyboard layout. It remains stuck after you press other keys such as arrow keys:

I confirm that with a French keyboard the main number keys can't be used.
After pressing Ctrl+Shift+U:

Pressing é à & " (first-level keys on the 2 0 1 3 key positions) inputs only 20
Pressing Shift+é (2) Shift+à (0) Shift+& (1) Shift+" (3) also only inputs 20

The behavior is weird when you move the caret:
https://github.com/user-attachments/assets/b73e6f03-8e8e-4d78-afd9-8b3d31cbe3b0

The behavior is weird when you move the caret

This is a side effect of https://github.com/godotengine/godot/pull/87479 (this change seems fine, but I have not accounted for this behavior, the same change probably should be done for LineEdit), should be fixed now.

Pressing é à & " (first-level keys on the 2 0 1 3 key positions) inputs only 20
Pressing Shift+é (2) Shift+à (0) Shift+& (1) Shift+" (3) also only inputs 20

Should work now, both with and w/o Shift (tested on macOS), I forgot there are keyboard layouts with non-primary level numbers.

That being said I see merit in using ui_text_submit over ui_accept, so maybe it's fine as is.

Changed it to use both ui_accept and ui_text_submit, not sure about Shift and Ctrl.

this change seems fine, but I have not accounted for this behavior, the same change probably should be done for LineEdit

Updated LineEdit to handle IME and this in the same way TextEdit do.

Thanks!


Update makefile to use python3

On installing python3 on your machine command python is undefined error will appear or python can not be found.

Already done in https://github.com/OpenDevin/OpenDevin/pull/650.


[DRAFT] Update to recent platform chart version

Update Camunda platform dependency
Updating to the recent version involved several changes, as some behaviors and properties changed in the parent chart. See https://docs.camunda.io/docs/self-managed/setup/upgrade/#deprecation-notes
Prework:

Introduced a variable in make file, so I can build the project locally. I have multiple go versions / binaries installed.
Add missing golden file tests for zeebe deployments

Migration work:

Disable identity keycloak it was separated from identity subchart (there exist no longer an sub chart)
Change zeebe-gateway to zeebeGateway
Set tag on all components, see related thread

Fix in parent to use right version in label - https://github.com/camunda/camunda-platform-helm/pull/2183

Rename the benchmark zeebe-config - application.yaml file and mount to benchmark-config.yaml to not clash with the new default application.yaml

Otherwise: Installation will be broken. We can't define/mount an application.yaml as this is now done using the platform chart. We can't override the default configuration, as this replaces all defaults. We can't copy the template, as templates are not supported currently. We can't simply copy values from an installed chart, as they depend on the configs of the chart and are dynamic evaluated like clusterName: {{ tpl .Values.global.zeebeClusterName . }}. See thread
In order to load the benchmark-config.yaml we configure spring for an additional config location, see https://docs.spring.io/spring-boot/reference/features/external-config.html#features.external-config.files. Thanks to @npepinpe for the hint.

Generate all golden files

Related
Closes https://github.com/zeebe-io/benchmark-helm/pull/158
Closes https://github.com/zeebe-io/benchmark-helm/pull/145

With the and especially setting SPRING_CONFIG_ADDITIONALLOCATION we can now install the chart again. We can also see the config has been applied via:
 k port-forward svc/zeebe-benchmark-test-zeebe 9600

And accessing http://localhost:9600/actuator/configprops
In the gateway the threads are set

In the brokers the properties are set as well

Benchmark is successfully running here https://grafana.dev.zeebe.io/d/zeebe-dashboard/zeebe?orgId=1&refresh=10s&var-DS_PROMETHEUS=prometheus&var-cluster=All&var-namespace=ck-update-helm&var-pod=All&var-partition=All&from=now-3h&to=now

As the aftermath we have to adjust the benchmark helm install settings/configs in the Camunda repo.

❓ Should we enable Identity eventually? We can't benchmark multi-tenancy without it, for example. And we already know there are some performance issues surrounding it (e.g. blocking calls in gateway). Plus, they will start using Zeebe as a DB, so we will likely want that. Not in this scope of course, just saying because you mentioned disabling it 😄

Thanks for the question. I don't think we need to do this in the defaults for now. This can be done via --set camunda-platform.identity.enabled=true for example. I actually planned to do once a chaos day with identity, but had never time for it, unfortunately.

🔧 Did you start a line with upstream about extensible configuration? An issue, Slack thread, or something?

See slack thread https://camunda.slack.com/archives/C03UR0V2R2M/p1722947834149849
See github issue https://github.com/camunda/camunda-platform-helm/issues/2197


Take over this repo?

Anyone want to take over this repo? Sorry I haven't checked this in forever and haven't had any time.

@yamill, this is a very useful package you should talk to the @react-community people and ask them if they can take over it.

Let's migrate this to react-native-community.
cc: @dmtrKovalenko @satya164 @brentvatne please guide us on how to transfer org ownership.

There needs to be an active maintainer or someone who wants to take over the project for us to move. Community org is not meant to be place to transfer unmaintained repos, but for good quality and well maintained libraries.

I am interested in becoming the maintainer for this if @yamill is fine with it. I would like to maintain it under the react-native-community umbrella of projects.

this repo seems to be a fork of this, and of course, active. maybe he and @paramaggarwal can be new maintainers.(maybe in react-native-community.)

@alikazemkhanloo is right. The linked repo in his/her comment is active and works fine. I would also suggest to transfer it into react-native-community!

Moving it to RNC would be fine, as long as there is at least one (ideally two) maintainer(s) assigned to it. If @paramaggarwal and/or @wonday are interested in maintaining, then let's do it. Please comment here and if you are fine with it, we can starting the process and see what we can do.

@yamill I would love to maintain this repo for everyone in the community. I have some experience with native modules and I think I can handle it.

@yamill I would love to maintain this repo for everyone in the community. I have some experience with native modules and I think I can handle it.

Hey @yamill (and pinging @pvinis @ammarahm-ed @JCMartell as part of this discussion).
Can we either archive this repo and point users to https://github.com/wonday/react-native-orientation-locker or move this repo to React Native community (if someone wants to pickup the maintainance of this)?
I was looking at this repo in the context of the New Architecture for React Native.
There are a number of open issues on this repo related to compatibility with latest version which are making this library harder to use, such as #410 #407 #403 #399

Can't believe it's been two years since I posted a comment here. 😄

pointing to https://github.com/wonday/react-native-orientation-locker seems like a good idea.


Fix: Clean up erroneous use of the PUT HTTP verb #2431

#2431

Automated message from Dropbox CLA bot
@540KJ, it looks like you've already signed the Dropbox CLA. Thanks!

I think you should also need to change the API bindings under api/ to stop using PUT in create_user.

Posted a couple comments; otherwise this looks good @540KJ!

@timabbott Added changes. Thoughts?

@540KJ it looks like your code doesn't work; see the Travis CI output :)

Rebased off master. Getting this error:

Tried changing {'PUT': 'zerver.views.reactions.add_reaction_backend', into a POST version. Still receives same error. Don't know why.

The reaction one should stay as PUT; that one is actually using PUT correctly.

I left test_reactions.py as it was. Still getting {"msg":"Emoji 'smile' does not exist","result":"error"} I tried to print out the emoji lists that supposedly contain the smile emoji, they printed out empty lists. Have I done something seriously wrong?

This sufficed to get the backend tests passing:
diff --git a/zerver/tests/test_realm_emoji.py b/zerver/tests/test_realm_emoji.py
index a978ef1..dcc064c 100644
--- a/zerver/tests/test_realm_emoji.py
+++ b/zerver/tests/test_realm_emoji.py
@@ -82,7 +82,7 @@ class RealmEmojiTest(ZulipTestCase):
         realm.add_emoji_by_admins_only = True
         realm.save()
         data = {"name": "my_emoji", "url": "https://example.com/my_emoji"}
-        result = self.client_put("/json/realm/emoji", info=data)
+        result = self.client_post("/json/realm/emoji", info=data)
         self.assert_json_error(result, 'Must be a realm administrator')

     def test_delete(self):

I think if you apply that fix, this should pass tests.  However, I can't accept this PR as-is.  This should have 1 commit per route that is being moved.

Thoughts?

Looks great; I'll try to review today (no promises though, since it's a holiday!)

Thanks for working on this @540KJ!
I merged everything but the emoji commit.  For that one, the Reactions case is actually using PUT correctly; we shouldn't change it.  We just need to change the realm emoji one; arguably, we should convert it to work like the emoji reactions style (AKA move the choice of emoji into the URL) rather than converting it to use POST.
In other words, move the PUT entry here next to the DELETE block.
    url(r'^realm/emoji$', rest_dispatch,
        {'GET': 'zerver.views.realm_emoji.list_emoji',
         'PUT': 'zerver.views.realm_emoji.upload_emoji'}),
    url(r'^realm/emoji/(?P<emoji_name>[0-9a-zA-Z.\-_]+(?<![.\-_]))$', rest_dispatch,
        {'DELETE': 'zerver.views.realm_emoji.delete_emoji'}),

When I try to update result in test_upload to result = self.client_put("/json/realm/emoji/my_emoji"), I receive {"msg":"Internal server error","result":"error"}. Any tips for solving?

There should be a traceback showing the actual failure above that lint; you'll need to provide that to make it possible to debug...

  File "/srv/zulip-venv/local/lib/python2.7/site-packages/django/core/handlers/base.py", line 185, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/srv/zulip-venv/local/lib/python2.7/site-packages/django/views/decorators/csrf.py", line 58, in wrapped_view
    return view_func(*args, **kwargs)
  File "/srv/zulip/zerver/lib/rest.py", line 122, in rest_dispatch
    return target_function(request, **kwargs)
  File "/srv/zulip/zerver/decorator.py", line 429, in _wrapped_view_func
    return view_func(request, *args, **kwargs)
  File "/srv/zulip-venv/local/lib/python2.7/site-packages/django/utils/decorators.py", line 149, in _wrapped_view
    response = view_func(request, *args, **kwargs)
  File "/srv/zulip/zerver/decorator.py", line 477, in _wrapped_view_func
    return authenticate_log_and_execute_json(request, view_func, *args, **kwargs)
  File "/srv/zulip/zerver/decorator.py", line 455, in authenticate_log_and_execute_json
    return view_func(request, user_profile, *args, **kwargs)
TypeError: upload_emoji() got an unexpected keyword argument 'emoji_name'

Traceback (most recent call last):
  File "/srv/zulip/zerver/lib/test_runner.py", line 131, in run_test
    test_method()
  File "/srv/zulip/zerver/tests/test_realm_emoji.py", line 52, in test_upload
    self.assert_json_success(result)
  File "/srv/zulip/zerver/lib/test_classes.py", line 302, in assert_json_success
    self.assertEqual(result.status_code, 200, result)
  File "/usr/lib/python2.7/unittest/case.py", line 515, in assertEqual
    assertion_func(first, second, msg=msg)
  File "/usr/lib/python2.7/unittest/case.py", line 508, in _baseAssertEqual
    raise self.failureException(msg)
AssertionError: Vary: Accept-Language, Cookie
Content-Type: application/json
Content-Language: en

{"msg":"Internal server error","result":"error"}

in test_upload:
    def test_upload(self):
        # type: () -> None
        email =<EMAIL_ADDRESS>        self.login(email)
        data = {"name": "my_emoji", "url": "https://example.com/my_emoji"}
        result = self.client_put("/json/realm/emoji/my_emoji")
        self.assert_json_success(result)
        self.assertEqual(200, result.status_code)
        emoji = RealmEmoji.objects.get(name=data['name'])
        self.assertEqual(emoji.author.email, email)

        result = self.client_get("/json/realm/emoji")
        content = ujson.loads(result.content)
        self.assert_json_success(result)
        self.assertEqual(len(content["emoji"]), 1)
        self.assertIn('author', content["emoji"]['my_emoji'])
        self.assertEqual(
            content["emoji"]['my_emoji']['author']['email'], email)

        realm_emoji = RealmEmoji.objects.get(realm=get_realm_by_string_id('zulip'))
        self.assertEqual(
            str(realm_emoji),
            '<RealmEmoji(zulip.com): my_emoji https://example.com/my_emoji>'
        )

@540KJ can you rebase this onto master to clear our the commits that are already merged?
Once you do that, I can spend a few minutes helping debug the remaining issue with using the right verb.

@timabbott Pushed the remaining issue.

OK, cool, it turns out the issue here was that you needed to also update the view function to accept the arguments in the new format.  I'll merge the corrected version of this shortly.