User/docker tests broken with duplicate identifier IteratorResult

https://github.com/microsoft/TypeScript/pull/32324 shows some errors in the user tests with duplicate identifier IteratorResult between the es2015 lib and @types/node. The docker tests also fail, probably for a similar reason.
#32303 should fix some of these errors; we should make sure that the docker tests compile without error since those are open source partner teams in microsoft. Not sure if the fix will be in our code or theirs.

I'm seeing the same thing when I tried to move to 3.6.1-rc
    ERROR in<EMAIL_ADDRESS>    ERROR in C:/Users/Eric/code/vscode-gitlens/node_modules/@types/node/index.d.ts(177,11):
    TS2300: Duplicate identifier 'IteratorResult'.

    ERROR in C:/Users/Eric/code/vscode-gitlens/node_modules/typescript/lib/lib.es2015.iterable.d.ts
    ERROR in C:/Users/Eric/code/vscode-gitlens/node_modules/typescript/lib/lib.es2015.iterable.d.ts(41,6):
    TS2300: Duplicate identifier 'IteratorResult'.

@eamodio You need to update the version of @types/node you are using as this has already been addressed in that types package.

@rbuckton Excellent -- that worked! Thank you!

I upgraded to typescript 3.7.2 today and now am seeing the same error:
node_modules\@types\node\index.d.ts(72,11): error TS2300: Duplicate identifier 'IteratorResult'
I have upgraded @types\node to latest (12.12.60, but still getting the error. Any suggestions?

@JontyMC where is the other location that it is defined? I just ran into that issue as well:
node_modules/@types/node/index.d.ts:169:11 - error TS2300: Duplicate identifier 'IteratorResult'.

169 interface IteratorResult<T> { }
              ~~~~~~~~~~~~~~

  node_modules/typescript/lib/lib.es2015.iterable.d.ts:41:6
    41 type IteratorResult<T, TReturn = any> = IteratorYieldResult<T> | IteratorReturnResult<TReturn>;
            ~~~~~~~~~~~~~~
    'IteratorResult' was also declared here.

However, for me it was because I didn't have @types/node installed in that project. For you I see that you already have this installed. Could it be a reference in your tsconfig lib prop that's causing this? What do you have listed in there?

Yeah, that was the issue, thanks. I had:
<EMAIL_ADDRESS>If this helps anyone else, I'm using Aurelia, and had to remove the above from aurelia.json in transpiler > dtsSource.
Here's a good post that explains how type definitions work https://blog.angular-university.io/typescript-2-type-system-how-do-type-definitions-work-in-npm-when-to-use-types-and-why-what-are-compiler-opt-in-types/

@eamodio You need to update the version of @types/node you are using as this has already been addressed in that types package.

@rbuckton Exactly where is this addressed already?  IteratorResult is still there at: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/node/index.d.ts#L72

@rbuckton we need a flag to disable this error.  The release notes say we need to fix this on case-by-case basis, but we cannot fix it for libraries that we cannot control, so due to this one feature we cannot adopt Typescript 3.7.
Why can't we opt in to this behaviour as has been the case with other stricter checking changes?

@nealeu this is handled by the "typesVersions" entry in package.json: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/50adc95acf873e714256074311353232fcc1b5ed/types/node/package.json#L4-L10
When the TypeScript compiler searches for types (either using the "types" entry in your compiler options or automatic type directive detection when an "types" is not present), it will search in node_modules/@types/node and encounter this package.json. This informs the compiler to redirect the request for<EMAIL_ADDRESS>to<EMAIL_ADDRESS>which does not contain IteratorResult.
However, if your build is configured such that you are explicitly adding<EMAIL_ADDRESS>(either via "files" or "includes" in your tsconfig.json), the compiler does not perform this redirection.

@rbuckton Thanks.  Sorry to have required spoon-feeding.

@rbuckton I'm running into this issue even when upgrading to the latest @types/node^10 on TypeScript 3.7. any advice would be appreciated!
Here are the errors:
node_modules/@types/node/index.d.ts:72:11 - error TS2300: Duplicate identifier 'IteratorResult'.

72 interface IteratorResult<T> { }
             ~~~~~~~~~~~~~~

  node_modules/typescript/lib/lib.es2015.iterable.d.ts:41:6
    41 type IteratorResult<T, TReturn = any> = IteratorYieldResult<T> | IteratorReturnResult<TReturn>;
            ~~~~~~~~~~~~~~
    'IteratorResult' was also declared here.

node_modules/@types/node/index.d.ts:93:15 - error TS2451: Cannot redeclare block-scoped variable 'custom'.

93         const custom: symbol;
                 ~~~~~~

  node_modules/@types/node/ts3.2/util.d.ts:6:15
    6         const custom: unique symbol;
                    ~~~~~~
    'custom' was also declared here.
  node_modules/@types/node/ts3.2/util.d.ts:9:15
    9         const custom: unique symbol;
                    ~~~~~~
    and here.

node_modules/@types/node/index.d.ts:96:15 - error TS2451: Cannot redeclare block-scoped variable 'custom'.

96         const custom: symbol;
                 ~~~~~~

  node_modules/@types/node/ts3.2/util.d.ts:6:15
    6         const custom: unique symbol;
                    ~~~~~~
    'custom' was also declared here.
  node_modules/@types/node/ts3.2/util.d.ts:9:15
    9         const custom: unique symbol;
                    ~~~~~~
    and here.

node_modules/@types/node/ts3.2/util.d.ts:6:15 - error TS2451: Cannot redeclare block-scoped variable 'custom'.

6         const custom: unique symbol;
                ~~~~~~

  node_modules/@types/node/index.d.ts:93:15
    93         const custom: symbol;
                     ~~~~~~
    'custom' was also declared here.
  node_modules/@types/node/index.d.ts:96:15
    96         const custom: symbol;
                     ~~~~~~
    and here.

node_modules/@types/node/ts3.2/util.d.ts:9:15 - error TS2451: Cannot redeclare block-scoped variable 'custom'.

9         const custom: unique symbol;
                ~~~~~~

  node_modules/@types/node/index.d.ts:93:15
    93         const custom: symbol;
                     ~~~~~~
    'custom' was also declared here.
  node_modules/@types/node/index.d.ts:96:15
    96         const custom: symbol;
                     ~~~~~~
    and here.

node_modules/typescript/lib/lib.es2015.iterable.d.ts:41:6 - error TS2300: Duplicate identifier 'IteratorResult'.

41 type IteratorResult<T, TReturn = any> = IteratorYieldResult<T> | IteratorReturnResult<TReturn>;
        ~~~~~~~~~~~~~~

  node_modules/@types/node/index.d.ts:72:11
    72 interface IteratorResult<T> { }
                 ~~~~~~~~~~~~~~
    'IteratorResult' was also declared here.

 Are you using tsc directly, or another build tool like gulp, etc.? From what you've posted<EMAIL_ADDRESS>is still somehow being directly added to your compilation.

@rbuckton I'm invoking tsc directly or using an npm build script such as:
  "scripts": {
    "build": "npm run ts-build && npm run lint && npm run parcel-build",
    "lint": "tslint -p . -t verbose",
    "parcel-build": "NODE_ENV=production parcel build --no-cache --out-dir ../java/appserver/src/main/resources/appserver/web/bin-js ./ts/bundle.ts ./ts/bundle-graphiql.ts ./ts/bundle-components.ts",
    "ts-build": "tsc --noEmit -p .",
  },

Even running the script like the defined npm build script ts-build or running a tsc command manually, results in the previous error that I posted.

Do you see errors when you run npm run ts-build, or do they only show up when you run npm run parcel-build?

@rbuckton it stills errors with npm run ts-build only

Sorry, I just noticed you mentioned running ts-build also results in the errors. I noticed you have "types": [] in your tsconfig.json. This tells the compiler to not generate automatic type references. How are your node types being referenced then? Are you using /// <reference types="node" /> in one of your source files?

@rbuckton I see. we just have them added to our dev dependencies. is that not suitable? we aren't using /// <reference types="node" />.

In general, unless something has a /// <reference types="node" /> somewhere, if you have "types": [] then we shouldn't be including the NodeJS types at all. We exclude "node_modules/**/*" by default, so it shouldn't be automatically included. One possibility might be in how your project is structured. Is your tsconfig.json in the same directory as your node_modules? If not, or if you have additional node_modules directories underneath your project, then it is possible it could be included from there.
You could try restricting your included files by adding an "include": [...] to your tsconfig to ensure you are only including your sources by default (i.e. "include": ["src/**/*"]):
{
  "compilerOptions": { ... },
  "parcelTsPluginOptions": { ... },
  "include": ["paths/to/your/sources"]
}

If the build then fails because it can't resolve a NodeJS built-in module like "fs", then you are moving in the right direction. You could then modify your "types" entry in tsconfig.json to "types": ["node"] to ensure the NodeJS type definitions are included automatically, which should use the correct module resolution behavior.

I also get the following error with TS3.7.2 and<EMAIL_ADDRESS>node_modules/@types/node/index.d.ts(200,11): error TS2300: Duplicate identifier 'IteratorResult'.
node_modules/typescript/lib/lib.es2015.iterable.d.ts(41,6): error TS2300: Duplicate identifier 'IteratorResult'.

tsconfig.json
{
  "compilerOptions": {
    "allowJs": true,
    "outDir": "build/",
    "rootDir": ".",
    "target": "es2015",
    "moduleResolution": "node",
    "module": "commonjs",
    "esModuleInterop": true,
    "allowSyntheticDefaultImports": true,
    "sourceMap": false,
    "inlineSourceMap": true,
    "inlineSources": true,
    "noImplicitThis": false,
    "noImplicitAny": true,
    "strictFunctionTypes": true,
    "strictNullChecks": true,
    "suppressImplicitAnyIndexErrors": true,
    "lib": [
      "esnext"
    ]
  },
}

So far tried to play around with types typeRoots include and exclude without luck. Any ideas?

@m19: Are you using tsc to perform your build or a different build process/orchestrator like Gulp/Jake?

@rbuckton it seems somehow I was stuck at @types/node``10.10.x and I just managed to fix it by updating to 10.17.5. Sorry!

Hi, I'm getting the same errors as well:
node_modules/@types/node/index.d.ts(66,11): error TS2300: Duplicate identifier 'IteratorResult'.
node_modules/typescript/lib/lib.es2015.iterable.d.ts(41,6): error TS2300: Duplicate identifier 'IteratorResult'.

Using Node: v9.11.2, "@types/node": "9.6.55", "typescript": "3.7.3" and "grunt-ts": "6.0.0-beta.17", "grunt": "0.4.5".
Global: tsconfig.json
{
  "compileOnSave": true,
  "compilerOptions": {
    "baseUrl": ".",
    "declaration": true,
    "lib": [
      "esnext",
      "dom"
    ],
    "module": "commonjs",
    "moduleResolution": "node",
    "sourceMap": true,
    "target": "es2017"
  },
  "exclude": [
    "node_modules"
  ]
}

Module: tsconfig-lib.json
{
  "extends": "../tsconfig.json",
  "compilerOptions": {
    "rootDir": "./src",
    "outDir": "./lib"
  },
  "include": ["./src/**/*.ts"],
  "types": ["node", "mocha"]
}

I've tried to play with all mentioned blocks (like types and exclude), but nothing helped.
Any help is appreciated.

Per @rbuckton, you'll need to update @types/node.

Per @rbuckton, you'll need to update @types/node.

Unfortunately, it was the first thing I tried and that didn't help.

The latest versions of the node declarations directly include the required lib, rather than forward declaring anything - are you sure? The latest version of node'd declarations quite literally do not include IteratorResult.

@weswigham One of the submodules stored the old version of @types/node. Updated it as well and error's gone. Thanks for your help!

Whow?! That really hearts! :)
I had an issue with obsolated @types/nodes in the parent folder

Just upgrade @types/node in devDependencies of your Angular project:
npm i --save-dev @types/node
*** Do not change anything in node_modules ***
Hope this helps

@eamodio You need to update the version of @types/node you are using as this has already been addressed in that types package.

This issue can be closed, the StackOverflow question also suggests that it resolves this issue.

As mentioned, please refer to https://stackoverflow.com/questions/57331779/typescript-duplicate-identifier-iteratorresult if you are still experiencing problems.

I have used 17.0.3 version of type/node. The issue still persist. Can you specify which can be the best version to be used. Please help me out. Its urgent.
Version:
npm : 6.13.4
angular: 8
node: v10.19.0
storybook angular: 6.0.12


enable our Contact Delete Override page to be used in S1 & LEX

Critical Changes
Changes
Issues Closed
Fixes #2208

@jjbennett ready for review and merge.


Make cargo export CARGO_TARGET_DIR to build.rs scripts

Resolves issue #5457
https://github.com/rust-lang/cargo/issues/5457

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Eh2406 (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.

Thank you for getting this conversation started. Looks like CI is failing. This will need to be added to the docs.
The bigger question is how does this work with the direction we are hoping to take the structure of the target directory. @ehuss Thoughts?

yeah i got a build failure, sorry, will iterate

so i can try to describe my use-case but it's not unlike what people describe here: https://github.com/rust-lang/cargo/issues/5457
for my purpose, an alternate solution might be not to do this, and instead do:
println!("cargo:artifact={}/foo.so", out_dir);

and that would tell cargo that something that we produced and placed in out_dir should get copied to the target dir, whatever it may be

Thanks for the PR here @cbeck88, but the first thing that needs to be covered is whether the Cargo team thinks this should happen. Build scripts are intended to have a very scoped output (just in their OUT_DIR), and they're not currently really intended to be used as installation scripts for other sorts of files. In that sense this change was never intended for build scripts.
Now that's not to say that this can't happen, but this needs to be considered carefully. For example how would dependencies make use of this? Should this only be set for the "final package"? Is this really all that's necessary for installation? (etc, etc)

thanks @alexcrichton

I'm going to go ahead and close this because I don't think this feature is fleshed out enough yet. I think that this still wants discussion to figure out the best way forward and how Cargo can cater to the use cases mentioned here and in https://github.com/rust-lang/cargo/issues/5457, and I don't think setting this one environment variable is going to be the full fix.


[BUG] Users can rescale the root of the tablet object when this could break things

Known things this breaks is gizmo rendering, it scales incorrectly

Fixed in 1.6.3


refactor - Extract copy functionality to utils

SUMMARY
https://trello.com/c/hggzc6p5/17-dry-up-repeated-clipboard-logic
Extract copy functionality to utils

Codecov Report

Merging #11928 (3409110) into master (4666445) will decrease coverage by 3.65%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #11928      +/-   ##
==========================================
- Coverage   67.12%   63.47%   -3.66%
==========================================
  Files         915      462     -453
  Lines       44537    28496   -16041
  Branches     4235        0    -4235
==========================================
- Hits        29897    18088   -11809
+ Misses      14526    10408    -4118
+ Partials      114        0     -114

Flag
Coverage Δ

cypress
?

javascript
?

python
63.47% <ø> (-0.63%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

superset/views/database/views.py
62.30% <0.00%> (-25.14%)
:arrow_down:

superset/db_engine_specs/mysql.py
79.59% <0.00%> (-12.25%)
:arrow_down:

superset/db_engine_specs/sqlite.py
65.62% <0.00%> (-9.38%)
:arrow_down:

superset/db_engine_specs/presto.py
73.81% <0.00%> (-8.47%)
:arrow_down:

superset/databases/commands/create.py
83.67% <0.00%> (-8.17%)
:arrow_down:

superset/databases/commands/update.py
85.71% <0.00%> (-8.17%)
:arrow_down:

superset/db_engine_specs/base.py
80.73% <0.00%> (-6.73%)
:arrow_down:

superset/sql_validators/base.py
93.33% <0.00%> (-6.67%)
:arrow_down:

superset/views/database/forms.py
83.33% <0.00%> (-5.56%)
:arrow_down:

superset/views/core.py
70.96% <0.00%> (-3.83%)
:arrow_down:

... and 492 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4666445...2d80d5d. Read the comment docs.

Ugh... Github Actions seems stalled, but I'll merge this ASAP.


[v2] add Twitch provider

This is the configuration for Twitch. Tested by adding a custom object to the Providers list.
{
      id: 'twitch',
      name: 'Twitch',
      type: 'oauth',
      version: '2.0',
      scope: 'user:read:email',
      options: { grant_type: 'authorization_code' },
      accessTokenUrl: 'https://id.twitch.tv/oauth2/token',
      authorizationUrl:
        'https://id.twitch.tv/oauth2/authorize?response_type=code',
      profileUrl: 'https://api.twitch.tv/helix/users',
      profile: profile => {
        const data = profile.data[0];
        return {
          id: data.id,
          name: data.display_name,
          image: data.profile_image_url,
          email: data.email,
        };
      },
     ...options
    },

Thank you! This is really appreciated

Added Twitch to the example at http://next-auth-example.now.sh which is now on GitHub.
Thanks again, this works great!

Nice! I can add some other providers too if you want.

Oh yes please, that would be really neato! Thanks for all your help so far!
If you run into any you can't get working but you think they have the correct details, I'm really happy to get PRs for them too, if you can leave a comment in to say they might be not working yet.
I can try them with a different oAuth library and see if that is a quick fix; it's possible some providers won't work well with all oAuth libraries.
I need to add Facebook at some point, but I didn't add it at the start because it doesn't work with callbacks at localhost URLs (at least that used to be the case, not sure if it's still true). Other than that it was fine, it was just more awkward to test locally.


Test with Travis

It's likely that there is a good reason this hasn't already been implemented, but this was a simple change so I thought I'd submit a PR regardless.

Thanks!

My pleasure!

If you want to enable this you'll need a Travis CI account and the repository to be switched on under https://travis-ci.org/profile/jwiegley.

Done.

Thanks again!


matrix-authentication-service: init at 0.7.0

Description of changes
MAS (Matrix Authentication Service) is an OAuth 2.0 and OpenID Provider server for Matrix.
It has been created to support the migration of Matrix to an OpenID Connect (OIDC) based authentication layer as per MSC3861.
One can learn more about Matrix and OIDC at areweoidcyet.com.
https://github.com/matrix-org/matrix-authentication-service/releases/tag/v0.7.0
Vendoring the Cargo.lock is necessary because of a dependency they use: opa-wasm-0.1.0 (pinned to a git repo) .
Future work:
For this to be really useful, a NixOS module will be needed.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Actually I've packaged this before, see https://github.com/NickCao/flakes/blob/master/pkgs/matrix-authentication-service/default.nix for some ideas to steal from.

Thanks, I liked your version a lot and stole a lot (if not all :smile:).

Do you mean a simple version test? In case you think of something more complex, can you point me to an example?

Do you mean a simple version test? In case you think of something more complex, can you point me to an example?

Something like nixos/tests/matrix/synapse.nix, but with MAS instead of builtin authentication.

Was missing translations path.
I started something regarding module / test in this branch: https://github.com/teutat3s/nixpkgs/commit/287fbae6e5bbc5baed1fef45c9497327f067c1d3

@teutat3s are you planning to add the module to this PR or should we move forward with the package alone?

@adamcstephens I'm still working on the module and might be able to look into it some more in the coming week.
For me it would be fine to merge this now and add the module in a separate PR.


Problem with filesaver.js

Hello,
I would like to understand why in the src folder the filesaver.js contain these lines :
 typeof self !== "undefined" && self 	|| typeof window !== "undefined" && window 	|| this.content
Whereas in the dist folder the minified file has :
typeof self !== "undefined" && self || typeof window !== "undefined" && window || undefined.content
The thisis replaced by undefinedwhich causes errors when I try to access to my application.
Do you have any idea ?

The problem is solved?


[#expense] [Bring copilot to NewDot] Re-add the Try New Expensify button (when applicable to show it) within HybridApp for Copilot

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

E/A issue for https://github.com/Expensify/Expensify/issues/414571 . We removed this functionality before copilot was migrated over, and now it is! @war-in is working on PRs already.
View all open jobs on GitHub
Issue OwnerCurrent Issue Owner: @garrettmknight

Hi 👋 I'm working on PRs here (ND part, OD part)

assigned!

@war-in if they're ready, can you put the PRs into review? You can add a [HOLD] to the title so they won't be merged early

@war-in if they're ready, can you put the PRs into review? You can add a [HOLD] to the title so they won't be merged early

PRs are marked as ready for review :) Mentioned you in both 🫡

@Ollyws you were assigned to review the App PR, let us know if you can take a look soon, thanks!

Hi 👋 I updated both PRs with the newest main and I'm waiting for the final review

This can't be tested by External contributors, so I'll unassign you @Ollyws.
Also, @dangrous I can take over reviewing and testing of the PRs

Alright, next step is to wait for the App changes to hit prod then I'll bump the HybridApp submodule (like this) and test @war-in's HybridApp changes.
Back in a few days.

Thanks @Julesssss !

@war-in do you want to give a summary of that other bug with the tokens you were encountering here, so @Julesssss can weigh in? So for some reason disconnecting as a delegate calls CreateLogin which then fails here because it's sending chat-expensify-com as the partner name. I think we could probably just add that partner name to the conditional there to fix it, but I'm not sure if that would cause other side effects. I'm happy to keep working on that side of things, but would love your input!

So for some reason disconnecting as a delegate calls CreateLogin which then fails here because it's sending chat-expensify-com as the partner name.

Oh thanks for sharing, was that discussion on another issue or something? Adding chat-expensify-com as a partner seems reasonable to me, maybe we should just ask in slack to see if anyone see's a problem with it. But yeah it would be great if you can continue with that and I'll handle the HybridApp reviews and tests 👍

Oh thanks for sharing, was that discussion on another issue or something?

I DMed @dangrous to check if it's a known issue or not and forgot to write a summary here, sorry!

FYI, there's also the second PR (on the OD side) so let's not close the issue yet

Not overdue, working on existing PRs, and I'll hopefully be pushing up 1-2 PRs today to fix the token issue for Hybrid App

Multiple PRs ongoing.

Not overdue, the PRs that allow this to move forward are in review and then waiting on the one in review. The App PR is good to go with current backend, and now being tested with the changes. We'll be there soon!

Working on one minor fix in the backend PR and then can move forward.

nearly there!

App is deployed - the backend PR is not yet merged but I think we won't need it to move forward with testing this and getting it done.

both parts merged! So we're just waiting on https://github.com/Expensify/Mobile-Expensify/pull/13289 again

We're almost done here but are shooting for doing this as soon as 2025 rolls around since both @war-in and I are out through new years and we want to be around to deal with anything unexpected.


Add option to enable or disable encryption at rest for sns topic

Issue #2:
Description of changes:

Added a parameter for user's to provide the choice for encryption at rest
Added AWS::KMS::Key resource and attach it to AWS::SNS::Topic depending on the condition.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

thanks for contribution!


Backport fix for Ccache from 0.74 to main

Summary:
While doing the release of 0.74.0-RC.9, we encountered some failures while building because the committed project had some new flags that have been added by cocoapods and that required Ccache.
However, Ccache is not a hard requirement to run React Native and the build started failing on systems that does not have ccache installed.
That happened because we were missing the piece of code that removed Ccache from the project in case the tool is not installed in the system.
We already committed such commit in the stable branch of 0.74, with this commit. This change will port the same fix in main.
Changelog
[iOS][Fixed] - Make sure to remove ccache scripts when ccache is not installed
Differential Revision: D56140015

Thanks a lot for tackling this heads on.

the build started failing on systems that does not have ccache installed.

This is indeed unexpected, do you have a link for such a failure?
I would love to learn how that could happen with the changes introduced in https://github.com/facebook/react-native/pull/42051


Update the example app to give visual feedback for testing

Reason
The plugin needs to be tested in different environments with useful debug logs, while not connected to a debugger..
Description
Currently the tests with the example app are done connected to a debugger in xcode/android studio/chrome/safari.
It needs to write all the logs in the example app screen so that it can be copied and shared with the development team for proper debugging.
The example app UI should consist in a form and a text area.
In the form the tester can input login credentials when necessary and press buttons to login, logout, list connected accounts and get receipts.
The example app should log all steps that are performed, methods results and errors, including the data sent to the plugin and received from it.
Success Criteria

[ ] The UI is updated to include the form and text area
[ ] The buttons perform the selected actions
[ ] The logs are shown in the screen

Additional Information
In the future this example app logs can be included in the apps-capacitor-receipt with remote logging in Amplitude for anonymous usage tracking and Sentry for error logs.

Example app updated with some visual feedbacks for test in branch testing/update-the-example-app-to-give-visual-feedback-for-testing


created analytics component  in html and css module

hi @meerhamzadev  can you please verify it now?

Okay great.

@meerhamzadev it is showing that your repository got excluded from hacktoberfest


Clicking on STANDINGS could select by default the first Item on top row (e.g. Main Championship) actually it shows blank

Changed this to bug because this is actually expected behaviour


feat: Improve dice-rolling flow

#52  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @aMediocreDad and the rest of your teammates on  Graphite


FancyZones: Resizing non visible windows with hide attribute - Fix for issue microsoft#19440

Summary of the Pull Request
Resizing non visible windows with attribute hide to avoid re-appearing

PR Checklist

[X] Closes: #19440
[ ] Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
[ ] Tests: Added/updated and all pass
[ ] Localization: All end user facing strings can be localized
[ ] Dev docs: Added/updated
[ ] New binaries: Added on the required places

[ ] JSON for signing for new binaries
[ ] WXS for installer for new binaries and localization folder
[ ] YML for CI pipeline for new test projects
[ ] YML for signed pipeline

[ ] Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed
Tested locally, issue fixed

Would you be so kind to update the title to be a bit more descriptive? :)

Hi,
Now that you drew attention to it, yes, it is nicer in one line.
Will update the code.
Thanks,
Laszlo
From: @.>
Sent: 2022. november 9., szerda 12:35
To: @.>
Cc: Laszlo @.>; @.>
Subject: Re: [microsoft/PowerToys] FancyZones: Resizing non visible windows with hide attribute - Fix for issue microsoft#19440 (PR #21565)
@Jay-o-Way commented on this pull request.
why not like this?
—
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/PowerToys/pull/21565#pullrequestreview-1173867529, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ANVPUS2CNZGUTXSS4COHF4TWHOD65ANCNFSM6AAAAAARTJV5IE.
You are receiving this because you authored the thread.Message ID: @.***>

ready to merge?

Yes, merged.
Laszlo Nemeth
@.***
www.janeasystems.comhttp://www.janeasystems.com/
+36203210211
@.***
From: Clint @.>
Sent: 2022. november 16., szerda 8:08
To: @.>
Cc: Laszlo @.>; @.>
Subject: Re: [microsoft/PowerToys] FancyZones: Resizing non visible windows with hide attribute - Fix for issue microsoft#19440 (PR #21565)
ready to merge?
—
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/PowerToys/pull/21565#issuecomment-1316478898, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ANVPUS76MACRLIR6OLMDXXTWISB53ANCNFSM6AAAAAARTJV5IE.
You are receiving this because you authored the thread.Message ID: @.***>


Some minor fixes :)

Hi Todd,
some more minor updates; let me know what you think!
Rafael

sorry for the delay :)
maybe we can co-maintain, for now?


Write to the same memory in different always blocks

Version
Yosys 0.26+50 (git sha1 0f2d226ae, gcc 7.5.0-3ubuntu1~18.04 -fPIC -Os)
On which OS did this happen?
Linux
Reproduction Steps

download verilog files: https://github.com/liangkangnan/tinyriscv/blob/master/rtl/core/regs.v
download verilog files: https://github.com/liangkangnan/tinyriscv/blob/master/rtl/core/defines.v
read_verilog regs.v
proc
hierarchy
opt
clean
write_verilog

Expected Behavior
  reg [31:0] regs [31:0];
  always @(posedge clk) begin
    if (_02_[31])
      regs[_00_] <= _01_;
  end else if (_05_[31])
      regs[_03_] <= _04_;
  end

Actual Behavior
  reg [31:0] regs [31:0];
  always @(posedge clk) begin
    if (_02_[31])
      regs[_00_] <= _01_;
  end
  always @(posedge clk) begin
    if (_05_[31])
      regs[_03_] <= _04_;
  end

What do you need this for exactly? As I understand using separate processes for this is perfectly fine according to the verilog language spec.


Feature request: Transparent image output (with alpha channel) when saving image

From Amit Chourasia via the developers list: Hello, It would be great if VisIt could output transparent images with alpha channel. Please consider supporting transparent output in PNG format instead of adding support to all formats like tiff, etc. While the python difference workaround could be useful sometimes. It is not really possible to incur the cost of rendering twice just for the sake of generating a transparent image. This is especially true with raycasting or anything with larger dataset, which have expensive render times to begin with. Thanks-Amit
-----------------------REDMINE MIGRATION-----------------------
This ticket was migrated from Redmine. As such, not all
information was able to be captured in the transition. Below is
a complete record of the original redmine ticket.
Ticket number: 2339
Status: Pending
Project: VisIt
Tracker: Feature
Priority: Normal
Subject: Feature request: Transparent image output (with alpha channel) when saving image
Assigned to: -
Category: -
Target version: -
Author: Cyrus Harrison
Start: 07/14/2015
Due date:
% Done: 0%
Estimated time:
Created: 07/14/2015 10:00 pm
Updated: 08/05/2015 05:02 pm
Likelihood:
Severity:
Found in version: 2.12.3
Impact: 3 - Medium
Expected Use: 3 - Occasional
OS: All
Support Group: Any
Description:
From Amit Chourasia via the developers list: Hello, It would be great if VisIt could output transparent images with alpha channel. Please consider supporting transparent output in PNG format instead of adding support to all formats like tiff, etc. While the python difference workaround could be useful sometimes. It is not really possible to incur the cost of rendering twice just for the sake of generating a transparent image. This is especially true with raycasting or anything with larger dataset, which have expensive render times to begin with. Thanks-Amit
Comments:

So what is the status of the alpha channel inclusion to image output? I have obtained PNG outputs with proper alpha channels, but I have trouble in reproducing this reliably on VisIt 3.2.1. For example, far as I can tell, I have two wholly-opaque plot elements (I'm concerned about removing the background), with the same annotation and image save parameters, incl. pixel flags and render parameters, with one producing output with an alpha channel, and the other not. Likewise, a batch job of the script that usually produces non-transparent output sometimes a) fails with only a transparent image (for whatever reason, possibly some corrupt file, but goes to show that alpha channel output is on) b) produces a correct alpha channel very rarely.
I'm really scratching my head with this, since the feature seems to work very capriciously - a session setup can quit producing alpha channel output for no apparent reason. Changing and resetting pixel flags also, somehow, bungled the RGB output as well (for color-mapped pseudocolor plots, I get what I assume is luminance value?). I did find the PIL script workaround, something like that of course very useful here (since in this case I only do background removal with alpha), but this behaviour is quite frustrating :(. Any ideas what could be the culprit?

@alhom I will put on tomorrow's project meeting agenda to see if/when we can prioritize this.

@alhom I am closing this issue.
We support alpha channel output now.
I am using your comment here to start a new issue. I will include there some comments about possible causes of your experiences.


Rocket structure

I have completed the following tasks.

created rockets component and fetch rocket data for rendering.
A screenshot of the design is shown below.

Hi @worashf :wave:
Great job so far!
Highlights :rocket:
:heavy_check_mark: Created a route and used page navigation.
:heavy_check_mark: Created a directory to organize redux files.
Status: APPROVED 🟢 🟢 🟢
Everything is looking good, there is no more left to say than...
Let's merge it! 🥳 🥳
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread and tag me @Gopxfs if something is not 100% clear.


Release KTX 1.9.10-b5

[ ] GitHub release.
[ ] Maven Central upload.

A new module - ktx-preferences (#255) - and quite a few handy utilities were added since the latest stable release. Notably, useful app and graphics utilities from Cyberpunk were finally integrated into KTX (#183).

1.9.10-b5 will be released when changes related to #182 are merged.

#182 is merged, but it seems that Travis CI is out of sync with GitHub and commits are not correctly pointing to associated builds. I'd like to avoid pushing to master before it is resolved.


Enhance download bitstream function

On current official demo site "https://demo7.dspace.org/" download bitstream function is bit different than on site generated by standard code.
Official site downloads bitstream in the same page where request originated from.
On site generated by standard dspace-angular code (latest for 11.Okt 2021) download triggers the same href, but it ends up loading a new page showing "Now downloading 'filename'...".
The solution on demo site is more user friendly, please add that approach to standard code.
Standard code does not perform the UI internal redirect, instead   bitstream-page-routing.module.ts does the /download route redirection to BitstreamDownloadPageComponent (my best understanding of it..)
P.S.
Demo site leverages these 2 requests :

@MarisArins : The demo7.dspace.org site is running standard code. It's running what is on the main branch at https://github.com/DSpace/dspace-angular/ with no customizations to the code.
When I run the Angular UI locally (starting it using yarn start), I see the same internal redirect that occurs on the demo site.  It's possible that internal redirect requires running in production mode (with server-side rendering enabled).
Closing as "won't fix" as this doesn't appear to be a reproducible bug.  My best guess is you either have a configuration issue or you are not using server-side rendering.


Goex Authentication Error

I tried to authorize my Gmail account using the provided OAuth2 link.
I was expecting the authorization process to be completed successfully and grant the necessary permissions.
But I encountered an SSL certificate verification error, specifically: certificate verify failed: certificate has expired.
This error occurs every time I attempt to authorize the account using the same link.
Error message: HTTPSConnectionPool(host='goex-services.gorilla-llm.com', port=443): Max retries exceeded with url: /authorize (Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: certificate has expired (_ssl.c:1007)'))

Hey @ishamim do you mind trying again? From what I can tell, the certificate has been renewed!

Yes, now I don't see a SSL certification error. It shows this:

Is there a way I can resolve this issue?


SQL Editor - add script pattern

Hi.
In my Database Navigator I had created folders:
Local -> Program 1
Production -> Program 1
In script patterns I would like to add these folders to save SQL Scripts in format:
Folder -> Program -> Script.sql
Is any chance to add folder name variable?

Do you mean put scripts for different connections in separate folders?
Or create scripts folders for connections which are in connection folders?

The second option.
I would like to create the same path like in Database Navigator:

Ok. This can be solved with one extra preference option. And that's easy to do.

Thank you.


Update to docker-compose

Fixes so latest version of minio will run properly. Putting console at 9001 with internal map to 9443

Closing as no response.


build: bump dependencies

This PR updates the outdated dependencies listed in Cargo.toml

How would you feel about enabling Dependabot in this repo?

I would prefer getting FreeBSD tested (or at least compile-checked) first. This repo has a lot of platform specific code.

Superseded by #4.


Automatic Seeding option

You forgot to document the first option on the Select Initial Data Synchronization page: "Automatic Seeding"

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3d4a2bb4-93b7-3ef7-ccdb-b0312208f062
Version Independent ID: 1288b338-f71d-19cd-5415-ddef24d65151
Content: Add a database to an availability group with the 'Availability Group Wizard' - SQL Server Always On
Content Source: docs/database-engine/availability-groups/windows/availability-group-add-database-to-group-wizard.md
Product: sql
Technology: high-availability
GitHub Login: @MashaMSFT
Microsoft Alias: mathoma

@MashaMSFT Hi Masha, Can you please process this Issue 2265, about Availability Groups.

Hi @andyhush-athena ,
Thank you for contacting Microsoft and providing your feedback to our documentation! We'll need some time to look into this further. Depending on the complexity, the turnaround time for this may vary anywhere from a few business days to a few business weeks. We'll reply via comment should we need anything further in the meantime, and please feel free to do the same.
Thanks again for your submission, and hope you have a wonderful rest of your day!

Hi @andyhush-athena , thanks again for bringing this to our attention! I have added a section discussing automatic seeding. Please let me know if there is anything else we can do for you? If not, I will proceed with closing out this Git Issue in a few business days.
Thanks!

Looks great, thanks!


Invalid blob metadata gives confusing error

Describe the bug
When uploading a new blob with invalid metadata. In our case a trailing space you get the following error:

Azure.RequestFailedException: Server failed to authenticate the request. Make sure the value of Authorization header is formed correctly including the signature.

This is very confusing because there is nothing wrong with the authorization header.
Expected behavior
A more relevant exception, eg InvalidArgumentException with a message saying the metadata isn't valid.
To Reproduce
Upload a blob with invalid metadata (trailing spaces or special chars) and then the following error is thrown:
Azure.RequestFailedException: Server failed to authenticate the request. Make sure the value of Authorization header is formed correctly including the signature.
RequestId:27687209-401e-00d4-1d3c-b8894c000000
Time:2020-11-11T15:07:22.2871106Z
Status: 403 (Server failed to authenticate the request. Make sure the value of Authorization header is formed correctly including the signature.)

Environment:

Library package used: Azure.Storage.Blobs 12.6.0
Hosting platform: Azure development storage
IDE and version : Visual Studio 16.8

Thank you for your feedback.  Tagging and routing to the team best able to assist.

I was able to reproduce your issue. Looks like special characters and trailing spaces could corrupt the http headers in some way due to the fact that metadata is a http header value. Which is why we get an unhelpful error such as AuthenticationError.
Let me check if there are restrictions on the metadata, since special characters and spaces could mess with the format of all the other headers.

We should be throwing an invalid metadata error, instead of allowing the user to send invalid metadata here.

Any change we can get a definition for "special characters"?
I'm seeing the same issue when a blob has a metadata entry that's just a comma (",").
AFAIK a comma is not strictly a special character per the http spec and would only be a special character if the parser implementation on the other end is treating it as such.

Maybe the azure sdk can provide a base64 encoding and decoding of the metadata api extensions to prevent issues with invalid chars?

Any change we can get a definition for "special characters"?

The metadata keys must ahead to C# identifier naming rules - https://docs.microsoft.com/en-us/rest/api/storageservices/naming-and-referencing-containers--blobs--and-metadata#metadata-names.
I believe the metadata values must be valid HTTP header characters.

I'm seeing the same issue when a blob has a metadata entry that's just a comma (",").

I don't think "," is a valid header value in the HTTP spec - https://tools.ietf.org/html/rfc7230#section-7.

In contrast, the following values would be invalid, since at least
one non-empty element is required by the example-list production:

 ""
 ","
 ",   ,"

I'm not sure if we should provide extension method to base64 encode/decode metadata values, since we would actually be changing the data that is stored in the service, and the data can be accessed outside of the SDK.  @tg-msft.

I know that is why I say extension methods so people can optionally use those methods.
blob.SetMetaData64(IDictionary<string,string> metadata);
var metadata = blob.GetMetadata64();

Because I read that that is also the suggestion for setting metadata with invalid chars

Just ran into this myself. Azure support lead me to believe it was because I was storing some email data. but after a lot of digging, I found out it was a trailing space on the metadata. the error is not helpful and if there was a check for leading and trailing spaces in the library so we could get a more useful error that would of saved me a lot of time.

Hi @njannink, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.


Error on startup of Sponge API 5 1.10.2

Error on startup.  Fails to register as an Economy plugin for JobsLite.
http://pastebin.com/FqZXcUdU

Can you post your config file?

You beat me to this.  Was about to close it.  Can't use $ like symbol=$

Yes, also, EconomyLite has not been updated for Sponge API 5. Here is a development build: http://downloads.flibio.net/EconomyLite-5.0.0-v2.2.3.jar.


@RequestMapping "path" is not considered in Feign contract even though it's an alias for "value"

The following client definition ends up ignoring the "path" argumet in RequestMapping, therefore causing a "java.lang.IllegalStateException: Body parameters cannot be used with form parameters.".
To correct this all you have to do is to change "path" to "value", but since those are aliases the implementation should example both.
    @FeignClient(url = "http://localhost:8181")
    interface PlatformClient {
        @RequestMapping(path = "/rest/some/{id}",
                method = RequestMethod.POST,
                produces = MediaType.APPLICATION_JSON_VALUE)
        void execute(@PathVariable(value = "id") String id, SomeObject data);
    }

Good catch.

The issue is in SpringMvcContract line 90 of version 1.0.4, that only the "value" attribute of RequestMapping is examined.

We should use AnnotatedElementUtils to automatically resolve the aliases.

Request body parameters should be placed in front. try
 void execute( SomeObject data,@PathVariable(value = "id") String id);

It works! @zdRan


Carthage support

Hi,
It's will be great to make your component Carthage compatible
Take a look at these articles:

Ruthlessly Simple Dependency Management with Carthage
Carthage Tutorial: Getting Started
Making Carthage-compatible Frameworks with Swift
[Creating Cross-Platform Swift Frameworks for iOS, watchOS, and tvOS via Carthage and CocoaPods] (http://basememara.com/creating-cross-platform-swift-frameworks-ios-watchos-tvos-via-carthage-cocoapods/)

On your README.md add   on top and add section for the installation with Carthage.

Done 👍
ISTimeline v0.0.4


Error in supervisord.conf of jenkins exemplary docker file

While using the exemplary Dockerfile for Jenkins, I came across something that looks like an error in supervisord.conf.
The jenkins process is configured with username=jenkins, but I think it should be user=jenkins. This could save the next person some time.
According to supervisord.conf documentation:
username belongs to configuration of [unix_http_server], which is not what we're doing here.
user on the other hand:
Instruct supervisord to use this UNIX user account as the account which runs the program. The user can only be switched if supervisord is run as the root user. If supervisord can’t switch to the specified user, the program will not be started.

Thanks @sebastian-peter for catching this.
This means that supervisor.conf must have ignored username and therefore run Jenkins as root inside the Sysbox container (which is fine since it's root in the user-namespace of the container only, not on the underlying host machine). Nonetheless it's better to fix it to user=jenkins. I'll open a PR soon. Thanks!

I'm using a slightly different Dockerfile, so it's hard to be 100% certain. One more thing that is missing (once Jenkins is not ran by root anymore) is providing the jenkins user with the rights to use docker. Thus I added a line usermod -aG docker jenkins to the Dockerfile.

Fix PR: https://github.com/nestybox/dockerfiles/pull/40

PR merged, closing.


TFKUBE-360: Fixes for issues identified during Confluence blitz

Various fixes for issues that were identified during the Confluence blitz.

Fix synchrony URL for deployments that do not use a domain.

It would be good to add an end to end test, that hits the synchrony ingress and verify the HTTP status code (200) and potentially some content from the reposponse.

Good finds!

It would be good to add an end to end test, that hits the synchrony ingress and verify the HTTP status code (200) and potentially some content from the reposponse.

💯  - Done!


Module name

When I try to install bafi with go install github.com/mmalcek/bafi@latest there is an error:
go: downloading github.com/mmalcek/bafi v1.0.13
go install: github.com/mmalcek/bafi@latest: <EMAIL_ADDRESS>parsing go.mod:
        module declares its path as: bafi
                but was required as: github.com/mmalcek/bafi

Probably you could simply rename bafi to github.com/mmalcek/bafi in go.mod ?

Hi, you are right - i've just fixed it in v.1.0.14 (no other changes). It should work now


show current user profile info

user avatar
user name
user city and country
user interests list
user memberships list

click the interest topic to search the topic


Negating config values when using config()

I'm trying to use a margin value from Tailwind's config using config('margin.3') and need to prefix that with a minus to negate the value. I tried:

usingconfig('negativeMargin.3'): does not help as the value itself isn't negative
- config('margin.3) / -config('margin.3): config() isn't interpreted at all
config(-'margin.3)): result is undefined

The only solution I found working is: calc (-1 * config('margin.3')). Obviously that is an unnecessary calculation I'd like to avoid. Any other ideas?

Good catch, hadn't thought of this. I'm not sure what the best fix is but it will definitely involve a change to Tailwind itself. Guessing for your situation you can't just use @apply .-m-3; or similar?

No unfortunately not, I'm using it in a box-shadow context (where it also makes no sense to put the shadow):
    // Tailwind variables should be used instead of .7rem, but it's not possible
    // to negate these, see https://github.com/tailwindcss/discuss/issues/126
    box-shadow: .7rem 0 0 config('colors.blue'), -.7rem 0 0 config('colors.blue');

Trying to achieve this for an hour now and nothing works, and it's basically how postcss works I guess?
I tried every way possible, cheating up functions, variables etc and it's just impossible to convert the config function result into negative value. What I tried:
right: -config('sidebar.width');

right: -#{config('sidebar.width')};

$tmp: config('sidebar.width');
right: -$tmp;
right: -#{$tmp};

and a lot more, and it just compiles into -config("sidebar.width") css value.
Adding
'-config': (path, defaultValue) => {
  return '-' + _lodash2.default.get(config(), _lodash2.default.trim(path, `'"`), defaultValue);
}

to evaluateTailwindFunctions.js solves it :\

Another work around for now is to just add extra keys to your tailwind.js, for example to create a negative version of width.6:
module.exports = {
  // ...
  width: {
    // ...
    'negative-6': '-1.5rem',
    // You can add as many as you need here
  },
  // ...
}

And then use them like before:
config('width.negative-6');


Feature: React Hooks?

I really love the Context API, so I could have many control on how component could be customised and placed.
I am trying to replace the components like ButtonFirst, ButtonBack, ... with Material-UI.
I know we could customise the look and feel using the css.
But sometimes we may want to integrate with framework that using jss, or even replace the entire component with some existing component in other framework.
Here is how I do it currently.
import { ButtonFirst } from 'pure-react-carousel';
import Button from '@material-ui/core/Button';

const CustomButtonFirst = React.forwardRef((props, ref) => <Button component={ButtonFirst} ref={ref} {...props} />);

// This line is needed because the "disabled" is internal state of "ButtonFirst".
export default withStore(CustomButtonFirst, state => ({ disabled: state.currentSlide === 0 }));

You could see the "disabled" logic have to be injected via "withStore". It means that I am assumed to know how the "disabled" is derived inside ButtonFirst component.
It would be nice if we could do something like this instead...
import { useButtonFirst } from 'pure-react-carousel';
import Button from '@material-ui/core/Button';

const CustomButtonFirst = React.forwardRef((props, ref) => {
   const buttonProps = useButtonFirst();
   return <Button ref={ref} {...buttonProps} {...props} />);
});
export default CustomButtonFirst;

Then I could have full control how ButtonFirst looks like without knowing any logic inside ButtonFirst component and no matter what styling solution I using as well.
Similar Hooks could be done as well like useButtonNext(), useButtonPlay(), useDot(slideIndex), etc.
Thanks.

I am not sure I understand the issue - can you provide more detail?
Do you want to be able to pass additional props to button that are not currently supported by the button? Can you show me an example or a PR that provides additional details on what you are trying to solve?

Now the ButtonFirst, ButtonBack, ButtonNext and ButtonLast are actual components that with the  tag. I would like to integrate those button to Material-UI (i.e change the button to IconButton). IconButton is a React Component which underlying is a button component, so it could accept all the props that button could receive.
The issue here is I am not able to replace the ButtonFirst/ButtonBack/ButtonNext/ButtonLast to Material-UI's IconButton as it is not "a simple css override". I have to implement all the button logic myself with "withStore" hoc helper. Although these buttons are simple to implement, what I suggest here is to provide hooks that allow us to grab the corresponding props that the ButtonFirst/ButtonBack/ButtonNext/ButtonLast/etc using. (i.e separate the props and state to React Hook and expose them).

@raymondsze I think the best way to propose this is via a PR that shows what you are asking. It sounds like you are asking to replace the carousel buttons, with Material UI buttons.
If you wanted to get a draft PR that developers could look at and comment on that would be great. Once comments have been discussed on it, the draft could be finalized and submitted as a mergeable PR.


Loading only the newsletter section

While visiting https://satriaana.github.io/Satriaana-Web-Site/#/
It's loading only the newsletter section.

Created PR for it. Please review.
#100

Hi @DreamsOfImran,
I have reviewed your pull request. Great work!
Thank you so much for your generous contributions to the GitHub issues regarding the website of Satriaana. We highly appreciate all the work you’ve done. Your efforts in developing our website are very commendable.
It’s with great pleasure that we’d like to inform you that we've decided to give you the chance of joining us as volunteers, after seeing your enthusiasm for open-source. So, if you’re interested, simply fill out the form through the link we’ve attached forthwith.
Note: We’re starting our volunteer onboard process in three weeks time from now on and we’re sending this form only to you as you have contributed to our website. Hence we’ll be closing the link of the form right after you’ve submitted the form. So, we would like to kindly request you to send us a message in reply after you’ve filled it.
Volunteer Form: https://satriaana.typeform.com/to/XYGqfnkI
Hope we can work together again very soon!

@nimeshkavinda Thank you and I've already filled this form.


Remove unused vscode/src/vs/css.d.ts

This PR "vscode/src/vs/css.d.ts" file was removed from the project because it was not used.
File is empty last four years.

This file is still needed for generating the standalone editor.


[ Feat ] Arcjet Security Implementation

This PR implements Arcjet Security into Remix SaaS via remix-init.
Remix SaaS should be initialized with npx create-remix-saas@latest, a command that will take care of a few things, one of those allowing the user to opt in for Arcjet Security, replacing the required files to properly implement and initialize Arcjet into Remix SaaS.
Feel free to provide new documentation or anything else that could add value to the whole feature/implementation @davidmytton.
The following video showcases how the implementation would look for the end user.
https://github.com/user-attachments/assets/18e95c68-5aa0-4396-b980-21dc68edbe45

With that said, I will also recover the contact of a few people who decided to sponsor Remix SaaS before. Sadly, my paperwork wasn't in place (personal documentation), and some of those opportunities were simply skipped by me.
In the same way, Fly.io will publish a blog post sooner rather than later, as far as I know, showcasing Remix SaaS as part of some Fly.io apps.
Let me know anything else you may want to talk about, and feel free to provide new documentation, links for the SVG, or anything else.

Looks good. I've suggested some changes to the wording.
The docs from https://github.com/dev-xo/remix-saas/pull/362/files#diff-2abc6729452120f62d2f8d7dceabdaac18819d3346b66a3acc89c1ef894922ff can be moved over as well - it only needs minor changes to reflect that this needs to be enabled and how to do it manually.
You can use these SVG images:

  <picture>
    <source media="(prefers-color-scheme: dark)" srcset="https://arcjet.com/logo/arcjet-dark-lockup-voyage-horizontal.svg">

  </picture>

All right, will finish this tomorrow. We got the original docs, added a few images of Arcjet on the main docs, and simply moved what was on the original PR here, with the addition of the updated remix-init.
I want to test this on a private repository (initializing the template and checking that everything is in place), and with that, we may be able to merge into main.
Also, I want to create some docs that could showcase a manual initialization of Arcjet, in case some folks simply want to opt in later on, either by noticing they can do so based on the docs provided or simply because they discovered Arcjet.

Again, this looks good to me, especially considering that Remix SaaS has been created to be a community project and one that I know some folks appreciate, and maintaining that is a way to pay back some of the support they provided.
Will also reach back to some folks who wanted to support the project before, in case they are still up for it, and that will simply do it for now.
There are plans to move Remix SaaS to Cloudflare, React-Router 7, and simply maintain and improve the project over time, allowing it to be discovered by some new folks, which is great, and if that also helps Arcjet in some way, even better.
With that said, will let you know to give the initialization a test, and with that done, the whole feature would be ready to be pushed.

How can I test the init script? I tried node index.js from within remix.init, but it throws an error due to the commonjs module syntax.

Thanks for the updates on the docs (redirect to the arcjet.com ref).
About testing it, not sure if you have tried it on this repo; currently, there is no available way to test it here, and that's why the remix-init-arcjet repository was created.
Remix runs remix-init after template initialization, allowing us to customize it, as we have done in this case. I'm unsure of how Remix runs the remix-init/index.js script, although probably should be similar to what we do in remix-init-arcjet.
In order to properly test it, I will set up another repo with the updated changes on this PR, and by simply running npx create-remix-saas-dev@latest, we should be able to successfully initialize the repository, opting in for Arcjet.
Will have that done by tomorrow, allowing you to give it a test and also share some feedback, in order to merge into main after ensuring everything works as expected.

This is a bit picky, @davidmytton, but can the ref code be simply arcjet.com/?ref=remix-saas? Again, just a little preference, but I think the URL could look a bit cleaner, and that could have a little impact in the long run.
If so, feel free to simply share the new ref here, and I will update those wherever required in the docs.

All right, this should be working.

You can give the dev repository a try with: npx create-remix-saas-dev@latest.

I want to polish the Arcjet implementation a bit, update the comments provided, and simply check the implementation to learn more about it. Overall, the basics and the opt-in should already be working as expected.
Let me know how it goes.
https://github.com/user-attachments/assets/dc0ef756-8279-47a2-8eac-ac4c1ce137db

Looks good - all works on my side.
Given that users are opting in to Arcjet, should we change the code to throw if the ARCJET_KEY environment variable isn't set like it does with Stripe?

Yes, the moment the users have opted for ARCJET, the key may be required, good point. Gonna clean up the comments a bit and check on the base implementation (the files we are replacing), and with that done, we may be ready to merge into main.
It would be great to also have a step-by-step guide in the docs on how to implement ARCJET for those who opted to do it later, as that could be really helpful.

All right, this should be done @davidmytton.
Feel free to give it a last install to the dev repository, although the implementation should be the same, just a bit polished.

Also, as mentioned before, if you want to provide a new ref remix-saas in order to have a cleaner URL, I can update that across the docs.

The integration ended up pretty good, the default to opt-in Arcjet is true, so I would say that most, if not all, the installs may include Arcjet, which is good.
Let me know if you want to test anything else; otherwise, this may be ready to be merged into the main branch.

Thanks, all looks good. Let's keep the current URL for now as it tracks clicks better.
Once this is merged, I'll open a new PR with docs improvements for you to review.

All right, feel free to reach back with that docs @davidmytton, and we can even create a 10-arcjet-security.md specific one, if you prefer it, with the configuration, the step-by-step guide, or anything else related to Arcjet.
Will wait for the Sponsor then, and we can merge into main, as everything should be ready.

Thanks to the sponsor @davidmytton! I think the implementation ended up well for both, especially considering that most, if not all, users will opt for Arcjet, as either by pressing enter or Y, the user is in.
Merging this into main. Please feel free to reach out with the updated docs or anything else that may fit the implementation.

Remix Discord Announcement: Discord Post


Double-click to select word, followed by copy/paste does not work as expected

VSCode Version: 1.50.1

OS Version: Darwin x64 19.6.0

Full information from 'about vscode'
Version: 1.50.1
Commit: d2e414d9e4239a252d1ab117bd7067f125afd80a
Date: 2020-10-13T14:53:05.704Z
Electron: 9.2.1
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: <IP_ADDRESS>-electron.0
OS: Darwin x64 19.6.0

Steps to Reproduce:

In an editor window double click a word to 'select'. The word on which the cursor was placed get highlighted
press command-c to copy the 'word' to clipboard:

Command-V to a new location. This is what we get:

Actual:
As can be seen above the whole like where the cursor was got copied instead of just the 'selected' word.
Expected:
Only the selected word should have gotten pasted.

Does this issue occur when all extensions are disabled?: Yes

This might be a regression of https://github.com/microsoft/vscode/issues/83150 fix. Apologies but I was not able to update that issue as it seems it has been locked out.

From the screenshot in 2. , I can see that the word azdataApi is not selected, it is highlighted probably by the word highlighter feature which highlights usages of the same symbol in the file.
When there is no selection, ctrl+c will copy and place the entire line in the clipboard. This feature can be turned off via "editor.emptySelectionClipboard": false,


version 8.7 of highlight.js

Addresses https://github.com/elm-lang/package.elm-lang.org/issues/56.

Awesome, thank you!


warnings while doing VCF calls with pandora map

I finally got around to try the --genotype argument in pandora map and while I got the expected two VCF files as output, I also had a lot of warnings in the console. They were always these two for different (probably all, I didn't count) genes:
[2020-01-08 09:32:57.905378] [0x00007fd741ceff80] [warning] Input vcf_ref path was too short to be the ref for PRG GC00002025
[2020-01-08 09:32:57.905389] [0x00007fd741ceff80] [warning] Could not find reference sequence for GC00002025 in the PRG so using the consensus path
They occur after this line:
Wed Jan  8 09:32:57 2020 Find PRG paths and write to files:
This did not happen when I used pandora map without the --genotype option. What does it mean?

These warnings can safely be ignored. They are being triggered by the default user behaviour which is not to provide a VCF reference. The first of these is already fixed in a pull request I'm waiting to merge in. We will update the code to stop the second being triggered also (or at least call it something other than warning)

Thank you!


How to open the app

How to open it

"First, compile the make file. Then it will give you a .deb file. Use tools like ssh and scp to transfer the file to your phone and install it. You can also install it using the Troll Store app."


Do you want to allow user-defined specializations of indirect or polymorphic?

There is a blanket wording in [namespace.std] that permits users to declare explicit or partial specialization of any standard library class template provided the declaration depends on at least one program-defined type and the specialization meets the requirements of the original template.
Is this something that you want to allow for the indirect and polymorphic class templates?
If not, we should add some wording that prohibits such specializations.

This seems a reasonable way to allow users to define comparisons and hash for polymorphic. What are the downsides?

The only concern I can think of here would be if you want to later add support for implicit conversion from e.g. polymorphic<derived> to polymorphic<base>. In this case, one of the classes would presumably need to reach into the implementation of the other class to transfer ownership and this would break if one of them was specialized by the user in a way that was incompatible with the original implementation.
Any operation involving another specialization of the class template would be restricted to only using the public API of that other specialization.

Thanks, I'll have a ponder.

I think we prohibit specializations - we can relax this later; the reverse is not true.

I'll add wording and update the changes table.


'Getting Started' user documentation + sample Makefile

The current Low* tutorial needs some work to help get a new developer started on their first project.
The first chapter in Rust's book might serve as inspiration, as it describes both the basic "Hello, World!" with rustc and "Hello, Cargo!" with the cargo build system.
Specifically, there is an outstanding TODO in the Introduction:

Section ?? provides a complete sample Makefile that performs parallel verification and extraction, along with parallel compilation of the resulting C code, using F*’s automated dependency analysis and gcc -MM for correct, incremental builds.

I'm happy to help test the documentation and provide input where I can. Thanks!

Sorry it took me so long to get to this, but there's a brand new documentation with a sample project, under CI, and heavily commented things including build, how to structure your project, etc.. If you have time to give it a go, it'd be most grateful for pull requests and amendments to the documentation.
Thanks,
Jonathan


SpoolTransport's event system creates memory leaks

Q
A

Bug report?
yes

Feature request?
no

RFC?
no

How used?
Symfony

Swiftmailer version
6.2.3

PHP version
7.4

Observed behaviour

I am using enqueue bundle with long-living consumer along with monolog bundle (swift_mailer handler). I detected a memory leak caused by commented lines of the send() method:
public function send(Swift_Mime_SimpleMessage $message, &$failedRecipients = null)
    {
//        if ($evt = $this->eventDispatcher->createSendEvent($this, $message)) {
//            $this->eventDispatcher->dispatchEvent($evt, 'beforeSendPerformed');
//            if ($evt->bubbleCancelled()) {
//                return 0;
//            }
//        }

        $success = $this->spool->queueMessage($message);

//        if ($evt) {
//            $evt->setResult($success ? Swift_Events_SendEvent::RESULT_SPOOLED : Swift_Events_SendEvent::RESULT_FAILED);
//            $this->eventDispatcher->dispatchEvent($evt, 'sendPerformed');
//        }

        return 1;
    }

The problem isn’t in memory consumption only, but in slowing down every next iteration. Basically what happens is garbage collector tries to remove object references each time “possible roots” buffer has more than 10k references. Since we add more and more objects each consumer’s iteration, php runs GC all the time and removes nothing. The more references we have in the buffer, the longer it takes to go through it (multiple times per request).
Expected behaviour

Removing unused refernces
Example

I've noticed that because I am using sort of RPC and send hundreds of messages into a queue awaiting response. Just send as many messages as you can generating any logs, and you will notice every http request is processed slower and slower.
# config/packages/swiftmailer.yaml
swiftmailer:
    url: ...
    spool:
        type: file
        path: ...

# config/packages/monolog.yaml
monolog:
    handlers:
        swift:
            type: swift_mailer
            from_email: ...
            to_email: ...
            subject: ...
            level: ...
            formatter: monolog.formatter.html
            content_type: text/html

P.S.: It seems like this issue has been here for a long time: https://stackoverflow.com/questions/21617163/memory-leak-with-symfony2-swiftmailer

The leakage is in MessageLogger, which collects messages but never clears them.
public function beforeSendPerformed(Swift_Events_SendEvent $evt)
{
    $this->messages[] = clone $evt->getMessage();
}

As for the Swiftmailer Bundle (Symfony's), you can set "logging" to "false" to disable this plugin for long-living apps/commands.


Monthly returns do not work if local machine locale is not in English

The function monthly_returns in stats.py is hardcoded to read month names in English. My personal laptop locale is in Brazil and thus the months names differ, and the monthly returns are then all zero as a result.

I had the same problem. What's weird was that some months showed the correct values, other zero.
You can set the locale as a workaround to fix the issue.
import locale locale.setlocale(locale.LC_ALL, 'en_US.utf-8')


I have questions about the CLI ?

I've been using the Shopify cli and I haven't seen the "routes" where I can do the requests, be they Post , Get , put etc.
I've spent a lot of time analyzing the code and I can't create a get or a post, is there a tutorial that can help me with this

@ClairCc I stopped using the shopify-cli generated app. Just published a working example using nextjs. If you know nextjs you can do whatever you want. https://github.com/redochka/nextjs-shopify-app-no-custom-server
Give it a try


image not creating

when i try to build it is showing "error launching source instance : the request launching is not supported

Hi Sasi,
Can you please share packer file


Simplify the PDFDocument constructor

Originally the code in the src/-folder was shared between the main/worker-threads, and back then it probably made sense that the PDFDocument constructor accepted different arguments.
However, for many years we've not been passing anything except Streams to PDFDocument and we should thus be able to slightly simplify that code. Note that for e.g. unit-tests of this code, using either a NullStream or a StringStream works just fine.

Makes sense; thanks!


feat(msm): add hinted w-windowed glv msm

This PR includes an optimization over the current implementation of hinted msm. It uses glv msm.
Existing implementation has the following benchmarks.

msm for single input is split to around 80 bit commitments
cost of script size and as such bit-comms scales linearly i.e. 80*n for n public inputs.

This improvement includes:

msm for single input is split to around 16 bit comms.
cost of script size (or bitcomms) doesn't scale linearly. e.g. 20 bitcomms for 2 public inputs

Tests have been added.

What's not included here is direct integration with existing chunker.
I believe chunk_msm.rs has not made use of direct msm utils present in bn254/curves -- as such this PR will not affect it.
If these changes are to be integrated, I'd recommend going through it over a separate issue (PR).  This way ongoing work on each line doesn't depend on one another.

requesting @Hakkush-07 @wz14 for review.

Short intro to glv:
Given a scalar, glv gives a way to break the scalar into two parts, each of bit length half of the original.
k = k0 + lambda * k1 where lambda is constant.
k < Fr::N_BITS,
k0, k1 < Fr::N_BITS/2
In bitcoin script,

we pass k0 and k1 alongside k.
we check that k0 + k1. lambda == k
we use k0, k1 with msm
if k had G1Affine base P, k0 has base P and k1 has base phi(P) where phi(P) is point endomorphism of P
P and phi(P) are both baked into circuit as lookup tables.
Thus we have twice the number of scalars, half the bit size of these scalars, and their bases are hardcoded in circuit. We run w-windowed double and add algorithm off-the-box.

https://ethresear.ch/t/fake-glv-you-dont-need-an-efficient-endomorphism-to-implement-glv-like-scalar-multiplication-in-snark-circuits/20394

Thank you for mentioning me. Looks good to me.
I am not sure if we could have two versions of algorithm. There are different purposes for a large size script and plenty of smaller chunks. Some scripts work well in the large script but can't be used in chunks. For example, https://github.com/BitVM/BitVM/blob/cb5fe1807d963d60ca19fb33f0fcfdb61cabf2c9/src/bn254/msm.rs#L287-L299. Here we are not supposed to mix hints and input with scripts in the context of chunks because we haven't known the hint and input when pre-signing.
Certainly, large script also has its functionality. By checking the large script, we can identify the integrity of zkp verifier more easily.
So, I propose that we can keep the algorithm of two versions aligned through PRs. How do you think of this point? @lucidLuckylee @manishbista28 @Hakkush-07

Thanks for the review and reply @wz14.
Discussed internally but adding some context if it can be useful to others.
Large script (unchunked-version of groth16 verifier) and chunked version should reuse as much code as possible. Snippet of the code above is from function "hinted_msm_with_constant_bases_affine" which is called only by unchunked version and serves to demonstrate how the chunks returned by core function:  G1Affine::hinted_scalar_mul_by_constant_g1() can be integrated. As such the hints were hard-coded in the above snippet.

Here we are not supposed to mix hints and input with scripts in the context of chunks because we haven't known the hint and input when pre-signing.

I agree that the hints will be passed by chunks as witnesses.

So, I propose that we can keep the algorithm of two versions aligned through PRs

I agree that having this version integrated to chunker will be helpful. I'd also like to hear @Hakkush-07 's feedback as i think he was involved in a lot of changes around msm very recently.


Ask for Java 21 support for org.springframework.cloud : spring-cloud-dependencies

Hi team,
At our organization, we are asking internal service teams to upgrade to Java 21. As such, their projects' 3P dependencies also need to be Java 21 compatible. Hence, my following question:
Does org.springframework.cloud : spring-cloud-dependencies support Java 21?
If not, can this issue be used to request Java 21 support for org.springframework.cloud : spring-cloud-dependencies?
If there are plans already to support Java 21, is there an ETA for the same?

We do support Java 21. Are you having any issues?

I am developing also with Java 21 since beginning of the year and having no issues with spring-cloud-dependencies.


XDG_CONFIG_HOME support?

I'm opening this issue because:

[x] I want to request a feature
My Go version is: 1.15.4
My GOPATH is set to: /home/micro/.cache/go

If XDG_CONFIG_HOME is defined, it would be nice to default the qrcp.json to ${XDG_CONFIG_HOME}/qrcp/config.json or ${XDG_CONFIG_HOME}/qrcp.json.

Hello @jedahan, sorry for the late reply, this seems to be interesting.
I will consider this for the next release, thanks!
C

Hello @jedahan, sorry for the late reply, this seems to be interesting.
I will consider this for the next release, thanks!
C

Hello @jedahan, the XDG support is now available thanks to the work of @samhh.
Thanks both for suggesting and implementing the feature.
Claudio


[Feature] z-index to overlays

Feature Description
Can we implement a way to manage overlays z-index attribute ?
To Do
Adding z-index to overlay's styles option

This is a good idea. I'm not sure if it's a property or a style.

v9.4.0


Storage account: Deployment fails in main (Identity issue)

That's interesting. Although there is an issue with the principal ID as I'll detail below, but there's another thing interesting here as this was working for about a week without issues. When testing locally, I can see that the ARM API is not returning an exception in this case. The $res variable contains data. Tested using our New-ModuleDeployment and regular New-AzResourceGroupDeployment, To narrow if its a bug in our script. Turns out its not.
PS> New-AzResourceGroupDeployment -TemplateFile '.\arm\Microsoft.Storage\storageAccounts\deploy.bicep' -TemplateParameterFile '.\arm\Microsoft.Storage\storageAccounts\.parameters\parameters.json' -ResourceGroupName validation-rg

DeploymentName          : deploy
ResourceGroupName       : validation-rg
ProvisioningState       : Failed
Timestamp               : 12/10/2021 5:15:26 AM
Mode                    : Incremental
TemplateLink            :
Parameters              :
                          Name                                     Type                       Value
                          =======================================  =========================  ==========
                          name                                     String                     sxxazsaweux001
                          location                                 String                     westeurope
                          roleAssignments                          Array                      [

The ProvisioningState is returned as Failed. So the deployment is not pushing this out as a failure. If you look at the history of this module deployment, this has started failing when we introduced the principal ID as output. I've tried getting the principal ID using the CLI to that same storage account and indeed it does not exist. So its either an issue with Storage account that it doesn't provide it although it does indeed exist. Or it isn't supported.
Get-AzStorageAccount -Name sxxazsaweux001 -ResourceGroupName validation-rg | Select-Object -ExpandProperty Identity

PrincipalId TenantId Type                         UserAssignedIdentities
----------- -------- ----                         ----------------------
                     SystemAssigned, UserAssigned

So I think there are two issues here:

The deployment does not fail when this issue exists, which was the case for the past week until this last run on main, hence the issue was not detected.

So I thought it might be related to the Az.Resources Module (5.1.0) but not 100% sure as its the same version didn't fail yesterday, but locally I'm on an old version (4.4.1). Hence I can't tell where the issue is.
5.1.0 was released 3 days ago and we were using 4.4.1 before that so something must have changed in the last 2 days to cause this to pop up now.
Nevertheless, I think our New-ModuleDeployment should look inside the $res to see the ProvisioningState if it has failed as well. So we need a ticket for that

Also we need to remove the principal ID as output from the storage module as it isn't returned in the first place

Thoughts?
@MrMCake @MariusStorhaug

Further testing scenario: Used the min.parameters.json, and set to use systemAssignedIdentity to true, and it worked.. It returned the output... Then I introduced the userAssignedIdentity and then the issue popped up again. So for the storage account identity issue. I think that's where the problem is.. I am interested to know your thoughts.

Good catch, thanks @ahmadabdalla. @MariusStorhaug, any chance you could check this out?
If first thought it's related to the existing properties reference we talked about before, but it's actually not. Probably we need a dummy value? Still weird

Just to add, I ran the storage account workflow for my branch when I did the updates for Diagnostic Updates. My PR was just added 2 days ago with no issues during deployment. The behavior seems to be intermittent, sometimes it works other times it doesn't.  The workflow ran all green for all 3 parameter files:

Something like this before the return $deploymentName should be able to pick up the edge case:
if ($res.ProvisioningState -eq 'Failed') {
      throw ($res | Select-Object -Property DeploymentName, ProvisioningState, Timestamp | Out-String)
      return
}

Result:
[DBG]: PS C:\Users\ahmadabdalla\github\azure\ResourceModules>
     |  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     |
DeploymentName                       ProvisioningState Timestamp
--------------                       ----------------- ---------
storageAccounts-20211211T0812292848Z Failed            12/10/2021 9:32:43 PM

It is truly an edge case as running it again doesn't always get into that state.
The Storage Account itself when having both SystemIdentity + UserIdentity is still an issue, although the documentation doesn't restrict this.

The issue is not limited to Storage accounts but also other resources. See e.g. the KV here
See related issue #730
Note It's also flaky. The error may not be experienced in the next run (reason why issue #730 was initially closed).


Cursor unit tests

Adds tests for general json-compatible cursor implementations based on the existing JsonCursor tests
Ports tests to new cursor API
Adds additional tests specific to the new API

Did you check that the enabled assert's performance impact?

Did you check that the enabled assert's performance impact?

Good call. I checked and there's a minimal difference where some runs are actually faster with the asserts so I don't think it matters too much.


Update storm kafka docs.

docs/storm-kafka.md is out of date. This updates it to be the same as storm/external/storm-kafka/README.md

+1

+1

@aandis thanks for the fix.  I merged it into master.


crashes when using it with pkg

I got segmentation fault error when trying the compiled .exe using pkg

Hey, you would need to provide a lot more detail on this matter but segmentation fault signifies this is a low level crash caused by uWebsockets.js so your best shot is making an issue with as much detail as posible in the uwebsocket.js repository.


Reduce personal data storage

This removes usage and storage of the given names and family names of users. It includes a function to remove existing names from the database.
⚠ The function should require some kind of admin access to run, but it doesn't as of now. We need to discuss how to handle it. An alternative I thought about would be to have the authenticateUser mutation erase givenName and familyName if they are present.

Could we merge this?


Add an optional disable_notification parameter

https://telegram.org/blog/channels-2-0#silent-messages

Wow, I missed this change since it has not been mentioned in API changelog.
Thx!


♻ Remove streams

Co-authored-by: Anthony Accomazzo<EMAIL_ADDRESS>

#622  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


IndexOutOfRangeException: Array index is out of range.  at Dissonance.Networking.PacketWriter.Write (Byte b) [0x00000] in :0

IndexOutOfRangeException: Array index is out of range.
  at Dissonance.Networking.PacketWriter.Write (Byte b) [0x00000] in <filename unknown>:0
  at Dissonance.Networking.PacketWriter.Write (UInt16 u) [0x00000] in <filename unknown>:0
  at Dissonance.Networking.PacketWriter.WriteHandshakeResponse[HlapiConn] (UInt32 session, UInt16 clientId, Dissonance.Networking.ClientIdCollection idMap, System.Collections.Generic.Dictionary`2 peersByRoom) [0x00000] in <filename unknown>:0
  at Dissonance.Networking.Server.BroadcastingClientCollection`1[Dissonance.Integrations.UNet_HLAPI.HlapiConn].ProcessHandshakeRequest (HlapiConn source, Dissonance.Networking.PacketReader& reader) [0x00000] in <filename unknown>:0
  at Dissonance.Networking.BaseServer`3[Dissonance.Integrations.UNet_HLAPI.HlapiServer,Dissonance.Integrations.UNet_HLAPI.HlapiClient,Dissonance.Integrations.UNet_HLAPI.HlapiConn].NetworkReceivedPacket (HlapiConn source, ArraySegment`1 data) [0x00000] in <filename unknown>:0
  at Dissonance.Integrations.UNet_HLAPI.HlapiServer.OnMessageReceivedHandler (UnityEngine.Networking.NetworkMessage netmsg) [0x00000] in <filename unknown>:0
  at UnityEngine.Networking.NetworkConnection.HandleReader (UnityEngine.Networking.NetworkReader reader, Int32 receivedSize, Int32 channelId) [0x00000] in <filename unknown>:0
  at UnityEngine.Networking.NetworkConnection.HandleBytes (System.Byte[] buffer, Int32 receivedSize, Int32 channelId) [0x00000] in <filename unknown>:0
  at UnityEngine.Networking.NetworkConnection.TransportReceive (System.Byte[] bytes, Int32 numBytes, Int32 channelId) [0x00000] in <filename unknown>:0
  at UnityEngine.Networking.NetworkServer.OnData (UnityEngine.Networking.NetworkConnection conn, Int32 receivedSize, Int32 channelId) [0x00000] in <filename unknown>:0
  at UnityEngine.Networking.NetworkServer+ServerSimpleWrapper.OnData (UnityEngine.Networking.NetworkConnection conn, Int32 receivedSize, Int32 channelId) [0x00000] in <filename unknown>:0
  at UnityEngine.Networking.NetworkServerSimple.HandleData (Int32 connectionId, Int32 channelId, Int32 receivedSize, Byte error) [0x00000] in <filename unknown>:0
  at UnityEngine.Networking.NetworkServerSimple.Update () [0x00000] in <filename unknown>:0
  at UnityEngine.Networking.NetworkServer.InternalUpdate () [0x00000] in <filename unknown>:0
  at UnityEngine.Networking.NetworkServer.Update () [0x00000] in <filename unknown>:0
  at UnityEngine.Networking.NetworkIdentity.UNetStaticUpdate () [0x00000] in <filename unknown>:0

== STACKTRACK STATS ==
Times seen: 1
Last reported: 2018-02-21 12:24:40.517234


[Opensource]: RGSOC under Open_Source_Programs

Description
I want to contribute using documentation on RGSOC (RAILS GIRLS SUMMER OF CODE) under Open_Source_Programs
Domain
Open Source
Type of Contribution
Documentation
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

/assign

@priyanshiparolia  Do we need to add into  Open source programs? Since this program, I guess not active right now (last update : 2020) https://railsgirlssummerofcode.org/

I think you are right this program didnt took place in 2021 so maybe its not active

should I close this issue or replace its description with another one

should I close this issue or replace its description with another one

It would be better if you edit this any other program or if don't found any then you may close this

@priyanshiparolia Go with Bitcoin summer of code, This year bitcoin org started this program

@priyanshiparolia  Issue description updated

@Aryamanz29  how to add this hacktoberfest tag in an issue while creating?

@Aryamanz29 how to add this hacktoberfest tag in an issue while creating?

You can't add by yourself, You can tag Supervisors or Mentor for that