FlutterError.onError doesn't catch Dart exceptions (e.g. in the 'Crashy' example)

I've been trying to set up Sentry.io with Flutter with no success. I thought it was just something to do with my code but since an official Flutter example behaves in the same way, I assume it isn't. In the 'Crashy' example, which demonstrates how to integrate Sentry, there are three buttons: 'Dart exception', 'async Dart exception' and 'Java exception'. The latter two get caught by FlutterError.onError and run whatever code is in it. The first one, 'Dart exception', however, does not. I'm not an expert, but it seems like these exceptions are getting caught by something in Flutter before they can get to FlutterError, which only handles uncaught exceptions?
To reproduce:
Run the code in this repository: https://github.com/flutter/crashy
For async Dart exception, you will get some output like this:
`I/flutter (10543): Caught error: Bad state: This is an async Dart exception.
I/flutter (10543): #0      MyHomePage.build.<anonymous closure>.foo (package:crashy/main.dart:150:19)
I/flutter (10543): #1      MyHomePage.build.<anonymous closure>.bar (package:crashy/main.dart:153:28)
I/flutter (10543): #2      MyHomePage.build.<anonymous closure> (package:crashy/main.dart:155:26)
I/flutter (10543): #3      _InkResponseState._handleTap (package:flutter/src/material/ink_well.dart:779:19)
I/flutter (10543): #4      _InkResponseState.build.<anonymous closure> (package:flutter/src/material/ink_well.dart:862:36)
I/flutter (10543): #5      GestureRecognizer.invokeCallback (package:flutter/src/gestures/recognizer.dart:182:24)
I/flutter (10543): #6      TapGestureRecognizer.handleTapUp (package:flutter/src/gestures/tap.dart:504:11)
I/flutter (10543): #7      BaseTapGestureRecognizer._checkUp (package:flutter/src/gestures/tap.dart:282:5)
I/flutter (10543): #8      BaseTapGestureRecognizer.handlePrimaryPointer (package:flutter/src/gestures/tap.dart:217:7)
I/flutter (10543): #9      PrimaryPointerGestureRecognizer.handleEvent (package:flutter/src/gestures/recognizer.dart:475:9)
I/flutter (10543): #10     PointerRouter._dispatch (package:flutter/src/gestures/pointer_router.dart:76:12)
I/flutter (10543): #11     PointerRoute
I/flutter (10543): In dev mode. Not sending report to Sentry.io.`

For 'Dart exception', you will get some output like this:
`════════ Exception caught by gesture ═══════════════════════════════════════════════════════════════
The following StateError was thrown while handling a gesture:
Bad state: This is a Dart exception.

When the exception was thrown, this was the stack:
#0      MyHomePage.build.<anonymous closure> (package:crashy/main.dart:142:17)
#1      _InkResponseState._handleTap (package:flutter/src/material/ink_well.dart:779:19)
#2      _InkResponseState.build.<anonymous closure> (package:flutter/src/material/ink_well.dart:862:36)
#3      GestureRecognizer.invokeCallback (package:flutter/src/gestures/recognizer.dart:182:24)
#4      TapGestureRecognizer.handleTapUp (package:flutter/src/gestures/tap.dart:504:11)
...
Handler: "onTap"
Recognizer: TapGestureRecognizer#83092
  debugOwner: GestureDetector
  state: possible
  won arena
  finalPosition: Offset(235.7, 351.4)
  finalLocalPosition: Offset(92.0, 35.7)
  button: 1
  sent tap down`

Also in the meantime if anyone has a functional workaround for Sentry integration I would much appreciate it, because I really need it working on a live app.

Hi @alexobviously,
I see there's a similar open issue describing your case, 48972.
Please follow-up there for updates.
Closing this as duplicate. If you disagree, write in comments and I'll reopen.
Thanks.


tests: refactoring tests

I separated concerns and use cases in different describes.
I also developed some new tests duplicating class-based ones and moving them to HOF when missing on that side.

Tests do not pass just because we need #51 for this to work.


Testing the new changesmd change

This PR is trying to merge into master, so concierge SHOULD remind me about CHANGES.md !

@OmarShehata, thanks for the pull request! Maintainers, we have a signed CLA from @OmarShehata, so you can review this at any time.
I noticed that CHANGES.md has not been updated. If this change updates the public API in any way, fixes a bug, or makes any non-trivial update, please add a bullet point to CHANGES.md and comment on this pull request so we know it was updated. For more info, see the Pull Request Guidelines.

:sparkles: :sparkles: :sparkles:I'm the Cesium Concierge and I'm here to test things. :sparkles: :sparkles: :sparkles:


Migration to landscape2

Hi! 👋
We've been working on a new version of the landscape generating software, landscape2. This new version relies on the same landscape.yml file as the main data source, so nothing changes regarding adding or updating entries in the landscape.
The CNCF landscape has already been successfully migrated to landscape2, and we'd like to start migrating more landscapes 🙂
We are already building the GraphQL landscape using landscape2, you can check it out at https://graphql.landscape2.io/. It'd be great if you could give it a try when you have a chance and, whenever you are ready, we can proceed with the migration.
The process is very simple and would involve the following steps:

[ ] Add/update some DNS entries [1]
[ ] Stop background automated processes that write to this repository (i.e. CNCF bot)
[ ] Unlink this repository from Netlify
[ ] Update README file and clean up some files no longer needed in this repository
[ ] Setup the landscape2-validate-action to validate the landscape.yml file on PRs (optional)

We can take care of the last 4 points, you'd only need to add/update some DNS entries.
Landscape2 supports embedding a view with items in a category/subcategory in another website, but it works slightly different than landscape1. If parts of this landscape are embedded using this mechanism on other websites, we'd appreciate if you could let them know about how it works now.
Please ping me if you have any question 😉
[1] We’d need to know the hostnames you'd like to use to prepare our end to listen on them before switching the DNS (i.e. landscape.graphql.org). Once we are ready we'll provide you with the destination for the DNS entries so that you can update them.

OMG Yay! I didn't even realize we had a landscape v2, and I was just thinking I need to get it set up for some other projects. I think I can help with the DNS stuff, though I can't immediately find the record on graphql.org... so will have to do some digging. Thank you @tegioz !!

Thanks @jorydotcom!
Could you please create the following CNAME entries for us? We need them to prove that we are allowed to setup a certificate for those subdomains.
_d616d082e0014fef0b081f5543ccac18.landscape.graphql.org. -> _9deb6d30aaf056882afbe927deefd783.mhbtsbpdnt.acm-validations.aws.
_33000b4281f838c952a1f980c6791a1b.l.graphql.org. -> _487983a8444d7f7cbea305b4d0172ec1.mhbtsbpdnt.acm-validations.aws.

Once they are ready I'll update the list of hostnames and will share with you the new destination of the current landscape subdomains 🙂

@tegioz I think this is all set. Once we get GraphQL set up, I have some new projects to set up on v2!

Hi @jorydotcom

I think this is all set.

The CNAME entries for the certificate validation don't seem to be ready yet:
% host -t cname _d616d082e0014fef0b081f5543ccac18.landscape.graphql.org.
_d616d082e0014fef0b081f5543ccac18.landscape.graphql.org has no CNAME record
% host -t cname _33000b4281f838c952a1f980c6791a1b.l.graphql.org.
_33000b4281f838c952a1f980c6791a1b.l.graphql.org has no CNAME record

Once we get GraphQL set up, I have some new projects to set up on v2!

Awesome, looking forward to it 🙂

Hi @jorydotcom 👋
Do you mean the updates in #377? I think they've been applied to https://graphql.landscape2.io as well.
Please note that the GraphQL landscape v2 is built once a day, so it may take up to 24 hours for the changes to be applied.
BTW looking forward to completing the migration to v2 as soon as the CNAME entries I mentioned in my previous comment are ready 😇


Updated documentation for creating a named Docker volume

Documentation was outdated. Need the --name option when creating a named volume
Signed-off-by: Isaac Gentz<EMAIL_ADDRESS>

Apologies for the extremely late review on this request.  This is approved.


Upload new doc transactional licence page

Changes in this PR:
Upload new doc transactional licence page
Trello card / Rollbar error (etc)
https://trello.com/c/AVHWYqMm/1547-update-computational-analysis-word-document-form-on-the-transactional-licence-page
Screenshots of UI changes:
Before

After

[ ] Requires env variable(s) to be updated

 Update computational analysis word doc form on the transactional licence page


Implement SHA256/512 multi-buffer with Arm64 crypto extention

Arm64 crypto extention support sha256/512 instruction .
This PR implement SHA256/512 with the instructions .

@gbtucker  Please review it

close it . It will reupload after multibinary patch


Add license and copyright statement (fixes #8200) [ci skip]

:+1:

That looks good.
Is there some kind of conflict between the [ci skip] commit label and the repository configuration that requires CI tests to pass before allowing a merge? It appears that GitHub has been stuck on "Some checks haven't completed yet" for quite a while.

Forced-push so CI should now run.


feat: Allow SES SourceARN to be set

part of FlowFuse/flowfuse#4173
Description

Allows AWS SES sourceArn to be configured when using a shared SES instance.
Related Issue(s)

FlowFuse/flowfuse#4173
Checklist

[x] I have read the contribution guidelines
[ ] Suitable unit/system level tests have been added and they pass
[x] Documentation has been updated

[ ] Upgrade instructions
[x] Configuration details
[ ] Concepts

[ ] Changes flowforge.yml?

[ ] Issue/PR raised on FlowFuse/helm to update ConfigMap Template
[ ] Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

[ ] Includes a DB migration? -> add the area:migration label

Don't merge before https://github.com/FlowFuse/flowfuse/pull/4177


Cut the WF prefix with NS_SWIFT_NAME

I think we should carefully consider whether this is something we should be doing, both inside Workflow or outside. I'm not sure it's actually currently in the spirit of Swift to do so (especially for third-party libraries) given the lack of real namespacing and the fact that Apple system libraries retain their prefixes. This morning, I read through the entirety of the Swift Evolution postings on the NS prefix dropping proposal to better understand what the goals are, and rationale behind the prefix dropping was pretty specifically because some Foundation classes are meant to be thought of as core Swift classes.
Also note that the stated purpose for NS_SWIFT_NAME on the Swift blog is as follows:

Specific Objective-C APIs that translate poorly into Swift will then be annotated (for example, with NS_SWIFT_NAME) to improve the resulting Swift code.

(That is, NS_SWIFT_NAME is primarily intended to improve the names of methods; it's not recommended anywhere that it be used to drop class prefixes.)


[MRG] Improve embedding net tutorial

What does this implement/fix? Explain your changes
This improves the text and presentation for the tutorial on embedding networks for SBI
Does this close any currently open issues?
Fixes #903
Any relevant code examples, logs, error output, etc?
No
Any other comments?
I experimented with some formatting and admonitions from mkdocs-material and would like to know your thoughts on that. I could extend this formatting style to other tutorials and examples if you think it is good.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask. We're here to
help! This is simply a reminder of what we are going to look for before merging
your code.

[x] I have read and understood the contribution
guidelines
[x] I agree with re-licensing my contribution from AGPLv3 to Apache-2.0.
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have reported how long the new tests run and potentially marked them
with pytest.mark.slow.
[x] New and existing unit tests pass locally with my changes
[x] I performed linting and formatting as described in the contribution
guidelines
[x] I rebased on main (or there are no conflicts with main)

thanks for adding this @plcrodrigues
Similar to the other PR, there seems to be a problem with the commits here. There is a number of commits from main showing up in this PR, possibly because they appear in between your commits. I believe a fix could be to run rebase -i main and re-order your commits on top of those from main.
Thanks 🙏

Oh, I see. Yes, the syntax and notes look great on the website. I would say that there is a trade off to make: given that many users will probably also execute notebooks locally, I would opt for showing the syntax in the beginning without mkdocs macro, but using plain markdown syntax highlighting.
Because the !!! tips is less invasive in the notebooks, I think we can keep it.

OK, I've removed the mkdocs macro for main syntax (it was a !!! tip) but kept the macro for notes, which is less intrusive. Once this PR is merged I will try to find a way of formatting both the notebooks+websites without the ugly intrusive macros above.

Cool, thanks for helping out! :) how can I be sure of having a linter that is consistent with what ruff will be checking?  The problem could be that your are using flake8 automatically within your IDE, e.g., "on save".
Ideally, you would deactivate that when working in the sbi repo.
ruff includes flake8 rules.
Our pre-commit hooks will run the ruff linter and fail if something is off, e.g., line lengths. Then you need to fix that by running ruff format . --fix or by hand. E.g, for fixing line lengths I an extension in VSCode called rewrap, setting the line length to 88.
In this case things got chaotic because our ruff checks where broken so that too long lines where accidentally merged into main last week.


[Bug]: [Security] [Sealed Secrets] Catalog secret have only 2 var not 4

What happened?
in the workshop :
kubectl -n catalog get deployment catalog -o yaml | yq '.spec.template.spec.containers[] | .env'
- name: DB_USER
  valueFrom:
    secretKeyRef:
      key: username
      name: catalog-db
- name: DB_PASSWORD
  valueFrom:
    secretKeyRef:
      key: password
      name: catalog-db
- name: DB_NAME
  valueFrom:
    configMapKeyRef:
      key: name
      name: catalog
- name: DB_READ_ENDPOINT
  valueFrom:
    secretKeyRef:
      key: endpoint
      name: catalog-db
- name: DB_ENDPOINT
  valueFrom:
    secretKeyRef:
      key: endpoint
      name: catalog-db

and in reality:
- name: DB_USER
  valueFrom:
    secretKeyRef:
      key: username
      name: catalog-db
- name: DB_PASSWORD
  valueFrom:
    secretKeyRef:
      key: password
      name: catalog-db

What did you expect to happen?
so some commands whil failed like :
kubectl -n catalog get secrets catalog-db --template {{.data.endpoint}} | base64 -d
catalog-mysql:3306%
~
$
kubectl -n catalog get secrets catalog-db --template {{.data.name}} | base64 -d
catalog%
as it don't exists
How can we reproduce it?
just deploy the catalog service
Anything else we need to know?
No response
EKSversion
1.23

I'll take ownership, a fix is queued up for this already

This has now reappeared in live website. https://www.eksworkshop.com/docs/security/sealed-secrets/exploring-secrets#exploring-the-catalog-pod


deno-server preset: duplicated line in index.mjs "import process from 'node:process'"

Environment
<EMAIL_ADDRESS>Node.js v18.7.0
deno 1.34.3 (release, aarch64-apple-darwin)
v8 <IP_ADDRESS>
typescript 5.0.4
Reproduction
npx giget@latest nitro
cd nitro-app
npm install

and deno part:
NITRO_PRESET=deno-server npm run build
deno run --unstable --allow-net --allow-read --allow-env .output/server/index.mjs

Describe the bug
I got this error:

error: Uncaught SyntaxError: Identifier 'process' has already been declared

so I looked into .output/server/index.mjs :
import process from 'node:process';globalThis._importMeta_={url:import.meta.url,env:process.env};import "npm:node-fetch-native/polyfill";
import destr from "npm:destr";
import { defineEventHandler, handleCacheHeaders, createEvent, eventHandler, setHeaders, sendRedirect, proxyRequest, getRequestHeader, setResponseStatus, createError, createApp, createRouter as createRouter$1, toNodeListener, fetchWithEvent, lazyEventHandler } from "npm:h3";
import { createFetch as createFetch$1, Headers } from "npm:ofetch";
import { createCall, createFetch } from "npm:unenv/runtime/fetch/index";
import { createHooks } from "npm:hookable";
import process from "node:process";

the import process line was written twice. When I commented out later one, it works.
Additional context
No response
Logs
No response

/cc @danielroe I guess we should remove the direct polyfill since unenv already provides it..


Outline view shows local variables as type members

In the screenshot below, frequency, format, channels, and result are local variables in the computed property audioDeviceSettings.
Similarly, count, decoders, and index are local variables in the chunkDecoders computed property.

This is using version 0.8.2 with Swift 5.7 on macOS

Can you include the code that generates this. I won’t be able to look at this for the next week as I’m on holiday. It is most likely some confusion between the vscode language client and sourcekit-lsp. It is probably worthwhile adding a bug to the source kit-lisp repo.

Here's a minimal test case:
struct OutlineIssue {
    var x: Int {
        let y = 0
        return y
    }
}

It also occurs on Linux.

Fixed on main branch of SourceKit-LSP, fix will be available with Swift 6.


SQL Error [XX000]: ERROR: ClickHouse does not support deletes

Describe the problem you're observing:
SQL Error [XX000]: ERROR: ClickHouse does not support deletes
Steps to reproduce, if exist:
query: delete from [clickhouse_fdw] where [expr]
Solution
Clickhouse supports deletes as "Alter table [table] delete where [expr]"
Please update

thanks for the report
duplicates #10718


Added post leaderboard use case

Organized getLeaderboard into a folder and added a post leaderboard use case

Great pull request but in the future add comments to your code to aid in readability.


Fixes to compile with clang 15

Note: this is only for building the code base with clang15.
I will have a separate PR for using LLVM15 as the JIT.
Signed-off-by: Larry Gritz<EMAIL_ADDRESS>

This look ok to everybody?

LGTM


Upgrade to React 15.5

Related to #36. Our test suite throws warnings since we upgraded to 15.5.
https://facebook.github.io/react/blog/2017/04/07/react-v15.5.0.html

We're still using React 15.4.2 in production, but if you put together a PR @nmonti I'll gladly take a look at and accept it. :)


obs_source_info.video_render has void* type for the effect parameter instead of gs_effect_t

gs_effect itself seems to exist in NetObsBindings already and there is also lots of functions for the whole libobs/graphics area available in ObsGraphics, but still the obs_source_info.video_render delegate uses void* type for the effect parameter so something still seems to be missing.

Removed gs_effect type replacement in in <IP_ADDRESS>-alpha.

Parameter type is gs_effect now, thanks!


[ACR] add contextAccessToken to task step

Bug fix: Add contextAccessToken to task step so that a task can be manually run from a private repository even when source triggers are disabled.

@yugangw-msft @tjprescott we are ready to merge this bug fix. Can you please take a look? Thanks!


Anacrusis bar number issue

c.70 songs with an anacrusis in which that first measure given as 1 but should be 0 (i.e. 'excluded from bar count').
Automatically identified and manually fixed.
Should all be resolved in the next update from the MuseScore.com collection version of record.

@MarkGotham, updated! Does this have the data you need now?


Add test for #853

Shows bug is fixed by upstream verilogAST change for index nodes

Closing, will do a pull to master with the fix by itself


feat(expressive modal): v1 & v2 guidance updates

Related Ticket(s)
https://github.com/carbon-design-system/carbon-for-ibm-dotcom-website/issues/1616
Description
v1 & v2 guidance updates
Changelog
New

Added behaviour section with details on Model position, Overflow and closing the modal

Changed

Updated the default use case image with one from lightbox media viewer

Removed

Removed use case image for large variant

@ariellalgilmore ,
Added images to the behaviour section.

@sangeethababu9223 could you please look into adding the GIF player to your two GIFs? I think the light prop might be best but if you could try light for the first and dark for the second so we can see both that would be helpful.
We could take a static pull from your video files for the static image?

@oliviaflory,
Added Gif player as per your comment. Please check.

It's perfect, thanks you @sangeethababu9223 !


Add Files to Project

What problem are you facing?

When creating a project I want to add some initial files so that its not empty. So I have some smooth onboarding process. I currently use crossplane and the provider to provision a group (like a tenant) and a corresponding repository where a user would be able to configure the "tenant".

Are you looking for Gitlab Templates? If so, have you tried some of the existing options, e.g. useCustomTemplate?

https://docs.gitlab.com/ee/api/repository_files.html#create-new-file-in-repository

This would be great if a gitlab repository file could be created

Great idea +1

Hello guys, any chance that we can have this feature?


migrate from travis ci to github actions

Description
GitHub Actions are a far superior experience for testing this library, so moving our test suite to GitHub Actions should be prioritised.
Expected behaviour
Test suite runs on a GitHub Action workflow, and all travis ci related config is removed from the repo.

actively working on this one today.


Error messages on docker instance because of missing /run directory

Version
[jenkins@3f48927aac4f ~]$ pacaur -v
pacaur 4.7.2

Description
Error messages on docker instance because of missing /run directory.
The build doesn't fail, but it would be nice if these messages wouldn't
be printed.
Output
e.g.
pacaur -S cutecom

...
touch: cannot touch '/run/user/1000/pacaur.build.lck': No such file or directory
...
rm: cannot remove '/run/user/1000/pacaur.build.lck': No such file or directory

This is already fixed in current master. The code now uses ${XDG_RUNTIME_DIR:-/tmp} instead of hardcoded /run/user, so /tmp will be used as fallback. See fa98859f515c1202f702ba9504187e15ca307d98.


Added b2sum and b3sum utility entries

Fixes: #3162.
Added "b2sum" and "b3sum" to the phf map. I ran both cargo test and ran the gnu test and didn't see any regressions.

Thanks!


add logic for daylight saving changes

Fixes #4
Rewrite logic to don't rely on 96 lines per report.
Reports can contain any number of "hour_blocks" (4 QH lines in the right order) now. This can be used to update one specific hour value too.
With the new logic summer daylight saving changes don't have to be considered since the whole "hour_block" is missing (this should be double checked when the QH report from March 26 2023 is available).
PR contains test to bump coverage of test_sensor.py to 100%

Thanks @brandstaetter
Manual testing in dev environment seem to work too. (2022-10-30 displayed 25 bars in the energy dashboard; 2022-03-27 displayed 23; can be tested with the files in the test folder)
I removed the warning in the readme too since this should be resolved with this PR.


Add github badges for React, Django and NodeJS in the readme.md

Describe the solution you'd like
Add GitHub badges/SVGs for ReactJS, Django and NodeJS in the readme.md.
Additional context
The badges should look like the following badge:

@PragatiVerma18 can I take this issue. I am very interested!

Hello again! I'd really like to work on this :)

Hello @PragatiVerma18 I'll love to make a contribution to this.
I tried searching through the Github Repository of https://forthebadge.com/ and found that the minimal look required for the other three badges aren't available, also the Repo is inactive with past PRs and unsolved issues.
So, I used other relevant websites to create the following badges:
ReactJS

DJango

NodeJS

Hello @PragatiVerma18 I am willing to make a contribution to this.

I would like to work on this issue.

@PragatiVerma18 I want to learn and work on this issue

Hello, @PragatiVerma18 I would like to work on the issue.

Interested

I would like to work on this issue.

@PragatiVerma18 Can I take this issue

@huonggiangbui try doing this task as early as possible. Good Luck.


Possibility to run Flank with Cucumber tests

How can i run my cucumber tests ?
Describe the bug

In documentation it said that we could run Cucumber test by disable sharding and only if there are other Instrumented tests. But it did not work.

To Reproduce

Steps to reproduce the behavior:

Run './gradlew runFlank' ( i use fladle)
only not cucumber tests are run

Expected behavior

I expected that my cucumber tests would run.

Details (please complete the following information):

 flank --version : 21.01.1

Hey, unfortunately cucumber tests aren't supported.
https://github.com/Flank/flank/blob/master/docs/cucumber_support.md

Yes but the documentation you send me said that its possible no ?

Did you try disabling orchestrator? use-orchestrator: false

Yes

@maxbetton Hey, thanks for reporting this. We will take a look but we need more info. It would be great if you change the issue description with the template https://github.com/Flank/flank/issues/new?assignees=&labels=Bug%2C+%3Atiger%3A&template=bug_report.md&title=
Thanks!

@pawelpasterz I have done thank you


Add Holmfirth High

Official website: https://holmfirthhigh.co.uk/

@Shm3xyP1nk Pull request merged. Thank you!


Symbol.id of zero-sized arrays

The Symbol for arrays is assigned an id which is the starting id for the (sequential) ids of its elements.
In the case of a zero-sized arrays, the Symbol is still assigned such an id, but this id is not "reserved": it will be reused by the next declaration.
This is fine, except that care must be taken when updating/referencing zero-sized array ids through array_elements().
Questions:

should we disallow zero-sized arrays?
should their symbol id be handled differently?

Especially I'm wondering if we should disallow col witnes x[0];, i.e. fixed-size witness arrays declared statically.


Make perf and itimer use cpu clocks

Both itimer and perf would rely on wall clocks to sample threads. This
makes them wall-time profilers, not cpu profilers. To fix that, we
simply make sure that they both use cpu clocks.
The difference is for example in profiling sleep 1, a wall clock will
display 1 second of activity, while a cpu clock will display close to 0
seconds of activity. That's because, in the second case, the process was
sleeping for 1 second and was thus not executing on cpu for 1 second.
The time spent executing on cpu was then close to 0.

Would it be possible to add a test case which would show that eg. for a program doing only 'sleep' the profiler would not gather (almost) any data?


test(optimize-missing-deps): rewrite deps in CJS

Description
Fix test optimize-missing-deps, rewrite deps with CJS. This will pass #6698 failing test and eliminate the following warning:

Additional context

What is the purpose of this pull request?

[ ] Bug fix
[ ] New Feature
[ ] Documentation update
[x] Other

Before submitting the PR, please make sure you do the following

[ ] Read the Contributing Guidelines.
[ ] Read the Pull Request Guidelines and follow the Commit Convention.
[ ] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[ ] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[ ] Ideally, include relevant tests that fail without this PR but pass with it.

Would you explain why the current esm wasnt working? Could it break user code or is it just an artifact of our test setup?

Would you explain why the current esm wasnt working?

Because we don't have field type: "module" in missing-dep's package.json, if we externalize it, Vite treats it as CJS that raised the error. While we could add this field to package.json, when I try it, I found that jest does not support running ESM in Node environment.

it just an artifact of our test setup?
yes


Doesn't work, opens a safari tab for the web player

The app doesn't do anything other than a new safari tab that loads the web player, How do I fix this? Tried quitting the app and spotify, opening the app then spotify and vice versa, no effects.
Spotify version:
Spotify for macOS (Apple Silicon)
<IP_ADDRESS>2.g26c92729
macOS Sonoma 14.3

@Plagg06 killing "ssa-core" process worked for me


updated logo

I did a dirty css hack by doing a display:none to the name in the log (as it was part of the html, and is now part of the logo svg)
Also, it seems like I had to copy the whole _nav.scss to the local assets, if I removed the rest of the css rules the navbar lost the styles to, so looks like stuff needs to be here.
If someone knows how this is done in Hugo, please advise.

It looks quite nice, @tigert!

It looks quite nice, @tigert!

/close
This was replaced by #22


re-run doc examples after roms-tools fix

see: https://github.com/CWorthy-ocean/roms-tools/issues/163

roms-tools v.1.4.1 (available on PyPI) contains the fixes

Will take this on when at a workstation this afternoon, thanks for the update.

When you re-run this notebook, do you mind changing the following things in the final notebook cell:

Add a comment

BGC_DS = xr.open_dataset(example_case_2.caseroot / 'output/ROMS_MARBL_bgc.20120103120000.nc')  # this contains 6-hourly data, with the date in the filename reflecting the first time entry

Use lower-case cmap in

p2 = ax2.pcolormesh(lon,lat,BGC_DA.isel(time=0).values, vmin=VMIN, vmax=VMAX, cmap=cmap)
p3 = ax3.pcolormesh(lon,lat,BGC_DA.isel(time=-1).values, vmin=VMIN, vmax=VMAX, cmap=cmap)


Remove buffers noAssert argument

Support for the noAssert argument dropped in the upcoming Node.js
v.10. This removes the argument to make sure everything works as it
should.
Refs: https://github.com/nodejs/node/pull/18395

Ping @indutny

@indutny PTAL

PTAL


settings: Revert "loader" indicator from fontawesome to SVG.

This reverts loader indicator from the new fontawesome
icon-button-loading to previous SVG one, this change is only reflected
to those loaders which use loader.handlebars template for
loading indication(because there are some indicators like "Save changes"
in org settings which don't use loader.handlebars).
This main problem with this indicator is that it is bit
inconsistent with other places where we use loader.handlebars like
loading Zulip icon which appears while fetching old messages.

Merged, thanks @shubhamdhama!


Xcode 11.4 Fix

This fixes working with Xcode 11.4 and enables Whole Module Optimization for the Targets.
Use ENABLE_TESTING_SEARCH_PATHS = YES

Fixed it 👍

Thanks!

And it's live in version 3.1.0.


The following environment variables should be defined:  - ARM_CXX=path-to-cross-compilation-g++ - ARM_STAGING=path-to-cross-compilation-staging-dir

ARM_STAGING=path-to-cross-compilation-staging-dir 新手，请问这里的路径指的是哪个配置路径？

just for example:
ARM_CXX=aarch64-linux-gnu-g++
ARM_STAGING=gcc-linaro-6.3.1-2017.05-x86_64_aarch64-linux-gnu/bin

Hi
How did you find this info?
I mean it's there a way to verify if it's just like this, or if it differs?


relax memory ordering of treiber stack

I think it is correct to use relaxed ordering, since:

push function has no data to publish to other thread.
all write operations on TreiberStack.head is atomic read-modify-write, so will be part of the release sequence headed by the release operation in push function, according to the cpp ref.

It's true.  Thanks!
bors r+


Fix cloning vs pulling by normalizing path

Fixing issue 440:
Problem:
On Windows 10 Backport will always clone, because the projectRoot & repoPath never will be equal, even though they do exist.
A problem with \ vs / .
My solution is to add path.normalize() which should work on both Windows and POSIX.
Feel free to adapt my solution as needed.
Test executed:
Run 1st time: Repo cloned
Run 2nd time: Repo pulled
Run 3th time (after deleting the repo): Repo cloned

Change lgtm . Thank you for the help!

Released in 8.9.4. Please try it out and lmk if it works as expected. Thanks!


[Urgent] Researcher cannot see all of the 12 publications in the back-office in the front-office

Bug

Researcher
https://telefoonboek.prd.rad.ugent.be/nl/people/802004158104
has 12 public publications in the back-office (assigned as author)
https://backoffice.biblio.ugent.be/publication?q=guido+bartolini&sort=date-updated-desc
can only see one in the front-office
https://biblio.ugent.be/person/39eb8225-5a39-11ed-94f6-eae236849690

Is this a "person" bug?

@mietcls not indexed in frontoffice for some reason, ok after reindexing


Exit code block on ```

When a user types ``` in a code block we should exit the code block.

Oh that already works, I'm a dummy.


Add functional test to parse all Fedora spec files

Inspired by #235.

================ 2812 failed, 20192 passed in 968.78s (0:16:08) ================

Are you planning on fixing it? :eyes:

It will go down to about 10 failures once I figure out and install all the macro packages that are necessary for parsing :slightly_smiling_face:

Ah sure, it seemed like there are some “clusters”, I think Go was one of those?

Yes. Let's see now.

Ok, https://github.com/rpm-software-management/rpm/commit/b3adc8ce62517cd764a589d2bdccbf97dadb915a explains the higher number of failures on rawhide. As for the rest, some of them are bugs (and for some of those there are already issues reported, thanks @xsuchy) and a few of them are packaging errors, I'll try to find a way to differentiate those.


Problem in Batching

Hey! Thanks for the amazing work.
I was trying to run the code in batches of 8. Ran into an issue with torch.stack as all images for Corvi2023 are not resized to the same dimensions. I was wondering why is it so?

The technique works only with batch-size equals to 1


Casper not found

I tried setting up a new Ghost blog and I am getting the error "Casper theme not found". I've not had this issue before, was Casper removed from the docker image?

Casper is there as it is part of Ghost as a sub-folder.
We can close this.


Donation flow

Awesome project, thank you for making icons so easy!
Could we add something like a PayPal link for donation to the Readme.md?

Hey, thanks, I'm glad you're enjoying it! ❤
This is the first request for a donation link I've gotten, but If you'd like to donate, there's three ways I think:

GitHub sponsors: https://github.com/sponsors/jacobwgillespie
My personal PayPal: https://paypal.me/jacobwgillespie
OpenCollective: https://opencollective.com/styled-icons

Thank you!
I just saw that you also have it at the end of the Readme as well, but I didn't think to search for contributors!


I just want to say I tried adding the checkpoint and animation classes from gta iv but I don't think I am that good in c++ so someone else more experienced better check it.

I just want to say I tried adding the checkpoint and animation classes from gta iv but I don't think I am that good in c++ so someone else more experienced better check it.
And please fix anything I may have messed up with.

Thank you =). Unfortunately, that code does not do anything right now. It adds those classes, but it's missing an implementation for GTA 5. Also, please make sure you only commit files you actually want to commit, because this pull request would overwrite half the project (I'm guessing that's because of whitespace differences).

okay thanks crosire.
I guess it is because of whitespace differences
as I did do the checkpoint implementation in world::drawcheckpoint
I should have removed the checkpoint.cpp or ones that is basically a filler(left over after trying to get c++ to build)


Support multiple rarity languages

Hi,
currently item rarity overlay just work in english language.
https://github.com/SteveKunG/SkyBlockcatia/blob/310b9505e6d0d3a00cf5e1fe2f3d55c27e57faac/src/main/java/com/stevekung/skyblockcatia/utils/RenderUtils.java#L112
In Actions House some items has a rarity in different languages results that the rarity wont work.
Maybe you could move away from word matching and just use a match based on the color.

Well, Hypixel should export their API by default language (English). That's really annoying for website or mods.

Fixed in 1.0.9


What does dispatch?: boolean of an effect cause exactly?

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report
[ ] Performance issue
[ ] Feature request
[x] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior
On https://datorama.github.io/akita/docs/angular/effects and in the file<EMAIL_ADDRESS>is documentaton for dispatch?: boolean missing.
What does dispatch?: boolean cause exactly?
My effects didn't work for me until I found that dispatch hast to be undefined instead of false in my case, say just skipped.
Expected behavior
dispatch?: boolean is documented at least in one of the sources above and ideally also on https://datorama.github.io/akita/docs/best-practices
Minimal reproduction of the problem with instructions
Just go to https://datorama.github.io/akita/docs/angular/effects or open<EMAIL_ADDRESS>What is the motivation / use case for changing the behavior?
To work with akita optimally
Environment
Angular version: ~10.1.0
Akita version: ^6.0.0

If you want to return a new action from the effect, you can use { dispatch: true }, and it'll dispatch the returned action for you.

That's correct.
What's  your exact setup?
If this issue still persists can you show a stackblitz or code sample?
You should be using no flag or set {dispatch: true} if you are returning one or morge actions from your effect.
https://github.com/datorama/akita/blob/e6f0b5d83684e9ad84ddbf065c6c571912b2c50c/libs/akita-ng-effects/src/lib/module-manager.service.ts#L35-L36

The issue is the document one, not the technical one. It works fine for me now, but it took a couple of hours for me to figure out that the beginning effect should not have dispatch set to false. I think, it's a mistake of a state management newbe.
That's why I expect dispatch to be documented on https://datorama.github.io/akita/docs/angular/effects and in<EMAIL_ADDRESS>Now hen I know, what dispatch does, I can also improve the documentation myself.
Should I just do it?

What's your exact setup?
If this issue still persists can you show a stackblitz or code sample?
You should be using no flag or set {dispatch: true} if you are returning one or morge actions from your effect.

IIt'll be cumbersome to put the productive app to stackblitz, but for the sake of completeness here is the effects class where I had problem to solve (I renamend some variables and classes before putting the code here).
The first effect had also dispatch put to false, making all the effects useless.
import { HttpClient } from '@angular/common/http';
import { Injectable } from '@angular/core';
import { Actions, createEffect, ofType } from '@datorama/akita-ng-effects';
import { Observable, of } from 'rxjs';
import { catchError, switchMap, tap } from 'rxjs/operators';

import { ErrorService } from 'src/app/services/error.service';
import { loadFoo, loadFooError, loadFooSuccess } from './foo.actions';
import { FooEntity } from './Foo.model';
import { FooStore } from './Foo.store';

@Injectable()
export class FooEffects {

  constructor(
    private actions$: Actions,
    protected store: FooStore,
    private http: HttpClient,
    private errorService: ErrorService,
  ) {}

  loadFoo$ = createEffect(() =>
    this.actions$.pipe(
      ofType(loadFoo),
      switchMap( _ => this.get().pipe(
          tap((entity: FooEntity) =>
            this.actions$.dispatch(loadFooSuccess(entity)))
        )
      ),
      /* tslint:disable:no-any */
      catchError( (error: any) => {
      /* tslint:enable:no-any */
        this.actions$.dispatch(
          loadFooError(this.errorService.convertToAppError(error))
        );
        return of(error);
      }),
    )
  );

  loadFooSuccess$ = createEffect( () =>
    this.actions$.pipe(
      ofType(loadFooSuccess),
      tap((entity: FooEntity) => this.store.set([entity])),
    ),
    { dispatch: false }
  );

  loadFooError$ = createEffect( () =>
    this.actions$.pipe(
      ofType(loadFooError),
      /* tslint:disable:no-any */
      tap((error: any): void => this.store.setError(error)),
      /* tslint:enable:no-any */
    ),
    { dispatch: false }
  );

  get(): Observable<FooEntity> {
    return this.http.get<FooEntity>('/foo');
  }
}

@juri-sinitson you're welcome to submit a PR. Thanks.


360 instructions

So in other places talking about this project I've seen it mentioned that it can be set up to do 360 degree tracking instead of just 180.  But your setup guide doesn't offer a lot of hints about how to do it...
Can I just generate more tags and make the trackers into octagons or similar?  I would assume that's the reason for having such a large range assigned to each tracker...  Or does it require a second camera?  I can likely fiddle out the details if I can get an idea of where to start...
Assuming it just takes additional tags, then personally I can probably handle chasing down through the subrepos to find more tags (the pre-generated tags from the AprilTag project are 9x9px and need a bit of scaling and fitting onto standard pages...) Would you like the results of that work posted as something for other users?

Hello!
Sorry for the confusion, the setup guide may be a bit outdated by now, but I am working on a better one! Most of the updates were shared through the discord server - any instructions for the beta will be found there until i rework the github instructions, so I would suggest you join it :)
Yes, you can get more tags in the official AprilTags repo, but I do include the additional 2 markers you need for the backside in the download, inside the "images to print" folder. Examples of how trackers like that look like can also be found in the discord, in the #user-examples channel, you can look around there for ideas on how to put that together. You can also share your results there, or anywhere else you would like, i always enjoy seeing how other got this working.
If you need any help, feel free to ask. Some parts of setup, such as opening a webcam properly and setting exposure, can be a weird process that isnt well documented yet...


Cannot get property 'supportLibVersion' on extra properties extension as it does not exist

Hello,
I am trying to use this library in my project, although I am getting the following error when trying to build on Android:
A problem occurred evaluating project ':react-native-reanimated'.

Cannot get property 'supportLibVersion' on extra properties extension as it does not exist

The project builds fine on iOS.
Any help would be much appreciated, really would love to use this library!

I have this issue too

add this code in you android/build.gradle:
/**
 * Project-wide gradle configuration properties for use by all modules
 */
ext {
    compileSdkVersion           = 25
    targetSdkVersion            = 25
    buildToolsVersion           = "25.0.2"
    googlePlayServicesVersion   = "12.0.1"
    supportLibVersion           = "27.0.0"
}

and sync again

add this code in you android/build.gradle:
/**
 * Project-wide gradle configuration properties for use by all modules
 */
ext {
    compileSdkVersion           = 25
    targetSdkVersion            = 25
    buildToolsVersion           = "25.0.2"
    googlePlayServicesVersion   = "12.0.1"
    supportLibVersion           = "27.0.0"
}

and sync again

Ty for answer, this solves issue

// face the same issue then I follow @tourze suggestion solved the problem here is my android/build.gradle looks like

buildscript {
    repositories {
        jcenter()
        google()
    }
    dependencies {
        classpath 'com.android.tools.build:gradle:3.0.1'

        // NOTE: Do not place your application dependencies here; they belong
        // in the individual module build.gradle files
    }
}

ext {
    compileSdkVersion           = 25
    targetSdkVersion            = 25
    buildToolsVersion           = "25.0.2"
    googlePlayServicesVersion   = "12.0.1"
    supportLibVersion           = "27.0.0"
 }

allprojects {
    repositories {
        google()
        // Add jitpack repository (added by tipsi-stripe)
        maven { url "https://jitpack.io" }
        mavenLocal()
        jcenter()
        maven {
            url 'https://maven.google.com'
        }
        maven {
            // All of React Native (JS, Obj-C sources, Android binaries) is installed from npm
            url "$rootDir/../node_modules/react-native/android"
        }
    }
    subprojects {
        project.configurations.all {
            resolutionStrategy.eachDependency { details ->
                if (details.requested.group == 'com.android.support'
                        && !details.requested.name.contains('multidex') ) {
                    details.useVersion "26.0.1"
                }
                if (details.requested.group == 'com.google.android.gms'
                && !details.requested.name.contains('multidex') ) {
                    details.useVersion "12.0.1"
                }
            }
        }
        // to activate when your SDK is Android P
        afterEvaluate {project ->
            if (project.hasProperty("android")) {
                android {
                    compileSdkVersion 28
                    buildToolsVersion "28.0.3"
                }
            }
        }
    }
}

It seems. that nothing on my App (as it is migradet to AndroidX) need this supportLibVersion entry, but this react-native-reanimated Component.
I use  androidXCore = "1.0.2" instead supportLibVersion = "28.0.0" in my android/build.gradle.
Isn't there a way to make react-native-reanimated also work with this above setting?

One workaround for the time being if you're on RN 0.61, add back supportLibVersion = "28.0.0" to android/build.gradle under buildscript.ext.

I believe this issue was solved by @tourze and #463, so I'm closing it. If you have any further concerns don't hesitate to ask.


[FancyZones] Add slight delay to "hold a non primary mouse button to activate zones"

Environment
Windows build number: 10.0.18363.836
PowerToys version: v0.18.1
PowerToy module for which you are reporting the bug (if applicable): FancyZones

Steps to reproduce

Enable "hold a non primary mouse button to activate zones"
Start dragging a window, then start dragging the non-primary mouse button
Let go of both buttons at the same time, but the non-primary button ever so slightly first

Expected behavior
Snap to the zone. Basically I think there should be a slight delay (50ms?) where it stays active, after the non-primary button has been released. Right now I have to consciously let go of the left mouse button first, since it seems like my hand/brain/mouse/something releases the right mouse button ever so slightly first.

Hi @nathan-sav
we are changing the way the non primary mouse buttons will work https://github.com/microsoft/PowerToys/issues/2136
The change will be available in 0.19.
Closing this as dup of https://github.com/microsoft/PowerToys/issues/2136
Thanks.


cannot pass in spaces with --add-flags with makeBinaryWrapper

Describe the bug
It seems it's impossible to pass argument that contains space with makeBinaryWrapper. With makeShellWrapper it's possible with --add-flags '"a b"'. But makeBinaryWrapper splits it as two arguments "a and b".
User @gerg-l:matrix.org on matrix proposed to add --add-flag to bypass split by space on --add-flags.
I'm guessing it might be @Gerg-L?
Steps To Reproduce
I've made a derivation for testing:

default.nix
{ stdenv, writeTextFile, makeBinaryWrapper  }:

stdenv.mkDerivation {
  name = "example";

  src = writeTextFile {
    name = "example.c";
    text = ''
      #include <stdio.h>

      int main(int argc, const char const * argv[])
      {
        for (int i = 0; i < argc; i += 1) {
          puts(argv[i]);
        }
      }
    '';
  };
  dontUnpack = true;

  nativeBuildInputs = [ makeBinaryWrapper ];

  buildPhase = ''
    gcc $src -o example
  '';

  installPhase = ''
    install -D example -t $out/bin/
    wrapProgram $out/bin/example --add-flags '"a b"'
  '';

}

shell.nix
with import <nixpkgs> {};

let
  example = pkgs.callPackage ./default.nix {};

in
pkgs.mkShell {
  packages = [ example ];
}

Run with nix-shell --run example.
Expected behaviour
It should be possible to add/append spaces as arguments to wrapped program.
Notify maintainers

Add a :+1: reaction to issues you find important.

Yup it was me

Basically this is a limitation when we don't use __structuredAttrs.
See #114044 for a similar issue.

Hmm, we could add --add-flag as a workaround for now, but maybe it's better to wait for https://github.com/NixOS/nixpkgs/pull/318614.

Can you give an example of why this would be useful?

Whenever you need to overwrite some cli arguments and those arguments contain spaces.
E.g. of arguments that could contain spaces are space-delimited lists or shell commands.

Basically this is a limitation when we don't use __structuredAttrs

i don't understand how __structuredAttrs would matter at all here
maybe when using wrapGApps, but not when using raw wrapProgram in the postInstall

You're right, it doesn't matter for the current implementation. Though, with structuredAttrs we could implement makeWrapper differently, using derivation arguments. E.g.
stdenv.mkDerivation {
...
wrapPrograms = [
  {
    path = "bin/example";
    addFlags = [ "--cmd" "foo bar" ];
  }
];
}


Stabilize the JSON format

Is your feature request related to a problem? Please describe.
We are using noseyparker as part of a 'defect dojo' secret tracking and discovery process. We use the jsonl format, but it seems to change arbitrarily between even minor versions.  This causes us to have to modify our parser scripts (for defect dojo) since our unit tests fail when the JSON format changes.
Describe the solution you'd like
Can we stabilize the json format or agree to only change it on x versions? This would make derivitave works or programs having a 'stable' base upon which to build.
Describe alternatives you've considered
Perhaps 'we change the json format every .2 or .4 increments of a new version? Or an 'odd vs 'even' which gives us some stability on the JSON format?
Additional context
Just to note this is a GREAT project and we really appreciate the work you are doing!

P.S. @munntjlx out of curiosity, are your defect dojo parser scripts proprietary, or are they part of the DefectDojo project?

THey will eventually be part of the main project. Tanvi is working on these which we hope to mainline once they get around to importing the parser.

From: Brad Larsen @.***>
Sent: Monday, 11 December 2023 15:23
To: praetorian-inc/noseyparker
Cc: Munn, Thomas (LNG-RDU); Mention
Subject: Re: [praetorian-inc/noseyparker] Stabilize the JSON format (Issue #101)
*** External email: use caution ***
P.S. @munntjlxhttps://github.com/munntjlx out of curiosity, are your defect dojo parser scripts proprietary, or are they part of the DefectDojo project?
—
Reply to this email directly, view it on GitHubhttps://github.com/praetorian-inc/noseyparker/issues/101#issuecomment-1850829752, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALVIUB34Y7IJJORMBAIYIMLYI5TSJAVCNFSM6AAAAABAQJLZRWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJQHAZDSNZVGI.
You are receiving this because you were mentioned.Message ID: @.***>

Anyway, aside from trying hard to not change the JSON output between releases, the place to start with stabilization is to write a schema and validate against that (at least in testing): #72.

@munntjlx there are more changes to the JSON report coming in the next release (#122). Some fundamentals have changed in the Nosey Parker data model that require some visible changes to the JSON report format.
I'm hoping that these changes are the last major ones, and that future format changes will be infrequent and involve only adding new fields.
I'm also hoping to put together a JSON Schema definition of the report format for the next release. This should help both with documentation of the format and also help with identifying changes of that format.

Thanks for the heads up. We have been standardizing on 'specific' versions to help reduce the workload associated with schma changes. A json schema would go a long way for helping us to 'stabilize' final version formats.
Thomas

From: Brad Larsen @.***>
Sent: Friday, 16 February 2024 18:43
To: praetorian-inc/noseyparker
Cc: Munn, Thomas (LNG-RDU); Mention
Subject: Re: [praetorian-inc/noseyparker] Stabilize the JSON format (Issue #101)
*** External email: use caution ***
@munntjlxhttps://github.com/munntjlx there are more changes to the JSON report coming in the next release (#122https://github.com/praetorian-inc/noseyparker/pull/122). Some fundamentals have changed in the Nosey Parker data model that require some visible changes to the JSON report format.
I'm hoping that these changes are the last major ones, and that future format changes will be infrequent and involve only adding new fields.
I'm also hoping to put together a JSON Schema definition of the report format for the next release. This should help both with documentation of the format and also help with identifying changes of that format.
—
Reply to this email directly, view it on GitHubhttps://github.com/praetorian-inc/noseyparker/issues/101#issuecomment-1949491394, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALVIUB5GML6JQKGXZ7WNCBLYT7VJ7AVCNFSM6AAAAABAQJLZRWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBZGQ4TCMZZGQ.
You are receiving this because you were mentioned.Message ID: @.***>

Our Noseyparker decoder has been added to Defect Dojo Main Project. Probably need to get it beyond v0.16

Additions would be preferable!

From: Brad Larsen @.***>
Sent: Thursday, 7 March 2024 16:57
To: praetorian-inc/noseyparker
Cc: Munn, Thomas (LNG-RDU); Mention
Subject: Re: [praetorian-inc/noseyparker] Stabilize the JSON format (Issue #101)
*** External email: use caution ***
Describe the solution you'd like
Can we stabilize the json format or agree to only change it on x versions? This would make derivitave works or programs having a 'stable' base upon which to build.
Possible changes to the JSON format will become less frequent as Nosey Parker becomes more mature.
Though I'm not going to promise not to change the JSON format at this point, I will provide an updated JSON schema and an announcement in the release notes when this does happen. The JSON schemas between versions could be diffed to understand what has changed. (You can get the JSON schema from the v0.17.0 releaseshttps://github.com/praetorian-inc/noseyparker/releases/v0.17.0, or using the new noseyparker generate json-schema command.)
I don't have any changes that I want to make to the JSON format at the moment. I suspect that future modifications to it would be in the form of additional data rather than renaming fields or changing its organization.
—
Reply to this email directly, view it on GitHubhttps://github.com/praetorian-inc/noseyparker/issues/101#issuecomment-1984570543, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALVIUBYHESE7Y6ZZA24G7ILYXDPD3AVCNFSM6AAAAABAQJLZRWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBUGU3TANJUGM.
You are receiving this because you were mentioned.Message ID: @.***>


Body sometimes remains partially transparent after leaving water tiles

Description
Pretty much as it says on the tin. When leaving water tiles, sometimes other players still see your lower body as partially transparent - as if it was still obscured by the water. Players seeing your lower body as transparent do not have to witness you entering or leaving the pool for the effect to be apparent.
Reproduction

Enter a water tile, and move around for a bit.
Leave the water tile and have a friend tell you what they see. (sometimes requires a few tries)

There seems to be a higher success rate if you leave the water tile from a different direction than you entered. For example, entering the pool from the north and leaving from the west.
As an aside, I'm somewhat curious if this could also affect a character's whole body if you get slipped in a pool...
Screenshots

Additional context
None available at this time.

dupe #21165

Thanks for the heads up! Our difference in how we typed the title made searching for it... not very fruitful. I'll close this one in lieu of the other.


Add basic arithmetic to several textboxes

Let users enter basic arithmetic in textboxes, and convert them on_gui_confirm. (Instead of instantly confirming the dialog when doing so). Applies to the item picker, beacon total, maybe others.
Will not allow me to use the vanilla numeric textfields, will have to implement those checks myself again, which is annoying. A better solution might be to have a button that brings up a small calculator that you can use right in there. Might be fun to do.

Implemented for 2.0


[ja] Translate tasks/administer-cluster/migrating-from-dockershim into Japanese

resolve #31249

The changes already got reviewed.
https://github.com/kubernetes/website/pull/31250
This PR is to solve the conflict.

/label tide/merge-method-squash

/assign @inductor

in this case, you can just do rebase and force-push because you're working on your own fork
/assign
/approve

/cc @riita10069

@inductor
Could you give a lgtm if the change is OK to you.

/lgtm


chore: update to hickory =0.25.0-alpha.4

Description
Update hickory to 0.25.0-alpha.4 and try to get the code to compile again. Hopefully the API won't change that much from this to the next non-alpha release 0.25 https://github.com/hickory-dns/hickory-dns/issues/2206#issuecomment-2511154019 .
Breaking Changes
None
Notes & open questions
Note: we still trigger cargo-deny because of the swarm-discovery crate: https://github.com/rkuhn/swarm-discovery/blob/master/Cargo.toml#L20
I guess even once we have merged this we still have to add an exemption to the deny.toml
Is the usage of the new API correct, specifically regarding the new LookupControlFlow enum.
It seems from the doc that I should just take the existing code and wrap it in LookupControlFlow::Continue?

/// Result of a Lookup in the Catalog and Authority
///
/// * **All authorities should default to using LookupControlFlow::Continue to wrap their responses.**
///   These responses may be passed to other authorities for analysis or requery purposes.
/// * Authorities may use LookupControlFlow::Break to indicate the response must be returned
///   immediately to the client, without consulting any other authorities.  For example, if the
///   the user configures a blocklist authority, it would not be appropriate to pass the query to
///   any additional authorities to try to resolve, as that might be used to leak information to a
///   hostile party, and so a blocklist (or similar) authority should wrap responses for any
///   blocklist hits in LookupControlFlow::Break.
/// * Authorities may use LookupControlFlow::Skip to indicate the authority did not attempt to
///   process a particular query.  This might be used, for example, in a block list authority for
///   any queries that **did not** match the blocklist, to allow the recursor or forwarder to
///   resolve the query. Skip must not be used to represent an empty lookup; (use
///   Continue(EmptyLookup) or Break(EmptyLookup) for that.)
pub enum LookupControlFlow<T, E = LookupError> {
    /// A lookup response that may be passed to one or more additional authorities before
    /// being returned to the client.
    Continue(Result<T, E>),
    /// A lookup response that must be immediately returned to the client without consulting
    /// any other authorities.
    Break(Result<T, E>),
    /// The authority did not answer the query and the next authority in the chain should
    /// be consulted.
    Skip,
}

Change checklist

[ ] Self-review.
[ ] Documentation updates following the style guide, if relevant.
[ ] Tests if relevant.
[ ] All breaking changes documented.

FWIW I created https://github.com/rkuhn/swarm-discovery/pull/10


Testing new CDN endpoint changes

This change is temporary; this CDN URL will be deleted after testing.

Cool, that works.


Gatling 3 - NoSuchMethodError io.gatling.core.Predef$.csv

I'm currently using Gatling 3.1.3 which is the latest version and I tried to update my performance tests to have the latest changes.  Did mvn clean install and the build is success.
When running the tests It gives error at the ".feed". Below is the error:
Error:
Exception in thread "main" java.lang.NoSuchMethodError: io.gatling.core.Predef$.csv(Ljava/lang/String;CLio/gatling/core/config/GatlingConfiguration;)Lio/gatling/core/feeder/SourceFeederBuilder;
Can you please help me fix the issue.
Below is the code:
import scala.concurrent.duration._
import io.gatling.core.Predef._
import io.gatling.core.structure.ScenarioBuilder
import io.gatling.http.Predef._
val rolesAccessKeySample: ScenarioBuilder = scenario("Access key authentication")
.feed(csv("access-keys.csv"))
.exec(localModeSupport)
.repeat(Iterations) {
exec(http("get roles")
.get(resolveUrl("security", "roles", "NEP_IDENTITY_VIEWER")))
.pause(1 second, 3 seconds)
}
Key Changes:
Updated my pom to use 3.1.3 version for gatling-core, gatling-app and gatling-http. Also added async-http-client with version 2.10.0.
Thank you

You must clean in order to properly recompile.

Thanks for the quick reply. I did mvn clean and then a mvn clean install.
But still getting the error at .feed . Exception in thread "main" java.lang.NoSuchMethodError: io.gatling.core.Predef$.csv(Ljava/lang/String;CLio/gatling/core/config/GatlingConfiguration;)Lio/gatling/core/feeder/SourceFeederBuilder;

Please provide a full maven project sample.

Sure, here is my sample project.
sample.zip

This is not a sample, this is a large internal project that seams to be generating Gatling code on the fly.
Please provide a simple sample.

Yes its a large project, but just executing a simple simulation and it gives error at the
.feed(csv("access-keys.csv")) with below error:
Exception in thread "main" java.lang.NoSuchMethodError: io.gatling.core.Predef$.csv(Ljava/lang/String;CLio/gatling/core/config/GatlingConfiguration;)Lio/gatling/core/feeder/SourceFeederBuilder;
I knew it was some dependency error,  that is why I shared my whole maven project, so that you can help me fix that issue.

I ran mvn clean compile test-compile and it compiled just fine.

Thanks again. But as told before no compilation errors. It is when running the tests.

You've built your own custom platform to generate Gatling tests. I have no idea how it works but the problem is on your side.

:-), I got you. But the error is coming only after I upgraded from gatling version 2.3.0 to 3.1.3. So only reached here.

Really, we from GatlingCorp can't help with an internal custom platform.
Moreover, there's a good chance the features it has are covered in FrontLine.

i met a similar problem that caused by i got version conflict of gatling, i have both 3.0.3 and 3.1.2 in one project.


Prep Orders Ops Fulfillment Refactor

Issue #178 built the documentation to support a future release in support of the Orders Ops Fulfillment Refactor.
When the refactor is released, we'll need to move the docs built by #178 to the current docs.  Build examples of the request/response for each api.  And, refactor the  _config.yml an _includes/filtered_collections.html files to remove the future release.

Superceded by #182


add ncumul_tests from bag

On the daily "Situationsbericht zur epidemiologischen Lage in der Schweiz und im Fürstentum Liechtenstein" PDF of the BAG one finds the number of total tests up to today. To my knowledge this number is not available anywhere else and also the PDF itself is not archived.
I am archiving the German version of the PDF since March 31st and could restore via web.archive.org all PDFs since March 25th, the day of the first publication of the number of tests. (on the 27th only the French version was archived)
All PDFs are in this Dropbox folder together with the Excel files containing the "Daten des Situationsberichtes" which is published together with the "Situationsbericht".
I think it would be interesting to add the total number of tests and maybe also the positive percentage to the data set and maybe to archive the PDFs and Excel files.
For example for some reason the daily number of tests went down from over 6500 last week to about 4500 this week.
Gregor
The numbers from the PDFs
Date        | Tests     | Positive [%]
25-03-20 |   84000 | 12
26-03-20 |   91400 | 14
27-03-20 |   97012 | 12
28-03-20 | 106000 | 12
29-03-20 | 111000 | 13
30-03-20 | 116700 | 13
31-03-20 | 123150 | 13
01-04-20 | 130700 | 15
02-04-20 | 139330 | 15
03-04-20 | 145780 | 15
04-04-20 | 153440 | 15
05-04-20 | 158000 | 15
06-04-20 | 162500 | 15
07-04-20 | 167429 | 15
08-04-20 | 171938 | 15

FYI. I also have a dump of all PDFs since 2020-03-23 here: https://www.functor.xyz/covid_19b/
In file unique_pdfs.txt you can find a list.

On Wednesday, I received a detailed daily overview of tests, directly from the BAG.
I haven't checked whether these data are consistent with what they publish in their PDFs.
Nonetheless, you can download their Excel sheet right here (never mind the emoji in the URL...):
https://srgssr-my.sharepoint.com/:x:/g/personal/timo_grossenbacher_srf_ch/EQU7Mw27pVdKk6lZ8imEjUcBslzN6VOq0k4OR4KxfAlPPg?e=yFegzZ

More context: https://www.srf.ch/news/schweiz/daten-zur-krise-die-wichtigsten-fragen-und-antworten-zu-den-corona-zahlen

@grssnbchr this is great, thanks for the link to the spreadsheet! Is this being updated by the BAG or by you? And is there a downloadable link somewhere? Are there any limitations with sharing the data? I'd like to include it as a dataset in our covid-19 public data project.

@grssnbchr thank you very much for your article and the link to your data.
The two data sets seem to be somewhat consistent as far as I can tell. At least in order of magnitude and tendency. One can expect some differences since the PDF data probably represents the number of finished tests per day while the data from SRF represents the number of tests started on a given day. However, what surprises me, is that the PDF data seems to be almost consistently larger than the SRF data. Not sure whether this can be explained by the testing delay.

@rokroskar @grbos
As said: I received the Excel that is available for download as is from the BAG on a one-time-basis. I cannot explain the differences to the PDFs either. All information I received is within the Excel, there was no context provided. As far as I know, the BAG does not publish the test frequencies anywhere else. I might ask them again soon, but you're free to do that as well.

I'm closing this issue for now, since we decided not to mix BAG and cantonal data. Feel free to re-open this issue if needed.


getDeviceUUID doesn't work for ZFS

Mount info for ZFS is like this:
tmpfs on /var type tmpfs (rw,nosuid,nodev,noexec,relatime,size=1023524k,mode=755)
testpool/nextnas/containerd-vol on /var/lib/containerd/io.containerd.snapshotter.v1.zfs type zfs (rw,xattr,noacl)
testpool on /var/zpool type zfs (rw,xattr,noacl)
testpool/nextnas on /var/zpool/nextnas type zfs (rw,xattr,noacl)

The pool is not a file on the disk, thus could not be stated.
We need to figure out how to get device UUID for zfs. Or maybe we need admin to pass the UUID to us for zfs if we could not figure it out.

Reopen this issue. According to https://github.com/kubernetes-incubator/cri-containerd/pull/335#issuecomment-336724360, ZFS still doesn't work.
The main problem is that ZFS doesn't have an uuid, because it manages the block/volume itself.
I feel like we should throw out an error and proceeding if we could not get uuid, the only thing won't work is that kubelet can't get image fs capacity. However, we should not block people from trying this out because of that.


Address changes on validateModelManifest() from schematic

address #309

disable great expectation

only get errors - 1st element of output list

rename function params

Do not merge until https://github.com/Sage-Bionetworks/schematic/pull/614 is merged to develop of schematic

Note: this pr has not tested with new cross-validation rules yet. The changes here can make the DCA works as before to address the changes on function validateModelManifest.
To test new cross-validation rule, we would need to add new cross-validation rules to data-model and update DCA codes to display appropriate errors for users. -> it will be saved for another PR, when the error message for cross-validation from schematic is settle.

Ah, I was just poking around to see if you had already solved this new issue in annotation_status, looks like this PR is to address that?

2022-04-28T22:19:16.242590+00:00 shinyapps[5711947]: Warning: Error in validationResult: object 'annotation_status' not found
2022-04-28T22:19:16.242697+00:00 shinyapps[5711947]:   13: fn
2022-04-28T22:19:16.242649+00:00 shinyapps[5711947]:   15: <Anonymous>
2022-04-28T22:19:16.242749+00:00 shinyapps[5711947]:    8: retry
2022-04-28T22:19:16.242783+00:00 shinyapps[5711947]:    7: connect$retryingStartServer
2022-04-28T22:19:16.242816+00:00 shinyapps[5711947]:    6: eval
2022-04-28T22:19:16.242877+00:00 shinyapps[5711947]:    5: eval

@allaway yes, the develop of schematic is recently updated on validation function. To quick fix your issue, you could just add [[1]] at the end of this function. Or you could test with this pr.

Thanks! I will pull in the changes from this PR and let you know how it goes!


Refresh events are dispatched even when unrelated git file is changed

Describe the bug

Given config-server is configured with the spring.cloud.config.server.git.searchPaths to spring-config
And cloud-bus is also configured on the config-server
And gitlab webhook is setup to notify the git repository changes on /monitor path of the config-server
When I change an unrelated file in the git repository (e.g. /docker-compose/docker-compose.yml)
Then config-server dispatches a RefreshRemoteApplicationEvent for the destinations: docker-compose:*:** and docker-compose:*:** [ISSUE]

Expected Result
As the git repository file updated was out of the configured searchPaths, No RefreshRemoteApplicationEvent` should be dispatched.
Suggested Fix
PropertyPathEndpoint.notifyByPath should be updated.  It should filter out the paths retrieved from the PropertyPathNotifiationExtractor which aren't matching the configured searchPaths.

Thanks for the suggested fix, but I doubt we'd be able to match search paths. Maybe there could be a list of regexes to ignore.


Added support for page background

The changes I'm proposing are strictly related to the page-background support

Thank you very much for your contribution!

It was an honour!


[RIP-37] New and unified APIs

This issue aims to track the RIP-37, which try to unify a universal APIs spec for RocketMQ.
What can we benefit from this RIP?

The behavior of interfaces is more clearly defined, making it easier for newcomers to get started, and the behavior of various interfaces is more predictable.
The new APIs unbinds the implementation and interface to realize real interface-oriented programming, and the upgrade cost for users will be lower in the future.
The implementation of polyglot clients has always been a difficult problem, and the lack of a unified specification is one of the important reasons. New specifications allow them to be standardized so that users do not behave inconsistently by switching languages.

or you can view more details from the docs link: https://shimo.im/docs/m5kv92OeRRU8olqX

@aaron-ai Some optimized suggestion about api-module, please take a look.

Create masker interface ErrorClassification, and replace ErrorCode with ErrorClassification in ClientException. I think developer need custom error type, such as limitation;
Replace CompletableFuture with Future in Producer#sendAsync, since Future is more extensibie. the default implementation of Producer#sendAsync still can use CompletableFuture;
Replace  BackoffRetryPolicy with RetryPolicy in ProducerBuilder#setRetryPolicy .

Describe in Chinese
您好，关于 api-module 有些建议请评估是否采纳：

创建标记接口ErrorClassification、并使ErrorCode实现该接口，ClientException中ErrorCode替换为ErrorClassification。因为我认为开发者经常需要自定义异常和异常类型，例如限流，而现在的接口设计其实也支持用户自定义异常；
在Producer#sendAsync中使用Future替换CompletableFuture，因为前者已经可以满足接口需要，我们可以再具体实现中在返回CompletableFuture；
在ProducerBuilder#setRetryPolicy中使用RetryPolicy替换 BackoffRetryPolicy。

@aaron-ai Some optimized suggestion about api-module, please take a look.

Create masker interface ErrorClassification, and replace ErrorCode with ErrorClassification in ClientException. I think developer need custom error type, such as limitation;
Replace CompletableFuture with Future in Producer#sendAsync, since Future is more extensibie. the default implementation of Producer#sendAsync still can use CompletableFuture;
Replace  BackoffRetryPolicy with RetryPolicy in ProducerBuilder#setRetryPolicy .

Describe in Chinese
您好，关于 api-module 有些建议请评估是否采纳：

创建标记接口ErrorClassification、并使ErrorCode实现该接口，ClientException中ErrorCode替换为ErrorClassification。因为我认为开发者经常需要自定义异常和异常类型，例如限流，而现在的接口设计其实也支持用户自定义异常；
在Producer#sendAsync中使用Future替换CompletableFuture，因为前者已经可以满足接口需要，我们可以再具体实现中在返回CompletableFuture；
在ProducerBuilder#setRetryPolicy中使用RetryPolicy替换 BackoffRetryPolicy。

Thanks for your suggestion, here is my opinion:

Yes, as you say, error code may be added frequently, what's more, the new APIs is intend to unify both of RemotingCommand-based client and gRPC-based client #3949 , we need a looser structure to define error code here, so the existing design may be updated in subsequent pull request, welcome to be involved in the code review :)
CompletableFuture may be essential, which allows users add their callback easily.
In most case, BackoffRetryPolicy is enough, so we are not sure about that whether it is time to replace BackoffRetryPolicy by RetryPolicy now, a customized RetryPolicy which is not well-designed may be harmful to the server side, which is we are worried about. The design of BackoffRetryPolicy is refer to gRPC, and has undergone a long-term practice.

Thanks for your reply, there is already a pr for these suggestion #4134. If some work is already done, please ignored #4134.

CompletableFuture may be essential, which allows users add their callback easily.

Return Future will not stop developers use callback in CompletableFuture because CompletableFuture is a implementation of Future. but return a concret CompletableFuture will affect the extensibility of the interface —— You must accept both pros and cons, such as async timeout, and it is hard to extend CompletableFuture.

In most case, BackoffRetryPolicy is enough.

If BackoffRetryPolicy could satify developers, I think RetryPolicy will be redundant. The reason I think RetryPolicy is better is that Developers will always want to change maxAttempts.
Describe in Chinese
感谢回复，针对这些建议当前已经有了一个pr、见#4134，如果有相关的代码已经实现或者正在进行中则请忽略该PR。

CompletableFuture may be essential, which allows users add their callback easily.
返回Future并不影响开发者在后续处理中使用CompletableFuture中提供的回调方法、因为开发者可以在具体的视线中返回Futrue的实现类CompletableFuture。但是返回具体的类将会影响该接口的可扩展性、也意味着我们必须同时接受CompletableFuture的优缺点、例如异步超时机制在jdk1.9才出现、而该特性对于超时发送也许会很重要；

In most case, BackoffRetryPolicy is enough.

如果BackoffRetryPolicy已经能够应对各种场景那RetryPolicy的定义似乎有些多余？
我认为RetryPolicy使用比较恰当的原因是开发者总是想动态的修改maxAttempts(比如通过redis或者公司各种配置平台配置系统的一些关键参数)。nextAttemptDelay同理。

返回 Future 并不影响开发者在后续处理中使用 CompletableFuture 中提供的回调方法、因为开发者可以在具体的实现中返回 Futrue 的实现类 CompletableFuture。

Could you provide an example to add callback or convert Future to CompletableFuture if there is a method for message publishing like this?
Future<SendReceipt> sendAsync(Message message);

About the RetryPolicy, actually it is not public, which means it is not exposed to users, maxAttempts could also be modified in BackoffRetryPolicy, but we may reconsider that if it is reasonable enough to keep RetryPolicy in this module.

Not convert Future to CompletableFuture, but implements #sendAsync(Message) which return CompletableFuture.
Describe in Chinese
并非将Future转换成CompletableFuture，而是在Producer中实现#sendAsync(Message)方法的时候将返回结果修改为CompletableFuture，甚至Future任意的实现，例如返回 guava-ListenableFuture 已使用jdk8的CompletableFuture中没有的特性。
public interface Producer {

    ......

    Future<SendReceipt> sendAsync(Message message);

}

public class DefaultProducer {

    ......

    CompletableFuture<SendReceipt> sendAsync(Message message){
               // 具体的实现，CompletableFuture 其逻辑的确依赖
           ......
    }

}

Actually we considered about ListenableFuture, unfortunately it doesn't belong to the standard library. On the other side user will use Producer#sendAsync to publish message directly rather than DefaultProducer#sendAsync in their programs, so the implementation is not the scope of APIs discussion.


Add Room Media API Calls

Second Pull Request with Room API Calls authored by @nalin29

After we figure out that comment on getAudioDevices/getVideoDevices we should be good to merge!

Should I rebase and squash all commits together, or is this fine

Should I rebase and squash all commits together, or is this fine

This is fine, it'll all be squashed by GitHub on merge


WIP: Higher level calibration function

Description
This PR renames the phasor_calibrate function to phasor_transform and adds the higher level function phasor_calibrate for easier calibration.
Tests and tutorials are missing, so do not merge yet.
...
Release note
Summarize the changes in the code block below to be included in the
release notes:
```Add higher level function phasor_calibrate and rename old one to phasor_transform
...

## Checklist

- [ ] The pull request title, summary, and description are concise.
- [ ] Related issues are linked in the description.
- [ ] New dependencies are explained.
- [ ] The source code and documentation can be distributed under the [MIT license](https://www.phasorpy.org/stable/license.html).
- [ ] The source code adheres to [code standards](https://www.phasorpy.org/stable/contributing.html#code-standards).
- [ ] New classes, functions, and features are thoroughly [tested](https://www.phasorpy.org/stable/contributing.html#tests).
- [ ] New, user-facing classes, functions, and features are [documented](https://www.phasorpy.org/stable/contributing.html#documentation).
- [ ] New features are covered in tutorials.
- [ ] No files other than source code, documentation, and project settings are added to the repository.

Hi @cgohlke, I created this PR so we can start discussing the approach of the higher level function phasor_calibrate. I haven't done the corresponding tests yet, but wanted to share beforehand to see if you consider the approach correct.
Particularly, I have questions with the optional arguments passed to other functions, such as phasor_from_lifetime and phasor_center. I left the option to pass them as kwargs, but I don't know if this is the best approach since they won't be directly visible when using phasor_calibrate. They would have to go to the documentation of those functions and I don't think is optimal. Maybe add something in the docstring of phasor_calibrate regarding those optional kwargs? What do you think.

I think the split into higher level phasor_calibrate and lower level phasor_transform functions make a lot of sense.

I have questions with the optional arguments passed to other functions, such as phasor_from_lifetime and phasor_center. I left the option to pass them as kwargs, but I don't know if this is the best approach

This is a recurring issue.
I think in this case of few parameters forwarded to functions within the same library, the use of kwargs should be avoided. Instead, explicitly list the parameters and repeat the documentation. That way the user does not have to look up documentation elsewhere and can use hints from the IDE. Also MyPy can verify the types.
In other cases, for example, when forwarding many possible parameters to matplotlib functions, it does not make sense to list and document those parameters again.

also renamed the phase0 and modulation0 parameters to phase_shift and modulation_ratio as discussed before.

I can't seem to find a link to the previous discussion right now. I don't particular like the phase0 and modulation0 names, and phase_shift and modulation_ratio look nicer. However, I find those confusing, since (1) phase and modulation are practically always phase shifts and modulations relative to something, and (2) the phase shift and relative modulation in this case are very specific to calibration. In formulas (I am aware of), the phase shift and relative modulation used for calibration are usually denoted as φ0 and M0, hence I chose phase0 and modulation0. In the past I used phase_zero and modulation_zero. Maybe we can discuss and settle this in Monday's meeting?

We mentioned it in #32, but I agree that it may be confusing using phase_shiftand modulation_ratio because they are also used in other context, altough they look nicer and also are easier to understand what they mean. phase_zeroand modulation_zero can be a good approach. I prefer them to phase0and modulation0.
Maybe if we add some math equations to the docstring it can be more visual what phase_zeroand modulation_zeroare and we can use those names.
I agree, lets discuss on monday.

Should it be the already calculated real and imag for the image to be calibrated and reference, as it as of now, or should it be the signals

I think the function should accept phasor coordinates, which are the central "data structure" of this library. Some file formats (REF, R64, IFLI) do not contain signals but phasor or polar coordinates. At some point we will add high level io functions that return phasor coordinates.

That's a good Idea, having higher level io functions that call phasor_calibrate and maybe can have an option to already return the calibrated phasor coordinates if desired. I like that approach much better as this allows greater versatility in phasor_calibrate

higher level io functions that call phasor_calibrate and maybe can have an option to already return the calibrated phasor coordinates if desired.

Sorry, that's not really what I meant. Usually, signals of reference measurements are in separate files and that will require separate io and calibration steps. Some file formats like R64, IFLI, FLIF already contain referenced data or contain calibration information. Only in those cases the phasor coordinates will be returned calibrated. Otherwise they need to be calibrated, which I would keep separate, something like:
mean, real, imag, frequency = io.phasor_from_ptu(filename)
mean_ref, real_ref, imag_ref, _ = io.phasor_from_ptu(filename_ref)
real, imag = phasor_calibrate(real, imag, real_ref, imag_ref, frequency, lifetime, ...)

Re phasor_calibrate documentation: how about adding a note or an example that it is a convenience function for:
phasor_transform(
    real,
    imag,
    *polar_from_reference_phasor(
        *phasor_center(
            reference_real,
            reference_imag,
            skip_axes,
            method,
        ),
        *phasor_from_lifetime(
            frequency,
            lifetime,
            fration,
            preexponential,
            unit_conversion,
        ),
    ),
)

@cgohlke I added the tests and modified the introduction tutorial. I think this is ready for review, but there may be some aspects to improve.

I will review this later today.

This is almost ready. Can you pull in the recent changes from main?

I am getting some errors in testing, I believe is with the fetch datasets, but I am not sure.

You can follow the "Details" links next to the failed test runs and see exactly what failed. There's also an option to re-run failed checks.

I just noticed that the skip_axes parameter is missing from phasor_calibrate. Is that intentional?
It would be nice to have a tutorial using a real world dataset that can demonstrate this and other advanced features of the new phasor_calibrate function. I'm not aware of any suitable dataset though.

I missed the skip_axes parameter, you are right. I will fix this in a PR.
It would be great to have an interesting dataset that we can use for this. We could generate an suitable dataset here but we can only get .fbd files, which are not so good for a tutorial I think. But we can have something and look for files from another lab with access to other hardware.

I think a small, multi-harmonic FDB dataset might be OK for this. The skip_axes parameter could be used on the harmonics, no? Maybe I am missing something. Anyway, it is not urgent, just something to keep track of...


Added tests to home page

I've noticed that there is a test ExampleTest.php which should be named HomeTest.php since it has a tests for home page. There are only 2 commits in this PR

Renamed ExampleTest.php to HomeTest.php
Added 2 more tests to HomeTest.php

first test is checking that home page is accessible for auth user
second test is checking if home page is accessible for admin

We should test every page for 3 cases, for guest, auth and admin. Because sometimes page is working for guest but throws error for auth user.

Agree, I'll make an issue and take care of it tomorrow :)


Proposal: new service resource type

Sometimes a build task requires some "service" to be run in the "background" (aka detached container). Currently the only resource type that runs this way is a compose resource. So to provide a service to another build task you have to create a Compose file.
Docker 1.12 added the concept of a Swarm mode service. It would be good to add a new resource type which starts these services, so that it's not necessary to create a Compose file just to get a single service.

I like this idea, as currently in my pipeline I depend on docker-compose run --rm service-name command stuff to do things like run unit tests, especially for containers that depend on other services (like redis in another container, or even other services in the same repository). With dobi currently I can't quite make this work.

to do this we need to bump docker on Circle.
And CIrcle is slow https://discuss.circleci.com/t/docker-1-12-availability/6849

So when? The main question.

@dnephin So what does stop you Daniel from implementing this, a free time? Well do you mind to be funded for this work and if yes - what would be estimated effort approximately? Or maybe we can hire someone to get things done?


iwasm command Exception

The problem is that i use the AOT mode to run a *.aot file, it did NOT work! @wenyongh sir
My Computer Info(MacOS):
Darwin MacBook-Pro-4.local 20.6.0 Darwin
Kernel Version 20.6.0: Wed Jun 23 00:26:31 PDT 2021;
root:xnu-7195.141.2~5/RELEASE_X86_64 x86_64

CPU
2.3 GHz 8-Core Intel Core i9

My steps are below:

Create a file test.c with content:

#include <stdio.h>
#include <stdlib.h>

int main(int argc, char **argv)
{
    char *buf;

    printf("Hello world!\n");

    buf = malloc(1024);
    if (!buf) {
        printf("malloc buf failed\n");
        return -1;
    }

    printf("buf ptr: %p\n", buf);

    sprintf(buf, "%s", "1234\n");
    printf("buf: %s", buf);

    free(buf);
    return 0;
}

Compile test.c into test.wasm using emcc command below:

emcc test.c -o test.wasm

Run test.wasm using command wasmer——a wasm runtime, as below:

wasmer test.wasm

it's ok. and the output is
Hello world!
buf ptr: 0x500e58
buf: 1234

Run iwasm command with file test.wasm

iwasm test.wasm // or ./wasm test.wam

But it's NOT ok, the output is
[04:54:26:303 - 11C60CE00]: warning: failed to link import function (wasi_snapshot_preview1, fd_close)
[04:54:26:334 - 11C60CE00]: warning: failed to link import function (wasi_snapshot_preview1, fd_write)
[04:54:26:337 - 11C60CE00]: warning: failed to link import function (wasi_snapshot_preview1, fd_seek)
[04:54:26:339 - 11C60CE00]: warning: failed to link import function (wasi_snapshot_preview1, args_sizes_get)
[04:54:26:341 - 11C60CE00]: warning: failed to link import function (wasi_snapshot_preview1, args_get)
[04:54:26:343 - 11C60CE00]: warning: failed to link import function (wasi_snapshot_preview1, proc_exit)
Exception: lookup the entry point symbol (like main, _main, __main_argc_argv) failed

Try to compile test.wasm to test.aot using wamrc, and my command is

wamrc -o test.o test.wasm

then error is
Create AoT compiler with:
  target:        x86_64
  target cpu:    skylake
  cpu features:
  opt level:     3
  size level:    3
  output format: AoT file

Error: invaid llvm binary bin_type.

What should I do in order to use AOT mode with wamrc

The problem is that i use the AOT mode to run a *.aot file, it did NOT work! @wenyongh sir
My Computer Info(MacOS):
Darwin MacBook-Pro-4.local 20.6.0 Darwin
Kernel Version 20.6.0: Wed Jun 23 00:26:31 PDT 2021;
root:xnu-7195.141.2~5/RELEASE_X86_64 x86_64

CPU
2.3 GHz 8-Core Intel Core i9

Run iwasm command with file test.wasm

iwasm test.wasm // or ./wasm test.wam

But it's NOT ok, the output is
[04:54:26:303 - 11C60CE00]: warning: failed to link import function (wasi_snapshot_preview1, fd_close)
[04:54:26:334 - 11C60CE00]: warning: failed to link import function (wasi_snapshot_preview1, fd_write)
[04:54:26:337 - 11C60CE00]: warning: failed to link import function (wasi_snapshot_preview1, fd_seek)
[04:54:26:339 - 11C60CE00]: warning: failed to link import function (wasi_snapshot_preview1, args_sizes_get)
[04:54:26:341 - 11C60CE00]: warning: failed to link import function (wasi_snapshot_preview1, args_get)
[04:54:26:343 - 11C60CE00]: warning: failed to link import function (wasi_snapshot_preview1, proc_exit)
Exception: lookup the entry point symbol (like main, _main, __main_argc_argv) failed

Hi, the LIBC-WASI isn't enabled on darwin platform by default, could you please build iwasm with:
cmake .. -DWAMR_BUILD_LIBC_WASI=1

and rebuild gain?

Try to compile test.wasm to test.aot using wamrc, and my command is

wamrc -o test.o test.wasm

then error is
Create AoT compiler with:
  target:        x86_64
  target cpu:    skylake
  cpu features:
  opt level:     3
  size level:    3
  output format: AoT file

Error: invaid llvm binary bin_type.

What should I do in order to use AOT mode with wamrc

Not sure how you build wamrc, do you build it with cmake .. -DWAMR_BUILD_PLATFORM=darwin?
If wamrc doesn't work again, can you please try wamrc --target-abi=gnu -o test.aot test.wasm? Thanks.

Yes, i build wamrc with shell below:
cd wamr-compiler
./build_llvm.sh (or "./build_llvm_xtensa.sh" to support xtensa target)
mkdir build && cd build
cmake .. (or "cmake .. -DWAMR_BUILD_PLATFORM=darwin" for MacOS)
make
# wamrc is generated under current directory

And still, wamrc --target-abi=gnu -o test.aot test.wasm cause error:
Create AoT compiler with:
  target:        x86_64
  target cpu:    skylake
  cpu features:
  opt level:     3
  size level:    3
  output format: AoT file
Error: invaid llvm binary bin_type.

event i build wamrc with cmake ..  -DWAMR_BUILD_PLATFORM=darwin agagin

use cmake .. -DWAMR_BUILD_LIBC_WASI=1 well
iwasm test.wasm runs ok

Hi, normally we use wamrc under Ubuntu/Windows or other Linux systems, I uploaded a patch, could you please patch it, rebuid wamrc and test again?
wamrc_macos.zip

git apply wamrc_macos.diff

   if (arch) {

   if (abi) {

       /* Construct target triple: <arch>-<vendor>-<sys>-<abi> */

       const char *vendor_sys;

       char *arch1 = arch, default_arch[32] = { 0 };

       if (!arch1) {

           char *default_triple = LLVMGetDefaultTargetTriple();

           if (!default_triple) {

               aot_set_last_error("llvm get default target triple failed.");

               goto fail;

           }

           vendor_sys = strstr(default_triple, "-");

           bh_assert(vendor_sys);

           memcpy(default_arch, default_triple, vendor_sys - default_triple);

           arch1 = default_arch;

           LLVMDisposeMessage(default_triple);

       }

       if (!strcmp(abi, "msvc")) {

           if (!strcmp(arch1, "i386"))

               vendor_sys = "-pc-win32-";

           else

               vendor_sys = "-pc-windows-";

       }

       else {

           vendor_sys = "-pc-linux-";

       }

       bh_assert(strlen(arch1) + strlen(vendor_sys) + strlen(abi)

                 < sizeof(triple_buf));

       memcpy(triple_buf, arch1, strlen(arch1));

       memcpy(triple_buf + strlen(arch1), vendor_sys, strlen(vendor_sys));

       memcpy(triple_buf + strlen(arch1) + strlen(vendor_sys), abi,

               strlen(abi));

       triple = triple_buf;

   }

   else if (arch) {

it did NOT work either.

@jackiealex did you add --target-abi=gnu for wamrc after applying the patch? e.g. wamrc --target-abi=gnu -o test.aot test.wasm or wamrc --target-abi=gnu --disable-simd -o test.aot test.wasm?

@jackiealex did you add --target-abi=gnu for wamrc after applying the patch? e.g. wamrc --target-abi=gnu -o test.aot test.wasm or wamrc --target-abi=gnu --disable-simd -o test.aot test.wasm?

Thanks, it works well, i just use aot mode to test performance, and which meets my expectations


Fix halofit issue at small scale factor a

This PR aims to solve the issue identified by @jecampagne in #77
We will prevent the computation of non-linear scales from returning negative numbers.

I have started by adding a new test, which should fail, next step is to implement the fix

Yep, the test returns NaNs, so correctly captures the issue, now we just need a fix

Ok so, fun fact, CCL also sucks at halofit when the scale factor becomes too small, it clips non linear scales to some k=100 value. so even at very low a, you don't reach the expected linear power spectrum. Good to know.... I've restricted the test range to a =0.2 where I think CCL works correctly by default.

Ok, so I've added a simple fix, I'm now computing non-linear scales in log space, taking an exponential at the end, this ensures positivity. I also clip to some very small scale, to avoid divergence.
    # Step 1: Finding the non linear scale for which sigma(R)=1
    # That's our search range for the non linear scale
    logr = np.linspace(np.log(1e-4), np.log(1e1), 256)

    # TODO: implement a better root finding algorithm to compute the non linear scale
    @jax.vmap
    def R_nl(a):
        def int_sigma(logk):
            k = np.exp(logk)
            r = np.exp(logr)
            y = np.outer(k, r)
            pk = linear_matter_power(cosmo, k, transfer_fn=transfer_fn)
            g = bkgrd.growth_factor(cosmo, np.atleast_1d(a))
            return (
                np.expand_dims(pk * k ** 3, axis=1)
                * np.exp(-(y ** 2))
                / (2.0 * np.pi ** 2)
                * g ** 2
            )

        sigma = simps(int_sigma, np.log(1e-4), np.log(1e4), 256)
        root = interp(np.atleast_1d(1.0), sigma, logr)
        return np.exp(root).clip(
            1e-6
        )  # To ensure that the root is not too close to zero

@jecampagne could you review this PR :-) ? Let me know what you think?


Set id_retrieved if set_id is present

If set_id is present in the SharedState for promise_base, we can also
safely set id_retrieved_. This avoids a problem within hpxcl.

LGTM


[$250] Migrate FloatingActionButtonAndPopover.js to function component

Class Component Migration
Filenames

[ ] src/pages/home/sidebar/SidebarScreen/FloatingActionButtonAndPopover.js

type: React.Component
has state values: true
has refs: false
has context: false
lifecycle methods: componentDidMount,componentDidUpdate

Task

We currently have some class components in our codebase that we would like to refactor to a function component.
Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
If you need additional guidance, please ask in #expensify-open-source
Test for any regressions and verify that there are no breaking changes

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01866339ed0c2906ce
Upwork Job ID:<PHONE_NUMBER>157169664
Last Price Increase: 2023-06-26

⚠ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

Heads up! The pricing for this issue has been adjusted based on the scope of the work and the fact that no complex bug investigations or proposal are required.

I'd like to work on this issue

I would like to work on this.

@muxriddinmuqimov77 are you still available to pick this up?

I am ready to work on this ticket :)

Offer sent to @abdulrahuman5196 in Upwork, @dayana7204 please apply here https://www.upwork.com/jobs/~01866339ed0c2906ce

Offer sent to @abdulrahuman5196 in Upwork, @dayana7204 please apply here https://www.upwork.com/jobs/~01866339ed0c2906ce

Just sent proposal on upwork.
Let me complete and prepare PR asap.
Thank you again :)

Hi @dayana7204 . Caught up in other issues. Will try to prioritise it today

payments issued:

@dayana7204 - PR $250
@abdulrahuman5196 - PR Review $250


'€' asJSON renders as:  "â¬".

Issue reported by Ivo on the PharoJS slack
'€' asJSON renders as:  "â¬".
I think some unicode escapement is missing

I think a quick fix (if dependency on STON is an option) might be:
WideString>>printJsOn: aStream
STON jsonWriter
on: aStream;
asciiOnly: true;
nextPut: self .
One test fails after this, but the test itself looks strange to me.

I have a working fix, just trying to get it committed.

Committed now.