PowerShell preview entries are not consistent

Brief description of your issue
Follow up from https://github.com/microsoft/winget-pkgs/pull/8623#issuecomment-797654830.
EDIT: Related to https://github.com/microsoft/winget-pkgs/issues/100.
The community have submitted several entries for PowerShell releases, which is awesome.
Unfortunately, the submissions are not consistent, either in the manifest contents/metadata or in the version string of the directory.
Steps to reproduce

Expected behavior
winget entries for PowerShell should be consistent to ensure a good experience for users using winget as an installation vector.
Actual behavior
winget entries for PowerShell vary.
Environment
N/A

Just took a look, the inconsistent manifests versions are from before Manifest Schema 1.0.0 which is why it dosn't match ARP, after diving deeper it seems like you were the one automatically generating manifests based on the marketing version https://github.com/microsoft/winget-pkgs/pull/17879

after diving deeper it seems like you were the one automatically generating manifests based on the marketing version #17879

Yeah that's our automation. Can you explain the "marketing version" vs what's expected? The version we give there is PowerShell's self-reported semver v2 version:

I've been in contact with the winget team around our automation and they didn't seem to indicate any issue.
Ideally I'd like to establish a canonical format for our manifests so that they're all consistent with each other, so I'm happy to learn what the right approach is here.

7.2.0-preview.7 or Powershell 7.2 Preview 7 is the marketing version, whatever is displayed in Windows (Add or Remove Programs/Display Version in Registry) is what we call the real version which winget-cli requires for matching against new versions.
At the same DisplayName and Publisher also needs to match what Windows/ARP sees.

If its Microsoft Employees then we know they don't do quality check or are up to date with the changes.
The more correct Metadata you can provide the better (filling the working Schema fields), i can see that the ShortDescription field which certain websites uses are broken in the older manifests, however those websites will pull the metadata from the latest manifest.

is what we call the real version which winget-cli requires for matching against new versions

I see, sounds like we'll need to reuse some logic to map from PowerShell's versions to Windows file versions.

At the same DisplayName and Publisher also needs to match what Windows/ARP sees.

Can you elaborate on what you're referring to by ARP here? Where does the requirement about matching fields come from?

If its Microsoft Employees then we know they don't do quality check or are up to date with the changes.

Thanks for the feedback.

i can see that the ShortDescription field which certain websites uses are broken in the older manifests (because of the Schema v1.0.0 update), however those websites will pull the metadata from the latest manifest.

I didn't follow you here. Looking through the manifests that are currently checked in, I don't see any URLs other than some references to the PowerShell GitHub repository, which I'm fairly sure are live links. Certainly the ShortDescription fields seem to be populated with just a short package name.

Talk to @denelon

Yeah, I have an internal thread with the winget team to try and understand the situation here better.

We have schemas and docs, but it is honestly easiest to look at the existing examples there.  Of course, there might be other fields that they don’t have, so you can check the docs and schemas.
The PackageName and Publisher fields in the locale manifest are used to match with the DisplayName and Publisher values from the ARP (Add/Remove Programs) registry entries.  You can see from OfficialEsco's comment where those are located in the registry.  These are the same values that will be displayed in the Add/Remove Programs UI on Windows.  We prefer these to match exactly if possible, if only for consistency.  However, it is not uncommon for the DisplayName to include details that we encode elsewhere, and thus it can be difficult to have an exact match.  For instance, PowerShell is putting the architecture in the DisplayName, likely because it is not exposed to the user anywhere else and both could be installed, leading to confusion in ARP if it is not present.
There is a normalization algorithm applied to both strings, so certain portions of the name can be omitted in the manifest.  It is a rather complicated set of regexes though, but removing things like versions and architectures is part of it.  We should probably expose a way for the client to spit that information out to make sure it matches and easier process...
There are other fields that we can correlate on as well, and more that we are planning to add in the future.  The most relevant one that you can use right now is the ProductCode; this GUID value comes from the MSI and lets us bypass the name and publisher match, but is version specific.

So I've had a user raise an issue in https://github.com/PowerShell/PowerShell/issues/14583#issuecomment-888118788 that they can't install PowerShell-Preview in the de-DE locale. That feels related to the current structure our manifests, but I'm not sure I understand the locale element here well enough to know what to change.

A locale provides additional Metadata/matching possibility if it appears differently in ARP when installed in another language.
The default locale (en-US) should contain the default Product Name and global tags such as cross-platform and foss, a non default locale can contain Unicode characters so its easier to discover the software in different languages.
The issue:
winget install --name PowerShell-Preview --exact
No package found matching input criteria.

winget show -?

The following options are available:
  -m,--manifest  The path to the manifest of the package
  --id           Filter results by id
  --name         Filter results by name
  --moniker      Filter results by moniker
  -v,--version   Use the specified version; default is the latest version
  -s,--source    Find package using the specified source
  -e,--exact     Find package using exact match
  --versions     Show available versions of the package

@mi-hol is attempting to install PackageName: PowerShell-Preview which is case sensitive and does not exsist
You can install Powershell Preview with
winget install PowerShell-Preview
winget install PowerShell-Preview --exact
winget install "PowerShell Preview"
winget install "PowerShell Preview" --exact
winget install Microsoft.PowerShell.Preview
winget install Microsoft.PowerShell.Preview --exact
winget install --name "PowerShell Preview"
winget install --name "PowerShell Preview" --exact
winget install --id Microsoft.PowerShell.Preview
winget install --id Microsoft.PowerShell.Preview --exact
winget install --moniker powershell-preview
winget install --moniker powershell-preview --exact
winget install pwsh

Ah that's very helpful, thanks @OfficialEsco!

winget install pwsh (or not really since Powershell stable also uses this)

Hmmmm, preview should really be pwsh-preview I think. That's how it's intended to be exposed on the command line. But if winget is focused on the MSI, and the MSI installs a pwsh.exe (which we alias through a cmd script), then maybe we can't do that?

You can add pwsh-preview to either one of these and it will work
https://raw.githubusercontent.com/microsoft/winget-cli/master/schemas/JSON/manifests/v1.0.0/manifest.installer.1.0.0.json

Commands: List of commands or aliases to run the package

https://raw.githubusercontent.com/microsoft/winget-cli/master/schemas/JSON/manifests/v1.0.0/manifest.defaultLocale.1.0.0.json

Tags: List of additional package search terms

I am marking this external for powershell to resolve.  winget is not taking any action on this issue perse.  Yell if I got that wrong.


Faq Personal data update

Update related to issue #1729. Replaced list of data inputs with link to privacy policy.

https://www.coronawarn.app/en/faq/#personal_data

https://www.coronawarn.app/de/faq/#personal_data

Internal Tracking ID: EXPOSUREAPP-12410

I suggest to convert the hyperlinks to relative i.e. remove the https://www.coronawarn.app and remove the rel='noopener noreferrer' which is not necessary for internal links.
Check out https://www.coronawarn.app/en/faq/#have_to_use for an example of another FAQ article which refers to the Privacy notice using a relative link.

I agree this is a good idea. Let me make those changes on my end and I can push another round of commits.

Apologies if I did something out of order but the latest commit captures @MikeMcC399 's suggestion and it is ready for review.

@ahodzic2

The end result of your changes now look fine! 👍🏻

Here are just some additional points to consider:

In the Contributing Guide we are asked to squash commits after making corrections.

Your branch is out of date with the base (master) branch.

You would need to update your fork's copy of the master branch, rebase on this, squash your commits, then force push to your FAQ-Data-Update branch on GitHub.

Note that @dsarkar wrote in https://github.com/corona-warn-app/cwa-website/issues/1729#issuecomment-1076223553 "we would appreciate a PR after going live with the new FAQ website (today)." however the PR for the FAQ (which is https://github.com/corona-warn-app/cwa-website/pull/2434) has been delayed due to technical issues and it has not yet been merged.

Some optional points:

I would suggest editing the title from "FAQ data update" to "FAQ personal data update" as the original title is a little vague.

It is helpful for checking to include the URLs, which will be changed, in the original post i.e.

https://www.coronawarn.app/en/faq/#personal_data
https://www.coronawarn.app/de/faq/#personal_data

@ahodzic2

The end result of your changes now look fine! 👍🏻

Here are just some additional points to consider:

In the Contributing Guide we are asked to squash commits after making corrections.
Your branch is out of date with the base (master) branch.
You would need to update your fork's copy of the master branch, rebase on this, squash your commits, then force push to your FAQ-Data-Update branch on GitHub.
Note that @dsarkar wrote in personal_data FAQ entry is outdated #1729 (comment) "we would appreciate a PR after going live with the new FAQ website (today)." however the PR for the FAQ (which is FAQ page rework #2434) has been delayed due to technical issues and it has not yet been merged.

Some optional points:

I would suggest editing the title from "FAQ data update" to "FAQ personal data update" as the original title is a little vague.

It is helpful for checking to include the URLs, which will be changed, in the original post i.e.

https://www.coronawarn.app/en/faq/#personal_data
https://www.coronawarn.app/de/faq/#personal_data

Thank you @MikeMcC399 for the feedback! I reviewed those contributing guide previously but I think I may have confused myself when actually creating the PR and pushing commits. I don't think I am able to squash the commits at this point as there is a merge commit as I rebased before making the updates. Additionally, the rebase option is no longer available at this point as it says there are merge conflicts.
I did a fetch with my forked version of master and that had nothing else to pull in. Any idea how I can proceed from here? I am using Github Desktop.
Apologies for the beginner questions. I very much appreciate your guidance and tips for how to improve moving forward :)

@ahodzic2

I don't think I am able to squash the commits at this point as there is a merge commit as I rebased before making the updates. Additionally, the rebase option is no longer available at this point as it says there are merge conflicts.
I did a fetch with my forked version of master and that had nothing else to pull in. Any idea how I can proceed from here? I am using Github Desktop.

GitHub Desktop is limited in functionality. To rebase you need to use the CLI version of git.
There are a couple of ways to tackle this:

git rebase master FAQ-Data-Update-work will throw a merge conflict, however if you use an editor you can resolve the conflict and continue the rebase

Another way is to use git reset to move the HEAD back to before your first commit. You can then recommit your changes.

If that is unclear or you need some more detailed help, then please ask.

@ahodzic2
I just looked at the effect of the new FAQ site which was merged this morning and it introduces some major changes into the FAQ source files which cause conflicts in this PR if you try to merge them. That was the reason that @dsarkar advised you to wait before submitting a PR.
Let me look at how you might sort this out. I think it might be possible, but it is more an academic exercise. The simplest solution would be to close this PR and open a new one based on the updated master branch from this morning.
One thing you could do in any case is to update your master branch locally and in your fork:
git switch master
git fetch upstream
git merge upstream/master
git push origin

assuming that you are using standard naming for "upstream" and "origin".

@ahodzic2
I think it is simplest to close this PR and submit a new PR based on the new master. Otherwise you will need to make a lot of manual corrections to resolve the conflicts. You can't simply cherry-pick your changes unfortunately.

@ahodzic2 I think it is simplest to close this PR and submit a new PR based on the new master. Otherwise you will need to make a lot of manual corrections to resolve the conflicts. You can't simply cherry-pick your changes unfortunately.

Thank you so much for the details @MikeMcC399! I'll look to close this PR, make sure I have the most up to date master and then make the changes under a new PR. I noticed that the contributing guide suggests keeping commits as independent as possible, so do you recommend two commits (1 for faq and one for fag_de) or do you think these can go under the same commit?

@ahodzic2

do you recommend two commits (1 for faq and one for fag_de) or do you think these can go under the same commit?

One commit is fine. You can look at closed PRs to see how other contributors have done this in the past. In general, if an article is being corrected at the same time in English and German it will be one commit. Sometimes if a new article is being written and it is first available in one language, you might find one commit for one language followed by a later commit for the other language.


error: numpy 1.19.0 is installed but numpy<1.19.0,>=1.16.0 is required by {'tensorflow'}

Attempted fresh install with
$ python setup.py install

leads to
error: numpy 1.19.0 is installed but numpy<1.19.0,>=1.16.0 is required by {'tensorflow'}

I could do an install by adding requirements for numpy
  install_requires=[
        'numpy<=1.18.0',
        'pandas',
        'tensorflow>=2.0.0',
        "ensmallen_graph>=0.2.5"
    ],

Since this error does not lead to broken installations nor it stops the pip install process I would suggest we just leave the requirement for "numpy".

Closing this issue as deprecated in the new version of Embiggen. Please feel free to reopen as need be.


[Box2D] Clarity + Consistency improvements

This is mainly for clarity and consistency within itself and other extensions. This extentions specifically gets a lot of questions i'll try to hopefully alleviate with better worded blocks.

change "setup stage <>" to "set stage boundaries to <>" makes it more clear that this is just setting bounds
add "to" back to the older physics properties properties (set bounce <>) is now (set bounce to <>)
the confusing "touching <>" block is now a much more clear "list sprites touching <>"
added "to" to the set scroll block for internal consistency and global consistency

The documentation should be updated along eventually.


Kanb board Setup

In this project we did initial setup for our kanb board we are two in our capstone group:
https://github.com/users/obed300/projects/7

Hi team,
STATUS: CHANGES REQUIRED ♻ ♻
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights

Kanban board has been well set-up ✔ ✔
All tasks have been fairly assigned 👍 👍
All tasks have a description and title 👏

Required Changes ♻

According to the project requirements, each requirement should have at least one corresponding card in the Kanban board. I cannot find a card for this requirement. Make sure there are no N+1 queries happening. Please fix this 👍
According to the project requirements, I suggest you attach this pts as a suffix to each of the number of points/hrs required for each card, please fix this 👍 👍 .
Check the comments under the review.

Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@mckent05  Thank you we updated the change

Hi Team,
Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉
Highlights 💯

Descriptive info ✔
Tasks distributed equally ✔

Optional suggestions
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


Local pull request success status testing

Docs Build status updates of commit d504e41:
:clock10: Pending: waiting for processors (13 builds ahead of you)
:warning: Docs Build is busy, currently there are 13 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit d504e41:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

E2E_DocsBranch_Dynamic/index.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


deserialize [package.metadata] and [workspace.metadata] tables

Uses the cargo_toml metadata tables to enable getting workspace and package metadata.
Current specification:
[package.metadata.cargo-semver-checks]
one = "major"  # override lint "one"'s required semver update to `major`, keeping the lint level default
two = "deny"  # override "two"'s lint level to `deny`, leaving the required semver update default
three = { lint-level = "warn" }  # more verbose syntax to override lint level while leaving update default
four = { required-update = "major" }  # more verbose syntax to override required version update
five = { required-update = "minor", lint-level = "allow" }  # override both required semver update and lint level

[workspace.metadata.cargo-semver-checks]
six = "major" # same syntax as above but workspace-level overrides

Considerations:

When we start reading these as config, we will read the configuration from the current-version crate (i.e., --manifest-path).  This makes sense e.g. for running cargo semver-checks before a release, might complicate CI pipelines where you can't edit the manifest file? I'm not sure.
for the Deserialize implementations for RequiredSemverUpdate and LintLevel enums, I added the #[serde(alias = "$name as kebab-case")] instead of doing #[serde(rename_all = "kebab-case")].  This is because we are also deserializing them in the query .ron files, where we use rust enum PascalCasing to specify the enum variant.  This means that e.g., lint = { lint-level = "Deny" } would be valid syntax.
To think about: do we want to specify lint names in the metadata table as Cargo.toml kebab-case or as they currently are in snake_case?

For reviewing: I tried to make a smaller PR - most of the length comes from an added test, starting from line 118 in manifest.rs

Sounds good, thanks for the catch!

The considerations section was very, very helpful btw — nicely done!
I'm not worried about CI pipelines having different config than pre-release right now. If it ends up being a problem later, I'm sure we can figure out some CLI flags or other way around it.
Btw in a near-future PR, it would be great to have some end-to-end test cases over realistic workspaces, where the workspace and the package sections aren't in the same Cargo.toml and yet all the right Cargo.toml files are located, parsed, and applied correctly. Ideally, you'd think through various ways that we might have ended up with buggy implementations, and then come up with scenarios where the test would fail if that bug was present: things like "workspace Cargo.toml is read and applied but package's is not" or vice versa, or where the package's Cargo.toml overrides something the workspace set.
The number of possible "gotchas" there is a bit worrying, so it would be lovely to have lots and lots of thoughtful test coverage there as early as possible.


browserify increasingly slow

What used to be wonderfully quick has gone frustratingly slow.
It is about time to look into how we can speed up our development build times. If nothing else a patch for now and then revisit when updating to gulp 4 which is another pending task

stop parsing a set list of vendor files. exlude another set of fixed vendors and build those into a seperate file.
The later should either be a part of the standard vendor bundle or be included in the custom if it isn't too slow. but at least it is way faster to develop now.


Disappear laser pointer drawings only when the user stopped writing

Laser pointer is a great edition. It enabled to quickly highlight things without disturbing the actual content. But, it disappears quite fast and is difficult to get focus to a point in the canvas. The problem is, even when the user is writing, it starts disappearing from the other end.
https://github.com/excalidraw/excalidraw/assets/186833/c6525a45-34c0-453d-9842-43f89907aa29
The way PPT or some other tools handle is, the laser writing stays as long as you are continuing to write. Once you stop, it waits for few seconds and then disappears.
https://github.com/excalidraw/excalidraw/assets/186833/80253ea8-415a-4f68-8c3e-7b1aaf4f43e0
It would be helpful if the laser pointer writing stays as long as the user is writing and disappear a few seconds after the user stopped writing.

Hey @karuturi this is a pretty great suggestion!
What do you guys reckon? @are @dwelle

interested to work on this!


CI: TestWarmup randomly failed

https://app.travis-ci.com/github/juicedata/juicefs/builds/248777167
=== RUN   TestWarmup
2022/04/01 07:35:36.687875 juicefs[2[5171]()] <INFO>: Meta address: redis://<IP_ADDRESS>:6379/10 [interface.go:383]
2022/04/01 07:35:36.688835 juicefs[25171] <WARNING>: AOF is not enabled, you may lose data if Redis is not shutdown properly. [info.go:84]
2022/04/01 07:35:36.688958 juicefs[25171] <INFO>: Ping redis: 67.915µs [redis.go:2590]
2022/04/01 07:35:36.689710 juicefs[25171] <INFO>: Data use file:///tmp/TestWarmup3219196357/001/test/ [format.go:390]
2022/04/01 07:35:36.690764 juicefs[25171] <INFO>: Volume is formatted as {Name:test UUID:032b6fa9-079d-45f7-88f6-fe8d0b4cdf7d Storage:file Bucket:/tmp/TestWarmup3219196357/001/ AccessKey: SecretKey: BlockSize:4096 Compression:none Shards:0 HashPrefix:false Capacity:0 Inodes:0 EncryptKey: KeyEncrypted:false TrashDays:1 MetaVersion:1 MinClientVersion: MaxClientVersion:} [format.go:423]
2022/04/01 07:35:36.691310 juicefs[25171] <INFO>: Meta address: redis://<IP_ADDRESS>:6379/10 [interface.go:383]
2022/04/01 07:35:36.692247 juicefs[25171] <WARNING>: AOF is not enabled, you may lose data if Redis is not shutdown properly. [info.go:84]
2022/04/01 07:35:36.692479 juicefs[25171] <INFO>: Ping redis: 68.148µs [redis.go:2590]
2022/04/01 07:35:36.693429 juicefs[25171] <INFO>: Data use file:///tmp/TestWarmup3219196357/001/test/ [mount.go:274]
2022/04/01 07:35:36.693603 juicefs[25171] <INFO>: Disk cache (/var/jfsCache/032b6fa9-079d-45f7-88f6-fe8d0b4cdf7d/): capacity (102400 MB), free ratio (10%), max pending pages (15) [disk_cache.go:90]
2022/04/01 07:35:36.694754 juicefs[25171] <INFO>: create session 1 OK [base.go:184]
2022/04/01 07:35:36.695562 juicefs[25171] <INFO>: Prometheus metrics listening on <IP_ADDRESS>:46109 [mount.go:157]
2022/04/01 07:35:36.695704 juicefs[25171] <INFO>: Mounting volume test at /tmp/jfs-unit-test ... [mount_unix.go:172]
2022/04/01 07:35:37.206088 juicefs[25171] <INFO>: OK, test is ready at /tmp/jfs-unit-test [mount_unix.go:45]
16470:M 01 Apr 2022 07:38:56.091 * 100 changes in 300 seconds. Saving...
16470:M 01 Apr 2022 07:38:56.092 * Background saving started by pid 27360
27360:C 01 Apr 2022 07:38:56.096 * DB saved on disk
27360:C 01 Apr 2022 07:38:56.096 * RDB: 0 MB of memory used by copy-on-write
16470:M 01 Apr 2022 07:38:56.192 * Background saving terminated with success
No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#build-times-out-because-no-output-was-received
The build has been terminated

https://app.travis-ci.com/github/juicedata/juicefs/builds/250703080

Recent test shows that it's probably caused by thread scheduling when doing epoll.
The test process calling mount hangs forever. The stacks are:
26272
[<0>] request_wait_answer+0x102/0x210
[<0>] fuse_simple_request+0x1ac/0x2f0
[<0>] fuse_file_poll+0x20b/0x280
[<0>] ep_item_poll.isra.0+0x2f/0x50
[<0>] ep_insert+0x25f/0x550
[<0>] do_epoll_ctl+0x33d/0x640
[<0>] __x64_sys_epoll_ctl+0x61/0xa0
[<0>] do_syscall_64+0x5c/0xc0
[<0>] entry_SYSCALL_64_after_hwframe+0x61/0xcb

and
26283
[<0>] do_epoll_ctl+0x270/0x640
[<0>] __x64_sys_epoll_ctl+0x61/0xa0
[<0>] do_syscall_64+0x5c/0xc0

Syslog shows:
[Wed Sep 14 08:51:47 2022] INFO: task cmd.test:26273 blocked for more than 845 seconds.
[Wed Sep 14 08:51:47 2022]       Not tainted 5.15.0-1019-azure #24~20.04.1-Ubuntu
[Wed Sep 14 08:51:47 2022] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message.
[Wed Sep 14 08:51:47 2022] task:cmd.test        state:D stack:    0 pid:26273 ppid: 14802 flags:0x00000000
[Wed Sep 14 08:51:47 2022] Call Trace:
[Wed Sep 14 08:51:47 2022]  <TASK>
[Wed Sep 14 08:51:47 2022]  __schedule+0x2c2/0x8d0
[Wed Sep 14 08:51:47 2022]  schedule+0x4e/0xc0
[Wed Sep 14 08:51:47 2022]  schedule_preempt_disabled+0xe/0x20
[Wed Sep 14 08:51:47 2022]  __mutex_lock.isra.0+0x20c/0x470
[Wed Sep 14 08:51:47 2022]  __mutex_lock_slowpath+0x13/0x20
[Wed Sep 14 08:51:47 2022]  mutex_lock+0x36/0x40
[Wed Sep 14 08:51:47 2022]  ep_poll+0x14a/0x690
[Wed Sep 14 08:51:47 2022]  ? __fget_light+0xd6/0x100
[Wed Sep 14 08:51:47 2022]  do_epoll_wait+0xba/0xe0
[Wed Sep 14 08:51:47 2022]  do_compat_epoll_pwait.part.0+0x12/0x80
[Wed Sep 14 08:51:47 2022]  __x64_sys_epoll_pwait+0x77/0xc0
[Wed Sep 14 08:51:47 2022]  do_syscall_64+0x5c/0xc0
[Wed Sep 14 08:51:47 2022]  ? do_syscall_64+0x69/0xc0
[Wed Sep 14 08:51:47 2022]  ? syscall_exit_to_user_mode+0x17/0x40
[Wed Sep 14 08:51:47 2022]  ? do_syscall_64+0x69/0xc0
[Wed Sep 14 08:51:47 2022]  ? do_syscall_64+0x69/0xc0
[Wed Sep 14 08:51:47 2022]  entry_SYSCALL_64_after_hwframe+0x61/0xcb

and
[Wed Sep 14 08:49:47 2022] INFO: task cmd.test:26283 blocked for more than 362 seconds.
[Wed Sep 14 08:49:47 2022]       Not tainted 5.15.0-1019-azure #24~20.04.1-Ubuntu
[Wed Sep 14 08:49:47 2022] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message.
[Wed Sep 14 08:49:47 2022] task:cmd.test        state:D stack:    0 pid:26283 ppid: 14802 flags:0x00000000
[Wed Sep 14 08:49:47 2022] Call Trace:
[Wed Sep 14 08:49:47 2022]  <TASK>
[Wed Sep 14 08:49:47 2022]  __schedule+0x2c2/0x8d0
[Wed Sep 14 08:49:47 2022]  schedule+0x4e/0xc0
[Wed Sep 14 08:49:47 2022]  schedule_preempt_disabled+0xe/0x20
[Wed Sep 14 08:49:47 2022]  __mutex_lock.isra.0+0x20c/0x470
[Wed Sep 14 08:49:47 2022]  __mutex_lock_slowpath+0x13/0x20
[Wed Sep 14 08:49:47 2022]  mutex_lock+0x36/0x40
[Wed Sep 14 08:49:47 2022]  do_epoll_ctl+0x270/0x640
[Wed Sep 14 08:49:47 2022]  __x64_sys_epoll_ctl+0x61/0xa0
[Wed Sep 14 08:49:47 2022]  do_syscall_64+0x5c/0xc0
[Wed Sep 14 08:49:47 2022]  ? irqentry_exit_to_user_mode+0x9/0x30
[Wed Sep 14 08:49:47 2022]  ? irqentry_exit+0x1d/0x30
[Wed Sep 14 08:49:47 2022]  ? sysvec_hyperv_stimer0+0x4e/0x90
[Wed Sep 14 08:49:47 2022]  entry_SYSCALL_64_after_hwframe+0x61/0xcb

Tracked in #3105.


No way to load datadir from GCS or S3; how to run a distributed deploy

Hi, my team is getting great results from libpostal (thanks for open-sourcing!), but we're facing some issues in deploying. We're trying to get it to run as part of an existing Google Cloud Dataflow pipeline. The Java code runs fine locally with the datadir installed as a resource using a hardcoded path.
However, in Dataflow, the work is distributed across a number of nodes not known beforehand, which makes passing an absolute path to the datadir hard. (Dataflow also packages our code as a JAR making it even trickier path-wise.)
Ideally we could just put the required datadir in something like GCS, and then read from that when initializing libpostal. This would also reduce duplication of the static files across every worker.
Is there something I'm missing here that would enable this? Is there some way we could read in the contents of datadir and pass it to libpostal? Instead of as an directory absolute filepath?
(Generally it seems like something like this is important for distributed execution using libpostal. I saw a Hadoop issue that solves this by going on each node and installing libpostal with datadir configured; unfortunately that isn't possible here since we don't know the nodes until runtime.)

Tried a workaround by reading the resources as a stream, converting to a temporary file, then getting the path from that, but even that will not work since I assume libpostal requires the files named a specific way.

@albarrentine any tips?

Running it as a service via https://github.com/pelias/libpostal-service looks to be an option...


No license

Looks like this project is missing a license, and since it's a dependency of react-native-track-player and I include licenses in my build, and fail the build when licenses are missing (or not manually added, but I can't find one here to add), my build is broken with the Android rewrite.  Could you add a license to this library?  Thank you!

@austinried LICENSE had been added!

Thank you!


Testing, please ignore. (gxzdoq)

Bug bounty test - please ignore.... Please DO NOT APPROVE THIS! (gxzdoq)

This is not a legitimate commit. Closing for safety


how to run on esp-idf

thank you so much ,do you have a sample on esp-idf？

Hi @hijoh - there are two example folders in examples/esp-idf showing how to use this library with esp-idf (there is a README.md in each directory).
If you run into any specific problems please let us know and we'll do our best to help you out :)

esp-idf5.1,succsessful,thank you!

Hi @hijoh - there are two example folders in examples/esp-idf showing how to use this library with esp-idf (there is a README.md in each directory).
If you run into any specific problems please let us know and we'll do our best to help you out :)

I successfully ran in IDF 5.1 and with GFX. But how can I display Chinese?


Time axes does not function anymore with 3.5.1

My data values have an x=iso date string and y=integer or float. The line chart has a time x axes.
This works ok with chart js 2.9.3. The time values are not recognised in any way using version 3.5.1.
It is also very hard to get hold of the luxon and moment adapters. You are pointed to sources like npm but if you just need to load js files in your html code you get no help at all.
test source code:
<!doctype html>

chart js test 1

<script src="script/chart.min.js"></script>

<script>

const data = {
datasets: [{
data:[{"x":"2021-09-19T07:00:00","y":"509"},{"x":"2021-09-19T07:01:00","y":"507"},{"x":"2021-09-19T07:02:00","y":"512"},{"x":"2021-09-19T07:03:00","y":"519"},{"x":"2021-09-19T07:04:00","y":"521"},{"x":"2021-09-19T07:05:00","y":"379"},{"x":"2021-09-19T07:06:00","y":"278"},{"x":"2021-09-19T07:07:00","y":"257"},{"x":"2021-09-19T07:17:00","y":"436"},{"x":"2021-09-19T07:18:00","y":"439"},{"x":"2021-09-19T07:19:00","y":"420"},{"x":"2021-09-19T07:20:00","y":"444"},{"x":"2021-09-19T07:21:00","y":"423"},{"x":"2021-09-19T07:22:00","y":"444"},{"x":"2021-09-19T07:23:00","y":"420"},{"x":"2021-09-19T07:24:00","y":"416"},{"x":"2021-09-19T07:25:00","y":"430"},{"x":"2021-09-19T07:26:00","y":"422"},{"x":"2021-09-19T07:27:00","y":"434"},{"x":"2021-09-19T07:28:00","y":"418"},{"x":"2021-09-19T07:29:00","y":"432"},{"x":"2021-09-19T07:30:00","y":"427"},{"x":"2021-09-19T07:31:00","y":"426"},{"x":"2021-09-19T07:32:00","y":"428"},{"x":"2021-09-19T07:33:00","y":"423"},{"x":"2021-09-19T07:34:00","y":"419"},{"x":"2021-09-19T07:35:00","y":"434"},{"x":"2021-09-19T07:36:00","y":"416"},{"x":"2021-09-19T07:37:00","y":"422"},{"x":"2021-09-19T07:38:00","y":"436"},{"x":"2021-09-19T07:39:00","y":"435"},{"x":"2021-09-19T07:40:00","y":"441"},{"x":"2021-09-19T07:41:00","y":"427"},{"x":"2021-09-19T07:42:00","y":"437"},{"x":"2021-09-19T07:43:00","y":"403"},{"x":"2021-09-19T07:44:00","y":"405"},{"x":"2021-09-19T07:45:00","y":"413"},{"x":"2021-09-19T07:46:00","y":"416"},{"x":"2021-09-19T07:47:00","y":"428"},{"x":"2021-09-19T07:48:00","y":"434"},{"x":"2021-09-19T07:49:00","y":"389"},{"x":"2021-09-19T07:50:00","y":"391"},{"x":"2021-09-19T07:51:00","y":"291"},{"x":"2021-09-19T07:52:00","y":"294"},{"x":"2021-09-19T07:53:00","y":"272"},{"x":"2021-09-19T07:54:00","y":"283"},{"x":"2021-09-19T07:55:00","y":"283"},{"x":"2021-09-19T07:56:00","y":"299"},{"x":"2021-09-19T07:57:00","y":"273"},{"x":"2021-09-19T07:58:00","y":"300"},{"x":"2021-09-19T07:59:00","y":"296"},{"x":"2021-09-19T08:00:00","y":"241"},{"x":"2021-09-19T08:01:00","y":"251"},{"x":"2021-09-19T08:02:00","y":"373"},{"x":"2021-09-19T08:03:00","y":"377"},{"x":"2021-09-19T08:04:00","y":"343"},{"x":"2021-09-19T08:05:00","y":"353"},{"x":"2021-09-19T08:06:00","y":"330"},{"x":"2021-09-19T08:07:00","y":"311"},{"x":"2021-09-19T08:08:00","y":"311"},{"x":"2021-09-19T08:09:00","y":"331"},{"x":"2021-09-19T08:10:00","y":"314"},{"x":"2021-09-19T08:11:00","y":"323"},{"x":"2021-09-19T08:12:00","y":"325"},{"x":"2021-09-19T08:13:00","y":"318"},{"x":"2021-09-19T08:14:00","y":"320"},{"x":"2021-09-19T08:15:00","y":"328"},{"x":"2021-09-19T08:16:00","y":"328"},{"x":"2021-09-19T08:17:00","y":"1902"},{"x":"2021-09-19T08:18:00","y":"316"},{"x":"2021-09-19T08:19:00","y":"304"},{"x":"2021-09-19T08:20:00","y":"337"},{"x":"2021-09-19T08:21:00","y":"325"},{"x":"2021-09-19T08:22:00","y":"324"},{"x":"2021-09-19T08:23:00","y":"329"},{"x":"2021-09-19T08:24:00","y":"323"},{"x":"2021-09-19T08:25:00","y":"338"},{"x":"2021-09-19T08:26:00","y":"241"},{"x":"2021-09-19T08:27:00","y":"239"},{"x":"2021-09-19T08:28:00","y":"222"},{"x":"2021-09-19T08:29:00","y":"206"},{"x":"2021-09-19T08:30:00","y":"207"},{"x":"2021-09-19T08:31:00","y":"205"},{"x":"2021-09-19T08:32:00","y":"215"},{"x":"2021-09-19T08:33:00","y":"229"},{"x":"2021-09-19T08:34:00","y":"208"},{"x":"2021-09-19T08:35:00","y":"201"},{"x":"2021-09-19T08:36:00","y":"237"},{"x":"2021-09-19T08:37:00","y":"179"},{"x":"2021-09-19T08:38:00","y":"179"},{"x":"2021-09-19T08:39:00","y":"192"},{"x":"2021-09-19T08:40:00","y":"180"},{"x":"2021-09-19T08:41:00","y":"171"},{"x":"2021-09-19T08:42:00","y":"183"},{"x":"2021-09-19T08:43:00","y":"152"},{"x":"2021-09-19T08:44:00","y":"141"},{"x":"2021-09-19T08:45:00","y":"149"},{"x":"2021-09-19T08:46:00","y":"138"},{"x":"2021-09-19T08:47:00","y":"138"},{"x":"2021-09-19T08:48:00","y":"134"},{"x":"2021-09-19T08:49:00","y":"116"},{"x":"2021-09-19T08:50:00","y":"92"},{"x":"2021-09-19T08:51:00","y":"90"},{"x":"2021-09-19T08:52:00","y":"79"},{"x":"2021-09-19T08:53:00","y":"68"},{"x":"2021-09-19T08:54:00","y":"83"}]
}]
};
const config =
{
type: 'line',
data: data,
options:
{
showLine:true,
scales:
{
xAxes:
[{
type: 'time',
time:
{
unit: 'hour',
},
}],
yAxes:
[{
type: 'linear',
tick:
{
source:'data'
},
}]
}
}
};
var myChart = new Chart(
document.getElementById('myChart'),
config
);

<scriptx src="script/moment.js"></scriptx>
<scriptx src="script/chartjs-adapter-moment.min.js"></scriptx>
<script src="script/luxon.js"></script>
<script src="script/chartjs-adapter-luxon.min.js"></script>

Your scale configuration is in v2 format and is not working for v3:

scales.[x/y]Axes arrays were removed. Scales are now configured directly to options.scales object with the object key being the scale Id.

https://www.chartjs.org/docs/next/getting-started/v3-migration.html#specific-changes

It is also very hard to get hold of the luxon and moment adapters. You are pointed to sources like npm but if you just need to load js files in your html code you get no help at all.

Installation instructions are provided by the adapters, for example:
https://github.com/chartjs/chartjs-adapter-luxon#cdn
https://www.npmjs.com/package/chartjs-adapter-luxon

The referenced adapter pages show how to load from a CDN. If you want to host the js files yourself then using the CDN link in the browser address bar will give you the minified code on screen. Then it is up to you to copy/paste into a js file. There is no proper download link for the js files.

The CDN link in the adapter instructions page refers to a version that is not present.
I tried the CDN links without version and changed the configuration to v3 format again and this time I could get it to work with  luxon. I will try again to get a local copy of luxon and the adapter.
I support issue #9605 that states that the chart samples are not very helpfull. In the samples that I looked at for a time axes the data values were all prepared using a custom Utils function and tick labels were pre-generated. In real life you get a series of data points and you have to work with them as they are.

Closing as the original issue was resolved.


fix(docker) Update base image to slim-bullseye

Description
After an update to the python3.XX-slim base images, Gunicorn has problems creating threads. However python3.XX-slim-bullseye does not.
Added
Changed

base image from python:3.10-slim to python:3.10-slim-bullseye

Steps to consider while deploying

Configuration changes:
Documentation updates:
Inform users by email:

Review:

[ ] Code approved by
[ ] Tests executed on stage by:  (Document the test done with screen shots and description.)
[ ] "Merge and deploy" approved by

This version is a:

[ ] MAJOR - when you make incompatible API changes
[ ] MINOR - when you add functionality in a backwards compatible manner
[ ] PATCH - when you make backwards compatible bug fixes or documentation/instructions

Closing since I'm unable to make tests work


Edits by peers produce a prosemirror transaction that spans the entire document

Checklist

[x] Are you reporting a bug? Use github issues for bug reports and feature requests. For general questions, please use https://discuss.yjs.dev/
[x] Try to report your issue in the correct repository. Yjs consists of many modules. When in doubt, report it to https://github.com/yjs/yjs/issues/

Describe the bug
When a remote peer makes a change (types a single letter, for example), other peers receive this update as a prosemirror transaction that replaces the entire document content. This happens at https://github.com/yjs/y-prosemirror/blob/2d06ece86f8359b14e9f6b27bb5746e2ca2efc82/src/plugins/sync-plugin.js#L385.
This makes it very hard for prosemirror plugins to manage their state in state apply functions. For example, when such an update occurs, tr.mapping.map(oldPos) will always point at the end of the entire document (except 0, which maps to 0).
y-prosemirror manually fixes the main consequence of this (that the current text selection/cursor location would otherwise be lost) with restoreRelativeSelection, but any prosemirror plugins that need to deal with positions in the document cannot use standard prosemirror mechanisms for tracking shifts in position.
One of the major consequences of this is that any plugins that compute decorations will have to recompute all that state any time a peer makes a single letter change. We have a custom spellcheck plugin that suffers from this, and other plugins like TipTap's syntax highlighting plugin also suffer - any time a peer makes a change, all code blocks most recompute their entire syntax highlighting because the prosemirror transaction from y-prosemirror spanned and replaced the entire document, preventing correlation of the old nodes to the new ones. For large documents and on devices with limited CPU (e.g. mobile), this causes very significant performance issues.
To Reproduce

Open two editors using y-prosemirror. E.g. https://tiptap.dev/ - refresh until both browsers are in the same room.
Open devtools in one browser, put a breakpoint anywhere that receives prosemirror transactions. E.g. in some plugin's state apply function.
Type a letter in the other browser. You may have to continue past peer cursor position change transactions.
On the transaction that represents the remote peer's minor change, observe that tr.mapping.map() produces useless results for any input value, and that the single step in the transaction replaces the entire document content rather than surgically updating the single text node that actually changed.

Expected behavior
y-prosemirror commits updates received from the Yjs doc as precise, surgical updates rather than replacing the entire document.
Screenshots

Environment Information

Chrome
Yjs version:

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>

I am able to tentatively resolve this by integrating https://github.com/sueddeutsche/prosemirror-recreate-transform to calculate the specific diffs between the incoming yjs update and the current prosemirror doc. Of course, it would be better if this could be computed directly from the yjs transaction in the same manner that it is computed when going from prosemirror => yjs:
diff --git a/node_modules/y-prosemirror/src/plugins/sync-plugin.js b/node_modules/y-prosemirror/src/plugins/sync-plugin.js
index 2a83da1..c5f0f78 100644
--- a/node_modules/y-prosemirror/src/plugins/sync-plugin.js
+++ b/node_modules/y-prosemirror/src/plugins/sync-plugin.js
@@ -382,8 +382,38 @@ export class ProsemirrorBinding {
       transaction.changedParentTypes.forEach(delType)
       const fragmentContent = this.type.toArray().map(t => createNodeIfNotExists(/** @type {Y.XmlElement | Y.XmlHook} */ (t), this.prosemirrorView.state.schema, this.mapping)).filter(n => n !== null)
       // @ts-ignore
-      let tr = this._tr.replace(0, this.prosemirrorView.state.doc.content.size, new PModel.Slice(new PModel.Fragment(fragmentContent), 0, 0))
-      restoreRelativeSelection(tr, this.beforeTransactionSelection, this)
+
+      // BEGIN https://github.com/yjs/y-prosemirror/issues/113
+      const { recreateTransform } = require("@technik-sde/prosemirror-recreate-transform");
+      let tr = this._tr;
+      const newContent = new PModel.Fragment(fragmentContent)
+      const newDoc = this.prosemirrorView.state.schema.node("doc", {}, newContent);
+
+      let transform = recreateTransform(
+        this.prosemirrorView.state.doc,
+        newDoc,
+        {
+            complexSteps: true, // Whether step types other than ReplaceStep are allowed.
+            wordDiffs: false, // Whether diffs in text nodes should cover entire words.
+            simplifyDiffs: true // Whether steps should be merged, where possible
+        }
+      );
+      for (const step of transform.steps) {
+        tr = tr.step(step)
+      }
+
+      // Safety check: Make sure that `recreateTransform` did the right thing.
+      // If there's a diff, fall back on the old behavior of y-prosemirror and replace the whole content.
+      const diffStart = newContent.findDiffStart(tr.doc.content)
+      if (diffStart !== null) {
+        console.error("recreateTransform produced a possibly incorrect transform. Falling back on old behavior.");
+
+        tr = this._tr.replace(0, this.prosemirrorView.state.doc.content.size, new PModel.Slice(new PModel.Fragment(fragmentContent), 0, 0))
+        restoreRelativeSelection(tr, this.beforeTransactionSelection, this)
+      }
+      // END https://github.com/yjs/y-prosemirror/issues/113
+
+
       tr = tr.setMeta(ySyncPluginKey, { isChangeOrigin: true })
       if (this.beforeTransactionSelection !== null && this._isLocalCursorInView()) {
         tr.scrollIntoView()

Any update on this? The prosemirror-recreate-transform approach seems like the only current solution. Is there a better approach?

Previously discussed in the community here, https://discuss.yjs.dev/t/decorationsets-and-remapping-broken-with-y-sync-plugin/845/4


Optimizations to check multiple histories

I use porcupine to check for linearizability in FizzBee's autonomous testing framework.
I have a large number of histories to validate, and I'm considering making this part of continuous build.
Since the model is fixed, we'll be checking different executions, there's a good chance the initial subsequence has a lot of duplicates.
Besides improving the model (in my case, the state graph is generated upfront and loaded in memory), are there any easy to maintain optimization possible to check large number of histories?
It could be batch mode - create 1000's of histories and check once or incremental.

I haven't thought about supporting a batch mode or incremental checking. I suspect it will be nontrivial.
Do you know if this is necessary for your use case? Or does the baseline Porcupine end up being fast enough?
If it doesn't complicate the implementation too much, and if it demonstrates substantial improvement for certain use cases, I would welcome a pull request that implements such functionality.

Thanks Anish. I agree, this will be non trivial. I just asked so in case you or someone had thought about some optimizations.
At present it found bugs, but more histories we could evaluate more confident we could be. For running in continuous builds, throughput is more important than latency of a single check.


Add preview caching

Previews will be cached in the cache (with an expiration date set for 48 hours) so that we can avoid unnecessary re-renders.

Merging since if it doesn't work, it won't inhibit any functionality.


Support target="_blank" for <router-link>

@fnlctrl I absolutely forgot about this, sorry

@posva Totally forgot this too 😂😂😂
I think I'll just wait for Evan to get back to this.

@yyx990803 , hello you da, but how can i do it in the instance, like this:
this.$router.push({name: 'users.index', target: '_blank'})

If it's supported you should update this line.


Undefined symbols _iconv

Hi @JDevlieghere
I have followed the build steps in the README. cmake .. works fine. When I run cmake --build . I get the following:
[ 53%] Built target ebc
[ 57%] Linking CXX executable ebctest
Undefined symbols for architecture x86_64:
"_iconv", referenced from:
_xmlIconvWrapper in libxml2.a(encoding.o)
"_iconv_close", referenced from:
_xmlFindCharEncodingHandler in libxml2.a(encoding.o)
_xmlCharEncCloseFunc in libxml2.a(encoding.o)
"_iconv_open", referenced from:
_xmlFindCharEncodingHandler in libxml2.a(encoding.o)
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [test/ebctest] Error 1
make[1]: *** [test/CMakeFiles/ebctest.dir/all] Error 2
make: *** [all] Error 2
But iconv appears to be installed:
which iconv
/usr/local/bin/iconv
Have I not done something correctly here? I appreciate any help you can offer!
Thank you!

Hi Wayne,
Are you building on OSX and did you use Homebrew to install libxml2? If not, what operating system are you using?
The issue is related to the statically linked version of libxml2, which LibEBC prefers to use over the dynamically linked one. If libxml2 was configured to use iconv or libz, you respectively need the linker flags -liconv and -lz. Normally CMake takes care of that through PC_LIBXML_STATIC_LIBRARIES (see CMakeLists.txt).
Can you try removing your build folder and running CMake again with the additional flag -DBUILD_SHARED_LIBS=False.
Cheers,
Jonas

Hi Jonas,
Many thanks. I really appreciate your detailed response.
Yes, I am building on OSX and, yes, I did use Homebrew to install libxml2. When I added the additional flag DBUILD_SHARED_LIBS=False, everything worked great.
Cheers & thanks again!
Wayne


summary_separator doesn't work with //

I am sure it worked once, but I can't accurately give you the version number since I've upgrade middleman-blog several times and just found this issue today.

Hiya,
Thanks for sending in the your report. To further aid in finding the issue can you please supply either a full repository that mimics your issue. Or at least a GIST of the config.rb file and an explanation on what steps to take to replicate this
Thank you.

I have just tested this
  # Separator
  blog.summary_separator = /<!-- more -->/

In blog post - article.html.markdown
Add a separator into the mix into this blog so we can see what <!-- more -->happens with the
separator
Output
Summary
Add a separator into the mix into this blog so we can see what
Can you let me know versions and file names / extensions please


feat(CategoryTheory/Sites): locally bijective morphisms of presheaves

Let C a category equipped with a Grothendieck topology J. Let A be a concrete category. In this file, we introduce a type-class J.WEqualsLocallyBijective A which says that the class J.W (of morphisms of presheaves which become isomorphisms after sheafification) is the class of morphisms that are both locally injective and locally surjective (i.e. locally bijective). We prove that this holds iff for any presheaf P : Cᵒᵖ ⥤ A, the sheafification map toSheafify J P is locally bijective. We show that this holds under certain universe assumptions.

[x] depends on: #13318

Thanks!
bors merge

How often will this be used? Is it worth adding a new abbrev Presheaf.IsLocallyBijective J f := Presheaf.IsLocallyInjective J f ∧ Presheaf.IsLocallySurjective J f ?

We could do it, but as IsLocallyInjective/Surjective are type-classes, I would rather not introduce this abbreviation. Lemmas typically use the local injectivitity or the local surjectivity, but not that many use both assumptions.


Need to tell runUnitTests how to find libgrt.dylib (OS X).

I get the following error when running runUnitTests:
dyld: Library not loaded: @executable_path/../Frameworks/libgrt.dylib
  Referenced from: /Users/mellis/Source/ESP/./runUnitTests
  Reason: image not found
Trace/BPT trap: 5

It looks like this can be fixed by telling runUnitTests where to find libgrt.dylib:
install_name_tool -change @executable_path/../Frameworks/libgrt.dylib Xcode/ESP/libgrt.dylib runUnitTests

But I'm not sure how to tell cmake to insert this into the Makefile. @nebgnahz: any ideas?

Fixed.

The idea is to run a custom command (install_name_tool) after build (see POST_BUILD argument).
Although I am not sure how the path ../Framework/libgrt.dylib is added to the build process...

Thanks! It seems to work now. The ../Framework/libgrt.dylib is something I've been doing manually, although I recently added it to the https://github.com/damellis/ESP/blob/master/update-xcode-grt.sh script. It's needed for the ESP executables built with Xcode to find the grt.


chore(deps): update terraform-module

This PR contains the following updates:

Package
Type
Update
Change

terraform-ibm-modules/cos/ibm (source)
module
minor
7.1.4 -> 7.5.1

terraform-ibm-modules/resource-group/ibm (source)
module
patch
1.1.4 -> 1.1.5

terraform-ibm-modules/secrets-manager-secret-group/ibm (source)
module
patch
1.1.3 -> 1.1.4

terraform-ibm-modules/secrets-manager/ibm (source)
module
minor
1.1.4 -> 1.2.1

Release Notes

terraform-ibm-modules/terraform-ibm-cos (terraform-ibm-modules/cos/ibm)
v7.5.1
Compare Source
Bug Fixes

Don't output bucket name until it exists (#559) (697ccc3)

v7.5.0
Compare Source
Features

added support for bucket-name-suffix in fscloud and bucket module (#550) (f00db98)

v7.4.3
Compare Source
Bug Fixes

usage example fscloud readme (#547) (b7d555e)

v7.4.2
Compare Source
Bug Fixes

deps: update terraform-module (#544) (68d58ec)

v7.4.1
Compare Source
Bug Fixes

extend the required terraform version to < 1.7 (#541) (a75748c)

v7.4.0
Compare Source
Features

added new outputs bucket_region, cos_instance_name and cos_instance_crn (#540) (c6d7455)

v7.3.2
Compare Source
Bug Fixes

deps: update terraform-module (#536) (44224c6)

v7.3.1
Compare Source
Bug Fixes

deps: update terraform terraform-ibm-modules/cbr/ibm to v1.18.1 (#534) (8dcdde9)

v7.3.0
Compare Source
Features

added support to create a single site bucket using new variable single_site_location(#514) (dc9711e)
added the ability to set force_delete for bucket deletion (#514) (dc9711e)
added the ability to set hard_quota (#514) (dc9711e)

v7.2.2
Compare Source
Bug Fixes

delay before using auth policy which is required as a workaround for this provider issue. NOTE: Upgrades from earlier to version to this version may show a time_sleep.wait_for_authorization_policy being deleted if they are skipping authorisation policy creation. This is expected, since there is no need to delay if the authorisation policy already exists. (#518) (472a353)

v7.2.1
Compare Source
Bug Fixes

updated variable validation for bucket_configs in fscloud submodule (#507) (122c2cf)

v7.2.0
Compare Source
Features

add support for the COS module creating a resource key for IAM only, or a resource key for IAM and HMAC.The following input variables are renamed:- create_hmac_key -> create_resource_key- hmac_key_name -> resource_key_name- hmac_key_role -> resource_key_role A new input variable is introduced: generate-hmac-credentialsBy default generate-hmac-credentials is false and an IAM only resource key is created. Change the value to true to generate an IAM and HMAC resource key. Note: This is a change in behavior, previously the default option was to generate an resource key containing both IAM and HMAC keys.When deploying for the first time at this level, everything is deployed as expected on the first apply.When upgrading and requiring the IAM and HMAC resource key, the upgrade sequence should be to two deploys. The first deploy should rename existing properties. Then apply. Then add generate-hmac-credentials = true. Then apply. During the first apply some new terraform_data resources are created, during the second deploy the resource key is upgraded in place.When upgrading and requiring an IAM only resource key, the upgrade sequence may not remove the HMAC key from resource key in the state file; but the IAM key is still present. This will correct itself later, or to force the removal; add generate-hmac-credentials = true. Then apply. Then remove generate-hmac-credentials and apply again. Both applies will be upgrade in place. (#506) (f5db77c)

v7.1.5
Compare Source
Bug Fixes

made resource_group_id optional, as its only required when create a COs instance (not required for bucket creation). resource_group_id has also been removed as an option in the bucket_configs variable for the buckets submodule. (#513) (4622158)

terraform-ibm-modules/terraform-ibm-resource-group (terraform-ibm-modules/resource-group/ibm)
v1.1.5
Compare Source
Bug Fixes

extend the required terraform version to < 1.7 (#581) (5552c65)

terraform-ibm-modules/terraform-ibm-secrets-manager-secret-group (terraform-ibm-modules/secrets-manager-secret-group/ibm)
v1.1.4
Compare Source
Bug Fixes

extend the required terraform version to < 1.7 (#132) (b8c1942)

terraform-ibm-modules/terraform-ibm-secrets-manager (terraform-ibm-modules/secrets-manager/ibm)
v1.2.1
Compare Source
Bug Fixes

Add missing variable required for ibm catalog onboarding (#61) (c8cf2f5)

v1.2.0
Compare Source
Features

Added Secrets Manager DA to IBM catalog (#54) (98c1073)

v1.1.6
Compare Source
Bug Fixes

deps: update terraform-module (#55) (37d69b2)

v1.1.5
Compare Source
Bug Fixes

update required ibm provider version to < 1.7 (#52) (5dd20e7)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

secret-group 1.2.0 adds the ability to set endpoint type
TestRunUpgradeExample 2024-04-29T15:15:16Z command.go:185: Terraform used the selected providers to generate the following execution
TestRunUpgradeExample 2024-04-29T15:15:16Z command.go:185: plan. Resource actions are indicated with the following symbols:
TestRunUpgradeExample 2024-04-29T15:15:16Z command.go:185:   ~ update in-place
TestRunUpgradeExample 2024-04-29T15:15:16Z command.go:185:
TestRunUpgradeExample 2024-04-29T15:15:16Z command.go:185: Terraform will perform the following actions:
TestRunUpgradeExample 2024-04-29T15:15:16Z command.go:185:
TestRunUpgradeExample 2024-04-29T15:15:16Z command.go:185:   # module.secrets_manager_group.ibm_sm_secret_group.secret_group will be updated in-place
TestRunUpgradeExample 2024-04-29T15:15:16Z command.go:185:   ~ resource "ibm_sm_secret_group" "secret_group" {
TestRunUpgradeExample 2024-04-29T15:15:16Z command.go:185:       + endpoint_type   = "public"
TestRunUpgradeExample 2024-04-29T15:15:16Z command.go:185:         id              = "us-south/79c6d411-c18f-4670-b009-b0044a238667/f128cd9a-91fc-08f7-5509-02ccc2398708"
TestRunUpgradeExample 2024-04-29T15:15:16Z command.go:185:         name            = "sm-secret-module-upg-hdgmn4-group"
TestRunUpgradeExample 2024-04-29T15:15:16Z command.go:185:         # (6 unchanged attributes hidden)
TestRunUpgradeExample 2024-04-29T15:15:16Z command.go:185:     }
TestRunUpgradeExample 2024-04-29T15:15:16Z command.go:185:
TestRunUpgradeExample 2024-04-29T15:15:16Z command.go:185: Plan: 0 to add, 1 to change, 0 to destroy.

skip upgrade test

/run pipeline

Edited/Blocked Notification
Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.
⚠ Warning: custom changes will be lost.

/run pipeline


UWP support

So I suppose this isn't ready for UWP, right :P?

@mcosmin222 Hey! Well, it should be ready for UWP as a native library, as well as MSS. But I'm not sure if it actually is needed on UWP, as FLAC is supported in Windows 10 natively :)


Release Ci pipeline

To me it looks good. Thanks @zeotuan P.S. Can we have a similar one for tsumugi?

Yeah let's me prepare PR

Lest see if we can release a snapshot version with this pr


Adding the various Glue resources

These were introduced on October 24, 2017.
Takes care of https://github.com/cloudtools/troposphere/issues/870.

Looks good. Could you add a copyright and license comment to the beginning similar to the other files? Thanks.

Nice job. Thanks!


fix convertBody for reverse 'http-equiv'

convertBodyfunction work fine when html has this meta tag.
<meta http-equiv="content-type" content="text/html;charset=shift_jis">
However, if the http-equiv attribute is reversed like this, it will not work.
<meta content="text/html; charset=Shift_JIS" http-equiv="Content-Type" />

Codecov Report

Merging #682 into master will decrease coverage by 0.34%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master     #682      +/-   ##
==========================================
- Coverage     100%   99.65%   -0.35%
==========================================
  Files           7        7
  Lines         575      579       +4
  Branches      183      185       +2
==========================================
+ Hits          575      577       +2
- Misses          0        1       +1
- Partials        0        1       +1

Impacted Files
Coverage Δ

src/body.js
98.92% <50%> (-1.08%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47a24a0...2096773. Read the comment docs.

In v3, we are going to be replacing the regex system with an actual parser in Richienb/fetch-charset-detection/src/index.ts#L53 but we can still use this as a band-aid patch if we do eventually make a final release for v2.
I'm adding some unit tests now.

@Richienb  Thank you for your reply.
Added test. I'm sorry if it's misplaced.


Please give permission to use your code.

Hey benno,
due to Apache legal stuff, the apache developer community need your explicit permission that I can use your code. So this is the ticket for that, I will link that in my PR which moves your code to the core code.
So please write clear opinion and permission for me to use your code.
Cheers
Chris

Yes, I allow you to use the code. It is already Apache 2.0 licensed, so it is easier to integrate into Apache NetBeans.
If you like I can also transfer the project to your ownership.

If you like I can also transfer the project to your ownership.

Thx Benno, that would be cool :)

Done


[WINDOWS] Error: Could not get HiyaCFW

Windows 7 x64, 7-zip 19.00 x86, HiyaCFW Helper 3.6.1 (Win)
-Error occurs whether nand.bin is on SD or moved to OS/app drive.
-Error occurs whether running as admin or not.
Wifi connection tests out fine, stock firewall settings, fairly fresh install of Win7 Home with all updates. (All apps were downloaded only minutes prior.)
Time is set correctly and synced with time.windows.com.
Screenshot of error and terminal details:

Follow this steps:
https://community.spiceworks.com/topic/584022-missing-or-invalid-root-certificates-on-windows-7-64bit
If that does not work for you, use the python version including the Windows folder from the Windows release archive

Thanks for the reply. So it turns out that updating the root certificates works, but the method in the article you linked is no longer valid. (Microsoft no longer offers a public link for updroot.exe, and ideally the updated certificates need to be pulled via certutil on a Win10 machine.) Kaspersky has an updated method and a link to the update utility hosted on their servers here: https://support.kaspersky.com/13727
This worked for me, and I was able to run HiyaCFW on that Win7 Home install without the need to install Python. However, I suggest adding a note or reference to the Kaspersky KB article.
...OTOH, maybe this will no longer be relevant after general Win7 support ends next month?
Thanks again.

Hi, great you were able to solve your issue. Hadn't added that to the readme as W7 is ten years old and mostly everybody is using W10 these days. Closing ticket.


File search ignores "include" folders in Fedora 40

Type: Bug
File search does not seem to work for multi-folder exclusion.
See the example below: ./modules/heat/ has been set as the only folder to search (with the correct syntax as far as I can tell...) and yet the search hits files in ./modules/_example_module/.
I've also tried without the ./ at the start, same behavior.

VS Code version: Code 1.92.2 (fee1edb8d6d72a0ddff41e5f71a671c23ed924b9, 2024-08-14T17:29:30.058Z)
OS version: Linux x64 6.10.4-200.fc40.x86_64
Modes:

System Info

Item
Value

CPUs
13th Gen Intel(R) Core(TM) i7-13700H (20 x 3479)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_graphite: disabled_offvideo_decode: enabledvideo_encode: disabled_softwarevulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_offwebnn: disabled_off

Load (avg)
1, 1, 1

Memory (System)
15.25GB (9.01GB free)

Process Argv

Screen Reader
no

VM
0%

DESKTOP_SESSION
gnome

XDG_CURRENT_DESKTOP
GNOME

XDG_SESSION_DESKTOP
gnome

XDG_SESSION_TYPE
wayland

Extensions (28)

Extension
Author (truncated)
Version

markdown-mermaid
bie
1.23.1

catppuccin-vsc
Cat
3.15.1

catppuccin-vsc-icons
Cat
1.15.0

ruff
cha
2024.42.0

vscode-markdownlint
Dav
0.55.0

EditorConfig
Edi
0.16.4

remotehub
Git
0.62.0

vscode-drawio
hed
1.6.6

mypy
mat
0.3.1

rainbow-csv
mec
3.12.0

git-graph
mhu
1.30.0

debugpy
ms-
2024.10.0

python
ms-
2024.13.2024081501

vscode-pylance
ms-
2024.8.1

jupyter
ms-
2024.7.0

jupyter-keymap
ms-
1.1.2

jupyter-renderers
ms-
1.0.19

vscode-jupyter-cell-tags
ms-
0.1.9

vscode-jupyter-slideshow
ms-
0.1.6

remote-ssh
ms-
0.113.1

remote-ssh-edit
ms-
0.86.0

azure-repos
ms-
0.38.0

remote-explorer
ms-
0.4.3

remote-repositories
ms-
0.40.0

autodocstring
njp
0.6.1

vscode-yaml
red
1.15.0

snakemake-lang
sna
0.1.8

even-better-toml
tam
0.19.2

You have comma after ./modules/heat/ so you effectively included any files in that folder, all files with .py & .smk extensions, and Snakefile
If you want to search only in that folder and limit files you should construct single glob AFAIK.
See https://code.visualstudio.com/docs/editor/codebasics#_advanced-search-options
Probably you are looking for something like ./modules/heat/**/{*.py,*.smk,Snakefile}

Ahhhh, that makes sense.
I assumed that searches would be "additive" from left to right. Issue closed!


fix: Support absolute file path for CLI

Summary
(If you have not already please refer to the contributing guideline as described
here)

[ ] Tell us about the problem your pull request is solving.
when I execute npx pinion   /Users/prozhou/playgroud/pinion-gen/generators/ts/gen.tpl.ts, the comand will be npx pinion   /Users/prozhou/playgroud/Users/prozhou/playgroud/pinion-gen/generators/ts/gen.tpl.ts when cmd is  /Users/prozhou/playgroud.
[ ] Are there any open issues that are related to this?
no
[ ] Is this PR dependent on PRs in other repos?
no
If so, please mention them to keep the conversations linked together.

Other Information
If there's anything else that's important and relevant to your pull
request, mention that information here. This could include
benchmarks, or other information.
Your PR will be reviewed by a core team member and they will work with you to get your changes merged in a timely manner. If merged your PR will automatically be added to the changelog in the next release.
If your changes involve documentation updates please mention that and link the appropriate PR in feathers-docs.
Thanks for contributing to Feathers! :heart:

Thank you!


Volumes actions dropdown has nothing in it

Create a container with mysql image
Go to Volumes page
Click on the menu icon for the volume
Results:
nothing in it just a little white box shows up
Expected:
If nothing in menu, then it should be dimmed and un-clickable until the situation where it needs the delete item.

volume page removed


Add debug subcommand

This allows users (inside a GCE VM) to print components of the Attestation Protobuf and MachineState Protobuf
Depends on #248
Signed-off-by: Joe Richey<EMAIL_ADDRESS>

:green_book: MEV SW OD Build #14309 result: SUCCESS

Manifest Name
Build Status
Jenkins Link
Artifacts
Unsuccessful Stages
Description

mmg-trunk
SUCCESS
26418
 Artifacts

mev-trunk
SUCCESS
45719
 Artifacts

mev-ts-trunk
SUCCESS
51302
 Artifacts

mev-release
NOT AFFECTED

mev-ts-release
NOT AFFECTED

mev-ts-release-bitbake
NOT AFFECTED

mev-ts-release-external
NOT AFFECTED

mev-ts-trunk-bitbake
NOT AFFECTED

mev-ts-trunk-external
NOT AFFECTED

mev-upstream-idpf
NOT AFFECTED

mev-ts-trunk BAT tests: success - build 51302 - it is required if PR have BAT MEV status check as mandatory. If failed, please review Tasks in provided link to Berta. For questions please contact with<EMAIL_ADDRESS>

:green_book: MEV SW OD Build #14340 result: SUCCESS

Manifest Name
Build Status
Jenkins Link
Artifacts
Unsuccessful Stages
Description

mmg-trunk
SUCCESS
26447
 Artifacts

mev-trunk
SUCCESS
45751
 Artifacts

mev-ts-trunk
SUCCESS
51324
 Artifacts

mev-release
NOT AFFECTED

mev-ts-release
NOT AFFECTED

mev-ts-release-bitbake
NOT AFFECTED

mev-ts-release-external
NOT AFFECTED

mev-ts-trunk-bitbake
NOT AFFECTED

mev-ts-trunk-external
NOT AFFECTED

mev-upstream-idpf
NOT AFFECTED

:closed_book: MEV SW OD Build #14355 result: FAILURE

Manifest Name
Build Status
Jenkins Link
Artifacts
Unsuccessful Stages
Description

mmg-trunk
SUCCESS
26471
 Artifacts

mev-ts-trunk
FAILURE
51337
 Artifacts
IPU SDK Build

mev-trunk
SUCCESS
45772
 Artifacts

mev-release
NOT AFFECTED

mev-ts-release
NOT AFFECTED

mev-ts-release-bitbake
NOT AFFECTED

mev-ts-release-external
NOT AFFECTED

mev-ts-trunk-bitbake
NOT AFFECTED

mev-ts-trunk-external
NOT AFFECTED

mev-upstream-idpf
NOT AFFECTED

:closed_book: MEV SW OD Build #14381 result: FAILURE

Manifest Name
Build Status
Jenkins Link
Artifacts
Unsuccessful Stages
Description

mev-trunk
FAILURE
45782
 Artifacts
MEV B0 F37

mev-ts-trunk
SUCCESS
51354
 Artifacts

mmg-trunk

Passed in previous build

mev-release
NOT AFFECTED

mev-ts-release
NOT AFFECTED

mev-ts-release-bitbake
NOT AFFECTED

mev-ts-release-external
NOT AFFECTED

mev-ts-trunk-bitbake
NOT AFFECTED

mev-ts-trunk-external
NOT AFFECTED

mev-upstream-idpf
NOT AFFECTED

mev-ts-trunk BAT tests: success - build 51324 - it is required if PR have BAT MEV status check as mandatory. If failed, please review Tasks in provided link to Berta. For questions please contact with<EMAIL_ADDRESS>

mev-ts-trunk BAT tests: success - build 51354 - it is required if PR have BAT MEV status check as mandatory. If failed, please review Tasks in provided link to Berta. For questions please contact with<EMAIL_ADDRESS>

:closed_book: MEV SW OD Build #14502 result: FAILURE

Manifest Name
Build Status
Jenkins Link
Artifacts
Unsuccessful Stages
Description

mmg-trunk
FAILURE
26698

Sources

mev-trunk
FAILURE
45878
 Artifacts
MMG Simics A0 IMC

mev-ts-release
FAILURE
8067
 Artifacts
IPU SDK Build

mev-ts-trunk
SUCCESS
51434
 Artifacts

mev-release
NOT AFFECTED

mev-ts-release-bitbake
NOT AFFECTED

mev-ts-release-external
NOT AFFECTED

mev-ts-trunk-bitbake
NOT AFFECTED

mev-ts-trunk-external
NOT AFFECTED

mev-upstream-idpf
NOT AFFECTED

mev-ts-trunk BAT tests: failure - build 51410 - it is required if PR have BAT MEV status check as mandatory. If failed, please review Tasks in provided link to Berta. For questions please contact with<EMAIL_ADDRESS>

mev-ts-trunk BAT tests: failure - build 51434 - it is required if PR have BAT MEV status check as mandatory. If failed, please review Tasks in provided link to Berta. For questions please contact with<EMAIL_ADDRESS>

mev-ts-trunk BAT tests: success - build 51410 - it is required if PR have BAT MEV status check as mandatory. If failed, please review Tasks in provided link to Berta. For questions please contact with<EMAIL_ADDRESS>

mev-ts-trunk BAT tests: success - build 51434 - it is required if PR have BAT MEV status check as mandatory. If failed, please review Tasks in provided link to Berta. For questions please contact with<EMAIL_ADDRESS>

:closed_book: MEV SW OD Build #14821 result: FAILURE

Manifest Name
Build Status
Jenkins Link
Artifacts
Unsuccessful Stages
Description

mev-trunk
FAILURE
46087
 Artifacts
MMG Simics A0 F37

mev-ts-trunk
FAILURE
51631
 Artifacts
IPU SDK Build

mmg-trunk
ABORTED
26912

https://ubit-artifactory-or.intel.com/artifactory/list/mountevans_sw_bsp-or-local/builds/official/mmg-trunk/od/mmg-trunk-od-26912

mev-release
NOT AFFECTED

mev-ts-release
NOT AFFECTED

mev-ts-release-bitbake
NOT AFFECTED

mev-ts-release-external
NOT AFFECTED

mev-ts-trunk-bitbake
NOT AFFECTED

mev-ts-trunk-external
NOT AFFECTED

mev-upstream-idpf
NOT AFFECTED

:closed_book: MEV SW OD Build #14866 result: FAILURE

Manifest Name
Build Status
Jenkins Link
Artifacts
Unsuccessful Stages
Description

mmg-trunk
FAILURE
26949
 Artifacts
Simics A0 IMC, Veloce A0 ACC, Veloce A0 IMC

mev-trunk
FAILURE
46126
 Artifacts
MMG Simics A0 ACC, MMG Veloce A0 ACC, MMG Veloce A0 IMC

mev-ts-trunk
SUCCESS
51653
 Artifacts

mev-release
NOT AFFECTED

mev-ts-release
NOT AFFECTED

mev-ts-release-bitbake
NOT AFFECTED

mev-ts-release-external
NOT AFFECTED

mev-ts-trunk-bitbake
NOT AFFECTED

mev-ts-trunk-external
NOT AFFECTED

mev-upstream-idpf
NOT AFFECTED

mev-ts-trunk BAT tests: success - build 51653 - it is required if PR have BAT MEV status check as mandatory. If failed, please review Tasks in provided link to Berta. For questions please contact with<EMAIL_ADDRESS>

:green_book: MEV SW OD Build #14928 result: SUCCESS

Manifest Name
Build Status
Jenkins Link
Artifacts
Unsuccessful Stages
Description

mmg-trunk
SUCCESS
26993
 Artifacts

mev-trunk
SUCCESS
46169
 Artifacts

mev-ts-trunk
SUCCESS
51705
 Artifacts

mev-release
NOT AFFECTED

mev-ts-release
NOT AFFECTED

mev-ts-release-bitbake
NOT AFFECTED

mev-ts-release-external
NOT AFFECTED

mev-ts-trunk-bitbake
NOT AFFECTED

mev-ts-trunk-external
NOT AFFECTED

mev-upstream-idpf
NOT AFFECTED

mev-ts-trunk BAT tests: success - build 51705 - it is required if PR have BAT MEV status check as mandatory. If failed, please review Tasks in provided link to Berta. For questions please contact with<EMAIL_ADDRESS>

:closed_book: MEV SW OD Build #17922 result: FAILURE

Manifest Name
Build Status
Jenkins Link
Artifacts
Unsuccessful Stages
Description

mev-trunk
FAILURE
48601
 Artifacts
Berta & Doc

mev-ts-trunk
FAILURE
53483
 Artifacts
IPU SDK Build

mmg-trunk
SUCCESS
29251
 Artifacts

mev-release
NOT AFFECTED

mev-ts-release
NOT AFFECTED

mev-ts-release-bitbake
NOT AFFECTED

mev-ts-release-external
NOT AFFECTED

mev-ts-trunk-bitbake
NOT AFFECTED

mev-ts-trunk-external
NOT AFFECTED

mev-upstream-idpf
NOT AFFECTED


Procedures subject_procedures and specimen_procedures may need slight modification

Describe the bug
When running the unit tests in aind-metadata-service, the following warning shows up when serializing some of the models to json:
pydantic/main.py:308: UserWarning: Pydantic serializer warnings:
  Expected `Union[Craniotomy, FiberImplant, Headframe, IntraCerebellarVentricleInjection, IntraCisternalMagnaInjection, IontophoresisInjection, NanojectInjection, Perfusion, RetroOrbitalInjection, TrainingProtocol, WaterRestriction, SubjectProcedure]` but got `Headframe` - serialized value may not be as expected

To Reproduce
Steps to reproduce the behavior:

Create a Procedures model with a Headframe
Serialize it to json
Notice warnings

Expected behavior
There shouldn't be warnings that show up
Additional context
I think the root cause is that this
subject_procedures: Annotated[
        List[
            Union[
                Craniotomy,
                FiberImplant,
                Headframe,
                IntraCerebellarVentricleInjection,
                IntraCisternalMagnaInjection,
                IontophoresisInjection,
                NanojectInjection,
                Perfusion,
                RetroOrbitalInjection,
                TrainingProtocol,
                WaterRestriction,
                SubjectProcedure,
            ]
        ],
        Field(title="Subject Procedures", discriminator="procedure_type"),
    ] = []

needs to look like:
SUBJECT_PROCEDURES = Annotated[
  Union[
                Craniotomy,
                FiberImplant,
                Headframe,
                IntraCerebellarVentricleInjection,
                IntraCisternalMagnaInjection,
                IontophoresisInjection,
                NanojectInjection,
                Perfusion,
                RetroOrbitalInjection,
                TrainingProtocol,
                WaterRestriction,
                SubjectProcedure,
  ], Field(discriminator="procedure_type")]

subject_procedures: List[SUBJECT_PROCEDURES] = Field([], title="Subject Procedures")

We should still implement the above suggestion because it fixes another issue that was raised. However, after running a few more tests, it seems that there are some serialization issues when an invalid class is constructed and serialized to json. The following still emits a serialization regardless:
h = Headframe.model_construct()
f = FiberImplant.model_construct()
subject_procedures = [h, f]
p = Procedures(subject_id="12345", subject_procedures = subject_procedures)
p.model_dump_json()

UserWarning: Pydantic serializer warnings:
  Expected `Union[Craniotomy, FiberImplant, Headframe, IntraCerebellarVentricleInjection, IntraCisternalMagnaInjection, IontophoresisInjection, NanojectInjection, Perfusion, RetroOrbitalInjection, TrainingProtocol, WaterRestriction, SubjectProcedure]` but got `Headframe` - serialized value may not be as expected
  Expected `Union[Craniotomy, FiberImplant, Headframe, IntraCerebellarVentricleInjection, IntraCisternalMagnaInjection, IontophoresisInjection, NanojectInjection, Perfusion, RetroOrbitalInjection, TrainingProtocol, WaterRestriction, SubjectProcedure]` but got `FiberImplant` - serialized value may not be as expected


From .po back to .strings

Hy,
i try to use Twine to convert our strings files to .po it works very good to convert strings > txt > po but how can i do this in the other direction i don't get a information out of the docu. Is there a possibility to convert from po > strings or po> txt > strings?

Hey,
.po is Django, right? This is another point in case for #95 :-/ What do you mean, when you say "strings" and "txt"? The file twine uses to store translation keys and values is called strings.txt in the documentation, so it's currently a bit confusing.
Anyway, given you have a twine strings file, you can convert it to Django format using
twine generate-string-file twine_strings.txt django.po

and, the other way round, from Django to twine's file format
twine consume-string-file twine_strings.txt django.po

Was this your question?

Ok i have it thanks for the help


Script section comment on src/index.html shows in IE

A comment in the script section is showing in IE due to the syntax of the comment.

Potentially fixed here: 25fe1028304c24f476c67fd1e699287be4939e52
Needs to be tested.

Tested, fixed. Closing this out.


issue with saving the model with python  on windows

I would really like to thank you for this amazing work.
however, I'm trying to save the model so I will be able to use it, later with spark streaming but somehow I'm not able to do this and I'm having an error saying "The default jsonEncode only supports string, vector, and matrix. org.apache.spark.ml.param.Param must override jsonEncode for java.lang.Double"
here is my code :
temp_path = tempfile.mkdtemp()
iforest_path = temp_path + "\iforest"
iforest_model.save(iforest_path)
I would really appreciate it if you can help, thanks in advance.

Are you using Spark version 3.0+ ?
Maybe you can take a look at this issue, which might help. https://github.com/titicaca/spark-iforest/issues/36

which branch are you using? The master branch is tested on spark 2.4.

Sir, thanks a lot for your help I really appreciate it, I was able to save the model finally but unfortunately, I'm not alb to load the model and I'm facing an error that says.
"Py4JJavaError: An error occurred while calling o542.load.
: org.apache.spark.SparkException: Job aborted due to stage failure: Task 3 in stage 59.0 failed 1 times"
Also, while saving the model there's an error occurred saying that
"ERROR CodeGenerator: failed to compile: org.codehaus.commons.compiler.CompileException: File 'generated.java'"
but even though the model is getting saved, I'm not sure if the saving progress is going in the right way or if there's something going wrong.
I was trying to solve the 2 errors for the past few days that's why I didn't answer your comment but unfortunately, I couldn't.
I believe that there's a compatibility problem between my spark and python version and forest version so I think I will need to train the model, again and again, every time I want to test or run my streaming application I'm really out of options.
I would like to ask if there's also any way to evaluate the model because I think I couldn't find such a method in the implementation, I would be really thankful for it. ,
note: my data is an accelerometer data coming in real-time from a mobile phone, and the main idea of the work is to identify outliers in the streaming application using spark, apache Kafka, and forest algorithm.
thanks a lot sir for your amazing efforts again I can't thank you enough.

No problem. There might be some compatibility problems, because it hasn't been fully tested on Spark 3.2. I will look into it when I have time.
For the model evaluation,  you can refer to the example

thanks a lot for your efforts.


Major Release Cut

Describe the Improvement:
Figure out how to cut major release, probably write a GitHub action and test in https://github.com/devlinjunker/test.github.actions
part of #4
Benefits:
We need a way to increment the final semantic versioning release number
Drawbacks:
N/A
How to Compare:
Should have action to cut major release and we should release v1.0.0 of this repo

[ ] TODO:

Rename this project to template.semver or template.github.semver on major release cut
init new template.github repo from release-0.8

This is currently supported by the Release Cut action
just need to add BREAKING CHANGE footer

blocked by:

#60
#61/#18
#56

This will be a manual process, after #69 is squash and merged manually with BREAKING CHANGE footer the Release Cut action should create release-1.0


feat: adds timer in verbose renderer

fix #320
adds the appropiate option for verbose renderer to act same with timing and logging out it with the
success message

:tada: This PR is included in version 3.5.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


HSEARCH-3945 Refactor ElasticsearchScopedIndexFieldComponent / LuceneScopedIndexFieldComponent

https://hibernate.atlassian.net/browse/HSEARCH-3945
No need to review; I'll just wait for the CI build to finish and for the Sonar report, then I'll merge.
Full build: https://ci.hibernate.org/job/hibernate-search/job/PR-2304/2/

The tests passed and I fixed the relevant Sonar warnings. Merging.


Unused testImplementation dependencies are not reported

Is your feature request related to a problem? Please describe.
I'm trying to remove unused dependencies in my project. Particularly I have unused testImplementation dependencies that are not reported by the plugin.
Describe the solution you'd like
testImplementation dependencies should be reported as unused if they are not needed in tests.
Additional context
I've created a repro: https://github.com/Dim0N22/dependency-analysis-android-gradle-plugin-testImplementation-bug-repro.
Steps to reproduce:
git clone https://github.com/Dim0N22/dependency-analysis-android-gradle-plugin-testImplementation-bug-repro.git
chmod +x ./gradlew
./gradlew buildHealth

Output
❯ ./gradlew buildHealth

> Task :buildHealth
Advice for root project
Looking good! No changes needed

Advice for project :lib
Unused dependencies which should be removed:
- implementation("com.google.guava:guava:29.0-jre")
- api("org.apache.commons:commons-math3:3.6.1")

Expected output
Since the library build script contains an unused testImplementation dependency on org.robolectric:robolectric:3.8, it should be reported by ./gradlew buildHealth.

Thanks for the reproducer! That will make it a lot easier to dig into. I wonder if Robolectric is only used at runtime.... I wonder what would happen if you used the Reason feature?
./gradlew lib:reason --id org.robolectric:robolectric

that feature is a work in progress and so may or may not be useful in this situation.

I've reproduced this and understand the reason. A fix will be forthcoming.

This will be released as 0.74.0.

I see new issues about this new behavior: #423, #425, #424.
They force to add many ignores a multi-module project or disable the check.
How about adding an experimental feature toggle for new behavior?

This plugin is in a prerelease state, as indicated by the leading zero. As such, it does not support experimental toggles.
That said, I already have a fix for one of those issues, and a WIP for another.


[WIP] Add posibility to register external code lists.

Addresses https://github.com/irobayna/stupidedi/issues/161
Below is a sample implementation as a simple proof of concept, which may definitely be extended further. I would like to initiate a discussion on the pros/cons of the suggested approach.
@irobayna  @kputnam Guys, I would like to know your thoughts on this.

@RomanKapitonov WOW, this is fantastic!  This will be one of those key features will be very handy to have.
I have to take a deeper dive and study your PR but out of the gate, I see that the new logic returns an empty if the code list does not exist.  What do you think about perhaps having some way to alert that the code list does not exist?  I could foresee someone making a typo and perhaps not realizing this or worse yet getting the wrong code list.
Will take a deeper dive and report back.
Isi

@irobayna Thank you! I'm planning to continue working on the PR sometime this week. I've actually added a warning upon referencing a non-existing external list but then decided to get rid of it. I'm going to add it back along with documentation and some examples of usage.

@irobayna I've been looking through some of the specs for 270/271/837I and others, and it looks like some of the code lists might have "sub-lists". This concept is also covered by stupidedi. For example, the definition of DMG segment might contain element DMG10 which is data element 1270. Based on how 1270 is defined it looks like the element may contain a reference to the external code list. But that doesn't make much sense to me.
How would it be used? I mean let's say a DMG segment has some value in DMG10, which in terms is a reference to the external code list:
E1270 = t::ID.new(:E1270, "Code List Qualifier Code"             , 1, 3,
          s::CodeList.build(
            "65"  => s::CodeList.external("508"),
            "68"  => s::CodeList.external("682"),
            "AAA" => s::CodeList.external("662"),
            ...

Say we have a DMG:
DMG**********65~

Then how will code list "65" be used?

Hey @RomanKapitonov, this looks promising! I really like the ability to have the lookup values in the pretty printed output. I also agree with removing the AbstractElementUse#code_lists method, since it's not called anywhere (except a few other methods that aren't used).
One thing I'm not sold on is having a mutable global variable, Stupidedi.external_code_lists. I think we can have this data be a member of Config instead, by using or extending Config#code_lists. It's currently just waiting to be used for future work like this. The type (CodeListConfig) seems similar to ExternalCodeListStorage.
I would like to use an approach that allows different files to use different external code list implementations (e.g., maybe it depends on who the sender or receiver is), without the two files interfering with each other's external code list table. That also reduces the risk that code in an unrelated part of your application (or loaded via a third-party library) could change that global variable; if instead it's part of Config you would need to pass the config explicitly for that to happen. I think you also noticed that potential issue, because you have register print a warning when replacing an existing code list.
My first thought was to pass the config around to each method as it's needed. It is conveniently stored next to the parse tree in StateMachine#config. But passing arguments to IdentifierVal#inspect is unconventional, and even difficult to accomplish when it's called from q.pp(...) in one of the pretty_print methods. Similarly,SimpleElementVal#allowed? would require an argument, because it needs the code list to check.
Looking at the bigger picture, that would place the process of linking an element to an external code list as late as possible -- only right when we need to check its membership or pretty print it. However, we have all the info needed when we are constructing the element value (i.e., this is E26 so we know we should use config.code_list.at("5") or whatever), so we could link the element to the external code list as soon as we're constructing it. That brings me to this plan...:
Normally SimpleElementVal is given its usage attribute in AbstractState.mksegment; it eventually gets to element_use.value(element_tok.value, element_tok.position), which eventually resolves to IdentifierVal.value(...) for instance, where that's a subclass of SimpleElementVal. That usage attribute is used to get the internal code list for pretty printing and to determine the set of allowed_values.
Instead, I think we can pass an updated element_use in AbstractState.mksegment. The new element_use can be constructed by calling element_use.copy(...) with a new value for definition, which itself is created by updating the existing element_use.definition with a new code_list. We probably also need to update element_use.allowed_values to point to that same code_list too. I think that would tie all the bits together without requiring a lot of surgery.
Side note: we already do something similar in ID.simple_use when an internal code list is used, the difference being that it's allowed_values (which can be further restricted when a user declares a transaction set), and we can do it right when the grammar is being defined since it doesn't depend on a config.
Now one important unresolved issue remains: when one element determines which code list applies to another element. That's what is going on with DMG10. I believe it determines which external code list applies to DMG11. I'm certain that NM108 is used to determine which external code list applies to NM109 -- in the case of HC837, "XX" means there is a Medicare/Medicaid National Provider Identifier (NPI) in NM109. These relationships between the two elements aren't currently described in the SegmentDef schema, but I think that's where they need to go. The relationship is predetermined, it doesn't depend on where the segment is being used.
In summary, eventually AbstractState.mksegment will need to handle two cases:

The element definition has a single CodeList.external (eg E26, used in DMG07 and N404).
The element definition has a CodeList.internal that maps values to an CodeList.external; those external code lists govern another element in that segment. (eg E66, seen in NM108).

In the short term, we can make some progress by updating mksegment to handle the first case. This can be done by (a) first checking that we fall under the first case and (b) updating the element_use via element_use.copy(:definition => element_use.definition.copy(:code_list => ...)) before constructing the element value. Then, you should automatically get error checking in BuilderDsl and with a change to this line, you will have the lookup value in the pretty printer output.
Once that's working I think it wouldn't be much of a leap to create a new data type similar to SyntaxNote which lets you declare that NM108 determines which code list applies to NM109. Then update mksegment to make use of that data and pass it along the same way as above.
Hopefully I haven't taken the fun out of it and it makes sense. This idea might have some problems once you get down to actually implementing it... before typing this up I had at least two ill-conceived ideas that fell apart as I was trying to explain them :-)


react version "detect-no-warn"

I want to use a single Eslint configuration for multiple projects. However, some of the projects do not use react. When I set the react version settings to detect, I get a warning that react is not installed in those repositories.
  "settings": {
    "react": {
      "version": "detect"
    }
  }

I wish there was an option to set the version to "version": "detect-no-warn", so I can use a single Eslint preset for all of the projects no matter if they are using react or not.

This is a duplicate of #2276.
tl;dr: if they're not using react, they shouldn't be using any eslint-plugin-react rules. It's simply not tenable to have a single preset that works for both react and non-react, which is why the airbnb styleguide doesn't do it.


Fix formatting for simulated keyboard event

Fix for braintree/braintree-web#262
I've checked this fix with 1Password extension on latest Chrome, Safari and Firefox.

@okovpashko We really appreciate this contribution! If you're interested in a Braintree t-shirt, email me and we'll send one your way.


Prove SETᴰ is a fibration

part of https://github.com/maxsnew/multi-poly-cats/issues/62

Ok I pushed one more commit that does the reverse direction between hi tech and explicit notion of cartesian lifts. Should be good to go now @hejohns


PHP code being rendered in documentation

Describe the bug
When adding any blade directives inside of code blocks for my documentation, Larecipe tries to execute those code blocks as actual PHP code. If there is an undefined variable in the docs or a syntax error, the page will throw an error.
To Reproduce
Steps to reproduce the behavior:

Add a blade directive such as @if to your .md file
Try and view that documentation, you will get an error

Expected behavior
Expected Behavior would be to see the documentation file, but instead I get an error
Screenshots

Desktop (please complete the following information):

OS: MacOS Mojave 10.14.4
Browser CHROME
Version 77.03

Additional context
I just upgraded to the latest version of Larecipe and this is happening now, it was not happening when I was using version 1.0.
If anyone could help me figure this out, I would really appreciate it :) Thanks!

It’d be a nice to have but I wouldn’t say it’s a bug necessarily. Why are you needing to use blade syntax in markdown? Have you tried making your own vue component instead?

I'm not sure if this is related, but I'd like to pass in variables, so that I can use the same value across all my docs and quickly/easily change it if/when it's needed.
Is this possible...?

Of course, it may be that I'm looking for this: https://github.com/saleem-hadad/larecipe/issues/138

Gotchya, makes sense. Seems like that issue you referenced has a solution?

@WillGoldstein Well, it does provide a solution, but not one that I or at least one of the others here are terribly happy with.  :-/

@telkins indeed, perhaps I should have said “workaround” instead of “solution”

as for now, this issue fixed in v2.4.3