Test/i2c

Summary
On the Nucleo-L152RE board there are two I2C, I2C1 and I2C2 devices. But in the code there is no GPIO definition for I2C1. Because of this, an error occurred:
chip/stm32_i2c.c:363:17: error: 'GPIO_I2C1_SCL' undeclared here (not in a function); did you mean 'GPIO_I2C2_SCL'?
chip/stm32_i2c.c:364:17: error: 'GPIO_I2C1_SDA' undeclared here (not in a function); did you mean 'GPIO_I2C2_SDA'?
This error caused due to missing pin definition and fixed through first commit on this PR.
Although, build is success through this fix but there is no /dev/i2c1 device due to missing initializing and register process. So I added registration logic i2c device in other commits.
Impact
###Add GPIO_I2C3_SDA, GPIO_I2C3_SCL macro.
###Added code for init and register process to I2C.
Testing
Built successfully and working on real nucleo-l152re board.
Successfully read HDC1080 sensor's value through I2C1.

Do I need any other action to merge?
пн, 7 февр. 2022 г. в 21:02, Xiang Xiao @.***>:

@.**** commented on this pull request.
In boards/arm/stm32/nucleo-l152re/include/board.h
https://github.com/apache/incubator-nuttx/pull/5439#discussion_r800921242
:

@@ -226,6 +226,4 @@
#define GPIO_I2C1_SCL    GPIO_I2C1_SCL_2  /* PB8  CN5 pin 10, D15 /
#define GPIO_I2C1_SDA    GPIO_I2C1_SDA_2  / PB9  CN5 pin 9, D14 */

-/* I2C2 */
let's merge the last two patch to the previous related patch instead.
—
Reply to this email directly, view it on GitHub
https://github.com/apache/incubator-nuttx/pull/5439#pullrequestreview-875057811,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACPULO6GJQBZB66347B7METU2ACLDANCNFSM5NXUHWJA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>


Add PEP 604 support

This commit add PEP 604 support. The actual check is a bit finicky as I did not want to break the compatibility with Python 3.8 and 3.9. UnionType is available from 3.10 and up.
Also add W503 to the ignore list and you have to choose W503 or W504 to keep pylint happy.

Superseded by #5


Remove live detatching of volumes from VM instances?

ciao currently supports live attaching and detaching of volumes.  This issue questions whether we should keep the live detaching of volumes feature.  The reasons to remove it being:

It only really works well on Fedora.  Support on Ubuntu 16.04 is flaky.  Live detaching sometimes fails and needs to be retried.  This flakyiness can lead to BAT test failures as this feature is tested by BAT.  Live detach doesn't work at all on Clearlinux.
The QMP command we use to implement this feature is experimental.
We don't have any real use case for this feature right now.
It could lead to data loss if the VM is writing to the volume when it is detached by controller.
The feature adds complexity to launcher and BAT which is currently hard to justify.

We could remove live detach but keep live attach and detach from stopped volumes.

@kaccardi What do you think about this?

ok, let's get rid of it. If someone needs this we can reimplement it.

@markdryan wants to address this himself as there is some cleanup that could be in in this part of the code.

@markdryan do you think we should support detach on exited state (i'm thinking not as it's just going to create complexity..)


Issue #247 - Replace execute with backend.run() in qiskit-qec

Summary:
This pull request aims to resolve issue #247 by replacing the outdated execute function with the more up-to-date backend.run method in the qiskit-qec codebase.
Details and comments:

Replaced the usage of execute with backend.run for simulating the quantum circuit.

Additional Notes:
The following files have been modified:

test/matching/test_circuitmatcher.py
test/matching/test_repetitionmatcher.py
src/qiskit_qec/analysis/faultsampler.py
src/qiskit_qec/analysis/faultenumerator.py
test/heavy_hex_codes/test_heavy_hex_decoder.py

@IceKhan13 PR 381 is now ready for review

@grace-harper I have fixed #247 and it is ready for review

Hello @grace-harper , I will look into the issues. Thank you

Hello @grace-harper the test errors are related to a bug I identified and described in issue #380. I do not think is related to the work I did on  issue #247. Regarding the lint/style check. I will fix those. Thank you.


[$500] mWeb safari - IOU - "Start" and "Finish" is greyed out for a short time

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.34-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:
Action Performed:

Create a workspace
Start doing a destination IOU in the workspace chat using the FAB
Tap on the "Start" button
Type in any valid text and tap on the suggestion
Tap on the "Finish" button
Type in any valid text and tap on the suggestion

Expected Result:
The buttons shouldn't change color.
Actual Result:
"Start" and "Finish" is greyed out for a short time.
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[x] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/38435837/06f564cf-4c19-4614-979c-85d507578025

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0146f78b88fcb1651e
Upwork Job ID:<PHONE_NUMBER>077106688
Last Price Increase: 2024-01-31

Proposal
Please re-state the problem that we are trying to solve in this issue
IOU - "Start" and "Finish" menu items are greyed out for a short time, while the route is loading.
What is the root cause of that problem?
https://github.com/Expensify/App/blob/9f6179a40b65b8101e14857ae9e0a7fee281fdad/src/pages/iou/request/step/IOURequestStepDistance.js#L199
The root cause of the "Start" and "Finish" menu items being grayed out is that we're setting disabled to true while isLoadingRoute (see code block above).
What changes do you think we should make in order to solve the problem?
https://github.com/Expensify/App/blob/9ab4fe92dcbac8252998febf6fa24a080a196a70/src/components/menuItemPropTypes.js#L143-L144
We should keep the "Start" and "Finish" menu items disabled while isLoadingRoute but in order to not have them grayed out we can take advantage of the MenuItem's shouldGreyOutWhenDisabled prop.
Within the DistanceRequestRenderItem component, add shouldGreyOutWhenDisabled={false} as a prop to MenuItemWithTopDescription.
Videos

iOS: mWeb Safari

Before
After

I don't understand why we need to disable the menu items while the route is loading. Removing the loading attribute seems like a more simple fix. Asking in Slack here if there was any particular reason to add it.

@allroundexperts mind summarizing that convo, please? 🙇♂

@dylanexpensify It hasn't gotten any traction. Can you please bump it?

sure can!

bumped

won't fix


Transactions does not work with multi tenant application

First of all, thank you for this library. It's a must-have.
I am using nest.js to create a multi tenant application, so the module creates the connection dynamically and injects into the service, and then  I get the repository like this:
export class SurveyService {
  public repository: Repository<SurveyEntity>;

  constructor(
     @Inject(TENANT_CONNECTION) private connection,
     private surveyAttributeService: SurveyAttributeService
  ) {
        this.repository = await this.connection.getRepository(SurveyEntity);  // <--- here
     }

  @Transactional()
  create(data): Promise<SurveyEntity> {
     const survey = this.repository.create(data);
     const savedSurvey = await this.repository.save(survey);
     if (data.attributes) {
       await this.surveyAttributeService.createFromArray(savedSurvey, data.attributes)
       // if an error occurs here, there is no rollback
     }
     return savedSurvey;
  }
}

The main.ts is:
import { NestFactory, Reflector } from '@nestjs/core';
import { AppModule } from './app.module';
import { Logger, ValidationPipe } from '@nestjs/common';
import { initializeTransactionalContext, patchTypeORMRepositoryWithBaseRepository } from 'typeorm-transactional-cls-hooked';
import * as compression from 'compression';
import { GqlRolesGuard } from './common/guards/gql-roles.guard';
import dotenvFlow = require('dotenv-flow');
import { ApolloErrorFilter } from './common/filters/apollo-error.filter';
import 'reflect-metadata';

async function bootstrap() {
  dotenvFlow.config({path: 'env'});
  initializeTransactionalContext(); // Initialize cls-hooked
  patchTypeORMRepositoryWithBaseRepository(); // patch Repository with BaseRepository.
  const app = await NestFactory.create(AppModule);
  app.useGlobalPipes(new ValidationPipe());
  app.useGlobalGuards(new GqlRolesGuard(new Reflector()));
  app.use(compression()); // enable gzip
  app.useGlobalFilters(new ApolloErrorFilter());
  await app.listen(process.env.APP_PORT);
  Logger.log(`Server is running on: ${await app.getUrl()}`);
}
bootstrap();

Although my application works fine, transactions just don't work. Am I missing something?

Thanks!
I have not tested this can of setup, however, I believe you need to define the connectionName within the decorator.
You can use function that returns the connectionName, but it is a must, if it is not default
See https://github.com/odavid/typeorm-transactional-cls-hooked#using-transactional-decorator
Hope it helps...

Thanks @odavid for your reply. Unfortunately I have no idea how to get the connection name within the decorator, since I have no access to the request in that context (I think), The connection name is the tenant name that I retrieve from the JWT in the Authorization header. Any idea? Could you please provide an example or direct me to a sample? Thanks in advance.

Hi @gcherem, I think that once this PR will be merged, you will be able to use the
runInTransaction function instead of the  decorator

I don't think this is related to multi tenant. I am using nestjs and it doesn't work as well.

Gracias @odavid por tu respuesta. Desafortunadamente, no tengo idea de cómo obtener el nombre de la conexión dentro del decorador, ya que no tengo acceso a la solicitud en ese contexto (creo). El nombre de la conexión es el nombre del inquilino que recupero del JWT en el encabezado de Autorización. ¿Alguna idea? ¿Podría darme un ejemplo o dirigirme a una muestra? Gracias por adelantado.

Hello, I am stuck in this same situation. Some help?

I'm using multi tenant too just as op said,
I need some help to resolve dynamic connections?

I can't get everything to run within the same transaction.
I have the following code:
`export class TestService {
repository: any;
constructor(
@Inject(TENANT_CONNECTION) private connection)
{
this.repository = connection.getRepository(Test)
}
@Transactional()
async agregar(tableNew: Test): Promise {
const tableSave = this.repository.create(tableNew)
await this.repository.save(tableSave)

if(tableSave.default){
  await this.repository.update(
        {default:true,id:Not(tablaSave.id)},
        {default:false}
  )
}
return tablaSave.id

}
The following is executed in the database:
query: START TRANSACTION
query: SELECT Test.id AS Test_id,Test.default AS Test_default FROM test Test WHERE Test.id IN (?) -- PARAMETERS: [0]
query: START TRANSACTION
query: INSERT INTO test(id,default) VALUES (?,?) -- PARAMETERS: [0,1]
query: COMMIT
query: UPDATE test SET default = ? WHERE (default = ? AND id != ?) -- PARAMETERS: [0,true,41]
query: COMMIT
`
As you can see, 2 transactions are executed, I need it to be only one

it's working for me now
here is the code snippet for multi tenant
  return runInTransaction(
      async () => {
       // async operations
      },
      { connectionName: this.connection.name },
    );

@pavel-xendit
weird, why the heck it's working for me then, I've tested on simple use-case though
Are you giving connectionName in the second param of runInTransacion?

@mohsinamjad
How can I get connectionName? I passed default as connectionName.

@odavid @mohsinamjad
Any thoughts on how to make runIntransactions work?

it is possible to use async-hooks or cls-hooked or some other similar package for creating request scoped context.
after that it is quite easy to use it in Transactional callback to get necessary connection

For multi tenant your connection name will be dynamic like in my case I set tenant ID as connection name,  and you can't use same connection name is e.g default.
You have to use this.connectio.name for it.


[ahub] fix ahub issues

Fix some issues of svace and coverity.
Self evaluation:

Build test:	 [X]Passed [ ]Failed [ ]Skipped
Run test:	 [X]Passed [ ]Failed [ ]Skipped

:memo: TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #2249. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

:octocat: cibot: @baek2sm, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/2249-202307191135440.66352295875549-83509bf48e2439a4d743c2c86102dbcd1e6c936c/.


Comparison with predpatt?

Hi, I truly believe dependency parsing has a huge potential for semantic role labeling/information extraction.
Predpatt is some intersting prior work and I wonder how they compare on precision/recall, please benchmark!
https://www.cs.jhu.edu/~s.zhang/assets/pdf/iwcs17.pdf
Moreover, regarding a way to further increase accuracy, I wonder if you could leverage Enhanced dependencies which predpatt unfortunately do not make use of.. despite their impressive expressive power.
@yzhangcs

@LifeIsStrange Hi, thank you for recommending this work to me, which I was not aware of before.
I have just spent some time getting to know this paper, and do think it's very interesting. However, I don't think this is a suitable benchmark for my paper, as Predpatt makes use of gold UD treebanks while my approach is fully end-to-end, taking dependency trees as latent annotations. In contrast, I think a more comparable work is Shi et al. 2020.
Thank you for your suggestions!


Introducing GitHub Actions to check Go SDK PRs

Signed-off-by: Ricardo Zanini<EMAIL_ADDRESS>

@tsurdilo I guess we need to merge this one first to have it started and then I can fix the follow up bugs (if any).


Better understanding of graphs axes

On home page
as user I want to defferentiate the abscissa and ordonates axes in order to understand the position of the bullets
Maybe add arrows to understand the coordinates, and the directions. Also add a legend for the abscissa and ordinates (like in /[category] we have "desire level" and "skill level"

@MailyLehoux I did a few modification to try and implement it, here a screenshot:

I don't know if the others have suggestions, but for me it's clearer like this :v:


update DataSet and DataSetLoader

now we can use different DataSetLoader  to load data from files and convert into DataSet

For sequence labeling, in training, set_target(truth=False).  In testing, set_target(truth=True).
This is because sequence labeling model with CRF computes loss in its forward() if truth given, and the loss needs an intermediate result.
But the naming is quite wired.
Can we develop a better machenism to handle this?


ci: add prose linting with vale

This is useful to smoothen the review of submissions and the overall quality of the content.
Vale is able to use certain comprehensive style guides (e.g. Redhat, Microsoft, Google). This PR just uses merely the base check, which already produces some good findings.
We can decide on a more opinionated style guide later.

@surajssd @ariel-adam are github actions disabled in this repository?
this would be example of a ci report

@surajssd @ariel-adam are github actions disabled in this repository?

No, I haven't disabled anything explicitly. I believe this run will only happen once this PR is merged, isn't it?

@surajssd @ariel-adam are github actions disabled in this repository?

No, I haven't disabled anything explicitly. I believe this run will only happen once this PR is merged, isn't it?

let's see...


offline transducer: treat unk as blank

Hi there, thanks for implementing this great project!
I saw that treating unk as blank is implemented in online transducer, but not in offline transducer, so I made some changes to offline transducer to match the behavior of online transducer.
Please let me know if there's anything else missing.
Thanks in advance!

Thank you for your contribution!
Will merge once the CI passes.


Can the virtual machines on the local area network be connected to the network like the 0.6 version

Can the virtual machines on the local area network be connected to the network like the 0.6 version
能否像0.6版本一样能够让 本机的局域网的虚拟机也能够连上网络

@TOPPOOL Storage nodes have always been configured with public IP addresses, otherwise you will not be able to store service files and thus be unable to obtain higher profits. Please refer to our manual requirements: https://app.gitbook.com/o/kiTNX10jBU59sjnYZbiH /s/QzzR05bLvPP615saNCGf/storage-miner#mining-preparation


use rust 1.83

Codecov Report
Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 25.30%. Comparing base (ce6c0df) to head (8384936).

Files with missing lines
Patch %
Lines

lib/g3-types/src/net/error.rs
0.00%
2 Missing :warning:

:exclamation:  There is a different number of reports uploaded between BASE (ce6c0df) and HEAD (8384936). Click for more details.
HEAD has 1 upload less than BASE

Flag
BASE (ce6c0df)
HEAD (8384936)

g3proxy
1
0

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #396       +/-   ##
===========================================
- Coverage   51.25%   25.30%   -25.95%
===========================================
  Files        1091      660      -431
  Lines       99767    48837    -50930
===========================================
- Hits        51132    12357    -38775
+ Misses      48635    36480    -12155

Flag
Coverage Δ

g3proxy
?

lib
25.30% <0.00%> (+0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


requested file format unknown - error

Godot version:
built 23rd dec off github
OS/device including version:
linux manjaro
amd rx580
Issue description:
open a dae, or glft or glb in the editor
move the mesh
the file shows in the editor with a (*) indicating its not been saved
press the play button
a dialog opens saying "Requested file format unknown" and the game fails to load
Steps to reproduce:
ops, as above :)
I'm assuming this is trying to save over the mesh file, as when i close that tab it all runs fine....

built 23rd dec off github

It'd be simpler to include the shorthash from the engine version. :)
Like so: 5c8aba2

Ah i didnt realize the version number was on the about screen!
Thanks
Version: 32d8b99

The error is technically valid, I wonder how it could be handled better..

@TutorialDoctor Yes, you can't save the scene and it explains you why. I'm not sure what else could be done..
I am still not sure this is a bug, how could it be improved usability wise?

Not sure when it was changed, but when trying to open a mesh now, Godot suggests you to create an inherited scene instead, which is the "correct" workflow. The only thing we could do more is prevent opening mesh scenes at all.

Closing as fixed as per the above.


Update OpenJDK base image to patch OpenSSL

http://www.ubuntu.com/usn/usn-3087-1/

Current coverage is 96.06% (diff: 100%)

Merging #37 into master will not change coverage

@@             master        #37   diff @@
==========================================
  Files            20         20
  Lines           229        229
  Methods           0          0
  Messages          0          0
  Branches          3          3
==========================================
  Hits            220        220
  Misses            9          9
  Partials          0          0

Powered by Codecov. Last update 1f2446d...94b6b0b

:+1:

:+1:


Properly plumb Snapshot Cache Expiry policy through driver and GC code

Description
This is a prerequisite for #11084.  We have to pass the maximumCacheDurationMs storage policy into GC because it's used to calculate the Sweep Timeout.  And we need this value to be the same one that's actually used in epochTracker.
In order to get the same policy applied throughout (GC, Storage Service, and epochTracker) I had to move ownership of the storage policy up to the Document Service Factory (not the Document Storage Manager classes).
To Do

[ ] Update tests

Does this introduce a breaking change?
No, thanks to sensible exports in odsp-driver's index.ts!

Do you have a test that outlines the advantage of this change?

@tyler-cai-microsoft - The alternative is you patch on the policy midway through epochTracker's lifetime.  See "Red" side of this commit.  Not good.
Not sure what test I would write.  The goal is to define the policy in one place and have everyone who needs it pick it up.  I guess maybe I could write a test that proves that epochTracker and GC get the same value for this policy.  Before this change, the value is hardcoded in epochTracker, and not passed to GC at all.

Converting to draft.  I don't think this works.  "This" being the existing IGarbageCollectorCreateParams.snapshotCacheExpiryMs.  GC is initialized during ContainerRuntime initialization which may be before the Container is attached in which case there is no document service to read the policy from.
I'll unblock myself for #11084 by setting it to 0 directly (but independently) in epochTracker and GC.  (side note: We'll have a small hiccup where driver / runtime aren't deployed together so there could be a mismatch... will think more on that and address in the SweepV0 PR if I have any ideas)

Closing for now.  We need a different approach.  I opened AB#1362 to track this problem.
Haven't given this more deep thought the last few days but my instinct is that the Loader layer needs to own this policy.  I also want to scrutinize the relationship between cached snapshot age and reference/unreference state/timestamps.  I'm not convinced the calculation of sweep timeout is quite right.

New approach: #12118


AS-1408 Upgrade Purescript to 0.14.1

What does this pull request do?
This library is no longer maintained so we fork it and upgrade the purescript version.

wrong place


Hints to overload protection and ANALYZE command

Summary of the changes / Why this is an improvement

Improvement of documentation: execute ANALYZE statements after (large) inserts and hints to overload protection

Checklist

[ ] Link to issue this PR refers to (if applicable):
[x] CLA is signed

Build still seems to fail due to warnings and broken links (r-project.org seems to be down at the moment?)
WARNING: myst-parser 0.12.10 does not provide the extra 'linkify'
cc: @amotl

Hi. I've forward-ported your patch to the new instance of this documentation. Thank you again.

https://github.com/crate/cratedb-guides/pull/6


Issue with tutorial  update/update-intro/ carousel not working

i discovered that bootstrap is upgraded, so i decided to add the specific class to ensure design did not change.
Fixes #14882

/assign @zacharysarah
/assign @rlenferink

@medmedchiheb it's more common to make this kind of fix with a separate pull request for each localization, starting with English. It might be OK to do this fix in one PR; I'm not certain.
(even though this isn't changing the text of pages, different localizations have different approvers).

@sftim yes i thought that at first, but after thinking , that there are no language change i decided to do it.
So, what do you think! separate it !!

/shrug
I'm not sure what the most appropriate approach is, sorry. Maybe an approver can comment?

Hi @medmedchiheb thanks for fixing this!
As @sftim suggested creating a PR per localization will get it approved faster, as there are more people who are able to approve the PR. However, it is possible for root approvers to approve this PR, but their review ability is limited as well, so for the next time it may be better to create a PR per localization :)
About this PR, I updated your initial comment to include links to the original and updated pages. I checked them and it seems that the carousel is fixed now. Thanks for fixing 🎉


Charging/discharging plan reset after changing the mode via HA

Hi,
First of all thanks for a great integration of GoodWe! I have started to use modes, however when I set charging/discharging plan via mobile app and then change the mode via HA (e.g. from eco to general), all the plan entries are disabled. When I activate them again they remain active till another mode change via HA. I have GoodWe 8K-ET.
Thanks for any help in advance.
Michal

Hi,
I'd like to connect to this issue and confirm that observe the same behavior on ET inverter. Going from General Mode (or other mode) to  ECO disables ECO schedules. The hours,values remain as previously set, but they are inactive.
Goodwe allows to setup 4 different plans in ECO. So in ECO mode should be an option in HM to direct which
"Battery power groupX" should be activated in ECO (where X=1,2,3,4).
The only solution for now is activation ECO plans manually in "PV Master" app each time when switching ECO out/in.
Please help how to fix this. Thanks.
BR,
Tom.

Not a solution from my end - but how about simply ditching PV Master and doing everything via HA (create corresponding schedules in HA)?

Not a solution from my end - but how about simply ditching PV Master and doing everything via HA (create corresponding schedules in HA)?

Well, HA doesn't have access (or at least I cannot find them) to some parameters which are visible inside Goodwe ET inverters.
They are available with PV Master only. Beside of this I'd like to stay with Goodwe original settings to have all
in sync in case of HA issues.
I'll try to use elRadix solution. Thanks.

Well, HA doesn't have access (or at least I cannot find them) to some parameters which are visible inside Goodwe ET inverters. They are available with PV Master only. Beside of this I'd like to stay with Goodwe original settings to have all in sync in case of HA issues.
I'll try to use elRadix solution. Thanks.

Just out of curiosity - which parameters you mean? The HA integration exposes almost everything.
Moreover even if you use HA as me or elRadix suggest you can still use PV Master to read data - by ditching PV Master I meant to not use it to control charging, you can still use it to access whatever information you want but leave charging control on some HA automation. I have a very similar one in place as elRadix and it works great. If HA fails, you can again set your schedules in PVM.

Just out of curiosity - which parameters you mean? The HA integration exposes almost everything.

"Battery power groupX"  in ECO (where X=1,2,3,4) is listed in PV Master. I don't know which parameter in HA is responsible for these.
Do you know which entity to look (select.inverter_operation_mode and then which option?) Thanks.

maybe delete them and let HA create a new one ...

maybe delete them and let HA create a new one ...

Sorry, I don't understand. What should be deleted in HA: whole Goodwee device and add it again in HA?

sorry I meant in the pv master app, the different eco modes

sorry I meant in the pv master app, the different eco modes
ECO mode without these "different eco modes" does not make any use to me.

Those modes are disabled by default when HA sets General Mode and then again back to the ECO mode.
The question is how to enable them again using HA "Eco mode"? Thanks.

"Battery power groupX" in ECO (where X=1,2,3,4) is listed in PV Master. I don't know which parameter in HA is responsible for these. Do you know which entity to look (select.inverter_operation_mode and then which option?) Thanks.

But isn't this "battery group" just the schedule? Or you have more battery modules connected that you control separately somehow? I am not at home now so have no access with PV Master...

I have re-implemented the EcoMode behavior in v<IP_ADDRESS>, can you verify it works now properly ?

I made some basic checking of ECO charge, discharge modes with ET inverter. Seem to work OK using "Battery power Group1".

I noticed that "Battery power Groups 2,3,4" are overwritten with some default values.
It would be useful if you could do the deactivation of these groups only - leaving their other values unchanged (time, day of week, type).

The Peak Shaving Mode (https://github.com/mletenay/home-assistant-goodwe-inverter/issues/145)  is quite similar to "ECO charge mode". The PSM requires also few parameters - currently they are not set when switching to PSM.

I have changed the Eco Mode Charge/Discharge switching in the library v0.2.28 (will get to integration release v.<IP_ADDRESS>).
It should no longer clear the schedules 2-4 and will just turn them off.

It would be great if you could reenable disabled schedules after going back to normal "Eco mode" from either "Eco Mode Charge/Discharge" or from "General". Or set in configuration those schedules that should be enabled when going to "Eco mode"
My scenario is that I have some schedules to charge/discharge battery in PV master for Eco mode and now mode change in HA will currently disable them and there is no way from HA to enable them again. I have to go to PV master a enable them manually. Thanks


Memo not getting sent to an IBC transfer from Keplr wallet.

The memo is not getting sent with the ibc-transfer from cosmos to namada when using Kepr wallet. I've resolve this by this PR: https://github.com/anoma/namada-interface/pull/700
Edit: replace this PR by: https://github.com/anoma/namada-interface/pull/747

@phat-kf hello! I'm closing this issue as we are handling this in another issue


[Windows Problem]:Error running on installing packages for collector

pip install - requirements.txt in /collector folder gives this error
From the initial inspection it seems this is an windows error

Steps to reproduce:

cd collector
pip install -r requirements.txt

similar/duplicate to #5
@Cenrax, the project maintainer is looking into dockerizing the various components of the app to avoid OS-specific package install issues. See #26

Closing this as duplicate + is in the works
as @jwaltz said refer to PR #34


Add failed_payloads attribute to FailedPayloadsError

The logs and stack trace can get quite large if a payload is large, or there are a lot of them.  Moved it  to be its own attribute.

Merged w/ change to super()


teleprompter: 2.3.4 -> 2.4.0

Motivation for this change
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Please, update license to gpl3Plus according to
https://github.com/ImaginarySense/Imaginary-Teleprompter/blob/3a11d747493837e722a9e5a6bf9dc72fe1b936e3/package.json#L6

@mweinelt done

Result of nixpkgs-review pr 101844 1

1 package built:

teleprompter


Update to Dagger 2

There is already PR for that https://github.com/JakeWharton/u2020/pull/42
But it seems like its in stale state.

PR for this was closed. u2020 still can be updated to Dagger 2 now.


InvalidStateError IOS error

Hello!
While using adyen-web 5.33.0 with native 3DS, this frontend error is reported to us many times every day:
InvalidStateError The input element's type ('submit') does not support selection.
    [native code]:2:302122 setSelectionRange
    node_modules/@adyen/adyen-web/dist/adyen.js:1:292873 a

I think it comes from https://github.com/Adyen/adyen-web/blob/master/packages/lib/src/components/internal/SecuredFields/lib/CSF/extensions/handleIOSTouchEvents.ts#L42:L53
Smartphone :

Device: iPhone
OS: iOS 16
Browser: Safari (mostly), some Chrome

@alepore - This issue should be fixed in release 5.39.0


SCM: Viewlet should improve "no repositories" messaging

Issue Type: Bug
This is a new installation of VS Code and Git.
I've reviewed other issues and I have verified the following:

Git can be found on the path. Git: Show Git Output displays:

Looking for git in: C:\Program Files\Git\cmd\git.exe
Looking for git in: C:\Program Files (x86)\Git\cmd\git.exe
Looking for git in: C:\Program Files\Git\cmd\git.exe
Looking for git in: d:\Program Files\Git\cmd\git.exe
Using git 2.19.1.windows.1 from d:\Program Files\Git\cmd\git.exe

This is a brand new install of VS Code and a new install of Git.

The extension is enabled (I did try disabling and reenabling), no luck.

There are no icons on the source control pane, nor any ellipsis menus (...).

VS Code version: Code 1.28.2 (7f3ce96ff4729c91352ae6def877e59c561f4850, 2018-10-17T00:23:51.859Z)
OS version: Windows_NT x64 10.0.17134

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-3770 CPU @ 3.40GHz (8 x 3396)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: enabledvideo_decode: enabledvideo_encode: enabledwebgl: enabledwebgl2: enabled

Memory (System)
15.96GB (4.15GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions: none

Screenshot.

Did you open a git repository at all?

From with VS Code? No, there is no option to do that.

I think this might just be a confusing message. I used the console to clone a repository and when I opened the folder in VS Code the source control pane worked as I expected it to. Once I closed the folder the same message reappeared. Coming from a Visual Studio & TFS world I was expecting a different experience.
IMHO the message should clarify that Git is installed and functioning, you just need to used the console to clone a repository and open it...at least that's how I think it should work. Time to watch a few videos!

click on extension type @disabled  you will see all disabled extension on of them will be git just enable(workstation)

Thanks, I did that before posting. Have a look at my last comment. The widget gave the impression that it wasn't working, when it was.

Actually just had the exact same problem
I opened vscode and it said "No source control providers registered."

So I googled vscode git support and followed the documentation: https://code.visualstudio.com/docs/editor/versioncontrol#_git-support
So I intalled git for window and ensured git was in the path, then just to be sure I restarted my PC
I reopend vscode and still had the exact same message "No source control providers registered.", so I assumed the git installation or something related to vscode was wrong, so I googled again and found this ticket first: https://github.com/Microsoft/vscode/issues/61522
in that ticket someone has the exact same problem, one comment said to press CTRL+SHIFT+P and then enter "Git: Show Git Output", which gave me:
Looking for git in: C:\Program Files\Git\cmd\git.exe
Using git 2.19.1.windows.1 from C:\Program Files\Git\cmd\git.exe
> git rev-parse --show-toplevel
fatal: not a git repository (or any of the parent directories): .git

so I realised vscode was indeed finding git, but somehow was expecting me to already have a git repo opened and finally the next comment of that ticket had the suggested solution which consisted off  manually creating a folder and do a manual git clone first,
So I went to the explorer opened a blank folder, then I opened a new vscode terminal panel, entered my git command, which opened the GitHub login window:

and after login in it successfully cloned my repository and I could use git as expected.
Next time I reopened vscode it had finally realized that git is installed and working and hence did not show the "No source control providers registered." message anymore
in the ticket https://github.com/Microsoft/vscode/issues/61522 it says to come to this ticket here to see if the git workflow could be improved, this is why I wrote this explanation
So in my opinion it would be great if after installing git, vscode would at least show another message, even better would be if there was a button that says checkout your first repo or login to your git service provider and open a login panel, you click it, enter your credentials or the repo url and bam you are done :)

And that's also why I am here --> also confused about the "No source control providers registered".
I was just about to reinstall visual studio code, when I found this post. pfew :)

Has this issue been solved? I have suddenly been getting the No source control providers registered message when cloning an existing git repository.
When using Git: Show Git Output in VS Code I get:
Looking for git in: usr/local/bin/git
Using git 2.17.1 from usr/local/bin/git

My repository is cloned from GitHub and has a .gitignore file. What else can I do to convince VS Code that a folder has version control?

@KokoDoko Did you configure git.path? If so, you forgot the leading / in /usr/local/bin/git.

SOLVED!!!
I just upgraded VS Code to the latest and had the same issue. What solved the issue? The solution posted by @pramodnitmz
For some reason, during the upgrade the "Git" extension was disabled. All i had to do was go the the "extensions", then type @disabled. It will show all disabled extensions, in my case, "Git". Enabling the extension solved my issue.

See https://stackoverflow.com/questions/46609255/git-missing-in-vs-code-no-source-control-providers for a sample of some confusion caused by this message.

Just got moved to a new machine at work, and this issue popped up. I agree with someone who said that the message should say "Git is installed/working (whatever), but you're not in a git enabled repository. Would you like to create a new one or open a folder that has one?" well, that's the gist of it, anyway. And then those two options should be available for the user to act on...

Hi, I solve this problem by changing the order of environment variables paths. Specifically, I move my desired searching scope of git upper and the problem just went away once I did so.

Fresh install of VSCode and Git on a brand new Windows 10 machine and despite git working in Terminal, PowerShell and WSL, AND the GitLab flow extension working, Source Control still reports "No source control providers registered". I've also tried after removing GitLab Flow and restarting just in case.
I have no disabled extensions. Authentication is working fine (I can use any of my terminals to successfully fetch). SmartGit works as expected when fired up (the point is to not have to though).
Version: 1.40.2 (system setup)
Commit: f359dd69833dd8800b54d458f6d37ab7c78df520
Date: 2019-11-25T14:54:45.096Z
Electron: 6.1.5
Chrome: 76.0.3809.146
Node.js: 12.4.0
V8: 7.6.303.31-electron.0
OS: Windows_NT x64 10.0.18362
Git: 2.17.1 (WSL), 2.24.0.windows.2 (Windows)

As I'm now seeing "fatal: not a git repository (or any of the parent directories)", I wonder if it has nothing to do with Git or our projects, just the context the commands are run in.

@bowdenk7 Since https://github.com/microsoft/vscode/issues/89080 has landed, I have adopted it in Git. We now cover the following cases:
Git extension is disabled

No git installation found

No open folder

No .git in current folder

No .git in current workspace

click on extension type @disabled you will see all disabled extension on of them will be git just enable(workstation)

Thank you. It is working perfect.


API and Debug API documentation

As a user or developer I want to have a documentation on exposed API and Debug API such that I can use it to make correct HTTP requests to them.
In order to have a documentation of exposed HTTP APIs, the best format would be OpenAPI 3.0.
A previous attempt to automate generation of such specification https://github.com/ethersphere/bee/issues/62#issuecomment-614781486 resulted in a conclusion that the tooling is not flexible and mature enough, with the suggestion to manually create and update specifications.
OpenAPI specifications can be put into docs/api/spec.yaml and docs/debugapi/spec.yaml in the bee repository. Autogenerated swagger files https://github.com/ethersphere/bee/blob/go-swagger/docs/api/swagger.yaml and https://github.com/ethersphere/bee/blob/go-swagger/docs/debugapi/swagger.yaml can be used as starting point, but not required.
Specifications should reflect functionalities implemented in pkg/api and pkg/debugapi packages with their router.go files as starting point. Following their handlers, would reveal request requirements and what responses are providing.
Additionally, a static Redoc can be added to the code for easier reading https://github.com/Redocly/redoc#tldr, alongside the spec.yaml files. Probably avoiding external cdn links for page assets.

An attempt to use go-swagger spec generation from source is available in go-swagger branch https://goswagger.io/use/spec.html. It assumes some code structure in order to correctly read comments that include api definitions out of which the final swagger structure is generated. This required defining httputil.UnmarshalMuxVars and httputil.UnmarshalURLValues functions in order to be able to define path parameters and url query values as structures with typed fields. These functions may be good also to have a unified way to declare and validate input variables from url path and query parameters, but require the usage of reflection.
But, even with these problems solved, go-swagger does not work well with custom types, most notably multiaddr.Multiaddr and fails to generate spec. Beside that, a lot of possibilities from spec format 2.0 are not supported, most notably on the response parameters where the response is not a defined struct by arbitrary byte stream.
API documentation can be generated with code on the go-swagger branch with make swagger-api serve-swagger-api and debug api documentation with make swagger-debugapi serve-swagger-debugapi.
Even my intention was to have spec generated from the code, I do not think that go-swagger is mature enough to allow us to produce a quality swagger spec. I would suggest to write swagger spec manually instead, because of the code expectations of go-swagger, problems with custom third-party types and lack of flexibility in defining spec variables.

@janos , what is the status of this issue? Are you still actively working on it, is it blocked?

I have updated the description yesterday and @metacertain is working on this task.

@metacertain , do I get that you leave this task, for now? Or is it completed? I would like to see this reflected in the board. If completed (or part of the work done), can you describe this here. If you set it aside for now, could you put it please back in the backlog?

@Eknir Yes, I have put this on hold on my side for a while


PL-apt 2.x support ( feedback requested )

Hi all,
I've seen several different solutions so far to implement PL-apt 2.x support and its very confusing which one is the best solution.
https://github.com/elastic/puppet-elasticsearch/pull/452
In repo.pp file
Class['apt::update'] -> Package[$elasticsearch::package_name]

https://github.com/elastic/puppet-elasticsearch/pull/448
On package resource:
require => Class['apt::update']

I would like to try and keep the apt parts confined to the repo.pp so it has the least possible impact on people if they don't use the repo management and have their own thing in place.
Also in the current form in the module i already force that the repo management happens before the package install it self at https://github.com/elastic/puppet-elasticsearch/blob/master/manifests/init.pp#L376-L378
And the repo management by the apt modules notifies the apt-get update part at https://github.com/puppetlabs/puppetlabs-apt/blob/master/manifests/setting.pp#L50
I would like to have some feedback on which solution people think its best.

@driegel @madAndroid @maxstepanov @philipwigg @pcfens @Pryz @br0ch0n @s12v @liamjbennett  @Tombar
Would love your feedback on this. Thank you!

Since I wrote #452, I figured a little explanaition of why I added new relationship line might help a bit. If I understand correctly, the resulting compiled catalog is the same with both approaches - but I tend to like the approach that keeps all things repo in repo.pp. What follows is a little dense, but I hope helps.
If I'm reading the documentation on containment correctly, classes declared inside of classes (like apt::update inside of apt) don't follow the same ordering restrictions  as the class doing the declaration. This was considered a bug that was fixed by adding the contain function.
In this case, we ensure that the Apt::Source['elasticsearch'] definition is handled before the package is installed, but that doesn't ensure that Class[apt::update] (and more specifically the contained Exec['apt_update']) runs before the package.
In the case of apt, the apt::update class should come after the apt::source resources and before packages, but there's no safe way for the puppetlabs/apt module to set this up using contain, or adding the relationship to their module. The authors of the apt module recommend setting the Class['apt::update'] -> Package[...] relationship, at least for use cases where the repository and dependent package should be added in a single puppet run.

I have to +1 on the repo.pp method because of both class containment and also for context containment benefits you mentioned.
It's also how we manage apt dependencies internally and how I expect many others do to.

+1 on repo.pp as well

+1  on #452

Thank you for the feedback guys and @pcfens thank you for the extended write up.
Did anyone test the module with others when adding Class['apt::update'] -> Package[$elasticsearch::package_name] to the repo part to validate the package stuff works like expected?
Thanks!

:+1: on #452

#452 has been merged and bumping the version in metadata file soon and doing a release this week.


Failure to Model

These devices were previously modeled successfully, been monitored all day on a test deployment. I added some basic modeler plugins for interfaces and all the normal snmp basics and started getting this:
2021-09-18 04:33:13,641 ERROR zen.ZenModeler: Problem while executing plugin daviswr.snmp.ArubaInstant
2021-09-18 04:33:13,641 ERROR zen.ZenModeler: Traceback (most recent call last):
File "/opt/zenoss/Products/DataCollector/zenmodeler.py", line 669, in processClient
datamaps = plugin.process(device, results, self.log)
File "/var/zenoss/ZenPackSource/ZenPacks.daviswr.Aruba.Instant/ZenPacks/daviswr/Aruba/Instant/modeler/plugins/daviswr/snmp/ArubaInstant.py", line 357, in process
del getdata['title']
KeyError: 'title'

It should check for presence of the key 'title' in the getdata dict before trying to remove it now, 2b00ece91b3245c4b12219613e9597fdeb255a9c .
The pack sets these modeler plugins on /Network/Aruba/Instant by default:

zenoss.snmp.DeviceMap
zenoss.snmp.InterfaceMap
zenoss.snmp.SnmpV3EngineIdMap
daviswr.snmp.ArubaInstant

Curious what else you're modeling on the IAP? SNMP on these doesn't appear expose much more than IF-MIB and AI-AP-MIB.
Been building this pack with some AP-224s running 8.6.0, what are you using?
Also, I had to do a double-take on the repo name when I saw the notification email ;)

Oh yeah, i love your zenpacks - probably the most professional "still maintained" ones around.
Plugins are minimal:

Interestingly enough, after restarting Zenoss it seems to work again.
We're transitioning from 4.x to 6.x right now so this might all be Zenoss' own weirdness in the modern construct (like i've noticed that the network map wont update elements until Zenoss is restarted)

Weirder things afoot, it seems.
Now i'm getting s slew of bad XML errors :-\
2021-09-28 14:01:53,052 ERROR zen.zencommand: Error Running Parser <Products.DataCollector.Plugins.PluginLoader instance at 0x12c02bd8>
Traceback (most recent call last):
  File "/opt/zenoss/Products/ZenRRD/zencommand.py", line 588, in _processDatasourceResults
    parser.processResults(datasource, results)
  File "/var/zenoss/ZenPackSource/ZenPacks.daviswr.Aruba.Instant/ZenPacks/daviswr/Aruba/Instant/parsers/nmap.py", line 47, in processResults
    parse_tree = etree.fromstring(cmd.result.output)
  File "src/lxml/lxml.etree.pyx", line 3213, in lxml.etree.fromstring (src/lxml/lxml.etree.c:77697)
  File "src/lxml/parser.pxi", line 1819, in lxml.etree._parseMemoryDocument (src/lxml/lxml.etree.c:116494)
  File "src/lxml/parser.pxi", line 1707, in lxml.etree._parseDoc (src/lxml/lxml.etree.c:115144)
  File "src/lxml/parser.pxi", line 1079, in lxml.etree._BaseParser._parseDoc (src/lxml/lxml.etree.c:109543)
  File "src/lxml/parser.pxi", line 573, in lxml.etree._ParserContext._handleParseResultDoc (src/lxml/lxml.etree.c:103404)
  File "src/lxml/parser.pxi", line 683, in lxml.etree._handleParseResult (src/lxml/lxml.etree.c:105058)
  File "src/lxml/parser.pxi", line 624, in lxml.etree._raiseParseError (src/lxml/lxml.etree.c:104201)
XMLSyntaxError: None,
Error Running Parser <Products.DataCollector.Plugins.PluginLoader instance at 0x12c02bd8>
Traceback (most recent call last):
  File "/opt/zenoss/Products/ZenRRD/zencommand.py", line 588, in _processDatasourceResults
    parser.processResults(datasource, results)
  File "/var/zenoss/ZenPackSource/ZenPacks.daviswr.Aruba.Instant/ZenPacks/daviswr/Aruba/Instant/parsers/nmap.py", line 47, in processResults
    parse_tree = etree.fromstring(cmd.result.output)
  File "src/lxml/lxml.etree.pyx", line 3213, in lxml.etree.fromstring (src/lxml/lxml.etree.c:77697)
  File "src/lxml/parser.pxi", line 1819, in lxml.etree._parseMemoryDocument (src/lxml/lxml.etree.c:116494)
  File "src/lxml/parser.pxi", line 1707, in lxml.etree._parseDoc (src/lxml/lxml.etree.c:115144)
  File "src/lxml/parser.pxi", line 1079, in lxml.etree._BaseParser._parseDoc (src/lxml/lxml.etree.c:109543)
  File "src/lxml/parser.pxi", line 573, in lxml.etree._ParserContext._handleParseResultDoc (src/lxml/lxml.etree.c:103404)
  File "src/lxml/parser.pxi", line 683, in lxml.etree._handleParseResult (src/lxml/lxml.etree.c:105058)
  File "src/lxml/parser.pxi", line 624, in lxml.etree._raiseParseError (src/lxml/lxml.etree.c:104201)
XMLSyntaxError: None

Is this on 6.x or 4.2.5? I haven't been able to keep a single-host 6 stable in my home environment and thus still develop on 4.2.5... so it's completely untested on the newer architecture.
Would be nice to see snippets of a zencommand debug log with --showrawresults and --showfullcommand, to see if the call to $ZENHOME/bin/nmap even works and what its output is.

I'll see about adding some error handling in the mean time.

Try 11303c37005ed7ca9eefe19eeaf25d05c5cfcadc ?

Confirm it works at current revision for all our targets, thank you!


QDAC2: Clean up triggers and markers on context exit

Codecov Report

Merging #251 (794e9cf) into main (e7c94f5) will increase coverage by 0.58%.
The diff coverage is 93.66%.

@@            Coverage Diff             @@
##             main     #251      +/-   ##
==========================================
+ Coverage   19.25%   19.83%   +0.58%
==========================================
  Files         146      146
  Lines       18018    18160     +142
==========================================
+ Hits         3469     3602     +133
- Misses      14549    14558       +9

Files Changed
Coverage Δ

...rivers/tests/QDevil/test_sim_qdac2_source_sweep.py
100.00% <ø> (ø)

qcodes_contrib_drivers/drivers/QDevil/QDAC2.py
95.66% <83.33%> (-0.68%)
:arrow_down:

...drivers/tests/QDevil/test_sim_qdac2_source_list.py
100.00% <100.00%> (ø)

...trib_drivers/tests/QDevil/test_sim_qdac2_square.py
100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
:loudspeaker: Have feedback on the report? Share it here.


Improve "Getting Started" and "Setup" docs of native automation

From #937 by @markwigzell:

I recommend changing the documentation to just having the one "Getting Started" section incorporate the Setup into it, and have it handle both IOS and Android in the same "Getting Started" section. Also, delay introducing the actual test code until all necessary steps have been sequentially outlined. Isolate the optional parts clearly so the flow is not broken. Because of the back and forth nature of how the set up is documented, I actually ended up missing some essential aspect of Setup.

I agree.

Related and kind-of duplicate: #948

Fixed in #1345, except for the problem described in the OP (lol).
I've changed my mind on. IMHO, common setup being before Android-specific and iOS-specific sections makes sense.


Open and Save dialogs in TestApp don't show file names (MacOS)

weird...

On each stop the entry's fields change... d_name's content also changes... I don't know if it is on purpose but the value at index 0 is always 0

0 is a null terminator, it could be that macos libc returns malformed c-strings, if d_name ends with a 0 again then i could make a workaround, but i have to do some more research before doing something unintended.

I added a memory dump to the method could you please run it again and paste the output

I selected all the text in the console window with ctrl+A and pasted it in a text file... Probably some of the text is cut out because of the console buffer limit
dump.txt
I don't know, maybe we should use .NET's  file enumeration apis, instead of using libc directly

It's enough for me to figure out what's wrong, it looks like d_type is too small

I changed some things (I call the system lib from osx directly) and added a test project for mac bypassing the ui stuff "MacTestThing"

This is the output
dump.txt

Okay i think i solved it, could you try the dialog again?

Now it works fine


Implemented dynamic getCommands() and functionality of close command

Got getCommands() in CommandManager.cs to dynamically add all of the commands in the Commands folder, so that we don't have to manually call each one.
Close room was also implemented but the icons are not yet working. When you enter a room and type /close, a message should pop up saying that the room is now closed. The message bar at the bottom is also blocked out. If you go back to the lobby, you should be able to check and uncheck closed rooms once, with the room disappearing. It doesn't work more than once due to caching, so once it is merged into dev and we get that set up, it should work but cannot be tested until then.
#149

This seems to work as heather described it :) :shipit:


target data pipeline: update nextclade CLI to 3.8 or greater

We currently control the nextclade version by pulling their docker image, but looks like we can all install it via conda (bioconda channel)

Closing this, since this upgrade has been incorporated into #8.


Multiple environments and custom ShareViewController.swift

Is it possible to use this library with different environments on iOS (schemas)?
Also, I don't need a post dialog when sharing images into the app. Can I use custom ShareViewController.swift, which will be linked to custom MainInterface.storyboard?

Hi. I ran across the similar problem.
I overcame using this:
1.) Declare a custom variable
Use this to create a custom variable:  https://stackoverflow.com/questions/58432568/swift-get-scheme-name-or-swift-compiler-custome-flags-value-at-run-time
2.). Use this variable in ShareViewController.swift like this:
let schemeName = Bundle.main.infoDictionary!["CURRENT_SCHEME_NAME"] as! String
lazy var hostAppBundleIdentifier = (schemeName == "dev") ? "devPackageName":"prodPackageName"


HDFS-16697.Randomly setting “dfs.namenode.resource.checked.volumes.minimum” will always prevent safe mode from being turned off

Description of PR
Add Precondition.checkArgument() for minimumRedundantVolumes to ensure that the value is greater than the number of NameNode storage volumes to avoid never being able to turn off safe mode afterwards.
JIRA:[HDFS-16697]
How was this patch tested?
It is found that “dfs.namenode.resource.checked.volumes.minimum” lacks a condition check and an associated exception handling mechanism, which makes it impossible to find the root cause of the impact when a misconfiguration occurs.
This patch provides a check of the configuration items，it will throw a IllegalArgumentException and detailed error message when the value of "dfs.namenode.resource.checked.volumes.minimum" is set greater than the number of NameNode storage volumes to avoid the misconfiguration from affecting the subsequent operation of the program.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 56s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
40m 28s

trunk passed

+1 :green_heart:
compile
1m 41s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
compile
1m 32s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m 18s

trunk passed

+1 :green_heart:
mvnsite
1m 42s

trunk passed

+1 :green_heart:
javadoc
1m 21s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
1m 47s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 46s

trunk passed

+1 :green_heart:
shadedclient
25m 54s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

-1 :x:
mvninstall
0m 25s
/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch failed.

-1 :x:
compile
0m 26s
/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>.txt
hadoop-hdfs in the patch failed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>.

-1 :x:
javac
0m 26s
/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>.txt
hadoop-hdfs in the patch failed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>.

-1 :x:
compile
0m 26s
/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
hadoop-hdfs in the patch failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.

-1 :x:
javac
0m 26s
/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
hadoop-hdfs in the patch failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.

-1 :x:
blanks
0m  0s
/blanks-eol.txt
The patch has 3 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

-0 :warning:
checkstyle
1m  2s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 6 new + 8 unchanged - 0 fixed = 14 total (was 8)

-1 :x:
mvnsite
0m 27s
/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch failed.

-1 :x:
javadoc
0m 26s
/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>.txt
hadoop-hdfs in the patch failed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>.

-1 :x:
javadoc
0m 26s
/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
hadoop-hdfs in the patch failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.

-1 :x:
spotbugs
0m 26s
/patch-spotbugs-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch failed.

-1 :x:
shadedclient
11m 45s

patch has errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
0m 29s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch failed.

+1 :green_heart:
asflicense
0m 38s

The patch does not generate ASF License warnings.

93m  6s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4653/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4653

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 84da643c5357 4.15.0-166-generic #174-Ubuntu SMP Wed Dec 8 19:07:44 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / b3810875d8ef5c15f54332b5cbe505eada2ec6c0

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4653/1/testReport/

Max. process+thread count
528 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4653/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 54s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
40m 59s

trunk passed

+1 :green_heart:
compile
1m 40s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
compile
1m 30s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m 21s

trunk passed

+1 :green_heart:
mvnsite
1m 41s

trunk passed

+1 :green_heart:
javadoc
1m 18s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
1m 46s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 45s

trunk passed

+1 :green_heart:
shadedclient
25m 44s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

-1 :x:
mvninstall
0m 26s
/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch failed.

-1 :x:
compile
0m 26s
/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>.txt
hadoop-hdfs in the patch failed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>.

-1 :x:
javac
0m 26s
/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>.txt
hadoop-hdfs in the patch failed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>.

-1 :x:
compile
0m 26s
/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
hadoop-hdfs in the patch failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.

-1 :x:
javac
0m 26s
/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
hadoop-hdfs in the patch failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.

-1 :x:
blanks
0m  0s
/blanks-eol.txt
The patch has 3 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

-0 :warning:
checkstyle
1m  1s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 4 new + 8 unchanged - 0 fixed = 12 total (was 8)

-1 :x:
mvnsite
0m 27s
/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch failed.

-1 :x:
javadoc
0m 26s
/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>.txt
hadoop-hdfs in the patch failed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>.

-1 :x:
javadoc
0m 27s
/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
hadoop-hdfs in the patch failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.

-1 :x:
spotbugs
0m 26s
/patch-spotbugs-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch failed.

-1 :x:
shadedclient
11m 47s

patch has errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
0m 29s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch failed.

+1 :green_heart:
asflicense
0m 38s

The patch does not generate ASF License warnings.

93m 16s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4653/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4653

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 7b67b373ed57 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 95db4661eae7ac4c62c48dfe85ac485dd8da846f

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4653/2/testReport/

Max. process+thread count
534 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4653/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 55s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
42m  4s

trunk passed

+1 :green_heart:
compile
1m 40s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
compile
1m 31s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m 19s

trunk passed

+1 :green_heart:
mvnsite
1m 40s

trunk passed

+1 :green_heart:
javadoc
1m 21s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
1m 46s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 48s

trunk passed

+1 :green_heart:
shadedclient
26m  3s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 22s

the patch passed

+1 :green_heart:
compile
1m 28s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javac
1m 28s

the patch passed

+1 :green_heart:
compile
1m 19s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
1m 19s

the patch passed

-1 :x:
blanks
0m  0s
/blanks-eol.txt
The patch has 2 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1 :green_heart:
checkstyle
1m  0s

the patch passed

+1 :green_heart:
mvnsite
1m 28s

the patch passed

+1 :green_heart:
javadoc
0m 56s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
1m 32s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 35s

the patch passed

+1 :green_heart:
shadedclient
26m  0s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
340m 52s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
1m  2s

The patch does not generate ASF License warnings.

460m 16s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.mover.TestMover

hadoop.hdfs.TestDFSInotifyEventInputStreamKerberized

hadoop.hdfs.TestRollingUpgradeRollback

hadoop.hdfs.qjournal.TestSecureNNWithQJM

hadoop.hdfs.TestRollingUpgrade

hadoop.hdfs.qjournal.TestNNWithQJM

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4653/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4653

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 194712d0a8d6 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 9ca81e12c62e111eccb8c4f8753edbef161d472a

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4653/3/testReport/

Max. process+thread count
2116 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4653/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 38s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
38m 23s

trunk passed

+1 :green_heart:
compile
1m 46s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
compile
1m 38s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m 22s

trunk passed

+1 :green_heart:
mvnsite
1m 45s

trunk passed

+1 :green_heart:
javadoc
1m 25s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
1m 49s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 39s

trunk passed

+1 :green_heart:
shadedclient
23m  4s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 25s

the patch passed

+1 :green_heart:
compile
1m 26s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javac
1m 26s

the patch passed

+1 :green_heart:
compile
1m 23s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
1m 23s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  1s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 2 new + 8 unchanged - 0 fixed = 10 total (was 8)

+1 :green_heart:
mvnsite
1m 27s

the patch passed

+1 :green_heart:
javadoc
0m 58s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
1m 29s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 24s

the patch passed

+1 :green_heart:
shadedclient
22m 25s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
240m 52s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
1m 14s

The patch does not generate ASF License warnings.

350m 24s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4653/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4653

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 7818fac7b3f8 4.15.0-169-generic #177-Ubuntu SMP Thu Feb 3 10:50:38 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / ae44e2db8fdd7729f1d2766626482c5d5d236fa7

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4653/4/testReport/

Max. process+thread count
3711 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4653/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 49s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
40m 46s

trunk passed

+1 :green_heart:
compile
1m 44s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
compile
1m 33s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m 21s

trunk passed

+1 :green_heart:
mvnsite
1m 48s

trunk passed

+1 :green_heart:
javadoc
1m 22s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
1m 47s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
4m 11s

trunk passed

+1 :green_heart:
shadedclient
26m 59s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 24s

the patch passed

+1 :green_heart:
compile
1m 30s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javac
1m 30s

the patch passed

+1 :green_heart:
compile
1m 26s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
1m 26s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  6s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 2 new + 8 unchanged - 0 fixed = 10 total (was 8)

+1 :green_heart:
mvnsite
1m 38s

the patch passed

+1 :green_heart:
javadoc
1m  0s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
1m 36s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 52s

the patch passed

+1 :green_heart:
shadedclient
26m 37s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
374m 56s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
1m 12s

The patch does not generate ASF License warnings.

495m 11s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.blockmanagement.TestBlockTokenWithShortCircuitRead

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4653/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4653

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 5db97312c0a7 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 438bd3edf65d372d2c68e0fca937e1282826ff37

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4653/5/testReport/

Max. process+thread count
1970 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4653/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 53s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
42m 29s

trunk passed

+1 :green_heart:
compile
1m 48s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
compile
1m 41s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m 22s

trunk passed

+1 :green_heart:
mvnsite
1m 51s

trunk passed

+1 :green_heart:
javadoc
1m 26s

trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
1m 47s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
4m  3s

trunk passed

+1 :green_heart:
shadedclient
26m 16s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 37s

the patch passed

+1 :green_heart:
compile
1m 41s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javac
1m 41s

the patch passed

+1 :green_heart:
compile
1m 30s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
1m 30s

the patch passed

+1 :green_heart:
blanks
0m  1s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  3s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 2 new + 8 unchanged - 0 fixed = 10 total (was 8)

+1 :green_heart:
mvnsite
1m 39s

the patch passed

+1 :green_heart:
javadoc
1m  8s

the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS>

+1 :green_heart:
javadoc
1m 41s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
4m  4s

the patch passed

+1 :green_heart:
shadedclient
29m 19s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
371m 43s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
1m  2s

The patch does not generate ASF License warnings.

497m 14s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4653/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4653

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux e91209389bb6 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 130f88ad8f18d7c81c112e54a6e794fa10292713

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu<IP_ADDRESS> /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4653/6/testReport/

Max. process+thread count
1967 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4653/6/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.


Added M4 iPad Pro & M2 iPad Air

Added support for new Apple M4 chip (+ M4 iPad Pro) and iPad Air with M2

Thanks for your implementation!
I'll merge them.


modify spelling error

Description

Todos

[ ] Tests
[ ] Documentation
[ ] Release note

Release Note

None required

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.maao seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.maao seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

@420691301 thanks! Could you make this change to the corresponding doc in the master/ directory as well?


Make test more tolerant

Test tests/split/test_userwise_split.py fails on i686 (float rounding issue?).
Made test more tolerant to release the new version.

Codecov Report

Merging #86 (da81d88) into main (777ca8a) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #86      +/-   ##
==========================================
- Coverage   94.64%   94.61%   -0.03%
==========================================
  Files          72       72
  Lines        3679     3679
==========================================
- Hits         3482     3481       -1
- Misses        197      198       +1


datastore: Don't allow duplicate IPs to be added

Although adding IP addresses to the pool checks for duplicates in the IP
addresses already added it does not check for duplicates in the set to
be added.
This change checks that you can't add duplicates that are specified in
the same request.
Signed-off-by: Rob Bradford<EMAIL_ADDRESS>

Coverage decreased (-0.001%) to 65.682% when pulling 140f47197e049adec7a30552427bab01e471c8ea on rbradford:external-ip-duplicate into 31b05dee431b4e76fc6065cd4d4f93f807cf4ca2 on 01org:master.


Add a utility script for converting fonts to cpp/hpp files

That would be useful :)

What does it do?

Seems like res2c.py in the develop branch can handle this.


removed duplicate word

fixed typo
(new to git, sorry if I've done something incorrectly)

Thanks for the fix!


BUG: Weird interaction with other modules

This bit of code is adapted from two pylsl examples and just starts one thread to send samples and receives them in the main thread, works on Linux (Ubuntu 20.10, pip) as it correctly starts printing a bunch of random samples:

import time
from multiprocessing import Process
from random import random as rand

from pylsl import StreamInfo, StreamOutlet, local_clock, resolve_stream, StreamInlet
import scipy.fft

def _send():
    info = StreamInfo('BioSemi', 'EEG', 8, 100, 'float32', 'myuid34234')
    outlet = StreamOutlet(info)
    start_time = local_clock()
    sent_samples = 0
    while True:
        elapsed_time = local_clock() - start_time
        required_samples = int(100 * elapsed_time) - sent_samples
        for sample_ix in range(required_samples):
            # make a new random n_channels sample; this is converted into a
            # pylsl.vectorf (the data type that is expected by push_sample)
            mysample = [rand() for _ in range(8)]
            # now send it
            outlet.push_sample(mysample)
        sent_samples += required_samples
        # now send it and wait for a bit before trying again.
        time.sleep(0.01)

print('Starting serving process')
process = Process(target=_send, daemon=True)
process.start()

print("looking for an EEG stream...")
streams = resolve_stream('type', 'EEG')
inlet = StreamInlet(streams[0])
while True:
    sample, timestamp = inlet.pull_sample()
    print(timestamp, sample)

However, if I move the import scipy.fft to before the pylsl import, things break. The stream is never found and it just hangs on the resolve_stream step. I narrowed the from scipy import fft issue down to it being due to an import of scipy.fft._pocketfft.pypocketfft, which is a pybind11-compiled module. (I can also experience it when other modules are imported in that same spot in the script, so I don't think it's specific to SciPy, though.)
This is on Linux, where I noticed there is a known issue that multiple threads are not supported. Is this what is meant by "not supported" in that it might work in some situations but not others depending on the import order? If so, is it expected that the conda-forge version will not have this problem, or is it some fundamental limitation? Also I'm not sure if this is related to #6 / #5 or not.
The above example is a minimized version of how we unit test and build docs for MNE-Realtime, hence my interest in it being fixed if at all possible.

What Linux distro are you on? I only have Ubuntu 20.04 in easy reach.
It would help narrow down the problem tremendously if you could please try the following.
pip install pylsl to get the latest version. Then git clone https://github.com/sccn/liblsl.git, build that, and copy the liblsl.so it outputs to the pylsl folder (replacing the old liblsl.so). If this works then we know it's not a liblsl version problem, it's just how liblsl is built for the linux pylsl packages.
We're hoping the next version of liblsl will have a different distribution process. See https://github.com/sccn/liblsl/issues/110
Then we don't need to build liblsl for manylinux, so hopefully we can avoid this problem altogether. Getting liblsl into Debian or NeuroDebian might take longer than you'd like, so maybe we can start with a custom conda channel.

is it expected that the conda-forge version will not have this problem?

Sorry what are you referring to here? Did you test something installed from conda and it didn't have the bug?
I'm guessing not pylsl because that's not on conda-forge.

I 1) git cloned this repo, 2) pip install -ve .ed it to use latest master, 3) git cloned liblsl.git, and then:
$ cmake -S . -B build -G Ninja
$ cd build
$ ninja -j 4
$ ln -s $PWD/liblsl.so ../../liblsl-Python/pylsl/lib/

And everything works! And when I replace liblsl-Python/pylsl/lib/liblsl.so with:

https://github.com/sccn/liblsl/releases/download/1.13.1/liblsl-1.13.1-manylinux1_x64.so - works
https://github.com/sccn/liblsl/releases/download/v1.14.0/liblsl-1.14.0-manylinux1_x64.so - works
https://github.com/sccn/liblsl/releases/download/1.13.1/liblsl-1.13.1-manylinux2010_x64.so - fails
https://github.com/sccn/liblsl/releases/download/v1.14.0/liblsl-1.14.0-manylinux2010_x64.so - fails
~/.local/lib/python3.9/site-packages/pylsl/lib/liblsl.so from the 1.14.0 installation by pip - fails

And then I verified that the 1.14.0 manylinux2010 library has the same MD5 (1793cbd2a45621572a14ff9090c57f32) as the 1.14.0 from PyPi / ~/.local/.... So it seems like the manylinux2010 build is for some reason problematic.

Thank you so much! This was tremendously helpful.
I deleted all of the manylinux2010 releases from pypi. I hope the manylinux1 release is adequate for most users until we start shipping liblsl through package managers.

Indeed I just did pip uninstall pylsl; pip install --no-cache pylsl and things appear to be working, thanks!


Optimize {Try}FormatDecimal

This improves decimal formatting performance by 1.09x and removes an unused nMinDigits parameter from many functions.

Most of this is modifying files in shared partition. Could you please submit it via CoreCLR - we have a better CI test coverage there.

I fixed the pointer subtraction and left only the non-shared part here.


Adding Dockerfile and instructions

Introduces a simple Dockerfile for increased platform portability.
The Dockerfile is a 2-stage build, resulting in a minimal Alpine Linux image. Though it is not necessary to specify, the GOOS and GOARCH build arguments are provided for future cross-platform build capability.
The Makefile has 2 new platform-specific build commands, a docker build example, a docker run example, and a release task to push images to Docker Hub. If you feel that this PR is acceptable, it would be best for you to run the make image and make release commands so that the resulting image ends up under your own user. It would be even better to link the Github repo to the Docker Hub repo so that builds are automated and make release isn't necessary.

Haah... I see that you just added a Dockerfile today! Nice work.
Are there any ideas from this PR that you find useful?

If you rebase the Dockerfile, I'm happy to merge this as yours is better

I noticed you removed the Makefile too... should that stay deleted?

Sorry to nitpack. Couple things:
The docker build stuff is now automated by goreleaser, so probably don't need that in the Makefile.
It'd be good to keep the WORKDIR outside of /root.


HostConfig Editor for UWP visualizer

Now that Host Config can be parsed and merged with the default HostConfig, UWP visualizer needs a HostConfig Editor/Loader like the one for the AdaptiveCard Payload.

Oh this is done, I added a host config editor to the UWP Visualizer a month ago or so :)


Graceful Descheduling instead of Eviction

Is your feature request related to a problem? Please describe.

Is there a graceful resolution(like rolling update) for Eviction?
For now, descheduler evicts the pods which will cause a service interruption.
And I wonder that can I customize the config to make it Restart the pods instead of Eviction?
like this:
kubectl rollout restart deployment/abc

Describe the solution you'd like

Provide an optional config to restart pods instead of evict pods, so that the service will not be interrupted.
Describe alternatives you've considered

Or create new pods before evict old pods, when new pods are ready, old pods can be deleted.
What version of descheduler are you using?
descheduler version: v0.31.0
Additional context

For now, descheduler evicts the pods which will cause a service interruption.

Would you please elaborate on why that is, given that it uses the eviction api. Do you define a PodDisruptionBudget?

Would you please elaborate on why that is, given that it uses the eviction api. Do you define a PodDisruptionBudget?

Sure, I'll provide more details about our scenario:
We have two kubernetes gpu node pools, A as monthly(one node) and B as elastic(zero node, but with autoscaler).
now a deployment with one replicas using gpu is running on A(exclusive to all resources of one node), when we rolling update it, it will trigger the autoscaler, and be scheduled to B, then A will be in low usage.
Since monthly node is cheaper, we want the pod to be rescheduled and go back to A, so that the elastic node can be recovered to zero.
In conclusion, this workload takes up almost all of resources on one node, and there's only one replicas so we can't use PDB(using multiple replicas will increase cost).
We hope that, when rolling update, it will be scheduled to the elastic node. After rolling update is done, trigger the reschedule and evict the workload to monthly node(depends on preferredDuringSchedulingIgnoredDuringExecution).
Also we don't want the service interrupted, so I'm looking for a graceful method to reschedule(create the pod before evict it, just like rolling update or kubectl rollout restart deployment).


docs: clarify behaviour of <Tabs> children

Pre-flight checklist

[ ] I have read the Contributing Guidelines on pull requests.
[ ] If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
[ ] If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Test Plan

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/
Related issues/PRs

Bad branch? You seem to have removed a lot of stuff...

Bad branch? You seem to have removed a lot of stuff...

Yeah I pushed from a very out of date local copy. Closing - will recreate.


Support for partials

Is there any support for any kind of partial system like ejs, handlebars, pug, moustache etc?

@zoranpopovic Thank you! Those parts I got working. (And I just saw that I already import ejs, calling ejs..render(...) eventually.
But the problem are partials, which are not recognised. And a solution how to make a navigation. None of that works in my codesandbox example (to which I added the root: process.cwd()): https://codesandbox.io/s/vite-with-virtual-html-plugin-92pkx
Did you get these things running?
UPDATE: I think I should once more point out that I am looking for a partial solution without any of those frameworks like Vue or React. Reason being that I have to create click dummies that will eventually be integrated into a CMS that has its own templating framework. Which means the resulting CSS and JS should be free of those frameworks and the components should be mirrored from what is created within vite with a template partial system.

did you still have partial file error?
how about look this:
https://github.com/WindsonFF/vite-plugin-virtual-html/blob/d0b747aa1158ec85f2b147ae4171c30c5154b523/vite.config.ts#L30
and
https://github.com/WindsonFF/vite-plugin-virtual-html/blob/d0b747aa1158ec85f2b147ae4171c30c5154b523/demo/demo1/demo1.html#L11

@WindsonFF So as it turns out there are 2 things:

those who can read and write, clearly have a better life. I called my template "test", but required "teXt".
The so-called "relative" path seems to be relative form vite.config.js, NOT from the file where the partial is included. This is actually NOT relative in my understanding, but absolute from the root directory.

So thank you for your help and patience - I got that part working!
Remains the question how to build a navigation? If I can ask you once more to have a look at my codesandbox example you will see that there is a link to a subpage. But no matter how I formulate the link (/src/pages/subpage/index.html, ./subpage/index.html ...) it won't work.
How can links like these be resolved without a router?

@WindsonFF Thank you!
I provided a PR (#9). If you want to, we can continue over there. I personally think this plugin is very powerful, but needs more documentation. Maybe I can help with that...