curveadm playbook deploy memcached

deploy_memcached
目前，部署memcahced 一个服务就要对应一个host，修改起来繁琐，可以对这方面进行优化，使得对一台机器部署多个服务时仅需要修改一个host即可。
At present, deploying a memcahced service requires corresponding to a host, which is cumbersome to modify. This aspect can be optimized so that only one host needs to be modified when deploying multiple services on a machine.
Registration procedure
Step 1. Add a comment when you sign up.The purpose of comments is for us to understand you and determine whether you have the basic ability to complete this issue.

If you are a student, please introduce your school, major, programming language, technical fields of interest, what you are good at, and why you chose this issue.
If you are already working, please introduce your company, career, work content, technical fields of interest, and why you chose this issue.

Step 2. Use WeChat to add the Curve community assistant "Curve" as a WeChat friend, tell your GitHub ID, and send the Issue link of your choice. The assistant will invite you to communicate with the mentor  by WeChat.
Step 3. In order to better complete each development task, the mentor will select the developer who best matches the issue based on everyone's comment on GitHub and communication status by WeChat. If you are not selected, please select another issue.
Tips

Before developing, please read the dev guideline( https://ask.opencurve.io/t/topic/201) carefully and communicate with your mentor.
Please submit a draft PR before 11.29, and the mentor will review it within 2-5 working days and may guide you to modify the PR based on the actual situation.
If you successfully merge into PR before 12.27 and you will receive gifts carefully prepared by the Curve community.

hi, I'm a student majoring in software engineering in hdu, who is interested in distributed system. I'm good at golang and javascript. Familiar at kubernetes and linux, I wish to contribute to this task.

Hello, I am a student from UESTC. I am good at golang language. I have learned k8s related knowledge and am interested in this issue.
I think a good solution is to reformat the yaml files. In current versions, deploying multiple services on a single host(<IP_ADDRESS>) requires the following configuration in hosts.yaml:
- host: server-host1
  hostname: <IP_ADDRESS>
  labels:
    - memcached
  envs:
    - IMAGE=memcached:1.6.17
    - LISTEN=<IP_ADDRESS>
    ...

- host: server-host2
  hostname: <IP_ADDRESS>
  labels:
    - memcached
  envs:
    - IMAGE=memcached:1.6.17
    - LISTEN=<IP_ADDRESS>
    ...

I think it can be modified as:
- host: server-host1
  hostname: <IP_ADDRESS>
  - servername: server1
    labels:
      - memcached
    envs:
      - IMAGE=memcached:1.6.17
      - LISTEN=<IP_ADDRESS>
      ...

  - servername: server1
    labels:
      - memcached
    envs:
      - IMAGE=memcached:1.6.17
      - LISTEN=<IP_ADDRESS>
      ...

so that only one host needs to be modified when deploying multiple services on a machine.
I hope the task will be assigned to me！

Hello, I am a student from UESTC. I am good at golang language. I have learned k8s related knowledge and am interested in this issue. I think a good solution is to reformat the yaml files. In current versions, deploying multiple services on a single host(<IP_ADDRESS>) requires the following configuration in hosts.yaml:
- host: server-host1
  hostname: <IP_ADDRESS>
  labels:
    - memcached
  envs:
    - IMAGE=memcached:1.6.17
    - LISTEN=<IP_ADDRESS>
    ...

- host: server-host2
  hostname: <IP_ADDRESS>
  labels:
    - memcached
  envs:
    - IMAGE=memcached:1.6.17
    - LISTEN=<IP_ADDRESS>
    ...

I think it can be modified as:
- host: server-host1
  hostname: <IP_ADDRESS>
  - servername: server1
    labels:
      - memcached
    envs:
      - IMAGE=memcached:1.6.17
      - LISTEN=<IP_ADDRESS>
      ...

  - servername: server1
    labels:
      - memcached
    envs:
      - IMAGE=memcached:1.6.17
      - LISTEN=<IP_ADDRESS>
      ...

so that only one host needs to be modified when deploying multiple services on a machine.
I hope the task will be assigned to me！

In this case, you also need to write a lot of configuration files. You can refer to the design of topology's replica. Add ${service_replica_sequence} to the port and file location. to distinguish.

Thanks to guidance, the code has been modified to support replicas and ${replicas_sequence}. Now, when deploying the memcached cluster, hosts.yaml can be written as follows：
global:
  user: curve
  ssh_port: 22
  private_key_file: /home/curve/.ssh/id_rsa

hosts:
  - host: server-host1
    hostname: <IP_ADDRESS>
    labels:
      - memcached
    envs:
      - SUDO_ALIAS=sudo
      - ENGINE=docker
      - IMAGE=memcached:1.6.17
      - EXPORTER_IMAGE=quay.io/prometheus/memcached-exporter:v0.13.0
      - LISTEN=<IP_ADDRESS>
      - PORT=1121${replicas_sequence}
      - EXPORTER_PORT=915${replicas_sequence}
      - USER=root
      - MEMORY_LIMIT=32768 # item memory in megabytes
      - MAX_ITEM_SIZE=8m # adjusts max item size (default: 1m, min: 1k, max: 1024m)
      - EXT_PATH=/mnt/memcachefile/cachefile:102${replicas_sequence}G
      - EXT_WBUF_SIZE=8 # size in megabytes of page write buffers.
      - EXT_ITEM_AGE=1 # store items idle at least this long (seconds, default: no age limit)
      - VERBOSE="v"
    replicas: 3

  - host: server-host2
    hostname: <IP_ADDRESS>
    labels:
      - memcached
    envs:
      - SUDO_ALIAS=sudo
      - ENGINE=docker
      - IMAGE=memcached:1.6.17
      - EXPORTER_IMAGE=quay.io/prometheus/memcached-exporter:v0.13.0
      - LISTEN=<IP_ADDRESS>
      - PORT=11211
      - EXPORTER_PORT=9151
      - USER=root
      - MEMORY_LIMIT=32768 # item memory in megabytes
      - MAX_ITEM_SIZE=8m # adjusts max item size (default: 1m, min: 1k, max: 1024m)
      - EXT_PATH=/mnt/memcachefile/cachefile:102${replicas_sequence}G
      - EXT_WBUF_SIZE=8 # size in megabytes of page write buffers.
      - EXT_ITEM_AGE=1 # store items idle at least this long (seconds, default: no age limit)
      - VERBOSE="v"


deploy_revision ends up nuking all the releases if a deploy fails, because a reference can't be resolved.

Chef 11.16.4,  deploying from git.
If rollback_on_error is set = true, and the release tag is fat fingered and not found, the complete releases/ directory, destroying the server! leading to a fun few hours of production recovery
   [2015-06-12T22:45:00+00:00] DEBUG: Re-raising exception: Chef::Exceptions::UnresolvableGitReference - deploy_revision[/home/XX] (XX::webserver line 232) had
   an error: Chef::Exceptions::UnresolvableGitReference: Unable to parse SHA reference for '20150612.xx' in repository 'git@github.com:XX/yy.git'. Verify your (case-se
   nsitive) repository URL and revision.
   `git ls-remote` output:
   /opt/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-11.16.4/lib/chef/mixin/why_run.rb:241:in `run'
     /opt/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-11.16.4/lib/chef/mixin/why_run.rb:322:in `block in run'
     /opt/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-11.16.4/lib/chef/mixin/why_run.rb:321:in `each'
     /opt/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-11.16.4/lib/chef/mixin/why_run.rb:321:in `run'
     /opt/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-11.16.4/lib/chef/provider.rb:134:in `process_resource_requirements'
     /opt/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-11.16.4/lib/chef/provider.rb:111:in `run_action'
     /opt/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-11.16.4/lib/chef/provider/deploy.rb:259:in `run_scm_sync'
     /opt/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-11.16.4/lib/chef/provider/deploy.rb:254:in `update_cached_repo'
     /opt/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-11.16.4/lib/chef/provider/deploy.rb:154:in `deploy'
     /opt/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-11.16.4/lib/chef/provider/deploy.rb:109:in `block in action_deploy'
     /opt/chef/embedded/lib/ruby/gems/1.9.1/gems/chef-11.16.4/lib/chef/provider/deploy.rb:443:in `with_rollback_on_error'

followed by a total wipe of the releases directory:
   [2015-06-12T22:44:59+00:00] INFO: Removing failed deploy */home/XX/releases/*
   [2015-06-12T22:45:00+00:00] INFO: Running queued delayed notifications before re-raising exception

Looking at the code in 11-stable, this is still an issue !

Still an issue in 12?

12 requires ruby >2 (https://www.chef.io/blog/2014/11/25/ruby-1-9-3-eol-and-chef-12/)
It's not an option for us.

11 is not receiving bugfixes only security updates.  if this bug affects only 11 or if you hit any other bugs that affect only 11 those will not be getting fixed.  you should use the omnibus updaters which come pre-packaged with ruby 2.x and not be rolling your own distro or gem solutions to avoid this problem.  we cannot and will not support bugs specific to chef running in distro rubies or hand rolled rubies.

The code in: https://github.com/chef/chef/blob/11-stable/lib/chef/provider/deploy/revision.rb#L45 seems relatively trival to fix... and this is a pretty critical issue ((which according to support, is still applicable to 12!)


Double strip logs

Timings link
No response
Expected behavior
In vanilla, when you right click on a log to strip it, it only does it once.
Observed/Actual behavior
In purpur based servers, it seems that the axe triggers twice, along with the sound.
This does not strip more logs than you expected, but is still quite an annoyance.
Steps/models to reproduce
Install purpur.
Strip a log with any axe.
Purpur version
This server is running Purpur version git-Purpur-1287 (MC: 1.17.1) (Implementing API version 1.17.1-R0.1-SNAPSHOT) (Git: 01b35a2 on ver/1.17.1)
You are running the latest version
Previous version: git-Purpur-1285 (MC: 1.17.1)
Agreements

[X] I am running the latest version of Purpur available from https://purpur.pl3x.net/downloads.
[X] I have searched for and ensured there isn't already an open issue regarding this.
[X] My version of Minecraft is supported by Purpur.

Other
No response

this is happen when vanilla blocks strip meet purpur, also happen with hoe
they trigger twice
i suggest, cancel purpur custom strip on vanilla blocks stripable

I just tried this out myself and I am not seeing these actions double up. I tested using a diamond axe on an oak log, and a diamond hoe on grass and a plugin listening to the PlayerInteractEvent. The event fired once per hand, like normal. I then enabled sound subtitles to see if the sound was playing twice, which it is not. I also only see one arm swing animation for these actions.
Tested on Purpur #1313 using this plugin:
public final class Test extends JavaPlugin {
    @Override
    public void onEnable() {
        getServer().getPluginManager().registerEvents(new Listener() {
            @EventHandler
            public void on(PlayerInteractEvent event) {
                if (event.getHand() != EquipmentSlot.HAND) {
                    return;
                }
                event.getPlayer().sendMessage("Hmm");
            }
        }, this);
    }
}

That might be true but when you listen carefully you can really hear the sound being played twice, tested on build 1314

That might be true but when you listen carefully you can really hear the sound being played twice, tested on build 1314

you don't need to listen closely with sound subtitles


Missing note with the EF Core version the feature was introduced on

For example:
[!NOTE] This feature was introduced in EF Core 2.0.
It is probably missing in other topics as well.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b7c9bd3e-4b99-9acf-48d8-e47bc53eb54e
Version Independent ID: 220e0a6c-d227-956a-d27a-7c88804f770c
Content: Global Query Filters - EF Core
Content Source: entity-framework/core/querying/filters.md
Product: entity-framework
GitHub Login: @anpete
Microsoft Alias: divega

@maumar  given that anything below 2.1 is out of service, can I close this issue?

Yeah, we generally do this when introducing docs for new features, and remove the note a couple of releases later. Definitely no use in going back to stuff introduced a long time ago.


Add packaging build changes and scripts.

Ported @SedarG's changes to enable proper packaging and the project changes he made to support that.
Add build-packages scripts.
Updated pipeline builds to call build-packages and publish the packages.
Minor other pipeline build fixes for problems discovered testing this.
Pipeline build with these changes: https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_build/index?buildId=465040&_a=summary.

Hi @crummel, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
TTYL, DNFBOT;

@SedarG @dagood @joshfree @jkotas

@dagood @jkotas Updated for your comments.  New successful pipeline build is https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_build/index?buildId=480103&_a=summary.

Otherwise looks fine to me.

@jkotas Adding the ConvertCommonMetadataToAdditionalProperties build target back in seems to have fixed the problem and not broken anything (https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_build/index?buildId=480356&_a=summary).  I'm not sure why this was originally removed, so if that seems reasonable to you then I think we're good.

Do we still need the change to disable the parallel build?

No, I took that out, parallel builds are enabled again.

Thanks!

@crummel Is the official build going to run and packages get published automatically after this change, or is there still something left to enable?

@jkotas With this change we are publishing Windows and Mac packages to the dotnet-core MyGet feed.  I logged https://github.com/dotnet/corert/issues/2389 to change the way we publish packages that will make Linux work.


jwt-issuer endpoint

the same protocol specific metadata jwks should be then published in the .well-known/jwt-issuer endpoint according to https://www.ietf.org/id/draft-terbu-sd-jwt-vc-02.html#name-jwt-issuer-metadata-response-3

according to the current sd jwt vc specs, the metadata purpose is only related to vci (vc issuers) and not RP (credential verifier) therefore at this stage, unless the interop might require this feature, this endpoint is not required anymore


Fix imcompatible between presto and velox when hash double/float -0.0

For double/float -0.0 and 0.0, folly::hasher will return the same value.
but in presto, the return hash values are not equal. We should firstly
cast double/float to longBits, then call folly::hasher to get hash value.

@bikramSingh91 @rschlussel Similar to NaN, how does Presto treat 0.0 and -0.0?  It seems 0.0 = -0.0 returns true, but during join/groupby they are treated differently?  Should we add this to our plan of NaN unification?

Agree that we need 1st to check what we want it to be in Presto.
Also, just curious, since bit representation of 0.0 and -0.0 look different, does folly::hasher() performa an extra check to return the same hash for 0.0 and -0.0?

does folly::hasher() performa an extra check to return the same hash for 0.0 and -0.0?

@spershin thats probably true based on this comment in folly
https://github.com/facebook/folly/blob/427a1ef2c1641e0cfaec5c9300487d084175b00e/folly/Range.h#L1664-L1665

@bikramSingh91 @rschlussel Similar to NaN, how does Presto treat 0.0 and -0.0? It seems 0.0 = -0.0 returns true, but during join/groupby they are treated differently? Should we add this to our plan of NaN unification?

do you have an example query to reproduce this?  Earlier I had the same suspicion about group by and tried to test it out, but didn't see the behavior you are describing.

@rschlussel
> select 0.0 = -0.0;
 _col0
-------
 true
> WITH t as (SELECT * FROM unnest(array[0.0, -0.0], array[1, 2]) as _t(k, v)) select * from t join t as t2 on t.k = t2.k;
  k   | v |  k   | v
------+---+------+---
  0.0 | 1 |  0.0 | 1
 -0.0 | 2 | -0.0 | 2
(2 rows)

cc: @zhli1142015

With this change, do we need to normalize -0.0 and 0.0 in #9272 for Spark? @zhli1142015

Yes, then we need to also normalize -0.0 and 0.0.

This is the behavior of mysql, it won't aggregate -0 and 0.
mysql> create table double_basic_test_2(id int,col1 double,col2 double) ;
Query OK, 0 rows affected (0.04 sec)

mysql> insert into double_basic_test_2 values(6,'0','-0');
Query OK, 1 row affected (0.04 sec)

mysql> insert into double_basic_test_2 values(5,0,0);
Query OK, 1 row affected (0.04 sec)

mysql> select sum(id),col2 from double_basic_test_2 group by col2;
+---------+------+
| sum(id) | col2 |
+---------+------+
|       6 |   -0 |
|       5 |    0 |
+---------+------+
2 rows in set (0.03 sec)

@czentgr, @karteekmurthys


fixed encrypt not found

Short Description: encrypt fix
Fixes:

./encrypt.so not found

See #2768


require('a/b'): Is this possible?

Hi. As of React 0.14 there is a new file react-dom.js which is used like this:
// In the browser
var ReactDOM = require('react-dom');

// In server-side Node
var ReactDOMServer = require('react-dom/server');

When writing scalajs-react unit tests, it is important to have both ReactDOM and ReactDOMServer available as they have different, useful methods.
With this ↓ ReactDOM works but I can't seem to find a way to get ReactDOMServer to work in Scala.JS at all, let alone alongside ReactDOM.
jsDependencies += "org.webjars.npm" % "react-dom" % "0.14.0" / "react-dom.js" commonJSName "ReactDOM"

Is it possible? Is there a way?
(Btw, http://www.scala-js.org/ could really benefit from a search feature. I wanted to just search for require there but no such luck. Manually scanning each page I didn't find anything pertinent.)

@gzm0 Out the top of your head, do you think the / in the require invocation could cause trouble?

The Node.js inclusion mechanism throws all libraries in the same directory (since originally the assumption was, that they are only selected by the same file name).
In this case, the following should work:
jsDependencies += "org.webjars.npm" % "react-dom" % "0.14.0" / "react-dom/server.js" commonJSName "ReactDOMServer"

Hey @gzm0. I tried that snippet above and it doesn't work. Looking at the webjar contents (and ignoring React's own doc) it looks like just server.js should work but it doesn't either. Unfortunately I don't get enough error info for me to chase this down further so I don't know.
If you have time, would you be able to try the project at this branch?
https://github.com/japgolly/scalajs-react/tree/dom-server
If you can configure jsDependencies such that sbt test doesn't crash, you win! :D

@japgolly Are you feeding the generated js into any post processor from react? It is indeed not possible to generate the exact string require('react-dom/server') in the code.
I'll have a look at your project now.

Look at the content of server.js:
'use strict';

module.exports = require('react/lib/ReactDOMServer');

There lies your problem... Our dependency management cannot handle transitive includes like this (again, since this depends on the exact system and JS VM you are using).
I'll try to hack patch it :)

I fail to bring up sbt on this branch:
[warn] 	::::::::::::::::::::::::::::::::::::::::::::::
[warn] 	::          UNRESOLVED DEPENDENCIES         ::
[warn] 	::::::::::::::::::::::::::::::::::::::::::::::
[warn] 	:: commons-io#commons-io;2.0.1: configuration not found in commons-io#commons-io;2.0.1: 'master(compile)'. Missing configuration: 'compile'. It was required from com.github.mpeltonen#sbt-idea;1.6.0 compile
[warn] 	::::::::::::::::::::::::::::::::::::::::::::::
[warn]
[warn] 	Note: Unresolved dependencies path:
[warn] 		commons-io:commons-io:2.0.1
[warn] 		  +- com.github.mpeltonen:sbt-idea:1.6.0 (sbtVersion=0.13, scalaVersion=2.10) (/tmp/scalajs-react/project/plugins.sbt#L5-6)
[warn] 		  +- default:scalajs-react-build:0.1-SNAPSHOT (sbtVersion=0.13, scalaVersion=2.10)

Our dependency management cannot handle transitive includes like this (again, since this depends on the exact system and JS VM you are using).

Oh that seems like a very serious restriction. Does that mean that all the other JS libs I've used up until now have never used require in them? I wouldn't imagine so but maybe I've been lucky :) Is there a plan to fix this properly? It would be ideal if we were able to feed dependencies to node/phantom in a way that their require functions just worked normally.

I fail to bring up sbt on this branch:

That's weird, Travis runs SBT without that error. Hmm I'll just remove the sbt-idea plugin. Please try again.

This should now be possible with scalajs-bundler.


PVC Creation fails for default storage classes

Bug description
PVC Creation fails for default storage classes
How to reproduce
Steps to reproduce the behavior:

Create a Capsule Tenant Object, with the storage options in the spec. So that tenant can only list storage classes which has label "capsule.clastix.io/tenant-usable"
`    storageOptions:
matchExpressions:

key: capsule.clastix.io/tenant-usable
operator: Exists
`

Add the label "capsule.clastix.io/tenant-usable" to all storage classes in the cluster, including the default storage class
Create a StatefulSet and define volumeClaimtemplates. But do not put any storage class name in the spec. Let the default storage class be automatically injected to PVC in annotation (volume.beta.kubernetes.io/storage-class) by kubernetes.
Describe the stateful set. PVC creation fails with the error
Warning  FailedCreate  2m29s (x177 over 6h57m)  statefulset-controller  create Pod test-20 in StatefulSet test failed error: failed to create PVC file-test-20: admission webhook "pvc.capsule.clastix.io" denied the request: A valid Storage Class must be used: matching the label selector defined in the Tenant

Expected behavior
PVC creation should be successful, because if we don't specify storage class name in volumeClaimtemplates,  kubernetes picks up the default storageclass and set it in annotation (volume.beta.kubernetes.io/storage-class) in PVC,  but since capsule checks that pvc must have the storageClassName in the spec it fails.  We should also add a check for the annotation (volume.beta.kubernetes.io/storage-class) with the valid storage class name, and if its present then allow the request to create pvc.
Sample code
https://github.com/projectcapsule/capsule/blob/main/pkg/webhook/pvc/validating.go#L48-L56

@abhinandanbaheti Thanks for reporting this. I will try to reproduce and deliver a fix.

Which Kubernetes Version are you running? I can't replicate it with > 1.25. According to the docs:
In the past, the annotation volume.beta.kubernetes.io/storage-class was used instead of the storageClassName attribute. This annotation is still working; however, it will become fully deprecated in a future Kubernetes release.

In my tests, the storageClass attribute was set directly with the cluster default storageClass

Hey @oliverbaehler thanks for the response. We're running 1.24 currently

@logikone A specific distribution or something like that? I am unable to confirm that issue with KinD 1.24.0

Hey, it took me a while but i've finally been able to repo this issue. for some of our pvcs we have the volume.beta.kubernetes.io/storage-class annotation set, which is the old way of specifying the storage class. In this instance since the storage class is defined spec.storageClassName doesn't get populated with the default and then we get this error in response: https://github.com/projectcapsule/capsule/blob/main/pkg/webhook/pvc/validating.go#L53
I think we need to look in both places for the storage class until support for the annotation is fully removed, which I suspect might be a bit as per this comment: https://github.com/kubernetes/kubernetes/pull/51440#issuecomment-396640304 which is already over 5 years old 😢

i'm not able to repro this in testing using the e2e test suite in this repo. still digging to try and figure out whats going on

Are you using a specific distro or do you have any custom FeatureGates enabled?

its just the standard k8s dist, installed by kops. for whatever reason when the annotation is present on a pvc the request gets denied by the pvc.capsule.clastix.io webhook, but when its absent it works. but then on other clusters is works even with the annotation so i'm not yet convinced that capsule is causing the issue. still trying to figure out what the difference is between the clusters. in both cases though there is no default storage class set on the tenant so the mutating webhook shouldn't be changing anything afaict

I think we need to look in both places for the storage class until support for the annotation is fully removed, which I suspect might be a bit as per this comment: kubernetes/kubernetes#51440 (comment) which is already over 5 years old

@oliverbaehler we're doing something similar to Ingress objects, where the annotation is still used for previous Kubernetes versions. don't you think we should add this also for PVCs?


Improvement: Setup Eval Pipeline for summarization task

title.
Links:
https://cookbook.openai.com/examples/evaluation/how_to_eval_abstractive_summarization
https://github.com/open-compass/opencompass
https://github.com/Mercury7353/PyBench

Just gonna do G-Eval. https://arxiv.org/abs/2303.16634
https://learn.microsoft.com/en-us/ai/playbook/technology-guidance/generative-ai/working-with-llms/evaluation/g-eval-metric-for-summarization
SummEval: https://arxiv.org/abs/2007.12626

Skeleton is in. Using G-Eval setup.


document the flow of the tenancy system

How is the tenant decided, what effect has the middleware.. etc

[ ] how is the tenant decided upon
[ ] what is the middleware doing
[ ] document how global vs localized works

This would be very helpful.

Waiting on this.

The documentation is already mentioning part of this; https://hyn.readme.io/v2.0/docs/tenant-identification.

closing this in favor of #121


tests: uart: fix integration platforms

Fix usage of integration_platforms and apply it individually instead of
the common section.
Signed-off-by: Anas Nashif<EMAIL_ADDRESS>

Looks ok. Just wanted to confirm that you left  drivers.uart.basic_api.cdc_acm without integration_platforms on purpose?

this is fixing a bug. selecting the right integration platform for the remaining test is not in scope of this change.


use julia document to generate code

mkdocs's result is so...sad, with Julia documenter, we get

syntax highlighting
nice in-site searching
no extra graphviz need

complete in https://github.com/llir/document/commit/3b1ac313efe214261c9f4a56dc60925537900eb9


Search is not working

Expected Behaviour
Actual Behaviour
Reproduce Scenario (including but not limited to)
Steps to Reproduce
ON pressing Enter after the search query, it takes us to helpx.adobe.com page
the pages shown in search page have title in lower case. ex: devx
Platform and Version
Sample Code that illustrates the problem
Logs taken while reproducing problem

Enter button press takes to helpx.adobe.com

PR raised on milo to modify gnav to remove enter event
https://github.com/adobecom/milo/pull/1098

Closing this out for lack of activity and with the assumption that opening helpx on pressing "Enter" key is acceptable.


Feature request: Windows!

Related:

https://stackoverflow.com/questions/7814027/how-can-i-get-urls-of-open-pages-from-chrome-and-firefox

oh, interesting... everyone is welcome to help


Gate decomposition reports incorrect angles

Describe the bug
Gate decompositions (called manually and from reports) have rotation angles that are incorrect by a factor of sqrt(2).
To Reproduce

Make a simple model, e.g.:

from pygsti.processors import QubitProcessorSpec as QPS
from pygsti.models import modelconstruction as mc

pspec = QPS(1, ["Gxpi2", "Gypi2"])
model = mc.create_explicit_model(pspec)

Call the gate decomposition:

from pygsti.report.reportables import evaluate,General_decomposition

decomp = evaluate(General_decomposition(model,model))

The rotation angles for both Gxpi2 and Gypi2 are given as sqrt(2)*0.5, rather than 0.5.

Expected behavior
I would expect the rotation angles to be 0.5.
Environment (please complete the following information):

pyGSTi version [<IP_ADDRESS>]
python version [3.10.5]
OS [macOS 12.4]

Additional context
The relevant code seems to be in reportables.py (starting on 2309):
        decomp[gl + " angle"] = norm * 2.0 / _np.pi
        # Units: hamProjs (and norm) are already in "Hamiltonian-coefficient" units,
        # (see 'std_scale_factor' fn), but because of convention the "angle" is equal
        # to *twice* this coefficient (e.g. a X(pi/2) rotn is exp( i pi/4 X ) ),
        # thus the factor of 2.0 above.

@sserita , thanks - would you recommend I work from develop for now or just monkey patch as workaround?

Maybe try the tip of develop. That way you can get all the up-to-date bugfixes as we fix the issues you are bringing to our attention? :)
(Also let me know if this is still broken on develop).

Will do! Happy to be the canary on these things and I expect my group will be making heavy use of pygsti.

@sserita , confirmed fixed in develop. Thanks!

Closed as this is now in 0.9.11 release


Autocomplete strange suggestions when multiple options have same label value

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Steps to reproduce 🕹
Link to live example: modified version of code sandbox Checkbox example from documentation
Steps:

Enter "12" in the text field.
Notice Godfather is shown.
Clear the input and enter "god" several times.
Notice how the suggestion list grows.

Current behavior 😯
The godfather option should not be shown when not matching the input.
The suggestion list should not grow with new instances of "Godfather".
Expected behavior 🤔
I expected "Godfather" only to be shown when matching the input and that I can select the option.
Context 🔦
The example is a modified version of the Checkbox example from the documentation.
The "Godfather" option is occurring multiple times in options. This can occur in real life, for instance when selecting people by name (two people can have the same name). I know the user can't tell which "godfather" is chosen, but I don't think the component should behave the way it does now.
Your environment 🌎
Codesandbox example from the documentation

this is my first time in open source contribution, i would like to work on this

Try to clear the input and enter "god". Repeat some times. Suggestions grow.

@ilbrando I can't reproduce this part, would you mind clarifying what you meant by "Repeat some times"? (I tried inputting godgodgod, god god god ...)

Try to clear the input and enter "god". Repeat some times. Suggestions grow.

@ilbrando I can't reproduce this part, would you mind clarifying what you meant by "Repeat some times"? (I tried inputting godgodgod, god god god ...)

Type god and count how many times "The Godfather" is listed.
Hit backspace a few times, then type god again and count how many times it's listed now. Each time you repeat this, the number of duplicates grows larger.

Fairly certain this is because a non-unique value (the label) is being used as a key.
https://vscode.dev/github/mui/material-ui/blob/d14d288ae9e9b0e2b3b33d0a77b4113f024d4215/packages/mui-base/src/useAutocomplete/useAutocomplete.js#L1146

Hit backspace a few times to clear it, then type god again and count how many times "The Godfather" is listed now.

I see! 😅

Fairly certain this is because a non-unique value (the label) is being used as a key.

I wonder if we could just use the index as the key here (it's used for other keys in the same file) @sai6855 @JJuggy

Hit backspace a few times to clear it, then type god again and count how many times "The Godfather" is listed now.

I see! 😅

Fairly certain this is because a non-unique value (the label) is being used as a key.

I wonder if we could just use the index as the key here (it's used for other keys in the same file) @sai6855 @JJuggy

Maybe a prop to a function which supplies the key. If it is not set you can use index.

I wonder if we could just use the index as the key here (it's used for other keys in the same file)

But isn't it recommended highly to not use index as key?
Reference : https://epicreact.dev/why-react-needs-a-key-prop/

@ilbrando what is your use-case for using same label for different options? From UX prespective it's making much sense, atleast for me

It seems "The Godfather" is matched from 12 because it matched the 1 and 2 in the year, so this part could be expected behavior (of the default option filtering logic)

What do you think @sai6855 ?

i don't think this is the reason, Entered 12 in the example from docs and God father is not shown in options.
I'm fairly certain, both bugs described by the OP is because same key is used for different options.

@ilbrando what is your use-case for using same label for different options? From UX prespective it's making not much sense, atleast for me

I know it is a bit far fetched. Say the user has so choose a person and a list is shown. The data might contain two persons  with the same name. It’s correct that the user wouldn’t be able to distinguish them from another but it’s inconvenient if the control can’t handle the case.

But isn't it recommended highly to not use index as key?

It is indeed, that's why I noticed it in this file 😅

Maybe a prop to a function which supplies the key. If it is not set you can use index.

This is probably the way: pass a key to getOptionProps, but unless it's required, it will still need to fallback to either the label or index

@sai6855 my example is a real life example. The data comes from a database and the values are not known by the app. How would you create the options when you don’t know beforehand the values? I think the right solution is to have a unique key on each option. Either it should be required on the option (like label is) or it should be possible to supply a function which returns the key for an option.

Okay adding 'waiting for upvotes' label. It helps us prioritising issues correctly

@ilbrando  i've updated code in comment (https://github.com/mui/material-ui/issues/36897#issuecomment-1516660298) to take options coming from database into account. I'm assuming you have unique id's associated with each option.

@ilbrando i've updated code in comment https://github.com/mui/material-ui/issues/36897#issuecomment-1516660298 to take options coming from database into account. I'm assuming you have unique id's for each option

@ilbrando i've updated code in comment #36897 (comment) to take options coming from database into account. I'm assuming you have unique id's for each option

Yes No problem there 😊
Thank you very much.

Duplicate of #26492


Add an entry for running pydeps

https://pydeps.readthedocs.io/en/latest/#basic-usage
pretty useful

Wanted to make an issue but I don't have access. Should look into these things as well:

autoflake
isort
bandit
mccabe

We already have:

pylint
flake8
mypy

Try and figure out what's going on here: https://github.com/PyCQA
Also we should look into what https://python-poetry.org/ is doing?

Seems autoflake and bandit are probably not worth running. mccabe is probably low value but maybe at least worth it, having a way to invoke pydeps would be cool
we should switch things over to installing linters etc only when they're invoked too (i.e. concrete target)

Since we did #15 and we want to generate documentation on https://github.com/vkottler/workspace/issues/7, we should maybe do this first (since it's probably pretty cheap)

Adding this on https://github.com/vkottler/vmklib/pull/33, including example README integration

We should make the dependency graph generation / inclusion in the README constant so we can have it at the end for all Python projects

Closing now that all packages have the dependency graph readme snippet.


current_op/3 failed for prefix +/1

Following code failed in Trealla:
:- initialization(main).

main :-
        current_op(P, fy, +), write(P), nl, halt.

According to result of GProlog, SWI and Yap, I think that should be 200.

Fix confirmed, thanks.


error: python is already installed from !

Please note that we will close your issue without comment if you delete, do not read or do not fill out the issue checklist below and provide ALL the requested information. If you repeatedly fail to use the issue template, we will block you from ever submitting issues to Homebrew again.

[x] are reporting a bug others will be able to reproduce and not asking a question. If you're not sure or want to ask a question do so on our Discourse: https://discourse.brew.sh
[ ] ran a brew command and reproduced the problem with multiple formulae? If it's a problem with a single, official formula (not cask) please file this issue at Homebrew/homebrew-core: https://github.com/Homebrew/homebrew-core/issues/new/choose. If it's a brew cask problem please file this issue at https://github.com/Homebrew/homebrew-cask/issues/new/choose. If it's a tap (e.g. Homebrew/homebrew-php) problem please file this issue at the tap.
[x] ran brew update and can still reproduce the problem?
[ ] ran brew doctor, fixed all issues and can still reproduce the problem?
[ ] ran brew config and brew doctor and included their output with your issue?

What you were trying to do (and why)
I tried to install jupyter by using brew, brew install jupyter.
What happened (include command output)
An error occured,
Error: python is already installed from
Please brew uninstall python first."

Command output

command output:
error: python is already installed from !

What you expected to happen
Before using jupyter, I've already install python3.6 by using brew. And I've been using python3 for a while. Now I cannot just simply uninstall python3. So, since python is already exist, why brew just skip the installing of python?
I want jupyter to be installed on my mac with my current python environment unchanged.
Step-by-step reproduction instructions (by running brew commands)
brew update
brew install jupyter

From the issue template:

Please note we will close your issue without comment if you delete, do not read or do not fill out the issue checklist below and provide ALL the requested information. If you do not read fill out the issue template repeatedly you will be blocked from ever submitting issues to Homebrew again.

If you add the necessary information to this issue (don't create a new one, please) then this issue may be reopened.

I've provided all the infos and details. Could you please help me find out the reason?

ran brew config and brew doctor and included their output with your issue?

No you did not.

Getting same error on brew install php

Same error with brew install googler.
I have python2(2.7) and python3(3.7) installed on mac os x mojave (v 10.14). I also have anaconda. Python3 locations:
/Library/Frameworks/Python.framework/Versions/3.7/bin/python3
/usr/local/bin/python3


Add script for generating a krew plugin manifest.

What type of PR is this?
/kind enhancement
What this PR does / why we need it:
This adds a script that can generate a krew plugin manifest from the output of goreleaser. I don't know if there's a way to run this with goreleaser, but if there is we should do that.
Which issue(s) this PR fixes:

Fixes #276
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

NONE

Would we rather generate this manifest from disk or have it fetch the archives from Github and SHA them from there?

The Krew project has not yet defined acceptance criteria for plugins. So I've done some digging to see how we can maximize our chances.
Here's an example of a plugin that did poorly in review: https://github.com/kubernetes-sigs/krew-index/pull/146

Hey, I think conftest is a great tool and it deserves to be featured so that k8s users get aware of it. However, I'm a bit worried that it requires so many extra speps to be useful. As far as I understand, you need to have a policy folder with rego rules. This means that interested users need to dig deep into the conftest manual before they can get started. Your suggested starting point is to clone an example rules repo. At that point, a user might as well also download conftest and I don't see the advantage to invoke conftest via kubectl.
Further, my feeling is that conftest is by spirit not an extension of kubectl, but rather a standalone k8s tool. We haven't defined yet, what are the criteria for a krew plugin, but looking at what we have, I would say: tools that extend existing kubectl functionality. Only very few require extra configuration. And in that regard, I don't see how conftest fits in. To me it looks more like a tool from the k8s kosmos, but very different from kubectl.

They also started a document describing criteria that might be helpful: https://github.com/kubernetes-sigs/krew-index/pull/152
In light of this, I think we should spend some time refining the description and short description to be more clear on what KUDO does and why you would install the CLI.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: alenkacz, jbarrick-mesosphere, kensipe
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [alenkacz,jbarrick-mesosphere,kensipe]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/cc @runyontr @mattj-io @yankcrime

@jbarrick-mesosphere: GitHub didn't allow me to request PR reviews from the following users: mattj-io.
Note that only kudobuilder members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @runyontr @mattj-io @yankcrime

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


docker-compose suggestions

Two tiny suggested tweaks to docker-compose based on the Perma team's experience so far:
We have found it convenient to run with uWSGI with the --need-app flag so that the whole container crashes if the python application fails to load, rather than staying up but serving nothing. It's hard for me to imagine a situation in which it's anything-but-misleading for uWSGI to be running without an app; you may find this convenient as well!
We also noticed that the proxy-certs bind mount declaration is redundant with ./webrecorder/:/code/. Since its presence has no effect, no particular reason to remove it from the file, except for documentation purposes. When we were just getting started, we thought this meant we had to create some certs before running, so they could be mounted in and used by the app.

(closed and re-opened to see if test failures were spurious)

Thanks, yes, --need-app does help make it easier to determine if there's an error


Projects Section Should route to Login Page

When User clicks on /projects in the navbar or footer then it should redirect to /projects page, and if not logged in, then it should redirect to /login page
@abhinandanwadwa Kindly take on the issue and finish it till tomorrow ( Urgent fix required )

I'll fix this within an hour or so.

fIXED


Create an installation section

Put all required installation in one place to let folks install everything prior to the event

done


Ensure the buffer is emptied on event handler errors and that the error is re-emitted

I found that when the event handler for line generated an exception, even though I caught it, the line buffer was not reset and the last line was emitted twice.

Thanks for merging the previous PR & releasing it so quickly.
I've added one commit to this, which improved performance in my use case by 25-30% (a 3.5GB file). You may or may not want it as it requires the maximum line length to be specified (it's 4K by default, which should be plenty).

@dkavassy thanks for your pull request. Looks ok, but want to make sure I understand the changes before merging. Hope to get to it this weekend.

@maleck13 do you think you might be able to have a look at this soon?

@dkavassy  Thanks you for your work. Sorry it took so long to get back to it.


[pred-memopt] Extract out dataflow computation into its own helper st…

…ruct.
This simplifies the code and enables me to extract out the code for deleting
dead allocations into a separate struct from AllocOptimize. Otherwise, I would
have to pass in a reference to AllocOptimize creating back references, a
complexity that isn't necessary and will force me to break encapsulation
properties.
Just chopping this off of a larger commit.
rdar://31521023

@swift-ci smoke test and merge


is property="twitter:description" and not name="twitter:description"

hi
i dont know what to say more than title ^^'
as you can see here https://developer.twitter.com/en/docs/tweets/optimize-with-cards/guides/getting-started
thank you

I don't see anything wrong here. Maybe you are confusing Twitter tags with Open Graph tags?

Open Graph protocol also specifies the use of property and content attributes for markup [...] while Twitter cards use name and content.


Faster triplet selector

Hi,
it is possible to make the triplet selector run much faster both in cpu and cuda. It run 5x faster in my setup. It consists of just converting some operations made in a for loop to a single tensor operation.
Here is some code that a used to test and compare running time:
import torch
from utils import FunctionNegativeTripletSelector, random_hard_negative
from time import time
import numpy as np

torch.manual_seed(123)
n = 256
X = torch.rand((n, 8), dtype=torch.float32)
Y = torch.randint(0, 4, size=(n,))

np.random.seed(123)
selector = ORIGINALFunctionNegativeTripletSelector(1.0, random_hard_negative)
t = time()
result1 = selector.get_triplets(X, Y)
t = time()-t
print("%s %.3fsec" % (selector.__class__.__name__, t))

np.random.seed(123)
selector = NEWFunctionNegativeTripletSelector(1.0, random_hard_negative)
t = time()
result2 = selector.get_triplets(X, Y)
t = time()-t
print("%s %.3fsec" % (selector.__class__.__name__, t))

assert((result1 == result2).all())

HI @Lucashsmello - thanks for the PR. Yes, unfortunately the triplet selection is not optimized, it's been on the TODO list for quite some time but I didn't have much time to work on this repo. I'll take a look at your PR and merge if there are no problems, I know that even more optimization can be done

I've been using this changes for bigger datasets and helps a lot!


HBASE-28268 Provide option to skip wal while using TableOutputFormat

original pr: #6436
cherry-pick from commit: 5c99925

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 16s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
hbaseanti
0m  0s

Patch does not have any anti-patterns.

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
4m 19s

branch-2 passed

+1 :green_heart:
compile
0m 47s

branch-2 passed

+1 :green_heart:
checkstyle
0m 16s

branch-2 passed

+1 :green_heart:
spotbugs
0m 40s

branch-2 passed

+1 :green_heart:
spotless
0m 52s

branch has no errors when running spotless:check.

_ Patch Compile Tests _

-1 :x:
mvninstall
3m  7s
/patch-mvninstall-root.txt
root in the patch failed.

-1 :x:
compile
0m 29s
/patch-compile-hbase-mapreduce.txt
hbase-mapreduce in the patch failed.

-0 :warning:
javac
0m 29s
/patch-compile-hbase-mapreduce.txt
hbase-mapreduce in the patch failed.

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 21s

the patch passed

-1 :x:
spotbugs
0m 29s
/patch-spotbugs-hbase-mapreduce.txt
hbase-mapreduce in the patch failed.

-1 :x:
hadoopcheck
2m  4s

The patch causes 20 errors with Hadoop v2.10.2.

-1 :x:
hadoopcheck
4m 35s

The patch causes 20 errors with Hadoop v3.3.6.

-1 :x:
hadoopcheck
6m 48s

The patch causes 20 errors with Hadoop v3.4.0.

+1 :green_heart:
spotless
0m 48s

patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m 10s

The patch does not generate ASF License warnings.

21m 59s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6472/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6472

Optional Tests
dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless

uname
Linux 932b7e2a17b5 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 5682627a4137d8e7c07b38cf9e2eb328f82da9d2

Default Java
Eclipse Adoptium-11.0.23+9

hadoopcheck
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6472/1/artifact/yetus-general-check/output/patch-javac-2.10.2.txt

hadoopcheck
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6472/1/artifact/yetus-general-check/output/patch-javac-3.3.6.txt

hadoopcheck
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6472/1/artifact/yetus-general-check/output/patch-javac-3.4.0.txt

Max. process+thread count
79 (vs. ulimit of 30000)

modules
C: hbase-mapreduce U: hbase-mapreduce

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6472/1/console

versions
git=2.34.1 maven=3.9.8 spotbugs=4.7.3

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 54s

Docker mode activated.

-0 :warning:
yetus
0m  7s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
4m 12s

branch-2 passed

+1 :green_heart:
compile
0m 22s

branch-2 passed

+1 :green_heart:
javadoc
0m 19s

branch-2 passed

+1 :green_heart:
shadedjars
7m 27s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

-1 :x:
mvninstall
3m 45s
/patch-mvninstall-root.txt
root in the patch failed.

-1 :x:
compile
0m 19s
/patch-compile-hbase-mapreduce.txt
hbase-mapreduce in the patch failed.

-0 :warning:
javac
0m 19s
/patch-compile-hbase-mapreduce.txt
hbase-mapreduce in the patch failed.

+1 :green_heart:
javadoc
0m 14s

the patch passed

-1 :x:
shadedjars
5m 24s

patch has 20 errors when building our shaded downstream artifacts.

_ Other Tests _

-1 :x:
unit
0m 24s
/patch-unit-hbase-mapreduce.txt
hbase-mapreduce in the patch failed.

24m 27s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6472/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6472

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux a3c796dd58f6 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 5682627a4137d8e7c07b38cf9e2eb328f82da9d2

Default Java
Eclipse Adoptium-11.0.23+9

shadedjars
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6472/1/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6472/1/testReport/

Max. process+thread count
78 (vs. ulimit of 30000)

modules
C: hbase-mapreduce U: hbase-mapreduce

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6472/1/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 10s

Docker mode activated.

-0 :warning:
yetus
0m  7s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
4m 28s

branch-2 passed

+1 :green_heart:
compile
0m 37s

branch-2 passed

+1 :green_heart:
javadoc
0m 26s

branch-2 passed

+1 :green_heart:
shadedjars
8m  1s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

-1 :x:
mvninstall
4m 16s
/patch-mvninstall-root.txt
root in the patch failed.

-1 :x:
compile
0m 32s
/patch-compile-hbase-mapreduce.txt
hbase-mapreduce in the patch failed.

-0 :warning:
javac
0m 32s
/patch-compile-hbase-mapreduce.txt
hbase-mapreduce in the patch failed.

+1 :green_heart:
javadoc
0m 20s

the patch passed

-1 :x:
shadedjars
6m 28s

patch has 20 errors when building our shaded downstream artifacts.

_ Other Tests _

-1 :x:
unit
0m 31s
/patch-unit-hbase-mapreduce.txt
hbase-mapreduce in the patch failed.

28m  1s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6472/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6472

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux a671c93cda45 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 5682627a4137d8e7c07b38cf9e2eb328f82da9d2

Default Java
Eclipse Adoptium-17.0.11+9

shadedjars
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6472/1/artifact/yetus-jdk17-hadoop3-check/output/patch-shadedjars.txt

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6472/1/testReport/

Max. process+thread count
83 (vs. ulimit of 30000)

modules
C: hbase-mapreduce U: hbase-mapreduce

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6472/1/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 45s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
hbaseanti
0m  0s

Patch does not have any anti-patterns.

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
2m 50s

branch-2 passed

+1 :green_heart:
compile
0m 32s

branch-2 passed

+1 :green_heart:
checkstyle
0m 11s

branch-2 passed

+1 :green_heart:
spotbugs
0m 28s

branch-2 passed

+1 :green_heart:
spotless
0m 42s

branch has no errors when running spotless:check.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 51s

the patch passed

+1 :green_heart:
compile
0m 32s

the patch passed

+1 :green_heart:
javac
0m 32s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 11s

the patch passed

+1 :green_heart:
spotbugs
0m 36s

the patch passed

+1 :green_heart:
hadoopcheck
15m 15s

Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.0.

+1 :green_heart:
spotless
0m 42s

patch has no errors when running spotless:check.

_ Other Tests _

+1 :green_heart:
asflicense
0m  8s

The patch does not generate ASF License warnings.

27m 23s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6472/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6472

Optional Tests
dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless

uname
Linux d2288a6917c7 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 4fdb5cb83dea63c6b8dc0b5cbacbcc1406bf8705

Default Java
Eclipse Adoptium-11.0.23+9

Max. process+thread count
79 (vs. ulimit of 30000)

modules
C: hbase-mapreduce U: hbase-mapreduce

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6472/2/console

versions
git=2.34.1 maven=3.9.8 spotbugs=4.7.3

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 51s

Docker mode activated.

-0 :warning:
yetus
0m  6s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
3m  9s

branch-2 passed

+1 :green_heart:
compile
0m 23s

branch-2 passed

+1 :green_heart:
javadoc
0m 16s

branch-2 passed

+1 :green_heart:
shadedjars
5m 27s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 46s

the patch passed

+1 :green_heart:
compile
0m 24s

the patch passed

+1 :green_heart:
javac
0m 24s

the patch passed

+1 :green_heart:
javadoc
0m 19s

the patch passed

+1 :green_heart:
shadedjars
5m 32s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
21m 42s

hbase-mapreduce in the patch passed.

41m 56s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6472/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6472

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux ceddbb5ad7b2 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 4fdb5cb83dea63c6b8dc0b5cbacbcc1406bf8705

Default Java
Temurin-1.8.0_412-b08

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6472/2/testReport/

Max. process+thread count
2915 (vs. ulimit of 30000)

modules
C: hbase-mapreduce U: hbase-mapreduce

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6472/2/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 55s

Docker mode activated.

-0 :warning:
yetus
0m  5s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
3m 49s

branch-2 passed

+1 :green_heart:
compile
0m 28s

branch-2 passed

+1 :green_heart:
javadoc
0m 21s

branch-2 passed

+1 :green_heart:
shadedjars
6m 47s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m  7s

the patch passed

+1 :green_heart:
compile
0m 31s

the patch passed

+1 :green_heart:
javac
0m 31s

the patch passed

+1 :green_heart:
javadoc
0m 20s

the patch passed

+1 :green_heart:
shadedjars
6m 55s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
19m 13s

hbase-mapreduce in the patch passed.

44m 34s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6472/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6472

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux d6d31f2169e6 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 4fdb5cb83dea63c6b8dc0b5cbacbcc1406bf8705

Default Java
Eclipse Adoptium-17.0.11+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6472/2/testReport/

Max. process+thread count
2840 (vs. ulimit of 30000)

modules
C: hbase-mapreduce U: hbase-mapreduce

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6472/2/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 50s

Docker mode activated.

-0 :warning:
yetus
0m  6s

Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
3m 41s

branch-2 passed

+1 :green_heart:
compile
0m 25s

branch-2 passed

+1 :green_heart:
javadoc
0m 17s

branch-2 passed

+1 :green_heart:
shadedjars
7m 24s

branch has no errors when building our shaded downstream artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m  8s

the patch passed

+1 :green_heart:
compile
0m 28s

the patch passed

+1 :green_heart:
javac
0m 28s

the patch passed

+1 :green_heart:
javadoc
0m 19s

the patch passed

+1 :green_heart:
shadedjars
7m 47s

patch has no errors when building our shaded downstream artifacts.

_ Other Tests _

+1 :green_heart:
unit
21m 25s

hbase-mapreduce in the patch passed.

47m 57s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6472/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/6472

Optional Tests
javac javadoc unit compile shadedjars

uname
Linux a634f429f734 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 4fdb5cb83dea63c6b8dc0b5cbacbcc1406bf8705

Default Java
Eclipse Adoptium-11.0.23+9

Test Results
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6472/2/testReport/

Max. process+thread count
2858 (vs. ulimit of 30000)

modules
C: hbase-mapreduce U: hbase-mapreduce

Console output
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6472/2/console

versions
git=2.34.1 maven=3.9.8

Powered by
Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.


Support Config Files

I recently ran into this tool and it's totally awesome. However I wasn't able to use it since my classes are prefixed with tw-.
A good way to solve this could be allowing users to import their config file, so if they have a custom configuration the app can take it into account.
There are obviously some questions/difficulties, like plugins for example, but maybe supporting a basic config file with no plugins or imports could be a good way to start.

An interesting situation. I suppose the workaround right now is to manually find and remove all instances of the tw- prefix.
I guess a function could be added to strip the prefix from the input before processing it, referencing how the prefix is used.
It could involve a small text box in the top header to input your prefix. Then when you paste the classes with prefix, they will be stripped (internally in server) during processing, and also added back to the generated CSS.
Is there any other reason to support config files besides the prefix situation?


fix: rm python-semantic-release as dependency

resolves #261 if appropriate, please close otherwise! thanks for building this package

Very good but it is missing updated lock file. To get the release as soon as possible, I created #263.


[request] make the map a windows so it can be moved to a secondary screen

Hi!! so basically what the title says. Dalamud has the option to put plugins on other monitor and i think it would be useful to for some to put the map layout on another monitor.

^
I'll note that if you enable transparent background, window will be constrained to main game window - this is basically some limitation of dalamud (if you remove that constraint, you'll see ugly shit). So select one or the other - window with transparent background on second screen doesn't make much sense anyway.


Editing a second series

sreeder[CodePlex] User can't stop editing a series and then begin editing another. there is an error

sreeder[CodePlex] This issue has been resolved


"Python extension loading" never ends

So when I open VScode the python extension keep loading and never ends.
I tried some ways include re-install python extension or downgrade the extension version but not work :<
But I add these lines in my setting and seems fixes this issue 🤔
    "python.experiments.optOutFrom": [
        "pythonDiscoveryModuleWithoutWatcher"
    ]

Environment data
OS: Windows_NT x64 10.0.19042

VS Code version: 1.56.2 (user setup)

Extension version (available under the Extensions sidebar): Python v2021.5.842923320

OS and version: Windows 20H2

Python version (& distribution if applicable, e.g. Anaconda): 3.8.10 (directly installed)

Type of virtual environment used (N/A | venv | virtualenv | conda | ...): N/A

Value of the python.languageServer setting: Default

[NOTE: If you suspect that your issue is related to the Microsoft Python Language Server (python.languageServer: 'Microsoft'), please download our new language server Pylance from the VS Code marketplace to see if that fixes your issue]
Expected behaviour
Vscode run normally with python extension.
Actual behaviour
Vscode loads python extension and never ends.
Steps to reproduce:
[NOTE: Self-contained, minimal reproducing code samples are extremely helpful and will expedite addressing your issue]

Open Vscode, open any .py file
The python extension start loading and stuck

Logs

Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)

# There was no any content in the output panel

I think I ran into a similar issue. My solution was to disable python.experiments.enabled.

#16294
In my issue I've tried adding the same "pythonDiscoveryModuleWithoutWatcher" opt-out and it stopped my issue.

@chdsbd @tibitTW thanks for the response in the issue, Can you share your output logs to keep track of the experiments that are generating the error?

@chdsbd @tibitTW thanks for the response in the issue, Can you share your output logs to keep track of the experiments that are generating the error?

I guess this is the log you're talking about?
使用者屬於 "pythonaa" 實驗性群組
使用者屬於 "pythonJediLSP" 實驗性群組
使用者屬於 "pythonDiscoveryModuleWithoutWatcher" 實驗性群組
使用者屬於 "pythonTensorboardExperiment" 實驗性群組
使用者屬於 "pythonSurveyNotificationcf" 實驗性群組
使用者屬於 "PythonPyTorchProfiler" 實驗性群組
使用者屬於 "pythonDeprecatePythonPath" 實驗性群組
Info 2021-07-20 10:26:54: Searching for conda.
Info 2021-07-20 10:26:54: Probing conda binary: conda
Info 2021-07-20 10:26:54: Error: spawn conda ENOENT
    at Process.ChildProcess._handle.onexit (internal/child_process.js:269:19)
    at onErrorNT (internal/child_process.js:465:16)
    at processTicksAndRejections (internal/process/task_queues.js:80:21) {
  errno: -4058,
  code: 'ENOENT',
  syscall: 'spawn conda',
  path: 'conda',
  spawnargs: [ 'info', '--json' ]
}
Info 2021-07-20 10:26:54: Searching for workspace virtual envs in: d:\Coding\code playground
Info 2021-07-20 10:26:54: Found interpreter for C:\Users\jim87\AppData\Local\Programs\Python\Python38\python.exe,c:\Users\jim87\.vscode\extensions\ms-python.python-2021.6.944021595\pythonFiles\interpreterInfo.py
Python interpreter path: ~\AppData\Local\Programs\Python\Python38\python.exe
Info 2021-07-20 10:26:54: Display locator refreshing progress, Class name = g, completed in 3ms, has a falsy return value, , Return Value: undefined

Those chinese letters in beginning lines in english should be "User belongs to ... experiments group" or nearly meaning

Thanks for the reply, we are going to see which of the experiments is causing the issue.


[WIP] PR: Don't block while sending messages

Description of Changes

[ ] Wrote at least one-line docstrings (for any new functions)
[ ] Added unit test(s) covering the changes (if testable)

[ ] Included a screenshot or animation (if affecting the UI, see Licecap)

Issue(s) Resolved

Mitigates #10209
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:

I did that because circleci failed. I think this is unrelated

Thanks @impact27 for this! I tested it and it solves the freeze (yay!) but it shows our report error dialog on every keystroke in the editor (which is not ideal).
What do you think if instead we show a message once about the lack of completion services due to the transport layer being blocked, and then let users code in Editor without problems?

Hello @impact27! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file spyder/plugins/completion/languageserver/client.py:

Line 315:21: E722 do not use bare 'except'


Pods stuck in "Terminating" state

kubectl delete <pod> will result in the pods to be stuck in the "Terminating" state. Same happens when I e.g. try to delete whole namespaces.
Setup

Fresh, bare-metal Ubuntu 20.04.1 LTS with all updates installed
microk8s installed via snap in 1.17/stable channel
microk8s in v1.17.12
kube-apiserver allowing privileged containers (/var/snap/microk8s/current/args/kube-apiserver contains --allow-privileged=true)

Symptoms

pods (and namespaces) stay in "Terminating" state forever
Running ps -Af | grep <CMD> and searching for the running command reveals, that the container command still runs in it's namespace
Checking the journalctl -x | grep apparmor shows several "denied" entries for runc:

Nov 25 08:23:45 k8s1 kernel: audit: type=1400 audit(1606289025.169:54559): apparmor="DENIED" operation="signal" profile="cri-containerd.apparmor.d" pid=2184447 comm="runc" requested_mask="receive" denied_mask="receive" signal=term peer="snap.microk8s.daemon-containerd"
Nov 25 08:23:45 k8s1 audit[2184457]: AVC apparmor="DENIED" operation="signal" profile="cri-containerd.apparmor.d" pid=2184457 comm="runc" requested_mask="receive" denied_mask="receive" signal=kill peer="snap.microk8s.daemon-containerd"

A kubectl describe <pod> shows the denied message as well in the pods' events:

Warning  FailedKillPod  8s (x4 over 47s)  kubelet, k8s1      error killing pod: [failed to "KillContainer" for "acmesolver" with KillContainerError: "rpc error: code = Unknown desc = failed to stop container \"117c0054ed29bd806c936728785afb4f8d4556354556ccdfc2839324eae30e0f\": unknown error after kill: runc did not terminate sucessfully: container_linux.go:388: signaling init process caused \"permission denied\"\n: unknown", failed to "KillPodSandbox" for "33ab7dd7-0a07-4df4-bd8c-990b4b2c1154" with KillPodSandboxError: "rpc error: code = Unknown desc = failed to stop container \"117c0054ed29bd806c936728785afb4f8d4556354556ccdfc2839324eae30e0f\": failed to kill container \"117c0054ed29bd806c936728785afb4f8d4556354556ccdfc2839324eae30e0f\": unknown error after kill: runc did not terminate sucessfully: container_linux.go:388: signaling init process caused \"permission denied\"\n: unknown"]

During analysis with @ktsakalozos, we found the problem to be the hosts' AppArmor service not running (via this comment). Starting the apparmor service and reloading the profile cache solved the problem.
For whatever reason, running aa-status did correctly show me several confinement-policies for processes, which led me to believe, that everything was working fine.
Hypothesis
Here's what I think happened. During installation, if apparmor is installed in the default directory, the necessary profiles are copied over and the script tries to reload apparmor (src). But if apparmor is inactive, reloading will fail. This will leave the old AppArmor profiles stale, which can be shown via aa-status - but the new required ones are never loaded, even after a reboot (if AppArmor is disabled).
You can follow the timeline in the slack microk8s channel
Reproduction
Unfortunately, after I enabled the AppArmor service I was unable to reproduce the behavior - so this is a hypothetical reproduction for now.
(1) Install a fresh ubuntu server 20.04.1
(2) Install snapd
(3) run snap install --classic microk8s --channel 1.17/stable
(4) Add the line --allow-privileged=true to /var/snap/microk8s/current/args/kube-apiserver
(5) Start a container via microk8s kubectl create pod test-pod --image=nginx/alpine
(6) Ensure that the container has started via microk8s kubectl get pod test-pod
(7) Delete the pod via microk8s kubectl delete pod test-pod
If everything runs well (in terms of buggy), you will be able to see the behavior as described above in "Symptoms"
Solution
The installation process should not only reload the profiles, but also check, if the new profiles are actually present via aa-status. If they are not, the installation should either fail or the user should be informed at the end of the installation.
inspection-report-20201125_080003.tar.gz

+1


Prune expressions for the meta index lookup

:notebook_with_decorative_cover: Description
We can take advantage of the fact that all string fields are covered by the same type level synopsis. To be more specific: A query like suricata.smb.host == "foo" || suricata.ssh.host == "foo" would check whether the string "foo" is included the same type-level string synopsis twice.
This PR adds a preprocessing step that removes predicates with duplicate strings from the expression as a preprocessing step for meta index lookups.
In my local comparisons with 12723 partitions with eve.log data I get the a 4 times speedup for the query vast export null 'net.domain == "alhgeoafh" || net.hostname == "alhgeoafh"'.
A release build on master finishes the command in ~ 930 ms, this branch is done after ~ 240 ms.
:memo: Checklist

[ ] All user-facing changes have changelog entries.
[x] The PR description contains instructions for the reviewer, if necessary.

:dart: Review Instructions
Try to reproduce my results.

I'll review this one in practice, I still have a 1TB database with Zeek streaming JSON on my hard drive.

I'm not sure whether I should add a changelog entry for this.

@tobim if the performance gains are substantial, it's a nice change item. As a user, I always enjoy reading gains if they are specific and to the point (while broad claims are rather a turnoff).


Fixed the typo outlined in issue 13429.

Summary
I fixed the typo correcting "pakcage" to "package" in the tip outlined in the issue request on the configurations.md file of the 29.1 versioned docs.

Thanks! Nice to see you. Could you fix this for all versions please? (;

You got it! Here they are!

All looks good. Thanks!


MWPW-140297- Prompt bar css fix if caas.css is loading on the page

Prompt bar css update

Resolves: MWPW-140297
Test URLs:

Before: https://main--cc--adobecom.hlx.page/drafts/jbrown/firefly/firefly?martech=off
After: https://MWPW-140297--cc--adobecom.hlx.page/drafts/jbrown/firefly/firefly?martech=off

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (9f7df68) 88.80% compared to head (a1d3ae3) 88.80%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #142   +/-   ##
=======================================
  Coverage   88.80%   88.80%
=======================================
  Files           8        8
  Lines         652      652
=======================================
  Hits          579      579
  Misses         73       73

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


better solution to register pages to generate as static files

better solution to generate routes, this would also eliminate the need for BlazorStaticOptions.RazorPagesPaths
Pros:

less prone to failing
allows for the use of @attribute [Route(...)]
should be faster

Cons:

uses reflection

I think we are done here, or do you see anything else to consider?

looks good, you can merge it


Make the navbar sticky

The navbar is not visible when scrolled down. I would like to make it fixed so that users can easily navigate.

Please assign this issue to me
I am working under GSSoC'24

Hello,
I am new to open source and very excited to contribute. I would love to work on this project. Could you please assign this issue to me?

I am good in Front-end ,
Please assign this issue to me.
I am working under GSSoC'24 .

/assign


Custom policy instructions can be very daunting and convoluted

So, this article discusses a bunch of technical profiles to add to one of the .XML files.
I think to assure customers don't get wrapped up in confusion, that we should be stipulated EXACTLY the lines these portions should be added, and provide a full output example of what the starter pack files should look like after the suggested modifications.
I see WHAT to add, don't understand WHERE to add it.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b0576a50-8bfd-ac73-6cfc-5121de4c1ba1
Version Independent ID: df6d7234-db4f-1a15-3010-26bd56d934e8
Content: Set up a password reset flow - Azure AD B2C
Content Source: articles/active-directory-b2c/add-password-reset-policy.md
Service: active-directory
Sub-service: b2c
GitHub Login: @kengaderdus
Microsoft Alias: kengaderdus

@DaveMenist
Thanks for your feedback! We will investigate and update as appropriate.

Hi @DaveMenist,
Thank you for your feedback and patience. We avoid mentioning the line number to which certain snippets are added because line numbers can change depending on a user's scenario. Currently,  we tell you the file .XML name and the element (xml tag) to which you add the snippet.
For full output examples, we provide an example custom policy in GitHub.
Even with this, we're always working to improve our docs to ensure the instructions are clear.
Thanks. #please-close


Re-train with LFW identities removed

https://groups.google.com/forum/#!topic/cmu-openface/p-otsETCFG8

FaceScrub only overlaps with the LFW by 150 identities, which I have now removed with the remove-lfw-names script attached to this issue. Re-aligning and re-training now.

As expected since it was only 150 identities, the performance hasn't changed. I'll replace the default model with this new one for consistency.

I'm closing this issue and not replacing the models since this doesn't impact the performance or accuracy results.


Create table filter partial

Instead of using the same (or slightly varied) markup in every filterable table in every app, use a common partial provided by the admin gem.
Simplest usage:
<%= render partial: 'govuk_admin_template/table_filter' %>

Use within table:

       …

    <%= render partial: 'govuk_admin_template/table_filter' %>

  …

cc @dsingleton

I think this is :+1:, but worth a second opinion.


refactor: sql_json view endpoint: separate validate query concern

SUMMARY
The sql_json view code in superset core view without any "clean code" standard and it does not adopt any software development principle.
This is the seventh PR in the sequence of future PRs (previous PR) try to solve it by refactoring the code.
The PR focus of separate the validate authorization of the new query concern into ad hod method so the code will be cleaner
there are no logic changes so it implies on the current tests.

reopen


Add Ox to linguist

Adding Ox language and demonstrating pull request for my class

Please have a look at the guidelines to add support for a new language to Linguist. In particular, notice the requirement on in-the-wild usage for file extensions.


Bug: Exception in event listener breaks listener

Description
In a separate production code base, we encountered what I believe to be an issue/behavior that could be fixed/improved and did not find anything other references of it when searching the issues here.
Basically, if an exception occurs inside of an event listener you will then see
INFO:     ASGI 'lifespan' protocol appears unsupported.

and the listener stream is closed which then prevents any additional events from being picked up. Any time request.app.emit is then called you will get ClosedResourceError.
I don't think a single exception inside an event execution should prevent all future events from getting picked up or at least the error should be a little more obvious as to what is going on.
I've created an example repo that recreates the issue consistently.
URL to code causing the issue
https://github.com/bnjmn/litestar-emit-fail-example
MCVE
See full example here
from litestar import Litestar, get, Request
from litestar.events import listener

import logging

logger = logging.getLogger(__name__)

@listener("raise_exception")
async def raise_exception_if_odd(value) -> None:
    """Raise an exception to test Emit error."""
    if value is not None and value % 2 != 0:
        raise ValueError(f"{value} is odd")
    else:
        return "The value is even. No exception raised."

@get("/")
async def index() -> str:
    return "Hello, world!"

@get("/check-value/{value:int}")
async def check_value(request: Request, value: int) -> str:
    try:
        request.app.emit("raise_exception", value)
        return f"Checked {value}: No exception raised."
    except ValueError as e:
        return str(e)

app = Litestar([index, check_value], listeners=[raise_exception_if_odd])

Steps to reproduce

Follow the steps outlined in the README

pipenv install
litestar run -d

Go to http://localhost:8000/check-value/2 to see a successful request
Go to http://localhost:8000/check-value/3 to see an exception raised in the listener
Attempt to go to http://localhost:8000/check-value/2 again, but you should get ClosedResourceError

Litestar Version
Recreated on both 2.3.2 and 2.4.1
Platform

[ ] Linux
[X] Mac
[ ] Windows
[x] Other (Please specify in the description above)

[!NOTE]
While we are open for sponsoring on GitHub Sponsors and
OpenCollective, we also utilize Polar.sh to engage in pledge-based sponsorship.
Check out all issues funded or available for funding on our Polar.sh Litestar dashboard

If you would like to see an issue prioritized, make a pledge towards it!
We receive the pledge once the issue is completed & verified
This, along with engagement in the community, helps us know which features are a priority to our users.

Thanks for the excellent reproduction!

Nicer exception formatting:
Traceback (most recent call last):
  File "/home/peter/PycharmProjects/litestar/litestar/app.py", line 574, in lifespan
    yield
  File "/home/peter/PycharmProjects/litestar/litestar/_asgi/asgi_router.py", line 164, in lifespan
    message = await receive()
  File "/home/peter/.local/share/pdm/venvs/litestar-hello-world-qe1MW6VZ-3.8/lib/python3.8/site-packages/uvicorn/middleware/message_logger.py", line 60, in inner_receive
    message = await receive()
  File "/home/peter/.local/share/pdm/venvs/litestar-hello-world-qe1MW6VZ-3.8/lib/python3.8/site-packages/uvicorn/lifespan/on.py", line 137, in receive
    return await self.receive_queue.get()
  File "/home/peter/.pyenv/versions/3.8.18/lib/python3.8/asyncio/queues.py", line 163, in get
    await getter
asyncio.exceptions.CancelledError

During handling of the above exception, another exception occurred:

  + Exception Group Traceback (most recent call last):
  |   File "/home/peter/PycharmProjects/litestar/litestar/_asgi/asgi_router.py", line 164, in lifespan
  |     message = await receive()
  |   File "/home/peter/.pyenv/versions/3.8.18/lib/python3.8/contextlib.py", line 189, in __aexit__
  |     await self.gen.athrow(typ, value, traceback)
  |   File "/home/peter/PycharmProjects/litestar/litestar/app.py", line 574, in lifespan
  |     yield
  |   File "/home/peter/.pyenv/versions/3.8.18/lib/python3.8/contextlib.py", line 679, in __aexit__
  |     raise exc_details[1]
  |   File "/home/peter/.pyenv/versions/3.8.18/lib/python3.8/contextlib.py", line 662, in __aexit__
  |     cb_suppress = await cb(*exc_details)
  |   File "/home/peter/PycharmProjects/litestar/litestar/events/emitter.py", line 116, in __aexit__
  |     await self._exit_stack.__aexit__(exc_type, exc_val, exc_tb)
  |   File "/home/peter/.pyenv/versions/3.8.18/lib/python3.8/contextlib.py", line 679, in __aexit__
  |     raise exc_details[1]
  |   File "/home/peter/.pyenv/versions/3.8.18/lib/python3.8/contextlib.py", line 662, in __aexit__
  |     cb_suppress = await cb(*exc_details)
  |   File "/home/peter/.local/share/pdm/venvs/litestar-hello-world-qe1MW6VZ-3.8/lib/python3.8/site-packages/anyio/_backends/_asyncio.py", line 664, in __aexit__
  |     raise BaseExceptionGroup(
  | exceptiongroup.ExceptionGroup: unhandled errors in a TaskGroup (1 sub-exception)
  +-+---------------- 1 ----------------
    | Traceback (most recent call last):
    |   File "/home/peter/PycharmProjects/litestar/litestar/events/emitter.py", line 88, in _worker
    |     async for item in receive_stream:
    |   File "/home/peter/.local/share/pdm/venvs/litestar-hello-world-qe1MW6VZ-3.8/lib/python3.8/site-packages/anyio/abc/_streams.py", line 35, in __anext__
    |     return await self.receive()
    |   File "/home/peter/.local/share/pdm/venvs/litestar-hello-world-qe1MW6VZ-3.8/lib/python3.8/site-packages/anyio/streams/memory.py", line 105, in receive
    |     await receive_event.wait()
    |   File "/home/peter/.local/share/pdm/venvs/litestar-hello-world-qe1MW6VZ-3.8/lib/python3.8/site-packages/anyio/_backends/_asyncio.py", line 1621, in wait
    |     await self._event.wait()
    |   File "/home/peter/.pyenv/versions/3.8.18/lib/python3.8/asyncio/locks.py", line 309, in wait
    |     await fut
    | asyncio.exceptions.CancelledError
    |
    | During handling of the above exception, another exception occurred:
    |
    | Exception Group Traceback (most recent call last):
    |   File "/home/peter/PycharmProjects/litestar/litestar/events/emitter.py", line 95, in _worker
    |     print(exc)
    |   File "/home/peter/.local/share/pdm/venvs/litestar-hello-world-qe1MW6VZ-3.8/lib/python3.8/site-packages/anyio/_backends/_asyncio.py", line 664, in __aexit__
    |     raise BaseExceptionGroup(
    | exceptiongroup.ExceptionGroup: unhandled errors in a TaskGroup (1 sub-exception)
    +-+---------------- 1 ----------------
      | Traceback (most recent call last):
      |   File "/home/peter/PycharmProjects/litestar-hello-world/app.py", line 12, in raise_exception_if_odd
      |     raise ValueError(f"{value} is odd")
      | ValueError: 3 is odd
      +------------------------------------


Introduce end-of-line normalization

Let's do this to avoild possible problems?
Some read here http://git-scm.com/docs/gitattributes

Triggering build using a merge of 8410591b600a9e507fef228eb7fe970be9030ae2 on branch master:
Private: https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/mod_cluster-1.3.x-pull-player-executor/

Build 145 outcome was FAILURE using a merge of 8410591b600a9e507fef228eb7fe970be9030ae2 on branch master:
Private: https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/mod_cluster-1.3.x-pull-player-executor/145
Public: https://hudson.jboss.org/hudson/job/mod_cluster-1.3.x-pull-player-executor/145

Also testing the CI job here, so the failure is anticipated, sorry for noise.

Retest this please.
PS: Switching CI job back to JDK7 due to Tomcat 8

Retest this please.

Triggering build using a merge of 8410591b600a9e507fef228eb7fe970be9030ae2 on branch master:
Private: https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/mod_cluster-1.3.x-pull-player-executor/

Build 147 outcome was SUCCESS using a merge of 8410591b600a9e507fef228eb7fe970be9030ae2 on branch master:
Private: https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/mod_cluster-1.3.x-pull-player-executor/147
Public: https://hudson.jboss.org/hudson/job/mod_cluster-1.3.x-pull-player-executor/147


chore(deps): upgrade dev dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-dev-dependencies-k8s-29-main" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 4704

Questions ?
Please refer to the Backport tool documentation


Add Error Nodes Handling for the BLangNodeTransformer

Description:
Currently, BLangNodeTransformer does not address the error nodes such as MissingTokens into consideration.
In the early ANTLR based implementation Compiler just halts on such syntax error without proceeding. In here, since we need to keep parsing process continues; We need to design and come-up with a plan to how to address scenarios such as MissingTokens.
One option might be in the event of missing token for a variable name will be "generate a valid name". Likewise, need to think about all possible scenarios and finalize the design.

Samples:
[n] - Places where something is missing. Replace these [n] with a blank-space for the source.
Function signature:
function [1](int [2], [3] [4]= "hello", int age = [5]) returns [6] {
}

[1], [4] - func name
[2] - param name
[3] - param type-desc
[5] - default value
[6] - return type-desc
Variable decl:
int [1]=[2];

[1] variable name
[2] value

Are these propose changes? Or have done any changes from Compiler FE to ack variable names with spaces? How about two variable declarations missing var name and replacing it with space causing syntax already defined error?

Umm no, these are some sample scenarios to consider when designing/implementing the feature.


TraceLogging.h causing error when building using Clang

When using Clang toolset to compile and do code analysis, using macros from TraceLogging.h are causing build errors. The code mapping to those macros does not seem to be supported by Clang compiler (probably not conformant to the standard?).
Code:

Output:

Note: the code build without any issue using MSVC

@ZenBird can you check this. perhaps #211 fixed it.


Move footer on the bottom of the screen

This should appear as the last thing on the page.
If there is not enough content on the screen, it should stick to the bottom of the viewport

@ankushdharkar can I work on this issue??

I would like to work on this issue.

@MukulKolpe Assigned to you.
Sorry @riyaku11, Could you take up this please: https://github.com/Real-Dev-Squad/website-dashboard/issues/79?

Yes, can you assign #79 to me?


Fixed  error when calling tortoise.destroy

Coverage decreased (-0.02%) to 97.753% when pulling 2f39589426794567d252b144ae3617fef8dafa3f on bbedwell:fix-destroy into 064cfffad9910972535ae3c9ead48f455e86db35 on CompassPHS:master.


CSV Header

It would be great if the header (first line) of a csv file is recognized by this plugin. That way, when I'm scrolling through a long csv file, I can still see the column titles. Thanks for an awesome plugin!

Won't track this as an issue but PR's are welcome.


How to customize the modal based on the datatable input

Hi,
in the below code,datatable is populated by json. modal popsup with add, edit , delete functionalities works fine.javascript objects are used to populate dropdownlists.
var optionActivityColumnsColumnType = {
"true": "Entity Specific Attribute",
"false": "Common Attribute"
}
var url_activitycolumns_get = "xxxxx/api/data/v8.2/ssi_activitiespluscolumns?
$select=.....,ssi_commonattributename,ssi_customattributetype,....";
TableActivityColumns = $('#datatableActivityColumns').DataTable({
    "sPaginationType": "full_numbers",
    ajax: {
        url: url_activitycolumns_get,
        dataType: 'json',
        type: "GET",
        cache: true,
        beforeSend: function (XMLHttpRequest) {
            XMLHttpRequest.setRequestHeader("OData-MaxVersion", "4.0");
            XMLHttpRequest.setRequestHeader("OData-Version", "4.0");
            XMLHttpRequest.setRequestHeader("Accept", "application/json");
            XMLHttpRequest.setRequestHeader("Prefer", "odata.include-annotations=\"*\"");
            XMLHttpRequest.setRequestHeader("Prefer", "odata.include-annotations=\"OData.Community.Display.V1.FormattedValue\"");
        },
        async: false,
        complete: function (json, type) { //type return "success" or "parsererror"
            if (type == "parsererror") {
                alert("parsererror");

            } else {

            }
        },
        dataSrc: function (json) {
            arrDataActivityColumns = [];
            arrItems = [];
            // Convert Json data into 2-d Array
            $.each(json.value, function (index, value) {
             arrItems.push(value.ssi_activitiespluscolumnid);
                arrItems.push(value.ssi_columnheading);
                arrItems.push(value["ssi_columntype"] == null ? "null" : value["ssi_columntype"]);
                arrDataActivityColumns.push(arrItems); // Push The Values Inside the Array to Create 2-D Array
                arrItems = [];
            });

            return arrDataActivityColumns;
        }
    },
    columnDefs: [{
            type: "hidden",
            "targets": [0],
            "visible": false,
            "searchable": false
        },
        {
            type: "select",
            "targets": 2,
            options: optionActivityColumnsColumnType,
            select2: {
                width: "100%"
            },
            render: function (data, type, row, meta) {
                alert(data);
                if (data == null || !(data in optionActivityColumnsColumnType)) return null;
                return optionActivityColumnsColumnType[data];

            }
        },

As you can see in the columnDef , target 2 uses a javascript object optionActivityColumnsColumnType, which is being used to get the datasrc json value of ssi_columntype.
what I want to do is , if the value is true, some fields in the modal should be hidden .
Could some one please help me with this requirement. Thanks in Advance

I'm afraid there is nothing as such.
Anyway, I think that you could reach your goal with some jquery trigger.
Something like this:
$(yourdatatable).on('change', 'the-input-field-that-you-want-to-watch', function(obj) {
    if (obj.value == true)
         $(the-other-field-that-you-want-to-hide).hide()
    else
         $(the-other-field-that-you-want-to-show).show()
    });

Hi, still I cannot figure out, The add or edit dialog is created based on the columndef. So the fields are dynamic. My requirement is if a particular  cell data in column 2 is true, hide field in the edit dialog corresponding to column 8. My assumption was to alter the alteditor js .  createDialog: function (columnDefs, title, buttonCaption, closeCaption, buttonClass) . Please guide if its wrong or if there is a better solution for it.
Thank you

Did you find a solution for this? If not, and you are still interested, you should create some minimal example on fiddlejs.