Seems to be incompatible with 1.16.5

Hey there.
Would you mind taking a look into making it compatible with the newest version please?

I feel it's unlikely that there's anything directly incompatible within DragonFight, but I will investigate shortly. 1.16.5 didn't introduce any relevant API changes, AFAIK.
In the meantime, you should check that NerdNu/BeastMaster dependencies don't refuse to load on 1.16.5, particularly ProtocolLib, LibsDisguises and WorldGuard.

I've just re-tested with:

Latest Paper git-Paper-529 (MC: 1.16.5) (Implementing API version 1.16.5-R0.1-SNAPSHOT)
Latest LibsDisguises from https://www.spigotmc.org/resources/libs-disguises.32453/
Latest stable ProtocolLib (LibsDisguises dependency) https://ci.dmulloy2.net/job/ProtocolLib/lastStableBuild/
Current BeastMaster release https://github.com/NerdNu/BeastMaster/releases/tag/v2.14.0
Current DragonFight release

I suggest if you are running all of these you file a detailed bug report with:

Detailed server version information
Plugin version information
A console log showing exception information or screenshots of error messages

At one stage there were problems with LibsDiguises':

Overly strict handling of disguises: https://github.com/libraryaddict/LibsDisguises/issues/525
Handling of disguised projectiles:  https://github.com/libraryaddict/LibsDisguises/issues/526

It worked, thank you. I think i had an Older Version of libsdisguises

Good to know.


state that Make requires a command line interface

Does it though? Is it not possible to write a function for this? And what about the Build tab in Rstudio?

Its not about invoking Make itself (the Build tab in RStudio does that without command line) but about what software can be employed by Make. E.g. using Excel from within Make.


PeptideIndexer error fixed.

PR checklist

[ ] This comment contains a description of changes (with reason)
[ ] CHANGELOG.md is updated
[ ] If you've fixed a bug or added code that should be tested, add tests!
[ ] Documentation in docs is updated
[ ] If necessary, also make a PR on the nf-core/proteomicslfq branch on the nf-core/test-datasets repo

While this is a nice addition, I think in such cases the reason for unmatched peptides should be investigated first.
In proteogenomics (e.g. point mutations) for example the mismatches_max or max_aaa parameters should be tweaked first. Maybe you can add them, too as advanced params.

Following this topic, the Proteogenomics database contains variants which one/two aminoacids difference but we also added the Protein accession of the Variant protein meaning:
> Reference Protein
AAAAAAAAAAK
> Variant Protein
AAAACAAAAAK

In the example, both proteins are in the database file. I suspect if both peptides are identified, the PeptideIndexer should be able to match Peptide 1 AAAAAAAAAAK -> Reference Protein and Peptide 2 AAAACAAAAAK -> Variant Protein. I actually thought that PeptideIndexer unmatched will only happen when a search engine uses a fancy mechanism to detect variants and start reporting it and you can not match any of those variants to the database.

While this is a nice addition, I think in such cases the reason for unmatched peptides should be investigated first.
In proteogenomics (e.g. point mutations) for example the mismatches_max or max_aaa parameters should be tweaked first. Maybe you can add them, too as advanced params.

Following this topic, the Proteogenomics database contains variants which one/two aminoacids difference but we also added the Protein accession of the Variant protein meaning:
> Reference Protein
AAAAAAAAAAK
> Variant Protein
AAAACAAAAAK

In the example, both proteins are in the database file. I suspect if both peptides are identified, the PeptideIndexer should be able to match Peptide 1 AAAAAAAAAAK -> Reference Protein and Peptide 2 AAAACAAAAAK -> Variant Protein. I actually thought that PeptideIndexer unmatched will only happen when a search engine uses a fancy mechanism to detect variants and start reporting it and you can not match any of those variants to the database.


feature/map-added

Fixes Issue #59

Proposed Changes
This PR add the feature of map so that any one can see their exact latitude and longitude and get the weather according to it.

Checklist (Check all applicable boxes)

[X] My code adheres to the project's coding style.
[ ] My changes require updates to the project's documentation.
[ ] I have updated the documentation accordingly.
[X] All new and existing tests have passed successfully.
[X] This PR does not contain any plagiarized content.
[X] The title of my pull request provides a brief description of the requested changes.

[ ] I am contributing independently.
[X] I am contributing for Hacktoberfest 2023.

Reviewer Notes
I used here leaflet service for maps so run these commands
npm i react-leaflet
npm i leaflet

Thankyou for your contribution @Hardik2972 !
Looking forward to more issues and collaborations.
If you learnt something from this repo make sure to ⭐ this repo.
Thankyou ,Happy coding !🚀


Check parent cte tablesAvailable

🏗 In Progress 🚧
Instead of inherited behaviour check if CTE parent is available in context
Have tested with SqlDelight and passes all tests
closes #543

Closed this as changes can be made on SqlDelight PR instead


add max_channel column for phy interface

Some older Phy-based NWB files, e.g. https://neurosift.app/?p=/nwb&url=https://api.dandiarchive.org/api/assets/b4a15b14-3a7b-49ae-b9ba-fa2c4d8f6c29/download/&dandisetId=000053&dandisetVersion=0.210819.0345 do not have any information that could associate a each unit to an electrode (or physical location). Without this information it is not possible to map a unit to 3D coordinates nor brain area, which has limited the utility of the data for secondary analysis. This is an attempt to remedy this by getting the templates from the Phy output files, calculating the peak channel of each template, and adding that to as a property of the units table.

@h-mayorquin I agree that these indices don't have much meaning if the electrodes table is missing. I think sorting interfaces should write the electrodes table.

But, I do get an error when I try to call the to_dataframe() method on the units table:
---------------------------------------------------------------------------
IndexError                                Traceback (most recent call last)
Cell In[17], [line 9](vscode-notebook-cell:?execution_count=17&line=9)
      [6](vscode-notebook-cell:?execution_count=17&line=6) # max_channel = np.array(nwbfile.units.max_channel.data)
      [7](vscode-notebook-cell:?execution_count=17&line=7) ch = np.array(nwbfile.units.ch.data)
----> [9](vscode-notebook-cell:?execution_count=17&line=9) units_table = nwbfile.units.to_dataframe()

File /opt/anaconda3/envs/schneider_lab_to_nwb_env/lib/python3.12/site-packages/hdmf/utils.py:668, in docval.<locals>.dec.<locals>.func_call(*args, **kwargs)
    [666](https://file+.vscode-resource.vscode-cdn.net/opt/anaconda3/envs/schneider_lab_to_nwb_env/lib/python3.12/site-packages/hdmf/utils.py:666) def func_call(*args, **kwargs):
    [667](https://file+.vscode-resource.vscode-cdn.net/opt/anaconda3/envs/schneider_lab_to_nwb_env/lib/python3.12/site-packages/hdmf/utils.py:667)     pargs = _check_args(args, kwargs)
--> [668](https://file+.vscode-resource.vscode-cdn.net/opt/anaconda3/envs/schneider_lab_to_nwb_env/lib/python3.12/site-packages/hdmf/utils.py:668)     return func(args[0], **pargs)

File /opt/anaconda3/envs/schneider_lab_to_nwb_env/lib/python3.12/site-packages/hdmf/common/table.py:1225, in DynamicTable.to_dataframe(self, **kwargs)
   [1217](https://file+.vscode-resource.vscode-cdn.net/opt/anaconda3/envs/schneider_lab_to_nwb_env/lib/python3.12/site-packages/hdmf/common/table.py:1217) """
   [1218](https://file+.vscode-resource.vscode-cdn.net/opt/anaconda3/envs/schneider_lab_to_nwb_env/lib/python3.12/site-packages/hdmf/common/table.py:1218) Produce a pandas DataFrame containing this table's data.
   [1219](https://file+.vscode-resource.vscode-cdn.net/opt/anaconda3/envs/schneider_lab_to_nwb_env/lib/python3.12/site-packages/hdmf/common/table.py:1219)
   (...)
   [1222](https://file+.vscode-resource.vscode-cdn.net/opt/anaconda3/envs/schneider_lab_to_nwb_env/lib/python3.12/site-packages/hdmf/common/table.py:1222) If exclude is None, this is equivalent to table.get(slice(None, None, None), index=False).
   [1223](https://file+.vscode-resource.vscode-cdn.net/opt/anaconda3/envs/schneider_lab_to_nwb_env/lib/python3.12/site-packages/hdmf/common/table.py:1223) """
   [1224](https://file+.vscode-resource.vscode-cdn.net/opt/anaconda3/envs/schneider_lab_to_nwb_env/lib/python3.12/site-packages/hdmf/common/table.py:1224) arg = slice(None, None, None)  # select all rows
-> [1225](https://file+.vscode-resource.vscode-cdn.net/opt/anaconda3/envs/schneider_lab_to_nwb_env/lib/python3.12/site-packages/hdmf/common/table.py:1225) sel = self.__get_selection_as_dict(arg, df=True, **kwargs)
   [1226](https://file+.vscode-resource.vscode-cdn.net/opt/anaconda3/envs/schneider_lab_to_nwb_env/lib/python3.12/site-packages/hdmf/common/table.py:1226) ret = self.__get_selection_as_df(sel)
   [1227](https://file+.vscode-resource.vscode-cdn.net/opt/anaconda3/envs/schneider_lab_to_nwb_env/lib/python3.12/site-packages/hdmf/common/table.py:1227) return ret

File /opt/anaconda3/envs/schneider_lab_to_nwb_env/lib/python3.12/site-packages/hdmf/common/table.py:1088, in DynamicTable.__get_selection_as_dict(self, arg, df, index, exclude, **kwargs)
   [1086](https://file+.vscode-resource.vscode-cdn.net/opt/anaconda3/envs/schneider_lab_to_nwb_env/lib/python3.12/site-packages/hdmf/common/table.py:1086)     raise IndexError(msg) from ie
   [1087](https://file+.vscode-resource.vscode-cdn.net/opt/anaconda3/envs/schneider_lab_to_nwb_env/lib/python3.12/site-packages/hdmf/common/table.py:1087) else:  # pragma: no cover
-> [1088](https://file+.vscode-resource.vscode-cdn.net/opt/anaconda3/envs/schneider_lab_to_nwb_env/lib/python3.12/site-packages/hdmf/common/table.py:1088)     raise ie

File /opt/anaconda3/envs/schneider_lab_to_nwb_env/lib/python3.12/site-packages/hdmf/common/table.py:1063, in DynamicTable.__get_selection_as_dict(self, arg, df, index, exclude, **kwargs)
   [1061](https://file+.vscode-resource.vscode-cdn.net/opt/anaconda3/envs/schneider_lab_to_nwb_env/lib/python3.12/site-packages/hdmf/common/table.py:1061)             ret[name] = col.get(arg, df=False, index=True, **kwargs)
   [1062](https://file+.vscode-resource.vscode-cdn.net/opt/anaconda3/envs/schneider_lab_to_nwb_env/lib/python3.12/site-packages/hdmf/common/table.py:1062)         else:
-> [1063](https://file+.vscode-resource.vscode-cdn.net/opt/anaconda3/envs/schneider_lab_to_nwb_env/lib/python3.12/site-packages/hdmf/common/table.py:1063)             ret[name] = col.get(arg, df=df, index=index, **kwargs)
   [1064](https://file+.vscode-resource.vscode-cdn.net/opt/anaconda3/envs/schneider_lab_to_nwb_env/lib/python3.12/site-packages/hdmf/common/table.py:1064)     return ret
   [1065](https://file+.vscode-resource.vscode-cdn.net/opt/anaconda3/envs/schneider_lab_to_nwb_env/lib/python3.12/site-packages/hdmf/common/table.py:1065) # if index is out of range, different errors can be generated depending on the dtype of the column
   [1066](https://file+.vscode-resource.vscode-cdn.net/opt/anaconda3/envs/schneider_lab_to_nwb_env/lib/python3.12/site-packages/hdmf/common/table.py:1066) # but despite the differences, raise an IndexError from that error

File /opt/anaconda3/envs/schneider_lab_to_nwb_env/lib/python3.12/site-packages/hdmf/common/table.py:1462, in DynamicTableRegion.get(self, arg, index, df, **kwargs)
   [1460](https://file+.vscode-resource.vscode-cdn.net/opt/anaconda3/envs/schneider_lab_to_nwb_env/lib/python3.12/site-packages/hdmf/common/table.py:1460) uniq = np.unique(ret)
   [1461](https://file+.vscode-resource.vscode-cdn.net/opt/anaconda3/envs/schneider_lab_to_nwb_env/lib/python3.12/site-packages/hdmf/common/table.py:1461) lut = {val: i for i, val in enumerate(uniq)}
-> [1462](https://file+.vscode-resource.vscode-cdn.net/opt/anaconda3/envs/schneider_lab_to_nwb_env/lib/python3.12/site-packages/hdmf/common/table.py:1462) values = self.table.get(uniq, df=df, index=index, **kwargs)
   [1463](https://file+.vscode-resource.vscode-cdn.net/opt/anaconda3/envs/schneider_lab_to_nwb_env/lib/python3.12/site-packages/hdmf/common/table.py:1463) if df:
   [1464](https://file+.vscode-resource.vscode-cdn.net/opt/anaconda3/envs/schneider_lab_to_nwb_env/lib/python3.12/site-packages/hdmf/common/table.py:1464)     ret = values.iloc[[lut[i] for i in ret]]

File /opt/anaconda3/envs/schneider_lab_to_nwb_env/lib/python3.12/site-packages/hdmf/common/table.py:1025, in DynamicTable.get(self, key, default, df, index, **kwargs)
   [1021](https://file+.vscode-resource.vscode-cdn.net/opt/anaconda3/envs/schneider_lab_to_nwb_env/lib/python3.12/site-packages/hdmf/common/table.py:1021)         return default
   [1022](https://file+.vscode-resource.vscode-cdn.net/opt/anaconda3/envs/schneider_lab_to_nwb_env/lib/python3.12/site-packages/hdmf/common/table.py:1022) else:
   [1023](https://file+.vscode-resource.vscode-cdn.net/opt/anaconda3/envs/schneider_lab_to_nwb_env/lib/python3.12/site-packages/hdmf/common/table.py:1023)     # index by int, list, np.ndarray, or slice -->
   [1024](https://file+.vscode-resource.vscode-cdn.net/opt/anaconda3/envs/schneider_lab_to_nwb_env/lib/python3.12/site-packages/hdmf/common/table.py:1024)     # return pandas Dataframe or lists consisting of one or more rows
-> [1025](https://file+.vscode-resource.vscode-cdn.net/opt/anaconda3/envs/schneider_lab_to_nwb_env/lib/python3.12/site-packages/hdmf/common/table.py:1025)     sel = self.__get_selection_as_dict(key, df, index, **kwargs)
   [1026](https://file+.vscode-resource.vscode-cdn.net/opt/anaconda3/envs/schneider_lab_to_nwb_env/lib/python3.12/site-packages/hdmf/common/table.py:1026)     if df:
   [1027](https://file+.vscode-resource.vscode-cdn.net/opt/anaconda3/envs/schneider_lab_to_nwb_env/lib/python3.12/site-packages/hdmf/common/table.py:1027)         # reformat objects to fit into a pandas DataFrame
   [1028](https://file+.vscode-resource.vscode-cdn.net/opt/anaconda3/envs/schneider_lab_to_nwb_env/lib/python3.12/site-packages/hdmf/common/table.py:1028)         if np.isscalar(key):

File /opt/anaconda3/envs/schneider_lab_to_nwb_env/lib/python3.12/site-packages/hdmf/common/table.py:1088, in DynamicTable.__get_selection_as_dict(self, arg, df, index, exclude, **kwargs)
   [1086](https://file+.vscode-resource.vscode-cdn.net/opt/anaconda3/envs/schneider_lab_to_nwb_env/lib/python3.12/site-packages/hdmf/common/table.py:1086)     raise IndexError(msg) from ie
   [1087](https://file+.vscode-resource.vscode-cdn.net/opt/anaconda3/envs/schneider_lab_to_nwb_env/lib/python3.12/site-packages/hdmf/common/table.py:1087) else:  # pragma: no cover
-> [1088](https://file+.vscode-resource.vscode-cdn.net/opt/anaconda3/envs/schneider_lab_to_nwb_env/lib/python3.12/site-packages/hdmf/common/table.py:1088)     raise ie

File /opt/anaconda3/envs/schneider_lab_to_nwb_env/lib/python3.12/site-packages/hdmf/common/table.py:1053, in DynamicTable.__get_selection_as_dict(self, arg, df, index, exclude, **kwargs)
   [1050](https://file+.vscode-resource.vscode-cdn.net/opt/anaconda3/envs/schneider_lab_to_nwb_env/lib/python3.12/site-packages/hdmf/common/table.py:1050) ret = OrderedDict()
   [1051](https://file+.vscode-resource.vscode-cdn.net/opt/anaconda3/envs/schneider_lab_to_nwb_env/lib/python3.12/site-packages/hdmf/common/table.py:1051) try:
   [1052](https://file+.vscode-resource.vscode-cdn.net/opt/anaconda3/envs/schneider_lab_to_nwb_env/lib/python3.12/site-packages/hdmf/common/table.py:1052)     # index with a python slice or single int to select one or multiple rows
-> [1053](https://file+.vscode-resource.vscode-cdn.net/opt/anaconda3/envs/schneider_lab_to_nwb_env/lib/python3.12/site-packages/hdmf/common/table.py:1053)     ret['id'] = self.id[arg]
   [1054](https://file+.vscode-resource.vscode-cdn.net/opt/anaconda3/envs/schneider_lab_to_nwb_env/lib/python3.12/site-packages/hdmf/common/table.py:1054)     for name in self.colnames:
   [1055](https://file+.vscode-resource.vscode-cdn.net/opt/anaconda3/envs/schneider_lab_to_nwb_env/lib/python3.12/site-packages/hdmf/common/table.py:1055)         if name in exclude:

File /opt/anaconda3/envs/schneider_lab_to_nwb_env/lib/python3.12/site-packages/hdmf/container.py:940, in Data.__getitem__(self, args)
    [939](https://file+.vscode-resource.vscode-cdn.net/opt/anaconda3/envs/schneider_lab_to_nwb_env/lib/python3.12/site-packages/hdmf/container.py:939) def __getitem__(self, args):
--> [940](https://file+.vscode-resource.vscode-cdn.net/opt/anaconda3/envs/schneider_lab_to_nwb_env/lib/python3.12/site-packages/hdmf/container.py:940)     return self.get(args)

File /opt/anaconda3/envs/schneider_lab_to_nwb_env/lib/python3.12/site-packages/hdmf/container.py:948, in Data.get(self, args)
    [945](https://file+.vscode-resource.vscode-cdn.net/opt/anaconda3/envs/schneider_lab_to_nwb_env/lib/python3.12/site-packages/hdmf/container.py:945) if isinstance(self.data, h5py.Dataset) and isinstance(args, np.ndarray):
    [946](https://file+.vscode-resource.vscode-cdn.net/opt/anaconda3/envs/schneider_lab_to_nwb_env/lib/python3.12/site-packages/hdmf/container.py:946)     # This is needed for h5py 2.9 compatibility
    [947](https://file+.vscode-resource.vscode-cdn.net/opt/anaconda3/envs/schneider_lab_to_nwb_env/lib/python3.12/site-packages/hdmf/container.py:947)     args = args.tolist()
--> [948](https://file+.vscode-resource.vscode-cdn.net/opt/anaconda3/envs/schneider_lab_to_nwb_env/lib/python3.12/site-packages/hdmf/container.py:948) return self.data[args]

File h5py/_objects.pyx:54, in h5py._objects.with_phil.wrapper()

File h5py/_objects.pyx:55, in h5py._objects.with_phil.wrapper()

File /opt/anaconda3/envs/schneider_lab_to_nwb_env/lib/python3.12/site-packages/h5py/_hl/dataset.py:758, in Dataset.__getitem__(self, args, new_dtype)
    [756](https://file+.vscode-resource.vscode-cdn.net/opt/anaconda3/envs/schneider_lab_to_nwb_env/lib/python3.12/site-packages/h5py/_hl/dataset.py:756) if self._fast_read_ok and (new_dtype is None):
    [757](https://file+.vscode-resource.vscode-cdn.net/opt/anaconda3/envs/schneider_lab_to_nwb_env/lib/python3.12/site-packages/h5py/_hl/dataset.py:757)     try:
--> [758](https://file+.vscode-resource.vscode-cdn.net/opt/anaconda3/envs/schneider_lab_to_nwb_env/lib/python3.12/site-packages/h5py/_hl/dataset.py:758)         return self._fast_reader.read(args)
    [759](https://file+.vscode-resource.vscode-cdn.net/opt/anaconda3/envs/schneider_lab_to_nwb_env/lib/python3.12/site-packages/h5py/_hl/dataset.py:759)     except TypeError:
    [760](https://file+.vscode-resource.vscode-cdn.net/opt/anaconda3/envs/schneider_lab_to_nwb_env/lib/python3.12/site-packages/h5py/_hl/dataset.py:760)         pass  # Fall back to Python read pathway below

File h5py/_selector.pyx:361, in h5py._selector.Reader.read()

File h5py/_selector.pyx:212, in h5py._selector.Selector.apply_args()

IndexError: Fancy indexing out of range for (0-0)

That's great, you said that you have location data for the channels right? I think that if we plot the distance between the locations of the calculated best_channel and the user defined best channels the effect on the plot should be even clearer.
I also tested artificial data and obtained matching results from @bendichter method:
https://gist.github.com/h-mayorquin/11a2e30a9fe1dad45c2075697f2e44e6
I think this is ready to go, we should just add a docstring. I also would like to not use the spikeinterface method to read the nwbfile for the reasons mentioned above.

I think this is ready to go

What about the to_dataframe() error?

I think this is ready to go

What about the to_dataframe() error?

Let me see if I can reproduce wit the mock sorting.

@pauladkisson
This works for me without error
from neuroconv.tools.testing import MockSortingInterface, MockRecordingInterface

recording_interface = MockRecordingInterface(durations=[1.0])
nwbfile = recording_interface.create_nwbfile()

sorting_interface = MockSortingInterface(num_units=3)
sorting_interface.sorting_extractor.set_property(key="max_channel", values=[0, 1, 2])

metadata = sorting_interface.get_metadata()
sorting_interface.add_to_nwbfile(nwbfile, metadata=metadata)

from pynwb import NWBHDF5IO

with NWBHDF5IO("test.nwb", mode="w") as io:
    io.write(nwbfile)

with NWBHDF5IO("test.nwb", mode="r") as io:
    read_nwbfile = io.read()
    units_df = read_nwbfile.units.to_dataframe()

units_df

I wonder what's going on. Did you write the electrodes table before?

Ok, I tracked down the problem to https://github.com/catalystneuro/neuroconv/tree/add_max_channel_for_phy/src/neuroconv/tools/spikeinterface/spikeinterface.py#L1476
I'm not sure what this code is supposed to do exactly, but if max_channel is named something different (ex. 'my_max_channel') it no longer fails.
@h-mayorquin, any idea what's going on here?

Ok, I tracked down the problem to https://github.com/catalystneuro/neuroconv/tree/add_max_channel_for_phy/src/neuroconv/tools/spikeinterface/spikeinterface.py#L1476
I'm not sure what this code is supposed to do exactly, but if max_channel is named something different (ex. 'my_max_channel') it no longer fails.
@h-mayorquin, any idea what's going on here?

The code is creating the link.
Can you open an issue with the script that reproduces this error? If you can use the mock interfaces great but I can also download the data from google drive if that is not possible.

I can't replicate with a mock, but here is the code that gives an error with Schneider Lab data
from neuroconv.tools.testing import MockSortingInterface, MockRecordingInterface
from neuroconv.datainterfaces import PhySortingInterface

def main():
    recording_interface = MockRecordingInterface(durations=[1.0])
    nwbfile = recording_interface.create_nwbfile()

    folder_path = "/Volumes/T7/CatalystNeuro/Schneider/Schneider sample Data/Processed Ephys/m69_2023-10-31_17-24-15_Day1_A1"
    sorting_interface = PhySortingInterface(folder_path=folder_path)

    metadata = sorting_interface.get_metadata()
    sorting_interface.add_to_nwbfile(nwbfile, metadata=metadata)

    from pynwb import NWBHDF5IO

    with NWBHDF5IO("test.nwb", mode="w") as io:
        io.write(nwbfile)

    with NWBHDF5IO("test.nwb", mode="r") as io:
        read_nwbfile = io.read()
        units_df = read_nwbfile.units.to_dataframe()

    print(units_df)

if __name__ == "__main__":
    main()


maps_topdown_object

I cannot find the img list star_yellow,blue in maps_topdown_object this unexist folder.

You can download the assets from this link.


An error when training with my own dataset with scale 3

When running EDSR model with scale 3, the following error occurs, scale 2 and 4 is OK, did anyone encounter this problem?
Traceback (most recent call last):   File "D:/EDSR-PyTorch-master/src/main.py", line 35, in <module>     main()   File "D:/EDSR-PyTorch-master/src/main.py", line 29, in main     t.train()   File "D:\EDSR-PyTorch-master\src\trainer.py", line 41, in train     for batch, (lr, hr, _, idx_scale) in enumerate(self.loader_train):   File "D:\Anaconda3\envs\EDSR\lib\site-packages\torch\utils\data\dataloader.py", line 637, in __next__     return self._process_next_batch(batch)   File "D:\Anaconda3\envs\EDSR\lib\site-packages\torch\utils\data\dataloader.py", line 658, in _process_next_batch     raise batch.exc_type(batch.exc_msg) RuntimeError: Traceback (most recent call last):   File "D:\EDSR-PyTorch-master\src\dataloader.py", line 65, in _ms_loop     samples = collate_fn([dataset[i] for i in batch_indices])   File "D:\Anaconda3\envs\EDSR\lib\site-packages\torch\utils\data\dataloader.py", line 232, in default_collate     return [default_collate(samples) for samples in transposed]   File "D:\Anaconda3\envs\EDSR\lib\site-packages\torch\utils\data\dataloader.py", line 232, in <listcomp>     return [default_collate(samples) for samples in transposed]   File "D:\Anaconda3\envs\EDSR\lib\site-packages\torch\utils\data\dataloader.py", line 209, in default_collate     return torch.stack(batch, 0, out=out) RuntimeError: invalid argument 0: Sizes of tensors must match except in dimension 0. Got 48 and 47 in dimension 2 at c:\a\w\1\s\tmp_conda_3.6_094431\conda\conda-bld\pytorch_1550396825513\work\aten\src\th\generic/THTensorMoreMath.cpp:1307

Hey @m732367606 , I see that you've closed this issue. I was wondering if you found the solution to this?
I'm having a similar issue too as your error message.

Hey @m732367606 , I see that you've closed this issue. I was wondering if you've found the solution to this?
I'm having a similar issue too as your error message.

The solution was to make training images' size are capable of being divided. For instance, use images whose size 384*384 since 384 can be divided by 2,3,4 with without any remainder.
Hope that can help you!

hey I am meeting an question when i train my own datasets ,I didnot know where to put my HR resolution images and LR images , I am too confused . Hope your help sooooo much


Improve lexer performance

Right now ddmd's lexer is much faster: http://i.imgur.com/k50dFbU.png

http://i.imgur.com/D5IAlvl.png


Some preview pane improvements

Resolved / Related Issues
Items resolved / related issues by this PR.

Closes #issue...
Related #issue...

Details of Changes
Add details of changes here.

Move preview pane to main page
Added properties listed in #4487
Switched to rounded rectangle aka pill for resizer
Added a brush for the preview pane bg so that it can be themed with an acrylic brush
Implement minimum sizes
cache properties list to improve performance
Disable preview pane for very small window sizes (since it doesn't really work anyway)
switch to toggle button for preview pane button in nav toolbar
Added button to show preview for online only items in cloud drives to help prevent downloading them unintentionally
Added progress ring while loading preview
Updated design

Validation
How did you test these changes?

[x] Built and ran the app
[ ] Tested the changes for accessibility

Screenshots (optional)

https://user-images.githubusercontent.com/17484252/122638384-0afecb00-d0f4-11eb-90ff-6d804045f2e8.mp4
There is this weird text animation when filling the preview pane which moves the text up a bit. I feel like this should get removed. What do you think?

There is this weird text animation when filling the preview pane which moves the text up a bit. I feel like this should get removed. What do you think?

That's the default animation when items are added to the ListView. I think it makes the transition smoother when opening the pane and when switching the selected item. However, I am open to removing it if others think it should be removed as well.

I know this is a weird and niche ask, but is there any value in tying the direction of the animated transition, to the relative position of the item being tapped?
So in list and details view, the next item you click would be either above or below the current item.
In the grid views the next item could be above, below, to the left or right.

I know this is a weird and niche ask, but is there any value in tying the direction of the animated transition, to the relative position of the item being tapped?
So in list and details view, the next item you click would be either above or below the current item.
In the grid views the next item could be above, below, to the left or right.

It is possible, but why though?

I know this is a weird and niche ask, but is there any value in tying the direction of the animated transition, to the relative position of the item being tapped?
So in list and details view, the next item you click would be either above or below the current item.
In the grid views the next item could be above, below, to the left or right.

It is possible, but why though?

I just thought it would be neat if the preview pane transition felt linked and relative to the actions you are taking in the icon view :)
A little attention to detail that would feel nice.

I know this is a weird and niche ask, but is there any value in tying the direction of the animated transition, to the relative position of the item being tapped?
So in list and details view, the next item you click would be either above or below the current item.
In the grid views the next item could be above, below, to the left or right.

One idea would be to use a connected animation for the item icon.

@winston-de It looks a little off to have the round corners on the preview pane, can you try reverting that?

I know this is a weird and niche ask, but is there any value in tying the direction of the animated transition, to the relative position of the item being tapped?
So in list and details view, the next item you click would be either above or below the current item.
In the grid views the next item could be above, below, to the left or right.

One idea would be to use a connected animation for the item icon.

The transitions are in two different panes, so not sure if a connected animation makes sense, as you wouldn't want any text or icon moving from the list/grid view, over to the Preview/Details pane.

@winston-de Can you resolve the merge conflicts?

@winston-de Great work!


Navigation Samples are missing from the repository

@harikmenon - This has been added, hence closing it.


TernDef can not jump correctly from within a JSON object.

I am not sure if this is a Tern issue or a tern_for_vim plugin issue. In below code snippet, If you run TernDef from this.fun1() line (cursor is under fun1), You will get no definition found. Any clue for this? Thanks.
var obj = {
fun1: function(){
console.log("fun1 is running");
},
fun2: function(){
this.fun1();   //this line, you run TernDef command
}
}

Attached Tern patch should help (you'll have to manually update Tern from git to get it, though)


Investigate Steps not being updated correctly during migration.

e.g. steps 'bagit creation and upload' and 'Export with PREMIS data' in Process b3061451x with ID 302499

steps now appear correctly after import


docs: update pass documentation with password-name

This will update the README.md to include setting the configuration
option password-name when using pass.

Thanks for the PR!  Sorry for the delay.


fix wrong image name in docker run comment

Signed-off-by: Martin Palma<EMAIL_ADDRESS>

Thanks @mazebuhu


No rule passed into vue-valid8 creates console error.

When creating elements dynamically that do not have any rules, cannot pass an empty string. validateAll with a scope is called but sits in pending on the promise. The rule must have any type of value but will display a console error at validateRule in validation.js.
Is it possible to check if the rule is empty and pass if no validation is necessary?

If you pass false to the validation, it won't try to validate anything already. Is this what you're looking for?


Issue with migrations

Getting the below error on running the build - created using make build
{"args":[0.014014875],"component":"pop","level":"info","msg":"%.4f seconds","time":"2024-08-20T19:06:21Z"}
{"level":"fatal","msg":"running db migrations: error executing migrations/20240729123726_add_mfa_phone_config.up.sql, sql: do $$ begin\n    alter type auth.factor_type add value 'phone';\nexception\n    when duplicate_object then null;\nend $$;\n\n\nalter table auth.mfa_factors add column if not exists phone text unique default null;\nalter table auth.mfa_challenges add column if not exists otp_code text null;\n\n\ncreate unique index if not exists unique_verified_phone_factor on auth.mfa_factors (user_id, phone);\n: ERROR: type \"auth.factor_type\" does not exist (SQLSTATE 42704)","time":"2024-08-20T19:06:21Z"}

Below is my .env.example - I have added these variables, please let me know if I am missing anything.
GOTRUE_JWT_SECRET=
GOTRUE_JWT_EXP=
GOTRUE_JWT_AUD=
GOTRUE_JWT_DEFAULT_GROUP_NAME=
GOTRUE_JWT_ADMIN_ROLES=

GOTRUE_DB_DRIVER=
DB_NAMESPACE=
DATABASE_URL=
API_EXTERNAL_URL=
GOTRUE_API_HOST=
PORT=

GOTRUE_SMTP_HOST=
GOTRUE_SMTP_PORT=
GOTRUE_SMTP_USER=
GOTRUE_SMTP_MAX_FREQUENCY=
GOTRUE_SMTP_PASS=
GOTRUE_SMTP_ADMIN_EMAIL=
GOTRUE_SMTP_SENDER_NAME=

# Google OAuth config
GOTRUE_EXTERNAL_GOOGLE_ENABLED=
GOTRUE_EXTERNAL_GOOGLE_CLIENT_ID=
GOTRUE_EXTERNAL_GOOGLE_SECRET=
GOTRUE_EXTERNAL_GOOGLE_REDIRECT_URI=

# Signup config
GOTRUE_DISABLE_SIGNUP=
GOTRUE_SITE_URL=
GOTRUE_EXTERNAL_EMAIL_ENABLED=
GOTRUE_EXTERNAL_PHONE_ENABLED=
GOTRUE_EXTERNAL_IOS_BUNDLE_ID=

GOTRUE_URI_ALLOW_LIST=

# Additional Security config
GOTRUE_LOG_LEVEL=
GOTRUE_SECURITY_REFRESH_TOKEN_ROTATION_ENABLED=
GOTRUE_SECURITY_REFRESH_TOKEN_REUSE_INTERVAL=
GOTRUE_SECURITY_UPDATE_PASSWORD_REQUIRE_REAUTHENTICATION=
GOTRUE_OPERATOR_TOKEN=
GOTRUE_RATE_LIMIT_HEADER=

@siddharth-sable if you're using the docker setup, maybe try clearing the schema and starting from scratch?

Hey @kangmingtay, I am not using docker. Any workaround for local setup?

Hey @siddharth-sable,
Thanks for flagging the issue. Could you try using docker? Once it's downloaded one can run make dev
Alternatively, to continue down the local route if you have no existing data it should be possible to reset the db (e.g. drop the database and recreate).
If that is not an option either you can try running
do $$ begin
    create type auth.factor_type as enum('totp', 'webauthn');
exception
    when duplicate_object then null;
end $$;

and see if that works for you
Let us know

Hey @siddharth-sable,
I'm going to close the issue for now but if the issue persists feel free to reach out to us at supabase.help anytime

I am having a similar same issue, I ran a db upgrade today from the dashboard and since then the a bunch of services stopped working.
Trying to start Supabase locally I am getting:
running db migrations: error executing /usr/local/etc/auth/migrations/20240729123726_add_mfa_phone_config.up.sql, sql: do $$ begin\n    alter type auth.factor_type add value 'phone';\nexception\n    when duplicate_object then null;\nend $$;\n\n\nalter table auth.mfa_factors add column if not exists phone text unique default null;\nalter table auth.mfa_challenges add column if not exists otp_code text null;\n\n\ncreate unique index if not exists unique_verified_phone_factor on auth.mfa_factors (user_id, phone);\n: ERROR: must be owner of type factor_type (SQLSTATE 42501)","time":"2024-09-11T21:3...

This error means you used the wrong user for migration or maybe don't have permissions on that action
Remember to run init_postgres, to create supabase_auth, etc...
Then connect to db supabase_auth_admin follow sample env docker file
I have the same issue because I don't realize that
p/s: I deploy in rds aws so I can't run the init script directly, so I run by SQL console in db manager app (pgadmin,...) through default user postgres with some adjustment

-- adjustment to make postgres user can do below action
grant supabase_admin to postgres;
grant supabase_auth_admin to postgres;

-- Supabase super admin
CREATE USER supabase_auth_admin NOINHERIT CREATEROLE LOGIN NOREPLICATION PASSWORD 'root';
CREATE SCHEMA IF NOT EXISTS auth AUTHORIZATION supabase_auth_admin;
GRANT CREATE ON DATABASE postgres TO supabase_auth_admin;
ALTER USER supabase_auth_admin SET search_path = 'auth';```


[AVM Module Issue]: Address issue where data sources could cause accidental deletion

Check for previous/existing GitHub issues

[X] I have checked for previous/existing GitHub issues

Issue Type?
Bug
(Optional) Module Version
0.3.1
(Optional) Correlation Id
No response
Description
The core team has identified an issue where data sources used in providing location data can cause accidental deletion of resource.  Removing the data source and making the location field mandatory is recommend.

Closed by PR 26, and version 0.4.0


Failed to use Vue component in markdown

I think the case conversion of plug-in V14 is incorrect when converting markdown to Vue components, which leads to the problem.
When I change the plug-in version to V13, it can be loaded successfully

Even ClientOnly cannot render successfully
↓↓↓↓↓↓↓↓↓↓↓You can see examples here↓↓↓↓↓↓↓↓↓↓↓
demo
↑↑↑↑↑↑↑↑↑↑↑You can see examples here↑↑↑↑↑↑↑↑↑↑↑

Please change the package Dependency in JSON "vite-plugin-md": "^0.14.0" -> "vite-plugin-md": "0.13.1"

@FuBaooo can you produce a reproducible example on Stackblitz?

it definitely does work if you use formal HTML syntax: example

I have been surprised for years that there hasn't been a greater push to move toward the standard. It's true there's no inherient advantage to either approach --  it's just another tabs vs spaces debate -- but the exception in this case is one is a a standard and the other is not. It would appear that Markdown It as a parser doesn't care but happy-dom does and losses the capitalization in its representation of the DOM API.

Thank you for your answer. I habitually use the way Vue is written. At the same time, I see that antfu is used in this way, so I think this is correct.
I will correct the use method in my project.

I will look a bit more into this but I believe this is because we're using DOM operations and officially uppercase characters are not valid HTML and are probably lost in one of the DOM transforms. In general I would always recommend that you use the dasherized form for component names as this is true to the specificiation.

@FuBaooo components are very commonly written in PascalCase and typically the first parser to receive that HTML is VueJS (or whatever framework the author is using). For this reason, so long as VueJS is happy with PascalCase it works (and VueJS definitely is happy with either format). However, when it goes further down the stack ,the HTML specification for "custom components" states that non-standard components must be dasherized. That means not only is PascalCase incorrect but single word components are also incorrect.
I presume the reason that PascalCase is so common is that kebab-case is language incompatible with Javascript so people like the consistency in naming. That still doesn't change the fact that when it comes to the official HTML specification that this is indeed non-standard. It may be a long road before HTML custom components rule the world but by then either the HTML specification will have to have been changed or parsers like VueJS will have to have incorporated the conversion before it arrives in the browser. I'm actually interested to see what VueJS does when you turn on the "custom component" flag on it's parser.
Anyway, because PascalCase is so common I think we need to support it ... and I think the easiest way to do so is just to convert it to kebab-case in this component. It should then work through the remainder of the transformatiion pipeline.

@FuBaooo components are very commonly written in PascalCase and typically the first parser to receive that HTML is VueJS (or whatever framework the author is using). For this reason, so long as VueJS is happy with PascalCase it works (and VueJS definitely is happy with either format). However, when it goes further down the stack ,the HTML specification for "custom components" states that non-standard components must be dasherized. That means not only is PascalCase incorrect but single word components are also incorrect.
I presume the reason that PascalCase is so common is that kebab-case is language incompatible with Javascript so people like the consistency in naming. That still doesn't change the fact that when it comes to the official HTML specification that this is indeed non-standard. It may be a long road before HTML custom components rule the world but by then either the HTML specification will have to have been changed or parsers like VueJS will have to have incorporated the conversion before it arrives in the browser. I'm actually interested to see what VueJS does when you turn on the "custom component" flag on it's parser.
Anyway, because PascalCase is so common I think we need to support it ... and I think the easiest way to do so is just to convert it to kebab-case in this component. It should then work through the remainder of the transformatiion pipeline.

I think it should be added

this will now convert your PacalCase components to kebab-case automatically when detected in v0.16.0


Build stops with error

Hello!
I downloaded your branch, and try to build openssl to use it in my iOS application. After a while the build process stops, and in the log file I have something like this (the demo xcode project keep says I have to run the script first):
cp: openssl: No such file or directory
make[1]: *** [install] Error 1
make: *** [install_sw] Error 1

build-openssl-1.0.2e.log.zip
I'm using xCode 7.2 (7C68). Do you have any idea what am I doing wrong? I attached the full log I get
Thanks for your help

@torokzsolt
Your root error may be follow. (at line 1131 in your zip)
Undefined symbols for architecture i386:

Make install error comes from simply nothing of copy source.
I worry about those lines at 1129, 1130.
ld: warning: ignoring file /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator9.2.sdk/usr/lib/libSystem.dylib, file was built for x86_64 which is not the architecture being linked (i386): /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator9.2.sdk/usr/lib/libSystem.dylib
ld: warning: ignoring file /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/clang/7.0.2/lib/darwin/libclang_rt.ios.a, missing required architecture i386 in file /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../lib/clang/7.0.2/lib/darwin/libclang_rt.ios.a (5 slices)

Please tell me output of follows.
$ lipo -info /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator9.2.sdk/usr/lib/libSystem.dylib
$ lipo -info /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/7.0.2/lib/darwin/libclang_rt.ios.a

Just for information, my result is
[omochi@omochi-MB ~]$ lipo -info /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator9.2.sdk/usr/lib/libSystem.dylib
Architectures in the fat file: /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator9.2.sdk/usr/lib/libSystem.dylib are: i386 x86_64
[omochi@omochi-MB ~]$ lipo -info /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/7.0.2/lib/darwin/libclang_rt.ios.a
Architectures in the fat file: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/7.0.2/lib/darwin/libclang_rt.ios.a are: i386 armv7 armv7k armv7s x86_64 arm64

Thanks for your answear. The output of the commands you asked for is the following:

$ lipo -info /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator9.2.sdk/usr/lib/libSystem.dylib
Non-fat file: /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator9.2.sdk/usr/lib/libSystem.dylib is architecture: x86_64
$ lipo -info /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/7.0.2/lib/darwin/libclang_rt.ios.a
Architectures in the fat file: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/7.0.2/lib/darwin/libclang_rt.ios.a are: armv7 armv7k armv7s x86_64 arm64

@torokzsolt
Hmm... This is strange.
We need i386 binary for 32bit iPhone Simulator target.
Its not special to OpenSSL, its iOS development generic topic.
I have no confidence, but recommend you to reinstall Xcode.
Or another approach, you can specify build target architectures with my fork of this script.
https://github.com/omochi/OpenSSL-for-iPhone/tree/new/selectable-archs
Please clone mine and switch branch new/selectable-archs.
I excluded i386 and AppleTVs below example.
$ git clone https://github.com/omochi/OpenSSL-for-iPhone.git
$ cd OpenSSL-for-iPhone
$ git checkout new/selectable-archs
$ ARCHS="armv7 arm64 x86_64" ./build-libssl.sh

@omochi
Thank you very much for your help. Reinstalling Xcode solved the problem. Now I get the same output for the suggested commands, than you are, and the build process finishes successfully.
Thanks again, I'm really greatfull

@torokzsolt Its good. 😊


TypeError: Cannot read property 'headers' of undefined

Started the server, after few HTTP requests it is shown:
Caught exception: TypeError: Cannot read property 'headers' of undefined
TypeError: Cannot read property 'headers' of undefined
    at Request.callback (/var/www/express-boilerplate/node_modules/connect-assetmanager/lib/assetmanager.js:263:37)
    at Request.<anonymous> (/var/www/express-boilerplate/node_modules/connect-assetmanager/node_modules/request/main.js:154:67)
    at Request.emit (events.js:64:17)
    at ClientRequest.<anonymous> (/var/www/express-boilerplate/node_modules/connect-assetmanager/node_modules/request/main.js:151:13)
    at ClientRequest.emit (events.js:64:17)
    at Socket.<anonymous> (http.js:1214:11)
      at Socket.emit (events.js:64:17)
    at Array.<anonymous> (net.js:830:27)
    at EventEmitter._tickCallback (node.js:126:26)

Where do I see the configs you were talking about? I did not touch anything other than siteConfig.js

I'm closing this ticket but if you are still experiencing issues please open it again.


remove obsolete debian devel repo key

According to Alfredo, this was used for gitbuilders. Right now shaman/chacra
dev repos are unsigned.
Signed-off-by: Patrick Donnelly<EMAIL_ADDRESS>

@alfredodeza PTAL.

OK - jewel-ansible2.2-update_cluster

jenkins test luminous-ansible2.2-journal_collocation

jenkins test this please


[incubator-kie-kogito-runtimes#2608] Generating one definitions json for each DMN model

Fixes https://github.com/apache/incubator-kie-kogito-runtimes/issues/2608
Needed by https://github.com/apache/incubator-kie-kogito-examples/pull/1888

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.
build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:

for pull request checks
Please add comment: Jenkins retest this

for a specific pull request check
Please add comment: Jenkins (re)run [kogito-runtimes|kogito-apps|kogito-examples] tests

for quarkus branch checks
Run checks against Quarkus current used branch
Please add comment: Jenkins run quarkus-branch

for a quarkus branch specific check
Run checks against Quarkus current used branch
Please add comment: Jenkins (re)run [kogito-runtimes|kogito-apps|kogito-examples] quarkus-branch

for quarkus main checks
Run checks against Quarkus main branch
Please add comment: Jenkins run quarkus-main

for a specific quarkus main check
Run checks against Quarkus main branch
Please add comment: Jenkins (re)run [kogito-runtimes|kogito-apps|kogito-examples] quarkus-main

for quarkus lts checks
Run checks against Quarkus lts branch
Please add comment: Jenkins run quarkus-lts

for a specific quarkus lts check
Run checks against Quarkus lts branch
Please add comment: Jenkins (re)run [kogito-runtimes|kogito-apps|kogito-examples] quarkus-lts

for native checks
Run native checks
Please add comment: Jenkins run native

for a specific native check
Run native checks
Please add comment: Jenkins (re)run [kogito-runtimes|kogito-apps|kogito-examples] native

for native lts checks
Run native checks against quarkus lts branch
Please add comment: Jenkins run native-lts

for a specific native lts check
Run native checks against quarkus lts branch
Please add comment: Jenkins (re)run [kogito-runtimes|kogito-apps|kogito-examples] native-lts

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

Quarkus-3 PR check is failing ... what to do ?

The Quarkus 3 check is applying patches from the `.ci/environments/quarkus-3/patches`.
The first patch, called 0001_before_sh.patch, is generated from Openrewrite .ci/environments/quarkus-3/quarkus3.yml recipe. The patch is created to speed up the check. But it may be that some changes in the PR broke this patch.
No panic, there is an easy way to regenerate it. You just need to comment on the PR:
jenkins rewrite quarkus-3

and it should, after some minutes (~20/30min) apply a commit on the PR with the patch regenerated.
Other patches were generated manually. If any of it fails, you will need to manually update it... and push your changes.

Kogito-runtimes failure unrelated
2024-03-07T14:41:33.3732929Z ##[group]🚀 Publish results
2024-03-07T14:41:33.3734601Z ℹ - JUnit Test Report - 3303 tests run, 3244 passed, 52 skipped, 7 failed.
2024-03-07T14:41:33.3736159Z    🧪 - apache_incubator-kie-kogito-runtimes/kogito-codegen-modules/kogito-codegen-processes-integration-tests/src/test/java/org/kie/kogito/codegen/rules/PublishEventBusinessRuleIT.java | expected: "2"
2024-03-07T14:41:33.3738507Z    🧪 - apache_incubator-kie-kogito-runtimes/kogito-codegen-modules/kogito-codegen-processes-integration-tests/src/test/java/org/kie/kogito/codegen/tests/PublishEventIT.java | No value present
2024-03-07T14:41:33.3740574Z    🧪 - apache_incubator-kie-kogito-runtimes/kogito-codegen-modules/kogito-codegen-processes-integration-tests/src/test/java/org/kie/kogito/codegen/tests/PublishEventIT.java | No value present
2024-03-07T14:41:33.3742604Z    🧪 - apache_incubator-kie-kogito-runtimes/kogito-codegen-modules/kogito-codegen-processes-integration-tests/src/test/java/org/kie/kogito/codegen/tests/PublishEventIT.java | expected: 5
2024-03-07T14:41:33.3744504Z    🧪 - apache_incubator-kie-kogito-runtimes/kogito-codegen-modules/kogito-codegen-processes-integration-tests/src/test/java/org/kie/kogito/codegen/tests/PublishEventIT.java | expected: "2"
2024-03-07T14:41:33.3746419Z    🧪 - apache_incubator-kie-kogito-runtimes/kogito-codegen-modules/kogito-codegen-processes-integration-tests/src/test/java/org/kie/kogito/codegen/tests/PublishEventIT.java | No value present
2024-03-07T14:41:33.3749227Z    🧪 - apache_incubator-kie-kogito-runtimes/quarkus/extensions/kogito-quarkus-serverless-workflow-extension/kogito-quarkus-serverless-workflow-integration-test/src/test/java/org/kie/kogito/quarkus/workflows/WorkflowEventIT.java | org.opentest4j.AssertionFailedError: expected: <ProcessInstanceStateEvent> but was: <ProcessInstanceStateDataEvent>

kogito-apps failures unrelated
2024-03-07T15:23:18.9047123Z ℹ Posting with conclusion 'failure' to https://github.com/apache/incubator-kie-kogito-runtimes/pull/3424 (sha: 2a46d69af51a5f4b1d9bf04ac4dfafc31053379c)
2024-03-07T15:23:18.9049206Z ##[endgroup]
2024-03-07T15:23:18.9050141Z ##[group]🚀 Publish results
2024-03-07T15:23:18.9051140Z ℹ - JUnit Test Report - 1693 tests run, 1673 passed, 10 skipped, 10 failed.
2024-03-07T15:23:18.9055155Z    🧪 - apache_incubator-kie-kogito-apps/apps-integration-tests/integration-tests-data-index-service/integration-tests-data-index-service-quarkus/src/test/java/org/kie/kogito/index/infinispan/ProcessDataIndexInfinispanHttpIT.java | Assertion condition defined as a org.kie.kogito.index.AbstractProcessDataIndexIT 1 expectation failed.
2024-03-07T15:23:18.9062144Z    🧪 - apache_incubator-kie-kogito-apps/apps-integration-tests/integration-tests-data-index-service/integration-tests-data-index-service-quarkus/src/test/java/org/kie/kogito/index/infinispan/ProcessDataIndexInfinispanKafkaIT.java | Assertion condition defined as a org.kie.kogito.index.AbstractProcessDataIndexIT 1 expectation failed.
2024-03-07T15:23:18.9068606Z    🧪 - apache_incubator-kie-kogito-apps/apps-integration-tests/integration-tests-data-index-service/integration-tests-data-index-service-quarkus/src/test/java/org/kie/kogito/index/inmemory/ProcessDataIndexInMemoryIT.java | Assertion condition defined as a org.kie.kogito.index.AbstractProcessDataIndexIT 1 expectation failed.
2024-03-07T15:23:18.9075067Z    🧪 - apache_incubator-kie-kogito-apps/apps-integration-tests/integration-tests-data-index-service/integration-tests-data-index-service-quarkus/src/test/java/org/kie/kogito/index/mongodb/ProcessDataIndexMongoDBHttpIT.java | Assertion condition defined as a org.kie.kogito.index.AbstractProcessDataIndexIT 1 expectation failed.
2024-03-07T15:23:18.9081586Z    🧪 - apache_incubator-kie-kogito-apps/apps-integration-tests/integration-tests-data-index-service/integration-tests-data-index-service-quarkus/src/test/java/org/kie/kogito/index/mongodb/ProcessDataIndexMongoDBKafkaIT.java | Assertion condition defined as a org.kie.kogito.index.AbstractProcessDataIndexIT 1 expectation failed.
2024-03-07T15:23:18.9088081Z    🧪 - apache_incubator-kie-kogito-apps/apps-integration-tests/integration-tests-data-index-service/integration-tests-data-index-service-quarkus/src/test/java/org/kie/kogito/index/postgresql/ProcessDataIndexPostgreSqlHttpIT.java | Assertion condition defined as a org.kie.kogito.index.AbstractProcessDataIndexIT 1 expectation failed.
2024-03-07T15:23:18.9094974Z    🧪 - apache_incubator-kie-kogito-apps/apps-integration-tests/integration-tests-data-index-service/integration-tests-data-index-service-quarkus/src/test/java/org/kie/kogito/index/postgresql/ProcessDataIndexPostgreSqlKafkaIT.java | Assertion condition defined as a org.kie.kogito.index.AbstractProcessDataIndexIT 1 expectation failed.
2024-03-07T15:23:18.9101704Z    🧪 - apache_incubator-kie-kogito-apps/apps-integration-tests/integration-tests-data-index-service/integration-tests-data-index-service-springboot/src/test/java/org/kie/kogito/index/ProcessDataIndexInfinispanIT.java | Assertion condition defined as a org.kie.kogito.index.AbstractProcessDataIndexIT 1 expectation failed.
2024-03-07T15:23:18.9107953Z    🧪 - apache_incubator-kie-kogito-apps/apps-integration-tests/integration-tests-data-index-service/integration-tests-data-index-service-springboot/src/test/java/org/kie/kogito/index/ProcessDataIndexMongoDBIT.java | Assertion condition defined as a org.kie.kogito.index.AbstractProcessDataIndexIT 1 expectation failed.
2024-03-07T15:23:18.9114676Z    🧪 - apache_incubator-kie-kogito-apps/apps-integration-tests/integration-tests-data-index-service/integration-tests-data-index-service-springboot/src/test/java/org/kie/kogito/index/ProcessDataIndexPostgreSqlIT.java | Assertion condition defined as a org.kie.kogito.index.AbstractProcessDataIndexIT 1 expectation failed.

PR job #5 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer
build-chain build full_downstream  -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u https://github.com/apache/incubator-kie-kogito-runtimes/pull/3424 --skipParallelCheckout
NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3424/5/display/redirect
Test results:

PASSED: 3205
FAILED: 7

Those are the test failures:

org.kie.kogito.codegen.rules.PublishEventBusinessRuleIT.testBusinessRuleProcessStartToEnd
expected: "2" but was: "0"

org.kie.kogito.codegen.tests.PublishEventIT.testBasicUserTaskProcessAbort
No value present

org.kie.kogito.codegen.tests.PublishEventIT.testBasicUserTaskProcessWithSecurityRoles
No value present

org.kie.kogito.codegen.tests.PublishEventIT.testServiceTaskProcessWithError
expected: 5 but was: 0

org.kie.kogito.codegen.tests.PublishEventIT.testExclusiveGatewayStartToEnd
expected: "2" but was: "0"

org.kie.kogito.codegen.tests.PublishEventIT.testBasicUserTaskProcess
No value present

org.kie.kogito.quarkus.workflows.WorkflowEventIT.testWorkflowEvents
org.opentest4j.AssertionFailedError: expected:  but was:

continuous-integration/jenkins/pr-head failure unrelated


YNAB Available Figures Overlapping Activity Column

Name of Defective Feature

Pacing - Full Amount Display

System Settings (Required)

ToolKit Version: 2.8.3
Operating System (Mac/Windows/Etc): Mac
Browser (Chrome/Firefox/Safari): Chrome
Browser Version: 67.0.3396.99 (Official Build) (64-bit)
Other Extensions: too many to list

Export of Toolkit Settings (Bottom Left of Settings Page)

Settings Export
[{"key":"AccountsDisplayDensity","value":"1"},{"key":"AccountsEmphasizedOutflows","value":true},{"key":"AccountsStripedRows","value":false},{"key":"AdjustableColumnWidths","value":false},{"key":"AutoDistributeSplits","value":false},{"key":"BetterScrollbars","value":"1"},{"key":"BudgetCategoryFeatures","value":true},{"key":"BudgetProgressBars","value":"0"},{"key":"BudgetQuickSwitch","value":false},{"key":"CalendarFirstDay","value":"1"},{"key":"CategoryActivityCopy","value":false},{"key":"CategoryActivityPopupWidth","value":"0"},{"key":"ChangeEnterBehavior","value":false},{"key":"CheckCreditBalances","value":false},{"key":"CheckNumbers","value":false},{"key":"ClearSelection","value":false},{"key":"CollapseSideMenu","value":false},{"key":"ColourBlindMode","value":false},{"key":"CompactIncomeVsExpense","value":false},{"key":"CreditCardEmoji","value":false},{"key":"CurrentMonthIndicator","value":true},{"key":"CustomFlagNames","value":true},{"key":"DaysOfBuffering","value":true},{"key":"DaysOfBufferingHistoryLookup","value":"0"},{"key":"DisableToolkit","value":false},{"key":"DisplayTargetGoalAmount","value":"0"},{"key":"DisplayTotalMonthlyGoals","value":true},{"key":"DisplayUpcomingAmount","value":false},{"key":"EasyTransactionApproval","value":true},{"key":"EditAccountButton","value":"0"},{"key":"EnlargeCategoriesDropdown","value":true},{"key":"EnterToMove","value":false},{"key":"GoalIndicator","value":false},{"key":"GoalWarningColor","value":true},{"key":"GoogleFontsSelector","value":"0"},{"key":"HideAccountBalancesType","value":"0"},{"key":"HideAgeOfMoney","value":false},{"key":"HideHelp","value":false},{"key":"HideReferralBanner","value":true},{"key":"HighlightNegatives","value":false},{"key":"ImportNotification","value":"0"},{"key":"IncomeFromLastMonth","value":"0"},{"key":"IncomeVsExpenseHoverHighlight","value":true},{"key":"LargerClickableIcons","value":true},{"key":"MonthlyNotesPopupWidth","value":"0"},{"key":"NavDisplayDensity","value":"0"},{"key":"Pacing","value":"1"},{"key":"PrintingImprovements","value":true},{"key":"PrivacyMode","value":"0"},{"key":"QuickBudgetWarning","value":false},{"key":"ReconciledTextColor","value":"0"},{"key":"RemovePositiveHighlight","value":false},{"key":"RemoveZeroCategories","value":false},{"key":"ResizeInspector","value":false},{"key":"RightClickToEdit","value":true},{"key":"RowHeight","value":"0"},{"key":"RowsHeight","value":"0"},{"key":"RunningBalance","value":"1"},{"key":"SeamlessBudgetHeader","value":false},{"key":"ShowCategoryBalance","value":true},{"key":"ShowIntercom","value":true},{"key":"SpareChange","value":true},{"key":"SplitKeyboardShortcut","value":true},{"key":"SplitTransactionAutoAdjust","value":false},{"key":"SquareNegativeMode","value":false},{"key":"StealingFromFuture","value":true},{"key":"SwapClearedFlagged","value":false},{"key":"TargetBalanceWarning","value":true},{"key":"ToBeBudgetedWarning","value":false},{"key":"ToggleMasterCategories","value":true},{"key":"ToggleSplits","value":false},{"key":"ToggleTransactionFilters","value":"0"},{"key":"TransactionGridFeatures","value":true},{"key":"ViewZeroAsEmpty","value":false},{"key":"l10n","value":"0"},{"key":"reports","value":true}]

Steps to Reproduce the Behavior

Enable the pacing full amount on toolkit
 Reload browser and allocate a 4 figure amount to a category

Expected Behavior

The available amount should align nicely and should not overlap.
Actual Behavior

The available amount overflows into the activity column and sits in front of any values entered in the column. This is mainly due to the addition of the ticks and loading icons into native Ynab.

I suspect the width of the browser window comes into play with this as well. Have you tried the Resize Inspector feature to give more are to the different columns? That could quite a bit in you can use one of the lower settings such as 15 or 20 percent. Of course if you have a small (narrow) browser window that probably won't help much. Just a thought.

We can look into adding a bit more styling to this feature but as @dbaldon this likely has a lot to do with how wide your browser is and since YNAB doesn't really have much going on in the ways of browser size optimization this could get complex, fast.


Slowfix

Avoid calling "slow" regex constructor
On my ubuntu VM it took ~17 seconds before tcpconnect.bt was compiled,
most of the time spent in the newly added remove)qualifiers:
Time spent in remove_qualifiers: 17502 ms
Time spent in remove_qualifiers: 16662 ms

Which is mostly caused by the regex constructor being called 27k times.
With this patch the average of 10 runs is down to: 575ms
This fixes a regression introduced by #1177

The second commit optimizes the regex a bit, shaving off ~70ms

@mmisono  can you take a look at this one? I tested it by adding:
std::string x = std::regex_replace(typestr, re, "");
std::cout << x << std::endl;
return x;

The output for the original and mine are equal for tcpconnect.bt

Initially, I implemented this feature by traversing AST: https://github.com/mmisono/bpftrace/commit/e6a079ba55110255adc273c8215fed957d866ddf
But I changed it to use regex because I thought it was more straightforward and I didn't know well about clang parser (I think the above implementation is OK, but I'm not completely sure).
In my environment, the times spent in ClangParser::parse() for tcp_connect.bt are (averages in 10 runs):

921ms (regex version (this PR version))
672ms (https://github.com/mmisono/bpftrace/commit/e6a079ba55110255adc273c8215fed957d866ddf version)

The speed of the latter version is almost the same as before. Considering the performance, I think it's worth to use the latter implementation.
Could you take a look the above patch? @fbs
If it is desirable, I'll create a PR.

(By the way, when using BTF, the parse times are around 30ms and 21ms respectively.)

Could you take a look the above patch? @fbs
If it is desirable, I'll create a PR.

That looks like a better approach.
I'll update this one to just factor out the regex and fix the regression for now, we can use yours to speed it up further.


Question: Is there any way I can hide links?

Just wondering if there is any way to hide these links

if we change the state of zenModeEnabled, it hides the side(burger icon) menu. I don't want to hide everything, only the links.

How can I get this component ?

Hi @shahriarhossain!

Just wondering if there is any way to hide these links

You can customize the menu and not include the <MainMenu.DefaultItems.Socials/> button. More info in the readme: https://github.com/excalidraw/excalidraw/blob/master/src/packages/excalidraw/README.md#mainmenu (we'll explain it better in the upcoming docs).

if we change the state of zenModeEnabled, it hides the side(burger icon) menu

That is true. We may want keep the hamburger shown even in zen mode.

How can I get this component ?

That's from the previous editor design and no longer accessible. You may be able to build this component from scratch once we add support for rendering custom UI to the top-left corner, soon.


Fixed the bug that the software will crash if there is no note

Please ignore the "added full combo"

Thanks! Merged.


Night CI 2022-12-07: Failed

action url: https://github.com/spidernet-io/spiderdoctor/actions/runs/3642522946

fix https://github.com/spidernet-io/spiderdoctor/pull/213


Questions for clarification from student on "ETERNAL LIFE"

How do I forget who I am when I don't know who I am? Forget what I think I know about myself?

You believe that there is no life after death, does that mean you believe that there is NO "eternal" life?

How do I forget who I am when I don't know who I am? Forget what I think I know about myself?

Forget what you know of yourself, e.g. your name.

You believe that there is no life after death, does that mean you believe that there is NO "eternal" life?

I FORGET (even momentarily) what I remember to be ME;
I REALIZE that I could be ANYONE that HAVE EXISTED, EXISTS, or SHALL EXIST.
OUTPUT:

BE KIND to as MANY PEOPLE as YOU CAN.
CHERISH your LIFE NOW.


Barrier style not drawn along area edges

Suddenly the barriers depiction just dissapears from the areas tagged so, as stand alone lines are depicted, but in areas no..

Was it solved? still do not shows the barriers in the depiction of areas tagged so

@jjiglesiasg This is in the current branch (http://preview.ideditor.com/master) and will be in the next version of iD.

Perfect, as it was before. Thanks


Refactor and improve URI implementation

This PR applies a ton of mostly small improvements to URI and URI::Parser.

The type of URI#path is changed to String. It is no longer nilable. The semantic is: every URI has a path, but it may be empty. This avoids ambiguity between empty path and nil path.
The macro URI::Parser.step is removed. It was previously used to spec internals of URI::Parser but it no longer works because the struct can't be inherited. It doesn't make much sense to spec the internal API anyway, having unit tests for URI.parse is totally fine. Consequently, I have removed the specs for URI::Parser and integrated them into the specs for URI.parse.
Most notable is probably the removal of the property URI#opaque. It is simply not necessary to have an extra ivar for this. It is replaced by URI#path which contains both a path in the hierarchical part as well as a non-hierarchical, opaque path. URI#opaque? answers if the URI is considered opaque.
The spec suite has been reorganized and I added a bunch of new examples, borrows from gloang and akka.
During that process I discovered and fixed a few issues in the parser and formatter:

#to_s no longer hides the port if it is the default port. A default port can now be stripped using #normalize.
#parse downcases the scheme to make it case-insensitive. This is recommended by RFC 3986.
#parse decodes escape sequences in host, and #to_s applies them.
#parse correctly parses an empty port. Previously, scheme://host:/ would set port to 0, now it's nil.
#parse parses a string starting with three slashes as empty host. Previously, host was nil.
#to_s inserts a slash if path does not start with one and follows an authority. Paths starting with double slash // are prefixed by /. if it does not follow an authority. Otherwise the first path component would be interpreted as authority.

The test failures make me wonder if eq should handle default ports.

Nah, the specs are only failing because of the previous incorrect behavior of ommitting the port if it was specified but equal to the default.
Comparing two URIs should be strict. If a port is specified, even if it's the default, there are chances this is on purpose. http://example.com and http://example.com:80 are not identical. You can easily use #normalize to remove default ports.

$ irb
irb(main):001:0> require "uri"
=> true
irb(main):002:0> u1 = URI.parse("http://foo.com:80")
=> #<URI::HTTP http://foo.com>
irb(main):003:0> u2 = URI.parse("http://foo.com")
=> #<URI::HTTP http://foo.com>
irb(main):004:0> u1 == u2
=> true

I'm not saying we should copy Ruby... but specifying a default port when it's the default one, and keeping it around... I don't know... there's no difference, really.

@asterite Yeah, Ruby does that. But it also uses a scheme-specific type URI::HTTP. Maybe that can serve as an excuse...
Besides, just a few counter examples:
u, err := url.Parse("http://foo.org:80")
fmt.Println(u.Port()) // => 80

System.out.println(new URI("http://foo.com:80").getPort()); // => 80

there's no difference, really.

For well-known schemes, probably not. But when you're using a custom scheme, it might not be given that the next consumer of a URI has the same default port configured.
URI should be a simple data container and serialize to and from string representation without any further processing. If you want to get rid of unnecessary default ports, use #normalize.
URI.parse(string).to_s == string should hold for any well-formed URI.

Sounds good

🏓 A second review would be great!

@bcardiff 🏓

Rebased and ready to ship.

@straight-shoota should all the parse_ methods in the src/uri/uri_parser.cr file be private?

I just realized that might have been out of scope for this refactor but thanks for moving the parse methods to private.

@wontruefree Yeah I thought so at first. But then, what the heck... it's a simple thing and fits to the set of changes in this PR.


Include token metadata for zero-balance ValueViews of delegation tokens

Currently, when a user has no delegation tokens for a given validator, we don't show their balance at all:

We should show a balance of 0 in the middle of that UI, just like we show a nonzero balance for validators the user has staked:

The problem is, we're generating ValueViews on the fly for validators we're not staked in. This means we don't have access to an asset ID for the delegation tokens we're supposed to show a zero balance for, and thus we can't fetch a fully fleshed out metadata object for the delegation tokens.*
Possible solutions

Fetch the metadata by a different method than asset ID, such as by display name. (This would likely require a new RPC method. Or, once #612 is done, the extension itself could take care of that more easily by looking for the right metadata in IndexedDB.)

* Per @aubrika, when I asked if it's possible for a validator to exist when no tokens have been staked:

https://github.com/penumbra-zone/penumbra/issues/2921 depends on if you are listing "declared" validators, "defined" validators, or both, I suppose. see linked issue for deets

Per @hdevalence:

how does a validator end up on the chain? someone makes a tx with a ValidatorDefinition action that declares it. at that moment, the validator has been "created" on chain, but there's no delegation tokens yet. i believe that the on chain asset registry actually registers the delegation token at this point
however to become active, or to appear in a users balances, there must be delegation

Two points:

The asset ID is always computable from the base denom string, since it's a hash of that denom string. However computing that hash may not be possible/easy in typescript (the hashing is provided by our Rust libraries).

There is a field in the AssetId proto that exists for this purpose: alt_base_denom https://buf.build/penumbra-zone/penumbra/docs/main:penumbra.core.asset.v1#penumbra.core.asset.v1.AssetId

@hdevalence Ah, thank you! I was able to use alt_base_denom to fetch the metadata 👏🏻


Add the demo link to Readme

** Question?(Go ahead, ignore issue template) **
no
Bug or Feature?:
no, just enhance
Expected Behavior:
Access the link correctly.
Current Behavior:
There is no demo link in Readme.
How to reproduce(The more detailed the better):
just check the readme~
Your Environment:

Kubernetes version:
Hardware or VM configuration:
OS (e.g. from /etc/os-release):
Kernel (e.g. uname -a):

/assign


⚡ Feature: BSL License Support

update getLicenseType on the Etherscan verification module to be on par with their API updates found here: https://docs.etherscan.io/tutorials/verifying-contracts-programmatically#4.-configuring-source-code-parameters where the license id are documented here: https://etherscan.io/contract-license-types

Hey thanks for the PR, saw your comment on the other :)
did not notice there was 2 PR :)


Define a simple Group Entity

Hey, I just made a Pull Request!
Creating a skeleton structure for the Group Entity as discussed in #1401
:heavy_check_mark: Checklist

[ X] All tests are passing yarn test
[ ] Screenshots attached (for UI changes)
[ ] Relevant documentation updated
[ X] Prettier run on changed files
[ X] Tests added for new functionality
[ ] Regression tests added for bug fixes

thanks again and congrats on your first contribution :)


(Fix) Prevent ENS check when not supported

This PR closes #1557, by:

renaming AddressBookInput to BaseAddressBookInput
creating two wrappers AddressBookInput and ContractsAddressBookInput. Each one with its respective responsibilities.
disabling ENS checks and error messages if it's not supported by the network
adding a new disabledFeatures entry for ENS
disabling ENS for EWC, Volta, and xDai.

Notes:

I wasn't able to accomplish what I wanted. Completely refactor AddressBookInput and the "form" state handling.
What I did, was to re-write the whole logic around AddressBookInput to prevent unnecessary re-renders and undesired updates.
There's still plenty to work/refactor. But I found it a bit more easy to reason about.

If changes around AddressBookInput doesn't justify the refactor, I can re-do this whole fix, and just add the ENS-related conditions in the previous code

Travis automatic deployment:
https://pr1570--safereact.review.gnosisdev.com/volta/app

Travis automatic deployment:
https://pr1570--safereact.review.gnosisdev.com/rinkeby/app

Travis automatic deployment:
https://pr1570--safereact.review.gnosisdev.com/volta/app

Travis automatic deployment:
https://pr1570--safereact.review.gnosisdev.com/rinkeby/app

Travis automatic deployment:
https://pr1570--safereact.review.gnosisdev.com/volta/app

Travis automatic deployment:
https://pr1570--safereact.review.gnosisdev.com/rinkeby/app

Travis automatic deployment:
https://pr1570--safereact.review.gnosisdev.com/volta/app

Travis automatic deployment:
https://pr1570--safereact.review.gnosisdev.com/rinkeby/app

Travis automatic deployment:
https://pr1570--safereact.review.gnosisdev.com/rinkeby/app

Travis automatic deployment:
https://pr1570--safereact.review.gnosisdev.com/volta/app

Issue:
In the Contract interaction form, whenever you write a random string of characters an error msj will show up (which is expected), but when I delete the string and I input a real contract address the Error message won't go away, even when the form loads the ABI from that contract address.
https://www.loom.com/share/e63189e580ad4978bec5334c74f73d6b

Issue:
In the Contract interaction form, whenever you write a random string of characters an error msj will show up (which is expected), but when I delete the string and I input a real contract address the Error message won't go away, even when the form loads the ABI from that contract address.
loom.com/share/e63189e580ad4978bec5334c74f73d6b
Safe: pr1570--safereact.review.gnosisdev.com/rinkeby/app/#/safes/0x9913B9180C20C6b0F21B6480c84422F6ebc4B808/settings

@francovenica,
Fixed, thanks for the catch!

Travis automatic deployment:
https://pr1570--safereact.review.gnosisdev.com/volta/app

Travis automatic deployment:
https://pr1570--safereact.review.gnosisdev.com/rinkeby/app

The issue was fixed
I tried with some ENS names I have
francotest.eth
safe.test
test.test
I checked that those are not read in the volta network and the error just reflects that those names are a string of characters, and not a ENS name.
In the rinkeby network the name still works as always
Tested in Contract Interactions, Address book entries, Settings user adding/replacement, Safe creation (for owners addresses), Safe Loading (for safes addresses)
Looks good to me

Travis automatic deployment:
https://pr1570--safereact.review.gnosisdev.com/volta/app

Travis automatic deployment:
https://pr1570--safereact.review.gnosisdev.com/rinkeby/app


NRFX-5977 Add mbox_error_cases

Add negative test cases for the MBOX driver.
Confirm that driver implementation is aligned with
the MBOX API documentation available at
https://docs.zephyrproject.org/latest/hardware/peripherals/mbox.html
Enable test execution on nRF54H20 Application and PPR cores.

According to the official MBOX API documentation
mbox_sen() shall return
-EMSGSIZE – If the supplied data size is unsupported by the driver.
Fix error code returned by the mbox_send().

Add overlay that enables execution of mbox_error_cases on
nrf54l15pdk/nrf54l15/cpuapp.

nrf54h20/cpuapp - works in upstream and NCS
nrf54h20/cpuppr - works in NCS (I tested only there)
nrf54l15/cpuapp - fails in upstream Zephyr (MBOX driver for 54l15 is not ported to NCS)

FYI: @nordic-piks

I get BUS FAULT on nrf54L15 Application core
START - test_05c_mbox_set_enabled_on_already_enabled_rx_channel
E: ***** BUS FAULT *****
E:   Precise data bus error
E:   BFAR Address: 0x5004c304
E: r0/a1:  0x00000000  r1/a2:  0x0000000f  r2/a3:  0x00008000
E: r3/a4:  0x5004c000 r12/ip:  0x000080f7 r14/lr:  0x0000095b
E:  xpsr:  0x01000200
E: Faulting instruction address (r15/pc): 0x000080ac
E: >>> ZEPHYR FATAL ERROR 0: CPU exception on CPU 0
E: Current thread: 0x20000160 (test_05c_mbox_set_enabled_on_al)
E: Halting system

Dear reviewers, please find some time to do the review.

rebased on main@ad3e941ad3ed9e3e2f9032b0151558a948e99fb9


Artifacts on replacement of data

Basically If I do a search, then do another search the new results (only visible ones) have some of the old data appended on and the first vertical-item is empty. If I scroll down so a new set of records loads and then scroll back those artifacts are gone.
Example screenshot:

("MAIN ST") was from the previous search. This only happens in the address field as far as I can tell.
The issue occurs when I replace the data directly with new data. If I clear the search after the first search, and do another search I don't see artifacts.

Give it a try here: https://stocktonca.mapgeo.alpha1.appgeo.com

Search for '8 main', hit enter.
Don't clear!
Type in 'podesto', hit enter.
See artifacts.

Ok, I think I found a workaround:

Use useContentProxy=false on the vertical-collection
Use clear() on the array before doing the same search, even if you replace the array after.
If you don't set true in 1, there is an error about undefined geography.. see error below

Uncaught TypeError: Cannot read property 'geography' of null_findFirstRenderedComponent @ vendor.js:249385
_updateChildStates @ vendor.js:249491
(anonymous function) @ vendor.js:249743
invoke @ vendor.js:14821
....

@knownasilya I can help you did in further in about two hours.

Sounds good 👍

@knownasilya I suspect this will get fixed or at least the performance of doing a clear or swap like this will improve in the next minor

Excellent!

@knownasilya let me know if 0.5.4 helped the situation out :)

Seems to have fixed it (I removed the clear and no more artifacts), let me do some more testing.

The rebuild time should also be substantially faster.

After more testing it looks like the issue persists, if you don't include the clear.

@knownasilya looking for a status update on this with 0.6.0

Will do tomorrow.

Should be fixed by updating to @html-next/vertical-collection (now re-exported by this lib)


ERROR in ./src/main.ts Module not found: Error: Can't resolve './$$_gendir/app/app.module.ngfactory'

Hello,
From Last week I found the below error, I have tried many things like update @angular/cli version but I am not able to resolved the production error.
my version :
Angular version - 4
"@angular/cli": "1.0.0",
"@angular/compiler-cli": "4.0.2"
Throwing below Error  while enter ng build --prod
ERROR in ./src/main.ts
Module not found: Error: Can't resolve './$$_gendir/app/app.module.ngfactory' in '/home/user2/Project/Streetwork/streetworkapp/material/loan_calculator/src'
@ ./src/main.ts 5:0-74
@ multi ./src/main.ts
Please help me how to fixed that issue ?

Doesn't follow template


Double builds fail after integration with salva2d

https://github.com/appsinacup/godot-rapier-2d/actions/runs/8668226381/job/23772870624
After integration with salva2d, double builds fail. Needs to wait for salva2d repo to support double builds.
Salva issue: https://github.com/dimforge/salva/issues/47

Removing it from issues as it is in readme as limitation. Better to not track it in issues also.


move currency converter and initial prices into separate modules

This reduces calc.py size. Next diff will remove some global variables.

Thanks!


Auto import suggestions create invalid imports when re-exporting with aliases

From @gsteacy on April 3, 2018 11:49

VSCode Version: 1.21.1
OS Version: Windows 8.1 x64

Steps to Reproduce:
Given the following files:
module1.ts
export function myFunction() { };
export default myFunction;

index.ts
export { myFunction as func1 } from "./module1";

In another file, type "myFunction" and you'll see the following:

Select either option and the following invalid import will be added:

import { myFunction } from ".";

The quick fix list will have the correct suggestions and will create the correct import:

This behaviour also occurs if re-exporting the default export with an alias.

In the new file, type "func1" and no suggestions will be given. The quick fixes list will have the correct suggestions and will create the correct import:

Does this issue occur when all extensions are disabled?: Yes
Copied from original issue: Microsoft/vscode#47139

Confirmed in 2.9.0-dev-21080404


[Excel] (ui) contextual tabs now supported on Mac

This doesn't need a review. And the SMEs have approved it.

Docs Build status updates of commit 4bc7ccb:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/design/contextual-tabs.md
:white_check_mark:Succeeded
View

docs/reference/requirement-sets/ribbon-api-requirement-sets.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


update nerdtree's statusline

Hello!
I wrote a patch.
This patch can choice NERDTree's statusline like below.
Please check this Pull Request.
let g:airline#extensions#nerdtree_statusline = 1

let g:airline#extensions#nerdtree_statusline = 0

default 1

please add the configuration variable to the documentation.

I added documentation, Please check.

Thanks!

@chrisbra
Thank you!


Fix transaction row highlight when pressed

The transaction row does not highlight the proper areas when pressed, this pr fixes the bug.
Before changes:

After after:

The dimensions on the recent transactions table is off.
Also, there is a gray line immediately after the side Nav. (second screenshot... red section)


Differrent server URL

Hi there,
thanks for useful framework!
Intro
I've a nginx proxy with internal httpotp auth for jenkins auth.
For api4jenkins scripts I've used an internal server url, like http://jenkins:8080/ to skip httpauth for local scripts.
For user auth, I'm using an external server url, like https://jenkins-in-house.com/
The issue.
For some cases, api4jenkins returns server url described in Manage Jenkins - Configure System - Jenkins Location - Jenkins URL instead of initialized object url
j = Jenkins('http://the_jenkins:8080/', auth=('automation', 'token'))

print(j)
print(j.url)

for job in j.iter_jobs():
    print(f"job = {job}")
    print(f"name = {name}")

......

<Jenkins: http://the_jenkins:8080/>
http://the_jenkins:8080/

job                 = <WorkflowJob: https://jenkins-in-house.com/job/Just_some_job/>
name             = Just_some_job

Is is possible to use server url that initialized for auth, instead of jenkins url?
Thanks!

As the description of 'Jenkins URL'

Optionally specify the HTTP address of the Jenkins installation, such as http://yourhost.yourdomain/jenkins/. This value is used to let Jenkins know how to refer to itself, ie. to display images or to create links in emails.
This is necessary because Jenkins cannot reliably detect such a URL from within itself.

The api4jenkins relies on the response from Jenkins, then item url will start with value of Jenkins URL in system configuration. but you can try following ways:

create a service account for external url for automation work

change the item url manually before doing something, eg
internal_url = 'http://jenkins:8080/'
external_url = 'https://jenkins-in-house.com/'
j = Jenkins(internal_url)
print(j)
for job in j:
    job.url = job.url.replace(external_url, internal_url)
    print(job)

# output
# <Jenkins: http://jenkins:8080/>
# <WorkflowJob: http://jenkins:8080/job/Just_some_job/>

check if nginx has configuration to fix issue

Thanks.
I've added this external hostname to /etc/hosts and all works fine!
<IP_ADDRESS> jenkins-in-house.com


Fake authentication for local development

I'm interested in this package, but unsure how to effectively fake a login in a local development environment. I don't see anything in the README or API docs.

Hello @jdpedrie, thank you for reporting the issue. I would kindly ask you to test the release v0.2.2 that I just published, were a new AuthenticationFunc configuration parameter has been introduced to help with mocking.
You can find some examples in the main readme

Thanks @fabiofenoglio! Worked fine, except that I found that TokenExtractFunc was not optional -- it has to return something besides an empty string, or the buildAuthenticatorMiddleware middleware returns before AuthenticationFunc is invoked.
Really appreciate the quick reply!
		c.TokenExtractFunc = func(c *gin.Context) (string, error) {
			return "dummy token", nil
		}

Yes, the TokenExtractFunc is optional in case you still plan on passing a token with the default headers and just want to mock the validation.
If you need to mock the whole authentication without passing any headers, using a TokenExtractFunc returning a fixed value as you did is the way to go.
Thank you for your feedback, I'm going to close this issue. Please don't hesitate to reach out as needed.


Changes to Roland Checksum and 14 bit MSB

Added a new algorithm for Roland checksums
Fixed MSB 14 bit numbers sending 0xFF instead of 0x7F

I just add your mods to the master and 5.6.30 branch.
commit is : https://github.com/RomanKubiak/ctrlr/commit/09f8bc89524d3f8d651a00ed56b6c66b4161c564
Thanks John!

Great! Thanks Damien.
On Fri, May 10, 2024 at 2:53 Damien S. @.***> wrote:

I just add your mods to the master and 5.6.30 branch.
commit is : @.***
https://github.com/RomanKubiak/ctrlr/commit/09f8bc89524d3f8d651a00ed56b6c66b4161c564
Thanks John!
—
Reply to this email directly, view it on GitHub
https://github.com/damiensellier/CtrlrX/pull/15#issuecomment-2103147830,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASKFXQ3BY74TDTJY5NTJO4LZBOZZLAVCNFSM6AAAAABGXDTKCSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBTGE2DOOBTGA
.
You are receiving this because you authored the thread.Message ID:
@.***>


Feature/245 contact addresses

Warning
Support has been added for addresses at the Contact level. Multiple Addresses (seasonal and not seasonal) are now supported at both the Account and Contact levels (as enabled in HEDA Settings). An Account can have multiple addresses, as well as a Contact, without connection between an Account's addresses and its children Contacts' addresses.
This means than new Address records can be created directly from the Addresses related list in Contact. These records will not be copied to the parent Account. It also means that when mailing address information is entered in the Contact, this address information will not be copied to the Billing fields in the parent Account. Likewise, changes in the parent Account's billing fields will not be copied to the child Contacts.
Info
Issues
Fixes #245.

Can you schedule a runthrough time with me before merging?

Sure thing. We are actually going to wait until middle of next week to
merge, to avoid mislabeling Summer'16 issues, if any, as being caused by
these changes.
Carlos Eiroa
Lead Developer | Salesforce.org
Mobile:<PHONE_NUMBER>
<EMAIL_ADDRESS>http://www.salesforce.org/
On Thu, May 26, 2016 at 4:30 PM, Kevin Bromer<EMAIL_ADDRESS>wrote:

Can you schedule a runthrough time with me before merging?
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/SalesforceFoundation/HEDAP/pull/255#issuecomment-222000518

@ceiroa OK, I finished reviewing this humongous pull request!  I really only could look for localized logic flaws, rather than wrap my head around the design.  So I hope it was helpful, but I'm guessing I should have asked for a design overview first; that may have led to better feedback. but that's all I can do, as I've spent many hours on it today.

Very helpful, @davidhabib. Thanks a lot for spending hours of your valuable time on this! Much appreciated.

Hi @kbromer ~ Unless @davidhabib objects, I think this pull request is ready for your final review and merge. Please let me know if you have any questions. Thank you.

no objections!


Cannot read properties of undefined (reading 'replace') at formatPluginName

Have you read the Contributing Guidelines on issues?

[X] I have read the Contributing Guidelines on issues.

Prerequisites

[X] I'm using the latest version of Docusaurus.
[ ] I have tried the npm run clear or yarn clear command.
[ ] I have tried rm -rf node_modules yarn.lock package-lock.json and re-installing packages.
[ ] I have tried creating a repro with https://new.docusaurus.io.
[ ] I have read the console error message carefully (if applicable).

Description
I report this error when I start the project

Reproducible demo
No response
Steps to reproduce
I updated the version to 3.4.0 and then started the project, and the terminal reported this error
Expected behavior
The project can be started normally
Actual behavior
1
Your environment

Public source code:
Public site URL:
Docusaurus version used:
Environment name and version (e.g. Chrome 89, Node.js 16.4):
Operating system and version (e.g. Ubuntu 20.04.2 LTS):

Self-service

[ ] I'd be willing to fix this bug myself.

Can you create a minimal repro ? There shouldn't be any issue upgrading docusaurus version, this might come from your setup

Please try again, this might be a temporary issue we had recently.
Until a runnable repro is provided (using https://docusaurus.new/stackblitz or GitHub), I'm going to close

I found an additional plugin without `name` when printing with `console.log`

I utilized a custom plugin and did not define the name field, which led to this issue.
I hope this information is helpful to you.

I've written a custom plugin that returns null under certain circumstances, and that's causing this issue. I hope this is helpful for you.

I've written a custom plugin that returns null under certain circumstances, and that's causing this issue. I hope this is helpful for you.

Curious to know more about this use-case
Maybe we could allow that

Forgot to mention but this original issue is related to https://github.com/facebook/docusaurus/pull/10239
We need plugins to have a name
But we could also allow a plugin to return null eventually, as a convenient way to self-disable depending on params 🤷♂ can you explain that need @htmlin ?

Note that we even have a use-case for this internally:
https://github.com/facebook/docusaurus/blob/main/packages/docusaurus-plugin-sitemap/src/index.ts#L21
So let's add the ability to return null!

Forgot to mention but this original issue is related to https://github.com/facebook/docusaurus/pull/10239
We need plugins to have a name
But we could also allow a plugin to return null eventually, as a convenient way to self-disable depending on options 🤷♂ can you explain that need @htmlin ?
Even if we allow this, this would only be a "shortcut" because you could also decide from the config file to filter out the plugin from the plugins array depending on context.

If I return a null value in the custom plugin, Docusaurus throws this error. So now, I’ve moved the condition check to the plugins configuration to bypass this issue.

This will be supported soon (v3.5)
PR: https://github.com/facebook/docusaurus/pull/10286


add(ui): add aria labels needed to for appium tests

What this PR does 📖

Add aria labels required for UI locators on appium tests for the following items: switch checkboxes, tooltips, hamburger button, debug logger, copy did button, mobile/tablet/desktop/CL view buttons, grant permissions button from settings notifications
Fixed a wrong aria label from settings developer (test notification had incorrect text)

Which issue(s) this PR fixes 🔨

Resolve #

Special notes for reviewers 🗒

Solves issue #68 added on Appium Repo

Additional comments 🎤

Sweet! All green 🍏


PHOENIX-5546: TASK_TS being set as HConstants.LATEST_TIMESTAMP in SYSTEM.TASK table

Please review @twdsilva @lhofhansl @kadirozde

Thanks for the reviews @twdsilva @kadirozde

JIRA resolved, closing


Make the documentation follow the common template

Instead of applying the template, just inserting this instead:
---
layout: default
---

This will make the craftyjs.com website easier to maintain, since one edit in the template will reflect the whole website, and not like now were the API documentation is very static.

Has this been solved with the website? :) @starwed

Yes, we should go ahead and close this -- the only big remaining doc-script related issue is to implement a local viewer for the api.


Settings and initial contents for Spanish localization

This PR is to initiate Spanish localization based on

Issue to #387
https://github.com/cncf/glossary/blob/main/LOCALIZATION.md guide

Base and target branch of this PR is dev-es which is development branch for Spanish localization.
This PR includes

[languages.es] section in config.toml
i18n/es.toml
Some translated documents

Main page

content/es/_index.md

Others

contribute: content/es/contribute/_index.md
style-guide: content/es/style-guide/_index.md

@electrocucaracha
Now Spanish Localization Team has https://github.com/cncf/glossary/tree/dev-es branch
Please rebase and change the target branch to dev-es

@electrocucaracha
I think this repository executes github/workflows/* (Github Actions) in main branch only.
Adding .github/workflows/es-spellcheck.yml to the dev-es branch only doesn't seem to work. (Am I right?)
In this PR, I'd like to focus on settings and initial contents for Spanish localization.
Can we handle Spell checker related files in another PR? (.github/workflows/es-spellcheck.yml, .gitignore)

@electrocucaracha  ! Thank you for the contribution ! :)
We are going to check following tasks in this PR. (target branch is dev-es)

[ ] 3-1. Adding a new language setting to site configuration https://github.com/cncf/glossary/blob/main/LOCALIZATION.md#3-1-adding-a-new-language-setting-to-site-configuration
[ ] 3-2. Adding a file for site strings https://github.com/cncf/glossary/blob/main/LOCALIZATION.md#3-2-adding-a-file-for-site-strings
[ ] 3-3. Adding a new localization directory https://github.com/cncf/glossary/blob/main/LOCALIZATION.md#3-3-adding-a-new-localization-directory
[ ] 3-4. Minimum required content https://github.com/cncf/glossary/blob/main/LOCALIZATION.md#3-4-minimum-required-content
[ ] 3-5. Check configuration works https://github.com/cncf/glossary/blob/main/LOCALIZATION.md#3-5-check-configuration-works-and-open-a-pr


ci: request CentOS Stream 8 bare-metal machines

CentOS 8 is EOL since the beginning of the year. CentOS Stream 8
installations should be used instead.

Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:

/retest ci/centos/<job-name>: retest the <job-name> after unrelated
failure (please report the failure too!)
/retest all: run this in case the CentOS CI failed to start/report any test
progress or results

/retest ci/centos/job-validation

/retest ci/centos/job-validation

/retest ci/centos/job-validation

/retest ci/centos/job-validation

/retest ci/centos/job-validation

/retest ci/centos/job-validation

/retest ci/centos/job-validation

/retest ci/centos/job-validation

/retest ci/centos/job-validation


Two types of links in one TextView

Hi! I have the following issue. If I have two types of links in one TextView (e.g. label and https://example.com one of the links will not be clickable. I see that this is so for the standard Linkify method. Did you saw something like that?

See #25.

Thank you! Could you share the code for the turning urls to tags?

Closing this because this does not seem related to this library. Better-Link-Movement-Method is only responsible for handling clicks on clickable spans. Please feel free to reopen this.