IsADirectoryError: [Errno 21] Is a directory: 'certs/icao_pkd_ml' (issue by @gbmamat)

Original from https://github.com/Fethbita/eMRTD_face_access/commit/e0167b107fed93d710f79ef11a6b4e0d36ff9bdc#commitcomment-66542414.

dear,
I try  to  process in  backend side   with  backend   Flask endpoint   https:///samples.com/v1/api/passiveAuth.  These  endpoint  will   upload  SODFile  as base64  to  backend server.
some things like this
from passive_authentication import (
    passive_auth,
    PassiveAuthenticationCriticalError,
)
from valid import download_certs
from icao_pkd_load import build_store
import os
from pathlib import Path
import base64

data ="""
d4IIzTCCCMkGCSqGSIb3DQEHAqCCCLowggi2AgEDMQ8wDQYJYIZIAWUDBAIDBQAwggGNBgZngQgB
AQGgggGBBIIBfTCCAXkCAQAwDQYJYIZIAWUDBAIDBQAwggFjMEUCAQEEQKd6LOBCwGcqeh/KYclP
j0nBuyFAaBMwk911RY6/xlXDDfqSvpUKekuecGlGpemeMnd2dIXoA14MWVBaRpcHZDkwRQIBAgRA
DonlwyPs5elPxB84jzBdKn0qnKVX6JfHsZoaOTZrTrASThTaRSIFVHAvSCJVTDgMYGrf0kBR4PRI
1hyfBFgNRzBFAgEHBEC4sUnCvDNAnGbaUP+6R5FMCa9taqR39HL4ZCs86NTtMg493OqFe+dta3MD
2XNLO+kdp5IBFm2BzTkmT2WsF0CTMEUCAQ4EQLMO7QiouSC0IXvv186U6wdSEbJ454y333e/skH1
8GlhM72R5ONh+6vuFC8zbH8Bm+TLQOistkIS22S3rMSHrh0wRQIBDwRAFFChsZtgEYXXrGpctmpR
rOv/uDSz9kaSf1pcIfGZW5gOwBsYZx82+ETGYjL6zPCNBFLgRiMz2TCS5NS80mdfbKCCBM4wggTK
MIICsqADAgECAgRXMu9QMA0GCSqGSIb3DQEBDAUAMEYxEjAQBgNVBAMMCUNTQ0FfRFBSSzEMMAoG
A1UECgwDTUZBMRUwEwYDVQQLDAxQYXNzcG9ydFVuaXQxCzAJBgNVBAYTAktQMB4XDTE2MDUxMTAw
MDAwMFoXDTI3MDcxMTAwMDAwMFowRDEQMA4GA1UEAwwHRFNfRFBSSzEMMAoGA1UECgwDTUZBMRUw
EwYDVQQLDAxQYXNzcG9ydFVuaXQxCzAJBgNVBAYTAktQMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8A
MIIBCgKCAQEAlrugYORjWDLXT+0C6YShJSN7kNq7Ifu5ZPXrwB0nlwLwdCPo/pfR0y3AMNBmzxoI
1g+4cc5Nwm3pKmSIgzgGdbc8Et0e8Hg6qSaNbRW53I+L1Uy/2ev1LSlz4tGdWL7ozHgo4p41UklP
VCTpAGvAlpncbWPjGmVmUHD4cuCfgt73kk+6EM0hMuucZXq+olT/2d9xRUfIbv4e1JYh+FZ54DsJ
RtaC6hsEhhXlfzpnJnEQLXxypS5Tdi9YUe0aZYpYzGYfnBMSoJ/1lCUaU5pMRM0EW2hWEnqyygf1
zy3Jx0F1dZ5RV7duTGNzRn+UnqKQcL/ssLFQ4yo/L/5OWRd2tQIDAQABo4HBMIG+MHEGA1UdIwRq
MGiAFNR9cbKREr4EQceQAL9PUbtDMPXKoUqkSDBGMRIwEAYDVQQDDAlDU0NBX0RQUksxDDAKBgNV
BAoMA01GQTEVMBMGA1UECwwMUGFzc3BvcnRVbml0MQswCQYDVQQGEwJLUIIEVzLqUzAOBgNVHQ8B
Af8EBAMCB4AwDAYDVR0TAQH/BAIwADArBgNVHRAEJDAigA8yMDE2MDUxMTAwMDAwMFqBDzIwMTcw
NjExMDAwMDAwWjANBgkqhkiG9w0BAQwFAAOCAgEAVYVXpUANQNFXt7GLR1sRtcl3w3CeNZpiDZ7N
dbDvLT9UbLJmF1rrf79VaaS8+Ox4QxtM+7pQXti8arJqMJ9oLOb1qbWinF31XjHLJtc1FRtw2nQY
tvbyQJlorA7FZhm2vj/gIETgg2ux+0HDaiRDavs3b3yiq3VTRR+cuIa3HY3aoCDdBe4ULMTbf62w
ZrQJAmWBkIB9RmUsPoL9tDgb9O40LgWwQ+oPa24bMw3S4qosI8q/+YrSN9frpwzDbCTfLOfOB6/C
tpmuo+BTFllgL0UjpcidO3q7x400bLnZJaHnRJFuc8Iov5ihVKsaYLIOI+vpttUnPBUKCYhBMdAo
IPigrBHGrKMnafXTZklOrUpphsFWiQ01T3LHu56XCTpvvUTO4/UIw7ey8hgYW01t2o69q1YpJnG3
rfn/PnrdYu5rhEPlj7DxeyRz4L+EyluPR/cm9a9/SZe3GWS0+WKlgDG9Tqe7C1a8QyJP0/4w885B
8I8wKp1Tn3lOqxbzrHqQhCmKqCELkGC7Jq8eultek+DjniMLy1GWWRTG3C8IT852++Sy9bfMDha0
M2nzmb+0WH/LAF8O5S5dPSNdtQXOurTQdkHBxFpgFBEIjgjdSI/mDKN1JPKQkvMDIUd4gX2N/pyG
7cViod+A9eVzlIhbipHMN9gHnXzCmaC+LZbNYKoxggI7MIICNwIBATBOMEYxEjAQBgNVBAMMCUNT
Q0FfRFBSSzEMMAoGA1UECgwDTUZBMRUwEwYDVQQLDAxQYXNzcG9ydFVuaXQxCzAJBgNVBAYTAktQ
AgRXMu9QMA0GCWCGSAFlAwQCAwUAoIGGMBUGCSqGSIb3DQEJAzEIBgZngQgBAQEwHAYJKoZIhvcN
AQkFMQ8XDTE2MTEyMjA4MzQxNVowTwYJKoZIhvcNAQkEMUIEQBi1YT+yTDlWiKgORwwA1ZcGX9/B
bDzJGfqfoS3lfTxpcIGd7ntxWroPK5zCJJf8JLKLkYdMWroTzotLgBdInD4wRgYJKoZIhvcNAQEK
MDmgDzANBglghkgBZQMEAgMFAKEcMBoGCSqGSIb3DQEBCDANBglghkgBZQMEAgMFAKIDAgFAowMC
AQEEggEAfj8R7ucrZ/bLkRKDj4car+covU3tQed9hegCJ3o0bF1W2Zw2YynsQDv3c0sLkl8k7IL4
BRRs1gQdBj5dKAH3psSwRgwNtuu+7uswxntGA0+fymSkVavUGIN15/7XCkNlTRkpU/tHyutGOZd3
XFopTL57MFx1plkpBunThEI8ng3hmXCXVrpf0uWaeLLfzgzGA8qzNZIuIWsZcdxbL5203tHYNfgf
vem9/RzeMlUPr7t8Ujdbv5Ka+IfW4yZ53uziUiUqWq9ilWopC00ZjvMiycwXOdM2iZu/1vR8mySF
bBYYGiyVy3C9+51hSru0bSsxAvbMmK1NkA7hHLOmFCQnng==
"""
sod = base64.b64decode(sodData)

 CSCA_certs_dir = Path("certs/")

 crls_dir = Path("certs/crls")

 download_certs(CSCA_certs_dir, crls_dir)

 dsccrl_dir = Path(os.path.join(os.path.dirname(CSCA_certs_dir), Path("icao_pkd_dsccrl")))

 ml_dir = Path(os.path.join(os.path.dirname(CSCA_certs_dir), Path("icao_pkd_ml")))

 build_store(CSCA_certs_dir, crls_dir, ml_dir, dsccrl_dir)

 try:
        passive_auth_return = passive_auth(sod, deviant_doc=False, dump=False)
        result =  {
                     "status": "200",
                     "message":" Successfull done!",
                     "result": passive_auth_return,
                     "authenticity": "SUCCESSED"

                  }
        return result
    except PassiveAuthenticationCriticalError as ex:
         result =  {
                     "status": "400",
                     "message":"Passive Authentication Critical Error!",
                     "authenticity": "FAILED"

                  }
        return result

But, I got  following  error
build_store(CSCA_certs_dir, crls_dir, ml_dir, dsccrl_dir)
File "/home/devadmin/com.biomiid.kyx/backend/icao_pkd_load.py", line 41, in build_store
with open(os.path.join(CSCA_certs_dir, file), "rb") as infile:
IsADirectoryError: [Errno 21] Is a directory: 'certs/icao_pkd_ml'
Please, can  you  help me to fix this  issue?
Thank you  in advance.
Regards,

The arguments for build_store should each be folders that contain the items directly as files. So in this case, you should have a CSCA_certs_dir that has certificates that you want to add as an extra (that are not in any ML for example), crls_dir should contain CRLs and so on. Do not create a CSCA_certs_dir to contain all the other folders (crls_dir, ml_dir, dsccrl_dir).
You can see how this is achieved in the main main_program_loop.py.
# ...
CSCA_certs_dir = args.certs or Path("certs/csca_certs")
crls_dir = args.certs or Path("certs/crls")
# ...
# note that os.path.dirname gets the directory name, not the name of the file itself
dsccrl_dir = Path(os.path.join(os.path.dirname(CSCA_certs_dir), Path("icao_pkd_dsccrl")))
ml_dir = Path(os.path.join(os.path.dirname(CSCA_certs_dir), Path("icao_pkd_ml")))
# ...
build_store(CSCA_certs_dir, crls_dir, ml_dir, dsccrl_dir)

Thank you for your reply.
in  my use case I want  support ICAO PKD   countries members(not  only individual country  like  on your demo use case EE)   used   ML, DSCRL,  NC    .ldip  files, so  will support all  ICAO PKD members countries (82 countries)
Regards

You can leave the CSCA_certs_dir directory empty if you do not want to add an individual country. If you are already adding and using MLs, then they should be used. Let me know if this helped you solve your issue.

ml_dir, dsccrl_dir   directories  depended of  CSCA_certs_dir

I'm  created  tree different directories :
dsccrl_dir = Path("certs/icao_pkd_dsccrl")
ml_dir = Path("certs/icao_pkd_ml")
nc_dir = Path("certs/icao_pkd_nc")
...
build_store(ml_dir, dsccrl_dir, nc_dir)

Now  i got  passive auth   verification result
[+] CertificateSet exist
[+] Document Signer Certificate is signed by a CSCA certificate
[+] Content Type of eContent match with the Content Type in SignedAttributes
[+] Hash of eContent match with the hash in SignedAttributes
[+] The signature on EF_SOD is valid.

how to  integrate   nc_dir  icaopkd-003-nc-xxxxxx.ldif     in  pypassport?

how to integrate nc_dir icaopkd-003-nc-xxxxxx.ldif in pypassport?

Unfortunately NC document handling is not supported.
It is only implemented for Estonian ID card cases, where the CDSs included in the eMRTD chips, in their notBefore and notAfter fields had a 12-hour negative offset compared to the original CDS that was signed. The workaround for this single case can be seen in https://github.com/Fethbita/eMRTD_face_access/blob/0f9cf2dd04559710720cac3a1109118c4bea6ed8/emrtd_face_access/main_program_loop.py#L291-L300 and https://github.com/Fethbita/eMRTD_face_access/blob/0f9cf2dd04559710720cac3a1109118c4bea6ed8/emrtd_face_access/passive_authentication.py#L116-L129

Thank you  so much  for  your reply  and time.
Have good day
see you   later

Thank you for showing interest on this project and creating an implementation using it. Have a nice day


Converting ROS PointCloud2 object to KITTI .bin file

This is more of a ROS/KITTI question, but does anyone know how to convert a ROS PointCloud2 object to a KITTI-style .bin file? I'm collecting PointCloud2 scan objects, but don't know how to convert them to the KITTI .bin format in order to use this lidar-bonnetal code for segmentation.

A .bin file contains 4*N values, where N is the number of points and 4 because it contains x, y, z, reflection in that order. So you have to extract these values from your pointcloud, create an array from them and save it in a binary file using a float32 format.
Sample python code:
  pc = pypcd.PointCloud.from_msg(msg)
  x = pc.pc_data['x']
  y = pc.pc_data['y']
  z = pc.pc_data['z']
  intensity = pc.pc_data['intensity']
  arr = np.zeros(x.shape[0] + y.shape[0] + z.shape[0] + intensity.shape[0], dtype=np.float32)
  arr[::4] = x
  arr[1::4] = y
  arr[2::4] = z
  arr[3::4] = intensity
   arr.astype('float32').tofile('filename.bin')

Thanks for resolving this issue, @kosmastsk.
I would also say, read the point cloud with ROS, write it as a binary file, 4 floats each point. But @kosmastsk provides actually nice code that should basically solve your problem.

Thanks for all the help! I'm now getting a "no field of name intensity" error. I also tried swapping out "intensity" for "reflection" just in case, and got the same type of error. Maybe the scan I'm receiving doesn't have that data? How should I fill in the intensity field for the .bin file? Again, thank you so much!

Thank you so much for the help!

Hello @jonathanslee4 , @kosmastsk I have the error "no module named pypcd" when I run python script. I have install pypcd with pip (python 3). Can you help me please ?

@SofianeB-03 you have to try re-install pypcd in your system, in a different environment or something. But there are also other ways to "read" a pointcloud, apart from pypcd, this was just an example

@kosmastsk first thank you for your reply. Okay I will probably try to re-install pypcd in a different environnement. Also I found pcl_ros package to convert a point-cloud2 message to PCD format but I have intensity and also reflectivity values in the output PCD file. What is the 4th component for the .bin KITTI: Intensity or reflectivity ?

@SofianeB-03 intensity and reflectivity is exactly the same thing in LiDAR data. In KITTI data as far as I remember these values are in the scale [0,1]

Okay I note this information. Thank you very much to take the time to answer me.

@kosmastsk thank you

Can someone share how to use above code

@kosmastsk @jonathanslee4  i have rosbag collected using ros2 galactic, can you tell me a detailed way to create .bin files from rosbag.
i saw above code but its giving
NotImplementedError('ROS sensor_msgs not found')
i am new to ros and pointcloud. any help is appreciated. Thank you.

The above response is for ROS1, I'm sorry but I have no such thing for ROS2 right not.

@kosmastsk i really appreciate the response.
thank you very much
if i use ros neotic can you share simple steps to convert rosbag into kitti format .bin file
apologies for such basic question, but im quiet confused.
Thank you in advance

FOR Noetic
See my StackExchange reply


nav bar hover color is no good in dark mode can we change this in to cream color

Related Issue
[Cite any related issue(s) this pull request addresses. If none, simply state “None”]
Fixes:  #(#1965.)
Description
nav bar hover color is no good in dark mode can we change this in to cream color

Type of PR

[ ] Bug fix
[ ] Feature enhancement
[ ] Documentation update
[x] Other (specify): _______________
![340787358-f88c01fc-87df-4371-9b5b-70133fda8e54]

Screenshots / videos (if applicable)
now

then
(https://github.com/anuragverma108/SwapReads/assets/125860170/2400c29f-5a8c-4b3b-a7a8-89983443ec47)
Checklist:

[x] I have made this change from my own.
[ ] I have taken help from some online resources.
[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[x] I have tested the changes thoroughly before submitting this pull request.
[x] I have provided relevant issue numbers and screenshots after making the changes.

@huamanraj  level is not assign plz add level tag


Fix allowed create/update params for endpoints

Endpoints were missing verify_ssl and certificate_authority as allowed
create/update params.

cc @bdunne @martinpovolny


python310Packages.aiohomekit: 3.0.2 -> 3.0.3

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python310Packages.aiohomekit is: Python module that implements the HomeKit protocol
meta.homepage for python310Packages.aiohomekit is: https://github.com/Jc2k/aiohomekit
meta.changelog for python310Packages.aiohomekit is: https://github.com/Jc2k/aiohomekit/releases/tag/3.0.3
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 3.0.3 with grep in /nix/store/190h69jpg1pnhvqh0l15yyf4xv1hmslx-python3.10-aiohomekit-3.0.3
found 3.0.3 in filename of file in /nix/store/190h69jpg1pnhvqh0l15yyf4xv1hmslx-python3.10-aiohomekit-3.0.3

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

3 package rebuild(s)

First fifty rebuilds by attrpath
home-assistant-component-tests.homekit_controller
python310Packages.aiohomekit
python311Packages.aiohomekit

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/190h69jpg1pnhvqh0l15yyf4xv1hmslx-python3.10-aiohomekit-3.0.3 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python310Packages.aiohomekit https://github.com/r-ryantm/nixpkgs/archive/855b90470096230d6af54aa103e0c7cb70d6aa8c.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/190h69jpg1pnhvqh0l15yyf4xv1hmslx-python3.10-aiohomekit-3.0.3
ls -la /nix/store/190h69jpg1pnhvqh0l15yyf4xv1hmslx-python3.10-aiohomekit-3.0.3/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

3 packages built:

home-assistant-component-tests.homekit_controller
python310Packages.aiohomekit
python311Packages.aiohomekit

Maintainer pings
cc @fabaff for testing.

@ofborg eval


Omit redundant lane information

"Keep left to turn left" is redundant. We should only indicate lanes when they contradict the user's intuition, like for Melbourne-style left-lane right turns.
/cc @freenerd @bsudekum

Do we still do this? Is there an example route?

This issue was filed in response to a prototype implementation that tacked lane guidance onto every instruction. In #38, we took the more conservative approach of including lane guidance only in use lane instructions and opened #48 as tail work to incorporate it into other kinds of instructions. As I understand it, use lane is going away, making #48 more important. Let’s track the remaining work there.


consul: 1.9.5 -> 1.9.6

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/hashicorp/consul/releases.
meta.description for consul is: "Tool for service discovery, monitoring and configuration"
meta.homepage for consul is: "https://www.consul.io/"
meta.changelog for consul is: ""
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

Warning: a test defined in passthru.tests did not pass

/nix/store/vllwf7391gclg569hw2mmivsfk183xls-consul-1.9.6/bin/consul passed the binary check.

/nix/store/vllwf7391gclg569hw2mmivsfk183xls-consul-1.9.6/bin/certgen passed the binary check.

2 of 2 passed binary check by having a zero exit code.

1 of 2 passed binary check by having the new version present in output.

found 1.9.6 with grep in /nix/store/vllwf7391gclg569hw2mmivsfk183xls-consul-1.9.6

found 1.9.6 in filename of file in /nix/store/vllwf7391gclg569hw2mmivsfk183xls-consul-1.9.6

directory tree listing: https://gist.github.com/5d9c6894b6005fd7267776c6bd454da8

du listing: https://gist.github.com/95566e6d8d0d4adc569747b05b9e1665

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
consul

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/vllwf7391gclg569hw2mmivsfk183xls-consul-1.9.6 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A consul https://github.com/r-ryantm/nixpkgs/archive/35ea60a0ff7e1c1a1bc7bc10515ce22c35c88ad8.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/vllwf7391gclg569hw2mmivsfk183xls-consul-1.9.6
ls -la /nix/store/vllwf7391gclg569hw2mmivsfk183xls-consul-1.9.6/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

consul

Maintainer pings
cc @pradeepchhetri @vdemeester @nh2 @kalbasit for testing.

Looking good.


add dash in user code for readability

yeah this seems fasted way, otherwise has to add and remove dash during retrieval and checking

will add at api layer


”Cotnari”, ”Bahluiu”, ”Cireșeni”, ”Cârjoaia” are listed in the drop-down menu

Description:
When user writes ”Cotnari”, ”Bahluiu”, ”Cireșeni”, ”Cârjoaia” the locations appear in the drop-down menu next to the comune and the county which is a part according to the law.
Precondition:
The website is up an running.

Step 1
Write in the search bar "Cotnari"

Expected results
The location appears in the drop-down menu as "Sat Cotnari, IAȘI (Cotnari)".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Write in the search bar "Bahluiu"

Expected results
The location appears in the drop-down menu as "Sat Bahluiu, IAȘI (Cotnari)".

Step 4
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 5
Write in the search bar "Cireșeni"

Expected results
The location appears in the drop-down menu as "Sat Cireșeni, IAȘI (Cotnari)".

Step 6
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 7
Write in the search bar "Cârjoaia"

Expected results
The location appears in the drop-down menu as "Sat Cârjoaia, IAȘI (Cotnari)".


simplify dependencies

Remove myget from nuget resolution list, may plausibly fix #617

It's recommended to embed the text Remove myget from nuget resolution list, may plausibly fix #617 in one of your commit messages. Otherwise, if in the future the repository is moved outside github, this metadata will be lost.


Include support to bytes  built-in type.

Implements support for bytes in response to #844 .

Hi @pedropgusmao, thanks for getting this started!
The implementation looks good.
Here are a few changes that I think should be made:

base.py:DictKeyType should accept bytes.
Update the OmegaConf docs

There are several places in OmegaConf's tests where each supported type is tested. To keep consistency with the other tests, it would be good to add bytes test cases in these places.

tests/test_omegaconf.py:test_is_none
tests/test_omegaconf.py:test_is_interpolation
tests/test_utils.py:test_node_wrap
tests/test_utils.py:test_get_ref_type
tests/test_utils.py:test_is_optional
tests/test_nodes.py:test_accepts_mandatory_missing
tests/test_nodes.py:test_legal_assignment
tests/test_nodes.py:test_eq
tests/test_pydev_resolver_plugin.py:test_get_dictionary_node``tests/test_pydev_resolver_plugin.py:test_can_provide
tests/test_matrix.py:TestNodeTypesMatrix
tests/__init__.py:SubscriptedDict
tests/test_basic_ops_dict.py:TestDictKeyTypes
tests/test_basic_ops_dict.py:test_in_dict
tests/test_to_yaml.py:test_to_yaml
tests/test_to_yaml.py:test_to_yaml_string_primitive_types_list``tests/test_to_yaml.py:test_to_yaml_string_primitive_types_dict
tests/interpolation/test_interpolation.py:test_type_inherit_type
tests/test_compare_dictconfig_vs_dict.py:TestUntypedDictConfig
tests/test_compare_dictconfig_vs_dict.py:TestUntypeTestPrimitiveTypeDunderMethods
tests/structured_conf
tests/examples/test_dataclass_example.py:SimpleTypes
tests/examples/test_dataclass_example.py:simple_types_class
comments in tests/examples/test_dataclass_example.py
tests/test_serialization.py:test_pickle_untyped

An open questions:
Are there any values that OmegaConf's interpolation parser should interpret as bytes?
If so, we will need to modify the following:

omegaconf/grammar and omegaconf/grammar_parser.py, etc
tests/test_grammar.py
tests/interpolation/built_in_resolvers/test_oc_decode.py:test_decode

I have pushed two commits to this PR branch.

Thanks @Jasha10 ,
I will start working on: https://github.com/omry/omegaconf/pull/845#issuecomment-999322636 (I might need help here though) and update the documentation for https://github.com/omry/omegaconf/pull/845#issuecomment-999322565 .
Sorry, I'm not very familiar with OmegaConf's interpolation parser. Where could I learn more about it? https://github.com/omry/omegaconf/pull/845#issuecomment-999322685

working on tests:

[ ] tests/test_omegaconf.py:test_is_none
[ ] tests/test_omegaconf.py:test_is_interpolation
[ ] tests/test_utils.py:test_node_wrap
[ ] tests/test_utils.py:test_get_ref_type
[ ] tests/test_utils.py:test_is_optional
[ ] tests/test_nodes.py:test_accepts_mandatory_missing
[ ] tests/test_nodes.py:test_legal_assignment
[ ] tests/test_nodes.py:test_eq
[ ] tests/test_pydev_resolver_plugin.py:test_get_dictionary_node``tests/test_pydev_resolver_plugin.py:test_can_provide
[ ] tests/test_matrix.py:TestNodeTypesMatrix
[ ] tests/init.py:SubscriptedDict
[ ] tests/test_basic_ops_dict.py:TestDictKeyTypes
[ ] tests/test_basic_ops_dict.py:test_in_dict
[ ] tests/test_to_yaml.py:test_to_yaml
[ ] tests/test_to_yaml.py:test_to_yaml_string_primitive_types_list``tests/test_to_yaml.py:test_to_yaml_string_primitive_types_dict
[ ] tests/interpolation/test_interpolation.py:test_type_inherit_type
[ ] tests/test_compare_dictconfig_vs_dict.py:TestUntypedDictConfig
[ ] tests/test_compare_dictconfig_vs_dict.py:TestUntypeTestPrimitiveTypeDunderMethods
[ ] tests/structured_conf
[ ] tests/examples/test_dataclass_example.py:SimpleTypes
[ ] tests/examples/test_dataclass_example.py:simple_types_class
[ ] comments in tests/examples/test_dataclass_example.py
[ ] tests/test_serialization.py:test_pickle_untyped

Don't worry about the parser for now -- we can publish a followup PR if we decide to change that later.
The idea is that arguments to omegaconf's interpolations and resolvers get parsed according to a grammar that is defined in the files omegaconf/grammar/*.g4.
For example, the string ${oc.decode:abc} would be parsed and decoded into a str, while ${oc.decode:123.456} would be decoded into a float. My question above was about if there is anything that should be decoded into bytes... But this is a question that can be dealt with later.

Hi @Jasha10 , I hope you are doing fine.
Please take a look at the tests I've created so far and let me know if those need improving.
Also, when creating Bytes tests for tests/test_to_yaml.py:test_to_yaml, I have noticed that pyyaml doesn't like to use bytes as keys.
>>> import yaml
>>> h = { "a" : "1", b"a": "1"}
>>> h
{'a': '1', b'a': '1'}
>>> print(yaml.dump(h))
a: '1'
? !!binary |
  YQ==
: '1'

Any ideas on how we should adapt this, or if bytes as keys are really necessary?

Hi @Jasha10 ,
Hope you are doing well and Happy New Year!
I was wondering if you had time to go over the tests I've written so far.
Thanks!

Apologies for the late reply!
I will take a look at it shortly.
Happy New Year to you too :)

Looking good, @pedropgusmao!
After some consideration, @pixelb and I feel best about not doing any conversion between str and bytes. Not doing automatic conversion will help avoid surprising behavior and bugs.

FYI I'm planning to push a few more commits to round-out the testing.

I've rebased to incorporate some changes from the master branch.
Additionally, I've added two commits.
The first commit (https://github.com/omry/omegaconf/pull/845/commits/32c0f9dbb6dfb4ed4585fc510de150cf26d4495f) removes all conversion between strings and bytes.
from dataclasses import dataclass
from omegaconf import OmegaConf

@dataclass
class Conf:
    s: str = "abc"
    x: bytes = b"binary"

cfg = OmegaConf.create(Conf)

cfg.s = b"bin"  # previously performed conversion, now this throws ValidationError
cfg.x = "string"  # previously performed conversion, now this throws ValidationError

The second commit (https://github.com/omry/omegaconf/pull/845/commits/64eeeab208ebce0963609bea6b752f7a2ed9f2f0) adds more tests for BytesNode and polishes the tests and documentation.

Thanks for this, @Jasha10
Is there anything else I can do on my side to help with this?
Also, just to clarify things a bit for me and to others who might read this PR; after we apply these changes, does it mean that :

Calls to instantiate/ call that require Bytes to be passed as arguments will be allowed?
Bytes will be supported, but not from yaml files. Or at least not encouraged?
Conversions between str and Bytes will not be supported.
Thanks

Thanks for this, @Jasha10 Is there anything else I can do on my side to help with this?

Nope, I am happy with the shape of the PR.

Also, just to clarify things a bit for me and to others who might read this PR; after we apply these changes, does it mean that :

Calls to instantiate/ call that require Bytes to be passed as arguments will be allowed?

Yes, Hydra+instantiate will support binary (bytes) values.
>>> instantiate({"_target_": "builtins.dict", "abc": b"123"})
{'abc': b'123'}
>>> instantiate({"_target_": "builtins.dict"}, abc=b"123")
{'abc': b'123'}

However, instantiate does not support binary keys:
>>> instantiate({"_target_": "builtins.dict", b"binary_key": "foo"})
...
TypeError: keywords must be strings

Bytes will be supported, but not from yaml files.

Bytes will be supported in yaml files via yaml's binary tag:
>>> cfg = OmegaConf.create({"x": b"binary_data"})
>>> yml = OmegaConf.to_yaml(cfg)
>>> print(yml)
x: !!binary |
  YmluYXJ5X2RhdGE=

>>> OmegaConf.save(cfg, "x.yaml")
>>> print(open("x.yaml", "r").read())
x: !!binary |
  YmluYXJ5X2RhdGE=

>>> OmegaConf.load("x.yaml")
{'x': b'binary_data'}

This will work when Hydra loads yaml files too.

Or at least not encouraged?

Storing large binary data will not be encouraged.
The Hydra+OmegaConf stack is primarily intended as a human interface rather than as an arbitrary data store. In particular, OmegaConf and Hydra are not tuned to work with big data; they may make copies of data when performing oeprations such as config creation and merging.
Storing large blocks of binary data is better supported by something like pickle or numpy.save. Note that you can always use Hydra's instantiate API to invoke e.g. numpy.load when you need to get big data from disk.
big_data = instantiate({"_target_": "numpy.load", "file": "my_big_data.npy"})

For small blocks of binary data, there is BytesNode :)

Conversions between str and Bytes will not be supported.

Yes, automatic conversion will not be supported. Users will need to manually convert using python code or using a custom resolver.

Thanks

Thank you!!

I've force-pushed again after doing an interactive rebase to drop commit https://github.com/omry/omegaconf/commit/f4d4ec5477d6f88fdda6984a597544df1c4868cb from this PR. (The dropped commit would undo the diff from #853 which is now merged into master).

Whoops, I closed this PR on accident, and now it seems I'm unable to reopen it. I've opened PR 872 instead.


CI: add build/lint/test workflow

Just something basic to get it going for now :).

Concept ACK
Checks fail because cargo.lock is not committed. Do you think we should commit it, or remove the  --locked argument from CI?
general rust recommendation is to not commit the .lock

Ah yeah, this is my bad. Don't think we should commit the lockfile—will remove the --locked argument!

ah yeah tests fail due to https://github.com/nomad-xyz/safe-sdk/pull/2#discussion_r1148634916 ; i think we should #[ignore] this test for now and just make sure we put this as an issue

aight seems good to go—should we squash the pr?

ya I'm one of those annoying "squash merge only" people :)

oh ya no worries, me too 😛


vk: remove unused platform GGP

I'm fine with removing, but this was added by a 3P contributor, FYI (#6235). Is it causing a maintenance burden?

I'm fine with removing, but this was added by a 3P contributor, FYI (#6235). Is it causing a maintenance burden?

It's been removed internally, therefore removing it here as well.


Added method for getting clipboard content

Added API method for getting clipboard content from selenoid continer

@dbudim Thank you! A couple of questions:

Do you really need to use OkHttpClient? SelenoidClient already has method readToString for performing GET requests.
How it would be easier for users to use clipboard?
Current syntax new ClipboardSelenoid(...).get(); is ok, but probably it would be even better to have methods like getClipboard, setClipboard or even clipboard.shouldHave(text(..)) in Selenide, and override them in selenide-selenoid?

@asolntsev
OkHttpClient isn't really needed, i just prefer it in using. I'll change it to existed method )
About condition i've commented in PR to main repo, think it's cool idea)


Trans coding Issue

4/20/2018 17:47:40 [INFO] [rtmp publish] New stream. id=WTV3CKWE streamPath=/live/stream streamId=1
4/20/2018 17:47:41 [INFO] verify it.
4/20/2018 17:47:41 [INFO] Debug Transcoder true
4/20/2018 17:47:41 [INFO] [Transmuxing MP4] /live/stream to ./media/live/stream/2018-04-20-17-47.mp4
4/20/2018 17:47:41 [INFO] [Transmuxing HLS] /live/stream to ./media/live/stream/index.m3u8
4/20/2018 17:47:41 [INFO] [Transmuxing DASH] /live/stream to ./media/live/stream/index.mpd
[NodeEvent on postPublish] id=WTV3CKWE StreamPath=/live/stream args={"ac":0,"vc":0}
[NodeEvent on preConnect] id=7F9LUKT0 args={"app":"live","flashVer":"LNX 9,0,124,2","tcUrl":"rtmp://localhost:1935/live","fpad":false,"capabilities":15,"audioCodecs":4071,"videoCodecs":252,"videoFunction":1}
4/20/2018 17:47:41 [INFO] [rtmp connect] id=7F9LUKT0 ip=<IP_ADDRESS> app=live args={"app":"live","flashVer":"LNX 9,0,124,2","tcUrl":"rtmp://localhost:1935/live","fpad":false,"capabilities":15,"audioCodecs":4071,"videoCodecs":252,"videoFunction":1}
[NodeEvent on postConnect] id=7F9LUKT0 args={"app":"live","flashVer":"LNX 9,0,124,2","tcUrl":"rtmp://localhost:1935/live","fpad":false,"capabilities":15,"audioCodecs":4071,"videoCodecs":252,"videoFunction":1}
[NodeEvent on prePlay] id=7F9LUKT0 StreamPath=/live/stream args={}
[NodeEvent on postPlay] id=7F9LUKT0 StreamPath=/live/stream args={}
4/20/2018 17:47:41 [INFO] [rtmp play] Join stream. id=7F9LUKT0 streamPath=/live/stream  streamId=1
4/20/2018 17:47:41 [INFO] [rtmp publish] Handle audio. id=WTV3CKWE streamPath=/live/stream sound_format=10 sound_type=2 sound_size=1 sound_rate=3 codec_name=AAC 44100 2ch
4/20/2018 17:47:41 [INFO] [rtmp publish] Handle video. id=WTV3CKWE streamPath=/live/stream frame_type=1 codec_id=7 codec_name=H264 1092x614
[NodeEvent on donePlay] id=7F9LUKT0 StreamPath=/live/stream args={}
4/20/2018 17:47:42 [INFO] [rtmp play] Close stream. id=7F9LUKT0 streamPath=/live/stream streamId=1
4/20/2018 17:47:42 [INFO] [Transmuxing end] /live/stream
4/20/2018 17:47:42 [INFO] [rtmp disconnect] id=7F9LUKT0
[NodeEvent on doneConnect] id=7F9LUKT0 args={"app":"live","flashVer":"LNX 9,0,124,2","tcUrl":"rtmp://localhost:1935/live","fpad":false,"capabilities":15,"audioCodecs":4071,"videoCodecs":252,"videoFunction":1}
System it self end-up the [Transmuxing end] /live/stream, even its not generating file at [Transmuxing DASH] /live/stream to ./media/live/stream/index.mpd

I have a kind the same issue, starting remux and it end without placing files etc., I am now using a second ffmpeg to transcode to hls however it is not the solution I want to have because I want to remux the stream in its origine.
My current workaround is
ffmpeg -v verbose -i rtmp://[server]/live/STREAM_NAME -c:v libx264 -c:a aac -ac 1 -strict -2 -crf 18 -profile:v baseline -maxrate 400k -bufsize 1835k -pix_fmt yuv420p -flags -global_header -hls_time 10 -hls_list_size 6 -hls_wrap 10 -start_number 1 /home/stream/public_html/test1/test.m3u8
Please inform me when solution is found anywhere


Fix #3299 Add offense for private_class_method without arguments

Refactored IneffectiveAccessModifier cop so it doesn't use any instance variables to track current state
Added more tests to the IneffectiveAccessModifier cop
The above was done in an attempt to make IneffectiveAccessModifier handle private_class_method with no arguments, but I eventually decided that the cop can't handle this reasonably, as it can't guess which methods were meant to be set as private (it may highlight just the first method after private_class_method or all static methods after it?)
Added offense in UselessAccessModifier cop for private_class_method without any arguments, as well as if the class contains only private_class_method call.

Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[x] The PR relates to only one subject with a clear title
and description in grammatically correct, complete sentences.
[x] Run rake default or rake parallel. It executes all tests and RuboCop for itself, and generates the documentation.

LGTM 👍
P.S. You should stop putting those . in the commit titles one of those days. 😉


Fix Active Sidebar Item on first page load

Expected Behavior
Sidebar Icon "Dashboard" should be highlighted as blue when first loading into the home page.
Actual Behavior
The sidebar icon does not have a color and only works when the url is "/dashboard"
Steps to Reproduce
Go to the landing page
Notice the icon is only white
Possible solutions
Make the /dashboard url the homepage

Commit: f0ed5a1
Uses next.js rewrites to solve this problem


Popover Arrow flipped when shown above item (iOS)

Short description of the problem:
When a popover opens above an element (f.e. button in footer) the arrow still points up.
What behavior are you expecting?
Popover arrow pointing to the element (down)
Steps to reproduce:

Create a page with a footer
Add button to footer
Open Popover with this button

Other information:
Caused by:
CSS class popover-bottom is added to the popover itself, but in the iOS styling it's handled as a child element:
https://github.com/driftyco/ionic/blob/master/src/components/popover/popover.ios.scss#L69
https://github.com/driftyco/ionic/blob/master/src/components/popover/popover.ios.scss#L74
Remove space should fix the issue
.popover-ios.popover-bottom .popover-arrow {
  top: auto;
  bottom: -10px;
}

.popover-ios.popover-bottom .popover-arrow::after {
  top: -6px;
}

Which Ionic Version? 1.x or 2.x
2.0.0-rc.0
Run ionic info from terminal/cmd prompt: (paste output below)
Cordova CLI: 6.3.1
Gulp version:  CLI version 3.9.1
Gulp local:
Ionic Framework Version: 2.0.0-rc.0
Ionic CLI Version: 2.1.0
Ionic App Lib Version: 2.1.0-beta.1
OS: Distributor ID:     LinuxMint Description:  Linux Mint 17.3 Rosa
Node Version: v6.7.0

Any way this could get moved in to the rc.1 milestone?

@zakton5 can you provide a screenshot?

@manucorporat

@brandyscarney confirmed this is a real issue:

Thanks for the PR! This will be fixed in the rc.1 release. :smile:


Working on the project

Hi I really wanto to contribute to this project but I'm having some difficulties
I'm using vscode and I've already cloned the project(locally, not in conda) but I'm having difficulties running the project in the console.
I've already switched the interpreter to conda but it seems like it's not working
I want to work on the stories so that the text is splitted by a separator and not every 5 words or so:)

Well, what's your error message? I assume you installed all requirements? Furthermore, make sure you have torch version 1.7.1.

I think I got it to run
The problem was that I tried to run it with the wrong python.exe
But through finding the python.exe in the conda env and the executing the project with that .exe it worked
But now I'm getting this error:
from .clip import load, tokenize  ImportError: attempted relative import with no known parent package

That might be a good place to start contributing! ;)
I think this line should have the full path: from deep_daze.clip import load, tokenized
For me it works as it is, but Windows might have some problems there.


Update Python.gitignore with VSCode extensions

Reasons for making this change:
Adding VS Code file extensions and DS_Store custom attributes.
TODO
Links to documentation supporting these rule changes:
TODO
If this is a new template:

Link to application or project’s homepage: TODO

Would like to have it added. Can this be merged soon?

@shiftkey


Error retrieving kubelet metrics

Rancher versions:
rancher/server or rancher/rancher:2.4.0
rancher/agent or rancher/rancher-agent:2.4.0
Infrastructure Stack versions:
healthcheck:
ipsec:
network-services:
scheduler:
kubernetes (if applicable):1.10.1-rc2
**Docker version: 1.13.1
**Operating system and kernel: CentOS7.5
**Type/provider of hosts: KVM
**Setup details: HA-rancher
**Environment Template: Kubernetes
Reference from
[https://github.com/coreos/prometheus-operator/tree/master/contrib/kube-prometheus#error-retrieving-kubelet-metrics]
"""
Error retrieving kubelet metrics
Should the Prometheus /targets page show kubelet targets, but not able to successfully scrape the metrics, then most likely it is a problem with the authentication and authorization setup of the kubelets.
As described in the prerequisites section, in order to retrieve metrics from the kubelet token authentication and authorization must be enabled. Some Kubernetes setup tools do not enable this by default.
Authentication problem
The Prometheus /targets page will show the kubelet job with the error 403 Unauthorized, when token authentication is not enabled. Ensure, that the --authentication-token-webhook=true flag is enabled on all kubelet configurations.
Authorization problem
The Prometheus /targets page will show the kubelet job with the error 401 Unauthorized, when token authorization is not enabled. Ensure that the --authorization-mode=Webhook flag is enabled on all kubelet configurations.
"""
Results:

I'm supposed to change kubelet config according to official instructions, but I don't know how to change the cluster deployed by rancher？？？？
i want to help.

With the latest integration of Prometheus and monitoring in Rancher 2.2, can you try that?


Odd visual effect in List View

Great theme, very official!
Here are some of my observations/feedback
Image showing files/folders in List View, with everyting selected (CTRL A)
Notice the alternate styles
Notice the table/column white selected heading

Remove default elFinder theme css/theme.css

Without the official theme, many things become unusable. Did you succeed with this on version 2.1.23?

I don't tested theme with latest version. Fix it over the weekend

https://github.com/RobiNN1/elFinder-Material-Theme/commit/d3c37bc117f9c8cec288609755aba9b505fc30d7

Probably the best themes for elFinder. Excellent design eye you have.

Thanks


Fix RC3 logic

Add otional field "disable_sending_commands_when_device_off" to codes files
Add possibility to use in temperature field values: string like common IR code and object
{  "on": "dkawmdlkwamdlkawmdlawdlmaw",  "regular": "wadmpp9iunjonj"  }
Add 1948.json - RC3 for Moes UFO-R11

Hello,
thank you for PR. I would like to understand what is the use case you are proposing to implement. If I understand your changes correctly, you are proposing changes to implement very specific Electra IR remote control. It seems, that it differs a lot from how currently supported AC units works.
Could you please describe in detail how Electra IR works and what is the use case behind your PR?
P.S.: I am not too much in favor of implementing features used only on specific type of AC units. This would be nightmare to maintain in longer term. Also I am currently working on preset modes support and most of the changes are exactly at the same place like your PR.

Thank you for an explanation.

That is actually seems like bug. I will check this, I probably know from where this is coming from.
This is normal behavior and most of the AC unit are working in this way. Only one code including all the setting shall be sent.
Clear, thank you

@litinoveweedle

ok
ok

Did not quite understand. Now if I send a command from the off state to cooling, for example, then the command cold + intensity + temperature is sent

But for the air conditioner to accept this command, it must first be turned on. If I add "on" next to the "off" command, it is sent every time the temperature changes. It turns off my air conditioner if it was on and vice versa.
That's why I added commands to turn it on from the off mode and switch the air conditioner already in the on mode. At the same time, I left the option of simply specifying the code in the temperature, and not the dictionary

So let me rephrase your issue. Your device has same command for "on" and "off", therefore if defined as 'on' command it will cause AC to switch off, if already on. The problem here is, that this whole integration only assume states of the device, and therefore to be sure 'on' and 'off' commands are send always.
I could add condition, than when on and off commands are same, than if will not be send if device state is already assume i the required state. Would this solve your issue?

Yes, this will partially solve the problem
If you use this approach, then you need to add a point that when you turn on the AC from the off state, you need to send two commands. First the "on" command, and then the command for a specific temperature state and other things. If already enabled, then yes, only the command to switch the temperature state. And to turn off - only shutdown commands
This will be simpler than my approach, but it seems to me that if the AC enable command already contains the necessary characteristics, then calling two commands instead of one is a crutch :)

Hello, would you please care to open feature request for not sending "off" and "on" command if those are same and device is already in the required assumed state? I would like to implement it, but I would like to be requester and to test it if possible. I will close this PR meanwhile.

Perfect, thank you so much. I will create dedicated branch and let you know when it will be ready for tests.

Hello! I have the same problem and I'm surprised that there aren't more people experiencing it. Usually, the on/off button is the same.
If you want, I can also support you with any necessary tests.
Best regards,


Executing SphincsPlus

A coworker of mine, Becky Powell, has been trying to get SphincsPlus running within Cryptol.  Before Cryptol 2.10, the performance of hash functions has made this goal impossible, but now, she gets some results.  Alas, the results are not correct.  The purpose of this issue is to share the driver files she used so that others can join the debugging process.  The attached files are

SphincsPlus.diff  - removes error reporting that trips up runs
Sphincs128sSHA256simple.cry - driver that selects parameters
SHA256MGF1.cry - pulls appropriate hash function from SuiteB
HMAC.cry - HMAC using SuiteB
SuiteB.cry - Copy of SuiteB used for tests
test_Sphincs.bat - batch file for Cryptol

SphincsPlus.diff.txt
Sphincs128sSHA256simple.cry.txt
SHA256MGF1.cry.txt
HMAC.cry.txt
SuiteB.cry.txt
test_Sphincs.bat.txt

Thanks for pointing this out! When we originally wrote this we had the experience, like you, that we couldn't evaluate it on concrete test vectors, using the interpreter at the time. I'm glad that the new primitives make it possible to evaluate, and I'm sure the results of your initial explorations will help speed up figuring out what's wrong.

Thanks for pointing this out! When we originally wrote this we had the experience, like you, that we couldn't evaluate it on concrete test vectors, using the interpreter at the time. I'm glad that the new primitives make it possible to evaluate, and I'm sure the results of your initial explorations will help speed up figuring out what's wrong.


Publish React router redux

You have updated the package.json for react-router-redux to open the react dependency version which opens apps using this package to upgrade to the react 16.  However, that change has not been published.  Will you please publish these changes?

Yes


Unable to find the robotic manipulation environment.

Thank you for your contribution. I would like to use the robotic manipulation environment (pushing the cube to the location of the red disc) used in the paper- Generalization in Reinforcement Learning by Soft Data Augmentation. Is this environment publicly available for everyone to use?
@nicklashansen Request your help.

Hi, glad to hear that you're interested in our work. The robot environments used for the paper are not made public, but we have open-sourced a similar environment with 4 tasks (including push) here: https://github.com/jangirrishabh/look-closer
It differs in subtle ways (visuals, robot, reward etc.) but is qualitatively similar.


What's the difference with turbo-django?

Hi guys,
I'm wondering, what's the difference of this package, with another package you're working on https://github.com/hotwire-django/turbo-django? Can't django-turbo-response be merged into turbo-django?

Both packages were independently started around the same time, but do very different things.
Turbo-django is mostly concerned with adding reactivity to your models, using django-channels consumers to broadcast changes as turbo-streams: so for example when your model is updated or deleted, a turbo-stream is broadcast via websocket to your frontend. It therefore requires django-channels/ASGI and websockets to work. So for example: you have some kind of news announcement model, and you want to have a notification on the navbar every time a new instance is created. You just define a template and inherit your model from BroadcastMixin to enable this functionality.
Turbo-response is used for returning turbo frames and streams as HTTP responses from normal Django views. For example, you can return a turbo frame or stream response when a user clicks a button, or lazy load pagination results into a turbo frame. It also includes middleware for detecting if the client has requested a stream/frame and respond accordingly in your view. It does have helpers you could use with channels if you wanted, but that's not the main focus, and you don't need to install channels or ASGI to use turbo-response: you can add them iteratively to your current Django project along with the turbo/stimulus client libraries.
There's an open ticket here https://github.com/hotwire-django/turbo-django/issues/19 to merge these two at some point, as they do have some pieces of common functionality, but at present they have a different scope.

Hi Dan,
Thanks for a quick response!
So it looks like this package covers integration with Turbo Drive and Turbo Frames (as in https://turbo.hotwire.dev/), whereas turbo-django covers integration with Turbo Streams.
Yeah, for an average folk it's a bit confusing so would be great to have them all in a single package, or at least, put a note somewhere in README what is what. Because even I, who's been following and working with turbo and turbolinks is wondering what's the difference.
And thank your for your work on this!

Turbo-response also handles streams. Streams have many uses other than with websockets: for example, you can use them in form validation (where you don't want to return a full page response) and you can return multiple streams in a single HTTP response : see the example here.

aha, them it looks like THIS page, is what most people want, but everyone stars ANOTHER package :) Thanks for the great docs, I think you got it all there.


text went AWOL, readding it

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Use original prices for digest

Discogs allows the user to their currency settings and converts the data returned from the API based on this

Changing the SHIPS_FROM env var should utilise the local currencies of listings accordingly as opposed to converting to the user currency setting.

  interface Listing {
    status: string;
    original_price: OriginalPrice;
    ships_from: string;
    original_shipping_price: ShippingPrice;
    price: Price;
    allow_offers: boolean;
    uri: string;
    comments: string;
    seller: Seller;
    sleeve_condition: string;
    shipping_price: ShippingPrice;
    release: Release;
    resource_url: string;
    audio: boolean;
    id: number;
    condition: string;
    posted: string;

    // If the authorized user is the listing owner the listing will include
    // the weight, format_quantity, external_id, and location keys.
    // If the user is authorized, the listing will contain a in_cart boolean
    // field indicating whether or not this listing is in their cart.
    in_cart?: boolean;
    weight?: number;
    external_id?: string;
    location?: string;
    format_quantity?: number;
  }

  interface OriginalPrice {
    converted?: OriginalPrice; // appears in marketplace
    curr_abbr: string;
    formatted: string;
    value: number;
    curr_id: number;
  }

  interface ShippingPrice {
    currency: string;
    value: number;
  }

  interface Price {
    currency: string;
    value: number;
  }

Done in https://github.com/jch254/discogs-market-monitor/commit/d3dd6fddc6200b2373cd0fd9a0adeabf1dfd1b8c


Errors aren't written to the log for failing notebook steps

Fixed in https://github.com/orchest/orchest/commit/5bff670ad45594a9a7dbe9f524ecb07d6f541038


Ch14 - narrow int&flt types

A prelude to arrays, this allows Simple to parse and manipulate narrow integer and float types, rounding/truncating when assigned, and assumed to be probably extended when loaded from a narrow struct field.

Narrowing for
u8 b = 123;
while(b) b = b + 456;// Truncate
return b;

seems not to work

Design questions:

The wording of the chapter README suggests that floats are rounded when truncated or sign-extended. For f32, why not zero-extend to u64?
Why is there flt and f64, int and i64, and u1 and bool? Why is there no u64?

In reviewing the changes made to the parser, I've found these issues. Not all are
from this chapter. I have fixed the marked bugs locally.

[x] The grammar file has not been updated.
[ ] The grammar includes | and ^ bitwise ops, but only & is parsed. Should those be removed from the grammar or should OrNode and XorNode be added?
[x] >> is parsed before >>>, making >>> impossible.
[ ] Assignment is allowed as an expression.
[ ] Issues parsing ? in Parser#type: Forward reference types don't work with
?, because it forces the caller to reparse the type. ? is only used with
structs, but the parser still accepts it otherwise.
[ ] Should the change to Parser#parseStruct, making it return the following
expression, be backported?

I've only reviewed the parser so far.

Not sure what you're asking about for f32 rounding.
flt,f64 and int,i64 and u1,bool are all synonyms.  No u64 because its functionally the same as i64 but hints at some other unsigned difference.  I can be talked into adding it.
Adding Or,Xor.
Fixed parsing >>>
Assignment IS allowed as an expression, on purpose.
Test Chapter13Test.testForwardRef exactly checks this?
struct S1 { S2? s; }
struct S2 { int x; }
return new S1.s=new S2;

These snippets fail, because struct forward references are not handled for declarations.
S x = new S;
struct S { int x; }
return x;

S? x = new S;
struct S { int x; }
return x;

Disallowed (for now).  Quality of implementation issue; we'd have to rework fairly substantially how we compute aliases.
User is forced to move the decl up
struct S { int x; }
S x = new S;
return x;


Improvement for k8s.io/zh-cn/docs/setup/production-environment/tools/kubeadm/create-cluster-kubeadm/

i still can not create a cluster through kubeadm even though i did every step in this page. so what is the meaning of this page?

close


PR for the issue #145: Please add redux-devtools-dock-monitor.

Hi @mxstbr ,
This is the PR for the issue #145: Please add redux-devtools-dock-monitor. I have not figured out how to remove it for the production env. Maybe, you can give some advise on that. Thanks.
Will.

Amazing work, thanks so much, the DevTools are amazing! I think we need to bump the dependency to Redux in the package.json from ^3.0.5 to ^3.1.0 because the new createStore() syntax only works in<EMAIL_ADDRESS>As for the production env, could you try this:
let store;
if (module.hot) {
  store = createStoreWithMiddleware(rootReducer, fromJS({}), DevTools.instrument());
} else {
  store = createStoreWithMiddleware(rootReducer, fromJS({}));
}
reduxRouterMiddleware.listenForReplays(store, (state) => state.get('route').location);

How are we looking here @standino, any update on this?

Could you rebase onto the current state of v3.0.0 and solve the routes merge conflict? Thanks!

Just back from vacation, I will work on that. Thanks for your comments.


Why is the test network different from the training network?

I read the code and find that, the training and the test networks are different in structure.
In particular, in training network, the embedding layers are added after the concatenation of the output of ResNet-101 and FlowNet, as is shown in the following code:
# In function get_train_symbol()
# conv_feat is output of ResNet, warp_conv_feat_1{or 2} is output of FlowNet
concat_embed_data = mx.symbol.Concat(*[conv_feat[0], warp_conv_feat_1, warp_conv_feat_2], dim=0)
embed_output = self.get_embednet(concat_embed_data)

However, in the test network, the structure becomes very different. The embedding layers are added only to the output of ResNet-101. And then the output of the embedding layers are concatenated with the output of FlowNet, as is shown in the following code:
# In function get_feat_symbol()
conv_feat = self.get_resnet_v1(data)
embed_feat = self.get_embednet(conv_feat) # embedding network is added right after ResNet
conv_embed = mx.sym.Concat(conv_feat, embed_feat, name="conv_embed")
... # some codes
# In function get_aggregation_symbol()
# flow is the output of FlowNet, feat_cache is the output of embedding layers
flow_grid = mx.sym.GridGenerator(data=flow, transform_type='warp', name='flow_grid')
conv_feat = mx.sym.BilinearSampler(data=feat_cache, grid=flow_grid, name='warping_feat')
embed_output = mx.symbol.slice_axis(conv_feat, axis=1, begin=1024, end=3072)

Why are the networks so different between training and test?
Moreover, when I'm training the network, the training Acc stays high, like 0.98, but when I test the model on demo images, I get a terrible result.
I clone the project and configure all the data and model paths following the instructions. I tried to continue to train from the model for demo, i.e.
./model/rfcn_fgfa_flownet_vid-0000.params
which is downloaded from the OneDrive url provided in the README.
 But as in groundtruth, there are only 7 planes in each image. This is strange because even if I use the initial checkpoint provided for demo, I get good detection results, with 7 bounding boxes each covering a plane perfectly.
What's wrong with my training?
The only changes I make to the code are the model and data paths, as well as gpu ids.

I think the warping sequence before or after embedding don't matter.
Because the warping operating do not contain any learning parameters.
My personal opinion，hope to help U.

According to my test case, I'm afraid it really matters, because when I build the training network and load the test checkpoint, the model does not converge very well. Moreover, though the warping operation does not contain parameters, it changes the feature map. That is, performing warping first and then embedding, yields very different feature map, compared with embedding first and then warping.

Really? I have train and test the network, it works well......
Could U show your logs?

@AresGao I have updated the issue. I posted the printed logs during training process. The problem is that I cannot get good results when I continue to train from the demo checkpoint provided in the README. The demo checkpoint yields very good results, but when I continue training from this checkpoint, the results become terrible. Though I only trained for 4k iterations, I would believe that, since the initial checkpoint is pretty good, I do not need to train it for that many iterations.
BTW, I'm curious about why we are suggested to train the model from the checkpoint of ResNet-101 and FlowNet, instead of directly train from the demo checkpoint?
I also tried to train from the checkpoint of ResNet-101 and FlowNet for 100k+ iterations, the performance was even worse.
Thank you for your patience and kindness in helping me!

That's really strange, I  train from the checkpoint of ResNet-101 and FlowNet for 100k+ iterations, the performance was even better, here is test results.
motion [0.0 1.0], area [0.0 0.0 100000.0 100000.0]Mean<EMAIL_ADDRESS>= 0.7648motion [0.0 0.7], area [0.0 0.0 100000.0 100000.0]Mean<EMAIL_ADDRESS>= 0.5727motion [0.7 0.9], area [0.0 0.0 100000.0 100000.0]Mean<EMAIL_ADDRESS>= 0.7515motion [0.9 1.0], area [0.0 0.0 100000.0 100000.0]Mean<EMAIL_ADDRESS>= 0.8444.

@AresGao Can you help me ?
I have a problem about "sh ./init.sh".
Traceback (most recent call last):
File "setup_linux.py", line 63, in
CUDA = locate_cuda()
File "setup_linux.py", line 58, in locate_cuda
for k, v in cudaconfig.iteritems():
AttributeError: 'dict' object has no attribute 'iteritems'
If youIf you can reply me in time, I will be very grateful.

I use the latest version of mxnet @FCInter

@txf201604
the func  locate_cuda() finds where your cuda installed, I thought u might check your cuda location
def locate_cuda():
    """Locate the CUDA environment on the system
    Returns a dict with keys 'home', 'nvcc', 'include', and 'lib64'
    and values giving the absolute path to each directory.
    Starts by looking for the CUDAHOME env variable. If not found, everything
    is based on finding 'nvcc' in the PATH.
    """

First of all, I would like to express my sincere gratitude to you for
replying to my email. I have already solved the problem of "sh ./init.sh".
It is due to the python version. I installed python2.7 to solve the
problem, but I have a new problem. I have not solved it correctly. . The
problem is that when I modified the "USE_CUDA = 1 USE_CUDA_PATH =
/usr/local/cudamxnet" in the config.mk under make, then the mxnet GPU
compilation has a problem. As shown below.
"In file included from src/operator/tensor/././sort_op.h:85:0,
from src/operator/tensor/./indexing_op.h:24,
from src/operator/tensor/indexing_op.cu:8:
src/operator/tensor/./././sort_op-inl.cuh:15:44: fatal error:
cub/device/device_radix_sort.cuh: No such file or directory
#include <cub/device/device_radix_sort.cuh>
^
compilation terminated.
Makefile:211: recipe for target
'build/src/operator/tensor/indexing_op_gpu.o' failed
make: *** [build/src/operator/tensor/indexing_op_gpu.o] Error 1
make: *** Waiting for unfinished jobs...."
Mxnet cpu version I can compile successfully, if you can not support the
GPU, when running "demo.py" will report the following error:
"Stack trace returned 10 entries:
[bt] (0)
/home/user/anaconda3/envs/py2.7/lib/python2.7/site-packages/mxnet-0.10.0-py2.7.egg/mxnet/libmxnet.so(_ZN4dmlc15LogMessageFatalD1Ev+0x3c)
[0x7febb91c2ebc]
[bt] (1)
/home/user/anaconda3/envs/py2.7/lib/python2.7/site-packages/mxnet-0.10.0-py2.7.egg/mxnet/libmxnet.so(MXImperativeInvoke+0x8c9)
[0x7febb9f6d6e9]
[bt] (2)
/home/user/anaconda3/envs/py2.7/lib/python2.7/lib-dynload/../../libffi.so.6(ffi_call_unix64+0x4c)
[0x7feb6c623ec0]
[bt] (3)
/home/user/anaconda3/envs/py2.7/lib/python2.7/lib-dynload/../../libffi.so.6(ffi_call+0x22d)
[0x7feb6c62387d]
[bt] (4)
/home/user/anaconda3/envs/py2.7/lib/python2.7/lib-dynload/_ctypes.so(_ctypes_callproc+0x4de)
[0x7feb6c83a8de]
[bt] (5)
/home/user/anaconda3/envs/py2.7/lib/python2.7/lib-dynload/_ctypes.so(+0x9b31)
[0x7feb6c830b31]
[bt] (6)
/home/user/anaconda3/envs/py2.7/bin/../lib/libpython2.7.so.1.0(PyObject_Call+0x43)
[0x7febc057b973]
[bt] (7)
/home/user/anaconda3/envs/py2.7/bin/../lib/libpython2.7.so.1.0(PyEval_EvalFrameEx+0x3bb9)
[0x7febc0611d49]
[bt] (8)
/home/user/anaconda3/envs/py2.7/bin/../lib/libpython2.7.so.1.0(PyEval_EvalCodeEx+0x7e9)
[0x7febc06176c9]
[bt] (9)
/home/user/anaconda3/envs/py2.7/bin/../lib/libpython2.7.so.1.0(PyEval_EvalFrameEx+0x6a08)
[0x7febc0614b98]
Traceback (most recent call last):
File "/home/user/tmp/Flow-Guided-Feature-Aggregation/fgfa_rfcn/demo.py",
line 257, in
main()
File "/home/user/tmp/Flow-Guided-Feature-Aggregation/fgfa_rfcn/demo.py",
line 155, in main
arg_params=arg_params, aux_params=aux_params)
File
"/home/user/tmp/Flow-Guided-Feature-Aggregation/fgfa_rfcn/core/tester.py",
line 37, in init
self._mod.bind(provide_data, provide_label, for_training=False)"
File
"/home/user/tmp/Flow-Guided-Feature-Aggregation/fgfa_rfcn/core/module.py",
line 844, in bind
for_training, inputs_need_grad, force_rebind=False, shared_module=None)
File
"/home/user/tmp/Flow-Guided-Feature-Aggregation/fgfa_rfcn/core/module.py",
line 401, in bind
state_names=self._state_names)
File
"/home/user/tmp/Flow-Guided-Feature-Aggregation/fgfa_rfcn/core/DataParallelExecutorGroup.py",
line 191, in init
self.bind_exec(data_shapes, label_shapes, shared_group)
File
"/home/user/tmp/Flow-Guided-Feature-Aggregation/fgfa_rfcn/core/DataParallelExecutorGroup.py",
line 277, in bind_exec
shared_group))
File
"/home/user/tmp/Flow-Guided-Feature-Aggregation/fgfa_rfcn/core/DataParallelExecutorGroup.py",
line 550, in _bind_ith_exec
context, self.logger)
File
"/home/user/tmp/Flow-Guided-Feature-Aggregation/fgfa_rfcn/core/DataParallelExecutorGroup.py",
line 528, in _get_or_reshape
arg_arr = nd.zeros(arg_shape, context, dtype=arg_type)
File
"/home/user/anaconda3/envs/py2.7/lib/python2.7/site-packages/mxnet-0.10.0-py2.7.egg/mxnet/ndarray.py",
line 1003, in zeros
return _internal._zeros(shape=shape, ctx=ctx, dtype=dtype)
File "", line 15, in _zeros
File
"/home/user/anaconda3/envs/py2.7/lib/python2.7/site-packages/mxnet-0.10.0-py2.7.egg/mxnet/_ctypes/ndarray.py",
line 72, in _imperative_invoke
c_array(ctypes.c_char_p, [c_str(str(val)) for val in vals])))
File
"/home/user/anaconda3/envs/py2.7/lib/python2.7/site-packages/mxnet-0.10.0-py2.7.egg/mxnet/base.py",
line 84, in check_call
raise MXNetError(py_str(_LIB.MXGetLastError()))
mxnet.base.MXNetError: [10:59:41] src/c_api/c_api_ndarray.cc:392: Operator
_zeros cannot be run; requires at least one of FCompute,
NDArrayFunction, FCreateOperator be registered
高志华<EMAIL_ADDRESS>于2018年11月13日周二 下午6:33写道：

@txf201604 https://github.com/txf201604
the func locate_cuda() finds where your cuda installed, I thought u might
check your cuda location
def locate_cuda():
"""Locate the CUDA environment on the system
Returns a dict with keys 'home', 'nvcc', 'include', and 'lib64'
and values giving the absolute path to each directory.
Starts by looking for the CUDAHOME env variable. If not found, everything
is based on finding 'nvcc' in the PATH.
"""
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/msracver/Flow-Guided-Feature-Aggregation/issues/37#issuecomment-438217080,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Aq0WQqOYkloNmeIsyVSCX5Gh-ceZPfykks5uuqAHgaJpZM4YSTVH
.

Hello
First of all, I would like to express my sincere gratitude to you for
replying to my email. I have already solved the problem of "sh ./init.sh".
It is due to the python version. I installed python2.7 to solve the
problem, but I have a new problem. I have not solved it correctly. . The
problem is that when I modified the "USE_CUDA = 1 USE_CUDA_PATH =
/usr/local/cudamxnet" in the config.mk under make, then the mxnet GPU
compilation has a problem. As shown below.
"In file included from src/operator/tensor/././sort_op.h:85:0,
from src/operator/tensor/./indexing_op.h:24,
from src/operator/tensor/indexing_op.cu:8:
src/operator/tensor/./././sort_op-inl.cuh:15:44: fatal error:
cub/device/device_radix_sort.cuh: No such file or directory
#include <cub/device/device_radix_sort.cuh>
^
compilation terminated.
Makefile:211: recipe for target
'build/src/operator/tensor/indexing_op_gpu.o' failed
make: *** [build/src/operator/tensor/indexing_op_gpu.o] Error 1
make: *** Waiting for unfinished jobs...."
Mxnet cpu version I can compile successfully, if you can not support the
GPU, when running "demo.py" will report the following error:
"Stack trace returned 10 entries:
[bt] (0)
/home/user/anaconda3/envs/py2.7/lib/python2.7/site-packages/mxnet-0.10.0-py2.7.egg/mxnet/libmxnet.so(_ZN4dmlc15LogMessageFatalD1Ev+0x3c)
[0x7febb91c2ebc]
[bt] (1)
/home/user/anaconda3/envs/py2.7/lib/python2.7/site-packages/mxnet-0.10.0-py2.7.egg/mxnet/libmxnet.so(MXImperativeInvoke+0x8c9)
[0x7febb9f6d6e9]
[bt] (2)
/home/user/anaconda3/envs/py2.7/lib/python2.7/lib-dynload/../../libffi.so.6(ffi_call_unix64+0x4c)
[0x7feb6c623ec0]
[bt] (3)
/home/user/anaconda3/envs/py2.7/lib/python2.7/lib-dynload/../../libffi.so.6(ffi_call+0x22d)
[0x7feb6c62387d]
[bt] (4)
/home/user/anaconda3/envs/py2.7/lib/python2.7/lib-dynload/_ctypes.so(_ctypes_callproc+0x4de)
[0x7feb6c83a8de]
[bt] (5)
/home/user/anaconda3/envs/py2.7/lib/python2.7/lib-dynload/_ctypes.so(+0x9b31)
[0x7feb6c830b31]
[bt] (6)
/home/user/anaconda3/envs/py2.7/bin/../lib/libpython2.7.so.1.0(PyObject_Call+0x43)
[0x7febc057b973]
[bt] (7)
/home/user/anaconda3/envs/py2.7/bin/../lib/libpython2.7.so.1.0(PyEval_EvalFrameEx+0x3bb9)
[0x7febc0611d49]
[bt] (8)
/home/user/anaconda3/envs/py2.7/bin/../lib/libpython2.7.so.1.0(PyEval_EvalCodeEx+0x7e9)
[0x7febc06176c9]
[bt] (9)
/home/user/anaconda3/envs/py2.7/bin/../lib/libpython2.7.so.1.0(PyEval_EvalFrameEx+0x6a08)
[0x7febc0614b98]
Traceback (most recent call last):
File "/home/user/tmp/Flow-Guided-Feature-Aggregation/fgfa_rfcn/demo.py",
line 257, in
main()
File "/home/user/tmp/Flow-Guided-Feature-Aggregation/fgfa_rfcn/demo.py",
line 155, in main
arg_params=arg_params, aux_params=aux_params)
File
"/home/user/tmp/Flow-Guided-Feature-Aggregation/fgfa_rfcn/core/tester.py",
line 37, in init
self._mod.bind(provide_data, provide_label, for_training=False)"
File
"/home/user/tmp/Flow-Guided-Feature-Aggregation/fgfa_rfcn/core/module.py",
line 844, in bind
for_training, inputs_need_grad, force_rebind=False, shared_module=None)
File
"/home/user/tmp/Flow-Guided-Feature-Aggregation/fgfa_rfcn/core/module.py",
line 401, in bind
state_names=self._state_names)
File
"/home/user/tmp/Flow-Guided-Feature-Aggregation/fgfa_rfcn/core/DataParallelExecutorGroup.py",
line 191, in init
self.bind_exec(data_shapes, label_shapes, shared_group)
File
"/home/user/tmp/Flow-Guided-Feature-Aggregation/fgfa_rfcn/core/DataParallelExecutorGroup.py",
line 277, in bind_exec
shared_group))
File
"/home/user/tmp/Flow-Guided-Feature-Aggregation/fgfa_rfcn/core/DataParallelExecutorGroup.py",
line 550, in _bind_ith_exec
context, self.logger)
File
"/home/user/tmp/Flow-Guided-Feature-Aggregation/fgfa_rfcn/core/DataParallelExecutorGroup.py",
line 528, in _get_or_reshape
arg_arr = nd.zeros(arg_shape, context, dtype=arg_type)
File
"/home/user/anaconda3/envs/py2.7/lib/python2.7/site-packages/mxnet-0.10.0-py2.7.egg/mxnet/ndarray.py",
line 1003, in zeros
return _internal._zeros(shape=shape, ctx=ctx, dtype=dtype)
File "", line 15, in _zeros
File
"/home/user/anaconda3/envs/py2.7/lib/python2.7/site-packages/mxnet-0.10.0-py2.7.egg/mxnet/_ctypes/ndarray.py",
line 72, in _imperative_invoke
c_array(ctypes.c_char_p, [c_str(str(val)) for val in vals])))
File
"/home/user/anaconda3/envs/py2.7/lib/python2.7/site-packages/mxnet-0.10.0-py2.7.egg/mxnet/base.py",
line 84, in check_call
raise MXNetError(py_str(_LIB.MXGetLastError()))
mxnet.base.MXNetError: [10:59:41] src/c_api/c_api_ndarray.cc:392: Operator
_zeros cannot be run; requires at least one of FCompute,
NDArrayFunction, FCreateOperator be registered
FCInter<EMAIL_ADDRESS>于2018年11月13日周二 下午6:28写道：

@AresGao https://github.com/AresGao What version of mxnet are you
using? I was wondering if it's caused by the version, since I got a bug
because of the wrong version I was using.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/msracver/Flow-Guided-Feature-Aggregation/issues/37#issuecomment-438215491,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Aq0WQpaPN8JFZjelrLU5ECPgt79mOR9wks5uup7JgaJpZM4YSTVH
.

@AresGao Finally I got good results after training for 2 complete epoch!!!
I just have one last question.  I find that when saving checkpoint at the end of each epoch, the following codes are used to create two new weights, namely rfcn_bbox_weight_test and rfcn_bbox_bias_test.
arg['rfcn_bbox_weight_test'] = weight * mx.nd.repeat(mx.nd.array(stds), repeats=repeat).reshape((bias.shape[0], 1, 1, 1))
arg['rfcn_bbox_bias_test'] = arg['rfcn_bbox_bias'] * mx.nd.repeat(mx.nd.array(stds), repeats=repeat) + mx.nd.repeat(mx.nd.array(means), repeats=repeat)

Why do we need to do this?
I have tested that if I do not do this, the checkpoint will make terrible predictions on the test data. This is also the reason why my previous predictions are bad, though the training loss looked good.
Thank you!

Hi, @AresGao  @FCInter  @YuwenXiong  , I tried the training and inference of the code. I used 4 gpus and all the setting is not changed, and the final mAP is 75.78. I am confused about the drop of mAP. Do you change any setting or do you have some advice on my case?

That's really strange, I train from the checkpoint of ResNet-101 and FlowNet for 100k+ iterations, the performance was even better, here is test results.
motion [0.0 1.0], area [0.0 0.0 100000.0 100000.0]Mean<EMAIL_ADDRESS>= 0.7648motion [0.0 0.7], area [0.0 0.0 100000.0 100000.0]Mean<EMAIL_ADDRESS>= 0.5727motion [0.7 0.9], area [0.0 0.0 100000.0 100000.0]Mean<EMAIL_ADDRESS>= 0.7515motion [0.9 1.0], area [0.0 0.0 100000.0 100000.0]Mean<EMAIL_ADDRESS>= 0.8444.

@AresGao Hi~ I just have one GPU(1080TI), and only get mAP=0.7389 test by default setting.
How can you get better mAP? Can you tell us your setting detail?
Such as epochs, min_diff/max_diff, lr,  gpus, test key_frame and so on...
Thank you!

That's really strange, I train from the checkpoint of ResNet-101 and FlowNet for 100k+ iterations, the performance was even better, here is test results.
motion [0.0 1.0], area [0.0 0.0 100000.0 100000.0]Mean<EMAIL_ADDRESS>= 0.7648motion [0.0 0.7], area [0.0 0.0 100000.0 100000.0]Mean<EMAIL_ADDRESS>= 0.5727motion [0.7 0.9], area [0.0 0.0 100000.0 100000.0]Mean<EMAIL_ADDRESS>= 0.7515motion [0.9 1.0], area [0.0 0.0 100000.0 100000.0]Mean<EMAIL_ADDRESS>= 0.8444.

hi,i want to know how many epochs exactly you set to train the model, i train this model  for
2 epochs,and get a result aboult 73.16% ,and why paper always talk about iterration not epochs,
i wish to hearing from you ,thank you

@AresGao
hi,i want to know how many epochs exactly you set to train the model, i train this model for
2 epochs,and get a result aboult 73.16% ,and why paper always talk about iterration not epochs,
i wish to hearing from you ,thank you

@AresGao Finally I got good results after training for 2 complete epoch!!!
I just have one last question. I find that when saving checkpoint at the end of each epoch, the following codes are used to create two new weights, namely rfcn_bbox_weight_test and rfcn_bbox_bias_test.
arg['rfcn_bbox_weight_test'] = weight * mx.nd.repeat(mx.nd.array(stds), repeats=repeat).reshape((bias.shape[0], 1, 1, 1))
arg['rfcn_bbox_bias_test'] = arg['rfcn_bbox_bias'] * mx.nd.repeat(mx.nd.array(stds), repeats=repeat) + mx.nd.repeat(mx.nd.array(means), repeats=repeat)

Why do we need to do this?
I have tested that if I do not do this, the checkpoint will make terrible predictions on the test data. This is also the reason why my previous predictions are bad, though the training loss looked good.
Thank you!

Hi, @FCInter Do you know why there is arg['rfcn_bbox_weight_test'] here?
I try to change detection network to light-head, so I do not keep the arg['rfcn_bbox_weight_test'] .
but I get a bad result. Do you know what the meaning of    arg['rfcn_bbox_weight_test'] is?


✨ Update master reference to main/controlplane and BMO reference to main branch

/test-v1b1-integration

/test-v1b1-e2e
/test-v1b1-centos-e2e
@furkatgofurov7 Do you think we need e2e v1a5 test on this PR?

@furkatgofurov7 Do you think we need e2e v1a5 test on this PR?

no, you should not run v1a5 e2e on the main branch, but only release-0.5. We have to cherry pick this one to release-0.5 once it is merged and trigger v1a5 e2e tests there.

/test-v1b1-centos-e2e

/test-v1b1-centos-e2e

/lgtm


make the dictionary db as a real singleton

when get a new instance of a MemoryAdapter which have no data in cache db,
it will create a new dictionary. 'cause empty {} is a False value.
fix it and add the test case.

Current coverage is 100.00%

Merging #5 into master will not affect coverage as of 9b405e2

@@            master      #5   diff @@
======================================
  Files            1       1
  Stmts           45      50     +5
  Branches         0       0
  Methods          0       0
======================================
+ Hit             45      50     +5
  Partial          0       0
  Missed           0       0

Review entire Coverage Diff as of 9b405e2

Powered by Codecov. Updated on successful CI builds.

assertIs is not support in python2.6.
use assertEqual with id instead

nice work，thx…


Fix weird thing you did :smile:

:smile: Yeah here is the fix.

Thank you :)

Thank you for your solution to my problem, but I have closed this fix because after you sent me the solution and added it to my website, your fix was then no longer needed since it already helped me :+1:


fix: typo spelling grammar

fixing typo spelling grammar and replace to correct words with reference from merriam webster

[x] User visible changes (including notable bug fixes) are documented in whats-new.rst
[x] Fix typo

thank you sir @max-sixty


Lane arrow super-small on some resolutions

Biffa reports super-small UI on the lane arrows popup:

That's on STABLE release, but I assume similar on LABS and ALPHA.
I've not seen this before; it might be something to do with screen resolution or gfx drivers?
As we already plan major overhaul of lane arrow UI (see #391) I suggest we do that rather than spend time on the old UI...?
@kvakvs What is the current plans for #391?

I've see that. Biffa started streaming in 4k, and that UI window is pixel-sized not scaled to the screen %.
I already have a working prototype of GUI.
The creation API makes me "poop in feer" i need to focus once again and make the API pretty, and then we can begin replacing game windows one by one with the new UI, which is capable of being scaled to screen % or parent %.
The lane arrow overhaul has no GUI at all (it should because the user will have no idea what each mode means).


rebirth gameplay notefield changes get reset when transitioning song while playing playlist as course

need to check til death and see if this applies there too but this is probably rebirth only because of the weird way i redid some of that stuff. this likely only affects the notefield sizing and position

f012bbadd44dd01339d1ac2d8a2f28c26c69842c


plugin:disable -> Permission Denied

I'm getting the following error when I try to disable a plugin:
$ sudo su
$ dokku plugin:disable logging-supervisord
rm: cannot remove ‘/var/lib/dokku/plugins/enabled/logging-supervisord’: Permission denied

The link mentioned (and all other links in that directory) are owned by root, and I'm running dokku as root, so dokku must be changing it's user (right?).
FWIW, I was able to remove the plugin with
$ dokku plugin:uninstall logging-supervisord
-----> Plugin logging-supervisord uninstalled

The link is probably owned by root but the dokku user is trying to remove it. Interesting.

I can't recreate this in master, v0.4.0, v0.4.1....
root@dokku:~/dokku# dokku plugin
  00_dokku-standard    0.4.0 enabled    dokku core standard plugin
  20_events            0.4.0 enabled    dokku core events logging plugin
  apps                 0.4.0 enabled    dokku core apps plugin
  backup               0.4.0 enabled    dokku core backup plugin
  build-env            0.4.0 enabled    dokku core build-env plugin
  certs                0.4.0 enabled    dokku core certificate management plugin
  checks               0.4.0 enabled    dokku core checks plugin
  common               0.4.0 enabled    dokku core common plugin
  config               0.4.0 enabled    dokku core config plugin
  docker-options       0.4.0 enabled    dokku core docker-options plugin
  domains              0.4.0 enabled    dokku core domains plugin
  enter                0.4.0 enabled    dokku core enter plugin
  git                  0.4.0 enabled    dokku core git plugin
  logs                 0.4.0 enabled    dokku core logs plugin
  nginx-vhosts         0.4.0 enabled    dokku core nginx-vhosts plugin
  plugin               0.4.0 enabled    dokku core plugin plugin
  ps                   0.4.0 enabled    dokku core ps plugin
  shell                0.4.0 enabled    dokku core shell plugin
  tags                 0.4.0 enabled    dokku core tags plugin
  tar                  0.4.0 enabled    dokku core tar plugin
root@dokku:~/dokku# dokku plugin:install https://github.com/sehrope/dokku-logging-supervisord
-----> Cloning plugin repo https://github.com/sehrope/dokku-logging-supervisord to /var/lib/dokku/plugins/available/logging-supervisord
Cloning into 'logging-supervisord'...
remote: Counting objects: 158, done.
remote: Total 158 (delta 0), reused 0 (delta 0), pack-reused 158
Receiving objects: 100% (158/158), 26.40 KiB | 0 bytes/s, done.
Resolving deltas: 100% (83/83), done.
Checking connectivity... done.
-----> Plugin logging-supervisord enabled
root@dokku:~/dokku# dokku plugin
  00_dokku-standard    0.4.0 enabled    dokku core standard plugin
  20_events            0.4.0 enabled    dokku core events logging plugin
  apps                 0.4.0 enabled    dokku core apps plugin
  backup               0.4.0 enabled    dokku core backup plugin
  build-env            0.4.0 enabled    dokku core build-env plugin
  certs                0.4.0 enabled    dokku core certificate management plugin
  checks               0.4.0 enabled    dokku core checks plugin
  common               0.4.0 enabled    dokku core common plugin
  config               0.4.0 enabled    dokku core config plugin
  docker-options       0.4.0 enabled    dokku core docker-options plugin
  domains              0.4.0 enabled    dokku core domains plugin
  enter                0.4.0 enabled    dokku core enter plugin
  git                  0.4.0 enabled    dokku core git plugin
  logging-supervisord  0.1.0 enabled    A plugin for dokku that injects supervisord
  logs                 0.4.0 enabled    dokku core logs plugin
  nginx-vhosts         0.4.0 enabled    dokku core nginx-vhosts plugin
  plugin               0.4.0 enabled    dokku core plugin plugin
  ps                   0.4.0 enabled    dokku core ps plugin
  shell                0.4.0 enabled    dokku core shell plugin
  tags                 0.4.0 enabled    dokku core tags plugin
  tar                  0.4.0 enabled    dokku core tar plugin
root@dokku:~/dokku# dokku plugin:disable logging-supervisord
-----> Plugin logging-supervisord disabled

Can you compare the following command and output in your env?
root@dokku:~/dokku# ls -lad /var/lib/dokku/plugins/available/logging-supervisord /var/lib/dokku/plugins/enabled/logging-supervisord
drwxr-xr-x 4 root  root  4096 Oct 13 19:20 /var/lib/dokku/plugins/available/logging-supervisord
lrwxrwxrwx 1 dokku dokku   52 Oct 13 19:23 /var/lib/dokku/plugins/enabled/logging-supervisord -> /var/lib/dokku/plugins/available/logging-supervisord

@michaelshobbs
$ ls -lad /var/lib/dokku/plugins/available/logging-supervisord /var/lib/dokku/plugins/enabled/logging-supervisord
drwxr-xr-x 4 root root 4096 Oct 14 02:06 /var/lib/dokku/plugins/available/logging-supervisord
lrwxrwxrwx 1 root root   52 Oct 14 02:06 /var/lib/dokku/plugins/enabled/logging-supervisord -> /var/lib/dokku/plugins/available/logging-supervisord

No. Somehow root owns the link in enabled as @josegonzalez mentioned. Not sure how that ended up that way unfortunately. You could chown it and then it would work.

I'm on this issue too. Everything inside /var/lib/dokku/plugins/available/ is owned by root.

I couldn't immediately reproduce this tonight, @ignlg @spalger can you give steps to reproduce?

@u2mejc I did the usual steps:
In a brand new Ubuntu 14.04 LTS server, as root, I went through the bootstrap.sh setup, apt install ..., etc. Then dokku plugin:install mariadb....
I've made 3 servers and every of them had this issue.
Folders inside /var/dokku/services are owned by dokku. Everything else at /var/dokku/, even folders created with dokku plugin:install, is owned by root (me). Example:
enabled: lrwxrwxrwx 1 root root   40 Nov  4 16:47 mariadb -> /var/lib/dokku/plugins/available/mariadb/
available: drwxr-xr-x 4 root root 4096 Nov  6 13:59 mariadb/

Ah ok. I see the problem. My installs are installing from source and not using the .deb method. @josegonzalez thoughts on how to make this work in the .deb installation method?

We could probably chown the directory in the postinst hook. Does that work?

yeah make copyfiles does this
https://github.com/progrium/dokku/blob/v0.4.4/Makefile#L63

Probably can do it here.


Separate compiled code for remaining type defs

[x] This contribution adheres to CONTRIBUTING.md.

What does this Pull Request accomplish?
Separate compiled code from source for type defs that do not have the option selected.
Why should this Pull Request be merged?
Several unit tests are failing after the check for compiled code in type defs was added to the test tools.
What testing has been done?
None

This build won't complete until dcafbuild04 is back online.


What is the cave_app documentation and structure section at top of main readme.

Create an example app and run run it to capture the idea of the cave_app and its features.
This should be added to add to the main README.md in the root of cave_app. Then create simple explanations of what the cave app is and the basics for how it works to go along with these screenshots.

Added a bit of final cleanup here:
f8955d2c0c9cc4e91c64c3a4e76606ad171e28ce
eb3bee2202c37826f39168e4bb876c417f46f6a7


Demonstrate Azure AD Based Authentication & Authorization in API

Remove Mock Code
Reference Secured Secrets
Make Real Call to Azure AD
Create Integration Tests to Hard-Code Document Claims, Token Validation, etc.

Oath MVP


Fixed issue #2581

When the users clicks a button on the edge of the page like in the image below (client x = 0, the problem only happens on the white button on the image), the ripple effect stops working.
The error happens in line 105 of ripple.js, where it tries to set a variable "clientX" as "event.touches[0].clientX", but "event.touches" is undefined (it's a mouse click at x = 0!).
Tested on Google Chrome.

Garbee pulled content in from issue to straighten things up. No need for doing an issue just to turn around and do a PR as well.

I signed it!

This setup seems to me like it should never naturally occur when implementing Material Design. You should have padding around inputs in just about every case they get used.
Why should we include a "fix" for something that isn't occurring within the given goal of the project?

Yes, it's very unlikely to ever happen in a real world scenario, but the fact is -there is- a problem with the code. I just addressed it.
It's a very minor piece of code to solve a very minor issue, I don't see why it shouldn't be fixed.

It shouldn't be fixed since the goal is to keep the library as lite as we can. If this is fixing a use-case that doesn't appear naturally in Material Design, then it isn't something we should address internally. It falls into a custom design space that developers are responsible for.
:-1: to inclusion from me.
cc @surma, @sgomes, and @addyosmani for sanity check please.

Hello there! We're currently doing some housecleaning on the repository to prepare for the big changes to v2, and part of this is to close the mdl-1.1 and mdl-1.2 branches, and move all 1.1 and 1.2 PRs to the mdl-1.x branch. Since it's not possible to target PRs at a new branch, we're closing this PR and asking you to reopen against mdl-1.x if you think it's still valid.
Thank you!


fixed  '$kebabName' (T_VARIABLE), expecting ']'

i don't know it was working with my local change :(

Thank you @iMokhles !
Happens to the best of us 😞 It's my fault too for not double-checking - Travis CI told me the build was failing but since so many times before it had false positives, and the change was so small, I ignored it and said I would take a look tomorrow. I though it's the boy who cried wolf. And it was - but it was that one time it really was the wolf 😄
Thanks for moving so fast to fix it! 🥳
To anyone who opens the issue because of the error code:

it's been fixed in 3.1.3, so a composer install --dev backpack/generators should get the proper (fixed) version now;
if not, please do composer install --dev backpack/generators:"^3.1.3", that should force composer to pick up at least the fixed version;
very sorry you had this bad experience; I really am;
I want to make the experience better, so I'd give you a cookie, but... the EU won't let us...

I want to make the experience better, so I'd give you a cookie, but... the EU won't let us...

This is poetry. Someone write to Romania got talent. \o


add route api test

Fix https://github.com/open-cluster-management/backlog/issues/17505
Fix https://github.com/open-cluster-management/backlog/issues/17504
Signed-off-by: Song Song Li<EMAIL_ADDRESS>

/test test-e2e

/test test-e2e

/test test-e2e

/test test-e2e

/unhold

/cherrypick release-2.4


improve examples tests, document

@whoburg, this is ready for review

Code review complete, looks awesome, merge at will.


[3pt]  Recipe Details and Toggle Button

Display recipe details
Implement toggle button for making recipe public or private
Allow the owner to add new food if the recipe is public or owned by the user
Handle N+1 queries in recipe details
Write tests for recipe details and toggle button


Update Cals dataset

This update adds source information to all entries, and makes this work with lexibank 1.1.1,
NOTE: The ds.align_cognates() command is broken as the cognate ids are non-numeric. See traceback below. Any ideas how to fix? do we need to have numeric cog ids (I know a lot of datasets will have A...Z or 1a..1b.. etc).
Traceback (most recent call last):
  File "/Users/simon/.pyenv/versions/3.7.0/lib/python3.7/site-packages/lingpy-2.6.4-py3.7.egg/lingpy/align/sca.py", line 661, in add_alignments
    modify_ref=modify_ref)
  File "/Users/simon/.pyenv/versions/3.7.0/lib/python3.7/site-packages/lingpy-2.6.4-py3.7.egg/lingpy/basic/wordlist.py", line 480, in get_etymdict
    cogid = f(cog)
ValueError: invalid literal for int() with base 10: 'i-a'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/Users/simon/.pyenv/versions/3.7.0/bin/lexibank", line 11, in <module>
    load_entry_point('pylexibank', 'console_scripts', 'lexibank')()
  File "/Users/simon/.pyenv/versions/3.7.0/lib/python3.7/site-packages/pylexibank-1.1.1-py3.7.egg/pylexibank/__main__.py", line 139, in main
    sys.exit(parser.main())
  File "/Users/simon/.pyenv/versions/3.7.0/lib/python3.7/site-packages/clldutils-2.6.3-py3.7.egg/clldutils/clilib.py", line 110, in main
    catch_all=catch_all, parsed_args=args)
  File "/Users/simon/.pyenv/versions/3.7.0/lib/python3.7/site-packages/clldutils-2.6.3-py3.7.egg/clldutils/clilib.py", line 82, in main
    self.commands[args.command](args)
  File "/Users/simon/.pyenv/versions/3.7.0/lib/python3.7/site-packages/clldutils-2.6.3-py3.7.egg/clldutils/clilib.py", line 35, in __call__
    return self.func(args)
  File "/Users/simon/.pyenv/versions/3.7.0/lib/python3.7/site-packages/pylexibank-1.1.1-py3.7.egg/pylexibank/commands/misc.py", line 148, in makecldf
    with_dataset(args, Dataset._install)
  File "/Users/simon/.pyenv/versions/3.7.0/lib/python3.7/site-packages/pylexibank-1.1.1-py3.7.egg/pylexibank/commands/util.py", line 28, in with_dataset
    func(get_dataset(args, dataset.id), **vars(args))
  File "/Users/simon/.pyenv/versions/3.7.0/lib/python3.7/site-packages/pylexibank-1.1.1-py3.7.egg/pylexibank/dataset.py", line 376, in _install
    if self.cmd_install(**kw) == NOOP:
  File "/Users/simon/projects/lexibank2018/cals/lexibank_cals.py", line 88, in cmd_install
    ds.align_cognates()
  File "/Users/simon/.pyenv/versions/3.7.0/lib/python3.7/site-packages/pylexibank-1.1.1-py3.7.egg/pylexibank/cldf.py", line 253, in align_cognates
    method=method)
  File "/Users/simon/.pyenv/versions/3.7.0/lib/python3.7/site-packages/pylexibank-1.1.1-py3.7.egg/pylexibank/lingpy_util.py", line 96, in iter_alignments
    segments=column.lower())
  File "/Users/simon/.pyenv/versions/3.7.0/lib/python3.7/site-packages/lingpy-2.6.4-py3.7.egg/lingpy/align/sca.py", line 627, in __init__
    split_on_tones=split_on_tones)
  File "/Users/simon/.pyenv/versions/3.7.0/lib/python3.7/site-packages/lingpy-2.6.4-py3.7.egg/lingpy/align/sca.py", line 663, in add_alignments
    raise ValueError("Did not find a cognate ID in the input file.")
ValueError: Did not find a cognate ID in the input file.

oh, this is fixes #3, and corrects the citation too.

looks okay to me, and we don't need alignments for the time being, I'd say.


Check licence drive teste

Hi bro It is possible to integrate a function to check if the user is allowed to drive thanks

https://github.com/Kyominii/Cops_FiveM/issues/41


a lot of wasted render cycles according to react-addons-perf

I used https://reactjs.org/docs/perf.html#printwasted at the start of my admin-on-rest based application and after a short navigation of 10 or so steps. I printed the results of wasted render cycles that state wasn't even changed and it seems that there is a lot of room for improvement. Any thoughts on this?

Thanks!
Admin-on-rest version: 1.3.4
react-addons-perf": "^15.4.2

We'll look into it

react-addons-perf was discontinued and does not handle React 16 (cf https://reactjs.org/docs/perf.html#printwasted).
We do regular profiling sessions using the Chrome DevTools, and fix the most obvious rerenders.


Fix double upload bug and improve test

In our deployment we have been encountering a bug that happens when:

a package file is uploaded through the /upload/ route.
a package file with the same package version inside and the same file name, but different hashes is uploaded again.

We observe that in the second upload, we get a 409, which is good. However, we also find that the binary package file is still updated on the server, even though the http request was rejected. The repodata is not updated, as expected. This means that we get hash mismatch errors because the incorrectly updated binary does not agree with the correct hashes for the original file in the repodata.
I think the problem is here, where we call pkgstore.add_package_async before the try/except block that ultimately results in the 409.
During debugging I found that the other upload route is also affected.
Changes in this PR:

Extended the existing duplicate upload test:

we now use files that have the same name. This is crucial to trigger the bug. In previous testing, files with different names were used.
we now also check the file that is actually present in the store. Previously, we just uploaded and checked the repodata, which leads us to miss the bug that manifests only in the stored files.

Bug fix:

in /channels/{channel_name}/packages/{package_name}/files/, the upload is handled through a call to handle_package_files, which in turn uses _extract_and_upload_package. I added a force argument and a file existence check to  _extract_and_upload_package, which is then transformed into an HTTP 409 in handle_package_files
In /channels/{channel_name}/upload/{filename}, the solution is more straightforward as the call to pkgstore.add_package_async happens right in the top-level function. I moved the call after the try/except block that checks for 409.

Expected test failure before fix here

Codecov Report
Patch coverage: 100.00% and project coverage change: +0.01% :tada:

Comparison is base (f20db64) 83.63% compared to head (e4a831e) 83.64%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #663      +/-   ##
==========================================
+ Coverage   83.63%   83.64%   +0.01%
==========================================
  Files          79       79
  Lines        6226     6230       +4
==========================================
+ Hits         5207     5211       +4
  Misses       1019     1019

Files Changed
Coverage Δ

quetz/main.py
89.89% <100.00%> (+0.05%)
:arrow_up:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add error handling to POAPI creation and display error with snackbar

Summary
Handle PurchaseOrderAPI creation errors by displaying an error snackbar with the message from the HTTP response.
Preview (some of the HTTP responses are fixed in https://github.com/dolittle/platform-api/pull/34 as shown here):

Added

Error handling to POAPI creation view

@joelhoisko when testing this out locally I'm currently getting something that looks like this:

Is there something not merged into platform-api that causes it, or could it be a bug here?

Seems like the platform-api is returning a bit too much stuff:


Accessibility improvements on default color palette

Our current default color palette has some accessibility issues because of insufficient contrast ratio. We always want to keep a11y on our mind while we develop Baklava Design System, so this issue is an important concern for us.
Our design team is already working on this, and this issue is for following the work on that topic. Updates and fixes can be tracked here.

We'll fix on #91


java folder added, arraylist creation in java added, fixed name of a file in javascript which was written in camelCase

Thank you sir!
Deployed here: https://onelinerhub.com/java/create_arraylist
We have done multiple edits to match the format and guidelines. Did our best to keep everything in place, but please feel free to edit/comment.
Thank you!


Remove automated sorting of data

The pyam package currently automatically sorts the _data series and meta dataframe by their index. This makes it easy for consistency, assert-frame-equal and some operations like interpolation. But it can have unintended consequences in cases where ordering is forgotten, e.g. #811
Also, the repeated ordering is probably not very resource-efficient for large IamDataFrame instances.
For pyam 3.0, I suggest to drop the automated ordering on initialization and rename/aggregation/etc. methods, and instead provide a sort() method that can be called explicitly. We could also have a kwarg on all relevant methods whether to sort, but that may not effective on the effort-vs.-benefit trade-off.
@phackstock @gidden @znicholls, any thoughts?

I like the idea of making sorting optional. I cannot really think of a use case off the top of my head where I care or depend on the order of data.
For assert-frame-equal we would then also introduce a keyword argument that would switch whether or not order is considered when checking for equality.

Reminder: not sorting the time column may cause confusion when working with the wide timeseries format (e.g., write to xlsx)


chore: Typo roundup with cSpell

Why:
Was building out a cSpell dictionary for an eventual CI. The WIP config is over here https://gist.github.com/nschonni/d8655aeb3f5479e79ca29f37b4c658f5, but I figured I'd PR the more straight-forward issues it found
What's being changed:

Typos across various content folder documents
Typos across various GraphQL data elements. This might actually be product bugs being generated from code comments. Each one is separated by commit, so they can be rebased if needed

Check off the following:

[x] All of the tests are passing.
[x] I have reviewed my changes in staging.
[x] For content changes, I have reviewed the localization checklist
[x] For content changes, I have reviewed the Content style guide for GitHub Docs.

@runleonarun I'll see if I can figure out how to filter-branch properly and move those to a separate PR

🎉 Fantastic pull request. aloglia has bugged me more than once 😂

@heiskr I pulled that change out for the content folks, but I'll resubmit it after this lands. Feel free to copy/submit the fix ahead of that though 😉

@runleonarun I rebased and threw on an extra commit because the heroku deploy stalled on the previous commit