Ecobee Integration Borked with Updated Climate

Home Assistant release with the issue:
0.96.0

Last working Home Assistant release (if known):
0.95.4
Operating environment (Hass.io/Docker/Windows/etc.):
Docker

Component/platform:
Ecobee

Description of problem:
Ecobee integration is borked and has some fairly significant breaking changes to previous functionally.
The major issue is that basically setting a preset hold does nothing.
The first issue is some typos with the function definition of preset_mode:
    def set_preset(self, preset):
        """Activate a preset."""
        if preset == self.preset_mode:
            return

        self.update_without_throttle = True

        # If we are currently in vacation mode, cancel it.
        if self.preset_mode == PRESET_VACATION:
            self.data.ecobee.delete_vacation(
                self.thermostat_index, self.vacation)

        if preset == PRESET_AWAY:
            self.data.ecobee.set_climate_hold(self.thermostat_index, 'away',
                                              'indefinite')

        elif preset == PRESET_TEMPERATURE:
            self.set_temp_hold(self.current_temperature)

        elif preset in (PRESET_HOLD_NEXT_TRANSITION, PRESET_HOLD_INDEFINITE):
            self.data.ecobee.set_climate_hold(
                self.thermostat_index, PRESET_TO_ECOBEE_HOLD[preset],
                self.hold_preference())

        elif preset is None:
            self.data.ecobee.resume_program(self.thermostat_index)

        else:
            _LOGGER.warning("Received invalid preset: %s", preset)

preset is being used instead of preset_mode
sometimes it was correct sometimes it wasn't
¯(ツ)/¯
It should be more like this:
    def set_preset_mode(self, preset_mode):
        """Activate a preset."""
        if preset_mode == self.preset_mode:
            return

        self.update_without_throttle = True

        # If we are currently in vacation mode, cancel it.
        if self.preset_mode == PRESET_VACATION:
            self.data.ecobee.delete_vacation(
                self.thermostat_index, self.vacation)

        if preset_mode == PRESET_AWAY:
            self.data.ecobee.set_climate_hold(self.thermostat_index, 'away',
                                              'indefinite')

        elif preset_mode == PRESET_TEMPERATURE:
            self.set_temp_hold(self.current_temperature)

        elif preset_mode in (PRESET_HOLD_NEXT_TRANSITION, PRESET_HOLD_INDEFINITE):
            self.data.ecobee.set_climate_hold(
                self.thermostat_index, PRESET_TO_ECOBEE_HOLD[preset_mode],
                self.hold_preference())

        elif preset is None:
            self.data.ecobee.resume_program(self.thermostat_index)

        else:
            _LOGGER.warning("Received invalid preset: %s", preset)

That resolves it actually setting a preset, but then we get into the next issue.  You can't use user defined presets, nor does it load the default presets Home or Sleep that are present on every Ecobee
So by default we should at least setup for the default Home and Sleep
PRESET_HOME = 'home'
PRESET_SLEEP = 'sleep'

Ecobee lets you set custom presets, called comfort profiles, these were able to be set previously, but now it does a check for one of the pre-canned presets and throws an error.
Removing the check and adding back in the else that does a catch all to the user input fixes it:
        elif preset_mode is None:
            self.data.ecobee.resume_program(self.thermostat_index)

        else:
            self.data.ecobee.set_climate_hold(
                self.thermostat_index, hold_mode, self.hold_preference())
            self.update_without_throttle = True

This list of Presets that are actually available to an Ecobee unit are called up via Climate List:
    def climate_list(self):
        """Return the list of climates currently available."""
        climates = self.thermostat['program']['climates']
        return list(map((lambda x: x['name']), climates))

In my scenario it returns, which shows up as an attribute for the Ecobee device.
climate_list: Upstairs,Fireplace,Home,Sleep,Guest,Away
It would probably be more useful if the climate_list is what was used to populate the presets, as those are the actual presets.  The current list of presets make very little sense.
Now that leads me to my next item, which is why is next_transition, indefinite, and temp defined as presets?  Those really don't make much sense to have in there or show up in the UI as an option.  Those are fairly useless as presets and essentially do nothing.
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
ecobee:
  api_key: !secret ecobee_api_key

Traceback (if applicable):
2019-07-17 22:30:41 ERROR (MainThread) [homeassistant.components.websocket_api.http.connection.140568187639184]
Traceback (most recent call last):
  File "/usr/src/app/homeassistant/components/websocket_api/commands.py", line 121, in handle_call_service
    connection.context(msg))
  File "/usr/src/app/homeassistant/core.py", line 1150, in async_call
    self._execute_service(handler, service_call))
  File "/usr/src/app/homeassistant/core.py", line 1172, in _execute_service
    await handler.func(service_call)
  File "/usr/src/app/homeassistant/helpers/entity_component.py", line 194, in handle_service
    required_features
  File "/usr/src/app/homeassistant/helpers/service.py", line 316, in entity_service_call
    future.result()  # pop exception if have
  File "/usr/src/app/homeassistant/helpers/service.py", line 337, in _handle_service_platform_call
    await getattr(entity, func)(**data)
  File "/usr/src/app/homeassistant/components/climate/__init__.py", line 399, in async_set_preset_mode
    self.set_preset_mode, preset_mode)
  File "/usr/local/lib/python3.7/concurrent/futures/thread.py", line 57, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/src/app/homeassistant/components/climate/__init__.py", line 394, in set_preset_mode
    raise NotImplementedError()
NotImplementedError

Additional information:
If I can find some time I'll try and get a pull request out tomorrow that at least fixes the core functionality.  I've yet to try and tackle how to properly send back the list of presets that are available.

To add presets to the list you have to add them here.
like:
PRESET_HOME = 'home'
PRESET_SLEEP = 'sleep'

PRESET_MODES = [
    PRESET_AWAY,
    PRESET_TEMPERATURE,
    PRESET_HOLD_NEXT_TRANSITION,
    PRESET_HOLD_INDEFINITE,
    PRESET_HOME,
    PRESET_SLEEP,
]

I got that part, already tested it on mine.  I was suggesting that at a minimum the default set should include Home and Sleep, and do away with Temperature Hold, Next Transition, and Indefinite.

https://github.com/home-assistant/home-assistant/issues/25215#issuecomment-512701518 fixed my problem.

@madrose thanks for reporting back but please don't mix up topics.

Pull request submitted.

Will go out in a couple of hours. Thanks @geekofweek

Running 0.96.4 and it looks like the climate attribute hvac_action goes undefined if the Ecobee is not heating or cooling (as in hvac_action would normally say off) but the fan is on.
I have a template sensor setup for the Ecobee's operating state which was originally defined as:
value_template: "{{ states.climate.home_bee.attributes.operation }}"
before 0.96.x but updated it to:
value_template: "{{ states.climate.home_bee.attributes.hvac_action }}"
due to the changes in 0.96.x and found that that sensor would show no data every now and then but eventually tracked it down to when it wasn't heating and cooling but the fan was running.  I changed my template to this:
value_template: >-
  {% if states.climate.home_bee.attributes.hvac_action is defined %}
    {{ states.climate.home_bee.attributes.hvac_action }}
  {% else %}
    off
  {% endif %}

to make sure the sensor reported off when only the fan was running.


basedpyright: 1.12.6 -> 1.13.1

Description of changes
Expands on previous work by @GaetanLepage at #320941, fixing the build
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nix shell .#basedpyright -L
 cat << EOF > test.py; basedpyright --version; basedpyright test.py
import sys

if sys.platform == "win32":
    a = "a" + 1
EOF
basedpyright 1.13.1
based on pyright 1.1.369
/home/kiike/projects/nixpkgs/test.py
  /home/kiike/projects/nixpkgs/test.py:1:8 - error: Import "sys" could not be resolved (reportMissingImports)
  /home/kiike/projects/nixpkgs/test.py:3:4 - error: Type of "platform" is unknown (reportUnknownMemberType)
  /home/kiike/projects/nixpkgs/test.py:4:5 - error: Type of "a" is unknown (reportUnknownVariableType)
3 errors, 0 warnings, 0 notes


Settings: Color Options

Suggestion: display the colors in a shape (circle or square) under the 'primary, secondary, or text color' headings... because unless you're a developer, no one knows what these codes mean.

Yeah, I agree. Something like this would be great.

Not as pretty as @morebrownies, but it gets the point across.


"Found reply from unexpected source" when upstream DNS is also a Resource

Minor regression -- lookups for non-Resources that go to a DNS server that is a Resource cause the warning "reply from unexpected source". On staging:

Resource is in the Release gateways site.
This is a fairly common configuration we've seen across quite a few customers now.

This is now fixed in the latest version of https://github.com/firezone/firezone/pull/5049.


kill states by IP

I tried looking over the docs and don't see an api call to filter states by IP and then kill the states. if there is a way, please let me know as all I can see is to list the current states but can't see anything I can do with it ie kill.
I need to be able to add a new rule but then kill any connections to it which is what I see lacking.

Hey!
Currently there is not endpoint to do this. I'll keep this open as a feature request for a future release.
Thanks!

Hey!
These features have been implemented on the v1.4.0 (#172) branch and are live on the v1.4.0beta_4 build that is posted on that pull request. Feel free to try it out. We are likely 1-2 months away from v1.4.0 being released as a production release.
Thanks!

that's brilliant, thanks. I can finally control my daughters internet browsing and kicking her off when time is up :)


Minor typo in kubernetes-the-hard-way/docs/06-kubectl.md

In the section - Configure Kubectl
/var/run/kubernetes/token.csv on the controller nodes
chAng3m3,admin,admin
Should be
/var/lib/kubernetes/token.csv on the controller nodes
chAng3m3,admin,admin

This is fixed on master.


C# Sample code does not work

Type of issue
Code doesn't work
Description
I was not able to get The C# sample code to work in my new MAUI project. I imagine the code sample is outmoded.
To start, the using CommunityToolkit.Maui.Alerts; statement gets the error "type or namespace name 'Alerts' does not exist".
Which NuGet packages to install is not made clear. I installed CommunityToolkit.Maui and CommunityToolkit.Maui.Core. That did not help.
Thanks.
--Bruce
Page URL
https://learn.microsoft.com/en-us/dotnet/communitytoolkit/maui/alerts/toast?tabs=android
Content source URL
https://github.com/MicrosoftDocs/CommunityToolkit/blob/main/docs/maui/alerts/toast.md
Document Version Independent Id
8536c827-5a35-ebdd-51fd-0a184bfe1d69
Article author
@VladislavAntonyuk
Metadata

ID: 8536c827-5a35-ebdd-51fd-0a184bfe1d69
Service: dotnet-communitytoolkit
Sub-service: dotnet-maui-community-toolkit

@BruceHaley you should only need CommunityToolkit.Maui. Did your issue get resolved? The code sample is correct, perhaps Visual Studio needed to be restarted?

No response for 2 weeks so assuming this is resolved!


BeautyHiddens options are ignored inside csproj file

Uncommented  section of the csproj file ignored - NCB leaves hostfxr.dll, hostpolicy.dll, *.deps.json and *.runtimeconfig.json files in the publish directory while I expected they will be hidden too.
Project uses .Net Core 3.1 executable target, NCB version <IP_ADDRESS>.

it works for me, have you enabled Hidden items option in File Explorer or using *nix?
BeautyHiddens option is literally hiding them, not moving them, and works under windows only.

it works for me, have you enabled Hidden items option in File Explorer or using *nix?
BeautyHiddens option is literally hiding them, not moving them, and works under windows only.

Yes, I notified hidden attribute, but I expected they will be moved :)
I think, it is better to add a note in the description about this to remove misunderstanding.
Thank you!

Yes, I notified hidden attribute, but I expected they will be moved :)
I think, it is better to add a note in the description about this to remove misunderstanding.


Issue with reading header rows

I ran across a problem with reading a header row to get the field names. If the text in a column header has a space at the end of it, the code can't find it if you are looking for the text without the space on the end.
Example:
Excel file column header text: "Hours "
Data row value looking for: dr["Hours"]
Is there a way to trim the spaces off of the column header text when its reading the excel file?

I wonder if it would be a good idea to have an optional SafeFieldName, perhaps created in @appel1's proposed adapter wrapper idea, as not only do I need to get the bulk insert working - but I also will need to address the issue of "safe" field names.
I'm currently doing this manually in my resulting DataSet: cleaning up the field names by trimming leading and trailing spaces and replacing characters I don't want with an underscore at load time before inserting into SQL via XML raw data; Although I did have a problem with types as mentioned in https://github.com/ExcelDataReader/ExcelDataReader/issues/508. Alas the XLS files have grown and even change over time (changing field names, field order, add/remove fields).
This is a bit more interesting problem for the SqlBulkCopy exercise as I don't allow odd field names in the target SQL table. Also GetName() is not implemented anyhow as noted in https://github.com/ExcelDataReader/ExcelDataReader/issues/535  (also more of an argument that this all needs to be implemented in a wrapper)

I think i found a way around this by using ExcelDataReader.Mapping where on your class, add an attribute like this that maps the excel column to a property on your class like this:
[ExcelColumnIndex(1)]
public string Employee { get; set; }

That might work in some situations. For me Employee is not always in column 1, and may not even always be called Employee.
I really need to be able to access the columns by name for the SQL Bulk Insert.
The data I have to deal with:

Comes from a third party I cannot control
Field names are added / removed / renamed / reordered - often unexpectedly and unannounced
May have up to 700 columns or more, with up to hundreds of thousands of rows
Is being loaded by my app that handles many different files based on fields in first row

Sure, I could first get a list of the names from the first row, then get the ordinal reference for each. But I'd rather have something more graceful and intuitive.
When accessing by name, I can do a "best fit" of the data, and simply send an alert when expected fields are missing and/or new field are found. I probably could force similar logic into ordinal references, but that's not the right solution for me.
My initial PR has a solution that works with the sample code shown in #536, but I still plan to take a look at creating a data adapter.


Pretty print for metadata causes error

Bug Description
When pinging the app with the GET method you get an error:
  File "/Applications/ADDED/venv/clams/app-swt/lib/python3.10/site-packages/clams/app/__init__.py", line 338, in cast
    assert isinstance(vs, list), f"Expected a list of values for key {k}, but got {vs} of type {type(vs)}"
AssertionError: Expected a list of values for key pretty, but got true of type <class 'str'>

Reproduction steps
With any app running on localhost
curl localhost:5000?pretty=True

Expected behavior
No response
Log output
No response
Screenshots
No response
Additional context
No response

should be fixed in 3d5bc763a2f8bcee32d828763d7701fc95a9c8a5, closing as complete. Please re-open when the issue persist in the next version.


BOM Considerations When Extracting Your Video frames & Audio

when I tried loading my own data by using src/preprocess/extract_{audio/video_fram}.py, I encountered some problem such that
(the path in my csv file): No such file or directory
is displayed despite the fact that the path actually exists and it's correctly written in the csv file.
This was due to BOM, and solved by inserting encoding="utf-8-sig" as an argment of np.loadtxt in the files.
I write this here because the error message does not directly show the cause of the problem, which may confuse the user.

thanks so much for reporting this. this would help other users of this repo.
Btw, which operating system are you using? Is that Windows? (all exps in this repo are in ubuntu).
-Yuan

Thanks for your reply.
I am using Ubuntu 20.04.6 LTS.


Resolves enclosure URLs to site URL

Fixes #117

If you can provide an unit test with this commit, it would be great !

urljoin('http://media.mywebsite.com/toto.jpg', 'http://media.mywebsite.com/toto.jpg') == 'http://media.mywebsite.com/toto.jpg'


Add workaround for programmatically open and close datepicker.

Workaround to programmatically open/close datepicker
Description
Change how component checks new props so we can control open prop separately.
Motivation and Context
This is workaround for issue #44
This will solve problems with controlling "open" property from outside of datetime component.
Workaround assumes that you have parent container that controls datetime component. (See the example).
You can create controlled component by forwarding control "open" prop to datetime and component will react to prop change.
Also we need feedback when datetime closes itself in order to change our control value in parent component, and for this we can use onBlur function handler in parent component.
This doesn't extend existing API.
Checklist

[ ] My change required changes to the documentation.

[ ] I have updated the documentation accordingly.

[ ] I have updated the TypeScript type definition accordingly.

[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

Hi @borisarzentar and thanks for your contribution. My first impression of your PR is that I do not like the word workaround, I prefer not having any workarounds in the codebase.
I like the idea and effort though. On our roadmap we're currently working on a V3 of this component where we will probably change how the open prop is working, so to me it makes sense to not fiddle with the current stable API right now (this is kinda a breaking change).
Thanks for this, I might use some of the code/example/tests it in V3 but I'm closing this for now.

As a workaround until the next release, here's how I open the DatePicker:

    <Datetime
        value={this.props.value}
        onChange={this.props.onChange}
        inputProps={{ref: (input) => {this.input = input;}}}
    />
     {this.input.focus()}}>

it closes himself if you click somewhere else.

@edy thanks for the workaround! Any idea as to how to modify onClick to open the datepicker if it is closed and close it if it is open? I tried keeping track of the open/closed state and focusing/blurring depending on that but it didn't work unfortunately.

@simonedavico sorry, i have no idea


IVAR for QueueInstance

Describe the bug
If you ask basket to show you the data before you have gone through the process, @queue_colleciontion is not initialized.
This should not happen.

hahahah.


doc: add instructions on how to connect Alby Go with Alby Hub

Updates README.md on how to connect Alby Go with your Alby Hub.
Context: when I first downloaded Alby Go from TestFlight it was not clear to me what QR code to scan.

Maybe there should be mention of NWC, so any NWC node can be used.

Context: when I first downloaded Alby Go from TestFlight it was not clear to me what QR code to scan.

Now that we have this info added to the app itself (there is a help icon on the scan screen that explains how to connect) do you think we still need it in the README?

Now that we have this info added to the app itself (there is a help icon on the scan screen that explains how to connect) do you think we still need it in the README?

No, closing this. In any case, the README could use some general love <3
Thanks!

@kennym what sort of stuff would you add to the README that would provide value for developers? we will probably add a landing page later which can show screenshots and describe the product in more detail.

https://github.com/getAlby/go/pull/115


cmd/go: test no longer accepts list of files to test

What version of Go are you using (go version)?
go1.11rc1
Does this issue reproduce with the latest release?
This works in go1.10.3 and go1.11beta3
We might have been doing this wrong for years but we had some Makefiles that listed out the files we wanted to test in a package. With go1.11rc1 in module mode this no longer works.
It looks like this was done as a way to exclude some tests. I've changed our Makefiles so this isn't a blocking issue.
root@f677d648e597:/go/src/test# ls
nothing_test.go
root@f677d648e597:/go/src/test# cat nothing_test.go
package nothing

import "testing"

func TestNothing(t *testing.T) {
}
root@f677d648e597:/go/src/test# export GO111MODULE=auto
root@f677d648e597:/go/src/test# go test -count=1
PASS
ok  	test	0.002s
root@f677d648e597:/go/src/test# go test -count=1 ./nothing_test.go
ok  	command-line-arguments	0.002s
root@f677d648e597:/go/src/test# export GO111MODULE=on
root@f677d648e597:/go/src/test# go mod init nothing
go: creating new go.mod: module nothing
root@f677d648e597:/go/src/test# go test -count=1
PASS
ok  	nothing	0.002s
root@f677d648e597:/go/src/test# go test -count=1 ./nothing_test.go
build test: cannot find module for path test

I'm fine if this was undefined behavior that will not be supported with modules. Just calling out the change in behavior.

@rsc @bcmills @ianlancetaylor

Duplicate of #26046, fix pending.


Preserve syntax highlighting when exporting png that contains %XX

Closes #1064
This PR attempts to solve the highlighting issue described in #1064 without reintruducing any of the issues from #564. For that reason I have manually tested with the following snippets and left it as a fairly naive solution:

Snippet from #1064
Snippet from #564
Snippet 1 from comments of #564
Snippet 2 from comments of #564

This fix assumes %XX never occurs within the actual markup - only in the text itself

This is great — thanks so much @qw-in 🖤
I might not have time to review this until the weekend, but I think this is going to solve a lot of issues.

Just hope it helps! Thanks for maintaining this awesome app!
If you have any suggestions for how I could put together some tests for this I would be happy to take a crack at it in a later pr 🙂

@qw-in I was just about to say, would love to see some integration tests for this case so we don't break it in the future.
I am positive we can test for style/CSS properties using Cypress, so that would be the first place I would look.
As for what the test should look like, I would just use the snippet in the original issue (https://github.com/carbon-app/carbon/issues/1064) and add the test right here: https://github.com/carbon-app/carbon/blob/main/cypress/integration/basic.spec.js#L22
Obviously no expectations from me — but the effort would be incredibly appreciated 🙏

Really though: hall-of-fame level PR right here, @qw-in. This line of code has been so pervasive when it comes to issues. Really really appreciate your thoroughness when it comes to investigating and fixing the issue.


Add hint to Ansible role/systemd deployment

I've just released an Ansible role which deploys your tool as a systemd service. If you don't want that in your README, just close the PR. ✌

[x] run cargo clippy and fix all issues
[x] run cargo fmt to format all source files

looks good! thanks for the contribution.

something wrong with the credentials here?

Thanks so much for the contribution


Email regressions

The footer needs to be updated to reflect the new UI footer
The styling is a bit messed up:

Assigning to @mrvisser for fix

@nicolaasmatthijs I submit a fix for the footer issues, but I can't reproduce the template getting messed up, though it happened to me on QA0 as well. I'd like to get the footer updates merged and then see if I can reproduce on QA0 again afterward.

Provided fix for templating issue as part of https://github.com/oaeproject/Hilary/pull/1171


simplify program

rename beginnerProgram to simpleProgram, there is nothing about those kinds of programs that is specific to beginners, there are legitimate usecases where you just don't need subscriptions/comands.

make both program and simpleProgram take simple arguments instead of a record
its extremly confusing to beginners to see view = view and the like. (in addition to having to explain record syntax)

I avoided the name "simple" because I felt it may not look that way to everyone. It is simpler than the other, but I don't want to be telling people what they find easy or difficult.
I don't agree that getting rid of the record would be less confusing for beginners.

maybe another nomenclature would be more fitting then? beginner program just does not describe what the function does. maybe program and complex program?
about the record: i sometimes teach people elm for fun (with great success, its very teachable!), and they are always confused about that part.
for simple programs you don't really need records, and introducing them is a new concept. elm is very teachable because it does not need a lot of concepts, just functions and types basically. people are already confused about pattern matching but matching is necessary, so it can't be removed. having a struct as argument to program is not. and one could argue that its unideomatic, too, as it kinda tries to emulate named parameters from python, instead of sticking to the currying default.


Core test routing

[A clear and concise description of what the pull request is for along with a reference to the associated issue IDs, if they exist.]

[ ] DefaultRouteScriptAppenderTest.java (Difficult!)
[x] JsonRoutingAppender2Test.java
[x] JsonRoutingAppenderTest
[x] PropertiesRoutingAppenderTest
[ ] RoutesScriptAppenderTest (Difficult!)
[x] RoutingAppender2767Test (Easy)
[x] RoutingAppender3350Test (Easy)
[x] RoutingAppenderKeyLookupEvaluationTest (Middle)
[x] RoutingAppenderTest (Easy)
[ ] RoutingAppenderWithJndiTest (Middle)
[ ] RoutingAppenderWithPurgingTest (Middle)
[x] RoutingDefaultAppenderTest (Easy)

Checklist

Base your changes on 2.x branch if you are targeting Log4j 2; use main otherwise
./mvnw verify succeeds (if it fails due to code formatting issues reported by Spotless, simply run ./mvnw spotless:apply and retry)
Non-trivial changes contain an entry file in the src/changelog/.2.x.x directory
Tests for the changes are provided
Commits are signed (optional, but highly recommended)

DefaultRouteScriptAppenderTest is done in https://github.com/neighbourhoodie/logging-log4j2/pull/8


Represent balances and other amounts in Øre internally

I'm having doubts about this issue. Is the nice integer representation in Øre worth the trouble of re-implementing the Django modelForms and doing all the translation back and forth between øre and kroner?  Wouldn't it be okay to represent amounts in kroner everywhere and store these amounts in the database as decimal numbers with a fixed number of decimals (1 or 2 should do)? Rounding errors should not occur with this solution as we only subtract and add amounts (and multiply them by integers).

Is it really that complex? It's only when it's displayed to the user that it needs to be converted to Øre, and when the values from the forms are read, that it needs to be converted back. I guess two functions for conversion needs to be written, and they need to be applied in various places across the code, but I don't see it as a difficult problem, but perhaps I'm wrong?

The thing is that I have implemented all the forms as "model forms". This is a nice thing to do when the data types in the models and the forms are the same, since forms in this case will be defined and validated automatically. However, if we want float values in the forms and integers in the model it is no longer a good idea as we then have to "hack" into the process and change the input values before validation of the form. So either we should implement such as hack or reimplement the forms as plain Django forms not associated to models. I will take a few days off and then reconsider...

Ok, let's talk about it monday

When googling questions such as "what is the best way to represent price/money/currency" in a Django model, most people seem to suggest a DecimalField with 2 decimals. Perhaps I've been biased in my search...?
Eg: https://stackoverflow.com/questions/1139393/what-is-the-best-django-model-field-to-use-to-represent-a-us-dollar-amount


Refact

Proposed change

This pull request attempts to merge the main branch into the refact branch. The goal is to import all new functionality from more recent changes to main while maintaining the newer names and overall structure of refact.
The following files received manual changes:

lua/telekasten/config.lua received new config options media_extension, clipboard_program, and enable_create_new
lua/telekasten/util/file.lua functions check_dir_and_ask and global_dir_check had been updated in main directly in telekasten.lua, so these functions were removed from telekasten.lua and updated in files.lua
lua/telekasten.lua had many, many conflicts which were all resolved in accordance with the above stated goal

All other changes were performed automatically by git when the merge was initially attempted. I have reviewed these changes, and they seem reasonable, but a more knowledgeable eye may want to glance over them still.
Type of change

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (thank you!)
[x] Code quality improvements to existing code or addition of tests
[ ] Documentation update

Additional information

This PR does not seem to have a corresponding issue. However, discussion #239 is relevant.
Checklist

[x] I am running the latest version of the plugin.
[x] The code change is tested and works locally.
[x] There is no commented out code in this PR.
[x] The code has been formatted using Stylua (a .stylua.toml file is provided)
[x] The code has been checked with luacheck (a .luacheckrc file is provided)
[ ] The README.md has been updated according to this change.
[ ] The doc/telekasten.txt helpfile has been updated according to this change.

On the subject of testing, while I have done some basic testing myself, I do not have a compatible vault of my own to use for testing. Since no functionality has been intentionally changed, there theoretically should be no impact, but I am not equipped to test in more depth.
As no functionality has been added, no changes have been made to README or to the doc file.

Thank you for this amazing job. I will review and merge it this evening.

I took a pass over every thing rather quickly, I did not see any special issue.
I also pulled your changes and did some basic testing and did not encounter any problem. As this is still not a merge to main anyway, it is ok to merge and build on this basis.
Once again, thank you very much for your involvement.

On the subject of testing, while I have done some basic testing myself, I do not have a compatible vault of my own to use for testing. Since no functionality has been intentionally changed, there theoretically should be no impact, but I am not equipped to test in more depth.

This is has indeed been a problem for quite some time. I am waiting for @renerocksai to move this project to a proper organization so we can setup a repository with a few dummy notes, tags, etc and create a standardized test environment like that. This will also simplify issue/bug reports in the future.

I am terribly sorry for being so unavailable and becoming the bottleneck. I'll try to move to org now, @lambtho12!


[Bug Report] When the height is relatively high, the text wraps

Element UI version
2.15.6
OS/Browsers version
Microsoft Edge Version 94.0.992.50 (Official build) (64-bit)
Vue version
2.6.14
Reproduction Link
https://codepen.io/edric-li/pen/porEKGK
Steps to reproduce
See example.
What is Expected?
Show in one row.
What is actually happening?
Word wrap.

如果等不及官方合并，可以按照修复的样式改一下就可以了。

好的


Error when doing paket restore: Name cannot begin with the '.' character, hexadecimal value 0x2E. Line 20, position 17.

I am experiencing issues when building a solution on the CI server. Default targets fail on restore with the error below:
Paket version <IP_ADDRESS>
Resolving packages for group Main:

Newtonsoft.Json is pinned to 7.0.1
ServiceStack is pinned to 4.0.46
ServiceStack.Client is pinned to 4.0.46
ServiceStack.Common is pinned to 4.0.46
ServiceStack.Interfaces is pinned to 4.0.46
ServiceStack.OrmLite is pinned to 4.0.46
ServiceStack.Text is pinned to 4.0.46
Autofac is pinned to 3.5.2
EventStore.Client is pinned to 3.2.1
Serilog is pinned to 1.5.11
Ix-Main is pinned to 1.2.5
EventStore.SerilogAdapter is pinned to 1.0.0
AggregateSource is pinned to 0.0.300
AggregateSource.EventStore is pinned to 0.0.300
Paramol is pinned to 0.0.125
Projac is pinned to 0.0.125
Nuget.CommandLine 2.8.6
Locked version resolution written to C:\Atlassian\Data\Bamboo\xml-data\build-dir
\AF-AES-JOB1\paket.lock
Paket failed with:
Name cannot begin with the '.' character, hexadecimal value 0x2E. Line 20, position 17.

It is quite cryptic since it looks like an XML error but doesn't give a clue where to look.

Can you please try to run it with "paket restore -v"?
On Oct 10, 2015 6:30 PM, "Alexey Zimarev"<EMAIL_ADDRESS>wrote:

I am experiencing issues when building a solution on the CI server.
Default targets fail on restore with the error below:
Paket version <IP_ADDRESS>
Resolving packages for group Main:

Newtonsoft.Json is pinned to 7.0.1
ServiceStack is pinned to 4.0.46
ServiceStack.Client is pinned to 4.0.46
ServiceStack.Common is pinned to 4.0.46
ServiceStack.Interfaces is pinned to 4.0.46
ServiceStack.OrmLite is pinned to 4.0.46
ServiceStack.Text is pinned to 4.0.46
Autofac is pinned to 3.5.2
EventStore.Client is pinned to 3.2.1
Serilog is pinned to 1.5.11
Ix-Main is pinned to 1.2.5
EventStore.SerilogAdapter is pinned to 1.0.0
AggregateSource is pinned to 0.0.300
AggregateSource.EventStore is pinned to 0.0.300
Paramol is pinned to 0.0.125
Projac is pinned to 0.0.125
Nuget.CommandLine 2.8.6 Locked version resolution written to
C:\Atlassian\Data\Bamboo\xml-data\build-dir \AF-AES-JOB1\paket.lock Paket
failed with: Name cannot begin with the '.' character, hexadecimal value
0x2E. Line 20, position 17.

It is quite cryptic since it looks like an XML error but doesn't give a
clue where to look.
—
Reply to this email directly or view it on GitHub
https://github.com/fsprojects/Paket/issues/1126.

Also why is it using "paket update" or "paket install"? Usually you only
want to run "paket restore" on the CI.
Anyways please try -v
On Oct 10, 2015 8:06 PM, "Steffen Forkmann"<EMAIL_ADDRESS>wrote:

Can you please try to run it with "paket restore -v"?
On Oct 10, 2015 6:30 PM, "Alexey Zimarev"<EMAIL_ADDRESS>wrote:

I am experiencing issues when building a solution on the CI server.
Default targets fail on restore with the error below:
Paket version <IP_ADDRESS>
Resolving packages for group Main:

Newtonsoft.Json is pinned to 7.0.1
ServiceStack is pinned to 4.0.46
ServiceStack.Client is pinned to 4.0.46
ServiceStack.Common is pinned to 4.0.46
ServiceStack.Interfaces is pinned to 4.0.46
ServiceStack.OrmLite is pinned to 4.0.46
ServiceStack.Text is pinned to 4.0.46
Autofac is pinned to 3.5.2
EventStore.Client is pinned to 3.2.1
Serilog is pinned to 1.5.11
Ix-Main is pinned to 1.2.5
EventStore.SerilogAdapter is pinned to 1.0.0
AggregateSource is pinned to 0.0.300
AggregateSource.EventStore is pinned to 0.0.300
Paramol is pinned to 0.0.125
Projac is pinned to 0.0.125
Nuget.CommandLine 2.8.6 Locked version resolution written to
C:\Atlassian\Data\Bamboo\xml-data\build-dir \AF-AES-JOB1\paket.lock Paket
failed with: Name cannot begin with the '.' character, hexadecimal value
0x2E. Line 20, position 17.

It is quite cryptic since it looks like an XML error but doesn't give a
clue where to look.
—
Reply to this email directly or view it on GitHub
https://github.com/fsprojects/Paket/issues/1126.

closing since we have no repro


Add Slice to replace Snippet Chunks (#50)

SE-0356 latest changes include parsing "slices" out of snippets.
These are not quite the same as the current "chunks", which were
a speculation that eventually formed into "slices". Deprecate chunks
and add the slice data model.
Move snippet presentation code to a line-based format: slices are represented
simply as a name and index range to pull their code lines.
Add the isVirtual property to modules, for modules that are created
implicitly to hold relationships. When snippet symbol graphs are created,
a fake module is created to hold the snippets, since snippets do not come
from any one module. This property simplifies what is basically just a
heuristic in DocC to a simple factual check.
Added round-trip decoding tests for SymbolGraph.Module.
rdar://95220716

Thanks @bitjammer! Since this change is targeting the release/5.7 branch, can you please update the PR description to follow the template from https://forums.swift.org/t/swift-5-7-release-process/56316?

@swift-ci Please test


type detection isn't working correctly

When defining compound type names like supplyCategory, the OperationProcessor.resourceFor() function fails to return the correct type.
Expected: SupplyCategory
Received: Supplycategory
Putting some logs revealed this:
2019-02-18T14:13:28.597530346Z checking if  SupplyCategory  matches  Supplycategory

The following error was thrown after:
2019-02-18T14:13:28.598537676Z JSONAPI-TS:  TypeError: resourceClass is not a constructor
2019-02-18T14:13:28.598555998Z     at records.map.record (/opt/app/node_modules/@ebryn/jsonapi-ts/dist/processors/knex-processor.js:54:20)
2019-02-18T14:13:28.598561872Z     at Array.map (<anonymous>)
2019-02-18T14:13:28.598566464Z     at KnexProcessor.convertToResources (/opt/app/node_modules/@ebryn/jsonapi-ts/dist/processors/knex-processor.js:49:24)
2019-02-18T14:13:28.598574428Z     at KnexProcessor.get (/opt/app/node_modules/@ebryn/jsonapi-ts/dist/processors/knex-processor.js:19:21)
2019-02-18T14:13:28.598578273Z     at <anonymous>

Problem was due to capitalize() exceeding its responsibility. Granted, it upper-cased the first character of a string but also lower-cased the rest.
f7c074b replaces this greedy function with a simple replace operation:
export default function capitalize(str: string) {
  return str.replace(/^\w/, chr => chr.toUpperCase());
}


Renovate gh runner images, workflows, dependencies

update the macos-12 runner image to macos-13 (12 goes EOL december 2024)
FWIW: The next upgrade macos-14 hopefully on native runner without cross-compiling

arm64 m1 builds broken:
➜  .dylibs lipo -info libboost_regex.dylib
Non-fat file: libboost_regex.dylib is architecture: arm64
➜  .dylibs lipo -info libicudata.75.1.dylib
Non-fat file: libicudata.75.1.dylib is architecture: x86_64
➜  .dylibs lipo -info libicui18n.75.1.dylib
Non-fat file: libicui18n.75.1.dylib is architecture: x86_64
➜  .dylibs lipo -info libicuuc.75.1.dylib
Non-fat file: libicuuc.75.1.dylib is architecture: x86_64
➜  .dylibs lipo -info libboost_program_options.dylib
Non-fat file: libboost_program_options.dylib is architecture: arm64

for the record: I had to pin a new version of icu: icu@75 - m1 build work again


Bug: Can't log back into mobile after logout

Describe the bug
After creating an account and logging in to the mobile app, when I sign out and try to log back in i get a user not found error message
To Reproduce

Go to Mobile app
Create a user
Log out with that user
Attempt to log back in
See error

Expected behavior
A clear and concise description of what you expected to happen.
I Should be able to log back in normally
Screenshots
If applicable, add s

creenshots to help explain your problem.

@bdesollar Can you look into how you are logging users out? Let me know if this works on your end

This is done


[$250] Track expense - App is stuck on confirmation page when submitting track expense

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.68-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Issue reported by: Applause Internal Team
Action Performed:
Precondition:

Account has only one workspace.

Track a manual expense.
Click Categorize it.
Select a category, enter merchant and submit the expense to the workspace.
Delete the workspace.
Open FAB.
Click Track expense under Quick action.
Enter amount > Next.
Select a user.
Click Submit on the confirmation page.
Might need to repeat Step 7 to 11 if user can submit the track expense (it will show error in the report if the submit is successful).

Expected Result:
In Step 9. after entering amount, app should proceed to confirmation page to submit the track expense to self DM because we cannot directly submit track expense to other user.
Actual Result:
In Step 9. after entering amount, user can select other recipient to submit the track expense.
As a result, app is stuck on the confirmation page when trying to submit track expense directly to other user.
Workaround:
Unknown
Platforms:

[x] Android: Standalone
[x] Android: HybridApp
[x] Android: mWeb Chrome
[x] iOS: Standalone
[x] iOS: HybridApp
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
https://github.com/user-attachments/assets/e8ccfcb4-a7d7-4643-8b46-40e8cb961860

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021863595844310832183
Upwork Job ID:<PHONE_NUMBER>310832183
Last Price Increase: 2024-12-09

Issue OwnerCurrent Issue Owner: @eVoloshchak

Proposal
Please re-state the problem that we are trying to solve in this issue.
Track expense - App is stuck on confirmation page when submitting track expense
What is the root cause of that problem?
When categorizing (or even sharing) we are setting the quick action to track and the chatReportID to the chat report target we are submitting to here
https://github.com/Expensify/App/blob/64829131fe962681626b4b016140521d05f7fe52/src/libs/actions/IOU.ts#L1381-L1386
this function is used for tracking expense case on that case it has no problem because the chatReport is the selfDM so our quick action will navigate to track flow with report id as the self dm but the problem is we use it for categorizing flow and in that case the chat report is the policyExpense chat so we are setting the quick action to track with quickActionReportID as the workspace chat.
What changes do you think we should make in order to solve the problem?

We have two options to solve it

On categorizing/sharing case we can set the quick action to request type instead of track type so that now the quick action will be request for the expense chat
https://github.com/Expensify/App/blob/64829131fe962681626b4b016140521d05f7fe52/src/libs/actions/IOU.ts#L1359-L1364

 const isSelfDM = ReportUtils.isSelfDM(chatReport);
    let newQuickAction: ValueOf<typeof CONST.QUICK_ACTIONS> = isSelfDM ? CONST.QUICK_ACTIONS.TRACK_MANUAL : CONST.QUICK_ACTIONS.REQUEST_MANUAL;
    if (isScanRequest) {
        newQuickAction = isSelfDM ? CONST.QUICK_ACTIONS.TRACK_SCAN : CONST.QUICK_ACTIONS.REQUEST_SCAN;
    } else if (isDistanceRequest) {
        newQuickAction = isSelfDM ? CONST.QUICK_ACTIONS.TRACK_DISTANCE : CONST.QUICK_ACTIONS.REQUEST_DISTANCE;
    }

Otherwise, if we want to set it to track quick action on categorizing/sharing we should set the quickActionReportID here to be always the selfDM
https://github.com/Expensify/App/blob/64829131fe962681626b4b016140521d05f7fe52/src/libs/actions/IOU.ts#L1385

                    chatReportID: ReportUtils.findSelfDMReportID() ?? chatReport.reportID,

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?
What alternative solutions did you explore? (Optional)

@eVoloshchak, please provide an update. Thanks!

@eVoloshchak, I DM'd you for visibility. Thanks!

Hey @jasperhuangg, can you please share an update? Thanks!

Yeah, I agree that the first option is more intuitive to me. Categories are only available when you request money from a workspace, so categorizing an expense is the same as requesting money on that workspace. Let's move forward with your first approach. @FitseTLT Thanks for asking!

Yeah, I agree that the first option is more intuitive to me. Categories are only available when you request money from a workspace, so categorizing an expense is the same as requesting money on that workspace. Let's move forward with your first approach. @FitseTLT Thanks for asking!

Ok don't forget to assign me 👍


TagHelpers not working Beta 7

Hi! I use Asp.Net beta 7 now.
I follow this steps: 1) Create empty Asp.Net mvc 6 project, then add many needed dependencies with dependency Microsoft.AspNet.Mvc.TagHelpers too and add @addTagHelper directive in _ViewImports.cshtml
And this not working for me. A try to add AnchorTagHelper to .cshtml page, but this not transformed to valid element and in client looks like this server tag with attrs (GitHub cuts tag=(

So you have the following in your _ViewImports?

@addTagHelper "*, Microsoft.AspNet.Mvc.TagHelpers"

You're also including it in your package.json?

"Microsoft.AspNet.Mvc.TagHelpers": "6.0.0-beta7"

Here is an example of some of the tag helper syntax

asp-controller="Home" asp-action="Index"...

It seems like you're doing everything correctly, maybe double check the addTagHelper syntax?

Ok. I check at morning again)

I checked. All Right. I noticed one detail. When a dublicate  addTagHelper in view that I needed, all works fine.

You may see issue in this  project http://1drv.ms/1QqEmgW

Ooh. I found problem. I place _Viewimports in /Views/Shared not in /Views . All works fine, exclude Intellisense - this does not work on Empty or StarterKit project

@Sm1le291 for IntelliSense ensure that you have the Microsoft.AspNet.Tooling.Razor package in your project and are at least targeting dnx451.

Hmmm...yeah, I'm not getting Intellisense for Razor in VSCode, even though I have that package installed in my project. On the other hand, VSCode doesn't explicitly say that it supports Intellisense for VSCode. I sure wish it did!

Ahh, in VSCode you will not get Razor IntelliSense sadly. Hopefully one day :smile:

@NTaylorMullen I mean that autocomplete not works in .config files for bower or npm(for NuGet works well) - works only for version, not for package name! You may try this in my attached project above.
But in some screenshots  on docs.asp.net I see that works for package name too

This issue is being closed because it has not been updated in 3 months.
We apologize if this causes any inconvenience. We ask that if you are still encountering this issue, please log a new issue with updated information and we will investigate.


Make a market booth creation tutorial.

Context and Problem Statement
To present at various virtual market locations, we need to do various workflow steps that are quickly forgotten.
Describe the proposed option and how it helps to overcome the problem or limitation
We can write down our collective workflows for creation.
Describe how your proposal will work, with code, pseudo-code, mock-ups, or diagrams
Write a guide of our wisdom for making a 3d market booth.
Tools used

Substance designer
Blender
4m x 4m x 5m standard size

Initial task

Make a procedural grid texture and some text
put it in blender on the booth boundaries (cube)

Storage

Upload to Github organization.

Positive Consequences

Increase our workflow

Negative Consequences

Loss of creativity

Option graveyard

Option: Recreate the workflow from scratch

If this enhancement will not be used often, can it be worked around with a few lines of script?
Workflow enhancement.
Is there a reason why this should be core and done by us?
We are doing this, so we can record how we did it.
References

V-Sekai
https://www.youtube.com/watch?v=LGZWjyeUPHU

License of the contribution
Copyright (c) 2022 V-Sekai contributors.
Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
 IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

Love this! If you make this I'd love to add to the metaverse.dev site

Added as part of https://github.com/V-Sekai/V-Sekai.github.io/commit/e27aec49d09e7625d0d0666a74ebbded91a415f4.


What is the status of WebSocket.Client?

What is the current status for Microsoft.AspNetCore.WebSockests.Client?
From the official documentation currently you are redirected to the master branch of this repo, which is currently behind dev and contains the Client, ProtocolandServer` projects.
Do I use WebSocketClient which hasn't been updated in several months or do I just use ClientWebSocket from System.Net.WebSockets?
Thanks!

Use WebSocketClient. WebSockests.Client was only ever a proof of concept.

Woops, I meant use ClientWebSocket.

@Tratcher Thanks for the quick reply!

And how about Microsoft.AspNetCore.Sockets?

That's something @davidfowl needs to rename before it drives us all crazy.

Thanks a lot, I will close the issue now.
Thanks!


Upgrade to 0.7.1: Parameter 'directory' is not a directory

I started updating my ReSharper/Rider plugins and got the following:

A problem occurred evaluating project ':protocol'.
Parameter 'directory' is not a directory: /Users/matt/.gradle/caches/modules-2/files-2.1/com.jetbrains.intellij.rider/riderRD/2021.1-EAP4-SNAPSHOT/c5868e69b7a5064f95dc1ea103c865483e4fc9a7/riderRD-2021.1-EAP4-SNAPSHOT/lib/ant/lib

Everything is working on the old 0.6.x. If you need any particular logs, please let me know which one.

Thanks for reporting, Matthias.
Issue is already fixed and will be released soon with 0.7.2
https://github.com/JetBrains/gradle-intellij-plugin/commit/876008b69366bd51088cba8b6f5a67fd9b942b14#diff-ac48c8d8df65750fc94bd65f5b103769e90f2708736533bc0b9131ba079cca6bR224


Raise argumenterror when raising negative to fractional

This code path first returned Float::NaN, which made the specs fail, so these specs were disabled. Pull Request #969 updated some behaviour of Float::NaN, which means the test would now erroneously pass. At the same time, Pull Request #959 did enable the tests with a NATFIXME block. These two changes combined resulted in passing tests within a NATFIXME block.
For now, just raise an exception so it's clear this still has to be implemented, and make the specs pass again.

Currently  #975 shows an example of the error raised by running the full test suite


Fixes a tiny typo in settings

Just changes doesn' to doesn't.  Easy peasy!

It was a Shakespearean omission... 😆 Thanks


Demo link correction (README.md)

File: README.md
In Demo section
↳ Replace Astrofy --> (https://astrofy.astrofy-template.app/)
↳ By Astrofy --> (https://astrofy-template.netlify.app/)

Thanks  @GrungeElFz, nice catch  :+1:  Obviously copy and paste in the wrong place haha


Documentation / Wiki

User story

As an IT project manager
I want / need to read a complete technical / build documentation
So that I can implement the software on my own device

Acceptance criteria

Complete build documentation
Complete technical documentation
Make it understandable for first time users

Definition of done

Documentation conform with tsdoc
Reviewed with 4 eyes principle
Understandable documentation for developers
did not break other code

I will add additional, more details technical descriptions to the wiki that is based on the technical presentation slides.


Fix #12791

Q
A

Is bugfix?
yes

New feature?
no

Breaks BC?
no

Tests pass?
yes

Fixed issues
#12791

Resolved by commit d4df72a2a4d83ce2f4ae4fef4ca252834d6a319b


Cask request: Softorino YouTube Converter 2

Cask details
YT Converter. Music Downloader. Ringtones Maker.
Name:
Softorino YouTube Converter 2
Homepage:
https://softorino.com/youtube-converter-2/
Download URL:
https://dl.devmate.com/com.softorino.syc2/SYC2.dmg
Description:

https://github.com/caskroom/homebrew-cask/pull/37839


Find some co-owners or maintainers

While I'm personally committed to maintaining this project and publishing releases in sync with the rest of circe, it'd be great to get one or two other people on board to help with issues (like #1, #2, and #3), reviewing, and publishing.
If you're interested in joining this project as a co-owner or maintainer, please contact me on Gitter or by email at travisrobertbrown at gmail dot com.

Can you let me in? I'll do what I can.

@n4to4 Done!


Enable travis for java tests

Inspired by:
https://github.com/apache/incubator-netbeans/pull/790
Trying to enable java.completion tests on JDK 8, 11 (both with nb-javac) and 12 (without nb-javac) in Travis. Unclear if we want the tests on 12 on the gate, as external changes (new 12 builds) may lead to CI failures.
Will obviously need merge with https://github.com/apache/incubator-netbeans/pull/790.

Superseded by other PRs.


Add Invariants checks for pallet(Balances).

part of #12831.

[ ] alliance
[ ] balances

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2557439

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2557440

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2561341

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-benches
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2593288


Standardize typical CLI options

Most LS do allow using stdio or nodeipc ad transport and have the same options to choose one or the other when starting LS.
In order to easily factorize deployment/startup of LS, it would be convenient to standardize those options to safely build strategies on top of them.
For example, once some registry exist and some client use it to discover and use a LS automatically, it'd be useful to just be able to use the same startup flags all the time.

Makes sense to me: here is what the VS Code language servers currently support:

--node-ipc: use node IPC communication
--stdio: uses stdio
--pipe: use pipes / socket files. The pipe / socket file name is passed as the next arg or with --pipe=
--socket: uses a socket. Port is passed as next arg

I am not sure if this should go into the spec or whether we would have implementation guild lines.

Having it as a hint or a recommendation would work for me. The thing is just that we have written it down somewhere so we can link LS implementors to it and say "can you please adopt this".
Whether it's officially part of the spec or not doesn't matter. As long as it's written down on some official-ish document the result would be the same and the value would be here.


Issues with 'with()'

I have models: Customers, Invoices and DeliveryAddresses
CustomersTable.php:
 public function initialize(array $config): void
    {
        $this->hasMany('Invoices', [
            'foreignKey' => 'customer_id',
        ]);
    }

InvoicesTable.php:
    public function initialize(array $config): void
    {
        $this->belongsTo('Customers', [
            'foreignKey' => 'customer_id',
            'joinType' => 'INNER',
        ]);
        $this->belongsTo('DeliveryAddresses', [
            'foreignKey' => 'delivery_address_id',
        ]);
    }

DeliveryAddressesTable.php
    public function initialize(array $config): void
    {
        $this->hasOne('Invoices', [
            'foreignKey' => 'delivery_address_id',
        ]);
    }

I baked my factories as in the docs
In one of my test cases, when i do:
CustomerFactory::make()->withInvoices()->persist();

I get both models saved correctly
However if i do:
InvoiceFactory::make()->withCustomers()->persist();

I get the following error:
CakephpFixtureFactories\Error\PersistenceException : Error in Factory App\Test\Factory\InvoiceFactory.
Message: SQLSTATE[HY000]: General error: 1364 Field 'customer_id' doesn't have a default value
What am i doing wrong?
Another issue is when i try to make a deeper association.
As in the tutorial
CustomerFactory::make()->with('Invoices.DeliveryAddresses')->persist();

The Customer and Invoice are correctly saved. However delivery_address_id can be NULL,  so the DeliveryAddress record is not created, and delivery_address_id in Invoice is NULL. When i force it to NOT NULL in database, i get the following error:
CakephpFixtureFactories\Error\PersistenceException : Error in Factory App\Test\Factory\CustomerFactory.
Message: SQLSTATE[HY000]: General error: 1364 Field 'delivery_address_id' doesn't have a default value
How do i make this work?
Thanks in advance!

Hi,
A question before I further dig: did you modify the factories after baking them? If yes, please kindly share the code of all 3 factories. This will help me provide you a solution to your two issues.

InvoicesFactory was not modified, I only added some default data to CustomersFactory using faker such as username, password etc.

Helpful would be the output of
InvoiceFactory::make()->withCustomers()->getEntity()->toArray();
and
CustomerFactory::make()->with('Invoices.DeliveryAddresses')->getEntity()->toArray();

Are there some required fields in the invoices table, that you did not populate?

The saving of belongsTo associations is covered by the package, so I do not see for the moment where the issue comes from.
The package's tests cover a similar case here:
https://github.com/pakacuda/cakephp-fixture-factories/blob/master/tests/TestApp/src/Model/Table/AddressesTable.php
https://github.com/pakacuda/cakephp-fixture-factories/blob/master/tests/Factory/AddressFactory.php
Where the AddressesTable belongs to a City.
Tests pass when calling AddressFactory::make()->withCity()->persist();
For example in this test:
https://github.com/pakacuda/cakephp-fixture-factories/blob/master/tests/TestCase/Factory/BaseFactoryTest.php#L690

The only difference I see, is that the associated model is singular cased. This should not be an issue, but you may try calling your association in the InvoicesTable Customer instead of Customers, and thus in the InvoiceFactory name the method withCustomer instead of withCustomers. This reflects the model's logic a bit clearer. But again, it should work without doing that.

Here are my three factories:
InvoiceFactory.php
class InvoiceFactory extends CakephpBaseFactory
{
    protected function getRootTableRegistryName(): string
    {
        return 'Invoices';
    }
    protected function setDefaultTemplate(): void
    {
        $this->setDefaultData(function(Generator $faker) {
            return [];
        });
    }
    public function withCustomers(array $parameter = null): InvoiceFactory
    {
        return $this->with(
            'Customers',
            \App\Test\Factory\CustomerFactory::make($parameter)
        );
    }
    public function withDeliveryAddresses(array $parameter = null): InvoiceFactory
    {
        return $this->with(
            'DeliveryAddresses',
            \App\Test\Factory\DeliveryAddressFactory::make($parameter)
        );
    }
}

CustomerFactory.php
class CustomerFactory extends CakephpBaseFactory
{
    protected function getRootTableRegistryName(): string
    {
        return 'Customers';
    }
    protected function setDefaultTemplate(): void
    {
        $this->setDefaultData(function(Generator $faker) {
            return [
                'name' => $faker->name,
                'login' => $faker->userName,
                'password' => $faker->password
            ];
        });
    }
    public function withInvoices(array $parameter = null, int $n = 1): CustomerFactory
    {
        return $this->with(
            'Invoices',
            \App\Test\Factory\InvoiceFactory::make($parameter, $n)->without('Customers')
        );
    }
}

DeliveryAddressFactory.php
class DeliveryAddressFactory extends CakephpBaseFactory
{
    protected function getRootTableRegistryName(): string
    {
        return 'DeliveryAddresses';
    }
    protected function setDefaultTemplate(): void
    {
        $this->setDefaultData(function(Generator $faker) {
            return [
                'address' => $faker->address
            ];
        });
    }
    public function withInvoices(array $parameter = null): DeliveryAddressFactory
    {
        return $this->with(
            'Invoices',
            \App\Test\Factory\InvoiceFactory::make($parameter)
        );
    }
}

Here are requested outputs:
InvoiceFactory::make()->withCustomers()->getEntity()->toArray();

results in an empty array
[]

The line below
CustomerFactory::make()->with('Invoices.DeliveryAddresses')->getEntity()->toArray();

results in
   [
     "name" => "John Doe",
     "login" => "bernhard.gilda",
     "password" => "$2y$10$5snFBm8XALfTU6AKCQxy4eZ6KXD0NqLGdCEnNwQpOesfKZTG3PmH2",
     "invoices" => [
       [],
     ],
   ]

My invoices table for now only has the following fields: id, customer_id, delivery_address_id, created, modified. Only the first two are required.
I do not really understand your third point. CakePHP conventions are clear that association names are plural and so are their table names. If i singularize my association from Customers to Customer, Cake will look for the table called customer instead of customers which produces errors.

Regarding the third point, you simply have to set the key className to customers, and the association Customer will work. This is illustrated in the examples I sent you.

All right i managed to resolve the first issue with renaming the association as you pointed out. Now it gets correctly saved.
However singularizing the associations in InvoicesTable and DeliveryAddressesTable did not work as expected, the DeliveryAddress record is still not saved when using.
CustomerFactory::make()->with('Invoices.DeliveryAddresses')->persist();

I found out that when using
DeliveryAddressFactory::make()->with('Invoices.Customer')->persist();

All three entities are correctly saved. I have no idea why it does not work the other way.

How about if you singularize the association DeliveryAddresses to DeliveryAddress?
There might be an issue in the package, the saving should work regardless of the name of the association. But if this worked, you could at least keep on working for the moment. I'll be able to search for a bug only by next week.

Tried that, no effect

I found out that association saving really does depend heavily on association name. Especially whether it's plural or singular. After setting all properties in my entities to accessible with
    protected $_accessible = [
        '*'=> true
    ]

i noticed that sometimes the association ends as an array istead of an entity instance with incorrect property name.
I would seem that FixtureFactory does not extract the correct property name from association.

I have found that the native singularization/pluralization of 'Address/Addresses' is un predictable. I've had to add this rule:
Inflector::rules('singular', ['/^(.*)(address)$/i' => '\1\2']);

and make sure it gets run in both my app and the testing bootstrap

@rtrochim Do you have a concrete example illustrating that?
I agree with dreamingmind.

@rtrochim Do you have a concrete example illustrating that?
I agree with dreamingmind.

I have fixed the issue of non saved plural toOne association.
As described in the documentation here:
https://book.cakephp.org/3/en/orm/saving-data.html#saving-belongsto-associations
the associated data should be singular, which the package did not consider.
This is now fixed, you may update the package with its latest version.
I personally prefer naming my toOne associations singular, but if you don't, feel free rename your associations plural, and please let me know if it worked for you.
I will close this issue in three days, if this alright for you.

Everything now works correctly.
Thank you for your time and contribution. This plugin really does ease handling test data.
Cheers!


Update package

First, thanks very much for this package. I can't thank you enough.
Some updates from the dependencies of this package are already available, it would be nice to have an update.

Are you referring to any Pull Request you have made or some other updates? Can you please make it clearer?Ram    On Wednesday, September 6, 2023 at 11:32:22 PM EDT, arturdaraujo @.***> wrote:
First, thanks very much for this package. I can't thank you enough.
Some updates from the dependencies of this package are already available, it would be nice to have an update.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

Have you contemplated using some validation dataset for tuning the features selected?
This way it is possible to select the features that are more representative of the real target on the test dataset.

Hello: Thanks for the suggestion. But I have a doubt.
The way recursive XGBoost algorithm works is by sampling features multiple times. If you want more than that, it will take a longer time to run and may be redundant.
Has someone tested to see if your suggested approach is better than featurewiz' current approach? Can you provide some proof?
ThanksAuto Vimal
On Tuesday, September 12, 2023 at 05:19:23 PM EDT, arturdaraujo @.***> wrote:
Have you contemplated using some validation dataset for tuning the features selected?
This way it is possible to select the features that are more representative of the real target on the test dataset.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: @.***>

I have added a cross_validate.py which shows how to cross-validate features selected using featurewiz. Take a look and see if it is what you are looking for.featurewiz/examples/cross_validate.py at main · AutoViML/featurewiz
|
|
|
|  |  |
|
|
|
|  |
featurewiz/examples/cross_validate.py at main · AutoViML/featurewiz
Use advanced feature engineering strategies and select best features from your data set with a single line of co...
|
|
|
Auto Vimal
On Thursday, October 5, 2023 at 12:33:20 PM EDT, arturdaraujo<EMAIL_ADDRESS>wrote:

Closed #78 as completed.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: @.***>


log not complete

21:15:56.515 [error] Error in process <0.427.0> on node<EMAIL_ADDRESS>with exit value: {{badmatch,#{generals=>[#{equipment_infos=>[#{equipment_id=>0,equipment_tid=>4217,level=>37},#{equipment_id=>0,equipment_tid=>2212,level=>20},#{equipment_id=>0,equipment_tid=>3211,level=>1}],favor_level=>28,general_id=>-5,general_tid=>72,level=>40,skill_group_infos...
The log is not complete, instead of "...", How can i make it complete?

Have you tried the configuration suggested at https://github.com/basho/lager#setting-the-truncation-limit-at-compile-time ?

My rebar.config is:
{erl_opts, [{parse_transform, lager_transform}, {lager_truncation_size, 102400}]}.
And the log is:
21:46:18.724 [error] Error in process <0.427.0> on node<EMAIL_ADDRESS>with exit value: {{badmatch,#{generals=>[#{equipment_infos=>[#{equipment_id=>0,equipment_tid=>1202,level=>9},#{equipment_id=>0,equipment_tid=>2216,level=>59},#{equipment_id=>0,equipment_tid=>3202,level=>13},#{equipment_id=>0,equipment_tid=>4212,level=>19}],favor_level...

This error is reported by "emulator" process. Truncation is performed not by lager but by erlang itself. You cannot control truncation size for this type of errors.

Does it mean it can not work now?
It is not convenient to debug.

21:15:56.515 [error] Error in process <0.427.0> on node<EMAIL_ADDRESS>with exit value: {{badmatch,#{generals=>[#{equipment_infos=>[#{equipment_id=>0,equipment_tid=>4217,level=>37},#{equipment_id=>0,equipment_tid=>2212,level=>20},#{equipment_id=>0,equipment_tid=>3211,level=>1}],favor_level=>28,general_id=>-5,general_tid=>72,level=>40,skill_group_infos...
The log is not complete, instead of "...", How can i make it complete?
[posted via JIRA by Derek Somogyi]

You may need to patch error_logger_lager_h - by default it has a hard coded limit of 100 or 500 characters for most log messages.  We plan to make that fully configurable in the future, but for now, you'd have to change it in the Erlang code, recompile the beam and hot load it into your emulator.
See for example: https://github.com/basho/lager/blob/master/src/error_logger_lager_h.erl#L399

This is a duplicate of #162

Ummm, this GH issue was closed on June 25, 2015. Closing in JIRA.
[posted via JIRA by Scott Fritchie]


added path property to topic json

PrayerPoints component:
Remove tech debt of the newly added optional parameter of the topic page's path (e.g, ancestor-veneration)
This was only use for the prayer points on the home page and it should really be something that each topic should store anyways.
It is a bit unfortunate that 'metadata' type information here is duplicated per language, but if we ever get too much metadata per topic or start adding many more languages we can make the change to pull it out into it's own file

Sorry Simon I just remembered, I think I added the  unity-in-christ JSONs to the folder. Do you think you can update this PR to make this change to those files too? If not I can do it later on a separate PR, just let me know! Thanks!


Remove dupe WPF from titles

@mairaw I'll create a separate PR for the Windows Forms folder.

@mairaw This should be good to merge now.


[BUG]: Studio - Supabase PostgresError: permission denied for table xxx

Report hasn't been filed before.

[X] I have verified that the bug I'm about to report hasn't been filed before.

What version of drizzle-orm are you using?
0.36.3
What version of drizzle-kit are you using?
0.28.1
Other packages
No response
Describe the Bug
I am using a Supabase postgres DB.
When I open studio, I get this error:

bug-report.zip

Can confirm I also get this.
Have also tried to create a custom config for studio alone, which specifically ignores the table/schema schema_migrations is in, but no luck


Generate a bmap file for the resin-sdcard image

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

connect https://github.com/resin-os/resinos/issues/163


fix attenuation setting

Description
This PR closes #1399 the attenuation initialization in vispy, and also fixes an iso_threshold / attenuation initialization in napari. The vispy fixes are probably best moved to vispy in the long run, but this works for now.

This has been superseded by #1454


chore(core): cleanup testing utilities

Just a bunch of cleanups and some of them should fix some core-related flakeyness. More description in comments

Codecov Report

Merging #583 (eeb9203) into main (1f83373) will decrease coverage by 0.20%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #583      +/-   ##
==========================================
- Coverage   63.44%   63.23%   -0.21%
==========================================
  Files          92       92
  Lines        4995     5002       +7
==========================================
- Hits         3169     3163       -6
- Misses       1495     1506      +11
- Partials      331      333       +2

Impacted Files
Coverage Δ

core/testing.go
100.00% <100.00%> (ø)

node/testing.go
100.00% <100.00%> (ø)

node/settings.go
56.41% <0.00%> (-12.83%)
:arrow_down:

service/header/core_listener.go
51.92% <0.00%> (-5.77%)
:arrow_down:

node/fxutil/util.go
52.17% <0.00%> (-4.35%)
:arrow_down:

das/daser.go
72.48% <0.00%> (-2.69%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f83373...eeb9203. Read the comment docs.

The coverage decreased a bit due to skipped test. The why is commented there

❓ ❓ ❓ ❓ ❓

Nvm I saw a weird error on this PR previously


Yandex music.kz / music.by

ru and com addresses are present in the processing of tracks. But there can also be kz and by

https://music.yandex.by/users/llimonix123/playlists/3
https://music.yandex.kz/users/llimonix123/playlists/3
You need to change the regular expression and add kz and by there

resolved in https://github.com/topi314/LavaSrc/pull/197

published in https://github.com/topi314/LavaSrc/releases/tag/4.1.1


Question about training epochs

Hi, Thanks for the amazing work! I was wondering how many epochs per sequence length you had trained for each sequence length. "We train our single-motion NeMF for 500 iterations to fit a 32-frame
sequence, and scale the number of iterations proportionally as the sequence length increases to make
sure that our model is sufficiently trained for each length of sequences.". In the supplementary material for NeMF, from my understanding it was written that you had trained for 500 epochs on sequence length of 32 and for each higher sequence length, a proportional number of epochs were taken. What proportional number of epochs were taken in this case?

Thanks a lot for the prompt reply!

Hey, I had another question and didn't want to open another issue. With each sequence length beyond 32, say 64, do you also double the frame rate for the calculation of dt? Also how is step size being used during training and testing. I was unclear on these parameters.

Hi, we fixed the frame rate as 30 during training with different sequence lengths. It will be changed during testing to validate the smoothness of our result, since we learned a continuous representation. Step size is then the parameter used to change the frame rate, where step size 1 equals the original frame rate 30, and step size 0.5 equals the frame rate  30/0.5=60, etc. You can find the corresponding code here:
https://github.com/c-he/NeMF/blob/146a1eade5dd7eb77db8380c7f03adf99bfb09a2/src/nemf/basic.py#L228-L232

Hi, thanks for answering these questions! I was wondering if you had tried training on different frame rates also during training to provide a better continuous representation during testing.

No we didn't try this experiment. Since we pre-normalized all sequences to 30 fps, we don't have ground truth data of different frame rates for training. But if you don't pre-process AMASS data, there do exist sequences with different frame rates, and you can try to see if training on these data gives you better results.

Hi, thanks for the detailed answers and I might check it out for better up-sampling representations in the future.


Filter isn't removing the extra filtering

I tried using the EnableFilter query and use a lambda with a function to check user level and filter as required. This function returned false, but the filter still navigated to entities that weren't required.
I found that I had to add a statement into BuildFilterExpressionWithDynamicFilters of
(!_DbContext.IsFilterEnabled(filter.FilterName)) continue;
for each filter in filterList for this to work.
I'm certain I'm doing something wrong with the configuration of DynamicFilters rather than your code, but I can't see what's wrong. I also noticed from the source that methods like PreventAllDisabledFilterConditions in DynamicFilterExtensions were not being called but I don't know why.

Hello @timalmond ,
Do you think you could submit us a small example?
By example, check this example: https://github.com/zzzprojects/EntityFramework.DynamicFilters/issues/72#issuecomment-331672195
It will help us to getting started and better understand this problem.
Best Regards,
Jonathan

Hello @timalmond ,
I will close this issue since no example has been provided.
If you can provide one, please reopen this issue and we will work on it.
Best Regards,
Jonathan


Closes #44, Task screen CSS now appears in Task popup

Closes #44.
Added<EMAIL_ADDRESS>to Task.fxml root AnchorPane

Great looking CSS @poli648! Please check if theres any issues compared to how you designed in SceneBuilder

Everything looks good! Another thing to add would be to darken the background if possible.


full screen animation looks kinda weird

on mac when i click full screen it does this during the transition:

not super important but thought I'd log it in case anyone knows a quick fix

hahaha, oh wow - yea not entirely sure what's going on there. Just for
reference: which MacOS version are you running?
On Fri, Feb 10, 2017 at 8:17 PM maxogden<EMAIL_ADDRESS>wrote:

on mac when i click full screen it does this during the transition:
[image: screen shot 2017-02-10 at 11 16 29 am]
https://cloud.githubusercontent.com/assets/39759/22840448/71b279d0-ef82-11e6-9918-d15ad8a452aa.png
not super important but thought I'd log it in case anyone knows a quick fix
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/datproject/dat-desktop/issues/214, or mute the thread
https://github.com/notifications/unsubscribe-auth/ACWleh6_YSqI_cNI7zCMYREhgHYohIRzks5rbLfEgaJpZM4L9v_i
.

@kriesse I suspect it might be that the hex code of the electron background is slightly different from our neutral color; just spotted it too when resizing

Looks like it might be a regression of https://github.com/electron/electron/issues/4992

@Kriesse did you end up reporting this bug to the Electron team?

@yoshuawuyts no, not yet.

Seems to work in v3.0.0:latest


why do you use prediction_model to evaluate? why not use the model used during training?

why do you use prediction_model to evaluate? why not use the model used during training?

Hi @dhiaul98 , I believe the prediction model is used because the evaluation function expects decoded outputs from the network. If you look at the efficientdet function in model.py you'll see the difference between the model used for training and prediction model is their output layer. Training model has classification and regression layers as its output, which makes it possible to directly calculate loss during the training process. The prediction model (that is used in evaluation) has the same weights as the training model but it has extra layers used for decoding (and filtering) the output of the network into final predictions which can then be used to evaluate the model performance. Hope this answer helps!

Oke sir, i'am sorry about that, i'am newbie in this field :D


⚠ Turnos 24x7 has degraded performance

In 7c3d99b, Turnos 24x7 (https://reservas-dev.alternativasinteligentes.com/) experienced degraded performance:

HTTP code: 200
Response time: 906 ms

Resolved: Turnos 24x7 performance has improved in 19ca6b7.


doc(rust): add badge in README.md

Codecov Report

Merging #491 (9a9fe6e) into master (585f93e) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #491   +/-   ##
=========================================
  Coverage     45.60%   45.60%
  Complexity      646      646
=========================================
  Files           207      207
  Lines         11452    11452
  Branches       2892     2892
=========================================
  Hits           5223     5223
  Misses         6004     6004
  Partials        225      225

Flag
Coverage Δ

rust
84.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Well done! left a couple of comments above.


fix(aduit): client ip length more langer then audit column client_ip_address

…address

What type of PR is this?

type-bug
What this PR does / why we need it:
client ip length more langer then audit column client_ip_address
Which issue(s) this PR fixes:

Fixes #1179
Special notes for your reviewer:

Additional documentation e.g., usage docs, etc.:

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.keyang.lk seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


chore(master): release 2.2.0

:robot: I have created a release beep boop
2.2.0 (2023-05-03)
Features

support lavalink v4 (#68) (cd63b41)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/ooliver1/mafic/releases/tag/v2.2.0 :sunflower:


Problem with Dart extension

Type: Performance Issue
Sometimes Dart Analysis Server continues to load for a long time and doesn't update the text editor, i.e.:

Doesn't recognize mistakes
Doesn't recognize packets
when I hover over a word, like a class for example, it only comes up "Loading"
I've tried rebooting the Dart Analysis Server and sometimes it works but other times it just stays the same.

VS Code version: Code 1.85.2 (8b3775030ed1a69b13e4f4c628c612102e30a681, 2024-01-18T06:40:10.514Z)
OS version: Windows_NT x64 10.0.22621
Modes:

In this example, the App class is imported from the app_model package, but it is marked as undefined and the package is not being used.

Here it is evident that the Dart Analysis Server stays loading for a long time

If this isn't the place where I should report this or it doesn't comply with any reporting format, I'm sorry, it's the first time I've posted something like this.

Hi @AlexitoSnow
Thanks for reaching VS Marketplace Team, as this issue looks specific to VS Code, could you please reach out to the VS Code Team https://github.com/microsoft/vscode/issues for further assistance.
Regards,
VS Marketplace Team


emit warnings on the fly as a rebuild happens

It's rather annoying having to wait for the entire project to rebuild everytime you fix a warning deep in a module hierarchy.

If you feel this is usefull, point me in the direction and I'll implement it.


Web - No limit message when add Message on Close account page

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.46-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:

Go to Profile> Security> Close account
Add email address
In message field add very long text

Expected Result:
There should be message that added text is very long
Actual Result:
No message about text limitation for Message field
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/44338005-0586-45f8-bdf0-b3fbbc2fc083
View all open jobs on GitHub

@kevinksullivan  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

I don't think this is worth prioritizing.


Cannot erase AWS Lex SessionAttributes

For erasing aws lex sessionAttributes I need to pass empty map according to aws lex docs (https://docs.aws.amazon.com/lex/latest/dg/context-mgmt.html)
But LexResponse uses json tag with omitempty option and aws lex won't clear sessionAttributes.
Code example: https://play.golang.org/p/Qpca-uHwGQL
I'm proposing to remove omitempty option in LexResponse struct.

Makes sense to me, feel free to open a pull-request!

Hi, I've created, please review https://github.com/aws/aws-lambda-go/pull/225


Provide low-impact alternative to transform -repartition for reducing partition size

Disclaimer: ADAM noob here, so this may be bogus.
Steps to reproduce:

Run adam-submit transform -mark_duplicate_reads ...
Open the driver webapp
Note the number of partitions, e.g. 2306
Hit Ctrl-C
Run adam-submit transform -repartition 4612 -mark_duplicate_reads ... (i.e. twice the # of partitions)

Notice how the repartition incurs a shuffle, spilling to disk. With a 288GB BAM, we saw 1.5 TB of shuffle data being spilled to disk before the second, productive stage began. The reason is that RDD.repartition() effectively scatters consecutive elements all over the partitions in the result RDD by creating a pair RDD where each key is a randomized index of the target partition, and applying a HashPartitioner. I think the intent is to produce partitions of approximately equal size even when the input RDD is unevenly partitioned. However, in the transform case, we can assume that the input RDD is already very evenly partitioned.
If the purpose of -repartition is to allow users to work around resource limitations by reducing the partition size for their workload, then it shouldn't incur an additional strain on resources. I found that I can achieve the same effect—reducing the partition size—by specifying the spark.hadoop.mapred.max.split.size property when running adam-submit. Should transform get another parameter, e.g. -max-partition-size N that explicitly sets aforementioned property to N?
I also wonder why there isn't an RDD.split( N ) that simply splits each parent partition into the given number of child partitions.

That's fair. We've got both -repartition N and -coalesce N for transform. I've generally conceived the use case for -repartition N to be when you have a small file on a large cluster, where you want to force increased parallelism, but the cost of doing a shuffle isn't too big (since the dataset is small).
I'd generally prefer to avoid modifying Spark config via command line parameters. We currently support modifying configuration via ADAM_OPTS, and I don't think there is a clean way to set a configuration parameter inside of an ADAMCommand.

sc.hadoopConfiguration.set("mapred.max.split.size","12345") should do it.
I guess this is merely a usability concern. I'm under the impression that the partition size is an important variable in the heap space vs. computation time trade-off. It may deserve more prominence, in either the UI or documentation. Maybe just add a note about spark.hadoop.mapred.max.split.size in the usage screen?
I agree wrt the small file / large cluster scenario. I was not aware of that use case.

I think we should drop this ticket as unsupported. Thoughts?

Consensus was to close this as unsupported.


npm release of version 1.1.0

hi, when do you publish the new version on npm?
Regards
erik

It's not published currently, redux-websocket-middleware name is taken we should come up with something else

What about redux-middleware-websocket?

This one is available redux-middleware-web-socket

i've published it under the name redux-mw-ws.
regards erik

Add that to the readme


Test for interactive window debugging

In order to not regress IW again, we need a test that:

Runs a cell in the IW
Debugs a different cell
Verifies the debugger stops in the original file
Verifies breakpoints work

Finished


Version update

Updating version for new deployment.

to get this to pass you'll need to:

update this branch to pull in your changes to main (either click update branch here, or run git pull origin main --ff locally)
reinstall all the packages locally (run . dev_tools/install.sh, or pip install each one)
update all the *superstaq requirements (./checks/requirements.py --apply)


"Revert Selected Ranges" not working- m.getChanges is not a function

Open https://github.com/microsoft/vscode/blob/3d2e10fa6ee6c30cbc72647dff512bf16cc94403/src/vs/workbench/contrib/notebook/browser/notebook.contribution.ts
Do "organize imports"
Select all the imports and run "Revert Selected Ranges"

2023-01-20 13:32:25.877 [error] TypeError: m.getChanges is not a function
    at cc.$getDiffInformation (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2301:14870)
    at m.N (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1573:15147)
    at m.M (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1573:14865)
    at m.H (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1573:13958)
    at m.G (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1573:12939)
    at vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1573:11727
    at p.invoke (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:86:145)
    at n.deliver (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:86:2029)
    at a.fire (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:86:1667)
    at r.fire (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:553:15221)
    at q.onmessage (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1671:1489) git.revertSelectedRanges {"value":"vscode.git","c":"vscode.git"}

I think on mac there is the same problem. When I try to revert a change within a file, there is a git error. But the git output is empty (or at least nothing new appears after trying to revert a change).

@alexr00, it looks like this is a regression that was introduced with this commit.
In that commit the getChanges() method has been removed which unfortunately is used here: https://github.com/microsoft/vscode/blob/1278cb5e744d6abf8467a199585d26ce5a53034d/src/vs/workbench/api/browser/mainThreadEditors.ts#L271-L272
I do not have full contact on why the as any cast is being used here. @joaomoreno do you have any context?

I have investigated some other issues and it looks like that commit might have a broader impact as the stage/revert  changes commands also seem to be broken. The root cause is that the vscode.git extension is expecting LineChange[] while it gets LabeledChange[]. Let's get together first thing tomorrow morning to get to the bottom of this. Thanks!

Thank you very much @alexr00 🎉

That was fixed so quickly that I didn't have time to complain :D
Thank you!


Always save ombg, innovNN, oman in variational

Description
Companion to https://github.com/JCSDA-internal/oops/pull/2749
build-group=https://github.com/JCSDA-internal/oops/pull/2749

The oops PR was merged, this can be merged too

The oops PR was merged, this can be merged too - not sure what happened to the CI

The build group should be removed now that the oops PR is merged, no?


Create 94-2048.md

Left empty video_id since the video isn't uploaded yet

@jelitter If you create a file for a video that hasn't been published yet, just omit the video_id property completely. That way, it can be merged but it won't show up on the page. If you leave it like you have it now, Jekyll expects some form of value for video_id and will give errors if there isn't one.


fix: 更改remapping字段顺序

👀 PR includes

✨ Feature

[ ] New feature

🎨 Enhance

[ ] Code style optimization
[ ] Refactoring
[ ] Change the UI
[ ] Improve the performance
[ ] Type optimization

🐛 Bugfix

[x] Solve the issue and close #1242

🔧 Chore

[ ] Test case
[ ] Docs / demos update
[ ] CI / workflow
[ ] Release version
[ ] Other ()

📝 Description
防止获取facet config时，style中同名字段被options错误覆盖
🖼 Screenshot

Before
After

❌
✅

🔗 Related issue link

🔍 Self Check before Merge

[ ] Add or update relevant Docs.
[ ] Add or update relevant Demos.
[ ] Add or update relevant TypeScript definitions.

:tada: This PR is included in version @antv/s2-v1.14.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Followup with Platform team to get their "usage tool"

Used for VW deal
Crawls all repos to get js package usage
Could replace Dash impl

Chris Tonas wants to focus on this.

Met with their team. Got a primer on the code.  Will need to fork and modify for now.

fyi, the mods to run this tool are in this repo#branch: ps-dev/oss-audit#design-system.


index.md

aliases: ios-app, ios-swift, ios10, ios11
created_by: Apple Inc.
display_name: iOS
logo: ios.png
released: June 29, 2007
short_description: iOS is the operating system for Apple's mobile products.
topic: ios
url: https://www.apple.com/ios/
wikipedia_url: https://en.wikipedia.org/wiki/IOS
iOS is the  system for all of Apple’s mobile products. The operating system was unveiled at Macworld Conference and Expo in 2007 to support the company’s new venture, the iPhone. Since then, the operating system has grown to incorporate other products, including the iPad and iPod Touch.
Thank you for contributing! Please confirm this pull request meets the following requirements:

[ x ] I followed the contributing guidelines: https://github.com/github/explore/blob/master/CONTRIBUTING.md
[ x ] I have no affiliation with the project I am suggesting (as a maintainer, creator, contractor, or employee).

Which change are you proposing?

[ x ] Suggesting edits to an existing topic or collection
[ x ] Curating a new topic or collection

Editing an existing topic or collection
I'm suggesting these edits to an existing topic or collection:

[ x ] Image (and my file is *.png, square, dimensions 288x288)
[ x ] Content (and my changes are in index.md)

Please replace this line with an explanation of why you think these changes should be made.

Curating a new topic or collection

[ x ] I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME] or https://github.com/collections/[NAME])
[ x ] My folder contains a *.png image (if applicable) and index.md
[ x ] All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/master/docs

Please replace this line with an explanation of why you think this topic or collection should be curated.

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

Fun


Uncaught TypeError: t is not a function

Describe the bug
Getting this bug in production
To Reproduce
Deploye it on vercel or use build version locally.
Screenshots

Platform
Vercel https://vercel.com
Live
https://react-do-ats1999.vercel.app/
Open dev console

@ats1999
It looks the duplicate issue(#1589).

@js87zz exactly, it's duplicate, but i created this because it's also appearing in production.

This issue is closed because the duplicate issue is resolved.