message_edit: Do not move messages that have passed the time limit.

First commit is to not treat "no topic" messages as special case wrt to topic editing.
Second second is the backend work to return error when moving messages that have passed the time limit.
Third commit is the frontend work to show the confirmation modal when user is trying to move messages that have passed the time limit.

Screenshots and screen captures:

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

Hm, let me know if I'm doing something wrong here...
I logged in as Aaron, posted a message on a topic that had some old messages, went into the "Move messages" modal from the new messages, and selected "Move all messages". The result was that the "Confirm" button is disabled; I didn't get a confirmation dialog.

Hm, let me know if I'm doing something wrong here...
I logged in as Aaron, posted a message on a topic that had some old messages, went into the "Move messages" modal from the new messages, and selected "Move all messages". The result was that the "Confirm" button is disabled; I didn't get a confirmation dialog.

The "Confirm" button is disabled until the topic/stream is changed. And just to be clear, in this PR the time limit only applies for topic editing. #23916 adds time limit for changing streams.

Ah, yeah, that helps -- thanks!
Let's tweak the modal a bit:

Add a ? at the end of the modal heading
Add a line break before "N messages will remain in the current topic."

Otherwise looks good to me!

Updated the PR -

Added ? at the end of modal heading.
Added line break before "N messages will remain in the current topic." and also updated the code to have 3 different translation blocks for 3 sentences.

Also, I noticed that the messages count in notification sent when moving the message is not correct, need to fix it.
And currently in this PR, the rule of moving messages that are recent enough applies when moving between streams also, even when there is no limit on moving messages between streams. I think completing #23916 first would help us in avoiding complicated changes in this PR.

Let's try to get this in shape fairly quickly, since the intermediate state after #23916, while coherent, is a lot less nice than the once with this finished as well.

Updated the PR.

Added a commit to not treat "no topic" messages as a special case as we discussed. Note that the "pencil" icon in recipient bar is still highlighted always without hovering for "no topic" messages.
Updated the last two commits to follow the new approach discussed in https://chat.zulip.org/#narrow/stream/378-api-design/topic/partially.20move.20messages.20as.20per.20time.20limit.20setting

Sorry, I didn't see that this was updated. Works for me in manual testing!
Let's add some vertical space before the last line in the confirmation modal -- I think that will look nicer.

When testing a different PR, I noticed that we aren't handling the case where a user is allowed to move messages to a different stream but not to a different topic correctly. The topic field in the "Move topic" modal should be disabled, and it's not:

I don't know if this PR happens to fix this?

Updated the PR.

Added space before last line in the modal.
Added commit to disable the topic input if required as per edit_topic_policy.

Can you post in "api design" the precise set of parameters in the new API response? I'd like to make sure we get feedback on that detail, and am not sure we've done that.

I think it's possible you could optimize the queries at the end of check_time_limit_for_change_all_propagate_mode for the public stream case by just fetching the set of (message_id, date_sent) values in the topic and then doing the date filtering in Python -- I believe the current construction goes to the database twice.

Updated the PR -

Modified check_time_limit_for_change_all_propagate_mode to reduce the number of queries for public stream case.
Added commit to modify the test comment. The commen may require rephrasing though.
Updated the error response variable names and added the API documentation.

Updated this for the above two details. We likely will want to rewrite the text/modal given the context I added to the API documentation, that probably in most cases we want to plant the idea of asking a moderator to do the move instead of going forward as the default action.

We can probably add a line like "You can also ask a moderator to move the complete topic instead." after "Do you want to go ahead and do that?". But we would have the text about how many messages will remain in the topic after that. So, we might want to add the text about asking moderators at the end in a new line.
Current modal -

How about something like this for the modal text?

You do not have permission to move some of the messages in this topic. Contact a moderator to move all messages.

Do you still want to move the latest 2 messages? 3 messages will remain in the current topic.

Draft copy for modal to show when a user attempts to resolve a topic where some of the messages cannot be moved:
Could not resolve topic
You only have permission to resolve newer topics in this organization. Contact a moderator to resolve this topic.

How about something like this for the modal text?

You do not have permission to move some of the messages in this topic. Contact a moderator to move all messages.

Do you still want to move the latest 2 messages? 3 messages will remain in the current topic.

Looks good to me. Will update the PR.

Can we do the resolve topic changes in a follow-up PR?

Yeah I think it's probably fine to do that, but we should aim to do those changes this week.

I missed one question in the previous comment. Do we want the text in first para shown in the modal to be something different when there is only one message which user cannot move or "do not have the permission to move some of the messages" is fine.

Updated the error message returned by API.

Yeah I think it's probably fine to do that, but we should aim to do those changes this week.

I guess this could be completed this week. Have started discussion in https://chat.zulip.org/#narrow/stream/378-api-design/topic/partially.20move.20messages.20as.20per.20time.20limit.20setting

For cross-reference: this appears to be related to #21739.


set baseBranch=development in .changeset/config.json

cc @kanej

I looked at the instructions you sent, and it appears that CD involves multiple steps with secrets/env setup. I was just trying to unblock running changeset locally, but it seems there are a few other things that need to be done as well. I would rather not update/change anything right now, and risk breaking the pipeline, so I will leave it for now.


Periods in ROM filenames yield incorrect shortcut names

Commit: https://github.com/scottrice/Ice/commit/5000749fd68c6fa7356ad38a75d148527d216ef6
When a ROM contains a '.' in the filename, it seems that the parsing of the filename stops.
For example, Dr. Mario 64.z64 puts the shortcut name as Dr with no text following.
I would suspect that it is trying to strip off the extension but this is being handled incorrectly.

It looks like it's caused by the regex string used here: https://github.com/scottrice/Ice/blob/5000749fd68c6fa7356ad38a75d148527d216ef6/ice/parsing/rom_parser.py#L10-L15

Ah, good find. Thanks for the report! Adding an example name also helps a lot, I'll work on getting this fixed.

Looks good @scottrice, can I close my pull request https://github.com/scottrice/Ice/pull/365?


adding coverage for server

Codecov Report

Merging #2 (a2dfe57) into develop (dc06790) will increase coverage by 9.96%.
The diff coverage is 77.77%.

@@             Coverage Diff             @@
##           develop       #2      +/-   ##
===========================================
+ Coverage    36.75%   46.72%   +9.96%
===========================================
  Files            4        4
  Lines          117      122       +5
===========================================
+ Hits            43       57      +14
+ Misses          66       57       -9
  Partials         8        8

Impacted Files
Coverage Δ

internal/server/server.go
63.63% <77.77%> (+63.63%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc06790...a2dfe57. Read the comment docs.


Feature/356 view a list of markets page and show additional useful information

Related issues 🔗
Closes #356
Description ℹ
Simplified version of market list of simple trading app :-). Due to no router yet in the app market list is displayed on main page now. To get percent change of the prices we have subquery for market candles. As expiry date market auctionEnd property is used.
There is also added a proposal for layout with the use of grid view.
There are a few of todos:

Live update of the list via subscription
Navigation to the market view after click
Infinitive scroll to get next portion of data - some kind of pagination on server side will be needed.

Technical 👨🔧
Components fully written in tailwind css and local components described in storybook. Grid view is used almost each case where data are presented.

Market list related stuff should be moved to libs/market-list


Trying to support alternative git servers

Generalize the _split_repo_url. Still works as exactly as before for GitHub urls but doesn't fall over for GitLab.

I was hoping I could point to our internal Jupyter-Hub server. There is no chance I can rely on Binder.

Gotcha - can you confirm that this actually works for GitLab or other repositories?


how to make two actors listener work at same time

just like this
Actor a1 = new Actor();
a1.addListener( listener() ); // listener bind a keydown action
Actor a2 = new Actor();
a2.addListener( listener() );

Stage stage = new Stage();
stage.addActor(a1);
stage.addActor(a2);

stage.setKeyboardFocus(a1);  // if miss this,not any actor could be fire

Gdx.input.setInputProcessor(stage);

then ,when I press a key,only a1's listener could reply for my acton;
how could I do to fire both two actors?
I have a idea to deal with it. like this:
public class MyStage extends Stage {

    public MyStage() {
        super();
    }
//
    @Override
    public boolean keyDown(int keyCode) {
        InputEvent event = Pools.obtain(InputEvent.class);
        event.setStage(this);
        event.setType(InputEvent.Type.keyDown);
        event.setKeyCode(keyCode);
        Array<Actor> actors = this.getActors();
        for (Actor actor:actors){
            actor.fire(event);
        }
        boolean handled = event.isHandled();
        Pools.free(event);
        return handled;

    }
}

but I don't know is it the right way to fire all actor which in a same stage.

help me

please don't ask for help here, this is a bug tracker. you should ask in Discord server instead : https://libgdx.com/community/


Fragment fontFace not detecting correctly

Windows Terminal version (or Windows build number)
1.9.1942.0
Other Software
Oh-My-Posh (latest)
Steps to reproduce
Set a default fontFace in settings.json
Set different fontFace in {fragments}.json
Review if font is displaying correctly.
If not, disable the default fontFace and revalidate.
Expected Behavior
The expected behavior is that the fontFace that is set for a profile in the {Fragments}.json file is indeed using the desired font.
Actual Behavior
When a default fontFace is set then the fontFace that is set as part of the fragment is ignored.
Removing the default fontFace string enables the fontFace that was set in the fragment to be used.

This is indicative of the problem Kayla's often talked about. Right now, the settings look like this:
   ┌─────────────────────────────────────────────────────────┐
3  │ Specific settings block for a profile guid              │ Most Important
   └─────────────────────────────────────────────────────────┘
                                                                │  │  │  │  │
   ┌─────────────────────────────────────────────────────────┐  │  │  │  │  │
2  │ User's ".defaults" settings (apply to all profiles)     │  │  │  │  │  │
   └─────────────────────────────────────────────────────────┘  │  │  │  │  │
                                                                │  │  │  │  │
   ┌─────────────────────────────────────────────────────────┐  │  │  │  │  │
1  │ Fragment                                                │  │  │  │  │  │
   └─────────────────────────────────────────────────────────┘  │  │  │  │  │
                                                                ▼  ▼  ▼  ▼  ▼
   ┌─────────────────────────┐ ┌─────────────────────────────┐
0  │ Built-in default json   │ │ Generated (wsl)             │ Least Important
   └─────────────────────────┘ └─────────────────────────────┘

Settings are read top-down. If something exists in a higher layer, it overrides the thing in the lower layer.

This is a polarizing topic, and there's really just two camps:

Fragments are generated by an application vendor, and as such represent the application's desires. The application should win over the user's desire for uniformity.
Fragments are generated by an application vendor, and as such represent the application's suggestion. The user's uniformity should win out over all application suggestions.

tagging this up for discussion, but I'm not sure what there is to discuss that we haven't already. If anything, we need to clearly document (with examples) how the layering works in cases like this.

Okay so I think our conclusion was:

#10436 will help make this clearer to the user what's happening
We should also add some variation on the above diagram to the Fragments page on the docs.

So I'm gonna leave this open to track the second bit of work. Thanks!


Feature request: custom threshold for positive/negative data display

I'm wondering if it's possible to set a custom threshold for positive/negative display of data? For example, I'd like to set a value of 5 where a value between 0-5 is red and 5-10 is blue.
It appears this functionality is only available if the value is below zero.
Thanks for your consideration.

Sure it would be possible, if I understand right you need something like https://github.com/gpbl/SwiftChart/issues/34 @Cyphontin requested.
or better, what would you expect for values below 0 and above 10 in your example?

Exactly the same request. I'll give it a shot with a pull request.

I wanted to make a PR but did not work :o/

I'll be in same boat...need to figure it out

Hi! I added my PR for this feature. Does it look like what you've been asking for?

It's exactly what I asked.  Thank a lot.

Closed by #45. Releasing soon on cocoapods. Thanks @algrid

Uh I'll release on cocoapods the next days as I'm on a limited connection and cocooapods seems to want to download the entire github 😅


Provide default implementations of factory methods when possible

The fromSpecificIterable, newSpecificBuilder, and other factory methods that are currently implemented in concrete collections only could probably have default implementations earlier in the hierarchy.

The approach I had in mind runs into a bug (or a more fundamental language problem?) in Scala (but would work in Dotty): https://github.com/scala/bug/issues/10725


Improve UI

Test it for breaking responsiveness and show tweets Twitter style.

We can use Polymer for native feel.


Ease install of packages in our workstations

Write some documentation on how to install this package in our workstations
We should describe that you have to follow the Dockerfile to install the system libraries required

We should specify that gcc>=5 is necessary to build the mesher, where gcc 4.8 is installed by default in our 14.04 workstations.
Here is a guide on how to install a newer gcc version
https://gist.github.com/application2000/73fd6f4bf1be6600a2cf9f56315a2d91

Just to write it down, I was able to run python setup.py develop with gcc 6.3.0 after removing these lines: https://github.com/seung-lab/neuroglancer/blob/master/python/ext/src/on_demand_object_mesh_generator.cc#L32-L37
That recommendation came from @nicholasturner1.
Maybe want to separate Precomputed API from the mesher, too. Also probably want to mention how to get a google-secret.json & aws-secret.json. I just pulled them from another workstation.

I figured out why you guys are having trouble with that line but I'm not. # __has_include is a C++17 feature that hasn't made it into gcc yet. On osx, gcc is by default an alias for clang, which includes support.

https://clang.llvm.org/docs/LanguageExtensions.html
I should add this:
// To avoid problem with non-clang compilers not having this macro.
#if defined(__has_include)
#if __has_include("myinclude.h")
# include "myinclude.h"
#endif
#endif


Investigate using MUST on 422 response

In https://github.com/openservicebrokerapi/servicebroker/pull/409 in the "accepts_incomplete=true" section, we say that the Broker SHOULD return a 422 if "accepts_incomplete" is false and the broker knows it can't process the request in time. We should look into whether we can make it a MUST so that platforms can be guaranteed of the status code.

I believe this is now fixed, and we use MUST for all sections regarding accepts_incomplete=false


KDE support

Hi,
I'd like to integrate your library in my project but it does not seem to support KDE. It instead uses the Gnome file picker which is a very suboptimal experience with a KDE setup. Beyond the different interface, it does not integrate with favorite locations or lacks many navigation controls.
Would it be possible to add KDE support?

I just filed issue #42, which is potentially a solution that could solve this problem. Experiment #42 provides a runtime check to see if GTK/GLIB is available and then dlopens the libraries if available to use them.
In principle, somebody could implement a Qt or KDE backend using the same technique, and we could try to make the autodetection smarter (somehow?) to figure out which desktop environment the user uses and pick the more appropriate one. This does presume that there is some stable ABI we can rely on which I'm not sure is something we can depend on since C++ is notorious for NOT providing a stable ABI. (But if we assume we are probably only targeting Unix/Glibc platforms, maybe this can sneak by assuming Qt itself is stable enough in terms of ABI.)
And this of course is predicated on whether I can make Experiment #42 reliable. (There is a crash I need help with.)

Thanks.
Support for KDE is very important to me, but I also had some troubles to integrate this library with my builds (it does not use CMake and I am not a C/C++ expert). So it was easier for me to write a similar library in Rust, with support for both Qt and Gtk (link). The issue is that at the moment I also have to determine at compile time which library will be used for Linux. I was also planning to add support for dynamic linking.
Regarding how to pick the environment, I asked a SO question. There does not seem to be a reliable way yo do it. By checking xdg-util, I decided to settle on checking the environment to guess the desktop environment and then use Qt for KDE and LXQt, otherwise GTK.

The status of KDE support:
I am willing to accept a kdialog PR that meets the standards laid out in https://github.com/mlabbe/nativefiledialog/blob/master/docs/submitting_pull_requests.md

Having switched from GNOME to a KDE (Plasma) based distro I have also wanted to see support for KDE, so I began implementing my own, based on the kde_zenity.c source. Currently I only need to open single files, so only NFD_OpenDialog works. It uses the command strings kdialog, --getopenfilename, --title=Open File. Deriving from Zenity looks very straightforward.
I'm still trying to figure how how KDE applies filters for several file types as their documentation isn't very clear for lists of types. (would rather keep using file name extensions rather than MIME file format)

Having switched from GNOME to a KDE (Plasma) based distro I have also wanted to see support for KDE, so I began implementing my own, based on the kde_zenity.c source. Currently I only need to open single files, so only NFD_OpenDialog works. It uses the command strings kdialog, --getopenfilename, --title=Open File. Deriving from Zenity looks very straightforward.
I'm still trying to figure how how KDE applies filters for several file types as their documentation isn't very clear for lists of types. (would rather keep using file name extensions rather than MIME file format)

@ccajas I am supportive of this effort continuing to be built by the community.  If you can link to a PR containing your changes perhaps someone else would be interested in filling out your work until it is ready.

@ccajas I am supportive of this effort continuing to be built by the community.  If you can link to a PR containing your changes perhaps someone else would be interested in filling out your work until it is ready.

Just passing by but I noticed this, and this looks very much the wrong way to open a file dialog box on linux, regardless of the desktop environment.  Both GTK and KDE (and others) support the DBUS freedesktop spec for file dialog boxes, see here for that API.  You can just call the FileChooser in the dbus desktop portal and whatever desktop the user has running will open a file dialog box (open or save as you request, a variety of options are able to be passed in via the variant map as well if you wish to constrain to specific file extensions or whatever else).
In short just access the local session dbus port, call with the service name of org.freedesktop.portal.Desktop on path /org/freedesktop/portal/desktop and using the object name of org.freedesktop.portal.FileChooser call the appropriate method of OpenFile/SaveFile/SaveFiles with the appropriate arguments (parent window or none if you don't want it parented, the title, and the variant map of options), and you'll get the reply handle back, just wait for a reply on it (poll it every once in a while or so) until you get a response, which will contain whether it was successful, the file path if an openfile or the success result on save file(s).
This will handle KDE, GTK, and others, basically any DE that follows the freedesktop spec (all of them? or at least all the bigger ones) and will open their native file handling dialog for whatever that may be for them.

Also, another bonus with following the freedesktop spec, open dialog's will also work even if the application is running sandboxed, like via snap/flatpak or so for the people that use those, where if you just call for an open dialog box functions directly in the kde/gtk/etc API's then it will not have access to any user allowed files.

While this is the cleaner solution, would there be any concern about the freedesktop portals not being installed on the user's system?  There are questions like this one which suggest that not all users have the portals on their systems - not sure if this solution would impact usability.

I am pretty sure one or the other portal is guaranteed to be installed. For example kde portal is required by plasma-meta package. Portals are not exactly old thing though. This library predates existence of portals. Maybe a parallel dbus-based implementation would be a good idea if support for ancient systems is desired.

While this is the cleaner solution, would there be any concern about the freedesktop portals not being installed on the user's system? There are questions like this one which suggest that not all users have the portals on their systems - not sure if this solution would impact usability.

Can fall back to other methods.  If they don't have a freedesktop portal (are there any DE's that don't that are still active?) then I'm not even sure what you could even call out to at that point.

Maybe a parallel dbus-based implementation would be a good idea if support for ancient systems is desired.

Yep, manually calling out to things at that point could be warranted, each option should probably be behind feature flags though, like I'd probably want to only compile with dbus support, I don't want to be linking in random other things when possible.


TURN server support

I see that in code there are placeholders for the stun server support. Is there a plan to finish it?

The "simple" webRTC implementation we are using probably doesn't fully support TURN. but a browser implementation (or using the pre-built chrome WebRTC implementation) will use stun/turn fully which the peer server fully supports sending the configuration for.
One change I am looking at doing is dumping the simple webRTC library completely and switching to another library that is more stable and hopefully feature complete (it's actively developed).


HTTPS to HTTP

Hi, how to redirect HTTPS to HTTP?

This type of questions is more suited to the community https://caddy.community, this is not a bug.
Why would you want to redirect from secure to insecure ? The norm is the opposite.
However, you can leverage redir.


Unresolvable type reference or unsupported built-in utility type 以及热更新失败

Vue version
3.4.25
Link to minimal reproduction
https://play.vuejs.org/#eNp9kk1P3DAQhv/K1IculWiiqj2tslvRAgLElwCJiy8hOxsM/pI9WRZF+e+MvSLhgDhEiud5x37noxcH3hebDsVcVLEJyhNEpM6Drm27kIKiFEtplfEuEPQQcA0DrIMzMOO02Yjo1SPzQzTuOjgfR1VRJhRZKW3jbCTwmS9ghWtlMaurMW+592NSmtiyjt/cm52g1g7uXdCrbzOWVOXOLpvjA6HxuibkE0D1+GvZ9zl5GKqSTzmqrO8INj+NW6Hm0phLASXDqvyQL/a5aH5+rdriKTrLnelTvhSNM15pDFeeFNuTYg6ZJFazu5ezHKPQ4f57vHnE5vmT+FPcppgU1wEjhg1KMTKqQ4u0w0e3l7jl/xGy+06z+gt4g9HpLnncyf51dsW2P+iy29M8OGXbu3i0JbTxvahkNCmHrJeC5/z/i9Inu7+LPzlP2iF1MY29oMgNHNfn2AVzcndxfkAU1ENHOO1J3qbA0+QPt9NOTRu14DcZAtja4N85RL7Dtik0wPdPrk5EDG9+JvpQ
Steps to reproduce
使用 vue 内置的类型 FormHTMLAttributes 作为 props，报 ’Unresolvable type reference or unsupported built-in utility type’

移除 FormHTMLAttributes  后热更新失败（热更新没有任何反应）
What is expected?
no response
What is actually happening?
no response
System Info
No response
Any additional comments?
No response

The resolution has some bugs that are resolved in a476692ed, but it does not completely fix the usage.
Note that by including FormHTMLAttributes you are going to declare hundreds of props and the runtime declaration will be very large - this is probably not what you want, I assume you only want the component to accept those as props at the type level, and treat them as fallthrough attributes at runtime.
If that is what you want, in the next patch you will be able to use /* @vue-ignore */ on it (landed in a23e99bed):
export type DemoProps = {
  name?: string
} & /* @vue-ignore */ FormHTMLAttributes

This will allow you to pass FormHTMLAttributes at the type level, but treat them as fallthrough at runtime.


Error  'Sentry' is not defined  no-undef

I have followed the instructions and I got this error Error  'Sentry' is not defined  no-undef
Gatsby: 2.2.9,
React: 16.8.5,
Gatsby-sentry: 1.0.1,
Node: 10.15.3,

Hi @MatteoGioioso, my company's site just broke because of this.
Were you able to fix this or did you went back to a traditional Sentry setup?

@jmz7v as this package did not work at that time, I went for a classic approach and place Sentry report into ErrorBoundary

Thank you @MatteoGioioso!
Will do the same.

just want to bump this issue as currently the setup instructions on gatsbyjs.org are not working

ok found a solution, if in the future someone stumbles upon this thread :)
the problem is only the eslint rule of no-undef
You just manually need to add Sentry with
/*global Sentry*/

https://eslint.org/docs/rules/no-undef
@jmz7v @MatteoGioioso


Establish compatibility with OTP 23+, Elixir 1.12+

In order to stay current with elixir / OTP releases, we need to verify that the library compiles and runs tests under more recent versions of elixir and erlang.
While the CI test matrix currently covers elixir 1.12 and OTP 23, my local tests do not run under that version combo. Instead, either one test runs or no tests run and the mix test execution never completes.

I have tested a couple of combinations locally and observed the following results (version strings below are from asdf):

elixir 1.12.3-otp-22, erlang <IP_ADDRESS>: PASS
elixir 1.12.3-otp-23, erlang <IP_ADDRESS>: FAIL

I was able to get newer versions working in CI by updating rustler to 0.25.0. I am still unable to run tests locally on my m1 mac with any OTP above 22.

I have updated all of the outdated dependencies, but the problem I originally observed where tests hang is still present with elixir 1.13.4 and OTP 23. I will ask a question on the relevant slack / matrix channels for rustler.

I was able to run a linux VM locally (ubuntu 22 / arm64), and I got the same three test failures:

test/ex_gpgme/context_test.exs:221
test/ex_gpgme/context_test.exs:285
test/ex_gpgme/context_test.exs:198

Also, I was unable to get the library to build with OTP 23 as it returned several warnings and errors around OpenSSL function name conflicts. Switching to OTP 24 allowed the library to build as expected.

I opened https://github.com/rusterlium/rustler/issues/480 since I had enough information to narrow the scope of the problem.


jarjar -e -m 0 results in an error

jarjar -e -m 0 or even jarjar -e -m "0" results in an error: missing_text_or_fallback_or_attachments

covered by #10


Use moban template for appveyor

Hi, I'm GitMate.io!
It seems you've just enabled the issue triaging. I'm just scraping all issues from your repository and will give you some more information about this in a few minutes or so.
Because of the rate limit we can't scrape all information (including all comments and authors) right now - our system is already set up to scrape this in the next days over which the predictions will become more precise every day.
If you want me to use a different account for triaging your issues, simply create one and log in with it.
Sit tight!

Blocked by https://github.com/coala/coala-bears/pull/2641.


Quick way to check accuracy of trained model

Understand I can use score.py, but is there a way to get a general accuracy of a trained model and evaluated against a dataset?

For obtaining MT metrics, you should use the utils/evaluate_from_file.py script.

Hi @lvapeab ,
Tried running the script but I get this error, I'm evaluating Chinese texts.
$ python utils/evaluate_from_file.py -m bleu -l cn -t local/CnTrans/test_mini.cn -r local/CnTrans/test_mini.cn
language cn <codecs.StreamReaderWriter object at 0x00000218B0A76518>
The number of references is 1
[<_io.TextIOWrapper name='local/CnTrans/test_mini.cn' mode='r' encoding='cp936'>]
Traceback (most recent call last):
  File "utils/evaluate_from_file.py", line 118, in <module>
    evaluate_from_file(parser.parse_args())
  File "utils/evaluate_from_file.py", line 93, in evaluate_from_file
    ref, hypothesis = load_textfiles(args.references, hypotheses_file)
  File "utils/evaluate_from_file.py", line 36, in load_textfiles
    raw_refs = list([list(map(str.strip, r)) for r in list(zip(*references))])
UnicodeDecodeError: 'gbk' codec can't decode byte 0xa2 in position 22: illegal multibyte sequence
(nmt-keras)

It seems there is an encoding problem with your default encoding (cp936). I've uploaded a fix for always using utf-8. Make git pull and run the script again.


Add credentials into the profile.

Would you accept a PR that allows storing the credentials in a file in the user's ~/.config dir? I know that you don't intend to maintain it, but we can't fork the PyPI name :( I'd be happy to maintain it for you, though, if you want.

Hey @skorokithakis!
It looks like PyPI stopped recording download stats earlier this year, but I just checked and was surprised to see so many downloads for this library: http://pypi-ranking.info/module/imgur-uploader
If you're up for the job of maintaining it, I'll happily give you full control and make you an owner on PyPI.
I can also make you a full collaborator on this repo, or you can fork it and update PyPI to point to your repo.
How does that sound?

Either way sounds good to me, I've forked it because I wanted to add the credentials, so whichever way works for you is fine by me.
Thanks!

Alright - you're an Owner on PyPI and I just updated the README on this repo with a big notice pointing to your fork.
Let me know if there's anything else you need from me. And of course, thanks for taking stewardship of the project.

Thank you!


Fix game of life example on macos

[x] Describe in common words what is the purpose of this change, related
Github Issues, and highlight important implementation aspects.

[x] Run cargo fmt on the changes.

I noticed that on my macos the create_vk_surface_from_handle encounters an error:
[mvk-error] VK_ERROR_INITIALIZATION_FAILED: vkCreateMacOSSurfaceMVK(): On-screen rendering requires a layer of type CAMetalLayer.

What is done in winit_to_surface prevents this. I wasn't even sure why the handle version was used anyway...

I'm not on MacOS so I can't test this, but it seems like a simple enough fix. Can you explain why this fixes it though, and is it maybe something that should be documented in these two functions?

@hakolao Can you address @Rua's question, please?

Apologies for the delay! @Eliah-Lakhin @Rua
CAMetalLayer is the native rendering surface of Apple’s Metal framework. It is required to be able to render on mac. It looks like that the winit_to_surface function ensures this layer is set to the ns_view before passing it to Surface::from_mac_os.
Without that, the direct create_surface_from_handle fails to above error.
Some references: https://github.com/KhronosGroup/MoltenVK/issues/78
https://www.khronos.org/registry/vulkan/specs/1.3-extensions/man/html/VK_EXT_metal_surface.html
This could be documented somewhere, however I'd think that having it searchable on github might also be enough, and those who use or should use create_surface_from_handle are probably very few. I thought I needed it, but turned out I did not...

I think this should be included as documentation on create_surface_from_handle so that users know they may need to do this manually. It's not very user friendly to ask them to search on Github.

Ok, I’ll add it there!

@Rua would this be better now? I extracted the layer setting to its own function, so if someone wants to use the from_handle they can then call that function also on macos.


[CoroutineAccessors] Add read and modify.

Enable parsing the new keywords behind the CoroutineAccessors experimental feature.

https://github.com/swiftlang/swift/pull/76526
@swift-ci please test

https://github.com/swiftlang/swift/pull/76526
@swift-ci please test

Accidentally opened this PR from a branch in this repo rather than my fork.  Closing in favor of the one from my fork: https://github.com/swiftlang/swift-syntax/pull/2855 .


Chronograf Run Module

This PR does the following:

Include run-chronograf script to update the config and start up the Chronograf service
Update install-chronograf script to install run-chronograf script in /opt/chronograf/bin
Update install-chronograf script to disable Chronograf service so it doesn't start up on first instance boot
Adds Chronograf to Packer template that includes the entire TICK stack*
Adds Chronograf to local docker example, tick-single-cluster
Add Chronograf local docker example, tick-multi-cluster

Late in, but LGTM!


Select element not implemented fully?

Hi, really enjoying the project, great idea.
I'm trying to use a select element, but I'm not sure it's fully implemented. I couldn't find an Option type, so I had to define one:
public class Option : Element
{
	public Option()
		: base("option")
	{
	}

	string _value = "";
	public string Value
	{
		get => _value;
		set => SetProperty(ref _value, value ?? "", "value");
	}
}

but then I couldn't find a way to get the SelectedIndex of the current element from the Select in the ChangedHandler, and the Selects Value property is null, even with an item selected . Am I doing it wrong?

You're doing it right, but there is something going on that I don't understand.
I'll have to write a test to understand what's missing.

I fixed the Value property of Select to read the right values. Please see the Draw sample for an example of its use.

Thanks!
On 9 Dec 2017 21:24, "Frank A. Krueger"<EMAIL_ADDRESS>wrote:

I fixed the Value property of Select to read the right values. Please see
the Draw sample for an example of its use.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/praeclarum/Ooui/issues/40#issuecomment-350506500, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAQ0-j2AhFR9gsbjrnhaMRNXndkvBCdRks5s-vqNgaJpZM4Qus7-
.


Build failing on master

This is causing problems downstream (e.g. StatsBase).

I will try to take a look this evening.

Looks like it is something related to convert and unsafe_convert for pointers.

My bad. I forgot to import unsafe_convert. It is fixed now. I'll also tag a new version.


New version of glob uses different syntax

Instead of glob.globSync they now have glob.sync
Affected line is line number 3 in brequire.js
Seemed to fix the problems for me

I've removed build mode since browserify does a better job


Error when building iOS app

Getting the following error after upgrading to 4.0.0:
../../../Flutter/flutter/.pub-cache/hosted/pub.dartlang.org/flutter_translate-4.0.0/lib/src/utils/device_locale.dart:11:49: Error: Property 'window' cannot be accessed on 'WidgetsBinding?' because it is potentially null.
     - 'WidgetsBinding' is from 'package:flutter/src/widgets/binding.dart' ('../../../Flutter/flutter/packages/flutter/lib/src/widgets/binding.dart').
    Try accessing using ?. instead.
      final deviceLocales = WidgetsBinding.instance.window.locales;

Flutter Doctor output:
Flutter (Channel stable, 2.10.5, on macOS 12.3.1 21E258 darwin-arm, locale
    en-DE)
    • Flutter version 2.10.5 at /Users/janbrinkmann/Flutter/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 5464c5bac7 (2 weeks ago), 2022-04-18 09:55:37 -0700
    • Engine revision 57d3bac3dd
    • Dart version 2.16.2
    • DevTools version 2.9.2

Yes it seems this issue occurs in stable channel.

Seems like 4.0.1 doesn't contain the changes i made

Fixed now in 4.0.2

Confirm, thanks for the quick response!

Hello, it seems like this bug is present again in 4.0.3


Update to Grafana 9.5.1

Keep up to date with the latest Grafana toolkit.

Codecov Report
Patch and project coverage have no change.

Comparison is base (9b7fbf8) 73.68% compared to head (59210e8) 73.68%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #40   +/-   ##
=======================================
  Coverage   73.68%   73.68%
=======================================
  Files          25       25
  Lines         304      304
  Branches       33       33
=======================================
  Hits          224      224
  Misses         68       68
  Partials       12       12

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Add turbulette CLI

What kind of change does this PR introduce? (check at least one)

[ ] Bugfix
[x] Feature
[ ] Code style update
[ ] Refactor
[ ] Build-related changes
[ ] Other, please describe:

Does this PR introduce a breaking change? (check one)

[ ] Yes
[x] No

If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:

[x] It's submitted to the dev, not the master branch
[ ] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
[x] All tests are passing
[x] New/updated tests are included

Other information:

Codecov Report

Merging #8 into develop will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##           develop        #8   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           40        41    +1
  Lines          802       870   +68
=========================================
+ Hits           802       870   +68

Impacted Files
Coverage Δ

turbulette/conf/constants.py
100.00% <100.00%> (ø)

turbulette/core/management/cli.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbf5642...bb015a2. Read the comment docs.


ReferenceError: process is not defined

Describe the bug
When building with esbuild, I get the following error: ReferenceError: process is not defined.
To Reproduce
Steps to reproduce the behavior:

create a sample app with esbuild
add your component
See error

Additional context
https://github.com/the-bugging/react-use-downloader/blob/e473b8c31e6fc680da1d89b5236cabeec657a99d/src/index.ts#L124
update to
 const debugMode = process?.env?.REACT_APP_DEBUG_MODE

still errors when it tries to access process. This worked for me :
  let debugMode = false;
  try {
    if (process) {
      debugMode = !!process?.env?.REACT_APP_DEBUG_MODE;
    }
  } catch (err) {
    //Your error handling
  }

Hey guys, thank you for opening this issue. I'm having a hard time managing time in between things, you know, would you be so kind opening a PR for this fix? I'd gladly review and I'd really appreciate it

@all-contributors please add @peranosborn and @MarcosRS for bug, idea

Thank you again, guys, it should be fixed now on version<EMAIL_ADDRESS>If anything just let me know.
https://github.com/all-contributors please add @MarcosRS for bug, idea

@all-contributors please add @MarcosRS for bug, idea

Thank you for fixing this issue for us


boolean field - renderer doesn't detect string "0" as false

I'm not sure, if there are internal checks for all normal edge cases, but I currently have some data with ones and zeros instead of true/false. The renderer displays "On" for all values, because my zero is a string, which returns true.
The reason: I work on implenting MySQL (InnoDB) as an addon. MySQL has no boolean field and I have to work with tinyint.

@raffaelj How is you progress on the addon?
I'm assuming that you decided to use one SQL column per document property/ field?

@piotr-cz I was very busy and had to pause the project. I'll publish it in a few weeks. Send me a private message if you want to have a look at it earlier.
My addon is no sql driver, like yours. I use Cockpit to manage an existing database with m:n relations and yes, I use one column per field.


CLI changes needed for BBS+

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Closed as BBS+ ended up being implemented differently in ssi


Format CSV does not include ReadableDate

The format XML has this column and data, but the format CSV does not.

The CSV spits out exactly what the database contains, basically. The readable date is manually created when generating the XML. I currently have no plans to add it as an output due to the amount of additional per-entry processing.


Issues with pagehead and pagehead-action classes

Hi, I am using primer css build that I fetched via<EMAIL_ADDRESS>(I also later used the latest one I got via a npm install primer.
I have found that the following snippet:

<button class="btn btn-sm" href="#url">Action</button>

<button class="btn btn-sm btn-primary" href="#url">Action</button>

Inventory

does not get me the intended formatting on the page and instead lands me something of this order

I ended up inspecting the build.css and found no instances of either pagehead or pagehead-actions..... what gives?
Thanks

I inspected https://styleguide.github.com/primer/components/pagehead/ and foundout that .pagehead is found over at https://styleguide.github.com/assets/github/styleguide.css
For now I am just importing that in my page as a secondary stylesheet.
Am I holding this wrong or ...?

hey @surajrav the pagehead component is not apart of primer yet.
See https://github.com/primer/primer/issues/539#issuecomment-409981806 from August 2nd, and still the current status at the time of writing this.

We could do a better job of making it clear which components live in the GitHub app source, but for now you can tell by the absence of a package and version indicator on the style guide reference: anything with a package name and version listed is part of Primer; any component without lives elsewhere, and should be considered a “private” API.

oh cool thanks for the clarification @AustinPaquette
For now I have "stolen" that component from the styleguide.css and await it landing in the main lib soon.
Since, this is a non-issue I shall go ahead and close it.


New feature about permission and owner of log file

Hi all ~
I'm using concurrent-log-handler very usefully.
But I had some problem about permission and owner of log file. Our company put a primium on security. So we set limited permission and owner on log files.
Unfortunately, the concurrent-log-handler has not feature to set permission and owner on log file. So I made default log file with touch command and I set permission and owner it with chmod and chown command.
Finally, I guess that this problem about permission and owner of log file is done.
But the problem occrued when the log file was rotated.
A permission of the new log file after rotating was different with original log file which was made by me. A permission of original log file was 660 but a permission of new log file was 644.
In the end, I decied adding new feature to set permission and owner on log file.
This pull request about it.
Please check this feature and codes.
Thank you!!
P.S
I'm developing and operating my service only on linux. So this feature only tested on linux.

Hello,
Thank you for this PR! This looks like a very useful feature. I will start a detailed review soon.
I do need to make sure the changes won't break Windows users. At first glance that looks ok, as long as you don't try to set owner and chmod on Windows. May need to guard against that. It would be nice if similar functionality was available on Windows but the model is quite a bit different.
In fact, what would be potentially useful on both platforms is an option to retain the existing security settings without needing to specify what those are. I'm thinking that should be the default behavior anyway - to try to preserve the owner and permissions of the rollover file.

I created a PR to your PR with a Windows compatibility fix. If you accept to to your branch I can accept this one. Thanks.

I absolutely sympathize with your opinion about windows compatibility.
So, I've accepted your code.
Thank you for your response and code.


'IUnknown': ambiguous symbol (compiling source file App.xaml.cpp)

Describe the bug
I am trying to use IMMDevice and CComPtr in my WinUI 3 desktop application but I got an error like the title.
However, the issue didn't occur on my another project.
Therefore, I did some research and found that the error can be reproduced with specific declaration sequence.
Please see the reproduce steps.
Steps to reproduce the bug

Create a C++ WinUI 3 desktop packaged with WAP project
Add

#include <atlbase.h>
#include <mmdeviceapi.h>
#include <vector>

to MainWindow.xaml.h

Add

std::vector<CComPtr<IMMDevice>> devices;

as a member of MainWindow class.

Build
You will get the error like title.
Add

CComPtr<IMMDevice> device;

before above devices variable.
It will look like:
CComPtr<IMMDevice> device;
std::vector<CComPtr<IMMDevice>> devices;

Build
No any error will be received.

Expected behavior
No response
Screenshots
No response
NuGet package version
No response
Windows app type

[ ] UWP
[X] Win32

Device form factor
Desktop
Windows version
Windows 11 (22H2): Build 22621
Additional context
Microsoft.Windows.CppWinRT v2.0.210806.1
Microsoft.Windows.ImplementationLibrary v1.0.211019.2
Microsoft.Windows.SDK.BuildTools v10.0.22000.194
Microsoft.Windows.AppSDK v1.1.3

Yup, this is one of the problems of the default template code. It designed to allow you to quickly start writing code, but it has some problems. Including wrl.h also causes problems.
The problem here is that the start of the file has:
using namespace winrt;
using namespace Windows::Foundation;

This causes your problem because it brings winrt::Windows::Foundation into the global scope. To help with the C++/WinRT projection, there exists a couple of helper wrappers. The two biggest ones are winrt::Windows::Foundation::IInspectable and, because IInspectable derives from it, winrt::Windows::Foundation::IUnknown. This means that in App.xaml.cpp, an unqualified IUnknown could refer to ::IUnknown as defined in unknwn.h, or winrt::Windows::Foundation::IUnknown as defined as part of the C++/WinRT projection.
When I start a new project with WinUI, one of the first things I do is sort out the namespaces in App.xaml.cpp. So as an example of what I do:
#include "pch.h"

#include "App.xaml.h"
#include "MainWindow.xaml.h"

namespace winrt
{
    //Makes wf an alias of winrt::Windows::Foundation
    namespace wf = Windows::Foundation;
    //Makes mux an alias of winrt::Microsoft::UI::Xaml
    namespace mux = Microsoft::UI::Xaml;
    //Makes muxc an alias of winrt::Microsoft::UI::Xaml::Controls
    namespace muxc = Microsoft::UI::Xaml::Controls;
    //Makes muxn an alias of winrt::Microsoft::UI::Xaml::Navigation
    namespace muxn = Microsoft::UI::Xaml::Navigation;
}

// To learn more about WinUI, the WinUI project structure,
// and more about our project templates, see: http://aka.ms/winui-project-info.

namespace winrt::App2::implementation
{
    /// <summary>
    /// Initializes the singleton application object.  This is the first line of authored code
    /// executed, and as such is the logical equivalent of main() or WinMain().
    /// </summary>
    App::App()
    {
        InitializeComponent();

#if defined _DEBUG && !defined DISABLE_XAML_GENERATED_BREAK_ON_UNHANDLED_EXCEPTION
        UnhandledException([this](wf::IInspectable const &, mux::UnhandledExceptionEventArgs const &e)
            {
                if (IsDebuggerPresent())
                {
                    auto errorMessage = e.Message();
                    __debugbreak();
                }
            });
#endif
    }

    /// <summary>
    /// Invoked when the application is launched normally by the end user.  Other entry points
    /// will be used such as when the application is launched to open a specific file.
    /// </summary>
    /// <param name="e">Details about the launch request and process.</param>
    void App::OnLaunched(mux::LaunchActivatedEventArgs const &)
    {
        window = make<MainWindow>();
        window.Activate();
    }
}

The namespace App2 comes from the fact that the project is named App2. But as you can see, I use namespaces and namespace aliases to qualify names. With this code, IUnknown would unambiguously refer to ::IUnknown since you need to use a fully qualified name to refer to winrt::Windows::Foundation::IUnknown.

@DarranRowe Thanks for your help.
It works well!
IMHO, the MSFT team still needs to solve this problem for better user experience...

@DarranRowe Thanks for your help.
It works well!
However, the MSFT team still needs to solve this problem for better user experience...

@petercoin, closing this issue as you now have a workaround.  If you have any ideas for how to improve use of COM interfaces without negatively impacting more common scenarios, please create a feature request.


Poor Performance with bigbird-roberta-base

Hi @OhadRubin ,
Replacing Grappa based encoder with bigbird-roberta-base, yields validation accuracy of just 40.8%.
Is this expected because best_validation_spider is not pre-trained using the Grappa-based objectives?
Thanks,

Hey,
Yes, this is expected. SmBoP was hyperparameters were tuned w.r.t GraPPa, if you change a major part of the model like the encoder, you need to perform HP tuning again.


Building suddenly failed...

Details

Project URL: https://github.com/qnzhou/PyMesh
Build URL (if applicable): https://readthedocs.org/projects/pymesh/builds/5323255/
Read the Docs username (if applicable):

Expected Result
My doc has been building fine for a long time.  However, It seems the RTD suddenly changes the build steps for my project.  It simply fails to build after a commit with nothing to do with doc.
Actual Result
It seems the building script is looking for docs/requirements.txt.  Is it possible to know the exact steps of the doc building process?  Existing doc seems to suggest requirements.txt is optionals (and I don't see where docs comes from).

What's your setting here in your RTD project?

On the other hand, you have a doc/requirements.txt file in your repo at: https://github.com/qnzhou/PyMesh/blob/master/doc/requirements.txt and it's blank. Probably has nothing to do, but anyway, I don't understand what's that useful for :)

I did not set the requirements file.

The empty doc/requirements.txt was not used, and should be deleted.  Another observation is that suddenly RTD switch to python3.5 instead of python2.7 used before for my build.

Is it all right that the command running the -r docs/requirements.txt is -rdocs/requirements.txt...

The original issue looks cleared up, but looking into recent builds, your project has a broken git submodule configuration:
Build failed with unhandled exception: No option 'path' in section: u'submodule "pybind11"'

Closing this as not an issue with RTD, but feel free to reopen if you come across something we're doing wrong.

Thanks @agjohnson !  I was wondering why the recent build fails.  Where did you find the error info?  I cannot find this error message from the logs.


Treat .env as its own configuration source to simplify precedence logic

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/2138
Originally created by @DouweM on 2020-07-06 23:56:37

View 2 previous comments from the original issue on GitLab


Bruuh you need serious in gujarati language.....

Don't use Google translator to add Gujarati else it will become inappropriate ...... Do you think Google can actually translate Indian regional languages accurately?

I can help in upgrading strings for whole Gujarati Hindi and Marathi ( dheere dheere )


Create 0024_auto_20181103_1340.py

Hi @alfuhigi. Have closed this, as these changes are unlikely to pass tests on their own. Please see #286.


text.trimEnd is not a function

Environment (please complete the following information):

**Node.js version:10.14.0
**NPM version:6.5.0

Describe the bug
When I install the prettier through NPM in my project, prettier in VScode extension is not working, when I save the the file it is not formatting.when ever I hit the save button in prettier output it is showing
"text.trimEnd is not a function"
If I uninstall the prettier through NPM it is working as normal.
Also I can format the it using nom commands.
To Reproduce
Steps to reproduce the behavior:

install prettier in VScode from extensions

in VScode Settings enable the format on save and check the Required 'prettierconfig' to format.

npm i -D prettier;

write the below code int he scripts section of the package.json file
"format": "prettier "src/**/*.{html,js,jsx}

create .prettierrc file in root folder

[Include code or an example repository that can easily be set up]
Expected behavior
A clear and concise description of what you expected to happen.
when I save the file it should format the code, as I enable the format on save
Snapshots
If applicable, add snapshots to help explain your problem.
Additional context
Add any other context about the problem here.

Not applicable


[Suggestion] More Item Conduit upgrades

Compared to the other conduits, the item conduits have no real upgrades. They are allready more powerfull than most other item transfer systems right from the beginning, A few Speedupgrades make them unmatched.
So how about configs for:
Base number of items per transfer.
Transfer increase per speedupgrade.
Changeing the ticks between transfers.
And also a new channelupgrade. So the item conduits by themself have only one color and to unlock the other 15, upgrades must be inserted.
Maybe another speedupgrade that lowers the ticks beween transfers.
That way they would scale much better and with configs everyone can decide how weak they would start and how powerfull they could become.

The speed upgrades are already very modular - without upgrades it is 4 items / second which I think is a good speed for the cost of the item conduits.
The ticks between transfers depends on the speed upgrades and how many items have been transferred previously. So it should also scale nicely as is.
The channels are an integral part of the conduits - and that won't change.

Everyone has a different opinion about the "right" speed.
The fluid conduits have a bunch of confing options to balance it but the item conduits have nothing like that so we must take them as they are.
In my experience the item conduits are so powerful, that no one even tries to use others when they are in the modpack.
As it currently stands, i will remove EnderIO from my modpack because of that. Or at last completely remove the item conduits with minetweaker.

It is an open source mod, public domain at that. You're welcome to submit pull requests or use your own fork. Not really much reason to come here and say that you're going to remove the mod from the pack you added it to if one of the devs doesn't have any desire to implement your feature.

extra utilities: wireless teleport, stack / tick if needed, nestable filters, pipes cost stone+glass+1pcs redstone
translocators: moves a stack with 1 pcs of glowstone, filters are built in, fancy as hell
steve's factory: every possible feature ...
ae: almost everything or even more...

I can go on for pages, if the players in your modpack does only use enderio for item transportation, then that's there own fault, I like item conduits and the filter and speed upgrades feels perfectly balanced, no1 crafts a stack of electrical steel and dumps it into each and every connection because /just/, if you look at it peeps only upgrade their conduits to the level where they needed.


python3Packages.yalesmartalarmclient: init at 0.3.1

Motivation for this change
Python module to interface with Yale Smart Alarm Systems
https://github.com/domwillcode/yale-smart-alarm-client
This is a Home Assistant dependency.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 113791 run on x86_64-linux 1

3 packages built:

python37Packages.yalesmartalarmclient
python38Packages.yalesmartalarmclient
python39Packages.yalesmartalarmclient

Result of nixpkgs-review pr 113791 at 308d4d10 run on aarch64-linux 1

3 packages built:

python37Packages.yalesmartalarmclient
python38Packages.yalesmartalarmclient
python39Packages.yalesmartalarmclient

@GrahamcOfBorg build python38Packages.yalesmartalarmclient python39Packages.yalesmartalarmclient


Add UnaryWithParam, UnaryOpType binding to TTNN and replace FusibleActivation

[x] Create new binding for FusibleActivation in TTNN library to replace reference to tt_eager  and eltwise_unary_op.hpp
[x] Change the reference used in ttnn.UnaryWithParam and ttnn.UnaryOpType to use the new binding

UnaryWithParam = ttnn._ttnn.deprecated.tensor.FusibleActivationWithParam
UnaryOpType = ttnn._ttnn.deprecated.tensor.FusibleActivation

[x] To replace references of the function UnaryWithParam and enum UnaryOpType to ttnn/eltwise/unary

using ttnn::operations::unary::UnaryWithParam;
using ttnn::operations::unary::UnaryOpType;

[x] UnaryWithParam is used as a parameter std::optional<UnaryWithParam> in binary ops, matmul ops etc.

[x] Replace usage of tt_lib.tensor.FusibleActivation in models and tests

Merged to main


Fix inter-artifact comparisons.

There were two cases in Pex locks that could lead to TypeError being
raised:

A locked resolve with more than one locked requirement for a given
pin where each locked requirement had differing primary artifact
types.
A locked requirement with more than one additional artifact where
the additional artifact types were not homogeneous.

It's not clear how either of these cases can arise, but case 1. did in
the wild using the vendored Pip (20.3.4).

E           TypeError: '<' not supported between instances of 'VCSArtifact' and 'FileArtifact'
...
============================================================================================ short test summary info =============================================================================================
FAILED tests/resolve/test_locked_resolve.py::test_locked_requirement_mixed_artifacts_issue_2150 - TypeError: '<' not supported between instances of 'VCSArtifact' and 'FileArtifact'
FAILED tests/resolve/test_locked_resolve.py::test_locked_resolve_same_pins_mixed_primary_artifacts_issue_2150 - TypeError: '<' not supported between instances of 'VCSArtifact' and 'FileArtifact'
============================================================================ 2 failed, 18 passed, 641 deselected, 1 warning in 0.46s =============================================================================
...


Rename topology section to Overview

The change removes duplicity of  names of the section and the link inside the section to have the same name (topology)

@miq-bot add_label providers/containers, ui

@martinpovolny please review. thanks!

@martinpovolny thanks. do you need to relate it to a milestone flag?

@abonas: all PRs are supposed to be related with a milestone flag corresponding with the current sprint


Publinova connection

What are we going to do with webhooks?

People fill out "other" as copyright. That's probably a mistake?

Is it possible to associate links with products? So not a file, but some kind of URL. How does this information come from the API?

Note that since webhooks are not actually implemented the code kinda makes some assumptions about how webhooks will be send to the endpoint. Next to all the usual API properties we also expect a "state" which is "active" or "deleted". Indices will update according to this state and without a state errors will occur.


TsInterface should not have exported static members

For example the following java class
@TsInterface
@TsName(namespace = "dh")
public class HasEventHandling {

    @JsProperty(namespace = "dh.Client")
    public static final String EVENT_REQUEST_FAILED = "requestfailed";

}

will produce the following TS
export namespace dh {

   export interface HasEventHandling {

      get EVENT_REQUEST_FAILED():string;

   }

}

we need to error out for TsInterface static members.

Note that this might be related to the attempt to export the property to a different type, which we've agreed should be forbidden (at least for now).


datasource as environment variables

hello
is it possible to provide data source credentials via ENV variables  in future releases? editing .jar looks pretty much awful this days.
thank you

sure, it is possible.

The question is, why do you need this project as it was created for particular users.

The question is, why do you need this project as it was created for particular users.

Алексей из Ремарка, когда просит обновить ПО, занимает лишнее время...

will be done soon


Web pages cannot correctly identify and download image links.

Environment

Operating System: debian 10
node --version: v20.12.2
npm --version: 10.7.0
yarn --version, if using Yarn:
percollate --version: v4.2.1

Description
Thank you for answering my question.
Images requiring a Referer header are not fetched
Another minor issue mentioned in this question has not yet been resolved.
chromium --headless --incognito --dump-dom  https://mp.weixin.qq.com/s/Yr9naXOZSPHlR3XDHVJ8tQ | percollate html --url https://mp.weixin.qq.com/s/Yr9naXOZSPHlR3XDHVJ8tQ - --inline

chromium --headless --incognito --dump-dom  https://mp.weixin.qq.com/s/Yr9naXOZSPHlR3XDHVJ8tQ | percollate epub --url https://mp.weixin.qq.com/s/Yr9naXOZSPHlR3XDHVJ8tQ -

EPUB and HTML cannot download images; even when using the --inline parameter, HTML still displays image URLs, whereas PDF can correctly display images.
Thanks.

I am currently using a non-conventional method to solve the problem of downloading images, which involves using the sed command to modify the HTML image links into image formats (such as png, etc.).
I tried asking ChatGPT how to solve this problem, and it suggested installing Cheerio library to get the image links. For images without a suffix, it also recommended using the mime-types library to obtain the MIME type from the response headers to determine the file extension.

Thanks for the report, it seems that something is not hooked up correctly when the HTML content comes via the standard input. Will investigate!

I have a question: how can I modify the following command to bundle multiple web pages into one EPUB?Thanks!
chromium --headless --incognito --dump-dom  https://mp.weixin.qq.com/s/B_-_5k0JMiDoWWTAv7aSbw|sed -e 's/\(\?wx_fmt=png\)[^"]*/.png/gI' -e 's/\(\?wx_fmt=jpe\?g\)[^"]*/.jpg/gI' -e 's/\(\?wx_fmt=gif\)[^"]*/.gif/gI'| percollate epub https://mp.weixin.qq.com/s/B_-_5k0JMiDoWWTAv7aSbw -

In the example from the first message, image URLs don’t use a file extension that allows us to identify the image format. In #178 I’ve made a change so that such images receive a generic image MIME media type. Similarly, images collected as resource files for bundling inside EPUB will be saved with an .image file extension and a image MIME type.
The extent to which the EPUB reader can render images with such a MIME type depends on the application, but it’s the best we can do at the moment.

I have a question: how can I modify the following command to bundle multiple web pages into one EPUB?Thanks!

To bundle several pages fetched with an external tool (in this case chromium), you can try saving them to files on the disk and then using something like:
percollate epub file1.html --url=url1 file2.html --url=url2 ...

Released as<EMAIL_ADDRESS>


Arbitrary Python objects

Maybe this is totally off, but would it even be possible to support arbitrary Python objects? For example, if I had a Python function like this:
class Input(TypedDict):
  type: Literal["http"]
  status_code: int
  method: Literal["GET", "PUT"]
  callback: Callable[[], None]

class Output(TypedDict):
  message: str
  callback: Callable[[], None]

def process(inp: Input) -> Output:
  assert inp["type"] == "http"
  status_code = input["status_code"]
  assert 99 < status_code < 600
  method = input["method"]
  assert method in ("GET", "PUT")
  msg = f'{method} {status_code}"
  return Output(message, inp["callback"])

This crate is super convenient to parse and validate type, status_code and method since you can make a declarative serve model for this:
#[derive(Serialize, Deserialize]
#[serde(rename_all = "UPPERCASE")]
enum Method {
  Get,
  Post,
}

#[derive(Serialize, Deserialize]
struct HTTPMessage {
  status_code: u32,
  method: Method,
}

#[derive(Serialize, Deserialize]
#[serde(tag = "type")]
enum Message {
  Http(HTTPMessage),
}

But as far as I can tell there is no way to say "make the callback key a Py<PyAny>. In other words, something like:
#[derive(Serialize, Deserialize]
struct HTTPMessage {
  status_code: u32,
  method: Method,
  callback: Py<PyAny>,
}

Is that right?

Hello, sorry for the very slow response. You're correct at the moment this isn't possible.
I wonder if Pythonize and Depythonize traits could solve this problem. They could have blanket implementations for T: Serialize (or Deserialize) and then Python types which aren't serde-compatible could be handled separately. Other than that, I'm not aware of a way that we could hook into serde to achieve this.
(This problem is very related to #1 I think.)

To deal with this in a current project, I've been using a proxy class that can wrap an object and make it look like a dict to depythonize, that looks something like:
class DictProxy(collections.abc.Mapping):
    _inner = None
    _keys = None

    def __init__(self, inner, aliases=None):
        self._aliases = aliases or {}
        self._inner = inner
        self._keys = [k for k in dir(inner) if not k.startswith("_")]
        for alias in self._aliases:
            if alias not in self._keys:
                self._keys.append(alias)

    def __getitem__(self, key):
        if key in self._aliases:
            alias = self._aliases[key]
            if type(alias) is str:
                return getattr(self._inner, self._aliases[key])
            else:
                return alias(self._inner)
        elif key in self._keys:
            return getattr(self._inner, key)
        else:
            raise KeyError

    def __iter__(self):
        yield from self._keys

    def __len__(self):
        return len(self._keys)

    def __contains__(self, key):
        return key in self._keys

    def keys(self):
        return list(self._keys)

I only need to go in the Python -> Rust direction, but I think a similar approach could work in the other direction as well. One semi-major frustration at the moment, though: as currently implemented, the deserializer for mappings calls both .keys() and .values() on the incoming map, and eagerly evaluates the returned iterators, which means every field on the object gets accessed, including @property fields (which get evaluated), even if those fields aren't actually needed in the deserialization. At least in my application, this is resulting in some unnecessary slow/expensive calls, and I haven't yet figured out a way around it.
It doesn't seem like there's any reason it has to work that way, but that's how it works now. I think if object deserialization were to be explicitly supported, some kind of laziness would be important.

Given that pythonize doesn't yet support arbitrary python objects it is not as powerful as pickle which means that it doesn't have the same security concerns as pickle does. If you manage to support arbitrary python objects it's worth considering to leave a function that doesn't support the full set of python objects as that is a feature in of itself in terms of keeping security tight.

I'm using dill (or pickle) to serialize any python object.


Syntax fix

Euwe Backport conflict:
$ git cherry-pick -e -x -m 1  fdf3f03
error: could not apply fdf3f03... Merge pull request #187 from mzazrivec/syntax_fix
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'
hint: and commit the result with 'git commit'

$ git status
On branch euwe
Your branch is up-to-date with 'upstream/euwe'.
You are currently cherry-picking commit fdf3f03.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)

	both modified:   client/app/components/flowchart/node-toolbar.html

no changes added to commit (use "git add" and/or "git commit -a")

$ git diff

diff --cc client/app/components/flowchart/node-toolbar.html
index 32f9980,c8843e4..0000000
--- a/client/app/components/flowchart/node-toolbar.html
+++ b/client/app/components/flowchart/node-toolbar.html
@@@ -9,7 -9,7 +9,11 @@@

        </button>

{{vm.node.name()}} {{"Tags" | translate}}

++<<<<<<< HEAD
 +      <tagging-widget tags="vm.tags" object-type="service_templates" object-id="vm.node.id()"/>
++=======
+       <tagging-widget tags-of-item="vm.tagsOfItem"/>
++>>>>>>> fdf3f03... Merge pull request #187 from mzazrivec/syntax_fix

@chriskacerguis @mzazrivec Maybe a different PR needs to have been backported for this fix to apply.  If this is needed for euwe branch, please resolve merge conflict, make PR against euwe branch and assign to me.

@chessbyte I was wrong, this PR is not euwe material.


If done to exact spec, App will crash on launch.

If done completely to spec, the emulator run will crash on launch. Needs many included imports and includes some deprecated features. The app builds correctly but will crash on the emulator.

@Mroussell can you please describe the errors you're getting?

@Mroussell I am facing the same error. When run on the emulator it crashes on launch. Logcat indicates:
Caused by: java.lang.IllegalStateException: Cannot call useEmulator() after instance has already been initialized.
What caused it is from a code  block  in MainActivity:
if (BuildConfig.DEBUG) {             Firebase.database.useEmulator("<IP_ADDRESS>", 9000)     //error             Firebase.auth.useEmulator("<IP_ADDRESS>", 9099)             Firebase.storage.useEmulator("<IP_ADDRESS>", 9199) }
How to overcome that?


Fix pass header argument

This is a quick fix, but I guess the more right name for cli arguments it headers

@IvanGoncharov hey, do you have time to review this PR?

@vomchik Thanks 👍
Merged 🎉

@vomchik Released 1.9.2 📦
Can you please test it?

@IvanGoncharov yes, works fine. thanks for a quick response!


changing telegram bot to use webhook instead of updates api

Codecov Report
Attention: Patch coverage is 18.75000% with 26 lines in your changes are missing coverage. Please review.

Project coverage is 53.18%. Comparing base (8c895fc) to head (712dc8c).
Report is 5 commits behind head on dev.

Files
Patch %
Lines

anyway/telegram_accident_notifications.py
16.66%
15 Missing :warning:

anyway/flask_app.py
8.33%
11 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2576      +/-   ##
==========================================
+ Coverage   52.96%   53.18%   +0.21%
==========================================
  Files         119      119
  Lines        9834     9868      +34
==========================================
+ Hits         5209     5248      +39
+ Misses       4625     4620       -5

Flag
Coverage Δ

unittests
53.18% <18.75%> (+0.21%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

as long as the secret values are not committed to git, and kept in .env file or something like that, it's fine

@tkalir see Ori's answer, you can add the vars (w/o the secrets of course) to our docker-compose files


Didn't support  Content-Security-Policy

Already present: http://caniuse.com/#feat=contentsecuritypolicy


feat(Shortcuts): Add shortcut to toggle devmode and open the web inspector

What this PR does 📖

@phillsatellite this is a bug with the keyboard shortcuts, we need to add some logic so that if there is no keybind set it will use the default one. We can open a new ticket for this. This will happen for any new keybinds we add until we add this fix.


refactor modules

An issue tracker for modules (and example) refactor.
Introduction
The key points to address when refactoring the modules:

promote resource names to the variables level - this should affect resources(vnets, route tables, NSGs), not sub-resources (subnets, UDRs, NSG rules)
define types for all variables, even complex ones, use optional keyword
bump min supported TF version to 1.3
migrate to new documentation format:

README in document layout
introduction, purpose, usage should be moved to .header.md
every variable should have a description, where the 1st sentence (ending with a .) should contain a summary
when documenting complex types, follow the format described below
keep the variables in variables.tf in order that makes sense (see below)
keep the description of variables that repeat between example the same, like name or tags (see below for a copy&paste pattern to follow)

get rid of lookup/try statements where possible -> relay on default values (for complex variables as well)
get rid of boolean variables that do not add any value, like enable_zones - use smart defaults instead
be bold, if you see some old code, or you think something can be done better, DO IT (this will be a breaking change anyway 😄 )
when you work on a module, do fix all examples using that module. Make sure the code is the same across all examples
~add tests to you module (follow #337)~ TBD
inside module, add a comment with link to terraform registry before a resource block, like this:# https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/linux_virtual_machine_scale_set
resource "azurerm_linux_virtual_machine_scale_set" "example" {
name                = "example-vmss"
...

Issues per module

[x] #325
[x] #326
[ ] #327
[ ] #328
[x] #329
[x] #330
[x] #331
[x] #332
[x] #333
[x] #334
[x] #335
[x] #337
[x] #336

Variables ordering
Some basic principals:

unless a module is constructed in a different way, variables.tf should start with these vars in this particular order:

name
resource_group_name
locations
tags

keep vars related to the same type of resource next to each other, i.e. create_subnets should be next to subnets
order the variables, either:

based on decision steps when designing infrastructure, i.e. create_subnets 1st, then subnets definition (you have to decide if you create subnets, or do you source them, then you provide the specs, which will differ based on your decision)
based on dependencies between resources, i.e. you define NSGs and RTs 1st, then Subnets, as in subnets variable we point to already defined NSGs and RTs.
if no other criteria matches, based on importance or usage frequency.

Keep in mind that his order will be retained in a README.md.
Description format
Follow the example below:
description = <<-EOF
A short, one sentence description of the variable.

Some more detailed description, can be multiple lines.

List of either required or important properties:

- `name`                   - (`string`, required) name of the Network Security Group.
- `some_optional_value`    - (`string`, optional, defaults to `null`) some description
- `some_complex_property`  - (`map`, optional) A list of objects representing something.
  - `name`                    - (`string`, required) name of the something
  - `some_number`             - (`number`, optional, defaults to `5`) numeric value
  - `some_value_1`            - (`string`, required, mutually exclusive with `some_value_2`) some description
  - `some_value_2`            - (`string`, required, mutually exclusive with `some_value_1`) some description
  - `some_optional_value`     - (`bool`, optional, defaults to `false`)

List of other, optional properties:

- `less_important_1`    - (`string`, optional, defaults to `null`) some description
- `less_important_2`    - (`string`, optional, defaults Azure defaults) some description
- `less_important_3`    - (`string`, optional, defaults to `""`) some description
- `less_important_4`    - (`list(string)`, optional, defaults to `[]`) some description

Example:
```hcl
{
  "object_1" = {
    name = "name of object 1"
    .....
  }
}
```
EOF

Common variables
Replace the following variables with this definitions:
variable "name" {
  description = "The name of the Azure Virtual Network."
  type        = string
}

variable "resource_group_name" {
  description = "The name of the Resource Group to use."
  type        = string
}

variable "location" {
  description = "The name of the Azure region to deploy the resources in."
  type        = string
}

variable "tags" {
  description = "The map of tags to assign to all created resources."
  default     = {}
  type        = map(string)
}

A NOTE: I think we should add these guidelines to somewhere like CONTRIBUTING before closing this issue; in order to follow the same conventions in the future.


class components

can this be used in class components (without hooks)

Hey @Jagadeesz, as long as React version matches ("react": "^16 || ^17") - that being at least v16.x.x or v17.x.x - which is the version in which hooks were introduced it will work, even in a class-based component declaration. It won't work on versions below 16th, because this package uses hooks.


Initial support for accessibility

While likely far from being complete, this pull request adds some initial support to make c3 charts more accessible:

adding a few WAI ARIA annotations (on tooltips, lines, grid focus)
making the charts keyboard navigable
making tooltips more accessible

Hi Team,
Hi Team, is there any update on this bug?

Hi Team,
Any update on this issue?

Hi Team,
Any update on this issue?


Fixes #2790 file handling for custom user add/edit forms/views

This PR fixes the following issue: "Custom user image field." #2790
I added file handling to support custom user add/edit forms.

Hi @Eraldo - thanks for this!
Instead of adding enctype="multipart/form-data" all the time, it would be better to check {% if form.is_multipart %}, as we've done in https://github.com/torchbox/wagtail/pull/2420/files - please could you add this?
We also need a test for this (although that'll probably require some updates to the test models / forms in https://github.com/torchbox/wagtail/blob/master/wagtail/tests/customuser/models.py and https://github.com/torchbox/wagtail/blob/master/wagtail/wagtailusers/tests.py).

Thank you @gasman for your feedback.
I am working on the tests. :)
What is wagtails recommended way to "mock" an image object for the tests?
Since 1.8 I use file-like objects.
Django docs:
New in Django 1.8:
The ability to use a file-like object was added.

However I am not sure if that would do for wagtail.
Apart from that I am finished integrating your feedback.
Feedback is wanted.

Hi @Eraldo,
There's some code for creating a test image at https://github.com/torchbox/wagtail/blob/master/wagtail/wagtailimages/tests/utils.py . I don't think we really need to test with an image file here, though - a plain FileField would work just as well for confirming that file uploads work, and that would simplify the test (see https://github.com/takeflight/wagtail/blob/de0af8769ff1cc11ea7d614ed55a99d48360e9f7/wagtail/wagtailsnippets/tests.py#L179-L188 for example).

Thank you for the hint and pointers.
I updated the tests accordingly to use "document" as a model attribute (field) instead of an "image".
I ran the test and got some errors. Just some mistakes on my side.
I learned that it is not a good idea to name a user model attribute document (especially when using wagtail).
Now everything is going smoothly.
Ran 1925 tests in 92.478s
OK (skipped=45, expected failures=2)

@gasman Does that work for you?

@gasman I tried to rebase my code on the current master since there were some updates on the side of wagtail. Somehow this ticket was closed by accident.
My code is still there.

Sorry I messed up. Please use the new one: 2799
(based on the current master)


Loosen the constraint on serializing/deserializing ndarrays in np_shape semantics

Description
np_shape semantics was introduced to support future NumPy operators where scalar tensors and zero-size tensors are common to see. Due to the concern on the potential issues of backward compatibility when this semantics is enabled, such as different handling on scalar tensors w/ or w/o this semantics, serializing/deserializing was simply marked as unsupported when this semantics is enabled.
At the moment, DGL developers want to enable this semantics in their work to support zero-size tensors. Simply disabling serializing/deserializing ndarrays of all types: dense, sparse, zero-size, and scalars would make their unit tests fail in np_shape semantics.
After careful consideration, we decided to loosen the constraint to support serialization/deserialization in the semantics of np_shape for ndarrays satisfying ALL the following three conditions as it would be the same as handling future NumPy ndarrays.

The storage type MUST be default type, i.e. this is a dense ndarray.
The ndarray CANNOT be a zero-size ndarray, i.e. with shape like (2, 0, 3).
The ndarray CANNOT be a scalar ndarray, i.e. with shape ().

Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
[x] Changes are complete (i.e. I finished coding on this PR)
[x] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[x] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
[x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@mxnet-label-bot add [NDArray]

@zheng-da Please test this PR in DGL to see if any test of saving/loading zero-size tensors is broken before merge.

@reminisce I checked with DGL. it works fine.


Error when trying to use version 1.0.0 with radium

Hello, I've been trying to upgrade radium to use version 1.0.0 of your library with  however doing so and running the radium tests gives me the following errors:
START:
08 03 2016 10:09:35.544:INFO [karma]: Karma v0.13.21 server started at http://localhost:8080/
08 03 2016 10:09:35.553:INFO [launcher]: Starting browser PhantomJS
08 03 2016 10:09:36.385:INFO [PhantomJS 1.9.8 (Mac OS X 0.0.0)]: Connected on socket /#FoTscCSsKMIAWLOIAAAA with id 57301862
PhantomJS 1.9.8 (Mac OS X 0.0.0) ERROR
  ReferenceError: Can't find variable: Set
  at /Users/cwa21/radium/src/__tests__/enhancer-test.js:20600

It looks like maybe inline-style-prefixer or inline-style-prefixer-all isn't distributing using babel properly? I've spent a while investigating this but I've hit a bit of a wall. I've managed to get the tests to run if I use an es5 shim for PhantomJS into their karama tests but that doesn't seem to be good solution.
Do you have any pointers or ideas?

In fact, I am using ES2015 Set to do faster lookups for properties (compared to array/object). Babel though does not transpile Set. As far as I learned it is considered best practice to provide polyfills with a library but rather let the users choose their own.
So if you're adding e.g. es6-set before your tests, everything should work as expected.
I guess this is worth pointing out in the README directly. I kind of forgot about that, thanks!

I guess this solved the problem, if not feel free to reopen.


⚠ ClamAV has degraded performance

In 4f7eeef, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 54 ms

Resolved: ClamAV performance has improved in 945a939 after 5 minutes.


Add manualRules to tailoredProfile CRD

This PR enables users to disable automated checks on rules so that they can check those rules manually. They can do that by adding rules under manualRules in TailoredProfile Spec.
ex.
apiVersion: compliance.openshift.io/v1alpha1
kind: TailoredProfile
metadata:
  name: mod-node
spec:
  title: My modified profile with manual rules
  manualRules:
  - name: ocp4-kubelet-eviction-thresholds-set-soft-imagefs-available
    rationale: test
  description: test

First off, I'd like to hear from others what do they think. To expand on what's been requested -- some of our rules, for example those that check SCCs for being very privileged don't take into account customer customizations.
The SCCs example checks that there exists one SCC that allows all capabilities and its name is privileged. We've seen reports where the rule would fail because there are custom SCCs that are almost as privileged so they make the rule fail. One option we've offered so far was to tailor out the rule completely, but we've seen pushback on that as well because a tailored rule is "hidden" from the reports and doesn't prompt you to actually go and check the SCCs. A rule that returns MANUAL would.
So I'm OK with this approach personally, but because it touches the API, I'd like to hear from others, maybe there is a different solution. @mrogers950 @rhmdnd @JAORMX

I think the approach makes sense.

/retest

/retest

/retest


PARMS.DAT download facility

coords need to be able to download PARMS.DAT files (member login)

To discuss with Doug/Pat/Brenda and myself.

To define work-flow first.

No longer needed - will be done online.


Thanks!

Thanks a lot for the amazing boilerplate, this really helped me to think in a better way. I hope i will do some good contributions soon, still learning ... :)

Thank you @zsajjad! Contributions are always welcome.


Is it possible to pass in a custom transport?

I'm trying to add response caching via hishel transports, but am not seeing a way to customize the transport used by the Crawlee client as it is created internally in _get_client():
    def _get_client(self, proxy_url: str | None) -> httpx.AsyncClient:
        """Helper to get a HTTP client for the given proxy URL.

        If the client for the given proxy URL doesn't exist, it will be created and stored.
        """
        if proxy_url not in self._client_by_proxy_url:
            # Prepare a default kwargs for the new client.
            kwargs: dict[str, Any] = {
                'transport': _HttpxTransport(
                    proxy=proxy_url,
                    http1=self._http1,
                    http2=self._http2,
                ),
                'proxy': proxy_url,
                'http1': self._http1,
                'http2': self._http2,
            }

            # Update the default kwargs with any additional user-provided kwargs.
            kwargs.update(self._async_client_kwargs)

            client = httpx.AsyncClient(**kwargs)
            self._client_by_proxy_url[proxy_url] = client

        return self._client_by_proxy_url[proxy_url]

Is there a way to customize the httpx client transport that I'm not seeing?
Or instead of using a 3rd party library, does Crawlee have a native method for storing long term persistent caches of responses?
Somewhat related question, if its not possible to customize the transport.  Is overriding HttpxHttpClient._get_client() the recommended way to use a custom httpx client, or is there a cleaner way?
    hishel_client = await _create_hishel_client(cache_path)
    class HishelCacheClient(HttpxHttpClient):
        def _get_client(self, proxy_url: str | None) -> httpx.AsyncClient:
            return hishel_client
    http_client = HishelCacheClient()

    crawler = BeautifulSoupCrawler(
        http_client=http_client,
    )

Hey @tleyden , thank you for your interest in crawlee.
Indeed, there's currently no way to pass a custom transport to HttpxHttpClient. I'm not entirely sure if we should add such capability. Since a transport can significantly affect client behavior, making it unpredictable, adding this feature requires careful consideration. Perhaps @janbuchar or @vdusek have some thoughts on this.
Regarding your proposed solution. Please note that it completely disables proxy usage. You might want to keep the current _get_client implementation and only modify the transport definition.

Indeed, there's currently no way to pass a custom transport to HttpxHttpClient. I'm not entirely sure if we should add such capability. Since a transport can significantly affect client behavior, making it unpredictable, adding this feature requires careful consideration. Perhaps @janbuchar or @vdusek have some thoughts on this.

I agree with @Mantisus here. Unless there is significant demand from the community, I don't think we should allow custom transports. Perhaps adding a _create_httpx_client method that you could override in a subclass may help?
If you want to take the reins completely, you're free to implement your own subclass of BaseHttpClient and use HttpxHttpClient as inspiration.

Thank you @janbuchar and @Mantisus for the help!
I ended up overriding the transport with this code:
    hishel_transport: hishel.AsyncCacheTransport = _create_hishel_transport(cache_path)
    crawlee_client = HttpxHttpClient(transport=hishel_transport)

    crawler = BeautifulSoupCrawler(
        http_client=crawlee_client,
    )

and will keep in mind the risks of using a custom transport.

@tleyden cool, I'll just repeat that your client will be missing proxy settings in this case. Glad you solved the problem to your satisfaction :slightly_smiling_face:


VsyncSchedulingOverhead timeline event reported using system clock instead of Dart_TimelineGetMicros()

We are getting a VsyncSchedulingOverhead "b" and "e" event that is way beyond the expected time range of the request (985 days beyond, to be exact).
It looks like this is caused by us using fml::TimePoint::Now() to determine the times that are passed to fml::tracing::TraceEventAsyncComplete in shell/common/animator.cc, resulting in an extremely zoomed out timeline when rendered in DevTools.
cc @jason-simmons @chinmaygarde @cbracken @kenzieschmoll

Sorry, Ben - I was mistaken the first time. It is actually ~1 day beyond the expected time range (not 985). Accidentally converted from ms instead of micros. Nevertheless, still a problem it would be great to get a quick fix for.

This looks an easy fix to animator.cc. I'll patch it.

[issue-triage]
Should this be closed? (it has exceeded the waiting response timeout)!

@chinmaygarde any update here?

Can we get a fix for this issue? This is complicating trace event processing, especially now that we are trying to convert the timeline to be live.

A similar problem is happening with SceneDisplayLag events:
{name: SceneDisplayLag, cat: Embedder, tid: 41475, pid: 19780, ts:<PHONE_NUMBER>8, ph: b, id: 163, args: {frame_target_time:<PHONE_NUMBER>1500, current_frame_target_time:<PHONE_NUMBER>8166, vsync_transitions_missed: 1}}

{name: SceneDisplayLag, cat: Embedder, tid: 41475, pid: 19780, ts:<PHONE_NUMBER>4, ph: e, id: 163, args: {frame_target_time:<PHONE_NUMBER>1500, current_frame_target_time:<PHONE_NUMBER>8166, vsync_transitions_missed: 1}}

I would argue this is higher priority than P3. If we can't guarantee that timeline events are sharing a common clock, this breaks a lot of assumptions based on timestamps that are necessary for processing events in the Chrome Trace Event Format.

Our workaround for this is also proving to be flaky. We are currently checking if we have any spurious timestamps that are out of our expected range - we are using the arbitrary value of 16 hours outside of range - but if the two different clocks are actually closer than that, this workaround fails. I saw yesterday that the clocks can be within an hour of each other, so it seems like there may not be any guarantees about how far apart these two clocks are.

cc @iskakaushik who was also working on accurately figuring out startup times.

Dart_TimelineGetTicks was exposed in a VM patch. @iskakaushik s next task is to wire this up in the engine.

It appears the VsyncSchedulingOverhead events are still causing some problems. Here's an example where the timestamp of the VsyncSchedulingOverhead event is after the previous events. Not sure if this is because the time clock is still off or if vmService.getVMTimeline is returning events out of timestamp order (though I suspect the former is more likely).
flutter: attempting to process {name: PipelineItem, cat: Embedder, tid: 22795, pid: 24167, ts:<PHONE_NUMBER>84, ph: b, id: 81, args: {}}
flutter: attempting to process {name: PipelineProduce, cat: Embedder, tid: 22795, pid: 24167, ts:<PHONE_NUMBER>85, ph: b, id: 81, args: {}}
flutter: attempting to process {name: VsyncSchedulingOverhead, cat: Embedder, tid: 22795, pid: 24167, ts:<PHONE_NUMBER>73, ph: b, id: 153, args: {}}

@kenzieschmoll would you mind filing a different issue for this? Looks like the time bases are in-order. I ran into this issue before as well, timeline event ordering wasn't aligned for async events.

Done - filed https://github.com/flutter/flutter/issues/88056. Thanks.


add new theme name of mellow for hexo

create a new theme of hexo, name of mellow, material design

Close due to duplicate.


Publish a library+tool snap

We should publish it as a snap. I have reserved the name wamp
We should aim to have it available on pypi, independent of autobahn-python (needs discussion)
Long stretch: we should also have builds for Mac/Windows as well.

Reasons: Our CLI tool should be the entry point for anyone coming to WAMP/Crossbar/Autobahn, think of it as curl or httpie but for WAMP proto. Ideas welcome.

IMO, if we publish another snap, that snap should be autobahn, and this bundles the CLI. is there an autobahn snap?

so there is no autobahn snap package: https://snapcraft.io/search?q=autobahn

We should publish it as a snap. I have reserved the name wamp

my view: no, we should not publish a separate snap, but an autobahn snap (including the library and any tools the library bundles)

We should aim to have it available on pypi, independent of autobahn-python (

my view: no, why separate?

Long stretch: we should also have builds for Mac/Windows as well.

my view: what do you mean with "builds"? a binary package for windows or mac?

We reverted the change, more details in the PR.