Supporting native ads on iOS

Thanks for this great package.
Is there any plans to support native ads on iOS?

Hey! Unfortunately no :/. The current implementation was made with android in mind, and porting it to iOS is hard (some people have tried and didn't have success). I also can't do it myself because I don't have a mac, so porting it to iOS depends on the community.

Well, this is a bit misleading then... You named your package "native_admob_flutter" and even the README shows iOS as supported platform. We were in hope that we can use the Widgets, which btw work great on Android, on iOS too, in a near future.

We were in hope that we can use the Widgets

This was my plan for this plugin from the beggining, but it isn't a viable option, then I decided to make it look mostly like widgets.
Using Widgets should come from google (in their admob plugin). It's their framework and it's their ad server, it shouldn't be up to the community to do so. There are a lot things I'd like to do with this plugin but I can't because of such limitations, and there's nothing I can do about it.
The reason NativeAds in iOS isn't supported is because of Android. The current implementation was thought on Android and I had no idea how it's like to program in SwiftUI (iOS) the time I developed this. Porting this to iOS means I'd need to recreate the whole NativeAd implementation in a way it'd be good for both SwiftUI and for Android
Also, I think everyone should read Developer's note at the top of the NativeAd wiki.

Also, you could just set up macOS on VMWare.

Unfortunally this isn't a viable option. A macOS VM takes more than 15GB of disk, and I'm not doing this.
Either way, if anyone want to do the iOS implementation for iOS, I can guide you through discord: https://discord.gg/674gpDQUVq
Bruno.

Using Widgets should come from google (in their admob plugin). It's their framework and it's their ad server
I totally agree here! When they announced google_admob recently, I was hoping they've tackled this issue, which they didn't, and this is something that pisses me off. They just did something, that some developers have had already done before, like you did, but IMHO, you even did a better job 👍

I'd love to contribute, but I'm absolutely not familiar with Swift/Kotlin.
I hope someone is willing to pick up on the iOS side, this would really be helpful.

Unfortunally this isn't a viable option. A macOS VM takes more than 15GB of disk, and I'm not doing this.
 You can run the example app and the native ads looks kinda the same, but it's totally not stable. The thing left to do is make it look like the same as Android, which I can't achieve.

Dude, are u workin' on an Raspberry Pi with 64GB SD-card? 😂😂

🤣

And my goal, when I started to make this app, was to make a plugin better than flutter_native_admob, which I achieved.

I hope someone made it.

Thanks for your great plugin. This plugin is much more performant than the official google_mobile_ads plugin. I just wanted to know if the support for iOS is implemented or not? because the docs says it does. However I haven't been able to make it work on iOS. The app just jumps out, and in xCode I get the following error:
Module 'native_admob_flutter' not found

@ramtinq It is implemented. Can you try running flutter clean?

Thank you. The problem was caused by me forgetting to run pod install in ios directory after adding this plugin to my pubspec.yaml.
Now I have another problem: The UI in iOS is too much laggy after adding Native ads via this plugin. Without ads, the app runs on my iOS device smoother than my android device, so the problem shouldn't probably be with the iOS device having lower hardware resources.
In Android however, showing a Native ad via this plugin seems not to affect the smoothness/performance at all.
PS: I'm showing native ads inside draggable Positioned widgets.
would be so much thankful if any improvements could be made on the iOS support of this plugin.
Thanks.

True. The performance issues would be there even after the full-support for iOS because it uses hybrid composition. In Android, Virtual Display is used by default, but unfortunatelly it's not enabled on iOS. Even the official google_mobile_ads plugin have the same performance issue. Tho in release mode it shouldn't affect performance the way it does on debug mode.


imu subscriber stopping subscribing ?!!

Hi, my imu subscriber is into UnitreeHW.pp -> init()
ros::Subscriber sub = root_nh.subscribe("imu/data", 1000, &UnitreeHW::imuCallback, this);
The imu callback is :
void UnitreeHW::imuCallback(const sensor_msgs::Imu::ConstPtr& imu_message){

  //ROS_INFO("****************** Imu Orientation x: [%f], y: [%f], z: [%f], w: [%f]", imu_message->orientation.x,
          //imu_message->orientation.y,imu_message->orientation.z,imu_message->orientation.w);
  imuData_.ori_[0]        = imu_message->orientation.x;
  imuData_.ori_[1]        = imu_message->orientation.y;
  imuData_.ori_[2]        = imu_message->orientation.z;
  imuData_.ori_[3]        = imu_message->orientation.w; // TODO : is this 4rd index w, or x ?

  imuData_.angularVel_[0] = imu_message->angular_velocity.x;
  imuData_.angularVel_[1] = imu_message->angular_velocity.y;
  imuData_.angularVel_[2] = imu_message->angular_velocity.z;
  imuData_.linearAcc_[0]  = imu_message->linear_acceleration.x;
  imuData_.linearAcc_[1]  = imu_message->linear_acceleration.y;
  imuData_.linearAcc_[2]  = imu_message->linear_acceleration.z;
}

But, when leaving init() function, imuData_ isn't actualized and keep last value !!
here is my package : https://github.com/elpimous/Legged_Control/blob/c5cad9608556c21835cd147e952fdd2afb53a0d6/legged_unitree/legged_unitree_hw/src/UnitreeHW.cpp#L57
Don't find the problem !!
Any help ?

Small up friends. could it be a Thread problem ?
So, waiting for any help, working on a service, to call imu into read() function !

Up please, friends..
my imu callback is into the class class legged::UnitreeHW
Just after the UnitreeHW::init() run, the callback value isn't actualized !!
Please help, all !!

Up, please !

well, found, with GPT4 help !
needed to use a specific subscriber :
https://github.com/elpimous/Legged_Control/blob/e0a6560fb057e1ba9ec215c66dacd934c2091aa1/legged_unitree/legged_unitree_hw/src/legged_unitree_hw.cpp#L66


LOADIN, STOREIN not working as documented

LOADIN and STOREIN need some maintanance

The cryptic line

LOADIN and STOREIN are used as follows: LOADIN ACC IN1

does not tell anything about how the command is used.
Rather the command LOADIN1 i from the ReTI-lecture now becomes LOADIN 1 i.

These commands have an error in their implementation:

It should say:

acc = s[ind[j] + i]

But it says:

acc = s[ind[j], i]

This fix would be nice, as this code is used for university practice tasks.

Feel free to submit PRs fixing these issues - I'm happy to merge it!


Async Support

Are there any plans to support async network requests for the web api?  If so, whats the timeline?

We don't have an ETA for it yet, but it's on our roadmap:
https://github.com/slackapi/python-slackclient/wiki/Slack-Python-SDK-Roadmap


Add unit tests for auto model

Thanks for pointing out. I resolved your comment in the last commit.


Question: Generalize Rule

Hi,
i don't understand how to use the last generalize example.
https://github.com/microsoft/Tools-for-Health-Data-Anonymization/blob/master/docs/FHIR-anonymization.md#generalize
How is
"$this.replaceMatches('(?<year>\\d{2,4})-(?<month>\\d{1,2})-(?<day>\\d{1,2})\\b', '${year}-${month}'"
a key value pair for the cases in the generalization method ? Ist straightup just a method with two params in it.
Other example make more sense:
"$this >= @2010-1-1": "@2010"
Where the key is clearly the condition and the value is target.
In the replaceMatches example the key-value pair of condition-target is not understandble, hence i don't know how to specify the JSON file appropriately.

In this case, if the value is yy-mm-dd or yyyy-mm-dd, then generalize to yy-mm or yyyy-mm respectively.


Make the "play" command make the bot join the channel you are currently in

Please tick all applicable boxes.

[x] I am using Python 3.5.3 or higher (run python --version on the command line)
[x] I have followed the official guides to install the bot for my system
[x] I have updated my dependencies to the latest version using the appropriate update script

Which version are you using?

[x] The latest master version (release-260419)
[ ] The latest review version

What type of issue are you creating?

[ ] Bug
[x] Feature request
[ ] Question

It would be nice to just do "!play " and have the bot join the current voice channel you are in, instead of doing "!summon" then "!play!.

#1850, #1915 duplicate of #837


it_lower_cases_aliased_service_ids fails

The test fails, because ContainerBuilder::getAlias() does not lower the given string anymore since 3.3.

This is correct. That test was removed in https://github.com/SymfonyTest/SymfonyDependencyInjectionTest/pull/87
Thank you for reporting this.

👍


parameterized patterns

An idea on how to look at parameterized patterns.  Currently Asteroid supports parameterized patterns via variables read from the environment,
Asteroid Version 2.0.1alpha
(c) University of Rhode Island
Type "asteroid -h" for help
Press CTRL-D to exit
ast> let p = pattern %integer.
ast> let pair = pattern (x:*p,y:*p).
ast> let q:*pair = (1,2). -- here pair is a pair of integer values
ast> q
(1,2)
ast> let p = pattern %real. -- now pair is a pair of real values
ast> let q:*pair = (1,2).
error: pattern match failed: conditional pattern match failed
ast> let q:*pair = (1.1,2.2).
ast>

This is very clumsy and prone to programming errors...think dynamically scoped functions.  A nice way would be to actually have have parameters on the pattern.  Something like this perhaps,
ast> let p = pattern %integer.
ast> let pair = pattern with a match (x:*a,y:*a).
ast> let q:*pair(p) = (1,2). -- here pair is a pair of integer values
ast> q
(1,2)

or in more concise form,
ast> let pair = pattern with a match (x:*a,y:*a).
ast> let q:*pair(pattern %integer) = (1,2). -- here pair is a pair of integer values
ast> q
(1,2)
ast> let q:*pair(pattern %real) = (1.1,2.2). -- here pair is a pair of real values
ast> q
(1.1,2.2)

We cannot use juxtaposition as a way to parameterize patterns, it makes the language too ambiguous due to the confusion with function application.


comment separation markdown

Diff Review: {"response": [{"details": "Change Management Summary\n\nChanges:\n\n* Feature: Added a new feature to the application.\n* Bug Fix: Fixed a bug that was causing the application to crash.\n* Refactoring: Refactored the code to improve performance and maintainability.\n\nImpact:\n\n* The new feature will improve the usability of the application.\n* The bug fix will prevent the application from crashing.\n* The refactoring will improve the performance and maintainability of the application.\n\nRisks:\n\n* The new feature may introduce new bugs.\n* The bug fix may not completely resolve the issue.\n* The refactoring may break existing functionality.\n\nMitigation:\n\n* The new feature will be thoroughly tested before being released.\n* The bug fix will be tested to ensure that it resolves the issue.\n* The refactoring will be performed in a controlled environment and will be tested before being merged into the main branch.\n\nTimeline:\n\n* The new feature will be released in the next sprint.\n* The bug fix will be released in the current sprint.\n* The refactoring will be completed in the next two sprints.\n\nCommunication:\n\n* The changes will be communicated to the team via email and in the team's weekly meeting.\n* The team will be given an opportunity to review and provide feedback on the changes."}]}

Security Review: {"response": [{"details": "\n## Security-Focused Code Review\n\n### Insecure Cookies\n\n- **ClassName.methodName:** No issues found.\n\n### Insecure Session Management\n\n- **ClassName.methodName:** No issues found.\n\n### SQL Injection\n\n- **ClassName.methodName:** No issues found.\n\n### Cross-Site Scripting (XSS)\n\n- **ClassName.methodName:** No issues found.\n\n### Other Vulnerabilities\n\n- **Authorization flaws:** No issues found.\n- **Buffer overflows:** No issues found.\n- **Insecure file uploads:** No issues found.\n- **Sensitive data exposure:** No issues found.\n\n### Conclusion\n\nNo major security issues found.\n"}]}

Perf Review: {"response": [{"details": "\nNo major performance concerns identified.\n"}]}

#Diff Review: {"response": [{"details": "### Change Management Summary\n\nNo changes are found."}]}

#Security Review: {"response": [{"details": "\nNo major security issues found.\n"}]}

#Perf Review: {"response": [{"details": "markdown\n**No major performance concerns identified.**\n"}]}

Diff Review: {"response": [{"details": "Change Management Summary\n\nChanges Detected:\n\n\n$diff_file_content\n\n\nChange Analysis:\n\n* Type of Change: Bug fix, feature addition, refactoring, etc.\n* Impact of Change: Minor, major, critical, etc.\n* Affected Components: List of affected modules, classes, or functions.\n* Rationale for Change: Explanation of why the change was made.\n* Testing Performed: Description of any testing conducted to verify the change.\n* Risks and Mitigation: Identification of potential risks associated with the change and steps taken to mitigate them.\n\nChange Management Plan:\n\n* Approval Process: Description of the approval process for the change.\n* Deployment Plan: Outline of the steps involved in deploying the change.\n* Rollback Plan: Contingency plan in case of any issues after deployment.\n* Communication Plan: Strategy for communicating the change to stakeholders.\n\nIf no changes are found:\n\nNo changes are found."}]}

Security Review: {"response": [{"details": "Sure, here is a security-focused code review of the provided code, in markdown format:\n\nNo major security issues found.\n\nI reviewed the code and did not find any major security issues. The code appears to be well-written and follows best practices for security.\n\nHere are some specific things I looked for:\n\n* Insecure Cookies: I checked for cookies that were missing the HttpOnly and Secure flags, had inadequate expiration times, or stored sensitive data in plaintext. I did not find any issues.\n* Insecure Session Management: I examined the session generation, storage, transmission, timeout mechanisms, and protection against session hijacking or fixation. I did not find any issues.\n* SQL Injection: I looked for any unsanitized user input that was used directly in SQL queries. I did not find any issues.\n* Cross-Site Scripting (XSS): I inspected how user input was handled and whether it was properly sanitized/encoded before being rendered on web pages. I did not find any issues.\n* Other Vulnerabilities: I remained alert for authorization flaws, buffer overflows, insecure file uploads, and sensitive data exposure. I did not find any issues.\n\nOverall, the code appears to be secure and well-written. I recommend continuing to follow best practices for security and keeping the code up to date with the latest security patches."}]}

Perf Review: {"response": [{"details": "markdown\n**Application Performance Review**\n\n**No major performance concerns identified.**\n"}]}

Diff Review: {"response": [{"details": "No changes are found."}]}

Security Review: {"response": [{"details": "\nNo major security issues found.\n"}]}

Perf Review: {"response": [{"details": "markdown\nNo major performance concerns identified.\n"}]}

Diff Review: {"response": [{"details": "I'm sorry, but I cannot provide a change management summary without the code changes. Please provide the code changes so I can analyze them and provide a summary."}]}

Security Review: {"response": [{"details": "\nNo major security issues found.\n"}]}

Perf Review: {"response": [{"details": "markdown\n**Application Performance Review**\n\n**Language-Specific Issues**\n\n**No major performance concerns identified.**\n"}]}


ImportError: DLL load failed while importing _pywrapsat

What version of OR-tools and what language are you using?
Version: 7.5.7466
Language: Python 3.8
Which solver are you using (e.g. CP-SAT, Routing Solver, GLOP, BOP, Gurobi)
CP-SAT
What operating system (Linux, Windows, ...) and version?
Windows 10
What did you do?
Steps to reproduce the behavior:

from ortools.sat.python import cp_model

What did you expect to see
Expected to be able to use cp_model like I was in ortools version 7.2.6977
What did you see instead?
Traceback (most recent call last):
  File "einsatzplanung\main.py", line 8, in <module>
    import assign
  File "C:\Users\Fabian.Nick\Documents\...........\assign.py", line 13, in <module>
    from ortools.sat.python import cp_model
  File "C:\Users\Fabian.Nick\.conda\envs\Python 3 Newest Shit\lib\site-packages\ortools\sat\python\cp_model.py", line 59, in <module>
    from ortools.sat import pywrapsat
  File "C:\Users\Fabian.Nick\.conda\envs\Python 3 Newest Shit\lib\site-packages\ortools\sat\pywrapsat.py", line 13, in <module>
    from . import _pywrapsat
ImportError: DLL load failed while importing _pywrapsat: Das angegebene Modul wurde nicht gefunden.

Make sure you include information that can help us debug (full error message, model Proto).
This used to work with Python 3.7.3 and ortools 7.2.6977

May be related to: https://github.com/google/or-tools/issues/1872

On windows when trying to use wrapped language aka Python, Java or .Net,
A user must have the Microsoft Visual C++ Redistributable for Visual Studio 2019 installed on its machine...


How to block/suspend users?

Not a problem, but do you have any suggestions for blocking users by invalidating all tokens and preventing future sign-ins in a clean way?

You could hook into the session fetch and then check if the user is blocked by using a database or KV store.
Example: ~/server/plugins/check-blocked.ts
export default defineNitroPlugin(() => {
  sessionHooks.hook('fetch', async (session, event) => {
    // Check if user is blocked (in DB or KV) using session.user.id for example

    // If blocked clear the session and throw an error (or redirect to sign-in page)
    if (blocked) {
      await clearUserSession(event);

      // Throw an error (401 probably)
      throw createError({ ... })
      // or a redirect?
      return sendRedirect(event, '/sign-in');
    }
  });
});

Not sure if it works because it only checks on session fetch (so first page load?). I based it on the readme
In api routes you could create a middleware: ~/server/middleware/check-blocked.ts
export default defineEventHandler(async (event) => {
  const session = await requireUserSession(event);
  // Same check as in example above
}

I hope this gives you enough information?

Thanks!


[$1000]  Text is flickering when click on checkbox

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open website and Click on avatar to open settings
Click Workspaces > any Workspace > Cards > Connect Bank Account > Connect Manually > Reach 3rd step (Personal Information)
Fill in blanks and come to checkbox.
Click checkbox's text multiple times.

Expected Result:
Text should be flickered when click on checkbox
Actual Result:
Text is flickering when click on checkbox
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number:
Reproducible in staging?: needs reproduction
Reproducible in production?: needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/43996225/faf505af-e81b-4118-8b92-3a89bacb1542
Expensify/Expensify Issue URL:
Issue reported by: @muxriddinmuqimov77
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688394732965969
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0134ff9d9773d47adc
Upwork Job ID:<PHONE_NUMBER>684984832
Last Price Increase: 2023-07-17

That is expected behaviour. As user should get some type of feedback that the text was pressed and due to that the Check Box was selected

@jeet-dhandha I meant second flickering not first. If you see the video properly, when you click on text you see first flickering and It's intentional. But when the checkbox is about to be checked you can see second flickering and It's not intentional.

Added the external label to create an Upwork job

Proposal
Please re-state the problem that we are trying to solve in this issue.
Text flickers twice when clicking on a <PressableWithFeedback> component. We want to eliminate the second flicker but keep the first.
What is the root cause of that problem?
The root cause of the issue is the setting of the isExecuting property in the <PressableWithFeedback> component on the onPress event.
I first noticed that when you hold down the press, the flicker does not occur. This makes sense according to this documentation on the <Pressable> component. If you hold the press for longer than 500ms, the onLongPress event fires, meaning onPress does not.
I looked into the onPress event and noticed that it is setting a property called isExecuting after the press. This is effectively triggering another disable/enable on the component which causes the flickering. I believe the <Pressable> component will take care of its state without this event.
What changes do you think we should make in order to solve the problem?

You can either make it so the isDisabled property ignores isExecuting, or, simply remove/change the onPress event to accept a prop.
Either of those changes results in the desired behavior (a little laggy in my emulator):
device-2023-07-17-165002.webm
What alternative solutions did you explore? (Optional)
I also explored the possibility of using the <PressableWithoutFeedback> component as noted in the proposal above, but it is to my understanding based on the previous comments in this thread that initial feedback is desired, so it makes sense to use <PressableWithFeedback> in my opinion.

📣 @timothyfisherdev! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:

Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/timothyfisherdev

After taking a second look, I have updated my proposal with a better solution that results in the same fix.

Is this issue reproducible on Android Native? Unable to reproduce.
https://github.com/Expensify/App/assets/25876548/a79173cc-27c5-4875-b59c-fbd3e275268c

Is this issue reproducible on Android Native? Unable to reproduce.
Screen.Recording.2023-07-19.at.17.10.41.mov

@sobitneupane The phone I used is: Redmi Xiaomi Note A5
Maybe you should use some kind of phone that is near to this one.

In Android Studio I emulated Google 3a Pixel XL

Still trying to reproduce.

@anmurali Were you able to reproduce the issue? I cannot reproduce the issue.

@anmurali Were you able to reproduce the issue? I cannot reproduce the issue.

Nope I cannot reproduce it either. Closing it.


Version specific config for SR OS

With release 24, a listen container is added to the netconf container under management-interface. To accommodate this and not break functionality with older releases, add some function that generates different base configurations depending on which release is being used.
Tested with SROS releases 20.10.R13, 21.10.R13, 22.7.R2, 23.7.R2 and 24.3.R1.

Thanks @hendriksthomas!


Order class names in markup. What's your secret?

Been trying out Tailwind for about a week now, and lovin' it!! 😍
Just wanted to see how everybody's sorting/ordering their classes in the markup. Sometimes the strings can get very long...
Outside of Tailwind, I've been grouping my CSS properties like in this chapter from the SMACSS book (box, border, background, text, other) and then alphabetically inside each group for several years.
It has worked wonderfully in traditional CSS and I've been trying to order Tailwind's classes in the markup the same way, but I don't feel like it translates well to this workflow.
Do you have any special tricks for ordering the classes? All alphabetically? All variations (hover, responsive, etc) at the end? Variations directly after the class you're modifying? One class per line?
Please leave a reply below, and we can all maybe learn something from each other! 🎉

I basically always put "theming" (color, background, borders) it last. But the Basscss suggest a good order: http://basscss.com/v7/docs/guides/basics/#order

I use (two) spaces and slashes to help visually divide groups of like-classes (all flex classes together, spacing classes grouped together, etc.). Responsive classes follow any related non-responsive class. For example, something like:
flex  sm:inline-flex  items-center  /  bg-blue  /  text-white  text-sm  font-bold   /  px-4  py-3

The thing is: As long as you are developing your own stuff and are the only one who's working on the project it's up to you and no one cares about. You can group by position, typo, whatever. But when it comes, that a (larger) team is working on a project you have to ensure, that every single team mate knows the rule to have consistency over your project.
In that case I'd prefer something easy. If you define an order like:

Positions
Layout
Typo
Whatever

I can guarantee, that nobody cares because nobody remembers and they have to refer to the documentation all the time. So one easy way (even if you write regular css in your css files) I find, is, to order it alphabetically. It's not very logical and at the beginning it's strange to read. But the very big advantage is, everybody knows the alphabet. Or at least they should :) I promise you, with that in mind, you have a really straight consistency of code. But again, I apply that only if you work on larger teams. If you are on a one-man show, do whatever you want, what you like and what you're used to.

Never heard of Typosilaycosta? It could be the name of a Greek village in the Ionian Islands, but it's not. It's just a way to remember Typography, Position, Layout, Colors, and State!

I tend to place things alphabetically within each responsive class, that work from sm up to large. For example:
rounded w-full sm:border-t sm:mx-2 sm:my-4 lg:mx-4 my-5

Duplicate of #97.

I've been using Headwind for some time and love it!
Headwind is an opinionated Tailwind CSS class sorter for Visual Studio Code. It enforces consistent ordering of classes by parsing your code and reprinting class tags to follow a given order.
https://github.com/heybourn/headwind


SimpleITK not working with any data type, be it 3D or 2D

I'm using SimpleITK to load in a layered tiff image, its a volumetric image having 30 planes/slices.
After playing around a lot with skimage and imageio Ive found out that SimpleITK is the best way to handle volumetric images but the problem is that none of the functions seem to work for my image.
img = sitk.ReadImage(path)

After reading the image in, I can easily convert it to numpy and even display it using sitk.Show() so its loading up properly. but any function I use on it such as:
img_s = sitk.CurvatureFlow(img, 0.125, 5)
# or
sitk.IntensityWindowing(img)
# or
img_m = sitk.ConnectedThreshold(img, (257,419,7))

gives the warning:

sitk::ERROR: Pixel type: vector of 16-bit unsigned integer is not
supported in 3D byclass itk::simple::

I tried casting to to any other datatype as well but I keep getting errors again:
img2 = sitk.Cast(img, sitk.sitkFloat32)

sitk::ERROR: Filter does not support casting from casting vector of
16-bit unsigned integer to 32-bit float

I tried a 2D variation as well of the above:
img_m = sitk.ConnectedThreshold(img2[:,:,7], [(257,419)])

but this time I got the error:

sitk::ERROR: Pixel type: vector of 64-bit float is not supported in 2D
byclass itk::simple::ConnectedThresholdImageFilter

Any idea what may be causing this?
Thanks

Your image is a multi-component vector image, it's pixel type is "vector of 16-bit unsigned integer". Perhaps the image is an RGB image? You can get the number of components with img.GetNumberOfComponentsPerPixel() or looking at the image's meta-data via "print(img)".
The first filters only support scalar images, and not vector images. You could select the first components with sitk.VectorIndexSelectionCast(img,0).

img2 = sitk.Cast(img, sitk.sitkFloat32)

You can not cast a vector image to s scalar, try casting to sitk.sitkVectorFloat32.

Your image is a multi-component vector image, it's pixel type is "vector of 16-bit unsigned integer". Perhaps the image is an RGB image? You can get the number of components with img.GetNumberOfComponentsPerPixel() or looking at the image's meta-data via "print(img)".
The first filters only support scalar images, and not vector images. You could select the first components with sitk.VectorIndexSelectionCast(img,0).

img2 = sitk.Cast(img, sitk.sitkFloat32)

You can not cast a vector image to s scalar, try casting to sitk.sitkVectorFloat32.

Thank you for responding. Yes the image is a grayscale TIFF image. My original image is a "Leica Image Format, .lif" file. SimpleITK does not support that I believe so I used bio-formats in ImageJ to export it to a multi-layered TIFF file, and that is what I am using as input here. Is there a better way to handle this?
Below is the output of print(img)
VectorImage (0000020E9CC62E20)
  RTTI typeinfo:   class itk::VectorImage<unsigned short,3>
  Reference Count: 1
  Modified Time: 957
  Debug: Off
  Object Name:
  Observers:
    none
  Source: (none)
  Source output name: (none)
  Release Data: Off
  Data Released: False
  Global Release Data: Off
  PipelineMTime: 944
  UpdateMTime: 956
  RealTimeStamp: 0 seconds
  LargestPossibleRegion:
    Dimension: 3
    Index: [0, 0, 0]
    Size: [1024, 512, 30]
  BufferedRegion:
    Dimension: 3
    Index: [0, 0, 0]
    Size: [1024, 512, 30]
  RequestedRegion:
    Dimension: 3
    Index: [0, 0, 0]
    Size: [1024, 512, 30]
  Spacing: [0.000568182, 0.000568182, 1]
  Origin: [0, 0, 0]
  Direction:
1 0 0
0 1 0
0 0 1
  IndexToPointMatrix:
0.000568182 0 0
0 0.000568182 0
0 0 1
  PointToIndexMatrix:
1760 0 0
0 1760 0
0 0 1
  Inverse Direction:
1 0 0
0 1 0
0 0 1
  VectorLength: 3
  PixelContainer:
    ImportImageContainer (0000020E9C8AB710)
      RTTI typeinfo:   class itk::ImportImageContainer<unsigned __int64,unsigned short>
      Reference Count: 1
      Modified Time: 953
      Debug: Off
      Object Name:
      Observers:
        none
      Pointer: 0000020EA50C9040
      Container manages memory: true
      Size: 47185920
      Capacity: 47185920

sitk.VectorIndexSelectionCast(img,0)  gave me an output having all zero's. No imformation was retained from the original image?
Thanks

Yes, reading microscopy image formats can be tricky. We are actively working on getting SCIFIO (bio-formats) to work better with SimpleITK, and improve the ability to read microscopy file formats. Using SCIFIO, right now requires compelling SimpleITK's master branch with some custom configuration flags. Here is a recent discussion: https://discourse.itk.org/t/reading-images-via-scifio-handle-5-d-images/918/3
I am not sure you need to convert the file with ImageJ/FIJI. You image is still a multi-component image, which is the original source of the error message. It appears the you expect the image to just be grayscale but it's actually a multi-component image.
I'd recommend loading the original image, and running the StatisticsImageFilter on each of the components of the image.
I suspect that there was a conversion problem going form a 16-bit to 8-bit data. We need to know the range of values of the original input image.

Thanks for the reply @blowekamp

I'd recommend loading the original image, and running the StatisticsImageFilter on each of the components of the image.

By original file, do you mean the original .lif file? I tried that and followed your method that you gave in your link above but got the following:
path2 = 'C:\\300117.lif'
reader = sitk.ImageFileReader()
reader.SetFileName(path2)
reader.ReadImageInformation()

RuntimeError: Exception thrown in SimpleITK ImageFileReader_ReadImageInformation: C:\d\VS14-Win64-pkg\SimpleITK\Code\IO\src\sitkImageReaderBase.cxx:97:
sitk::ERROR: Unable to determine ImageIO reader for "C:\300117.lif"

We need to know the range of values of the original input image.

Im happy to provide this, can you please let me know what you mean or how I can determine the range of values?
Thanks for your help

Thank you for your questions. If your problem is not resolved you are welcome to reopen the issue.


setting of scale

Whether the size of scale should satisfy spatial_shape between 128 and 512？

No. It is just the max and min threshold used for random cropping using at training only.


neonvm-controller: Standardize / clean up kustomize configuration

While working on #773, I hit some behavior that was different from what I expected.
This PR makes some of the kustomize stuff around the neonvm-controller cleaner (IMO).
The commits are logically separate, and may be easier to review as such. I'll detail them in order below.

5349f6acea0ded22b315a2d84575987c519637a0

mv neonvm/config/common/controller/{manager => deployment}.yaml
This has no effect on the rendered manifests.

83751247a30bd8e9627abd6a8752da0c98928209

neonvm: Move manager_config_patch.yaml into manager deployment
This has no effect on the rendered manifests (but it would have made it nicer to implement #773).

c1cc0f1c97f1d5cfbd3ea448183c32c6639c5aee

neonvm: Remove controller metrics auth proxy
This wasn't being used (not scraping metrics), and then when we started scraping metrics, we just exposed the port directly.
Maybe in the future we'll want to make these metrics more restrictive, but for now there's bigger fish to fry.

Diff to neonvm.yaml from this commit:
3729,3744d3728
<       affinity:
<         nodeAffinity:
<           requiredDuringSchedulingIgnoredDuringExecution:
<             nodeSelectorTerms:
<             - matchExpressions:
<               - key: kubernetes.io/arch
<                 operator: In
<                 values:
<                 - amd64
<                 - arm64
<                 - ppc64le
<                 - s390x
<               - key: kubernetes.io/os
<                 operator: In
<                 values:
<                 - linux
3803,3825d3786
<       - args:
<         - --secure-listen-address=<IP_ADDRESS>:8443
<         - --upstream=http://<IP_ADDRESS>:8080/
<         - --logtostderr=true
<         - --v=0
<         image: gcr.io/kubebuilder/kube-rbac-proxy:v0.13.0
<         name: kube-rbac-proxy
<         ports:
<         - containerPort: 8443
<           name: https
<           protocol: TCP
<         resources:
<           limits:
<             cpu: 500m
<             memory: 128Mi
<           requests:
<             cpu: 5m
<             memory: 64Mi
<         securityContext:
<           allowPrivilegeEscalation: false
<           capabilities:
<             drop:
<             - ALL

We may want to consider getting rid of config/default and only use config/default-vxlan. AFAICT it isn't used anywhere and hasn't been for some time.

We may want to consider getting rid of config/default and only use config/default-vxlan. AFAICT it isn't used anywhere and hasn't been for some time.

+1

Opened #812 - looking back at this now, I think maybe it'd make sense to combine the two (especially looking at 33496328e9718d3c7ea5a99ad5ab31aabbd34705 here vs 1521e908c468b6a1966e1bc39ef827b228b410e1 there).
WDYT @shayanh?

@sharnoff sounds good to me.


Error "scm: parameter not set" in all git directories on fresh install of bash-it

On a fresh install of bashit, i get the following error when inside git repos on the terminal: -bash: scm: parameter not set
Expected Behavior

No such error message
Current Behavior

Error message -bash: scm: parameter not set everytime i cd into a git repo
Possible Solution

A fix is to set export SCM_CHECK=false to get rid of the error messages but then i don't get the display of the git status on the prompt.
I often install bash-it on different systems with the same procedure and never had this problem, so not sure why it happened this time, except maybe from a change in the bash-it Github repo (i always pull from the repo)
Context

The issue is particularly annoying as the message appears at every single command within a git repo
Steps to Reproduce

I can only indicate the way i installed bash-it and the steps i did. So here they are:
git clone --depth=1 https://github.com/Bash-it/bash-it.git ~/.bash_it
~/.bash_it/install.sh
# Update ~/.bashrc to change BASH_IT_THEME variable to powerline-multiline
# and add hostname to prompt right side
sed -i "s/^export BASH_IT_THEME=.*/export BASH_IT_THEME='powerline-multiline'\nexport POWERLINE_RIGHT_PROMPT='in_vim clock battery user_info hostname'/" ~/.bashrc
# Disable bash-it custom aliases:
source ~/.bashrc
bash-it disable alias general

Your Environment

Bash-it version used:

Version type: dev
Current git SHA: c81c9dc on 2022-01-03T14:00:39+02:00
Commit info: https://github.com/Bash-it/bash-it/commit/c81c9dc
Compare to latest: https://github.com/Bash-it/bash-it/compare/c81c9dc...master

List of enabled plugins, themes and aliases (use bash-it show (plugins/themes/aliases)):

bash-it show plugins

Plugin              Enabled?  Description
alias-completion      [x]     Automatic completion of aliases
autojump              [ ]     Autojump configuration, see https://github.com/wting/autojump for more details
aws                   [ ]     AWS helper functions
base                  [x]     miscellaneous tools
basher                [ ]     initializes basher, the shell package manager
battery               [ ]     display info about your battery charge level
blesh                 [ ]     load ble.sh, the Bash line editor!
boot2docker           [ ]     Helpers to get Docker setup correctly for boot2docker
browser               [ ]     render commandline output in your browser
chruby-auto           [ ]     load chruby + auto-switching (from /usr/local/share/chruby)
chruby                [ ]     load chruby                  (from /usr/local/share/chruby)
cht-sh                [ ]     Simplify `curl cht.sh/<query>` to `cht.sh <query>`
cmd-returned-notify   [ ]     Alert (BEL) when process ends after a threshold of seconds
direnv                [ ]     load direnv, if you are using it: https://direnv.net/
dirs                  [ ]     directory stack navigation
docker-compose        [ ]     Helper functions for using docker-compose
docker-machine        [ ]     Helpers to get Docker setup correctly for docker-machine
docker                [ ]     Helpers to more easily work with Docker
edit-mode-emacs       [ ]     Enable emacs editing mode
edit-mode-vi          [ ]     Enable vi editing mode
explain               [ ]     mankier.com explain function to explain other commands
extract               [ ]     one command to extract them all...
fasd                  [ ]     load fasd, if you are using it
fzf                   [ ]     load fzf, if you are using it
gif                   [ ]     video to gif, gif to WebM helper functions
git-subrepo           [ ]     load git-subrepo if you are using it, and initialize completions
git                   [ ]     git helper functions
gitstatus             [ ]     speeds up your life by using gitstatus for git status calculations. install from https://github.com/romkatv/gitstatus
go                    [ ]     go environment variables & path configuration
goenv                 [ ]     load goenv, if you are using it
gradle                [ ]     Add a gw command to use gradle wrapper if present, else use system gradle
hg                    [ ]     hg helper functions
history-eternal       [ ]     eternal bash history
history-search        [ ]     search history using the prefix already entered
history-substring-search  [ ]     search history using the substring already entered
history               [ ]     improve history handling with sane defaults
hub                   [ ]     load hub, if you are using it
java                  [ ]     Java and JAR helper functions
javascript            [ ]     download jquery files into current project
jekyll                [ ]     manage your jekyll site
jenv                  [ ]     load jenv, if you are using it
jgitflow              [ ]     Maven jgitflow build helpers
jump                  [ ]     initialize jump (see https://github.com/gsamokovarov/jump). Add `export JUMP_OPTS=("--bind=z")` to change keybinding
latex                 [ ]     use mactex
less-pretty-cat       [ ]     pygmentize instead of cat to terminal if possible
man                   [ ]     colorize man pages for better readability
nginx                 [ ]     manage your nginx service
node                  [ ]     Node.js helper functions
nodenv                [ ]     load nodenv, if you are using it
nvm                   [ ]     node version manager configuration
osx-timemachine       [ ]     OS X Time Machine functions
osx                   [ ]     osx-specific functions
pack                  [ ]     CNB pack cli aliases
percol                [ ]     Search&Select history with percol
pipsi                 [ ]     load pipsi, if you are using it
plenv                 [ ]     plenv plugin for Perl
postgres              [ ]     postgres helper functions
powerline             [ ]     enables powerline daemon
projects              [ ]     quickly navigate configured paths with `pj` and `pjo`. example: "export PROJECT_PATHS=~/projects:~/work/projects
proxy                 [ ]     Proxy Tools
pyenv                 [ ]     load pyenv, if you are using it
python                [ ]     alias "shttp" to SimpleHTTPServer
rails                 [ ]     Helper functions for Ruby on Rails
rbenv                 [ ]     load rbenv, if you are using it
ruby                  [ ]     ruby and rubygems specific functions and settings
rvm                   [ ]     load rvm, if you are using it
sdkman                [ ]     Load Software Development Kit Manager
ssh                   [ ]     ssh helper functions
sshagent              [ ]     sshagent helper functions
subversion            [ ]     svn helper functions
sudo                  [ ]     Toggle sudo at the beginning of the current or the previous command by hitting the ESC key twice
textmate              [ ]     set textmate as a default editor
thefuck               [ ]     Initialization for fuck
tmux                  [ ]     make sure that tmux is launched in 256 color mode
tmuxinator            [ ]     sources tmuxinator script if available
todo                  [ ]     Todo.txt integration
virtualenv            [ ]     virtualenvwrapper and pyenv-virtualenvwrapper helper functions
xterm                 [ ]     automatically set your xterm title with host and location info
z_autoenv             [ ]     source into environment when cding to directories
zoxide                [ ]     zoxide is a smarter cd command for your shell.

bash-it show aliases

Alias               Enabled?  Description
ag                    [ ]     the silver searcher (ag) aliases
ansible               [ ]     ansible abbreviations
apt                   [ ]     Apt and dpkg aliases for Ubuntu and Debian distros.
atom                  [ ]     Atom.io editor abbreviations
bash-it               [ ]     Aliases for the bash-it command (these aliases are automatically included with the "general" aliases)
bolt                  [ ]     puppet bolt aliases
bundler               [ ]     ruby bundler
clipboard             [ ]     xclip shortcuts
composer              [ ]     common composer abbreviations
curl                  [ ]     Curl aliases for convenience.
dnf                   [ ]     dnf aliases for fedora 22+ distros
docker-compose        [ ]     docker-compose abbreviations
docker                [ ]     docker abbreviations
emacs                 [ ]     emacs editor
fuck                  [ ]     fuck/please to retry last command with sudo
general               [ ]     general aliases
git                   [ ]     common git abbreviations
gitsvn                [ ]     common git-svn abbreviations
heroku                [ ]     heroku task abbreviations
hg                    [ ]     mercurial abbreviations
homebrew-cask         [ ]     homebrew-cask abbreviations
homebrew              [ ]     homebrew abbreviations
homesick              [ ]     homesick aliases
jitsu                 [ ]     jitsu task abbreviations
kubectl               [ ]     kubectl aliases
laravel               [ ]     laravel artisan abbreviations
maven                 [ ]     maven abbreviations
msys2                 [ ]     MSYS2 aliases
node                  [ ]     the Node.js environment aliases
npm                   [ ]     common npm abbreviations
osx                   [ ]     osx-specific aliases
phoenix               [ ]     phoenix abbreviations
puppet                [ ]     puppet aliases
pyrocms               [ ]     pyrocms abbreviations
rails                 [ ]     rails abbreviations
svn                   [ ]     common svn abbreviations
systemd               [ ]     systemd service
terraform             [ ]     Terraform abbreviations
terragrunt            [ ]     Terragrunt abbreviations
textmate              [ ]     textmate abbreviations
tmux                  [ ]     Tmux terminal multiplexer
todo.txt-cli          [ ]     todo.txt-cli abbreviations
uuidgen               [ ]     uuidgen aliases
vagrant               [ ]     vagrant aliases
vault                 [ ]     vault aliases
vim                   [ ]     vim abbreviations
yarn                  [ ]     yarn package manager aliases

bash-it doctor output:

DEBUG: core: main: Loading libraries(except appearance)...
DEBUG: lib: helpers: Loading library file...
DEBUG: lib: log: Loading library file...
DEBUG: lib: preview: Loading library file...
DEBUG: lib: search: Loading library file...
DEBUG: lib: utilities: Loading library file...
DEBUG: vendor: Loading "preexec"...
DEBUG: core: reloader: Loading all enabled components...
DEBUG: plugin: base: Loading component...
 WARN: plugin: base: Command 'markdown' does not exist!
 WARN: plugin: base: Command 'mkisofs' does not exist!
DEBUG: completion: bash-it: Loading component...
DEBUG: completion: system: Loading component...
DEBUG: plugin: alias-completion: Loading component...
DEBUG: core: reloader: Loading "powerline-multiline" theme...
 WARN: themes: base: Command 'battery_percentage' does not exist!
DEBUG: core: main: Loading custom aliases, completion, plugins...
DEBUG: core: main: Loading general custom files...
DEBUG: custom: example: Loading custom file...
 WARN: custom: example: Command 'reload' does not exist!

Bash version:

GNU bash, version 5.0.17(1)-release (x86_64-pc-linux-gnu)
Copyright (C) 2019 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>

This is free software; you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Operating System and version:

Distributor ID: Ubuntu
Description:    Ubuntu 20.04.3 LTS
Release:        20.04
Codename:       focal

Your Bash Config File

# Path to the bash it configuration
export BASH_IT="/home/me/.bash_it"

# Lock and Load a custom theme file.
# Leave empty to disable theming.
# location /.bash_it/themes/
export BASH_IT_THEME='powerline-multiline'
export POWERLINE_RIGHT_PROMPT='in_vim clock battery user_info hostname'

# (Advanced): Change this to the name of your remote repo if you
# cloned bash-it with a remote other than origin such as `bash-it`.
# export BASH_IT_REMOTE='bash-it'

# (Advanced): Change this to the name of the main development branch if
# you renamed it or if it was changed for some reason
# export BASH_IT_DEVELOPMENT_BRANCH='master'

# Your place for hosting Git repos. I use this for private repos.
export<EMAIL_ADDRESS>
# Don't check mail when opening terminal.
unset MAILCHECK

# Change this to your console based IRC client of choice.
export IRC_CLIENT='irssi'

# Set this to the command you use for todo.txt-cli
export TODO="t"

# Set this to false to turn off version control status checking within the prompt for all themes
export SCM_CHECK=true
# Set to actual location of gitstatus directory if installed
#export SCM_GIT_GITSTATUS_DIR="$HOME/gitstatus"
# per default gitstatus uses 2 times as many threads as CPU cores, you can change this here if you must
#export GITSTATUS_NUM_THREADS=8

# Set Xterm/screen/Tmux title with only a short hostname.
# Uncomment this (or set SHORT_HOSTNAME to something else),
# Will otherwise fall back on $HOSTNAME.
#export SHORT_HOSTNAME=$(hostname -s)

# Set Xterm/screen/Tmux title with only a short username.
# Uncomment this (or set SHORT_USER to something else),
# Will otherwise fall back on $USER.
#export SHORT_USER=${USER:0:8}

# If your theme use command duration, uncomment this to
# enable display of last command duration.
#export BASH_IT_COMMAND_DURATION=true
# You can choose the minimum time in seconds before
# command duration is displayed.
#export COMMAND_DURATION_MIN_SECONDS=1

# Set Xterm/screen/Tmux title with shortened command and directory.
# Uncomment this to set.
#export SHORT_TERM_LINE=true

# Set vcprompt executable path for scm advance info in prompt (demula theme)
# https://github.com/djl/vcprompt
#export VCPROMPT_EXECUTABLE=~/.vcprompt/bin/vcprompt

# (Advanced): Uncomment this to make Bash-it reload itself automatically
# after enabling or disabling aliases, plugins, and completions.
# export BASH_IT_AUTOMATIC_RELOAD_AFTER_CONFIG_CHANGE=1

# Uncomment this to make Bash-it create alias reload.
# export BASH_IT_RELOAD_LEGACY=1

# Load Bash It
source "$BASH_IT"/bash_it.sh

Hi @kafka2000, this was fixed with #2021 😄
Feel free to reopen if the problem persists


What kind of IParameter for Operation?

I'm migrating to AspNetCore, and I encountered a problem. What is the concrete class that implements IParameter for OpeationFilter?
As in:
operation.Parameters.Insert(0, new IParameter
{
    name = "token",,
    @in = "header",
    required = true,
    type = "string"
});`

This is OSS. Don't be afraid to peak at the code :)
https://github.com/domaindrivendev/Swashbuckle.AspNetCore/blob/master/src/Swashbuckle.AspNetCore.Swagger/Model/SwaggerDocument.cs#L192
https://github.com/domaindrivendev/Swashbuckle.AspNetCore/blob/master/src/Swashbuckle.AspNetCore.Swagger/Model/SwaggerDocument.cs#L214


Implement Gigantamaxing properly

Closes https://github.com/smogon/damage-calc/issues/406
This could certainly use some UI improvements @AustinXII and iirc you're more familiar with the UI so I'll let you take a look

What does the UI look like currently with this?

@KrisXV update on this?

@KrisXV update on this?


Regression: Segfault when project has too many classes

Input
Generate a file with many classes (or many files with a single class each), 32,500 will tip it over the threshold:
echo > output.rb ; i=0;
while [ $i -lt 32500 ]; do i=$((i+1)); echo "class MyClass$i; end" >> output.rb; done

Then run:
srb tc --no-config .

Observed output
~/.rbenv/versions/3.2.1/lib/ruby/gems/3.2.0/gems/sorbet-0.5.10693/bin/srb: line 46: 66439 Segmentation fault: 11  "${sorbet}" "${args[@]}"

Expected behavior
No segfault.
Additional background

Issue introduced in https://github.com/sorbet/sorbet/pull/6763
Fix attempted in https://github.com/sorbet/sorbet/pull/6792
Tested above snippets with 0.5.10685 with up to 1,000,000 classes without issue.

I'll have to look into this. I don't see an obvious cause, and it's tricky for us to revert those two PRs now.

I'm not sure if it's related, but using srb rbi gems on the ruby_parser gem (version 3.20) now generates a lot of methods which causes a segfault:
$ srb tc
Exception::raise(): isModule() but neither flags.isModule nor flags.isClass. Call to isModule before resolver?

Backtrace:
  #3 0x950127 sorbet::namer::(anonymous namespace)::defineSymbols()
  #4 0x94dfdb sorbet::namer::Namer::runInternal()
  #5 0x9559f3 sorbet::namer::Namer::run()
  #6 0x7c0369 sorbet::realmain::pipeline::name()
  #7 0x7c05bd sorbet::realmain::pipeline::resolve()
  #8 0x68cb32 sorbet::realmain::realmain()
  #9 0x6882dc main
  #10 0x7fb49da65d0a __libc_start_main
  #11 0x6423aa _start

/usr/local/rvm/gems/default/gems/sorbet-0.5.10696/bin/srb: line 46:  3678 Segmentation fault      (core dumped) "${sorbet}" "${args[@]}"

See the attached ruby_parser.rbi.

@spditner I reverted the revert, which originally closed this issue, and have rolled forward with what I believe should be a long term fix in #6883.
If you see the issue re-occur, please feel free to open a new issue.


Fix comment about compilers

I believe these are backward. If not, just close PR.
What does this PR do?
Fix transposition of compiler names in README.
Why was it initiated? Any relevant Issues?
Improve correctness of docs.
PR Checklist

[X] Correct base branch selected? develop for new features and bug fixes too. If it's
part of a hotfix, it will be moved to master during it.
[X] All tests still pass. Check the developer manual about Running the Tests. There
are Travis tests that cover the most important things however, and you are
welcome to rely on those, but they might not cover enough.
[X] Ideally new features or fixed regressions ought to be covered via new tests.
[X] Ideally new or changed features have documentation updates.

No, MinGW64 was indeed fastest, MSVC slowest.
Yours,
Kay


Issue Regarding UI of AI- image generator

The UI of AI image generator is not up to the mark so I want to contribute to it please assign me this work

@omsherikar there are problem issue templates already present in the repo  please use them to raise your issue proper by filling up all the details . otherwise I can't be able to assign u the issue without proper clarification of your issue . So sorry to close this issue for now . But will be waiting for your new & proper issue


Provide user ability to pass custom kubeconfig file path

Closes: #1

Can one of the admins verify this patch?

Thanks for the PR @smalleni.


OpenAI: implement streaming support

The OpenAI chat completions instrumentation should have support for streaming.

Update the instrumentation to support streaming
Implement the overall ai_monitoring.streaming.enabled config
Update documentation to show Ruby supports streaming
Verify support with the latest LLM agent spec

Bumped. Will consider for a future quarter.


k8s.affinity configuration doesn't seem to work using installer

Sorry if I'm missing something here.
Bug description
I got a error report using k8s.affinity  settings.

[x] Configuration Infrastructure

apiVersion: install.istio.io/v1alpha1
kind: IstioOperator
metadata:
  namespace: istio-system
spec:
  profile: default
  components:
    ingressGateways:
    - enabled: true
      k8s:
        affinity:
          nodeAffinity:
            requiredDuringSchedulingIgnoredDuringExecution:
              nodeSelectorTerms:
              - matchExpressions:
                - key: zone
                  operator: In
                  values:
                  - istio

Expected behavior
I want to set ingressgateway.affinity by istioctl  manifest apply -f config.yaml.
Steps to reproduce the bug
When I excute istioctl  manifest apply -f config.yaml. I got:
proto: tag has too few fields: "-"
Error: failed to apply manifests: failed to generate manifest: validation errors (use --force to override):
validate path Components.K8S.Affinity.NodeAffinity.RequiredDuringSchedulingIgnoredDuringExecution, value: istio, expected ptr, got string

Version (include the output of istioctl version --remote and kubectl version and helm version if you used Helm)
istio: 1.5.0
k8s: v1.15.10
How was Istio installed?
by istioctl

Seems like there is a mismatch between the path and the value so the validation fails, @ostromart


[backport] ci: standardize E2E job timeout to 2 hours on PR pipeline (#3124)

Reason for Change:

backports #3124 to v1.5 release train
Issue Fixed:

Requirements:

[x] uses conventional commit messages

[ ] includes documentation
[ ] adds unit tests
[x] relevant PR labels added

Notes:

/azp run Azure Container Networking PR


hb_mc_device_init should allow users to initialize less tiles than the whole array

The default behavior should be all the tiles, but if users want their simulation init to be faster, there should be a method to initialize a subset.
Borna's excellent experiments today demonstrated that this can reduce cosimulation time by 5x for 1x1 tile groups (which I think is substantial)
@mrutt92 Any thoughts on default arguments?

What tommy is suggesting only works for external memory, right?

On Feb 11, 2020, at 6:58 PM, mrutt92<EMAIL_ADDRESS>wrote:

Yeah and that'll probably be addressing the real issue more than fussing with the default behavior of CUDA.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

No, I think what Tommy is suggesting works for any of the RAMs (I hope).
I'm already working on a solution to DRAM IO which is a similar approach (except I've moved data store into C++ and I'm using memcpy instead of readmemb).

Since we're switching to C++ models for DRAM, that solution sounds reasonable to me.
For the kernels that this Issue affects, DRAM overhead is small. The code Borna and I worked on earlier took 100 seconds to execute with full array initialization, vs 19 to execute with single tile-initialization.

Maybe we should run the profiler on hb_mc_device_init ?   ;-)

But we know what the issue is - the runtime has to initialize the instruction cache of every single tile. If your program only uses one tile this is a huge overhead.

Initializing the icache is not an inherently slow operation. We should see why it is slow.

It is slow because IO is slow. For every ICache we have to inititialize every entry with program data. That means every tile requires 1K writes. For a 4x4 manycore array, that's 16K 4-byte writes, or 64K of data being uploaded to the device before a program can run.
Why do people think this is a controversial change? Unlike a backdoor to the device, it isn't introducing any magic. We've demonstrated that there's a 5x speedup and it requires a simple change to the API that will only affect a few users.

Well, there are two levels to it.
First, before we optimize, we should understand why something is slow.
Agreed, we have 16K writes to do. Are we injecting an icache write packet
into the array every cycle, and if not why not? With Leonard’s AXI code, we
should have much more control over the I/O and be able to optimize the
timing?
If we are actually hitting the limit, then, the next step is to have
parallel host interfaces for simulation. We did this in Raw and it was very
helpful for address I/O slowdowns.
Second, this is a very narrow optimization. Why not just run on a 1x1? Then
everything will run faster, not just initialization. On the other hand, we
still want to run large tile arrays and it will still be slow with this
optimization.
M
On Wed, Feb 12, 2020 at 6:29 AM Dustin Richmond<EMAIL_ADDRESS>wrote:

It is slow because IO is slow. For every ICache we have to inititialize
every entry with program data. That means every tile requires 1K writes.
For a 4x4 manycore array, that's 16K 4-byte writes, or 64K of data being
uploaded to the device before a program can run.
Why do people think this is a controversial change? Unlike a backdoor to
the device, it isn't introducing any magic. We've demonstrated that there's
a 5x speedup and it requires a simple change to the API that will only
affect a few users.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/bespoke-silicon-group/bsg_replicant/issues/505?email_source=notifications&email_token=AEFG5AE56ES5R6SON77I2LDRCQBULA5CNFSM4KTLZNR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELQ6YVI#issuecomment-585231445,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEFG5ADYLQFUWXV3WZYS67TRCQBULANCNFSM4KTLZNRQ
.

ps: agree on the general desireability of avoiding magic. :-)
On Wed, Feb 12, 2020 at 6:46 AM Michael Nguyen Taylor <
<EMAIL_ADDRESS>wrote:

Well, there are two levels to it.
First, before we optimize, we should understand why something is slow.
Agreed, we have 16K writes to do. Are we injecting an icache write packet
into the array every cycle, and if not why not? With Leonard’s AXI code, we
should have much more control over the I/O and be able to optimize the
timing?
If we are actually hitting the limit, then, the next step is to have
parallel host interfaces for simulation. We did this in Raw and it was very
helpful for address I/O slowdowns.
Second, this is a very narrow optimization. Why not just run on a 1x1?
Then everything will run faster, not just initialization. On the other
hand, we still want to run large tile arrays and it will still be slow with
this optimization.
M
On Wed, Feb 12, 2020 at 6:29 AM Dustin Richmond<EMAIL_ADDRESS>wrote:

It is slow because IO is slow. For every ICache we have to inititialize
every entry with program data. That means every tile requires 1K writes.
For a 4x4 manycore array, that's 16K 4-byte writes, or 64K of data being
uploaded to the device before a program can run.
Why do people think this is a controversial change? Unlike a backdoor to
the device, it isn't introducing any magic. We've demonstrated that there's
a 5x speedup and it requires a simple change to the API that will only
affect a few users.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/bespoke-silicon-group/bsg_replicant/issues/505?email_source=notifications&email_token=AEFG5AE56ES5R6SON77I2LDRCQBULA5CNFSM4KTLZNR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELQ6YVI#issuecomment-585231445,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEFG5ADYLQFUWXV3WZYS67TRCQBULANCNFSM4KTLZNRQ
.

Great suggestions! Thank you for explaining

On Feb 12, 2020, at 9:47 AM, taylor-bsg<EMAIL_ADDRESS>wrote:
Well, there are two levels to it.
First, before we optimize, we should understand why something is slow.
Agreed, we have 16K writes to do. Are we injecting an icache write packet
into the array every cycle, and if not why not? With Leonard’s AXI code, we
should have much more control over the I/O and be able to optimize the
timing?
If we are actually hitting the limit, then, the next step is to have
parallel host interfaces for simulation. We did this in Raw and it was very
helpful for address I/O slowdowns.
Second, this is a very narrow optimization. Why not just run on a 1x1? Then
everything will run faster, not just initialization. On the other hand, we
still want to run large tile arrays and it will still be slow with this
optimization.
M
On Wed, Feb 12, 2020 at 6:29 AM Dustin Richmond<EMAIL_ADDRESS>wrote:

It is slow because IO is slow. For every ICache we have to inititialize
every entry with program data. That means every tile requires 1K writes.
For a 4x4 manycore array, that's 16K 4-byte writes, or 64K of data being
uploaded to the device before a program can run.
Why do people think this is a controversial change? Unlike a backdoor to
the device, it isn't introducing any magic. We've demonstrated that there's
a 5x speedup and it requires a simple change to the API that will only
affect a few users.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/bespoke-silicon-group/bsg_replicant/issues/505?email_source=notifications&email_token=AEFG5AE56ES5R6SON77I2LDRCQBULA5CNFSM4KTLZNR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELQ6YVI#issuecomment-585231445,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEFG5ADYLQFUWXV3WZYS67TRCQBULANCNFSM4KTLZNRQ
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/bespoke-silicon-group/bsg_replicant/issues/505?email_source=notifications&email_token=ABQVI5GWY34XPVJHE76WCWTRCQDW3A5CNFSM4KTLZNR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELRA27I#issuecomment-585239933, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABQVI5DLZHDPLE3UL3HZDNTRCQDW3ANCNFSM4KTLZNRQ.

f we are actually hitting the limit, then, the next step is to have
parallel host interfaces for simulation. We did this in Raw and it was very
helpful for address I/O slowdowns.

And to prepare for having multiple host interfaces. For example, a multi-core BlackParrot :)

Closing because there seem to be better solutions. May issue a related PR that reduces duplicated code


Persistence through user profiles

It'd be cool if we could authenticate using Github (say) and have our data accessible from any device. Firebase, maybe?

Thanks for raising this. It is on my list of things to do if the site gains traction :)
And yes, it would defo be Firebase.


Adapt latest core agent version

Quick fix, so we can make a new release

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Coverage remained the same at 91.563% when pulling f37b48a56e7e473eb2ca3d9f24551e9044ac51b2 on adapt-core-agent into 0b2ace8bad963f8ae6a68d46e369dc9696bb73f4 on master.


Add Selenium and Firefox to vm to power Behat tests

Relates to https://github.com/geerlingguy/drupal-vm/issues/137
Notes/TODOs from @geerlingguy:

[x] Update www.drupalvm.com documentation with note about Selenium
[x] Leave it uninstalled by default (to avoid bloat of Java + FF + etc. for majority of projects).
[x] Update README.txt with documentation about Selenium
[x] Add wiki page on using Behat (or other tools?) with Selenium (added)
[x] Test on Ubuntu 14.04 & 12.04 and CentOS 6 & 7
[x] Make composer global require'd packages more accessible (see #154)

One other question: Would you be willing to (or would you accept a PR from me to) make this work on RHEL/CentOS? Currently all other configuration in the VM works across platforms, so people can switch to other base boxes if they would like, and I don't want to take away that ability if they want to use selenium.

@geerlingguy let me give it a shot to get it working on RHEL/CentOS.

@arknoll - Great! let me know when that's done, and I'll un-postpone this PR.

@geerlingguy Done and tested on CentOS https://galaxy.ansible.com/list#/roles/4340.

Great! I'll merge and do some more testing tonight.

Verified that behat/selenium/firefox/etc. works great across all supported CentOS and Ubuntu versions.


AuthFilter allowing requests through to the controller for authenticated endpoints with no Auth-Key header present.

While testing multiblast I noticed that if i sent in a request with no Auth-Key header present, the auth filter was not rejecting the request and was instead allowing it through to the controller.

Invalid issue, service was misconfigured.


Describe clusters, the control plane node, and the worker node

issue #40554
Looking at the  Kubernetes Components description, the word worker node was unfamiliar to me, so I wanted to change it.
However, worker nodes and control plane nodes are not defined, so they are defined.
Accordingly, the control plane description was changed to manage the nodes as well as this worker nodes.

@911432 Thanks you for your contribution.
Could you please sign the CLA before the PR can be reviewed.
You can follow the steps documented here: CLA Steps

@911432
thank you for your contribution.
You must sign the CLA for teams of kubernetes/website to do code reiview.
Please click on the red button NOT COVERED line in the first comment.
If you don't know how to do it, here isthe CLA tutorial.

/easycla

@911432,
Deploy got failed, you need to re trigger deploy with empty command. can you execute following command?
git commit --amend --no-edit && git push -f

I did it

@911432, Deploy got failed, you need to re trigger deploy with empty command. can you execute following command? git commit --amend --no-edit && git push -f

@911432, Deploy got failed, you need to re trigger deploy with empty command. can you execute following command? git commit --amend --no-edit && git push -f
I think EasyCLA didn't approve me.

@911432, Deploy got failed, you need to re trigger deploy with empty command. can you execute following command? git commit --amend --no-edit && git push -f
@T-Lakshmi  I think EasyCLA didn't approve me.

/easycla

/approve

/assign

/assign

Why is it delayed?

Why is it delayed?


Chat onStartReached loader fix

The issue is that the loader doesn't have space to appear. When we pull the page, the loader is visible momentarily, but it's immediately hidden by the list. This happens because we removed the containerStyles of the list for mobile. This change was made to fix a bug that arose after upgrading React Native Web

BUG8: money request view position is wrong when no messages

https://github.com/Expensify/App/pull/24482#issuecomment-1688977186

Original PR where this style comes from PR.
Details

Fixed Issues

$
PROPOSAL:
Tests
Please check tests from both linked PRs

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@getusha, by chance, do you remember why you added this style?
tldr: it already passed in the parent component. So it should be safe to remove it
https://github.com/getusha/App/blob/c97ff978ee258af698628b6a4632074dec451ddb/src/pages/home/report/ReportActionsList.js#L361

@perunt i am not sure if the style was added later but we experienced an issue on iOS and was resolved by adding it. https://github.com/Expensify/App/pull/24482/commits/96151dcf7c599cffcd5add8a6826e59934801ef0
BUG8: money request view position is wrong when no messages https://github.com/Expensify/App/pull/24482#issuecomment-1688977186

hmm, thanks for the info!
it looks like the culprit is flexGrow: 1
I'll make appropriate changes

@aimane-chnaif Since you reviewed the original PR do you want to be the C+ on this issue?

@thienlnam can we merge it?

ok, so the actual changes in the PR are:
remove flexGrow: 1 in web Flatlist's contentContainerStyle (seems redundant)

right, it always stretches the container even if we have a few items inside.

add paddingBottom: 16 in native FlatList's contentContainerStyle (fix padding ignored issue)

I didn't add any paddings in my PR. What do you mean?
test steps from nested PRs

Test:

On a blank chat, send a message and make sure the message is docked at the bottom of the screen
Add more messages and make sure the bottom-docking is still happening
With a chat that has many, many messages, make sure the container scrolls normally

Money request view position is wrong when there are no messages
Bug with number 8, follow this link: https://github.com/Expensify/App/pull/24482#issuecomment-1688977186

After:
We're using same style as web (removing flexGrow1) so {justifyContent: 'flex-end', paddingBottom: 16}
So paddingBottom: 16 is the only difference

Correct.
I've merged main as this component was migrated to TS

@perunt When you get a chance, please handle https://github.com/Expensify/App/pull/33343#issuecomment-1868559900

@perunt When you get a chance, please handle https://github.com/Expensify/App/pull/33343#issuecomment-1868559900

I added them here https://github.com/Expensify/App/pull/33343#issuecomment-1871312406
will duplicate it in the header as well

You may have to merge main to fix the typescript checks, I'm not sure why it's erroring on your build but I asked here

Thanks for pointing it up
Done

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/thienlnam in version: 1.4.23-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.23-4 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


Amazon.AWSCLI Install has verification failed

I was attempting to install Amazon.AWSCLI today using winget and received a warning that the installer has failed verification.  Due to this mismatch I canceled the installer to prevent a possible security issue on my system.
The following are the commands that I executed when installing:
winget install -h -e Amazon.AWSCLI

Found AWS Command Line Interface v2 [Amazon.AWSCLI]
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://awscli.amazonaws.com/AWSCLIV2.msi

Installer hash verification failed. Continue? (Y|N)
Canceled; Installer hash mismatch

System information:

Hardware: SurfaceBook 2 with latest SurfacBook 2 patches
OS: Windows 10 Pro, 2004, Build: 19041.264
Windows Insider Program enabled for slow
Developer settings

Developer Mode is on
Device Portal off
Device discovery off
PowerShell policy has been set to run all scripts

It seems that link https://awscli.amazonaws.com/AWSCLIV2.msi points to latest 2.x.x version so the hash does not match.

I did end up just installing the CLI via the Amazon site.  My goal is to create a PowerShell script to help rebuild my laptop after I complete an engagement.

I've opened https://github.com/microsoft/winget-pkgs/pull/682 to remove the current awscli 2.0 manifest, as its clearly broken.

This has been resolved with https://github.com/microsoft/winget-pkgs/commit/dc0deabf47897aeb7ee1e36529a08d82cc621bf6.

It is possible to get static links to the AWS CLI
i.e. https://awscli.amazonaws.com/AWSCLIV2-2.0.15.msi

See https://chocolatey.org/packages/awscli#files for examples on how to get static versions of the AWS CLI binary links

Thanks @superusercode! I've opened another PR to re-add aws-cli v2 (https://github.com/microsoft/winget-pkgs/pull/820).

We now have automation that will generate a new manifest if the installer has changed at the URL. Does that resolve this issue?

We now have automation that will generate a new manifest if the installer has changed at the URL. Does that resolve this issue?


projection should start with empty tile

 projection shuld start with empty tile

Pull Request Test Coverage Report for Build 849930274

1 of 2 (50.0%)  changed or added relevant lines in 1 file are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.02%) to 82.795%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

operators/src/adapters/raster_overlap_adapter.rs
1
2
50.0%

Files with Coverage Reduction
New Missed Lines
%

operators/src/adapters/raster_overlap_adapter.rs
4
88.7%

Totals

Change from base Build 849536646:
-0.02%

Covered Lines:
16997

Relevant Lines:
20529

💛  - Coveralls


Hide pw in connect params

Summary

https://github.com/PrefectHQ/prefect-snowflake/issues/21
Relevant Issue(s)

Checklist

[ ] Summarized PR's changes in CHANGELOG.md

Let's go with this for now. Removing connect_params has implications for prefect-dbt:
https://github.com/PrefectHQ/prefect-dbt/blob/main/prefect_dbt/cli/configs/snowflake.py#L75


add additional sysupgrade switches (-k -u) to Generate Archive button

I would like the additional (-k -u) switches added to the Generate Archive option.

These options would allow me to create a backup config file without unmodified files to allow better compatibility when I do a manually upgrade or restore my settings to another router and make it much easier too re-install all of the missing required packages because they will be listed in /etc/backup/installed_packages.txt
grep "\toverlay" /etc/backup/installed_packages.txt | cut -f1 | xargs -r opkg install

I can imagine it will look similar to the Flash new firmware image

Related: #5530 #4160

@Ansuel @ynezz @rmilecki @aparcar @jow- @hnyman
I am also interested in more options from sysupgrade in luci for "Generate Archive"
I could make use of -u , -c and -o.
I could not find the file in luci source with the command sysupgrade -b or sysupgrade --create-backup
On the device:
grep -r create-backup /www/
/www/cgi-bin/cgi-backup:--create-backup
/www/cgi-bin/cgi-download:--create-backup
/www/cgi-bin/cgi-exec:--create-backup
/www/cgi-bin/cgi-upload:--create-backup

See also:
https://github.com/openwrt/openwrt/issues/9348

@shoulders Another way is to modify /sbin/sysupgrade on the device (or package/base-files/files/sbin/sysupgrade in openwrt source)
# initialize defaults
export MTD_ARGS=""
export MTD_CONFIG_ARGS=""
export INTERACTIVE=0
export VERBOSE=1
export SAVE_CONFIG=1
export SAVE_OVERLAY=0
export SAVE_OVERLAY_PATH=
export SAVE_PARTITIONS=1
export SAVE_INSTALLED_PKGS=0
export SKIP_UNCHANGED=0
export CONF_IMAGE=
export CONF_BACKUP_LIST=0
export CONF_BACKUP=
export CONF_RESTORE=
export NEED_IMAGE=
export HELP=0
export FORCE=0
export TEST=0
export UMOUNT_ETCBACKUP_DIR=0

After editing export SKIP_UNCHANGED=0 to export SKIP_UNCHANGED=1 "Generate Archive" does skip from backup files that are equal to those in /rom.
Edit also export SAVE_INSTALLED_PKGS=0 to export SAVE_INSTALLED_PKGS=1
If you want to backup the script too then you have to add /sbin/sysupgrade into /etc/sysupgrade.conf because even -o does not catch it. But beware of that the sysupgrade script then never gets updates if you always restore it.

What I still didn't understand is if these options are available from CMD
Or we should add supporto for them in sysupgrade first.
Il Dom 27 Feb 2022, 02:18 jospezial @.***> ha scritto:

@shoulders https://github.com/shoulders Another way is to modify
/sbin/sysupgrade on the device (or package/base-files/files/sbin/sysupgrade
in openwrt source)
initialize defaults
export MTD_ARGS=""
export MTD_CONFIG_ARGS=""
export INTERACTIVE=0
export VERBOSE=1
export SAVE_CONFIG=1
export SAVE_OVERLAY=0
export SAVE_OVERLAY_PATH=
export SAVE_PARTITIONS=1
export SAVE_INSTALLED_PKGS=0
export SKIP_UNCHANGED=0
export CONF_IMAGE=
export CONF_BACKUP_LIST=0
export CONF_BACKUP=
export CONF_RESTORE=
export NEED_IMAGE=
export HELP=0
export FORCE=0
export TEST=0
export UMOUNT_ETCBACKUP_DIR=0
After editing export SKIP_UNCHANGED=0 to export SKIP_UNCHANGED=1
"Generate Archive" does skip from backup files that are equal to those in
/rom.
Edit also export SAVE_INSTALLED_PKGS=0 to export SAVE_INSTALLED_PKGS=1
If you want to backup the script too then you have to add /sbin/sysupgrade
into /etc/sysupgrade.conf because even -o does not catch it. But beware of
that the sysupgrade script then never gets updates if you always restore it.
—
Reply to this email directly, view it on GitHub
https://github.com/openwrt/luci/issues/5555#issuecomment-1052899601, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AE2ZMQUXBLVDMDY5XRYRNKDU5F3XHANCNFSM5I37OC7A
.
You are receiving this because you were mentioned.Message ID:
@.***>


KAFKA-6145: Set HighAvailabilityTaskAssignor as default in streams_upgrade_test.py

This PR sets HighAvailabilityTaskAssignor as default task assignor in
streams_upgrade_test.py. The verification of the test needed to be
modified to because the HighAvailabilityTaskAssignor surfaced a flakiness
in the test. More precisely, the verifications assume that the last
client that is bounced joins the group before the other two clients
are able to rebalance without the last client. This assumption does not
always hold.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Call for review: @vvcephei @ableegoldman

System tests job: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/3928/

test this please

Just in case, I re-run the system tests: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/3929/

Thanks @cadonna , Let's see how those tests play out.

System test passed again: http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/2020-05-05--001.1588709838--cadonna--fix_version_probing_system_test--b80ef74/report.html

The test results are gone now, unfortunately.
Retest this please

Actually, since the only thing that changed was a python system test file, it couldn't cause any of the integration test failures, so I'll go ahead and merge.
Here were the failures:
org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta[true]
org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta[true]
org.apache.kafka.streams.integration.QueryableStateIntegrationTest.shouldAllowConcurrentAccesses
org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta[false]


LDAP connector does not pick up what groups a user belongs to

Issue Report Template
Tectonic Version
tectonic-sandbox-1.7.5-tectonic.1
Environment
What hardware/cloud provider/hypervisor is being used with Tectonic?

MacBook Pro (15-inch, 2017)
macOS 10.13.2
Vagrant 2.0.1
VirtualBox 5.2.6

Expected Behavior
That role bindings can be created for LDAP-users based on what groups they belong to in LDAP.
Actual Behavior
Role bindings can only be created for specific LDAP-users and not using the LDAP-groups they belong to.
Reproduction Steps
Note: LDAP OrgId and passwords are replaced with "..." in the description below!

Create an account in https://jumpcloud.com

Setup users and groups
Registered a user named magnus that belongs to the group cluster-viewers in the JumpCloud directory.

Verify the user magnus using ldapsearch
 $ ldapsearch -H ldap://ldap.jumpcloud.com:389 -ZZ -x -b "ou=Users,o=...,dc=jumpcloud,dc=com" -D "uid=ldapservice,ou=Users,o=...,dc=jumpcloud,dc=com" -w "..." "(objectClass=inetOrgPerson)"

 # magnus, Users, ..., jumpcloud.com
 dn: uid=magnus,ou=Users,o=...,dc=jumpcloud,dc=com
 sn: Larsson
 cn: Magnus Larsson
 uid: magnus
 gidNumber: 5001
 homeDirectory: /home/magnus
 mail<EMAIL_ADDRESS> givenName: Magnus
 objectClass: top
 objectClass: person
 objectClass: organizationalPerson
 objectClass: inetOrgPerson
 objectClass: shadowAccount
 objectClass: posixAccount
 objectClass: jumpcloudUser
 uidNumber: 5001
 loginShell: /bin/bash
 jcLdapAdmin: TRUE
 memberOf: cn=cluster-viewers,ou=Users,o=...,dc=jumpcloud,dc=com

Verify the groupcluster-viewers using ldapsearch
 $ ldapsearch -H ldap://ldap.jumpcloud.com:389 -ZZ -x -b "ou=Users,o=...,dc=jumpcloud,dc=com" -D "uid=ldapservice,ou=Users,o=...,dc=jumpcloud,dc=com" -w "..." "(&(objectClass=groupOfNames)(member=uid=magnus,ou=Users,o=...,dc=jumpcloud,dc=com))"

 # cluster-viewers, Users, ..., jumpcloud.com
 dn: cn=cluster-viewers,ou=Users,o=...,dc=jumpcloud,dc=com
 cn: cluster-viewers
 ou: cluster-viewers
 objectClass: top
 objectClass: groupOfNames
 description: tagGroup
 member: uid=magnus,ou=Users,o=...,dc=jumpcloud,dc=com

Configure Tectonic for using the LDAP connector
Following the instructions at https://console.tectonicsandbox.com/settings/ldap, I extended the ConfigMap ´tectonic-identity´ in namespace tectonic-system with:
 connectors:
   - name: ldap
     id: tectonic-ldap
     type: ldap
     config:
       host: 'ldap.jumpcloud.com:389'
       bindDN: 'uid=ldapservice,ou=Users,o=...,dc=jumpcloud,dc=com'
       bindPW: ...
       userSearch:
         baseDN: 'ou=Users,o=...,dc=jumpcloud,dc=com'
         filter: (objectClass=inetOrgPerson)
         username: uid
         idAttr: uid
         emailAttr: mail
         nameAttr: cn
       groupSearch:
         baseDN: 'ou=Users,o=...,dc=jumpcloud,dc=com'
         filter: (objectClass=groupOfNames)
         userAttr: dn
         groupAttr: member
         nameAttr: cn
       insecureNoSSL: true

...and redeployed the tectonic-identity deployment...

Try login with a LDAP user magnus in the console
Works like a charm :-)

Setup kubeconfig for the LDAP user
Downloads kubectl-config the standard way and setup the environment variable KUBECONFIG.

Try a kubectl read operation (fails on no-priv)
 $ kubectl get namespace
 Error from server (Forbidden): User<EMAIL_ADDRESS>cannot list namespaces at the cluster scope. (get namespaces)

Bind the clusterrole view to the LDAP user
 $ kubectl create clusterrolebinding cluster-viewer-binding --clusterrole=view<EMAIL_ADDRESS>

Try a kubectl read operation (works)
 $ kubectl get namespace
 NAME              STATUS    AGE
 default           Active    4h
 kube-public       Active    4h
 kube-system       Active    4h
 tectonic-system   Active    4h

Remove the cluterrolebinding  for the LDAP user
 $ kubectl delete clusterrolebinding cluster-viewer-binding

Bind the clusterrole view to a LDAP group that LDAP user belongs to
 $ kubectl create clusterrolebinding cluster-viewer-binding --clusterrole=view --group=cluster-viewers

Try a kubectl read operation (fails on no-priv, expected it to succeed)
 $ kubectl get namespace
 Error from server (Forbidden): User<EMAIL_ADDRESS>cannot list namespaces at the cluster scope. (get namespaces)

Other Information
Logs from the tectonic-identity pods:
    $ kubectl -n tectonic-system logs tectonic-identity-2868094004-kfxpv

    time="2018-02-01T11:48:53Z" level=info msg="performing ldap search ou=Users,o=...,dc=jumpcloud,dc=com sub (&(objectClass=inetOrgPerson)(uid=magnus))" connector=ldap
    time="2018-02-01T11:48:53Z" level=info msg="username \"magnus\" mapped to entry uid=magnus,ou=Users,o=...,dc=jumpcloud,dc=com" connector=ldap
    time="2018-02-01T11:48:53Z" level=info msg="login successful: connector \"tectonic-ldap\", username=\"Magnus Larsson\"<EMAIL_ADDRESS>groups=[]"

The output from the log seems to indicate that Tectonic doesn't succeed with connecting the LDAP user to the LDAP groups it belongs to.
Have I configured the LDAP connector incorrectly or what could be the cause?

@magnus-larsson LDAP functionality is mainly used/tested with Active Directory ldap.
I think that this is a Jumpcloud specific issue and relates to their implementation of LDAP groups as OpenLDAP does not have groups by default.

Thanks, took a while to get access to a MS AD to try it out.
Works fine when used with a MS AD LDAP server!


CLI arguments are lazily parsed

Running a robot CLI command with an invalid argument should produce an error. Instead, it seems to ignore invalid arguments and attempt execute the command anyway. This was observed when there was a typo in a command (-nostatusrc was used when it should be --nostatusrc) and the exit code on a failure was still 1. Subsequently, I was able to reproduce this using an argument of -no.
I haven't found it in the code, but it seems that the CLI is taking the -n and ignoring the rest. An argument of -foo emits an error, while -doo creates an output dir called oo. Perhaps the entire argument (up to the first whitespace) should be evaluated?

When you use -nostatusrc it's actually equivalent to -n ostatusrc which is valid. I'm not the biggest fan of using short options like this, but it's pretty common behavior. In our case we get this functionality via the getopt module. I don't think trying to fight against getopt is worth the effort, especially when changing this would be backwards incompatible.

I don't think that's accurate. I believe it's equivalent to -n oncritical, which would yield different results.
-n --noncritical tag *   Tests with given tag are not critical even if they
                          have a tag set with --critical. Tag can be a pattern.

Perhaps the entire arguments section can be re-evaluated to be more uniform? I don't mind short, nor long, but some consistency would be good.

No, --nwhatever is equivalent to -n whatever which is equivalent to --noncritical whatever. But if you have ideas how to enhance the docs, we certainly can do that.

At least the User Guide explains this pretty thoroughly: http://robotframework.org/robotframework/latest/RobotFrameworkUserGuide.html#short-and-long-options

No, --nwhatever is equivalent to -n whatever which is equivalent to --noncritical whatever. But if you have ideas how to enhance the docs, we certainly can do that.

But it's not, that's what I'm trying to say. --nostatusrc has no short code, so -nostatusrc will translate to the -n short code, which translates to --noncritical. That is my point here. :-) If -n and --nostatusrc were the same, this wouldn't be an issue.

First of all, reporting problems is always appreciated. In this case the problem is caused by a feature in an external module, which makes it hard to fix. I don't like the idea to remove all short options because it would be backwards incompatible and because short options are handy. Migrating to argparse would be great, but it would be rather big task and I wouldn't be surprised if argparse would handle this case same way as getopt.


assert exists(wav_path) AssertionError

assert exists(wav_path)
AssertionError

Hello.
First of all, the information provided is too little to answer.  At least you should post the following information, or you will never get any answer.

Platform you used(Windows, Linux, Macintosh, or Google Colaboratory etc.)
The version of NNSVS and related packages
Singing voice database you used
Detailed instruction you did and whole error message you got.


CU-2fkwmve | Support password update and reset

Task linked: CU-2fkwmve Support password update and reset


Call loadOptions in Select.Async after receiving new value

To show changes proposed in https://github.com/JedWatson/react-select/issues/812
If valid solution, will re PR into https://github.com/JedWatson/react-select

Closing since<EMAIL_ADDRESS>seems to fix the issue.

@alexjesp how did you end up solving this? your old issue 812 is still open and active. it doesnt seem obvious that<EMAIL_ADDRESS>fixes this as you mention

@stephenhuh we have since moved to using downshift-js which works a lot better for us.


chore(DEVHAS-452): Add visualization for application deletion SLO

This PR adds a very basic visualization of the Application Deletion SLO: 99% of deleted applications must succeed to the Grafana dashboard.

LGTM, but I would like @amisstea to take a look as well

@amisstea @avi-biton Review comments addressed