Dockstore Compliance

Shared Doc with InfoSec
Google Drive with Daniel Wilson Docs
┆Issue is synchronized with this Jira Epic
┆Sprint: CGP February Sprint
┆Issue Number: DOCK-121

Tasks from infosec

A base SSP based on IS3
A review of Dockstore compliance to IS3
A plan for Review Board
A new point person

➤ Brian O'Connor commented:
Notes from 20190227

email intro from Cricket
Terra

ISA for UCSC/OICR
ISA for OICR/USCS/Broad

She made tickets, look at the tickets

➤ Brian O'Connor commented:
Take a look at my email thread (Brian only) for the conversation wtih Bernick: https://mail.google.com/mail/u/1/#label/2-orange-star/FMfcgxwBVWQNZpHFjWtGNMqfjvgdRGzk
Some key points:
I don’t have an invite for Tuesday meeting.
So yes, as I understood originally, you’d need to prepare a nist-800-53 ssp. But recently (like really recently) nci has really been on us to make sure all interconnections have 3pao attestation, not just self atteststion. They MIGHT accept your internal isso atteststion — they might not. It is unknown until we submit it. That’s just a reality of dealing with this kind of thing. Our nci isso has been recently really pushing for all our interconnections to be fisma.
In the past this process has been a non-process and the nci sort of rubber stamped everything. Very recently they appear to actually care about following some of the rules.
3pao audit for something like Dockstore will be about 100k. But once done it’s usually good for 4 years or so.
Does your SSP have any poams in the high or medium categories at all? Not having any poams at all will make everything go faster. Is your infosec partner acting as essentially an internal auditor and are they making SAR/POAM or are they just doing operations? Part of an SSP are making sure there are no open items (or at least items are mitigated). Please make sure that’s in order.
I just wanted to have contingency plans in case nci wants it. The Interconnection documentation will help (showing how limited the connection is and how limited the data share is). The more work we do in “data minimalization” there the better and documenting what is being shared and how.
Plan B would be if NCI doesn’t accept your attestation so Broad would have to operate it. I have no idea what the product ramifications of that are. Hopefully we can do as much possible up front to have NCI not care about this one. We are extra sensitive to this because as we apply for FedRAMP all of our connections will be scrutinized.
On Sun, Feb 17, 2019 at 6:36 PM Cricket Sloan<EMAIL_ADDRESS>wrote:
David,
Thanks for the update.  I think there are two thread here for the Plan A and the Plan B.  Let me address them each.
Plan A:  Dockstore ups its compliance.
We have just gotten to the point where UCSC InfoSec has agreed to take over logging and breach detection.  They are working with us to prepare our SSP and then send it to the UCSC Review Board.  Because it took so long for InfoSec to own this, they have now made it one of their highest priorities.  Until the email I just received, I was thinking if that review came back positive and we could send the package to you, then we would be all good to go.  I am now hearing that we will need to move to a 3rd party audit (which I will need to check the budget concerns here) and then get approval for use in a FISMA system.
Do I have this right?
If so, the timeline will be a problem, but the cost and agreement from OICR might be.
Plan B: Dockstore is moved to within the Broad Boundary
I am not sure what this is going to look like.  Will the Broad have its own version of Dockstore?  Or will there be the main Dockstore and the one within the Broad environment?  Once that question is answered we will have many other fall out questions.  I do think we need to explore this plan B.  This concern also shows a possible flaw in the DataBiosphere model of a federation. We are not very federated if all the pieces need to be absorbed into one boundary.   In our Tuesday meeting, would you or someone from Broad have a rough proposal of what Dockstore run by Broad would look like?
Thanks,
Cricket

➤ Brian O'Connor commented:
See my notes from "20190220 - Dockstore Compliance":
Notes:

3 options... trying to work together on this... these are:
A) NIST controls... FISMA...  address controls, they are OK with it, sign off
start with minimal ISA for send to firecloud/terra with Broad... simple
B) 3rd party attestation for Dockstore and FedRamp
Bernick pretty much guarantees this is what we need to do
C) Dockstore instance running in Broad if we can’t do B for some reason
nobody really wants this
Bernick, we need a 3rd party attestation
since Dockstore is storing user email and refresh token
thinks we just need to go for it
AI: confirm data flow diagrams
update the flow diagram showing user and data exchanged
David B needs to see this, we are storing sensitive data
work with David An to confirm... Denis and Charles will work on this
needed for send to Terra/Firecloud
do we need an attesation?  Sounds like we don’t and just need an ISA with Broad for public workflows and no sensitive info flowing between systems.
need to be documented
AI: need an interconnect and agreement in place and ISA... Sarah and Cricket
making sure Cricket clearly documents what’s needed
UIs
A) just send to FireCloud of public workflows... OK with just a ISA agreement?
B) Dockstore and Terra separate with send to and support for SAM/Google IDs/private repos (we certify this through the FISMAmoderate/FedRAMP process to prep for C)
C) Terra can call Dockstore API directly and provide a UI in Terra for interacting with Dockstore (This is what the Terra folks really want)
AI: by summer
budget for third party attestation
end of August need to have it done
should only take a month to do this
Cricket will start with internal NIST compliance and working with InfoSec to pre-screen what we’re doing
this will gate future work with Terra making
AI: ISA now with Broad, FEDRamp later for Dockstore
that’s the key for moving forward for AnVIL and STAGE in the short run
need to document and get Bernick to sign off
this is just the send to fire cloud functionality
AI: work with Neeru to get the appropriate sent to firecloud/terra button in for the March 30 Dockstore release.

WE HAVE MOVED THIS TO SEAB-78 to get it out of github


[Infrastructure] Investigate the use of alembic for openledger migrations

Current Situation

We have the DDL files for the openledger database defined in a series of SQL files in the local_postgres Docker image folder.
Suggested Improvement

For future migrations, it might be useful to have the database managed by a system like alembic^1 for tracking migrations.
Benefit

A migration manager could help us determine which migrations need to be applied to the database and what its current state is. It can also help us roll back should we need to revert to a previous change.
Alternatives

Alembic is the only tool I've used in the past (besides Django's migration tooling, which isn't really applicable here). There also appears to be another tool called yoyo-migrations
Additional context

Implementation

[ ] 🙋 I would be interested in implementing this feature.

The idea of a "migration DAG" is feeling more and more reasonable...

Can you clarify what "migration DAG" would entail? Would it just be a DAG to run alembic migrations when new ones exist? If so, that sounds good. If the idea would be to implement a migration system based on SQL DDL files, I would strongly suggest against it for the following reasons:

We would need to create and manage our own "migrations table" to maintain migrations state
It would make the local API and ingestion server environments dependent on Airflow for migrations, rather than being able to run Alembic independently to apply the migrations
We would need to implement our own conventions and approach to up/down migrations

If the DAG merely runs Alembic periodically or on command, that sounds fine and seems like a great way to solidify the production implementation and shield it from needing direct user input. However, the local environment also requires the same schema for applications that can currently run independent of the catalog. Unless we're willing to break that independence (feels like an important conversation we should have elsewhere before making that decision) we shouldn't rely exclusively on a new DAG or set of DAGs to manage migrations.
I'd also like to suggest a higher prioritisation of this issue based on the reasons given in #2364. Especially we embark on the data normalisation and other projects that may change the schema in any way, we need a more secure and consistent way to apply this that simultaneously doesn't involve running potentially destructive queries by hand in production (even copy/pasted ones) and that solves the local environment issue.

Yes, I was thinking of a DAG which would run whichever migration system we end up using. I similarly want to avoid a home-brewed migration system! Similar to Airflow, we may also add the migration step to the entrypoint for the catalog service. That would require deployments of the catalog in order to apply those changes, but it would make certain that the local environment is always up-to-date. I think paired with a DAG for executing the same migrations in production without requiring a restart, that would cover all our needs.

That would require deployments of the catalog in order to apply those changes

That seems like a fine way to manage the migrations anyway. However, it would force us to follow zero-downtime principles more closely, which I don't think we think of for the catalog db at the moment.
But that sounds good.
Do you think this issue should be an implementation plan, @AetherUnbound? I think so, but if you think it's straightforward enough maybe just updating the issue with specific instructions to use Alembic, codify the existing DDL, configure the local environment to run them in the entrypoint of the upstream_db, and create the DAG? Anything else that would warrant a more thoughtful plan?

That seems like a fine way to manage the migrations anyway. However, it would force us to follow zero-downtime principles more closely, which I don't think we think of for the catalog db at the moment.

You're right, we're a ways away from a zero-downtime deployment on the catalog. However, the catalog database is one that Airflow interacts with, not necessarily one that it depends on the same way that the API depends on its database. I don't think it should be necessary to deploy the service when the dag-sync script we have deploys updates to the DAG files (which might use that database) every minute. Certainly migrating on deploy would also be necessary, but we can trigger migrations without having to stop all running DAGs.

Do you think this issue should be an implementation plan, @AetherUnbound? I think so, but if you think it's straightforward enough maybe just updating the issue with specific instructions to use Alembic, codify the existing DDL, configure the local environment to run them in the entrypoint of the upstream_db, and create the DAG? Anything else that would warrant a more thoughtful plan?

I think an implementation plan would be a great idea for this, especially to get feedback from folks and make sure we haven't missed anything! I'll convert the issue 🙂


Add object to possible data types for value array in Select propTypes validation

Would it be possible to add the object datatype to the props validation for multi-select Select menus?
For example, I have an array of categories with name and id properties for each item. Right now, I can only add either the ID or the category name to the values array causing the renderValue function to display a list of ID's instead of the names to render correctly.

[x] This is a v1.x issue (v0.x is no longer maintained).
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

I would like the ability to pass an object (name, id) to add to the values array for multiple select menus instead of either a string or number.
Current Behavior

Currently the values array only accepts arrays of strings or numbers.
Context

I'm trying to send the id value to the api to return the relevant results while displaying the name of the property selected on the input.
Your Environment

Tech
Version

Material-UI
v1.2.0

React
16.3

It's a duplicate of #10845


chore: update package import paths and go.mod to v8

Closes: #XXX
What is the purpose of the change

Add a description of the overall background and high level changes that this PR introduces

(E.g.: This pull request improves documation of area A by adding ....
Brief Changelog
(for example:)

The metadata is stored in the blob store on job creation time as a persistent artifact
Deployments RPC transmits only the blob storage reference
Daemons retrieve the RPC data from the blob cache

Testing and Verifying
(Please pick one of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added unit test that validates ...
Added integration tests for end-to-end deployment with ...
Extended integration test for ...
Manually verified the change by ...

Documentation and Release Note

Does this pull request introduce a new feature or user-facing behavior changes? (yes / no)
Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? (yes / no)
How is the feature or change documented? (not applicable   /   specification (x/<module>/spec/)  /  Osmosis docs repo   /   not documented)

Codecov Report

Merging #1497 (8c80c6c) into main (f6275dc) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1497   +/-   ##
=======================================
  Coverage   19.49%   19.49%
=======================================
  Files         231      231
  Lines       31503    31503
=======================================
  Hits         6140     6140
  Misses      24237    24237
  Partials     1126     1126

Impacted Files
Coverage Δ

app/upgrades/v4/upgrades.go
100.00% <ø> (ø)

app/upgrades/v9/prop214.go
45.45% <ø> (ø)

app/upgrades/v9/upgrades.go
25.00% <ø> (ø)

osmoutils/partialord/partialord.go
75.00% <ø> (ø)

store/legacy/v101/tree.go
77.77% <ø> (ø)

v043_temp/address/hash.go
80.00% <ø> (ø)

x/epochs/abci.go
100.00% <ø> (ø)

x/epochs/client/cli/query.go
0.00% <ø> (ø)

x/epochs/client/cli/tx.go
0.00% <ø> (ø)

x/epochs/genesis.go
100.00% <ø> (ø)

... and 83 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68d546d...8c80c6c. Read the comment docs.


Python Decimation Filter with Aligning Frames

Required Info

Camera Model
D435

Firmware Version
<IP_ADDRESS>

Operating System & Version
Ubuntu 16.04

Kernel Version (Linux Only)
4.15.0-33-generic

Platform
PC

SDK Version
2.13.0

Language
python

Segment
Robot

Issue Description
I am trying to get the decimation filter combined with aligning frames to run, but could not make it work. I did not find any python documentation/issues/examples regarding this. As per this issue #1207 I wanted to first post-process before aligning.
Here is my current code. Everything works fine without using the filter.
# frameset of color and depth
frames = self.pipeline.wait_for_frames()
depth = frames.get_depth_frame()
# Apply filters to depth
depth = self.dec_filter.process(depth)

# TODO: Combine filtered depth with frames
# ????

# Align the depth frame to color frame
aligned_frames = self.align.process(frames)

# Get aligned frames
aligned_depth_frame = aligned_frames.get_depth_frame()
color_frame = aligned_frames.get_color_frame()

# Validate that both frames are valid
if not aligned_depth_frame or not color_frame:
    continue

I thought I figured out a way that could work, but currently the binding is bugged so I don't know if that would work:
#...
depth = self.filter_chain(depth)
list_of_frames = [rs.frame(frames.get_color_frame()), depth]
source = rs.frame_source()
frames = source.allocate_composite_frame(list_of_frames)

# Align the depth frame to color frame
aligned_frames = self.align.process(frames)
#...

Which gives me this:
TypeError: pyrealsense2.frame_source: No constructor defined!
So my question is: Am I on the right track? Or even better, Is there a way to do it without using allocate_composite_frame?

So I finally had a chance to try it on a realsense device after upgrading to 2.16. But currently this does not seem to work with python:
AttributeError: 'pyrealsense2.composite_frame' object has no attribute 'apply_filter'.
Is there any other way to apply the decimation filter before applying align? Or possibly another way to rebuild the frameset manually?

[Realsense Customer Engineering Team Comment]
Hi @Inch4Tk,
If the decimation filter applied before align, that means the image size is reduce to 1/4. So far, it's not like the current implementation.
Any reason you like to implement this way?

Thanks for your reply @RealSense-Customer-Engineering . Here in this Issue, evp-mp https://github.com/IntelRealSense/librealsense/issues/1207#issuecomment-367718085 explains in point 3 that he recommends applying filters before aligning.

We recommend to apply post-processing filters before aligning depth to color to reduce aliasing. This is the way it implemented in ''realsense-viewer''s pointcloud view.

That is why I wanted to do it that way. I also wanted to avoid having to rescale the aligned depth or color image myself to get it aligned again.

@ev-mp https://github.com/IntelRealSense/librealsense/issues/1207#issuecomment-367718085 explains in point 3 that he recommends applying filters before aligning. A python example code is required to have the correct the filters before align.

Since 2.16 there is a simpler way to do this.
Something like:
fs = pipe.wait_for_frames()
fs = fs.apply_filter(align).apply_filter(decimate);

The idea is to have single apply_filter method that can compose any operation, so that you don't have to deal with splitting and re-building the frameset.
I can't check the code right now, but if you run into problems please let us know and we will post a full example.

Hi
I used it and i got error saying that " object has no attribute 'apply_filter' "

[Realsense Customer Engineering Team Comment]
Ticket being closed due to inactivity for 30+ days

I would also like to see a working python example of alignment and post-processing together. This issue was closed without one being provided. The suggest apply_filter method does not appear to exist as shown.

This worked for me when i modified the align-dept2color.py example.  both frames come out 640x480
decimate = rs.decimation_filter(8)
align_to = rs.stream.color
align = rs.align(align_to)

# Streaming loop
try:
    while True:
        # Get frameset of color and depth
        frames = pipeline.wait_for_frames()
        decimated = decimate.process(frames).as_frameset()
        # Align the depth frame to color frame
        aligned_frames = align.process(decimated)

A reference python snippet was provided by @darrell-rg

This worked for me when I modified the align-dept2color.py example. both frames come out 640x480
decimate = rs.decimation_filter(8)
align_to = rs.stream.color
align = rs.align(align_to)

# Streaming loop
try:
    while True:
        # Get frameset of color and depth
        frames = pipeline.wait_for_frames()
        decimated = decimate.process(frames).as_frameset()
        # Align the depth frame to color frame
        aligned_frames = align.process(decimated)

This script does work. So the size of frames doesn't change after the decimation filter, is that correct? How about " the Decimation Filter will reduce spatial resolution preserving z-accuracy and performing some rudamentary hole-filling."

How about " the Decimation Filter will reduce spatial resolution preserving z-accuracy and performing some rudamentary hole-filling."

Is there any update on this aspect? I am trying to use the decimation filter specifically to reduce the resolution of the frame - and that seems like the most intuitive use of the filter. But, I am not getting a reduced frame size, I'm just getting the voxels in little grids of 3x3, 4x4, 5x5, etc.
As per https://github.com/IntelRealSense/librealsense/issues/10716#issue-1316384390, the last line of that opening post says that the frame size should be reduced if the decimation filter is applied AFTER alignment - but I can't get that to work on my system. I get errors a few lines later, in the open3d.geometry.RGBDImage.create_from_color_and_depth() function.

Can anyone please show me the result(image) after this(applying filter)?

Hi @Bash226  An animated image in Intel's post-processing guide at the link below shows before (original) and after (post-processing) when applying filters such as Decimation.
https://dev.intelrealsense.com/docs/rs-post-processing


Lower level Subscenes are not refreshed automatically in parent scenes

This issue is fresh continuation of https://github.com/godotengine/godot/issues/2307 topic.
Current status:

Issue it's partially addressed since changes on the first level seems to be refreshed in parent scenes automatically.
For lower level changes we still need to close and reopen parent scenes.

(I'm not 100% sure what milestone should be, for now setting 2.0 since this is milestone of original issue.)

Is this the only issue left regarding automatically refreshing changed scenes?

@reduz Somewhat related bug would be this one: https://github.com/godotengine/godot/issues/3127

could I get a test project for this? like 3 scenes with different inheritance and what do I have to change for it to work

@reduz sure, here is a sample: https://dl.dropboxusercontent.com/u/168251/godot/bugsquad/AutorefreshScenesSample.7z
here is a vid that demonstrates how to use this sample to get the bug: https://youtu.be/sARtaENFTl4
This sample is also valid for https://github.com/godotengine/godot/issues/3127 but more on this inside https://github.com/godotengine/godot/issues/3127

I can confirm that the behaviour shown in the video is exactly what I saw and mentioned in https://github.com/godotengine/godot/issues/2307#issuecomment-165066022 back then.
(i.e. Scenes A -> B -> C, change in C is properly shown in B but not in A)


Loosen bound on base on Hackage

lzma builds for me with GHC 8.10.1
Cheers!

This was resolved via #20 already


FormData [ReferenceError: FormData is not defined]

As part of a suite of tests in a mocha environment, FormData is now not defined. This is making the tests fail. Could be perhaps part of the 9.4 updates.
ReferenceError: FormData is not defined
Revering to the previous version fixes the issue
  "jsdom": "9.3.0",

Cannot reproduce:
const jsdom = require("jsdom");
const window = jsdom.jsdom().defaultView;

// From inside:
window.eval(`console.log(FormData))`);

// From outside:
console.log(window.FormData);

both console.logs work.
Please provide a small test case, not using any external dependencies (like mocha), to show the problem.

Probably a dupe of #1549.

It looks like FormData is not an enumerable property in<EMAIL_ADDRESS>anymore. Before, in<EMAIL_ADDRESS>and earlier, FormData was an enumerable property.
This doesn't break in Mocha specifically, I think, but in jsdom-global (which I assume is often used in combination with Mocha).
To reproduce:
$ npm install<EMAIL_ADDRESS>const jsdom = require('jsdom');

const window = jsdom.jsdom().defaultView;

console.log(Object.keys(window).filter((key) => key === 'FormData'));

This logs an array with one value FormData. In 9.4.0 and up this logs an empty array.

Ah, yeah, that was a bug fix in 9.4.0. Closing since this is not a jsdom bug, but happy to continue helping in the closed thread.
You may also enjoy https://github.com/tmpvar/jsdom/wiki/Don't-stuff-jsdom-globals-onto-the-Node-global .


No such module 'React' when newly integrating into an existing app (0.63.2)

Description
Integrating React Native 0.63.2 into an existing Swift-based project does not compile with the following error on Xcode:
No such module 'React'
Note: A full-example RN project is included in this ticket
React Native version:
System:
    OS: macOS 10.15.6
    CPU: (8) x64 Intel(R) Core(TM) i7-7820HQ CPU @ 2.90GHz
    Memory: 142.84 MB / 16.00 GB
    Shell: 3.2.57 - /bin/bash
  Binaries:
    Node: 14.5.0 - /usr/local/bin/node
    Yarn: 1.22.4 - /usr/local/bin/yarn
    npm: 6.14.5 - /usr/local/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  Managers:
    CocoaPods: 1.9.3 - /usr/local/bin/pod
  SDKs:
    iOS SDK:
      Platforms: iOS 13.6, DriverKit 19.0, macOS 10.15, tvOS 13.4, watchOS 6.2
    Android SDK:
      API Levels: 25, 27, 28
      Build Tools: 27.0.3, 28.0.0, 28.0.3
      System Images: android-28 | Google APIs Intel x86 Atom, android-28 | Google Play Intel x86 Atom
      Android NDK: Not Found
  IDEs:
    Android Studio: 3.6 AI-192.7<IP_ADDRESS>92135
    Xcode: 11.6/11E708 - /usr/bin/xcodebuild
  Languages:
    Java: 1.8.0_251 - /usr/bin/javac
    Python: 2.7.17 - /usr/local/bin/python
  npmPackages:
    @react-native-community/cli: Not Found
    react: 16.13.1 => 16.13.1
    react-native: ^0.63.2 => 0.63.2
  npmGlobalPackages:
    *react-native*: Not Found

Steps To Reproduce

Create a new Storyboard-based Xcode project
Follow the steps described here: https://reactnative.dev/docs/integration-with-existing-apps
Update the Podfile to follow the format of the latest, as described here: https://github.com/facebook/react-native/blob/v0.63.2/template/ios/Podfile
Podfile here: https://github.com/algera/rnproject-error/blob/master/ios/Podfile
Run pod install -> Completes successfully
Open Xcode and build the project

Expected Results
Expect Xcode project to compile, link and build correctly.
Actual Results

Snack, code example, screenshot, or link to a repository:
Full repository available here:
https://github.com/algera/rnproject-error
Related
https://github.com/facebook/react-native/issues/26256

I have the same issues.

Also seeing this issue.

In case it's of use to anyone, I was able to work around this by adding React imports in a bridging header file. Example in a PR against @algera's sample repo here: https://github.com/algera/rnproject-error/pull/1
Caveat: I'm brand new to native iOS dev, so unsure if I've missed anything or if there may be problems with that approach.

@jbrunton This looks good - Removing the import React and utilizing the bridging header with #import <React/RCTRootView.h> is working sufficiently. Closing this issue.

@algera: Glad it helped! I think it would be useful to keep this issue open, however. At a minimum, it would be good to have someone from the React Native team confirm whether or not this is expected behavior, and update the docs if it is.
If you prefer to keep this closed, I'll open another issue to track.

Thank you @jbrunton , your workaround worked for me!
I am somewhat disappointed that the documentation page for "Integration with existing apps" (https://reactnative.dev/docs/integration-with-existing-apps) hasn't been updated with this information, even with the docs set to v0.63. In fact, the pages hasn't been updated in 3 years, which is pretty bad considering it's the next page after "installation" - I would have assumed that it is kept at least somewhat recent.
This issue should definitely be kept open until that documentation is fixed.

Hi all! Sorry you are having issues, these type of questions belong on stack overflow.
As @hannessolo pointed out, the docs may need updating. A PR to the docs will be appreciated!

@safaiyeh The crux of the issue may be that the React module is no longer able to be imported into Swift and instead requires a bridging header for RCT related classes. This may be intentional as of 0.63.2, however AFAIK, preceding versions of RN (<= 0.62.x), this was not the case. Happy to submit a PR to alleviate future misunderstandings if import React has been indeed deprecated / removed.

Closing as React Native version 0.63.3 has addressed this issue and is currently available in production.  import React is again available.

I have having same issue on 0.63.4
{
    "name": "native",
    "version": "1.0.0",
    "dependencies": {
        "components": "1.0.0",
        "core-js": "^3.8.1",
        "react": "^17.0.1",
        "react-native": "^0.63.4",
        "react-native-check-version": "^1.0.8",
        "react-native-device-info": "^7.3.1"
    }
}

Podfile looks like

source 'https://github.com/CocoaPods/Specs.git'

# Required for Swift apps
platform :ios, '11.0'
#use_frameworks!

# The target name is most likely the name of your project.
target 'RNSandboxDemo' do

  # Your 'node_modules' directory is probably in the root of your project,
  # but if not, adjust the `:path` accordingly

  pod 'React'
  #, :podspec => '../RNSandboxDemo/node_modules/react-native'

  # Explicitly include Yoga if you are using RN >= 0.42.0
  pod "Yoga", :path => "../RNSandboxDemo/node_modules/react-native/ReactCommon/yoga"

  # Third party deps podspec link
  pod 'DoubleConversion', :podspec => '../RNSandboxDemo/node_modules/react-native/third-party-podspecs/DoubleConversion.podspec'
  pod 'glog', :podspec => '../RNSandboxDemo/node_modules/react-native/third-party-podspecs/glog.podspec'
  pod 'Folly', :podspec => '../RNSandboxDemo/node_modules/react-native/third-party-podspecs/Folly.podspec'

end

#import <React/RCTRootView.h>

What about Swift?


Setup event based reconciliation based on changes of non-dependent resources

Type of question
How to implement a specific feature
Is it possible to setup event based reconciliation of custom resources based on changes of non-dependent resources?
I have two types of custom resources (App1 and App2) which I use to manage instances of two different types of apps. Many instances of App2 can communicate with an instance of App1's Service.
I want to have a way to control to which App1 instance a group of App2 instances will communicate with. Moreover, I want to be able to change the App1 instance to which a group is associated without having to update the spec of App1s.
With this in mind I came up with the following:

What did you do?
I created APIs for each type of CRD (App1, AppBinding, App2) and wrote the ansible playbook and role to handle them.

The playbook and role for App1 handles deployments for the App1 instances.
The playbook and role for App2 looks up AppBinding resources based on the binding selector and if present uses the information present in its status to setup the App2 instance.
The playbook and role for AppBinding looks up App1 resources based on the app selector and populates its status field appropriately.

I want to be able to reconcile the whole chain. Specifically:

If an App1 changes (looking at labels here), I want to reconcile AppBindings.
If an AppBinding changes (looking at labels and status), I want to reconcile App2s.

What did you expect to see?
A way to implement this type of event based triggering of reconciliation based on non-dependent resources.
What did you see instead? Under which circumstances?
The obvious way that I see for handling the whole the reconciliation chain would be to rely on timer based reconciliation for each resource type (i.e. reconcile every couple of seconds). However, I'm afraid that it will become problematic because:

I expect to deal with a lot of instances.
If reconciliation isn't done in the correct order then some things will break until reconciliation is done again (e.g. if App2s are reconciled before AppBindings then they might use the wrong App1 instance).

The other alternative that I see would be to invert the way the change is propagated. E.g.:

When an App1 instance is updated/created, find AppBindings that need updating and update them.
When an AppBinding is updated, find App2s that need updating and update them.

Both solutions don't feel right, so I'm looking to get for your opinion on how to best handle this usecase.
Environment
Operator type:
/language ansible
Kubernetes cluster type:
GKE.
$ operator-sdk version
operator-sdk version: "v1.3.0", commit: "1abf57985b43bf6a59dcd18147b3c574fa57d3f6", kubernetes version: "1.19.4", go version: "go1.15.5", GOOS: "linux", GOARCH: "amd64"

$ kubectl version
Client Version: version.Info{Major:"1", Minor:"19", GitVersion:"v1.19.4", GitCommit:"d360454c9bcd1634cf4cc52d1867af5491dc9c5f", GitTreeState:"archive", BuildDate:"2020-11-25T13:19:56Z", GoVersion:"go1.15.5", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"18+", GitVersion:"v1.18.12-gke.1205", GitCommit:"160736941f00e54acb1c0a4647166b6f6eb211d9", GitTreeState:"clean", BuildDate:"2021-01-05T23:44:13Z", GoVersion:"go1.13.15b4", Compiler:"gc", Platform:"linux/amd64"}

I owe an update on the issue so here we go: In the end I did not find a good way to deal with this using the ansible runner and ended up experimenting with other frameworks.
Being more familiar with python, I ended up implementing things using kopf so the original problem no longer applies to me. I can answer additional questions if there are any otherwise I'm okay with closing the issue as is.

Great 👍
So how does we connect events on resources not managed by an operator to one of our CRD (primary resource).
It would be great, if you could share a link to the code. so that I can better understand the flow.
In tektoncd/operator, (built with knative/pkg) we had to deal with something similar. We wanted one of our Reconcilers to be triggered, on events on namespaces. The namespaces were not created by operator, so there was no owner reference or label to extract the keyRef of the primary resource.
We ended making a hack, where we set the name of a CR we want in the namespace event, before it gets enqueued.
https://github.com/tektoncd/operator/blob/8734ca2ea98e2220127b3159b13e0521dc943ab5/pkg/reconciler/kubernetes/tektonconfig/controller.go#L86 .
This particular, CRD (primary resource) is a "singleton" CRD so we know the name.

Unfortunately I can't share the code as it lives in a private repository outside of github but I can happily describe what I did and hopefully that clarifies it.
I realized that in my case it made sense to have all custom resources collectively managed by a single (kopf) operator. Thus, I ended up adapting the 'alternative' solution that I was talking about in my first message:

When an App1 instance is updated/created/deleted, find AppBindings that need updating and update them.
When an AppBinding is updated/created/deleted, find App2s that need updating and update them.

Instead of actually updating the affected objects directly, I trigger the update handler (reconciler) by programatically adding a temporary annotation to each resource that needs updating. This works pretty well and to make the lookups efficient, I make use of in-memory indexing over the labels and match-labels in order to figure out what objects are affected.
On a first glance it does not look like your use-case has a lot of similarity to mine, nonetheless, I hope it helps.

Thanks :heart:

I trigger the update handler (reconciler) by programatically adding a temporary annotation to each resource that needs updating.

Interesting, this would work in our situation too.
Less hacky and more clear for a code reader. :technologist: :+1:


feat: end to end functionality for registering ui to servers and on demand scaling

@muratozkan and @bhavaniMiro - this is almost ready to merge.
I would like to always maintain that local no docker / no k8s environments work which will require some small modifications to the new api service as well as updates to the docs.

@muratozkan and @bhavaniMiro - we should be good to go!


[Discussion] Microsoft Security Advisory CVE-2017-11879: Open Redirect can cause Elevation Of Privilege

Microsoft Security Advisory CVE-2017-11879: Open Redirect can cause Elevation Of Privilege
Executive Summary
Microsoft is releasing this security advisory to provide information about a vulnerability in public ASP.NET Core 2.0. This advisory also provides guidance on what developers can do to update their applications correctly.
Microsoft is aware of a security vulnerability some public versions of ASP.NET Core where an Open Redirect exists, leading to Elevation Of Privilege.
Announcement
The original announcement can be found at https://github.com/aspnet/Announcements/issues/277
Mitigation Factors
ASP.NET Core applications using version 1.0.x or 1.1.x are not affected.
Affected Software
The vulnerabilities affect any Microsoft .NET Core project if it uses the following affected package versions.

Package name
Package versions
Fixed package versions

Microsoft.AspNetCore.All
2.0.0
2.0.1

Microsoft.AspNetCore.Mvc.Core
2.0.0
2.0.1

Advisory FAQ
How do I know if I am affected?
.NET Core and ASP.NET Core have two types of dependencies: direct and transitive. If your project has a direct or transitive dependency on any of the packages and versions listed above, you are affected.
Direct Dependencies
Direct dependencies are dependencies where you specifically add a package to your project. For example, if you add the Microsoft.AspNetCore.Mvc package to your project then you have taken a direct dependency on Microsoft.AspNetCore.Mvc.
Direct dependencies are discoverable by reviewing your csproj file.
Transitive Dependencies
Transitive dependencies occur when you add a package to your project that in turn relies on another package. For example, if you add the Microsoft.AspNetCore.Mvc package to your project it depends on the Microsoft.AspNetCore.Mvc.Core package (among others). Your project has a direct dependency on Microsoft.AspNetCore.Mvc and a transitive dependency on the Microsoft.AspNetCore.Mvc.Core package.
Transitive dependencies are reviewable in the Visual Studio Solution Explorer window, which supports searching, or by reviewing the project.lock.json file contained in the root directory of your project for project.json projects or the project.assets.json file contained in the obj directory of your project for csproj projects. These files are the authoritative list of all packages used by your project, containing both direct and transitive dependencies.
How do I fix my affected application?
You will need to fix both direct dependencies and review and fix any transitive dependencies. The affected packages and versions in the previous “Affected Software” section include each vulnerable package, the vulnerable versions, and the patched versions

If you are targeting .NET Core a "meta-package" is used, Microsoft.AspNetCore.All. You should begin by updating its version number to 2.0.1, this will pull in the fixed Microsoft.AspNetCore.Mvc.Core package.
If you are targeting .NET Framework you should first update the Microsoft.AspNetCore version to the version number to 2.0.1, then adjust the version number for any other packages beginning with Microsoft.AspNetCore. to 2.0.1.

Fixing Direct Dependencies – Projects targeting .NET Core
Open your projectname.csproj file in your editor, or right click the project in Visual Studio 2017 and choose Edit projectname.csproj from the content menu, where projectname is the name of your project. Look for PackageReference nodes. The following shows an example project file:
<Project Sdk="Microsoft.NET.Sdk.Web">
  <PropertyGroup>
    <TargetFramework>netcoreapp2.0</TargetFramework>
  </PropertyGroup>
  <ItemGroup>
    <PackageReference Include="Microsoft.AspNetCore.All" Version="2.0.0" />
  </ItemGroup>
  <ItemGroup>
    <DotNetCliToolReference Include="Microsoft.VisualStudio.Web.CodeGeneration.Tools" Version="2.0.0" />
  </ItemGroup>
</Project>

The example has has a reference to the vulnerable metapackage, as seen by the single PackageReference elements. The name of the package is in the Include attribute, and the package version number is in the Version attribute that is exposed to the right of the package name. The example shows a single direct dependency on Microsoft.AspNetCore.All version 2.0.0.
To update to the fixed package, change the version number to the updated package version. In the example, this would be updating Microsoft.AspNetCore.All to 2.0.1.
After updating the vulnerable package version, save your csproj file. The example csproj would now look as follows:
<Project Sdk="Microsoft.NET.Sdk.Web">
  <PropertyGroup>
    <TargetFramework>netcoreapp2.0</TargetFramework>
  </PropertyGroup>
  <ItemGroup>
    <PackageReference Include="Microsoft.AspNetCore.All" Version="2.0.1" />
  </ItemGroup>
  <ItemGroup>
    <DotNetCliToolReference Include="Microsoft.VisualStudio.Web.CodeGeneration.Tools" Version="2.0.0" />
  </ItemGroup>
</Project>

If you are using Visual Studio and save your updated csproj file, Visual Studio will restore the new package version. You can see the restore results by opening the Output Window (Ctrl+Alt+O) and changing the Show output from drop-down list to Package Manager.
If you are not using Visual Studio open a command line and change to your project directory. Execute the dotnet restore command to restore your new dependency.
Fixing Direct Dependencies – Projects targeting .NET Framework
Open your projectname.csproj file in your editor, or right click the project in Visual Studio 2017 and choose Edit projectname.csproj from the content menu, where projectname is the name of your project. Look for PackageReference nodes. The following shows an example project file:
<Project Sdk="Microsoft.NET.Sdk.Web">
  <PropertyGroup>
    <TargetFramework>net461</TargetFramework>
  </PropertyGroup>
  <ItemGroup>
    <PackageReference Include="Microsoft.AspNetCore.Mvc.Core" Version="2.0.0" />
  </ItemGroup>
  <ItemGroup>
    <DotNetCliToolReference Include="Microsoft.VisualStudio.Web.CodeGeneration.Tools" Version="2.0.0" />
  </ItemGroup>
</Project>

The example has has a reference a single packages, as seen by the PackageReference element. The name of the package is in the Include attribute, and the package version number is in the Version attribute that is exposed to the right of the package name. The example shows a direct dependency on one of the vulnerable packages from the table above, Microsoft.AspNetCore.Core version 2.0.0.
To update to the fixed package, change the version number to the updated package version. In the example, this would be updating Microsoft.AspNetCore.Core to 2.0.1.
After updating the vulnerable package version, save your csproj file. The example csproj would now look as follows:
<Project Sdk="Microsoft.NET.Sdk.Web">
  <PropertyGroup>
    <TargetFramework>net461</TargetFramework>
  </PropertyGroup>
  <ItemGroup>
    <PackageReference Include="Microsoft.AspNetCore.Mvc.Core" Version="2.0.1" />
  </ItemGroup>
  <ItemGroup>
    <DotNetCliToolReference Include="Microsoft.VisualStudio.Web.CodeGeneration.Tools" Version="2.0.0" />
  </ItemGroup>
</Project>

If you are using Visual Studio and save your updated csproj file, Visual Studio will restore the new package version. You can see the restore results by opening the Output Window (Ctrl+Alt+O) and changing the Show output from drop-down list to Package Manager.
If you are not using Visual Studio open a command line and change to your project directory. Execute the dotnet restore command to restore your new dependency.
After updating your direct dependencies
Recompile your application.
If after recompilation you see a Dependency conflict warning, you must update your other direct dependencies to the appropriate version.
For example if your project refers a direct reference to Microsoft.AspNetCore.Mvc.Cors with a version number of 2.0.0 when you update your Microsoft.AspNetCore.Mvc package to 2.0.1, compilation will throw:
NU1012      Dependency conflict. Microsoft.AspNetCore.Mvc 2.0.1 expected Microsoft.AspNetCore.Mvc.Cors >= 2.0.1 but received 2.0.0
To fix this, edit the version for the expected package to be the version expected by updating your project.json in the same way that you used to update the vulnerable package versions.
After you have addressed all of your direct dependencies, you must also review your transitive dependencies.
Reviewing Transitive Dependencies
There are two ways to view transitive dependencies. You can either use Visual Studio’s Solution Explorer, or you can review your project.assets.json file.
Using Visual Studio Solution Explorer (VS2017)
If you want to use Solution Explorer, open your project in Visual Studio 2017, and then press Ctrl+; to activate the search in Solution Explorer. Search for each of the vulnerable package names and make a note of the version numbers of any results you find.
For example, searching for Microsoft.AspNetCore.Mvc.Core in an example project that contains a package that takes a dependency on Microsoft.AspNetCore.Mvc shows the following results in Visual Studio 2017.

The search results appear as a tree. In these results, you can see we have found references to Microsoft.AspNetCore.Mvc.Core version 1.1.2.
Under the Dependencies node will be a NuGet node. Under the NuGet node will be the list of packages you have directly taken a dependency on and their versions. In this example, the application takes a direct dependency on Microsoft.AspNetCore.Mvc. Microsoft.AspNetCore.Mvc in turn has leaf nodes that list its dependencies and their versions. In the example the Microsoft.AspNetCore.Mvc package takes a dependency on a version of Microsoft.AspNetCore.Mvc.ApiExplorer which in turn takes a dependency on a vulnerable version of Microsoft.AspNetCore.Mvc.Core.
Manually reviewing project.assets.json (VS2017)
Open the project.assets.json file from your project’s obj directory in your editor. We suggest you use an editor that understands json and allows you to collapse and expand nodes to review this file; both Visual Studio and Visual Studio Code provide this functionality.
Search the project.assets.json file for each of the vulnerable packages, using the format packagename/ for each of the package names from the table above. If you find the assembly name in your search examine the line on which they are found, the version number is after the / and compare to the vulnerable versions table above. For example a search result that shows Microsoft.AspNetCore.Mvc.Cors/1.1.0 is a reference to v1.1.0 of Microsoft.AspNetCore.Mvc.Cors.   If your project.assets.json file includes references to any of the vulnerable packages shown above then you will need to fix the transitive dependencies.
If you have not found any reference to any vulnerable packages this means none of your direct dependencies depend on any vulnerable packages or you have already fixed the problem by updating the direct dependencies.
If your transitive dependency review found references to any of the vulnerable packages you must add a direct dependency to the updated package to your csproj file to override the transitive dependency. Open your projectname.csproj file in your editor, or right click on the project in Visual Studio 2017 and choose Edit projectname.csproj from the content menu, where projectname is the name of your project. Look for PackageReference nodes, for example:
<Project Sdk="Microsoft.NET.Sdk.Web">
  <PropertyGroup>
    <TargetFramework>net461</TargetFramework>
  </PropertyGroup>
  <ItemGroup>
    <PackageReference Include="ThirdParty.NotUpdatedYet" Version="2.0.0" />
  </ItemGroup>
  <ItemGroup>
    <DotNetCliToolReference Include="Microsoft.VisualStudio.Web.CodeGeneration.Tools" Version="2.0.0" />
  </ItemGroup>
</Project>

For each of the vulnerable packages your search returned you must add a direct dependency to the updated version by adding it to the csproj file. You do this by adding a new line to the dependencies section, referring the fixed version. For example, if your search showed a transitive reference to the vulnerable Microsoft.AspNetCore.Mvc.Core version 2.0.0 you would add a reference to the fixed version, 2.0.1.
<Project Sdk="Microsoft.NET.Sdk.Web">
  <PropertyGroup>
    <TargetFramework>net461</TargetFramework>
  </PropertyGroup>
  <ItemGroup>
    <PackageReference Include="Microsoft.AspNetCore.Mvc.Core" Version="2.0.1" />
    <PackageReference Include="ThirdParty.NotUpdatedYet" Version="2.0.0" />
  </ItemGroup>
  <ItemGroup>
    <DotNetCliToolReference Include="Microsoft.VisualStudio.Web.CodeGeneration.Tools" Version="2.0.0" />
  </ItemGroup>
</Project>

After you have added the direct dependency reference, save your csproj file.
If you are using Visual Studio, save your updated csproj file and Visual Studio will restore the new package versions. You can see the restore results by opening the Output Window (Ctrl+Alt+O) and changing the Show output from drop-down list to Package Manager.
If you are not using Visual Studio, open a command line and change to your project directory. Execute the dotnet restore command to restore your new dependencies.
Rebuilding your application
Finally rebuild your application, test as you would do normally and redeploy using your favored deployment mechanism.
Other Information
Reporting Security Issues
If you have found a potential security issue in .NET Core, please email details to<EMAIL_ADDRESS>Reports may qualify for the .NET Core Bug Bounty. Details of the .NET Core Bug Bounty including Terms and Conditions are at https://aka.ms/corebounty.
Support
You can ask questions about this issue on GitHub in the .NET Core or ASP.NET Core organizations. These are located at https://github.com/dotnet/ and https://github.com/aspnet/. The Announcements repo for each product (https://github.com/dotnet/Announcements and https://github.com/aspnet/Announcements) will contain this bulletin as an issue and will include a link to a discussion issue where you can ask questions.
Disclaimer
The information provided in this advisory is provided "as is" without warranty of any kind. Microsoft disclaims all warranties, either express or implied, including the warranties of merchantability and fitness for a particular purpose. In no event shall Microsoft Corporation or its suppliers be liable for any damages whatsoever including direct, indirect, incidental, consequential, loss of business profits or special damages, even if Microsoft Corporation or its suppliers have been advised of the possibility of such damages. Some states do not allow the exclusion or limitation of liability for consequential or incidental damages so the foregoing limitation may not apply.
Acknowledgments
Thanks to Kévin Chalet for reporting this issue.
External Links
CVE-2017-11879:
Revisions
V1.0 (Nov 14, 2017): Advisory published.
Version 1.0
Last Updated 2017-11-14

Any more information? Is every application vulnerable, or only applications that use redirects in a particular way?

In attempting to update Microsoft.AspNetCore.Mvc.Core to 2.0.1 the update fails on attempting to resolve Microsoft.Extensions.DependencyModel 2.0.3. That version does not exist in NuGet.

Is every application vulnerable, or only applications that use redirects in a particular way?

Every application that uses ControllerBase.LocalRedirect() or returns a LocalRedirectResult is impacted.
If you've kept the AccountController class coming with the ASP.NET Core template for VS, you're likely vulnerable as LocalRedirect is used to redirect the users back to the original return URL when they log in or register.

@tillig thanks for bringing the missing packages to our attention. They just got uploaded to NuGet.org (https://www.nuget.org/packages/Microsoft.Extensions.DependencyModel) and you should be able to restore it as soon as NuGet.org's index is updated.

@blowdart  - There doesn't appear to be a 2.0.1 of the Microsoft.AspNetCore.All metapackage, only 2.0.3.

@Eilon @muratg - I don't control the publishing or metapackages.

Ah. Apparently I was given the wrong metapackage version for the bulletin. This is now corrected. 2.0.3 it is.

The dot.net site doesn't have the latest Windows Server Hosting installer with these fixes.
When I upgrade to .All v2.0.3, the server bombs bc the Runtime Store doesn't have the latest dll.  I'm not sure who owns the downloads for that site?  Any Microsoft employee who could contact that person and let them know would be great.
The error I got is below:
An assembly specified in the application dependencies manifest (GroupSystem.BenefitsPortal.AspNetCore.deps.json) was not found:
package: 'Microsoft.AspNetCore.Antiforgery', version: '2.0.1'
path: 'lib/netstandard2.0/Microsoft.AspNetCore.Antiforgery.dll'
This assembly was expected to be in the local runtime store as the application was published using the following target manifest files:
aspnetcore-store-2.0.3.xml

@muratg @shirhatti  Any news on when the hosting installer gets updated?

@leecow @joeloff re@blowdart's last question.

Working on the dotnet site now. In the meantime, you can grab it directly from https://download.microsoft.com/download/5/C/1/5C190037-632B-443D-842D-39085F02E1E8/DotNetCore.2.0.3-WindowsHosting.exe

That worked - thanks @leecow!  It hadn't really hit me that this is a downside with the Runtime Store/.All package until this first upgrade, that the package in your project and the server installer need to be in lockstep.  I guess I should be using Docker.
It would be cool to have a self-updating command within the dotnet cli.

@leecow When we have the new hosting bundle installer link, I'll get it into the docs asap.
btw- @blowdart I just came over from the Announcement topic. In the section Fixing Direct Dependencies – Projects targeting .NET Core it still shows that the go-to metapackage for "All" is 2.0.1. It should be 2.0.3, correct? I saw you say you updated :point_up:, but it looks like that section needs the version fix, too ...

To update to the fixed package, change the version number to the updated package version. In the example, this would be updating Microsoft.AspNetCore.All to 2.0.1.

@guardrex Fixed, thanks

@guardrex - links on https://github.com/dotnet/core/blob/master/release-notes/download-archives/2.0.3.md are correct. Only the posting to dot.net are pending.

@leecow We use this one :point_right: https://aka.ms/dotnetcore.2.0.0-windowshosting ... so I presume you'll have me take that to ...
https://aka.ms/dotnetcore.2.0.3-windowshosting
... when the time comes. Is that right?

I hadn't planned on creating an aka.ms url but suppose I could if it's needed.

We've gone back-and-forth with aka.ms links for the hosting bundle. @Rick-Anderson, do we especially need an aka.ms link for the hosting bundle installer for the topics?

@guardrex  If you don't use a fwlink you'll have to update the doc when the latest download link changes. Your call

@leecow standby a sec ... let me talk to Rick offline for a sec about it.

Created the following which we'll keep updated and get you out of the link update game.

https://aka.ms/dotnetcore-2-windowshosting
https://aka.ms/dotnetcore-1-windowshosting

@leecow Ah ... thank u sir! :smile:

Using openvas for pen testing I still get a warning as the vunerable packages get installed even with hosting bundle 2.0.8
Is this for backward compatibility?
This is after removing everything and reinstalling.
openvas checks for the existance of the package not whether its being used.
Presumably if its there it could inadvertantly be used.
Vulnerability Detection Result
Installed version: <IP_ADDRESS>05
File checked:      c:\program files (x86)\dotnet\store\x86
etcoreapp2.0\microsoft.aspnetcore.mvc.core\2.0.0\lib
etstandard2.0\Microsoft.AspNetCore.Mvc.Core.dll
Fixed version:     2.0.1


Sensu RPM prevents other RPMs from writing to /etc/sensu/conf.d

We have several RPMs that are droping sensu configs into the /etc/sensu/conf.d/checks directory. After version 0.27.0 the sensu RPM seems to own the /etc/sensu & /etc/sensu/conf.d directories which prevents our RPMs from installing and placing those files.
We are using the nebula release gradle plugin for create the RPMs. When it creates the spec file it ensures that the directories are created for the files its putting in place, which causes a conflict with the sensu RPM. This did not happen with sensu version 0.26.x.
Using rpm command I was able to see that sensu defiantly owned /etc/sensu directories:
$ rpm -qf /etc/sensu/conf.d/
sensu-0.27.0-1.el7.x86_64

With sensu 0.26.0 it does not own that directory:
$ rpm -qf /etc/sensu/conf.d
file /etc/sensu/conf.d is not owned by any package

Any idea what has changed in the RPM creation on the sensu side that might be causing this problem?
Expected Behavior
Install other RPMs that drop configurations to the sensu directory
Current Behavior
Error from yum/rpm saying it is owned by sensu:
Transaction check error:
  file /etc/sensu from install of sampleapp-0:0.18.0-SNAPSHOT.x86_64 conflicts with file from package sensu-1:0.27.0-1.el7.x86_64
  file /etc/sensu/conf.d from install of sampleapp-0:0.18.0-SNAPSHOT.x86_64 conflicts with file from package sensu-1:0.27.0-1.el7.x86_64

Possible Solution
Roll back directory ownership in the spec file.
Steps to Reproduce (for bugs)
Context
Your Environment

Sensu version used: 0.26.0 & 0.27.0
Active Sensu extensions (e.g. WizardVan 0.1.0): NA
Operating System and version (e.g. Ubuntu 14.04): CentOS 7-3.1611
Transport and runtime versions (e.g. RabbitMQ 3.6.2 on Erlang 18.2): NA

I believe that was an intentional choice @cwjohnston can you elaborate? I seem to recall a discussion about epel packages being signed. Btw I don't know as much about packaging RPMs as I do debs but this sounds like a sane thing to me, if you have 2 packages that manage the same group of files then how would you resolve conflicts.
What is the purpose of managing files in /etc/sensu/conf.d with an rpm and not some config management like chef, puppet, ansible?
I have not really had to package RPMs in a while so take what I say with a grain of salt as I am probably missing something important.

@majormoses Thanks for the feedback. This is not about signing the RPM, its about how the RPM claims ownership in the RPM database on the host. I don't know the best term for what RPM is doing, but it has to deal with the rpm database as far as I know.
We practice immutable infrastructure with our deployments. So we create a image once and deploy that image where we need to. If we make a change, then we create a new image. RPMs are the best why to manage that.

@blee1170 thanks for reporting this issue, it does sound to me like a regression. Starting with Sensu 0.27 we switched our build tool chain to Chef Omnibus, and as a result the rpm specs are being built differently which may account for the behavior you are seeing.

@cwjohnston Is it something that you might be willing to switch back?

Agreed it sounds like a regression, my question is this preferable now after the fact? I still question the need for multiple packages to manage files in the same dir. I still feel like what you want is config management to manage files. Just my 2 cents...

Looks like the sensu RPM is also owning the /etc/systemd/system directory as well. So we are unable to drop in systemd services as well.

Again I see this as sane (and personally desired) behavior. IMHO you should not be using a package to manage other packages files, you need config management to manage these.

Here are some links to the CM that sensu has out of the box code for:

https://github.com/sensu/sensu-chef
https://github.com/sensu/sensu-puppet
https://github.com/sensu/sensu-ansible

To clarify my stance I agree that it is a bug that it does not allow writing to /etc/sensu/conf.d but for every other resource that the package manages I do not feel that other packages should attempt to manage these. This introduces complexity and risk when dealing with upgrades (who wins between changes)

@blee1170

Is it something that you might be willing to switch back? Not Omnibus, but how the RPM claims ownership of the directory.

I understand the use case as "RPM packages should be able to write JSON configuration into /etc/sensu/conf.d and its subdirectories." I think if at all practical we should enable this use case. 👍

Looks like the sensu RPM is also owning the /etc/systemd/system directory as well. So we are unable to drop in systemd services as well.

This sounds like a big problem as well, and  I'd like to be able to reproduce this myself. Is this causing problems with any publicly available packages you're aware of?

I've opened https://github.com/sensu/sensu-omnibus/issues/224 to track this, as the changes to address the problem will likely be made the sensu-omnibus project.


Add support for API key auth when using Google Vertex AI

After some investigation we realized that API key authentication doesn't work.
I had the impression it was locally as it was picking up my ADC credentials.
API key authentication with vertexai installed through google-cloud-aiplatform doesn't work as an exception is raised saying it's not supported.
google-generativeai doesn't work either when using an API key, I get this error locally: User location is not supported for the API use.
I tried running google-generativeai in a Colab but for some reason imports that work locally don't work in Colab.
ADC is annoying to use but works, closing this. 👋


Adds plane-takeoff & plane-landing icons

Closes #781

Looks like a plane but feels out of of place somehow, maybe its just the sharpness of the cornenrs :thinking:


Possible issue with python3 using virtualenvs and Docker?

I'm trying to use Mitogen within a Docker virtual environment. Docker container is Ubuntu 18. This issue does not seem to occur using python2.7 on an Ubuntu 18 virtual machine.
Dockerfile:
RUN virtualenv /ansible27
RUN . /ansible27/bin/activate; python3 -m pip install ansible==2.7.6 mitogen
ENV ANSIBLE_STRATEGY=mitogen_linear

Within the container:
root@e35c798bf514:/# . /ansible27/bin/activate
(ansible27) root@e35c798bf514:/# pip3 list | egrep 'mitogen|ansible'
ansible          2.7.6
mitogen          0.2.6

(ansible27) root@e35c798bf514:/#  ansible-config dump --only-changed
ANSIBLE_NOCOWS(/etc/ansible/ansible.cfg) = True
ANSIBLE_PIPELINING(/etc/ansible/ansible.cfg) = False
ANSIBLE_SSH_ARGS(/etc/ansible/ansible.cfg) = -o ControlMaster=yes -o ControlPersist=yes -F /root/.ssh/config
ANSIBLE_SSH_CONTROL_PATH(/etc/ansible/ansible.cfg) = ~/.ssh/master-%%r@%%h:%%p
DEFAULT_FORKS(/etc/ansible/ansible.cfg) = 9
DEFAULT_SCP_IF_SSH(/etc/ansible/ansible.cfg) = True
DEFAULT_STRATEGY(env: ANSIBLE_STRATEGY) = mitogen_linear
DEFAULT_TRANSPORT(/etc/ansible/ansible.cfg) = ssh
HOST_KEY_CHECKING(/etc/ansible/ansible.cfg) = False
RETRY_FILES_ENABLED(/etc/ansible/ansible.cfg) = False

(ansible27) root@e35c798bf514:/# ansible localhost -m setup -vvv
ansible 2.7.6
config file = /etc/ansible/ansible.cfg
configured module search path = ['/root/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
ansible python module location = /ansible27/lib/python3.6/site-packages/ansible
executable location = /ansible27/bin/ansible
python version = 3.6.7 (default, Oct 22 2018, 11:32:17) [GCC 8.2.0]
Using /etc/ansible/ansible.cfg as config file
/etc/ansible/hosts did not meet host_list requirements, check plugin documentation if this is unexpected
Skipping due to inventory source not existing or not being readable by the current user
/etc/ansible/hosts did not meet script requirements, check plugin documentation if this is unexpected
Skipping due to inventory source not existing or not being readable by the current user
/etc/ansible/hosts did not meet yaml requirements, check plugin documentation if this is unexpected
Skipping due to inventory source not existing or not being readable by the current user
/etc/ansible/hosts did not meet ini requirements, check plugin documentation if this is unexpected
/etc/ansible/hosts did not meet auto requirements, check plugin documentation if this is unexpected
[WARNING]: Unable to parse /etc/ansible/hosts as an inventory source

[WARNING]: No inventory was parsed, only implicit localhost is available

[WARNING]: provided hosts list is empty, only localhost is available. Note that the implicit localhost does not match 'all'

ERROR! Invalid play strategy specified: mitogen_linear

I'm not sure whether this is bug related, but going by step 3 https://mitogen.readthedocs.io/en/latest/ansible.html#installation it would appear that this is possible.
Using a normal environment with python2.7 (not Docker) this is working fine so just wanted to see whether this output is expected, and whether I'm incorrect somewhere.
Thanks in advance for any advice/pointers!

So.. looks like i was being a bit silly!
``` was required within the Dockerfile. Would it be useful for the docs linked above be updated with the fact that `ANSIBLE_STRATEGY_PLUGINS` needs to be called also?

Thanks!!

I tried adding this and I don't like the result -- it pushes BS config choices on the user, I'd rather remove BS choices :)
The real answer to this is likely to be Ansible Collections when it is ready. It should allow use of a well-known command for activating the plugin
Thanks again for reporting


Add dynamic module support

Hello,
Is it possible to add dynamic module support for nginx-dav-ext? The module is part of nginx-full in debian/ubuntu and we are in the process of splitting the modules in separate packages.
Thank you,

Any update on that?

Arut,
Is there any chance you plan to add dynamic module support to this module?
This is a module that Debian has included in with our most commonly installed version (flavour) of nginx. We are in the process of migrating 3rd party to independent packages that can be collectively maintained, but this would require changes to this source code.
We'd prefer not remove this module for anyone that have may have come to rely on it, but we also need to continue splitting up modules into more maintainable packages. If you intend to work on this, could we please get some comment?

Hey guys #22


Missing asm.js annotations

I've been benchmarking hashing algos and I noticed that your implementation is missing a few asm.js annotations to appease the JS engines, details here: https://github.com/cristianbote/goober/pull/588#issuecomment-2309600140

Hello. Sorry for the delayed response!
I've looked at your benchmark code, and haven't found any significant differences without that it uses an Int32Array of a pre-allocated buffer instead of DataView and getUint32. This change seems difficult to apply to this library, which accepts Uint8Array. It seems like a good idea to add a function that accepts text as input.
Could you explain in more detail what other parts need to be changed?

Here are the results for modified benchmark (on an M1 Macbook Air):
### node: v22.6.0 ###
CASE: murmur2_unmodified: ##################................................   37.57% (426 ops) (2.347 ms/op)
CASE: murmur2:            ############################......................   56.53% (641 ops) (1.562 ms/op)
CASE: murmur2_dataview:   ############################......................   57.94% (657 ops) (1.524 ms/op)
CASE: xxh:                ##########################################........   84.04% (953 ops) (1.049 ms/op)
CASE: xxh_dataview:       ##################################################  100.00% (1,134 ops) (0.8818 ms/op)
CASE: fnv-1a:             ###################...............................   38.80% (440 ops) (2.275 ms/op)
CASE: djb2a:              #######################...........................   46.74% (530 ops) (1.887 ms/op)
CASE: goober:             #####################.............................   42.42% (481 ops) (2.081 ms/op)

Good to know, I'll close the issue then. The few modifications that exist in the benchmark repo might explain why the annotations make a difference there (the V8 disassembly was clear that they were needed though).
Thanks for sharing about the DataView, I'm in the process of implementing a light replacement for EmotionCSS at MUI, and I'll probably be picking your implementation of xxh for the hashing (unless I can find a way to avoid, hashing in JS is painful).


Possible Bug in ECCV18 split code for Sketchy Extended

Hi there,
Kindly correct me if I am wrong about this code segment here in utils.py
if split_eccv_2018:
        # According to Yelamarthi et al., "A Zero-Shot Framework for Sketch Based Image Retrieval", ECCV 2018.
        cur_path = os.path.abspath(os.path.join(os.path.dirname(__file__), ".."))
        with open(os.path.join(cur_path, "test_classes_eccv_2018.txt")) as fp:
            te_classes = fp.read().splitlines()
            va_classes = te_classes
            tr_classes = np.setdiff1d(classes, np.union1d(te_classes, va_classes))

Here, you are setting validation classes to be the same as the test classes. So, is it still zero-shot since you are now seeing the test classes during train (validation on them that is)? As I understand, validation classes are supposed to be the same as the train classes (seen classes that is) with sketch and images of the 104 seen classes being divided in a certain ratio between train and val. Also, this results in the validation and test sets being exactly the same since you are filtering sketch and images files based only on classes in get_coarse_grained_samples function.  I also have run the code, and this is indeed the case. Would like to know your thoughts on this.

This is also same as the previous issue. We don't have validation set. This is how I implemented things...

Hi, sir. Could you please share the link to download the Sketchy Extended dataset and TU-Berlin Image dataset?


Make RegistryConfig a typed value in the api.

Remove possible circular dependency that prevented us from using a real
type.
Signed-off-by: David Calavera<EMAIL_ADDRESS>

LGTM

LGTM


DM Entry Controller

Description
Closes #117

Creates a controller to handle specific behaviour of DM entries which do not belong to a character.
Upon /entry.store , if type is 'dm' the response will be a redirect to the index of DMEntryController.
A new view may be needed to be added in the future in case we wish to differentiate listing characterless DM entries from a list of entries on a character.
Also fixes an issue in web.php routes where some routes did not have middleware.

I'm also struggling to see where we can add tests to meet the diff coverage threshold set by CodeClimate. The ones you have seem to cover the index you added.

I realised that theres nothing fundamentally different about creating a DM entry vs a regular entry, so the actual creation can be handled by the EntryController store function, whereas the index might be slightly different as you're specifically only getting entries with type 'dm', so I chose to have a redirect case wthin entry.store which redirects to dm-entry.index if the store request was for a dm-entry.
This way, we only need one form for creating entries, which can be either attached to a player or a free floating DM entry.

I have some ideas where test coverage can be added.


log4net FileName may be null

This fixes the root cause null of this exception. You may wish to revisit exception handling for this to produce better errors. If label values can't be null, perhaps this is a better way to safeguard this.

Got this bug when trying to get started following the readme. It looks like it applies only with withLocation is enabled.
It can simply be commented out to avoid that bug:
<?xml version="1.0" encoding="utf-8" ?>
<log4net>
  <appender name="ConsoleAppender" type="log4net.Appender.ConsoleAppender" >
    <layout type="log4net.Layout.PatternLayout">
      <conversionPattern value="%-4timestamp [%thread] %-5level %logger %ndc - %message" />
    </layout>
  </appender>
  <appender name="CloudLogger" type="Google.Logging.Log4Net.GoogleStackdriverAppender,Google.Logging.Log4Net">
    <layout type="log4net.Layout.PatternLayout">
      <conversionPattern value="%-4timestamp [%thread] %-5level %logger %ndc - %message" />
    </layout>
    <projectId value="tachyusatmion" />
    <logId value="myLog" />
    <!--<withMetaData value="Location" />-->
    <withMetaData value="ThreadName" />
  </appender>
  <root>
    <level value="DEBUG" />
    <appender-ref ref="ConsoleAppender" />
    <appender-ref ref="CloudLogger" />
  </root>
</log4net>

Thanks for bringing this to our attention, and for the fix.


[Barreleye/Palmetto] Verify System VPD Properties mismatch with the model setup

Looks like we need to change the test logic to do verification of the inventory field as per
https://github.com/openbmc/ipmi-fru-parser/blob/master/frup.c#L169
Reference : https://github.com/openbmc/openbmc/issues/532

Need to check on Witherspoon

Closing as the new interface are going to replace and the old skeleton model is going to go away


Stuck txn without error msg.

Describe the bug
A transaction made an hour and a half ago from Gnosis to BNB Chain sending DAI that should have gone through the fast path because there is sufficient liquidity, is still processing and the UI does not give the option to Bump the transaction.
https://connextscan.io/tx/0x63c704ae3cdfd95b9d77bca0ecca919f588c18dd422628252413ce3a444b9c6f
Additional context
Another one stuck tx with the same potential problem:
Similar time, to the same chain.
https://connextscan.io/tx/0xeb5215c8b72a8f4cad7e8518e095cf622e6f172119df2e135aa43fc53c78cdc6

Executed!


get tests from Ryan and port them into R so they can check data locally

Did this -- the code from Ryan is python from Talus, have translated it into the testthat framework


HWKAPM-766 Fix issue with ruby zipkin data when server span doesn't h…

…ave URL, but client span does

@pavolloffay Could you review please?
I've tested it against zipkin polyglot example and it now displays the roda service correctly.

@pavolloffay Timestamp and durations removed. Let me know when ok and I'll rebase before merge.

@pavolloffay Thanks!

retest this please

Merging as build failures seem unrelated. Travis is having trouble finding the jdk, and jenkins is having iptable trouble when trying to run the instrumentation tests. :(


enable custom HTTP client

The class documentation in the HTTPClient states that is possible to override the get and post methods. As they are static this is not possible.
I propose a refactoring making HTTPClient an interface without static methods and then making it possible to inject the client in the services.

Don't know if this is still a demand for that, but I made a compromise towards being able to set a global custom HttpClient for use in the services. If you want to implement your own HttpClient, implement HttpClientInterface and set it with HttpClient.setCustomHttpClient(...).


CI failing

test-py-epidata fails because thecoverage module can't find our epidata package  with the given path.
/opt/hostedtoolcache/Python/3.8.16/x64/lib/python3.8/site-packages/coverage/inorout.py:507: CoverageWarning: Module /opt/hostedtoolcache/Python/3.8.15/x64/lib/python3.8/site-packages/memilio/epidata was never imported. (module-not-imported)   self.warn(f"Module {pkg} was never imported.", slug="module-not-imported") /opt/hostedtoolcache/Python/3.8.16/x64/lib/python3.8/site-packages/coverage/control.py:838: CoverageWarning: No data was collected. (no-data-collected)   self._warn("No data was collected.", slug="no-data-collected") No data to report.

It would be good if the path is not python version specific, so it doesn't have to be corrected whenever the used version changes.

Please make it a new issue @patricklnz


Each gantt Task as a time picker

This is feature request.
I want to abuse  each 'gantt Task' as the time picker.
Add  the extra data-link which set the start and end time of the  'gantt Task' to dashboard time-range!

Data link URL is absolute(As far as I know), Therefore

It is not portable(dashboard export and import)
Invoke full reload

Hope to use locationsrv.
https://grafana.com/docs/grafana/latest/packages_api/runtime/locationsrv/
  getLocationSrv().update({
    query: {
      from: From_value,
      to: To_lue,
    },
    partial: true,
    replace: true
  })


[Wave Collect] [Xero] Remove text jitter for More Features modal

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/42903
$ https://github.com/Expensify/App/issues/42644
PROPOSAL:
Tests

Open the app
Open any workspace with an existing accounting integration - say, Xero or QBO..
Click on More Features.
Go to Organize section and try clicking on any of the switches.
Verify that you see a modal with the following content & click on "Cancel"
Verify that the prompt text (description) doesn't disappear while the modal closes, and the dimension of the modal doesn't change.

[ ] Verify that no errors appear in the JS console

Offline tests

Same as Test Steps
QA Steps

Same as Test Steps

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Is there any one who will review this or shall I go ahead?

@c3024 This will be reviewed by @hungvu193 or @rushatgabhane.  Thanks for checking.
I am still left with adding screencasts for all platforms. No electricity. Will update when it comes back.

@mananjadhav nothing urgent, could you please briefly explain the changes. Why and what we're doing 😁

@rushatgabhane I've updated the Details section and also uploaded all the screencasts.

@rushatgabhane @hungvu193 Can one of you help with the review here?

It's being late here. I can do a quick review in my morning if Rushat isn't available

Tomorrow is fine, either one of you can do it. Thank you 🙏

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

https://github.com/Expensify/App/assets/16502320/eaea567a-436a-42e0-be75-7ab5546bc3d5

iOS: mWeb Safari

https://github.com/Expensify/App/assets/16502320/cdca6930-7e47-459c-ba42-e83735da49b3

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/16502320/0e685f11-6ede-432d-bf31-f46c61322138

MacOS: Desktop

https://github.com/Expensify/App/assets/16502320/518a3782-a72e-4785-8e58-964120d42feb

@lakchote This will be ready for your final review

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.79-11 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


[ISSUE] FlutterDevices Slow to Open

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
When you run :FlutterDevices it takes multiple seconds to open the popup window with all devices
Expected Behavior
The window opens immediately
Steps To Reproduce
Run :FlutterDevices
Environment
- OS: Mac 14.2.1 (23C71)
- Flutter version: 3.16.9
- Is flutter in $PATH: Yes
- neovim version: 0.9.5

Anything else?
I would imagine that this is taking so long as it's querying devices every time the command is run. A potential alternative solution would be to only fetch devices when the dialog is first opened and then cache them. Then, on subsequent opens, show the cache as well as another cell that says "Refresh" that would fetch all devices again.

experience the same behavior


[Feature] Restart worker pod when raylet exited

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description
For now, ray-operator generate worker pod command
ulimit -n 65536; ray start  --node-ip-address=$MY_POD_IP  --redis-password=LetMeInRay  --address=raycluster-heterogeneous-head-svc:6379  && sleep infinity

If the raylet in worker pod exited, the raylet don't restart, so the pod will be useless without raylet.
Use case
If the raylet in worker pod exited, the raylet should restart.
One option is starting ray with --block and delete the sleep infinity.
Another option is restarting the pod, so the raylet will start. Maybe we can add some default liveness probe.
Related issues
No response
Are you willing to submit a PR?

[X] Yes I am willing to submit a PR!

Agree. this should be improved to handle failures


[PE-D][Tester E] Unable to delete date of wedding

After adding a date for a wedding, there is no function to remove the date (for eg if the date changes and becomes undecided). Would it better to include a function to allow deletion of date or allow blanks like role assignment to remove it?

Labels: severity.Medium type.FeatureFlaw
original: sarahteonin/ped#9

Add in UG that cannot delete venue and date, only can edit.


does not work as expected with AWS - SignatureDoesNotMatch

If we have such uploader:
class FileUploader < CarrierWave::Uploader::Base
  include CarrierWaveDirect::Uploader
end

AWS responds with:
<?xml version="1.0" encoding="UTF-8"?>
<Error>SignatureDoesNotMatch<Message>The request signature we calculated does not match the signature you provided. Check your key and signing method.</Message><AWSAccessKeyId>AKIAJ3XAFXRG7WWCP36Q</AWSAccessKeyId><StringToSign>...</StringToSignBytes><RequestId>89A2E7E7BD6135A9</RequestId><HostId>ClcOGqdr9Xx+r7lgzlmmCYsFKiMVu0G/kJhFan2+c4va+1zbx27EcGsbEztPg6qrO2EWBzYDJHQ=</HostId></Error>

Reverting back (from v.0.0.15) in Uploader module to this implementation:
def signature
      Base64.encode64(
        OpenSSL::HMAC.digest(
          OpenSSL::Digest.new('sha1'),
          aws_secret_access_key, policy
        )
      ).gsub("\n","")
    end

solves the issue


Missed section header if enumerate.

In
Documenting C/C++ Code
======================

NumPy uses Doxygen to parse specially-formatted C/C++ comment blocks. This generates
XML files, which are  converted by Breathe into RST, which is used by Sphinx.

1. Writing the comment blocks
-----------------------------

Although there is still no commenting style set to follow, the Javadoc
is more preferable than the others due to the similarities with the current
existing non-indexed comment blocks.

The section title is seen as a enumerated list instead of a title.
I could try to send a PR upstream that remove the ., but I think it would be great if it could be fixed somehow.

I think this is the same case as https://github.com/stsewd/tree-sitter-rst/issues/30


tests.cloud_to_cloud:node:node_server:unimplemented_method

https://grpc-testing.appspot.com/job/gRPC_interop_pull_requests/10012/testReport/junit/(root)/tests/cloud_to_cloud_node_node_server_unimplemented_method/
assert.js:90
throw new assert.AssertionError({
^
AssertionError: 14 === 12
at Object.callback (/var/local/git/grpc/src/node/interop/interop_client.js:391:12)
at /var/local/git/grpc/src/node/src/client.js:421:14

It seems we haven't seen this in a while. Closing.


What is -Desks Variable

There's no data under the -Desks variable. It just says 'fill content here' like the article was never finished.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 7af332a3-efc1-49aa-24c2-64b5031a2420
Version Independent ID: f47bc209-aa9e-f337-1cfa-b8a727a9f780
Content: Set-Place (ExchangePowerShell)
Content Source: exchange/exchange-ps/exchange/Set-Place.md
Service: exchange-powershell
GitHub Login: @chrisda
Microsoft Alias: chrisda

@pyoungberg, empty parameter descriptions are a known commodity. Availability vs. functionality are two different things. You can read more about it here.
Are you being directed to use that parameter in other content?

@pyoungberg Hope this comment is helpful for you. If you see a documentation update is required, please feel free to open an issue for the same. We proceed here to close it. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


Missing key in mlora.json when training and evaluating multi-task

After executing python ./launch.py gen --template mixlora --tasks "arc-c;arc-e;boolq;obqa;piqa" --multi_task True --adapter_name mixlora to generate mlora.json, I tried python ./launch.py run --base_model <Path to Your Base Model> for training and evaluating on multi-task setting.
Then I got the following error message:
Traceback (most recent call last):
  File ".../mlora/mlora.py", line 268, in <module>
    mlora.train(mlora.Dispatcher(config, tokenizer), model,
  File ".../mlora/mlora/dispatcher.py", line 201, in __init__
    dataload_function=lora["dataloader"],
KeyError: 'dataloader'

I checked the code in dispatcher.py, the dataloader should be a Callable object. How can I fix this error?
Thanks.

Which version of m-LoRA you are using with?

Which version of m-LoRA you are using with?

0.3.2, same as the README mentioned.

All our experiments were conducted under version 0.3.2. Based on your description, I cannot reproduce this problem. There may be some problems with your Git repository. You can try using the latest version. If the problem persists, you can add me on WeChat (ID: mikecovlee) to discuss in detail.

Closing issue because no further response.


Improve data loaded by using Truth Set

In this issue, add an environment variable, say SENZING_G2CONFIG_DATA, that init-container.py puts into /etc/opt/senzing/G2Config.gtc (as a default location)
See https://github.com/Senzing/aws-cloudformation-ecs-poc-simple/issues/46

Pull requests:

https://github.com/Senzing/docker-init-container/pull/108


Added videos mentioned in issue #264 to the talks page with start and end comment tags accordingly

Added the videos to talks page !

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi Shirpad,
If you don't mind, can you please sign the CLA? That needs to be done before we can take next steps. Thank you and I appreciate your contribution.
Shilla

Hi Shirpad,
If you don't mind, can you please sign the CLA? That needs to be done before we can take next steps. Thank you and I appreciate your contribution.
Shilla

Hello,
I have signed the CLA. please check.


error in file "firmata_mraa.c"

error in file "firmata_mraa.c:
// if this isn't working then we have an issue with our uart
    int retry = 20;
    while (!firmata_dev->isReady && retry--) {
       firmata_pull(firmata_dev);
    }

if (!retry) {

but "retry" = -1.
must be like this, then the value of "retry" is = 0
// if this isn't working then we have an issue with our uart
    int retry = 20;
    while (!firmata_dev->isReady && --retry) {
       firmata_pull(firmata_dev);
    }

Nice catch, thanks! Fixed.