feat: modify ACL of advanced settings when switching feature flag.

Description

Issues Resolved

Screenshot

Testing the changes

Check List

[ ] All tests pass

[ ] yarn test:jest
[ ] yarn test:jest_integration
[ ] yarn test:ftr

[ ] New functionality includes testing.
[ ] New functionality has been documented.
[ ] Update CHANGELOG.md
[x] Commits are signed per the DCO using --signoff

Codecov Report

Merging #110 (f8b1661) into workspace (e2f277c) will decrease coverage by 31.00%.
The diff coverage is n/a.

:exclamation: Current head f8b1661 differs from pull request most recent head 9ad9572. Consider uploading reports for the commit 9ad9572 to get more accurate results

@@              Coverage Diff               @@
##           workspace     #110       +/-   ##
==============================================
- Coverage      65.77%   34.77%   -31.00%
==============================================
  Files           3336     1921     -1415
  Lines          64493    38143    -26350
  Branches       10264     5460     -4804
==============================================
- Hits           42418    13263    -29155
- Misses         19502    24274     +4772
+ Partials        2573      606     -1967

Flag
Coverage Δ

Linux_1
?

Linux_3
?

Windows_1
34.77% <ø> (ø)

Windows_2
?

Windows_3
?

Windows_4
?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 2151 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


update requirements.txt

Fixes #100 .
Was facing these issues when pulled from the main, hence updated.
Just a small note: for mac users the following issue will pop up:
ImportError: MagickWand shared library not found.

Solution:
brew install imagemagick@6
export MAGICK_HOME=/opt/homebrew/opt/imagemagick@6

Can you please add this debugging information somewhere? I recommend creating a debugging.md and referencing it in the docs.


One Dark Pro theme changed with vscode version update

VSCode Version: 1.49.0
OS Version: Manjaro Linux

New update vscode to 1.49 brings an interesting thing:
I have been using One Dark Pro theme with Python for ~1.5 year, and now it looks very different than yesterday on version 1.48 with same list of extensions.
One more interesting thing that it changes on toggling PyLance extension.
Steps to Reproduce:

Open vscode v1.49, install extensions: Python, PyLance, One Dark Pro. Reload window.
Open python code (with python 3.6.9). Now you see new colors.

Example

Turn PyLance off. Reload window. Now you see old colors.

Example

Other themes don't have this this behavior

Does this issue occur when all extensions are disabled?: No

Oh, now i see, it changes back with setting
"editor.semanticHighlighting.enabled": false


Legend

Hi,
it's possible to have legend in left like this :

@nseb the legend can be located into top, bottom, right and left. But it's not part of axes, as you drawed

My result :-(, I create in issue enhancement in chart.js ?

@nseb yes you can. Seeing your first sample, why don't to have something like that ?

@nseb What do you think? Close to what you are looking for?
Bone by Charba with a TickCallback and a puglin.

exactly, did you develop an extension?
Look what I did, tab stats, thanks for watching on a tablet or mobile, because verson pc I did not work the style:
https://www.ukart.io/#!/race/183/run/2318

Not really an extension. I'm adding the capabilitty to get all information from CHART JS instance (for instance the size of boxes, like legends, axis and so on). With this data and using a plugins, I can draw into canvas whatever and wherever I want.
I'm gonna have a look. We are developing something similar (as dashboard) on GWT MAterial but we didn't have those behaviours

therefore, it makes a lot of code to do this dashbard if you redraw everything, right?

well, if you redraw everything, you could have effort to do it. What are you using as base components for your dashboard? MaterialMasonry?

MaterialMasonry -> MaterialColumn->MaterialCard (with chart in MaterialCardImage).

@stockiNail  , you can share your code example to realize if that will not make my app heavier?

@nseb sorry but that application  is not open source and I can not.

@stockiNail  , no problems I understand

@nseb here are the instructions to have the chart as  above described.
Set padding on top and right to be able to have space to write the "values" on right part of chart and disable the legend.
chart.getOptions().getLegend().setDisplay(false);
chart.getOptions().getLayout().getPadding().setTop(40);
chart.getOptions().getLayout().getPadding().setRight(40);

The values to put on AXIS, you could set the label of each datasets with the tick to put into axis.
dataset.setLabel(TICKS[i]);

Then you can create an axis setting the "reverse"to true and adding a tickcallback in order to put the dataset labels as ticks of axis:
CartesianLinearAxis axis2 = new CartesianLinearAxis(chart);
axis2.setDisplay(true);
axis2.getTicks().setReverse(true);

axis2.getTicks().setCallback(new TickCallback() {

	@Override
	public String onCallback(AbstractChart<?, ?> chart, TickItem item) {
		List<Dataset> dss = chart.getData().getDatasets();
		Dataset ds = dss.get(item.getIndex());
		return ds.getLabel();
	}
});

Then we could add a specific plugin which will add to the canvas the label on right about standing. This plugin is leveraging on new features of Charba to get the info from CHART.JS chart instance about sizing, dimensions and other values.
AbstractPlugin p = new AbstractPlugin() {

	@Override
	public String getId() {
		return "standings";
	}

	/* (non-Javadoc)
	 * @see org.pepstock.charba.client.plugins.AbstractPlugin#onAfterDatasetsDraw(org.pepstock.charba.client.AbstractChart, double)
	 */
	@Override
	public void onAfterDatasetsDraw(AbstractChart<?, ?> chart, double easing, JavaScriptObject options) {
		final int padding = 30;
		final int datasetsCount = chart.getData().getDatasets().size();
		Context2d ctx = chart.getCanvas().getContext2d();

		ScaleItem scaleX = chart.getChartNode().getScales().getItems().get(ScalesNode.DEFAULT_X_AXIS_ID);
		ScaleItem scaleY = chart.getChartNode().getScales().getItems().get(ScalesNode.DEFAULT_Y_AXIS_ID);

		int heightAmongLabels = (scaleY.getBottom() - scaleY.getTop()) / (datasetsCount-1);

		int x = scaleX.getRight() + padding;
		int y = scaleY.getTop();
		for (int i=0; i<datasetsCount; i++) {
			int index = i + 1;
			ctx.setFillStyle("rgb(0, 0, 0)");
			ctx.setFont("22px bold Helvetica Neue");
			ctx.setTextAlign(TextAlign.CENTER);
			ctx.setTextBaseline(TextBaseline.MIDDLE);
			ctx.fillText(String.valueOf(index), x, y);
			y = y + heightAmongLabels;
		}
	}
};
try {
	chart.getPlugins().add(p);
} catch (InvalidPluginIdException e) {
	// exception
}

Here is a temporary version of Charba 1.5.
charba-1.5.zip


Fix issue #365. ELPP_DISABLE_LOGS not working in VS

For some reason the previous definition of ELPP_LOGGING_ENABLED did not resolve to a numeric value which meant that it was always true when used.

Nothing should ever go to master. If you change the branch to develop i will merge it. Thanks for this :)

Done


Read configs with marshmallow

Now marshmallow can be used to generate JSON schemas. Though description fields would play nicely so should probably add them.


Use standard menu item for search icon in Toolbar

I understand that you made it such that clicking anywhere on the right half of the toolbar opens the search dialog, but it feels very odd and inconsistent with the rest of the Android platform. By using a standard menu item with the Toolbar, the search toggle code becomes simpler, and has better UX (IMO) i.e. ripple icon on search icon press, no weird behaviour where not pressing the search icon can open the search view.
I'm able to work on this, but would like some assurance that this would be an accepted change.

Sure, it's a thing i've planned to do in the future.


CIV-7170 Renovate Automerge

JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/CIV-7170
Change description
Renovate auto merge enabled
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[x] No

No need to update the branch to the very latest on this one. Also, today PRs on civil-service are going to fail regardless for unrelated reasons.
I'll be overriding the requirement to update the branch to the latest and merge this, as it's not going to cause build issues.


absent zygomaticus muscle

absent zygomaticus muscle
DEF: absence of the zygomaticus major and/or minor facial muscles that originate from the body of the zygoma and pass downwards to insert into the corner of the mouth and lateral aspect of the upper lip, respectively
Annotation J:41540
review placement of terms under absent facial muscle

absent zygomaticus muscle MP:0030207


chore: bdd-ghfjxy-import-1582334211 to 0.0.1

chore: Promote bdd-ghfjxy-import-1582334211 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Error when compiling from source

When compiling from source with catkin_make, I was running into this issue:
Vocabulary.cpp:249:109: error: no matching function for call to ‘cv::flann::Index::build(cv::Mat&, cv::flann::LinearIndexParams, cvflann::flann_distance_t)’
Looking at that particular line in Vocabulary.cpp indicated that it was looking for a specific version of opencv. The one hardcoded in is 2.4.12 (https://github.com/introlab/find-object/blob/kinetic-devel/src/Vocabulary.cpp#L246) and I had 2.4.13. I fixed it by replacing the 12 with 13 and the issue went away.
Just highlighting this since no specific version of Opencv was required for this package.

This is already fixed in master branch: https://github.com/introlab/find-object/blob/master/src/Vocabulary.cpp#L246


Exception raised using MISP feature

Dear,
After pulling the latest version, I'm not able to run properly the MISP module:
cd /opt/munin/
sudo git pull
sudo vi /opt/munin/munin.ini (to add/change my own API keys)
sudo python3 -m pip install -r /opt/munin/requirements.txt
sudo python3 /opt/munin/munin.py --debug -i /opt/munin/munin.ini -f <input>
However, I reached the following exception:

[D] Querying MISP: 'https://misppriv.circl.lu'
Traceback (most recent call last):
File "/usr/local/lib/python3.6/dist-packages/pymisp/api.py", line 98, in init
response = self.get_recommended_api_version()
File "/usr/local/lib/python3.6/dist-packages/pymisp/api.py", line 1340, in get_recommended_api_version
response = self._prepare_request('GET', url)
File "/usr/local/lib/python3.6/dist-packages/pymisp/api.py", line 177, in _prepare_request
return s.send(prepped, verify=self.ssl, proxies=self.proxies, cert=self.cert)
File "/usr/lib/python3/dist-packages/requests/sessions.py", line 612, in send
adapter = self.get_adapter(url=request.url)
File "/usr/lib/python3/dist-packages/requests/sessions.py", line 703, in get_adapter
raise InvalidSchema("No connection adapters were found for '%s'" % url)
requests.exceptions.InvalidSchema: No connection adapters were found for ''https:/servers/getPyMISPVersion.json'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
File "/opt/munin/munin.py", line 503, in getMISPInfo
misp = PyMISP(MISP_URL, MISP_API_KEY, args.verifycert, 'json')
File "/usr/local/lib/python3.6/dist-packages/pymisp/api.py", line 112, in init
raise PyMISPError('Unable to connect to MISP ({}). Please make sure the API key and the URL are correct (http/https is required): {}'.format(self.root_url, e))
pymisp.exceptions.PyMISPError: Unable to connect to MISP ('https://misppriv.circl.lu'). Please make sure the API key and the URL are correct (http/https is required): No connection adapters were found for ''https:/servers/getPyMISPVersion.json'

I double checked the API key and it is good.
Any idea?
Thanks in advance,
Regards,
Julien

It seems like a connection error.
What is the output of
curl -o /dev/null --silent --head --write-out '%{http_code}\n' https://misppriv.circl.lu

Thanks Florian,
Below the command line output:
curl -o /dev/null --silent --head --write-out '%{http_code}\n' https://misppriv.circl.lu
302
I use a proxy but it is specified in my environment "$http_proxy" and "$https_proxy" and it allows connection to this subdomain.
The same with VT:
curl -o /dev/null --silent --head --write-out '%{http_code}\n' https://www.virustotal.com
200
So it is a proxy issue... strange!
Regards

PyMISP requires a manual proxy definition.
https://github.com/CIRCL/PyMISP/blob/644e1b065afd6f87f480a4bafa45ec908882cab7/pymisp/api.py#L65
I don't have that yet in my program.

I would keep this open as a missing feature in munin


Could not find a declaration file for module '@fower/react-native'

First of all, thank you for this great package :)
When trying to use the @fower/react-native package, i get an declaration missing error with the @fower/react-native types :

In the package.json of the pusblished package, i notice the typings is pointing on an missing file...

The typing types/index.d.ts is missing (seems to be ignored on publish), or located in the wrong folder dist/
Thank you for your help.

@sgaloux Thank for  bug feedback, I fixed it in latest version v1.3.0, please check it~


Unable to use a template literal type as a record() key value

I have tried to use the template literal type for a key of the record schema like this:
type Key = `${string}-${number}`;
const KeySchema = special<Key>((key:string) => {
  const parts = key.split("-");
  const num = parts.unshift();
  if (Number.isNaN(Number(num))) return false;
  const str = parts.join('-');
  if (typeof str !== "string") return false;
  return true;
});

const FooSchema = record(KeySchema, string());

But the type error happened at the last line:
No overload matches this call.
  The last overload gave the following error.
    Argument of type 'SpecialSchema<`${string}-${number}`, `${string}-${number}`>' is not assignable to parameter of type 'RecordKey'.
      Type 'SpecialSchema<`${string}-${number}`, `${string}-${number}`>' is not assignable to type 'StringSchema<string | number | symbol>'.
        Type 'SpecialSchema<`${string}-${number}`, `${string}-${number}`>' is not assignable to type '{ type: "string"; message: ErrorMessage; pipe: Pipe<string>; }'.
          Types of property 'type' are incompatible.
            Type '"special"' is not assignable to type '"string"'.

Here is the playground that tests this.
https://stackblitz.com/edit/typescript-c4dusa?file=index.ts
Is there proper a way to do this?

custom is a pipeline validation an not a schema. special is probably the correct schema for this use case but at the moment it is not supported with record. I will investigate if it is possible to support special. Until then, I recommend using string:
import * as v from 'valibot';

const KeySchema = v.string([
  v.custom((key) => {
    const parts = key.split('-');
    const num = parts.unshift();
    if (Number.isNaN(Number(num))) return false;
    const str = parts.join('-');
    if (typeof str !== 'string') return false;
    return true;
  }),
]);

const FooSchema = v.record(KeySchema, v.string());

@fabian-hiller Sorry I have mistakenly post an old example.
Now I have corrected it.

As I wrote special is the right schema for this, but currently not supported by record. It it is possible I will fix this with the next minor version.
import * as v from 'valibot';

type Key = `${string}-${number}`;
const KeySchema = v.special<Key>((key) => {
  if (typeof key !== 'string') return false;
  const parts = key.split('-');
  const num = parts.unshift();
  if (Number.isNaN(Number(num))) return false;
  const str = parts.join('-');
  if (typeof str !== 'string') return false;
  return true;
});

const FooSchema = v.record(KeySchema, v.string());

@fabian-hiller
Thanks! I understand :)
Is it good to remain open this issue until the solution would come?

Yes, please leave it open. I will probably work on it later or tomorrow.

Fixed. As soon as v.24.0 is available, I will close this issue. Thank you for your contribution!

@fabian-hiller
Thanks! I have confirmed the latest code solves this issue.

v0.24.0 is available.


Set default interview and document that feature

Following:

#19

I think it should push every 10s by default if it hasn't had a full batch yet. Should be documented.

Documentation should go on this page: https://dclient.datasette.io/en/latest/inserting.html

Since JSON cannot be streamed but newline-delimited JSON can, I could document how to use jq to turn JSON into newline-delimited JSON. But I can't figure out how to do that, the closest I got was:
stream.py:
import json
import time

i = 0
print('[', flush=True)
while True:
    i += 1
    print(
        json.dumps({"id": i, "name": "abc Name of again again {}".format(i)}) + ',',
        flush=True,
    )
    time.sleep(0.5)

Then:
python stream.py | jq -c --stream 'fromstream(1|truncate_stream(inputs))'

But that output:
{"name":"abc Name of again again 1"}
{"id":2,"name":"abc Name of again again 2"}
{"id":3,"name":"abc Name of again again 3"}
{"id":4,"name":"abc Name of again again 4"}

The first id is missing and I can't figure out why.

I think it's missing because I'm outputting [ on a single line at the start and fromstream is processing a line at a time, perhaps?
But this suggests it's not:
python stream.py | jq --stream -c

Output:
[[0,"id"],1]
[[0,"name"],"abc Name of again again 1"]
[[0,"name"]]
[[1,"id"],2]
[[1,"name"],"abc Name of again again 2"]
[[1,"name"]]
[[2,"id"],3]
[[2,"name"],"abc Name of again again 3"]
[[2,"name"]]
[[3,"id"],4]


Switch on Interactive Report??

Can be a field on a interective report be a Switch?
I have values stored like 1 - 0 so need to be displayed like a display only switch.
😄

Good question. You can't because the Switch item is a plugin and we can't attach plugins to Interactive Report.
However, I think you can use it inside an Interactive Grid, just select the unsupported column types:

Let me know how it goes.

changed for icon check on a html expression field.... that works...
Thanks for your time!


Multi-Threading

When many people speak at the same time, the sound is stretched.
Would multi-threading solve the problem?

No threads required! I don't think think Godot even allows multiple threads to play sound.
I think this problem is solved by giving each participant a seperate voip instance. This way (hopefully) they'll use their seperate audio buffers.

I have 3 instances (on diffrent pc's) connected to a server and when 2 or more speak, the sound is not clear.
(So when a program receives 2 (or more) signals, the sound is stretched, delayed and choppy.)
I do not know if it is because of how the sound is processed.

Yes. Because a VoipInstance only has space for one input at a time, the audio gets weird when it gets multiple inputs. The solution is creating a new VoipInstance for every connection to your server.

Thanks, I will try to implement this, but I think it would be helpful for others to have some instructions or a hint in the readme/description.

Yes. I will probably update the plugin to make it easier.

Thank you

Okay I made some changes which make it possible to receive multiple inputs with a single instance.

I think it is working. Thank you.

@casbrugman If I connect 10 voice programs to a server (and they all speak) the sound is weird again. This can probably only be fixed with a new voip instance. Could you help me figure out how to connect the incoming connections ID's to a new voip instance?
(I'm testing it alone, but if 10 people are talking, it must be a mess ;) but if too many people have background noise, it would probably lag).
With 8 connections the sound is really great now!

Could you explain in what way the sound is weird?

It's stretched, delayed and choppy. (like the first time, but now only for about 9+ connections).

@casbrugman To test multible connections alone I have changed the signal to button_toggled:
func _on_Voice_toggled(button_pressed):
    if button_pressed:
	    voice.recording = true
    else:
	    voice.recording = false

Could this be a problem? (Too many programms that want a microphone signal?)

Should be completely fine

I think this might be a performance issue (not your computers fault of course). I'll have to investigate further.

@casbrugman If I connect 10 voice programs to a server (and they all speak) the sound is weird again. This can probably only be fixed with a new voip instance. Could you help me figure out how to connect the incoming connections ID's to a new voip instance?
(I'm testing it alone, but if 10 people are talking, it must be a mess ;) but if too many people have background noise, it would probably lag).
With 8 connections the sound is really great now!

Like you would when making an online game. For every player you spawn an instance and let each player control their own. However, if you are not familiar with making multiplayer games, it can be quite complex.

Thank you. I think I have an idea to connect the players with the instances. I will try it out in the next few days. Do you think this would solve the problem?

At this moment I'm not sure.


Alias boolean cli flags in minimist config

Looks like minimist defaults boolean flags to false which in turn messes with alias reconciliation in args. Simplest way to deal with this right now is to add minimist configuration for boolean flag aliases.
Closes #128

Thanks!

Released!


[Event Request] Codeunit 99000845 Reservation Management - OnDeleteReservEntriesOnBeforeDeleteReservEntries

Hi Team,
In codeunit 99000845 we need possibility to replace and avoid using standard code. Having event with handling in the beginning of procedure DeleteReservEntries, would be a perfect solution :

[IntegrationEvent(false, false)]
local procedure OnDeleteReservEntriesOnBeforeDeleteReservEntries(CalcReservEntry: Record "Reservation Entry"; var CalcReservEntry2: Record "Reservation Entry"; var IsHandled: Boolean)

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


Update codeql languages

Looks like CodeQL can't build your C++, but you can analyze Javascript easily enough by manually specifying languages.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@jhutchings1 Thanks! We haven't really had time to dig in and work with this yet. What I'd really like to use this for is our main codebase at https://github.com/defold/defold. We already have a lot of the infrastructure in place to build the game engine so I'm thinking it might be easier to get it to work there.

@britzl Glad to hear it! Keep us posted if you run into any major issues!


Updates for Rust 1.0

Do not merge yet.
This removes the asterisk about laundry, adds 1.0 links to the header, and a section of stable installers to install.html, adjusts the curl flags, removes .exe in favor of .msi.
One thing to note is that instead of adding additional stable links to the header I replaced beta with stable. It felt a bit overwhelming having a third set of duplicate links, and the beta docs seemed pretty dispensable.
cc @steveklabnik

r? @pcwalton
(rust_highfive has picked a reviewer for you, use r? to override)

@steveklabnik The link to explanation of unstable features is actually not that great. It links to the books 'nightly' page which is mostly another explanation of how to download nightly. What I really wanted was an explanation of release channels and how unstable features work.

r? @steveklabnik

This updates the pitch to 'Rust is a systems programming language that runs blazingly fast, never segfaults, and guarantees thread safety.'
cc @kmcallister

Updated. @steveklabnik I tried to incorporate your suggestion as 'The current stable release of Rust, updated every six weeks and backwards-compatible.'


Docker image size

Description
Uses node:20.12.2-alpine as the base image. Since it includes Node already, we don't need to install any dependencies. The file size is small and the build process is fast.
Validation

[ ] Run docker build .
[ ] Build Docker image with GitHub workflow
[ ] Run image in SageMaker

Related Issues

Addresses #329
Relates to #307.

Check List

[x] I confirm that my contribution is made under the terms of the Apache 2.0 license.
[ ] I have run pnpm checks to ensure code compiles and meets standards.
[ ] I have run pnpm test to check if all tests are passing.
[ ] I've covered new added functionality with unit tests if necessary.

Oh interesting. I didn't even consider that.
Would the sagemaker version of the image require those tools or are they simply a convenience for users who shell in to the docker image to diagnose issues?


docs: Update README to include link to Python version

@jakubroztocil I finally remembered to add the link to the Python implementation


Merge pull request #3 from BhekieRoots/main

Merge pull request #2 from BhekieRoots/My-First-Branch

I have matched the commites


[testlib] Add generic PyTorch check for the cscs-supported apps into hpctestlib/apps

This is a continuation of the work on the test library. This PR work has been done with PyTorch tests. A new file base_check.py has been added, introducing the main class for the PyTorch test, as well as the CSCS tests inherited from it.

Hello @hurricane642, Thank you for submitting the Pull Request!

In the file hpctestlib/apps/pytorch/base_check.py:

Line 11:1: E303 too many blank lines (3)
Line 79:20: E126 continuation line over-indented for hanging indent
Line 85:20: E126 continuation line over-indented for hanging indent
Line 90:15: E271 multiple spaces after keyword

Do see the ReFrame Coding Style Guide

Can I test this patch?

Codecov Report

Merging #2183 (c05cde5) into master (3857bad) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head c05cde5 differs from pull request most recent head 50de583. Consider uploading reports for the commit 50de583 to get more accurate results

@@           Coverage Diff           @@
##           master    #2183   +/-   ##
=======================================
  Coverage   86.12%   86.12%
=======================================
  Files          56       56
  Lines       10208    10208
=======================================
  Hits         8792     8792
  Misses       1416     1416

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3857bad...50de583. Read the comment docs.

ok to test


Empty extended type/module with --include-extended-types

Description
When using --include-extended-types and moving all extended APIs up to top-level with an extension file, DocC still creates entries for the extended type and module, which contains basically nothing.
Checklist

[ ] If possible, I've reproduced the issue using the main branch of this package.
[X] This issue hasn't been addressed in an existing GitHub issue.

Expected Behavior
Since there’s nothing, I would expect the entries to be omitted.
Actual behavior
There’s an "Extended Module" entry holding an "Extended Class" entry, which contains nothing.
Steps To Reproduce
https://swiftpackageindex.com/teco-project/teco-core/main/documentation/tecopaginationhelpers
Swift-DocC Version Information
5.8.0
Swift Compiler Version Information
Swift version 5.8 (swift-5.8-RELEASE)
Target: x86_64-unknown-linux-gnu

Oh it seems to be fixed by #541!


Team permission to create repository in organization

Implements #5114.

New team setting to allow team members to create repository in organization
If a user that is not owner creates an repository in organization, he/she is automatically assigned as administrator (collaborator) on the new repo.

Screenshots
Team settings page:

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@5774260). Click here to learn what that means.
The diff coverage is 73.86%.

@@            Coverage Diff            @@
##             master    #8312   +/-   ##
=========================================
  Coverage          ?   41.56%
=========================================
  Files             ?      494
  Lines             ?    65424
  Branches          ?        0
=========================================
  Hits              ?    27194
  Misses            ?    34734
  Partials          ?     3496

Impacted Files
Coverage Δ

modules/auth/org.go
0% <ø> (ø)

models/org_team.go
52.86% <ø> (ø)

routers/org/teams.go
0% <0%> (ø)

routers/api/v1/org/team.go
31.8% <100%> (ø)

models/org.go
70.88% <100%> (ø)

routers/api/v1/convert/convert.go
81.49% <100%> (ø)

models/repo.go
47.49% <33.33%> (ø)

routers/repo/repo.go
23.35% <40%> (ø)

routers/api/v1/repo/repo.go
65.43% <50%> (ø)

modules/context/org.go
38.7% <50%> (ø)

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5774260...71f5c00. Read the comment docs.

LGTM - you need to fix the err:= assignments.

I added information to the team sidebar also (only shown if this permission is granted):

It's strange you can create a repository, but only have read access permission of that repository.
Maybe we should add a new permission between write access and admin access. I noticed github added serval new permissions.

@lunny I agree you need permission to a repository you created. I would say you should even have admin access. I think it is just strange to be able to create a repository but not change its settings.
What I have done in this PR is to add the creator as admin collaborator if he is not owner. With teams with access to all repositories, that might not be necessary if user will be admin of repo anyhow.

GitHub has the concept of org members and outside collaborators. In Gitea currently all team members is also members of the organization. Access to repositories seem to be possible to set for a user / team regardless if they are member or not. All organization members can per default create repositories. It is not clear what access the creator of a repository has, but I suppose the creator gets admin access automatically?

@lunny It would be good with refined access levels (for teams and/or collaborators), but I don't think it affects this PR. What could maybe be done is to allow setting the minimum default access the creator of a repository should get.

So we need some hints on the create UI?

I suppose the creator gets admin access automatically?

I suppose the creator gets admin access automatically?

Exactly. 👍

So we need some hints on the create UI?

Maybe on the team settings page, to clarify for owner that users get admin access to repositories they create? I think for the creator it will be obviously he got admin access and he probably don't object.

I have merged with the add all repos feature (#8688). The creator now gets admin access unless get it automatically. If someone see need for it an option could be added what access the creator get, but I am not sure it makes much sense. Maybe write access could be enough if other settings are set up automatically (e.g. templates).
Updated screenshot:

needs @lafriks 's review.


Question about sort menu items

VSCode Version: 1.5.0-insider (3d9622208b2167921b6664e04fd1fbd51507a4a0)
OS Version: Windows 10 Redstone 1

How are sorted the items in the menu? I would like to put item before or after copy, copy path, rename and delete.
Case 1. "group": "navigation"
"menus": {
  "explorer/context": [{
    "command": "duplicate.execute",
    "group": "navigation"
  }]
}

Case 2. "group": "1_modification"

This group comes next and contains commands that modify your code.

"menus": {
  "explorer/context": [{
    "command": "duplicate.execute",
    "group": "1_modification"
  }]
}

Case 3. "group": "9_cutcopypaste"

The last default group with the basic editing commands.

"menus": {
  "explorer/context": [{
    "command": "duplicate.execute",
    "group": "9_cutcopypaste"
  }]
}

Also in the documentation there is no information that there are groups except navigation (https://code.visualstudio.com/docs/extensionAPI/extension-points#_contributesmenus).

Oh, sorry, seems I didn't properly read this:

You can add menu items to these groups or add new groups of menu items in between, below, or above. In this release, only the editor context menu allows this grouping control but it will soon be available for the editor title menu and the explorer context menu as well.

Yeah - we are not yet fully done with the menu story. It's stretch for August and likely September when that lands


How do I manage multi rtsp more efficiently?

Overview
I have tens of rtsp video stream to recv and to calc the frames. Now the problem is that recv multi rtsp stream at the time may occupy the most cpu resource.
ffmpeg command-line
I had tried to use subproccess to exec the ffmpeg cmd to do that, the cpu goes to 70% —— I think it make sense. The only problem is that it seems it can only save the image into disk, and I have to read the pic from disk. That's a little bit complex.
num = 32
cmd = 'ffmpeg -y -rtsp_transport tcp -i {} -r 1 /data/test_ffmpeg/stream_{:02}/img_{:02}_%03d.jpg'
for i in range(num):
    idx = i % 3
    url = rtsp_ls[idx]
    ## delegator is the lib that use subprocess more gracefully
    # p = Thread(target=lambda url, i: delegator.run(cmd.format(url, i, i)), args=(url, i))
    # p.start()
    p = delegator.run(cmd.format(url, i, i), block=False)

pyav
So I use the pyav lib to do the job.

To avoid the GIL, I select Process to exec the decoding job.
using multiprocessing.Queue to combine video stream decoding and the calculation work.

class Decode(Process):
    options = {'rtsp_transport': 'tcp', 'stimeout': '5000000', 'max_delay': '5000000'}

    def __init__(self, logger, queue_frame, stream_id, stream_data, time_sample=1):
        Process.__init__(self, daemon=True)
        # ...

    def run(self):
        rtsp_url = self.stream_data['stream_url']
        cap = av.open(rtsp_url, 'r', options=self.options)
        # cap.streams.video[0].thread_type = 'NONE'
        ## interval
        try:
            fps = int(cap.streams.video[0].average_rate)
        except Exception:
            fps = 25
        num_interval = round(fps*self.time_sample)
        ## start to run
        cnt_frame = 0
        while True:
            vf = next(cap.decode(video=0))
            cnt_frame += 1
            if cnt_frame == num_interval:
                frame = vf.to_ndarray(format='bgr24')
                self.queue_frame.put(frame)

the code snippet is to calc
class Calc(Process):
    def __init__(self, logger, queue_frame):
        Process.__init__(self)
        # ...

    def run(self):
        while True:
            if self.queue_frame.empty():
                sleep(0.1)
                continue
            temp = self.queue_frame.get()
            # calculation work

SO in my code, there are multi Decode processes and one Calc process.
Expected behavior
The code can do the same work same the command-line, and has the similar performance.
Actual behavior
My code using pyav works, but the performance is not well. Ignoring the Calc process, the 32 Decode processes drive the cpu 100%.
Investigation

In fact, I used OpenCV to complete the work, but it cost too much resource. When the num of rtsp streams is only 20, the cpu had achieved 100%.
I thought that maybe Process cost too much, so I changed to Thread —— made no sense.
If I use ProcessPool to manage the processes, it seems that I can't get the status of the rtsp stream in real time, so I haven't done that.

Research
I have done the following:

[x] Checked the PyAV documentation
[x] Searched on Google
[x] Searched on Stack Overflow
[x] Looked through old GitHub issues
[ ] Asked on PyAV Gitter
[ ] ... and waited 72 hours for a response.

As far as the actual decoding goes, FFmpeg and PyAV will be similar.
I wonder if there is a bunch of overhead serializing the Numpy array for the queue. It might even be serializing the frame, and stream, and etc.. I'm not sure.
I vaguely remember there being an ability to decode at lower res, if that would be interesting for you.
If this is all you'll be using PyAV for, you can also go back to the ffmpeg cli and have it pipe frames back to you so you dont have the JPEG and disk overhead. Maybe like:
ffmpeg -rtsp_transport tcp -i {} -pix_fmt bgr24 pipe:1

(that is not tested)


WIP: DO NOT REVIEW: iptables: test the effect of missing socket match rule.

The missing socket match rule may make egress proxy upstream return
traffic not be routed to the local socket, due to it being destined
for the original (source POD) source address/port. It is possible that
the ip_early_demux will make the match for us, and policy routing
should work since we already set the skb->mark in the bpf program.
Signed-off-by: Jarno Rajahalme<EMAIL_ADDRESS>

This change is

test-me-please

Coverage decreased (-0.02%) to 44.103% when pulling d0e6f19e6ec4fd7389007c20cb1ba4468cc3f54b on pr/jrajahalme/test-missing-socket-match into 54b480c636d8bb622542429609dd3ddaa1d936a8 on master.

test-me-please

Unrelated Istio test flake on one of the two k8s versions, retesting.

test-me-please

Failed due to helm timing out. Re-testing.

test-me-please

This test concluded that a missing xt_socket module does not break any existing CI tests.


Fix Numpy 2.0 warnings

I think they are actually caused by PySCF. I've enabled the NPY201 Ruff rule.


style

style broken when using in iframe

Hi can you give please some code how do you put it in inframe? And how the styles got broken? I'd like to reproduce this


Let fetch return resultRow & support named style parameters

ResultRow objects enables one to acces elements either
using indices or using their column names.
Add support of keyword parameter style and
remove support of format parameter style.
Support of format parameter style is removed, because they do not lead
to prepared statements, instead the parameters are inserted
as strings. Thus, there are no benefits of using this style of prepared
statement style, neither regarding security nor performance.
To not let one think using format style parameters leads to prepared statements,
the support of this style should be removed.

request review: @jarus

Thank you for your pull request. In my eyes the introduction of ResultRow is problematic because it breaks all existing compare operations. Could you please split both features into separate pull request. You shouldn't edit tests which are not related to your changes.


array_diff(): Argument #2 must be of type array, int given

Package
filament/filament
Package Version
3.2.83
Laravel Version
11.9.1
Livewire Version
3.5.0
PHP Version
8.3.7
Problem description
Having composer updated from filament 3.2.78 to 3.2.83 my users are now getting an error when saving models getting the following error:
array_diff(): Argument #2 must be of type array, int given
Expected behavior
Editing and saving resources should work as expected. Rolling back the Filament version back to 3.2.78 it all works as expected
Steps to reproduce
Firstly create a category
Secondly create a product - select a category from the select dropdown
Save the product
Error occurs
Reproduction repository
https://github.com/scottjo/genie.git
Relevant log output
[2024-05-29 12:59:17] local.ERROR: array_diff(): Argument #2 must be of type array, int given {"userId":1,"exception":"[object] (TypeError(code: 0): array_diff(): Argument #2 must be of type array, int given at /Users/jon/Herd/genie/vendor/filament/forms/src/Components/Select.php:994)
[stacktrace]
#0 /Users/jon/Herd/genie/vendor/filament/forms/src/Components/Select.php(994): array_diff(Array, 1)
#1 /Users/jon/Herd/genie/vendor/filament/support/src/Concerns/EvaluatesClosures.php(35): Filament\\Forms\\Components\\Select::Filament\\Forms\\Components\\{closure}(Object(App\\Filament\\Fields\\CategoryIDSelectField), Object(App\\Models\\Product), 1)
#2 /Users/jon/Herd/genie/vendor/filament/forms/src/Components/Concerns/BelongsToModel.php(49): Filament\\Support\\Components\\Component->evaluate(Object(Closure))
#3 /Users/jon/Herd/genie/vendor/filament/forms/src/Concerns/BelongsToModel.php(33): Filament\\Forms\\Components\\Component->saveRelationships()
#4 /Users/jon/Herd/genie/vendor/filament/forms/src/Concerns/HasState.php(232): Filament\\Forms\\ComponentContainer->saveRelationships()
#5 /Users/jon/Herd/genie/vendor/filament/filament/src/Resources/Pages/EditRecord.php(143): Filament\\Forms\\ComponentContainer->getState(true, Object(Closure))
#6 /Users/jon/Herd/genie/vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php(36): Filament\\Resources\\Pages\\EditRecord->save(true, true)
#7 /Users/jon/Herd/genie/vendor/laravel/framework/src/Illuminate/Container/Util.php(41): Illuminate\\Container\\BoundMethod::Illuminate\\Container\\{closure}()
#8 /Users/jon/Herd/genie/vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php(93): Illuminate\\Container\\Util::unwrapIfClosure(Object(Closure))
#9 /Users/jon/Herd/genie/vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php(35): Illuminate\\Container\\BoundMethod::callBoundMethod(Object(Illuminate\\Foundation\\Application), Array, Object(Closure))
#10 /Users/jon/Herd/genie/vendor/livewire/livewire/src/Wrapped.php(23): Illuminate\\Container\\BoundMethod::call(Object(Illuminate\\Foundation\\Application), Array, Array)
#11 /Users/jon/Herd/genie/vendor/livewire/livewire/src/Mechanisms/HandleComponents/HandleComponents.php(474): Livewire\\Wrapped->__call('save', Array)
#12 /Users/jon/Herd/genie/vendor/livewire/livewire/src/Mechanisms/HandleComponents/HandleComponents.php(101): Livewire\\Mechanisms\\HandleComponents\\HandleComponents->callMethods(Object(App\\Filament\\Resources\\ProductResource\\Pages\\EditProduct), Array, Object(Livewire\\Mechanisms\\HandleComponents\\ComponentContext))
#13 /Users/jon/Herd/genie/vendor/livewire/livewire/src/LivewireManager.php(97): Livewire\\Mechanisms\\HandleComponents\\HandleComponents->update(Array, Array, Array)
#14 /Users/jon/Herd/genie/vendor/livewire/livewire/src/Mechanisms/HandleRequests/HandleRequests.php(93): Livewire\\LivewireManager->update(Array, Array, Array)
#15 /Users/jon/Herd/genie/vendor/laravel/framework/src/Illuminate/Routing/ControllerDispatcher.php(46): Livewire\\Mechanisms\\HandleRequests\\HandleRequests->handleUpdate()
#16 /Users/jon/Herd/genie/vendor/laravel/framework/src/Illuminate/Routing/Route.php(260): Illuminate\\Routing\\ControllerDispatcher->dispatch(Object(Illuminate\\Routing\\Route), Object(Livewire\\Mechanisms\\HandleRequests\\HandleRequests), 'handleUpdate')
#17 /Users/jon/Herd/genie/vendor/laravel/framework/src/Illuminate/Routing/Route.php(206): Illuminate\\Routing\\Route->runController()
#18 /Users/jon/Herd/genie/vendor/laravel/framework/src/Illuminate/Routing/Router.php(806): Illuminate\\Routing\\Route->run()
#19 /Users/jon/Herd/genie/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(144): Illuminate\\Routing\\Router->Illuminate\\Routing\\{closure}(Object(Illuminate\\Http\\Request))
#20 /Users/jon/Herd/genie/vendor/laravel/framework/src/Illuminate/Routing/Middleware/SubstituteBindings.php(50): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}(Object(Illuminate\\Http\\Request))
#21 /Users/jon/Herd/genie/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(183): Illuminate\\Routing\\Middleware\\SubstituteBindings->handle(Object(Illuminate\\Http\\Request), Object(Closure))
#22 /Users/jon/Herd/genie/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/VerifyCsrfToken.php(88): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}(Object(Illuminate\\Http\\Request))
#23 /Users/jon/Herd/genie/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(183): Illuminate\\Foundation\\Http\\Middleware\\VerifyCsrfToken->handle(Object(Illuminate\\Http\\Request), Object(Closure))
#24 /Users/jon/Herd/genie/vendor/laravel/framework/src/Illuminate/View/Middleware/ShareErrorsFromSession.php(49): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}(Object(Illuminate\\Http\\Request))
#25 /Users/jon/Herd/genie/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(183): Illuminate\\View\\Middleware\\ShareErrorsFromSession->handle(Object(Illuminate\\Http\\Request), Object(Closure))
#26 /Users/jon/Herd/genie/vendor/laravel/framework/src/Illuminate/Session/Middleware/StartSession.php(121): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}(Object(Illuminate\\Http\\Request))
#27 /Users/jon/Herd/genie/vendor/laravel/framework/src/Illuminate/Session/Middleware/StartSession.php(64): Illuminate\\Session\\Middleware\\StartSession->handleStatefulRequest(Object(Illuminate\\Http\\Request), Object(Illuminate\\Session\\Store), Object(Closure))
#28 /Users/jon/Herd/genie/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(183): Illuminate\\Session\\Middleware\\StartSession->handle(Object(Illuminate\\Http\\Request), Object(Closure))
#29 /Users/jon/Herd/genie/vendor/laravel/framework/src/Illuminate/Cookie/Middleware/AddQueuedCookiesToResponse.php(37): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}(Object(Illuminate\\Http\\Request))
#30 /Users/jon/Herd/genie/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(183): Illuminate\\Cookie\\Middleware\\AddQueuedCookiesToResponse->handle(Object(Illuminate\\Http\\Request), Object(Closure))
#31 /Users/jon/Herd/genie/vendor/laravel/framework/src/Illuminate/Cookie/Middleware/EncryptCookies.php(75): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}(Object(Illuminate\\Http\\Request))
#32 /Users/jon/Herd/genie/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(183): Illuminate\\Cookie\\Middleware\\EncryptCookies->handle(Object(Illuminate\\Http\\Request), Object(Closure))
#33 /Users/jon/Herd/genie/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(119): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}(Object(Illuminate\\Http\\Request))
#34 /Users/jon/Herd/genie/vendor/laravel/framework/src/Illuminate/Routing/Router.php(805): Illuminate\\Pipeline\\Pipeline->then(Object(Closure))
#35 /Users/jon/Herd/genie/vendor/laravel/framework/src/Illuminate/Routing/Router.php(784): Illuminate\\Routing\\Router->runRouteWithinStack(Object(Illuminate\\Routing\\Route), Object(Illuminate\\Http\\Request))
#36 /Users/jon/Herd/genie/vendor/laravel/framework/src/Illuminate/Routing/Router.php(748): Illuminate\\Routing\\Router->runRoute(Object(Illuminate\\Http\\Request), Object(Illuminate\\Routing\\Route))
#37 /Users/jon/Herd/genie/vendor/laravel/framework/src/Illuminate/Routing/Router.php(737): Illuminate\\Routing\\Router->dispatchToRoute(Object(Illuminate\\Http\\Request))
#38 /Users/jon/Herd/genie/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php(200): Illuminate\\Routing\\Router->dispatch(Object(Illuminate\\Http\\Request))
#39 /Users/jon/Herd/genie/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(144): Illuminate\\Foundation\\Http\\Kernel->Illuminate\\Foundation\\Http\\{closure}(Object(Illuminate\\Http\\Request))
#40 /Users/jon/Herd/genie/vendor/livewire/livewire/src/Features/SupportDisablingBackButtonCache/DisableBackButtonCacheMiddleware.php(19): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}(Object(Illuminate\\Http\\Request))
#41 /Users/jon/Herd/genie/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(183): Livewire\\Features\\SupportDisablingBackButtonCache\\DisableBackButtonCacheMiddleware->handle(Object(Illuminate\\Http\\Request), Object(Closure))
#42 /Users/jon/Herd/genie/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/ConvertEmptyStringsToNull.php(27): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}(Object(Illuminate\\Http\\Request))
#43 /Users/jon/Herd/genie/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(183): Illuminate\\Foundation\\Http\\Middleware\\ConvertEmptyStringsToNull->handle(Object(Illuminate\\Http\\Request), Object(Closure))
#44 /Users/jon/Herd/genie/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/TrimStrings.php(47): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}(Object(Illuminate\\Http\\Request))
#45 /Users/jon/Herd/genie/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(183): Illuminate\\Foundation\\Http\\Middleware\\TrimStrings->handle(Object(Illuminate\\Http\\Request), Object(Closure))
#46 /Users/jon/Herd/genie/vendor/laravel/framework/src/Illuminate/Http/Middleware/ValidatePostSize.php(27): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}(Object(Illuminate\\Http\\Request))
#47 /Users/jon/Herd/genie/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(183): Illuminate\\Http\\Middleware\\ValidatePostSize->handle(Object(Illuminate\\Http\\Request), Object(Closure))
#48 /Users/jon/Herd/genie/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/PreventRequestsDuringMaintenance.php(110): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}(Object(Illuminate\\Http\\Request))
#49 /Users/jon/Herd/genie/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(183): Illuminate\\Foundation\\Http\\Middleware\\PreventRequestsDuringMaintenance->handle(Object(Illuminate\\Http\\Request), Object(Closure))
#50 /Users/jon/Herd/genie/vendor/laravel/framework/src/Illuminate/Http/Middleware/HandleCors.php(49): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}(Object(Illuminate\\Http\\Request))
#51 /Users/jon/Herd/genie/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(183): Illuminate\\Http\\Middleware\\HandleCors->handle(Object(Illuminate\\Http\\Request), Object(Closure))
#52 /Users/jon/Herd/genie/vendor/laravel/framework/src/Illuminate/Http/Middleware/TrustProxies.php(57): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}(Object(Illuminate\\Http\\Request))
#53 /Users/jon/Herd/genie/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(183): Illuminate\\Http\\Middleware\\TrustProxies->handle(Object(Illuminate\\Http\\Request), Object(Closure))
#54 /Users/jon/Herd/genie/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(119): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}(Object(Illuminate\\Http\\Request))
#55 /Users/jon/Herd/genie/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php(175): Illuminate\\Pipeline\\Pipeline->then(Object(Closure))
#56 /Users/jon/Herd/genie/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php(144): Illuminate\\Foundation\\Http\\Kernel->sendRequestThroughRouter(Object(Illuminate\\Http\\Request))
#57 /Users/jon/Herd/genie/vendor/laravel/framework/src/Illuminate/Foundation/Application.php(1176): Illuminate\\Foundation\\Http\\Kernel->handle(Object(Illuminate\\Http\\Request))
#58 /Users/jon/Herd/genie/public/index.php(17): Illuminate\\Foundation\\Application->handleRequest(Object(Illuminate\\Http\\Request))
#59 /Applications/Herd.app/Contents/Resources/valet/server.php(153): require('/Users/jon/Herd...')
#60 {main}
"}

Could you please try and reproduce this in a new repository? I see theres quite a lot of code in the existing one that is not related and I think there might be something weird in the setup that might be causing this. While you're reproducing from scratch, its quite likely that you'll find what might be wrong to provide more detailed information.

HIya Dan - that seems to be the issue - by adding multiple() to the select field it works a treat. Thats my issue - at present the users want to have a single 'category' for a product but in the short to medium term they are going to move to the products belonging to more than one category. This worked in 3.2.78 but no longer in 3.2.83. I don't really want to go through my production code base removing those many-to-many relationships

It should be a simple fix, I will work on it probably tomorrow and get a fix out

If you want to speed up the process, look on line 999 of Select.php and wrap that line in an Arr::wrap() function call, and PR it in so I can quickly merge. If you do that I can squeeze it into todays release

Sorry Dan - away from my machine for the rest of the day. Thanks again for your help.JonSent from my iPhoneOn 29 May 2024, at 15:30, Dan Harrin @.***> wrote:
If you want to speed up the process, look on line 999 of Select.php and wrap that line in an Arr::wrap() function call, and PR it in so I can quickly merge. If you do that I can squeeze it into todays release
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

Fixed by #13010


leveldb core dump

#0  leveldb::ReadBlock (file=0x8ba6420, options=@0x783124c0,
handle=@0x78311fd0, result=0x78311f90) at table/format.cc:101
#1  0x0000000000b9f179 in leveldb::Table::BlockReader (arg=0x7f3b158a6c18,
options=@0x783124c0, index_value=Variable "index_value" is not available.
)
    at ./include/leveldb/status.h:95
#2  0x0000000000b9f4e6 in leveldb::Table::InternalGet (this=0x7f3b158a6c18,
options=@0x783124c0, k=@0x783122a0,
    arg=0x783121b0, saver=0xba4940 <SaveValue>) at table/table.cc:232
#3  0x0000000000b9e76f in leveldb::TableCache::Get (this=0x8cf3640,
options=@0x783124c0, file_number=Variable "file_number" is not available.
)
    at ./include/leveldb/status.h:95
#4  0x0000000000baa4fd in leveldb::Version::Get (this=0x8c1d480,
options=@0x783124c0, k=Variable "k" is not available.
) at ./include/leveldb/status.h:95
#5  0x0000000000b8b151 in leveldb::DBImpl::Get (this=0x8cf5dc0,
options=@0x783124c0, key=@0x783125f0, value=0x78312610)
    at ./include/leveldb/status.h:95

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 1 Mar 2014 at 3:26

in TableCache::FindTable
 *handle = cache_->Lookup(key);
    ..............
    *handle = cache_->Insert(key, tf, 1, &DeleteEntry);

if there are two threads  A, and B,they Get the same key,
A lookup(key) failed ,but haven't Insert(key)in cache_,
B lookup(key) failed also, but when B Insert(key) ,A has Insert(key) already.

so, when program free the memory ，there is an error。

does the time  between lookup（key）and insert（key） need a lock？

Original comment by<EMAIL_ADDRESS>on 27 Mar 2014 at 8:46

[deleted comment]


Fixing / documenting how editable installs with --install-dir=$path work

Hi there,
since https://github.com/pypa/pip/pull/9636 got merged, setuptools is now next in line. :-)
I'd like some input on how to proceed here, as I am still quite new to setuptools.
Some immediate thoughts, I think it would be safe to document that right now (i.e. with the next version of pip) it will work to use pip install --target $target --editable path/to/package which is then equivalent to… I'm actually not quite sure yet, python setup.py develop --install-dir=$targetI think? And to activate the packages in that directory code like this can be used:
def add_site(path):
    """This adds a path to as proper site packages to all associated import
    systems.  Primarily it invokes `site.addsitedir` and also configures
    pkg_resources' metadata accordingly.
    """
    site.addsitedir(path)
    ws = pkg_resources.working_set
    ws.entry_keys.setdefault(path, [])
    ws.entries.append(path)
    for dist in pkg_resources.find_distributions(path, False):
        ws.add(dist, path, insert=True)

Then, second would be the question how to best proceed with this in setuptools? A simple thing could be to add code like this in setuptools to ensure .egg-link's in directories on the python path are recognised? I have actually not yet started looking into how setuptools can actually do something there.
I'm not sure yet how backwards compatibility concerns play a role here, but flit allows to just symlink the installed package or allows using .pth files to achieve the same effect.
It is my understanding that even Windows supports symlinks nowadays, so maybe that is a really attractive option to change the install and simplify all the code in question?
Well, some code reading is probably next, but I wanted to open a space for discussion on how to proceed here, so: feedback welcome.

Linking to https://github.com/pypa/setuptools/issues/2589 to continue the discussion from there.

@jaraco I would really appreciate some input on how to approach this issue.

Absolutely. Thanks for the ping.
First, some observations mostly off the top of my head:

New use of pkg_resources is discouraged. If possible, whatever solution we come up with should work without setuptools (and thus pkg_resources) being installed.
Although pkg_resources recognizes .egg-link files, Python itself does not, and pkg_resources is being replaced by other libraries (importlib.metadata and importlib.resources) that don't recognize egg-links. For that reason, I consider egg-link to be largely deprecated.
pth files are normally not honored in directories except site-packages, but they can be honored if something calls addsitedir() on that directory early (in site, sitecustomize, or usercustomize modules).
pth files (easy-install.pth in particular) is how regular develop installs work today. Setuptools can install to --user or the system site-packages path, and since these paths are implicitly inclided in site.addsitedir(), pth files are honored there.
Although Symlinks are supported on Windows, they still require enabling developer mode or running as Administrator or running as a user with special privileges. Last I checked, it doesn't work out of the box, so can't be relied upon in the general case.
In #2612, we see where other environments have struggled with develop installs to non-site directories when setuptools removed its implicit 'site.py' hack, but the effort there illustrated a simple workaround that nix was able to use to make those prefix directories develop-installable. If we can find a solution that also works for nix's use-case, that'd be great.
The solution might be as simple as making sure a sitecustomize exists in the target directory that makes sure that addsitedir is added for the target dir and install a .pth file.
The situation might be complicated if we need to support more than one such install target in the same environment, but we can figure that out later.


Use custom nuget package for VS 2017 Visual Studio Visualizer library reference instead of directly referencing DLL

We should use custom nuget package for VS 2017 Visual Studio Visualizer library reference instead of directly referencing DLL.
Because we have to avoid having to differentiate between Professional and Enterprise edition of VS 2017.

I've been searching in nuget.org, and there's no nuget package of Visual Studio 2017 Debugger Visualizer. The available nuget packages are only for Visual Studio 2019 and 2022 from https://www.nuget.org/packages/Microsoft.VisualStudio.DebuggerVisualizers
The versions are only for 16.* and 17.*:


Example of loading brion/ogv.js inside an extension

Might not need to merge this one, but we should explore loading this package that requires a wasm blob URL.
https://github.com/foxglove/studio/issues/3401#issuecomment-1206997865

Some PRs I made while working through making this example:
https://github.com/foxglove/create-foxglove-extension/pull/71
https://github.com/foxglove/create-foxglove-extension/pull/70
Both of these make the extension authoring experience more pleasant

Here is an example: https://github.com/defunctzombie/studio-extension-ogv-example
It needs: https://github.com/foxglove/create-foxglove-extension/pull/70 (or the custom config added back to its config.ts)
@amacneil Should we have this in the create-foxglove-extension repo? That the end of it all the two "example" items here are how to use wasm/inline in config.ts and how to deal with emscripten specific wasm loading.
/cc @rgov

I think having a "here's how to use wasm" example in this repo would be nice.
I don't think your example is good for that, because it's more specifically "how to use ogv.js" with some monkey patch hacks, and I don't think is generalizable to other libraries. So keeping it a separate repo seems fine for now.
ogv.js seems pretty well maintained, maybe worth submitting your patch upstream while we're here?

I think having a "here's how to use wasm" example in this repo would be nice.

There's no one-size-fits-all wasm example. emscripten uses this loader pattern where you can override wasmBinary and locateFile. Rust wasm uses different patterns: https://rustwasm.github.io/wasm-pack/book/tutorials/hybrid-applications-with-webpack/using-your-library.html
The common part would be that you need to inline your wasm.

ogv.js seems pretty well maintained, maybe worth submitting your patch upstream while we're here?

Not something I'm keen in spending cycles on right now cause I'm sure it will need several rounds of API design or feedback from the maintainers.

The example repo is updated to the latest version of create-foxglove-extension. It should how to load wasm for ogv.js.
I'm closing out this issue since the example works. If we think this should be moved to the create-foxglove-extension repo feel free to open a new issue otherwise I'm gonna consider this issue as the reference for how to do this for now.


Revert #317

Resolves #346, closes #273, and replaces #348.

@amontalenti @emmett9001 this is a full revert of the changes in #317, which caused the consumer to be suspended if we couldn't speak to zookeeper. So there's nothing new and a lot of old here, but just to be sure I've slapped a "needs review" on it anyway.


Batch Normalization layers inconsistently placed in regards to paper

According to "Efficient parametrization of multi-domain deep neural networks" the Batch Normalization (BN) layers are not needed for the parallel configuration but the model it appears that you still use task specific BN layers for the parallel configuration:
elif config_task.mode == 'parallel_adapters' and is_proj:             self.parallel_conv = nn.ModuleList([conv1x1(in_planes, planes, stride) for i in range(nb_tasks)])             self.bns = nn.ModuleList([nn.BatchNorm2d(planes) for i in range(nb_tasks)])
Additionally in the series configurations, the BN layer is stated to come before the convolution yet that is not the case in the provided code:
if config_task.mode == 'series_adapters' and is_proj:             self.bns = nn.ModuleList([nn.Sequential(conv1x1(planes), nn.BatchNorm2d(planes)) for i in range(nb_tasks)])

I also have the concern about the BN configurations inconsistency with paper.

is this question answered yet? I am also curious about it

I thank you for your comment. Indeed, the paper could have been a bit clearer about this point.
First, for the parallel configuration, specific BN layers are needed as the data distribution is very different from one dataset to another (hence mean and std cannot be shared). We should have put the BN layer in blue in the Figure 2,b of the paper to make it clearer.
Second, in the series configuration, there are two BN layers as conv1x1(planes) = Identity + nn.Sequential(nn.BatchNorm2d(planes), conv1x1_fonc(planes)). Though, I advice against the series configuration as it requires pretraining with the adapters already in the network whereas the parallel configuration is plug and play with networks pretrained and available online.

Thank you for your reply! but why cannot the series adapter be plug and play?

We tried the series configuration in a plug and play configuration but the model did not train properly. I assume that inserting modules in series in a neural network hurts the backpropagation process whereas inserting these same modules seem to preserve good training properties. I do not have a clear reason why it works that way, it is just an observation.

Quite clear now! Thank you so much!


Update blog

Q
A

Is bugfix?
✔/❌

New feature?
✔/❌

Breaks BC?
✔/❌

Fixed issues
#497

Waiting https://github.com/yiisoft/yii-cycle/pull/152

👍


[docs] Interactive demos are broken

The interactive demos on material-web.dev are broken.
I get this error log in the console:

here's the full log:
material-web.dev-1691402211304.log

Should be fixed with the next published version

Fixed now


linux_mptcp: update 0.90 -> 0.90.1

Motivation for this change
Update MPTCP-capable kernel.
Things done

[X] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[X] NixOS

[X] Tested execution of all binary files (usually in ./result/bin/)
[X] Fits CONTRIBUTING.md.

Oh, BTW, the travis build for the kernel will timeout ;).


removed port.h.patch as it is no longer needed

The if defined block was added to include an header #include <sys/endian.h> in port.h file. This header is not present in port.h file in the latest stable build.
Hence, the patch was not applying and the build was failing. On removing this patch file, build is completed successfully.

/run tests

/run tests

Fix works with latest clang

Tests passed, will merge


Add default value for stackdriver tracer

@bianpengyuan: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
e39cec9906145c58252895d6a107d75c820c2607
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bianpengyuan: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
e39cec9906145c58252895d6a107d75c820c2607
link
/test gencheck_istio

unit-tests_istio
e39cec9906145c58252895d6a107d75c820c2607
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bianpengyuan: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-istioio-k8s-tests_istio
3a3cee4eaf90013f2d0e14425eb8730d9c6a1528
link
/test integ-istioio-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Cluster autoscaler docs/tests

Codecov Report

Merging #1284 into master will increase coverage by 0.08%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1284      +/-   ##
==========================================
+ Coverage   36.63%   36.71%   +0.08%
==========================================
  Files          63       63
  Lines        3882     3884       +2
==========================================
+ Hits         1422     1426       +4
+ Misses       2242     2241       -1
+ Partials      218      217       -1

Impacted Files
Coverage Δ

core/controlplane/config/config.go
63.13% <100%> (+0.31%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15458e8...38d4874. Read the comment docs.

@c-knowles Would you mind rebasing this too?

LGTM. Thanks as always!


Last line never get saved

when saving a file last line does not get saved

issue was fixed
for (int i = 0;i < line_count; i++)
the i was not counting to the last line
for (int i = 0;i <= line_count; i++)


"Unresolved use of symbol" warning, externalResources/script function

Like discussed on gitter, it could be an interesting feature to avoid  "Unresolved use of symbol" warning, for function declared in a plain javascript file defined in externalResource (or maybe elsewhere don't mind to give your opinion).
Just to expose the problem it solves, currently i have a plain javascript file with plenty "utility" function, i declared it in Manifest.json externalResource/script, i used these functions in many qooxdoo classes, it works without problem but the compiler throw a  "Unresolved use of symbol" warning for each use of function. The problem can be solved by adding on each class a @ignore for each function but it's quite time-consuming when you have like me many functions and many classes. The goal is so to automaticaly avoid these warning.

There is a global ignores for this purpose - only documented here:
https://github.com/qooxdoo/qooxdoo-compiler/blob/master/source/resource/qx/tool/schema/compile-1-0-0.json
"ignores": {
  "description": "An array of names which the compiler should ignore. Same as @ignore in source code",
  "type": "array",
  "uniqueItems": true,
  "examples": [
    "modules.*"
  ],
  "items": {
    "type": "string"
  }
},

We should add a section to https://github.com/qooxdoo/qooxdoo/blob/master/docs/compiler/configuration/compile.md.
SASS Option is missing to in compile.md

Thanks @hkollmann  for the information, i will use that, however, I have no idea of how difficult it can be and what part of code handle that but i think it could still be a good idea, if possible, to ignore by default function (or other things) declared as external script.
And yes an update of docs about that will be necessary ;)

three cheers for the schema :)


Typing in Italics in the Markup editor causes the text to Jiggle

Steps to Reproduce:

Open a md file
Start typing in italics

https://user-images.githubusercontent.com/25044782/214726025-c5bd5bf3-b542-4bf7-b857-ba542bd1670d.mp4

Unfortunate but it's not clear how you'd reasonably fix this
Italics can not be closed by space then star. This means every time you type space, the text is no longer italic. Some markdown editors seem to parse the text like this in a non-conformant way to avoid this but we try to stick to the commonmark spec


Dev

Pull Request Test Coverage Report for Build 29

1 of 4 (25.0%)  changed or added relevant lines in 2 files are covered.
13 unchanged lines in 1 file lost coverage.
Overall coverage increased (+2.2%) to 61.735%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/WebHook.ts
0
3
0.0%

Files with Coverage Reduction
New Missed Lines
%

src/WebHook.ts
13
0.0%

Totals

Change from base Build 25:
2.2%

Covered Lines:
440

Relevant Lines:
688

💛  - Coveralls


FR: Ctrl+click files and colors

I thought of this when reading about #9463.
It would be really continent to have a pop-up editor appear if you ctrl+clicked on a file url or a color (#FFFFFF) in a string. The colors could bring up a color picker and the files could bring up a file browser. It would let you see the color or file and/or replace it in the text.

@bcolsen the files and the urls and mailtos are already in place.
See https://github.com/spyder-ide/spyder/pull/9387
Want to work on the color picker ?
Should be straightforward to do based ont the PR I attached

Want to work on the color picker ?

Yes I was thinking that would be great.
I should be able to give a color preview on the hover tool tip as well.

I should be able to give a color preview on the hover tool tip as well.

Sure!


Running fab local results in 0 TPS / BPS / Latency

Steps to Reproduce Issue
I've tried different bench_params in fabfile, each time TPS / BPS / Latency is zero.
bash-3.2$ fab local

Actual Result
Starting local benchmark
Setting up testbed...
About to run ['cargo', 'build', '--features', 'benchmark', '--release']...
    Finished release [optimized + debuginfo] target(s) in 4.22s
warning: the following packages contain code that will be rejected by a future version of Rust: nom v5.1.2
Running benchmark (60 sec)...
Parsing logs...

-----------------------------------------
 SUMMARY:
-----------------------------------------
 + CONFIG:
 Faults: 0 node(s)
 Committee size: 4 node(s)
 Worker(s) per node: 1 worker(s)
 Collocate primary and workers: True
 Input rate: 50,000 tx/s
 Transaction size: 512 B
 Execution time: 0 s

 Header number of batches threshold: 32 digests
 Header maximum number of batches: 1,000 digests
 Max header delay: 2,000 ms
 GC depth: 50 round(s)
 Sync retry delay: 10,000 ms
 Sync retry nodes: 3 node(s)
 batch size: 500,000 B
 Max batch delay: 200 ms
 Max concurrent requests: 500,000

 + RESULTS:
 Batch creation avg latency: 201 ms
 Header creation avg latency: -1 ms
        Batch to header avg latency: -1 ms
 Header to certificate avg latency: 2 ms
        Request vote outbound avg latency: 1 ms
 Certificate commit avg latency: 848 ms

 Consensus TPS: 0 tx/s
 Consensus BPS: 0 B/s
 Consensus latency: 0 ms

 End-to-end TPS: 0 tx/s
 End-to-end BPS: 0 B/s
 End-to-end latency: 0 ms
-----------------------------------------

System Information
bash-3.2$ uname -a
Darwin MacBook-Pro-Sergey.local 22.3.0 Darwin Kernel Version 22.3.0: Thu Jan  5 20:53:49 PST 2023; root:xnu-8792.81.2~2/RELEASE_X86_64 x86_64

Git commit: c30bd6f6e945b59aa8f07b0578f2de70f4c199cf
Comparing with other logs, logs/client-* files look empty:
bash-3.2$ cat logs/client-0-0.log
2023-06-17T08:40:58.171435Z  INFO narwhal_benchmark_client: Node address: http://<IP_ADDRESS>:3009/
2023-06-17T08:40:58.171582Z  INFO narwhal_benchmark_client: Transactions size: 512 B
2023-06-17T08:40:58.171618Z  INFO narwhal_benchmark_client: Transactions rate: 12500 tx/s
2023-06-17T08:40:58.171639Z  INFO narwhal_benchmark_client: Waiting for all nodes to be online...
2023-06-17T08:40:58.195428Z  INFO narwhal_benchmark_client: Start sending transactions
2023-06-17T08:40:58.19707Z  INFO narwhal_benchmark_client: Sending sample transaction 0
bash-3.2$

Logs: https://gist.github.com/pavlovdog/db0b4827c9be988cfcb66770ebfe4e2f

same problem with me.


Installer should create a new module node for each mod uuid

This should be a simple change, will require modification to install and uninstall methods

Fixed in latest dev build, will be on nexus soon!


Fix The Content Not Aligned Properly ,Add Contest Icons in Tags

fixes #331

Looks great, merged 🎉

@all-contributors please add Ayusht777 for code


Split font atlas texture into 1024*1024 size if atlas size > 1024

Resize memory-pool chunk-size in editor/app
Split font atlas texture into 1024*1024 size if atlas size > 1024

There are merge conflicts in this PR. If the changes are still relevant, could you try to rebase it on top of the current master branch? (and if possible, switch the indentation back to tabs instead of spaces to match the rest of the code)

Closing as old.


Train 201

This is train 201. It includes:

#1747 (Admin Router: Remove periodic AR reloading in favour of DNS queries)
#1808 (Bumped the packages 'Mesos' and 'mesos-modules')
#1811 ([next-beta] DCOS-UI: Update package for 1.10)

@mesosphere-mergebot bump-ee

The dcos-vagrant tests will most probably be failing and will need to be muted after merging this PR:

test_octarine
test_service_discovery_docker_bridge
test_service_discovery_docker_overlay
test_service_discovery_docker_overlay_port_mapping
test_ip_per_container

I have provided more detailed description of the problem in the description of https://github.com/dcos/dcos/pull/1747, section "Failing tests". Please check linked Jira issues for even more information.

smoke-test/dcos-docker failed with [17:29:27][Step 4/5] Makefile:121: recipe for target 'postflight' failed, see https://teamcity.mesosphere.io/viewLog.html?buildId=733894.

I'd also request review from @karlkfi  for the request on muting the tests.  I read the JIRA (which explained about race conditions), but have not reviewed it closely. I will do it.

@karlkfi  - the failures that we are trying to mute are this: https://teamcity.mesosphere.io/viewLog.html?buildId=733402

smoke-test/dcos-docker succeeded in a 2nd attempt, i.e. it is flaky. Would appreciate if someone can track that in JIRA, need to run now.

Hi @jgehrcke  / @vespian  - the vagrant-bash  tests is the only suite that exercises "multi-master" configuration.
I looked at the related JIRAs, although it suggests that the failure is out of the scope of the changes being introduced,  it might be a good idea to try those "suggested" fixes alongside this PR and bring them in.

https://jira.mesosphere.com/browse/DCOS_OSS-1523 - DC/OS Vagrant: Improve how memory resources are defined for agents
https://jira.mesosphere.com/browse/DCOS_OSS-1524 - dcos-diagnostics --diag returns false positives during DC/OS install.

If we mute it, then this will be a contentious point when the tests are unmuted again.  The best approach will be to have a solution to those "multi-master" test failures before we introduce this change.

For the time being, another train has been started that will move forward that non-contentious PRs: https://github.com/dcos/dcos/pull/1813

For the time being, another train has been started that will move forward that non-contentious PRs: #1813

... and then #1813 was closed w/o leaving a corresponding comment.

The call is to unblock this via https://jira.mesosphere.com/browse/DCOS_OSS-1531.

Looks like https://github.com/dcos/dcos/pull/1808 was already merged (on its own?), so you may need to remove it from the train on rebase

Looks like #1808 was already merged (on its own?), so you may need to remove it from the train on rebase

Yeah, a small comment about that in this PR would have been good. I missed that :(. Now we really need to reassemble this train. Reflecting this with the 'work in progress' label.

This train has been updated.
This is train 201. It includes:

#1747 (Admin Router: Remove periodic AR reloading in favour of DNS queries)
#1784 ([DCOS_OSS-1470] Exhibitor: use PatternLayoutEscaped logger layout for structured journal logger)
#1811 ([next-beta] DCOS-UI: Update package for 1.10)
#1819 (skip vagrant tests for DCOS_OSS-1532)

I re-created the train and forced pushed with additional PRs, instead of closing and creating a new PR.  I wanted to keep the discussion that happened for the previous attempt.

@mesosphere-mergebot bump-ee

Approved (cannot add a green checkmark, because I am the PR creator)!

(cannot add a green checkmark, because I am the PR creator)!

I can!

Note: this is currently waiting on the downstream tests. Mergebot is reporting the aggregate as complete but it is not. Please be sure to check manually before merge

Github's delay in status forwarding. It's gone pending again.
It should have shown green briefly because for the EE train, it went completely green and then I added two more commits. :)

mergebot/enterprise/build-status/aggregate failed as of a known flake. I am in favor of just proceeding.

@mesosphere-mergebot bump-ee


Please consider fixing issues detected by repository checker

Notification from ioBroker Check and Service Bot
Dear adapter developer,
I'm the ioBroker Check and Service Bot. I'm an automated tool processing routine tasks for the ioBroker infrastructure. I have recently checked the repository for your adapter lcn for common errors and appropiate suggestions to keep this adapter up to date.
Please see the result of the check below.
ioBroker.lcn
   -

ERRORS:

[ ] :heavy_exclamation_mark: [E035] No devDependency declared for @iobroker/testing. Please add "@iobroker/testing":"4.1.3" to devDependencies at package.json
[ ] :heavy_exclamation_mark: [E124] Main file not found under URL: https://raw.githubusercontent.com/ioBroker/ioBroker.lcn/master/lcn.js
[ ] :heavy_exclamation_mark: [E140] width and height of logo are not equal
[ ] :heavy_exclamation_mark: [E518] "@alcalzone/release-script" (>=3.0.0) is used, but ".releaseconfig.json" not found. Please create.
[ ] :heavy_exclamation_mark: [E901] .gitignore not found

WARNINGS:

[ ] :eyes: [W109] Missing suggested translation into pt,nl,fr,it,es,pl,uk,zh-cn of "common.desc" in io-package.json.
[ ] :eyes: [W145] Missing suggested translation into uk of some "common.news" in io-package.json.
[ ] :eyes: [W184] "common.materialize" is deprecated for admin >= 5 at io-package.json. Please use property "adminUI".
[ ] :eyes: [W184] "common.title" is deprecated and replaced by "common.titleLang". Please remove from io-package.json.
[ ] :eyes: [W521] "gulp" found at devDependencies at package.json but no "gulpfile.js" found. Is this dependency really required?
[ ] :eyes: [W522] Please consider migrating to admin 5 UI (jsonConfig).
[ ] :eyes: [W523] "package-lock.json" not found in repo! Please remove from .gitignore!

Please review issues reported and consider fixing them as soon as appropiate.
Errors reported by repository checker should be fixed as soon as possible. Some of them require a new release to be considered as fixed. Please note that errors reported by checker might be considered as blocking point for future updates at stable repository.
Warnings reported by repository checker should be reviewed. While some warnings can be considered as a suggestion and be ignored due to good reasons or a dedicated decision of the developer, most warnings should be fixed as soon as appropiate.
Feel free to contact me (@iobroker-bot) if you have any questions or feel that an issue is incorrectly flagged.
And THANKS A LOT for maintaining this adapter from me and all users.
Let's work together for the best user experience.
your
ioBroker Check and Service Bot
Note: This issue replaces issue #30
@mcm1957 for evidence

This issue has been replaced by new isse #34
This issue can be closed.
your
ioBroker Check and Service Bot


Create test suite

It would be nice to have some automated tests. An artificial git repository would be nice to have so that all kinds of corner cases can be tested without needing to have a proper repository where those appear.

When creating tests, make sure to include tests for correct timezone handling of commit timestamps.


Generate an invite when there are zero users to onboard the initial user

I have just deployed wakapi to my kubernetes cluster, with both WAKAPI_INVITE_CODES=true and WAKAPI_ALLOW_SIGNUP=false. With zero users, I don't have a login yet so I can't create an invite that way.
Is there a way to generate an invite so I can create the initial user without allowing signups at all?

Hi @nogweii, there's no way to do this, but you can disable sign-ups again immediately after you created the initial account.


Check for Windows Updates being disabled should pass if Automatic Updates are set to “never check for updates”

Per comments I added to #59: Currently the code does the following check for if Windows Updates are enabled (which is if the service is enabled then the setting must be "notify before download"):
   this.isWindowsUpdateAutoDownloadEnabled =
                    wuLibAutoUpdates.ServiceEnabled &&
                    wuLibAutoUpdates.Settings.NotificationLevel != AutomaticUpdatesNotificationLevel.aunlNotifyBeforeDownload;

In my environment, the service is enabled but Windows Update is set to "never check for updates". I think the above check should be amended to include that as an additional acceptable sign that Windows updates are disabled (the enum to check I believe would be AutomaticUpdatesNotificationLevel.aunlDisabled).
Note also that I set virtualMachineProfile.osProfile.windowsConfiguration.enableAutomaticUpdates to false in the ARM template as per the guide on VMSS automatic OS image upgrades and this still didn't end up putting Windows Update in a state where it was disabled for my environment (even for new nodes that were created after the change). Although its worth noting that we have a boot script that sets auto updates to "never check for updates" in the registry so maybe this has overridden the default setting that this ARM property sets (and that it would have been the one you currently check for). I was surprised the ARM setting didn't just disable the Windows Update service, but it seems it does not.

You don't want to disable Windows Update completely. That is not a secure thing to do. Please don't try that (you probably can't do that anyway).
The OSObserver check is to make sure that automatic download of windows updates is disabled not a check to see if you have disabled AU. POA, for example, requires AU and will override settings that attempt to disable it. VMSS auto image upgrade does not need AU.
The goal of the OSObserver check is to get customers to POA or VMSS automatic os image update quickly, as AU with with automatic download enabled can lead to instability in clusters due to potential concurrent VM reboots (unexpected). You really do need either POA or VMSS auto os image update service.
Perhaps a better check for the purposes of OSObserver is:
var wuLibAutoUpdates = new AutomaticUpdatesClass();
this.isWindowsUpdateAutoDownloadEnabled =
wuLibAutoUpdates.ServiceEnabled &&
wuLibAutoUpdates.Settings.NotificationLevel == AutomaticUpdatesNotificationLevel.aunlScheduledInstallation;

Thanks for the update. I agree the revised check seems sensible and will resolve my use case.

Thank you for bug report! 2.0.7 shipped.

Just thought I’d let you know I’ve tested this and it’s working fine for me.


Add Brew cask install

I noticed that I could install outline-manager through brew cask, but not for outline-client.
Could you please add outline-client to the repository?
Thanks

@guoyida Thanks for trying Outline. I hadn't realised we were in Homebrew - great! Regarding the client, I'm afraid that because it uses VPN it must be distributed via the Apple Store. Sorry :-/
@alalamav Correct me if I'm wrong.

Hello @trevj ,
I don't think that VPN _must be _ distributed via the Apple Store.
The clients for StrongVPN, Freedome can be downloaded as .pkg or .dmg and then installed.
This would be really helpful in automation !

Hi @insyria, the Outline clients rely on the NetworkExtension framework to establish a full-system VPN. In order to receive the entitlements to user the NetworkExtension framework, the app must be distributed through the App Store (see this post for more information).
The apps you mention likely do not use the NetworkExtension framework, but instead rely on default protocols such as IPSec or L2TP.

@insyria @guoyida Mac appstore (mas) provides somehow even more convenience to follow stricter security model of distribution, as if you use mas-cli as an extension to brew to control packages.
However, the update cycle is slower in MAS


Fix createFiles function to handle cases where activity programming language is nil

This pull request addresses an issue in the createFiles function where it fails to handle cases where the programming language of an activity activity.programming_language is nil. By adding a conditional check to ensure that the programming language is not nil before attempting to create a file, this fix ensures the function behaves correctly and prevents potential errors.

Looks good, have you come across an activity where activity.programming_language is nil (just to be curious)

I have come across this issue in a course I'm following. It includes "activities" which I presume are markdown files with extra info on the exercises. Its just text, there is nothing to submit.


New feature r.runFromLineToEnd

Closes #442
What problem did you solve?
New feature  r.runFromLineToEnd bind to VSCode hotkey Ctrl+alt+e, similar to r.runFromBeginningToLine bind to VSCode hotkey Ctrl+alt+b.
(If you do not have screenshot) How can I check this pull request?
Create file temp.R with text, position cursor at line 2, run r.runFromLineToEnd or press hotkey Ctrl+alt+e to run the codes from current line to end
1+1
2+2  # Position cursor in this line,  run `r.runFromLineToEnd` or press hotkey `Ctrl+alt+e`
3+3
4+4
5+5

How to debug VSCode extension and typescript? For instance, how do I test the values interactively such that I want to see what are the available items inside object window.activeTextEditor.selection or simply checking the value of window.activeTextEditor.document.lineCount. Is there any documentation on this and what do you normally do to check these values? Is there such a interactive console for typescript like in R programming language?

Hi @Dave-cruzz, thank you for working on this feature! You can place a breakpoint in the vscode-R TypeScript code, then launch the extension with F5. When the breakpoint is reached you should be able to check the values of the variables by hovering over them in the editor, and you can type variables into the 'Debug Console' to inspect them. The Debug Console is not quite as versatile as the R console, but it should help. This link has a picture: https://vscode.readthedocs.io/en/latest/extensions/debugging-extensions/#:~:text=You can easily run your,view or the Debug Console .

@Dave-cruzz, I have tested this and it works fine, and the code looks good to me.

The 0 in const range = new Range(startPos, new Position(endLine, 0)); should be the last character of the endLine? But it works?

I thought the same thing, but it does work and the code is slightly simpler like this than it would be if we found the last character of endLine. So I'm fine with the current version.
If you're happy with everything as it is, let me know and I'll merge this PR.

Thank you guys. @andycraig yes I am happy with everything. Please merge the pull request.


Always store images with tarsum.v1 checksum added

Updates image.StoreImage() to always ensure that images
that are installed in Docker have a tarsum.v1 checksum.
Docker-DCO-1.1-Signed-off-by: Josh Hawn<EMAIL_ADDRESS>(github: jlhawn)

@dmcgowan @vbatts @icecrime hey! I forgot to get this included in #9784 My original PR was here: https://github.com/docker/docker/pull/9215#issuecomment-67981149

gracious.
LGTM

LGTM

LGTM

I just updated with a minor comment change, no biggie.

It's Monday morning so I prefer to make sure I'm understanding this correctly: if I pull down an image with a TarSum.Dev checksum, it will be verified, but will be "upgraded" to a TarSum.Version1 before being stored locally?

@icecrime yeah, the layer data will be verified using whatever version of TarSum is in the manifest, but when saved into the image graph, we make sure that it has the latest version of TarSum and it updates/saves the tarsum.v1 value in the image json file.

Alright thanks! LGTM


Change to use the factory to get a transaction

Transactions should be created with the syntax below - ideally not from JSON as originally. Also that was missing the transaction ID!
	      let factory        = this.businessNetworkDefinition.getFactory();
	      let transaction    = factory.newTransaction('net.biz.digitalPropertyNetwork','RegisterPropertyForSale');
		  transaction.title  = factory.newRelationship('net.biz.digitalPropertyNetwork', 'LandTitle', 'LID:1148');
		  transaction.seller = factory.newRelationship('net.biz.digitalPropertyNetwork', 'Person', 'PID:1234567890');

          LOG.info(METHOD, 'Submitting transaction');

          return this.bizNetworkConnection.submitTransaction(transaction);

fabric-composer/fabric-composer/issues/424

fabric-composer/fabric-composer/issues/424


ignore delmark when add minmax for pk column (#4746) (#4757)

cherry pick of https://github.com/pingcap/tiflash/pull/4757
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
What is changed and how it works?
Check List
Tests

[ ] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

None

/run-all-tests


not picking up method signatures that span multiple lines

This works:
  extractEmailsFromString(text, options = { isWrappedLessThanGreaterThan: false, }) {
    if (options.isWrappedLessThanGreaterThan) {
      return text.match(/(<[a-zA-Z0-9._-]+@[a-zA-Z0-9._-]+\.[a-zA-Z0-9_-]+>)/gi);
    }
    return text.match(/([a-zA-Z0-9._-]+@[a-zA-Z0-9._-]+\.[a-zA-Z0-9_-]+)/gi);
  }

But this doesn't work:
  extractEmailsFromString(text, options = {
    isWrappedLessThanGreaterThan: false,
  }) {
    if (options.isWrappedLessThanGreaterThan) {
      return text.match(/(<[a-zA-Z0-9._-]+@[a-zA-Z0-9._-]+\.[a-zA-Z0-9_-]+>)/gi);
    }
    return text.match(/([a-zA-Z0-9._-]+@[a-zA-Z0-9._-]+\.[a-zA-Z0-9_-]+)/gi);
  }

I know ctags works on a line by line basis, so is this just not possible to implement? Thanks for making this project!

Yeah, in cases where there is no function or : or = I need to be sure that this is a definition and not a call and for that I must find the ) {.
I don't think I've ever tried to use \n in this context but I can see this becoming very complicated very quickly. I will see what I can do.


Issue 14

Simulate horizontal gene transfers using 2 complete genomes (input in GenBank format).

Coverage decreased (-14.5%) to 76.351% when pulling ca8ec87e2828630f77c5b3002e00ad646fb42343 on ekopylova:issue_14 into 2939df96ec53492513735ebceb777f21fe2060e9 on biocore:master.

Coverage decreased (-13.6%) to 77.29% when pulling e4a1f1fda66237275af5b5ab6c073cc7a30a9099 on ekopylova:issue_14 into 2939df96ec53492513735ebceb777f21fe2060e9 on biocore:master.

Coverage decreased (-13.6%) to 77.29% when pulling f3deb945af82eb0403ed3647560b725e9e129f52 on ekopylova:issue_14 into 2939df96ec53492513735ebceb777f21fe2060e9 on biocore:master.

Coverage decreased (-13.4%) to 77.462% when pulling 952b03f84f3853b60bc7bd01547348afcbbb2152 on ekopylova:issue_14 into 2939df96ec53492513735ebceb777f21fe2060e9 on biocore:master.

Coverage decreased (-13.5%) to 77.389% when pulling 28e84b83151fc4a4143d0bb42f4f88f851bad93c on ekopylova:issue_14 into 2939df96ec53492513735ebceb777f21fe2060e9 on biocore:master.

Coverage increased (+5.0%) to 95.82% when pulling 50c894f2d21257113ada76ade964a6c6cd5dbe68 on ekopylova:issue_14 into 2939df96ec53492513735ebceb777f21fe2060e9 on biocore:master.

Coverage increased (+3.0%) to 93.839% when pulling c4529dea97ab092523c2fa7435f3e5168adaf671 on ekopylova:issue_14 into 2939df96ec53492513735ebceb777f21fe2060e9 on biocore:master.

:+1:

A couple of questions.

Coverage increased (+2.7%) to 93.571% when pulling 565fd10227da8fd5707e8bec9e9a00bac21fab21 on ekopylova:issue_14 into 2939df96ec53492513735ebceb777f21fe2060e9 on biocore:master.

Coverage increased (+2.7%) to 93.564% when pulling 48c804d7bdee78d3dbedbb72c63cad095d8aa4ab on ekopylova:issue_14 into 2939df96ec53492513735ebceb777f21fe2060e9 on biocore:master.


Add Copyright Notice

Hi Ashley,
I check through all of the open and closed issues, and didn't see this - could you please add a copyright notice?
Thanks!

The license is right here: https://github.com/ashleymills/Reachability.swift/blob/master/LICENSE

Just saw it @mitchellporter thanks.  Closing it.


Change project name from SMPS to SMP

Signed-off-by: Jubayer Abdullah Joy<EMAIL_ADDRESS>Description
Current State:
SMP is shorter and gets people less tripped up. It doesn't need "Specification" in the title. Many people will already add the word specification as a descriptor when describing SMPS, so the "S" often becomes redundant.
Desired State:

[x] Change this repository's name (drop "specification")
[x] Remove the "S" in SMPS in the logo.
[x] Update elsewhere....?

This PR fixes #80
Notes for Reviewers
I updated,

README.md
All images i.e. .png and .svg and dropped 'M' from SMPS
All .yml and .html mentions of Service Mesh Performance Specification / SMPS to Service Mesh Performance / SMP
Renamed files that had Service Mesh Performance Specification / SMPS in the name to Service Mesh Performance / SMP
Refactored .html and .yml file to support the renamed/changed file

Needs Attention

There are some more fixes that need to be done on this repo as they are not related to the Jekyll website. Someone should refactor those codes to comply with project name (Refactor Make, .go, and .proto).
[Layer5] (https://layer5.io/projects/service-mesh-performance-specification) will be fixed my a separate PR

Signed commits

[x] Yes, I signed my commits.

Welldone @JubayerJoy you did awesome with little time 💯

Hi, @PluckyPrecious, there were some sign-off issues (Keeps happening 😭) in this PR, so made a new PR covering all the changes you have suggested. Please have a look 😃