ColumnView

Added a columnViewBrowser.
Very barebones, only the "Layout Mode" Context menu item works.

Bugs I've managed to spot:

If double clicked a directory, two columns would open with the same directory
"Continue where you left off" does not work with column view

@TyJOrtiz Good job on your PR!
I've compiled a list of things for this PR.
There are some smol bugs I've managed to spot 🐞 :
(This list also includes things that need? to be done)

If double clicked a directory, two (or more) columns would open with the same directory

Fixed

"Continue where you left off" does not work with column view

I have no idea how to implement that

Context menu is not shown for items, instead it is shown for current directory (which is incorrect) - (I can't reproduce this issue anymore. Guess it fixed it self 🤷♂)
Rounded corners on items?

I can fix that

When selecting more than one item, progressbar shows up

Fixed

When item is selected, the context menu for this specific item is still shown when left-clicked on empty space (Not only in ColumnView)

Trying to fix this

Refreshing directory in ColumnView makes the previous directory the same as the leading one

Fixed

Keyboard shortcuts don't work (ctrl+c,v,x,a etc.)
Selection Rectangle is not present

Working on it

Some items have a border around them:

.....

Should be fixed

and sometimes not:

FileSystemWatcher is not present
No drag & drop
Items have click animation whereas listview items doesn't

?

Selection options don't work

Working on that

"Continue where you left off" does not work with column view
@TyJOrtiz
There's a Path property in ITabItem (- newest commit) that needs to be updated when navigating to a directory.
Continue where you left off uses that property. Do you update it?

@TyJOrtiz
There's a Path property in ITabItem (- newest commit) that needs to be updated when navigating to a directory.
Continue where you left off uses that property. Do you update it?

"Continue where you left off" does not work with column view

I have no idea how to implement that

@TyJOrtiz
There's a Path property in ITabItem that needs to be updated when navigating to a directory.
Continue where you left off uses that property. Do you update it?

"Continue where you left off" does not work with column view

I have no idea how to implement that

@d2dyno1 Fixed

@TyJOrtiz It looks lile the option to rename items isn't working in the column view layout.

@yaichenbaum I'm still working on it, I don't know how to do all that stuff yet. Like I said everything's more complex from when I first started on this so I'm just trying to acquaint myself.

@yaichenbaum I'm still working on it, I don't know how to do all that stuff yet. Like I said everything's more complex from when I first started on this so I'm just trying to acquaint myself.

There's a IFilesystemHelpers interface for this

Refreshing directory in ColumnView removes all previous directories
Keyboard shortcuts don't work (ctrl+c,v,x,a etc.)
Selection Rectangle is not present

.....
and sometimes not:

FileSystemWatcher is not present
No drag & drop
Items should not have click animation
Selection options don't work

Phone contents aren't shown in ColumnView:

.

@TyJOrtiz How's progress going?

@TyJOrtiz It looks lile the option to rename items isn't working in the column view layout.

@yaichenbaum Renaming file functionality is now there, I will need to make improvements

Items should not have click animation

@d2dyno1 Fixed
I'll be working on this more throughout the week

Hi @TyJOrtiz! Do you need any help with the PR?

I would love to see this live! ❤

I would love to see this live! ❤

@TyJOrtiz Can we get a status update on this pull request? We would be happy to help solve the merge conflicts from main.

@TyJOrtiz Can we get a status update on this pull request? We would be happy to help solve the merge conflicts from main.

I'm rewriting the whole ColumnView. I'm still trying to figure out how to make individual instances of the itemviewmodel

I'm rewriting the whole ColumnView. I'm still trying to figure out how to make individual instances of the itemviewmodel

I'm rewriting the whole ColumnView. I'm still trying to figure out how to make individual instances of the itemviewmodel

ColumnView probably wont be compatible with the Split Pane view.  I don't think it would make for a great UI or UX for users.

I'm rewriting the whole ColumnView. I'm still trying to figure out how to make individual instances of the itemviewmodel

ColumnView probably wont be compatible with the Split Pane view.  I don't think it would make for a great UI or UX for users.

I'm rewriting the whole ColumnView. I'm still trying to figure out how to make individual instances of the itemviewmodel

@TyJOrtiz don't hesitate to ask for help!

I'm rewriting the whole ColumnView. I'm still trying to figure out how to make individual instances of the itemviewmodel

@TyJOrtiz don't hesitate to ask for help!

@d2dyno1 I figured out how to create new viewmodels so now it's full steam ahead

@d2dyno1 I figured out how to create new viewmodels so now it's full steam ahead

Let's gooo! Thank you 🙌

Let's gooo! Thank you 🙌

Any progress?

I created a pull request a couple weeks ago, what I’m working on now is keyboard shortcuts and trying to fix that MTP issue.
Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows 10
From<EMAIL_ADDRESS>Sent: Tuesday, February 16, 2021 1:10 PM
To<EMAIL_ADDRESS>Cc: Tyler<EMAIL_ADDRESS>State<EMAIL_ADDRESS>Subject: Re: [files-community/Files] ColumnView (#2500)
Any progress?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ffiles-community%2FFiles%2Fpull%2F2500%23issuecomment-780120057&data=04|01||b1f57704ae104f33a86408d8d2bf5a65|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637491066580406631|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=BFnghuL%2BkPY5jLb9%2FON21E1iqsjrCU3KSnZMWiRT9dA%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAGBFXDH6OBFXMAI3YUT7EGTS7LNOBANCNFSM4UISACBA&data=04|01||b1f57704ae104f33a86408d8d2bf5a65|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637491066580416588|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=bNuI2eoWBlX8u2Gq0shNmfjGUrnLdTTbdhAPfurGP74%3D&reserved=0.

What if we merge ColumnView as is and enable it for debug only. And improve it with further PRs to have this PR finally out of the way?

That sounds like a good idea.
Sent from my iPhone
On Feb 27, 2021, at 1:48 PM, d2dyno1<EMAIL_ADDRESS>wrote:

What if we merge ColumnView as is and enable it for debug only. And improve it with further PRs to have this PR finally out of the way?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ffiles-community%2FFiles%2Fpull%2F2500%23issuecomment-787165354&data=04|01||1a809cc11fe745cd994908d8db696b5e|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637500593101154742|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=ELn4cntRSZc2w5%2BwoAFwr0VlJl1jsGTrKfAqZxM00F4%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAGBFXDCCQ3LP5QXKWFT6MILTBFSC3ANCNFSM4UISACBA&data=04|01||1a809cc11fe745cd994908d8db696b5e|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637500593101154742|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=QJmnS4QhNiTndcTKs66mQEgUTBCHqhgCT%2BYNtpAnYtY%3D&reserved=0.

@TyJOrtiz please resolve conflicts

Will do, I'll have it finished before the night's over

I tried to see whats conflicting and it’s saying “too complex to view in browser”. I have no idea what to do
Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows 10
From<EMAIL_ADDRESS>Sent: Saturday, February 27, 2021 3:23 PM
To<EMAIL_ADDRESS>Cc: Tyler<EMAIL_ADDRESS><EMAIL_ADDRESS>Subject: Re: [files-community/Files] ColumnView (#2500)
@TyJOrtizhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FTyJOrtiz&data=04|01||3f4fa5ee38714dddb52d08d8db76a31c|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637500649919185353|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=C5SMRujg8tnq6qz8kCj0SdyZpBVCYlObq7tbcHE9q50%3D&reserved=0 please resolve conflicts
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ffiles-community%2FFiles%2Fpull%2F2500%23issuecomment-787203044&data=04|01||3f4fa5ee38714dddb52d08d8db76a31c|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637500649919185353|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=FR%2Bsrnn3fiBKTOQaZCtQMhI20xuBiXX58SfzXZDmry0%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAGBFXDGPMD4SN5VY6MLK5ZLTBF5FTANCNFSM4UISACBA&data=04|01||3f4fa5ee38714dddb52d08d8db76a31c|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637500649919195308|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=N4GZKeWLdQZpffyJLCiv0E0nFjpiUGsRsgJS%2B63g4E8%3D&reserved=0.

@TyJOrtiz in VS, click "Commit and Sync"

if that doesn't work,
open cmd in files repo dir:
1
git fetch origin master

2
git merge origin master

If that doesn't work, do:
1
git remote add upstream https://github.com/files-community/Files.git

2
git fetch upstream

3
git merge upstream/master

Conflicts will be shown in VS to resolve

I finally merged the main to my fork, I have a question before I freate a pull request...
The context menu no longer shows the Windows Explorer-like context menu (for any view), now its just a basic context menu

Was that intentional?

The context menu no longer shows the Windows Explorer-like context menu (for any view), now its just a basic context menu
Was that intentional?

Nooope, we need to investigate why this is happening :)

@gave92 I have this issue with main as well.

Hey, why didn't this get merged? 😢

@bl-ue There is a new PR #4176.

Ah, I see. Thank you, @yaichenbaum!


Tunes intialPoll times for async endpoints, fixes removeModal size

Ticket Link
GROUPINGS-1408
Test Checklist

[x] Unit Tests Passed:
[x] Jasmine Tests Passed:
[x] General Visual Inspection:

Would like to understand the tuning methodology at some point. Maybe the inline comments could explain in detail?

Ok, I've added comments. The methodology of tuning the initial poll is it should be as close as possible to the time for the regular non-async endpoint to finish.


Label's set_autowrap_mode() not working, but changing from inspector does

Godot version
4.0beta2
System information
Windows 10
Issue description
I have a list of labels dynamically created, and their texte went off-screen. So I added this snipper before adding the child to the tree:
new_label.set_autowrap_mod(TextServer.AUTOWRAP_ARBITRARY)
However, when running the game and checking the remote tree, the autowrap is set to off.
When adding a label from the GUI into the scene, at the same place, the autowrap indeed work.
I have also tried this, but as expected it doesn't work :
new_label.autowrap_mode =TextServer.AUTOWRAP_ARBITRARY)
Other autowrap_mode also don't work.
Steps to reproduce
Copy the following snipper :
var new_label = Label.new()
new_label.text = "my extra long label my extra long label my extra long label my extra long label my extra long label my extra long label my extra long label my extra long label my extra long label my extra long label my extra long label my extra long label my extra long label my extra long label my extra long label my extra long label my extra long label my extra long label"
new_label.set_autowrap_mode(TextServer.AUTOWRAP_ARBITRARY)
add_child(new_label)

Minimal reproduction project
No response

Setting autowrap mode from the code seems to be working as expected, so it might be an issue with remote tree not reading it correctly.

Remote tree inspector can't change properties' values in master. This is already reported in another issue, but I can't find it right now.

^ it was fixed already.


feat(docs): document mermaid diagrams

This PR documents Fern's integration with Mermaid.js diagrams.

Blocked by: https://github.com/fern-api/fern-platform/pull/1514 which needs to be merged first.

waiting for the frontend to be released


chore: limit esbuild upgrades by renovate

Description
Limit the upgrade range for ESBuild by renovate due to breaking changes in v0.17.x
Resolves #649

Don't merge this for now, partially solved in https://github.com/DARPA-ASKEM/TERArium/pull/648


Fix duplicate trending score change and incorrect effective_amount in resolve/claim_search for non activated claims

https://github.com/lbryio/lbry-sdk/issues/3465

Coverage remained the same at 68.759% when pulling e998f106f56349135c584cba4bd3c41d3ed42539 on fix-effective-amount into f5f8775c59d54a7b7de945d31bd034a398bc9ff0 on master.


Scheduler tool - Add scheduler tool admin users to calendar

Scheduler tool uses Outlook calendar meeting to maintain available meeting slots. Currently these meetings can be edited by engineering team only.  We should share these calendars with admin team DL so they can block or add a random slot within these placeholder calendars.

[x] Informational
[ x] API
[ ] SDK (ish, ideally we can change to the DL which need to be enabled to be a SG)


Add ARM support (without NEON for now)

Could you make a suggestion of how it should be grouped together? Do we want to split it into different files?

What do you think of the way it is organized in https://github.com/nomonosound/numpy-rms/blob/main/numpy_rms/_rms.c?

What do you think of the way it is organized in https://github.com/nomonosound/numpy-rms/blob/main/numpy_rms/_rms.c?

I think it's good. It is less code though.
I think it is okay to have it in the same file for now, as long as it is kept more together, but we probably want to split it out in separate files when we add neon


Easy guide for customizing the HTML and CSS?

[x] I've read the guidelines for Contributing to YOURLS Projects
[x] This request isn't a duplicate of an existing request
[x] This is not a personal support request that should be posted on the YOURLS Discourse community

Summary
I would like to know if there can be a guide that describes how to customize the HTML and CSS for yoURLs. Such as what CSS property changes what, how to add your own HTML, change some existing HTML, etc.
Motivation
I think that it would be cool to get to customize the HTML and CSS. If someone wants to become the next bit.ly, they will need to change the HTML to make it like they want. It is hard for me to look through all the code (I do not have any knowledge of PHP) and figure out what changes what, if it works or not, and if it does the thing I want.
Describe the solution you'd like
The solution I would like is a guide that is easy to follow, that gives you details on functions do what and how to customize the HTML and CSS.

I suggest you have a look at how YOURLS plugins or themes that modify the interface work.


A11y_MySQLextensionforAzureDataStudio_Create new server group_ Usability:The color name is not available to users along with the Hexadecimal value in the Group Color Field, in the add server group dialog.

GitHub Tags:
#A11yUsable; #A11yTCS; #A11ySev4; #DesktopApp; #GH-MySQLextensionforAzureDataStudio-Win32-Mar23; #MySQL extension for Azure Data Studio; #Win32; #Benchmark;
Environment and OS details:
Azure Data Studio Version: 1.42.0 (user setup)
Windows 11 Enterprise Version	22H2
Installed on	28-12-2022
OS build	22621.1413
Experience	Windows Feature Experience Pack 1000.22639.1000.0
Pre-Requisite:

Install Azure data studio From here https://learn.microsoft.com/en-us/sql/azure-data-studio/download-azure-data-studio?view=sql-server-ver16&tabs=redhat-install%2Credhat-uninstall
Once installation done , Install MySQL Extension in Azure data studio
Tab Till  new connection and press enter
Enter a valid server name username and password and press connect

Repro Steps:

Launch Azure Data Studio.
Select the Connections icon (if not already selected) from left bar.
Hover over the 'Servers' header and select the icon that has a tool tip of 'New Server Group' icon.
Tab till "Group Color"
Verify that Color name is available or not

Actual Result:
The color name is not available to users along with the Hexadecimal value in the Group Color Field, in the add server group dialog.
Expected Result:
The color name should be available to users along with the Hexadecimal value.
Attachment:

This issue is external to MySQL extension as it is a common UI of Azure Data Studio.


Update Vagrantfile with Cloud CLI

Added code to the end of the vagrantfile. We may need to update our local apikeys/credentials for this to work

Codecov Report

Merging #42 into master will not change coverage by %.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #42   +/-   ##
=======================================
  Coverage   90.83%   90.83%
=======================================
  Files           2        2
  Lines         131      131
=======================================
  Hits          119      119
  Misses         12       12

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b59395...d170bfe. Read the comment docs.


Sidr needs two click on link, before showing.

Anyone can duplicate this issue?

I just downloaded v1.2.1 and I'm getting a similar issue.
The first time I attempt to open the sidr it takes 2 clicks.  After that it seems to work fine.  Do I need to initialize it on page load / show?

I just encountered the same issue, and none of the solutions here helped me. I think the simplest solution is to trigger the first click programmatically as soon as the plugin is initialized in your javascript. Simply add $('.switch').click(); after initializing sidr.

Please before reopning this issue give a jsfiddle, a codepen, a url or somewhere we can reproduce the error.


Remove system dependency on lsif-semanticdb

Currently, lsif-java shells out to lsif-semanticdb to convert SemanticDB files into LSIF. This system dependency complicates the installation for lsif-java because lsif-semanticdb needs to be available on the $PATH.
It would be nice if we can remove this system dependency by implementing the SemanticDB->LSIF conversion in Java. Ideally, I'd like lsif-java to be distributed as a standalone native binary with batteries included. We already embed the compiler plugin and the java agent jars as resources. WDYT @efritz @Strum355?

I have no issues here. We only wrote it on go initially for code reuse with (what is now) lsif-protocol.

Given we probably have 0 people using it currently (:raised_eyebrow:), this change will probably not affect anyone so Ive no issues either

Maybe we should write it in a language that can compile it to both :laughing:
Nah, I'm kidding. That sounds like a good plan. Are we going to keep both implementations then? Can we have some shared spec of tests that they both pass, etc?

Are we going to keep both implementations then?

Good question. I suspect the Java implementation may diverge as the project evolves. It might make sense to deprecate/archive one of the implementations down the road.

lsif-semanticdb lives in this repo now since #127


Moving to new github organisation for the longer suatainablity and maintenance of the project: New Org Coffeekup

this is the new org https://github.com/coffeekup which is still unofficial, but we are looking forward to formalize some thing for the project. contribution and participation are welcome
give your opinion here please

I've found https://github.com/goodeggs/teacup

Any news on this? Nothing in the repository mentioned above.

I send email and invited the coffeecup package maintainer to handover the repo to the or and share publishing credentials to new maintainers. but he seems too busy. I could start a new repo with the updated codes but to publish it under old known name need the package maintainer response. though he told that he will share the credentials.

or select a new name such as coffeecups or coffeekups


Update integrations.py

Running this script showed the syntax error. I have added ',' on line 143.

Automated message from Dropbox CLA bot
@ishankschauhan, it looks like you've already signed the Dropbox CLA. Thanks!

@ishankschauhan I don't believe that this is a syntax error; the existing code works properly.  Can you explain why you thought this was a syntax error?

During integration task I got this error. It worked properly after adding ','

@timabbott I doubt that it runs properly. Compare that line with others

@ishankschauhan you should read about how Python works; trailing commas are not required for the last item in a list.  Stylistically, I like to include them, but it's completely optional.


Cannot call method 'has_focus' on a null value

I added this addon for the first time in a recently created project, and after a project reload I got this

I have no idea why, so I just changed the line 255 of plugins.gd if (!filter_txt.has_focus()): for if (not filter_txt or !filter_txt.has_focus()):
I do have two more plugins: project timer tracker by fifut and inputmapperpresetloader by light1c3.  But uninstalling those did not fix it.
Is this error normal? I can make a PR but I'm not sure if this is something that shouldn't happen.
And well, even after changing that line, I still get some errors when closing or opening a tab

are you using Godot 4.2.1 or Godot 4.3.dev?

I am also seeing this issue in Output, while using Godot 4.2.1

I'm having this same issue
Godot 4.2.1

Hm, I wonder what is different for you. It works for me and some friends are using it as well, no problems at all.
I will probably add a nullcheck so we fail safe, but it would be interesting to know what the root cause is.

are you using Godot 4.2.1 or Godot 4.3.dev?

I'm using Godot 4.2.1

Same problem here, with 4.3.dev3.

Found the problem, will submit a new update to the AssetLib soon.

The update is on the asset store! Please install the plugin again and tell me if the bug is fixed for you! :)

Bug is fixed for me! Output is reporting no issues!
Thank you so much for the fast response!

Everything works here too, thanks a lot! :+1:

I've been using it for a while today and everything is working fine! Thank you!

Thank you guys for reporting back!


Container images for arm64 contain amd64 os binaries

Operating system
arm64 conatiner images
Helmfile Version
latest
Helm Version
latest
Bug description
I went too overboard in #817 and ran the final image with --platform=$BUILDPLATFORM. This means that the arm64 build is not emulated and pulls in amd64 base image (as well as any package installed images). This means that the binaries pulled in manually work completely fine (helmfile, helm, etc) but you cannot extend the image because even apt update fails.
Relates to original #816
Example helmfile.yaml
all
Error message you've seen (if any)
.buildkit_qemu_emulator: /bin/sh: Invalid ELF image for this architecture

Steps to reproduce
run apt update in an arm64 image
Working Helmfile Version
NA
Relevant discussion
No response

@lavifb PR is welcome.

Yup it's up. Thanks for bearing with me here


Auto-detect and install homebrew

The prepare toolchain script could also attempt to detect home-brew and install it if it is not present.

There appears to be an issue with executing the brew installer from within an automated script. This is a resolvable issue, but not a critical one.


Merge branch cookiecutter-sql back to main

Subject of the issue
A lot of rework was done to move the data storage concept from files to SQL backend. This branch has now matured and can be pulled back into master.
Workstream
Cookiecutter supports ws1 (health) and ws3 (economic engine)
Your environment

python 3.6 and 3.8
ubuntu 16 and 18
Chrome Canary, Chrome

Steps to reproduce
N/A
Expected behaviour
Should work as specified
Actual behaviour
N/A

Closed via pull request


Create a DAG to log and report code review response times

Problem

Currently our code review response times can feel slow and potentially hinder the project.
Description

Create a new DAG to collect average PR review response times from the GH API and report them to Slack.
How granular do we want to get here? Do we want to look at individuals response times, or a breakdown per repo, for example? I'd prefer to avoid calling out anyone specifically.
Is there a metric we could show to indicate how many PRs were reviewed past the review times indicated by their priority? For example if a PR should have been reviewed in 5 days and was instead reviewed in 6, can we log that?
Also, do we think it's sufficient to have isolated weekly totals, or should we store and collect this data somewhere so we can look at it over time?
Alternatives

Additional context

Implementation

[ ] 🙋 I would be interested in implementing this feature.

Oops, I should have made note of this - I already made this issue! Though yours is more descriptive, so I can close mine:
https://github.com/WordPress/openverse-catalog/issues/670

How granular do we want to get here? Do we want to look at individuals response times, or a breakdown per repo, for example? I'd prefer to avoid calling out anyone specifically.

+1 to not recording specific people's times, at least not publicly. If individuals want access to that maybe there can be a way for them to retrieve it... but I'm wary of how much "pressure" we want to put on people vs just having the information so we can investigate which processes are not working. To me this question is less about "how do we get people to review PRs faster" and more "are PRs not getting reviewed in the time that we expect them to and if so, what are the reasons for this and can we fix those reasons". I guess it's just broader and assuming more that people are doing their best but may be hitting road blocks during reviews. In this sense it could be extremely useful to know if there are individuals who are struggling to be able to collect specific feedback. But again, wary of singling out anyone who is just having a hard time with the current processes.

Is there a metric we could show to indicate how many PRs were reviewed past the review times indicated by their priority? For example if a PR should have been reviewed in 5 days and was instead reviewed in 6, can we log that?

I'd be interested in seeing something like this:
In the past week:

5 medium PRs were reviewed. 3 were on time with an average of 0.3 days ahead of expectations. 2 were reviewed after the expected date with an average of 1 day of tardiness.

... etc

Probably a table of that information is easier to digest than sentence form. I'm not sure whether averages or ranges or what is useful. Seeing these aggregated over longer periods of time than a week would also be useful, so yes to longer term storage, as you mentioned. Store it in the catalog Postgres seems fine?
I'm very curious if the impression that PRs are reviewed slowly is provable or if individual expectations are merely not aligned with the stated expectations of PR review times.


Add metadata which says whether or not the type of authentication was persistent

For Antiforgery by default in MVC - we need a way to know that the type of authentication used was a persistent auth.
This should be implemented such that the non-persistent auth schemes (bearer) make a declaration that they are not persistent. The antiforgery infrastructure in MVC will look for confirmation that the scheme is not persistent.

@rynowak - at this point we should either do something or close the issue. Given what we've done with APIs, what seems worthwhile?


New factory functions for NotEmptySet.Companion

Description
We would like to add experimental factory functions to the NotEmptySet.Companion type for all platforms with the following signature:
fun <E> NotEmptySet.Companion.create(array: Array<E>): NotEmptySet<E>
fun <E> NotEmptySet.Companion.createOrNull(array: Array<E>): NotEmptySet<E>?

fun <E> NotEmptySet.Companion.create(collection: Collection<E>): NotEmptySet<E>
fun <E> NotEmptySet.Companion.createOrNull(collection: Collection<E>): NotEmptySet<E>?

fun <E> NotEmptySet.Companion.of(head: E, vararg tail: E): NotEmptySet<E>

The NotEmptySet type being incompatible with Java due to its declaration as inline value class, these functions shouldn't be available yet for Java users.
Checklist

[ ] Add the create(Array<E>) function, test it, update the public API binaries and the unreleased changelog.
[ ] Add the createOrNull(Array<E>) function, test it, update the public API binaries and the unreleased changelog.
[ ] Add the create(Collection<E>) function, test it, update the public API binaries and the unreleased changelog.
[ ] Add the createOrNull(Collection<E>) function, test it, update the public API binaries and the unreleased changelog.
[ ] Add the of(E, vararg E) function, test it, update the public API binaries and the unreleased changelog.
[ ] Create an issue depending on this one for making these functions available for Java users.

We should wait for the issue #371 to be resolved before implementing this one.


Make word count warnings work with leatest TinyMCE editor.

Fixes #4270
Test Steps

[ ] Confirm that the word count warnings on rich text fields on applications forms are working.

@theskumar Added your version of the script, definitely more readable.
If the only rich text field is in a field group it can be hidden. That might be the reason for using "setInterval". It was I who added this, but it was five years ago.


UX: Redesign Transactions at Dashboard

Problem:
The current table is not scalable and doesn't fit multiple wallet treasuries.
User story
As a user,
I want to see from what wallet this transaction was made and what the destination wallet
so than I will clearly see what treasury wallet was used and more.

@FREZZZBE how do we segregate the lockup and sputnik dao transactions?

@Megha-Dev-19  you can see it in from/to columns. If the wallet end with .lockup.near that means lockup wallet was used to send or receive some funds.

oh sorry yes we have both, so one of them will have it, looks good to me.


Add configuration check and pre-emptive bump

-Pre-emptively bumped the version number to 3.1.0-beta since I expect
that will be in develop by the time this is merged.
-Added a configuration checker that ensures no unwanted keys are present
and that wanted keys are accounted for. Does nothing about values at
this point.
-Updated the relevant POD mentioning the above.

So, this kind of works.
It warns the user that a invalid config is present, but running --update-config dies too. :(


Release 0.3.4

Codecov Report

Merging #234 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #234   +/-   ##
=======================================
  Coverage   72.98%   72.98%
=======================================
  Files         219      219
  Lines       10174    10174
=======================================
  Hits         7426     7426
  Misses       2748     2748


Display of grafana link and information is not displayed correctly

Setup

Rancher version:2.7-head (2.7.2 ish)

Describe the bug
Grafana controls and messages have suffered bit rot

Grafana link isn't vertically aligned with buttons
no padding between sections in Etcd Metrics tab

To Reproduce

Install monitoring
Nav to cluster dashboard
Scroll down below events

Screenshots

retest passed moving to closed
testing information:
-stood up a local 2.7.2rc6
-deployed two downstream clusters-- one 1.25 k8, one 1.24 k8
**testing activities- **

installed monitoring version 102.0.0+up40.1.2
navigated to cluster dashboard
validate UI displays as expected.
click on 'detail', 'summary' and 'grafana' and confirm working as expected

results:
1.25 version result- passed
1.24 version result- passed
pass criteria - all buttons work and UI displays as expected


Video Record Failed on some Devices when set >=veryHigh. The ResolutionPreset is not auto-downgrade to a proper one

Looks like old issue but still appear.
I set ResolutionPreset.veryHigh. The takePicture() is working fine but RecordVideo() is "freeze". I'm using the latest version 0.10.0. It can be reproduced easily with example code (https://github.com/flutter/plugins/tree/main/packages/camera/camera). And just like a lot of discussions mentioned the ResolutionPreset.medium may make it work, me too. I set high and medium, they both works. From LogCat, I found a message "Surface with size (w=1920, h=1080) and format 0x1 is not valid, size not in valid set: [1440x1080, 1280x960, 1088x1088, 1280x720, 960x540, 720x480, 640x480, 352x288, 320x240, 176x144]". Looks like the setting "veryHigh" is asking 1920x1080, it's out of what the camera supportable resolution then failed. In "resolution_preset.dart", that said "If a preset is not available on the camera being used a preset of lower quality will be selected automatically.", but not really happen. It's just generating failure. Could team review again whether the "automatic selection" can really work to resolve it? Thanks!
[Device] Oppo A79
[OS] Android 7.1.1
[Code] Camera 0.10.0 example (https://github.com/flutter/plugins/tree/main/packages/camera/camera)
[Camera] Both front and back camera failed
[Symptom] Freeze when startRecordVideo(). If do stopRecordVideo(), the file size is 0 byte.
[Pass] ResolutionPreset.high, ResolutionPreset.medium, ResolutionPreset.low
[Fail] ResolutionPreset.veryHigh, ResolutionPreset.ultraHigh, ResolutionPreset.max
My flutter doctor:
C:\src\flutter\bin\flutter.bat doctor --verbose
Flutter assets will be downloaded from https://storage.flutter-io.cn/. Make sure you trust this source!
[√] Flutter (Channel stable, 2.10.3, on Microsoft Windows [Version 10.0.22000.739], locale zh-TW)
• Flutter version 2.10.3 at C:\src\flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision 7e9793dee1 (5 months ago), 2022-03-02 11:23:12 -0600
• Engine revision bd539267b4
• Dart version 2.16.1
• DevTools version 2.9.2
• Pub download mirror https://pub.flutter-io.cn/
• Flutter download mirror https://storage.flutter-io.cn/
[√] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
• Android SDK at C:\Users\Jemmy_Wu\AppData\Local\Android\Sdk
• Platform android-33, build-tools 31.0.0
• ANDROID_HOME = C:\Users\Jemmy_Wu\AppData\Local\Android\Sdk
• Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
• Java version OpenJDK Runtime Environment (build 11.0.12+7-b1504.28-7817840)
• All Android licenses accepted.
[√] Chrome - develop for the web
• Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe
[√] Visual Studio - develop for Windows (Visual Studio Community 2019 16.10.0)
• Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
• Visual Studio Community 2019 version 16.10.31321.278
• Windows 10 SDK version 10.0.19041.0
[√] Android Studio (version 2021.2)
• Android Studio at C:\Program Files\Android\Android Studio
• Flutter plugin can be installed from:
https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 11.0.12+7-b1504.28-7817840)
[√] Connected device (4 available)
• OPPO A79 (mobile) • S4NZ9L7HWG6SSC8P • android-arm64 • Android 7.1.1 (API 25)
• Windows (desktop) • windows • windows-x64 • Microsoft Windows [Version 10.0.22000.739]
• Chrome (web) • chrome • web-javascript • Google Chrome 103.0.5060.66
• Edge (web) • edge • web-javascript • Microsoft Edge 103.0.1264.62
[√] HTTP Host Availability
• All required HTTP hosts are available
• No issues found!
Process finished with exit code 0

Hi @JmyW
I can not reproduce the issue on the latest stable and master channels with sample code
I tested with veryHigh, ultraHigh and max on Samsung Galaxy Tab A7 Lite Android 11. It can record video normally.

Demo

veryHigh
ultraHigh
max

flutter doctor -v
[✓] Flutter (Channel stable, 3.0.5, on macOS 12.2.1 21D62 darwin-x64, locale en-VN)
    • Flutter version 3.0.5 at /Users/huynq/Documents/GitHub/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision f1875d570e (9 hours ago), 2022-07-13 11:24:16 -0700
    • Engine revision e85ea0e79c
    • Dart version 2.17.6
    • DevTools version 2.12.2

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-33, build-tools 31.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] IntelliJ IDEA Community Edition (version 2020.3.3)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] IntelliJ IDEA Community Edition (version 2022.1.1)
    • IntelliJ at /Users/huynq/Library/Application Support/JetBrains/Toolbox/apps/IDEA-C/ch-0/221.5591.52/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.69.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.44.0

[✓] Connected device (3 available)
    • SM T225 (mobile) • R9JT3004VRJ • android-arm64  • Android 11 (API 30)
    • macOS (desktop)  • macos       • darwin-x64     • macOS 12.2.1 21D62 darwin-x64
    • Chrome (web)     • chrome      • web-javascript • Google Chrome 103.0.5060.114

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

[✓] Flutter (Channel master, 3.1.0-0.0.pre.1751, on macOS 12.2.1 21D62 darwin-x64, locale en-VN)
    • Flutter version 3.1.0-0.0.pre.1751 on channel master at /Users/huynq/Documents/GitHub/flutter_master
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision e56047a62c (14 minutes ago), 2022-07-19 23:17:05 -0400
    • Engine revision d9ba4345fc
    • Dart version 2.19.0 (build 2.19.0-12.0.dev)
    • DevTools version 2.15.0

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-33, build-tools 31.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 13E113
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] IntelliJ IDEA Community Edition (version 2020.3.3)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] IntelliJ IDEA Community Edition (version 2022.1.1)
    • IntelliJ at /Users/huynq/Library/Application Support/JetBrains/Toolbox/apps/IDEA-C/ch-0/221.5591.52/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.69.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.44.0

[✓] Connected device (3 available)
    • SM T225 (mobile) • R9JT3004VRJ • android-arm64  • Android 11 (API 30)
    • macOS (desktop)  • macos       • darwin-x64     • macOS 12.2.1 21D62 darwin-x64
    • Chrome (web)     • chrome      • web-javascript • Google Chrome 103.0.5060.134

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

Are there any exception logs? Could you please provide it so that we may verify this?
As far as I can see, you are using the old Flutter version 2.10.3, the latest Flutter stable is 3.0.5 and the master is 3.1.0. Please try upgrading them and retry to see if this issue still reproduces.
Also, is this issue only reproducible on your device? Does it happen on another device?

@huycozy Thanks for prompt feedback.
It's device depends. I have several phones on hand.

The two old HTC (android 6.0) works
A new phone "Vivo Y52 (android 12)" also works
An old phone "Oppo A57 (android 6.0.1)" also works
*** Only failed on the "Oppo A79 (android 7.1.1) , sounds like you don't have this device.

I'm trying on emulator, so far so good. Keep trying, hopefully find another one for easily reproducing issue.

Hi @JmyW
Could you provide exception logs on Oppo A79 (android 7.1.1)?
Also, please try upgrading Flutter SDK and retry to see if this issue still reproduces.

Hopefully the log provides some helpful information.
BTW, I tested most of versions of Android, found:

Android 12: work and the view can move during recording (view moving by press shift+arrowKey)
Android 11: work and the view can move during recording
Android 10: work and the view can move during recording
Android 8.0: work but the view is frozen during recording. But finally still has the mp4 file in storage although it's froze video.
Android 7.1.1: work but the view is frozen during recording. But finally still has the mp4 file in storage although it's froze video.

In my case, the view of Oppo A79 is froze with 0 bytes mp4 file. It's even worse than Android 8.0/7.1.1 emulators. But maybe referable or relative.

@JmyW thanks for providing information. Labeling the issue for further investigation from the team!

Same problem on "vivo x21 UD A"

On this issue, I found some interesting operations on "vivo x21 UD A"：
this code in camera_android-0.10.0+1
  // path : /android/src/main/java/io/flutter/plugins/camera/features/resolution/ResolutionFeature.java
  /**
   * Gets the best possible {@link android.media.CamcorderProfile} for the supplied {@link
   * ResolutionPreset}. Supports SDK < 31.
   *
   * @param cameraId Camera identifier which indicates the device's camera for which to select a
   *     {@link android.media.CamcorderProfile}.
   * @param preset The {@link ResolutionPreset} for which is to be translated to a {@link
   *     android.media.CamcorderProfile}.
   * @return The best possible {@link android.media.CamcorderProfile} that matches the supplied
   *     {@link ResolutionPreset}.
   */
  public static CamcorderProfile getBestAvailableCamcorderProfileForResolutionPresetLegacy(
      int cameraId, ResolutionPreset preset) {
    if (cameraId < 0) {
      throw new AssertionError(
          "getBestAvailableCamcorderProfileForResolutionPreset can only be used with valid (>=0) camera identifiers.");
    }

    switch (preset) {
        // All of these cases deliberately fall through to get the best available profile.
      case max:
        if (CamcorderProfile.hasProfile(cameraId, CamcorderProfile.QUALITY_HIGH)) {
          return CamcorderProfile.get(cameraId, CamcorderProfile.QUALITY_HIGH);
        }
      case ultraHigh:
        if (CamcorderProfile.hasProfile(cameraId, CamcorderProfile.QUALITY_2160P)) {
          return CamcorderProfile.get(cameraId, CamcorderProfile.QUALITY_2160P);
        }
      case veryHigh:
        if (CamcorderProfile.hasProfile(cameraId, CamcorderProfile.QUALITY_1080P)) {
          return CamcorderProfile.get(cameraId, CamcorderProfile.QUALITY_1080P);
        }
      case high:
        if (CamcorderProfile.hasProfile(cameraId, CamcorderProfile.QUALITY_720P)) {
          return CamcorderProfile.get(cameraId, CamcorderProfile.QUALITY_720P);
        }
      case medium:
        if (CamcorderProfile.hasProfile(cameraId, CamcorderProfile.QUALITY_480P)) {
          return CamcorderProfile.get(cameraId, CamcorderProfile.QUALITY_480P);
        }
      case low:
        if (CamcorderProfile.hasProfile(cameraId, CamcorderProfile.QUALITY_QVGA)) {
          return CamcorderProfile.get(cameraId, CamcorderProfile.QUALITY_QVGA);
        }
      default:
        if (CamcorderProfile.hasProfile(cameraId, CamcorderProfile.QUALITY_LOW)) {
          return CamcorderProfile.get(cameraId, CamcorderProfile.QUALITY_LOW);
        } else {
          throw new IllegalArgumentException(
              "No capture session available for current capture session.");
        }
    }
  }

this line return true
case veryHigh:
        if (CamcorderProfile.hasProfile(cameraId, CamcorderProfile.QUALITY_1080P)) {
          return CamcorderProfile.get(cameraId, CamcorderProfile.QUALITY_1080P);
        }

However, "vivo x21 UD A" doesn't actually support 1920x1080
"vivo x21 UD A" valid set: [1440x1080, 1280x960, 1280x720, 1024x768, 960x540, 800x480, 720x480, 768x432, 640x480, 384x288, 352x288, 320x240, 176x144]
Maybe on "vivo x21 UD A"：veryHigh means 1440x1080 ???

I have the same problem

the same problem on Asus ZenFone 3 Max

I have same problem
[Device] Galaxy A52s
[OS] Android 13
[Code] Camera 0.10.5+2 example
[Camera] Back only tested
[Symptom] startRecordVideo() fail, if resolution setting over high.
[Pass] ResolutionPreset.medium, ResolutionPreset.low
[Fail] ResolutionPreset.high, ResolutionPreset.veryHigh, ResolutionPreset.ultraHigh, ResolutionPreset.max
succss log at medium
I/Camera  (18291): prepareMediaRecorder
I/MediaRecorderJNI(18291): release
D/MediaRecorder(18291): Constructor MediaRecorder
I/MediaRecorderJNI(18291): setup
I/MediaRecorderJNI(18291): setAudioSource(1)
I/MediaRecorderJNI(18291): setVideoSource(2)
I/MediaRecorderJNI(18291): setAudioEncoder(3)
I/MediaRecorderJNI(18291): setParameter(), params: audio-param-encoding-bitrate=256000
I/MediaRecorderJNI(18291): setParameter(), params: audio-param-sampling-rate=48000
I/MediaRecorderJNI(18291): setVideoEncoder(2)
I/MediaRecorderJNI(18291): setParameter(), params: video-param-encoding-bitrate=3449000
I/MediaRecorderJNI(18291): setVideoFrameRate(30)
I/MediaRecorderJNI(18291): setVideoSize(720, 480)
I/MediaRecorderJNI(18291): setParameter(), params: video-param-rotation-angle-degrees=90
I/MediaRecorderJNI(18291): setOutputFile
I/MediaRecorderJNI(18291): prepare
I/MediaRecorder(18291): prepare elapsed time : 177 ms
I/MediaRecorderJNI(18291): getSurface
I/CameraManagerGlobal(18291): Camera 0 facing CAMERA_FACING_BACK state now CAMERA_STATE_IDLE for client com.***.***API Level 2
W/om.***.***(18291): Long monitor contention with owner main (18291) at void android.hardware.camera2.impl.CameraDeviceImpl.waitUntilIdle()(CameraDeviceImpl.java:1402) waiters=0 in void android.hardware.camera2.impl.CameraDeviceImpl$4.run() for 579ms
I/Camera  (18291): CameraCaptureSession onConfigured
I/Camera  (18291): Updating builder settings
W/om.***.***(18291): Long monitor contention with owner main (18291) at void android.hardware.camera2.impl.CameraDeviceImpl.waitUntilIdle()(CameraDeviceImpl.java:1402) waiters=1 in void android.hardware.camera2.impl.CameraDeviceImpl$CameraDeviceCallbacks.onResultReceived(android.hardware.camera2.impl.CameraMetadataNative, android.hardware.camera2.impl.CaptureResultExtras, android.hardware.camera2.impl.PhysicalCaptureResultInfo[]) for 577ms
D/Camera  (18291): Updating builder with feature: ExposureLockFeature
D/Camera  (18291): Updating builder with feature: ExposurePointFeature
D/Camera  (18291): Updating builder with feature: ZoomLevelFeature
D/Camera  (18291): Updating builder with feature: AutoFocusFeature
D/Camera  (18291): Updating builder with feature: NoiseReductionFeature
I/Camera  (18291): updateNoiseReduction | currentSetting: fast
D/Camera  (18291): Updating builder with feature: FocusPointFeature
D/Camera  (18291): Updating builder with feature: ResolutionFeature
D/Camera  (18291): Updating builder with feature: SensorOrientationFeature
D/Camera  (18291): Updating builder with feature: FlashFeature
D/Camera  (18291): Updating builder with feature: ExposureOffsetFeature
D/Camera  (18291): Updating builder with feature: FpsRangeFeature
I/Camera  (18291): refreshPreviewCaptureSession
I/CameraManagerGlobal(18291): Camera 0 facing CAMERA_FACING_BACK state now CAMERA_STATE_ACTIVE for client com.***.app API Level 2
I/MediaRecorderJNI(18291): start

error log at high
I/Camera  (18291): prepareMediaRecorder
D/MediaRecorder(18291): Constructor MediaRecorder
I/MediaRecorderJNI(18291): setup
I/MediaRecorderJNI(18291): setAudioSource(1)
I/MediaRecorderJNI(18291): setVideoSource(2)
I/MediaRecorderJNI(18291): setAudioEncoder(3)
I/MediaRecorderJNI(18291): setParameter(), params: audio-param-encoding-bitrate=256000
I/MediaRecorderJNI(18291): setParameter(), params: audio-param-sampling-rate=48000
I/MediaRecorderJNI(18291): setVideoEncoder(2)
I/MediaRecorderJNI(18291): setParameter(), params: video-param-encoding-bitrate=48000000
I/MediaRecorderJNI(18291): setVideoFrameRate(30)
I/MediaRecorderJNI(18291): setVideoSize(3840, 2160)
I/MediaRecorderJNI(18291): setParameter(), params: video-param-rotation-angle-degrees=90
I/MediaRecorderJNI(18291): setOutputFile
I/MediaRecorderJNI(18291): prepare
E/MediaRecorder(18291): prepare failed: -12
E/MethodChannel#plugins.flutter.io/camera_android(18291): Failed to handle method call
E/MethodChannel#plugins.flutter.io/camera_android(18291): java.lang.NullPointerException: Attempt to invoke virtual method 'android.view.Surface android.media.MediaRecorder.getSurface()' on a null object reference
E/MethodChannel#plugins.flutter.io/camera_android(18291): 	at io.flutter.plugins.camera.Camera.startCapture(Camera.java:540)
E/MethodChannel#plugins.flutter.io/camera_android(18291): 	at io.flutter.plugins.camera.Camera.startVideoRecording(Camera.java:772)
E/MethodChannel#plugins.flutter.io/camera_android(18291): 	at io.flutter.plugins.camera.MethodCallHandlerImpl.onMethodCall(MethodCallHandlerImpl.java:122)
E/MethodChannel#plugins.flutter.io/camera_android(18291): 	at io.flutter.plugin.common.MethodChannel$IncomingMethodCallHandler.onMessage(MethodChannel.java:258)
E/MethodChannel#plugins.flutter.io/camera_android(18291): 	at io.flutter.embedding.engine.dart.DartMessenger.invokeHandler(DartMessenger.java:295)
E/MethodChannel#plugins.flutter.io/camera_android(18291): 	at io.flutter.embedding.engine.dart.DartMessenger.lambda$dispatchMessageToQueue$0$DartMessenger(DartMessenger.java:322)
E/MethodChannel#plugins.flutter.io/camera_android(18291): 	at io.flutter.embedding.engine.dart.DartMessenger$$ExternalSyntheticLambda0.run(Unknown Source:12)
E/MethodChannel#plugins.flutter.io/camera_android(18291): 	at android.os.Handler.handleCallback(Handler.java:942)
E/MethodChannel#plugins.flutter.io/camera_android(18291): 	at android.os.Handler.dispatchMessage(Handler.java:99)
E/MethodChannel#plugins.flutter.io/camera_android(18291): 	at android.os.Looper.loopOnce(Looper.java:226)
E/MethodChannel#plugins.flutter.io/camera_android(18291): 	at android.os.Looper.loop(Looper.java:313)
E/MethodChannel#plugins.flutter.io/camera_android(18291): 	at android.app.ActivityThread.main(ActivityThread.java:8757)
E/MethodChannel#plugins.flutter.io/camera_android(18291): 	at java.lang.reflect.Method.invoke(Native Method)
E/MethodChannel#plugins.flutter.io/camera_android(18291): 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:571)
E/MethodChannel#plugins.flutter.io/camera_android(18291): 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1067)
E/flutter (18291): [ERROR:flutter/runtime/dart_vm_initializer.cc(41)] Unhandled Exception: CameraException(videoRecordingFailed, prepare failed:-12)
E/flutter (18291): #0      CameraController.startVideoRecording (package:camera/src/camera_controller.dart:538:7)
E/flutter (18291): <asynchronous suspension>
E/flutter (18291): #1      _CameraRecordPageState._recordVideo (package:***/page/camera/camera_record_page.dart:94:7)
E/flutter (18291): <asynchronous suspension>
E/flutter (18291):
E/DartMessenger(18291): Uncaught exception in binary message listener
E/DartMessenger(18291): java.lang.IllegalStateException: Reply already submitted
E/DartMessenger(18291): 	at io.flutter.embedding.engine.dart.DartMessenger$Reply.reply(DartMessenger.java:435)
E/DartMessenger(18291): 	at io.flutter.plugin.common.MethodChannel$IncomingMethodCallHandler.onMessage(MethodChannel.java:278)
E/DartMessenger(18291): 	at io.flutter.embedding.engine.dart.DartMessenger.invokeHandler(DartMessenger.java:295)
E/DartMessenger(18291): 	at io.flutter.embedding.engine.dart.DartMessenger.lambda$dispatchMessageToQueue$0$DartMessenger(DartMessenger.java:322)
E/DartMessenger(18291): 	at io.flutter.embedding.engine.dart.DartMessenger$$ExternalSyntheticLambda0.run(Unknown Source:12)
E/DartMessenger(18291): 	at android.os.Handler.handleCallback(Handler.java:942)
E/DartMessenger(18291): 	at android.os.Handler.dispatchMessage(Handler.java:99)
E/DartMessenger(18291): 	at android.os.Looper.loopOnce(Looper.java:226)
E/DartMessenger(18291): 	at android.os.Looper.loop(Looper.java:313)
E/DartMessenger(18291): 	at android.app.ActivityThread.main(ActivityThread.java:8757)
E/DartMessenger(18291): 	at java.lang.reflect.Method.invoke(Native Method)
E/DartMessenger(18291): 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:571)
E/DartMessenger(18291): 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1067)
I/MediaRecorderJNI(18291): finalize
I/MediaRecorderJNI(18291): release
I/MediaRecorderJNI(18291): finalize
I/MediaRecorderJNI(18291): release

Experiencing the same problem on a Pixel 1 (Android version 10).
When using the BACK camera to record a video at ResolutionPreset.max the video recording preview freezes and only captures a frame every so often. The recorded video is the same in that it only shows a few frames.
The interesting bit is that using the FRONT camera, everything works as expected. The video recording goes through smoothly.
I can reproduce this behaviour, with a Pixel 1, using the camera example app with one minor modification, setting the line:
https://github.com/flutter/packages/blob/e578a16580c725d774319076e7e81c6528ca7e35/packages/camera/camera/example/lib/main.dart#L634
from:
      kIsWeb ? ResolutionPreset.max : ResolutionPreset.medium,

to:
      ResolutionPreset.max,

After additional research I found a StackOverflow question which may be related in relation to the CamcorderProfile.hasProfile method the plugin uses to check if a given resolution is supported.
Essentially, as far as I understand it. CamcorderProfile.hasProfile may return true for unsupported resolutions in certain situations. The Android docs, confirm this.
I'm not an Android developer myself so I don't known if the plugin implements the checking correctly to work on all devices. But these failures being experienced suggests, more validation might need to be performed before choosing a CamcorderProfile.


Update validations.py script

Fixed the behavior of validate_user function in validations.py
Closes # 1

It's a good idea to open an issue first for discussion.

[ ] Tests pass
[ ] Appropriate changes to README are included in PR

@googlebot I signed it!


⚠ Bofrost.be has degraded performance

In bde12e8, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1346 ms

Resolved: Bofrost.be performance has improved in 52d611b.


Modify schema in WebSQL: Data is lost

Hi,
I noticed that if I modify the schema of a certain store in WebSQL, all the data in that store is lost. In IndexedDB it works fine, the data is kept.
I created a simple jsfiddle to show it:
https://jsfiddle.net/otb1wbet/
If you look at the console you'll see that once the database is created with another schema I cannot retrieve the entries anymore.
If this data should be migrated manually by the developer, can you please give me some hints on how to do it?
Thank you

Hi,
WebSQL does not support ALTER TABLE.
For all my use case (and you should be), truth data is in server and can be restored at any time.


Add Kubernetes health check status for cluster nodes, bsc#1083462

 Bug 1083462 - Unable to update cni config: No networks found in /etc/cni/net.d

This will just make the orchestration fail if any node is in NotReady state, do we want this?

We don't run any functional check at the end orchestration, I had situation recently when bootstraping finished successfully but cluster wasn't configured properly. So yeah we need some health check when orchestration is over.

I agree with @ereslibre. I think it is an overkill to abort an orchestration because a node is failing... Maybe we should do a healthcheck with wait_for_successful_query  and run a kubectl drain (with onfail) if that check fails...

Thank you for suggestions, I've changed this check status as http.wait_for_successful_query.

I'm still not convinced if a NotReady node should make the orchestration fail... many external things could make a node be NotReady. After fixing those external issues that node may just become Ready, but our red cross will be permanent until the orchestration is relaunched.
My vote is to not check this at all, at least with the information I have.

Also - I just realised - all nodes will come up with NotReady status during initial bootstrap, only once CNI has been deployed, will they become Ready.


can't find my headset

I'm trying to find gear vr. The server version is v2.4.0-alpha5 and the client version is 2.3.1.I have created a rule for udp 9944. I find that when i start the server, vrserver.exe won't start and udp port 9943 will be used.I don't know if it is normal.No UDP package from port 9943/9944 can be captured by wireshark. Could you give me some suggestions? Thank you very much!!

Same - i also ran wireshark and saw all the packets from the phone, but nothing from the alvr server. It did seem to be communicating with something on localhost tcp port 9944, but, I think that's just the steamvr part.

I was debugging the exact same issue some time ago. The store version of the client is v2.3.1 and doesn't seem to be compatible with the later v2.4.0-alpha server versions - either downgrade the server, or build the alpha client as explained in https://github.com/polygraphene/ALVR/blob/master/README.md#alvr-client (it's not possible to simply share the updated file because of some weird Oculus signing stuff)
(also a duplicate of #487)

@krzys-h I will downgrade the server and try again. Thank you very much!


Items need to be refreshed after citekey pattern change/it takes long for BBT to get the go-ahead to start up

The automatic CiteKey creation doesn'e seem to work well.
No matter the pattern you define (for example [auth][year]) you get a very long CiteKey that seems to be created with something like [auth][title][year] and it takes very long to create them.
I'm using Zotero Better Bib(La)Tex 5.1.2 with Zotero 5.0.57 on Windows 10 x64.

The automatic citekey generation seems to work just fine for everyone else, and if it didn't work, almost 100% of my automated tests would fail, which I'd know almost instantly. The last checkbox you saw when opening the issue says "If I am posting an export or key-generation related bug report, I have included an error-report by selecting the problematic reference(s), right-clicking, and submitting an BBT error report from that popup menu" for this reason. I believe you when you say that it doesn't seem to work for you, but without a log, I can't tell what is going wrong. Please enable extended logging from the help menu, set the pattern to whatever you want, select a few references and right-click/refresh, then send a log.
When you say it takes long to create them, is that at startup? First-time startup? Refresh? Item change that leads to key change?

Here you can see a screenshot of what I mean.

I really must have a log, generated as I described above (and as was described in the initial issue template with the checkboxes you saw when you opened the issue. Without the log I cannot tell what is going wrong.
I also need to know the answers to the questions I posed earlier ("when you say...").

BTW the screen shots don't help; both can be entirely normal situations. The first one could be right after a pattern change but before the refresh (no way to tell without a log) and the 2nd one could be zotero startup (no way to tell because there's no log and the place the popup would be which would indicate zotero is still starting is cut off). I really can't help you if you don't submit a log. The procedure is clearly described when you open a new issue, but for now, enable extended logging from the help menu, select at least one reference which does not have a citekey as you expect it, right click, refresh, then right-click the same reference, send debug log. Then post the log ID here.

log ID
QLBY5M7V-euc

Thank you. And the questions?

I don't see any trace of a refresh attempt in the log; the reference in question is also not in the log. Please, allow me to help you. Do exactly this:

Make sure extended debugging is (still) on from the Help menu, and that BBT has finished initializing (no popup window in the lower right that says Better BibTeX)
Select 1 reference for which you think the citekey should be different. While it is selected, right-click that same reference, and select Better BibTeX - Refresh BibTeX Key from the menu that pops up.
Select the same reference again if it is not selected, right-click that same reference, and from the menu that pops up, select Better BibTeX - Report Better BibTeX Errors...
Post the debug ID you get here.

Additionally, I need to know: when you say "it takes long to create them", is that

at startup?
first-time startup after installing BBT?
after refreshing the key manually as in point 2.?
after a change to an item leads to the key changing?

You're leaving me blind here -- I cannot see into your system, so I need more information from you.

Most of that minute is spent in the status "Waiting for Zotero database". I am not allowed to touch (not even read) the Zotero database until Zotero tells me it is OK to access it; you will see that it flashes through a few stages and is then done. I cannot do anything about the long delay at the start -- if Zotero gives me the all-clear faster, BBT will start faster.

Can you upgrade to 5.1.5 and send a new log? I can't do anything about the long startup times of Zotero, but if I gather enough evidence (and my idea that this affects many people), maybe I can negotiate with the Zotero devs. 5.1.5 specifically adds logging that captures how long the startup phases take. For me it takes ~ 6 seconds but I've seen it take a lot longer.

Hello again.
I hope I did it properly.
I've tried just restarting and also generating the keys.
Better BibTex
VDK7E278-euc
AMGNRIKP-euc
Zotero
D1821317325
I'm not complaining about anything, just trying to help to improve Zotero.
Regards.

VDK7E278 shows 5.2 seconds waiting for the Zotero go-ahead and then 0.71 seconds for BBT to start after that; AMGNRIKP shows 6.4 seconds waiting for the Zotero go-ahead and then 0.72 seconds for BBT to start after that (I can't read the D<number> logs, those go to Zotero). It should be possible to shave a little off the 5-6 seconds startup time, but it's not currently a major priority in Zotero, and there's nothing I can do about the startup time on my end except the 0.7 seconds. The keys are ready even if you see the question mark in those first 5-6 seconds, I just am not permitted to open the database yet (opening it before ready would lead to lots of nastiness). The database is in some shape ready dusing that time or you wouldn't see any reference data either, but I'm getting my go-ahead substantially later.
I see the refresh in the logs, those take 2-8 milliseconds a piece, that shouldn't be so onerous.

OK thanks,
Anyway this was a small bibliography, around 200 entries but I just selected one third of them to refresh.

According to VDK7E278, there were 56 keys refreshed which took a total of 0.36 seconds. There's not much I can do to speed that up, and there's literally nothing I can do about the 6 seconds delay at the start.
Is there any place else that you experience long times to generate keys?

No, it's OK.
We can close this issue if you want.
Thanks.


Searching matches letters with accents

To repro:

Go to search demo at https://codemirror.net/demo/search.html
Add text with accented letters, e.g. 'thể'
Search for text without the accent, e.g. 'the'
ctrl+g/shift+ctrl+g to skip to the accented text

note that the accented text is not highlighted along with the other matches, but the cursor does skip to it as a valid match.
this seems to be a regression as it was not the case in version 3.21.0 (which I am currently using but trying to update).

I don't think loosely-matched highlighting ever worked—in the past, the main search was strict as well, so the accented form wouldn't match at all, which was more consistent but less usable. Ideally, the highlighting would agree with the matching, but no one has gotten around to implementing loose match highlighting.


Frequent application crashes

I'm on MacOS using latest goneovim (0.6.10). I observe the application crashes pretty frequently. The app will just hang, the cursor will start spinning and there's nothing you can do apart from force killing the app. It usually happens when I try to scroll with the mouse a very large JSX file that goneovim is struggling to render smoothly (i.e. when scrolling, the scrolling will be jerky, the cursor movement will be slow, etc.).

@pjg
I apologize for the inconvenience caused.
To investigate this issue further, I kindly ask for your cooperation with the following:

Could you run Goneovim from the terminal using the --nofork option? If a crash occurs, please provide the backtrace (error message) that is output in the terminal.
e.g.
/Applications/goneovim.app/Contents/MacOS/goneovim --nofork

Regarding the large JSX file, could you let me know the approximate size of the file (e.g., number of lines or file size)?

I'll try running it with the --nofork option. It's not exactly a crash. The app just hangs and I have to force kill it.
The JSX file is not large, perhaps 200-300 lines. Just a lot of JSX tags. Plus my wild vim config.

If I force quit a stalled goneovim, there's no backtrace:
☺ goneovim --nofork                                                                                zsh: terminated  goneovim --nofork

Managed to get the stack trace. Attaching.
GONEOVIM-HANGUP-stacktrace.txt

@pjg
Thanks for the additional info. However, no useful information was found.
I assume the problem is caused by some plugin, and I am trying to reproduce the issue with your settings, but it does not reproduce in my environment.
Just to confirm, would the issue reproduce with the following no Neovim settings?
/Applications/goneovim.app/Contents/MacOS/goneovim -u NONE

When I run your command I get this:
☺ open /Users/akiyosi/debug3.log: no such file or directory

I might be using some daily build though.

@pjg
Hmmm, it is strange to get such a message.
I am wondering about the contents of settings.toml in goeovim.
How about the following command?
/Applications/goneovim.app/Contents/MacOS/goneovim --noconfig -- -u NONE

I've downloaded the official 0.6.10 release and I'm still getting that error when running /Applications/goneovim.app/Contents/MacOS/goneovim --noconfig -- -u NONE:
☺ open /Users/akiyosi/debug3.log: no such file or directory

My ~/.config/goneovim/settings.toml file:
 # goneovim settings

 [Editor]
 # Default/classic vim mode
 ExtCmdline   = false
 ExtPopupmenu = false
 ExtTabline   = false
 ExtMessages  = false

 # Restore last window gemoetry on startup (doesn't seem to work)
 RestoreWindowGeometry = true

@pjg
Sorry, this problem was a bug in goenovim.
It seems that there was some debugging code left over from development.
We have created a corrected property, could you please try the following?
https://github.com/akiyosi/goneovim/actions/runs/12096946155
I am also trying to reproduce the problem with your setup, but it does not reproduce at all on my machine. Could you please tell me what operations you commonly use in your Neovim on a command basis?

Now I can run the application with /Applications/goneovim.app/Contents/MacOS/goneovim --noconfig -- -u NONE but that's not a workable solution. I cannot use vim like this :D
I'm doing anything crazy. Just regular programming. gonevim hangs on mouse movements for me. Once, twice a day. Or once per 2-3 days.

@pjg

Now I can run the application with /Applications/goneovim.app/Contents/MacOS/goneovim --noconfig -- -u NONE but that's not a workable solution. I cannot use vim like this :D

The above is not intended to be a solution, but to see if the problem reported in this Issue can be reproduced with plain nvim without configuration. My intention is to identify the conditions under which the problem occurs, as my expectation is that perhaps a specific plugin is responsible for the occurrence of this event.

I'm doing anything crazy. Just regular programming. gonevim hangs on mouse movements for me. Once, twice a day. Or once per 2-3 days.

Okay, I'll continue my investigation.

FWIW the crashes usually occur when I scroll up/down or sideways. I'm using Apple's Magic Mouse (maybe that's a factor? it's scrolling is kinda different from regular mices).


vdk-control-service: fix ingress template

Why?
The current check always returns false
What?
Change to the property we should actually be checking for
How has this been tested?
I created a helm chart locally which looked like this
apiVersion: v1
kind: ConfigMap
metadata:
  name: test
data:
  apiVersions.txt: |
    {{ .Capabilities.APIVersions.Has "networking.k8s.io/v1"  }}
{{- if .Capabilities.APIVersions.Has "networking.k8s.io/v1/ingress" }}
  blah: hasC
{{- else }}
  blah: noC
{{- end }}
{{- if .Capabilities.APIVersions.Has "networking.k8s.io/v1" }}
  blah2: hasC
{{- else }}
  blah2: noC
{{- end }}

I rendered it with helm by running helm template myhelmchart . The underlying kubectl version was 1.23.x.
the rendered template was:
# Source: apiversiontest/templates/serviceaccount.yaml
apiVersion: v1
kind: ConfigMap
metadata:
  name: test
data:
  apiVersions.txt: |
    true
  blah: noC
  blah2: hasC

This shows that it finds networking v1 but not the ingress version we were using before.
What type of change are you making?
Bug fix
Signed-off-by: murphp15<EMAIL_ADDRESS>

How did you do "I checked the property locally." What commands did you use.
Avoid saying I tested manually or locally but explain what was done locally or manually (e.g what commands, what was verified).

@tozka added more detailed testing description.

@tozka added more detailed testing description.

Thanks.


how to create RestFul API for the plugin created

Is there any way where we can create Rest Ful api for the plugin that we created using in builder plugin?

You can always create whatever you want in your plugin code. See https://octobercms.com/plugins?search=api for plugins that let you generate an API without writing code though


[VS Code] [Audio] Expected 200 status code to get SkypeToken

logs.zip
Error:
Expected 200 status code to get SkypeToken
Steps to Reproduce:

Start collaboration session...
Start audio call...

FWIW, prior to trying this, I uninstalled the Live Share extensions and manually deleted any artifacts in ~/.vscode/extensions/ms-vsliveshare.*.
There is no log output that I can see. There was no way to select Live Share Audio to see any logs.

Version Data

extensionName
VSLS-Audio

extensionVersion
0.1.60

applicationName
VSCode

applicationVersion
1.36.1

platformName
MacOS

platformVersion
18.2.0

@johnschult: thanks for testing this out! To initiate an audio call we need to obtain a SkypeToken.  Unfortunately the failed status code is not currently being logged (I've fixed this for our upcoming next release). In the interim, are you behind a proxy that blocks requests? You would need to be able to connect to the following host in order to obtain the required token:
https://authsvc-server.teams.microsoft.com/v1.0/authz/visitor
You could try the following from a command line to see if you can hit this:
curl -v https://authsvc-server.teams.microsoft.com/v1.0/authz/visitor

Also, I think your output logging looks better now. You will only see the Live Share and Live Share Audio output channels show up when Diagnostic Logging is enabled under Visual Studio Live Share user settings.

@jramsay Sorry for the delay...  One thing I corrected was the proxy server I had configured, I was using one that was not letting me connect to that server. That is fixed. I have the output from the curl command, sadly it is a 404 from MS, is the URL correct?
➜  ~ curl -v https://authsvc-server.teams.microsoft.com/v1.0/authz/visitor
*   Trying <IP_ADDRESS>...
* TCP_NODELAY set
* Connected to one.proxy.att.com (<IP_ADDRESS>) port 8888 (#0)
* Establish HTTP proxy tunnel to authsvc-server.teams.microsoft.com:443
> CONNECT authsvc-server.teams.microsoft.com:443 HTTP/1.1
> Host: authsvc-server.teams.microsoft.com:443
> User-Agent: curl/7.54.0
> Proxy-Connection: Keep-Alive
>
< HTTP/1.1 200 Connection established
<
* Proxy replied OK to CONNECT request
* ALPN, offering h2
* ALPN, offering http/1.1
* Cipher selection: ALL:!EXPORT:!EXPORT40:!EXPORT56:!aNULL:!LOW:!RC4:@STRENGTH
* successfully set certificate verify locations:
*   CAfile: /etc/ssl/cert.pem
  CApath: none
* TLSv1.2 (OUT), TLS handshake, Client hello (1):
* TLSv1.2 (IN), TLS handshake, Server hello (2):
* TLSv1.2 (IN), TLS handshake, Certificate (11):
* TLSv1.2 (IN), TLS handshake, Server key exchange (12):
* TLSv1.2 (IN), TLS handshake, Server finished (14):
* TLSv1.2 (OUT), TLS handshake, Client key exchange (16):
* TLSv1.2 (OUT), TLS change cipher, Client hello (1):
* TLSv1.2 (OUT), TLS handshake, Finished (20):
* TLSv1.2 (IN), TLS change cipher, Client hello (1):
* TLSv1.2 (IN), TLS handshake, Finished (20):
* SSL connection using TLSv1.2 / ECDHE-RSA-AES256-GCM-SHA384
* ALPN, server did not agree to a protocol
* Server certificate:
*  subject: CN=authsvc.teams.microsoft.com
*  start date: Mar 13 00:35:20 2019 GMT
*  expire date: Mar 13 00:35:20 2021 GMT
*  subjectAltName: host "authsvc-server.teams.microsoft.com" matched cert's "authsvc-server.teams.microsoft.com"
*  issuer: C=US; ST=Washington; L=Redmond; O=Microsoft Corporation; OU=Microsoft IT; CN=Microsoft IT TLS CA 5
*  SSL certificate verify ok.
> GET /v1.0/authz/visitor HTTP/1.1
> Host: authsvc-server.teams.microsoft.com
> User-Agent: curl/7.54.0
> Accept: */*
>
< HTTP/1.1 404 Not Found
< Date: Sat, 27 Jul 2019 15:34:26 GMT
< Server: Kestrel
< Content-Length: 0
< Request-Context: appId=cid-v1:a029c606-b560-482a-a6e9-0fe2788cadb0
< Correlation-Id: b5989571-e744-4b1a-adb4-ba214f9301a5
< Correlation-Tags: CorrelationId: b5989571-e744-4b1a-adb4-ba214f9301a5, ClientRequestId:
< Strict-Transport-Security: max-age=31536000; includeSubDomains
<
* Connection #0 to host one.proxy.att.com left intact

Additionally, when I try Start audio call... the error message is now:
Request endCall failed unexpectedly without providing any details.

Hi @johnschult
We have made multiple updates to the Audio extension, I would like to confirm if there are still issues or it is now fixed

I’ll check it out when I am on Corp VPN tomorrow.

Duplicate of #4053


add only first @ as default format

This is probably the most common format at small to medium companies

Thank you very much for the pull request/contribution (adding only first name in initial e-mail formats preprocessing)! I have already applied the change before noticing your open pull request. In any case, I accepted it. Good catch!


Explicit error logging inside jwtTokenExtractor in botframework-connector

Github issues should be used for bugs and feature requests. Use Stack Overflow for general "how-to" questions.
Versions
What package version of the SDK are you using. 4.16 (botframework-connector)
What nodejs version are you using 14.17.1
What browser version are you using N/A
What os are you using MacOS Monterey 12.5.1
Describe the bug
There is an explicit console.error statement here in jwtTokenExtractor. This error is then thrown and handled by us, but the log entry is still made which results in noise in our logs as well as the possibility for triggering associated alarms.
Why is this needed if the error is being thrown and will be logged if not handled by the caller?
Expected behavior
Error is thrown, handling/logging is left to the caller.

@itstaby thanks for opening the issue, you make a good point, I think we can fix this


Authentication Issue

So i am trying to use this is a Blazor Server .Net 8 Project and am having an issue getting the authentication to work. Everytime i try to submit the trade, i receive the Unauthorized response.
I am registering the service like this in my Program.cs
var configuration = new CoinbaseATConfiguration(
    apiKey, apiSecret
);

builder.Services.AddSingleton<ICoinbaseATConfiguration>(configuration);
builder.Services.AddSingleton<ICoinbaseATClient, CoinbaseATClient>();
 // builder.Services.AddSingleton<CoinbaseATClient>();

I am injecting the CoinbaseAtClient like this in my .Razor page:
@inject ICoinbaseATClient CoinbaseATClient

@code {
// ...
var result = await AtService.CreatMarketOrderAsync(Guid.NewGuid().ToString(), crypto.ProductId, OrderSide.BUY.ToString(), order_configuration);
var acct = await CoinbaseATClient.ProductsService.GetProductAsync("BTC-USD");
}

and here is my exception
  ---> System.Exception: Exception of type 'System.Exception' was thrown.    --- End of inner exception stack trace ---    at CoinbaseAT.Services.Abstractions.CoinbaseATService.SendHttpRequestMessageAsync(HttpMethod httpMethod, String requestPath, String contentBody)    at CoinbaseAT.Services.Abstractions.CoinbaseATService.SendServiceCall[T](HttpMethod httpMethod, String requestPath, String contentBody)    at CoinbaseAT.Services.ProductsService.GetProductAsync(String product_id)    at BotTrading.Shared.CryptoComponent.CryptoComponent.SubmitPosition(String orderType, OrderSide orderSide) in C:\Users\Stephanie\source\repos\BotTrading\BotTrading\Shared\CryptoComponent\CryptoComponent.razor:line 123
When i try to query an endpoint that doesnt require authentication i get this error:
System.Net.Http.HttpRequestException: An error occurred while sending the request.  ---> System.Net.Http.HttpIOException: The response ended prematurely. (ResponseEnded)    at System.Net.Http.HttpConnection.SendAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)    --- End of inner exception stack trace ---    at System.Net.Http.HttpConnection.SendAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)    at System.Net.Http.HttpConnectionPool.SendWithVersionDetectionAndRetryAsync(HttpRequestMessage request, Boolean async, Boolean doRequestAuth, CancellationToken cancellationToken)    at System.Net.Http.DiagnosticsHandler.SendAsyncCore(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)    at System.Net.Http.RedirectHandler.SendAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)    at Microsoft.Extensions.Http.Logging.LoggingHttpMessageHandler.<SendCoreAsync>g__Core|5_0(HttpRequestMessage request, Boolean useAsync, CancellationToken cancellationToken)    at Microsoft.Extensions.Http.Logging.LoggingScopeHttpMessageHandler.<SendCoreAsync>g__Core|5_0(HttpRequestMessage request, Boolean useAsync, CancellationToken cancellationToken)    at System.Net.Http.HttpClient.<SendAsync>g__Core|83_0(HttpRequestMessage request, HttpCompletionOption completionOption, CancellationTokenSource cts, Boolean disposeCts, CancellationTokenSource pendingRequestsCts, CancellationToken originalCancellationToken)    at CoinbaseAT.Services.Abstractions.CoinbaseATService.SendHttpRequestMessageAsync(HttpMethod httpMethod, String requestPath, String contentBody)    at CoinbaseAT.Services.Abstractions.CoinbaseATService.SendServiceCall[T](HttpMethod httpMethod, String requestPath, String contentBody)    at CoinbaseAT.Services.ProductsService.GetProductAsync(String product_id)    at BotTrading.Shared.CryptoComponent.CryptoComponent.SubmitPosition(String orderType, OrderSide orderSide) in C:\Users\Stephanie\source\repos\BotTrading\BotTrading\Shared\CryptoComponent\CryptoComponent.razor:line
I have already verified that my apiKey and apiSecret are correct and that they are being passeed into my CoinbaseATConfiguration, I am able to do api calls with these same credentials with another library package. I cant figure out what is causing this.  I have the same problem in both the razor file and in the service file.
I even tried it with the ICoinbaseAtClient for good measure, and tried registering the CoinbaseAtClient independntly as well in my Program.cs to no avail. Do you have any hints on what could resolve this issue? I really love the project and how thourough it is i do not want to remove it because nothing else is this complete. Very nice work, and thank you for any help you can offer!

recently i have not shown this project the love it deserves. i'll take a look in this direction when i get a moment. i have to finish clocking in my hours first. 😎

you're amazing cant believe how fast you were! looking forward to hearing what you come up with.

😊 thanks. i can get to this after thursday

it turns out i was having ip whitelisting issues.
for anyone's information, the ip whitelist field when generating api keys can be left blank to impose no restrictions


GraphQLClient subscription will lost when re-connected to server

What Happened
In some reasons, I required to write my script through GraphQLClient and develop using Query, Mutation, Subscription. When I developing the subscription I found that when every connection closed and after re-connect, it didn't pass any query operation(StartOperation) to the server. Therefore, everything will no longer be received from the server.
Expected behavior
On re-connected will also able to receive the message from the server.
Version

graphql v2.0.1

Additional context
I also checked the source code and found the reason happened in this line.
https://github.com/zino-app/graphql-flutter/blob/master/packages/graphql/lib/src/socket_client.dart#L254
If this line has gone, everything's works fine.

@ryanz1219 can you try and the beta version and see if you still experience the issue

I've tried the 2.1.1-beta.2  and I got the same behavior.
I'm checking this printing something in the onConnect callback. The first time I see how the it's called, but if I make the device lost connection and then connect it again, onConnect is never called

I've found it's the same issue as https://github.com/zino-app/graphql-flutter/issues/356

@gepd have you found solution?

I've not found a solution yet, I'm looking for something though

I have been away for the last week, I will look into this sometime over the weekend or next week. I am open for any suggestions.

cannot the streamController in the subscribe method (#L238) to reconnect too instead of only close the connection?

I don't know is it have other effects that will cause by removing line 254 in the before I said, but I am trying to remove this line because SocketClient._connect() called at the beginning and _connect() will auto re-connect the server according to the same file at line 140.
However, the connection is reconnected by line 140 but It didn't resend the previous GraphQL operation to the server so the WebSocket is connected, graphql operation isn't started in server cause by request isn't sent.
I hope this information will helpful for this problem.

cannot the streamController in the subscribe method (#L238) to reconnect too instead of only close the connection?

I think it can't because the subscribe method is directly called by the user so if reconnect it, then the user will be required to reload their subscription callback also.
In addition, the streamController doesn't know any network status of the connection at now. streamController depends on _connectionStateController to receive a new message for itself.
As my knowledge :)

Hey @mainawycliffe have you been able to check this? If so, what are your thought about it? It seems like it isn't an easy fix without breaking the current functioning

I am sorry, this is another that slipped my radar. I am thinking we could probably have a queue for all Subscription operations and upon reconnection, retry them again. When the connection fails, does it send an error and close the subscription? I currently don't have any way of testing this, so I will have to create a demo to see this behavior my self.

I tweaked it for my project a few months ago until waiting for this to be fixed. Not perfect solution, but may be helpful
https://github.com/EugenePisotsky/graphql-flutter/commit/57f64c37fdc895d822d0c713b3c7d21630613498
Idea is to create map of subscriptions, and callbacks that call response.onListen each time after websocket connection is restored

@EugenePisotsky If it's already working for you, can you PR the change and we will review and merge it. Here are our contributing guidelines.

@mainawycliffe Ok, I'll try to find time within the next few days

@EugenePisotsky did you get a chance to get a PR in for this? Subscriptions are pointless without it.

@kulture-rob
done. if someone has a better solution it would be awesome :)

:tada: This issue has been resolved in version 2.1.1-beta.5 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

I am closing this issue, the PR has been released to the latest beta.

:tada: This issue has been resolved in version 3.0.0-beta.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 3.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Rule: boolean-assignment

Avoid
is_snake_case(str) := str == lower(str)

Prefer
is_snake_case(str) if str == lower(str)

Controversial, perhaps? 😅 Just finding a few of these myself in Regal's codebase, and I'd like to be made aware of them, as the assignment is almost always redundant, and leaning in on undefined should be considered idiomatic.
The rule could also check for assignment from boolean functions:
allow if {
	sw := startswith("f", "a")
	# ...
}

But perhaps that should be a different rule? 🤔

@srenatus @charlieegan3 WDYT?

Controversial, perhaps?

Yeah, a bit. It think this is a style preference... so I guess if teams can come to the agreement that they'd like a consistent style, it would make sense to have a rule. But since it's stylistic, I could even see Avoid/Prefer swapped if that's your choice 🙃 🔀

Yeah, a bit. It think this is a style preference

To some degree, yes, but I think the difference to me is "do you understand undefined or not", and passing around boolean values would indicate that maybe you don't, which is why I was leaning towards this being in the idiomatic category. But it's not a hill I'll die on :)

It seems like my ideas aren't getting traction, but I'm a merciful ruler, so I'll update the category to style.

Got code for this now and ran it against 10 popular policy repos. Very few violations, and max 3 in any given repo. So I'm back to saying this is idiomatic.


refactor: remove assertions in force plot, test verify_valid_cmap

Overview
This PR is part of a larger effort of refactoring _force.py and _force_matplotlib.py. This PR covers some of the smaller / non-functional changes, so we can focus on the core functionalities in the following PR.
Description of the changes proposed in this pull request:

Removed most assert statements for enforcing logic, as it is not good practice. The only exception is the use of assert to test for IPython to be installed. (No strong reason for this, if there is a more suitable Exception type suggested, I can change it).
Added a set of tests for verify_valid_cmap() function (defined inside _force.py). To ensure no errors are introduced in the refactoring.
Add docstrings for some functions in _force.py.
Re-use an existing getjs() function to read the js bundle (DRY principle).
Added docstring for initjs(), just a quality-of-life improvement.

Checklist

[X] All pre-commit checks pass.
[X] Unit tests added (if fixing a bug or adding a new feature)

Removed most assert statements for enforcing logic, as it is not good practice

I agree asserts aren't good practice for cases where we expect the exception could be reached by the calling code, for example validating bad inputs. I think that's the case in the PR, so I agree with you here 👍
However, personally I think asserts can be helpful in other contexts, so I'd be wary of declaring them Bad Practice overall. Specifically for checking our internal logic, in cases where the assert statement should always pass unless we have any bugs. It can make debugging issues easier and can also serve as documentation of any assumptions we have about the state of any variables.

@thatlittleboy it would be good to get this one finished off in time for our next release, if you have time this week to look at the comments above?

@connortann Thanks for the comments, I made changes accordingly, please take a look when you get back.

LGTM!


Revert a previous change that cause two of itwin.js test to fail

After investigation, it turns out, the behavior documented by the test was incorrect.
DbConflictCause.NotFound - deleted row
The test check if we force an orphan row in change set, then anyone pulling it should see FK violation.

b1, b2 start off with an element el1
b1 delete el1.
b2 insert aspect for el1
b1 push OK
b2 pull/merge (test force to ignore conflict of type CONSTRAINT)
b2 push just the aspect with no parent element.
b3 pull all changes and it should see two conflict

NOTFOUND bis_Element (as el1 does not exist
FKVOILATION as bis_MultiElementAspect has orphan row with no parent.

Before SQLite update, we did not see FKVOILATION and only saw NOTFOUND.
aspect insert, update & delete requires exclusive lock
This test check if appropriate lock is needed to insert/update/delete aspect.
After the operations on b1 & b2, we should never have pushed any change that resulted in a conflict handler being called. Since we acquire locks and all insert/update/delete were serialized when pushed.
imodel-native: https://github.com/iTwin/imodel-native/pull/881

/azp run itwinjs-core

@aruniverse @DanRod1999 @khanaffan Can we completely disable these failing tests that are blocking all PRs until a proper fix can be worked out?


[TA] Renaming for Dynamic classification and API changes.

Description

Removed BooleanResolution
Make BaseResolution abstract class
Renamed dynamicClassifcationXXX name phrases to dynamicClassfifyXXX

All SDK Contribution checklist:

[ ] The pull request does not introduce [breaking changes]
[ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
[ ] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-ai-textanalytics


[SDL2] Add support for SDL_WINDOW_FULLSCREEN_DESKTOP flag

...if possible. It needs changes in SDL_video.c at least.

Moved to https://github.com/AmigaPorts/SDL-2.0/issues/17


image handling

Check if image2 inputs use looping or not, and set duration to infinity if needed

Great, thanks for the quick feedback!


FTP over time set to current date and forward.

When my FTP changes, this seem to be added to all the previous workouts, and change the entire chart.
When I measure my FTP today, it dident change my FTP in the past...

Duplicate of https://github.com/thomaschampagne/stravistix/issues/332
It's a know issue. Strava lacks of persisted physical data to handle that problem.
I cover this problem this year with my own solution that store athlete physical data over time. To pick and choose the right data for each activity calculated


CreateUser

I can not find functionality of creating user in client.

You're right, in the client there is no place where You can create a user, the only way right now in this repo is by loggin in, and in hooks.server.ts by Auth request. But nothing stands in Your way to add this functionality in client :) Everything should be ready on users service side.


Track upstream aws_s3_bucket_logging bug report and remove workaround

Persona

Maintainer
Description

Need to monitor this issue for provider updates/fixes
https://github.com/hashicorp/terraform-provider-aws/issues/31139
Use Case

Will remove (future) barnacles when issue is resolved
Impact

Barnacles in test pipeline
Completion

Provider is fixed
We update version in our codebase
Remove retry logic in terratest
No more intermittent errors in pipeline due to aws_s3_bucket_logging resource

Additional Context
related: https://github.com/defenseunicorns/delivery-aws-iac/issues/207

Barnacle verbiage: unnecessary or outdated code/features

@zack-is-cool can this be closed now?

not quite. We need to do the things under Completion in the issue ^
so far step 1 has happened


injectDomainIntoWorkflowList fails to handle null

injectDomainIntoWorkflowList encounters the following error when executions list returned is null

Cannot read property 'map' of null

Current implementation only handles the case when executions is undefined

Hi @sokada1221 , I believe you are right. I will write a unit test which proves your point and proceed with a fix.
Thanks!


Replace Godep by Glide

dependencies: replace godep by glide
glide is more usable and more flexible than godep
Moreover, a slice change in the travis file to allow Travis build from fork

Awesome. As soon as the two commits having the same comment have been squashed, let's merge!

Thanks!


Make WELL_KNOWN constant public

I'd like to make WELL_KNOWN a public constant. This is useful because it means that there is a source of truth for this value.
In practice, this improves our test code because we no longer have to hard code this magic constant.

AFAICT, the Java14 build is broken irrespective of this change.

AFAICT, the Java14 build is broken irrespective of this change.

I fixed this in #438, so once we merge that, this issue should resolve for you.


Updates to Dockerfile.

Switches to debian:stretch instead of ubuntu
Adds i386 support to support building gdx-controllers-desktop
Adds armhf/arm64 toolchains to support arm builds.

Untested, pulled from my notes, I don't have docker installed to test.

Sounds cool!
might be usefull for libgdx/libgdx#5556


bug(ssh):  Panic error occurs when exiting within the env container

Description
Error mesage:
[127:NOTFOUND] ⬢ [envd]❯ exit
exit status 127panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x2 addr=0x0 pc=0x105492720]

goroutine 1 [running]:
github.com/tensorchord/envd/pkg/ssh.generalClient.Attach({0x14000053130?, 0x14000c7c240?})
        github.com/tensorchord/envd/pkg/ssh/ssh.go:247 +0x500
github.com/tensorchord/envd/pkg/envd.dockerEngine.Attach({0x1?}, {0x0?, 0x140001fa310?}, {0x1055a2b63, 0x9}, {0x14000040b10?, 0x1400007dbc0?}, 0x105a3d278?, {0x14000153600?, 0x140002b2960?})
        github.com/tensorchord/envd/pkg/envd/docker.go:272 +0xf4
github.com/tensorchord/envd/pkg/app.up(0x14000619f80)
        github.com/tensorchord/envd/pkg/app/up.go:237 +0xae8
github.com/urfave/cli/v2.(*Command).Run(0x1061f0d00, 0x14000619f80, {0x14000119610, 0x1, 0x1})
        github.com/urfave/cli/v2@v2.23.7/command.go:271 +0x78c
github.com/urfave/cli/v2.(*Command).Run(0x14000179540, 0x140006194c0, {0x14000134000, 0x2, 0x2})
        github.com/urfave/cli/v2@v2.23.7/command.go:264 +0x9ac
github.com/urfave/cli/v2.(*App).RunContext(0x140000fe5a0, {0x105a33070?, 0x1400012e008}, {0x14000134000, 0x2, 0x2})
        github.com/urfave/cli/v2@v2.23.7/app.go:333 +0x5dc
github.com/urfave/cli/v2.(*App).Run(...)
        github.com/urfave/cli/v2@v2.23.7/app.go:310
main.run({0x14000134000, 0x2, 0x2})
        github.com/tensorchord/envd/cmd/envd/main.go:39 +0x104
main.main()
        github.com/tensorchord/envd/cmd/envd/main.go:67 +0x30

Reproduction
This appears to be an occasional error. Actually, I don't know why there is a 127 exit code here.
But it can be reproduced by killing the zsh process inside the container.
Additional Info
envd version: latest main branch

Message from the maintainers:
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

It looks like that this issue is caused by a mistake here:
https://github.com/tensorchord/envd/blob/aae5e27feaa06436fa81c3dc414b28b6b7e21a3b/pkg/ssh/ssh.go#L246-L248
I would like to open a PR to try to fix this