<EMAIL_ADDRESS>requires a peer of inquirer

Expected Behavior
Errorless install of clasp
Actual Behavior
Installing clasp results in this error:
sudo npm i @google/clasp -g
/usr/bin/clasp -><EMAIL_ADDRESS>npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS>|| ^6.0.0 but none is installed. You must install peer dependencies yourself.

+<EMAIL_ADDRESS>added 189 packages from 116 contributors in 11.015s

Steps to Reproduce the Problem

sudo npm i @google/clasp -g

Specifications

Node version (node -v): v13.8.0
Version (clasp -v): 2.3.0
OS (Mac/Linux/Windows): Linux (Ubuntu 19.10)

fixed in #733
@imthenachoman  Wait for the next release.

@takanakahiko Got it. Thanks! Sorry if this was mentioned somewhere. I did a search but didn't find any existing issues/comments.

So claps 2.3.0 can not be used ?

This peer dependency warn can probably be ignored and @google/clasp should work.
Alternatively, you can try the unofficial 2.4.0 build
npm uninstall -g @google/clasp && npm install -g forked-clasp
clasp --version
# should be 2.4.0 or more

Last, only sudo an npm install if it fails without sudo...

Thank you.  Ignoring the dependency warning turned out to be alright.  Had no issues using CLASP after installing it and didn't need to install the dependency.

I received same error on macOS Catalina. Ignoring the dependency warning also turned out to be alright. I will be testing it further.

How can we remove this error for now?

Same issue here on Windows 10 (2004),
node version: v14.15.1
version: 2.3.0
2020-12-04

This is a warning that can be safely ignored.
Also you can try this forked npm package
https://www.npmjs.com/package/forked-clasp
or from the github repository
https://github.com/PopGoesTheWza/clasp/tree/forked

Try replacing @google/clasp 2.3.0 with forked-clasp which is more advanced.
npm uninstall -g @google/clasp
npm install -g forked-clasp

Fixed in https://github.com/google/clasp/releases/tag/v2.3.1

@PopGoesTheWza thank you for you hard work


Issue 14320 - Improve diagnostic message for "undefined identifier" error

https://issues.dlang.org/show_bug.cgi?id=14320
Some existing diagnostic test cases will be expectedly changed. Therefore adding a new test case for issue 14320 is not necessary.
And also, quote undefined identifiers in the diagnostic messages for the readability and consistency.

Ready to merge.

Auto-merge toggled on


fix: cannot delete the model with operation not permitted

Fixes #730
What does this PR do?
Fixes error spawn when deleting a just downloaded model on Windows
Screenshot / video of UI
N/A
What issues does this PR fix or reference?
#730
How to test this PR?

Download a model
Once it is downloaded, delete it

What was the root of the issue ? I am not sure to follow why it fixes the problem to just move it inside the on callback ?

The file was opened twice: the first time when the redirect response was received (we opened the file but to do use the handle so it stays open) and a second time after the redirection is processed. So at then end the second handle is closed but not the first one. The path delay the creation of the handle when it's really needed

What was the root of the issue ? I am not sure to follow why it fixes the problem to just move it inside the on callback ?

The file was opened twice: the first time when the redirect response was received (we opened the file but to do use the handle so it stays open) and a second time after the redirection is processed. So at then end the second handle is closed but not the first one. The fix delay the creation of the handle when it's really needed

But, this is only valid for the .tmp file, as when the download is finish we rename it. The deletion issue was on the renamed file ?

What was the root of the issue ? I am not sure to follow why it fixes the problem to just move it inside the on callback ?

The file was opened twice: the first time when the redirect response was received (we opened the file but to do use the handle so it stays open) and a second time after the redirection is processed. So at then end the second handle is closed but not the first one. The fix delay the creation of the handle when it's really needed

But, this is only valid for the .tmp file, as when the download is finish we rename it. The deletion issue was on the renamed file ?

Yes but it fixes the issue so I think Windows is now smarter than it was and it moves the open handles to the renamed file


Yahoo 11 facts prototype

The basic functionality should remain the same for larger (desktop sized) screens
On mobile sized screens we want to serve a different yahoo-theme CTA, as well as the 'explore campaigns button' point to a yahoo link with a pre-filled search query

I nominate the 11 facts about volcano page, because it has the same nid on dev/stage/prod
node/176
cc @mshmsh5000 @namimody

Hi @angaither! Behavior sounds correct. Just a couple of clarifying points because I just want to make sure I fully understand --
this will only happen on staging for tomorrow and both the top and bottom CTA link will change on the smaller screen?
Thanks!

@namimody yep. it will be up on staging by tomorrow and we will switch out the top and bottom CTA's on mobile.
One question - what's the rule for the pre-populated search link, is it the cause term?

Amazing -- thanks for the clarification @sbsmith86! The rule for the pre-populated link is a bit up in the air because a few approvals have yet to be given -- but what is guaranteed is that we'll know which keyword is associated with each facts page (they vary based on what keyword will yield results with few ads) and how all the URLs are configured. Is that helpful?

@namimody hmm i guess i mean how do i know how to build out the custom cta link for this prototype i.e. https://search.yahoo.com/do?p=animals
Does the p=animals correlate to the cause term on the node? So if we do volcanos, it would be https://search.yahoo.com/do?p=environment?

@sbsmith86 for the prototype, you can link to: https://search.yahoo.com/search;_ylt=A0LEV1PdFwNW2ukAuyel87UF;_ylc=X1MDOTU4MTA0NjkEX3IDMgRmcgMEZ3ByaWQDMHVnUmhsV0lSMi5WWFZ1NWhWQVE2QQRuX3JzbHQDMARuX3N1Z2cDOQRvcmlnaW4Dc2VhcmNoLnlhaG9vLmNvbQRwb3MDMARwcXN0cgMEcHFzdHJsAwRxc3RybAM3BHF1ZXJ5A3ZvbGNhbm8EdF9zdG1wAzE0NDMwNDMyOTg-?p=volcano&fr=sfp&fr2=sb-top-search&iscqry=
for the entire partnership, we'll have a spreadsheet like this (not final): https://docs.google.com/spreadsheets/d/18XMsv8MGZlP1t2gTWumpCdfj24h8yvJHkccSjZ0hfZw/edit#gid=1825152800 that each page will need to pull from accordingly. let me know if you want to chat in person at all!

@namimody makes sense. thankkks!

@namimody looks like it's just searching for the title, correct?

@angaither for the title of the 11 Facts page? not always. generally, the Yahoo team suggests querying things like "facts about volcanoes" because that yields searches with less ads. Then, there are some pages, like ones about women in tech (oh heyyy) which are going to throw to search results for Megan Smith. Long and short -- the logic will need to consult the list for each fact page.

And it's captured in a feature flag! :100:


TreeView icons are still using the "no entry" icon compared to the design

What are you generating using Kiota, clients or plugins?
API Client/SDK
In what context or format are you using Kiota?
Nuget tool
Client library/SDK language
None
Describe the bug

Expected behavior

How to reproduce
Load an API description and select some nodes
Open API description file
No response
Kiota Version
1.18
Latest Kiota version known to work for scenario above?(Not required)
No response
Known Workarounds
No response
Configuration
No response
Debug output
Click to expand log
```

</details>

### Other information

_No response_

Copied the ACs from the duplicated issue:

All non-selected paths shouldn't have any icon but a blank space for the future check icon needs to be kept.
The indentation should still follow the current experience, so we don't confuse users when the ✅ icon is added, making the tree view hard to follow.
When creating a new plugin/client or just exploring an API, the OpenAPI should be loaded in the API explorer with no selected path.
When regenerating an existing plugin/client, the API should be loaded based on the current include/exclude paths and the right icons.


Cartoonifying

Related Issuse or bug

Info about Issue or bug

Fixes: #[issue number that will be closed through this PR]
Proposed Changes

Info about changes Goes here

Additional Info

Anything related Issues

Screenshots

Original
Updated

original screenshot
**updated screenshot **

@SoyabulIslamLincoln like i have done this from my side

You did a small mistake like you tried to merge it in your master branch

Hii in readme file i can see no such difference in two images
Can you please look at that issue and update it

Okay. I am getting onto it right away.


controlplane: implement a simple Ednpoint selection. Implements 534

This implements an exact match when requesting a NSE selection.
Based on PR https://github.com/ligato/networkservicemesh/pull/537

I rebased on #537 to make this easier to review :)

Re selectors: see:
https://github.com/ligato/networkservicemesh/blob/1cc12b71b7ca2a2c330c66ead88f20f6213fcd67/controlplane/pkg/selector/selector.go
https://github.com/ligato/networkservicemesh/blob/1cc12b71b7ca2a2c330c66ead88f20f6213fcd67/controlplane/pkg/selector/round_robin_selector.go
https://github.com/ligato/networkservicemesh/blob/1cc12b71b7ca2a2c330c66ead88f20f6213fcd67/controlplane/pkg/model/model.go#L225
and
https://github.com/ligato/networkservicemesh/blob/1cc12b71b7ca2a2c330c66ead88f20f6213fcd67/controlplane/pkg/nsmd/network_service_server.go#L59

Curious, how have you tested this?


Update README.md

Added link to doc, so it will be easier to find what's that project for without googling beepsend (also convenient to have link to docs here)

@soderwall ping
anyone alive here? Just interested in acceptance of potential future pull requests

Made https!


MCMC sampler now adds a barostat if pressure is specified

This is the simplest possibility from https://github.com/choderalab/perses/issues/225#issuecomment-253998035

Fixed.

Thanks!


Allow preferred Alert button regardless of the style

Summary
See https://github.com/facebook/react-native/pull/32538 for the discussion
cc @robbie-c
Changelog

[iOS] [Fixed] - Allow preferred Alert button regardless of the style
Test Plan
Same test plan as PR mentioned above

Oops, wrong repo 😅


Added Sass variables for the button components

I tried to make the existing variables more consistent as well for example we had:
$button-floating-size but $button-color-raised.
I made them all $button -  - .

for the background-color property I got inspired by  foundation and replaced:
$button-bg-color by $button-background
Background is one of the only css property we were shortening to bg.

Please let me know what you think of the changes in general.
This way we can agree on some general principles before I start adding variables to the other components.

The changes look good, I still need to check out the changes to make sure nothing was accidentally changed.
I like the naming convention you used where you have color at the end, but you had it reversed in a few cases,
$button-background-disabled: #DFDFDF !default;
$button-color-disabled

Looks great and thorough. Thanks!


Implement FieldOrderElements for BLS12-381

This is the first of a set of PRs to implement BBS signatures. I have broken it up to help with PR review instead of submitting one big PR.

@mikelodder7 @dhuseby @dcmiddle @hartm Do you think it would be good to include this AMCL Rust wrapper in Ursa https://github.com/lovesh/amcl_rust_wrapper? It has better abstraction and some more algorithms.


Follow paramter support

Hi Michael, great work :)  Have you considered adding support for "follow"?  I'll have a crack at this weekend, but I don't think it'll be good enough to merge...

Thanks, no I have never needed to use that parameter myself, so I didn't add it. I think it would make sense though, so I'd be happy to add it in if you get it working, or close to working.


update rich

Codecov Report

Merging #21 (5c30919) into master (89430d7) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #21   +/-   ##
=======================================
  Coverage   91.08%   91.08%
=======================================
  Files           6        6
  Lines         774      774
=======================================
  Hits          705      705
  Misses         69       69

Impacted Files
Coverage Δ

treeo/__init__.py
100.00% <100.00%> (ø)

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


Windows MSVC with shared libraries

In Windows with Visual Studio 2019, BUILD_SHARED_LIBS option active, I receive an error when compiling because bcrypt.lib is not created. This impedes using the library in larger projects where the library should be built as shared library.

Given the fact that this is a library consisting of one .hpp and four .c files, could you provide a PR for the build process to do this?

I just merged a PR with support for visual studio 2019. Could you try again?

Now it generates bcrypt.lib but when I look in the project properties I see that the library is generated as static library. Moreover I would like to generate the project myself only from the CMakeLists.txt file. At them moment when generating project from CMakeLists.txt it does not create bcrypt.lib (with BUILD_SHARED_LIBS flag)

What is the role of the .S file there ? I think that without it I can manage to generate .lib for shared library with MSVC.

The file seems to be used only for i386 architecture. For my needs (x86_64) I can ignore it and try to do without it. I will let you know how that worked.

I would suggest adding a cmake variable for compiling the i386 version. When the flag is not active one could active the export of all simbol for windows. This will allow compiling as shared library with Msvc. For the remaining case I do not know. Maybe some one has an idea.


Drop 'else' condition when 'if' ends with a return

This commit drops the else condition when the if block ends with a
return statement.

Thanks!


Closes: #1 Updates validations.py

Update validations.py
Fixes #1

It's a good idea to open an issue first for discussion.

[ ] Tests pass
[ ] Appropriate changes to README are included in PR

Try out the comments


mbedtls_ssl_get_record_expansion() returns wrong result for CBC suites in TLS >= 1.1

Description

Type: Bug
Priority: Minor for 2.12.0, Major considering the use of mbedtls_ssl_get_record_expansion() in #1879

Bug
OS
All
Mbed TLS build:
Version: all versions supporting (D)TLS 1.1 or higher.
Configuration: Any configuration allowing (D)TLS 1.1 or higher.
Description
The public function mbedtls_ssl_get_record_expansion() is supposed to return the maximum difference between the length of a protected record and the length of the plaintext it encapsulates, with respect to the currently enabled outgoing record protection.
int mbedtls_ssl_get_record_expansion( const mbedtls_ssl_context *ssl )
{
    size_t transform_expansion;
    const mbedtls_ssl_transform *transform = ssl->transform_out;

#if defined(MBEDTLS_ZLIB_SUPPORT)
    if( ssl->session_out->compression != MBEDTLS_SSL_COMPRESS_NULL )
        return( MBEDTLS_ERR_SSL_FEATURE_UNAVAILABLE );
#endif

    if( transform == NULL )
        return( (int) mbedtls_ssl_hdr_len( ssl ) );

    switch( mbedtls_cipher_get_cipher_mode( &transform->cipher_ctx_enc ) )
    {
        case MBEDTLS_MODE_GCM:
        case MBEDTLS_MODE_CCM:
        case MBEDTLS_MODE_STREAM:
            transform_expansion = transform->minlen;
            break;

        case MBEDTLS_MODE_CBC:
            transform_expansion = transform->maclen
                      + mbedtls_cipher_get_block_size( &transform->cipher_ctx_enc );
            break;

        default:
            MBEDTLS_SSL_DEBUG_MSG( 1, ( "should never happen" ) );
            return( MBEDTLS_ERR_SSL_INTERNAL_ERROR );
    }

    return( (int)( mbedtls_ssl_hdr_len( ssl ) + transform_expansion ) );
}

In (D)TLS 1.1 or higher, CBC ciphersuites use an explicit initialization vector at the beginning of the record which is not taken into account in
        case MBEDTLS_MODE_CBC:
            transform_expansion = transform->maclen
                      + mbedtls_cipher_get_block_size( &transform->cipher_ctx_enc );

In total, there are three components contributing to the expansion: Pre-expansion due to explicit IV, post-expansion due to MAC, post-expansion due to padding.

Impact
Currently, there is no internal impact on the library as Mbed TLS does not use mbedtls_ssl_get_record_expansion(). However, PR #1879 starts to make use of mbedtls_ssl_get_record_expansion() to deduce the maximum plaintext length from the maximum MTU, and miscalculation will lead to Mbed TLS not obeying the MTU.

ARM Internal Ref: IOTSSL-2462

This issue has been fixed in PR's #1915 and back ports #1959 and #1960, which have now been merged.


Rename invoke_without_command to something else and maybe change the default value.

Link
https://github.com/Rapptz/discord.py/projects/3#card-58810568

Please close this if you find it confusing, it seems confusing for me too, that's why I opened the issue as ported.

kinda unnecessary breaking change


[AutoPR cosmos-db/resource-manager] Cosmos Python

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/6172

This PR has been merged into https://github.com/Azure/azure-sdk-for-js/pull/3361


Add the endpoint to the 404 message

It would be helpful if this message could include the endpoint that is not found.

I'm trying to think how we would want to word this to include the endpoint. Should I just add the endpoint on a second line? or replace  "Elyra service" with the endpoint?

How about?
Error contacting server
Endpoint '/whatever/endpoint' not found.

that looks good to me, I'll make the change once I'm done reviewing other PRs


process mount mode does not work

POD_NAME is not set when using process mount mode: https://github.com/juicedata/charts/blob/9a907807d321830cffaed448c3e906e9b7027e8c/charts/juicefs-csi-driver/templates/controller.yaml#L50
But csi-driver does nothing when POD_NAME is not set: https://github.com/juicedata/juicefs-csi-driver/blob/afb8cf3de13e8c76a3f3ee79d038eaf3e9f2960d/cmd/main.go#L78

Hi @jgillich , what problem have you met?

So as you pointed out, I probably don't want to be using process mode
But this issue is of a different nature, when the chart is deployed with mountMode: process (without provisioner or any other options), it generates CSI controller/node pods that do nothing whatsoever, they simply exit with status 0 right away. This is because the csi driver only does something if POD_NAME is set.


Nested expand field

#8061 #6844

Tried locally and it works. Also, looking good! Thanks @mdmunir. Hope it gets merged soon :)

nice feature @mdmunir but is there a way to control authorization ? I mean when used to navigate where we are not authorized to like: /item?expand=cart.owner.account

otherwise I think it should be disabled by default to be implemented after unsetting related fields within the checkAccess method.

@tunecino the problem with this kind of design is that the fields are declared inside a model instance...
i would like to see somebody implement another layer for this one to implement in controller level wherein it can filter by user's credentials which expand it can see or not...
it can still be done via the model to some degree...
i just have a subclass of my main model that does the check

I think you are right @fernandezekiel.
Other thing that may help solving this could be by first solving Nested Urls. then we can also have something that works like scenarios in model::rules to control fields expanding. like when doing for example GET /carts/2/orders/4 we can easily have pre-setted conditions on fields to auto expand some related relations like the data in the juction_table between both models.
I think I have few ideas on implementing nested urls via a custom UrlRule class. I'll start by that. maybe an extension. if it works we can implement similar thing to the framework. if it dosent, who knows, maybe we help influencing others on figuring out a good solution.

the issue is related here though
https://github.com/yiisoft/yii2/issues/7098

i have some implementation of this one already, although it kind of makes me re-declare the mapped return fields in the controller...
i can make the usage also that if it's not declared in the expandDependency that it will not be in the response...
i also use this for eager loading or callbacks for the query object if a field was requested in the expand

    /**
     * usages:
     * 1. declare the expand field itself as the array value without a string pair, example: location
     * 2. declare the expand field by key value pair , the key will be the expand field requested and the
     * value can be a string or an array of the needed relations to be eager loaded, example: 'created_user' => 'createdUser',
     * 'is_deletable' => ['productAchPv', 'productGateway']
     * 3. declare the expand field wherein the other value is a callable that accepts query as a parameter and will return
     * the query object
     * ~~~
     * return [
     *      'location', 'created_user' => 'createdUser',
     *      'is_deletable' => ['recurrings', 'projects'],
     *      'special_field' => function ($query) {
     *          return $query;
     *      }
     * ];
     * ~~~
     * @return array
     */
    public function expandDependency()
    {
        return [];
    }

Won't make it into 2.0.


Re-apply 2 backup/master pull requests to staging if necessary

Please see the following commits:

[ ] https://github.com/freeCodeCamp/freeCodeCamp/commit/9142aec8ad118fa4881a82a731e5d5c3ffc9752f

[ ] https://github.com/freeCodeCamp/freeCodeCamp/commit/505778acbf4b6ecf4b79941590714c854b2cf78c

These were applied to backup/master branch, but not staging. If any of this code needs to be added to staging, we should do so. Otherwise we can close this issue.
@raisedadead may I defer to you on this? I believe you're the most familiar with our authentication and linking logic.

Sure, I'll take care of these. Thanks for looping me in.

@QuincyLarson quick query, can you guide with the verbiage that you would want from here:
https://github.com/freeCodeCamp/freeCodeCamp/blob/505778acbf4b6ecf4b79941590714c854b2cf78c/server/views/resources/unsubscribed.jade#L5-L10
Obviously this one from production is no longer relevant/updated, for beta.

I am back porting other code logic. PR is WIP.

I'm closing this issue as stale since it hasn't been active lately. If you think this is still relevant to the newly updated platform, please explain why, then reopen it.


Is there an option to read journald without a file? (basically tail journalctl output)

We would like to start using npd in our environment. However, the way our logging architecture is designed- we're not storing any logs locally. We have a syslog-ng client that tails journalctl output and forwards it to our syslog server without storing any local copies. Hence it seems like npd can't really read all these events. I tried to go through the documentation but didn't find anything that could be relevant to our scenario. Did I miss something? Is there a way to accomplish what I'm looking to get?
Thanks!

@MoShitrit Sorry for the delay.
Yes. npd has support for reading directly from journald. Actualy npd support both read kernel log from a file or journald. Please take a look at this the files under config. Especially https://github.com/kubernetes/node-problem-detector/blob/master/config/kernel-monitor.json

Thanks @andyxning !
I see indeed that kernel messages are flowing in to the kube-apiserver, however I was more curious regarding other logs such as Docker log and so on. We don't maintain any local log file such as /var/log/messages or /var/log/docker/docker.log and so on, they are all part of journalctl and are being forwarded directly to our syslog server. Does npd support tailing journalctl output for these logs as well?

Does npd support tailing journalctl output for these logs as well?

I am afraid not. NPD uses github.com/coreos/go-systemd/sdjournal package to read from journald. http://www.freedesktop.org/software/systemd/man/sd-journal.html seems to read local disk journal files to parse according to the sd-journal.html.

I see, thanks for your response!


echo: Some minor changes to options

Changed from static to const.
Added alternative usage, see GNU echo.
Do not allow short options for --version and --help, compare also to GNU echo.
Added tests for the above.

Do not allow short options for --version and --help, compare also to GNU echo.

Why do we want to do that?
This makes the code more complex

Do not allow short options for --version and --help, compare also to GNU echo.

Why do we want to do that?
This makes the code more complex

I thought that it might be usefull to mimic the exact behavior, e.g. to not break scripts etc.
But if you do not see fit thats also fine.

Mimicking the behavior is one of the goal but not for every cases. For example, here, not sure to see the value :)
Could you please remove this part of the PR ? thanks


Support for Sprockets v3?

In my attempt to update Sprockets to v3 to use ES6, I encountered an issue with this gem in that it's declared to only support v2. Does this work with v3 at all? I'd like to keep this gem in my project if possible.
Bundler could not find compatible versions for gem "sprockets":
  In Gemfile:
    sprockets (~> 3.0)

    sass-rails (~> 5.0) was resolved to 5.0.6, which depends on
      sprockets (< 4.0, >= 2.8)

    sprockets-webp (~> 0.3.2) was resolved to 0.3.2, which depends on
      sprockets (~> 2.2)

@JakeTheSnake3p0 Sorry, doesn't have time to update it to new sprockets. If you have time - I can review and accept PR.

I was trying to do this in Sprockets v3, but after 4 days of confusing, I gave up.
I have also problems with Webp-ffi, so I copy compiled version of  encoder, and paste it in vendor/cwebp
Finally I write rake task.
lib/tasks/webp.rake
namespace :assets do
  desc "Generate WebP format of images in public/assets/"
  task :webp => :environment do
    puts 'Generating WebPs'

    asset_root = Rails.root.join 'public', 'assets'

    Dir.glob("#{asset_root}/**/*.{png,jpg}").each do |image|
      image_webp = image + '.webp'
      next if File.exist? image_webp

      cwebp_path = Rails.root.join 'vendor', 'cwebp'
      `#{cwebp_path} #{image} -o #{image_webp} 2>&1`

      print '.'
    end

    puts "\nDone"
  end
end

Rake::Task['assets:precompile'].enhance do
  Rake::Task['assets:webp'].invoke
end

I needed to remove if statement from nginx.conf because If Is Evil. It just did not work for me.
location ~* ^/images/.+\.(png|jpg)$ {
  add_header Vary Accept;
  try_files $uri$webp_suffix $uri =404;
}

I know that this will not help your gem, but this gem does not work at the moment.
I'm using this rake task and I am satisfied.

I would also check to make sure the webp image is newer then the original
    next unless File.mtime(image) < File.mtime(image_webp)


Portafolio Week #1

I apologize for the large amount of commits, next time I will try to do pull request with a less amount. In the html I wrote the basic structure in which I added up some sections, including "About me", "Projects", "Contact Me" and "Get to know me better".
In each section I grouped its corresponding information, except in the last one "Get to know me better" in which I included some buttons that deploy information.

Don't worry about the # of commits. Looking @ the files changed makes it easy to see all the changes collapsed together I think.


Add possibility to configure db connection

Didn't find a way to call sqlite3_db_config so I've added it.

The function is here. There is no unittest, though, you can add yours.

But it isn't the same one. That is for global settings using sqlite3_config, but this one is for setting of just the actual connection using sqlite3_db_config
See https://sqlite.org/c3ref/config.html vs https://sqlite.org/c3ref/db_config.html

Oh right. So it's nice to have, indeed.


AppCenter Auth with native sign in page

[Enter feedback here]

Hello 👋,
We would like to use AppCenter as BaaS solution on mobile (iOS+Android) project, and in order to have user data partitions with need to implement authorisation using AppCenter SDK.
But our UI/UX would like to have native UI for sign in page with login & password inputs.
I know that AAD B2C supports custom UI for authorisation, but it will be displayed in a web view instead.
Is it possible to implement AppCenter authorisation without presenting web view but with long & password request from native screen instead?
I know there is Custom Token solution in Firebase for that, is there something similar in AppCenter?
With regards.
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f74618cf-1ab9-0977-d07f-26e840058259
Version Independent ID: cf027587-4bbf-1b73-fb10-b0e40094ef30
Content: Managing identities with the App Center Auth Service - Visual Studio App Center
Content Source: docs/auth/index.md
Service: vs-appcenter
GitHub Login: @amchew
Microsoft Alias: amchew

@OlexandrStepanov I'll ask the PM to take a look at your question.
In the mean time, App Center support is provided directly from within the App Center portal. Any time you need help, just click the blue chat button in the lower-right corner of any page and our dedicated support team will respond. For additional information, see the App Center Help Center.

Здрастуйте @OlexandrStepanov! :)
I'll am checking, and will get back shortly!
Also, thank you for using Auth! I'd love to learn about your experience with Auth so far. Would you be available for a call next week? If so, email me at amchew [at] microsoft [dot] com.

Ni hao, @amchew :)
We are currently on the stage of establishing a new project for our client, mobile app for both platforms.
The client is using Azure as infrastructure provider, and thus we are looking at AppCenter not only as CI/CD solution, but also as data storage, crash reporting and analytics provider.
We don't have experience with it, but have some with Firebase, and thus compare these two similar services in some kind.
Custom token solution is a feature which seems serious lack of AppCenter functionality.
With regards.

[Enter feedback here]
Hello 👋,
We would like to use AppCenter as BaaS solution on mobile (iOS+Android) project, and in order to have user data partitions with need to implement authorisation using AppCenter SDK.
But our UI/UX would like to have native UI for sign in page with login & password inputs.
I know that AAD B2C supports custom UI for authorisation, but it will be displayed in a web view instead.
Is it possible to implement AppCenter authorisation without presenting web view but with long & password request from native screen instead?
I know there is Custom Token solution in Firebase for that, is there something similar in AppCenter?
With regards.
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f74618cf-1ab9-0977-d07f-26e840058259
Version Independent ID: cf027587-4bbf-1b73-fb10-b0e40094ef30
Content: Managing identities with the App Center Auth Service - Visual Studio App Center
Content Source: docs/auth/index.md
Service: vs-appcenter
GitHub Login: @amchew
Microsoft Alias: amchew

Hi in order to use a native signup/signin experience with B2C - you will need to use ROPC. We have it in User Flows and a have sample with [custom policies-ROPC] (https://github.com/Azure-Samples/active-directory-b2c-custom-policy-starterpack/tree/master/scenarios/source/aadb2c-ief-ropc)

Hello @valnav,
Thank you for your feedback.
I have investigated the ROPC flow proposed by you above, but have some open questions left:

I didn't got where to place username/password validation in ROPC flow, so AAD B2C token is generated only if this pair exist on 3rd party service. Supposed flow is:
iOS app -(username/pass)-> Azure Function -(username/pass)-> 3rd party API -(3rd-party-token)-> Azure Function -(3rd-party-token)-> AAD B2C -(aad-token)-> Azure Function -(aad-token)-> iOS app.

It looks like AppCenter Auth module doesn't have support for ROPC flow, and if one would like to use it with AppCenter Data module, authentication part must be implemented via MSAL library manually. Is this correct?

With regards.

@amchew  Can we use this for a phone auth first approach similar to FB Account Kit, Firebase or Twilio?

Hello @valnav,
Thank you for your feedback.
I have investigated the ROPC flow proposed by you above, but have some open questions left:

I didn't got where to place username/password validation in ROPC flow, so AAD B2C token is generated only if this pair exist on 3rd party service. Supposed flow is:
iOS app -(username/pass)-> Azure Function -(username/pass)-> 3rd party API -(3rd-party-token)-> Azure Function -(3rd-party-token)-> AAD B2C -(aad-token)-> Azure Function -(aad-token)-> iOS app.
It looks like AppCenter Auth module doesn't have support for ROPC flow, and if one would like to use it with AppCenter Data module, authentication part must be implemented via MSAL library manually. Is this correct?

With regards.
I am not sure i understand your supposed flow, but did you see - Setup ROPC with Azure AD B2C

Hey @OlexandrStepanov, App Center Auth only supports the sign in user flows and custom policies, so yes the authentication part must be implemented via MSAL library manually. I would love to learn more about your use case, would you be available this week for a call? Email me at amchew [at] microsoft [dot] com.
@caseyniemann If I understand your question correctly, you're asking if Azure AD B2C supports phone auth (e.g. Firebase's phone auth: https://firebase.google.com/docs/auth/android/phone-auth). Let me know if that's correct! We'll get back shortly on this one.

@amchew Yes.  Your competition in this space is FB Account Kit and Firebase Phone Auth---they allow that to be a first authentication---instead of a second (like MFA).

@caseyniemann - there are few samples for one time pass code and phone number sign in here - https://github.com/azure-ad-b2c/samples

@amchew  In the Firebase panel of authenticated users there is an option of how they have connected, username and password, social networks
With the Facebook SDK in xamarin, I logged in natively and received a token later with the firebase sdk in authentication, you can receive that token and log in without the need for a web view or external pages. This is very important.
Regards

Any progress with my query?

Thanks @angelru, we're getting a lot of feedback about the native sign-in page, and I'm looking into it. Would you have some time today or tomorrow for a quick chat? Email me at amchew [at] microsoft [dot] com if you are interested.

@amchew Done.

Replied!

Do you have any updates on this topic, please?

Hi,
We are building a Xamarin forms app and want to use App Center. We had the same issue that we want to use the native UI on mobile and I went through this thread to look for a solution. Your solution mainly seems to use ROPC. After doing some research on that, ROPC seems to have many limitations and its own page recommendations not to use it as it is relatively insecure and also limited due to no support for personal accounts. Any plans on supporting native sign in experiences using other methods?

This content was deleted per the discontinuation of Auth here: https://devblogs.microsoft.com/appcenter/app-center-mbaas-retirement/


Wheel build issue with cibuildwheel

When building Nuitka projects with cibuildwheel, e.g., this toy project, .so-library files accumulate in the wheels, i.e., the wheel for Python 3.10 contains .so-files for all versions 3.7-3.10. I brought this up to the cibuildwheel devs here. The suggestion is that Nuitka probably doesn't handle caching correctly. Quoting:

Going to guess nuitka doesn't handle caching correctly and is collecting the outputs cached by initial runs. It should cache based on Python version, os, etc - everything that goes into a wheel.
To fix it you could add a pre-build step that deletes the cache, though you'd need to figure out where they are caching the outputs.

Have you attempted deleting the Nuitka cache then, and as such evidence that it is actually true?

Yup, I'm now clearing the build/ directory before each build. That works correctly.

Well, the build directory is not a cache of Nuitka, but something from setuptools. All Nuitka does, is to go over the python files and replace them with the extension module, and then let other code do its thing. Maybe it is supposed to clean up that directory, in the end, but if it is, that never happens for me for any other build.
So maybe it is supposed to clear it at the beginning, but I feel very innocent, because Nuitka only overloads code that works on it being populated.
You can check nuitka/distutils/DistutilCommands.py to only remove the Python files, and place the extension module, and otherwise to wrap all commands and the nuitka build backend just uses bdist_nuitka rather than bdist_wheel and otherwise is also the same.
There are options to clear temporary stages after build to setuptools, these are probably not used with the toml based configuration.

I checked, by going into tests/distutils/example_pyproject_1 and running python3.8 -m build and python3.7 -m build and there was no such issue as you describe. From your toy project, same thing. So total waste of my time, except that I think I got the idea how to specify options with toml and pyproject then.

You're missing --wheel. Exact steps to reproduce:

Clone the MWE repo
python3.9 -m build --wheel
python3.8 -m build --wheel
unzip dist/myfoobar-0.0.1-cp39-cp39-linux_x86_64.whl to find both .so files

Well, why would I use --wheel, it was making wheels by default.
Citing help output is very confusing:
By default, a source distribution (sdist) is built from {srcdir}
and a binary distribution (wheel) is built from the sdist.
This is recommended as it will ensure the sdist can be used
to build wheels.

Pass -s/--sdist and/or -w/--wheel to build a specific distribution.
If you do this, the default behavior will be disabled, and all
artifacts will be built from {srcdir} (even if you combine
-w/--wheel with -s/--sdist, the wheel will be built from {srcdir}).

Maybe it's picking up the build folder therefore, while is below there, definitely none of Nuitka's business though, definitely something about how the tool is used. You probably can demonstrate the bug without Nuitka and version specific extension modules built too.

I tried to demonstrate it with setuptools packages with C++ extensions, but I don't see this behavior there.
I don't want to push too hard on this since I have found a workaround for me (removing the build/ folder). If there are more problems with this in the future, we can come back to it.

While I believe you, I think it's still something outside of Nuitka's control. Working off a source directory with an extension module, is your choice there, and there is a wheel. The code of Nuitka is not tasked to judge what else there is in the build folder, e.g. there could be rust built stuff there, as seen in other issues.
Not sure if you used the pyproject.toml there, did you? If you shared that, I could compare it. I can reproduce it, but I have no idea, why in one case cleaning would occur, while not in the other.

Alright, thanks for looking further into it.

Let me know when you updated it. I have no clue how to build an extension module with pyproject.toml, hoping on you here.


Collision mask animation does not work

Godot version:
3.0.6
OS/device including version:
Windows 10
Issue description:
If you have an animation with one track relative to Collision Mask to activate/deactivate one flag over time, this does not work.
If you play this animation in the Animation console then it runs, but it does not run at runtime...
Steps to reproduce:

Create a new animation in the AnimationPlayer node of a character (KinematicBody2D in my case)
Add a new track with Mask Collision
Change it over time at least two times
Test it in the Animation Console. It works!
Now, Execute the game ant test it...

A sample project exhibiting this issue would be welcome.
Did you try with the AnimationPlayer having process_mode=physics?

I have tried today with your solution and it works. Thanks so much!
What worries me is that I tried again like yesterday (Animation idle mode) and today it works...
Thinking now about this it's as if yesterday Godot didn't take the changes I made to the animation, although I saved it several times to make sure...

Can anyone still reproduce this bug in Godot 3.2.2 or any later release?
If yes, please ensure that an up-to-date Minimal Reproduction Project (MRP) is included in this report (a MRP is a zipped Godot project with the minimal elements necessary to reliably trigger the bug). You can upload ZIP files in an issue comment with a drag and drop.

Closing due to lack of update. Please comment if you can still reproduce this issue in the latest stable version of Godot.


Object Signing requirement fix and adding protocol node into existing…

… object enabled cluster issue fix
Signed-off-by: Rajan Mishra<EMAIL_ADDRESS>

Duplicate PR with https://github.com/IBM/ibm-spectrum-scale-install-infra/pull/586


Various fixups

Various fixups and small additions that I made to the cookiecutter in order to get it to apply to LMS (https://github.com/hypothesis/lms/pull/5444).

@jon-betts Just FYI there are ways to tests these cookiecutter PRs before merging them if you want to. I should add this to the README but for now:

The cookiecutters repo itself has make sure (alias: make test), make test-pyapp, make test-pypackage and make test-pyramid-app commands. These generate fresh projects with each of the cookiecutters to temporary directories and run the make sure's of those projects. These also run on the cookiecutters repo's own CI

You can use cookiecutter to generate a new project from the PR branch then take a poke around. For example:
$ cd /tmp
$ cookiecutter gh:hypothesis/cookiecutters --directory pyramid-app --checkout various-fixups --no-input
$ cd my_pyramid_app
$ make dev

You can use make template to apply the cookiecutter from the PR branch to any existing cookiecuttered project and take a look at the changes. test-pypackage, test-pyapp and test-pyramid-app can be useful for this purpose but you could also do this in any of our real projects:
make template checkout=various-fixups


synchronize Scheduler scrollbars

if you scroll in one Scheduler, others must follow.
hint: https://stackoverflow.com/questions/12039038/how-to-synchronize-two-scrollbars-for-divs.

closing in favor of #201.


compressed model

How can get the compressed model and find the compression ratio which is an important concern in deep compression?

Greetings, @jinqijinqi!
@asenina is currently working on analyzing the quantized models and providing certain metrics pertaining to the compression level of a given quantizer layout.
As for other algorithms, check out the implementation of their .statistics() methods. These should be implemented namely for sparsity and pruning.


Add permission to allow searching for cyber.dhs.gov hosted zone ID

🗣 Description
In this pull request I add two permissions to the Route53ResourceChange-cyber.dhs.gov role that allows users to search for the cyber.dhs.gov hosted zone.
💭 Motivation and Context
These extra permissions are required, for example, in cisagov/openvpn-server-tf-module.
🧪 Testing
I deployed these changes to COOL production and used them to deploy cisagov/openvpn-server-tf-module to COOL staging.
🚥 Types of Changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (causes existing functionality to change)

✅ Checklist

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

Does it make sense to be setting a var for the domain, then searching for it, when you could just pull in the zone (cyber_dhs_gov_zone) from the output of this module:
https://github.com/cisagov/cool-dns-cyber.dhs.gov/blob/4ea955350ba257486ac6ba19d426f80b9a6c9ee9/outputs.tf#L1-L4
This was my intended use pattern for DNS in the COOL.

I will rework to use remote state.
On Thu, Mar 26, 2020 at 9:01 AM Mark Feldhousen<EMAIL_ADDRESS>wrote:

Does it make sense to be setting a var for the domain, then searching for
it, when you could just pull in the zone (cyber_dhs_gov_zone) from the
output of this module:
https://github.com/cisagov/cool-dns-cyber.dhs.gov/blob/4ea955350ba257486ac6ba19d426f80b9a6c9ee9/outputs.tf#L1-L4
This was my intended use pattern for DNS in the COOL.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/cisagov/cool-dns-cyber.dhs.gov/pull/8#issuecomment-604417716,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABKECPMAQG7VW4HSRP4SWUDRJNG3JANCNFSM4LT45TPA
.

--
Shane Frasier
Cyber Assessments
Cybersecurity and Infrastructure Security Agency
Cell:<PHONE_NUMBER> | Email<EMAIL_ADDRESS>

In deference to @felddy's comment, I resolved this a different way.  See cisagov/cool-sharedservices-openvpn#10 and cisagov/openvpn-server-tf-module#19.


shoelace_kitchensink example scrolling bug on IOS Desktop.

https://data-star.dev/examples/shoelace_kitchensink is broken in Safari ( Desktop ), but not on IOS ( mobile ).
The bug is that when you scroll, the text and combo box stay fixed, but everything else scrolls correctly.

Nothing about Datastar should effect rendering, it's most likely shoelace issue.

local it work son desktop, so I think this has been fixed ....


Add checkbox to ignore double-click to select segment

Adds a checkbox to the "Segment Selection" section which, when selected, disables the ability to double-click to select/deselect a segment.

Ignoring a layer now ignores splitting and merging as well, along with any future actions that may be added.

Looks good. Great job! I just have a few small comments:

I think the ignoreSegmentInteractions property can live on the segmentation user layer class, instead of the displayState object.
It should work without changing the Segmentation RenderLayer, I don't think we need to modify this file
Some lines are exceeding 100 characters. We are using the clang-formatter with a line width limit of 100 characters: https://github.com/seung-lab/neuroglancer/blob/master/.clang-format . If you decide to use VSCode, I can show you how to set up VSCode to format the code automatically.


[BEAM-409] Ensure precision in division of Longs in ApproximateQuantilesCombineFn

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

[x] Make sure the PR title is formatted like:
[BEAM-<Jira issue #>] Description of pull request
[x] Make sure tests pass via mvn clean verify. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
[x] Replace <Jira issue #> in the title with the actual Jira issue
number, if there is one.
[x] If this contribution is large, please file an Apache
Individual Contributor License Agreement.

This PR resolves BEAM-409 by casting a long to a float before division.
@swegner Would you mind reviewing for me?

R: @swegner

Thanks for this contribution. I'd like to have some unit tests that show the impact of this bug and to verify your fix. I've opened PR #856 with unit tests. Once that PR looks good, would you mind merging into yours to submit?

Thanks @swegner, your changes look good to me and I've cherry-picked them into #853. I learned quite a bit while reading it, thanks :)

mvn clean verify runs fine for me, and the failures on Jenkins and Travis look unrelated to this PR, or to each other for that matter. I've pulled the commits from #856 into this PR.

LGTM
R: @dhalperi for committer approval and merge.

On vacation ATM, will get back to it when I return in a week.

sgtm.

Hi Jason, any updates here?

I'll close for now and reopen later. Realized I needed to up my Java skills a bit first. :)


consider volume_services_id instead of volume_id on #182

see https://github.com/opiproject/opi-api/pull/182#issuecomment-1301115569

I don't feel like that makes any sense. It's a reference to the volume resource, not some sideband service. Can we elaborate on the thinking here?

I just didn't want to loose a comment from @jainvipin here https://github.com/opiproject/opi-api/pull/182#issuecomment-1301115569
not sure I get it myself, so will let @jainvipin to elaborate

my thought was that middle-end objects specifies a set of service applied to a given namespace/volume. Saying that this is a volume reference is not reflecting that this is a middle end object that is identifying a set of services (e.g. crypto) applied on a given volume. May be there is a better word to capture that but certainly leaving it as volume will be confusing, because it doesn't refer to the volume.

I was thinking like in linux kernel...
you have block device, on top you can add crypto and result is still block device...
you add RAID and result is still block device...
so instead of block we calling this here volume.
apply crypto and new volume is created with crypto
apply compression and new volume is created...
thoughts ?

The way most block storage stacks work (Windows, Linux, SPDK, etc.) is by building IO pipelines consisting of a stack of "block devices". The block devices have types (NVMe, SCSI, crypto, raid). Some block devices represent physical storage. Some block devices represent remote storage. Some block devices are purely virtual and can only be layered on top of other block devices (crypto, raid).
OPI is simply using this long established model and calling the objects that get stacked "volumes". To build a volume that does inline encryption of data, you'd layer a CryptoVolume on top of an NVMeVolume, for example. You assign the top-level volume_id into a subsystem when you create a namespace.
Note also that the stacks do not need to be linear. RAID would aggregate, a partition splits, etc. That's why each layer has to return their own new volume(s).

@benlwalker this leads to a question I had - create call can return a list of objects ?

It could, but more likely what'll happen for the partition/logical volume case is you'll call an API to provision some sort of "manager" object, associated with a backing volume. Then you'd ask the manager to provision volumes for you, giving you one volume_id at a time. That's because other than very simple splitting, the creation and destruction of volumes is dynamic and on-going.

The way most block storage stacks work (Windows, Linux, SPDK, etc.) is by building IO pipelines consisting of a stack of "block devices". The block devices have types (NVMe, SCSI, crypto, raid). Some block devices represent physical storage. Some block devices represent remote storage. Some block devices are purely virtual and can only be layered on top of other block devices (crypto, raid).
OPI is simply using this long established model and calling the objects that get stacked "volumes". To build a volume that does inline encryption of data, you'd layer a CryptoVolume on top of an NVMeVolume, for example. You assign the top-level volume_id into a subsystem when you create a namespace.
Note also that the stacks do not need to be linear. RAID would aggregate, a partition splits, etc. That's why each layer has to return their own new volume(s).

Thanks for this insight @benlwalker and thank you for your patience!
In a linux system when you see a volume it can specify the type and you can learn the stacking. However if everything is called volume object and identified as volume_id I suspect our APIs will look very confusing. I mean we are calling VolumeEncryption but the APIs and references from other objects will look very ambiguous - everything is a volume_id the stacking is implicit.
This also begs a question, where do we indicate this stacking of multiple services applied to a remote NVMe volume in them iddleend APIs?

@glimchb - the way I see the sequence:

Create Namespace, which refers to a volume_id of VolumeEncryption
Create VolumeEncryption, which refers to a volume_id which refers to a volume_id of VolumeCompression
Create VolumeCompression, which refers to a volume_id, etc.

Isn't this confusing to the user as to which volume_id is referring to what object?

@jainvipin Please propose how you would do arbitrary layering, where the order of the layering matters and it isn't always 1:1 and not all layers always exist. I think if you do that, you'll quickly see that the handles all have to be the same type and interchangeable like Boris outlined.

@benlwalker - you may be right, let me think over something that may look better. If not we go with what we have.


Add Protobuf typed/defined Penumbra ABCI Events

PR for #3460.

This looks great! I added a few commits to carry it over the finish line. In particular:

using DeserializeOwned avoids the lifetime bounds
using the fully-qualified proto name will avoid potential conflicts between events in different modules.

I had to make some changes to the (de)serialization to make it work with the EventOutput, as an example of something with nested substructures.
In the original issue there was a suggestion to replace all of the existing events with proto-events. I don't think we should do that before merging this, it could be a separate issue. The events are not consensus-critical, so we can change them later (though it's slightly annoying to have different event formats in the same database or otherwise to re-execute all the blocks, etc)


Default sa password

Hi,
I know containers have only one service, but I am trying to install an application based on  the mssql-server-windows-developer container, i.e. SQL Server and the application on the same container.
My problem is that I cannot seem to login to SQL Server  using the specified sa password in the cmd script I use to start the install and my application.
The cmd script I am using looks like the following:
start cmd /c CALL ".\start.ps1 -sa_password PassW0rd123# -ACCEPT_EULA Y -Verbose
sqlcmd -U sa -P PassW0rd123#

The problem is that the sqlcmd command logs that the password is not correct when trying to login.
What is the default password for the sa account? I want to see if I can perhaps use that?
Do you see anything wrong with the commands I am running?
Thank you.

The SA password is passed in at docker run time via the environment variable SA_PASSWORD.  See example here:  https://hub.docker.com/r/microsoft/mssql-server-windows-developer/

Hi,
The base example on the page mentioned in your comment works. However, the problem is that whenever I run the start.ps1 script manually from a .cmd file it would not use specified sa password.

I managed to fix the issue. I was using a password that contained a '$' sign. This was then interpreted by powershell as a variable rather than a literal string value, since I used powershell to run my .cmd file.
The problem was fixed when I changed the '$' sign to something else.


Templating not working with zabbix 3.0.4 and grafana 3.1.1

I'm submitting a ...

[x] Bug report
[ ] Feature request
[ ] Question / Support request

Hello, i using Grafana v3.1.1 and Zabbix v3.0.4. When i create a templating for $group and $host, everything seem to be ok : http://prntscr.com/dao4qw . However when i configure query from zabbix source, no template variables appear @@. I don't know why :| http://prntscr.com/dao596
And when i using another source ( graphite source ), the template varibale will appear. Pls answer me. Thanks !

Hi, you should write variable name from template to the appropriate field manually, i.e. it shouldn't appear in the list of Groups or Hosts.
Just like that - http://storage4.static.itmages.ru/i/16/1201/h_1480596657_5478298_fe63af0c73.png


Using deprecated NPM packages

When installing ManifoldJS via the command line, you'll get warnings about several deprecated/renamed packages that are in use.
Not sure if this is actually a problem but I'd prefer not to get warnings when installing things.
npm WARN deprecated<EMAIL_ADDRESS><EMAIL_ADDRESS>is no longer maintained. Upgrade to<EMAIL_ADDRESS>npm WARN deprecated<EMAIL_ADDRESS>the module is now available as 'css-select'
npm WARN deprecated<EMAIL_ADDRESS>the module is now available as 'css-what'

Thanks for reporting this.
None of these are direct dependencies of ManifoldJS. It seems that they are pulled in by another package, cheerio. ManifoldJS currently depends on v0.18.0. The current release of cheerio (v0.19.0) has apparently updated its dependencies. We'll need to test it and update to this version to remove the warnings.

Martin, just because a dependency has been abandoned doesn't mean it's not safe!  Just a joke.  0.18 was the latest version when we took it on, but now that .19 is out, we'll put it into an update to keep things on the up and up.

close this issue, and open one for new packages that are depricated


Tweaked loaddata command to re-use a calculated value.


"early exit if ray colour is nearly 0" leads to noticeable difference

First off, can I say how awesome your videos are and thanks for uploading the source code so I can play about with it! I've never done any game dev before so I'm in at the deep end here!
Now, I have noticed this if statement:
https://github.com/SebLague/Ray-Tracing/blob/71f88120ea9c7b0d5321abddefb44fc7c2eb7c5f/Assets/Scripts/Shaders/RayTracing.shader#L337-L341
With this in place, this is the result:

However, if you remove that early exit, there is a noticeable increase in bounce lighting, which looks more realistic to my eye:

Ok, nevermind, there is some weirdness going on when you do this (e.g. look at how light the dark grey ball has become)

If you remove the early exit you need to remove the following line as well -> rayColour *= 1.0f / p;
Results should then look very similar. I agree the green ball looks quite cool in the second image though :)

Yeah I figured that out eventually. Was wondering why divide by p until I read this part from https://blog.demofox.org/2020/06/06/casual-shadertoy-path-tracing-2-image-improvement-and-glossy-reflections/:

We are going to find the maximum color channel value in our throughput, R, G or B, and that value will be the percentage chance that we keep going with our ray after each bounce. When we do keep going, we are going to divide our throughput by that chance of keeping the ray, which makes up for the fact that we kill some of the rays there some of the other times, by making future bounces brighter.


What are the prerequisites for moving the tello drone through chat gpt?

I installed Anaconda after reading the previous posts, but I would appreciate it if you could tell me more about the connection procedure between the tello drone and computer or the connection procedure with chatgpt or Airsim.
I wonder if tello can be moved properly only after creating the environment related to the ChatGPT-Airsim Interface you uploaded.
https://github.com/microsoft/PromptCraft-Robotics/blob/main/chatgpt_airsim/README.md
I don't have much knowledge about coding or programming, so I'm not sure how to use the prompts you posted earlier because I don't know how.
https://github.com/microsoft/PromptCraft-Robotics/blob/main/examples/aerial_robotics/tello_example.md
I wonder if this applies to other dji drone models other than tello.

Hi, @HeavenlyCommencer did you find the solution? I'm also looking for the same. @saihv any help here?


Use of actor_token and actor_token_type

Should we allow the use of actor_token and actor_token_type to be used as a means of client authentication for the Transaction Token Service? If not, should explicitly prohibit the use of these parameters in the profile of the Token Exchange spec.

Since RFC8693 (Token Exchange) refers to the actor_token as "A security token that represents the identity of the acting party", we should not use it in the TraT request. I thought we wanted to have some way to convey the inbound token to the TraT service, and that's why we were using actor_token, but that is inconsistent with RFC8693. I think we should neither require nor disallow the use of actor_token because some implementations may want that for client auth, and some implementations may want to do something else (e.g. mTLS) for client auth.

This is kind of what the spec says today. It's not required and up to the implementation. It is just referenced as an example. However, I'm fine removing the example and just being silent in the spec on the topic.

Recommendation to update example and be silent on use of actor_token and actor_token_type. Add a section to Security Considerations to talk about client authentication and add some non-normative examples.

Removed the additional text regarding possible client authentication methods and just left it that the client MUST authenticate itself to the Transaction Token Service and that the specific client authentication method is out of scope for this specification.


Update alpine to 3.8

For https://github.com/giantswarm/giantswarm/issues/4197

There is no an upstream maintained image: https://www.elastic.co/guide/en/beats/filebeat/current/running-on-docker.html

@webwurst I leave it to you to archive this repo. Ideally place the above link in the README.md.


HIVE-27723: Prevent localizing the same original file more than once if symlinks are present

What changes were proposed in this pull request?
Resolving symlinks before considering local files to be transformed to yarn LocalResource.
Why are the changes needed?
Because localizing the same hive-exec jar more then once is a needless burden on HDFS and runtime.
Does this PR introduce any user-facing change?
No.
Is the change a dependency upgrade?
No.
How was this patch tested?
very same as on https://github.com/apache/hive/pull/4741
cluster test worked as expected, unit tests worked as expected also

all failures are related to docker problems, create some jiras about those:
https://issues.apache.org/jira/browse/HIVE-27759

@ayushtkn: thanks for the comments so far, let me know if the current state with my comments and fixes is ready to merge

This is a slightly different topic, but I'm putting it here since it is also slightly related. Also, my memory and comment here could be wrong.
I am also aware that it takes time and consumes space to copy hive-exec.jar per app. So, I'm wondering if we can potentially develop an option to mark the resource as LocalResourceVisibility.PUBLIC. It needs to care of security but it sounds possible if an administrator has control of Hive deployment.

This is a slightly different topic, but I'm putting it here since it is also slightly related. Also, my memory and comment here could be wrong. I am also aware that it takes time and consumes space to copy hive-exec.jar per app. So, I'm wondering if we can potentially develop an option to mark the resource as LocalResourceVisibility.PUBLIC. It needs to care of security but it sounds possible if an administrator has control of Hive deployment.

very good point @okumin , we might want to discover the possibility to localize hive-exec jar as PUBLIC, similarly to the tez.tar.gz here:
https://github.com/apache/tez/blob/2ad10b61a0263770e4e78983939bb9d823d9dc27/tez-api/src/main/java/org/apache/tez/client/TezClientUtils.java#L271-L277

looks good, but you have got some unrelated change in the Jenkinsfile.
btw. did you try the latest changes also on the actual env, the dupe hive-exec jar is getting copied only once post this, right?

eh, rebased, Jenkinsfile was a noise from another work :)
I'm trying out the latest changes on an actual env

@ayushtkn : confirmed on cluster, hive-exec.jar is localized once with the latest patch


fix: version pattern for CCv2 build.version

CCv2 uses Version pattern "2105.10-2105-2202.26-20220510.1-cbe2a6a-develop" which causes Spring Bean initialization to fail since the current pattern for NEW_VERSION causes .match() to return false so the pods in the CCv2 won't start anymore.
BTW, some of the index definitions in the items.xml will also cause the build to fail because items like DroolsRule and AbstractRule depend on extensions that are not included out of the box like droolsruleengineservices, so I'm not sure if it makes sense to include these per default.

ouch, thanks for catching that one.
regarding drools / rule engine:
Drools is the default to do promotions / advanced pricing for quite a while now, that's why included it by default.


Become official

Thanks for the great Dockerfile - would you be interested in making this the official mitmproxy image? I'd happily accept a PR that reduces our container size! :relaxed:
(cc @dweinstein - he's our awesome chief Docker officer :smiley:)

Yes sure. On https://github.com/mitmproxy/mitmproxy I don't see your Dockerfile.

the base images are here https://github.com/mitmproxy/docker-base -- looks like the important changes are: use alpine as base, update some deps possibly for the dev base, and to use the mitmproxy user.

Thanks for dockerizing this.
Why not upstream the python stuff as well? then people can use the same image to run mitmdump -s on a dump file

Moved to the official so closing this.


proposal: reserve GOOS=zos for IBM z/OS

As discussed here: https://groups.google.com/d/topic/golang-dev/f6IC8Dm7weI/discussion there may be a z/OS port in the future (subject to further discussions etc.).
As part of this effort it would be helpful to reserve GOOS=zos now, in order to make supporting z/OS outside of Go itself easier in the future (similar to what was done here: https://github.com/golang/go/issues/10165).
I am open to names other than zos if zos is considered undesirable for whatever reason.

Seems pretty uncontroversial.
/cc @minux @ianlancetaylor @rsc

Sure.

Speaking of which, @josharian , want to reserve a RISC-V arch name?

Speaking of which, @josharian , want to reserve a RISC-V arch name?

Yes. Is there any reason to do it now (in 1.8) vs when the port is ready (hopefully 1.9)?
There are some naming questions, too--there are many RISC-V variants (ISA subsets, 32 vs 64 bit, compressed).

The advantage is that "foo_riscv.go" would be recognized as a reserved file in Go 1.8, even without +riscv build tags.
But we'd probably need them anyway, at least in subrepos, for people using Go 1.7 and below.

Ok.

Reserving zos SGTM.
Yeah, I think we should riscv and riscv64 as GOARCHes too.

I think we should use riscv and riscv64 to match the existing GOARCHes,
and the ISA variant should be specified in $GORISCV.
Actually, I don't think Go (at least the gc port) needs to handle any ISA
subsets at all. The compiler should target the generic (G) variant, and
additional feature required should be tested at runtime.

SGTM. Want to send a CL and add me as a reviewer? I'll pull in the other folks working on the port as well just to confirm.

I'm not sure why we are discussing this on this issue, but I would also toss in aix as a GOOS.  I know some people at IBM are interested in porting Go to AIX.


Maybe dead code

I'm listing some code to look at.
There is this class that seems to implement Null pattern:
Object subclass: #SpartaUnimplementedPathBuilder
	uses: TSpartaPathBuilder
	instanceVariableNames: ''
	classVariableNames: ''
	package: 'Sparta-Core-Builders - Unimplemented'

Only referenced from SpartaCanvas:
pathBuilderClass
	<return: #'TSpartaPathBuilder class'>

	true ifFalse: [ self subclassResponsibility ].
	^ SpartaUnimplementedPathBuilder

UPDATE:
I discovered the class when looking at Code Critics and wanted to take note. But minutes later I realized there is a Package tag with many classes with this "pattern"... something to understand.

In SkiaThreadedLibrary:
calloutAPIClass
	^ ThreadedFFIMigration threadedFFIAvailable
		ifTrue: [ TFCalloutAPI ]
		ifFalse: [ super calloutAPIClass ]

Where ThreadedFFIMigration  doesn't exist

This class doesn't have any method, subclass, reference, or class comment:
Object subclass: #Sparta
	instanceVariableNames: ''
	classVariableNames: ''
	package: 'Sparta-Core'


[release-1.10] Integration testing: support 1.9.0 -> latest and 1.8.1 -> latest upgrades using helm

This is an automated cherry-pick of #31048

@googlebot I consent.


Type metadata / shadow types

Suggestion
🔍 Search Terms
type metadata info secondary
✅ Viability Checklist
My suggestion meets these guidelines:

[x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[x] This wouldn't change the runtime behavior of existing JavaScript code
[x] This could be implemented without emitting different JS based on the types of the expressions
[x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
[x] This feature would agree with the rest of TypeScript's Design Goals.

⭐ Suggestion
Create a type that in a union, has no effect on the result of the union (same as never), but can be retrieved using a special type (i.e. GetMetadata<T>).
type x = number | Metadata<unknown>; // type is: number
type metaX = GetMetadata<x>; // type is unknown

📃 Motivating Example
This can be used to document errors which a function may throw.
Currently, Typescript allows to do something like the below, but there's an issue in that the Throws<> type pollutes the function return type which has to be manually eliminated by type casting - not very practical.
This is a full example of what I'm aiming at, from my comment in the issue https://github.com/microsoft/TypeScript/issues/13219#issuecomment-928866237
type Throws<T> = { throws: T };

type GetThrow<T> = T extends Throws<infer R> ? R : never;
type GetResult<T> = T extends Throws<unknown> ? never : T;

type GetFunctionThrow<T extends (...args: any[]) => any> = GetThrow<ReturnType<T>>;
type GetFunctionResult<T extends (...args: any[]) => any> = GetResult<ReturnType<T>>;

type CalcError = {
    code: "calc_error"
    message: string
}

type DivisionError = {
    code: 'division_error'
    message: string
}

function divide(a: number, b: number): number | Throws<DivisionError> {
    if (b === 0) {
        throw { code: "division_error", message: "Cannot divide by 0" } as DivisionError;
    }

    return a / b;
}

function calc(a: number, b: number, operation: 'divide'): number | Throws<CalcError | DivisionError> {
    if (typeof a !== 'number' || typeof b !== 'number') {
        throw { code: "calc_error", message: "Required 2 number arguments" } as CalcError;
    }

    if (operation !== 'divide') {
        throw { code: "calc_error", message: "Unsupported operation" } as CalcError;
    }

    return divide(a,b);
}

let x: number;

try {
    // This casting makes this method hardly practical. If we had a metadata type, it would be a number by default.
    x = calc(5 ,6, 'divide') as GetFunctionResult<typeof calc>;
} catch (e: unknown) { // Catch-clause annotation must be any or unknown
    const err = e as GetFunctionThrow<typeof calc>; // CalcError | DivisionError
}

Playground
With the new special Metadata<T> utility type it would possible to store such information and access it with a special type GetMetadata<T> while the type like number | string | Metadata<unknown> would be just number | string.
💻 Use Cases

What do you want to use this for?
Documenting what types of errors a function may throw.

What shortcomings exist with current approaches?
It's possible to use a helper type to eliminate the metadata from the union, but it's too verbose to be practical.  It could also be stored in a separate type, but with classes, it would be away from the method body and also not practical enough to consider.

What workarounds are you using in the meantime?
I'm not documenting the types of errors a function may throw at all or I use tsdoc throws (but it does not allow to store type info).

i almost publish my lib https://github.com/kraftrio/kraftr/tree/develop/core/errors you can check it how i handled to store metadata, i created a eslint plugin too to enforce the usages (could have auto fix)


compilation failure on linux

Hi, thanks for this very interesting project! I tried to compile it (master branch, at commit 1c252f2a1ef006a2044bc5cecd9b207f6a93d6cd)  on Debian linux with gcc 4.9.1, and the compilation failed:
Linking CXX executable ../../../../binaries/BasicPublisher
../../../../lib/libaeron_client.a(Aeron.cpp.o): In function std::thread::thread<aeron::common::common::AgentRunner<aeron::ClientConductor, aeron::common::common::BusySpinIdleStrategy>::start()::{lambda()#1}>(aeron::common::common::AgentRunner<aeron::ClientConductor, aeron::common::common::BusySpinIdleStrategy>::start()::{lambda()#1}&&)': /usr/include/c++/4.9/thread:136: undefined reference to pthread_create'
collect2: error: ld returned 1 exit status
Adding -pthread flag to CMAKE_CXX_FLAGS fixed the issue.

Odd. The addition of find_package(Threads) should add that naturally.
When you run cppbuild, what is the output of the cmake part? i.e. the initial bit from a clean build.

That's the cmake part, including the one generated by gtest:
-- The C compiler identification is GNU 4.9.1
-- The CXX compiler identification is GNU 4.9.1
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Looking for include file pthread.h
-- Looking for include file pthread.h - found
-- Looking for pthread_create
-- Looking for pthread_create - not found
-- Looking for pthread_create in pthreads
-- Looking for pthread_create in pthreads - not found
-- Looking for pthread_create in pthread
-- Looking for pthread_create in pthread - found
-- Found Threads: TRUE
-- Configuring done
-- Generating done
-- Build files have been written to: /home/pablo/Aeron/cppbuild
Scanning dependencies of target gmock
[  3%] Creating directories for 'gmock'
[  6%] Performing download step (verify and extract) for 'gmock'
-- verifying file...
file='/home/pablo/Aeron/aeron-common/src/main/cpp/3rdparty/gmock-1.7.0.zip'
-- verifying file... done
-- extracting...
src='/home/pablo/Aeron/aeron-common/src/main/cpp/3rdparty/gmock-1.7.0.zip'
dst='/home/pablo/Aeron/cppbuild/gmock-prefix/src/gmock'
-- extracting... [tar xfz]
-- extracting... [analysis]
-- extracting... [rename]
-- extracting... [clean up]
-- extracting... done
[ 10%] No patch step for 'gmock'
[ 13%] No update step for 'gmock'
[ 16%] Performing configure step for 'gmock'
-- The CXX compiler identification is GNU 4.9.1
-- The C compiler identification is GNU 4.9.1
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Found PythonInterp: /usr/bin/python (found version "2.7.8")
-- Looking for include file pthread.h
-- Looking for include file pthread.h - found
-- Looking for pthread_create
-- Looking for pthread_create - not found
-- Looking for pthread_create in pthreads
-- Looking for pthread_create in pthreads - not found
-- Looking for pthread_create in pthread
-- Looking for pthread_create in pthread - found
-- Found Threads: TRUE
-- Configuring done
-- Generating done
-- Build files have been written to: /home/pablo/Aeron/cppbuild/gmock-prefix/src/gmock-build

I think ${CMAKE_THREAD_LIBS_INIT} might be needed for the aeron-samples target_link_libraries. That's a guess based on the error and what I see.
This does not seem to be a problem for CentOS 7 with gcc 4.8.2 and things build and test fine there.
Could you try adding that to your copy and see if it works? Adding to the flags directly is a bit uglier since it might break some other systems later if/when ported.

I added this flag and the build succeded on Debian. Also, on Fedora 21 it builds just fine without any modifications (without adding ${CMAKE_THREAD_LIBS_INIT}). So, maybe it's some issue with debian... FindThreads.cmake and cmake versions are same on both systems. By the way, do you plan FreeBSD support?

Yesterday I added the libs as well. So, the Debian build should be OK now. Seems to be OK on Mac & CentOS. Windows is not happy at this moment with one usage, but I will be cleaning that up soon.
FreeBSD, I would love to support. But will have to be done as time allows right now. The C++ API is still under a good deal of change and won't be feature complete for a little bit.

Going to close this. Seems to currently build fine on CentOS. And I think Windows builds OK for the moment. C++ still in a state of flux and under active change, though.


Duration Value

Hello,
How do I get once the value is set from the duration widget into controller. I kept the widget in my form while submitting I was unable to get the Duration value and also I did not find the any callback function for set method if we have callback function then it is helpful other things . What do you say ?

@lakhsmi The directive binds the duration value to whatever variable name you pass in the idp-output attribute. It will give out the value in seconds.

@kshaaban- OK. Here is my issues on initialization I set   the value $scope.mileRunDuration = 10 i,e it shows 0:10 as duration time later on I update the to 1:45 as duration time when try to print the   $scope.mileRunDuration it is getting the old one not updated one in the controller any thing wrong with me.

@lakhsmi No, nothing is wrong with you - As a matter of fact, when I wrote the docs/demo, I missed the fact that two-way data binding between parent and children scopes doesn't work as one would expect on primitive data types (the duration in seconds is an integer).
Try passing an object property instead of a scope variable and things should work just fine. i.e.
// Controller:
$scope.durations = {
    mileRun: 10
}

// Template:
<ionic-durationpicker idp-label="Example 1" idp-output="durations.mileRun">
</ionic-durationpicker>

I'll update the docs to reflect that accordingly.
Thank you for bringing that up 👍


Enable fine-grained control over coreos update.

For certain setups, mainly the ones using the Container Linux Update Operator,
it's required to have the CoreOS update-engine enabled while disabling
locksmithd. Previously, you could only enable/disable these together.
Thos patch adds two options so that they can be individually tweaked
while also retaining the old behaviour.
This patch also fixes the test data, as my patch introduced some
whitespace differences.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Add Container Linux specific config options: `disableLocksmithD` and `disableUpdateEngine`, to allow for more fine-grained control over the Container Linux update process.

Thanks!
/lgtm
/approve

/retest


Add a new ORM called Toshihiko

Thanks for the suggestion, but going to pass on this. There's already way too many ORMs in the list.


Remove unused signature features

Describe the problem
For embedded usages of the generated exi code, it would be nice, if some large unused types of XML signature could be excluded from generated exiDocument structure. Especially those which are mentioned as "shall not be used" in e.g. ISO15118-2 standard:

This would free a lot of currently reserved RAM of the exi structure.
Describe your solution
Add a list to config like iso2_fragments, where also xmlsig functions can be filtered. Those structures can be generated, but should not be added to exiDocument and xmlsigFragment struct.
If any of those types appear while encode/decode anyway, an error should be thrown.
Additional context
No response

This is already done for the parameters too to limit the length of the array (though this is also done because of limitations in the generator itself)
A configuration could solve this (i.e. next to the iso2_array_optimizations you'd have the iso2_field_optimizations with an array of field names you don't want in the structs or the en/decoders of these specific fields.
Other fragments of the xmldsig schema can be left out like this too to keep the code size down.
But to me the generator itself by default should focus on creating the "correct" EXI en/decoding and only as an extension of the configuration should it leave out fields that are actually in there.
xmldsig was a mistake.

I have created a branch rebased on recent main, and with a modification to apply the optimizations from PR https://github.com/EVerest/cbexigen/pull/79 to all protocols. (Should be disabled by default though, i.e config commented out. Fragment coding still needs to be fixed as well.):
https://github.com/EVerest/cbexigen/tree/feature/Mike-M0-remove-unused-fragments-PR-79


abstractModel not found

I posted this in issue 187 but since its a closed issue I figured I should open a new one.
I got the abstractModel not found error even after pulling latest code that includes commit ab3e2590.
Fatal error: Class 'InstagramScraper\Model\AbstractModel' not found in /var/www/html/public/wp-content/plugins/crown-tracking/includes/lib/instagram/lib/vendor/instagram-php-scraper/src/InstagramScraper/Model/Account.php on line 9

Looks like Account extends AbstractModel except abstract model is required after Account.php. Abstract Model also depends on the two traits, and needed them to be required prior to Abstract Model. I had to change InstagramScraper.php to this for it to work for me:
<?php

require_once __DIR__ . '/InstagramScraper/Instagram.php';
require_once __DIR__ . '/InstagramScraper/Endpoints.php';
require_once __DIR__ . '/InstagramScraper/InstagramQueryId.php';
require_once __DIR__ . '/InstagramScraper/Traits/ArrayLikeTrait.php';
require_once __DIR__ . '/InstagramScraper/Traits/InitializerTrait.php'; // AbstractModel requires the new traits
require_once __DIR__ . '/InstagramScraper/Model/AbstractModel.php'; // Moved abstract model
require_once __DIR__ . '/InstagramScraper/Model/Account.php';
require_once __DIR__ . '/InstagramScraper/Model/CarouselMedia.php';
require_once __DIR__ . '/InstagramScraper/Model/Comment.php';
require_once __DIR__ . '/InstagramScraper/Model/Location.php';
require_once __DIR__ . '/InstagramScraper/Model/Media.php';
require_once __DIR__ . '/InstagramScraper/Model/Tag.php';
require_once __DIR__ . '/InstagramScraper/Exception/InstagramException.php';
require_once __DIR__ . '/InstagramScraper/Exception/InstagramAuthException.php';
require_once __DIR__ . '/InstagramScraper/Exception/InstagramNotFoundException.php';

Thank you, I had the same problem and your sort order seems to have fixed that!


Use moar builders in tests 👷♀

Changes
In #1043 @EliZucker updated the package names of the v1alpha1 tests to
be v1alpha1_test. He did this b/c he wanted to use a function he was
adding to the builder test package for the work he is doing in #207, but
this has the nice side effect of making it so that we can use more
builders in these tests! (We couldn't before b/c the builders themselves
have to import and use v1alpha1). This commit updates many of these
tests to use builders.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:

[x] Includes tests (if functionality changed/added)
[n/a] Includes docs (if user facing)
[x] Commit messages follow commit message best practices

See the contribution guide
for more details.
Release Notes
n/a

aw no space cat for me :( the /meow plugin can't seem to handle when anything follows it on newlines! 😅
i will do my own space cat:
/meow space


Crash

Version
3.1.3 (cbe02d7)
Seed
R730-RMWK-XNHH4HMZ2YA00QK9KW92YZ1ZGZZZZZZZZZZZZZZZXZZZ
Scenario
RE 1 (Chris)
Player Character
Barry
What happened?
Crashed upon opening the very first door after climbing the dumpster. Right in the beginning.

I am unable to reproduce this


feat(semantic/cfg): add Condition instruction.

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#3567  👈
#3566
#3547 : 1 other dependent PR (#3238 )
#3519
#3473
#3454
#3472
#3462
#3453
#3452
#3451
#3381
#3407
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rzvxa and the rest of your teammates on  Graphite


Azure SDK Review - [IC3 ACS Rooms]

New SDK Review meeting has been requested.
Service Name: IC3 ACS Rooms
Review Created By: Mike Hang
Review Date: 04/08/2024 02:05 PM PT
Release Plan:
Hero Scenarios Link: here
Architecture Diagram Link: here
Core Concepts Doc Link: here
APIView Links: Python, Java, .NET, Javascript,
Description: Follow up review meeting for ACS Rooms SDK GA release which is fully based on the previously appvoved public preview release. There is no changes since the public review release besides the API version.
Detailed meeting information and documents provided can be accessed here

Meeting updated by Mike Hang
Service Name: ACS Rooms
Review Created By: Mike Hang
Review Date: 04/08/2024 02:05 PM PT
Hero Scenarios Link: here
Architecture Diagram Link: here
Core Concepts Doc Link: here
APIView Links: Python, Java, .NET, Javascript,
Description: Follow up review meeting for ACS Rooms SDK GA release which is fully based on the previously appvoved public preview release. There is no changes since the public review release besides the API version. Therefore, there is NO API view detected via the changes. Therefore usingn PR link instead of API view link.
Detailed meeting information and documents provided can be accessed here

Cancelled by: Mike Hang


Fwdport/7.2 7.4

@ironman-machine r+

Hello @rahulreddy
"r+": Success

:hourglass: PR is now pending. CI build url: http://ci.ironmann.io/gh/scality/Integration/19623

:sunny: :+1: circleCI test succeeded!


Light refactor of models based on experience with Predictive, forecasting, and plans for time handling.

[x] n_timepoints_to_simulate should be renamed. Maybe just n_datapoints
[x] We should not pad data inside or outside of the model. Right now we pad and then slice when we could just do neither. Addressed in https://github.com/CDCgov/multisignal-epi-inference/pull/241
[x] There should not be a separate fork if observed_data is None in either model Addressed in https://github.com/CDCgov/multisignal-epi-inference/pull/241

In the context of #304, I realized we have the arguments n_timepoints and duration for seeding processes and processes in general. Shouldn't all be named duration, @damonbayer @dylanhmorris?

Shouldn't all be named duration, @damonbayer @dylanhmorris?

In https://github.com/CDCgov/multisignal-epi-inference/issues/156, we standardized on n_timepoints, but I think we should do something with time units for these arguments.

New issue to discuss/decide this?


Add exchange UpBit

Please provide as much information as possible to make the addition of the exchange easier:
Exchange API URL
https://docs.upbit.com/docs/upbit-quotation-websocket
Additional information about Websocket connection
Documentation in Korean.  WebSocket supports Tickers, Trades, and L2 Orderbooks Updates (snapshot provided on connection).
BasicClient can probably be used, it looks like the socket allows subscribing to more than one feed per connection.

Refer to Contributing Guide for additional information.

Create client in src/exchanges that follows CCXWS library interface (refer to README)
Create client test suite in src/exchanges to validate subscribe/unsubscribe methods and that data parsing is correct
Add a lowercase export to index.js
Implement subscribe to tickers sending logic

must support calling subscribe multiple times in a row with different markets

Implement subscribe to trades

must support calling multiple times in a row with different markets

Implement subscribe to orderbooks/depth

should default to highest limit and smallest resolution interval
determine if exchange supports snapshots, updates, or both
if exchange supports broadcasting depth updates, CCXWS should initiate a snapshot request when subscribe for a market is called and broadcast a snapshot event

Please push update to npm. Thank you!

@OnlyC, will have a few updates (including this) this week. Thanks!


Twitter widget id is not a thing that exists anymore

Twitter has changed their system, and the widget id is not a concept that exists anymore. Since it is a required box when editing the event settings, this should ideally be addressed, as I had to fill it with nonesense

6 months.. anyone?


Review messaging in KN-PMP

This MR:

resolves #425
does some more docstring clean up

xref #414

I need to update the test for this. Will push up a fix shortly.


Seven segment display extension

Generalized 7-segment display extension to make widgets for counters or customized digital displays to add to a game.
The display format has styles for both segment thickness and scale. Here's a sample of some:

You can make a multi-counter display for stuff like a 24 hour LCD digital clock:

A simple 5 digit display is coded like so:

This is really cool!

This is AWESOME!!!

I'm wondering if there is a better way to draw the segments. They're essentially vectors so it would be nice if you could have counters of varying sizes other than just the 2. Maybe not expose that functionality in blocks, but it would be nice for JavaScript.
This would also be a great case to use a fillPoly function (not to be confused with polyFill) in image.cpp. We should look into implementing that.

@ChaseMor I played with dynamic scaling earlier but the digits ended up looking ugly. The pixel size (dpi) starts to be the limiting factor. I just chose to have two sizes for simplicity. The draw could be optimized and done at once for each segment rather than multiple drawLine() calls.

@ChaseMor we could put just the general digit drawing code into its own cpp file and go after the image buffer directly for full optimization (only draw or clear pixels that will change, etc.).

@ganicke is this good to merge?

Sure, I can add any new tweaks in a later PR.


Cannot access protected property InstagramScraper\Model\Media

Hello! I installed via composer (composer require raiym/instagram-php-scraper) and apparently all installed correctly, no errors were shown. But when I try a test like:
`
error_reporting(E_ALL);
ini_set('display_errors', '1');
require_once 'vendor/autoload.php';
use InstagramScraper\Instagram;
use InstagramScraper\Model\Media;
$instagram  = Instagram::withCredentials('myuser', 'mypass');
$instagram ->login();
$posts = $instagram->getTopMediasByTagName('smsda');
print_r($posts);
foreach ($posts as $i => $post) {
echo ($i) . '. ' . $post->caption . PHP_EOL;
}
`
I get "Fatal error: Cannot access protected property InstagramScraper\Model\Media::$caption in ... test.php"
the print_r shows me
Array (     [0] => InstagramScraper\Model\Media Object         (             [id:protected] =><PHONE_NUMBER>186982284             [shortCode:protected] => BarozXFFHGM             [createdTime:protected] =><PHONE_NUMBER>             [type:protected] => image             [link:protected] => ...
what am I doing wrong?
Thx so much in advance!

$post->getCaption()

I will change documentation

wow, thx raiym!

sure


Improve login button

Suggestions on login button at home page.

I'm taking up this one, alright?

I guess we might consider improvement on design of sign up/ sign in forms also?

LMK your thoughts on these

K, I got it, we should make it looks like on other pages:

@RusinovAnton Yeah feel to take this issue. and yes we need to work on improving signup and login forms as well.


sanitize_html: append rel attributes instead of overriding

Document why this is safe, it's not obvious to me. Is it? Do we currently pass-through rel? Is rel a safe thing to inject?

Do we currently pass-through rel?

rel is currently an always-allowed attribute, so by default a pass-through: https://github.com/google/dart-neats/blob/master/sanitize_html/lib/src/sane_html_validator.dart#L133
However, if you have a return value from the addLinkRel, it overrides it. I think the current behavior should have either a setLinkRel callback, or the addLinkRel should append the attributes from the callback. In other words, I consider this a bug-fix, and not a new feature.


Alignment of the project section should be altered

The alignment of the project section is currently off. The project cards are not evenly spaced, and the text appears misaligned in some cases.
Proposed Solution:
Implement a responsive grid layout (using CSS Grid or Flexbox) to ensure even spacing between project cards on all screen sizes.
Add consistent margins and padding around the project items.
Ensure the text inside each project card is properly centered and aligned.
Test the alignment on different devices and screen sizes to ensure a responsive design.
Please assign me this issue under gssoc'24 extd and hacktoberfest 2024.
Thank you

This problem is solved.
So i am closing this issue.


Adjust RBAC to run on OpenShift

Checklist

[x] The title of this PR would make a good line in Acorn's Release Note's Changelog
[x] The title of this PR ends with a link to the main issue being address in parentheses, like: This is a title (#1216). Here's an example
[x] All relevant issues are referenced in the PR description. NOTE: don't use GitHub keywords that auto-close issues
[x] Commits follow contributing guidance
[ ] Automated tests added to cover the changes. If tests couldn't be added, an explanation is provided in the Verification and Testing section
[x] Changes to user-facing functionality, API, CLI, and upgrade impacts are clearly called out in PR description
[ ] PR has at least two approvals before merging (or a reasonable exception, like it's just a docs change)

This PR is related to issue #1834 in that it adds the ability to run acorn runtime on OCP.
This PR does the following:
- Add acorn-image-system ClusterRole, ClusterRoleBinding, and SA
- Bind nonroot-v2 SCC to acorn-image-system ClusterRole
- Bind nonroot-v2 SCC to acorn-system ClusterRole

As a side note, the registry and controller pods seems to work fine as any UID, but apiserver requires UID 1000 for some stuff at the moment. Later, should evaluate if the apiserver deployment can move to any UID. I hit permission errors with the apiserver.local.config certs directory when trying to move to any UID.
This is my first PR to this repo, so if I'm missing anything here, please feel free to correct me. I tried running make test but started hanging partly through the integration suite, so I might need to configure something else for OCP here. I still want to get this PR open/reviewed for general feedback, so I'll work on getting my test setup going in the background. I didn't add unit tests as I think this is covered by the repo's existing integration tests/deployments being functional.
I don't think there are upgrade impacts here as both the registry and controller deployments seem to function as any UID already.

The changes here seem simple enough.  The only issue is that if we do accept these changes we really have no idea going forward if openshift will work. We don't test on OpenShift. So I have no problem accepting this PR, just that we are basically just expecting the community to tell us if we happen to break OpenShift.
@thedadams When you get a second can you review this one?

Sure thing, thanks @ibuildthecloud. I was just trying out the project and figured I would help out since it was fairly easy.


Missing stop service command missing

Post
daytona purge
sudo rm $(where daytona)

Missing stop service command missing

@Tpuljak should this be closed?


engine/java:chore - updating log4j rule to avoid false positives

Signed-off-by: Nathan Martins<EMAIL_ADDRESS>
- What I did
- How to verify it
- Description for the changelog

Fixes https://forum.zup.com.br/t/falso-positivo-log4j/354

Can we add a test case for this?

Can we add a test case for this?

yeah the case Sample5MavenSafeHSJAVA150 have coverage for this scenario


Diff between commits

First and foremost, this it an awesome package, just what I was looking for! I came across this and spent some time reading the docs, but couldn't find reference to how git-diff can be done, similar to https://godoc.org/github.com/libgit2/git2go#Diff. I noticed that there's https://godoc.org/gopkg.in/src-d/go-git.v3/diff, but this is more for comparison of the contents between a src and dst, which is different from retrieving a list of the diff files between two commits. Is functionality not available in go-git, or did I miss it in the docs?

The Diff entity is the bare part of the diff, but currently we don't provide a direct method from a commit for retrieve the diff from the previous file or tree. Sorry

@mcuadros @ajnavarro I was actually trying to use this and it is able to create a patch, but for my use-case, I need to create a format the patch with extra lines in the context which we are able to achieve via format-patch option
       -U<n>, --unified=<n>
           Generate diffs with <n> lines of context instead of the usual three. Implies --patch.

Is there any similar option available in the library?