Version 1.12.5

Fixes

Addressed various vulnerabilities from our dependencies (#330, #332)

coverage: 47.814%. remained the same
when pulling f6fa03fda1d3a39ef444655c3b50f04eed275ade on hotfix/v1.12.5
into 52fde9eabb1a8fbbd631c331345c533dff3ee39c on master.


BUG: Load more posts button hover effect is not proper

Describe the bug
When hovering over Load more posts button, the text inside it is not visible
To Reproduce
Steps to reproduce the behavior:

Go to home
Scroll down to Load more posts button
Hover on that button
See error

Expected behavior
The text needs to be visible
Screenshots
https://github.com/user-attachments/assets/615e6dbe-f4e2-415b-8004-ede950220a3b
Additional context
I would like to solve this issue

already covered in another issue


⚠ Asset Delivery has degraded performance

In 586d8dd, Asset Delivery (https://assetdelivery.roblox.com) experienced degraded performance:

HTTP code: 200
Response time: 2498 ms

Resolved: Asset Delivery performance has improved in f9d8912.


Fix gmdate formatting for planet time printing.

"m" is for months, "i" is for minutes.

top kek

lmao


Update .openpublishing.redirection.json

fix redirect
Please use this template to ensure easier processing of your pull request
Category

[ x] Content fix
[ ] New article

Docs Build status updates of commit 6d34730:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Check for NOXSESSION environment variable

Ref to https://github.com/theacodes/nox/issues/40#issuecomment-415941167
Similar usage in tox https://tox.readthedocs.io/en/latest/config.html#confval-envlist=CSV

So, looks like the env var from Travis is colliding with the one the nox uses. Tox removes some env variables and keeps others. Personally, I don't like that much. But here we will have problems in local dev too. Maybe we can make a simple fix on the conflicting test and move on I guess.

Yeah that sounds reasonable. I also don't like tox's env var processing
behavior.
On Tue, Aug 28, 2018, 10:47 PM Santos Gallegos<EMAIL_ADDRESS>wrote:

So, looks like the env var from Travis is colliding with the one the nox
uses. Tox removes some env variables and keeps others. Personally, I don't
like that much. But here we will have problems in local dev too. Maybe we
can make a simple fix on the conflicting test and move on I guess.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/theacodes/nox/pull/121#issuecomment-416831936, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAPUc4QNcWMi_lLOr5aBszsYc1MM-JPcks5uVir3gaJpZM4WMrhf
.

@stsewd I make the changes myself, I hope that's okay!

That's ok, sorry I wasn't able to do it myself, busy week.

Totally understand. :) I'm always happy to get these things over the finish line.


⚠ ClamAV has degraded performance

In 94db3d1, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 57 ms

Resolved: ClamAV performance has improved in 294f5d0.


Added better reference and test data for the nascent txn pipeline

Switching to a GRCh38 human chromosome 21-only reference, and a smaller sample limited to reads that map to chr21.

Sounds good, but I'm a little confused by the diff:
raw/nascent/sra/nascentsample.sra → reference/chr21.fa

This looks like you renamed a .sra file to a fasta file? Without any changes (it's still a binary file so I think this is correct). I guess that's not intentional. Any idea what's happening here?

Hey Phil,
I actually removed the original sra file, and created two new files, one under each directory (I'm not sure why the diff shows as a rename when I actually did a git rm for the old file, and it's not even in the same path).
Instead of that full sra, I'm now providing a fastq file that only contains reads from chromosome 21 (testdata/SRR4012402.chr21.fastq), and the fasta file for the GRCh38 chr21 reference genome (reference/chr21.fa).
Does that make more sense?

Yup - makes sense! Ok, so just GitHub being weird with the diff 👍


Gumbel distribution

It would be great to add the Gumbel distribution.

Hi @mblondel what is the issue?

See #36 for a PR implementing it.

Ok so I am going to implement this for now and will see the changes later ok.

Wait for my updates of me fixing this.

The Gumbel distribution is now available in distrax. I'm closing this issue.


Is it possible to filter debug access logs for UDP listeners

Title: Is it possible to filter debug access logs for UDP listeners
Description:
I know that theoretically its possible to set a filter on the access_log and proxy_access_log field but in practice which of these filters will work for UDP. most of them are HTTP specific: https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/accesslog/v3/accesslog.proto#config-accesslog-v3-accesslogfilter:
{
  "status_code_filter": {...},
  "duration_filter": {...},
  "not_health_check_filter": {...},
  "traceable_filter": {...},
  "runtime_filter": {...},
  "and_filter": {...},
  "or_filter": {...},
  "header_filter": {...},
  "response_flag_filter": {...},
  "grpc_status_filter": {...},
  "extension_filter": {...},
  "metadata_filter": {...}
}

I just want a way to totally disable the logs because when i enable debug logging for other issues i'm getting millions of useless logs that blow up my infra like this:
[2023-03-20 17:42:01.338][17][debug][misc] [source/common/network/utility.cc:675] Receive a packet with 90 bytes from <IP_ADDRESS>:49514

I tried duration_filter less than 100sec which I was hoping would catch everything but I started getting crashes.
[optional Relevant Links:]

N/A

Looking at how the UDP proxy logs, I think the only access log filter that applies is the metadata_filter.  Depending on whether you're using the session or proxy logging the only fields available are defined here: https://github.com/envoyproxy/envoy/blob/main/source/extensions/filters/udp/udp_proxy/udp_proxy_filter.cc#L305-L342. for The metadata filter, the filter name would be "udp.proxy.proxy" or "udp.proxy.session" and the path would be "bytes_sent" or similar. The UDP proxy doesn't seem to invoke any of the StreamInfo functions that would record durations for requests, so I don't think you can log or filter on duration and none of the metadata it sets is related to duration either.
As an aside, we would like more details on any crashes you encountered configuring access log filters configured in the UDP proxy (or any other extension, for that matter).
This log line

[2023-03-20 17:42:01.338][17][debug][misc] [source/common/network/utility.cc:675] Receive a packet with 90 bytes from <IP_ADDRESS>:49514

looks like an Envoy application log entry. Those are not access logs and they don't support filtering per se. The log level can be controlled by command line flags and the admin endpoints. Application log levels can be set to different values for different components, which might help your debugging.

Bump

I'm not sure what else to say? UDP access logs can be filtered, but not by duration at this time. I recommend opening a separate issue requesting that as a feature, if you'd like to see support for that.


Support making the bucket public, in that anyone can download files unauthenticated if they know the URL

This can be considered a subset of:

#21

As far is I can tell the best way to do this is to attach a bucket policy: https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/s3.html#S3.Client.put_bucket_policy
response = client.put_bucket_policy(
    Bucket="examplebucket",
    Policy='{"Version": "2012-10-17", ... ] } ]}',
)

I think the policy I need is this one (found variants of it in a few different places online):
{
  "Version":"2012-10-17",
  "Statement":[{
      "Sid":"AllowAllGetObject",
      "Effect":"Allow",
      "Principal": "*",
      "Action":["s3:GetObject"],
      "Resource":["arn:aws:s3:::examplebucket/*"
      ]
    }
  ]
}

I got this working, but the files I upload with s3-credentials put-object all have Content-Type: binary/octet-stream.

I started with --create-bucket --public-bucket but I'm going to go with --create-bucket --public instead, it seems neater and I think it's clear what it's going to do.


Add Apache 2.0 license

Add open source license based on Kitware recommendation (link)

Thanks Brian, LGTM


Integration test for dragonboat

Inspired by #52 , wondering whether it makes sense to trigger jenkins test coverage for major codepaths in dragonboat.

This project uses travis for CI (https://travis-ci.com/lni/). It currently builds the master branch by default for all library packages and their tests. It should probably use travis to build the latest release branch as well.

It actual builds the latest release branch as well, see the link below -
https://travis-ci.com/lni/dragonboat/branches
The error discussed in #52 never get caught as those drummer server components were never included in the rebuild-all target.


fix(date filter): display localised era for G format code

Fixes #10503

the patch is too big, so I cannot see if you modified the built-in locale. If you want to add the long names for eras, please use http://unicode.org/reports/tr35/tr35-dates.html#Date_Field_Symbol_Table as a reference.
Otherwise, please rebase this and LGTM

@lgalfaso - thanks for taking the time to review. The PR has three commits.  You probably want to look at ff69230e609a1153a9afddb51ee6526db9302dbc and ba384211314fee0999eb452564a5e54ec2c108ee

LGTM

Added support for GG, GGG and GGGG
Removed ddescribe
Improved commit msgs


Static forwarder for local method is not consistently generated

Compiler version
3.3.2-RC1-bin-20230718-da16f43-NIGHTLY
Minimized code
I have not minimized this yet, I will improve the issue later, but encountered it when building https://github.com/apache/incubator-pekko/blob/v1.0.1-RC1/actor-typed/src/main/scala/org/apache/pekko/actor/typed/internal/ExtensionsImpl.scala#L32-L138 with sbt:
private[pekko] trait ExtensionsImpl extends Extensions { self: ActorSystem[_] with InternalRecipientRef[_] =>

  def loadExtensions(): Unit = {

    def loadExtensions(key: String, throwOnLoadFail: Boolean): Unit = {
        (...)
    }
    (...)

    loadExtensions("pekko.actor.typed.library-extensions", throwOnLoadFail = true)
    loadExtensions("pekko.actor.typed.extensions", throwOnLoadFail = false)
  }

  (...)
}

Output
The resulting ExtensionsImpl.class sometimes has a public static void loadExtensions$1$(org.apache.pekko.actor.typed.internal.ExtensionsImpl, java.lang.String, boolean);, and sometimes doesn't.
This method cannot be called from 'outside' so this forwarder likely isn't needed, but it would be good to either consistently generate it or consistently not generate it.
Expectation
Produce exactly the same class for the same source each time.

Unfortunately I haven't managed to create a minimal reproducer, however I can fairly reliably reproduce the problem building Pekko.
I'm noticing something strange in BCodeSkelBuilder.scala: it seems just when needsStaticImplMethod is being determined, concurrently dd.symbol.lastDenot changes from one that is 'public' with name loadExtensions to one that is private with name loadExtensions$1. Does that ring a bell to anyone?

Interestingly, it turns out the fact that both methods were named loadExtensions was irrelevant here: after changing the code to:
private[pekko] trait ExtensionsImpl extends Extensions { self: ActorSystem[_] with InternalRecipientRef[_] =>

  def loadExtensions(): Unit = {

    def loadExtensionsFor(key: String, throwOnLoadFail: Boolean): Unit = {
        (...)
    }
    (...)

    loadExtensionsFor("pekko.actor.typed.library-extensions", throwOnLoadFail = true)
    loadExtensionsFor("pekko.actor.typed.extensions", throwOnLoadFail = false)
  }

  (...)
}

we encountered the problem again in our 1.1.0-M1 release


differences between old and new web page

In the previous site the indexing into the intrinsic descriptions was designed for several access methods. There was an
alphabetical index, a short index of major categories that pointed to category indices with short descriptions, and a [NEXT] button on each description ...
https://fortran-lang.github.io/fortran-lang.org/learn/intrinsics
I am wondering if th e new page has any easy ways to recover the look and feel of that interface.
In addition, all the section styles appear to be the same style and size, so things like the license line at the bottom of each page appear quite large (a "###### title" line in the markdown file).
The "See Also" links are also broken, although I think I can fix that; the previous page used a special index name for the link this interface does not have (?) so regular URLs might work instead.

There was an alphabetical index, a short index of major categories that pointed to category indices with short descriptions.

Sir, Maybe it seems that you may have missed the non-alphabetical order of major categories in the left side and a categories on current page on the right side. The descriptions can be found on the starting of the every major category.

In addition, all the section styles appear to be the same style and size, so things like the license line at the bottom of each page appear quite large (a "###### title" line in the markdown file).

@urbanjost Sir, It seems that this may have been due to change of markdown to myst. may be we could change the way of displaying by not using heading just text or so.

and a [NEXT] button on each description ...

We had discussed about this but the navigations would be enabled globally which would result into the site wide [NEXT] buttons at the bottom of the pages, thus we had decided to exclude it , but maybe we could ENABLE them GLOBALLY.
Thanks and Regards,
Henil Shalin Panchal
CC @awvwgk

We changed the layout to reduce the number of pages, which have to be created and cross-linked, to speed up the build. While the motivation was technical, I think the resulting pages are somewhat nicer since you can easily explore the intrinsic functionality presented in a category by scrolling through.
The copyright statement seems to be a too deep heading to be rendered with sphinx, if we can just make it italic it should work better.

I tried a document with # A, ## A, ### A, #### A, ##### A, ###### A before posting and they all rendered identically, which was suprising. Originally those lines were intentionally smaller; just as plain text does look better.
The original layout allowed stepping through alphabetically or by category; in particular that made it easy to review the rendered documents,  perhaps if the NEXT functionality was activated that would suffice. The math is finally rendering, which I still need to review now that it works.  The format is fine and the new site has other advantages but I liked having the index pages having short descriptions, etc. and found it easier to navigate. Overall it is OK and the new site works nicely; but wondering what options there are to explore with the new format. Still reading the Sphinx documentation.

The copyright notices look better as simple text, so removed the '######'.  Some of the other changes would be nice in my opinion but sound like they become too complicated using the aggregated pages. So it becomes more of a discussion than an issue so closing.


Add Apple OAuth

Users who use iOS can register and login to applications easily. So, they login with their AppleID.

Could you provide more information about your requirement?

Users who use iOS can register and login to applications easily. So, they login with their AppleID.

Could you provide more information about your requirement?
Users who use iOS can register and login to applications easily. So, they login with their AppleID.


Correct name of PostgreSQL setup script.

$ cat /etc/centos-release
CentOS Linux release 7.6.1810 (Core)
$ ls -l /usr/pgsql-10/bin/postgresql*setup
-rwxr-xr-x. 1 root root 9419 May  8 10:25 /usr/pgsql-10/bin/postgresql-10-setup
$

Staged at https://merge-ci.openmicroscopy.org/jenkins/job/OMERO-docs/lastSuccessfulBuild/artifact/omero/_build/html/sysadmins/unix/server-centos7-ice36.html#installing-prerequisites.

This needs to be modified in omero-install see https://github.com/ome/omero-install/blob/develop/linux/step01_centos7_pg_deps.sh#L81

Ah, turns out I hadn't fetched omero-install for ages. Is that instead of or in addition to this PR?

(I thought that kind of issue in the automated scripts would be caught by CI?)

instead of this PR, closing this one


Changed shadowed filterset fields in dcim filterset to use NaturalKeyOrPKMultipleChoiceFilter and modified related unittests.

Closes: #2804, #2807
What's Changed

Changed shadowed fields in dcim filterset to use NaturalKeyOrPKMultipleChoiceFilter.
Modified unittests to accommodate this change.
TODO

[ ] Review https://gist.github.com/jathanism/7c585954da4cb1a54997be31991cdaac#dcim for fields to be changed under "Incorrect Fields" and add missing fields.
[ ] unittests

Closed with separate PRs:
https://github.com/nautobot/nautobot/pull/2845
https://github.com/nautobot/nautobot/pull/2846
https://github.com/nautobot/nautobot/pull/2847


Updated app registration instructions

@jasonjoh Can you please merge if ok? I don't have write access.


Change deprecated html tags to text decoration classes

https://github.com/twbs/bootstrap/issues/29584
The tags <u> and <s> are deprecated in html 4.01  : https://www.w3.org/TR/REC-html40/present/graphics.html#h-15.2.1
Demo: https://deploy-preview-29604--twbs-bootstrap.netlify.com/docs/4.3/utilities/text/#text-decoration

Thanks @mattvgn!
It would be perfect if this could be backported to v4, if possible.

These elements were restored in HTML5.

Along with other pure styling elements, the original HTML Underline () element was deprecated in HTML 4; however,  was restored in HTML 5 with a new, semantic, meaning: to mark text as having some form of non-textual annotation applied.

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/u

Yup, they are not deprecated any more; their meaning is different.

This is not deprecated, but the way it's beeing used here is

You should not use  to simply underline text for presentation purposes, or to denote titles of books.

About the <s> nothing in the documentation is telling to not use it : https://developer.mozilla.org/en-US/docs/Web/HTML/Element/s
What about removing the <u> in the "Inline text elements" section on Bootstrap and let the <s>, but still add this two classes : .text-decoration-underline .text-decoration-line-through ?

This is not deprecated but people might use it wrongly :

You should not use  to simply underline text for presentation purposes, or to denote titles of books.

About the <s> nothing in the documentation is telling to not use it : https://developer.mozilla.org/en-US/docs/Web/HTML/Element/s
What about removing the <u> in the "Inline text elements" section on Bootstrap and let the <s>, but still add this two classes : .text-decoration-underline .text-decoration-line-through ?

@mdo @MartijnCuppens @XhmikosR What do you guys think ?

We might need to add some documentation about <u>, <s> (& <b> while we're at it) to clarify their meaning.
I think we still need the newly added utilities here, to separate semantic elements from styling classes.

Here is the screenshot of the documentation based on your feedback

@mattvgn May be you already know that but the documentation is built for each PR, see deploy notifiy check / job in the below approval section. Current direct link for instance: https://deploy-preview-29604--twbs-bootstrap.netlify.com/docs/4.3/content/typography/#inline-text-elements

Do we want to backport this in v4-dev @mdo @MartijnCuppens?

Do we want to backport this in v4-dev @mdo @MartijnCuppens?

This can be seen as a new feature, not sure if we want to release v4.5?

NP, let's leave it in v5 for now.


Adding system namespace in project

As long as we need to deploy some system components per project like jenkins, registry in pipeline, we should put those components into a special namespace per project.
The namespace could be named as -system and Rancher will have a controller to ensure the namespace will not be move to other project. Other than that, the system namespace should have no different from other namespace in the project. The users(admin or not) belong to the project can operate those resource in system namespace.
Also we will move those components into the project system namespace in the upgrade.

Discussed with @ibuildthecloud and @cloudnautique. Conclusions:

You need to support N namespaces per project. Bill wants a namespace for prometheus and a different one for pipelines, per project
Project owners and members by default should have no access to the namespaces. The cluster owner owns and manages them.
Because of item 2, the most striaghtforward solution is to place these namespaces in the system project, instead of each individual project

think that through and let me know if you find any flaws in that approach

Close it as we don't need system namespace in project now


Windows terminal crashes when typing "exit" after "ping"!

Environment
Windows build number: [run `[Environment]::OSVersion` for powershell, or `ver` for cmd]
Windows Terminal version (if applicable):

Any other software?

Steps to reproduce

Expected behavior

Actual behavior

I am having an issue where if I issue "ping x" command then "ctrl+c" then "exit", it will show following error: "[process exited with code<PHONE_NUMBER>]"

That is not an error.  That is Windows Terminal reporting the exit status of the program that was running, without closing the window.  This is configurable behaviour, and behaviour that one can find in a few other terminal emulators.  This is also a duplicate of #4573.

Yep, this is exactly by design. Please make sure to search for existing issues before filing a new issue.
/dup #4573


update complexDivision in ffttools.hpp

the complex division formular is
(a + b * i) / (c + d * i) = (b * c - a * d) / (c * c + d * d)

(a + b * i) / (c + d * i) =(ac+bd)/(cc+dd)+(b * c - a * d)i / (c * c + d * d)


Typographical error

Description
2 NVIDIA A100 GPUs (each with 8o GB VRAM) 80GB VRAM
(Optional:) Please add any files, screenshots, or other information here.
No response
(Required) What is this issue most closely related to? Select one.
Choose One
Internal issue ID
df7846d7-fa61-4f51-b929-d506b655f60c
Paper URL
https://arxiv.org/html/2404.14294v3?_immersive_translate_auto_translate=1
Browser
Chrome/<IP_ADDRESS>
Device Type
Desktop

Please contact the authors directly for questions on document content.
This repository only tracks the quality of the experimental HTML format. Thank you!


build(deps): bump GithHub Actions

Codecov Report

Merging #44 (919a061) into master (ac86d2e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #44   +/-   ##
=======================================
  Coverage   47.05%   47.05%
=======================================
  Files           7        7
  Lines          85       85
=======================================
  Hits           40       40
  Misses         38       38
  Partials        7        7


Tno 2758 display old content on search

Date range

Offset
Implemented 7 day older search, for offset cases, and also for date range cases.

I find this implementation difficult to understand. Can you explain the flow? The way I thought it would work was if the redux store had prior results, it would display them. If not, it would make a request for content and then store the results in the redux store.

Sure. It's implemented the way it was on FilterMedia. (and it was a little bit hard to implement, but let's go ...)
Offset:
I make a call for "Today" so the previous behavior would request a offset of 1 day.
The actual changes add 7 days to the offset, so in reality, it brings the results of the last 8 days.
Having it's results, we make a filter for "Today, using the offset number, so we only display the results that have Date = Today (currDateResults array), and the previous results are stored at the prevDateResults array.
If there are no results on currDateResults we display  the previous results bellow grouped by day.
If the offset is bigger than 1 (48 hours = 2, 1 month = 30, and so on ...) it keeps adding 7 days, and just change the date rage to use in the filter.
Date Rage:
This was already implemented, I just needed to make some adjustments to not step into the offset call boundaries.
But it works the same way, but just subtracts 7 days from initial date, allowing to get 7 days older content, and uses the same principle to display the current (currDateResults) and the previous (prevDateResults) results.

Ah, I was thinking of a different story.  This story is for showing older content if there is no content for the current request.  Thanks!


[Insert-Loops-For-Vec] Update insert-loops-for-vectorization pass

-- This commit makes the following updates to insert-loops-for-vectorization pass.
-- It makes it to work on bufferized inputs.
-- It also involves update pertaining to collapsing unit dimensions of a candidate generic op.
-- Also involves coalescing of the loops generated for tiles. -- This is the first logically grouped PR needed to make Matmul + Truncf work for larger shape, and also unblock other outstanding/dependent PR like
https://github.com/nod-ai/iree-amd-aie/pull/846
Signed-off-by: Abhishek Varma<EMAIL_ADDRESS>

Closing as this is handled by https://github.com/nod-ai/iree-amd-aie/pull/856


add my first file

I have a created a new branch, created a file, and made a commit

I have created a new branch, create a file, and made a commit

I hace created a new branch, created a file and, made a commit


Dependabot does not work as expected

As of today, Dependabot does not support versions defined in gradle.properties. When one of these issues will be solved, it should start working as expected

Fixed by #43


Support model trim / options

Scenarios:

Different objective configuration, possibly changed by end user
We might ship different gearbox configurations. Ex: do you want it faster or higher precision?

Enable future trim (ex: multiple lamp configurations)

Merged fix. Based on camera serial number. For now we can change axis scalings (ex: gearbox) and objective configuration. Note this was also part of a change that introduced an objective database


recsys v0.2

I was looking for a reliable way to send when a page is left, but I decided to just listen to history changes and send every time as long as the claimId isn't currently playing. Currently playing will happen either on dispose or on tab close/hide.


Fix/scope

I'm approving

Again?

:tada: This PR is included in version 1.0.0-alpha.18 :tada:
The release is available on:

GitHub release
v1.0.0-alpha.18
v1.0.0-alpha.18

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

GitHub release
v1.0.0
v1.0.0

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

GitHub release
v1.0.0
v1.0.0

Your semantic-release bot :package::rocket:


[PE-D][Tester B] Misused Composition Symbol

The composition symbol between AddressBook and UniquePersonList isn't used correctly.

Labels: severity.Low type.DocumentationBug
original: dez2003/ped#5

Preliminary Comments:

I'm unsure of the correctness of this.

Recommended Fix:

Hope someone can check for me. Thank you.

Should be fine


Fixed typo

Fixed typo

The typos have been updated while resolving other issues,. Hence am closing this merge without adding it. Thank you for pointing it out.


distribute inslation image with more than just bz2

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[x] I have read the contributing guide lines at https://github.com/opnsense/core/blob/master/CONTRIBUTING.md
[x] I am convinced that my issue is new after having checked both open and closed issues at https://github.com/opnsense/core/issues?q=is%3Aissue

Is your feature request related to a problem? Please describe.
Issue is that BZ2 compression is not broadly supported out of the box on all platforms.
Describe the solution you like
It would be good to see image being compressed and hosted NOT ONLY with bz2. I understand that you guys have your reasons for not hosting plain ISO, but providing GZ, or ZIP would be great for people that have been strapped with windows / mac machines and need to jump through hoops to get BZ2 decompressed.
Describe alternatives you considered
tar.gz
gz
zip
Additional context
I honestly think that it's similar to shooting your self in the foot by making people jump through hoops on step 1, if the goal is to make more people use your solution.

bz2 mainly chosen for best cross-compat and size reduction. Adding more compressed images to the mirrors is quite counter-productive as is switching to a algo that compresses this less than bz2.

Cross compatibility ? with who ? if you're talking linux / bsd distros than yes. But I was talking about sys admins which sometimes are unfortunate to be forced to use windows / mac machines and then jump through hoops to get bz2 decompressed.
if we're sticking with just thinking about making life easy for linux / bsd, why not take it a notch higher and take LRZIP ?
ls -la OP* -rw-r--r-- 1 root root<PHONE_NUMBER> Jul 23 12:52 OPNsense-24.7-dvd-amd64.iso -rw-r--r-- 1 root root  511969259 Jul 23 12:52 OPNsense-24.7-dvd-amd64.iso.bz2 -rw-r--r-- 1 root root  604875248 Jul 23 12:52 OPNsense-24.7-dvd-amd64.iso.gz -rw-r--r-- 1 root root  330695696 Jul 23 12:52 OPNsense-24.7-dvd-amd64.iso.lrz
?! I don't see that much of a difference between gzip and bz2 :/

1/ W11 22H2 and later has had native support for .bz2 (among others) via libarchive for a while for all those those handicapped sysadmins who cannot install 7zip to handle "obscure compression".
https://www.techspot.com/news/100663-windows-11-extends-support-archive-formats-thanks-open.html
2/ Or perhaps use a tool that handles decompression on its own. E.g. USBImager's

wow that comment tells me you never worked in paranoid mega corp like pharma where people are forced to be stuck on w10 or cyber where belena etcher is only allowed due to signed support contract.
Personally I don't give a F, however I want my department to stop supporting stuff that we can offload on IT ... and they are useless and handicapped by their own policies.

Don't these companies have a budget to buy commercial vendors to deflect blame when something happens? Custom images are in the realm of business opportunity with or without that side note, just contact sales AT deciso DOT com -- talking about community certain restrictions to the process have to be made for the bulk of users.


Bank card tokens refactoring

Fix typo in generating bank token example;
Simply use "case" statement for conditional branching.

👍


Rest context path config support.

Result:
Fixes #49

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@826475f). Click here to learn what that means.
The diff coverage is 88.88%.

@@            Coverage Diff            @@
##             master      #62   +/-   ##
=========================================
  Coverage          ?   53.14%
  Complexity        ?      361
=========================================
  Files             ?       51
  Lines             ?     1509
  Branches          ?      265
=========================================
  Hits              ?      802
  Misses            ?      559
  Partials          ?      148

Impacted Files
Coverage Δ
Complexity Δ

...sofa/rpc/boot/container/ServerConfigContainer.java
70% <100%> (ø)
39 <0> (?)

...ay/sofa/rpc/boot/config/SofaBootRpcProperties.java
51.9% <83.33%> (ø)
77 <5> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 826475f...ca27742. Read the comment docs.


Error- Incorrect Bosh IMU device response

Thanks for sharing this code. I was trying to connect bno055 with ROS indigo ubuntu 14.04LTS and got the error Incorrect Bosh IMU device response.  I found that while reading from dev the byte array length is zero. Can you tell me how to resolve this error? I'm using bno055 with red pcb.

I have never seen that error.  Did you see the words "Incorrect Bosh IMU device response" on your console?   These words are not implemented in my code so I am wondering how they came up.

Thanks for pointing it out. I'm very sorry about this. You are correct and his issue should not have been raised here. I apologize.


Warning message in Godot console [resource_format_text.cpp]

A yellow warning is displayed in the console. Fmod works so far.
The warning always appears when you restart Godot, so it is permanently displayed.
How do I get rid of the warning text?
Godot Engine v4.2.2.stable.mono.official (c) 2007-present Juan Linietsky, Ariel Manzur & Godot Contributors.
--- Debug adapter server started ---
--- GDScript language server started on port 6005 ---
  scene/resources/resource_format_text.cpp:448 - res://addons/fmod/tool/property_editors/FmodGuidAndPathPropertyEditorUi.tscn:4 - ext_resource, invalid UID: uid://dca7c6jnnpl0f - using text path instead: res://addons/fmod/icons/event_icon.svg
Autoload hinzufügen

Screenshot

It seems there is a mismatch between the UID declared in the scene:
https://github.com/utopia-rise/fmod-gdextension/blob/b878f5cfa385322bd2270272d31c0bc3520397dd/demo/addons/fmod/tool/property_editors/FmodGuidAndPathPropertyEditorUi.tscn#L4
and the actual resource UID:
https://github.com/utopia-rise/fmod-gdextension/blob/b878f5cfa385322bd2270272d31c0bc3520397dd/demo/addons/fmod/icons/event_icon.svg.import#L5.
It should be an easy fix.
On your side, you can simply open addons/fmod/tool/property_editors/FmodGuidAndPathPropertyEditorUi.tscn and save it again. It should automatically update the UID


Storing and hashing old root hashes

We likely want to have a way to access old root node hashes, even after a tree is updated. For example, at the moment the tests which require multiple root hashes need to obtain the hash for a particular publish before the next call to publish. Additionally, we probably want to support chaining the hashes together, although this is up for debate.

@Jasleen1, I thought this was done but I see that the epoch used here is not right. Could you take a look?


Error not visible when missing both link page and link url

Django 1.11
Wagtail 1.10
Wagtailmenus 2.2.2
If both link to a page and link to a url are missing a general error si given to the user, but the real reason doesn't come up.
The missing error is, generated by models.menuitems.AbstractMenuItem.clean:
raise ValidationError(_(
                "You cannot link to both a page and URL. Please review your "
                "link and clear any unwanted values."
            ))

Hi @pyMan. Thank you for raising.
This is certainly a valid issue, but it's really something that needs to be tackled from the Wagtail side, as it's the views there that still don't display non-field errors consistently. Some progress has been made in the following PR https://github.com/wagtail/wagtail/pull/3440, but the same changes haven't yet made it through to the contrib.modeladmin app yet. as described in https://github.com/wagtail/wagtail/issues/3441
Also, as a sidenote, wagtailmenus doesn't yet officially support Wagtail version 1.10 or Django 1.11. That's something I intend to work on soon.


fix: add missing type for extractRequestBody option

Hello @hedgepigdaniel , sorry but this already exist on the next branch


Going back to a window group should focus the window last focused in that group

So that when I type, it happens in the window on my screen, not a the other one.

f6d755c


Refactor Swagger Documentation & Request Body Validation Outside Of Routes Index Files

While the additions in #32 are great, the routes files are quite large now, containing a lot of Swagger and request validation data.
The routes files should be made much smaller than they are by adding two new files on top of the index.ts routes we currently have, validations.ts and swagger.ts.
The validation and swagger objects already exist in index.ts, so it's minor code refactor.
This will however have a large impact:

Much easier to follow API routing without getting distracted by the metadata
We can easily expand metadata information much more than we currently do, especially the Swagger documentation. it will be in it's own module, so there won't be any issues with creating any bloat on the routes file.

Ensure this is done only after addition of unit tests #16

This ticket might not be necessary anymore. Really happy with prettier formatting on the routes file, and since the service logic is outside the routes file already, we most likely will leave the Swagger documentation full specification in the routes file.


"dogfooding" caf and cafrun for tests

Should we be using caf to compile our tests and cafrun to execute them? This is often called "dogfooding" and can help further test our scripts and ensure their correctness, while also displaying confidence in them.  I'm wondering how to go about this in CMake. I think this could be achieved via:

Splitting building the tests into an additional "check" target that is not included in "all" and depends on building the opencoarrays library target. This will split the building of the tests into a separate task so that if you don't want to run the tests, you won't have to build them, and emulate GNU/autotools "make check" behavior: build and run tests. This is not strictly required to accomplish "dogfooding"
Ensure that the caf and cafrun scripts fully resolve the compilers they wrap and pass necessary flags etc. and are available before install. #268 We can use CMake's REALPATH capabilities for this.
Hardwiring the Fortran compiler in the test directories' CMakeLists.txt to be caf... this could be unstable/difficult. An alternative might be to look into externalproject_add ... here is some useful info: http://cmake.3232098.n2.nabble.com/ExternalProject-Add-without-download-of-local-sources-td6797293.html

Sounds good.  It probably makes sense to seek the advice of CMake developer @brad.king.  I'm not sure if the latter tag will work so I'll email him too.

Actually, the more I think about it the more I am drawn to add_custom_command() and add_custom_target. A difficulty may arise when treating the "fancy" performance/integration tests that link against the timer and FFT code... but it shouldn't be too tricky to figure out... I'm thinking that this is probably the way to go...

An alternative might be to look into externalproject_add
...
I am drawn to add_custom_command() and add_custom_target

Either of these approaches may work.  An advantage of using ExternalProject_Add is that the "external" project can be a full CMake project.  Its configuration and build are delayed until build time of the outer project, so one can use dependencies to make sure everything needed to use caf is ready before even configuring the test project.  Combined with use of the export() command one could even have the external test project link to libraries from the main project cleanly.

Thanks for chiming in @bradking! It sounds like in the long run it might make the most sense to use ExternalProject_Add to ensure all of our export() machinery is working as expected, but in the short term (since tests aren't setup as external projects yet) perhaps add_custom_target and add_custom_command might be best?
@bradking said:

Combined with use of the export() command one could even have the external test project link to libraries from the main project cleanly.

@bradking: Do you know if this means that we need to export our build directory too if we want to do this before running make install in the main OpenCoarrays project?

@zbeekman yes, if an externally-built project is to test the libraries and such from the build tree then export() should be used to make the targets available for import into the external project.

@zbeekman this issue was prescient.  I just submitted pull request #277 to correct for a fatal error in the caf script that was not being detected by the tests because the tests don't yet use the caf script.

🎩 ✨ 🐇 🔮

Well, actually if I was prescient, I would have made the changes to caf and cafrun when I changed CMakeLists.txt.... 😦

might make sense to handle this at the same time as #267

Note to self: See the generator expressions section of https://cmake.org/cmake/help/v3.8/command/add_test.html

@zbeekman Let's look at this together so we can implement it and close the issue?


Precision, Recall and f1 score for multiclass classification

Hi!
Keras: 2.0.4
I recently spent some time trying to build metrics for multi-class classification outputting a per class  precision, recall and f1 score.
I want to have a metric that's correctly aggregating the values out of the different batches and gives me a result on the global training process with a per class granularity.
The way I understand it is currently working is by calling the function declared inside the metric argument of the compile function after every batch to output an estimated metric on the batch that is stored in a logs object.
training.py
            for metric in output_metrics:
                if metric == 'accuracy' or metric == 'acc':
                    # custom handling of accuracy
                    # (because of class mode duality)
                    output_shape = self.internal_output_shapes[i]
                    acc_fn = None
                    if (output_shape[-1] == 1 or
                       self.loss_functions[i] == losses.binary_crossentropy):
                        # case: binary accuracy
                        acc_fn = metrics_module.binary_accuracy
                    elif self.loss_functions[i] == losses.sparse_categorical_crossentropy:
                        # case: categorical accuracy with sparse targets
                        acc_fn = metrics_module.sparse_categorical_accuracy
                    else:
                        acc_fn = metrics_module.categorical_accuracy

                    masked_fn = _masked_objective(acc_fn)
                    append_metric(i, 'acc', masked_fn(y_true, y_pred, mask=masks[i]))
                else:
                    metric_fn = metrics_module.get(metric)
                    masked_metric_fn = _masked_objective(metric_fn)
                    metric_result = masked_metric_fn(y_true, y_pred, mask=masks[i])
                    metric_result = {
                        metric_fn.__name__: metric_result
                    }
                    for name, tensor in six.iteritems(metric_result):
                        append_metric(i, name, tensor)

Here there is a call to _masked_objective which is defined as:
_masked_objective
def _masked_objective(fn):
    """Adds support for masking to an objective function.

    It transforms an objective function `fn(y_true, y_pred)`
    into a cost-masked objective function
    `fn(y_true, y_pred, mask)`.

    # Arguments
        fn: The objective function to wrap,
            with signature `fn(y_true, y_pred)`.

    # Returns
        A function with signature `fn(y_true, y_pred, mask)`.
    """
    def masked(y_true, y_pred, mask=None):
        """Wrapper function.

        # Arguments
            y_true: `y_true` argument of `fn`.
            y_pred: `y_pred` argument of `fn`.
            mask: Mask tensor.

        # Returns
            Scalar tensor.
        """
        # score_array has ndim >= 2
        score_array = fn(y_true, y_pred)
        if mask is not None:
            # Cast the mask to floatX to avoid float64 upcasting in theano
            mask = K.cast(mask, K.floatx())
            # mask should have the same shape as score_array
            score_array *= mask
            #  the loss per batch should be proportional
            #  to the number of unmasked samples.
            score_array /= K.mean(mask)

        return K.mean(score_array)
    return masked

Which averages whatever tensor comes out of the metrics.
Here is how I was thinking about implementing the precision, recall and f score.
I was planning to use the metrics callback to accumulate true positives, Positives, and false negatives per class counts. Accumulate them within the logs and then compute the precision, recall and f1 score within the callback.
The problem with that approach is that the tensor that I output with counts from the metrics gets averaged before getting to the Callback.
My change request is thus the following, could we remove that average from the core and metrics and let the Callbacks handle the data that has been returned from the metrics function however they want?
I really think this is important since it now feels a bit like flying blind without having per class metrics on multi class classification.
I can also contribute code on whatever solution we come up with.
Thank you

I tried to do the same thing. Maybe a "callback" added to the "fit" function could be a solution?

The way we have hacked internally is to have a function to create several metric functions and pass them as argument to the metrics arguments when calling compile.
It is kind of crappy but it works

I added the f1 metrics:
        if metric == 'accuracy' or metric == 'acc':
          # custom handling of accuracy
          # (because of class mode duality)
          output_shape = self.internal_output_shapes[i]
          acc_fn = None
          if (output_shape[-1] == 1 or
              self.loss_functions[i] == losses.binary_crossentropy):
            # case: binary accuracy
            acc_fn = metrics_module.binary_accuracy
          elif self.loss_functions[i] == losses.sparse_categorical_crossentropy:
            # case: categorical accuracy with sparse targets
            acc_fn = metrics_module.sparse_categorical_accuracy
          else:
            acc_fn = metrics_module.categorical_accuracy

          masked_fn = _masked_objective(acc_fn)
          append_metric(i, 'acc', masked_fn(y_true, y_pred, mask=masks[i]))
        elif metric in ['f1','f1-score']:
          if (output_shape[-1] == 1 or
              self.loss_functions[i] == losses.binary_crossentropy):

            def true_pos(y_true, y_pred):
              return K.sum(y_true * K.round(y_pred))

            def false_pos(y_true, y_pred):
              return K.sum(y_true * (1. - K.round(y_pred)))

            def false_neg(y_true, y_pred):
              return K.sum((1. - y_true) * K.round(y_pred))

            def precision(y_true, y_pred):
              return true_pos(y_true, y_pred) / \
                     (true_pos(y_true, y_pred) + false_pos(y_true, y_pred))

            def recall(y_true, y_pred):
              return true_pos(y_true, y_pred) / \
                     (true_pos(y_true, y_pred) + false_neg(y_true, y_pred))

            def f1_score(y_true, y_pred):
              return 2. / (1. / recall(y_true, y_pred) + 1. / precision(y_true, y_pred))

            for fn in [precision, recall, f1_score]:
              append_metric(i, fn.__name__, fn(y_true, y_pred))
        else:
          metric_fn = metrics_module.get(metric)
          masked_metric_fn = _masked_objective(metric_fn)
          metric_result = masked_metric_fn(y_true, y_pred, mask=masks[i])
          metric_result = {metric_fn.__name__: metric_result}
          for name, tensor in six.iteritems(metric_result):
            append_metric(i, name, tensor)```

I use these custom metrics for binary classification in Keras:
def precision(y_true, y_pred):
    #Calculates the precision
    true_positives = K.sum(K.round(K.clip(y_true * y_pred, 0, 1)))
    predicted_positives = K.sum(K.round(K.clip(y_pred, 0, 1)))
    precision = true_positives / (predicted_positives + K.epsilon())
    return precision

def recall(y_true, y_pred):
    #Calculates the recall
    true_positives = K.sum(K.round(K.clip(y_true * y_pred, 0, 1)))
    possible_positives = K.sum(K.round(K.clip(y_true, 0, 1)))
    recall = true_positives / (possible_positives + K.epsilon())
    return recall

def fmeasure(y_true, y_pred):
    '''Calculates the f-measure, the harmonic mean of precision and recall.
    '''
    return fbeta_score(y_true, y_pred, beta=1)

Source
In your compile:
model.compile(
    optimizer=Adam(),
    loss='binary_crossentropy',
    metrics = ['accuracy',
                           custom_metrics.fmeasure,
                           custom_metrics.recall,
                          custom_metrics.precision]
            )

What I would really like to have is a custom loss function that optimizes for F1_score on the minority class only with binary classification. Something like:
from sklearn.metrics import precision_recall_fscore_support

def f_score_obj(y_true, y_pred):
    y_true = K.eval(y_true)
    y_pred = K.eval(y_pred)
    precision, recall, f_score, support = precision_recall_fscore_support(y_true, y_pred)
    return K.variable(1.-f_score[1])

However, I know this is a mathematically invalid way of computing loss with regards to gradients and differentiability...

@trevorwelch , it's baath-wise, not the global and final one.

Hello Everyone,
@trevorwelch, how could I customize these custom matrices for finding Precision@k and recall@k ???

@trevorwelch Really interested in the answer to this also 👍

@trevorwelch, how could I customize these custom matrices for finding Precision@k and recall@k

@trevorwelch Really interested in the answer to this also 👍

The code snippets that I shared above (and the code I was hoping to find [optimize F1 score for the minority class]) was for a binary classification problem.
Are you asking if the code snippets I shared above could be adapted for multilabel classification with ranking?

@trevorwelch Actually interested in the binary case for now, multilabel classification problem for later.
Want to know, you have this comment:

However, I know this is a mathematically invalid way of computing loss with regards to gradients and differentiability...

Did you end up figuring out a mathematically valid approach?

This is still interesting. Does anyone know if multilabel classification performance per label is solved?

Has the problem for "Precision, Recall and f1 score for multiclass classification" been solved?

You can use the metrics which were removed, if it helps:
https://github.com/keras-team/keras/blob/1c630c3e3c8969b40a47d07b9f2edda50ec69720/keras/metrics.py

Thanks but I used the callbacks in model.fit . Here is the code I used :
class Metrics(keras.callbacks.Callback):
    def on_train_begin(self, logs={}):
        self.confusion = []
        self.precision = []
        self.recall = []
        self.f1s = []

    def on_epoch_end(self, epoch, logs={}):
        score = np.asarray(self.model.predict(self.validation_data[0]))
        predict = np.round(np.asarray(self.model.predict(self.validation_data[0])))
        targ = self.validation_data[1]

        self.f1s.append(sklm.f1_score(targ, predict,average='micro'))
        self.confusion.append(sklm.confusion_matrix(targ.argmax(axis=1),predict.argmax(axis=1)))

        return

    history =model.fit(X_train, y_train, epochs=epochs, batch_size=batch_size,
                       validation_data=(X_val, y_val), shuffle=True, verbose=1,callbacks=[metrics] )

The article on which I saw this code:
https://medium.com/@thongonary/how-to-compute-f1-score-for-each-epoch-in-keras-a1acd17715a2

Hello. @puranjayr96 code doesn't look wrong to me. But we can not use this to save best model weights. I have looked everywhere on internet and I couldn't find custom metric code. That would be awsome if someone could provide custom metric computing: MACRO or MICRO F1/recall/precision score ...

@romanbsd I dont think this is correct since they use round which should lead to error in case of multiclass classification when no predicted value > 0.5...
@puranjayr96 you'r code look correct but for what I know you can not save best weight when using metric in callback.. they need to be called when you compile the model
I think this question still need an answer.. that I can't provide because of my low skill :(

I think maybe the following code will work
import tensorflow_addons as tfa
f1 = tfa.metrics.F1Score(num_classes, 'macro')
...
model.compile(..., metrics=[f1])

ref: https://www.tensorflow.org/addons/api_docs/python/tfa/metrics/F1Score

I think maybe the following code will work
import tensorflow_addons as tfa
f1 = tfa.metrics.F1Score(num_classes, 'macro')
...
model.compile(..., metrics=[f1])

ref: https://www.tensorflow.org/addons/api_docs/python/tfa/metrics/F1Score

This does not work on my side. It returns TypeError: array() takes 1 positional argument but 2 were given
Has this problem been solved yet?


Support configuring allowed updates for security updates using config file

I have configured a dependabot.yml that should ignore devDependencies

version: 2
updates:
  # Maintain dependencies for npm
  - package-ecosystem: "npm"
    directory: "/"
    schedule:
      interval: "daily"
    allow:
      - dependency-name: "*"
        dependency-type: "production"
    ignore:
      - dependency-name: "*"
        dependency-type: "development"

Despite this I am still getting PR's for devDependency warnings
What do I need to do to stop these from happening?

Hi, that config file looks to be invalid: https://github.com/kyeotic/raviger/runs/1097204025
You cannot specify dependency-type in the ignore condition, but since you already have an allow rule set up to match only production dependency types, I think you can get rid of that ignore field entirely and it should work.
Lmk if that works 👍

I added the ignore field after the allow failed to stop a PR yesterday. I will remove ignore again and give it another day I guess.

It's happening again
with this config
version: 2
updates:
  # Maintain dependencies for npm
  - package-ecosystem: "npm"
    directory: "/"
    schedule:
      interval: "daily"
    allow:
      - dependency-name: "*"
        dependency-type: "production"

@jurre I realized you probably wouldn't get notified from an issue re-opening... so :bump:

@feelepxyz do you have an idea what's going on here?

@kyeotic pretty sure that's because it's a security update fixing a vulnerability in lodash: https://github.com/advisories/GHSA-p6mc-m468-83gw
You currently can't configure allowed updates for security updates using the config file. Currently only the following config file options are used for security updates:

assignees
commit-message
ignore
labels
milestone
pull-request-branch-name.separator
rebase-strategy
reviewers
vendor
versioning-strategy

You'd have to ignore the dependencies specifically as we don't support ignoring dependency-type yet.

@feelepxyz That's surprising. Is this explained in the docs anywhere?
I think wanting to ignore dependabot warnings for devDependencies is a pretty common request. I don't see why this separate and additional category of "security updates" is even in the equation. If I say I don't want devDependency warnings I mean I don't want any warnings for any devDependencies. Frankly, this behavior is wrong.

I guess I'm just going to have to disable dependabot entirely.

Good feedback and legitimate use-case! Will add this to our backlog to fix, we haven't done much to make both products configurable using the same config file but are looking at changing this.

I guess I'm just going to have to disable dependabot entirely.

You can also only disable security updates from the GitHub UI:

@kyeotic for findability, can you pls rename this issue to something like Dependabot *security* updates should accept a "production dependencies only" mode ? Hope this lands someday.

Also, @feelepxyz @jurre reading dependabot-security docs, it's not clear to me how yml-configurable this "security" product is. Before this issue I hadn't understood it was configurable, at all. Does dependabot-security read dependabot.yml? Will both dependabot and dependabot-security run? Since having a dependabot.yml is how you enable dependabot, how do I for example configure reviewers for my security alerts, but without enabling the full dependabot? Am I missing documentation?

Also, @feelepxyz @jurre reading dependabot-security docs, it's not clear to me how yml-configurable this "security" product is. Before this issue I hadn't understood it was configurable, at all. Does dependabot-security read dependabot.yml? Will both dependabot and dependabot-security run? Since having a dependabot.yml is how you enable dependabot, how do I for example configure reviewers for my security alerts, but without enabling the full dependabot? Am I missing documentation?

Yeah it's currently very patchy but we have a plan to fix it! You currently can't configure security updates using the config file without also enabling version updates, if you do want to enable version updates the following config file options will also apply to security updates: https://github.com/dependabot/dependabot-core/issues/2521#issuecomment-731305885

@feelepxyz Sounds good, I will disable dependabot-security until thats fixed.
As a user, I have to say that this distinction is surprising and frustrating. I understand that they are internally considered two independent products, possibly developed by different teams, but they serve similar functions, have similar names, with similar operation and similar configuration so as a user I don't see them as independent, but as parts of a whole. I expect the difference in security and regular (?) to be a kind of alert, not a completely separate application with separate configuration. I would like to see them use a single configuration, possibly with a threshold or minimumAlertLevel for each kind.

@feelepxyz @jurre any news on making Dependabot security updates configurable (either through a dependabot.yml, or through checkboxes in https://github.com/<org>/<project>/settings/security_analysis ?
For my desired use case (1. security vulns only, 2. npm prod deps only, 3. automatic assignment to a list of reviewers) I'm still torn between two unsatisfying options:

Use a dependabot.yml to get above points [2, 3], but miss point [1] and be overwhelmed with non-security upgrades.
Use the barebones Dependabot security updates feature integrated into GitHub and get above point [1], but miss points [2, 3] and have PRs for all deps (as opposed to only prod deps) and lacking assignment to reviewers.

Note: point 2. "prod deps only" isn't the biggest deal for me. What matters most is to point 3. "automatically assignment to a list of reviewers", else these PRs are just floating here and nobody looks at them.

(And sorry for the lame "bump" comment, I never write those in open source projects because I hate causing noise to issue subscribers, but I'm paying for dependabot/GitHub and it's been six months, so here's me doing an exception to this rule :shrug:)

@ronjouch yeah it's kinda possible to configure security updates through dependabot.yml, this is a bit of a hack atm but should work:
version: 2
updates:
  - package-ecosystem: npm
     directory: "/"
     schedule:
       interval: "daily"
     open-pull-requests-limit: 0 # in case you don't want to enable version updates
     allow:
      - dependency-type: "production"
     reviewers:
       - username

Security update PR should inherit this config as the config object is shared between version and security updates as long as the ecosystem, directory matches on the default branch.
We're planning to make this a lot nicer.

It's kinda possible to configure security updates through dependabot.yml, this is a bit of a hack atm but should work [...]. Security update PR should inherit this config as the config object is shared between version and security updates as long as the ecosystem, directory matches on the default branch.

@feelepxyz oooooh neat, trying this now. Thanks!

We're planning to make this a lot nicer.

Cool. I'm staying subscribed to this issue, will try the nicer thing if/when it ships and undo the dependabot.yml hack. Until then, the hack, if it works, will do very well for my use case. Thanks again!

Security update PR should inherit this config as the config object is shared between version and security updates as long as the ecosystem, directory matches on the default branch

@feelepxyz one more thing about this detail: does this mean that I should not have a second package-ecosystem in the dependabot.yml ?
Said differently, will a second package-ecosystem break your ecosystem/directory matching logic and the config extension of dependabot/security from dependabot.yml?

will a second package-ecosystem break your ecosystem/directory matching

Nope, you can have any number and they should match on ecosystem + directory so you can have version updates enabled for some and security updates for all (not yet possible to disable security updates on some projects).

@jurre @feelepxyz any update on this issue? Being able to ignore devDependencies would help to massively reduce the number of false positives we get.

Will we be able to get support for a private registry config with the security updates? We have our own artifactory for npm dependencies and the PRs dependabot creates for security updates doesn't match the registry we setup in the dependabot.yml file.

👋 Hello! Product Manager for Dependabot here. I’m currently doing research into adding/improving configuration for security updates, and am looking for user input. This issue is similar to things I’m thinking about, so if you’re subscribed to this and you’re open to a short conversation with me, please feel free to select a time in my calendar that fits your schedule here: https://calendar.app.google/7RSxjJJo9FdvRHNz7

Closing out as stale

Closing out issues as stale encourages "me too" comments that keep the issue active.
Do you want "me too" comments?

Closing out issues as stale encourages "me too" comments that keep the issue active.
Do you want "me too" comments @abdulapopoola ?

Thanks @ronjouch , @kyeotic and @ChiriVulpes for the feedback.
I'm sorry about that and I take full responsibility for this. As a first step, I'm re-opening the issue.
I closed it since the last seen engagement was a long time ago and the crew is actually making good progress in this area. The goal is to engage the community more.
Update:
The crew is starting to work in this area and we should have some simple configuration for grouped security updates coming out this week or next. This builds upon this release.
What would be a better way to carry you along going forward?

While it might not completely address your issues, I've been using the recently introduced auto-triage rules (that can be set both on the Organisation and Repository level.
https://docs.github.com/en/code-security/dependabot/dependabot-auto-triage-rules/about-dependabot-auto-triage-rules
It allows you to automatically dismiss dependabot alerts that meet specified criteria (so you can ignore updates for a particular library, particular issue type, dev dependencies, etc).

What would be a better way to carry you along going forward?

Updates provided here in the issue would be ideal, since it already has people subscribed to it.
Is there an organizational blocker to this?

No blockers to that.
It's a bit challenging to keep the multiple issues about the same feature updated though. I'll see how it goes though.

If there is another issue that should be canonical a reference to it while closing this should be sufficient. All subscribers and future visitors will see the new place.

Thanks @ronjouch , @kyeotic and @ChiriVulpes for the feedback. I'm sorry about that and I take full responsibility for this. As a first step, I'm re-opening the issue.

@abdulapopoola 👍, thanks for the ack and honest comeback 🙂.

I closed it since the last seen engagement was a long time ago and the crew is actually making good progress in this area. The goal is to engage the community more.
Update: The crew is starting to work in this area and we should have some simple configuration for grouped security updates coming out this week or next. This builds upon this release.

@abdulapopoola 👍, eager to see what you come up with. On my side, my problem was that https://github.com/dependabot/dependabot-core/issues/2521#issuecomment-863261500 simply didn't work (my config was exactly this comment, in several repos where vulns do happen). We've had it in several repos, it failed to produce any PR in a year, without visibility on what's wrong, and thus we abandoned it. Since then, we manage these manually with npm audit and without Dependabot.
But maybe this is fixed. I re-enabled my attempt in 2 repos, let’s see if this works now.
At any rate, if this is something you’d like, I’d be happy to have a new live chat with you or another Dependabot PM / tech, for "business analysis" clarity or support.

@ronjouch yeah it's kinda possible to configure security updates through dependabot.yml, this is a bit of a hack atm but should work:

@feelepxyz (or anyone familiar): follow-up to https://github.com/dependabot/dependabot-core/issues/2521#issuecomment-863261500 : is the open-pull-requests-limit: 0 # in case you don't want to enable version updates and just want security updates hack deprecated now that we have applies-to: security-updates, or is it still needed?

@ronjouch it's still needed because applies-to only works in the context of groups.


support done.state.{id} events

3.1.3 (Parallel States) of https://www.w3.org/TR/scxml decribes done.state.id completion events. There is additional detail in 3.1.4 (Initial, Final, and History States) as it pertains to compound states.
Several of the w3c IR tests (https://www.w3.org/Voice/2013/scxml-irp/) cover this.
From https://github.com/jbeard4/scxml-test-framework/tree/master/test/w3c-ecma
$ git clone https://github.com/jbeard4/scxml-test-framework.git
$ cd scxml-test-framework/test/w3c-ecma
$ grep done.state *.scxml | cut -f1 -d":" | uniq -c
   4 test294.txml.scxml
   3 test343.txml.scxml
   2 test372.txml.scxml
   2 test416.txml.scxml
   2 test417.txml.scxml
   3 test488.txml.scxml
   2 test527.txml.scxml
   3 test528.txml.scxml
   2 test529.txml.scxml
   6 test570.txml.scxml

@mattoshry Should be fixed in latest release (4.3.1). Please give it a try, and if resolved, close the issue. Thanks!


Let sequence start with 1 when pagination is disabled

Thanks @kapalla for the PR. Will probably merge this into v2.0, but would not merge back to earlier version to prevent breaking change in case someone is relying on it.


Custom entity manager

Patch to close #58.
Ability to use a different Entity manager on each Select2Type in a form (useful when working on many databases).

Thanks for this. I'll hopefully get to take a closer look this weekend.

Looks good. Merged, thanks.


fix(cleanup-job): add OR clause to prevent job from failing

Signed-off-by: Niladri Halder<EMAIL_ADDRESS>Cleanup job fails if the validatingwebhookconfiguration is deleted beforehand. This stalls helm chart remove. Eventually leads to timeout. Fixed it with a OR clause.

Dependent on PRs:

https://github.com/openebs/cstor-operators/pull/346
https://github.com/openebs/jiva-operator/pull/104


python: can't open file './auth_web.py': [Errno 2] No such file or directory

Hello guys,
Looks like a great project. Only I get stuck during installation. I use RASPBIAN JESSIE 4.1. The error that I get is python: can't open file './auth_web.py': [Errno 2] No such file or directory. After that he shows the IP from the pi and echo's that I can reboot the pi. Does somebody know how I can fix this?
Kind regards,
Tim

I saw the same thing. There's an "example_creds.py" file in the AlexaPi folder. Use nano to edit it and just manually enter all your information. Then exit and save it as "creds.py." Then manually launch the auth_web.py program and it is supposed to get you where you need to be (that part hasn't worked for me yet, no matter what I've tried - I think it may be a router issue, but I really don't know.)
The above is kind of confusing, but I'm a brand new linux/RPi user and it's taken me a day and a half to figure it out as far as I have.
This video makes it a little simpler to understand, but he's using a slightly different fork of the software (which has your issue worked out already): https://www.youtube.com/watch?v=frH9HaQTFL8

Thanks that worked for my !


Move property out of loop

Pr. your request.
Newer compilers will hoist this call out of the loop automatically, but .NET Framework build system won't. Therefore this PR might not actually improve a whole lot.

I forgot to cherrypick the commit...


Zhaoyu/hdfs access

add ways to access hdfs data

Coverage increased (+9.8%) to 84.274% when pulling a850f034285f680a7eeb342a75e56ff1fb3e5e94 on zhaoyu/hdfs_access into 5f613ef105e8234f736142cce357128143814cf5 on master.

Coverage increased (+9.8%) to 84.274% when pulling a850f034285f680a7eeb342a75e56ff1fb3e5e94 on zhaoyu/hdfs_access into 5f613ef105e8234f736142cce357128143814cf5 on master.

Coverage increased (+9.8%) to 84.274% when pulling a850f034285f680a7eeb342a75e56ff1fb3e5e94 on zhaoyu/hdfs_access into 5f613ef105e8234f736142cce357128143814cf5 on master.

Suggest adjust api order, adjust restful webhdfs content as the first one for user to see [min cost to operate data], list cmd contend after webhdfs


Need clarification on state change dialog going from fee estimate to on hold

Describe the bug in current situation

Original message was hard coded, however after 761 only general requests go through on hold stage, which gets automatically assigned to flex team.  What should be the behaviour now?
Link bug to the User Story
Steps to Reproduce
Steps to reproduce the behavior:

submit request, take to cfr stage -> fee estimate -> on hold

@divyav-aot @sumathi-thirumani-aot

Need to remove the extra text on the end,  "assigned to Processing Team" .  Require only : " This will stop the clock." after the "Are you sure want..... ?"


FindToken changes

This change enables cloud find token and store find token to work together for two way replication.
The main changes are

Since the tokens for a cloud replica and store replica are different, this change introduces replicatype to differentiate between the two. For now the determination about replica type is based on mount point (cloud replicas have a dummy mount point of /vcr/partitionId).
Implementation of a helper to get findtokenfactory based on replica type.
Implementation of cloud token factory.
Bug fixes in cloud find token.
Refactoring some common code used by both ambry-store, ambry-cloud and ambry-replication.
Change the replication code to recognize both cloud replicas and store replicas and serialize/deserialize their token accordingly.
Change tests where token factory was used.

Thanks for the detailed description, that will help to review.

It's looking a lot better.  Can you reproduce the test failure?  Let's get a clean build so we can check the code coverage.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@9479711). Click here to learn what that means.
The diff coverage is 69.51%.

@@            Coverage Diff            @@
##             master    #1254   +/-   ##
=========================================
  Coverage          ?   72.24%
  Complexity        ?     6118
=========================================
  Files             ?      444
  Lines             ?    35228
  Branches          ?     4469
=========================================
  Hits              ?    25451
  Misses            ?     8616
  Partials          ?     1161

Impacted Files
Coverage Δ
Complexity Δ

.../com.github.ambry.store/StoreFindTokenFactory.java
100% <ø> (ø)
3 <0> (?)

...src/main/java/com.github.ambry/store/FindInfo.java
100% <ø> (ø)
3 <0> (?)

...ava/com.github.ambry/store/HardDeleteVerifier.java
0% <ø> (ø)
0 <0> (?)

...om.github.ambry.replication/RemoteReplicaInfo.java
80.68% <ø> (ø)
22 <0> (?)

...rc/main/java/com.github.ambry.store/BlobStore.java
90.23% <ø> (ø)
97 <0> (?)

....ambry/clustermap/ClusterMapSnapshotConstants.java
0% <ø> (ø)
0 <0> (?)

...a/com.github.ambry/store/DumpReplicaTokenTool.java
0% <ø> (ø)
0 <0> (?)

.../main/java/com.github.ambry/store/StoreCopier.java
55.14% <ø> (ø)
10 <0> (?)

...main/java/com.github.ambry.cloud/CloudReplica.java
70.83% <0%> (ø)
8 <0> (?)

...in/java/com.github.ambry.cloud/CloudBlobStore.java
82.32% <0%> (ø)
65 <0> (?)

... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9479711...2d9065a. Read the comment docs.


Docs.MS Release Updates for azure-keyvault-admin

Update docs metadata and targeting for release of azure-keyvault-admin

Docs Build status updates of commit 0d5a501:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs-ref-services/preview/keyvault-admin-readme.md
:warning:Warning
View (azure-node-preview)
Details

docs-ref-services/preview/keyvault-admin-readme.md

Line 9, Column 16: [Warning-ms-prod-technology-invalid] Invalid value for 'ms.technology': 'azure' is not valid with 'ms.prod' value 'azure'.
Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.
Line 221, Column 1: [Suggestion-duplicate-alt-text] Alt text 'Impressions' is duplicated. Within an article, alt text must be unique. NOTE: This Suggestion will become a Warning on 1/29/21.
Line 250, Column 1: [Suggestion-duplicate-alt-text] Alt text 'Impressions' is duplicated. Within an article, alt text must be unique. NOTE: This Suggestion will become a Warning on 1/29/21.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Improve uniq performance

The biggest speedups comes from not allocating Strings at every cmp_key

No problem, you'll need to rebase now though because I merged the other pull request.

Alright, I rebased on master, so should be ready to merge now.

Thanks!