Drop support for Python 2.6

Fixes #325.
Split out from PR https://github.com/SoCo/SoCo/pull/523 ("Drop support for EOL Python 2.6 & 3.3, add support for 3.6") to allow more granular decision making.

Agreed. +1.
This looks great. Let's get it ASAP.
I guess this comment from @robwebset (https://github.com/SoCo/SoCo/issues/325#issuecomment-340693250) applies to this PR as well. But I would be a favor of pulling anyway, from a code maintainability (and fun features) point of view.
(BTW. If any of you want a horror story along those lines, try reading the code for olefile, which maintains compat back 1.something.extremely.old).

BTW. Just for the point of being thorough. I think we should create a 2.6 branch just before pulling, as the last point of maintaining 2.6 compat.

olefile's more up-to-date than SoCo: 2.7, 3.3+ :)
https://github.com/decalage2/olefile/blob/master/setup.py#L45-L51

@hugovk trust me, that has changed dramatically sometime within the last couple of years.

With two approvals and overall consensus on the deprecation, I have now merged the pull request. Thanks everyone for their thoughts and comments!

@stefankoegl did you make a branch beforehand?

I've now created branch python-2.6 at 4dd3ad10c4f524ec9d1a753b619c48ac075f2dc1, which was the commit right before the merge (11515c44332b98b4011c3e07509ba6f54fd32d96).

@stefankoegl thanks


Error: plugin.apply is not a function

Thanks for the plugin! :D
markdownIt().use(plugin, ...) calls plugin.apply(). But since this plugin doesn't define an apply function, an error is raised. @types/markdown-it doesn't seem to define is it either.
https://github.com/markdown-it/markdown-it/blob/6e2de08a0b03d3d0dcc524b89710ce05f83a0283/lib/index.js#L495-L499
Reproducing:
https://glitch.com/edit/#!/festive-orange-event?path=server.js%3A1%3A0
const markdownIt = require('markdown-it')
const mdShiki = require('markdown-it-shiki')

const mdlib = markdownIt()
        .use(mdShiki, {
            theme: 'nord'
        })

or
import MarkdownIt from 'markdown-it'
import Shiki from 'markdown-it-shiki'

const md = MarkdownIt()

md.use(Shiki, {
  theme: 'nord'
})

Error text:
/home/aravind/src/avoggu.com/node_modules/markdown-it/lib/index.js:497
  plugin.apply(plugin, args);
         ^

TypeError: plugin.apply is not a function
    at MarkdownIt.use (/home/aravind/src/avoggu.com/node_modules/markdown-it/lib/index.js:497:10)
    at file:///home/aravind/src/avoggu.com/ind.mjs:6:4
    at ModuleJob.run (node:internal/modules/esm/module_job:183:25)
    at async Loader.import (node:internal/modules/esm/loader:178:24)
    at async Object.loadESM (node:internal/process/esm_loader:68:5)
    at async handleMainPromise (node:internal/modules/run_main:63:12)

I believe apply is from the function's prototype. While we did expose an function for it, try
const mdShiki = require('markdown-it-shiki').default

Ooh that works! I thought markdown-it changed, and the plugin would need a re-write 😂
Smart thinking, exposing the prototype! Can we add it to the Readme? Perhaps in an FAQs section?

The default is mostly because of the ESM/CJS converting. https://github.com/rollup/rollup/issues/1961#issuecomment-423037881


Feat/typedoc update

This is created by @doriancrutcher , want to have typedoc updated with release tags

Seems https://docs.near.org/sdk/near-sdk-js/reference doesn't update, asking @doriancrutcher to help figure out


Support for R

Support for R.  This comes up in every case where data scientists are considering GitHub.

I think the big ticket item is CRAN. See https://r-pkgs.org/release.html: "If you want your package to have significant traction in the R community, you need to submit it to CRAN."

The most mature library I know of for dealing with R packages (including structuring, checking, and releasing) is devtools.
Packages are more generally described in https://r-pkgs.org/intro.html.
The file that contains dependencies to be checked is DESCRIPTION, see an example of the "Depends" block here.

See also more info at https://r-pkgs.org/description.html#dependencies.

See also renv R 📦 which allows to write a renv.lock file than contains the version number of the package, and the source if they come from CRAN or a source repo like Github. Any R project can use this to fix their dependencies requirement.
Otherwise, yes DESCRIPTION file are in every R packages developed to inform about dependencies and minimum version used. But it does not state all the dependency graph.

If anyone comes here looking for a solution, I wrote a custom github actions workflow that upgrades packages from a custom requirements file using renv. It's not the most general solution but could be easily adapted to work with a DESCRIPTION file instead.

Note if I were going to implement a feature to warn about out-of-date dependencies, I might try writing an renv.lock file and comparing it to the existing one.

Note https://r-pkgs.org/dependencies.html#other-dependencies says:

Prior to the roll-out of namespaces in R 2.14.0 in 2011, Depends was the only way to “depend” on another package. Now, despite the name, you should almost always use Imports, not Depends.

It would be cool, if dependabot would provide functionality similar to oysteR, which searches the sonatype repository for known vulnerabilities in R packages. One would need to see, if this could be adapted to scan only the requirements of a R software package.

Yes, RENV for R works a lot like poetry for python.  It would be great if dependabot could maintain RENV.

You could try the OSV scanner action. It picks up renv.lock and scans for security related issues in dependencies. https://osv.dev/


[GlobalOptimization] Move FuseDequantizationMatmulPass to after `Fo…

…ldUnitExtentDimsPass`

Looks like this worked fine on Vulkan but not on CPU. Scanning the failure message I see a huge number of vector inserts so it might need a triage + rematerialization for whatever pipeline it now goes down?


Error installing the package with nimble!

Error installing the package with nimble!
$ nimble install nauthy
Downloading https://github.com/lzoz/nauthy using git
  Verifying dependencies for<EMAIL_ADDRESS> Installing nimSHA2@>= 0.1.1
Downloading https://github.com/jangko/nimSHA2 using git
  Verifying dependencies for<EMAIL_ADDRESS> Installing<EMAIL_ADDRESS>   Success: nimSHA2 installed successfully.
 Installing<EMAIL_ADDRESS>   Success: nauthy installed successfully.
   Warning: Package 'nauthy' has an incorrect structure. The top level of the package source directory should contain at most one module, named 'nauthy.nim', but a file named 'utils.nim' was found. This will be an error in the future.
      Hint: If this is the primary source file in the package, rename it to 'nauthy.nim'. If it's a source file required by the main module, or if it is one of several modules exposed by 'nauthy', then move it into a 'nauthy/' subdirectory. If it's a test file or otherwise not required to build the the package 'nauthy.nim', prevent its installation by adding `skipFiles = @["utils.nim"]` to the .nimble file. See https://github.com/nim-lang/nimble#libraries for more info.

$ nim -v
Nim Compiler Version 1.4.4 [Linux: amd64]
Compiled at 2021-02-23
Copyright (c) 2006-2020 by Andreas Rumpf

Thank you for pointing that out. I fixed the project strucuture.


Compile all of the constructor function

Compile all of the constructor function (not just the body). This stops 'top level this' reference errors generated by 6to5 when compiling ES6 tags.
For example, here's what happens compiling the example ES6 test tag from the compiler documentation https://muut.com/riotjs/compiler.html#ecmascript-6
$ riot  --type es6 es6-test.tag

ReferenceError: unknown: Line 4: Top level `this` is `undefined` in strict mode
  2  |
  3  |   var type = 'JavaScript'
> 4  |   this.test = `This is ${type}`
     |   ^

I've found a ;.bind(this) syntax error with riotjs() parser, needs more work.


Move files from core to backend? Actually, maybe restructure the folders more generally

I'm a bit confused by our folder structure. One might think that core would be for things that all the other parts may end up using, both frontend, backend, ingress functions, etc. But currently much of what's in core really only concerns the backend: structure.py, db.py, models.py, sensors.py, locations.py, maybe others. We should probably move these to the backend folder: All other aspects of DTBase should always use the backend APIs rather than import anything from these files.
This might leave core mostly empty, which makes me wonder if we should call it utils instead.
Regardless, I would like to have a clear structure of what is allowed to import from where, so e.g. nothing in webapp should ever import anything from backend (but rather use the APIs).
Actually thinking of that, maybe the right thing would be to make the different parts be independent Python packages? Might make installation of them more annoying, but would help clarify the relations between them. Note that I mean different packages within the same git repo, I would not like to split the repo into subrepos, that gets messy fast.

Closed by #222


CVRP time windows

how would i run this cvrptw java code  in netbeans ?

Include the jar, add all the native libraries in the library path parameter.


loading config files and autocomplete give problems in certain cenarios

In the config file the lines:
experiment_dir: '/home/philipp/BEATS/SEM_6/foo/ExpData'
experiment_name: 'foo'
inhouse: False
h5file: ''
h5file_flats: ''
h5file_darks: ''
dataset: '<dataset>'
recon_dir: '/home/philipp/BEATS/SEM_6_recon/foo/recon/'
cor_dir: '/home/philipp/BEATS/SEM_6_recon/foo/cor'

must be filled in a coherent manner up to now. Otherwise the return values are "/". This is especially true, if a directory does not exist yet. Also must the experiment_name be the same as the second to last string in the experiment_dir.
Furthermore, there could be a bug with the autocomplete, making the first autocomplete "fake", since we already give it to start with. Upon subsequent calls, or when loading datasets, the behaviour is as expected though.
In
alrecon/alrecon/components/alrecon.py
we have the function
define_recon_dir_BEATS
def define_recon_dir_BEATS(self, number_heading_directories=5):
	### first 4 elements are defining the root at BEATS, + '/' what gets stripped to ''
	### but since we know the path for BEATS, we could also take a hardcoded thing
	path_ = os.path.abspath(self.experiment_dir.value)
	elements_path = path_.split(os.sep)[:number_heading_directories]
	elements_path[0] = '/'
	dir_recon_root = os.path.join(*elements_path)
	dir_recon_root = f'{dir_recon_root}_recon'
	return dir_recon_root

which is tuned to our BEATS workflows. It was created anticipating other configurations and the way how it is invoked should be revised.

Instead of giving
experiment_dir: '/home/philipp/BEATS/SEM_6/Test1/ExpData'
experiment_name: 'Test1'
inhouse: False
h5file: ''
h5file_flats: ''
h5file_darks: ''
dataset: '<dataset>'
recon_dir: '/home/philipp/BEATS/SEM_6_recon/foo/recon/'
cor_dir: '/home/philipp/BEATS/SEM_6_recon/foo/cor'

note that in recon_dir and cor_dir foo can be replaced by whatsoever, autocomplete does not care, takes the experiment_name + the name of the dataset and a tweaked recon.
A modified convention such as
experiment_dir: '/home/philipp/BEATS/SEM_6/Test1/ExpData'
experiment_name: 'Test1'
inhouse: False
h5file: ''
h5file_flats: ''
h5file_darks: ''
dataset: '<dataset>'
recon_root: '/home/philipp/BEATS/SEM_6_recon/Test1'
recon_dir: recon
cor_dir: cor

could be a step towards a more robust and understandable procedure.
One problem probably lies in how data are recorded, another one in the config file itself. In yaml references to other fields might be possible though, to achieve e.g. something like
&experiment_name: 'Test1'
experiment_dir: '/home/philipp/BEATS/SEM_6/*experiment_name/ExpData'

if an individual parser should not be used. Let's think about it!


Occasional userland null ptr dereference due to ELF TLS

Sometimes, it looks like gs = 0 when returning to userland, causing null pointer derefs. This seems to happen on current master if you let the VM run for a couple minutes.

userspace or kernel space ?
either

gs is wrong (i.e. incorrectly swapped. Wouldn't be the first time). Refer gs >> 3 to https://sunriseos.github.io/SunriseOS/master/sunrise_kernel/i386/gdt/index.html
[gs] is wrong: Maybe called before elf tls initialization, or I messed up the TLS init image (again, wouldn't be the first time).
Compare nm <service> | grep __tls to readelf --segments.

@Orycterope userspace is sometimes run with gs = 0. We pagefaults on instructions like mov ecx, gs:[0] with an invalid read on address 0.

Wait, gs is 0, or gs points to 0 ?
I see no reason for it to be zero

gs points to a segment whose base is 0.

OK scratch that. gs is 0.

So I did a quickfix where I changed trap_gate_asm to backup gs into UserSpaceHardwareContext and then restore it, and it seems to make the problem go away. I'm a bit ambivalent with the patch, and what bothers me the most is that I don't understand how we can end up in this situation. Like, at best I could understand gs pointing on the kernel segment, but this makes no sense 🤔 .

With #475 merged, the bug shouldn't cause crashes anymore at least. But it might still cause weirdness in some places (for instance, assuming it is indeed the detection that's broken, esp_cpy might be wrong). Keeping this open until we have a proper investigation of what was the cause of this bug.


feat: Add Queue not found strategy property

:loudspeaker: Type of change

[ ] Bugfix
[ ] New feature
[x] Enhancement
[ ] Refactoring

:scroll: Description

Add Queue Not Found Strategy Property
:bulb: Motivation and Context

The default behavior is to use the CREATE strategy and to change this you need to do it programmatically
:green_heart: How did you test it?
I added a unit test for this case
:pencil: Checklist

[x] I reviewed submitted code
[x] I added tests to verify changes
[x] I updated reference documentation to reflect the change
[x] All tests passing
[x] No breaking changes

:crystal_ball: Next steps

Thanks for the PR @gabrielsmartins, but we already have an open PR for this feature:
https://github.com/awspring/spring-cloud-aws/pull/1127
Let's try to concentrate on that one.


hapi-fhir-checkstyle now generates javadocs

Adding a dummy javadoc package so we can publish checkstyle without sonatype complaining.

doing as backport


Added metrics to SFlux/SMono

I went ahead and copied the docs from the core reactor project, I hope that's okay.

Thank you @rs017991

@sinwe after some thought, I'm leaning towards changing the tests to be micrometer-only. I think that would be more valuable.
Testing both scenarios would be overly complex, if even possible.
Will follow up with another PR


Adds tests for cache and fixes env var format

As requested for cache persistence, this adds some basic testing for image caching.
Further, writing the test showed that the formatting of the build-arg was wrong, so this PR fixes that too.

Checklist

[ ] Affected Issues have been mentioned in the Closing issues section
[ ] Documentation has been written/updated
[ ] PR title is ready for changelog and subsystem label(s) applied

Explain the details for making this change. What existing problem does the pull request solve?

two quick fixups to get this testing:

merge main branch in, then update make docker_pull in the makefile to also exclude _CACHE in grep -Ev '_REPO|_VERSION|_CACHE'
add image-cache to the TESTS var in the jenkinsfile second test-sute

Done @tobybellwood


Added autosave on the filters page

Fixes #41
Description
This PR aims to add auto save feature on the filters section of the options page
Other information

An issue currently exists and i would find it very helpful to get some suggestions on fixing the issue, chrome gave me the following error,

Checklist:

[ ] My pull request has a descriptive title (not a vague title like Update index.md).
[ ] My pull request targets the master branch of the repository.
[ ] My commit messages follow best practices.
[ ] I added tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[ ] I tried running the project locally and verified that there are no
visible errors.

Developer Certificate of Origin
Version 1.1
Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129
Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Hi @thegitone23, thanks for the PR.
The error you mentioned is described here. The maximum number of the set, remove, or clear operations that can be performed each minute is set to 120. A runtime.lastError is triggered if this limit is exceeded. Because of this error, after a couple of changes in the filters section, the extension will not write those changes to the local storage.
You should add a check for the chrome.runtime.lastError in the callback of chrome.storage.sync.set function here.
Something like the following would work
() => {
   if (chrome.runtime.lastError) {
        showNotification("Too many changes! Please wait some time", "negative", "snackbar-options");
   } else {
        showNotification("Settings saved!", "positive", "snackbar-options");
  }
}

Hi @thegitone23, thanks for the PR.
The error you mentioned is described here. The maximum number of the set, remove, or clear operations that can be performed each minute is set to 120. A runtime.lastError is triggered if this limit is exceeded. Because of this error, after a couple of changes in the filters section, the extension will not write those changes to the local storage.
You should add a check for the chrome.runtime.lastError in the callback of chrome.storage.sync.set function here.
Something like the following would work
() => {
   if (chrome.runtime.lastError) {
        showNotification("Too many changes! Please wait some time", "negative", "snackbar-options");
   } else {
        showNotification("Settings saved!", "positive", "snackbar-options");
  }
}

First of all thanks for the review, I fixed the linting errors and also added the message as you suggested, but as you saw the way I implemented auto save is essentially giving every checkbox save button like behavior which is a little  inefficient, can you kindly suggest some improvements over the current method.

Hi, @thegitone23. Sorry for the late response, but after testing the changes locally for some days I think adding this feature to the extension will not be user-friendly. This is because of the MAX_WRITE_OPERATIONS_PER_MINUTE limit. Only after a couple of changes, the limit error is shown and this will become worse in the future as we might add more data in the localStorage. The users may get confused due to this.
We will not be adding this feature(at least for now).
Thanks for helping us out with this.


Update the last known envoy

Like https://github.com/tetratelabs/func-e/pull/399
This must be automated by https://github.com/tetratelabs/archive-envoy/issues/25

wat


⚠ Fortnite has degraded performance

In 8a7f726, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1597 ms

Resolved: Fortnite performance has improved in 676b2b0.


ERROR with braces in array of strings

When parsing an array of strings where strings have open braces, it can fail quietly and return bad data, or eventually throws an error if there are enough open braces in a string. I've attached some examples (It says txt, but it's python code). The last example will throw an exception (It has three open braces).
toml_bug.txt

There is a workaround for this. Use unicode characters:
{ : \u007b
} : \u007d

I also have the same problem:

toml.loads(toml.dumps({'list': ["this is an example ${{AVAR}"]}))
{u'list': []}

another example:
toml.loads(toml.dumps({"list": ["{thing}"]}))

results in {"list": []}

for anyone else struggling with this, https://github.com/avakar/pytoml doesn't have this problem

I'm having trouble reproducing this in the latest master. Can someone verify that this isn't a duplicate or has otherwise been fixed in the year since the last pip release?

I can confirm this is fixed in master, but not in the 0.9.2 pip release. It would be great to update the pip package even if all the open issues aren't quite fixed. This bug is currently a blocker for me and the other pytoml package mentioned above has its own set of problems.

Closing as a duplicate of #90.
A new pip release is a priority for me right now. Unfortunately, I've just been unable to dedicate as much time to this project as I would like/as I feel it deserves.


Fix for properties with shared columns in Migrations

Issue #5894
This was an issue with code added for hasLength. It assumed each column was mapped from a single property. Fix is to use any property--model validator already checks that these properties do not have different mappings.
Also added more functional tests for shared columns.

:shipit:


Render one window per time

Render one window per time

Need to verify plugins.

[ ] Plugins no longer render. Needs to be clicked again for it to render.
[ ] Docs functionalities (searching, add to query, autocompletion) might not work as expected, since there is no proper separation/initialization of the docs worker for each window.

Alternatively, load windows only when they are opened.

Rendering only one window might not be an improvement in performance either.


pointops_cuda error

I have installed everything separately as requirements.txt is not valid anymore. I am facing problem while trying to train the model. please help me to solve it.
from models.transformer import Group
File "/home/amandal2023/Desktop/deep_learning3d/Partial2Complete/models/transformer.py", line 6, in
from extensions.pointops.functions import pointops
File "/home/amandal2023/Desktop/deep_learning3d/Partial2Complete/extensions/pointops/functions/pointops.py", line 4, in
import pointops_cuda
ModuleNotFoundError: No module named 'pointops_cuda'

I have the same issue

This is a common issue.
Please cd to extensions/pointops and run python setup,py install.
If you have complied it and had error message: undefined symbol: _ZN6caffe26detail37_typeMetaDataInstance_preallocated_32E
Then, please check the pytorch version. I run my experiments using 1.12, a higher version might lead to this problem.

您看，我使用了pytorch 1.12 cuda 11.6 2080ti去跑代码，并且cd到extensions/pointops并运行python setup,py install了，但是出现这个错误。
import pointops_cuda
ImportError: /root/miniconda3/envs/P2C/lib /python3.8/site-packages/pointops-0.0.0-py3.8-linux-x86_64.egg/pointops_cuda.cpython-38-x86_64-linux-gnu.so：未定义符号：_ZN8pybind116detail11type_casterIN2at6TensorEvE4loadENS_6handleEb

You see, I used pytorch 1.12 cuda 11.6 2080ti to run the code, and cd to extensions/pointops and run python setup,py install, but this error still occurs.
import pointops_cuda
ImportError: /root/miniconda3/envs/P2C/lib /python3.8/site-packages/pointops-0.0.0-py3.8-linux-x86_64.egg/pointops_cuda.cpython-38-x86_64-linux-gnu.so： undefined symbol:_ZN8pybind116detail11type_casterIN2at6TensorEvE4loadENS_6handleEb

If you cannot compile it, you can use the pre-build wheel. Please refer to https://github.com/yuxumin/PoinTr
pip install "git+https://github.com/erikwijmans/Pointnet2_PyTorch.git#egg=pointnet2_ops&subdirectory=pointnet2_ops_lib"

Another option is to use pure-PyTorch operations to replace the fps and gather KNN operations. You can refer to
https://github.com/fxia22/pointnet.pytorch

谢谢您


Fixed issues in README.md

Some redundant words have been removed and the structure of some sentences have been modified.

Thanks. I agree about the first part, but not so much about the rest. I think it's better to distinguish between Cython the language and Cython the compiler to a certain extent.


Improve README file

Did some restructuring. Also provided links to some of the terms used.

Merged :+1:


Top-half kernel

We want our kernel mapped to the upper half of virtual memory. This allows for several improvements, such as giving each userspace process the lower half of virtual memory, easily distinguishing between kernel and userspace, having virtual memory addresses always reserved for the kernel. I have added a milestone to it because I do not want it completed now. Instead it should take place after basic memory is set up. This is slightly problimatic, because right now we are assuming a lower-half kernel when configuring memory, however this is because Phillip's tutorial is doing things this way as well. Our kernel will soon diverge from this tutorial in memory as it has for other parts, and then we will make it higher-half.

I think that I will do this in protected mode and switch to the higher half and long mode at the same time. src/arch/x86_64/boot.asm is already pretty big, so I'm open to suggestions to put it somewhere else, but I think that there's no problem with having that file large because it is exceptionally important. Rust code will not have to change very much except the memory module which will have to account for everything being mapped to the higher half, however I don't think this should be that much of a problem.
I'm not yet sure what to do with the lowest mb of memory, perhaps I will continue to identity map it for now, because important parts of the system (such as the VGA buffer) are there. The kernel heap will also have to change place. Finally all pointers that GRUB hands off to the kernel (that are identity mapped 32bit pointers) will have to be changed, or mapped specifically to access them.
Overall I have a good feeling about this and it is the next thing that I will work on. If everything goes as plan.


WCAG: Status Messages

Description
Im not sure if we are within this one. Should do a check if our error messages and dynamics are good.
Intent

The intent of this Success Criterion is to make users aware of important changes in content that are not given focus, and to do so in a way that doesn't unnecessarily interrupt their work.

Source
Loadbar
We have a loadbar that is visible sometimes. This component will need the Aria-atributtet role="progressbar"
Acceptance criteria

[ ] The user is aware of important changes in content

[ ] Status for validation errors that are activated onBlur. Look at this article for example
[ ] Check if our loader should have has role="progressbar"

Would #117 be relevant for this case?

@FinnurO the issue you are linking to can be beneficial for making sure that users be aware of changes in the content. We should resolve both this and issue #117, but separately. Both issues should absolutely be done to increase user experience. Due to issue #117 there are users that do not recognize the changes within the form. When reading issue #117 description, looks like we need to figure out what is the best solution to resolve the challenge.  Anyway, I would prioritise only this issue before 01.02.23. :)


Add --max-retries and --retry-interval flags

Hey, sometimes the connection to Bazarr can be interrupted due to updates, restarts, network upgrades, etc.
It would be really nice if we can define --max-retries and --retry-interval flags.
Restarting a sync from scratch is extremely time consuming especially with large libraries.

Great idea, thanks!


Frontend auth

Closes: #164 (Frontend auth)
This also fixes: #108 as the white space at the top was caused by the router link being hidden behind the top bar.

Some commits are duplicated somewhere else. I don't like force-pushing so I am closing this.


Input being chopped on issue page

I just installed gitpoint on my Moto G5 Plus, android 7, and noticed that when entering an issue, the comment input gets  chopped(you can easily notice by the placeholder on the bottom). Here's a link to the video showing it: https://drive.google.com/file/d/0B1YWQtOX-9n_dXdUQzFONUcwQ00/view?usp=drivesdk

Np! Actually I mean the section in the bottom where the placeholder "Add a comment here" is.
See the image below:

Ooooh thank you, surprised I didn't catch that from the video.
Thanks for this :) We'll make sure it's resolved before our next patch release 💃


Snapshot - fix String character count deprecation warning in SnapshotHelper

Checklist

[x] I've run bundle exec rspec from the root directory to see all new and existing tests pass
[x] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
[x] I've read the Contribution Guidelines
[x] I've updated the documentation if necessary.

Motivation and Context
Xcode 9.1 gives a Swift Compiler Warning with the notice SnapshotHelper.swift:115:125: 'characters' is deprecated: Please use String or Substring directly. This commit removes the deprecated usage of characters from the String instance.
Note: there are two files in master branch that use launchArguments.characters.count. I only modified SnapshotHelper.swift. The other file, SnapshotHelperXcode8.swift, I assume is for Xcode 8.
Xcode 8 uses Swift 3. The String characters deprecation happened as part of Swift 4 & Xcode 9.
Description
By using the count method of the launchArguments String, instead of using the deprecated characters.count, the warning goes away.

Thanks, your CLA has been submitted.

I signed it!

Thanks @taquitos
I've updated the SnapshotHelperVersion. Let me know if I need to squash commits, etc.


Clarify how to produce hex representation

The documentation comments relating to how to produce the standard hex representation implied that you should run show on the Bytestring produced by md5DigestBytes rather than the MD5Digest.
I think this is a little clearer.

Thanks


Update name of doom's custom hideshow folded face

Doom no longer uses the name +doom-folded-face. It's now called +fold-hideshow-folded-face.

@hlissner this is Doom related.

Sorry for the tremendously late reply, this was done in f0ec55a to sidestep conflicts.

@hlissner this is Doom related.

It's the face we use for regions folded with hideshow (note the [...]):


Thread list not showing

Describe the bug
A clear and concise description of what the bug is.
client = OpenAI::Client.new
client.threads.list

irb(main):015> client.threads.list

OpenAI HTTP Error (spotted in ruby-openai 6.3.0): {"error"=>{"message"=>"Your request to GET /v1/threads must be made with a session key (that is, it can only be made from the browser). You made it with the following key type: secret.", "type"=>"invalid_request_error", "param"=>nil, "code"=>"missing_scope"}}
/Users/juanlopez/.asdf/installs/ruby/3.2.2/lib/ruby/gems/3.2.0/gems/faraday-2.7.12/lib/faraday/response/raise_error.rb:18:in `on_complete': the server responded with status 401 (Faraday::UnauthorizedError)

To Reproduce
Steps to reproduce the behavior:

Go to: rails console
connect to openAi client: client = OpenAI::Client.new
Type on console(bug): client.threads.list
See error

Expected behavior
See list of treads...

Interesting the api documentation does not have a list call

Seems like there is no way to list threads from the API unless you have an id already.

@coezbek

Seems like there is no way to list threads from the API unless you have an id already.

Do you mean messages?
and yes I had to start storing thread id's to manage this...

No, messages you can list via the messages end-points.

Released in v6.4


Inquiry about Adversarial Traning Versions and Testing Scripts

Dear Dr. Shawn,
Sorry to interrupt you.
My question is the same as "Doesn't protect against Face++ Recognition in my test #67" (https://github.com/Shawn-Shan/fawkes/issues/67).
I also have the same problem as Harry and hope to test Face++. I would appreciate it if you could send me a script with a local facial recognition model as you send to Harry. My e-mail address is<EMAIL_ADDRESS>What is more, the feature extractors in Table 1 of your paper are Web-Incept, Web_Dense, VGG2_Incept and VGG2_Dense. But in this release code, there are only extractors_0 and extractors_2. Can you kindly tell me what architectures and datasets these extractors is based on？ and is that possible to release adversarial training versions? Since in this paper you claimed that the adversarial training models performance better in the wild.
Thank you so much for spending time on my questions!
Jun.

When I cloaked my selfie with the low level perturbation by Fawkes 1.0, then tested them in Face++, the cloak seems to be ineffective. The test images are not the celebrity as you mentioned in other the reply issues. Is it the problem that only the adversarial training extractor can cheat Face++ as your experimental results in your paper?
1、my two clean selfies comparison, the similarity score is 89.701:

2、The right side image is low-cloaked by Fawkes 1.0, but the similarity score is still up to 86.099:

This is the app I used in Windows 10.

When I use Amazon Rekognition service,
case 1: the similarity of two clean images is 99.97;
case 2: the similarity of a low-cloaked image 1 and a clean image 2 is 99.7;
case 3: the similarity of two cloaded images is 98.6, which are still too high.
Case 1:

Case 2:

Case 3:

I have exactly the same problem as pidanhua! The method provided in the code does have little effect, which may be related to the difference between the feature extractor in the code and that in the paper, or it may not use  adversarial traning.
If anyone can also send me the Local Facial recognition model and model uesd adversarial traning and feature extractor in the paper etc, I would be very grateful! My email is<EMAIL_ADDRESS>Thanks a million!


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade" workflow

Codecov Report

Merging #107 (75627fb) into main (2974dfe) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #107   +/-   ##
=======================================
  Coverage   83.33%   83.33%
=======================================
  Files           2        2
  Lines         126      126
  Branches       31       30    -1
=======================================
  Hits          105      105
  Misses         21       21

Impacted Files
Coverage Δ

example/src/main.ts
88.46% <100.00%> (ø)

src/index.ts
82.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6e127e...75627fb. Read the comment docs.


Use scan/next instead of range in VM's Storage trait

In order to avoid most of the mess from https://github.com/CosmWasm/cosmwasm/issues/335, I'd like to propose the following change to the VM's Storage trait. This matches exactly what we need for the import implementations (fn do_scan and fn do_next) and pushes the problem of storing iterator state to the Storage implementations.
diff --git a/packages/vm/src/traits.rs b/packages/vm/src/traits.rs
index 5cc96887..7a0ca89e 100644
--- a/packages/vm/src/traits.rs
+++ b/packages/vm/src/traits.rs
@@ -70,16 +70,24 @@ pub trait Storage {

     #[cfg(feature = "iterator")]
     /// Allows iteration over a set of key/value pairs, either forwards or backwards.
+    /// Returns an interator ID that is unique within the Storage instance.
     ///
     /// The bound `start` is inclusive and `end` is exclusive.
     ///
     /// If `start` is lexicographically greater than or equal to `end`, an empty range is described, mo matter of the order.
-    fn range<'a>(
-        &'a self,
-        start: Option<&[u8]>,
-        end: Option<&[u8]>,
-        order: Order,
-    ) -> FfiResult<Box<dyn StorageIterator + 'a>>;
+    ///
+    /// This call must not change data in the storage, but creating and storing a new iterator can be a mutating operation
+    /// on the Storage implementation.
+    fn scan(&mut self, start: Option<&[u8]>, end: Option<&[u8]>, order: Order) -> FfiResult<u32>;
+
+    /// Returns the next element of the iterator with the given ID.
+    ///
+    /// If the ID is not found, a FfiError::IteratorDoesNotExist is returned.
+    ///
+    /// This call must not change data in the storage, but incrementing an iterator can be a mutating operation on
+    /// the Storage implementation.
+    #[cfg(feature = "iterator")]
+    fn next(&mut self, iterator_id: u32) -> FfiResult<Option<KV>>;

     fn set(&mut self, key: &[u8], value: &[u8]) -> FfiResult<()>;

This makes instances of Storage moveable without invalidating references and allows us to get rid of the lifetime 'a in struct ContextData<'a, S: Storage, Q: Querier> that has to outlive the ContextData instance.
For the production implemetation it is trivial to store iterators, because
#[repr(C)]
pub struct GoIter {

can be copied. For the mock implementation, we might need to create a custom iterator that somehow stores a position as binary.
ping @ethanfrey @reuvenpo

Very nice thinking.
The important API to maintain is the cosmwasm-std API for contract developers, and this doesn't touch that. I keep being more happy you guys decided to separate the -vm and -std traits. :smile:
This solution does sound good, and in production we do actually store a hash table of numbers to iterators in Go. And punt this whole Iterator lifetime issue into "Go land" where the compiler doesn't complain any more :laughing:
For mock, since it really is a mock and does not need to be performance, let's just do what I did in the first draft before I gained some ground and the current uneasy truce with lifetimes: for cosmwasm_vm::MockStorage, let us just .collect() the entire iterator on scan and store it as a Vec<KV> in internal memory. Then we can just store the entire Vec in the MockStorage struct as well as an index and then step through it.
I think this is a very pragmatic approach to reduce a lifetime/reference nightmare into something manageable. However, longer term (for 2.0), I would be curious to get this working (with scan/next) against a Rust DB/Storage layer without using collect. But for now, let's go the simplest way to maintain the interface.

👍
One thing we need to be careful about is that iterator_ids must be assigned in a deterministic way, as this now becomes external data injected into the contract. When this was controlled in the VM it was easy as ContextData was newly created per execution. Probably not hard to ensure in go-cosmwasm as well, but something we must not forget.

Yeah, I use some deterministic integer counters in wasmd. Not sure what I do in go-cosmwasm


Rhode Island qualifier additions

Added “Is your zip code covered by the Hard-Hit Community Vaccination Strategy?” qualifier to universal list under People of Color
Adjusted age from 65+ to 60+ in current phase
Added Hard-Hit Community qualifier to current phase
Added more info strings for medical conditions
Added more info strings for educators

[{"key":"global","type":"customStrings","value":{"content":{"c19.eligibility.question/people_of_color.is":{"en-us":"Is your zip code covered by the Hard-Hit Community Vaccination Strategy?"}}}},{"key":"rhode_island","type":"vaccination","value":{"content":{"phases":[{"id":"1a","qualifications":[{"question":"c19.eligibility.question/healthcare_worker"},{"question":"c19.eligibility.question/long_term_care_resident"},{"question":"c19.eligibility.question/congregate.do"},{"question":"c19.eligibility.question/essential_worker.are"},{"question":"c19.eligibility.question/age.60_up"},{"question":"c19.eligibility.question/essential_worker.are_you","moreInfoText":"c19.eligibility.moreinfo/essential_worker.are_you.ri.1a"},{"question":"c19.eligibility.question/age.are_you_age","moreInfoText":"c19.eligibility.moreinfo/age.are_you_age.ri.1a","moreInfoUrl":"https://health.ri.gov/publications/guidelines/COVID19-underlying-conditions.pdf"},{"question":"c19.eligibility.question/people_of_color.is","moreInfoUrl":"https://covid.ri.gov/vaccination/rhode-islands-hard-hit-community-vaccination-strategy"}]},{"id":"1b","qualifications":[{"question":"c19.eligibility.question/healthcare_worker"},{"question":"c19.eligibility.question/long_term_care_resident"},{"question":"c19.eligibility.question/essential_worker.1b"},{"question":"c19.eligibility.question/age.75_up"}]},{"id":"1c","qualifications":[{"question":"c19.eligibility.question/healthcare_worker"},{"question":"c19.eligibility.question/long_term_care_resident"},{"question":"c19.eligibility.question/essential_worker"},{"question":"c19.eligibility.question/health"},{"question":"c19.eligibility.question/age.65_up"}]}]}}},{"key":"rhode_island","type":"strings","value":{"content":{"c19.eligibility.moreinfo/age.are_you_age.ri.1a":{"en-us":"High risk medical conditions include: \nDiabetes\n• Type 1\n• Type 2\n\nLung disease\n• COPD (chronic obstructive pulmonary disease)\n• Emphysema\n• Cystic Fibrosis\n• People with significant decreased lung function\n• People with ALS (Lou Gehrig’s disease)\n\nHeart disease\n• Congestive heart failure\n• Coronary artery disease\n• People with enlarged hearts (cardiomyopathies)\n• People with other significant heart conditions\n• People with Down Syndrome\n\nKidney disease\n• People on dialysis\n• Significant chronic kidney disease\n\nWeakened immune system\n• Cancer\n• People who get chemotherapy or radiation\n• People who have had a transplant or are waiting for a transplant\n• HIV/AIDS\n• Sickle cell disease\n• People who have a disease that weakens the immune system\n• People who take medicine that weakens the immune system\n• Pregnancy"},"c19.eligibility.moreinfo/essential_worker.are_you.ri.1a":{"en-us":"Pre K -12 teachers and staff at public, private, parochial, and independent schools, and licensed child care providers are eligible for vaccination at municipal sites where they work or participating pharmacy sites.  Vaccinations for this group will began mid-March.\n\nFor schools, eligible individuals include anyone providing regular, direct service to students, including teachers, administrative and clerical staff, bus drivers/monitors, coaches, cafeteria staff, maintenance staff, therapists working in schools, substitute teachers, and student teachers. School Committee members are not eligible.\n\nFor licensed child care providers, eligible individuals include all employees (regardless of schedule and hours of employment) who deliver direct, in-person services to children in DHS-licensed child care settings, maintenance staff, security and transportation personnel, and therapists and support staff."}}}}]


Plugin not overwriting theme fonts

@ashergz I'm seeing the font you mentioned here. Can you confirm that it's not showing up, even in a search for "Autor"?

Works now. I dunno why the font wasn't showing up before. Now though, there's another issue. I use a theme with custom font and unlike v1, the selected font in the plugin can't seem to override it. Can you please look into it?
Originally posted by @ashergz in https://github.com/notmike101/betterdiscord-google-fonts/issues/35#issuecomment-1138180581

Wait i didnt mention #35 is solved XDD
i only said that previously this could be solved by restarting discord, but the issue did not go away this time
this is why i commented there XD

I mean the plugin is designed to change the font and that's what anyone using it expects it to do? If they want to retain the theme font, they will just disable the plugin? right now, there isn't any way to use a theme but with the font of our choice which I believe is something people would want.

Makes sense, the only issue I can see with this type of solution is that I'm not sure how themes are applying fonts, so I wouldn't be able to apply it consistently.
As of right now, the plugin works by overwriting some of Discord's CSS variables, specifically --font-primary, --font-display, and --font-headline.
In order for me to figure out the most common way that themes are overwriting fonts, @ashergz, can you let me know what theme you're using and provide a link to it if possible?

@ashergz Can you try the new version 2.0.11 and let me know if that's more acceptable?

Yup, this is perfect. Thanks!


[balsa] Run HttpProtocolIntegrationTests with BalsaParser as well.

Set up HttpProtocolIntegrationTest and its derived test classes, as well as Http2BufferWatermarksTest (a class derived from HttpIntegrationTest) to run with BalsaParser in addition to http-parser if either the upstream or the downstream protocol is HTTP/1.1.  Disable BalsaParser for now for a few tests that are failing.
Tracking issue: https://github.com/envoyproxy/envoy/issues/21245
Signed-off-by: Bence Béky<EMAIL_ADDRESS>Commit Message: [balsa] Run HttpProtocolIntegrationTests with BalsaParser as well.
Additional Description:
Risk Level: low, test-only change
Testing: //test/integration:all
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a

/assign @diannahu @birenroy

/assign @KBaichoo


Proposal: Remove children prop, add prop about when to render

I'd like to change how Route render and children work.
What's the difference between them?
<Route path="/foo" children={() => (

Children always renders, match or miss.

)}>

<Route path="/foo" render={() => (

Render only renders if there's a match, null if miss

)}>

The API isn't instructive
The API is not instructive of behavior at all: "render" doesn't indicate "only renders when there's a match" and children doesn't indicate anything either.
Maybe we can ditch having two render props with a prop that is instructive of the behavior.
<Route alwaysRender={true} render={({ match }) => (

Now we only have one render prop, and an instructive API

)}/>

I'm pretty convinced this is a good way forward. Route has two types of props:

How should I match? (path, exact, strict)
How should I render? (render, children, component)

It’s a bit conflated that the distinction between render and children is how things match!
Component prop
Also, with this change the component prop can participate in use-cases where you want to render even when there's no match. Today you have to use the children prop.
<Route children={(props) => <OtherThing {...props} />}/>
// becomes this when the use case for the route changes:
<Route alwaysRender={true} component={OtherThing}/>

Bikeshedding on the name of the prop
<Route alwaysRender={false} render={() => ()}/>
<Route renderOnMiss={false} render={() => ()}/>
<Route renderOnMatchOnly={true} render={() => ()}/>
<Route renderOn={"match" || "miss" || "both"} render={() => ()}/>
<Route ignoreMatch={false} render={() => ()}/>

Thoughts?

I agree that the difference between children prop and render is a little annoying.
Two things I like about your suggestion:

remove children and just use render for render function behavior
This can be confusing and I like simplifying it to always be one prop.
add another "behavior prop" to tell Route to always render regardless of match
Since the current api uses a prop to denote behavior, (strict, exact), I like the idea of having a prop that means "render regardless of match". I also like that this means the component={Component} pattern can exist for always render scenarios.

As far as naming, I like alwaysRender or a single word like always.

<Route type={'miss' | 'match' | 'any'} render={({ match, route }) => } />

Dropping children for the confusion makes sense. I like the idea of render and component essentially working the same with the main difference being inline. Lastly I think alwaysRender is the mostly intuitive.

Haha, new idea:
<Route when={'miss' | 'match' | 'always'} render={({ match, route }) => } />

Why do you need the alwaysRender prop when there's the match param in the render function?

Like @edygar said but reverse the prop order in examples to read like a sentence:
<Route render={({ match, route }) => } when={'miss' | 'match' | 'always'} />

@klzns the first stab at the v4 API started that way but it was just way too inconvenient for every route to be checking "match" before rendering. You rarely need the "always render" behavior.

Why not just merge the props together?
<Route rendeAlwaysr={() => ()}/>
<Route renderMiss={() => ()}/>
<Route renderMatch={() => ()}/>

Benefit of making it something which has to be true:
<Route always render={() => ()}/>

@timdorr
<Route renderAlways={() => ()}/>
<Route   renderMiss={() => ()}/>
<Route  renderMatch={() => ()}/>
<Route componentAlways={Foo}/>
<Route   componentMiss={Foo}/>
<Route  componentMatch={Foo}/>

Would rather not have potential props conflict confusion:
<Route renderAlways={() => ()} renderMiss={() => ()}/>`
<Route always miss render={() => ()} />

So I'd prefer the @edygar suggestion:
<Route when={'miss' | 'match' | 'always'} render={({ match, route }) => } />
And default to always and a match check could be made as suggested by @klzns

I like the core idea ! :)
For these kind of cases I usually go for a prop should... to match a bit with the React API. How about shouldRouteRender ?
And it would be nice if children was kept but deprecated for a smooth transition.

I like the idea of a always flag/boolean for the cases where you want to always render..
But if you do end up with a prop like when={'miss' | 'match' | 'always'}, please don't make always the default..

Hm can't you already "always render" by just skip having path prop?
Like this:
<Route component={SomeComponent}>
or
<Route render={() => (
hello
)}>

The only thing I can think of that might not be easily done is rendering on the negation of path (render on any path except path matching X)

@HeyHugo
NavLinks:
https://github.com/ReactTraining/react-router/blob/master/packages/react-router-dom/modules/NavLink.js#L27-L31
Custom Links:
https://reacttraining.com/react-router/web/example/custom-link
Animations:
https://reacttraining.com/react-router/web/example/animated-transitions

I see, thanks

Since it is a boolean I think it would be nice if the API aligns with how other boolean props on <Route> are used. In other words it is assumed to be true when present and false otherwise
<Route alwaysRender path="/foo" render={() => ()}/>

Idea of alternative name for the prop forceRender

Thanks for bringing this up, @ryanflorence. I was thinking about this the other day as well! I like the idea of <Route alwaysRender>.

Personally I'd go for the renderOn={"match" || "miss" || "both"} or a prop that would allow me to control when a route should render its children. I have a use case like the one below where I only want to render the page footer when I'm on the exact match...I know I can get around it now by using a render prop but it looks and feels a little cumbersome....
               <Route path={match.path} exact>
                    <Page.Footer>
                        SOME FOOTER STUFF ONLY TO SHOW ON THE EXACT MATCH
                    </Page.Footer>
                </Route>

I probably don't know all the reasons <Match /> was renamed <Route /> but perhaps it's time to go back and add <Match /> <Miss /> and <Always />
I always thought Match was more expressive of what was happening.
Assuming that isn't how thing go however and we stick with a prop...
Its hard to think of a render function that conditionally needs to flip between match and always (or another pair of conditions) so having boolean properties for JSX sugar is unlikely to be used meaningfully and using a when prop taking enumerable valid render conditions is impossible to use inconsistently so I'd favor that.

@GodsBreath I think the argument against your framing is that there would be implicit prop assignment on MyComponent causing unexpected interactions between the route provided props and the owner provided props. render prop forces the consumer to make an explicit choice on how to layer these things and guarantees you can compatibly compose any component, especially ones you did not write yourself, with a Route component

I'm relatively new at this, but that seems to sacrifice an awful lot of readability for the sake of what seems to be a relatively unlikely scenario. The example I provided is simple. It gets even worse when there are several props that need to be passed to MyComponent. If there is a conflict with the implicitly passed props, then at that point the consumer could still make use of the render prop.
I suppose you could improve readability a bit by replacing the anonymous, inline function with a named function that does some partial application, but that has it's own readability problems:
MyComponent.makeRenderer = (myProp) => {
  return (props) => <MyComponent {...props} myProp={myProp} />;
};

<Route path='/mycomponent' render={MyComponent.makeRenderer('myVal')} />

Either way, it seems like a lot of trouble and violation of the react philosophy just to accommodate a hypothetical naming collision between router props and component props.

@GodsBreath also thought about this, why not use direct children.
But it seems that, children, render, component should be called at some point and render something.
One way we could use children directly is to use it as a render prop
<Route path="/mycomponent">
  {({match}) => match && (
    <MyComponent myProp="myVal" />
  )}
</Route>

But as we can see it does not look nicer
If we add children directly inside route, it gets executed at that moment when we reach the route code, and errors may throw.
ex: someAsyncData is loaded when we are on route /mycomponent
<Route path="/mycomponent">

{someAsyncData.someInfo}

</Route>

someInfo is not available at this moment, because someAsyncData is not loaded yet and errors may throw.
Better this. render is called when we are on /mycomponent route and someAsyncData is kind of on loading already
<Route path="/mycomponent" render={() => (

{someAsyncData.someInfo}

)} />

Kind of this. Correct me someone if I'm wrong.

FWIW, I like the proposed when naming scheme...
<Route when="always">
  {...}
</Route>

...because I think it might be nice to have this become a sort of pseudo-standard for render-prop-based APIs. I have often wanted a similar thing for Apollo-like state management libraries...
<Query when="success">
  {({ data }) => (
    ...
  )}
</Query>

...instead of having to deal with the matching logic yourself all the time.
And in React Router's case it obviously makes sense to have when="match" as the default, whereas in other libraries the default might make sense as something else.

I hope I'm not breaking ettiquette by bumping this thread.

Thank you everyone for the discussion here. I think there is probably an easier way forward that I discussed in depth in #6362. Please give that a look and let me know what you think. If it sounds better, we can go ahead and close this.

It's looking like #6362 is going to work, so I'm going to close this in favor of that.


Confirm EU OD repository compatibility

Validate if metadata is pulled from the current repo to the EU one and, if it is, make jkan compatible with it.

Dataset pages compatible with https://www.w3.org/TR/vocab-dcat/


Installation question

Hello. I did send this to the mailing list but haven't received any response, is that still active? Seems to have been no activity since 2020 and I didn't want to pollute the issues!
We're currently rolling out our production version of GBIF IPT but running into some confusion about the URLs it requires exposed to the internet. [1]
The plan is to host our instance via an HTTPS endpoint, which is served via HAProxy to the internal host (currently straight to the jetty instance). There are two issues with this, with the first currently blocking our deployment:

The terminology for base URL and proxy URL is rather confusing, both are stated as having to be accessible via the internet. The base URL is, to my mind, the base/host URL of the Jetty server on which IPT should be responding to requests (eg. in this instance the connection between haproxy and jetty) which is NOT public. The proxy URL I would surmise as being the externally accessible URL (https) accessible for the registry, obviously being public.

The documentation (sort of) suggests that we should be setting base url to the externally accessible endpoint for the registry, and the proxy url to the internal proxy <-> host url. Unfortunately, regardless of which way around this is done, neither combination works for us (eg. HTTPS public endpoint as BASE and HTTP internal endpoint as PROXY, and vice versa.)
Please can you clarify what these URLs are for, and why (if it's the case) we would need to make the internal host URL publicly accessible (which we obviously don't want to do!)

Is it the case that the public endpoint has to be publicly available to the registry during setup? This is rather sub-optimal security wise as it potentially gives anyone the capability to register as the administrator. If necessary, I'll do the whole process myself to ensure it's done quickly!

Thanks in advance for any information you can provide!
James
[1] https://github.com/gbif/ipt/wiki/IPT2ManualNotes.wiki#ipt-setup-II

Hi Jim,
The mailing list is still active, but until recently there hasn't been much development work on the IPT, so it's quiet.  I don't see your message — were you subscribed?
We'll update the terminology on the setup page, as I agree it's no longer clear when current practise pretty much requires a reverse proxy (HAProxy, Apache, Hitch etc) to provide HTTPS.
The setup page should then look like this:

Public URL
The public (Internet) URL for this IPT.
The URL that points to the root of your IPT installation.  If you wish to register resources with GBIF, you must have a publicly accessible address.  For example, https://ipt.example.org or https://www.example.org/ipt
Forward proxy URL
An optional institutional proxy server address.
This setting is required on some institutional networks.  If the IPT must make outbound HTTP and HTTPS requests through an institutional proxy, enter the address and port number here.  For example, http://proxy.example.org:8080

Thanks @MattBlissett
I've adjusted the setup page according to your suggestion


Compatibility with PyInstaller

When creating a package with pyinstaller I've an issue because xmldsig1-schema.xsd is not included. The application is executed in a temporary directory, and the file path should be for example C:\\Users\\ADMINI~1\\AppData\\Local\\Temp\\2\\_MEI46203\\signxml\\schemas\\xmldsi g1-schema.xsd
A potential workaround would be to specify at run-time the directory path containing xmldsig1-schema.xsd and the other schemas. es:
signxml.xmldsig(rootXML, schemas_dir=...)

Is it feasible?

Is there a way to make pyinstaller obey the contents of https://github.com/kislyuk/signxml/blob/master/MANIFEST.in?

don't know, I'm not a master of pyinstaller, maybe with hooks? perhaps @matysek can help

Regarding pyinstaller, this looks like a usecase for data files: https://github.com/pyinstaller/pyinstaller/wiki/Recipe-Collect-Data-Files

Not going to do anything about this. If the installation software that you use follows the setuptools protocol, then the schemas are going to be included.

The problem is still happening on the latest version. I tried a bunch of different things like including the library data with multiple methods but nothing seemed to work.
I don't really know where the problem is, but my best guess is that the loader cannot deal with the xml includes when being called from the pyinstaller frozen environment.
If anyone is interested, here is my (very very ugly) workaround, I instead imported and parsed as a python file (that is for sure included in pyinstaller). You can see the changes here (only core was included, so some functionality might be lost):
https://github.com/bvanelli/signxml/commit/82052d4647548643d386940d3e2dfea7ba4a89d7
The result successfully runs on a pyinstaller environment (tested on python 3.8, pyinstaller 3.6).

The problem is still happening on the latest version. I tried a bunch of different things like including the library data with multiple methods but nothing seemed to work.
I don't really know where the problem is, but my best guess is that the loader cannot deal with the xml includes when being called from the pyinstaller frozen environment.
If anyone is interested, here is my (very very ugly) workaround, I instead imported and parsed as a python file (that is for sure included in pyinstaller). You can see the changes here (only core was included, so some functionality might be lost):
https://github.com/bvanelli/signxml/commit/82052d4647548643d386940d3e2dfea7ba4a89d7
The result successfully runs on a pyinstaller environment (tested on python 3.8, pyinstaller 3.6).

From the pyinstaller documentation, it looks like you are looking for the --add-data option.

From the pyinstaller documentation, it looks like you are looking for the --add-data option.

@kislyuk I tried this already by including a custom hook for the library.
from PyInstaller.utils.hooks import collect_data_files

datas = collect_data_files("signxml")

This collects all the files correctly but the result still fails to run. The same happens with --add-data (under the hood is the same thing):
pyinstaller -F --add-data "signxml/schemas/*:signxml/schemas"  script.py

How to reproduce
On the repo top level create a script:
example_key = """
KEY HERE
""".encode()

example_pem = """
CERT HERE
""".encode()

from lxml import etree
from signxml import XMLSigner, XMLVerifier

data_to_sign = "<Test/>"
root = etree.fromstring(data_to_sign)
signed_root = XMLSigner().sign(root, key=example_key, cert=example_pem)
verified_data = XMLVerifier().verify(signed_root, x509_cert=example_pem).signed_xml
print("Finished successfully)

Run pyinstaller:
pyinstaller -F --add-data "signxml/schemas/*:signxml/schemas"  script.py

There are no errrors on the bundling. If you check the .spec file, the files are included:
a = Analysis(['script.py'],
             ...,
             datas=[('signxml/schemas/*', 'signxml/schemas')],
             ...)

But unfortunatelly it fails to run:
> ./dist/script
Traceback (most recent call last):
  File "script.py", line 57, in <module>
    verified_data = XMLVerifier().verify(signed_root, x509_cert=example_pem).signed_xml
  File "signxml/__init__.py", line 806, in verify
    self.schema().assertValid(signature)
  File "signxml/util/__init__.py", line 140, in schema
    cls._schema = etree.XMLSchema(etree.parse(schema_path))
  File "src/lxml/etree.pyx", line 3521, in lxml.etree.parse
  File "src/lxml/parser.pxi", line 1859, in lxml.etree._parseDocument
  File "src/lxml/parser.pxi", line 1885, in lxml.etree._parseDocumentFromURL
  File "src/lxml/parser.pxi", line 1789, in lxml.etree._parseDocFromFile
  File "src/lxml/parser.pxi", line 1177, in lxml.etree._BaseParser._parseDocFromFile
  File "src/lxml/parser.pxi", line 615, in lxml.etree._ParserContext._handleParseResultDoc
  File "src/lxml/parser.pxi", line 725, in lxml.etree._handleParseResult
  File "src/lxml/parser.pxi", line 652, in lxml.etree._raiseParseError
OSError: Error reading file '/tmp/_MEIuCyOxv/signxml/util/../schemas/xmldsig1-schema.xsd': failed to load external entity "/tmp/_MEIuCyOxv/signxml/util/../schemas/xmldsig1-schema.xsd"
[6343] Failed to execute script script

Now with the schemas as a python file
> git checkout develop
> pyinstaller -F script.py
> ./dist/script
Finished successfully

@kislyuk I tried this already by including a custom hook for the library.
from PyInstaller.utils.hooks import collect_data_files

datas = collect_data_files("signxml")

This collects all the files correctly but the result still fails to run. The same happens with --add-data (under the hood is the same thing):
pyinstaller -F --add-data "signxml/schemas/*:signxml/schemas"  script.py

How to reproduce
On the repo top level create a script:
example_key = """
KEY HERE
""".encode()

example_pem = """
CERT HERE
""".encode()

from lxml import etree
from signxml import XMLSigner, XMLVerifier

data_to_sign = "<Test/>"
root = etree.fromstring(data_to_sign)
signed_root = XMLSigner().sign(root, key=example_key, cert=example_pem)
verified_data = XMLVerifier().verify(signed_root, x509_cert=example_pem).signed_xml
print("Finished successfully)

Run pyinstaller:
pyinstaller -F --add-data "signxml/schemas/*:signxml/schemas"  script.py

There are no errrors on the bundling. If you check the .spec file, the files are included:
a = Analysis(['script.py'],
             ...,
             datas=[('signxml/schemas/*', 'signxml/schemas')],
             ...)

But unfortunatelly it fails to run:
> ./dist/script
Traceback (most recent call last):
  File "script.py", line 57, in <module>
    verified_data = XMLVerifier().verify(signed_root, x509_cert=example_pem).signed_xml
  File "signxml/__init__.py", line 806, in verify
    self.schema().assertValid(signature)
  File "signxml/util/__init__.py", line 140, in schema
    cls._schema = etree.XMLSchema(etree.parse(schema_path))
  File "src/lxml/etree.pyx", line 3521, in lxml.etree.parse
  File "src/lxml/parser.pxi", line 1859, in lxml.etree._parseDocument
  File "src/lxml/parser.pxi", line 1885, in lxml.etree._parseDocumentFromURL
  File "src/lxml/parser.pxi", line 1789, in lxml.etree._parseDocFromFile
  File "src/lxml/parser.pxi", line 1177, in lxml.etree._BaseParser._parseDocFromFile
  File "src/lxml/parser.pxi", line 615, in lxml.etree._ParserContext._handleParseResultDoc
  File "src/lxml/parser.pxi", line 725, in lxml.etree._handleParseResult
  File "src/lxml/parser.pxi", line 652, in lxml.etree._raiseParseError
OSError: Error reading file '/tmp/_MEIuCyOxv/signxml/util/../schemas/xmldsig1-schema.xsd': failed to load external entity "/tmp/_MEIuCyOxv/signxml/util/../schemas/xmldsig1-schema.xsd"
[6343] Failed to execute script script

Now with the schemas as a python file
> git checkout develop
> pyinstaller -F script.py
> ./dist/script
Finished successfully

Thanks. I'm not sure why --add-data is not working for you there.
I'm going to reopen this issue and leave it open for visibility. I am not familiar with pyinstaller and its conventions for bundling files (which are apparently incompatible with setuptools). We need a pyinstaller expert to chime in here. I am open to modifying setup.py for this package to get the appropriate configuration in place for pyinstaller to work out of the box, but I need specific guidance with documented and supported features used to achieve this.

Thanks. I'm not sure why --add-data is not working for you there.
I'm going to reopen this issue and leave it open for visibility. I am not familiar with pyinstaller and its conventions for bundling files (which are apparently incompatible with setuptools). We need a pyinstaller expert to chime in here. I am open to modifying setup.py for this package to get the appropriate configuration in place for pyinstaller to work out of the box, but I need specific guidance with documented and supported features used to achieve this.

@bvanelli the pathlib change looks innocuous to me, but can you explain to me why it works? What is the effective path used with pathlib, and how is it different from the relative path to signxml/util/../schemas/xmldsig1-schema.xsd that apparently doesn't work with pyinstaller? I'm happy to accept your PR since it doesn't add anything custom or increase complexity, just curious what difference it makes.
You're free to make a PR to the pyinstaller hooks repo of course - I have no control over that - but it strikes me as a brittle and unmaintainable system if any package that uses standard setuptools data files functionality has to be added to that repo by name.


Mismatch in installed package checksums

Version
22.11.02
Explain the issue and what happens
On the matrix channel Samir mentioned some checksum mismatched when using pkg check -s. I ran the check to and found more or less the same mismatches but I wonder what is being checked.
Explain how to reproduce the bug?
pkg check -s
The output:
Checking all packages:  14%
ghostbsd-icons-1.8: checksum mismatch for /usr/local/share/icons/Qogir-dark/icon-theme.cache
ghostbsd-icons-1.8: checksum mismatch for /usr/local/share/icons/Qogir/icon-theme.cache
Checking all packages:  34%
hicolor-icon-theme-0.17: checksum mismatch for /usr/local/share/icons/hicolor/index.theme
Checking all packages:  65%
mate-control-center-1.26.0_3: checksum mismatch for /usr/local/share/applications/mimeinfo.cache
Checking all packages:  71%
os-generic-userland-boot-22.12.09: checksum mismatch for /boot/device.hints
Checking all packages:  71%
os-generic-userland-conf-22.12.09: checksum mismatch for /etc/passwd
Checking all packages:  95%
wireguard-tools-1.0.20210914_1: checksum mismatch for /usr/local/bin/wg-quick
Checking all packages: 100%
What is the Expected behavior (if applicable)
No mismatches :-)
Additional context (if applicable)
I am wondering what is checked. Is pkg check -s checking the actual packages or the installed files? Since if it looks at the installed files then it is not a bug but a logical find since it mentioned .cache files, the wireguard files (I changed one) and /etc/passwd. I think it is that what is checked (the man page isn't clear about that.

issue moved from ghostbsd/ghostbsd-src to ghostbsd/issues


support parsing multiple documents in istioctl

With this change istioctl create now expects YAML files that include name/type/spec.  An example YAML file in that format is provided for manual testing.
There was no existing test case to modify.  A test case for the istioctl commands is needed.

Jenkins job manager/presubmit passed

Jenkins job manager/presubmit passed

Jenkins job manager/presubmit passed

Please update the four-rules.yaml with correct rules and then i think this is good to go.

Jenkins job manager/presubmit passed


Explain Team Config Files

Is your request for enhancement related to a problem? Please describe.
It is unclear what the effect of running zowe config init and zowe config secure is with various switches (--global-config, --user-config).
Describe the solution you'd like
It would be valuable to have a concise description / overview / picture of all files that participate in team config (profiles v2), what they are called (terminology), how they are impacted by various zowe config commands and how they participate in profile contents resolution when a profile is read.

Closed with PR 2690.

See comment above.


Is there an event for cell hover?

Hi Paul, just getting started with jexcel. It solves addresses a major gap among spreadsheet libraries in tje JS world. Thank you.
I need to take an action on cell hover but I cant find any reference in the examples. Is there any support for cell hover event?

Thanks. I did but that’s on click of cell not on hover. I am looking for an event on cell mouseover .
Sent from my iPhone

On 02-Sep-2018, at 8:52 PM, Paul Hodel<EMAIL_ADDRESS>wrote:
Have you tried onselection method? Init:
onselection: function(a, b,c) {
// do your stuff
}
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Sorry, understand. I am going to add that in the next release.

Hi, the new event onmouseover is available in the master repo.

Thanks!
On Mon, Sep 3, 2018 at 1:35 AM Paul Hodel<EMAIL_ADDRESS>wrote:

Closed #212 https://github.com/paulhodel/jexcel/issues/212.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/paulhodel/jexcel/issues/212#event-1822374985, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AABDixa5HTNvgz3fpeLCNUlUrh7_f0wyks5uXDoEgaJpZM4WWpJC
.

--
https://in.linkedin.com/in/shehjar

Hi, when is the next release coming up? I could really use this about now. Thank you.

I add the onmouseover to the code, it does not stop at the focus function.
What is wrong?

...
jexcel(document.getElementById('spreadsheet'), {
    data:data,
    rowResize:true,
    columnDrag:true,
    columns: [
        { type: 'text', width:'200' },
        { type: 'text', width:'100' },
        { type: 'text', width:'100' },
        { type: 'calendar', width:'100' },
    ],
    onchange: changed,
    onbeforechange: beforeChange,
    oninsertrow: insertedRow,
    oninsertcolumn: insertedColumn,
    ondeleterow: deletedRow,
    ondeletecolumn: deletedColumn,
    onselection: selectionActive,
    onsort: sort,
    onresizerow: resizeRow,
    onresizecolumn: resizeColumn,
    onmoverow: moveRow,
    onmovecolumn: moveColumn,
    onload: loaded,
    onblur: blur,
    onfocus: focus,
    onmouseover: focus,
});

I check the element name of the table, it is "td".
I used "td:hover { background: pink; }.
It works for me,

Hi, the new event onmouseover is available in the master repo.

couldnt able to find event in master repo...  can u please hepl me with this ?

Is any update on mouse hover event for cell?


rafs: fix rafs v6 to obtain file parent inode

Currently, the parent of file is None,
we can set the parent inode by traversing root.
This PR is addressing #768
Signed-off-by: Bin Tang<EMAIL_ADDRESS>

I have different thought here. It's a little heavy to enhance get_inode_ext() to support such a case, it may  potentially cause serious performance issue. So I would prefer only to change nydus-image icheck implementation.


How to replace the Api path in the swagger.json file with the API gateway?

Instructions
I created two services: UserService, ProductService

The routing template of the UserService is: api/users/{id}
The routing template of the ProductService is: api/products/{id}

Then I created an Ocelot gateway service: ApiGateway
It is such a proxy for these two services:

/userService/swagger/{url}          -->   /swagger/{url}
/userService/{url}                         -->    /api/{url}
/productService/swagger/{url}    -->   /swagger/{url}
/productService/{url}                   -->    /api/{url}

An example is shown below:

The ui display is normal, but the obtained swagger.json file because of the road strength is: /api/users/{id}, which makes it impossible to use the test function provided by ui. How can I replace the api road force in swagger.json with What about gateway routing?
Thank you!

I also need this.

@zengqinglei I don't understand this description. What does "road strength" and "road force" mean?

The ui display is normal, but the obtained swagger.json file because of the road strength is: /api/users/{id}, which makes it impossible to use the test function provided by ui. How can I replace the api road force in swagger.json with What about gateway routing?

what @zengqinglei  means maybe the follows:

When you access the api via gateway,the url may be http://gateway/api/users/123, but the swagger ui requests may request http://userService/api/users/123, can I config any option or do something else to proxy the swagger ui request forware to the gateway ?

@domaindrivendev Yes, as @WeihanLi  said !
When you access the api via gateway,the url may be http://gateway/userService/users/123, api gateway will forward the request to: http://<IP_ADDRESS>/api/users/123, but the swagger ui requests may request http://gateway/api/users/123, can I config any option or do something else to proxy the swagger ui request forware to the gateway ?

Also facing this issue.

There might be a better way, but this is how we solved it:
app.UseSwagger(c => c.PreSerializeFilters.Add((swagger, httpReq) => {
                var oldPaths = swagger.Paths.ToDictionary(entry => entry.Key,
                                               entry => entry.Value);
                foreach(var path in oldPaths)
                {
                    swagger.Paths.Remove(path.Key);
                    swagger.Paths.Add(path.Key.Replace("api", "api/me"), path.Value);
                }
            }));

This will replace the 'api' strings with the api/me string, which is the configured downstream path in Ocelot for this specific microservice. But you get the idea!


Incorrect links in the README

Just a small, not-important issue about the README.markdown:
Some links in the "Introduction"-section are wrong:

TABLES: Link should maybe be http://fletcherpenney.net/multimarkdown/
ABBREVIATIONS: Link should be http://michelf.com/projects/php-markdown/extra/#abbr
DEFINITION LISTS: Link should be http://michelf.com/projects/php-markdown/extra/#def-list
FENCED CODE BLOCKS: http://michelf.com/projects/php-markdown/extra/#fenced-code-blocks

Typo in line "See http://sirthias.github.com/pegdown/api for the pegdown API documation."

Thanks!


API: Use symfony/http-foundation for sessions

I was going to do an RFC, but I got so far with my proof-of-concept that I ended up carrying on with it... so this is my RFC
An alternative proposal would be to remove the SilverStripe\Control\Session class entirely, and make HTTPRequest::getSession() return an instance of Symfony\Component\HttpFoundation\Session\SessionInterface. I didn’t go for that approach, because we still rely on the Foo.Bar.Baz session-name-to-array-traversal magic for things like form errors.
Pros are slightly less code to maintain (at least less complexity handling cookies on our end) and better support for/easier to configure save handlers.

It looks like some of the tests are failing possibly because of session leakage in tests? or maybe because the session isn't being passed correctly to the mock requests to framework?

@kinglozzer I'm currently going through some old PR's to see what is still active and what makes sense to be closed - is this one something you're still planning on keeping active or would you prefer to now close this one?

Let’s close it. I’d still like this change to happen, but I think we really need to remove the “dot-to-array” magic and handle the array traversal in user-code, rather than re-implement it all on top of a different layer... that’s a bigger job and bigger upgrade pain though so I think it’d make more sense as part of some wider request/response work rather than on its own

My suggestions here would be to experiment with swapping out the whole of Control, after #9679 is done. In principle your View and ORM would be able to be retained.
What the dev experience is like for that is anyone's guess, but it's worth an experiment ;-)


Windows 10 with UWF support

It would be great to have proper UWF exclusions for Windows 10.
Current documentation is only for Windows Embedded and it takes quite some effort to generate proper exclusion list, especially for Windows 10 LTSC 2019 which seem to differ from previous versions :(

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 06054b07-e62e-6444-54c1-2f9f95c6a0d2
Version Independent ID: 71d76827-704c-3496-a2dc-cd821d734efd
Content: Planning client deployment to Windows Embedded devices - Configuration Manager
Content Source: sccm/core/clients/deploy/plan/planning-for-client-deployment-to-windows-embedded-devices.md
Product: configuration-manager
Technology: configmgr-client
GitHub Login: @aczechowski
Microsoft Alias: aaroncz

Thanks @sccmfan for the feedback

Thanks again for the feedback. We moved this content to a new GitHub repository, so this issue is no longer tracked with the original article. As part of that process, we reviewed our backlog of feedback, and made some tough decisions on items that we don't think we'll realistically ever address. If you're passionate about this specific feedback, please refile it on the current article, now under docs.microsoft.com/mem/configmgr.


[improve][ci] Upgrade GitHub Actions versions to fix deprecation warning

Motivation
There's now a warning message for GitHub Actions:

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/cache@v3, actions/setup-java@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Modifications
Upgrade to actions/checkout@v4, actions/cache@v4 and actions/setup-java@v4
Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (d37d31f) 73.61% compared to head (462013e) 73.59%.
Report is 1 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #21978      +/-   ##
============================================
- Coverage     73.61%   73.59%   -0.02%
- Complexity    32433    32448      +15
============================================
  Files          1861     1861
  Lines        138738   138738
  Branches      15200    15200
============================================
- Hits         102130   102104      -26
- Misses        28704    28739      +35
+ Partials       7904     7895       -9

Flag
Coverage Δ

inttests
24.08% <ø> (-0.04%)
:arrow_down:

systests
23.66% <ø> (+0.02%)
:arrow_up:

unittests
72.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 62 files with indirect coverage changes


Laggy at FPS above 120

Describe your bug here.
Version: 0.0.1 pre-release
Issue: Any FPS above 120 lags the game until you load a song
OS: Linux (Untested on Windows)
Command Prompt/Terminal logs (if existing)
No response
Are you modding a build from source or with Lua?
Source
What is your build target?
Linux
Did you edit anything in this build? If so, mention or summarize your changes.
No

Fixed


Full Admin Template Support (PR Welcome!)

Hi all, We start to migrate more features and pages from the original vue-element-admin project, and I created a list of issues to better track the progress. You can help us with that too, just tell me which task you want to work on and I'll assign you that one, any PR is welcome, thanks! :)

中文版本: #40

Halfway done!

Mostly done!

Mark as done now for vue 2.


UVI Request

--- UVI JSON ---
{
  "vendor_name": "Linux",
  "product_name": "Kernel",
  "product_version": "versions from v4.14.222 to before v4.14.237",
  "vulnerability_type": "unspecified",
  "affected_component": "unspecified",
  "attack_vector": "unspecified",
  "impact": "unspecified",
  "credit": "",
  "references": [
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=e46d433754420b4d6513ca389403de88a0910279",
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=2d598902799886d67947406f26ee8e5fd2ca097f"
  ],
  "extended_references": [
    {
      "type": "commit",
      "value": "e46d433754420b4d6513ca389403de88a0910279",
      "note": "introduced"
    },
    {
      "type": "commit",
      "value": "2d598902799886d67947406f26ee8e5fd2ca097f",
      "note": "fixed"
    }
  ],
  "reporter": "joshbressers",
  "reporter_id": 1692786,
  "notes": "",
  "description": "tracing: Correct the length check which causes memory corruption\n\nThis is an automated ID intended to aid in discovery of potential security vulnerabilities. The actual impact and attack plausibility have not yet been proven.\nThis ID is fixed in Linux Kernel version v4.14.237 by commit 2d598902799886d67947406f26ee8e5fd2ca097f, it was introduced in version v4.14.222 by commit e46d433754420b4d6513ca389403de88a0910279. For more details please see the references link."
}
--- UVI JSON ---

This issue has been assigned UVI-2021-1000859


Upgrade Flutter and all packages to latest

Done because it's the first step in our plan for #612, the "Missing API declaration" warning from Apple.
Changelogs for deps that are major-version upgraded:
https://pub.dev/packages/device_info_plus/changelog
https://pub.dev/packages/file_picker/changelog
https://pub.dev/packages/flutter_local_notifications/changelog
https://pub.dev/packages/package_info_plus/changelog
https://pub.dev/packages/share_plus/changelog
https://pub.dev/packages/pigeon/changelog
Manual tests done:

My iPhone 13 Pro running iOS 17.3.1:

App starts up; pages load (including Inbox and message list)

Office Android device (Samsung Galaxy S9 running Android 9):

App starts up; pages load (including Inbox and message list)
DM notification received; navigates to conversation when tapped
device_info_plus exercised and seems to work correctly (discussion)

Related: #612

Thanks!
All these changes look good. I won't have time to read those changelogs before heading out on vacation; but if you've read them and nothing jumps out at you, and given that it passes your manual testing, please go ahead and merge. I looked through all these changes other than reading the changelogs.
All of these changelogs except `pigeon` mention adding "privacy
info" or "privacy manifest" in the version we're taking here --
exactly the kind of thing we want to see, with #612 in mind.

Great!
I would
guess that `pigeon` doesn't need one, as it's mainly just a code
generator tool.

Yeah. And more concretely: it's a dev dependency only, so it's not part of the actual app build.

Ah, and CI is failing — looks like you just need to update the Pigeon-generated output.
(And then I guess rerun the manual testing, unless the changes are trivial.)

Huh odd.
I guess one thing you can do to debug is to edit tools/check to print the full diff in that case, rather than the status.

Alternatively, try making a meaningless edit to the Pigeon input file and rerunning Pigeon — wonder if this is a caching issue, like the one we've seen with other code generators (using build_runner).

I guess one thing you can do to debug is to edit tools/check to print the full diff in that case, rather than the status.

Aha, this seems like a useful clue from that output:
-// Autogenerated from Pigeon (v17.2.0), do not edit directly.
+// Autogenerated from Pigeon (v18.0.0), do not edit directly.

The issue seems to be that the old Pigeon 17 is running locally despite the upgrade in the headline commit taking it to Pigeon 18. The command tools/check pigeon --all-files kept succeeding.
Then I did something different:
$ dart run pigeon
Resolving dependencies in `/Users/chrisbobbe/dev/zulip-flutter`...
Downloading packages...
Got dependencies in `/Users/chrisbobbe/dev/zulip-flutter`.
Building package executable... (5.2s)
Built pigeon:pigeon.
Pigeon is a tool for generating type-safe communication code between Flutter
and the host platform.

usage: pigeon --input <pigeon path> --dart_out <dart path> [option]*
[…]

and thereafter, tools/check pigeon --all-files is failing, which is the expected behavior from Pigeon 18. I think the Building package executable... step is what got it working. Is there a nice way to make sure that gets run automatically when our Pigeon version changes?

Anyway, revision pushed; tools/check pigeon should be happy now.

And I've just redone manual tests for Android notifications. (The code did look NFC to me, but just for good measure.)

All these changes look good. I won't have time to read those changelogs before heading out on vacation; but if you've read them and nothing jumps out at you, and given that it passes your manual testing, please go ahead and merge.

Cool; yep. Merging.

Filed #622 for the Pigeon version issue.


Feature Request: Right Click Hop to World

Hey, thanks for the great plugin. I'd like to request a QOL change so that you can right click a record and automatically hop to that world.

Fixed in commit b7561d2bd543826501b7d8058547a485bca102fa for v1.0.1


Read ssh public keys from an authorized_keys file

What version of nebula are you using?
1.8.1
What operating system are you using?
Linux, macOS, iOS
Describe the Bug
Make able to read public access keys for ssh service from an authorized_keys file.
Now I have to describe each key explicitly in the conf file which is not very useful.
Logs from affected hosts
No response
Config files from affected hosts
sshd:
  enabled: true
  listen: <IP_ADDRESS>:2222
  host_key: /etc/ssh/ssh_host_ed25519_key
  authorized_users:
    - user: root
      keys:
        - /root/.ssh/authorized_keys

Trusing ssh certificates issued by an ssh ca would also be very useful.
For our use case more useful than authorized_keys - if it has an option to limit access by groups

https://en.wikibooks.org/wiki/OpenSSH/Cookbook/Certificate-based_Authentication
https://www.hashicorp.com/blog/managing-ssh-access-at-scale-with-hashicorp-vault

@ieugen Can you file an additional ticket for that request? I think there are different use cases for these features, and they deserve to be separate FRs.


Consider removing the boost dependency

The roof duality functions rely on several boost graph objects. This makes installing from sdist problematic, also building on read the docs. We should determine if we can remove the boost dependency without significantly affecting performance or the clarity of the code.

Upon further inspection, the two boost functions strong_components and push_relabel_max_flow would be difficult to replace without significant additional code needed. With the changes added by #284 I am closing this issue as being infeasible.


create example for how to mount custom files into running k2 image

for all supported platforms (aws, gke) mount the default location into k2 of the on-disk credentials.  for aws this will be ~/.aws and I'm not sure what the default is for gke.

there is already auto-mounting code to handle a local path.  create an example in a quick start guide that shows this.

closed, README was much improved


Assumes organization-image entity is embedded

Dunno if this or https://github.com/Brightspace/course-image is "at fault", but if organization-image is an embedded link on the organization, then we try to fetch undefined via writing it out as the src/srcset on the img.

https://github.com/Brightspace/d2l-my-courses-ui/blob/dd91cd099290cffabcd782f4cc556f1df0282f5a/src/d2l-course-tile.html#L723-L725

https://github.com/Brightspace/d2l-my-courses-ui/blob/dd91cd099290cffabcd782f4cc556f1df0282f5a/src/d2l-course-tile.html#L384,L395
Not completely related (different code-path), but this assumes getDefaultImageLink and getImageSrcSet returned something useful.

https://github.com/Brightspace/course-image/blob/f264e99e8625c08a197c2e59c81012d68b922c58/d2l-course-image.html#L138-L140
And similarly, but somewhat more relatedly, course-image assumes it was passed in a full entity (could be a legit assumption, but it doesn't verify it) and the getDefaultImageLink and getImageSrcSet return something useful.

Looks like d2l-organization-hm-behavior is the underlying issue within d2l-course-image. Not sure if it should also work with image links, or leave fetching the entity up to the consumer...

Hokay, resolved I believe, with https://github.com/Brightspace/organization-hm-behavior/pull/16, https://github.com/Brightspace/course-image/pull/18, and https://github.com/Brightspace/d2l-my-courses-ui/pull/509.
Note that these fixes just remove the assumption; they don't add support for linked entities. I figure that's probably it's own thing? In general we don't have a lot of places where we're supporting linked entities (if (entity.href) { fetchTheEntity.then(stuff); }), but we certainly could.
Also worth noting that d2l-course-tile is being replaced by d2l-course-image-tile, which only requires one of the two fixes mentioned above.


Add integration resource and end points

Need to add:

Resource integration
End point - integrations list
Ability to select integration by id
Ability to create new integrations
Ability to update integration
Ability to delete integration
Ability to get stories list for selected integration

We happily accept pull requests. There are good patterns in place for most of this so it should be pretty straight forward.


Question: if I want to subtract a manual dark image, how?

I have constructed a numpy array of a dark image, from the raw_image values, and want to apply this to the data image before postprocess - however I get:
AttributeError: attribute 'raw_image' of 'rawpy._rawpy.RawPy' objects is not writable

trying to:
    black = raw.black_level_per_channel
    assert black[0] == black[1] == black[2] == black[3]
    help(raw)
    raw.raw_image += black[0]
    raw.raw_image -= dark

here the += black[0] is to ensure value stays positive as all data are type uint16 i.e. keep standard black value...
Any help much appreciated!

Solved myself - should have remembered numpy array syntax:
    raw.raw_image[:,:] = raw.raw_image + black[0] - dark

Good that you solved it. If  dark is also just a scalar, then you can simply do:
raw.raw_image[:] += black[0] - dark

Dark here is an array of same size as raw_image.
You have a place where things like this could be documented? I am happy to do so...

Currently the place for more tutorial-like examples would be https://github.com/letmaik/rawpy-notebooks. There's no place currently for shorter code snippets. So, if you have a nice use case that involves modifying the raw bayer data, then that could become a Jupyter notebook. Before starting on that, please open an issue that repo to discuss what it is about and whether it fits.


Rate Limit Error

openai.RateLimitError: Error code: 429 - {'error': {'message': 'You exceeded your current quota, please check your plan and billing details. For more information on this error, read the docs: https://platform.openai.com/docs/guides/error-codes/api-errors.', 'type': 'insufficient_quota', 'param': None, 'code': 'insufficient_quota'}}

So this is the problem I faced currently, may I know what are the possible solutions to solve this?

This is from Openai itself; as your message says, you need to increase your quota or plan. Could you check your billing page?

The error message indicates that you have exceeded your current usage quota for OpenAI's API.
You can check your API usage throughUsage Dashboard


Installation using Python's easy_install does not work

Originally submitted to Google Code by filip.noetzel on 14 Oct 2010

I'd like to be able to install robotframework-seleniumlibrary via setuptools (more specifically inside my zc.buildout setup).
Here's what happens if I try to do that (I don't have any global packages installed on my machine, not even robotframework):
user@box $> easy_install http://robotframework-seleniumlibrary.googlecode.com/files/robotframework-seleniumlibrary-2.4.tar.gz
install_dir /Library/Python/2.6/site-packages/
Downloading http://robotframework-seleniumlibrary.googlecode.com/files/robotframework-seleniumlibrary-2.4.tar.gz
Processing robotframework-seleniumlibrary-2.4.tar.gz
Running robotframework-seleniumlibrary-2.4/setup.py -q bdist_egg --dist-dir /var/folders/am/amvgZGWsGOiqK+2kOSmf4k+++TI/-Tmp-/easy_install-IF9W8h/robotframework-seleniumlibrary-2.4/egg-dist-tmp-mBX1pR
Traceback (most recent call last):
File "/usr/local/bin/easy_install", line 8, in <module>
load_entry_point('distribute==0.6.14', 'console_scripts', 'easy_install')()
File "build/bdist.macosx-10.6-universal/egg/setuptools/command/easy_install.py", line 1855, in main
File "build/bdist.macosx-10.6-universal/egg/setuptools/command/easy_install.py", line 1836, in with_ei_usage
File "build/bdist.macosx-10.6-universal/egg/setuptools/command/easy_install.py", line 1859, in <lambda>
File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/distutils/core.py", line 152, in setup
dist.run_commands()
File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/distutils/dist.py", line 975, in run_commands
self.run_command(cmd)
File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/distutils/dist.py", line 995, in run_command
cmd_obj.run()
File "build/bdist.macosx-10.6-universal/egg/setuptools/command/easy_install.py", line 342, in run
File "build/bdist.macosx-10.6-universal/egg/setuptools/command/easy_install.py", line 557, in easy_install
File "build/bdist.macosx-10.6-universal/egg/setuptools/command/easy_install.py", line 612, in install_item
File "build/bdist.macosx-10.6-universal/egg/setuptools/command/easy_install.py", line 802, in install_eggs
File "build/bdist.macosx-10.6-universal/egg/setuptools/command/easy_install.py", line 1079, in build_and_install
File "build/bdist.macosx-10.6-universal/egg/setuptools/command/easy_install.py", line 1068, in run_setup
File "build/bdist.macosx-10.6-universal/egg/setuptools/sandbox.py", line 29, in run_setup
File "build/bdist.macosx-10.6-universal/egg/setuptools/sandbox.py", line 70, in run
File "build/bdist.macosx-10.6-universal/egg/setuptools/sandbox.py", line 31, in <lambda>
File "setup.py", line 25, in <module>
File "/var/folders/am/amvgZGWsGOiqK+2kOSmf4k+++TI/-Tmp-/easy_install-IF9W8h/robotframework-seleniumlibrary-2.4/src/SeleniumLibrary/init.py", line 25, in <module>
ImportError: No module named robot.errors
This is because of this line:
https://code.google.com/p/robotframework-seleniumlibrary/source/browse/setup.py?r=6e6650df15f171118295457b3396be1cc59e9c47#25
from SeleniumLibrary import version
I propose
(a) moving the actual code (except the version declaration) from src/SeleniumLibrary/init.py to src/SeleniumLibrary/seleniumlibrary.py
or
(b) duplicating the version information to setup.py (not very DRY)

Originally submitted to Google Code by @yanne on 14 Oct 2010

Due to the way Robot Framework library imports work, the class SeleniumLibrary actually needs to be in init.py (Otherwise, it would have be imported like seleniumlibrary.SeleniumLibrary)
A third alternative solution would be a separate src/SeleniumLibrary/version.py, which could be imported from setup and init

Originally submitted to Google Code by ownersci... on 19 Oct 2010

You wouldn't be able to import a version.py, but would instead need to do:
execfile('src/SeleniumLibrary/version.py')

inside of setup.py.  Otherwise, the import will cause init.py to be loaded, with the same results.

Originally submitted to Google Code by @yanne on 12 Nov 2010

Implemented the solution proposed by the.real.pjeby in r8c265e1f4faf, thanks a lot for the hint.


Add -Wconversion flag to protect future developments

Same reasons as https://github.com/ros-controls/ros2_control/pull/1053
explicitly catching errors of time being zero in forward_command_controller see
I think there might be an ABI breaking in JTC with one argument changed from int to size_t. I did not know what to do there, and went for ABI breaking but I could also make it a static_cast if preferred. see

@mergifyio backport humble iron