Exception "Cannot Change The Following Flags For Property (6, Double) from 2 to 4"

Hi,
Just trying to get up and running here. I'm using Kotlin, and was able to get a couple of trivial entities to put/get, so thought I'd add some additional entities. Unfortunately i get an io.objectbox.exception.DbException when I initialize the Box. Specifically:

Cannot change the following flags for Property latitude (6, Double) (LocationSummary) from 2 to 4 (problematic flags: 4). Consider creating a new property instead.

This doesn't appear to be documented anywhere, nor was I able to find anything related out in the larger world.  I'm coming from GreenDao, so I thought at first maybe I needed to bump the schema version, but that doesn't seem to be an ObjectBox thing. Any thoughts? Thanks!
Environment

ObjectBox version (check if you are using the newest version): 0.9.15
Android version: 26.0.1
Kotlin 1.1.4-2

Steps that lead to the bug
Description
In my App class onCreate(), I build the box:
val boxStore: BoxStore = MyObjectBox.builder().androidContext(this).build()
Stacktrace:

08-26 13:29:28.391 29866-29866/us.tacticaledge.rubberduck E/AndroidRuntime: FATAL EXCEPTION: main
 Process: us.tacticaledge.rubberduck, PID: 29866
 java.lang.RuntimeException: Unable to create application us.tacticaledge.rubberduck.ConvoyApp: io.objectbox.exception.DbException: Cannot change the following flags for Property latitude (6, Double) (LocationSummary) from 2 to 4 (problematic flags: 4). Consider creating a new property instead.
     at android.app.ActivityThread.handleBindApplication(ActivityThread.java:5364)
     at android.app.ActivityThread.-wrap2(ActivityThread.java)
     at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1528)
     at android.os.Handler.dispatchMessage(Handler.java:102)
     at android.os.Looper.loop(Looper.java:154)
     at android.app.ActivityThread.main(ActivityThread.java:6077)
     at java.lang.reflect.Method.invoke(Native Method)
     at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:865)
     at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:755)
  Caused by: io.objectbox.exception.DbException: Cannot change the following flags for Property latitude (6, Double) (LocationSummary) from 2 to 4 (problematic flags: 4). Consider creating a new property instead.
     at io.objectbox.BoxStore.nativeCreate(Native Method)
     at io.objectbox.BoxStore.<init>(BoxStore.java:163)
     at io.objectbox.BoxStoreBuilder.build(BoxStoreBuilder.java:227)
     at us.tacticaledge.rubberduck.ConvoyApp.getDataStore(ConvoyApp.kt:271)
     at us.tacticaledge.rubberduck.ConvoyApp.init(ConvoyApp.kt:181)
     at us.tacticaledge.rubberduck.ConvoyApp.onCreate(ConvoyApp.kt:254)
     at android.app.Instrumentation.callApplicationOnCreate(Instrumentation.java:1024)
     at android.app.ActivityThread.handleBindApplication(ActivityThread.java:5361)
     at android.app.ActivityThread.-wrap2(ActivityThread.java)
     at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1528)
     at android.os.Handler.dispatchMessage(Handler.java:102)
     at android.os.Looper.loop(Looper.java:154)
     at android.app.ActivityThread.main(ActivityThread.java:6077)
     at java.lang.reflect.Method.invoke(Native Method)
     at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:865)
     at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:755)

Trigger code
    `val boxStore: BoxStore = MyObjectBox.builder().androidContext(this).build()`

Entities
The entity is:
@Entity
data class LocationSummary (
    val locationId: String,
    val name: String,
    val type: String,
    val description: String,
    val latitude: Double,
    val longitude: Double,
    @Id var id: Long = 0
)

Other

[] Is the bug happening inside a transaction?
[] To what degree does your app run multi-threaded?
[] Do you use indexes, especially on the queried properties?
[] Do you use explicit transactions?
[] Anything else special about your app?

Looks like the problem is the schema is "stale". In GreenDAO there's a build.gradle entry to "bump" the schema version. Is there something like this for ObjectBox, or something similar, or do you have to delete the app every time you change the schema?
Thanks!

Thanks for the quick response! Is there a way to just force a schema "refresh" short of uninstalling/reinstalling the app? If not, no big deal. Just a lot of flux right now to start twiddling with UIDs...
Thanks again!


Misc test and build clean-up

What this PR does / why we need it:

Fix the following bazel WARNING

WARNING: <...> /external/bazel_tools/tools/build_defs/pkg/pkg.bzl:196:9: pkg_tar: renaming non-dict `files` attribute to `srcs

Enable consistent checks in bash scripts (errexit, nounset, pipefail)

Remove noisy debug print fro bin/bazel_to_go

Remove bash color codes (i.e. "\033[1;34m"). This makes visually parsing prow test logs more difficult.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
Release note:

@ayj let's test one at a time.

Please test the defaults pr after this

SGTM - i'll hold off on rebase/resting until https://github.com/istio/pilot/pull/1243 is merged

@ayj: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/pilot-presubmit.sh
e7f9b4afe6b6089bd6649f16e70673be948acd55
link
/test pilot-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ayj: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/pilot-presubmit.sh
fe52f5279d7ab28e370ff003b251259a4bc070cf
link
/test pilot-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ayj: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/pilot-presubmit.sh
6e67ff3f643fb245af4f753fce9a5f489ae99fb3
link
/test pilot-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ayj: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/pilot-presubmit.sh
8dd99ce407fa4aa98369d9daad4588dd68cadd71
link
/test pilot-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ayj: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/pilot-presubmit.sh
bb62da15f299ea533ae5237f606249bcdb526399
link
/test pilot-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ayj: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/pilot-presubmit.sh
643bcfa45aed76a03e1da3445a74387a1496f92c
link
/test pilot-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ayj it still doesn't pass the build
and needs release-note set to NONE (or filled; just not empty)

/release-note-none


add amazon polarity dataset

This corresponds to the amazon (binary dataset) requested in https://github.com/huggingface/datasets/issues/353

amazon_polarity is probably a subset amazon_us_reviews but I am not entirely sure about that.
I guess amazon_polarity will help in reproducing results since even if it is a subset from amazon_us_reviews, it is not trivial how to extract amazon_polarity from amazon_us_reviews, especially since amazon_us_reviews was released after amazon_polarity.

do you know what the problem would be ? should I pull the master before ? @lhoestq

The error just appeared on master. I will try to fix it today.
You can ignore them since it's not related to the dataset you added

merging since the CI is fixed on master

Great thanks for the help.

Great thanks for the help.


Fix bug in album track listing

Trying to list the tracks in an album borks with this stack trace:
   ERROR    [HttpServer] mopidy_iris.handlers local variable 'data' referenced before assignment
   ERROR    [YTMusicBackend-3 (_actor_loop)] mopidy_ytmusic YTMusic failed getting tracks for album "xxx"
   Traceback (most recent call last):
     File "/usr/local/lib/python3.10/dist-packages/mopidy_ytmusic/library.py", line 437, in lookup
       tracks = self.albumToTracks(res, bId)
     File "/usr/local/lib/python3.10/dist-packages/mopidy_ytmusic/library.py", line 904, in albumToTracks
       songartists = [Artist(name=song["artists"])]
     File "/usr/lib/python3/dist-packages/mopidy/models/immutable.py", line 159, in __call__
       instance = super().__call__(*args, **kwargs)
     File "/usr/lib/python3/dist-packages/mopidy/models/immutable.py", line 35, in __init__
         self._set_field(key, value)
     File "/usr/lib/python3/dist-packages/mopidy/models/immutable.py", line 188, in _set_field
       object.__setattr__(self, name, value)
     File "/usr/lib/python3/dist-packages/mopidy/models/fields.py", line 50, in __set__
       value = self.validate(value)
     File "/usr/lib/python3/dist-packages/mopidy/models/fields.py", line 34, in validate
       raise TypeError(
     TypeError: Expected name to be a <class 'str'>, not [{'name': 'blah', 'id': None}]

This was an apparent typo since the type validation clearly expects a
string and not the full Artist object.

Fixes #63

Fixes #39

Thanks for the fix. Finally I am able to load the tracks of an album (built and installed from your branch). Please merge.

@impliedchaos Sorry for the ping but can this be merged? This fixes #39, #38 and #63. It also removes the need of pr's #62 and #55 i think.

No worries on the ping, apparently I needed it.   I'll get this merged and push out a new bugfix release ASAP.


Disable quic_platform_test by default

Description:
Disable quic_platform_test by default. Enable it only when "--define enable_quiche=enabled" is specified in the bazel command line.
This is needed to workaround a issue with --experimental_remap_main_repo + ci asan build, see here for details.
Risk Level: minimal: build only
Testing:
I introduced a failure in quic_platform_test, then confirmed quic_platform_test still passes by default(since it does nothing), and failed when "--define enable_quiche=enabled" is specified.
Also ran "./ci/run_envoy_docker.sh './ci/do_ci.sh bazel.asan'" to confirm the ci issue is gone.
Docs Changes: none
Release Notes: none
[Optional Fixes #Issue]
[Optional Deprecated:]

/retest

/retest

ci keeps fail for this PR, I've re-created #5838 to replace this. Sorry for the churn!


[FEATURE] Customize prefix of boolean getter

Let's say I have the following class:
@Data
public class MyEntity {
  private boolean contactform;
}

Lombok then provides the getter method isContactform(). In some cases I'd like this method to be called hasContactform().
Could we provide a feature/property which allows changing the prefix for a specific field?

Duplicate of #836 (a denied request).
I have a strong opinion on the naming (which doesn't matter as I'm not a lombok project member). Nonetheless, you may want to read my https://github.com/rzwitserloot/lombok/issues/836#issuecomment-501886584.
In any case, I'd suggest to call the variable hasContactform (or alike) as it's a boolean rather than a form.


when using baseUrl errors only show path as url property.

I am not sure if this github issue should bubble up to request itself but whenever an error is raised with a request client defaulted with a baseUrl, the error message will only show the path instead of the full url, which makes it almost impossible to debug.

You are talking about using rp.defaults({ baseUrl: ... }), right? You may have a look at err.options but as far as I remember these options don’t contain the defaults. That said, err.response certainly has the full info. In particular, have a look at err.response.req which is the original request.


Tag and generate a release

@mhogg, could we please generate a release (v0.1.9) to deploy the wheels for Python 3.12? Thanks!

Done


binlog-schema delete is always failed

What did you do?
from https://asktug.com/t/topic/963049, and test locally
» binlog-schema delete test start_task t -s mysql-replica-01
{
    "result": true,
    "msg": "",
    "sources": [
        {
            "result": false,
            "msg": "[code=44009:class=schema-tracker:scope=internal:level=medium], Message:  is not a valid `CREATE TABLE` statement, RawCause: [parser:1149]You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use",
            "source": "mysql-replica-01",
            "worker": ""
        }
    ]
}

What did you expect to see?
I didn't see any positive test case about binlog-schema delete, we should add it.
What did you see instead?
No response
Versions of the cluster
DM version (run dmctl -V or dm-worker -V or dm-master -V):
(paste DM version here, and you must ensure versions of dmctl, DM-worker and DM-master are same)
nightly

Upstream MySQL/MariaDB server version:
(paste upstream MySQL/MariaDB server version here)

Downstream TiDB cluster version (execute SELECT tidb_version(); in a MySQL client):
(paste TiDB cluster version here)

How did you deploy DM: tiup or manually?
(leave TiUP or manually here)

Other interesting information (system version, hardware config, etc):
>
>

current status of DM cluster (execute query-status <task-name> in dmctl)
DM is paused
» query-status test
{
    "result": true,
    "msg": "",
    "sources": [
        {
            "result": true,
            "msg": "",
            "sourceStatus": {
                "source": "mysql-replica-01",
                "worker": "worker2",
                "result": null,
                "relayStatus": null
            },
            "subTaskStatus": [
                {
                    "name": "test",
                    "stage": "Paused",
                    "unit": "Sync",
                    "result": {
                        "isCanceled": false,
                        "errors": [
                            {
                                "ErrCode": 20057,
                                "ErrClass": "config",
                                "ErrScope": "internal",
                                "ErrLevel": "high",
                                "Message": "start-time 2037-12-12 01:02:03 is too late, no binlog location matches it",
                                "RawCause": "",
                                "Workaround": "Please check the `--start-time` is expected or try again later."
                            }
                        ],
                        "detail": null
                    },
                    "unresolvedDDLLockID": "",
                    "sync": {
                        "totalEvents": "0",
                        "totalTps": "0",
                        "recentTps": "0",
                        "masterBinlog": "(mysql-bin.000001, 1410)",
                        "masterBinlogGtid": "0add8fb9-0201-11ed-9e0a-de5ffb51d67e:1-6",
                        "syncerBinlog": "(mysql-bin.000001, 1410)",
                        "syncerBinlogGtid": "0add8fb9-0201-11ed-9e0a-de5ffb51d67e:1-6",
                        "blockingDDLs": [
                        ],
                        "unresolvedGroups": [
                        ],
                        "synced": true,
                        "binlogType": "remote",
                        "secondsBehindMaster": "0",
                        "blockDDLOwner": "",
                        "conflictMsg": ""
                    },
                    "validation": null
                }
            ]
        }
    ]
}

This bug is because:
binlog-schema delete is set request's schema to empty
https://github.com/pingcap/tiflow/blob/1775b4f3dc1e3558af49be7c847ed2d3f3212de7/dm/ctl/master/source_table_schema.go#L179
then create SQL is empty
https://github.com/pingcap/tiflow/blob/1775b4f3dc1e3558af49be7c847ed2d3f3212de7/dm/syncer/schema.go#L84-L100
so parse create SQL failed
https://github.com/pingcap/tiflow/blob/1775b4f3dc1e3558af49be7c847ed2d3f3212de7/dm/syncer/schema.go#L108

/lable affects-6.0 affects-6.1 affects-6.2 affects-6.3

/lable affects-6.0

/assign @WizardXiao


atlas: init at 0.13.0

Description of changes
Add https://atlasgo.io/
Closes https://github.com/NixOS/nixpkgs/issues/197774
Closes https://github.com/NixOS/nixpkgs/issues/245472
Closes https://github.com/NixOS/nixpkgs/issues/247368
Closes https://github.com/NixOS/nixpkgs/pull/201531

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 251839 run on x86_64-linux 1

1 package built:

atlas

Result of nixpkgs-review pr 251839 run on x86_64-linux 1

1 package built:

atlas

Can you update the PR title to the new version?


Request trove classifier

can anyone tell me how to permanently delete project from pypi.org
while uploading package it will generate error
`HTTPError: 400 Client Error: This filename has already been used, use a different version. See https://test.pypi.org/help/#file-name-reuse for url: https://test.pypi.org/legacy/
`

This seems like a PyCharm issue, I'd recommend contacting support.


[FEATURE REQUEST] .NET 5 support?

It would be super awesome if you could migrate to .NET 5. I've forked the repository and got it working fairly easily. Just hoping support from the official nuget package :).

https://github.com/RobinPerris/DarkUI/pull/62


It is not possible to execute inside  a thread pool?

Can I execute nio api in a set of threads? In addition is possible to esecute selector inside a abstract pool of fibers or threads?

I'm closing this due to inactivity.


dartdev run command doesn't handle Windows drive letters

Running dart run c:\src\dart-repo2\sdk\temp\abstract.dart results in
Unsupported operation: Cannot extract a file path from a c URI
#0      _Uri.toFilePath (dart:core/uri.dart:2710:7)
#1      RunCommand.run (package:dartdev/src/commands/run.dart:132:10)
#2      CommandRunner.runCommand (package:args/command_runner.dart:197:27)
#3      DartdevRunner.runCommand (package:dartdev/dartdev.dart:238:24)
#4      CommandRunner.run.<anonymous closure> (package:args/command_runner.dart:112:25)
#5      new Future.sync (dart:async/future.dart:223:31)
#6      CommandRunner.run (package:args/command_runner.dart:112:14)
#7      runDartdev (package:dartdev/dartdev.dart:107:27)
#8      main (file:///c:/src/dart-repo2/sdk/pkg/dartdev/bin/dartdev.dart:13:9)
#9      _startIsolate.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:297:32)
#10     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:168:12)

See also #42779 for the unhandled corner case of running dart run \\?\c:\src\dart-repo2\sdk\temp\abstract.dart.

FYI @devoncarew

Assigning to Ben for triage.

@zichangg is investigating #42779 which this is related to. Zichang, feel free to reach out to me if you need any help with this. I'm guessing we'll just need to update some logic in pkg/dartdev/lib/src/commands/run.dart to handle this case.

Thanks! Franklin brings up the good point that this may be something that we'd want to have in for the coming branch for trhe next beta, ~monday next week.

@zichangg - I believe this is fixed now?

Yes.
For "\?" prefixed string, it needs some works in frontend to get it fixed and it will be tracked in the other issue.


[Arabic] translate the question

This needs rebased on master or recreated, sorry 😭

Haha!

Thanks for your contribution to Homebrew!  You rock!


Flake does not provide attribute 'packages.x86_64-linux.default' or 'defaultPackage.x86_64-linux'

Hey sorry I have very less knowledge about this stuff. I wanted to compile my own version of this to add custom programs and configs etc...
How I (cross)compile this from a x86-64 NixOS machine as easy as possible?
Thank you very much.
EDIT: Getting this error on nix build:
error: flake 'git+file:///home/cenk/nixos-orangepi-5x' does not provide attribute 'packages.x86_64-linux.default' or 'defaultPackage.x86_64-linux'

Just follow the README, this project is cross-compiled by default.

Yes but I get this error when trying to build:
error: flake 'git+file:///home/cenk/nixos-orangepi-5x' does not provide attribute 'packages.x86_64-linux.default' or 'defaultPackage.x86_64-linux'
I thought it was because of some cross compilation stuff but maybe you have any idea would highly appreciate. Thanks!

error: flake 'git+file:///home/cenk/nixos-orangepi-5x' does not provide attribute

@phaitonican The error shows you are using fb87/nixos-orangepi-5x instead of mine, and the build command provieded by my README is not nix build.

Thank you very much I accidently opened this issue in wrong repo. Yea the readme there is very confusing and i ask whats the command for it if not nix build its more like nix build .#something but either way his flake is not made for cross compilation on x86_64 so I will try to figure out still thank you and if you got any help for other repo I would highly appreciate thanks.


feat: add provider function for configuring route injection functions

PS: I'm not so sure about this!
One other way to fix this is to use snapshot and get rid of requireSync at all.
cc @nartc @fiorelozere @ajitzero

Going with a different approach:
https://github.com/nartc/ngxtension-platform/pull/339
This should not fail anymore, but Ionic users will have to check for the value if it's nullish before using them.


show enlarged card on mouseover

hide when mouse leaves extent of smaller image
do nothing if zoomed in beyond a certain level
hide when startdrag on smaller image

clicking card should make it stick unless clicked off of


Suggest supportbot when message is posted

May be able to use "conversations" api methods to detect first message in thread.

Actually can just use timestamps.  Added in latest commit.

We can probably use the user list block to manually add people to @.

Is the idea to @ the member or a support volunteer?

Marg wanted it to @ a member.  I'm not sure if it's worth it since this would happen infrequently and it's easy to just @ them manually.  Thought I'd at least look into it.


update major for aio-cli-lib-app-config

Description
TO DISCUSS: potential breaking  change because now every command that loads the configuration will undergo schema validation (via load in aio-cli-lib-app-config) and we may have some corner cases that were working without being valid
Depends on a release for https://github.com/adobe/aio-cli-lib-app-config/pull/21 and https://github.com/adobe/aio-cli-lib-app-config/pull/22

async config
no validation here, use aio-cli-lib-app-config instead.

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

Note tests are failing here but passing with local linking of  aio-cli-lib-app-config

do not merge yet.
pre-release at @adobe/aio-cli-plugin-app@next
needs release of aio-cli-lib-app-config and updated package.json

closing this for now as it is outdated

For now let's just disable validation to move forward, see https://github.com/adobe/aio-cli-lib-app-config/pull/32


Uninstallation instruction

The are no instruction how to uninstall teleconsole

Just noticed this issue #39 . But still, it would be nice to mention that in official docs.


Service Plan Information Missing in Kubernetes Secrets

Hi colleagues,
we noticed that upon creating a service binding (e.g. for XSUAA, IAS or Destination Service) the Service Operator "only" provides the credentials as Kubernetes secret.
However, some existing libraries and applications rely on other information that is usually available in the service binding. For example, the Java Security Library requires the service plan to be available for IAS or XSUAA bindings. Other services may provide other information outside of the service credentials, e.g. different endpoints for read/write, settings etc.
Q: Will the Service Operator provision such values in the future? If not, how should applications obtain the required information?
Thanks in advance!

Hi @MatKuhr,
We have a similar problem with the tags information being unavailable for the proper VCAP_SERVICES env variables replication, so we created a proposal #80 to add tags key as a part of the secret.
I assume that the plan information could be handled in the similar way (i.e. plan key in the ServiceBinding secret).

@MatKuhr @pbusko
we will provide a fix for that soon and all additional information will be on the secret.
@pbusko please close the PR as tags will be also available on the secret.
BTW query by catalog name can return multiple results because of subaccount scoped brokers and the tags could be wrong in your PR.
Thanks for your input.

please use release v0.1.12

Thanks a lot for the quick response! My colleague @cschubertcs tried it out and it worked, the information is now available. Highly appreciated! We'll build on that and get back to you in case we have more feedback / questions.


focus issue on single select - holding mouse button on open fixes it?

<select id="vinfo-timezone" class="form-control select2" name="settings[timezone]" style="width:100%;">
	<?php get_timezone($result['timezone']); ?>
</select>

Using the above to populate all timezones so a user can select.  What happens is on mouse click the dropdown opens, but it is similar to the mouse button being held down even when it is not... I can move the cursor around and all the text/content on the page is highlighted as if I were holding the button down for a copy.  Upon another click of the mouse the 'highlighting' is removed, but it also closes the dropdown making the whole select unusable.
The strange behavior I found is upon initial click of the select if I hold my mouse button down until the drop down shows, then release it, everything works correctly.  I did some digging and I believe this could be because of a settimeout() in the actual select2 code for single selects, but I don't see how it would affect this situation.
The php function is going to run on load so all the options would present before anyone has a chance to see/click on the select.  Is it simply because the list is rather large (all the timezones foreach(DateTimeZone::listIdentifiers() as $tz) {...) or what?

I played around with this some more... if I manually enter options in my html (not using php to populate them) the issue still occurs, but only seems to happen if the list of options is rather large.  When only a few options are entered it does not occur.  This eliminates php being a problem so it seems as though this has something to do with the size of the options?
I would still like to know why holding the mouse down for around on second or so on initial click ALWAYS prevents this and it works as it should.
I love select2, but this is the second time around I have tried integrating 4.0 into our project and it has been nothing but problems whereas 3.5 has been working great for awhile now with none of these issues and the exact same code (minus the select2 initialization changes needed).

If we could get a jsbin that consistently reproduced this, that would give us a decent starting place. It may be an issue with large data sets, but usually there aren't enough timezones to cause problems.

Can you expand upon the issue you are facing by adding a few more pieces of information to your bug report?

What steps can be used to reproduce the issue?
What is the bug and what is the expected outcome?
What browser(s) and Operating System have you tested with?
Does the bug happen consistently across all tested browsers?
What version of jQuery are you using? And what version of Select2?
Are you using Select2 with other plugins?

The contributing guide contains a useful section with a few questions which can help us track down the bug and speed up the process of finding a fix for it.  The creation of an isolated test case would also be useful.

Just loaded rc 4.0.1 and this issue has disappeared.  Not sure exactly why, but it no longer happens.

Just loaded rc 4.0.1 and this issue has disappeared.

Interesting, we had a few focus issues that were fixed with 4.0.1-rc.1, so that may be related.
If this comes up again, we can reopen this ticket.

Sounds good... I was able to reproduce this consistently, but since loading the rc it has not happened once.  Nothing has changed other than the s2 files so whatever was causing it must have been related somehow.


Allow Globalnet metrics port while preparing cloud

Submariner Globalnet pod runs with HostNetworking enabled and the
metrics are exported on TCP/8081 port. Currently, this port is
not configured while preparing the cloud infrastructure, because
of this Globalnet metrics are not seen in OCP dashboard. This PR
fixes the issue.
Fixes: https://github.com/stolostron/submariner-addon/issues/309
Signed-off-by: Sridhar Gaddam<EMAIL_ADDRESS>

CC @skitt @aswinsuryan @vthapar @nyechiel
In this PR I'm opening the Globalnet Metrics port unconditionally. Ideally we should open it only when Globalnet is enabled.
However, in order to do that it requires many changes because

The cloud preparation for clouds like AWS is done on Hub whereas its done on Spoke for GCP/RHOS.
The cloud preparation APIs in addon currently have an hard-coded list of internal ports. In order to support GlobalnetMetricsPort we will have to modify the APIs.
Currently the Spoke cluster has access to SubmarinerConfig on the Hub, but Globalnet is a ClusterSet wide configuration and users are not really expected to supply GlobalCIDR (unless explicitly overriding) in the submarinerConfig. Submariner-addon code will look at broker configuration in the managedClusterSetBrokre Namespace and will allocate a unique GlobalCIDR for each cluster which is not stored in the submarinerConfig. If Spoke has to read the broker config or local submariner config, it requires many changes.

Since we are very close to a release, IMHO its not advisable to make major changes. Also, the metrics port is an internal port which will only be allowed within the local cluster and NOT to outside of the cluster.
In the next release, IMO we should improve the cloud-prepare stuff to either Hub/Spoke and once its done, we can revisit this use-case to enable the Globalnet Metrics port accordingly.

I agree, let’s keep this simple. Since it’s temporary, I won’t ask for a metricsPorts slice instead of the two explicit fields in gcpProvider ;-).
/approve
(Leaving lgtm to a second reviewer.)

/lgtm

/cherry-pick release-2.5


Calling UseResourceSetupOnStartup recreates tables/clears wolverine_* tables

I'm running Wolverine as a demo. Messages are persisted to postgress with the EF core integration.
After running the application I can see messages in the postgress db and (as a test) end up in the dead letter queue as expected.
When I again start the application, I end up with empty wolverine_* tables.
I was expecting messaging in the dead letter queue or other messages to remain in the database after a restart.
I found out the call UseResourceSetupOnStartup trigger behaviour that either completely recreates the tables or only clears their content. Is this by design?

Nevermind, it'll be fixed in Wolverine 0.9.14 shortly. Thanks for reporting that!

Thank you for fixing and complements on Wolverine.


Blunderbuss should pick owners for top-level directory additions

When directory additions are made to the top-level of the repository, blunderbuss does not make assignments, or find owners.
Example: no assignees for #1343, #1189, #892, #841

So add an OWNERS at the top level...

(just don't put me in the list  :))

@eparis We do have a top-level OWNERS file.

son of a...   ok, i'll debug this.

please review #1493 to fix this.


artwork_type applies to individual works of art and not to a shop

Combining shop=art with artwork_type seems to give nonsensical values as it is not clear that it applies to the goods sold and not to the shop, see discussion https://forum.openstreetmap.org/viewtopic.php?id=59504 and http://wiki.openstreetmap.org/wiki/Tag:shop%3Dart
Don't have a strong opinion on this myself, but for example a mural is going to be a rather difficult good to have on premises :-).

This seems fine, thanks @simonpoole... If people want to tag what the shop sells, there are probably more suitable tags for that.


thoughts on strict .object check

Right now, .object() only checks typeof (...) === 'object'.  While this makes sense, it allows for a lot of things to pass that check that, while are objects, we might not consider to be objects as such.
For example:
assert.object(new Date());
assert.object(/regex/);
assert.object(null);
assert.object([]);
assert.object(new Error());

All pass the test.
null and [] are the most egregious, though everything listed above are technically javascript objects.  Would a modification to .object to be stricter make sense? or maybe the addition of a .strictObject?
ex:
function isObject(o) {
  return o !== null && typeof (o) === 'object' && o.constructor && o.constructor === Object;
}

isObject(new Date());
// => false
isObject(/regex/);
// => false
isObject(null);
// => false
isObject([]);
// => false
isObject(new Error());
// => false

isObject({});
// => true
isObject(new Object());
// => true

This implementation has been deemed too strict... based on a convo with me + @pfmooney

arrays are valid objects

@pfmooney
3:02 > Array.prototype.specialFunc = function () { console.log('omg'); };
[Function]
> bar = new Array()
[]
> bar.specialFunc();
omg
undefined

@pfmooney
2:57 I think o.constructor == Object might be dangerous
2:58 we can't be that strict
2:59 > function Foo() { }
undefined
> var bar = new Foo();
undefined
> bar
{}
> bar.constructor
[Function: Foo]
2:59 assert.object(bar) should absolutely succeed

The solution right now is to just bail if o === null

Fixed in v0.2.0


Uploading beta managed package via Selenium Fails Due to Timeout

It appears that the upload beta is failing because Selenium is having to wait more than 90 seconds to see the VersionInfoSectionItem:VersionText show up in the DOM.
Traceback (most recent call last):
File "../CumulusCI/ci/package_upload.py", line 249, in <module>
package_upload()
File "../CumulusCI/ci/package_upload.py", line 233, in package_upload
uploader.build_package(build_name)
File "../CumulusCI/ci/package_upload.py", line 146, in build_package
name_input = driver.find_element_by_id('ExportPackagePage:UploadPackageForm:PackageDetailsPageBlock:PackageDetailsBlockSection:VersionInfoSectionItem:VersionText')
File "/home/rof/.virtualenv/local/lib/python2.7/site-packages/selenium/webdriver/remote/webdriver.py", line 206, in find_element_by_id
return self.find_element(by=By.ID, value=id_)
File "/home/rof/.virtualenv/local/lib/python2.7/site-packages/selenium/webdriver/remote/webdriver.py", line 662, in find_element
{'using': by, 'value': value})['value']
File "/home/rof/.virtualenv/local/lib/python2.7/site-packages/selenium/webdriver/remote/webdriver.py", line 173, in execute
self.error_handler.check_response(response)
File "/home/rof/.virtualenv/local/lib/python2.7/site-packages/selenium/webdriver/remote/errorhandler.py", line 166, in check_response
raise exception_class(message, screen, stacktrace)
NoSuchElementException: Message: Unable to locate element: {"method":"id","selector":"ExportPackagePage:UploadPackageForm:PackageDetailsPageBlock:PackageDetailsBlockSection:VersionInfoSectionItem:VersionText"}
Stacktrace:
at FirefoxDriver.prototype.findElementInternal_ (file:///tmp/tmpGKjSbl/extensions/fxdriver@googlecode.com/components/driver-component.js:9641:7)
at fxdriver.Timer.prototype.setTimeout/<.notify (file:///tmp/tmpGKjSbl/extensions/fxdriver@googlecode.com/components/driver-component.js:548:5)

Closing out an old issue to make way for CumulusCI 2.
For future reference, CumulusCI 2 no longer supports the Selenium package upload process.  Instead, you can use cci task run upload_beta to upload a beta release using PackageUploadRequest (pilot) via the Tooling API.


Add PBC and improve AL extra time setting (#73)

Add PBC option for MLP-MD propagation of solvated systems
Change definition in extra_time in training to avoid the formation of distorted structures

Codecov Report
Attention: Patch coverage is 7.14286% with 13 lines in your changes missing coverage. Please review.

Project coverage is 57.12%. Comparing base (4bd5c1f) to head (e23f8ef).

Files with missing lines
Patch %
Lines

mlptrain/training/active.py
7.14%
13 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #112      +/-   ##
==========================================
- Coverage   61.28%   57.12%   -4.17%
==========================================
  Files          37       37
  Lines        4213     4226      +13
==========================================
- Hits         2582     2414     -168
- Misses       1631     1812     +181

Flag
Coverage Δ

python-3.9
57.12% <7.14%> (-0.16%)
:arrow_down:

python-3.9-ace
?

python-3.9-mace
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests


PLICS Constraints Pages

Details taken from #320 as this is a separate issue.
The All Items Index in V3+ for the PLICS Constraints pages looks odd:

They also look odd on the Supporting Information menu:

7/2/22 - Discussion with James. Moved to To Do.

15/2/22 - James still needs to do this and we will then need to be check it via the published output.

Fixed in the March 2022 release.

@PaulChapmanPM - T shirt label removed as now fixed.

T-Shirt label re-added


Director VM cannot connect to the internet

Hello, I'm a univ student from south korea.
I've been struggling to solve a problem about networking but I still don't know what's wrong, so I need you experts' help.. T.T..
I tried to deploy Cloud Foundry through BOSH-Lite Director(I finished installing BOSH CLI and BOSH-Lite Director), but when I tried to upload stemcell on the director(vbox), it failed to upload it.
So I looked into the task log with bosh -e vbox task 1 --debug, and i found this line.
Downloading remote release from https://bosh.io/d/github.com/cloudfoundry/cf-networking-release?v=2.17.0 failed: #<SocketError: Failed to open TCP connection to bosh.io:443 (getaddrinfo: Temporary failure in name resolution)>
So I thought that this is all about networking, so I've tried to solve it
I've tried many things on Google, but they haven't work at all. I have tried

reinstalling
installing virtualbox-5.2 and virtualbox-ext-pack
checking routing table of host vm
checking routing table of director vm
etc ...

and i try to connect to the internet in the director vm, it has failed. (I mean there's no reponse like HOST UNREACHABLE).
my assumption is that virtualbox networking is not working properly or I put some wrong options when I create the director or the routing tables are wrong.
What should I do to solve the problem?

I think it was about stemcell version or virtualbox version.
today I tried to re-install and i succeeded it.
the stemcell was ubuntu-xenial 170.5 for BOSH-Lite, and virtualbox was 5.2
So I close this issue.


[Roadmap] Add Updated OpenAI APIs (Files, Assistants)

[x] Update openAI SDK to v1.2 [Overview]

Necessary to use assistant API

[ ] Integrate [OpenAI File API]

Upload file

List files

Delete file

Retrieve file

Retrieve file content

[ ] Integrate [OpenAI Assistant API]

Create assistant

Retrieve assistant

Modify assistant

Delete assistant

List assistant

[ ] Integrate [OpenAI Assistant File API]

Create assistant file

Retrieve assistant file

Delete assistant file

List assistant file

Files, Assistants, and Assistant file APIs integrated under branch 'features/create_assistants_api'
Finishing up test cases and could use some examples before PR
Holding off on this project for now to implement an API for creating camel-internal assistants(agents) via FastAPI
The ultimate goal will be to create a shared abstraction layer between creating assistants, whether it's via Camel or OpenAI


Work on UEI Demo script

Description
Rewrite UEI demo script with changes suggested by Ravi

The first version of the modified demo script is here
https://docs.google.com/document/d/1koT4CNS7oTG4DqAaKBRTxKL1PK-X0IyrpIG0Ik55v1k/edit#heading=h.jzsrg2i9ny7y
20th Sept 19:23 in Version history

The second version of the modified demo script with a prosumer flow and converting the consumer flow to daily is here
https://docs.google.com/document/d/1koT4CNS7oTG4DqAaKBRTxKL1PK-X0IyrpIG0Ik55v1k/edit#heading=h.jzsrg2i9ny7y
23 Sept 22:09

The final version I modified based on feedback from Sujit, Ravi and Anirban, is at 25 Sept 13:53.


unable to download

PS D:\Anime\Pokemon> kissanime-dl https://kissanime.ru/Anime/Pokemon-Dub/
D:/Anime/Pokemon
Platform: Windows
Python Version: 3
Program Version: 1.9.8
Warning: Version 1.9.6 changed the host of kisscartoon.me to kisscartoon.se.
Checking for updates
Uh oh, an error occurred.
Go to https://github.com/wileyyugioh/kissanime_dl to report bugs.
Caught Error: AttributeError("module 'pip' has no attribute 'main'",)
thats the error its showing, any fixes?
EDIT: I tried reinstalling but didnt work.

As said in the readme "Due to all the new hurdles, development is over. Thanks for all the support!"
You could try using https://github.com/vn-ki/anime-downloader


respect git username and password

First of all, I would like to thank you for this great plugin for neovim, which is making my life easier a lot.
Recently, I have noticed that neogit asks for username and password for pushing the code but it's not respecting
the global config of git in which I have stored my username and password and it asks for the same thing again and again.
I really want that I don't have to type my username and password again and again every time I commit and push.
Is this feature already there or not in neogit? If yes, then how I can enable it otherwise what is the roadmap for this?

#172 will fix this.


Feature: enabled handling VPs (request, creation, verification) with different VCs

Enabled handing presentation requests with indy and dif

Enabled handling presentation requests with requests for claims from different JSON-LD VCs (verifier has to create separate submission requirement groups for each claim from different VC) In case, multiple claims should come from the same VC, the descriptors can be included in the same group

Updated demo/agent_controller to correctly construct presentations.

Signed-off-by: Anastasiia Sivirina<EMAIL_ADDRESS>

@swcurran Could we take this PR in the agenda of the upcoming Aca-Pug Call? Thanks and best

Yes -- super interested.  @teanas are you working with @hkny ?  Definitely would like to get a more detailed background about what is in here.  From reading the description -- does this mean Indy proofs via a DIF Presentation Exchange?
We can have this on the Agenda for the first Tuesday in October -- the next ACA-Pug meeting.
Thanks!!!!

It would be great to get the branch updated and the SonarCloud issues looked at, please.

@swcurran this is correct. It's all @teanas' work but yes, we are working together :) The goal was to combine AnonCreds with W3C VCs in Presentation Proofs. Some combinations were not possible and those should be fixed without creating breaking changes to the protocol .

Codecov Report

Merging #1956 (f3801eb) into main (98f5537) will increase coverage by 0.01%.
The diff coverage is 98.55%.

@@            Coverage Diff             @@
##             main    #1956      +/-   ##
==========================================
+ Coverage   93.59%   93.60%   +0.01%
==========================================
  Files         539      539
  Lines       34279    34308      +29
==========================================
+ Hits        32084    32115      +31
+ Misses       2195     2193       -2

@swcurran for some reason SonarQube did not start a new analysis after my latest commit. Can I somehow manually trigger the analysis?

I had to manually trigger the other tests, but I'm still not seeing the SonarQube analysis -- not sure why.  Any idea @WadeBarnes ?

Looks like there is some code formatting to clean up, which will result in another commit, so you can try again.

The 1 security hotspot refers to the usage of a path for a mock object, which has been previously used in other test cases as well. Is this hotspot safe if there are old tests containing the same structure? E. g., test_create_presentation.

@swcurran Are there any checks missing?

Sorry @teanas that the checks aren't running automagically due to a first commit -- I'll make sure I monitor them and run them with each of your commits.

The failing scenario in acapy-integration-tests is about issuing a credential and I haven't added any changes to the issuance process (failed scenario: features/0453-issue-credential.feature:57). The exception is ledger related and appears during create_schema_and_cred_def/create_and_send_credential_definition neither of which I altered. @swcurran do you have an idea what might be the problem?
7hAcme.agent | 2022-10-10 19:25:10,919 aries_cloudagent.ledger.base WARNING Credential definition KSKnzboJ3zTeZVHobSkYQh:3:CL:339254:Acme.agent.Schema_DriversLicense already exists on ledger default
7hAcme.agent | 2022-10-10 19:25:10,921 aries_cloudagent.admin.server ERROR Handler error with exception: Credential definition KSKnzboJ3zTeZVHobSkYQh:3:CL:339254:Acme.agent.Schema_DriversLicense is on ledger default but not in wallet acme.agent716296
7hAcme.agent | Traceback (most recent call last):
7hAcme.agent |   File "/home/indy/aries_cloudagent/messaging/credential_definitions/routes.py", line 262, in credential_definitions_send_credential_definition
7hAcme.agent |     endorser_did=endorser_did,
7hAcme.agent |   File "/home/indy/.pyenv/versions/3.6.13/lib/python3.6/asyncio/futures.py", line 327, in iter
7hAcme.agent |     yield self  # This tells Task to wait for completion.
7hAcme.agent |   File "/home/indy/.pyenv/versions/3.6.13/lib/python3.6/asyncio/tasks.py", line 250, in _wakeup
7hAcme.agent |     future.result()
7hAcme.agent |   File "/home/indy/.pyenv/versions/3.6.13/lib/python3.6/asyncio/futures.py", line 243, in result
7hAcme.agent |     raise self._exception
7hAcme.agent |   File "/home/indy/.pyenv/versions/3.6.13/lib/python3.6/asyncio/tasks.py", line 180, in _step
7hAcme.agent |     result = coro.send(None)
7hAcme.agent |   File "/home/indy/aries_cloudagent/ledger/base.py", line 462, in create_and_send_credential_definition
7hAcme.agent |     f"Credential definition {credential_definition_id} is on "
7hAcme.agent | aries_cloudagent.ledger.error.LedgerError: Credential definition KSKnzboJ3zTeZVHobSkYQh:3:CL:339254:Acme.agent.Schema_DriversLicense is on ledger default but not in wallet acme.agent716296
7hAcme.agent |
Assertion Failed: FAILED SUB-STEP: Given "Acme" is ready to issue a credential for driverslicense
Substep info: Traceback (most recent call last):
File "/home/indy/demo/runners/support/agent.py", line 850, in admin_request
resp.raise_for_status()
File "/home/indy/.pyenv/versions/3.6.13/lib/python3.6/site-packages/aiohttp/client_reqrep.py", line 1010, in raise_for_status
headers=self.headers,
aiohttp.client_exceptions.ClientResponseError: 400, message='Credential definition KSKnzboJ3zTeZVHobSkYQh:3:CL:339254:Acme.agent.Schema_DriversLicense is on ledger default but not in wallet acme.agent716296', url=URL('http://<IP_ADDRESS>:8021/credential-definitions')
  The above exception was the direct cause of the following exception:

  Traceback (most recent call last):
    File "/home/indy/.pyenv/versions/3.6.13/lib/python3.6/site-packages/behave/model.py", line 1329, in run
      match.run(runner.context)
    File "/home/indy/.pyenv/versions/3.6.13/lib/python3.6/site-packages/behave/matchers.py", line 98, in run
      self.func(context, *args, **kwargs)
    File "features/steps/0453-issue-credential.py", line 42, in step_impl
      version=schema_info["schema"]["schema_version"],
    File "/home/indy/demo/bdd_support/agent_backchannel_client.py", line 102, in aries_container_create_schema_cred_def
      version=version,
    File "/home/indy/demo/bdd_support/agent_backchannel_client.py", line 19, in run_coroutine
      return loop.run_until_complete(coroutine(*args, **kwargs))
    File "/home/indy/.pyenv/versions/3.6.13/lib/python3.6/asyncio/base_events.py", line 488, in run_until_complete
      return future.result()
    File "/home/indy/demo/runners/agent_container.py", line 826, in create_schema_and_cred_def
      schema_name, schema_attrs, self.revocation, version=version
    File "/home/indy/demo/runners/agent_container.py", line 629, in create_schema_and_cred_def
      revocation_registry_size=TAILS_FILE_COUNT if revocation else None,
    File "/home/indy/demo/runners/support/agent.py", line 292, in register_schema_and_creddef
      "/credential-definitions", credential_definition_body
    File "/home/indy/demo/runners/support/agent.py", line 951, in admin_POST
      "POST", path, data, text, params, headers=headers
    File "/home/indy/demo/runners/support/agent.py", line 853, in admin_request
      raise Exception(f"Error: {resp_text}") from e
  Exception: Error: 400: Credential definition KSKnzboJ3zTeZVHobSkYQh:3:CL:339254:Acme.agent.Schema_DriversLicense is on ledger default but not in wallet acme.agent716296

  Traceback (of failed substep):
    File "/home/indy/.pyenv/versions/3.6.13/lib/python3.6/site-packages/behave/model.py", line 1329, in run
      match.run(runner.context)
    File "/home/indy/.pyenv/versions/3.6.13/lib/python3.6/site-packages/behave/matchers.py", line 98, in run
      self.func(context, *args, **kwargs)
    File "features/steps/0453-issue-credential.py", line 42, in step_impl
      version=schema_info["schema"]["schema_version"],
    File "/home/indy/demo/bdd_support/agent_backchannel_client.py", line 102, in aries_container_create_schema_cred_def
      version=version,
    File "/home/indy/demo/bdd_support/agent_backchannel_client.py", line 19, in run_coroutine
      return loop.run_until_complete(coroutine(*args, **kwargs))
    File "/home/indy/.pyenv/versions/3.6.13/lib/python3.6/asyncio/base_events.py", line 488, in run_until_complete
      return future.result()
    File "/home/indy/demo/runners/agent_container.py", line 826, in create_schema_and_cred_def
      schema_name, schema_attrs, self.revocation, version=version
    File "/home/indy/demo/runners/agent_container.py", line 629, in create_schema_and_cred_def
      revocation_registry_size=TAILS_FILE_COUNT if revocation else None,
    File "/home/indy/demo/runners/support/agent.py", line 292, in register_schema_and_creddef
      "/credential-definitions", credential_definition_body
    File "/home/indy/demo/runners/support/agent.py", line 951, in admin_POST
      "POST", path, data, text, params, headers=headers
    File "/home/indy/demo/runners/support/agent.py", line 853, in admin_request
      raise Exception(f"Error: {resp_text}") from e

@ianco -- can you please take a look at this test?  Thanks!

@ianco -- can you please take a look at this test? Thanks!

It runs fine on my local, sometimes tests fail randomly :-(

@ianco @swcurran Is there anything else that needs to be done before the merge? :)

Hi @teanas,
please add the multicredential.md in the root folder of the project and add the following description (copy/paste)
Multi-Credentials
It is a known fact that multiple AnonCreds can be combined to present a presentation proof with an "and" logical operator: For instance, a verifier can ask for the "name" claim from an eID and the "address" claim from a bank statement to have a single proof that is either valid or invalid. With the Present Proof Protocol v2, it is possible to have "and" and "or" logical operators for AnonCreds and/or W3C Verifiable Credentials.
With the Present Proof Protocol v2, verifiers can ask for a combination of credentials as proof. For instance, a Verifier can ask a claim from an AnonCreds and a verifiable presentation from a W3C Verifiable Credential, which would open the possibilities of Aries Cloud Agent Python being used for rather complex presentation proof requests that wouldn't be possible without the support of AnonCreds or W3C Verifiable Credentials.
Moreover, it is possible to make similar presentation proof requests using the or logical operator. For instance, a verifier can ask for either an eID in AnonCreds format or an eID in W3C Verifiable Credential format. This has the potential to solve the interoperability problem of different credential formats and ecosystems from a user point of view by shifting the requirement of holding/accepting different credential formats from identity holders to verifiers. Here again, using Aries Cloud Agent Python as the underlying verifier agent can tackle  such complex presentation proof requests since the agent is capable of verifying both type of credential formats and proof types.
In the future, it would be even possible to put mDoc as an attachment with an and or or logical operation, along with AnonCreds and/or W3C Verifiable Credentials. For this to happen, Aca-Py either needs the capabilities to validate mDocs internally or to connect third-party endpoints to validate and get a response.

After that I think this is ready to merge. Thanks again.

Hello,
can a mainatiner approve the workflows and review the PR? Thanks

Sorry for the delay -- this is on @andrewwhitehead 's list for review.  We'd like to get it completed.


Small service refactoring

Small refactoring around service.go 🐭.

This moves AuthLookup in config package as other *Lookup and thus moves the field to project.Context
eachContainer now takes a list of containers and a new methods appears that does what eachContainer was doing (collectContainersAndDo). This way, we reduce some API calls for some cases (where to collectContainers were done in a row).

/cc @joshwget
🐸

I'm not sure I agree with moving AuthLookup to config. The other lookups are used in the config process, whereas AuthLookup isn't. Seems like it's more relevant to the docker package.
Is the only motivation for this to combine the two contexts? I think there's a pretty good case for keeping two. There's likely always going to be meta information that pertains only to the docker package. Moving those fields to project or config doesn't make sense for someone who wants to use libcompose but not the docker package.

@joshwget hum, I moved it for another refactoring and it made sense to me to move it to the project Context. On that, I think I see what you mean but using libcompose without the docker project is gonna be harder and harder with support of networks and volumes (although it might be possible to abstract a lot) — networks are initialize at the project level (I'm creating a docker/network package that project package imports).
What would be the use case of using libcompose without the docker package ? I guess using the compose files and project methods but on another backend like kubernetes right ? (what you are doing with rancher ?).

I think we should abstract networks and volumes in the same way as we do services. We can have an interface for them in project, and then an implementation in the docker package. This should allow the project package to not depend on docker or any of its subprojects.
Communicating with a different backend is definitely the use case I had in mind, but there are probably some others as well. Since that backend can be pretty much anything, project shouldn't have any logic specific to interacting with a Docker daemon (plenty of gray areas here, of course).

@joshwget ok sounds good to me, I'll orient some of my refactoring with that in mind then :angel:

@joshwget Removed the AuthLookup move :wink:

LGTM


Go:Implement GetEx command

Implementing the GETEX command with and without options in GO client.

Do we want to wait with this PR until this one #2310 is merged?

@eifrah-aws I am just waiting for an approving review in order to merge this PR. We don't need to block existing PRs on #2310 but while creating any further PRs we should consider the changes in #2310.


Upgrade pg_embedding to 0.3.2

Problem
Summary of changes
Checklist before requesting a review

[ ] I have performed a self-review of my code.
[ ] If it is a core feature, I have added thorough tests.
[ ] Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
[ ] If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

[ ] Do not forget to reformat commit message to not include the above checklist

Let's fix tests first https://github.com/neondatabase/pg_embedding/actions/runs/5739378413/job/15554841562


Test for #17

The test fails against<EMAIL_ADDRESS>but works against master built against emscripten 1.39.2.
I used emscripten 1.39.2 from https://github.com/emscripten-core/emsdk, following the instructions [here](https://emscripten.org/docs/getting_started/downloads.html.
I verified that all vscode-textmate tests pass as well.
@NeekSandhu Can you compile and publish an updated version?
(or make me a npm contributor (npm user id: aeschli))

added you as a contributor, please confirm push access.

So the issue gimbals around emscripten version? 1.39.2 works and other doesn't (that was my original theory too)?
can you please summarise your observations, like the all/any emscripten versions that you tried and their respective behaviors, because if the build setup is so sensitive, we might consider clamping the emscripten version somehow, so anyone cloning the repo should not have any struggles trying to get it all work.
thanks.

It seems I can't prove the hypothesis that the problem is caused by the emscripten version.
I now tried 1.38.10, 1.38.20, 1.38.30 and 1.38.40 and they all pass the test.
But +1 on having a fixed version of emscripten. To do that and to simplify setting up emsdk, I added the following new scripts:

npm run setup-emsdk that installs and activates a specific version of smsdk (currently 1.39.1)
npm run clean to clean out all binaries
npm run prepublish now runs setup-emsdk, clean, build and test to ensure a cleanly built wasm.

@NeekSandhu I published a version 2.2.3 with the recompiled wasm


ROX-21575: Add query locks part 2

Description
There are postgres errors such as the following resulting from pruning
2024-01-05 00:23:39.366 UTC [7678] DETAIL:  Process 7678 waits for ShareLock on transaction 1718495; blocked by process 6750.
	Process 6750 waits for ShareLock on transaction 1718264; blocked by process 7678.
	Process 7678: DELETE FROM listening_endpoints WHERE poduid IS NOT NULL AND NOT EXISTS
			(SELECT 1 FROM pods WHERE listening_endpoints.poduid = pods.Id)
	Process 6750: delete from listening_endpoints where listening_endpoints.PodUid = $1
2024-01-05 00:23:39.366 UTC [7678] HINT:  See server log for query details.
2024-01-05 00:23:39.366 UTC [7678] CONTEXT:  while deleting tuple (93996,16) in relation "listening_endpoints"
2024-01-05 00:23:39.366 UTC [7678] STATEMENT:  DELETE FROM listening_endpoints WHERE poduid IS NOT NULL AND NOT EXISTS
			(SELECT 1 FROM pods WHERE listening_endpoints.poduid = pods.Id)

This PR fixes those error by adding locks. This PR is built on top of https://github.com/stackrox/stackrox/pull/9222
Checklist

[ ] Investigated and inspected CI test results
[ ] Unit test and regression tests added
[x] Ran scale tests and did not observe the errors
[x] Ran scale tests on another branch and saw the errors
- [ ] Evaluated and added CHANGELOG entry if required
- [ ] Determined and documented upgrade steps
- [ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.
The change doesn't merit user facing documentation and there is no change to the upgrade process.
Testing Performed
Ran scale tests. Observed no errors in central-db after over two hours.
Reminder for reviewers
In addition to reviewing code here, reviewers must also review testing and request further testing in case the
performed one does not seem sufficient. As a reviewer, you must not approve the change until you understand the
performed testing and you are satisfied with it.

/retest

I'm not sure I like exposing the lock outside of the datastore. I think it would make more sense to push the execution of the query to the datastore so the lock can remain contained there. What do you think?

Either way is fine with me. Can you elaborate what you think are the benefits and drawbacks of both approaches.

I'm not sure I like exposing the lock outside of the datastore. I think it would make more sense to push the execution of the query to the datastore so the lock can remain contained there. What do you think?

I made the change here https://github.com/stackrox/stackrox/pull/9222


Reorganize integration tests based on Rust best practices.

Following the recommendations from the rust book:
https://doc.rust-lang.org/book/ch11-03-test-organization.html
This is in order to make integration tests simpler.
We can potentially make the things we share more strict, but it doesn't
really matter as this shouldn't be used as a lib.

@svix-daniel, I think that since it's now actual separate tests, we can remove the feature and instead just tell people to run cargo test --lib to only test the unit tests, otherwise they can just run the full suite with cargo test.
What do you think?


Remove ? if the removed tag is the only parameter

Unfortunately the latest update did not resolve this issue.

Works fine, thank you for your very fast reaction ;)

fixed on 1.2.1


Make repository a template

Please consider making this repository a template, which is a way to discriminate two use cases:

changing the template itself (forking)
using the template to create a project (create a new repository from template Github option)

Details:
https://docs.github.com/en/repositories/creating-and-managing-repositories/creating-a-repository-from-a-template#creating-a-repository-from-a-template

Thank you for a tip.
Done!


FocusBehaviour changing focus_next raises ReferenceError when previous value points to a collected object

Versions

Python: 3.7.3
OS: OS X 10.14.6
Kivy: 1.11.1
Kivy installation method: pip

Description
FocusBehaviour changing focus_next raises ReferenceError when previous value points to a collected object.
I have a list of items to edit and whenever an item is selected, I generate a new form. I also update the item list's focus_next to point to the first input field in the new form. Now, when a different item is selected from the list, the previous form is destroyed so focus_next points to non-existent object. Sometimes (in one widget) it's not an issue (I imagine when the object is still not collected), sometimes (in another widget) it blows up with a ReferenceError.
Code and Logs

def select_item(self, item):

    # form created on previous selection
    # gets destroyed here
    self.ids.container.clear_widgets()

    form = EditForm()
    self.ids.container.add_widget(form)

    ...

    # This raises ReferenceError in one widget, does
    # not in another
    self.item_selector.focus_next = form.ids.name_input

Exception:
   File "/Users/REDACTED/editor.py", line 69, in launch_edit_form
     self.item_selector.focus_next = form.ids.name_input
   File "kivy/properties.pyx", line 497, in kivy.properties.Property.__set__
   File "kivy/properties.pyx", line 544, in kivy.properties.Property.set
   File "kivy/properties.pyx", line 599, in kivy.properties.Property.dispatch
   File "kivy/_event.pyx", line 1214, in kivy._event.EventObservers.dispatch
   File "kivy/_event.pyx", line 1120, in kivy._event.EventObservers._dispatch
   File "/Users/REDACTED/.pyenv/versions/sk/lib/python3.7/site-packages/kivy/uix/behaviors/focus.py", line 250, in _set_on_focus_next
     if isinstance(next, FocusBehavior):
   File "kivy/weakproxy.pyx", line 42, in kivy.weakproxy.WeakProxy.__class__.__get__
   File "kivy/weakproxy.pyx", line 28, in kivy.weakproxy.WeakProxy.__ref__
 ReferenceError: weakly-referenced object no longer exists

Since the exception occurs in listeners, I can actually catch ReferenceError, throw it away, and it works, it's just ugly and who knows if I'm ignoring more serious issues later.
try:
    self.item_selector.focus_next = form.ids.name_input
except ReferenceError:
    pass

Here's a minimal example, but the problem is no mater how many times I click the button the issue doesn't happen on this one. I don't know how kivy works outside of what I see in Python code, and in Python code I don't see any dealing with weakref issues in _set_on_focus_next.
from kivy.base import runTouchApp
from kivy.lang import Builder
from kivy.uix.boxlayout import BoxLayout

Builder.load_string("""\
<Form>:
    TextInput:
        id: name_input
        multiline: False
        write_tab: False

<Editor>:
    TextInput:
        id: item_selector
        multiline: False
        write_tab: False
        on_text_validate: root.select_item()
    Button:
        text: "select"
        on_release: root.select_item()
    BoxLayout:
        id: container
""")

class Form(BoxLayout):
    pass

class Editor(BoxLayout):
    def select_item(self, *args):
        self.ids.container.clear_widgets()

        form = Form()
        self.ids.container.add_widget(form)

        self.ids.item_selector.focus_next = form.ids.name_input
        form.ids.name_input.focus_previous = self.ids.item_selector
        form.ids.name_input.focus = True

runTouchApp(Editor())


Add option to enable lifecycle hooks creation

PR o'clock
Description
Related to https://github.com/terraform-aws-modules/terraform-aws-eks/issues/527
Checklist

[x] terraform fmt and terraform validate both work from the root and examples/* directories
[x] CI tests are passing
[x] I've added my change to CHANGELOG.md and highlighted any breaking changes
[x] README.md has been updated after any changes to variables and outputs. See https://github.com/terraform-aws-modules/terraform-aws-eks/#doc-generation

Estou tendo o mesmo problema
2020/10/16 11:52:44 [WARN] Provider "registry.terraform.io/hashicorp/aws" produced an unexpected new value for module.eks.aws_autoscaling_group.workers_launch_template[0], but we are tolerating it because it is using the legacy plugin SDK.
The following problems may be the cause of any confusing errors from downstream operations:
- .launch_configuration: was null, but now cty.StringVal("")
- .placement_group: was null, but now cty.StringVal("")


Added some core simulator commands

Also includes a couple important bugfixes I found while implementing these commands (hence the core tag).

What's the current status of this PR?

Is it cool if I close this PR? It's been stale for awhile and lots of things have changed since the last commit here


External Function required in CodeUnit 231

Hi,
We need to have external function (or maybe event) for setting preview mode. This will be useful when you can call your own report by using posting preview.
Or for using this functionality you need to copy this code unit for simple Boolean variable.
Regards
Amol

In an upcoming fix pack, we will be exposing the Preview function in that codeunit. Does that suffice, or do you need to set the preview functionality in the codeunit?

I think one external function  will suffice the requirement

Great! Then we're on it :-) It will take a couple of weeks though, as the big fix pack takes some time to turn around. But we're aiming to have it in for the december update!

Thank you...


Failing to display

Hi sir,
Why is this picture open is blank?

Anyone can tell me how to solve it.
Thank you very much!
<IP_ADDRESS>.1<IP_ADDRESS>.54308.zip

I can't seem to get a DICOM file out of your ZIP. I just get something with '.cpgz'.
I would guess that it has something to do with the Min / Max Stored Pixel Values both marked as 0.


refactor: add some helpers for spread exprs

#84  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @malezjaa and the rest of your teammates on  Graphite


update Go header

A couple things of note:
The GRPC library doesn't expose a version yet, so that's not available
right now
The version string is in YYYYMMDD format. Rationale:
The semver spec states that "Once a versioned package has been released,
the contents of that version MUST NOT be modified". Since "go get" just
downloads the master branch, we are technically modifying the version
every time we submit code. If our users use the version package for
their own telemetry, they might be unpleasantly surprised.

Codecov Report

Merging #998 into master will not impact coverage.

@@            Coverage Diff            @@
##             master     #998   +/-   ##
=========================================
  Coverage     85.24%   85.24%
  Complexity     3367     3367
=========================================
  Files           341      341
  Lines         13415    13415
  Branches       1532     1532
=========================================
  Hits          11435    11435
  Misses         1545     1545
  Partials        435      435

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41e7cc2...5c398cb. Read the comment docs.

@pongad The Java implementation has a test case (and I requested one more). Is this easy to do for Go?

@bjwatson The handwritten libraries do call NewClient(); they immediately follow with SetGoogleClientInfo(...). The new insertXGoog method guarantees we only have one.

@jba Can you take a look at the latest revisions? I'm not familiar with the Go aspects of the changes. I'll review the header-related stuff tomorrow.

@bjwatson LGTM.

@bjwatson PTAL


Is there an example for adding multiple exclusions?

the following tries did not filter like i expected
loggerConfiguration.Filter.ByExcluding("RequestPath like '/health%' and SourceContext = 'Microsoft.AspNetCore.Routing.EndpointMiddleware'");

or
loggerConfiguration.Filter.ByExcluding("RequestPath like '/health%' and SourceContext = 'Microsoft.AspNetCore.Routing.EndpointMiddleware'");
loggerConfiguration.Filter.ByExcluding("RequestPath like '/health%' and StatusCode = 200");

in either case nothing was excluded from logging
still logs
{"@t":"2021-05-25T18:49:50.6790837Z","@m":"Executing endpoint '\"Health checks\"'","@i":"500cc934","EndpointName":"Health checks","EventId":{"Name":"ExecutingEndpoint"},"SourceContext":"Microsoft.AspNetCore.Routing.EndpointMiddleware","RequestId":"0HM8VLNG82QOS:00000002","RequestPath":"/healthz","ConnectionId":"0HM8VLNG82QOS"}

{"@t":"2021-05-25T18:49:50.6817044Z","@m":"Running health checks","@i":"6843e9ee","@l":"Debug","EventId":{"Id":100,"Name":"HealthCheckProcessingBegin"},"SourceContext":"Microsoft.Extensions.Diagnostics.HealthChecks.DefaultHealthCheckService","RequestId":"0HM8VLNG82QOS:00000002","RequestPath":"/healthz","ConnectionId":"0HM8VLNG82QOS"}

{"@t":"2021-05-25T18:49:50.6978398Z","@m":"Request finished HTTP/1.1 GET http://localhost:5051/healthz - - - 200 - text/plain 56.1577ms","@i":"791a596a","ElapsedMilliseconds":56.1577,"StatusCode":200,"ContentType":"text/plain","ContentLength":null,"Protocol":"HTTP/1.1","Method":"GET","Scheme":"http","Host":"localhost:5051","PathBase":"","Path":"/healthz","QueryString":"","HostingRequestFinishedLog":"Request finished HTTP/1.1 GET http://localhost:5051/healthz - - - 200 - text/plain 56.1577ms","EventId":{"Id":2,"Name":"RequestFinished"},"SourceContext":"Microsoft.AspNetCore.Hosting.Diagnostics","RequestId":"0HM8VLNG82QOS:00000002","RequestPath":"/healthz","ConnectionId":"0HM8VLNG82QOS"}

Any insight would be great

Thanks for getting in touch. Your filters look okay to me -- would it be possible to send:

Which version of the package you're using,
The full LoggerConfiguration setup, and
How you're integrating it into ASP.NET Core (UseSerilog(), AddSerilog(), etc.)

Version
dotnet add package Serilog.Expressions --version 2.0.0

integration
logging.AddSerilog(Log.Logger, dispose: true);

Registering
internal static void AddLoggingConsole(this ILoggingBuilder logging, IConfiguration config, LoggerOptions options, LogLevel logLevel)
        {
            if (options.UseSerilogTracing)
            {
                var loggerConfiguration = new LoggerConfiguration().Enrich.FromLogContext();
                var opts = options?.SerilogOptions ?? new SerilogOptions();
                loggerConfiguration.WriteTo.Console(new RenderedCompactJsonFormatter(), restrictedToMinimumLevel: ConvertToSerilogLevel(logLevel));

                if (options.SerilogOptions.ExclusionFilters?.Any() == true)
                {
                    foreach (var filter in options.SerilogOptions.ExclusionFilters)
                    {
                        // this is string expression as stated above, it looks like this is not additive so last one sent in would be the registered expression
                        loggerConfiguration.Filter.ByExcluding(filter);
                    }
                }

                if (options.SerilogOptions.InclusionFilters?.Any() == true)
                {
                    foreach (var filter in options.SerilogOptions.InclusionFilters)
                    {
                        loggerConfiguration.Filter.ByIncludingOnly(filter);
                    }
                }

                switch (logLevel)
                {
                    case LogLevel.Trace:
                        loggerConfiguration.MinimumLevel.Verbose();
                        break;
                    case LogLevel.Debug:
                        loggerConfiguration.MinimumLevel.Debug();
                        break;
                    case LogLevel.Information:
                        loggerConfiguration.MinimumLevel.Information();
                        break;
                    case LogLevel.Warning:
                        loggerConfiguration.MinimumLevel.Warning();
                        break;
                    case LogLevel.Error:
                        loggerConfiguration.MinimumLevel.Error();
                        break;
                    case LogLevel.None:
                    case LogLevel.Critical:
                        loggerConfiguration.MinimumLevel.Fatal();
                        break;
                }

                if (opts.ReadSettingsFromConfig)
                {
                    loggerConfiguration.ReadFrom.Configuration(config);
                }

                Log.Logger = loggerConfiguration.CreateLogger();
                logging.AddSerilog(Log.Logger, dispose: true);
                return;
            }

            if (options.IncludeDiagnosticLogging)
            {
                logging.AddDebug();
            }
        }

Thanks for the follow-up. Also looks okay!
The filters should be additive - does the filter work as you expect when it's the only one you apply?
If so, do the filters work if you set them manually in code, without reading them from configuration?

I only ever set them up from code, and tried only the example from the MD file for filtering /health. It did not work either. I then just rolled my own filter expression using the baked in ByExcluding and parsed the parameters and values and that worked correctly.
Nugets
<PackageReference Include="Datadog.Trace" Version="1.26.3" />
    <PackageReference Include="Microsoft.AspNetCore.Hosting" Version="2.2.7" />
    <PackageReference Include="Microsoft.Extensions.Hosting" Version="5.0.0" />
    <PackageReference Include="Microsoft.Extensions.Logging" Version="5.0.0" />
    <PackageReference Include="Microsoft.Extensions.Logging.Console" Version="5.0.0" />
    <PackageReference Include="Serilog.Extensions.Logging" Version="2.0.2" />
    <PackageReference Include="Serilog.Formatting.Compact" Version="1.1.0" />
    <PackageReference Include="Serilog.Settings.Configuration" Version="3.1.0" />
    <PackageReference Include="Serilog.Sinks.Console" Version="3.1.1" />

Howdy again - sorry not to have more ideas on this!
I've tried reproducing the problem locally, but no luck so far - the exclusions seem to work fine :thinking:
Unfortunately, the only way to get to the bottom of it might be for you to zip up a project with a minimal repro. No worries if you have moved on and don't have the time - but otherwise, please feel free to upload/link it here, or mail to (my GitHub username)@(my GitHub username).com :-)
Cheers!

I dont have  a repo I can send due to the layering of Nuget dependencies and private code.  But i think i have narrowed down the cause.  Seems like if I use simple filtering 1 statement to the console. Messages get filtered correctly
[13:42:29 INF] Request starting HTTP/1.1 GET http://localhost:5051/healthz - -
[13:42:29 DBG] Wildcard detected, all requests with hosts will be allowed.
[13:42:29 DBG] 1 candidate(s) found for the request path '/healthz'
[13:42:29 DBG] Request matched endpoint 'Health checks'
[13:42:29 DBG] Running health checks
[13:42:29 DBG] Health check processing completed after 3.2128ms with combined status Healthy
[13:42:29 DBG] Connection id "0HM950CCN3S5H" completed keep alive response.
[13:42:29 INF] Request finished HTTP/1.1 GET http://localhost:5051/healthz - - - 200 - text/plain 84.6962ms
[13:54:53 DBG] Connection id "0HM950JAFAHK2" accepted.
[13:54:53 DBG] Connection id "0HM950JAFAHK2" started.
[13:54:53 DBG] Connection id "0HM950JAFAHK3" accepted.
[13:54:53 DBG] Connection id "0HM950JAFAHK3" started.

Filter: "RequestPath like '/health%'"
[13:54:53 DBG] Connection id "0HM950JAFAHK2" accepted.
[13:54:53 DBG] Connection id "0HM950JAFAHK2" started.
[13:54:53 DBG] Connection id "0HM950JAFAHK3" accepted.
[13:54:53 DBG] Connection id "0HM950JAFAHK3" started.

When i create a multi-part statement it does not work
Filter "RequestPath like '/health%' and SourceContext = 'Microsoft.AspNetCore.Routing.EndpointMiddleware'"
[14:02:37 DBG] Connection id "0HM950NKV5DF2" accepted.
[14:02:37 DBG] Connection id "0HM950NKV5DF2" started.
[14:02:37 DBG] Connection id "0HM950NKV5DF3" accepted.
[14:02:37 DBG] Connection id "0HM950NKV5DF3" started.
[14:02:38 INF] Request starting HTTP/1.1 GET http://localhost:5051/healthz - -
[14:02:38 DBG] Wildcard detected, all requests with hosts will be allowed.
[14:02:38 DBG] 1 candidate(s) found for the request path '/healthz'
[14:02:38 DBG] Request matched endpoint 'Health checks'
[14:02:38 DBG] Running health checks
[14:02:38 DBG] Health check processing completed after 2.2297ms with combined status Healthy
[14:02:38 DBG] Connection id "0HM950NKV5DF2" completed keep alive response.
[14:02:38 INF] Request finished HTTP/1.1 GET http://localhost:5051/healthz - - - 200 - text/plain 57.4991ms

When i turn on JSON messaging with RenderedCompactJsonFormatter so i can see all the props and values, none of the messages are filtered out when i have multiple clauses either
Filter "RequestPath like '/health%' and SourceContext = 'Microsoft.AspNetCore.Routing.EndpointMiddleware'"
{"@t":"2021-06-01T13:58:33.1530993Z","@m":"Request matched endpoint '\"Health checks\"'","@i":"cbf60c4b","@l":"Debug","EndpointName":"Health checks","EventId":{"Id":1,"Name":"MatchSuccess"},"SourceContext":"Microsoft.AspNetCore.Routing.EndpointRoutingMiddleware","RequestId":"0HM950LBVGOIC:00000002","RequestPath":"/healthz","ConnectionId":"0HM950LBVGOIC"}

Code to add was
loggerConfiguration.Filter.ByExcluding(exp);

Not sure if this helps but seems like an issue with the multi statements

Thanks for the follow-up. Unless it's possible to reproduce in a File > New Project -based example I don't think I can track this down, sorry.

fair enough, I totally understand. Thanks for looking.

You're welcome - thanks. I'll still keep an eye out for clues 👍


Config file path command line argument

Is your feature request related to a problem? Please describe.
We have multiple AWS accounts we interact with and would like to be able to specify a config.properties file through a command line argument.
Describe the solution you'd like
Something like the example below.
java -jar ~/.okta/okta-aws-cli-2.0.0.jar --config=~/aws1-config.properties <command> <args>

Describe alternatives you've considered
We are open to options on how to specify configuration files.

Since the issue raised is basically regarding support of multiple AWS accounts, you may want to discuss it in #304.

Since the issue raised is basically regarding support of multiple AWS accounts, you may want to discuss it in #304.

Looked at it and it is a painful workaround. I strong believe this is a better approach. It would allow users to select different OKTA accounts and configurations without modifying their file repeatedly. It is also something that should be simple to achieve.

With https://github.com/oktadeveloper/okta-aws-cli-assume-role/pull/331 which was just released in v2.0.4 it will now load ~/.okta/config.properties then ~/.okta/config.{OKTA_PROFILE}.properties.
So for example. Say you had a "stage" environment you wanted to load. You would put your common properties in ~/.okta/config.properties, then make a file with properties specific to your stage account in ~/.okta/config.stage.properties and run:
 okta-aws stage s3 ls
this is equivalent to also running
OKTA_PROFILE=stage java -Djava.util.logging.config.file=~/.okta/logging.properties -classpath ~/.okta/okta-aws-cli.jar com.okta.tools.WithOkta aws --profile stage s3 ls
Can you give this a shot in latest release and let us know if it works for you?


Send email when BQ early rollout workflow fails

This should be actioned on immediately, so we'll send an email to do so.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

R: @liferoad @ahmedabu98


Entity is already registered

Hi guys,
I'm having a real headache here. I'm using the PooledEngine and I create and dispose all of my entities through my Engine instance as instructed, however It seems if I remove a load of entities in an update cycle, then after the engine update has completed I create and add new entities, it sporadically throws this exception.
java.lang.IllegalArgumentException: Entity is already registered com.badlogic.ashley.core.PooledEngine$PooledEntity@2d59b291
at com.badlogic.ashley.core.EntityManager.addEntityInternal(EntityManager.java:115)
at com.badlogic.ashley.core.EntityManager.addEntity(EntityManager.java:33)
at com.badlogic.ashley.core.Engine.addEntity(Engine.java:61)
My issue is, the code that's throwing that exception is the following:
Entity bloodEntity = createEntity();
bloodEntity.add(renderPositionComponent);
bloodEntity.add(spriteComponent);
bloodEntity.add(expiringComp);
addEntity(bloodEntity);
It's the final line that does it. My createEntity call there is directly to the engine, and this code is executing after a call to engine.update - I've spent two days trying to get to the bottom of this and I really can't, it only ever happens when stuff has been removed in the prior engine update call. The pooled engine has just passed me an entity via create, why is it immediately exploding and telling me it's already added?
In addition, sporadically it appears as though the engine is sometimes removing the wrong entities, I feel like this could somehow be related? Is it possible entities are being mistaken for each other? Could be a red herring.
Unfortunately my project is huge and fairly complex at this point so I can't exactly just throw a nice repro up, I was hoping you guys might have some ideas given this information that I could investigate further? Any clue why this would be happening?

It sounds like the PooledEntity objects are not being properly disposed when being returned to the pool. This is going to be very complicated to replicate. Could you please try to come up with a unit test that fails, exposing this issue?
I will give it a shot this weekend too.

I have to sheepishly admit I haven't written LibGDX unit tests before, I've been needing to get around to doing it for my own project anyway so I guess now's the time to figure that out :P
Through some further testing I can confirm this only occurs with the PooledEngine, I have reverted back to Engine and created my own 'create' methods as such (so as not to break the rest of my code in the mean while) that just return new instances...
         /**
	 * Temporary due to Ashley bug with {@link PooledEngine}
	 */
	public Entity createEntity () {
		return new Entity();
	}

	/**
	 * Temporary due to Ashley bug with {@link PooledEngine}
	 */
	public <T extends Component> T createComponent (Class<T> componentType) {
		try {
			return componentType.newInstance();
		} catch (InstantiationException e) {
			e.printStackTrace();
		} catch (IllegalAccessException e) {
			e.printStackTrace();
		}

		return null;
	}

...and everything is happy. This at least narrows it down specifically to the reuse of entities in the PooledEngine.

I have to sheepishly admit I haven't written LibGDX unit tests before, I've been needing to get around to doing it for my own project anyway so I guess now's the time to figure that out :P.

This is not Libgdx specific, we use the pretty standard JUnit testing framework. All of our unit tests are written using JUnit.

In my case it happens when accidentally I remove object two times (there is no check if object is already removed when putting it in free objects pool) so when you pick up objects from pool you will get same instance multiple times and when adding it to engine it will throw exception.
In my case it often happens when I remove objects at the end of tween (Animations, Particles etc.) but for some reason object is removed earlier. I have object hierarchy in which when parent is removed also children are removed. So for example I'm adding to weapon as child some animation and before it gets to the end weapon is removed with animation but TweenEngine continues and removes it again at the end.
@saltares shouldn't we check if entity is already removed before removing it again to prevent similar situations?

@lukz your issue could potentially be the same as @carlislefox's. Arguably this is a bug in your code although it is true that the symptoms appear quite far away from the root cause, which is bad.
Will look into throwing an exception if the entity didn't belong to an engine, should be pretty easy I believe.

I believe this is only a problem with PooledEngine, so we'll throw the exception when trying to remove an entity that is not in the engine to the PooledEngine class. Otherwise, we may break existing code.

@saltares yeah, throwing an exception when removing already removed entity only in PooledEngine would simplify tracking those bugs.
It will make little harder to migrate from Engine to PooledEngine (tracking existing entity removal bugs if Engine is not throwing an exception) but we should be fine with that.

Is an exception necessary?
Say in the same logic loop a system decides it's time for two entities to die, but one entity just so happens to be linked to that other entity and also decides to 'clean it up' as part of it's own destruction, you would have two removal calls within one update cycle. I don't see this case actually being an error in execution, more unfortunate timing.
Are we considering this to be worthy of throwing an exception or is it something we should design for and perhaps throw some warning level logging in? Two removal calls to the same entity is fine when not pooling, should it not be the same with?

@carlislefox shouldn't that be handled by some system that will prepare unique list of entities to remove if you are implementing such hierarchy? This is how I'm doing that.

Could be. Still not sure enforcing one remove request per update cycle is really necessary though, feels like an artificial limitation. What do you think Saltares?

So I've been thinking about this.
@lukz is right, game code should make correct use of the engine, adding an entity twice is an invalid oper

I fixed it by making the second removal operation from actually doing anything.

Thanks a lot @Salteres, and nice work figuring out the cause @lukz ! I'll test this out asap

Question - is it possible there is a similar bug when pushing component removal requests to entities i,e, entity.remove(MyComponent.class) ? I am still seeing a bit of weirdness very sporadically despite running with the latest snapshot (verified your fix is in it) and using a system to remove all flagged entities. I am no longer getting exceptions, but I'm convinced I've seen the wrong entity vanish, could this be a similar issue to as above but perhaps it's my sprite component that is having issues now rather than the entity itself?

We have checks in Entity and PooledEntity to only return components to the pool if we actually removed a component.
We can rewrite entity.remove() so that it's more explicit, but I think the code is correct.
Do you have a failing unit test with the issue? Maybe later this evening I can try write one.

Arr, I think I've got to the bottom of my issue - I've been really dumb.
I have two threads, one for the networking code, one is the LibGDX thread, I am creating entities via PooledEngine.createEntity() on the networking thread as I pass my dataInputStream directly to my components (which are also created in the networking thread) so they can read themselves - this obviously is screwing things up as it exists outside of the render() loop and must be short circuiting the PooledEngine's entity / component management.
Until I have rewritten everything so this is no longer the case, I would close this ticket as I cannot guarantee there is actually an issue here and entity creation / removal being thread safe isn't a reasonable request given most of libgdx is not thread safe.
If I find it still to be an issue after I have sorted this tangle out, I will get a working test case before commenting again on the ticket :)
Liam

Cool, multithreading would explain this as none of Ashley is threadsafe, same with Libgdx itself.

Well, I've gotten everything into the update cycle now and I still have this issue, though it seems the symptoms are slightly different, it seems if I add an entity around the same time as I remove one, sometimes it seems to 'steal' the components from the last entity I added. It's like because I removed an entity with the same components it thinks that the last one with those components I added is free?
Either that, or it gives me the same entity twice - but I'd expect my subsequent add to throw an exception so it must be the components that are getting mixed up? This is really, really strange.
Could the removal of an entity somehow incorrectly shift an index or something somewhere leading to the same component being freed twice?


How can I retrieve the cookies added post splinter driver instantiation

I see that all the cookies available in the browser are collected at the instant of instantiating splinter browser object but say in case some of the cookies gets added while am using the driver is there any way to retrieve them? Does CookieManager perform any kind of refresh to retrieve the newly added ones?
Reference: https://github.com/cobrateam/splinter/blob/0aae2027b02635526e45e021d4a5f51a7f53613e/splinter/driver/webdriver/cookie_manager.py#L16
UseCase:
In case am using splinter for testing an application configured with any SAML provider like OKTA, the steps I need to follow are:

Instantiate splinter browser
Perform a visit and wait for the redirection to happen on SAML page
Key-In the right credentials on SAML login page
Successful Login

I observe that the cookies created post step 3 are available in browser but not retrieved via splinter cookies.all() call.
Can some one please help?

This sounds like a selenium and/or SAML and/or browser issue. I can't reproduce it using a trivial example.


Todd Hendricks Sprint 2

Sprint Challenge Code Review
Unit 1 - Sprint 2: Data Wrangling and Storytelling
Great job getting everything done. Try to incorporate more comments throughout your code, but I know this one was a time crunch.
Your recreation of the graphic is really spot on!


Allow range and until vars to propagate into widget on single widget

@juliusv

:+1:
I'm a bit wary of the general architecture of how the shared graph behavior reaches "into" the widgets and does stuff to them conditionally depending on their type, instead of the widgets receiving some signal (broadcast?) and doing the right thing themselves. Missing encapsulation of implementation details, that is. That's a bit of a meta-topic though, so :+1: for this.


simplify calculate_soil_carbon_updates() function

Is your feature request related to a problem? Please describe.
The function to calculate the updates for the soil carbon pool (calculate_soil_carbon_updates) is much too complex, it's 150 lines long and has 17 arguments.
Describe the solution you'd like
I should remember to simplify the function. There should hopefully be an obvious moment to do this at some point when I'm adding more stuff to the soil model.
@alexdewar also suggested the following as good generic approaches to this sort of problem:

If lots of the arguments to this function are just being passed through to one or two other functions, you could just pass in the results of these functions instead and have the caller calculate them
If some of the arguments would naturally group together, consider bundling them together in a class/dataclass (provided that this function won't be the only user of it)

@davidorme had some a helpful suggestions here, which I should bear in mind for the next time I need to simplify this function