Component shift is off

Here is the output from the logger showing that one component is shifted by a very large amount:
DEBUG:scarlet.blend:shifting component (0, 0) by (-0.048/0.218) to (32.887/32.236) in it 190
DEBUG:scarlet.blend:shifting component (1, 0) by (-89806566564.740/-75030309405.693) to (-89806566533.021/-75030309379.929) in it 190
DEBUG:scarlet.blend:no flux in component (1, 0), skipping recentering in it 200
DEBUG:scarlet.blend:shifting component (0, 0) by (-0.024/0.018) to (32.863/32.255) in it 200```

just for reference, this is an example file with a 3-band image that show the failure after ~130 iteration in my tests
multi_band_im.fits.gz

Here's what happens: when we use acceleration for the bpgm method, there's an oscillation of the colors and associated morphologies that doesn't decay. Even worse, it builds up until the solutions jump off the rails:

The problem does not arise within 600 iterations if the acceleration is switched off.
The non-convergence here is a puzzle since there are convergence proofs that should apply here.

Looks like one of those animations of a binary neutron star merger :)

Let's call Nature ...

Keeping this productive: There are two tasks here:

prevent a source from moving off the frame
finding out why this optimization blows up

For the first one, we have to be somewhat careful because we need to allow a source center to be outside of the observed frame as long as it has flux that is on the inside.

For the second point I think we should look into the algorithm in Bubeck 2015 for accelerated geometric descent (see a brief summary in this blog post). It's similar to Nesterov acceleration except that it appears to be more stable and intuitive to understand why it works, and thus when it breaks down. They claim that it also has a performance increase, although I haven't verified this.

This problem will not arise anymore since as of v0.5 we don't optimize for a source center. The source is modeled over the entire image, instead of in the center of its own box. Some proximal updates may require to know a center but only in model space as opposed to image space where noise and blending can lead to instabilities.


[BUG] Keyboard can't push input above its height

Testing on android for now;
Kindly check the video; input hides behind keyboard, can't see it
Video > https://streamable.com/yx5jgx

@blahblehblah Thank you, i got it. This is browser or cordova webview ?

Tested it on device and simulator, cordova.

@blahblehblah please check latest push from master branch and give me your feedback
"cupertino-pane": "git+https://github.com/roman-rr/cupertino-pane.git"

Awesome work, does the job, thank you


notion-client 2.2.1

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

@conda-forge/notion-client this is ready for review


~20 character password length limit?

It appears that xfreerdp 1.0.2 on RHEL 7 has a password limit that is some number of characters higher than 19 but lower than 24.  A user reported to me that his 24 character password wasn't working from Vinagre or from xfreerdp on the command line.  We found the same type of bug reported for Vinagre here:  https://bugzilla.redhat.com/show_bug.cgi?id=1569552
I was not able to determine the exact length due to not being able to easily set up a lab environment to do further testing with a password of each character length between known good (18char) and known-bad (24char).
The remote systems tested were Windows 10 and Windows Server 2008.  Based on our observations we suspect it's overwhelmingly likely to be a freeRDP issue.
To reproduce, assuming you have a lab environment where you can change passwords repeatedly, try creating an AD account that uses a 24 character password.  You should see this message when the xfreerdp command dies:
connected to ts.college.edu:3389 Password: SSL_read: Failure in SSL library (protocol error?) $
Here is a sanitized version of the command line used and which works when the password length is 18 or less characters:
$ xfreerdp -d COLLEGENET -g 1680x1020 -u jimbob --plugin cliprdr --plugin rdpsnd --plugin drdynvc --data tsmf:audio:pulse – ts.college.edu
I ran a few open/closed issues searches on here and came up empty - apologies in advance if this is a known limitation with the client code that is already being worked on.

@kfiresmith Are you sure it is not a simple timeout of the ssl socket waiting for completiong (it should be something about ~20 seconds if I remember correctly

Hello @akallabeth  - that message seems to be something of an unintentional catch-all message that appears when nearly anything goes sideways.  The exact same environment & command with a 18char password works.  The fact that this is the last message that a user sees for many different unrelated problems points to the need for better error catching and messaging in the xfreerdp client in general, but that's a problem for a different bugreport :)
There is a password length gremlin in xfreerdp that we appear to be able to tickle with a 24 character password, and that's what this bugreport is for.
Thanks!

@kfiresmith Agree with the error handling, but that is (mostly) a protocol issue...
(the error status is not very detailed, specially with invalid user and passwords - but that is a security feature, ssh is similar in that regard)

Is this bug 1.0.2 only or does it also affect 2.0 release candidates?
Are you sure this is not triggered by a timeout?
Which authentication scheme are you using server side? ntlm, tls, nla, ...?

Hi @akallabeth  - thanks for the reply!

I'll have to see if I can find a pre-build of the 2x branch for RHEL 7
Everything is the same except for the actual password length so I'm going to assert no for now
NLA against WS2008, W10 Desktop

Thanks!

AFAICT there are no builds for xfreerdp 2x branch for RHEL 7, and I actually don't have an easy way to test anyhow since I can't get an arbitrary AD account in my operating environment to set a 20+ char password.

@kfiresmith There is a spec file in the repo in packaging/rpm we use for our nightly builds. Don't know if that will work with RHEL 7, but the main dependencies should be compatible enough.

@akallabeth  - unfortunately I won't be able to do further testing on this issue (I can't create the environment needed to test), I mostly wanted to raise the issue should others discover they cannot connect for the same reason.  We've already worked around the issue for the affected user.
Thanks again!

By the way, there is an unofficial copr repository with freerdp 2 packages for RHEL which might be useful for testing:
https://copr.fedorainfracloud.org/coprs/mikedep333/freerdp-backport/


fix: auto fix linter Warnings by npm-groovy-lint

Step one to fix lint Warnings , mostly for indentation.
Ref https://github.com/adoptium/ci-jenkins-pipelines/issues/428

@zdtsw Needs a rebase sorry

@zdtsw Linter still seemed to have some significant errors (unused private methods etc)

Yes. these wont be fixed by the "auto fix" ,  we need to do it one by one, listed in https://github.com/adoptium/ci-jenkins-pipelines/issues/428#issuecomment-1268019252


BUG: Valid Twilio messages incorrectly marked as unauthenticated

The vetext forwarder is failing some messages with the message - Returning 403 on unauthenticated Twilio request. This datadog log query shows the offending log messages.

Description

[ ] Ticket is understood, and QA has been contacted (if the ticket has a QA label).

Steps to Reproduce

Unknown, investigate incoming messages that have failed to ascertain the cause.

No workaround known.
Impact/Urgency

Currently some veterans replies via Twilio are not being forwarded to VEText.
Expected Behavior

[ ] Valid messages are not returned as 403 unauthenticated.

Additional Info & Resources

Just noting this started on April 22, affects messages To/From a specific country, whose config is in a different Twilio account.

Blocked externally as we await a new token and the full account sid to be able to validate properly. Kyle is also confirming with them if the fallback URL was effective in this case.

Root cause is likely this ticket where validation was introduced: https://github.com/department-of-veterans-affairs/vanotify-team/issues/1189#issuecomment-1860710883

After talking to Kyle we agreed it was ok to log the message body as long as it was encrypted, so that even if someone managed to access logs, they couldn't decrypted the info without more tools/secrets from our account.

Received the new credentials. Added log encryption. Tested locally, good. Deployed to Dev and it's good. Tested in staging, good. Need access to the PH Twilio account so I can validate text to the PH number is not rejected.


how to make it only a 3x3x3 instead of it trying to vein mine all dirt loaded

pls help

This is not a feature


Large blocks of text do not get indexed properly

When indexing large blocks of text (e.g. a movie script) not all phrases get indexed properly. It seems like randomly some phrases/words get indexed while others do not.

Do you have a link to a text I can replicate the issue with?

I was able to reproduce this with the lyrics from a song (after modifying READ_MAX in server.c so that it'd fit in one command)
INDEX fitter_happier fitter, happier more productive comfortable not drinking too much regular exercise at the gym, three days a week getting on better with your associate employee contemporaries at ease eating well, no more microwave dinners and saturated fats a patient, better driver a safer car, baby smiling in back seat sleeping well, no bad dreams no paranoia careful to all animals, never washing spiders down the plughole keep in contact with old friends, enjoy a drink now and then will frequently check credit at moral bank, hole in wall favours for favours, fond but not in love charity standing orders on sundays, ring-road supermarket no killing moths or putting boiling water on the ants car wash, also on sundays no longer afraid of the dark or midday shadows, nothing so ridiculously teenage and desperate nothing so childish at a better pace, slower and more calculated no chance of escape now self-employed concerned, but powerless an empowered and informed member of societ, pragmatism not idealism will not cry in public less chance of illness tires that grip in the wet, shot of baby strapped in backseat a good memory still cries at a good film still kisses with saliva no longer empty and frantic like a cat tied to a stick that's driven into frozen winter shit, the ability to laugh at weakness calm, fitter, healthier and more productive a pig in a cage on antibiotics
Text has been indexed
SEARCH a pig
["a"]
SEARCH a pig in a cage
[]

This problem has to do with the algorithm used in indexer.c (https://github.com/f-prime/fist/blob/master/fist/indexer.c). I haven't had a chance to look deeply yet, but I think there might be  a problem with the look ahead logic.
If you notice, the phrase missing is at the end of the text. This leads me to believe there is something wrong with line 20 (https://github.com/f-prime/fist/blob/master/fist/indexer.c#L20).
If someone is currently investigating the problem that is where I suggest to look.

Also notice that in the example fitter_happier is entered as the doc name, but ["a"] is returned in SEARCH

@StefanSlehta sorry, that part was just a bad copy and paste.

Do you think it is worth adding a longer string to the test cases?

Might be worth adding a case that wasn't caught by the original test


Animiru as a media player

Describe your suggested feature
How about Being able to open external media with animiru's player.
From an external file manager.
It would also be nice to be able to show a media notification in that case
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] If this is an issue with an extension, I should be opening an issue in the extensions repository.
[X] I have updated the app to version <IP_ADDRESS>.
[X] I will fill out all of the requested information in this form.

https://github.com/abdallahmehiz/mpvKt
The media player based on the current player, but much better.
It is what the updated internal player will be based on moving forward.

https://github.com/abdallahmehiz/mpvKt
The media player based on the current player, but much better. It is what the updated internal player will be based on moving forward.

yeah. also the official mpv android is being ported to material 3 by me

eyyy, Noice!


Consider a simpler way to get the results of a query for BigQuery

This can potentially be after GA, but we should consider the pattern now.
There are two ways of creating a query job (ExecuteQuery and CreateQueryJob), but in both cases you then need to wait for the job to complete before you can get results.
A few options:

Add methods which accept a PollSettings as well, and don't finish until the query job has actually completed
Add an extension method on Task<BigqueryJob> to transform it into a Task<BigqueryQueryJob>, when the job has been created and completed
Add a GetAwaiter method on BigqueryQueryJob so you can await it directly (and get what? unclear)
Add methods to BigqueryQueryJob such as PollRepeatedAndGetRows which basically concatenates the operations

None of these appeal much at the moment...
// cc @roji

Another option suggested:

Change GetRows and GetResultSet to accept a PollSettings and poll automatically, rather than throwing if incomplete.


Toolbar

Codecov Report

Merging #336 into next will decrease coverage by 3.42%.
The diff coverage is 8.74%.

@@            Coverage Diff            @@
##             next    #336      +/-   ##
=========================================
- Coverage   23.83%   20.4%   -3.43%
=========================================
  Files          47      56       +9
  Lines         684     882     +198
  Branches      178     231      +53
=========================================
+ Hits          163     180      +17
- Misses        518     697     +179
- Partials        3       5       +2

Impacted Files
Coverage Δ

packages/reakit/src/Popover/PopoverState.ts
4.87% <0%> (ø)
:arrow_up:

packages/reakit/src/Tab/utils.ts
0% <0%> (ø)
:arrow_up:

packages/reakit/src/__utils/hasAttribute.ts
0% <0%> (ø)

packages/reakit/src/Dialog/DialogState.ts
40% <0%> (ø)
:arrow_up:

packages/reakit/src/Tooltip/TooltipState.ts
33.33% <0%> (ø)
:arrow_up:

packages/reakit/src/Hidden/HiddenState.ts
15.38% <0%> (ø)
:arrow_up:

packages/reakit/src/Tab/TabState.ts
25% <0%> (ø)
:arrow_up:

packages/reakit/src/Step/StepState.ts
2.56% <0%> (ø)
:arrow_up:

packages/reakit/src/Dialog/Dialog.tsx
2.15% <0%> (-1.82%)
:arrow_down:

packages/reakit/src/__utils/useTabbable.ts
0% <0%> (ø)

... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 638da68...12c31c6. Read the comment docs.


Rebase button

It would be nice if we have a rebase button next to the update base branch (which merges master to this branch). I usually prefer the rebase because it helps to keep the commit history cleaner.

This isn't possible via the API. Even merging only recently became possible: https://developer.github.com/v3/pulls/#update-a-pull-request-branch
I don't think the API offers any such destructive options (rebase rewrites history and thus --force)

For anyone that wants this, there is a GitHub action that does it:
https://github.com/cirrus-actions/rebase

If anyone wants to build an extension for this, it's possible but you'll need a third-party server to clone and force push (which is basically what that action does on GitHub’s own Action servers)


subsample datasets

The viewer save a bit IO by subsampling the dataset.
We need to write equations that generate subsampled grid (correctly) and translate between new and old indices.

This is fixed with PR #12


feat(mixed-operators): add two tests for mixed operators

This PR adds initial support for mixed operators
Description

Cases to be supported (both from and to DSL)
(with no direct assignment):

[ ] define relation: (rel1 and rel2) but not rel3
[ ] define relation: ((rel1 and rel2) but not rel3) # transformation back to DSL will not keep the extraneous surrounding brackets
[ ] define relation: rel1 and (rel2 but not rel3)
[ ] define relation: rel1 and ((rel2 but not rel3) or (rel4 and (rel5 but not rel6 from rel7)))

(with direct assignment, only if there is a single reference to the assignment and only if it is the first entry):

[ ] define relation: [user, user:*, user#follower with condition] or ((rel1 and rel2) but not rel3)
[ ] define relation: ([user] or ((rel1 and rel2)) but not rel3 # Note we can de-prioritize this as pending discussion

Cases NOT planned to supported yet, pending discussion:
Anything involving multiple references to direct assignment, or the presence of direct assignment not as the first entry, or references to self/this:

define relation: [user] as self | rel1 but not self
define relation: [user] as self | this but not rel1
define relation: rel1 but not [user]
define relation: [user] as self | (self or ((rel1 and rel2)) but not rel3
define relation: (rel3 or ((rel1 and rel2)) but not [user]
define relation: (rel3 or (([user] and rel2)) but not self
define relation: ([user] and allowed) or ([user] but not blocked]

References

Closes #16

Review Checklist

[ ] I have clicked on "allow edits by maintainers".
[ ] I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
[ ] The correct base branch is being used, if not main
[ ] I have added tests to validate that the change in functionality is working as expected

Sadly this grammar, while pretty robust doesnt catch define relation: rel1 and ([user] or thing) as expected. Might have to validate it during transformation, unless we can spot a way to catch this with the grammar rules.


sc-5112 switch rVASP db connect to postgres

This makes some configuration changes to support connecting to a postgres database instead of the embedded sqlite one. The go tests still use sqlite but I've verified that I can connect to a postgres db running in a docker container.

Generally I've used database DSNs that look like: "postgres://user:password@localhost:5432/rvasp?sslmode=disable" to unify functionality across databases; I believe that you can pass a DSN like this directly to sql.Open (though not 100% sure about GORM). Is there a reason you're breaking up the database configuration in the environment and the CLI options?

Ahh, I guess I should have tried that but the gorm documentation doesn't make it clear that it accepts DSNs like that. Very happy to change back to a unified configuration string since it makes the code a lot better.


Implement AuditTrail tracking for pregnancy and clinic details

As I understand it, currently it's just tracking changes to Patient objects; we'll want to track it for embedded Pregnancy and Clinic objects as well.

Fixed in #198


feat(perms_test): we do not need to deploy the app for current perms tests

I accidentally removed @sgoings's LGTM1 while I added my LGTM2. Re-added it. Concurrency is hard....


Update release/3.10 from develop

Description
This is mainly to bring the updated build pipeline into release/3.10

Works for me, was this also merged in develop?

@goutnet Yeah, this is just syncing the branches.


Difference in Dataset Format

Thanks for the great work! I find the the format of dataset download from hugging face is different from the format using in the training stage (npy in hugging face and npz in the dataloader). The shape of data in the npy file are  N, N, and (B+1)x512x256x32, which is totally different from the npz format:
input: (B+1)x512x256x32 matrix # B is the number of previous frames, default is 10
label: (B+1)x512x256x32 matrix # B is the number of future frames, default is 10
invalid: (B+1)x512x256x32 matrix # same as label
May you tell me what's the meaning of the data in the npy files and the difference to the npz file? Thanks a lot!

I find that in the code of data preprocessing, only the npy format is stored in the voxel folder. I cannot find any code to generate npz voxel file that is utilized in the following dataloader code:
for i in self.split:
sample_path = glob(os.path.join(self.root_dir, 'voxel', '{:04d}'.format(i), '*.npz'))
self.data_path.extend(sample_path)


Storefront missing guzzlehttp/psr7 dependency and deprecated mimetype_from_filename used

PHP Version
8.1
Shopware Version
<IP_ADDRESS>
Expected behaviour
Storefront requires guzzelhttp/psr7 but does not include it.
furhtermore, the ThemeLifecycleService service uses mimetype_from_filename which has been deprecated sind guzzlehttp/psr7 v1.7.0 and the shopware core requires a guzzle version that uses guzzlehttp/psr7 1.7.0 at least.
Actual behaviour
Fix deprecation and add require
How to reproduce
see description

Created PR: https://github.com/shopware/platform/pull/2225


Web App auto-update via MSIX package doesn't support other AppInstaller options like Showing A User Prompt to Upgrade

Describe the bug
Web App auto-update via MSIX package doesn't seem to work. I publish .msix / .appinstaller to a website and when I start the app it doesn't seem to check/update. I have to manually go to the website to force an update despite the VS UI settings making it appear it should.
This might be a MSIX bug (see details below) or even VS bug since it generates the settings (although not as likely).
Steps to reproduce the bug

Steps to reproduce the behavior:

Create a basic WinAppSDK 0.8 app - https://docs.microsoft.com/en-us/windows/apps/windows-app-sdk/
In latest VS 16.10.3, right click package project - E.g MyApp (Package) and choose Publish -> Create App Packages
Go through the wizard and choose
a. Sideloading - Enable automatic updates
b. Sign package however you need to - e.g with dev cert
c. Configure packages however u want - E.g Version 0.1 (the first version)
d. Update settings - Installer Location (some website). e.g https://myapp.azurewebsites.net/
e. How often should this application check for updates? Choose - "Every time the application runs"
Click create and zip / copy to your website - e.g. https://myapp.azurewebsites.net/
Look in the .wapproj and see the settings - MyApp (Package)\MyAppUI (Package).wapproj
a.     <GenerateAppInstallerFile>True</GenerateAppInstallerFile>
b.     <HoursBetweenUpdateChecks>0</HoursBetweenUpdateChecks>
Verify on MSDN HoursBetweenUpdateChecks behavior that the UI implies https://docs.microsoft.com/en-us/windows/msix/app-installer/update-settings
a. HoursBetweenUpdateChecks: An integer that indicates how often (in how many hours) the system will check for updates to the app. “0” to “255” inclusive. The default value is 24 (if this value is not specified). For example if HoursBetweenUpdateChecks = 3 then when the user launches the app, if the system has not checked for updates within the past 3 hours, it will check for updates now.
b. Reading MSDN it seems ShowPrompt=false but the update should happen in the background before activation
appinstaller file will have content like this
b. 	<UpdateSettings>
<OnLaunch
HoursBetweenUpdateChecks="0" />
</UpdateSettings>
Install 0.1 of app on a box from https://myapp.azurewebsites.net/
Make a cosmetic change to the app  you can visually see. Go through steps 2-5 but rev the version to say 0.2
Zip deploy the app again
Close & Launch the app again but notice it doesn't seem to auto-update to 0.2 or your new UI

Note: MSIX is supposed to have ClickOnce like behavior but ClickOnce always updates properly for this scenario. It seems the default settings and behavior don't for WinAppSDK apps / MSIX despite the VS UI and settings implying that it should
Expected behavior
App auto updates on launch as implied by VS Wizard UI and MSDN docs
Screenshots

Version Info
NuGet package version:
WinAppSDK / ReUnion 0.8.1

Windows 10 version
Saw the problem?

Win11 Insider Build (22142)
Yes

Additional context
Will attempt to play/generate other settings like ShowPrompt=true and AutomaticBackgroundTask=true
https://docs.microsoft.com/en-us/windows/msix/app-installer/update-settings

Interestingly enough here is another page that talks about this - I don't know if it's out of date or not vs the other MSDN page. All this implies (to me) that updates will be done on launch (even if they don't force the user to do so - but I am not sure how that's going to happen without a UI)
https://docs.microsoft.com/en-us/uwp/schemas/appinstallerschema/element-onlaunch
Setting the ShowPrompt="true" attribute currently shows a prompt for UWP applications but not for desktop applications that have been packaged in a Windows app package (that is, desktop applications that use the Desktop Bridge). For desktop applications, this functionality provides a silent update; the same default functionality provided by the OnLaunch element.

Hi ivberg,
For "8. Install 0.1 of app on a box", how are you installing the app? If it's by clicking on the Msix or MsixBundle, then that won't link the app to its auto update settings. Do auto updates work if you perform the initial install through the appinstaller file link? Example: www.contoso.com/sampleapp.appinstaller
You can also try installing through PowerShell with "Add-AppxPackage -AppInstallerFile <your .appinstaller file uri>"
Thanks,
Jonathan

I edited step 9 to be more clear - 9. Install 0.1 of app on a box from https://myapp.azurewebsites.net/

Also, putting this in the MyApp (Package)\MyAppUI (Package).wapproj
<ShowPrompt>True
Does NOT seem to generate the equivalent in .appinstaller file <UpdateSettings node

Also @joshusto please inform what client side MSIX logs you guys recommend to gather to prove or disprove the apparent behavior. I could have been mistaken sometimes if the app silently updated, but the lack of ShowPrompt=True makes this harder to visibly confirm vs say ClickOnce defaults which always show a dialogue upon update available. Per above, what VS .wapproj settings is needed to make ShowPrompt=True generated?

Also @joshusto please inform what client side MSIX logs you guys recommend to gather to prove or disprove the apparent behavior. I could have been mistaken sometimes if the app silently updated, but the lack of ShowPrompt=True makes this harder to visibly confirm vs say ClickOnce defaults which always show a dialogue upon update available. Per above, what VS .wapproj settings is needed to make ShowPrompt=True generated?

I don't believe that the wapproj settings have a mapping for each AppInstaller file setting. To edit these, you'd need to change the generated appinstaller file that gets placed on your https://myapp.azurewebsites.net/ page. For example, you can change  in the generated appinstaller file to the following:
<UpdateSettings>
    <OnLaunch HoursBetweenUpdateChecks="0" ShowPrompt="true" UpdateBlocksActivation="true"/>
</UpdateSettings>

On the impacted build, try running the following in an elevated PowerShell:
1) Get-AppxPackage *<your package name or a substring from the name>*
2) $pm = new-object windows.management.deployment.packagemanager
3) $package = $pm.FindPackage("<PackageFullName from step 1>")
4) $package.GetAppInstallerInfo().Uri

In step 4, does $package.GetAppInstallerInfo().Uri return a non-null value that shows your appinstaller file? If not, then the app didn't link to its auto-update settings when it got installed. If the value was null, go to the AppInstaller file that VS generated then copy the following URI section:
<?xml version="1.0" encoding="utf-8"?>
<AppInstaller
    Uri=**"https://example.contoso.com/SampleApp_x86.appinstaller"**
    Version="<IP_ADDRESS>" xmlns="http://schemas.microsoft.com/appx/appinstaller/2017/2">

With the copied section, try running the below command in PowerShell:
Add-AppxPackage -AppInstallerFile <uri copied from "Uri" value above>

When you repeat the above steps, you should now see a value from $package.GetAppInstallerInfo().Uri and the app should update in the background when you publish a change. Note: It's necessary to update the AppInstaller file's MainPackage/MainBundle element with the new version of the package. For example, if the AppInstaller file previously had
<MainPackage
    Name="69f67761-c87e-4d21-ad49-400f427947ac"
    Version="<IP_ADDRESS>"
    Publisher="CN=joshusto"
    Uri="https://example.contoso.com/SampleAppV1.msix"
    ProcessorArchitecture="x86" />

you'd need to change it to
<MainPackage
    Name="69f67761-c87e-4d21-ad49-400f427947ac"
    Version="<IP_ADDRESS>"
    Publisher="CN=joshusto"
    Uri="https://example.contoso.com/SampleAppV2.msix"
    ProcessorArchitecture="x86" />

before the update can take place. Assuming you're using the default VS settings, the update occurs in the background on launch and it won't be applied until the next time the app opens. You can confirm that the update is getting staged by running the following in an elevated PowerShell:
Get-AppxPackage -AllUsers *<substring with your package name>*

If auto updates are working correctly, you should see v2 of your package with a "Staged" status shortly after launching your application. The update will be applied the next time the application starts.

I am still trying to determine if the auto-updating silent behavior in the background works (at all). I personally haven't seen it work successfully yet.
I did find out where some logs might be - https://docs.microsoft.com/en-us/windows/msix/app-installer/troubleshoot-appinstaller-issues
App Installer event logs
The app deployment infrastructure emits logs that are often useful for debugging installation issues via the Windows Event Viewer: Application and Services Logs -> Microsoft -> Windows -> AppxDeployment-Server

Ok - I did see a silent auto-update appear to work today! Please leave this issue open though so that WinAppSDK / wapproj  and VS support the other appinstaller settings like ShowPrompt. Otherwise, we have to write a workaround to re-write the .appinstaller after build. The event log showing the update in Microsoft-Windows-AppXDeploymentServer/Operational was:
Started deployment UpdateUsingAppInstallerOperation operation on a package with main parameter MyApp_<IP_ADDRESS>_x64__8wekyb3d8bbwe and Options 0 and 0. See http://go.microsoft.com/fwlink/?LinkId=235160 for help diagnosing app deployment issues.

This issue persists. Details ommitted but I can assure you that the endpoints and certificate are correct.
<?xml version="1.0" encoding="utf-8"?>
<AppInstaller
	Uri="http://domain/myapp.appinstaller"
	Version="<IP_ADDRESS>" xmlns="http://schemas.microsoft.com/appx/appinstaller/2017/2">
	<MainPackage
		Name="49d89e30-8b49-4435-844d-14ed2c10de79"
		Version="<IP_ADDRESS>"
		Publisher=""
		Uri="http://domain/apps/app.msix"
		ProcessorArchitecture="x86" />
	<UpdateSettings>
		<OnLaunch
			HoursBetweenUpdateChecks="1" />
	</UpdateSettings>
</AppInstaller>

The following data is logged in the Event Viewer:
Started deployment UpdateUsingAppInstallerOperation operation on a package with main parameter 49d89e30-8b49-4435-844d-14ed2c10de79_<IP_ADDRESS>_x86_stehcx39bde72 and Options 0 and 0. See http://go.microsoft.com/fwlink/?LinkId=235160 for help diagnosing app deployment issues.
The installed package name matches that of the one in the above log entry.
The appinstaller file at the endpoint points to the next update (<IP_ADDRESS>). The automatic update appears to start but the actual update does not happen. I will open a new issue if required.

@conorlawton you will need to change your appinstaller scheme to http://schemas.microsoft.com/appx/appinstaller/2021, which supports new ShowPrompt or UpdateBlocksActivation attribute, then update the OnLaunch section like the following.
<OnLaunch HoursBetweenUpdateChecks="0" ShowPrompt="true" UpdateBlocksActivation="true"/>
See https://learn.microsoft.com/en-us/uwp/schemas/appinstallerschema/schema-root for reference.

Here's the summary of the issue:

Add property <GenerateAppInstallerFile>True</GenerateAppInstallerFile> to the WapProj so that VS can generate the .appInstaller file.
If you want to use the auto-update feature, you will need to change the .appinstaller file manually.
a. change appInstaller scheme to http://schemas.microsoft.com/appx/appinstaller/2021, the default schema http://schemas.microsoft.com/appx/appinstaller/2017/2 generated by visual studio does not support ShowPrompt attribute
b. Set ShowPrompt to true in OnLaunch element, it may look like <OnLaunch HoursBetweenUpdateChecks="0" ShowPrompt="true" UpdateBlocksActivation="true"/>
c. Set UpdateBlocksActivation to true if you want to force user to update the app before use.
Upload the updated appinstaller file and corresponding package to the hosting website.

References: app installer file versioning

This issue is not related to WinAppSDK in particular, and it's related to appInstaller versioning.
Given solution is provided, hence closing the issue.


Fix typo: MessageTost -> MessageToast

I did not test it, but I think it's supposed to say "MessageToast"?

Hi @simonoswald, thanks for your contribution. We appreciate it and will look into this.


Run and Debug sidebar is opened after debugging a test

Testing #21495
Following linked test setup

Open the 'Testing' sidbar and debug a test with a breakpoint
continue when the breakpoint is hit
:bug: sidebar switches to 'run and debug'

This works as intended as we want to show the debug panel after selects to debug a test. Thanks!


share the dataset in BigQuery?

Since you have the dataset loaded - would you share it with other users?
(you only pay for storage, and each user for their queries)
https://twitter.com/felipehoffa/status/761635507080081408

I'd be happy to.  I just added view privileges to 'All Authenticated Users'.
Schema for sequence files is here:
https://bigquery.cloud.google.com/dataset/censusbigquery:acs1115
Schema for table files is here:
https://bigquery.cloud.google.com/dataset/censusbigquery:acs1115tables
I'm not exactly a GCP power user, so if there are additional steps I need to take to make this public, please let me know.  If you think there will be much interest I could add a bit more documentation as well.

Awesome!
The sample query ran for me:
#standardSQL
SELECT NAME, B19013_001
FROM `censusbigquery.acs1115tables.eB19013`
WHERE STATE = '08'
  AND SUMLEVEL = '050'
ORDER BY NAME ASC;

More docs and queries would be great :).
Thanks Roy!


Library "com.linkedin.events" can't be found

This particular library I can't find anywhere. Does anyone has this jar or download link??

Dear issue owner,
Thanks for your interest in WhereHows. We have recently announced DataHub which is the rebranding of WhereHows. LinkedIn improved the architecture of WhereHows and rebranded WhereHows into DataHub and replaced its metadata infrastructure in this direction. DataHub is a more advanced and improved metadata management product compared to WhereHows.
Unfortunately, we have to stop supporting WhereHows to better focus on DataHub and offer more help to DataHub users. Therefore, we will drop all issues related to WhereHows and will not accept any contribution for it. Active development for DataHub has already started on datahub branch and will continue to live in there until it's finally merged to master and project is renamed to DataHub.
Please check the datahub branch to get familar with DataHub.
Best,
DataHub team


Personal account

I created a placeholder for a username and password but had trouble getting started with how to code that.

Forgot to leave the URL: https://github.com/lukeware/happy-pixies/issues/7


'str' object has no attribute 'device' and other issues when using quantized model

System Info
- `Accelerate` version: 0.26.1
- Platform: Linux-6.1.58+-x86_64-with-glibc2.35
- Python version: 3.10.12
- Numpy version: 1.26.3
- PyTorch version (GPU?): 2.1.2+cu121 (True)
- PyTorch XPU available: False
- PyTorch NPU available: False
- System RAM: 83.48 GB
- GPU type: NVIDIA A100-SXM4-40GB
- `Accelerate` default config:
	Not found

Information

[ ] The official example scripts
[X] My own modified scripts

Tasks

[ ] One of the scripts in the examples/ folder of Accelerate or an officially supported no_trainer script in the examples folder of the transformers repo (such as run_no_trainer_glue.py)
[X] My own task or dataset (give details below)

Reproduction
import logging
from pathlib import Path
import psutil
import torch
from accelerate import (
    Accelerator,
    init_empty_weights,
)
from accelerate.utils import BnbQuantizationConfig, load_and_quantize_model
from transformers import (
    AutoModelForCausalLM,
    AutoTokenizer,
    AutoConfig,
    PreTrainedTokenizerBase,
)
from huggingface_hub import snapshot_download
from ts.torch_handler.base_handler import BaseHandler
from ts.utils.util import PredictionException

logger = logging.getLogger(__name__)

FETCH_QUANITZED = (
    False  # Fetch quantized weights from repo instead of quantizing on initialization
)
LOAD_IN_8BIT = True
LOAD_IN_4BIT = False

if LOAD_IN_4BIT and LOAD_IN_8BIT:
    raise Exception("Invalid config")

class MixtralHandler(BaseHandler):
    MODEL_NAME = "cognitivecomputations/dolphin-2.6-mixtral-8x7b"
    QUANTIZED_WEIGHTS_URL = "whistleroosh/dolphin-2.6-mixtral-8x7b-8bit"
    model: torch.nn.Module
    tokenizer: PreTrainedTokenizerBase
    accelerator: Accelerator
    model_dir: Path

    def initialize(self, context):
        properties = context.system_properties
        manifest = context.manifest
        self.model_dir = Path(properties.get("model_dir"))

        logger.info(f"Properties: {properties}")
        logger.info(f"Manifest: {manifest}")

        self.accelerator = Accelerator()

        self.tokenizer = AutoTokenizer.from_pretrained(
            self.MODEL_NAME, trust_remote_code=True, use_fast=False
        )

        config = AutoConfig.from_pretrained(self.MODEL_NAME, trust_remote_code=True)
        with init_empty_weights():
            self.model = AutoModelForCausalLM.from_config(config)

        logger.info("Loading model")
        weights_location, is_quantized = self._download_weights()
        if FETCH_QUANITZED or is_quantized:
            self._load_model(weights_location)
        else:
            self._quantize_and_load_model(weights_location)
        logger.info("Model loading completed")

        logger.info(f"Device map: {self.model.hf_device_map}")
        logger.info(f"Memory footprint: {self.model.get_memory_footprint()}")

        self.model.eval()

    def preprocess(self, data):
        if "input" in data:
            data = data["input"]

        if isinstance(data, list):
            data = data[0]

        if data is None:
            raise PredictionException("Input is None")

        logger.info(f'Received: "{data}". Begin tokenizing')

        message = [{"role": "user", "content": data}]
        tokenized_input = self.tokenizer.apply_chat_template(
            message, add_generation_prompt=True, return_tensors="pt"
        ).to(self.accelerator.device)

        logger.info("Tokenization process completed")

        return tokenized_input

    def inference(self, data, *args, **kwargs):
        logger.info("Begin inference")

        with torch.inference_mode():
            output = self.model.generate(
                data,
                max_new_tokens=2048,
                do_sample=True,
                temperature=0.2,
                repetition_penalty=1.1,
                top_k=50,
                top_p=0.95,
                num_return_sequences=1,
                eos_token_id=32021,
            )

        logger.info("Inference completed")

        return output

    def postprocess(self, data, input_len):
        output = self.tokenizer.decode(data[0][input_len:], skip_special_tokens=True)

        logger.info(f"Postprocessing completed. Output: {output}")

        return output

    def handle(self, data, context):
        input = self.preprocess(data)
        output = self.inference(input)
        output = self.postprocess(output, input.shape[1])

        return output

    def _download_weights(self):
        if not FETCH_QUANITZED and self.quantized_model_weights_dir.exists():
            logger.info("Quantized weights already exist")
            return self.quantized_model_weights_dir, True

        logger.info("Downloading weights")
        weights_location = snapshot_download(
            repo_id=self.QUANTIZED_WEIGHTS_URL if FETCH_QUANITZED else self.MODEL_NAME,
            allow_patterns=["*.json", "*.safetensors"]
            if FETCH_QUANITZED
            else ["*.json", "*.bin"],
            ignore_patterns=["*.bin.index.json"]
            if FETCH_QUANITZED
            else ["*.safetensors.index.json"],
        )
        logger.info(f"Weights location: {weights_location}")

        return weights_location, FETCH_QUANITZED

    def _quantize_and_load_model(self, weights_location):
        logger.info("Weights will be quantized and saved to the model directory")

        self._load_model(weights_location)

        logger.info("Saving quantized weights")
        self.accelerator.save_model(self.model, self.quantized_model_weights_dir, safe_serialization=False, max_shard_size="5GB")

    def _load_model(self, weights_location):
        bnb_quantization_config = BnbQuantizationConfig(
            load_in_8bit=LOAD_IN_8BIT
        )

        VRAM = torch.cuda.get_device_properties(0).total_memory / (1024 ** 3) - 30
        RAM = psutil.virtual_memory().total / (1024 ** 3) - 20

        self.model = load_and_quantize_model(
            self.model,
            weights_location=weights_location,
            device_map="auto",
            bnb_quantization_config=bnb_quantization_config,
            offload_folder=self.model_dir / "offload",
            offload_state_dict=True,
            no_split_module_classes=self.model._no_split_modules,
            max_memory={"cpu": f"{RAM:.2f}GiB", 0: f"{VRAM:.2f}GiB"}
        )

    @property
    def quantized_model_weights_dir(self):
        return self.model_dir / "drive" / "MyDrive" / "quantized_weights"

model = MixtralHandler()
class Context:
  pass

context = Context()
context.system_properties = {"gpu_id": 0, "model_dir": "."}
context.manifest = {}
model.initialize(context)

Expected behavior
I am trying to quantize and save a big model, however, there are a few issues with that. While it does manage to load the model, it fails when trying to save it with the following error:
AttributeError                            Traceback (most recent call last)

[<ipython-input-4-b60b17f2815a>](https://localhost:8080/#) in <cell line: 8>()
      6 context.system_properties = {"gpu_id": 0, "model_dir": "."}
      7 context.manifest = {}
----> 8 model.initialize(context)

3 frames

[/usr/local/lib/python3.10/dist-packages/accelerate/utils/modeling.py](https://localhost:8080/#) in get_state_dict_offloaded_model(model)
   1351         for key in module_state_dict:
   1352             # ignore placeholder parameters that are still on the meta device
-> 1353             if module_state_dict[key].device == torch.device("meta"):
   1354                 placeholders.add(name + f".{key}")
   1355                 continue

AttributeError: 'str' object has no attribute 'device'

I remember having a similar issue before on another model and I think I solved it by chaning device_map from custom dict to "auto". It does not help in this case, though.
When I try to run inference on the model two issues arise. If I don't set max_memory to very low values I will get CUDA: out of memory error. If I heavily limit max_memory I get:
ValueError                                Traceback (most recent call last)

<timed eval> in <module>

[<ipython-input-1-ae9ebbc85d19>](https://localhost:8080/#) in handle(self, data, context)
    119     def handle(self, data, context):
    120         input = self.preprocess(data)
--> 121         output = self.inference(input)
    122         output = self.postprocess(output, input.shape[1])
    123

23 frames

[/usr/local/lib/python3.10/dist-packages/accelerate/utils/modeling.py](https://localhost:8080/#) in set_module_tensor_to_device(module, tensor_name, device, value, dtype, fp16_statistics)
    308     if value is not None:
    309         if old_value.shape != value.shape:
--> 310             raise ValueError(
    311                 f'Trying to set a tensor of shape {value.shape} in "{tensor_name}" (which has shape {old_value.shape}), this look incorrect.'
    312             )

ValueError: Trying to set a tensor of shape torch.Size([8, 4096]) in "weight" (which has shape torch.Size([32, 4096])), this look incorrect.

I have almost identical code that I used to quantize deep seek coder 33b and it worked there. Though when I tried to run the quantized version of deep seek coder 33b on V100 (now I am running on A100) I had problems with CUDA: out of memory. Note that I had no problems with memory when loading unquantized (loaded with load_checkpoint_and_dispatch) version of deep seek coder 33b on V100 and inference worked as well, though it was very slow.
I am not sure if I just don't have enough memory to run this or this is caused by something else.

I'll try to check what is going on. In the meantime, I recommend you to use directly the integration of bitsandbytes in transformers by doing AutoModelForCausalLM.from_pretrained(self.model_name, load_in_8bit=True, device_map="auto")

@SunMarc Just curious fundamentally why is load_and_quantize_model() using more memory than AutoModelForCausalLM.from_pretrained(self.model_name, load_in_8bit=True, device_map="auto") ?
In the following 2 examples, first one succeeds and 2nd one fails with OOM on GPU.
Example 1:
quantization_config = BitsAndBytesConfig(
    load_in_4bit = True,
    bnb_4bit_quant_type="nf4",
    bnb_4bit_compute_dtype=torch.bfloat16,
    bnb_4bit_use_double_quant=True,
)

tokenizer = AutoTokenizer.from_pretrained(MODEL_PATH)

model = AutoModelForCausalLM.from_pretrained(
    MODEL_PATH,
    device_map = "auto",
    trust_remote_code = True,
    quantization_config=quantization_config,
)

Example 2:
checkpoint = MODEL_PATH
config = AutoConfig.from_pretrained(checkpoint)

model = None
with init_empty_weights():
    model = AutoModelForCausalLM.from_config(config)

bnb_quantization_config = BnbQuantizationConfig(
    load_in_4bit=True,
    torch_dtype=torch.bfloat16,
    bnb_4bit_compute_dtype=torch.bfloat16,
    bnb_4bit_use_double_quant=True,
    bnb_4bit_quant_type="nf4",
)

quantized_model = load_and_quantize_model(model,
                                          weights_location=MODEL_PATH,
                                          bnb_quantization_config=bnb_quantization_config,
                                          device_map = 'auto',
                                         )
quantized_model

Any insights is appreciated.

Hi @pinchedsquare, there shouldn't be any big difference. The goal of load_and_quantize_model is to enable any pytorch model to be quantized with bnb, not just models from transformers library. I'll have a look this strange OOM asap.

Will await your response. Thanks.


Quick and dirty fix for config-file-provider changes

... that does not require Jenkins core bump.

Incase it helps, this is the error I see: http://pastebin.com/yGWtLb3u

@olivergondza I need to check closer, but from the first look at it, it kind of feels strange...

Yeah, back to the drawing board ...


Support contract

The  "Developer Support Packages" on https://pqina.nl/filepond/#support is gone. If I want to know that Filepond will be maintained in a couple of years it has to be a commercial part of it. Is the support package temporarily gone or is there an alternative route to commit to the framework?
Regards Tomas

It’s gone because there was literally zero interest in it.
If you want to support the project feel free to sponsor (see link at the top).
Or better yet treat yourself to a Doka Image Editor license. Lots of Doka Image Editor customers use it with FilePond so as long as Doka is financed FilePond will be maintained.

Great, will do the second. Upload is an important part of our page so we need it to be long term :)


No module named 'fire'

(streamdiffusion) D:\Project\StreamDiffusion\StreamDiffusion>python -m streamdiffusion.tools.install-tensorrt
A matching Triton is not available, some optimizations will not be enabled.
Error caught was: No module named 'triton'
Traceback (most recent call last):
  File "D:\Project\Conda\envs\streamdiffusion\lib\runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "D:\Project\Conda\envs\streamdiffusion\lib\runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "D:\Project\Conda\envs\streamdiffusion\lib\site-packages\streamdiffusion\tools\install-tensorrt.py", line 3, in <module>
    import fire
ModuleNotFoundError: No module named 'fire'

(streamdiffusion) D:\Project\StreamDiffusion\StreamDiffusion>pip3 install fire
Requirement already satisfied: fire in d:\project\conda\envs\streamdiffusion\lib\site-packages (0.5.0)
Requirement already satisfied: six in d:\project\conda\envs\streamdiffusion\lib\site-packages (from fire) (1.16.0)
Requirement already satisfied: termcolor in d:\project\conda\envs\streamdiffusion\lib\site-packages (from fire) (2.4.0)
’
(streamdiffusion) D:\Project\StreamDiffusion\StreamDiffusion

Errors that occur after the third step
Cuda version 12.3 installed cuda version 12.1
System environment: Windows 10
Python environment: Conda Python 3.10
Running this line of code, （`Errors that occur after the third step
Cuda version 12.3 installed cuda version 12.1
System environment: Windows 10
Python environment: Conda Python 3.10
Running this line of code, as well as other example codes, all report an error of no model`）as well as other example codes, all report an error of no model
可以使用中文回复

(streamdiffusion) D:\Project\StreamDiffusion\StreamDiffusion>python -m streamdiffusion.tools.install-tensorrt
A matching Triton is not available, some optimizations will not be enabled.
Error caught was: No module named 'triton'
Traceback (most recent call last):
  File "D:\Project\Conda\envs\streamdiffusion\lib\runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "D:\Project\Conda\envs\streamdiffusion\lib\runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "D:\Project\Conda\envs\streamdiffusion\lib\site-packages\streamdiffusion\tools\install-tensorrt.py", line 3, in <module>
    import fire
ModuleNotFoundError: No module named 'fire'

(streamdiffusion) D:\Project\StreamDiffusion\StreamDiffusion>pip3 install fire
Requirement already satisfied: fire in d:\project\conda\envs\streamdiffusion\lib\site-packages (0.5.0)
Requirement already satisfied: six in d:\project\conda\envs\streamdiffusion\lib\site-packages (from fire) (1.16.0)
Requirement already satisfied: termcolor in d:\project\conda\envs\streamdiffusion\lib\site-packages (from fire) (2.4.0)
’
(streamdiffusion) D:\Project\StreamDiffusion\StreamDiffusion

Errors that occur after the third step Cuda version 12.3 installed cuda version 12.1 System environment: Windows 10 Python environment: Conda Python 3.10
Running this line of code, （`Errors that occur after the third step
Cuda version 12.3 installed cuda version 12.1
System environment: Windows 10
Python environment: Conda Python 3.10
Running this line of code, as well as other example codes, all report an error of no model`）as well as other example codes, all report an error of no model
可以使用中文回复

https://github.com/google/python-fire.git  python setup.py install


can't complete steps in README

Step 2 in README has a required dependency of a mapping.json file that is created in step 4?  Could you suggest how to create the mapping.json file before running the command that requires it please?

Hey @ivanoats,
Thanks for the input and the related PR #9
I'll look into fixing the CLI tool to not require the Settings file in the -h call rather than changing the documentation.
Cheers


Update references to Docker Client.

The docker-machine create command ends with the following potentially confusing phrase.
To see how to connect Docker to this machine, run: docker-machine env local
Please consider replacing it with the following phrase:
To see how to connect your Docker Client to the Docker Engine running on this virtual machine, run: docker-machine env local
Similarly, for the output of the following command:
$ docker-machine env local
Please consider updating the following line:
# Run this command to configure your shell
To:
# Run this command to connect your Docker Client to the Docker Engine running on <vmname>.

Ok for the first part ( done in #2917)
Not ok for the second part, since the action of docker-machine env local does not "connect your Docker Client to the Docker Engine" but really configure the shell for enabling it.
Putting a sentence like # Run this command to configure your shell to enable the connection between your Docker Client to the Docker Engine running on <vmname>. sounds a bit too verbose.


Add the site verification tokens (previously served by static)

⚠ This repo is Continuously Deployed: make sure you follow the guidance ⚠
What
Move Google and Bing authorisation tokens out of Static and into Frontend. The publishing of these is moved from static to Special Route Publisher as of: https://github.com/alphagov/special-route-publisher/pull/348.
Why
Static shouldn't really be handling any outside routes. This is the first thing to move over - then we'll do the favicon/apple touch icons.
Order of Deploy
When deploying, this change to frontend should go first. Then the deploy to special route publisher, and a call to publish the routes pointing to frontend. Finally, the change to static which removes its ability to serve the routes.
https://trello.com/c/o55zYQeB/317-tidy-verification-paths-in-static

Closing as obsolete (have worked out a better way to do this)


Impossible to disable encryption for Mail from .env

Laravel Version: 9.39
PHP Version: 8.1.12
Database Driver & Version: n/a

Description:
I'm relaying mail through a local mail server without auth or encryption, so my .env contains this:
MAIL_MAILER=smtp
MAIL_HOST=localhost
MAIL_PORT=25
MAIL_USERNAME=null
MAIL_PASSWORD=null
MAIL_ENCRYPTION=null

My config/mail.php contains the default:
'encryption' => env('MAIL_ENCRYPTION', 'tls'),

Ultimately, this value is passed to Symfony Mail, where encryption is not used if the $tls parameter is null.
The upshot of this arrangement is that it's not possible to disable encryption from the .env file. If you set it to null in .env, config will end up with the default tls value, so you have to edit the config file, which has knock-on consequences when it comes to future framework upgrades.
Symfony actually tries to solve this by disabling TLS if the hostname is localhost, however, Laravel's behaviour means it will never match that condition.
So my request here is to introduce a non-null value that results in null being passed to the $tls parameter of Symfony mail, perhaps none. We effectively already have some "magic" values for controlling this parameter (inherited from Symfony), so it's not a great departure, and strikes me as exactly the kind of thing that a facade wrapper should handle. I know this is a small thing, but it also enables the simplest possible SMTP config for Laravel. From my experience with PHPMailer, I know that SMTP to localhost is both faster and safer than using PHP's mail() function or calling a sendmail binary via a shell.

What about this?
MAIL_ENCRYPTION=false

> null === false
= false

It should then hit https://github.com/symfony/mailer/blob/6.1/Transport/Smtp/EsmtpTransport.php#L57-L59 no?

That's a good point – the second test is if (!$tls) {, which is less picky. I'd also not noticed that the $tls param is defined as bool $tls = null, so it doesn't actually let you specify the type of TLS connection, only turn it on or off. But I think that will do, thanks for the bandwidth!

Yep, and env allows false as the value
> env('MAIL_ENCRYPTION', 'tls')
= false

Enjoy!


Unable to Run r24+

After updating to r24 I am unable to open any of my D3 projects, everything was working just fine in r23.4.2 but in r24, r24.0.1, and r24.0.2 my Disguise software freezes and crashes my PC while attempting to open.
This is a link to a Google Drive folder with my System and Project Diagnostic files: https://drive.google.com/drive/folders/1E5648SSdQLEFlszR0wEst7Pm_eXLrbW_?usp=sharing
The LED volume in our studio is running on r24.0.1 and my coworker on his own machine was able to run r24.0.1/2 without any issues so I am wondering if it's possibly a hardware issue on my system.
When opening a D3 project it would either freeze on the black loading screen or open the project for just a second before freezing and locking up my entire PC. If there's anything else I can provide to assist with this please let me know.

Hi, this seems like a core D3 issue rather than Renderstream plugins. I'd recommend you contact<EMAIL_ADDRESS>and they should be able to help you out.


Filter for state=installed by default

Fix issue 54 from sdntrace_cp
Now on the flow_manager/v2/stored_flows endpoint, only installed flows are filtered if no state is specified.
This endpoint is used in function get_stored_flows() of sdntrace_cp.
See change
I wonder if it's better this way or if I should just filter it for sdntrace_cp

I wonder if it's better this way or if I should just filter it for sdntrace_cp

@gretelliz thanks for this PR.
As you've implemented it's an option that we could go for, however, that would have two drawbacks:

If flow_manager needs to change this default in the future then it'll break sdntrace_cp
Also, we would need to implement a all or None semantics otherwise the url arg will be a bit awkward ?state=

With that said, to minimize surprises, I think it'd be easier to maintain on sdntrace_cp to explicitly filter for what the client needs.
Let me know what you think.

@viniarck, I agree, let's change only sdntrace_cp


Migrate to core v0.8.3-SNAPSHOT

Support for archived and deleted feature.
Support for bulk write in RecordStorage.

@alexander-yevsyukov PTAL


Fixed issue where artefacts with parens () would not get copied

Regarding the copy_artefacts task, it was recently rewritten to use native Ruby methods instead of shell scripting magic via cp.
It seems a part of the old code was left over which is unnecessary for the native Ruby based approach, namely shellescaping, which was causing files with parens in them e.g. MyApp_v3.0_(3000).ipa
This PR fixes the issue.

Nice catch, thanks for the pull request @lmirosevic 🚀


challenge.replay not work

Form
Put an [x] if you meet the condition, else leave [ ].
Requirements

[x ] I've searched the Issues
[ x] I've read the basic concepts
[x ] I'm using the latest version

Platform

[x ] I'm using Node.js version v12.13.1
[ ] I'm using electron
[ ] I'm using the browser YOUR_BROWSER_AND_VERSION
[ ] I'm using some other environment YOUR_ENV

Description
Resending the confirmation code does not work
fiddler
Code
const IG = require('instagram-private-api');
const ig = new IG.IgApiClient();
ig.state.proxyUrl = 'http://<IP_ADDRESS>:8888';
const prompts = require('prompts');

const IG_USERNAME = 'login';
const IG_PASSWORD = 'pass';

ig.state.generateDevice(IG_USERNAME);

app();

async function app() {
    try {
        await ig.simulate.preLoginFlow();
        await ig.account.login(IG_USERNAME, IG_PASSWORD)
        process.nextTick(async() => await ig.simulate.postLoginFlow());
    } catch (e) {
        if (e instanceof IG.IgCheckpointError) {
            await ig.challenge.auto(true);
            let ch = ig.state.challenge;
            if (ch.step_name == 'submit_phone' && ch.step_data.phone_number == 'None') {
                let input = await prompts({
                    type: 'number',
                    name: 'value',
                    message: 'your phone:'
                });
                await ig.challenge.sendPhoneNumber(input.value);

            }
            let input = await prompts({
                type: 'number',
                name: 'value',
                message: 'your code:'
            });

            try {
                await ig.challenge.sendSecurityCode(input.value);
            } catch (e) {
                if (e instanceof IG.IgChallengeWrongCodeError) {
                    await ig.challenge.replay(0);
                }
            }
        }
    }
}

I don't know what's your issue there. The only thing I could find is that ig.challenge.replay takes a string as input. So you can replace the 0 with '0'.

Hm. I tried to sign in through the browser and IG demanded to pass Recpatcha2

I don't know what's your issue there. The only thing I could find is that ig.challenge.replay takes a string as input. So you can replace the 0 with '0'.

I tried passing a string but there is no difference

Then what are you expecting the method to do?

Then what are you expecting the method to do?

I am waiting for the code to be sent again. Now I have done it, via reset and code request.

This thread has been inactive for a long time now, so it will be closed. If this is still an issue, reopen the it.


Update bmi.hxx to reflect addition of virtual destructor

https://github.com/csdms/bmi-cxx/pull/12
https://github.com/NOAA-OWP/ngen/issues/831
Changes

Update the bmi-cxx submodule to get the above change

Checklist

[x] PR has an informative and human-readable title
[x] Changes are limited to a single goal (no scope creep)
[x] Code can be automatically merged (no conflicts)
[x] Code follows project standards (link if applicable)
[ ] Passes all existing automated tests
[ ] Any change in functionality is tested
[x] New functions are documented (with a description, list of inputs, and expected output)
[x] Placeholder code is flagged / future todos are captured in comments
[x] Visually tested in supported browsers and devices (see checklist below :point_down:)
[x] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
[x] Reviewers requested with the Reviewers tool :arrow_right:

This should maybe also evolve to replace the internal copy solely with the referenced version from extern/bmi-cxx


Feat/social event

This PR adds a page for the social event.

Are the added slugs changing the urls of the pages? I'd prefer to not change the urls at this point if that's the case, we'll break links in search engines, social media...
Also, did you check how the menu renders? The space for the sections is limited, and I think it can overflow with the new "Social event" section. I think my preference is to add a link in the program, and may be somewhere in the home, and not have a section for it in the top menu.

As far as I see, the slugs are not used anywhere, I just added them so the other ones wouldn't feel alone. I would have actually deleted them because AFAIK the save_as field is what defines the file name, hence the urls. The slugs are not used in the setup for this year, we are not using templates or articles.
I removed the social event from the menu, added the url in the index and program pages.
Thanks for the review!


Update index.md

A small description for the release of today.

@JulesVanThillo , it seems that your release note can be separated into an improvement and a fix:
If I rewrite it like this, will it be correct?
Improvements
We improved the create new app flow.
Fixes
We fixed an issue where you were redirected to the Comments page from the Stories page.

@MariaShaposhnikova That's an excellent description of our release. You can change it.

Discussed and agreed on slack to change the text of the improvement to: "We made minor improvements to the process of creating a new app".


Question: Serializing records with sets and lists in F#

I'm using F# and I have trouble packing record types containing sets or lists.
The code below fails with the message:

"System.Runtime.Serialization.SerializationException: Type 'FSI_0003+SetRecord' does not have default (parameterless) public constructor."

I guess I need to write a new custom serializer that packs the values as arrays are packed but I'm not sure how? Any ideas or pointers to where I can find examples?
#r "MsgPack.dll"

type TestRecord = {
    Foo : string;
    Bar: int;
}

type OptionRecord = {
    Foo : string option;
    Bar: int;
}

let serializer = MsgPack.Serialization.SerializationContext.Default

let serializeToMsgPack<'T> (x:'T) =
    serializer.GetSerializer<'T>().PackSingleObject(x)

// Gives result:

serializeToMsgPack { TestRecord.Foo = "Hello"; Bar = 42 }
serializeToMsgPack { OptionRecord.Foo = Some "Hello"; Bar = 42 }
serializeToMsgPack { OptionRecord.Foo = None; Bar = 42 }

type SetRecord = {
    Foo : string option;
    Bar: Set<int>;
}

// Crashes:
serializeToMsgPack { SetRecord.Foo = Some "Hello"; Bar = Set.empty.Add(42) }

type ListRecord = {
    Foo : string option;
    Bar: int list;
}

// Crashes:

serializeToMsgPack { ListRecord.Foo = Some "Hello"; Bar = [ 1 ] }

Hey @bhandfast, try to add the [] attribute to those records.

Thanks for the help. However, now I get another error.

System.Runtime.Serialization.SerializationException: Type 'Microsoft.FSharp.Collections.FSharpSet1[System.Int32]' does not have both of default (parameterless) public constructor and  public constructor with an Int32 parameter.    at MsgPack.Serialization.UnpackHelpers.GetCollectionConstructor(Type instanceType)    at MsgPack.Serialization.AbstractSerializers.SerializerBuilder2.BuildCollectionCreateInstance(TContext

context, Type concreteType)
Arrays seems fine though, guess I could remodel my type.

Sorry for delay. There are 2 problems.

There is a bug that record like type cannot be serialized if it has mutable collection type member.
As you know, FSharpSet<T> is not supported. You must register custom serializer for FSharpList, FSharpSet, and FSharpMap as built-in immutable collections support.

Fixed in 7bfdee5 for the bug. F# collection will not be supported in built-in serializers.


Send the real commit of the build to GitHub

GitHub marks the commit only at the moment we create release on GitHub.
And if we push some commits between the moment we start the build and the moment the build is ended and "uploaded" to GitHub, GitHub will create a Git tag on the wrong commit:

1 - the real commit, on which we start the build
2 - tag, which is created by GitHub at the moment when we call API for creating GitHub release

Fixed on CI:
BRANCH=%build.vcs.number%
...
API_JSON=$(printf '{"tag_name": "v%s","target_commitish": "%s","name": "v%s","body": "%s","draft": %s,"prerelease": %s}' "$VERSION" "$BRANCH" "$VERSION" "$MESSAGE" "$DRAFT" "$PRE" )

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


SOSO：５个并发的情况下出现重复数据

hi dear。
我们在程序里面采用单机模式（默认参数）。
最近做性能压测，0-5个并发还好。大于5个就会出现重复的key。

你用的什么开发语言？不妨贴一下测试代码看看。

目前还有这个问题存在，10个并发，出现重复 key

你好，我使用的是 Python，worker id 是通过 redis 生成的（redis_connect 表示连接redis的配置信息），主要代码如下：
获取worker id
register = security.gen_idgenerator(redis_connect)
worker_id = register.get_worker_id()
生成id generator
options = IdGeneratorOptions(worker_id=worker_id)
idgen = generator.DefaultIdGenerator()
idgen.set_id_generator(options)
uid = idgen.next_id()
redis_idregister.stop()
谢谢

每个进程，使用不同的WorkerId，是不会出现重复的。

Hello,
We have an exciting opportunity for you! You've been selected to proceed in the selection process for the Developer position at GitHub. Congratulations on your achievement!
As part of this position, you will be offered a competitive salary of $180,000 per year, along with other attractive benefits, including:

Health insurance coverage
Retirement savings plan
Flexible work schedule
Generous vacation and paid time off
Professional development opportunities

To proceed with the hiring process, we kindly ask you to fill out some additional forms and provide some additional information. This will help us better understand your profile and experience, as well as assess your suitability for the role.
Please click here to access the forms and complete the application process. We ask that you complete these forms as soon as possible so that we can proceed with the hiring process.
Important: You have 24 hours to complete the application process.
If you have any questions or need further information, please don't hesitate to contact us.
Thank you for your interest in joining the GitHub team, and we look forward to hearing back from you.
Best regards,
GitHub Recruitment Team
winxblast, @liutaihua, @okxx, @lichaoahcil, @wangfeng2016, @alexchenyu, @paperplane1230, @VINO42, @noah-lcf, @aeromomo, @jeffzlweng, @slamet235, @hanksuper, @RustMan88, @mericahero, @napioo, @EjiHuang, @cindyzjia, @kataCai, @xstone0527

我这边遇到多实例部署使用不同的workerId但是id一直重复么


kubectl follow logs stops after few seconds if there is a lot data to stdout

What happened?
A lot of running jobs generates a massive amount of log to stdout.
Steps:

Running K8s job that invokes a lot of lines to stdout.
kubectl logs -f  -n
Starts tailing pod output, till it stuck randomly.
Note, it stuck till pod exit with a success or failure.

What did you expect to happen?
Expected result is to see all pod stdout on screen. This is not happening.
How can we reproduce it (as minimally and precisely as possible)?

invokes a pod that generates a massive amount of stdout.
run:
kubectl logs -f  -n

after a while, this is randomly duration, it stops showing output

Anything else we need to know?
No response
Kubernetes version

$ kubectl version
Client Version: v1.28.1
Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3
Server Version: v1.27.7

Cloud provider

OS version

# On Linux:
$ cat /etc/os-release
# NAME="CentOS Linux"
VERSION="7 (Core)"
ID="centos"
ID_LIKE="rhel fedora"
VERSION_ID="7"
PRETTY_NAME="CentOS Linux 7 (Core)"
ANSI_COLOR="0;31"
CPE_NAME="cpe:/o:centos:centos:7"
HOME_URL="https://www.centos.org/"
BUG_REPORT_URL="https://bugs.centos.org/"

CENTOS_MANTISBT_PROJECT="CentOS-7"
CENTOS_MANTISBT_PROJECT_VERSION="7"
REDHAT_SUPPORT_PRODUCT="centos"
REDHAT_SUPPORT_PRODUCT_VERSION="7"
$ uname -a
# Linux <hostname> 3.10.0-1160.99.1.el7.x86_64 kubernetes/kubernetes#1 SMP Wed Sep 13 14:19:20 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

</details>

### Install tools

<details>

</details>

### Container runtime (CRI) and version (if applicable)

<details>

</details>

### Related plugins (CNI, CSI, ...) and versions (if applicable)

<details>

</details>

When logs are tailed kubectl uses the watcher utility, which relies on go channels, in this case a buffered go channel. We can see in the below link that the default size for the buffer is 100, and this is not currently configurable. Now, normally this would be fine because the logs coming in would be sent out, but because you are generating so much data, the logs are unable to exit the channel buffer at a faster rate than the logs are flowing in to the channel buffer, resulting in negative pressure and the channel to hang.
How the log function spawns multiple watchers
The default buffer size of the channel used by the watchers
If you run the command causing the issue with -v=9 flag that may give us a clearer indication that this is what is happening. Could you do that and post the resulting logs for that message (not the logs that are being output but the ones being returned as a result of the verbosity flag)?

/sig cli

@mpuckett159,  Thanks for detailed response. I'm guessing you're asking for the beginning of v=9 output.
if so, file attached with details.

kubectl-v9.pdf

would like to help here.
Do we want to provide an option to increase the buffer size?

not stale

/remove-lifecycle stale

@mpuckett159 does the logs shared above confirm your theory?
I can see that DefaultConsumeRequest uses the stream function of go-client.
I don't see watch package used in this code path. What am I missing? 🤔

I am surprised that more people aren't complaining about this 😄
This blocks me daily and I would love to help solve whatever limitation we are running into here.

Agree, it looks like people does not look into stdout anymore, but on main Log servers such as Loki, Elk etc.

I spent some time on this today and it was hard to reproduce. I think, checking the kubelet and api server logs if that happens can enlighten the issue. I'm not sure this issue is definitely happening on kubectl and we need to eliminate the other components first.

Also another question would be; does this happen without tailing -f?

I doubt kubelet too.
From whatever I could see, it wasn't happening on kubectl. Will dig some more on my next attempt.

not stale


Publish Orbis platform?

CryEngine GitHub repo already has an Orbis CMake Toolchain as well as Durango. https://github.com/bkaradzic/GENie also has some public Orbis platform code.
Why don't you publish Orbis platform code to the repo if you already have Durango which is also non-public? 😃
Orbis is not a typical Microsoft platform like Durango so there might be some complications in writing a platform from scratch especially for new users of Sharpmake.

Heya,
The reason is simple, we were not allowed to release it publicly.
It is however available on Sony's devnet forums, so if you have access to them you can retrieve it.
Thanks for your interest in sharpmake!

Oh, sorry, I haven't thought about searching the DevNet


Update viewport-units-buggyfill.js

Problem:
CSS from CDN does not work (CORS error) even if we add data-viewport-units-buggyfill="ignore" as attribute in link tag
Solution:
Add data-viewport-units-buggyfill="ignore" for importCrossOriginLinks function to skip import cross origin links.

+1

good catch! released in v0.5.3


Auto light/dark mode

Not sure if we have this but if a prefer is set then we should probably grab that instead. Because flashbang is bad.

Now uses the site wide theme changer, which respects prefer color scheme


Update absl dependency to 20210324.2

Absl doesn't build with glibc 2.34, which is now being rolled out by
more and more Linux distributions. Update to the lastest patch version
of the same LTS release to include the relevant build fixes.
https://github.com/abseil/abseil-cpp/commit/278e0a071885a22dcd2fd1b5576cc44757299343
are the only changes over the last version.

@googlebot I signed it!

Codecov Report

Merging #956 (290369e) into master (cc9ec78) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #956   +/-   ##
=======================================
  Coverage   92.71%   92.71%
=======================================
  Files         316      316
  Lines       20737    20737
=======================================
  Hits        19226    19226
  Misses       1511     1511

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc9ec78...290369e. Read the comment docs.

Thanks, merged!


GH Pages Deployment has no styles

What version of starlight are you using?
0.15.0
What version of astro are you using?
4.0.1
What package manager are you using?
yarn
What operating system are you using?
Mac, Linux
What browser are you using?
Chrome, Firefox
Describe the Bug
When deploying to Github Pages my site has no styles and the links don't work.
This is my workflow:
Since I am using a monorepo I was forced to use my own action. I am building to build instead of dist because anything that is .gitignored fails the artifact upload.
name: Deploy to GitHub Pages

on:
  push:
    branches: [main]
  workflow_dispatch:

permissions:
  contents: read
  pages: write
  id-token: write

jobs:
  docs:
    name: Deploy Docs 📖
    environment:
      name: github-pages
      url: ${{ steps.deployment.outputs.page_url }}
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v3
      - run: echo "NODE_VERSION=$(cat .nvmrc)" >> $GITHUB_ENV

      - name: 'use node ${{ env.NODE_VERSION }}'
        uses: actions/setup-node@v3
        with:
          node-version: '${{ env.NODE_VERSION }}'

      - name: Install dependencies
        run: yarn install --frozen-lockfile

      - name: Build
        run: yarn build

      - name: Setup Pages
        uses: actions/configure-pages@v4

      - name: Upload artifact
        uses: actions/upload-pages-artifact@v2
        with:
          path: docs/build

      - name: Deploy to GitHub Pages
        id: deployment
        uses: actions/deploy-pages@v3

This is the site after it deploys.
Link to Minimal Reproducible Example
https://jpwallace22.github.io/use-react-workers/
Participation

[ ] I am willing to submit a pull request for this issue.

I think you need to set base in your astro.config.mjs to tell Astro your site is not at / but at /use-react-workers/.
export default defineConfig({
  site: 'https://jpwallace22.github.io',
  base: '/use-react-workers/',
  outDir: 'build',
  // ...
})

I can confirm this by going to one of the assets with the base added.
https://jpwallace22.github.io/use-react-workers/_astro/page.36aCzv65.js
Hope this helps 💜

@delucis @kevinzunigacuellar Awesome, yeah. This got it working. I guess I was a little confused about what the base was. I tried a couple of times with the base: docs/ since it is a monorepo and in the docs directory. Maybe the docs could use some clarification for people like me? 😩
Regardless, thanks for the quick replies and I am up and running.


Changed how we read the cloud connect token

Remove duplicated labels
Description
PR changes the code the fetches the cloud-connect token. We now retrieve it from the Secret first if it exists, if it doesn't exist we check the configmap (Edge-Stack/Emissary). Also removed the need for List because we fet the exact Secret or ConfigMap, so I removed that from the ClusterRole as well.
Fill ALL sections
Documentation

[ ] I updated the relevant .md documentation.
[ ] I updated the relevant website documentation.
[x] This PR does not require documentation updates.

Dependencies

[ ] This PR contains new dependencies
[x] This PR does not have any change in dependencies.

Testing

[ ] I provided sufficient test coverage for the modified code.
[ ] The existing tests capture the requirements for the modified code.
[ ] The bulk of my code covered by unit tests.
[x] I executed manual tests to validate my changes and to avoid regressions.

Testing Strategy
A few words describing your testing strategy, e.g., manual tests, automated tests, extra validations, etc.
Dependencies, related issues, and other notes

List change dependencies, if any.
List related issues, if any.

I am Nanzi Yang, the reporter of this issue, can you give me a moderate CVE number, or a security advisory for awarding my efforts? Looking forward to your reply.
Regards,
Nanzi Yang
@jacoblbeck @knlambert


Add support of packing / unpacking structure during storage layout verification.

Let's say we have an ERC20Votes contract. This contract contains 3 consecutive slots dedicated to the voting logic:
    mapping(address => address) private _delegates;
    mapping(address => Checkpoint[]) private _checkpoints;
    Checkpoint[] private _totalSupplyCheckpoints;

This storage and the associated logic would benefit from being abstracted away, so it can be reused for ERC721 voting or ERC1155 voting (for example).
This is what this structure proposes. You'll note that, at a low level, the storage is consistent. It is however hidden in structs.
    struct Checkpoint {
        uint32 index;
        uint224 value;
    }

    struct History {
        Checkpoint[] _checkpoints;
    }

    struct Votes {
        mapping(address => address) _delegation;
        mapping(address => History) _userCheckpoints;
        History                     _totalCheckpoints;
    }

I believe that it would be a great improvement if the plugin was able to flatten the structure so that this would trigger a rename error, but not replace/delete/insert errors.
This branch include tests for such a feature

A naive implementation would not be correct because structs don't necessarily align in storage the same way as their contents. We've seen this recently with struct Timestamp { uint64 t; }, which is not equivalent to using the uint64 directly.
If we implement support for users packing variables into structs, we need to do it using the storage layout emitted by solc (#3) because it contains detailed information about alignment.

It is true that struct do force some data alignment which means that packing/unpacking is not as simple as that. However, in cases such as the one presented above, packing would be consistent.
I believe it would be indeed be interesting to refactor the storage compatibility check mechanism to use the storage layout emitted by solc. It would be more versatile (possible support for packing) and safer (be basically exploit data from the source)


Add more data fields to Kustomization and Source detail pages

Closes #29
Adds more detail to the pages:

This will probably need another pass once we have a more complex cluster.
Making the panels data-driven also required refactoring some protobuf messages, which in turn brought up a gap in type-checking support, so that was added to the CI job.

Way too stale to try and salvage now. Closing.


refactor!: rename wasm to smart contract

Description
The fact that we work with wasm smart contracts is a sort of implementation detail.
Let's not specify implementation details in the API.
Linked issue

Closes #{issue_number}

Benefits
If we change from wasm to some other VM, we will have a reduced effect on the API.
If we don't it is implied that we use wasm, so no harm done there
Checklist

[ ] I've read CONTRIBUTING.md
[ ] I've used the standard signed-off commit format (or will squash just before merging)
[ ] All applicable CI checks pass (or I promised to make them pass later)
[ ] (optional) I've written unit tests for the code changes
[ ] I replied to all comments after code review, marking all implemented changes with thumbs up

@s8sato has a good point. I'm closing this


Adding third party solution verbiage

Adding phrasing to speak to third party solution.

@JamesFerebee : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off

@jborsecnik : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Add help to README for loading fonts in non Windows systems

It works by name on macOS as well, so this might only be a Linux issue. Can you update accordingly?

Sure thing. Updated.


Fix: Undefined method pages on time entry report

Notion Card
Notion Card
Description
To fix the following issues -

Showing of pagination option even when no pages are present.
Previous and Next buttons enabled even when on the first and the last page.
Page crashes when the user filters by using group by week.

Preview
https://user-images.githubusercontent.com/57438322/228483995-0332277a-9ab6-4ae7-9e38-087441910f19.mp4

@mayankagnihotri7 There are 124 entries in my local and all of them are shown on the first and no pagination is shown. What's the max number of entries that we want to show on a page?


CentOS/RedHat install support

Hi,
Has anyone got Realsense to work for CentOS/RedHat?
Is there any instructions?  Any help highly appreciated.
a YUM script would help to just install the drivers.

Hi @GaryKT - Aside from some potential Cmake/building issues, yes -- librealsense should work on RedHat/CentOS based distributions: https://bugzilla.redhat.com/show_bug.cgi?id=1413646


poudriere naming conventions for jails and ports trees

Prerequisites

☑ Have you checked for an existing issue describing the issue?

From https://forums.FreeBSD.org/threads/81582/post-525675:

Don't use dashes (-) in the name of the jail … or the ports tree name. That causes a bunch of weird issues. …

From the manual page for poudriere-jail(8):
CAVEATS
   Jail Names
     The values set with the -j, -z, and -p flags are all used directly in the
     name of the jail created by poudriere.

     Be careful to respect the names supported by jail(8):

           This is an arbitrary string that identifies a jail (except it
           may not contain a '.').

FreeBSD 14.0-CURRENT              May 6, 2021             FreeBSD 14.0-CURRENT

% pkg info -x poudriere
poudriere-devel-<IP_ADDRESS>10720
%

Eh? I use dashes in all my jail names and have not had any issues and I have been doing it for many years..

(Maybe not a bug … I should have checked for myself before reporting …)

Closing; can be reopened if there's a response to https://forums.freebsd.org/threads/81582/#post-526102. Apologies for the noise.

The issue is with ports trees with -. Jails with - should be fine (I use this). I'll add a check to prevent using new ports trees with -.


Switched regex with pelite for pattern scanning

Wanted to start contributing to this project since i am a user myself :wink:
Memflow uses  pelite = "0.9.0" so why not use pattern scanning from that library?
(I am new-ish to rust, so please tell me if i should change something)

Hey! Thanks for the contribution - especially since you are the first contributor. The PR looks good to me so far. I'll give this a test and if it works fine i will merge it :+1:


[PacMin-18] Fixed broken build.

Fixes a broken build due to an upstream change.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/PacMin-prb/16/
Test PASSed.


How to limit the size of data in forall?

I am testing properties of objects that have complexity O(m * n), so it is very slow when large inputs are created. How can I limit the size of the data generated by forall?

Valid concern! I'll make a special small arbitrary for that, which will create log2 sized objects:
I.e. one could (soon) do:
jsc.property("high complexity algorithm property", "(small array) int", function (arr) {
  return /* property with small array of normal ints ... */;
});

or if one wants small array of small ints:
jsc.property("high complexity algorithm property", "small (array int)", function (arr) {
  return /* property with small array of small ints ... */;
});


Check on post code and body

Fixing the test post helper method so that is actually checks the expected body.

Current coverage is 80.27%

Merging #261 into master will not affect coverage as of 74fefe6

@@            master    #261   diff @@
======================================
  Files           70      70
  Stmts         3518    3518
  Branches       441     441
  Methods
======================================
  Hit           2824    2824
  Partial          0       0
  Missed         694     694

Review entire Coverage Diff as of 74fefe6

Powered by Codecov. Updated on successful CI builds.

:+1:


WorldQuery::init_state signature is too generous

          I realized that because `Storages` and `Components` aren't public fields on `World`, and there are no mutable accessor functions, doing the same change likely doesn't work for `init_state`.

Adding mutable accessor function does not make sense, because this would allow users to readily cause UB.
Instead we could have a function on &mut World that returns an opaque struct on which init_component, ... can be called.
Originally posted by @Victoronz in https://github.com/bevyengine/bevy/issues/13343#issuecomment-2107782171

@Victoronz do you want to tackle this?

Sure, as I'm already familiar with this.
Currently I'd suggest a component_initializer method on &mut World. It would return a ComponentInitializer struct, which would be a wrapper around &mut Components and &mut Storages. This struct would re-expose all methods on Components, minus the &mut Storages parameter on init_component and init_component_with_descriptor respectively.

Maybe this should be punted off of 0.14, because the bevy-trait-query has made this more involved. A note could be put in the method comment in the meantime.

Agreed: we should bump this to 0.15.

According to https://github.com/JoJoJet/bevy-trait-query/issues/59#issuecomment-2212516814, the caching isn't actually required to make bevy_trait_query work. It's a wash performance-wise.
Maybe we should allow it anyways, but that's a major relief for me.

If it wasn't required, I think it is best to constrain it again.
A superficial search on Github for WorldQuery::init_state impls has not turned up any further outliers for me, and the ones I knew for get_state seem to no longer be present either (presumably because of the update).


release new version

:tada: This PR is included in version 1.4.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add item to stop using APTCA

And changed tense
Summary
Describe your changes here.
Fixes #Issue_Number (if available)

Wanted to change the ms.date on this topic, so gave an editing pass on this. One question though @blowdart, is that opening paragraph correct?

Yea it's correct enough without dipping into the weeds


Pango Error on Ubuntu 20.04

When I try to open the Git-it executable, I get the following error:
(Git-it:8793): Pango-ERROR **: 15:37:22.651: Harfbuzz version too old (1.2.7)

Hey @rsaltus I had same issue as you at first, when I later I realised that I downloaded an old release (New Year New Release) which made me thought that was the latest version for English speakers.
Try downloading from this release Now with even more Spanish! that is not just for spanish speakers but it also have the latest release.


feat: add mapStores

Codecov Report

Merging #426 (26ea981) into v2 (1c85b88) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##                v2      #426   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            4         5    +1
  Lines          119       171   +52
  Branches        18        22    +4
=========================================
+ Hits           119       171   +52

Impacted Files
Coverage Δ

src/rootStore.ts
100.00% <ø> (ø)

src/types.ts
100.00% <ø> (ø)

src/mapHelpers.ts
100.00% <100.00%> (ø)

src/store.ts
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 755ec71...26ea981. Read the comment docs.


[SPARK-47074][INFRA] Fix outdated comments in GitHub Action scripts

What changes were proposed in this pull request?
This PR aims to fix outdated comments in GitHub Action scripts.
Why are the changes needed?

Cache limit is 10G as of now: 2G -> 5G -> 10G

https://github.com/actions/cache?tab=readme-ov-file#cache-limits

A repository can have up to 10GB of caches.

Since SPARK-32246 is resolved, we need to remove the following TODO comment.
https://github.com/apache/spark/blob/64fa13b5744fac11d62c35a9b1e1f8e7917bcc18/.github/workflows/build_and_test.yml#L136-L137

Does this PR introduce any user-facing change?
No. This is a comment-only change.
How was this patch tested?
Manual review.
Was this patch authored or co-authored using generative AI tooling?
No.

Could you review this comment-update PR, @HyukjinKwon ?

LGTM, thank you!

Thank you, @xinrong-meng ! Merged to master.


Improve Overall Responsiveness of the Website

Is your feature request related to a problem? Please describe.
The website currently lacks responsiveness, leading to a poor user experience on various screen sizes.
Describe the solution you'd like
I would like the website to have a fully responsive design that adapts to different screen sizes seamlessly.
Additional context

In the navigation bar, the hamburger menu, search bar, and account profile section collapse improperly on smaller screens.
The "Snippets" and "Add Snippets" pages are not responsive and their content does not scale correctly on mobile devices.

Video of the current design and suggestions for improvement can be provided upon request.
https://github.com/user-attachments/assets/12053e87-c228-43a6-bee4-777517a33779

@rudrapratap63, I understand your concern, but there is already an existing issue with the same objective #39. Kind comment there and I'll assign that to you. Additionally, I'll update the issue title so you can work on the responsiveness of all the pages. Please make sure to fetch the latest changes from the develop branch, make your updates, and raise the PR for the develop branch only. Thank you!

Thank you for the clarification! I’ll comment on issue #39 as suggested. I’ll also ensure I work on the responsiveness of all pages. I’ll make sure to fetch the latest changes from the develop branch and submit the PR to the same branch.
Appreciate your guidance!


@-mentions don't pick up my username correctly

When I signed up for ldjam.com, I said my name was "Steve Johnson". It then made my username into steve-johnson. But Feedback Friends thinks I'm Steve Johnson. People are commenting at me with @steve-johnson.
I'm not sure if there's a way to fix this, but if there is, I would appreciate it!

You're right, Feedback Friends should switch from storing the pretty names to actual @-based usernames, as it's what people use for mentions naturally.
I'll try to push an update tonight.

It's now fixed, thanks for the report :)


Update InstallCommand.php

This PR adds the possibility to publish a Provider into a subfolder.
For example ->publishesServiceProvider("Filament/AdminPanelProvider") will be published into app/Providers/Filament/AdminPanelProvider.php

Thanks!


[WIP] Use TableGen to generate the ops reference documentation

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
5 unchanged lines in 2 files lost coverage.
Overall coverage remained the same at 83.217%

Files with Coverage Reduction
New Missed Lines
%

mlir_graphblas/engine.py
1
75.57%

mlir_graphblas/tests/test_profile.py
4
51.95%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2742

Relevant Lines:
3295

💛  - Coveralls


Removing "undefined" on phone

Proposed changes

At the beginning of a speech builder if you use directly .addAudio() like this :
let speech = this.speechBuilder().addAudio("mp3_url")
without text parameter, you will have an "undefined" on your phone screen on Google Assistant App.
Adding optional text will correct that.
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] My code follows the code style of this project
[ ] My change requires a change to the documentation
[ ] I have updated the documentation accordingly
[x] I have added tests to cover my changes
[x] All new and existing tests passed

Thanks @JordanMontel
I will port this to v2.


Add source code line and character number to error messages

Errors do not currently reference the source code in any way when they are printed out.
For example, when running this fib function with an extra @ at the end, we get the following error which does not tell us which of the three @ operators threw the error.
aya> {0\1{$@+}@%;}:fib; .# correct fib
aya> {0\1{$@+}@%;@}:fib
{0 \ 1 {$ @ +} @ % ; @}
aya> 10 fib
Unexpected empty stack while executing instruction: @
   in @ .. }
Function call traceback:
  Error in: fib

This problem becomes worse when running larger programs with many lines and/or files of source code.
The goal of this issue is to include three things in error messages:

source file (if not running directly from the REPL)
line number
character number

Ideally, these are printed in a nice way like Python 3.11 PEP 657:
Traceback (most recent call last):
  File "calculation.py", line 54, in <module>
    result = (x / y / z) * (a / b / c)
              ~~~~~~^~~
ZeroDivisionError: division by zero

See PR #87


clib: Fix unsound free usage

CString should not be freed by ordinary libc free
but by using CString drop function. This will prevent
issues on systems that use custom allocators.
The pointer which this function returns must be returned to Rust and reconstituted using from_raw to be properly deallocated. Specifically, one should not use the standard C free() function to deallocate this string. from [0].
[0] https://doc.rust-lang.org/std/ffi/struct.CString.html#method.into_raw

Thanks for the help. Merged.


fix(tx-pool): prune known senders on new block

Closes #6802

something went wrong here while rebasing -.-

something went wrong here while rebasing -.-

@mattsse resolved.

this is too tricky to solve efficiently, caching senderinfo indefinitely should be okay