feat: Add snippets for all Layer classes [#34]

Fix: #34
@hhkaos, please check the PR.
I have added snippets to all the Layers.
Let me know if any changes are needed 🙂

Here is the task list for the progress on the changes requested.

Vector layers

[x]  CSVLayer
[x]  GeoJSONLayer
[x]  GeoRSSLayer (OGC)
[x]  GraphicsLayer
[ ]  FeatureLayer
[ ]  FeatureLayer (client-side)
[ ]  MapNotesLayer
[x]  OGCFeatureLayer OGC API - Features
[ ]  RouteLayer
[ ]  StreamLayer
[ ]  VectorTileLayer
[ ]  WFSLayer OGC Web Feature Service (WFS)

Raster Layers

[ ]  ImageryTileLayer
[ ]  ImageryLayer
[ ]  ImageryTileLayer /w COG
[ ]  ImageryTileLayer (Multidimensional)
[ ]  WebTileLayer - (XYZ layer / Slippy maps)
[ ]  WMSLayer OGC Web Map Service (WMS)
[ ]  WMTSLayer OGC Web Map Tile Service (WMTS)
[ ]  WCSLayer OGC Web Coverage Service (WCS)
[ ]  MapImageLayer (Time-based) Traffic layer
[ ]  BingMapsLayer
[ ]  OpenStreetMapLayer

3D layers

[ ]  SceneLayer
[ ]  Elevation
[ ]  PointCloud
[ ]  BuildingSceneLayer
[ ]  LineOfSightLayer
[ ]  DimensionLayer
[ ]  IntegratedMeshLayer
[ ]  VoxelLayer

Others

[ ]  MediaLayers (Overlayed images with control points)
[ ]  MediaLayers (/w video)
[ ]  KML Layer (OGC)
[ ]  GroupLayer
[ ]  SubtypeGroupLayer
[ ]  TileLayer
[ ]  KnowledgeGraphLayer

@hhkaos, I have pushed the requested changes. Please check it out.
Thank you for the feedback!


Adding HA support

Tested it on session cluster, usage for the application cluster is based on reply from Flink community

Hi @blublinsky,
Thank you for your contribution! We really value the time you've taken to put this together.
Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:
http://www.lightbend.com/contribute/cla

I did sign the CLA.

@blublinsky Could you provide some overview on the changes here? Are the newly added files adapted from the Flink code base? Is ZooKeeper a dependency for HA (I saw it mentioned several times)?

This is a completely new implementation, inspired by zookeeper implementation. The main things are described here https://github.com/lightbend/fdp-flink-build/blob/ha/src/main/java/org/apache/flink/runtime/highavailability/filesystem/FileSystemHAServices.java.
It has no dependencies on zookeeper.
There are overwrites for 2 existing classes - HighAvailabilityServicesUtils, which adds support for filesystem and HighAvailabilityMode - adding filesystem as an option

And it is fully functional now, including application cluster

This is no longer a small wrapper around the existing Flink images with added Prometheus integration, right? As @yuchaoran2011 asked, it seems that extensive changes are being made and it's not clear what's changed, what the purpose of the changes is, and how well tested they are for production usage scenarios. A good discussion of what's new in the README would help.

It is a completely new implementation. So with the exception of 2 files mentioned above, its a new implementation.
Will add readme

@blublinsky With your latest commits, the build was able to run. But it failed at the last step when building docker images. The error message is:
invalid argument "****/flink:.11_alpine" for "-t, --tag" flag: invalid reference format
See 'docker build --help'.

I wonder if it's because you don't have curly brackets around the env var FLINK_VERSION.

I'm closing this PR. As I said before, it's not acceptable to patch Flink itself this way. Instead, create an appropriate patch for Flink itself and remove those changes here, creating a new PR in this repo that uses those changes, as appropriate.


Step 5 - The verification process failed

First 4 steps always passed but I have a problem with 5 step. I Had this error

And I spent a lot of time to resolve it but without any results. It is my first experience with pact. If you need more information please text me I will give it.

hi folks, this is a point in time workshop that pinned to an alpha version of the Pact .NET library.
The officially supported workshops are here: https://docs.pact.io/implementation_guides/workshops#pact-workshops---from-0-to-pact-in-2-hours
The latest version of Pact .NET is currently the 4.x.x (beta) line: https://github.com/pact-foundation/pact-net. You can download from Nuget directly. I'd use the examples in the pact net repository until this workshop can be updated to reflect the latest API which is approaching a major (stable) release.

Thanks for the answer!

Hi all I'm having the same error, when will v3 be ready?

You can upgrade to the latest beta version of PactNet and make changes to ProductTest.cs in the Provider solution like so, also make sure to remove pactnet.Native since it is no longer used.
  using PactNet.Verifier;

   /* rest of the code */
  pactVerifier
      .ServiceProvider("ProductService", new Uri(_pactServiceUri))
      .WithFileSource(pactFile)
      .WithProviderStateUrl(new Uri($"{_pactServiceUri}/provider-states"))
      .Verify();

You can upgrade to 4.0.0-beta.3 version of PactNet and make changes to ProductTest.cs in the Provider solution like so, also make sure to remove pactnet.Native since it is no longer used.
  using PactNet.Verifier;

   ...

  pactVerifier
      .ServiceProvider("ProductService", new Uri(_pactServiceUri))
      .WithFileSource(pactFile)
      .WithProviderStateUrl(new Uri($"{_pactServiceUri}/provider-states"))
      .Verify();

I cannot see PactNet v4.0.0-beta.3. The only version I see is 4.0.0-beta (already selected). Pack package source is already added to Visual Studio and I chose Package Source: All.

thanks, It worked.

This is an unofficial workshop and not the place for that question. Best to
check at https://github.com/pact-foundation/pact-net/ or ask in our
community workspace: slack.pact.io in the #pact-net channel
On Mon, May 9, 2022 at 10:28 PM culudamar @.***> wrote:

Hi all I'm having the same error, when will v3 be ready?
—
Reply to this email directly, view it on GitHub
https://github.com/DiUS/pact-workshop-dotnet-core-v3/issues/5#issuecomment-1121035848,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAANFDBT2DRH44HHCWTPZSDVJEAHNANCNFSM5SJZ24KA
.
You are receiving this because you commented.Message ID:
@.***>

--
Matt Fellows
www.onegeek.com.au
calendly.com/mfellows


Unable to get this to work on Internet Explorer 11

Describe the bug
Created a basic react application to use react-trello component, it works on all the browsers except for IE11.
We have also tried below pollyfills to get it work, but it didn't work.
import 'react-app-polyfill/ie11';
import 'react-app-polyfill/stable';
import 'core-js';
import 'es6-polyfill';
import "@babel/polyfill"
To Reproduce
Steps to reproduce the behavior:

Create a basic react application.
Use react-trello.
Run it and open it in IE11.

Expected behavior
It should render the react-trello UI.
Screenshots
Below is what we see on IE.

Desktop (please complete the following information):

OS: Windows 10
Browser: Internet Explorer
Version: 11

Hey,
We figured out what issue it was card component has .rXSjd which has flex-basis : 0 when we kept it as auto in our CSS it started working
.rXSjd {
flex-basis: auto !important;
}


ability to wrap content in SQL query editor

It would be helpful, if we can toggle "wrap contents" in the SQL Query editor. Currently now it's bit hard to keep scrolling horizontly.

I got this one


As a content editor, I need to add and edit partial dates for generic events so that I can record whatever portion of the date is available when the exact date is not known.

testing notes
In the admin view:

[x] On the generic Event list page, by sorting the list you should be able to see partial start and end dates
[x] In the edit/change view for an Event, you should now be able to create a generic event with logic for displaying the partial dates, but otherwise the same as before
[x] Borrow and Purchases should have partial dates that are viewable, editable, and function as before both in their list view and in their change view. Would suggest creating one or two of each and making sure functionality is as prior to these changes.
[x] Existing borrow and purchase events with partial dates should appear unchanged; suggest checking a few against production to confirm.
[x] Subscriptions and reimbursements should continue not to have partial dates and their dates should save and function as before. Again, would suggest creating one or two and making sure that fields save as anticipated.

development notes

need database migrations to do the following:

add partial date precision field for start/end dates on the base Event class with different names than used on Borrow and Purchase
populate new partial date precision fields on Event from existing values on Borrow and Purchase
remove partial date precision fields on Borrow and Purchase
rename partial date precision fields on Event (probably by refactoring to use PartialDateMixin)

after this, borrow and purchase event list and edit should work as before with no data lost
configure generic Event admin list and edit to use partial dates - should work exactly the same as borrows and purchases, but dates should still work and display correctly for subscriptions and reimbursements

Can we have this done as soon as possible? It's holding Sylvie up with non-standard borrows. Thank you!!

This looks awesome! Thanks!!


Update architecture section to help troubleshooting and explain subsystems more

Is your request for enhancement related to a problem? Please describe.
When doing troubleshooting with users the architecture and ports and network flow and where logs are written is useful to share with them to help diagnose
Describe the solution you'd like
Create a new section in the docs to explain the architecture in more detail with the network traffic and logs to help diagnosis of problems
Related doc pages
Additional context

Duplicate of #737 . Closing this one.


Docker: Move console dirs to /usr/share/prometheus

Fixes #1845. Used symlinks as suggested by @brian-brazil in https://github.com/prometheus/prometheus/issues/1845#issuecomment-235857299. This works nicely for me, not having to change flags when bind mounting config dir over /etc/prometheus, while at the same time retaining backwards compatibility.

LGTM

Thank you both 👍


Bourbon example?

Sometimes this webpack setup can get a little over my head :p
I was wondering if anyone can show me an example of how to add node-bourbon? Or any sass mixin library for that matter. Thanks!

Closing this because I'm probably dont have the time to do this 😢


Hotfix/45 team leads latest requested changes

Made previously requested changes and added both admin side menu and header.

Please show me a screenshot since It does on my screen


Build is failing on Linux GPU

Hi,
I'm trying with no luck to build TF for OpenCL from source. I configured a new installed machine as is described in your guide but the build is failing.
I'm launching the build through this command:
bazel build -c opt --config=sycl //tensorflow/tools/pip_package:build_pip_package
And below you can find all the requested informations from my OS. In attach you'll find the Errors the compiler shows me.
I've tryed also to build with clang against GCC/G++ with no luck.
Errors TF.txt
Thank you

Operating System: Ubuntu 16.04, Kernel 4.4
Building TF for OpenCL as descripted in ./configure below:
`$ ./configure
Please specify the location of python. [Default is /usr/bin/python]: /usr/bin/python3
Please specify optimization flags to use during compilation [Default is -march=native]:
Do you wish to use jemalloc as the malloc implementation? [Y/n]
jemalloc enabled
Do you wish to build TensorFlow with Google Cloud Platform support? [y/N]
No Google Cloud Platform support will be enabled for TensorFlow
Do you wish to build TensorFlow with Hadoop File System support? [y/N]
No Hadoop File System support will be enabled for TensorFlow
Do you wish to build TensorFlow with the XLA just-in-time compiler (experimental)? [y/N]
No XLA support will be enabled for TensorFlow
Found possible Python library paths:
/usr/local/lib/python3.5/dist-packages
/usr/lib/python3/dist-packages
Please input the desired Python library path to use.  Default is [/usr/local/lib/python3.5/dist-packages]
Using python library path: /usr/local/lib/python3.5/dist-packages
Do you wish to build TensorFlow with OpenCL support? [y/N] y
OpenCL support will be enabled for TensorFlow
Do you wish to build TensorFlow with CUDA support? [y/N] n
No CUDA support will be enabled for TensorFlow
Please specify which C++ compiler should be used as the host C++ compiler. [Default is ]: /usr/bin/g++
Please specify which C compiler should be used as the host C compiler. [Default is ]: /usr/bin/gcc
Please specify the location where ComputeCpp for SYCL 1.2 is installed. [Default is /usr/local/computecpp]: `
$ bazel version Build label: 0.4.3 Build target: bazel-out/local-fastbuild/bin/src/main/java/com/google/devtools/build/lib/bazel/BazelServer_deploy.jar Build time: Thu Dec 22 12:31:25 2016<PHONE_NUMBER>) Build timestamp:<PHONE_NUMBER> Build timestamp as int:<PHONE_NUMBER>
$ git rev-parse HEAD a12c7dc3d83049e10c1dca8903d73cc71d3cb7b2

@gunan we don't support opencl, right?

https://github.com/tensorflow/tensorflow/blob/master/tensorflow/g3doc/get_started/os_setup.md
It is your guide that tells me to do so.

We should update our guide, sorry for the confusion.
OpenCL support is still in its early stages, and it is experimental:
You can follow this issue for more information:
https://github.com/tensorflow/tensorflow/issues/22

@lorenzo93 Does it compile without --config=sycl? It seems like the compilation error comes from GCC6 headers.

I'll test it tomorrow night and reply. I'm out for work
2017-01-26 12:27 GMT+01:00 Luke Iwanski<EMAIL_ADDRESS>
@lorenzo93 https://github.com/lorenzo93 Does it compile without
--config=sycl? It seems like the compilation error comes from GCC6
headers.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensorflow/issues/7056#issuecomment-275366718,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALtNaqaGWdf4xA3dc2hDqB1sbIfru5W1ks5rWIMZgaJpZM4LtYNV
.

I have the same issue, so I thought that I'll drop it here instead of creating a new one. Compiling TF with --config=syscl throws an error:
ERROR: /home/danielius/.cache/bazel/_bazel_danielius/c3436072caa9f5957dc8575117a2d1e5/external/llvm/BUILD:1661:1: C++ compilation of rule '@llvm//:support' failed: computecpp failed: error executing command external/local_config_sycl/crosstool/computecpp -Wall -msse3 -g0 -O2 -DNDEBUG '-std=c++11' -MD -MF ... (remaining 38 argument(s) skipped): com.google.devtools.build.lib.shell.BadExitStatusException: Process exited with status 1.
external/llvm/lib/Support/RandomNumberGenerator.cpp:34:8: error: reference to 'cl' is ambiguous
 static cl::opt<unsigned long long>
        ^
In file included from ./bazel-out/local_linux-opt/bin/external/llvm/_objs/support/external/llvm/lib/Support/RandomNumberGenerator.pic.sycl:13:0,
                 from <command-line>:0:
external/local_config_sycl/crosstool/../sycl/include/SYCL/predefines.h:88:14: note: candidates are: namespace cl { }
 namespace cl {
              ^
In file included from external/llvm/lib/Support/RandomNumberGenerator.cpp:17:0:
external/llvm/include/llvm/Support/CommandLine.h:48:14: note:                 namespace llvm::cl { }
 namespace cl {
              ^
external/llvm/lib/Support/RandomNumberGenerator.cpp:34:8: error: 'cl' does not name a type
 static cl::opt<unsigned long long>
        ^
external/llvm/lib/Support/RandomNumberGenerator.cpp: In constructor 'llvm::RandomNumberGenerator::RandomNumberGenerator(llvm::StringRef)':
external/llvm/lib/Support/RandomNumberGenerator.cpp:51:13: error: 'Seed' was not declared in this scope
   Data[0] = Seed;
             ^
Target //tensorflow/tools/pip_package:build_pip_package failed to build
Use --verbose_failures to see the command lines of failed build steps.
INFO: Elapsed time: 73.376s, Critical Path: 68.71s

Compiling without --config=syscl works fine.
System information:

Ubuntu 14.04 64bit
Intel Haswell Mobile graphics / Radeon 8800M

Maybe two graphics cards might be an issue?

@lorenzo93 The GCC 6 STL headers exposed a bug in clang 3.6, which has been fixed upstream and will soon be merged into computecpp. Until then, it is possible to work around this by either using the GCC5 headers or libc++ (https://llvm.org/bugs/show_bug.cgi?id=24770)

thanks @lukeiwanski -- very helpful!


Support for F# project files?

Hi,
I tried running Covenant on a solution that contains F# projects and it successfully generated a report, but when I tried running it directly against an fsproj file I got
SBOM was not created since no components could be found

I had a go at making it recognize .fsproj project files in https://github.com/patriksvensson/covenant/compare/main...Numpsy:covenant:fsproj and it appeared to work, so - is that something you'd be interested in supporting?
Thanks

@Numpsy Absolutely

Ok, I tried running the 0.15.2-preview.2 build in my CI build, and that's reporting on my F# projects ok now, thanks


team_scores endpoint bug

Description

Checklist

[ ] If code changes were made, they have been tested
[ ] This PR fixes an issue
[ ] This PR is not a code change (ie. documentation, typehinting, comments, etc.)

Originally posted by @camelwater in https://github.com/BadWolf1023/MKW-Table-Bot/pull/170
Bug introduced in the above PR. Not ever call of api_channelbot_interface.get_team_score_data was updated to work with the new method signature, breaking the sort_teams parameter in the team_scores endpoint.

Fixed with https://github.com/BadWolf1023/MKW-Table-Bot/commit/4173a88d220afdb0007bbc984a89870b53a3c103


Base Craggy Exterior pierces Spell Immunity

Reported by Hullupuru:

Summary: The base stun from Tiny's Craggy Exterior pierces Spell Immunity
Steps to reproduce: 1. Create Tiny Bot and lvl Craggy
2. Activate BKB
3. Hit Tiny
Expected Result: No Stuns
Actual Result: Stunned
Note: The Craggy Avalanche talent isn't piercing BKB.

https://cdn.discordapp.com/attachments/317271861966929921/318918125649133569/very_craggy.png

I think i fixed it
feb9b9669536277ed52de8fd5e116fe531c937ae


Ma/appbundle and move

Rework chef-server-ctl.
This makes it a gem, appbundles it, and moves it to the src directory alongside the habitat stuff. Previously we were letting the dependencies float free, and that breaks when we upgrade other gems.
This is built on #1513, and will replace it if it goes smoothly.
Will squash this up for final merge.

oc_erchef is failing in ct. I'm still merging this since master (a5b55c864411fcaea21b7da3fd5646e6c8db306a)  has the same issue, and is broken in other ways that this fixes.


Destination certificate type should be checked (or at least catch the error to describe how to address)

I was getting a strange error when using the current master of the ssl cert import tool.
DerInputStream.getLength(): lengthTag=109, too big.
It took a couple hours of searching to identify that the keystore in my Ubuntu instance (that has been upgraded many many times) still had the JKS format. Not sure if this really requires any code change to address as a keytool command to change the keystore from JKS to pkcs12 worked like a charm.
It could be worth looking at determining if the format of the destination keystore is JKS if that length=109 exception is thrown and doing the conversion automatically or at least suggesting verifying the keystore format in the output.

I too would be interested if there is an automated fix for this.  I tried using the keytool manually but ended up with password questions I could not answer so my only choice was to roll back my controller to a backup to get it back online.   Thank you in advance.


source-git update-dist-git: mandatory commit message

When update-dist-git was added we decided it's fine to run the command without -m nor -F and that it means "don't commit the change". The user was in that case supposed to do git diff, verify the change, and then do git commit themselves.
Since we added the git trailers later in fed17ae2 the no-commit use case is questionable because in that case the user would need to add the From-source-git-commit git trailer themselves into the git commit and that's very error-prone as one can very easily forget about it and then the history would be considered diverged by packit.
There are AFAICT two ways how to approach this:

if neither -m nor -F is specified, open a default editor to create the commit message there (and if an empty text is provided, raise an exception)
(if the previous way is not feasible for some reason) make -m/--message or -F/--file mandatory

Hello all,
as part of a backlog cleanup, we are closing source-git-related issues because it is not our priority anymore and if we were to change the priorities, the whole source-git project would need to be revisited nevertheless.
A more detailed description of why have come up with this can be found at https://packit.dev/source-git/status (most of this is still relevant), TLDR is that we can provide more benefits in other areas.
What now:

The service part is currently being decommissioned for no real use. (It even was offline for a couple of weeks because of a certificate issue and no one realised.)
The CLI is still there, but the Packit team won't work on these tasks. We are happy to help and accept any external contribution.
If you find something really, really important and can't do it yourself, let us know. We might still find a way but we would need to be really sure that our time spent on this is worth the benefit.

Our current priorities are visible on our board (revisited quarterly) and are based on user benefit and demand. (=> You can influence that..;)
František


call extension method passes analyzer but sometimes fails webdev compile with "Error: 'X' isn't a function or method and can't be invoked."

See dartpad gist: https://dartpad.dev/77e0390e003bf936c4ca0b82664ded0b
At time of writing, this is running on 2.7.1
import 'dart:async';

void main() {
  var ctl = StreamController<String>();
  ctl.stream((s) {
    print(s);
  });
}

extension TerseListen<T> on Stream<T> {
  StreamSubscription<T> call(Function onData) {
    return listen((d) {
      onData(d);
    });
  }
}

Error compiling to JavaScript:
main.dart:5:7:
Error: 'stream' isn't a function or method and can't be invoked.
  ctl.stream((s) {
      ^
Error: Compilation failed.

Interestingly, using call as an extension method does work on other simple cases. I haven't been able to figure out what makes Stream special. For example below works
void main() {
  var t = Test();
  t();
}

class Test {}

extension TestExt on Test {
  void call() {
    print('foo');
  }
}

@eernstg @lrhn - what's the right behavior here?

Invocation syntax (like o(f)) on an object (here o) whose static type matches the on type of an extension that declares a call method should invoke call.
But in this particular case we have the syntax ctl.stream((s) {...}), and that parses as ctl followed by two <selector>s, namely stream and ((s) {...}).
The language specification indicates that this syntax must be considered to be an instance method invocation, not a expression (ctl.stream) evaluating to a function object, which is then called with the given argument list.
So, to be safe, the desired invocation via call should be ensured by parenthesizing: (ctl.stream)((s) {...}).
However, the question remains whether there is some way to argue that the tools must discover the way over call even without the parentheses. It seems useful, since we'd replace an error by a meaningful behavior, so why shouldn't we just avoid reporting that error?
(...taking another look at the rules now... ;-)

I would want this to work, and I think the specification says that it should.
More precisely, the design document for extension methods says that it should work.
This is supported by the current language specification, under "unconditional ordinary method invocation" in the specification, which says:
If the getter lookup succeeded then invoke the getter $o.m$
and let $v_g$ be the returned object.
Then the value of $i$ is the value of

\code{$v_g$<$A_1, \ldots,\ A_r$>($a_1,\ \ldots,\ a_n,\ x_{n+1}$: $a_{n+1},\ \ldots,\ x_{n+k}$: $a_{n+k}$)}.

That is: The meaning of ctl.stream(...) is defined to be the value of x(...) where x is the value of ctl.stream, and the value of x(...) would invoke the extension method.
So, both sources agree, this is a bug in the implementation.

As of https://github.com/dart-lang/language/commit/9c7279b5d78622adac91b34c9d43da33ce13a354, the language specification handles the case where e.m(...) finds that e.m is a getter that returns a callable object. This is already consistent with the specification of the dynamic semantics, and it is implemented by both the vm and dart2js and accepted as a valid construct by the analyzer, so there is no need to consider this to be a breaking change.
The ability to invoke an extension method named call based on the same syntax e.m(...) is then already covered by the static extension method specification.


feat(overlay-directives): support setting panelClass

Adds the ability for customizing the panelClass of overlay.

Commit message to be changed to feat(overlay): support setting panelClass on cdkConnectedOverlay.

@crisbeto It seems like my attempt for changing the commit message end up with adding another commit. Is it ok?

Yeah it's fine, otherwise the person merging it in can change it.


[Feature Suggestion] Built-in Vanilla Command Permission Nodes

What Will It Do?
It will allow for users to have Vanilla command limiters if they so desire to have them.
Why This Would Be Awesomesauce:
Because all the plugins that have vanilla permission nodes are super convoluted or just flat out don't work, and having them built into the permissions plugin itself would be nice for just limiting the vanilla permissions without needing to get an extra 12 million commands from some stupid other plugin.
How Would It Work:
Just have like permissify.vanilla.<COMMAND>.[Sub Command] or something like that and Permissify reads it.

Great idea 👍

I've decided that this is something that would bloat the plugin too much, closing.


Update version

After fixing #6, can you release a new version?

Version has been bumped to 4.0.1, thanks for the reminder.

Hello, tried your plugin with the latest cordova version 6.x, its not working with iOS build. if possible please update.
Thanks

I am no longer actively updating this plugin, but if you can create a fix and submit a pull request I will merge it.

Hi, I am using your cordova-print-pdf-plugin. i have added
<gap:plugin name="com.sgoldm.plugin.printPDF"/>  as in my config.xml, but when i am uploading the build into phonegap, it shows error  plugin unsupported: com.sgoldm.plugin.printpdf.
please help me

@saagarbethi  try cordova-plugin-print-pdf

@saagarbethi The plugin name is "cordova-plugin-print-pdf". Hope that works.


Enter key does not confirm and close the Add torrent(s) dialog

When the Add torrent(s) dialog pops up and everything's ok, I think simply hitting the Enter key should confirm adding the torrent and close the dialog (no matter what element is focused at that moment).

I was thinking about suggesting to just put focus on the OK button as you now have implemented (that was fast!), but I thought that if you maybe decides to implement labels + linked download folder specifications (see https://github.com/picotorrent/picotorrent/issues/531), then it would make more sense to focus the drop-down list of the labels and pressing Enter after selection would also confirm and close the dialog. That's why I said "(no matter what element is focused at that moment)".

Yes, when presets are implemented we can revisit this and see how we can improve usability 😄 Right now the OK button is only the default.


Add dedentNextLinePattern to complement indentNextLinePattern

Issue Type: Feature Request
I was recently working on improving the Erlang LS language configuration, and stumbled upon the various indentation rules patterns.
However I couldn't quiet get it to behave. The issue is that in Erlang you want to dedent on the line after ; and ., and not the line itelf.
map(_, [], Result) ->
    lists:reverse(Result);
map(Fun, [Head|Tail], Accumulator) ->
    map(Fun, Tail, [Fun(Head)|Accumulator]).

func() ->
    case Something of
        pattern ->
            foo(),
            bar(); % <- I want to dedent after this...
    end. % ...which would make `end` dendent correctly. Then dedent again after `.`

I saw https://github.com/microsoft/vscode/issues/17868 which lead me to indentNextLinePattern, but as stated there there's a difference between increase and decrease patterns. The first applies after the second directly.
I also saw https://github.com/microsoft/vscode/issues/34621 amongst others, but that's far of into the future I believe. LSP also contain formatting, so maybe the truly future way :tm: is to do something there. But I digress. Right now I just want to be able to tweak the exisitng language configuration to be able to handle a bit more :smile:
Note: Not all pattern types are documented, filed an issue for that as well.
VS Code version: Code 1.53.2 (622cb03f7e070a9670c94bae1a45d78d7181fbd4, 2021-02-11T11:45:54.515Z)
OS version: Darwin x64 20.2.0

What you could use instead is onEnterRules. This snippet for example unindents after pressing enter as long as it matches the regex patterns given (in this case, after a break statement).
"onEnterRules": [
	{
		"beforeText": "^\\s*break;?$",
		"action": { "indent": "outdent" }
	}
]

If you want to take the previous line into account, there's previousLineText too.

Aha, cool. I thought they were just in the imperative API, but saw #114348 and #114948 now. Will take it for a spin. This is also not documented at the moment, but that's a separate issue.
Iff you can accomplish the above with onEnterRules alone, I guess it's just a matter of documentation. On one hand it would be nice to have this for symmetry. On the other it might be easier to understand onEnterRules and the others could (should?) be deprecated,  perhaps just in the docs. So many questions, but not too many answers I'm afraid.

I got most of what I wanted out of the onEnterRules, so I'm going to close this. I think it's just a matter of documentation at this point. Thanks for the awesome work and making such a nice editor ❤


Support for 1964GEPD Emulator save files

Hi there, I would love to use this software to transfer my save files from the 1964GEPD emulator to the PC port, but whenever I try uploading my save data it always says it's not a perfect dark save file. I'm not sure if I'm grabbing the wrong file or if it just isn't supported.
If it isn't supported, I'd love for this software to be updated to support it.
Thank you!

Not sure if I should close this issue because of this but I found a workaround. But,
If I use the program N64SaveConverter and convert the save data in 1964GEPD to retroarch, then back to .eep, I'm able to open it up with this program.

Hi, I'm glad you found a solution!
I took a look at the issue, and turns out that the format is correct, it's just that 1964 adds 2kb extra padding to the save file, making it 4kb in total. The save should be 2kb total. So another solution would have been just remove the last 2kb of bytes with an hex editor.
The file size check the program does is one of the checks to make sure the user is opening a valid Perfect Dark save, and not from another game or format, to prevent crashes.


docs(fix): reorganized usage guide for new users

Reorganized the docs usage page to try to make the installation process more clear for beginner users.

Codecov Report

Merging #3325 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3325   +/-   ##
=======================================
  Coverage   99.89%   99.89%
=======================================
  Files         170      170
  Lines        2801     2801
=======================================
  Hits         2798     2798
  Misses          3        3

Impacted Files
Coverage Δ

src/modules/Dimmer/DimmerInner.js
100% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93c918b...2c1dcff. Read the comment docs.

Thanks for starting up this work!  This page was getting quite cluttered and overwhelming.
I've reworked it a bit to use simplified language and tabs to clean it up:


Update example

Fixes https://github.com/dart-lang/dart-docker/issues/4
Some tweaks to the example/examples:

Remove the Functions example (I'd like if we kept this repo very foundational, and not pointing to a single Cloud product
Update the Dockerfile steps as discussed in https://github.com/dart-lang/dart-docker/issues/4
Add the sample app rather than call the generator (allows for browsing the sample code directly in github)
Add a readme with instructions

Abandoning; will work on adding similar content to dart create, and created a new PR for updating README: https://github.com/dart-lang/dart-docker/pull/10


deps: bump sigs.k8s.io/karpenter to v0.33.5

Fixes #N/A
Description
How was this change tested?
Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[x] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.02%) to 82.621%

Files with Coverage Reduction
New Missed Lines
%

pkg/providers/amifamily/ami.go
1
90.43%

Totals

Change from base Build<PHONE_NUMBER>:
-0.02%

Covered Lines:
5006

Relevant Lines:
6059

💛  - Coveralls


Interaction Manager doesn't adhere to hitArea after the latest commit

Interaction Manager doesn't adhere to hitArea after the latest commit.
Should line 402 be of the interaction manager (9a722a4) be?
if(hitTest && !hit || hitTest && displayObject.hitArea)

Hey @stephenweaver will take a look into the issue today, do you have a small fiddle demonstrating the issue? thanks!

@GoodBoyDigital Sure, I can make one. Is there an updated pixi.js file I can reference? The one in the bin folder is kinda old.

Thanks man! I just published the pixi flles on the dev branch, so you should be able to use them now.

Am I looking in the right spot?

try again, sorry my push failed!
On Wed, Dec 9, 2015 at 9:14 PM, stephenweaver<EMAIL_ADDRESS>wrote:

Am I looking in the right spot?
[image: devbin]
https://cloud.githubusercontent.com/assets/5230027/11699014/ee4c2fd0-9e8f-11e5-98db-bc3f16c849a3.PNG
—
Reply to this email directly or view it on GitHub
https://github.com/pixijs/pixi.js/issues/2228#issuecomment-163393684.

--
Mat Groves
Technical Partner
Telephone: 07708 114496 :: www.goodboydigital.com
First Floor, Unit 9B, Queens Yard, White Post Lane, London, E9 5EN
goodboy©. All Rights Reserved.

Sorry for delay, had some work I had to get done. https://jsfiddle.net/59tchdfj/

all fixed! :+1:
Setting a hitArea no longer checks the children (unless it has interactive children..)
Thanks for the fiddle man, made it really easy to debug :)

Thank you


Add GraphQL mutation to upgrade a Deployment

A GraphQL mutation should exist to upgrade an existing Deployment, i.e. upgrading the deployed app release to a newer release of the same app.
Running the mutation should result in the appropriate communication with the device so that the previous release is removed from the application deployments and the new release is present.

closed by #728


Improve the readability of post-installation test results

Test results will be displayed in green, red, and yellow to indicate success, failure, and skipped, respectively.
Show the total number of success, failure, and skipped tests in the end.
Return error if any test fails. Otherwise, it would be hard for automation tools to detect whether the check succeeds or not.

Example of success:

Example of failure:

cc @kanha-gupta

/skip-all


Cert revoked on latest Win11 version.

Hey,
Just letting you and others know that if you encounter error 0x800B010C, it means you're on the version of windows where the cert has been revoked.

To be clear, the cert itself is not revoked. It is a fake status code returned by the vulnerable driver block feature introduced in the ealier version of Windows 10 and 11.

To be clear, the cert itself is not revoked. It is a fake status code returned by the vulnerable driver block feature introduced in the ealier version of Windows 10 and 11.

I have that disabled. It has been revoked.
It's just that the CRL wasn't checked or enabled by default till Windows 11 22H2.
Windows 11 22H2 enables checking by default, and you can alter it [as shown here.](https://learn.microsoft.com/en-us/windows/security/threat-protection/windows-defender-application-control/microsoft-recommended-driver-block-rules)


Compiler (0.19.0) does not notice if module hides previously exported variable

Start with a project with the following files:
elm.json (nothing special, just a package exposing ModuleA)

{
    "type": "package",
    "name": "sscce/sscce",
    "summary": "sscce",
    "license": "BSD-3-Clause",
    "version": "1.0.0",
    "exposed-modules": ["ModuleA"],
    "elm-version": "0.19.0 <= v < 0.20.0",
    "dependencies": {
        "elm/core": "1.0.0 <= v < 2.0.0"
    },
    "test-dependencies": {}
}

src/ModuleA.elm

module ModuleA exposing (a)

import ModuleB

a = ModuleB.b

src/ModuleB.elm

module ModuleB exposing (b, dummy)

b = ()
dummy = ()

Compile with elm make. It should succeed.
Next, remove b from the exposing list of ModuleB.
Compile again, and it succeeds (!).
Remove elm-stuff and now compilation fails as expected, complaining that ModuleB does not expose b.

I am not able to reproduce this with Elm 0.19.0 on my computer.
There are some improvements in the development branch of the compiler to catch cases like this though. https://github.com/elm/compiler/issues/1956 has an SSCCE that was broken with 0.19.0 and fixed with the development build.
If you can reproduce your case with 0.19.0, let me know. I am seeing that it works with 0.19.0 and the development branch (which should be better with this kind of case anyway!) so we should close if it cannot be reproduced.

I was able to reproduce the error with a slight modification to the instructions. Once you have the files set up, you need to do:
$ elm make
Success! Compiled 2 modules.

# tweak src/ModuleB.elm

$ elm make src/ModuleB.elm
Success! Compiled 1 module.
$ elm make
Success!

You may have an editor plugin that runs elm make PATH on save which made it unnecessary to run that command by hand.

Anyway, a similar bug was reported in https://github.com/elm/compiler/issues/1956 and fixed in the development build of the compiler. Using the dev build, I am now seeing the following if I try with your SSCCE:
$ ./elm make
Success! Compiled 2 modules.

# tweak src/ModuleB.elm

$ ./elm make src/ModuleB.elm
Success! Compiled 1 module.
$ ./elm make
Detected problems in 1 module.
-- NAMING ERROR ------------------------------------------------ src/ModuleA.elm

I cannot find a `ModuleB.b` variable:

5| a = ModuleB.b
       ^^^^^^^^^
The `ModuleB` module does not expose a `b` variable. These names seem close
though:

    ModuleB.dummy
    modBy
    round
    toFloat

Hint: Read <https://elm-lang.org/0.19.1/imports> to see how `import`
declarations work in Elm.

So it looks like it is fixed in the development version! Thank you for reporting this, and the fix should be available along with a bunch of other improvements once 0.19.1 is released.


bug: takt fails to do the first check in from scratch.

takt fails to do the first check in from scratch.
From a clean installation and first use scenario, I did
takt check

which raised
FileNotFoundError: [Errno 2] No such file or directory: '/Users/username/.takt_file.csv'

To go around the issue, I created the file with touch
touch /Users/username/.takt_file.csv

and run takt again, getting the following issue
EmptyDataError: No columns to parse from file

use last commit from master and let me know if the problem persists ;-)


Value not being returned on flutter app.

Describe the bug
Query works on playground but not on Flutter.  I expected it to return an empty [ ] for the services field.  On the playground/postman the query returns the correct value.  Using the same query in flutter does not work.  The services fields are not even defined in the result when I print to console.
    final String businessQuery = """       query {         businesses{           name           phone           description           pictures {             url           }           employees {             name             avatar {               url             }           }           services {             name             description             price_min             price_max             duration           }         }       }     """;
Expected behavior
I was expecting to get the same result as the GraphQL playground/postman result.

Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: Mac OS
graphql_flutter:
dependency: "direct main"
description:
name: graphql_flutter
url: "https://pub.dartlang.org"
source: hosted
version: "3.0.1"

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

I have no idea what the issue here could be. My best guess is that services is an authenticated field or something. I seriously doubt we have a json parsing bug in the library or something like that

closing as again this doesn't look like an issue with graphql_flutter. I recommend coming by the discord #support channel for more help if need be


Adds missing changelog entries

We really should get in the habit of doing this in the PR's themselves, so we reference the PR author and number in the changelog correctly. So i've had to improvise in this scenario.
Thanks @acao

yes we added the action but it didnt work retroactively
the issue with this PR is that there are package bumps. We just need the two md files. i can just re-create it after work!

also, this was for #1776 and #1768. I can just redo this, my goal was just to create the two MD files sorry!


Code suggestion

Nice library! Seeing that you maintain the HTTP logic yourself, I was wondering whether you know about Refit?
It is a library that generates HTTP client logic for you based upon interfaces that you write, which means that you need to spend less time and attention to maintaining that part.

Good idea and noted for feature , thanks!


npm run migrate issue?

Having an issue with the initial setup and configuration of the MAGE server. I'm able to get all of the dependencies installed and if I skip the npm run migrate and go straight to npm build run and then node app.js I get the setup page to establish an initial account (although this part does fail).
I've attached the npm-debug.log file here.
npm-debug.log

Also forgot to mention that I'm trying to run this locally on a MacBook Pro running High Sierra.

@toddk sorry about that.  There is typo README that pointed to an old version of the server.
Substitute  with the latest release, which in this case is 4.5.2
https://github.com/ngageoint/mage-server#running-mage
There was a bug introduced in one of our dependencies in 4.4.3 that caused a bug with migrate.

Thanks, that solved it for me!


Fix correctness mistakes

if there are no objections i'll merge this soon....

if there are no objections i'll merge this soon....

added a few comments, but didn't go through everything

That is it.

@gf712 squash'n'merge?


chore: Bump EUI version

Summary
Upgrades EUI v52 to v55.
Implementation details
No material code changes.
How to validate this change
Look for UI-related defects.

:green_heart: Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2022-04-25T17:56:33.804+0000

Duration: 15 min 17 sec

:robot: GitHub comments
To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.


Platform specific configuration for operator

Each platform has some amount of customization required with their installation.
It is unclear what approach is ideal to support these types of customization.
@houshengbo kindly documented some of the thoughts on this topic in this doc.
https://docs.google.com/document/d/1OtlkJ8whTgHYTz5rz0lq5mNdDGK_pakG/edit

To add to this, we have 4 additional customizations that we'd need (I can open separate issues for each if needed):
1 - static data update of Kn config maps.  We modify the Kn configuration configMaps with static values - meaning we know them in advance of even starting the install process
2 - dynamic data update of Kn config maps. We modify the Kn configuaration configMaps with data that is specific to the cluster but can be retrieved via a normal kubectl get operation. So the data is within the cluster itself. The concrete example for this is we query another configMap to get the domain name.
3 - additional resource processing. We install some other resources as part of the Kn install. Abstractly, this can be thought of as just doing kubectl apply with a custom yaml file. In our case, we are creating an additional istio ingress.
4 - operator dependencies. We have the need to install/process other operators that our Kn one will need. For example, we require istio. So it would be good if the Kn operator install process also installed/managed the Istio operator.

5 - need to be able to have all of the images get pulled from private registries


licence

This is an elegant piece of work!
Please could you add a licence so that I and others might reuse it.

Done!

p.s. I just knocked this up very quickly for a toy project - I'm sure it has lots of bugs, and I may well make breaking changes at any point, so don't rely on it for anything important!


Pelican in production Docker image has the wrong version number

From @brianhlin, if you run the version command inside the production Docker container, you'll get:
[root@hostname pelican]# ./osdf-client --version
Version: 7.4.1-next
Build Date: 2024-01-10T22:48:53Z
Build Commit: 3caae35f06cd96ae97c2afca51a470b98c060010
Built By: goreleaser

while the tag this container was built for was 7.4.0.
This is because we use --snapshot flag when running goreleaser in the production image build. We should remove this flag to ensure the version matches git tag for production build.

It seems that there was something wrong with my fix, as this issue still exists in the 7.5.4 container:
sh-4.4# ./osdf-client --version
Version: 7.5.5-next
Build Date: 2024-02-09T14:45:28Z
Build Commit: 71053e4b6852a7eda4422131d06fffcf8b0e981f
Built By: goreleaser

@haoming29 what's the Pelican dev policy for closing issues that have been fixed in main? Should they be closed as PRs are merged or do we leave the issues open until there's been a release with the fix?

@haoming29 what's the Pelican dev policy for closing issues that have been fixed in main? Should they be closed as PRs are merged or do we leave the issues open until there's been a release with the fix?

We link the issue with the PR, so it closes when the PR is merged in. This one is special because we re-opened it after the initial fix, but I think we should be good to close this one now.


Status gui branch

Add GUI splitpane for note leaving status that @Btaykb is implementing.
Warning:
addressbook.json has been altered so it needs to be changed else it cannot be loaded. Find example implementation in
src/test/data/JsonSerializableAddressBookTest/typicalPersonsAddressBook.json
Justification:
Need to leave a note for person in status. Troublesome to write long note for each person especially if notes are similar. Therefore, allow storing status and giving same status for different people.
I think have some inkling of requirements but @Btaykb can change if want.
Requirements:
Add status to right pane.
Delete status from right pane. (when delete status, reset status of all persons who have that status?)
Add existing status in right pane to person stored in left pane.
Remove ability to add status to person directly.
Edit status (Optional)
Store status within each person but does not display in left pane.
Find on right pane using findstatus command.

List all status: liststatus
Show a list of all statuses in ModuleMate Finder.
Format: liststatus
Find a person's status: findstatus
Finds a person's status.
Format: findstatus INDEX
Format: findstatus INDEX s/STATUS

Finds a status for the person at specified INDEX
INDEX must be a positive integer 1, 2, 3, ...

Examples:

findstatus 1 finds the status of the 1st person in ModuleMate Finder.
findstatus 2 finds the status of the 2nd person in ModuleMate Finder.

Codecov Report

Merging #79 (77e3bad) into master (36ad9bc) will decrease coverage by 3.84%.
The diff coverage is 28.48%.

@@             Coverage Diff              @@
##             master      #79      +/-   ##
============================================
- Coverage     70.55%   66.70%   -3.85%
- Complexity      510      521      +11
============================================
  Files            85       92       +7
  Lines          1664     1805     +141
  Branches        190      206      +16
============================================
+ Hits           1174     1204      +30
- Misses          425      527     +102
- Partials         65       74       +9

Impacted Files
Coverage Δ

src/main/java/seedu/address/MainApp.java
0.00% <ø> (ø)

...rc/main/java/seedu/address/logic/LogicManager.java
71.42% <0.00%> (-3.58%)
:arrow_down:

...eedu/address/logic/commands/FindStatusCommand.java
0.00% <0.00%> (ø)

...java/seedu/address/logic/commands/ListCommand.java
100.00% <ø> (ø)

...eedu/address/logic/commands/ListStatusCommand.java
0.00% <0.00%> (ø)

.../seedu/address/logic/parser/AddressBookParser.java
64.00% <0.00%> (-5.57%)
:arrow_down:

.../address/logic/parser/FindStatusCommandParser.java
0.00% <0.00%> (ø)

src/main/java/seedu/address/ui/MainWindow.java
0.00% <0.00%> (ø)

src/main/java/seedu/address/ui/PersonCard.java
0.00% <ø> (ø)

src/main/java/seedu/address/ui/StatusCard.java
0.00% <0.00%> (ø)

... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36ad9bc...77e3bad. Read the comment docs.

Nice work on the second pane! Just for clarification, for your feature, will the comment now be added to the newly added separate list (right pane) instead of the usual one (left pane with all the contacts)?
Because the way I implemented my comment feature is basically like status (i.e an additional field) that can be added/removed from a contact and then be displayed under their name. Based on my understanding of your feature, I'm thinking for mine to work with yours, maybe the comment will need to be added to the newly added right pane instead of to the PersonCard in the left pane (as it currently is).

Nice work on the second pane! Just for clarification, for your feature, will the comment now be added to the newly added separate list (right pane) instead of the usual one (left pane with all the contacts)?
Because the way I implemented my comment feature is basically like status (i.e an additional field) that can be added/removed from a contact and then be displayed under their name. Based on my understanding of your feature, I'm thinking for mine to work with yours, maybe the comment will need to be added to the newly added right pane instead of to the PersonCard in the left pane (as it currently is).

I implemented comment as an attribute of status. I was imagining that you would have to add both "favourite" and "comment" to the panel on the right before you can add the combined status object to the left.
I don't think yours can work with mine just by adding to right pane since you kept comment as attribute of person. I think maybe just push yours first, it's easier to change from my side.
Maybe this makes sense as new requirements:
Justification: Annoying to type out comments repeatedly. Might repeat the same comment for different persons.
Requirements:
Save a comment on the right for future use.
savecomment c/COMMENT
Add comment from right pane to person on left pane.
addcomment INDEX INDEX
Add a comment to a person on the left.
addcomment INDEX c/COMMENT
Clear a comment from a person on the left.
clearcomment INDEX
Delete comment on the right.
List comment on right.
Find comment on right.


Command 'ps' required by nextflow to collect task metrics cannot be found

Hello,
I am using the singularity profile to run the pipeline with the following command:
nextflow run salzmanlab/readzs \     -r master \     -latest \     -profile singularity \     --runName "small_test_data" \     --input "https://raw.githubusercontent.com/salzmanlab/ReadZS/master/small_test_data/samplesheet.csv" \     --chr_lengths "https://raw.githubusercontent.com/salzmanlab/ReadZS/master/small_test_data/refs/chrLength.txt" \     --useChannels true \     --libType "10X" \     --isSICILIAN true \     --isCellranger false \     --metadata "https://raw.githubusercontent.com/salzmanlab/ReadZS/master/small_test_data/refs/meta.tsv" \     --minCellsPerWindowOnt 10 \     --minCtsPerCell 5 \     --ontologyCols "'compartment, tissue'" \     --annotation_bed "https://raw.githubusercontent.com/salzmanlab/ReadZS/master/small_test_data/refs/hg38.genes.bed" \     --gff small_test_data/refs/small.gff
During the CALL_PEAKS process I receive the following error:
Command 'ps' required by nextflow to collect task metrics cannot be found
From the Nextflow documentation here, the ps tool is required by Nextflow for certain tasks. Is it possible to add ps to the singularity profile?

Thanks Sarah! I'll add that to the container today.

Great, thank you. Please let me know when it's updated and I'll test it again.

Hi Sarah, apologies for the delays. The container should be up to date now, please let me know if there are any further issues

Hi Sarah, my apologies for the delay! I have updated the container to address the issue, please let me know if there are still container issues. Thanks!

Looks like the container issue resolved. Thanks!


Add Swift 2.0 compatibility

@kaishin I think we should change this to always have an image source. We won't ever be changing the image source in the animator since the AnimatableImageView creates a new one when you set a new image. I think this will simplify the Animator class as well.

@tonyd256 Mind taking a final look here? I added specs but haven't added CI yet.


refactor(freespace_planner): parameterize margin

Signed-off-by: Shumpei Wakabayashi<EMAIL_ADDRESS>PR Type

Improvement

Related Links

https://github.com/tier4/autoware_launch/pull/372
https://github.com/autowarefoundation/autoware.universe/pull/1190
Description

Add margin config param according to https://github.com/autowarefoundation/autoware.universe/pull/1190.
This reverts https://github.com/tier4/autoware_launch/pull/372 which is obsolete.
Review Procedure

Remarks

Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.

[x] Code follows coding guidelines
[x] Assign PR to reviewer

Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.

[ ] Commits are properly organized and messages are according to the guideline
[ ] Code follows coding guidelines
[ ] (Optional) Unit tests have been written for new behavior
[ ] PR title describes the changes

Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.

[ ] All open points are addressed and tracked via issues or tickets
[ ] Write release notes

CI Checks

Build and test for PR: Required to pass before the merge.
Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

@kenji-miyake Sorry for my impatience :bow:


Suggest promoter - send actions

link the modal form to either:

open the user client email to send an email, the content will be pre-filled from the form
open a github issue (similar to what done already on vfb).

@ddelpiano can you please specify the email to address, subject and body


Help setting up

I’m a youtuber looking to automate my uploads but i'm new to GitHub and pretty inexperienced with this kinda stuff. I installed Nodejs and ran the command “npm I youtube-videos-uploader”… but now I’m stuck. I tried running commands such as import, const, etc, in my command prompt but it keeps saying command not recognized. Again, forgive me if I sound stupid, I’m trying to figure all this out. If someone could help me set this up it would mean a ton!

I’m a youtuber looking to automate my uploads but i'm new to GitHub and pretty inexperienced with this kinda stuff. I installed Nodejs and ran the command “npm I youtube-videos-uploader”… but now I’m stuck. I tried running commands such as import, const, etc, in my command prompt but it keeps saying command not recognized. Again, forgive me if I sound stupid, I’m trying to figure all this out. If someone could help me set this up it would mean a ton!

did you find a way to run this script? can you tell me how to use this script?


a little bit more code clean

These code improvements / simplifications look good to me. I haven't tested, but after a code review it looks good to me. I'd suggest running the unit tests as well.


Handle domain socket host names

This PR makes pgo able to connect to unix domain sockets by using a domain socket path as the hostname.
If the host name looks like an absolute path or an abstract domain socket, pgo will now use {local, Socket} alongside port 0 to connect the postgres.
This is largely done in the same way as postgrex (https://github.com/elixir-ecto/postgrex/blob/5924c181da8c7991d51bd569eb26fa4cbf4f19ed/lib/postgrex/utils.ex#L102)
This PR should also solve #66

Going to merge this but would love some tests.


Create BUILD and INSTALL scripts

Simple shell scripts that automate the build and installation process. Nothing complicated since it's just a standard build of the C code, and installing should simply consist of copying the built executable over the ~/bin directory or wherever is most appropriate...

No need for a build script since to compile the code, the user can just run make. Install script should move executable to home directory's .bin and the man-page to the relevant area.


Duplicate Inclusion of jQuery

It appears that jQuery is being included twice - once as a dependency in WordPress when enqueuing the scripts in assets.php:
wp_enqueue_script('sage_js', asset_path('scripts/main.js'), ['jquery'], null, true);

Once in the Bower/Gulp workflow in the minified JS file, as evidenced by the sourcemap:
{"version":3,"sources":["../bower_components/jquery/dist/jquery.js"

The double-inclusion of jQuery not only introduces unnecessary overhead, but causes JavaScript breakage in other areas - most notably, Gravity Forms. Commenting out the first line of the generated main.js fixes the issue, but an upstream fix should be applied to prevent Gulp from pulling in jQuery in the asset build when reading the Bower dependency tree.

Fixed in https://github.com/roots/sage/pull/1501.
Please update and confirm it fixes it for you as well.

Just found this yesterday. Not naming names though.


Item qualities description disappears after enchant

Hello, i write you as you requested, images shows process when i try once again this bug. i found out that even if you put it to enchant everything but name disappear. No error in console. I know you wrote that it was fixed, i see that thats maybe not true or there is something else that make this bug.

Maybe i found what do that, plugin for stacking items. I think it can be fixed if we remove or turn false stacking of tools and weapons etc. that can have enchants.

Legit fixed this in 1.1.0, but hey, of course it works perfectly on my end but breaks for other people. Just how it goes, I guess. (totally not annoyed lol)
I'll see why this is happening.

I'm unable to recreate this. It is indeed functioning perfectly

.

unfortunately nothing helped, we will try use more methods to fix it, but i think it will be no use, something rewrites lore of item... and i dont know what. but thank you.


Further improvements on the application form

There is now no default resident/extern status. However, both the finalization pages and the radio button itself requires a selection.
Reworked the disclaimer for the Informatics workshop; the most notable change is that on the finalization page, it appears only for users who have indeed applied to the workshop.
Language exams can be deleted.
Other small changes.

Oh; I've missed that... I'll fix it. Thanks!

Done;)

Nice suggestions; thanks:) I've applied all of them.


Artificial feature generation

Feature branch: None
For the sake of this issue, artificial features are objects that are continuous in nature and directly adapt to the surrounding topology.
For finite objects, see #9
Many of these objects may be part of an area, see #10
Transport

[ ] Stepping stones: crossing shallow water
[ ] (essential) Paths: connecting points of interest (inspiration)
[ ] Canals: connecting bodies of water
[ ] Bridges: crossing ravines or deep water
[ ] Tunnels: connecting through mountains
[ ] Railways: transport of heavy goods for short distances
[ ] Secret tunnels between points of interest

Food, drink and health

[ ] Irrigation: channels connected to freshwater source (in rows spaced by 8 blocks)
[ ] Sewage: channels connecting houses to freshwater source
[ ] Crop field: monoculture farmland
[ ] Pasture: grassy plains for keeping livestock on farmland
[ ] Fencing: surrounding areas and dangers
[ ] Hot springs: on top of lava lakes?

Defence

[ ] Berms: under paths along steep terrain
[ ] Trenches/moats: surrounding fortified settlement
[ ] Flood wall: along riverbank for settlements prone to flooding
[ ] (essential) Palisades: surrounding settlement
[ ] Defensive wall: surrounding settlement

Industry

[ ] Mineshaft: Strip-mine or cave supports
[ ] Quarry: By exposed rock
[ ] Scaffolding: On quarries and buildings under construction

Culture

[ ] Climbing site: on steep mountainsides
[ ] Ice skating rink: on frozen water

Decoration

[ ] Fences / walls along paths

Closing this for the same reason as #9.


TypeError: Proxy handler is null

New Version
0.72.4
Old Version
0.72.1
Build Target(s)
iOS 17.0 simulator, Android 13 emulator
Output of react-native info
System:
    OS: macOS 13.5
    CPU: (10) arm64 Apple M1 Pro
    Memory: 71.17 MB / 32.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 18.16.0 - ~/.nvm/versions/node/v18.16.0/bin/node
    Yarn: 1.22.19 - ~/.npm-global/bin/yarn
    npm: 9.5.1 - ~/.nvm/versions/node/v18.16.0/bin/npm
    Watchman: 2<IP_ADDRESS> - /opt/homebrew/bin/watchman
  Managers:
    CocoaPods: 1.12.1 - /Users/groza/.rbenv/shims/pod
  SDKs:
    iOS SDK:
      Platforms: DriverKit 22.4, iOS 16.4, macOS 13.3, tvOS 16.4, watchOS 9.4
    Android SDK:
      API Levels: 28, 29, 30, 31, 32, 33
      Build Tools: 28.0.3, 29.0.2, 30.0.2, 30.0.3, 31.0.0, 32.0.0, 33.0.0
      System Images: android-27 | Google APIs ARM 64 v8a, android-30 | Google APIs ARM 64 v8a, android-33 | Google APIs ARM 64 v8a, android-33 | Google Play ARM 64 v8a
      Android NDK: 22.1.7171670
  IDEs:
    Android Studio: 2022.2 AI-222.4459.24.2221.10121639
    Xcode: 14.3.1/14E300c - /usr/bin/xcodebuild
  Languages:
    Java: 17.0.5 - /usr/bin/javac
  npmPackages:
    @react-native-community/cli: Not Found
    react: 18.2.0 => 18.2.0
    react-native: ^0.72.4 => 0.72.4
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

Issue and Reproduction Steps
After upgrading RN to 0.72.4 i get
TypeError: Proxy handler is null

on repeated API calls, what i assume is being thrown by fetch

Hey @lightrow 👋
Can you provide a reproducible sample as raised here?

@fortmarek nevermind, my apologies, the error is on my side, some unrelated code redux code was added to the project at the same time that was causing it


To investigate and implement a more flexible/pluggable networking system

To investigate and implement a more flexible/pluggable networking system for Apollo once Docker 1.9 with libnetwork support get released https://github.com/docker/libnetwork and mesos net modules becomes stable.
See https://github.com/docker/libnetwork/blob/master/docs/overlay.md
See https://github.com/projectcalico/calico-docker/blob/master/docs/getting-started/libnetwork/Demonstration.md
Once we move to mesos 0.25.0:
See http://mesos.apache.org/documentation/latest/networking-for-mesos-managed-containers/
See https://github.com/mesosphere/net-modules

Also see http://docs.weave.works/weave/latest_release/plugin.html

Also see https://github.com/coreos/flannel


Use without sharing when querying protected payment services configuration object

Now that the payment services config protected object is also being queried for community users who use the new constituent experience product, we found that sharing is being enforced when querying the protected payment services config records, causing the Elevate iframe not to display in the community portal. We are changing to without sharing instead to avoid sharing settings enforcement when querying this object.
Critical Changes
Changes
Issues Closed
Community Ideas Delivered
Features Intended for Future Release
Features for Elevate Customers
New Metadata
Deleted Metadata

this is a duplicate of https://github.com/SalesforceFoundation/NPSP/pull/7073 which was already approved

@lparrott I've tested this one and it's ready to merge. Just need one approving review on this duplicate PR.


add test for postfix completion relevance

Follow up to #11857, add a test and cov-marks
bors r+
🤖

bors r+

bors r+


Bump version

Yo, I don't want to be pushy about this, but I'd like to add the proxy functionality to my project asap. Could you bump the version of @prerenderer/prerender here and as a dependency of prerender-spa-plugin#v3 ? Thanks so much dude!

@b12f Sure. Almost forgot. ;)


Mandatory codeCoverageTool parameter is missing from this documentaton

The mandatory codeCoverageTool parameter is missing from this documentation and from the example YAML snippet.

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c6ac4ff4-9839-6a6d-8d20-a25084d221ef
Version Independent ID: bd09f139-8e69-8ea1-6671-b7bba8e17c23
Content: Publish Code Coverage Results task - Azure Pipelines
Content Source: docs/pipelines/tasks/test/publish-code-coverage-results.md
Product: devops
Technology: devops-cicd-tasks
GitHub Login: @shashban
Microsoft Alias: shashban

@shashban "codeCoverageTool" doesn't appear in the snippet or in the table below. Has that param been removed?

Thanks for letting us know. This issue is fixed in our new task reference, which is generated using the task source code and includes all task inputs, including any aliases here:
https://learn.microsoft.com/en-gb/azure/devops/pipelines/tasks/reference/publish-code-coverage-results-v1?view=azure-pipelines
Please check it out and let us know what you think. Thank you.


RNFSManager.stat got 1 arguments, expected 2

Hi, Thanks for writing this module. I'm having some trouble using it though. I get the above mentioned error. This seems to be linked to react-native-fs. So, I have double checked if the linking of react-native-fs is done properly, but couldn't get it to work.
Any pointers ?

Hi I'am facing similar issue. What did you do to overcome it?
I have linked react-native-fs properly.
The following is the error that I'am facing:
"RNFSManager. was called with 1 arguments, but expects 2. If you haven't changed this method yourself, this usually means that your versions of the native code and JavaScript code are out of sync. Updating both should make this error go away."


Correction for raw affiliation National Drug Research Institute, Curtin University, Shenton Park, Perth, WA, Australia; Centre for Addictions Research of British Columbia, University of Victoria, Victoria, BC V8W 2Y2, Canada

Correction needed for raw affiliation National Drug Research Institute, Curtin University, Shenton Park, Perth, WA, Australia; Centre for Addictions Research of British Columbia, University of Victoria, Victoria, BC V8W 2Y2, Canada
raw_affiliation_name: National Drug Research Institute, Curtin University, Shenton Park, Perth, WA, Australia; Centre for Addictions Research of British Columbia, University of Victoria, Victoria, BC V8W 2Y2, Canada
new_rors: 03rmrcq20;04s5mat29
previous_rors: 03rmrcq20
works_examples: W1965484807
contact: af8123d5c10209c234d8d92b0cb19ea0:bbb2cff9 @ ourresearch.org

This issue was accepted and ingested by the OpenAlex team on 2024-10-10. The new affiliations should be visible within the next 7 days.


Change Editor Option Button Size

Hello,
Can anyone suggest me how to change the size of bottom editor button? I am able to change images for them but how can I change height. I tried to change kMenuBarHeight, it reduces the height but the button goes down to the screen and are not fully visible, the text gets cut down. Please suggest.

Please modify initWithFrame: of CLToolbarMenuItem.


Add flag for validate command to turn on/off schema error colorization

Default is "colorize", but for large # of errors (
NOTE: we likely want to also find a faster way to "AddTabs" (i.e., reduce use of JSON marshal to speed up vulnerability formatting in the output)

Fixed by https://github.com/CycloneDX/sbom-utility/pull/22


Merge EIA861 short-form transform

Overview
Closes #3540 and replaces @nancy9ice PR #3565 to get all the CI to run because permissions are hard.
Testing
How did you make sure this worked? How can a reviewer verify this?
# To-do list
- [ ] If updating analyses or data processing functions: make sure to update or write data validation tests (e.g.,  `test_minmax_rows()`)
- [ ] Update the [release notes](../docs/release_notes.rst): reference the PR and related issues.
- [ ] Ensure docs build, unit & integration tests, and test coverage pass locally with `make pytest-coverage` (otherwise the merge queue may reject your PR)
- [ ] Review the PR yourself and call out any questions or issues you have
- [ ] For minor ETL changes or data additions, once `make pytest-coverage` passes, make sure you have a fresh full PUDL DB downloaded locally, materialize new/changed assets and all their downstream assets and [run relevant data validation tests](https://catalystcoop-pudl.readthedocs.io/en/latest/dev/testing.html#data-validation) using `pytest` and `--live-dbs`.
- [ ] For significant ETL, data coverage or analysis changes, once `make pytest-coverage` passes, ensure the full ETL runs locally and [run data validation tests](https://catalystcoop-pudl.readthedocs.io/en/latest/dev/testing.html#data-validation) using `make pytest-validate` (a ~10 hour run). If you can't run this locally, run the `build-deploy-pudl` GitHub Action (or ask someone with permissions to). Then, check the logs on the `#pudl-deployments` Slack channel or `gs://builds.catalyst.coop`.

Okay, we've got some real integration test failures here:
FAILED test/integration/etl_test.py::test_pudl_engine - pudl.etl.check_foreign_keys.ForeignKeyErrors: Foreign key error for table: core_eia861__yearly_short_form -- core_eia__codes_balancing_authorities (code) -- on rows [    1     2     3 ... 11343 11982 12515]

Foreign key error for table: core_eia861__yearly_short_form -- core_eia__entity_utilities (utility_id_eia) -- on rows [    2     3     4 ... 13013 13014 13015]
FAILED test/integration/output_test.py::test_outputs_by_table_suffix[eia861] - ValueError: Found null column: short_form_eia861.num_water_heaters

Hi Nancy! We've been meeting in person for the last couple of days, thanks for your patience. Yes, make pytest-coverage should reflect what gets run in CI.

Hi Nancy! We've been meeting in person for the last couple of days, thanks for your patience. Yes, make pytest-coverage should reflect what gets run in CI.

I understand. I've looked at the errors and it's because the values in the utility_id_eia and the balancing_authority_code_eia don't match values in the tables that also have these columns which is a bit odd.
Also, there are null values in the num_water_heater columns. For this one, should I change the NULL values to zero instead?

With the all NULL values for num_water_heaters... is it because that column doesn't exist or contain data in the years of data that are processed in the integration tests?  Or is it accidentally getting nulled in the transform somehow?  If you run the full ETL locally, is it also entirely NULL? It could also be a column naming error somewhere such that the real data is put into a column that's dropped when the database schema is enforced.
For the FK constraints, we might need to add some additional exceptions to the rules that are used to generate the constraints, since none of the EIA-861 tables are harvested -- i.e. they aren't used as the raw materials to construct the EIA Utility Entity table.  I'm not sure where the balancing authority code FK is pointing though, since we don't have an entity table for the BAs.  It might be that that column needs to be encoded / cleaned up in the short form table if it's got some bad / non-standard values in it.
I think @cmgosnell is going to pop in and take a look.

With the all NULL values for num_water_heaters... is it because that column doesn't exist or contain data in the years of data that are processed in the integration tests? Or is it accidentally getting nulled in the transform somehow? If you run the full ETL locally, is it also entirely NULL? It could also be a column naming error somewhere such that the real data is put into a column that's dropped when the database schema is enforced.
For the FK constraints, we might need to add some additional exceptions to the rules that are used to generate the constraints, since none of the EIA-861 tables are harvested -- i.e. they aren't used as the raw materials to construct the EIA Utility Entity table. I'm not sure where the balancing authority code FK is pointing though, since we don't have an entity table for the BAs. It might be that that column needs to be encoded / cleaned up in the short form table if it's got some bad / non-standard values in it.
I think @cmgosnell is going to pop in and take a look.

For the num_water_heaters, if you check the raw data files, they are actually NULL. For example, all the water_heater rows in the 2022 short form table are NULL

hey @Nancy9ice ! thanks for this insight! I went ahead and ran the CI tests locally and got the same results. I also generated this table with all of the years and it looks like this column is always null! So I'm going to add a defensive check in the transform to check if its always null and then remove it from the table.
And the FK problem is very expected with the 861 tables. This is an example of a quirk that don't have great documentation for ;-)
I'll push some changes momentarily and hopefully we'll get this merged in.


Lists is not showing in the sidebar even if it's turned on in Customize

https://user-images.githubusercontent.com/3111627/155664162-1b0ed0e6-05a4-46b7-8874-4ceccc65b992.mov

Hey @akoskm! Not everyone has access to lists. If you have Twitter Blue, it replaces it with Top Articles, and in your case, it looks like Communities?


Template error: Active view is null, can't overwrite content

Hi I am using the excalidraw plugin in Obsidian. When I try to select View mode, I get an error saying this - Template error: Active view is null, can't overwrite content. What may be wrong there?

Hey. We do not maintain the Obsidian plugin, but you can post the issue in the tracker here: https://github.com/zsviczian/obsidian-excalidraw-plugin/issues


Support Laravel 8 factories

Larastan Version: 0.6.4
--level used: max

Description
It's seems that states on the new factories that came with Laravel 8 are not yet supported.
It would be nice if we could deduct the return type of the Model::factory() method, added by the HasFactory trait.
Laravel code where the issue was found
User::factory()->expired()->create();

I would love to help out, but I haven't got a clue where to start. If anyone could guide me, I'm very much willing to put some time and effort into this.

I would love to help out, but I haven't got a clue where to start. If anyone could guide me, I'm very much willing to put some time and effort into this.

One way of doing this would be to write a DynamicStaticMethodReturnTypeExtension.
Here's an example of one https://github.com/nunomaduro/larastan/blob/master/src/ReturnTypes/StorageDynamicStaticMethodReturnTypeExtension.php
See also: https://phpstan.org/developing-extensions/dynamic-return-type-extensions
The class could look something like this:
public function getClass(): string
{
     return Model::class;
}

public function isStaticMethodSupported(MethodReflection $methodReflection): bool
{
     return $methodReflection->getName() === 'factory';
}

public function getTypeFromStaticMethodCall(
    MethodReflection $methodReflection,
    StaticCall $methodCall,
    Scope $scope
): Type {
    $modelName = $methodReflection->getDeclaringClass()->getName();
    // Here you have to determine $factoryName from $modelName
    return new ObjectType($factoryName);
}

I haven't worked a lot with the new factories yet, so I'm not sure if there are any caveats, but I think this should be enough to make it work.

I've been spending some time on this, I've got the return type resolving the correct factory but it's still in a union type with the base factory. When i have more time I'll try to fix this.

For all those who currently have this problem: I solved it by specifying the static method factory with a specified return value in the PHPDoc:
/**
 * @method static UserFactory factory(mixed $parameters)
 */
class User extends Model
{
    use HasFactory;
}

Hi,
I'll be adding support for Laravel 8 factories soon.
Apart from the basic support (User::factory()->create() should return User), which features would you like to see get implemented? Support for factory relationships seems to be possible as well.

@canvural glad to see you pick this up. Given the massive blocker to further Laravel updates that is https://github.com/laravel/framework/pull/37794, I personally would appreciate an MVP and am willing to help.

PHPStan errors are rarely blockers. You can ignore them or add to baseline.
I think next week I should have something 👍🏽

PHPStan errors are rarely blockers.

Fro whom? The short-term brave guy or the long-term guy who does care about technical debt?

PHPStan errors are rarely blockers.

For whom? The short-term brave guy or the long-term guy who does care about technical debt?

Anyone. It does not block you to deploy and use your code.

It does not block you to deploy and use your code.

It blocks long-term guys like me. CI produces an ❌ and I fix it.

@canvural Please do not be a short-term guy.


fix(Slider): overlapping labels on range slider

SPC-1098
Description
The labels for range sliders are overlapping each others when too close. We need to change tooltip placement when labels intersect.
Designs for new Range Slider: https://app.abstract.com/projects/1b06c884-06af-482a-bf12-a82f521a19a1/branches/master/commits/20c8113e84edea686ef2649d328d248e963e78c5/files/564adc73-0216-46a6-98e5-70ff39d5c47d/layers/4661426D-F2D3-4E56-81C6-0BAB4792872A
How to test

Go to the Slider story: /?path=/story/components-slider--slider
Test Range Slider.

Screenshots

Before.
After.

Insert screenshots or screen recordings
Insert screenshots or screen recordings

Review

[ ] Read CONTRIBUTING.md and Component API principles
[ ] Annotate all props in component with documentation
[ ] Create examples for component
[ ] Ensure that deployed demo has expected results and good examples
[ ] Ensure that tests pass by running yarn test
[ ] Ensure that visuals tests pass by running yarn test:visual. If not - check the documentation how to fix visual tests
[ ] Ensure the changed/created components have not caused accessibility issues. How to use accessibility plugin in storybook.

PR commands

List of available commands:

@toptal-bot run all - Run whole pipeline
@toptal-bot run build - Check build
@toptal-bot run visual - Run visual tests
@toptal-bot run deploy:documentation - Deploy documentation
@toptal-bot run package:alpha-release - Release alpha version

LGTM, the only problem is that HAPPO screenshots are no good. Maybe there is a way to do some kind of delay before taking a snapshot?

I tried with different time (wait()) but with no luck :(


Target tooltip appears on damage dealt section if no enemies targetted.

Thank you for looking at all my bug reports, I got more! haha
I get the apply damage tooltip hovering over the damage amount/type display box. It seems to happen both if an enemy is targeted or not. Foundry v12, on the latest alpha (18)
No target:

A target:

I'd love to actually apply damage to tokens that I have targeted, if my user forgets to target any/the right enemy, so this popup got me hopeful. However it doesn't seem like the value is clickable.

What can be done about this, is that if no tokens where targeted, a button will show on the bottom of the chat message "Select Targets". It'll grab all the newly targeted tokens and run it through the hitscan script, then re-render the chat message with the target information. Would this suffice?

ooh, that would actually be great.


User html list

Codecov Report

Merging #36 into master will increase coverage by 0.31%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master     #36      +/-   ##
=========================================
+ Coverage   90.09%   90.4%   +0.31%
=========================================
  Files          11      11
  Lines        1232    1272      +40
  Branches      118     121       +3
=========================================
+ Hits         1110    1150      +40
  Misses         91      91
  Partials       31      31


Adds bare run, drops 3.7, adds 3.11 to CI

The CI did not include a run that builds with none of the optional dependencies. This PR changes the standard runs to now use all optional dependencies, and adds a 'bare' run with none of them. It also drops 3.7 and adds a 3.11 run.

FYI @cjcscott I think that ebcc wasn't actually getting imported in the CI on #92 :grimacing:

I thought we already knew this? Hence lots of skipped tests? Good to run them though - 3.11 a good addition as well, let's see if any bugs gets turned up!

Ah I may have misunderstood, did the ebcc tests pass locally? Should be fine if so.

I've also edited this PR to drop CI support for python 3.7. It's EOL is in 3 weeks and dyson specifically requires >=3.8 anyway. I won't change the Vayesta requirements to disallow 3.7 for now, but I don't see much point in CI/CD for python versions past their EOL.

Yeah, I've run tests with ebcc separately when plumbing in the interface etc

I'll check what's happening with cvxy as a dependency here, the nicely skipping tests functionality appears to not be working..

Codecov Report
Patch coverage has no change and project coverage change: +0.06 :tada:

Comparison is base (10db358) 71.99% compared to head (9601255) 72.06%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #104      +/-   ##
==========================================
+ Coverage   71.99%   72.06%   +0.06%
==========================================
  Files         138      138
  Lines       18402    18497      +95
  Branches     2578     2542      -36
==========================================
+ Hits        13248    13329      +81
- Misses       4424     4435      +11
- Partials      730      733       +3

see 17 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

I fixed the cvxpy stuff, this can be merged


version compare between prerelease versions is wrong

tried with following code:
import semver
semver.compare("1.0.0-alpha10", "1.0.0-alpha9")

the expected output should is 1
but the actual output is -1
Python 3.7.4

from semver, looks like prerelease versions are separated with .
and it works with 1.0.0.alpha.10 vs 1.0.0.alpha.9


Fix fillna not accepting 0

Currently fillna throws an error when trying to fill with 0

Fixed and merged in latest TS version


My Portfolio

I have created my profile.Kindly merge it into your repository.Now,I have become confident how to do contribution in github.Thank You for wonderful experience.
Fixes- #28

Great


Add files via upload

I am requesting a domain for my school Hamilton District Christian High located in Hamilton, Ontario for my student license. Our school is using Pycharm of JetBrain but my school is not aware of the privilege to educators and students. Please review and merge this domain. Many Thanks

@Kevcode-0247 file.zip: this request has an incorrect file path format, please ensure that you are familiar with     this repository rules located at the bottom of this page and change     your request accordingly. If you don't know how to change request, close it and open a new one.     If you are not able to make the pull request according the instructions, please send us an email to<EMAIL_ADDRESS>Please mention this request URL in the message.

@Kevcode-0247 file.zip: this request has an incorrect file path format, please ensure that you are familiar with     this repository rules located at the bottom of this page and change     your request accordingly. If you don't know how to change request, close it and open a new one.     If you are not able to make the pull request according the instructions, please send us an email to<EMAIL_ADDRESS>Please mention this request URL in the message.

@Kevcode-0247 file.zip: this request has an incorrect file path format, please ensure that you are familiar with     this repository rules located at the bottom of this page and change     your request accordingly. If you don't know how to change request, close it and open a new one.     If you are not able to make the pull request according the instructions, please send us an email to<EMAIL_ADDRESS>Please mention this request URL in the message.

@Kevcode-0247 I had to close your pull request. You weren't supposed to upload file.zip file. It was expected that you unzip file.zip file, fork SWOT repository, add unzip file to your forked SWOT repository to an appropriate folder, lib/domains/org, and make a new pull request.
I added a correct file on your behalf manually. Please wait at least one hour after this message is sent, before start requesting the licenses at https://jetbrains.com/student.


For MapBox maps, change or remove requirements for Values field

As a data scientist, I want to put geospatial feature data on a map and show arbitrary fields (attributes) so that I can understand spatial relationships and access individual feature information.
See also issue #459: preserveCols is an interim step, since it is already partially implemented.
Expected behavior
In the Options dialog, I can choose or list attributes to be displayed in hover popups on the map. In the current dialog layout, the Values box can be used for that.
Actual behavior
The Values box is restricted to numeric columns only. This makes sense for normal charts but is an arbitrary and inappropriate restriction for maps.
Steps to reproduce the behavior
Take any geospatial data and use display() to create a MapBox map. It is impossible to drag a non-numeric column into the Values box.

may require over-riding a lot of existing base class methods

related to #203

Fixed in https://github.com/ibm-watson-data-lab/pixiedust/tree/mapbox-v2


ceph ansible 3.1 igw: fix rbd-target-gw startup

The problem is rbd-target-gw needs the rbd pool to be created, keyring to be copied over, and the iscsi-gateway.cfg to be setup before starting the rbd-target-gw service.
In the master branch this is fixed by this commit:
    commit 91bf53ee932a6748c464bea762f8fb6f07f11347
    Author: Sébastien Han<EMAIL_ADDRESS>    Date:   Fri Mar 23 11:24:56 2018 +0800

        ceph-iscsi: support for containerize deployment

where the needed setup tasks are done in common.yml which is done before prerequisites.yml.
To avoid porting all those changes to 3.1 this patch just moves the rbd-target-gw startup to configure_iscsi.yml after everything has been setup.
This fixes red hat bz:
https://bugzilla.redhat.com/show_bug.cgi?id=1601325

Mike, can you edit this pull request in GitHub to be targeted to "stable-3.1" instead of "master"?

Oh, I was able to do it, here.


ppxo_close_no_token_cancelurl error when closing the popup while loading

Description
When a user closes the Checkout popup while it's loading I get the warning ppxo_close_no_token_cancelurl

[x] Screenshots or videos that show the issue

[x] Your code

    CREATE_PAYMENT_URL  = 'http://localhost:3000/paypal/create_payment';
    EXECUTE_PAYMENT_URL = 'http://localhost:3000/paypal/execute_payment';

    paypal.Button.render({
      locale: 'en_US',
      env: 'sandbox',

      payment: function() {
        return new paypal.Promise(function(resolve, reject) {
          $('.paypal-overlay').fadeIn();
          $.post(CREATE_PAYMENT_URL)
            .done(function(data) { resolve(data.paymentID); })
            .fail(function(err)  { $('.paypal-overlay').fadeOut(); });
        });
      },

      onAuthorize: function(data) {
          console.log('The payment was authorized!');
          console.log('Payment ID = ',   data.paymentID);
          console.log('PayerID = ', data.payerID);

          $.post(EXECUTE_PAYMENT_URL, { paymentID: data.paymentID, payerID: data.payerID })
            .done(function(data) {
              window.location = '/payments/summary'
            })
            .fail(function(err)  {
              window.location = '/payments/cancelled'
            });
      },

      onCancel: function(data) {
        window.location = '/payments/cancelled'
      }

    }, '#paypal-buynow');

[x] The paypal.version from your browser console
4.0.130
[x] All console logs during the time of the issue, especially error messages
https://pastebin.com/m6gttHna
[x] Does the issue also occur at developer.paypal.com/demo/checkout?
Yes

Steps to reproduce

Click on Checkout
Close the Checkout popup before it finishes loading

Affected browsers

[x] Chrome
[x] Firefox

Thanks for the report. This is definitely an issue -- ideally I'd like to call onCancel in these scenarios. There are a few internal reasons why this adds a little complexity to the checkout.js script, but I'll keep this open since I'd like to get this prioritized at some point.

@bluepnume Thank you for the answer. Can you please tell me if I can somehow catch this error myself and handle it? Or I'd there's any alternative to integrate PayPal like checkout js? I wouldn't know if the user closed the pop-up and I'm afraid this issue will affect user experience

I'm afraid I don't have any short term solves at the moment. My advice for now, would be to give the buyer sufficient options on the page with the PayPal button, so they aren't blocked from doing whatever they want to do when they close the popup.
If it helps, looking at the logs on our side, the number of times this situation happens is pretty low.

@bluepnume Is there an ETA for resolution?

@bluepnume i would also need a fix for this issue - is there any update on this?

This should be resolved now. Please clear your browser cache and let me know if you still see the issue. Thanks!


Is systemMemStats working correctly?

On Linux I see:
>> [f,t]= stitchit.tools.systemMemStats

f =

    66295432

t =

    65875908

>> free
Undefined function or variable 'free'.

>> !free
              total        used        free      shared  buff/cache   available
Mem:       65875908     8239088      445172      180168    57191648    56668628
Swap:      67008508      713076    66295432
>>

On a Mac I see:
>> [f,t]= stitchit.tools.systemMemStats

f =

     1032028

t =

    15625000

The OS X activity monitor reports 11.7 GB of 16 GB used.

I have found when doing this myself in the past that different versions of free return the results formatted in slightly different ways and this has thrown off my readers. I don't have the time to look into this now, but I'm flagging it.


Is it over?

Hi
Any clue if this project will be maintained any further?
Thanks

Great to hear, gionkunz!

If I can help without coding, let me know

Hello @eddr 👋
Chartist has recently been updated to version 1.0 with some new exciting changes like ESM and TypeScript support. The migration guide can be found right here.


feat(#645): Enable Windows Platform

In this PR I completely repaired all pipelines on Windows platform.
They don't fail anymore.
Closes: #645.

PR-Codex overview
This PR updates the invoker.properties file by adding new goals and Maven options.
Detailed summary

Added invoker.goals = clean process-classes -e
Added invoker.mavenOpts=-Xss256m

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@volodya-lombrozo 🎉 Great contribution! You've earned +4 points for this effort. While there's room for improvement in code review and comments, we appreciate your work. Your hits-of-code count was 3, which is a start. Keep the contributions coming! Your current balance is +147. Let's aim for more comprehensive reviews and comments next time to boost your points further!


Populate genre dropdown

https://api.themoviedb.org/3/genre/movie/list?api_key=0bd9398a9daad70a50c685a4f8c0a74b&language=en-US

For each , the value attribute should be set to the genre ID from the API result above. The genre name will be shown in the dropdown box while the genre ID will be used in a later API call for getting the list of movie titles.


Vendor Name Default

Hey Guys -
Run into a problem with the :vendor_name default value. When I leave it set to the default value, I get this error:
NameError - uninitialized constant Devise::Models::Campaignable::Adapters::VendorName
When I change the default value to :mailchimp I get this error:
NameError - uninitialized constant Gibbon::API
I'm stuck at this point. I'm running Rails 4.2.4 and Ruby 2.2.1 and the latest version of Mailchimp.
Thanks!

HI @Austex - sorry for the late reply - I've only just seen your issue.
I think we have two separate problems here. For some reason the default value isn't being used, so I'll take a look into that, for the moment use :mailchimp
The next issue is the dependancy on the Gibbon gem, which we use to interact with the Mailchimp API. For some reason this dependancy isn't always properly installed.
Add gem 'gibbon' to your gemfile just before the devise_campaignable gem.
Hopefully this will solve your issues for the moment while I patch the gem.

Cool. Thanks Robert!
Reza Piri

On Dec 29, 2015, at 5:04 AM, Robert Rawlins<EMAIL_ADDRESS>wrote:
HI @Austex - sorry for the late reply - I've only just seen your issue.
I think we have two separate problems here. For some reason the default value isn't being used, so I'll take a look into that, for the moment use :mailchimp
The next issue is the dependancy on the Gibbon gem, which we use to interact with the Mailchimp API. For some reason this dependancy isn't always properly installed.
Add gem 'gibbon' to your gemfile just before the devise_campaignable gem.
Hopefully this will solve your issues for the moment while I patch the gem.
—
Reply to this email directly or view it on GitHub.

Taking another look at this @Austex I'm not entirely sure my initial diagnosis was correct. I actually think the gibbon gem was installed, but perhaps the wrong version.
Can you check which version of Gibbon has been installed on your environment?

Hey @Austex - I've just cut a new version of the gem (0.1.1) which fixes the README to save the confusion over the default vendor name.
This new version also changes the dependancy definition for Gibbon, as it appears the existing one meant that Gibbon 2.x.x was being installed, which has a different API to 1.x.x - hence the error message you were getting.
Update your version of the devise_campiaignable gem and you shouldn't have any more problems.

@Austex I'm going to close this issue off now as I believe it's been resolved. I've also cut another version of the gem today which upgrades to Gibbon 2.0 and uses MailChimp API v3.


Unable to query for permission: com.google.android.providers.gsf.permission.READ_GSERVICES

Hi,
Since I upgraded to marshmallow keeping the same gmscore version, I'm having this on wordox
02-14 22:44:08.485 4170 4170 E Unity : Unable to query for permission: com.google.android.providers.gsf.permission.READ_GSERVICES

I have at it startup, no prompt asking permission and a black screen.
I guess it may be related to the new permission model of Android6 and to the 'Google Play' permissions needed :

Thanks
PS: I'm working as a sysadmin in the company editing this game.

Fixed on our side. Sorry for the noise.


Hotfix/loose file handlers

In response to allowing the CI model outputs to save directly to the same run output file they were created from, we had to switch the file mode from 'r' to 'r+' in all runs. This was not ideal, as that should really strictly be a read-only module.
Prompted by this, this PR finally removes the loose file handlers that were strewn about runs in favour of a cleaner context manager only opening the file to read when needed.
This also very slightly begins the necessary standardization of the two seperate run classes (MCMC and nested), by providing more responsibility to their baseclass. There is of course still a lot of unnecessary overlap, but that's for another branch.

I suspect there is also a lot of opportunity for cleaning this up, this was a very quick cut and paste job replacing every call to read the file, with no thought given to whether said call was really needed. But again, that's for another branch