gitlab: fix module and corresponding test

Motivation for this change
This fixes some things I've encountered while trying to use this module:

uploads symlink from store was broken, causing migrations on fresh
installation to fail
Get lib folder from configured package, not from a global gitlab
one
Increase memory limit, so the test will be able to pass

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

No attempt on aarch64-linux (full log)
The following builds were skipped because they don't evaluate on aarch64-linux: tests.gitlab
Partial log (click to expand)
Cannot nix-instantiate `tests.gitlab' because:
error: attribute 'gitlab' in selection path 'tests.gitlab' not found

No attempt on x86_64-linux (full log)
The following builds were skipped because they don't evaluate on x86_64-linux: tests.gitlab
Partial log (click to expand)
Cannot nix-instantiate `tests.gitlab' because:
error: attribute 'gitlab' in selection path 'tests.gitlab' not found

Ah, you can then uncomment this: https://github.com/NixOS/nixpkgs/blob/5f5e3434874c6757504cbd5d48c02678e9851913/nixos/release.nix#L292-L294, was disabled since 61816b06e7f908c1f33c01312218e495f23426f1

@GrahamcOfBorg test gitlab

@GrahamcOfBorg test gitlab
Currently only trusted users can run builds through ofborg, see https://github.com/NixOS/ofborg#trusted-users-vs-known-users

Failure on x86_64-linux (full log)
Attempted: tests.gitlab
Partial log (click to expand)
gitlab: running command: systemctl --no-pager show "gitlab.service"
gitlab: exit status 0
error: action timed out after -1 seconds at /nix/store/id0qh30c3rms41b1f4gn3vqb76nhf58y-nixos-test-driver/lib/perl5/site_perl/Machine.pm line 238, <__ANONIO__> line 189537.
action timed out after -1 seconds at /nix/store/id0qh30c3rms41b1f4gn3vqb76nhf58y-nixos-test-driver/lib/perl5/site_perl/Machine.pm line 238, <__ANONIO__> line 189537.
cleaning up
killing gitlab (pid 593)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
builder for '/nix/store/wxpxsbvp039b6dcb666c2a999zsg71fk-vm-test-run-gitlab.drv' failed with exit code 255
error: build of '/nix/store/wxpxsbvp039b6dcb666c2a999zsg71fk-vm-test-run-gitlab.drv' failed

Failure on aarch64-linux (full log)
Attempted: tests.gitlab
Partial log (click to expand)
gitlab: running command: systemctl --no-pager show "gitlab.service"
gitlab: exit status 0
error: action timed out after -1 seconds at /nix/store/pzwslya6jvbcmki7nznl1h7vv07cz1zg-nixos-test-driver/lib/perl5/site_perl/Machine.pm line 238, <__ANONIO__> line 189502.
action timed out after -1 seconds at /nix/store/pzwslya6jvbcmki7nznl1h7vv07cz1zg-nixos-test-driver/lib/perl5/site_perl/Machine.pm line 238, <__ANONIO__> line 189502.
cleaning up
killing gitlab (pid 627)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
builder for '/nix/store/gil5nva9k1bnsw3llzv2k94n4xq6x9vy-vm-test-run-gitlab.drv' failed with exit code 255
error: build of '/nix/store/gil5nva9k1bnsw3llzv2k94n4xq6x9vy-vm-test-run-gitlab.drv' failed

The test fails because systemd for some reason decides to enforce start timeout, despite it being explicitly set to infinity. Didn't saw this myself as I was testing on a faster machine.
So what to do now? Disable the test back again?

@binarin that's not systemd , but a hard-coded timeout in nixos-test-driver:
https://github.com/NixOS/nixpkgs/blob/master/nixos/lib/test-driver/Machine.pm#L231

I think we had problems with this test inside a VM because the p9 filesystem used to passthrough the nix store is not fast enough to load all ruby gems from gitlab in time.

That's really weird, ExecStartPre commands should also use timeout_start_usec…

Searching around the internet showed that infinity was incompatible with older versions of systemd. Looks like this should be already fixed/implemented in the version that is currently used, but as I have no other ideas, I'm changing this timeout to 1day. Can someone please kick-off the tests again?

@GrahamcOfBorg test gitlab

Failure on aarch64-linux (full log)
Partial log (click to expand)
Merge failed

Failure on x86_64-linux (full log)
Partial log (click to expand)
Merge failed

@binarin can you rebase?

@flokli I've tried to do so half an hour ago, but master was broken. Will try one more time.

@GrahamcOfBorg test gitlab

Uff, 16 minutes is quite a long time.
Do you see what's taking so long here?
If it's I/O on the database, can we mount it with a tmpfs as storage for example?

@flokli it is loading ruby files from p9 file system which is super slow.

The longest part of a test in applying all the migrations. I don't think that applying them on bare-metal was much faster.

Failure on x86_64-linux (full log)
Attempted: tests.gitlab
Partial log (click to expand)
gitlab: running command: systemctl --no-pager show "gitlab.service"
gitlab: exit status 0
error: action timed out after -1 seconds at /nix/store/h5g1dpjzjzdk2vk15g18pvsbi5pvrdaq-nixos-test-driver/lib/perl5/site_perl/Machine.pm line 238, <__ANONIO__> line 190443.
action timed out after -1 seconds at /nix/store/h5g1dpjzjzdk2vk15g18pvsbi5pvrdaq-nixos-test-driver/lib/perl5/site_perl/Machine.pm line 238, <__ANONIO__> line 190443.
cleaning up
killing gitlab (pid 597)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
builder for '/nix/store/m1g5jbkcrznqvph06hjih0i65h7rs680-vm-test-run-gitlab.drv' failed with exit code 255
error: build of '/nix/store/m1g5jbkcrznqvph06hjih0i65h7rs680-vm-test-run-gitlab.drv' failed

OK, I've found why systemd was killing a unit while despite of infinity timeout. It's because the test was overriding that infinity to 10 minutes.
I've pushed a change increasing this to 30 minutes, let's try again - maybe it'll be able to finish when not experiencing random kills.

Failure on aarch64-linux (full log)
Attempted: tests.gitlab
Partial log (click to expand)
gitlab: running command: systemctl --no-pager show "gitlab.service"
gitlab: exit status 0
error: action timed out after -1 seconds at /nix/store/4959zlsg9mdg454k4232awf55ij9xb0d-nixos-test-driver/lib/perl5/site_perl/Machine.pm line 238, <__ANONIO__> line 190541.
action timed out after -1 seconds at /nix/store/4959zlsg9mdg454k4232awf55ij9xb0d-nixos-test-driver/lib/perl5/site_perl/Machine.pm line 238, <__ANONIO__> line 190541.
cleaning up
killing gitlab (pid 631)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
builder for '/nix/store/icxxgy0wv11sj472162vz9hqk78glxgi-vm-test-run-gitlab.drv' failed with exit code 255
error: build of '/nix/store/icxxgy0wv11sj472162vz9hqk78glxgi-vm-test-run-gitlab.drv' failed

@binarin ping ;-)

@flokli I hope I'll be able to get back to this issue within a few weeks.

superseded by #49658


Create tarnowckz.txt

Please Add CKZ Tarnow
https://tarnowckz.pl/

@philipto

@philipto First stage of verification passed, official domain as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@philipto First stage of verification passed, official domain is tarnowckz.pl as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@philipto First stage of verification passed, official domain is tarnowckz.pl as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@AndrzejPorebski Pull request merged. Thank you!


Unable to obtain updater for 'manifest-beta.json'

Describe the bug
When I try to use an "uncommon" manifest name, I have an error.
The manifest here is a valid json file, and the "normal" name (aka manifest.json) works. I use -beta for beta release on a specific workflow.
My config is :
"scripts": {
"beta": "commit-and-tag-version --prerelease --tag-build beta",
"community": "commit-and-tag-version --packageFiles package.json --bumpFiles manifest-beta.json"
},
"commit-and-tag-version": {
"t": "",
"bumpFiles": [
	{
	"filename": "manifest-beta.json",
	"type": "json"
	},
        {
	"filename": "package.json",
	"type": "json"
	}]}

Current behavior
Actually, the manifest-beta is not updated and skipped.
Log :
Unable to obtain updater for: "manifest-beta.json"
 - Error: Unsupported file (manifest-beta.json) provided for bumping.
 Please specify the updater `type` or use a custom `updater`.
 - Skipping...

Expected behavior
Should be updated as the manifest.
Environment

commit-and-tag-version version(s): [e.g. v6.0.0, v8.0.0, master] : 10.0.1
Node/npm version: [e.g. Node 10/npm 6]: v16.13.2 / 8.5.5
OS: [e.g. OSX 10.13.4, Windows 10] Windows 11

Possible Solution

get type based on .json
Possibility to add type directly in CLI
regex on "normal" name, and include every file with manifest.json in it. As \S*manifest\S*\.json$

Additional context
My goal is to separate release of manifest-beta and manifest but update manifest-beta when the manifest is updated.

Thanks for the report! If no one else has, I'll try to look at this in the next 7 days

Ok, so the problem here is that the --bumpFiles in the CLI is overriding the bumpFiles in the config stanza, and it's not possible to specify the type of the updater via the CLI. The tool is correctly complaining that it doesn't know the type of the updater.
For your specific use case, I think you can fix this by changing:
"community": "commit-and-tag-version --packageFiles package.json --bumpFiles manifest-beta.json"

to
"community": "commit-and-tag-version"

I'm not sure what the best way to improve commit-and-tag-version for this case is - here are some ideas:

Make it possible to specify the type of the updater via the CLI
Make it warn when a CLI setting is overriding the config
Try to infer the updater type from the file extension
Some other idea

What do you think?

I will try ! Thank you for this reply :)

I'll close this for now as the original issue is solved, and the underlying problem is covered by #31.


Batch process might not result in equilibrium

Introduction

traditional orderbook exchange has same last executed price and current price

the exchange finds equilibrium(no more matching) until new order comes in

constant product AMM has different swap price and resulting pool price

derivation of swap price and pool price after swap

constant product : X * Y = (X + △X) * (Y - △X/p)
swap price : p = (X + △X) / Y
pool price after swap : pp = (X + △X)/(Y - △X/p) = (X + △X)^2 / (X * Y)

example

X=100, Y=100, △X=1
swap price : p = (100 + 1) / 100 = 1.01
pool price after swap : pp = (100 + 1)^2 / (100 * 100) = 1.0201
when △X is small relative to X, pool price change rate is approximately twice of the change rate of swap price

in other word, swap price is approximately middle point between current price and the post swap pool price

AMM does not have orderbook, therefore there exists no concept of equilibrium

every order is one-block alive, so, after swap, there exists no old order to be matched anymore

Problem

in our implementation, we combine traditional orderbook exchange and AMM
orders will be located in orderbook, with longer than 1 block height life(in version 2), so we do have the concept of equilibrium
but, because of the characteristic of "constant product pool", batch might not result in equilibrium

this is assuming existence of limit orders in our version 2 model

Example

X reserve : 1,000 X
Y reserve : 1,000 Y
swap order from X to Y : 200 X at price 0.99 Y/X
swap order from Y to X : 100 Y at price 0.98 Y/X
batch swap price = 0.99
liquidity pool participation amount

pay out : X - Y*swapPrice = 1,000 - 990 = 10 X
receive in : 10/0.99 = 10.1010.. Y

perfect matching of the swap order from Y to X

pool match : 10/0.99 = 10.1010.. Y --> 10 X
self match : 100 - 10/0.99 = 89.8989.. Y --> 89 X

fractional matching of the swap order from X to Y

matched amount : 100 * 0.99 - 10 = 89 X
residual amount : 200 - 89 = 111 X

resulting pool price = X/Y = 990 / 1010.1010.. = 0.9801

because swap order from X to Y with order price 0.99 Y/X is remained, more matching is possible

additional matching

batch swap price = 0.99
liquidity pool participation amount

pay out : Y - X/swapPrice = 1010.1010 - 990/0.99 = 10.1010.. Y
receive in : 10.1010..*0.99 = 10X

fractional matching of the swap order from X to Y

matched amount : 10X
residual amount : 111 - 10 = 101X

resulting pool price = X/Y = 1000/1000 = 1

Tackling Plan

non-equilibrium after batch process can lead to unnecessary additional batch process for residual amount of orders to be executed by liquidity pool
but in version 1, every order will be canceled right after batch process, therefore there will be no order left for additional batch process
we have some options how to tackle this problem
a. no change in batch logic : let it process additional batch
b. constant product model modification : modify constant product model so that it can have same swap price and pool price

this can lead to significant impact on economy of liquidity pool, therefore it should be very carefully reviewed
c. combine the additional matching processes into one batch
this does not create significant economic impact, therefore an ideal solution

we will research option c and decide the strategy to solve this problem in Milestone 3
in version 1, we will keep this logic because non-equilibrium is not a significant issue for version 1

Serious edge case found:

X=100, Y=100
order from X to Y : 10X with order price = 1 + 0.1^6 - 0.1^10
order from Y to X : 10Y with order price = 1 + 0.1^6 + 0.1^10
iteration : batch process iterates about 210k to spend all quoted orders

to do

find exact formula for number of iterations for given orderbook status
find a way to prevent this kind of iteration

This issue is resolved by fixing constant product model as below.

constant product model

constant product equation : XY = (X+△X)(Y-△Y)
swap price : p = (X+△X) / Y
pool price after swap : pp = (X+△X)/(Y-△Y) = (X+△X)/(Y-△X/p) = (X + △X)^2 / (X * Y)

equivalent swap price model

constant product equation : does not hold
swap price : p = (X+2*△X) / Y
pool price after swap : pp = (X+△X)/(Y-△Y) = (X+△X)/(Y-△X/p) = (X+2*△X) / Y == p
liquidity provided by the pool :

△X = (p*Y-X)/2
PoolY = △Y = △X/p = (pY-X)/(2p)

Equivalent swap price model is derived from the property that the swap price is equal to next pool price.
This property is necessary consistency with limit orders in our AMM because the resulting post-swap pool price should be equal to the actual swap price from last batch process.
In constant product model, this consistency break down, causing non-equilibrium status with remaining limit orders.
The pseudo code for this new model is implemented here<EMAIL_ADDRESS>This model will be immediately applied to our implementation in this Liquidity Module repository.

spec updated to equivalent swap price model : https://github.com/tendermint/liquidity/commit/012a59733167b4a893627a42c9eb02b861f7efbf

This issue has been resolved from new equivalent swap price model adoption.


In a production environment, panic! may not be a good choice.

In a production environment, panic! may not be a good choice. Can we directly return the error message as a string, i.e., change the code from
panic!( "Failed to format a message for locale {} and id {}.\nErrors\n{:?}", lang, text_id, errors  )

to
Some(format!("Failed to format a message for locale {} and id {}.\nErrors\n{:?}",   lang, text_id, errors))

Thank you for your issue! I believe there are try_ variants for when you want to avoid panics, can you provide a specific example of where you're running into this?

I want to encapsulate the use of LOCALES.lookup_with_args in a Linux service. Sometimes, due to programming negligence, the name of the arguments may be written incorrectly, but this will not result in a compilation error. Instead, it will cause a runtime crash, which is not very user-friendly. Implementing compilation errors might be difficult, but directly printing error messages is a better approach as it allows for easy identification of the error, without the need to run the program multiple times to see the crash information.

The mentioned try_ function has left me a bit confused. Does the library provide such a function? Could you please provide an example? Thank you.

Even with try_ methods, it will still panic when no arguments are provided to messages expecting them (here). This method should definitely return a Result, instead.

Wanted to provide some feedback that this change is needed.
When hot reloading translations that has an invalid translation this panic is triggered even when calling try_ family method.
With #63 hot reloading even with invalid translations works nicely,  i can handle error correctly.  I am using this feature daily.


this.$set is not a function

I was trying to implement this in my Vue app and I was facing this error.
Vue Version: 3
code
`< vue-multi-select
v-model="values1"
search
:options="options1"
:selectOptions="data1" />
`

Stack trace
vue-multi-select.common.js?dcc6:3799 Uncaught (in promise) TypeError: this.$set is not a function
at Proxy.initValues (vue-multi-select.common.js?dcc6:3799)
at Proxy.init (vue-multi-select.common.js?dcc6:3789)
at Proxy.setConfig (vue-multi-select.common.js?dcc6:3765)
at Proxy.created (vue-multi-select.common.js?dcc6:3733)
at callWithErrorHandling (runtime-core.esm-bundler.js?5c40:154)
at callWithAsyncErrorHandling (runtime-core.esm-bundler.js?5c40:163)
at callSyncHook (runtime-core.esm-bundler.js?5c40:5957)
at applyOptions (runtime-core.esm-bundler.js?5c40:5888)
at finishComponentSetup (runtime-core.esm-bundler.js?5c40:6574)
at setupStatefulComponent (runtime-core.esm-bundler.js?5c40:6505)

Hi, this component is vue2 only sry

Hi, this component is vue2 only sry

hey, ohh okayy. is there any library you are aware of doing all these things like select and deselect all for vue 3, i tried vue multiselect and also tried their slots but cant get reactive buttons and the dropdown closes

i didn t use any lib for  vue3 atm sry


Fully compiled source template (with loader)?

Would be great if you've added it to the repository, since messing with npm and loader is such a nuisance.
I'm trying to set it up on Windows since I do most of stuff on it, but none of mentioned things works adequately in there. So just downloading, and perhaps changing something here and there a little bit, would be a totally great option.
It's just that I don't feel like dumping everything into either one HTML body or link Lua scripts through JS implementations; wouldn't it look terrible? Surely so.

Compiled source is attached to the releases. See https://github.com/fengari-lua/fengari-web/releases/tag/v0.1.4
We will not be committing compiled artifacts to the repository itself.


Changes for PCLM, Secret store, developer mode and screenshots changed

@katarzyna-koltun-mx - once this is out of draft, we need to discuss who picks it up and resolves conflicts/proofreads/merges it.
Adding you as assignee for information.

@Nidhi251289 - what is the status of this PR?
Do you know when you are likely to want it reviewed and published?

HI Mark,
This PR contains changes for multiple release such as PCLM, Secret store, some documentation changes. Since, we did not release PCLM yet, i would like to refer this once we release PCLM. After which i will close this PR.
Regards
Nidhi

From: Mark van Ments @.>
Sent: Wednesday, November 23, 2022 1:28 PM
To: mendix/docs @.>
Cc: Nidhi Soni @.>; Mention @.>
Subject: Re: [mendix/docs] Changes for PCLM, Secret store, developer mode and screenshots changed (PR #5269)
@Nidhi251289https://github.com/Nidhi251289 - what is the status of this PR?
Do you know when you are likely to want it reviewed and published?
—
Reply to this email directly, view it on GitHubhttps://github.com/mendix/docs/pull/5269#issuecomment-1324986585, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AH75NGRX5RT65WWI4FRVMHTWJYEVFANCNFSM6AAAAAAR2H3QVA.
You are receiving this because you were mentioned.Message ID: @.***>

HI Mark, This PR contains changes for multiple release such as PCLM, Secret store, some documentation changes. Since, we did not release PCLM yet, i would like to refer this once we release PCLM. After which i will close this PR. Regards Nidhi

Thanks for the update. Let me know if you want to split out the PCLM stuff and publish the rest. Otherwise, I'll wait to hear from you.

@Nidhi251289 Hey Nidhi, what's the status of this one? Shall I delete it?

Closing it should be enough. Thank you!


Recycler no longer stacks material it grinds

Description

Reproduction

Screenshots

Additional context

yea it was cursed

huh? it worked for me yesterday
at least in my pr
https://github.com/space-wizards/space-station-14/pull/31518

Same for lathes when ejecting mats so not just recycler

huh? it worked for me yesterday at least in my pr #31518

I just reporta the issues, I do not understand why the issues exist

this is what it looks like in practice:

This also applies to fabs...

fixed by https://github.com/space-wizards/RobustToolbox/pull/5415


gulp editorconfig overrides existing file

If there is already an .editorconfig in the destination we need to prompt 'Are you sure?'. Obviously we could do this easily with the fs module however we'd have to manually build the path for this check, duplicating gulp.src logic which reads paths from the process.cwd() -- this duped code isn't difficult or really a problem, I just think it's worth doing a bit of research to see if there's a nice way to do this sort of thing with gulp.

Editor config now lives in boilerplate


Make Contact form more attractive also add stylish scrollbar in contact page.

I want to make contact form stylish by adding hover effects, shadow effects ect.
Also want to add Stylish Scrollbar in contact page.

@sunny0625 Please assign me this task !

@khushi-joshi-05 Please assign me this task !

@sunny0625 please check it and merge!
Thank you


For some reason RUB currency doesn't work:(

It says "Error - expected source or destination currency not in rates file".
And indeed, there is no RUB currency in eurofxref-daily.xml file.

This is the European Bank - See here:
"Owing to current trading activity in the EUR/RUB market, the European Central Bank (ECB) is not in a position to set a reference rate that is representative of prevailing market conditions. The ECB has therefore decided to suspend its publication of a euro reference rate for the Russian rouble until further notice. The ECB last published a EUR/RUB reference rate on 1 March 2022."

Maybe you can make it work through google? It may be not that accurate, but at least it works. Thank you.

Adding a second provider isn't a small change. I am busy with my work until late June, but will have a closer look after that and see if there is anything I can do.

Thank you!


error when executing install.sh from some other directory

Confirm
Are you using fish v3.0+?
Describe the bug
I get error when I run install script from some other directory
Expected behaviour
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

This issue has been fixed in #22


New package: Photon v0.1.0

Registering package: Photon
Repository: https://github.com/neurallayer/Photon.jl
Created by: @jbaron
Version: v0.1.0
Commit: ca4cc9529fd169e1d921c1046476a49c927e55f2
Git reference: master

Your new package pull request does not meet all of the guidelines for automatic merging.
Specifically, your pull request does not meet the following guidelines:

The following dependencies do not have a compat entry that has an upper bound: Knet, MacroTools

If you want to prevent this pull request from being auto-merged, simply leave a comment.
(If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.)

It is important to note that if your pull request does not meet the guidelines for automatic merging, this does not mean that your pull request will never be merged. It just means that your pull request will require manual review by a human.

These guidelines are intended not as requirements for packages but as very conservative guidelines, which, if your new package or new version of a package meets them, it may be automatically merged.

On a separate note, I see that you are registering a release with a version number of the form v0.X.Y.
Does your package have a stable public API? If so, then it's time for you to register version v1.0.0 of your package. (This is not a requirement. It's just a recommendation.)
If your package does not yet have a stable public API, then of course you are not yet ready to release version v1.0.0.

[noblock]

Your new package pull request does not meet all of the guidelines for automatic merging.
Specifically, your pull request does not meet the following guidelines:

I was not able to install and import the package. See the Travis logs for details.

If you want to prevent this pull request from being auto-merged, simply leave a comment.
(If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.)

It is important to note that if your pull request does not meet the guidelines for automatic merging, this does not mean that your pull request will never be merged. It just means that your pull request will require manual review by a human.

These guidelines are intended not as requirements for packages but as very conservative guidelines, which, if your new package or new version of a package meets them, it may be automatically merged.

On a separate note, I see that you are registering a release with a version number of the form v0.X.Y.
Does your package have a stable public API? If so, then it's time for you to register version v1.0.0 of your package. (This is not a requirement. It's just a recommendation.)
If your package does not yet have a stable public API, then of course you are not yet ready to release version v1.0.0.

[noblock]

Automerge is unhappy because automerge runs on the latest stable release, which in this case is Julia 1.2. But this package requires Julia 1.3.
That's fine. We'll merge this PR manually. Once Julia 1.3 is released, then we'll stop running automerge on 1.2 and will start running automerge on 1.3.
[noblock]

Your new package pull request does not meet the following guidelines for auto-merging:

I was not able to install and import the package. See the Travis logs for details. Please make sure to read all of the Travis logs for all jobs. In particular, make sure to look at the logs for all Julia versions.

Note that the guidelines are only required for the pull request to be merged automatically. However, it is strongly recommended to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human.

If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.


Github template fixes

Q
A

Bug fix?
yes

New feature?
no

API breaks?
no

Deprecations?
no

Related tickets

License
Apache 2.0

What's in this PR?

Github Template issues:
support-questions.yml not rendering due to indention issue
Added placeholder versions to k8s version textbox
Sorry for the back to back PRs. Don't think I can test/render these changes outside of the master branch...

No problems :)


Await an animation to complete

Hello,
Great library! :-)
Question: I understand that I can issue several animations on the same model and get all the animations perform at the same time (provided that they animate different properties). What about if I want to animate a sequence, how do I "await" for an animation to complete?
Many thanks!

Starting an animation returns a Promise which you can either await or provide a continuation function.

await (not sure if every device supports async/await)$scope.runAnimation = async () =>
{
    await $scope.fadeOut("model")
    console.log("Fading out done.")
}

Continuation function (this should work everywhere but is not so nice to use):$scope.runAnimation = () =>
{
    $scope.fadeOut("model").then(() => console.log("Fading out done."))
}


is "ServerReflection service" part of php-grpc ?

I'm testing out with grpc_cli and I get a successful call:
$ grpc_cli call --protofiles service.proto  <IP_ADDRESS>:9002 Echo.Ping 'msg: "Nico"'
connecting to <IP_ADDRESS>:9002
msg: "NICO"

Rpc succeeded with OK status
Reflection request not implemented; is the ServerReflection service enabled?

but the last message suggests that I have to do something similar to
https://github.com/grpc/grpc-go/blob/master/Documentation/server-reflection-tutorial.md
In the go libraries this support is part of the tool, but php-grpc doesn't seem to have a similar way to do this.
Is there a non-documented feature that could enable this easily?

PHP-GRPC currently does not support this feature. There is a limitation of how the proxy is operating. We will def going to take a look at it in the future. Any help appreciated.

Can you expand on the limitation ? I'll be happy to give a hand on this if needed... but I want to understand the problem a little bit better.

Currently, php-grpc does not compile profobuf definition in order to operate. I just parse the original proto file to get the list of methods and services. It might not be enough for reflection API. To change it, we have to load compiled proto file into proxy (in binary form). It's not hard but it will require some changes in the integration flow.
Reference:
https://github.com/spiral/php-grpc/blob/master/service.go#L171


Remove Google+ from social icon list examples

Given the changes in Google Plus focus ("On April 2, 2019, Google+ will be shut down for consumers"), I suggest the "G+" logo be removed from social sharing examples.
See https://www.ampstart.com/components#links-and-sharing

There are a total of 12 references to gplus that I found:

https://github.com/ampproject/ampstart/search?q=gplus&unscoped_q=gplus

I'm working on a pull request to remove them.


Minimum deployment target

Add info about minimum deployment target for iOS platform required by the pod.

    installer.pods_project.targets.each do |target|
      target.build_configurations.each do |config|
        current_target = config.build_settings['IPHONEOS_DEPLOYMENT_TARGET']
        minimum_target = '11.0'
        if current_target.to_f < minimum_target.to_f
          config.build_settings['IPHONEOS_DEPLOYMENT_TARGET'] = minimum_target
        end
      end
    end

where minimum_target is you min target, so it will update only if it less
add this inside Podfile.


Update update-record-factory.ts  -> Fixes #30 and #28

When we are not editing the images and multiple option is on, it should not try to update them.
fixes #30 and #28

Please review this PR.


Perhaps "Zitify" is not the best marketing verb

Hi. I listened to Clint Dovholuk's DeveloperWeek Cloud's talk. Ziti looks useful, we'll be giving it a whirl, but please, please on your website, change "Zitify your application". It scans as "Zit-ify your application". I don't want to turn my application into a giant puss-filled pimple ;-)

bahahahahahahahah - the funniest part is that you're not the first person to notice that. Sounds like something must be done. :)

we use ziti-enabled or ziti-embedded more now


Next release

PR for 3.14.0 release

The branch alias in the composer.json also needs updating.
NB Using a next branch instead of committing dev work to master like was previously done has the disadvantage that composer can't fetch dev versions of the software.


ILO with ID .<IP_ADDRESS>.<IP_ADDRESS>.4.10 [Missing SNMP Polling Profile]

ILO with ID .<IP_ADDRESS>.<IP_ADDRESS>.4.10 [Missing SNMP Polling Profile]
Device Vendor: HP
Device Model: ILO
System Object Identifier (SysOID): .<IP_ADDRESS>.<IP_ADDRESS>.4.10
List of critical metrics that you expect in the profile (does not need to be all-inclusive, just a general idea of your expectations):

CPU
IP
Memory
Process Count

Please provide a public gist with a sanitized (sensitive information removed) SNMP walk of the device. Providing MIB files is not a substitute for an SNMP walk and failure to provide one here will result in delays for closing this issue. The output of these commands shows the "true story" of what a device will respond to in SNMP and is used to ensure that our profiles are efficient and accurate for your devices.
Gist Link:  https://gist.github.com/AjeetK/0f9437d6405fc1f245bec283c6ec21d9

Example SNMP walk commands:
# v2c example
snmpwalk -v 2c -t 10 -On -c $COMMUNITY_STRING $IP_ADDRESS . >> snmp_walk.out

# v3 example
snmpwalk -v3 -t 10 -l authPriv -u $USERNAME -a MD5|SHA -A $AUTH_PASS -x DES|AES -X $PRIV_PASS -ObentU -Cc $IP_ADDRESS . >> snmp_walk.out

@AjeetK - this was resolved with PR #244 - you should be good with the latest image now; thanks

@thezackm I pulled the latest image again and this time its not even showing the uptime, IP and other couple of metrics which it was showing before. In short, no metrics are available now.

can you email me your NR account ID please? I think what's happening is that you used to see a Kentik Default entity type and now that we have an SNMP profile for this device we need to build a new entity for it so it shows up in the UI properly. I'll need to look at your data to validate and build the new entity definition.
zmutchler<at>newrelic.com

@thezackm I have shared the account ID over email.
Thanks!

@thezackm The ILO section is now showing up. Thanks for the release!
The ILO section is showing under "others" tab, instead, it should come under "Network" tab.
Thanks!

We have internal PRs submitted to update the categorization of the ILO entity.


Reduce installs during merge checks

For this to work you need to update poetry:

make sure you do not have an IDE or console open that has been using poetry
in console, type "poetry self update"
on windows, you might get a problem when you start to use poetry after upgrade; you get an error that says something like "cannot import name 'main'". The resolution for this error is the comment of spex66 in this thread: https://github.com/python-poetry/poetry/issues/5377

The failure of codecov/patch is not related to this PR... bit strange that I get it here.


ValidatorCleanRestart: revert removal of sleep before generating blocks

Let's see if this is still needed as it has started failing again but with unrelated changes.
Once the underlying problem is fixed we should be able to remove this sleep again.

I don't think the removal of sleep is related to the failure on CI because I saw the same error before the change. The following is what I stored for solving issue #2971. I think that failure happens rarely.
2022-02-17 11:40:23,14 Warn [agora.network.Client.boa1xrval7gwhjz4k9raqukcnv2n4rl4fxt74m2y9eay6l5mqdf4gntnzhhscrh] - Client.attemptRequest 'getBlockHeaders' to addresses [agora://<IP_ADDRESS>/] FAILED after 2 attempts
======================================================================

Module tests failed: agora.test.ValidatorCleanRestart
core.exception.AssertError@source/agora/test/Base.d(1153): Check condition failed after timeout of 4 secs and 40 attempts: [source/agora/test/ValidatorCleanRestart.d:102] Client #7 did not receive tx in expected time for height 21
----------------
??:? void agora.utils.Utility.retryFor!(core.exception.AssertError).retryFor(lazy bool, core.time.Duration, lazy immutable(char)[], immutable(char)[], ulong) [0x1052f9470]


practical guidelines

Thanks for this nice library! What i would like to have is some guidelines on:

how would the typical REST CRUD look using tapestry?
would you recommend putting 'everything' (also non-dynamic queries) in this structure?

Hello. Thanks for the kind words.

how would the typical REST CRUD look using tapestry?

I'd say, it depends on whether or not the queries are complex enough that pgTAP tests seem necessary for them.
In my experience, usually select queries are more likely to contain business logic and/or dynamic conditional clauses, whereas insert/update/delete queries are much simpler in comparison. If the query is too simple e.g.
   DELETE from table where id = $1

then creating templates and pgTAP tests for it seems pointless. The only the kind of non-select queries I can think of where pgTAP tests can help is for UPSERT (INSERT INTO .. ON CONFLICT .. DO UPDATE kind of statements).

would you recommend putting 'everything' (also non-dynamic queries) in this structure?

In my personal projects, I have used tapestry for non-dynamic queries but not for all of them. If you have a non-dynamic query which has considerable business logic inside it, then it's recommended to write pgTAP tests and so tapestry could be useful in that case.
To answer your question more generally - you can think of tapestry as a tool that mainly solves 2 problems:

makes it easy to maintain dynamic queries
provides the guarantee that pgTAP tests run the exact same query as what the application runs

So if your queries are so simple that neither of the above 2 points benefit, then tapestry is not of much use.

Great, thanks! I'm really liking it so far. I was first happy user of cornucopia, but it does not (yet) support e.g. postgis types. I know sqlx and diesel do, but prefer more raw approach but did not really know how to set it up. Now I do, thanks!


Deleting a tsconfig.json file should clear it from out hot cache

Currently you need to hard reload atom.

Does this fix all things, not just tsconfig.json? I’ve been having a painful time dealing with outdated caching, usually due to switching from one branch to another. Atom generally figures out what’s happened eventually but atom-typescript doesn’t. It looks like this code is maybe generic enough but I’m too tired to read straight, so… #lazyweb question :).

Does this fix all things, not just tsconfig.json

No. We don't have any file watching for .ts files. So:

if you open file modFoo/a.ts. This will load the ts file + tsconfig for this file and keep it in memory.
close file (we have this file in cache now)
change branch.
open file modFoo/b.ts .... we will still have an outdated version of a.ts in memory, so your intellisence about stuff in a.ts will be wrong. This will resolve itself once you reopen a.ts.

TSServer should help here :heart:


devutils/validate_patches: Allow comments

Lines starting with '#' will be ignored.

Hmm, I didn't realize that quilt allowed comments in series files. If we're going to allow comments, then we should update all the utils and devutils to be consistent. I'll need to look into this further.

Usually I write comments directly in the series file. The final version of the file should probably not contain any, but it certainly helps while refreshing patches.
I would appreciate such an option, if it doesn't involve too many changes.

So far I have left notes about patches in the patch files themselves. I'm not entirely sure what I would use comments for in the series file. How are you using this in your workflow?

Mostly to toggle inclusion of patches and sometimes for notes while updating them. There are of course other ways to handle it.


Adds Dapr authentication handler

Description

This includes functionality which simplifies securing endpoints using Dapr API Token authentication
Fixes #682

Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #682
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[x] Code compiles correctly
[ ] Created/updated tests
[ ] Extended the documentation

I'm opening a draft PR to discuss the implementation. Is this how you imagined it?
// cc @rynowak @Tratcher

That's the right outline for implementing an auth handler. It is a strange use of an auth handler though, only accepting a single, hard-coded 'user' credential that doesn't give you any meaningful claims.

This looks pretty awesome! will need some integration tests for sure.

Yes! Will do. Just wanted to make sure implementation details was on right track before adding tests.

Will this be getting some traction? This pull request is very helpful when securing service controllers. I had to do this manually as well, so having this in the Dapr dotnet-sdk would help out a lot in the log run.

Please implement this.

/cc @rynowak

Thanks @bjorkstromm

Thank you for completing this merge. Much appreciated!


Performance optimizations

Hi @plone/volto-team,
do we have as a community a common place where we discuss and jot down notes on performance improvements for Volto?
It would be awesome to have something like Tiberiu's #2810
Do we have anything like that? Should we like start having one?

I don't like the pattern from #2810 because it is difficult to respond to and discuss individual messages.
My preference would be to create a new Issue for each performance improvement idea. If we want to be able to easily see them in one place, use a label or add them all to a Project.

For sure, we can turn it as a discussion. Anyway I don't think of Volto performance issues for itself rather than suggestions on deployment, configurations or hacks to achieve better results in projects.
Something as documentation for developers.
Then maybe some of these things can be brought back to core Volto if that's the case.

I see. Then I think https://community.plone.org/ is probably the best place to ask an open question like this for discussion, and if there are specific recommendations which are generally relevant, we should open issues to add them to the documentation.

Specifically, there are several potential sections to add a new chapter "Performance optimizations", either Configuration, Development recipes, or Deploying depending on its content.

My take here is that the official documentation should be the correct place for those kind of info, in a proper section like Steve suggested.


Polymer.dom.flush & observeNodes

In 1.x, Polymer.dom.flush() would cause the observeNodes callbacks to be invoke.
In 2.x (shadydom) this doesn't happen. If this is expected, could we update the README.md about this gotcha?
<dom-module id="x-sample">
  <template>
    <slot></slot>
  </template>

  <script>
    Polymer({
      is: 'x-sample',
      properties: {
        count: {
          type: Number,
          value: 0
        }
      },
      attached: function() {
        Polymer.dom(this).observeNodes(this._onNodesChange);
      },
      _onNodesChange: function() {
        this.count = Polymer.dom(this).children.length;
      }
    });
  </script>
</dom-module>

<button onclick="addNode()">add node</button>
<x-sample id="sample"></x-sample>

<script>
  function addNode() {
    Polymer.dom(sample).appendChild(document.createElement('div'));
    Polymer.dom.flush();
    console.log(sample.count);
  }
</script>

Yup, this is, unfortunately, a necessary breaking change. The return value from observeNodes is an object with a flush method. Will add this to the readme.

As justification, the reason that Polymer.dom.flush no longer flushes observeNodes callbacks is that Polymer.dom.observeNodes (and soon to be Polymer.FlattenedNodesObserver) relies on the native slotchange event when possible, which fires at microtask timing when a change in distribution occurs, and the browser exposes no way to "force" the event to fire (or to otherwise get information about whether distribution changed).
The only way to implement a flush would be to hold references to all FlattenedNodesObservers and then diff their current nodes against previous; holding the references would then leak without a mandatory dispose API, which would be too onerous and footgunny.  So we landed on just exposing a flush on the observer object returned, which at least provides a way to force synchrony for e.g. tests.

Fixed via https://github.com/Polymer/polymer/pull/4337.


why is the next message coming when commit function is not called?

Questions?
I want to receive one message at a time and receive the next message after processing the message.

I tried to set autoCommit as false.
but why is the next message coming when commit function is not called?

I want to receive one message at a time.
I think we can solve it by adjusting 'maxNumSegments' and 'maxTickMessages. I don't know the difference

how can i set max.poll.records ?

Environment

Node version: v12.13.0
Kafka-node version: ^5.0.0
Kafka version: 2.13-2.4.1

For specific cases also provide

Number of Brokers: 1
Number partitions for topic: 2

Include Sample Code to reproduce behavior
const kafka = require("kafka-node");

const consumerGroup = new kafka.ConsumerGroup(
  {
    kafkaHost: "<IP_ADDRESS>:9092",
    groupId: "mystericoTest",
    sessionTimeout: 15000,
    protocol: ["roundrobin"],
    fromOffset: "latest",
    outOfRangeOffset: "none",
    autoCommit: false,
    heartbeatInterval: 1000,
    // maxTickMessages: 1,
    // maxNumSegments: 1,
  },
  "social-monitor-dev"
);

consumerGroup.on("connect", () => {
  console.log("kafka consumerGroup connect");
});

consumerGroup.on("error", (err) => {
  console.error("ERR: ", err);
});

consumerGroup.on("message", (message) => {
  console.log(message);

});

Include output with Debug turned on
Thanks for your contribution!

I have the same question, message goes very fast. the queue seems not work.

You'll want ConsumerGroupStream instead.

You'll want ConsumerGroupStream instead.

Can you explain why?

Because that's literally what it's designed to do.
it allows you to pause the stream until it should be resumed (post commit)
This base api is more raw.
But note this library and concept is not very performant. you'll have to implement a lot of manual logic to get any decent performance.
Thomas and I were discussing options here: https://github.com/SOHU-Co/kafka-node/pull/1071
That PR shows a better design. I implemented this model using ConsumerGroupStream with a lot of manual pause/resume logic in our own code.
However, this library caused us so much trouble due to how buggy it is and bad performance that we ended up spending months just get off of kafka (We had a better design for our needs than Kafka anyways vs simply switching libraries).
I recommend looking into the newer libraries and maybe they have this partition aware consumer model implemented.
But if you insist on using this library, I suggest forking my fork https://github.com/aikar/kafka-node and going from there, as I have quite a few fixes that never got pulled here.


How does one implement this?

The quick start is supper confusing as is the documentation... i can not find any video documentaion or other resources...

Did you take a look at the included demo projects? Are they confusing as well?

How to animate left and right view differently?
sideMenuController.leftViewPresentationStyle =  .slideBelow
sideMenuController.rightViewPresentationStyle = .slideAbove
i set these property as above but right menu presentationStyle also like .slideBelow


Bundling and Minification (ASP.NET 4.x) example does not minimize and bundle

The example Bundling and Minification (ASP.NET 4.x) does not work as advertised. Bundled jsx files are not bundled into a single file and they are also not minified.
The following:
bundles.Add(new Bundle("~/bundles/main", new IBundleTransform[]
            {
                // This works the same as BabelBundle (transform then minify) but you could
                //add your own transforms as well.
                new BabelTransform(),
                new JsMinify(),
            }).Include(
                // Add your JSX files here
                "~/Scripts/Tutorial.jsx",
                "~/Scripts/Test.jsx"

                // You can include regular JavaScript files in the bundle too
                //"~/Content/ajax.js"
            ));

Gets rendered as two files, not bundled together:

Each file contains the full non-minified script. In fact there's a further bug. The content of Test.jsx is now inside of Tutorial.jsx and vice-versa!
As it stands Babel Bundling is pointless.

Please verify that debug=true is not set in Web.config and you are building in Release mode. You can also try installing an older version of ReactJS.NET to see if there was a regression.

Thanks for the swift reply, setting debug=false in Web.config worked! Maybe you should update the tutorial with this info.
Out of curiosity where are the bundled files located? Can't find the /bundles/ folder.

Off-hand I don't know where the bundled files are located, sorry..


Small optimisations of rd_to_date.

As per "Section 8 / First column" of the paper, we can replace
    let n = n % 146097 / 4;`
    let n = 4 * n + 3;

with
    let r = n % 146097;
    let n = r | 3;

which might improve the generated code. Unfortunately the Rust compiler doesn't seem to be able to do it on its own.
We can replace
    let m = m - 12 * nd;

with
    let m = if nd == 1 { m - 12 } else { m };

Fortunately, for the first expression above the compiler does not emit imul and it does not branch. Indeed, it uses a cmovb which is good. However, the same happens for the expression using the ternary operator. There's a difference though. Recall that nd is defined by
    let nd = (n >= 306) as u32;

and it is used in the calculation of y and m. For some reason, for the first expression, the compiler twice emits the cmp instruction to perform the (equivalent of the) comparison with 306. For the second expression, only one cmp is emitted.

Disclaimer: I'm one of the authors of the paper on which rd_to_date is based.
I'm not a Rust programmer and I didn't even compiled this PR. However, I tried it on Compiler Explorer in [1] and [2] which show the assembly for the original and modified version.
Notice that [1]  contains an and (line 8) which is absent from [2]. This comes from  4 * (r / 4) which simply resets the two rightmost bits of r to 0 -- so the use of and. However, these bits are immediately set to 1 by the following or 3 and thus, the and is not necessary at all.
Notice also that [1] contains two cmp instructions (lines 22 and 25) and [2] contains only one (line 22).
Finally, [3] and [4] show the llvm-maca analysis for the two assemblies in  [1] and [2]. Amongst other things they show that the original code takes 33 cycles whereas the modified version takes 32 cycles. (Every little helps.)
[1] https://godbolt.org/z/745vo9e1P
[2] https://godbolt.org/z/d7qnPo37s
[3] https://godbolt.org/z/rasxxMhnq
[4] https://godbolt.org/z/9eYWTPKfK

Thank you, and glad to see you here! Great work on the paper!
I just approved workflows for this pull, so we should see automatic benchmarks showing whether there is an increase in performance or not.

The automatic github actions workflow tended to be too variable to accurately capture the impact of the changes - but by manually running the benchmark, I was able to crunch out this result:
rd_to_date              time:   [4.6730 ns 4.7464 ns 4.8347 ns]
                        change: [-6.7047% -4.6671% -2.6917%] (p = 0.00 < 0.05)
                        Performance has improved.

So, on average, %4.67 percent improvement, from 4.97 ns to 4.75 ns.

For what it is worth, you can easily compile and test Rust in Github Codespaces online in your browser, without installing anything locally and regardless of your operating system of choice:

Find the "<> Code" button from the pull or from the repository frontpage
Switch to tab "Codespaces" and create a new codespace on master
Wait until it all loads, and you see a terminal in the bottom of the VS Code
Run cargo install cargo-criterion
Run cargo criterion --bench basic -- rd_to_date --measurement-time 30 (or anything else that might be interesting)
The criterion benchmarks automatically compare against the last run, so you can switch to the upstream master branch, do one run, switch to your branch, and rerun the same run to see the possible improvement
Benchmarking is always flaky, so good confidence requires a couple retries to confirm nothing else impeded the results - and if there's anything surprising, it's probably just an artifact that goes away on the next run

Thank you for your interest in our work and for accepting my patch. We have other results on other calendar algorithms that are not covered by the paper. I'll come back to you later in other PRs or emails to discuss. Best wishes.

Hello again. You might be interested in my talk about this and other calendar algorithms:
https://www.youtube.com/watch?v=0s9F4QWAl-E
Although the talk was presented in a C++ conference, the algorithms are generic and the presented code is basically C that can be easily ported to Rust. I hope this helps.

Thank you for this! I will go through the presentation and see what I can adapt.


fix(smart-wallet): Improve error message for connection failures

Problem solved
Short description of the bug fixed or feature added

PR-Codex overview
This PR improves error handling in smart wallet connection by providing a more informative error message when encountering an RPC error.
Detailed summary

Improved error message when smart wallet connection fails due to RPC error
Added dynamic error message including original error message or "unknown error"

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

#4343  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @joaquim-verges and the rest of your teammates on  Graphite


Buttonbox Color field

Buttonbox color field  causes javascript related issues when I first try to add a block to an entry. It makes it even worse when it's inside of a supertable as it's stopping the rest of javascript work, all the fields won't stack but they spill out of the container. When I refresh a page, it's all good but when I add another field that contains buttonbox color field it's the same issue again unless I refresh or re-save an entry. Issue can be seen on the attached screenshot
Steps to reproduce

Create a buttonbox color field
Assign a field to an entry type
Open the console
There should be an error related to $container

Additional info

Plugin version: 4.0.3
Craft version: <IP_ADDRESS>
Multi-site: N

I'm not seeing this error when using any Button box field, sorry. The only instance where this is happening is within a Super Table field.
Fixed for the next release. To get this early, change your verbb/buttonbox requirement in composer.json to:
Craft 3
"require": {
  "verbb/buttonbox": "dev-craft-3 as 3.0.2",
  "...": "..."
}

Craft 4
"require": {
  "verbb/buttonbox": "dev-craft-4 as 4.0.3",
  "...": "..."
}

Then run composer update.

Fixed in 3.1.0 and 4.1.0.


Create a new CONTRIBUTING.md file and adding a How to Contribute section in it.

Suggestion to Add a CONTRIBUTING.md file.
I think a "How to Contribute" section in the CONTRIBUTING.md file would be a great addition. This section could provide new contributors with a clear guide on how to get involved, including steps like:
1.Setting up the project locally
2.Finding good first issues
3.Coding standards or style guidelines
4.Creating pull requests
Adding these details could make it easier for new contributors to get started and increase overall contributions to the project. Can u assign this issue to me under hacktoberfest label?

Hello @tepinly  ! I noticed I was assigned and then unassigned from the documentation update issue I opened. Is there anything specific you’d like me to adjust, or was there a change in priority? Happy to make updates as needed, just let me know!

I would like to take this issue.Please assign it to me. THANKS


🐛 Fix validator Error

#2  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @mingi3314 and the rest of your teammates on  Graphite


Created using module with few corrections

I run your unit test code using module. You can have a look at it.

We did it in our code. Thankyou.


Add scoreboards with time intervals

Because the current "all-time" scoreboard is kind of unfair, I suggest adding different scoreboards based on the current week, month and läsperiod. Change the default scoreboard to something more  relevant, such as läsperiod.
:~]

+1

Study period isn't trivial to implement since it isn't all that easy to get the date when the study period starts and ends. The rest however should be bit av kaka.


Add more ASP.NET metrics

This PR adds aspnetcore_requests_total as well as aspnetcore_requests_current_total metrics.
/cc @gr-liam

I think you forgot to increase the metrics, and we might not need the counteraspnetcore_requests_total because we already have this infoaspnetcore_requests_duration_seconds_count. But the concurrent connections gauge is very handy :)

I think you forgot to increase the metrics

Thanks, added the missing inc/dec. Not too sure how to test this properly though..

and we might not need the counter aspnetcore_requests_total because we already have this info aspnetcore_requests_duration_seconds_count

Are you saying that Histogram.Count would be equivalent to a Total Requests counter?

Thanks, added the missing inc/dec. Not too sure how to test this properly though..

Yeah, testing might be challenging right now, maybe adding black-box testing or introducing interfaces, but these are major changes. I am waiting for @alexvaluyskiy to listen to his plan.

Are you saying that Histogram.Count would be equivalent to a Total Requests counter?

Yes, if you measure the latency of every request then you are also measuring the number of requests.
You can try this.
sum(rate(aspnetcore_requests_duration_seconds_count{namespace="$namespace", service="$container", code=~"[2-3]..", pod=~"$pod"}[$interval])) by (service, namespace, route, method, code)


Option to exclude components from chunk-extraction

🚀 Feature Proposal
Add possibility to exclude certain chunks from chunk extraction.
Motivation
I'm currently implementing a simple partial hydration functionality in my SSRed app. Basically I check if we're in the browser-environment and if so, I just use dangerouslySetInnerHTML={{ __html: '' }} to keep the SSRed HTML element with its content instead of hydrating it.
This might save a bit of execution time, but the problem is that the whole JS for creating the component is still downloaded and parsed on the client.
Ideally there would be a flag you could set in your loadable-component that excludes it from chunk-extraction so that the chunk never gets added as script tags and therefore never gets downloaded.
Of course when using this flag, you'd need to make sure that the component will actually never (tried to be) imported in your browser environment.
Example
See my commit: https://github.com/gregberge/loadable-components/commit/5b3614004e213b6b72d7f2f4867e0a4615c9dcb6
Pitch
Partial hydration is coming and there's nothing we can do about it 😄

I just use dangerouslySetInnerHTML={{ __html: '' }} to keep the SSRed HTML element with its content instead of hydrating it.

👉 Wrap "partial hydrated" components with another ChunkExtractorManager, to suppress any information coming from them.
This is basically the best, and the only correct way to handle the problem - attack it from the "I don't need js code for this block" angle.


Feat: Buffer api(WIP)

Work in progress Buffer API,
What's Changed:
I wanted to work on a mongo driver but that meant implementing bson and i realised theres no real buffer api.
You could probably hack something together with strings but i decided to write a atm very rough idea of a buffer api extremely inspired by node.js`s buffer api.
I open this to get feedback about everything i did wrong 😅
Type of Change:

[ ] Bug fix
[x] New feature
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Housekeeping:
TODO:

[ ] Tests have been updated to reflect the changes done within this PR (if applicable).
[ ] Documentation has been updated to reflect the changes done within this PR (if applicable).

Screenshots (If Applicable):

This is super cool. Reminds me that we still need to get that native bytes type implemented.
As for the PR, I'll refrain from commenting until you're ready but I'll mention there's a few places that still have the original code / names from the copy/paste. I do the exact same thing. :)
Side note, and happy to take to a different forum like the discussion section but would love to understand your uses of Dictu!

I wonder mostly if theres a way to reduce the copy paste for the integer methods which currently take up the majority of the file and only contain very small differences, thinking to have a generalised read/write to reduce it and then just have the typecast to the correct integer type.
Regarding forum you can mail me<EMAIL_ADDRESS>or discord: liz3

Damn yeah this looks really neat! What I'll do with it being WIP is mark it as draft, then just mark it as ready whenever you're good to go!

Sorry for being slow on this! @briandowns be good to get your thoughts on this one too if you get a spare moment!

Couple of pretty minor points, thanks so much for the effort on this!

Should be addressed.

Why do the tests for *nix likes take 2 hrs? Is this coming from my changes or githubs runners?

My guess is that it's the runners. On Linux, MacOS, and FreeBSD, (locally) the suite runs very quickly.

Thanks so much for this!


Error after first install: Cannot read property 'notifications' of null

I've just created a new project running "npx create-social-network my-network" and try to run the project with "yarn start" and I've received an error message on the console:
[GraphQL error]: Message: Cannot read property 'notifications' of null, Location: [object Object], Path: getAuthUser
index.js:1 Error: Cannot read property 'notifications' of null
    at new ApolloError (index.ts:49)
    at QueryData._this.getQueryResult (QueryData.ts:355)
    at QueryData.getExecuteResult (QueryData.ts:139)
    at QueryData.execute (QueryData.ts:64)
    at useBaseQuery.ts:70
    at useDeepMemo (useDeepMemo.ts:18)
    at useBaseQuery (useBaseQuery.ts:69)
    at useQuery (useQuery.ts:12)
    at App (App.js:23)
    at renderWithHooks (react-dom.development.js:14803)
    at updateFunctionComponent (react-dom.development.js:17034)
    at beginWork (react-dom.development.js:18610)
    at beginWork$1 (react-dom.development.js:23179)
    at performUnitOfWork (react-dom.development.js:22157)
    at workLoopSync (react-dom.development.js:22130)
    at performSyncWorkOnRoot (react-dom.development.js:21756)
    at react-dom.development.js:11089
    at unstable_runWithPriority (scheduler.development.js:653)
    at runWithPriority$1 (react-dom.development.js:11039)
    at flushSyncCallbackQueueImpl (react-dom.development.js:11084)
    at flushSyncCallbackQueue (react-dom.development.js:11072)
    at scheduleUpdateOnFiber (react-dom.development.js:21199)
    at dispatchAction (react-dom.development.js:15660)

System
Browser version: Version 86.0.4240.193 (Oficial version) 64 bits
Node.js version: v10.19.0
NPM or Yarn version: yarn version 1.22.5
Operating system: Ubuntu 20.04
Steps to reproduce
(Write your steps here:)

npx create-social-network my-network
cd my-network
yarn start

Expected behavior
Have the project running on port 3000 as well.
Actual behavior
Application is break.

Reproducible demo
None
Additional context
None

Hi @jamesalvaro, can you confirm that you are using the shared database? The demo database is being deleted and populated with demo data daily: https://github.com/dimiMikadze/create-social-network/#requirements-and-configuration
So in my opinion your user has been deleted from the database. To fix it, just remove the token from the local storage. localStorage.removeItem('token') run this command while on localhost:3000 in the browser's console.
To avoid similar issues, create your own MongoDB database either locally or in the cloud, and connect to the app. We'll be dropping support for the shared database in the near future, anyway.

Thank you @DimiMikadze !


Fixed example with output variable

I detailed a bit example with variables and fixed bad example with output variables

@kmadof : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@kmadof  Thank you! It's great to get someone new's perspective on this!
#sign-off

@juliakm Thank you! I'm happy that I could improve docs which I used widely.


Add features to show feedback to post

For each of the blog post written by the users add emojis so the reader can give feedback to the post.

i am interested to work on this issue.

@gaurav618618 Sure, have a go.

should i make any changes or is it looking good?

@gaurav618618 Great job. Only one suggestions the label of the comment is not properly aligned . Can you please fix that?
Thanks!

Does it look better now?

@gaurav618618 Yeah, go ahead!

Resolved in #27


Bordless Windows when Float Windows

Hi
I have the Main Window Bordless , and i have write the write all code for resizing and moving with code
i want that also the window floating once time that i drag out the main window have the window bordless , how can do ?

Have a look at the documentation here on customizing FloatWindows
http://docs.dockpanelsuite.com/en/latest/tutorials/customizing-floatwindow.html

Thanks , i try

I have tried ,
i have put FormBorderStyle = FormBorderStyle.None;
but of course i have to manage the move and resize
and i do with a code
after i insert the code for move window but i have result a strange effect
may be i put in wrong position my code
private void lblTitolo_MouseDown(object sender, MouseEventArgs e)
{
Wal_MouseDown2(sender, e);
}
    private void lblTitolo_MouseMove(object sender, MouseEventArgs e)
    {
      Wal_MouseMove2(sender, e);
    }

    private void lblTitolo_MouseUp(object sender, MouseEventArgs e)
    {
      Wal_MouseUp2(sender, e);
    }

const int WM_NCHITTEST = 0x0084;
const int HTCAPTION = 2;
const int HTLEFT = 10;
const int HTRIGHT = 11;
const int HTTOP = 12;
const int HTBOTTOM = 15;
const int HTBOTTOMLEFT = 16;
const int HTBOTTOMRIGHT = 17;
const int HTTOPLEFT = 13;
const int HTTOPRIGHT = 14;
private bool dragging;
private bool resizing;
private bool resizingUp;
private bool resizingDown;
private bool resizingLeft;
private bool resizingRight;
private int border = 8;
private Size previousSize;
private Point previousLocation;
private Point offset;
 protected override void WndProc(ref Message m)
    {
        if (!FormLock)
        {
            int dist = 20;
            if (m.Msg == WM_NCHITTEST)
            {
                Point pt = PointToClient(MousePosition);

                if (ClientRectangle.Contains(pt))
                {
                    if ((pt.X < dist) && (pt.Y < dist))
                    {
                        m.Result = (IntPtr)HTTOPLEFT;
                        return;
                    }
                    else if ((pt.Y < dist) && (pt.X > ClientRectangle.Width - dist))
                    {
                        m.Result = (IntPtr)HTTOPRIGHT;
                        return;
                    }

                    else if ((pt.X < dist) && (pt.Y > ClientRectangle.Height - dist))
                    {
                        m.Result = (IntPtr)HTBOTTOMLEFT;
                        return;
                    }
                    else if ((pt.Y > ClientRectangle.Height - dist) && (pt.X > ClientRectangle.Width - dist))
                    {
                        m.Result = (IntPtr)HTBOTTOMRIGHT;
                        return;
                    }

                    else if (pt.X < dist)
                    {
                        m.Result = (IntPtr)HTLEFT;
                        return;
                    }

                    else if (pt.Y < dist)
                    {
                        m.Result = (IntPtr)HTTOP;
                        return;
                    }
                    else if (pt.X > ClientRectangle.Width - dist)
                    {
                        m.Result = (IntPtr)HTRIGHT;
                        return;
                    }
                    else if (pt.Y > ClientRectangle.Height - dist)
                    {
                        m.Result = (IntPtr)HTBOTTOM;
                        return;
                    }
                    else
                    {
                        m.Result = (IntPtr)HTCAPTION;
                        return;
                    }
                }
            }

        }
        base.WndProc(ref m);
    }

    private void Wal_MouseDown2(object sender, MouseEventArgs e)
    {
      //  if (!FormLock)
        {
            dragging = true;
            offset = e.Location;
            if (resizing)
            {
                previousSize = this.Size;
                previousLocation = this.Location;
            }
        }
    }

    private void Wal_MouseUp2(object sender, MouseEventArgs e)
    {
       // if (!FormLock)
        {
            dragging = false;
            resizing = false;
            resizingUp = false;
            resizingDown = false;
            resizingLeft = false;
            resizingRight = false;
        }
    }

    private void Wal_MouseMove2(object sender, MouseEventArgs e)
    {
      //  if (!FormLock)
        {
            resizing = false;
            if (dragging)
            {
                if (resizing)
                {
                    //setLabelInfo();
                    Point currentScreenPos = PointToScreen(e.Location);
                    if (resizingLeft)
                    {
                        if (resizingUp)
                        {
                            this.Width = previousLocation.X + previousSize.Width - currentScreenPos.X + offset.X;
                            this.Height = previousLocation.Y + previousSize.Height - currentScreenPos.Y + offset.Y;
                            this.Location = new Point
                            (previousLocation.X + previousSize.Width - this.Width,
                            previousLocation.Y + previousSize.Height - this.Height);
                        }
                        else if (resizingDown)
                        {
                            this.Width = previousLocation.X + previousSize.Width - currentScreenPos.X + offset.X;
                            this.Height = currentScreenPos.Y - previousLocation.Y + previousSize.Height - offset.Y;
                            this.Location = new Point
                            (previousLocation.X + previousSize.Width - this.Width,
                            previousLocation.Y);
                        }
                        else
                        {
                            this.Width = previousLocation.X + previousSize.Width - currentScreenPos.X + offset.X;
                            this.Location = new Point(previousLocation.X + previousSize.Width - this.Width, previousLocation.Y);
                        }
                    }
                    else if (resizingRight)
                    {
                        if (resizingUp)
                        {
                            this.Width = currentScreenPos.X - previousLocation.X + previousSize.Width - offset.X;
                            this.Height = previousLocation.Y + previousSize.Height - currentScreenPos.Y + offset.Y;
                            this.Location = new Point
                            (previousLocation.X,
                            previousLocation.Y + previousSize.Height - this.Height);
                        }
                        else if (resizingDown)
                        {
                            this.Width = currentScreenPos.X - previousLocation.X + previousSize.Width - offset.X;
                            this.Height = currentScreenPos.Y - previousLocation.Y + previousSize.Height - offset.Y;
                        }
                        else
                        {
                            this.Width = currentScreenPos.X - previousLocation.X + previousSize.Width - offset.X;
                        }
                    }
                    else if (resizingUp)
                    {
                        this.Height = previousLocation.Y + previousSize.Height - currentScreenPos.Y + offset.Y;
                        this.Location = new Point(previousLocation.X, previousLocation.Y + previousSize.Height - this.Height);
                    }
                    else if (resizingDown)
                    {
                        this.Height = currentScreenPos.Y - previousLocation.Y + previousSize.Height - offset.Y;
                    }
                }
                else
                {
                    Point currentScreenPos = PointToScreen(e.Location);
                    Location = new Point
                    (currentScreenPos.X - offset.X,
                    currentScreenPos.Y - offset.Y);
                }
            }
            else
            {
                if (e.X <= border)
                {
                    resizing = true;
                    resizingUp = false;
                    resizingDown = false;
                    resizingLeft = true;
                    resizingRight = false;

                    if (e.Y <= border)
                    {
                        this.Cursor = Cursors.SizeAll;
                        resizingUp = true;
                    }
                    else if (e.Y >= this.Height - border)
                    {
                        this.Cursor = Cursors.SizeAll;
                        resizingDown = true;
                    }
                    else
                    {
                        this.Cursor = Cursors.SizeAll;
                    }
                }
                else if (e.X >= this.Width - border)
                {
                    resizing = true;
                    resizingUp = false;
                    resizingDown = false;
                    resizingLeft = false;
                    resizingRight = true;

                    if (e.Y <= border)
                    {
                        this.Cursor = Cursors.SizeAll;
                        resizingUp = true;
                    }
                    else if (e.Y >= this.Height - border)
                    {
                        this.Cursor = Cursors.SizeAll;
                        resizingDown = true;
                    }
                    else
                    {
                        this.Cursor = Cursors.SizeAll;
                    }
                }
                else if (e.Y <= border)
                {
                    resizing = true;
                    resizingUp = true;
                    resizingLeft = false;
                    resizingRight = false;
                    this.Cursor = Cursors.SizeAll;
                }
                else if (e.Y >= this.Height - border)
                {
                    resizing = true;
                    resizingDown = true;
                    resizingLeft = false;
                    resizingRight = false;
                    this.Cursor = Cursors.SizeAll;
                }
                else
                {
                    this.Cursor = Cursors.Default;
                    resizing = false;
                    resizingUp = false;
                    resizingDown = false;
                    resizingLeft = false;
                    resizingRight = false;
                }
            }
        }
    }


Talonbane Cobra missing pilot skill text

Talonbane CObra doesent have his pilot ability in right window. At last in Polish Version

I don't have the Polish translation, but I'll restore the English text for now.


STORM-3102 Remove check for partition offset before every emit.

In kafka >0.10.2 this check became expensive, causing large performance
decreases.

+1


fix: DB URL override fails in some cases

The current fallback implementation doesn't work in the below case:

The APPSMITH_MONGODB_URI is set outside the container, and APPSMITH_DB_URL is set in the docker.env.

This scenario will be showing up a lot more now that the docker.env.sh that generates new docker.env files has APPSMITH_DB_URL in it.
Problem is that since we load env variables from both outside and docker.env individually, we end up loading both APPSMITH_MONGODB_URI and APPSMITH_DB_URL. And in this case, the APPSMITH_DB_URL will be from the just-generated docker.env, so we'll end up with a localhost URL, even though APPSMITH_MONGODB_URI was set to an external endpoint outside the container.
This is the problem we were facing with our DPs recently.
This PR fixes this problem by doing the env name "rename" separately for outside env variables, and once for docker.env env variables.
/test sanity

/build-deploy-preview skip-tests=true


Avoid RDF value materialisation.

Codecov Report
Patch coverage: 63.11% and project coverage change: -0.03 :warning:

Comparison is base (c9e2200) 71.47% compared to head (7442f2e) 71.44%.

:exclamation: Current head 7442f2e differs from pull request most recent head 7e56712. Consider uploading reports for the commit 7e56712 to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@             Coverage Diff              @@
##             latest      #45      +/-   ##
============================================
- Coverage     71.47%   71.44%   -0.03%
+ Complexity     3106     3103       -3
============================================
  Files           310      310
  Lines         20025    20033       +8
  Branches       3125     3116       -9
============================================
  Hits          14312    14312
- Misses         4478     4482       +4
- Partials       1235     1239       +4

Impacted Files
Coverage Δ

...om/msd/gin/halyard/common/IdentifiableLiteral.java
100.00% <ø> (+2.32%)
:arrow_up:

.../main/java/com/msd/gin/halyard/common/ValueIO.java
82.27% <ø> (+0.13%)
:arrow_up:

.../gin/halyard/function/IdentifierTupleFunction.java
68.42% <ø> (+6.51%)
:arrow_up:

...d/gin/halyard/function/TimestampTupleFunction.java
78.94% <ø> (+7.51%)
:arrow_up:

...java/com/msd/gin/halyard/sail/ElasticSettings.java
46.26% <ø> (-0.80%)
:arrow_down:

...in/halyard/sail/HBaseFederatedServiceResolver.java
51.72% <ø> (+0.84%)
:arrow_up:

...yard/sail/connection/SailConnectionGraphQuery.java
62.22% <ø> (+1.35%)
:arrow_up:

...main/java/com/msd/gin/halyard/spin/SpinParser.java
68.50% <0.00%> (ø)

...yard/algebra/evaluation/AbstractQueryPreparer.java
0.00% <ø> (ø)

.../strategy/collections/AbstractValueSerializer.java
14.70% <0.00%> (-0.92%)
:arrow_down:

... and 17 more

... and 1 file with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


github-bot comment only list the file but not list the formatted result

Refer to the screenshot. more details see this commit https://github.com/shenxianpeng/test-cpp-linter-action/commit/db1640735fec26e9b5b61c4c75403dce97d0028a

Here is yml file (I'm not sure if I wrote the wrong yml)
name: cpp-linter

# Triggers the workflow on push or pull request events
on:
  push:
  pull_request:
jobs:
  cpp-linter:
    name: cpp-linter
    runs-on: ubuntu-latest
    steps:
      - name: C/C++ Lint Action
        env:
            GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
        uses: shenxianpeng/cpp-linter-action@master
        with:
          style: 'llvm'
          extensions: 'c'
          version: '11'

Expected result:

if list the file, should also list the formatted result.
otherwise do not add comment

I'm not sure I understand.
hypothetically for checks run on 1 file:

If there is no warnings/errors output from clang-tidy, then the second list is not posted.
If there is no warnings/errors output from clang-format, then the fist list is not posted.

I have no idea why the output of clang-tidy wasn't posted for heloworld.c

clang-tidy wasn't posted should be I have no compile_commands.json in the repository.
This is the output of actions of new run: https://github.com/shenxianpeng/test-cpp-linter-action/runs/3397347792
Performing checkup on helloworld.c
Error while trying to load a compilation database:
Could not auto-detect compilation database for file "helloworld.c"
No compilation database found in /github/workspace or any parent directory
fixed-compilation-database: Error while opening fixed database: No such file or directory
json-compilation-database: Error while opening JSON database: No such file or directory

I have a sneaky feeling that it has something to do with the extension .c. I've only been testing this with .hpp & .cpp files. I still don't know why this is happening though.

I removed extension, the same result after rerun https://github.com/shenxianpeng/test-cpp-linter-action/commit/a874fe2e9b03362e45feb374f8f044e5c4e8f516

clang-tidy and clang-format auto-detect the language based on the file's name (based on its extension). Removing the extension from the action's workflow shouldn't effect how clang tools auto-detect the code's programming language.

I rename the source code from helloworld.c to helloworld.cpp, it works now. new result is here

hmm. I renamed the demo.cpp to demo.c and ran clang-tidy locally:
brendan@B-DESKTOP:/mnt/c/Users/ytreh/Documents/GitHub/cpp-linter-action$ clang-tidy -checks="boost-*,bugprone-*,performance-*,readability-*,portability-*,modernize-*,clang-analyzer-*,cppcoreguidelines-*" demo/demo.c
424 warnings generated.
/mnt/c/Users/ytreh/Documents/GitHub/cpp-linter-action/demo/demo.c:3:10: warning: inclusion of deprecated C++ header 'stdio.h'; consider using 'cstdio' instead [modernize-deprecated-headers]
#include <stdio.h>
         ^~~~~~~~~
         <cstdio>
/mnt/c/Users/ytreh/Documents/GitHub/cpp-linter-action/demo/demo.c:8:5: warning: use a trailing return type for this function [modernize-use-trailing-return-type]
int main(){
~~~ ^
auto       -> int
/mnt/c/Users/ytreh/Documents/GitHub/cpp-linter-action/demo/demo.c:10:13: warning: statement should be inside braces [readability-braces-around-statements]
    for (;;) break;
            ^
             {
/mnt/c/Users/ytreh/Documents/GitHub/cpp-linter-action/demo/demo.c:13:5: warning: do not call c-style vararg functions [cppcoreguidelines-pro-type-vararg]
    printf("Hello world!\n");
    ^
Suppressed 420 warnings (419 in non-user code, 1 with check filters).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

Clearly there might be something wrong with how the bash script is capturing the output. The demo's compile_commands.json file sets the -Werror flag, so maybe that's I went wrong... I'll keep looking into it.


Add License Preamble

Add a preamble and update the year in the LICENSE file.
J=SLAP-2191
TEST=none

Coverage remained the same at 51.461% when pulling 4637111ce98283588028c7d3a8bad5b608dbddc2 on dev/add-preamble into 45470d21d57a0e124b2f72a5ce9da6a2ddf837d6 on develop.


Input lag on web

When testing a_foggy_scene some of us got 5seconds+ input lag

Is this due to networking or slowdowns due to memory usage?

Still not sure yet, I managed to reproduce locally by saturating the bandwidth - I've noticed that web handles it way worse than native. I'll give more info once I have something more concussive.


Access to cs_detail?

For something I'm working with, I'd like to be able to access cs_detail and get back info about registers read and written. (It might be useful to just wrap the actual cs_detail struct and make it easy to get access to all of the various details?)
This will require having a binding to set cs_option to generate detail.

I'm currently working on exposing some of detail interface in my branch:
https://github.com/tmfink/capstone-rs/tree/cs-detail
I do not plan supporting cs_reg_read and cs_reg_write yet because they require instruction ids. The architecture-specific capstone includes (such as x86.h) are very large. We need to automatically parse them.


Implement automatic filtering if only unfiltered matrix is available

Hey @smoe, could you have a look at this and let me know what you think about it?


Add Scrollbar to lower area if necessary

Fixes #93

So the problem with just doing this is that we end up with a second scroll bar on the chat tabs, as well as the chat text overlapping the tab bar slightly.

You are right, i did not look at the chat view. Now, the scrollbar in in the tabs and not global, which is better anyway and works like a charm.
Cheers

Now with that change, I didn't notice anything different at all. I suspect because nothing has both of those classes at the same time. I tried a couple variations on that, but nothing made it better (only worse).


Install WPI 2017 libraries

All eclipse installations should be updated
The roborio should be reflashed and reimaged with the new libraries

 Install WPI 2017 libraries


Tests for incoming messages don't check that failure is due to the right reason

I think we should improve the tests for the following because it's far too easy to write tests that fail for the wrong reason:
https://github.com/relaycorp/relaynet-endpoint-android/blob/95a47a627f31fc4d5715b029ea7e342839b7e6d3/lib/src/main/java/tech/relaycorp/relaydroid/messaging/ReceiveMessages.kt#L68-L91
Maybe we should inspect the logs?
For example, the current implementation has a bug which the tests aren't uncovering: There are two catch blocks for the same exception:
https://github.com/relaycorp/relaynet-endpoint-android/blob/95a47a627f31fc4d5715b029ea7e342839b7e6d3/lib/src/main/java/tech/relaycorp/relaydroid/messaging/ReceiveMessages.kt#L82-L86
I came across this whilst implementing #48, because my tests were passing before I changed the unit under test.

So before I start I wanted to check with you, if I understand what you want ... solutions to better test the reasons collectParcels might/is failing... correct?

Yes. The current assertions are insufficient to tell the tests are passing for the right reasons.
BTW, I recently integrated log captor, a library to capture logs in tests.


[ListView] In 0.7.0-rc.2, an empty header is rendered

Hi,
with RN 0.7.0-rc.2, a header is rendered for each ListView taking approx. 40-50pixels, even when not specified. This has not been that way in 0.6.0:

The corresponding code is:
        <ListView
          dataSource={this.state.dataSourceImages}
          renderRow={this._renderRowImages}
          alwaysBounceVertical={false}
        />

When using sticky headers, it looks like this:

I noticed that something to do with the top content inset changed, possibly due to one of the Navigator diffs. Can you try adding these props to your ListView?
contentInset={{top: 44}}  // may need to play with this value
automaticallyAdjustContentInset={false}

Hi @ide: no change, I'm afraid.

@ide: Update - the following works:
          contentInset={{top: -24}}

Something definitely changed with contentInset and automaticallyAdjustContentInsets in 0.7.0. After upgrading, I had to change all my ListViews with
contentInset={{top:64}}
automaticallyAdjustContentInsets={false}

to
contentInset={{top:0}}
automaticallyAdjustContentInsets={false}

This is broken because I can achieve the same effect with automaticallyAdjustContentInsets={true}

@marcshilling I'm not using NavigatorIOS but Navigator and I don't see the property translucent there.

Update:
Using contentInset={{top: -20}} works as well for ListViews with sticky header if you modify line 276 of RCTScrollView.m (https://github.com/facebook/react-native/blame/522fd33d6f3c8fb339b0dde35b05df34c1233306/React/Views/RCTScrollView.m#L276) to if (idx > subviewCount) { instead of if (idx >= subviewCount) {.
@nicklockwood What do you say about that? In my case, both idx and subviewCount seem to be 0 in the call of the function.

@nicklockwood After upgrading to 0.7.X, I had to change this again manually. Do you have any idea here or do I have a conceptional issue here?

@PhilippKrone I'm seeing the same issue going from 0.6.0 to 0.8.0-rc (skipped a couple of versions)

When scrolling:

@marcshilling your solution of
contentInset={{top:0}}
automaticallyAdjustContentInsets={false}

Worked for me, not using NavigatorIOS here.

Same here. Above fixes the problem. Would be awesome to have a nice explanation of the above as currently it looks more like a glitch than feature.

@nicklockwood - this issue seems pretty stubborn, happening on master, none of the above fixes are working for me

I had to do this to avoid the blank space at the top of my ScrollView :(
var React = require('react-native');
var { ScrollView, } = React;

var MyScrollView = React.createClass({
  render() {
    return (
      <ScrollView {...this.props} style={[{marginTop: -15}, this.props.style]}>
        {this.props.children}
      </ScrollView>
    )
  }
})

module.exports = MyScrollVIew;

automaticallyAdjustContentInsets={false} should fix a lot of issues... @brentvatne can you try again?

@ide - yeah, it didn't help for me, I tried all of the suggestions above

Hm ok. Thanks for checking.

Maybe that's the case, for ListView it worked perfectly (I am having another issue with ListView not scrolling to top on navbar tap, but there was an issue about some weird race conditions causing that when multiple ScrollViews are embedded, need to head over there)

OK this looks like it is solved for ListView then, I'm going to close this issue so we can focus on ScrollView referenced above.

@ide @brentvatne FYI, the automaticallyAdjustContentInsets flag appears in the ScrollView docs but is undocumented:
http://facebook.github.io/react-native/docs/scrollview.html#automaticallyadjustcontentinsets

We should add a link to https://developer.apple.com/library/ios/documentation/UIKit/Reference/UIViewController_Class/#//apple_ref/occ/instp/UIViewController/automaticallyAdjustsScrollViewInsets

Does this help anyone in the short term?
https://github.com/facebook/react-native/issues/2151#issuecomment-128159054


Update lots of shaders to singlepass

Updates the majority of our shaders to support single pass instanced rendering.
Notable exception is SE Natural Bloom which is fairly complicated, and we may be switching it soon anyways.

Probably worth checking the CI with our supported android platforms before merging. :)

I expected the CI to need to recompile all of the shaders, but it doesn't seem to have needed to (at least based on the amount of time it took and lines like finished in 0.00 seconds. Local cache hits 12 (0.01s CPU time), remote cache hits 0 (0.00s CPU time), compiled 0 variants (0.00s CPU time), skipped 0 variants. I don't know anything about how shader compilation works, but did this... work?

Ideally this should be a set and done, I just need more time to investigate! I also think it's worth temporarily delaying a switch while you've got new shaders dropping imminently.


Default JDBC configs set autocommit=false which is undesirable

Behavior with postgres in particular is problematic with this setting. It results in "rollback on dirty commit" warnings and seems to lead to connection leaks.  It should still be settable but should not be the default.

Resorved by https://github.com/Novartis/YADA/commit/cfbdfdf9fac36647b8b39cd80001bd2e826841b8


New package: fet v0.1.0

Registering package: fet
Repository: https://github.com/MitsuhaMiyamizu/fet.jl
Created by: @MitsuhaMiyamizu
Version: v0.1.0
Commit: eec76015a646366e0b86d3c6236d5d98304cd88c
Git reference: HEAD
Description: An accurate and native implementation of Fisher's Exact Test for Julia.

Hi, I want to prevent this pull request from being merged, because I've made a few modification for full compliance of Automerge guideline. See pull request here: https://github.com/JuliaRegistries/General/pull/73425


Bug fix/internal issue #502 (#7480)

update iresearch

update iresearch

Please note that for legal reasons we require you to sign the
Contributor Agreement
before we can accept your pull requests.

http://jenkins01.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/2263/


Add #[inline] to indexing

Adding the #[inline] attribute to the indexing operators got a speedup of 15-30% on mul_acc_mat_vec_csr for some matrices. The benchmarks in this library does not gain or lose anything from this change.
Further observations: Changing to unsafe access in mul_acc_mat_vec_csr does not modify the performance characteristics compared to the safe version.

That's a good change, these short functions are good candidates for inlining.

The benchmarks in this library does not gain or lose anything from this change.

I don't think they test mul_acc_mat_vec_csr, what's tested there uses iterators, so this explains why there's no difference.
Thanks for finding this!

@vbarrielle I would expect all functions using SparseVector to benefit from this, including the benched function dot_dense. It might be that it is inlined automatically inside the crate, but does not pass across the crate barrier.

Yes that's very probable actually.


Contributor account not found?

I made a contribution to get access to site search and it's been a few weeks and haven't received an email with my account credentials.
I tried to do a forgot password and it says my email is not found.
Is this feature still supported? I tried contacting @zachleat via email and twitter DM and have not received a response in over a week.
Am I missing something? Any help would be appreciated.

Thank you, it's working now.


fix for system task with external payload storage

Pull Request Test Coverage Report for Build 3255

14 of 14 (100.0%)  changed or added relevant lines in 3 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.04%) to 70.218%

Files with Coverage Reduction
New Missed Lines
%

server/src/main/java/com/netflix/conductor/server/JerseyModule.java
1
90.91%

Totals

Change from base Build 3251:
0.04%

Covered Lines:
10275

Relevant Lines:
14633

💛  - Coveralls


MSEARCH-148 Support search by uniform title

Purpose/Overview
The current implementation of the title search includes searches by title, alternativeTitle, indexTitle and series.  There are, however, use cases that the librarian would like to search by the specified uniform title.  This is especially important for music libraries.
Requirements/Scope:

Add search option that will support uniform title search
The search will occur in the alternativeTitle field  when the title type is set to Uniform title
Not all records will have the uniform titles populated.
The key to the Uniform title should be retrieved by the call to /alternative-title-types.  Since this is a user-specified value - it is possible that it will not be present - this needs to be handled gracefully as well
The search by uniform title should follow the same rules as search by title

Approach

Implement UniformTitleProcessor which will be responsible for extracting uniform titles from alternative titles array
Replace persistent cache with TTL because the uniform title is librarian specified value and can be created after mod-search initialization
Implement unit and integration tests to prove implemented functionality
Rename InstanceIdentifierTypeCache  to InstanceReferenceDataService because now it's responsible for all reference data, not only for identifier ids
Fix incorrect mappings for source field
Exclude all empty values from the index - it was an unexpected side effect because SearchFieldsProcessor checks output value only for null, now it also checks for empty map and collection

Looks good. Thanks!