[Storage] should newPipeline() use the cached DefaultHttpClient instance by default?

if none is specified in the storage pipeline options?
When we fix client constructors to use the cached DefaultHttpClient instance by default, the newPipeline() function is not touched. The reason was that newPipeline() now is considered an advanced usage scenario so we should respect whatever is and is not in the option bag.
But customers migrating from v10 might not be aware of this since newPipeline() is the way to create a pipeline and use the pipeline to instantiate clients.
ServiceClient will create a DefaultHttpClient() if none is passed from the option.
Also do we want to treat the two cases differently?

option bag missing httpClient property
option bag has httpClient: undefined

@bterlson @xirzec

I think treating those two cases differently (e.g. checking the property presence) would be weird, since even though it's technically possible, most wouldn't think about it being a meaningful distinction. If we wanted a sentinel value, I think false or null would make more sense.

Agree. Prefer to treat them same.
Also reasonable for newPipeline() use the cached DefaultHttpClient instance by default. It's what we recommend. And customer can always specific a new http client object by options bag.

This is fixed in Pipeline constructor.


Update After tear down to call resetTestExpections()

Update After tear down to call local resetTestExpections() methods, it includes mockNetworkService.reset and TestUtils.resetTestExpections()

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

SetupCoreRule handles reseting already.  Closing the PR.


Resize both buffers on resize, clean up alt buffer state

From commits:

This brings in proper support to resize both buffers (#510) and Fixes an
exception that was caused by wrongfully not clearing the normal buffer when
resizing while the alt buffer is active.
There was an obscure bug in this that could have caused some great confusion
later on; When switching to the alt buffer, a hard terminal reset was performed
which tried to retain the buffers. However, because buffers was initialized in
the Terminal constructor to a new BufferSet, the Terminal.buffer convenience
pointer was pointing at a stale alt buffer which was the one actually being
used, not Terminal.buffers.alt.
Fixes #842
Fixes #510

The alt buffer is now cleared immediated after activating the normal buffer and
is filled when switching to it. The tests were failing because the alt buffer
wasn't being cleared properly with the previous solution.

Coverage increased (+1.1%) to 71.601% when pulling d46003843b80416490dc2819420601037ed04060 on Tyriar:842_resize_buffers_bug into f5ba386c01d6f4032c88a83812e530e10d5a7cb9 on sourcelair:master.

Coverage increased (+1.1%) to 71.601% when pulling 1361ff8e2271d232dd81c0a239a6d68983b5a3c1 on Tyriar:842_resize_buffers_bug into f7b58d071858579f97dbb53a384051647d8ce73d on sourcelair:master.

Coverage increased (+1.1%) to 71.601% when pulling 1361ff8e2271d232dd81c0a239a6d68983b5a3c1 on Tyriar:842_resize_buffers_bug into f7b58d071858579f97dbb53a384051647d8ce73d on sourcelair:master.


Error cross compiling from linux/amd64 to arm

Hi,
I setup my dev env to cross compile, my host is linux amd64 and trying to cross compile to arm givesme:
GOOS=linux GOARCH=arm go build
# github.com/huin/goserial
./serial.go:151: undefined: openPort
./serial.go:151: not enough arguments to return

but  GOOS=windows go build
builds fine and I end up with a exe binary of my project
if I compile from an arm (raspbery pi), it compiles fine. Any idea of what I may be missing?
Thanks

@fmpwizard Are you using this repo or the huin version?
It builds for me locally:
~/go/src/github.com/tarm/goserial (master %)$ GOOS=linux GOARCH=arm go build
~/go/src/github.com/tarm/goserial (master %)$
Please try with this repo (tarm/goserial) and reopen the issue if needed.


Upgrade to version 4.4.1 lts of bootstrap

[ x] I've read the guidelines for Contributing to Roots Projects
[x ] This request isn't a duplicate of an existing request
[ x] This is not a personal support request that should be posted on the Roots Discourse community

##Versions
9.0.9
Summary
Will they upgrade to version 4.4.1 lts of bootstrap?
https://blog.getbootstrap.com/2019/07/24/lts-plan/

tracking here: #2466


Job Sequencing Problem

AIM
Given a set of N jobs where each job i has a deadline and profit associated to it. Each job takes 1 unit of time to complete and only one job can be scheduled at a time. We earn the profit if and only if the job is completed by its deadline. The task is to find the maximum profit and the number of jobs done.
Note: Jobs will be given in the form (Job id, Deadline, Profit) associated to that Job.
Please Assign me under LGMSOC'2021 . I will be doing in C++ Language.
Programming language

[ ] C
[x] C++
[ ] Java
[ ] Python

@Ayush7614 I would like to solve this issue in Python. Please assign me this under LGM-SOC'21

Please assign me this issue under LGMSOC'21.
I would like to solve in java.


Bad file descsriptor in building with make in w64devkit on Windows 11

I was trying to compile llama.cpp on a Windows 11 laptop with the instructions provided here. However, while using make in w64devkit console for building in directories containing spaces in their names, the make command fails with the following error:
Z:/Lab Work/llama.cpp $ make
process_begin: CreateProcess(C:\Users\Asus, C:/Users/Asus pc/Downloads/w64devkit-fortran-1.21.0/w64devkit/bin/sh.exe -c "cc  -Wl,-v 2>&1", ...) failed.
Makefile:206: pipe: Bad file descriptor
process_begin: CreateProcess(C:\Users\Asus, C:/Users/Asus pc/Downloads/w64devkit-fortran-1.21.0/w64devkit/bin/sh.exe -c "{ cc -dumpfullversion 2>/dev/null || cc -dumpversion; } | awk -F. '{ printf(\"%02d%02d%02d\", $1, $2, $3) }'", ...) failed.
scripts/get-flags.mk:3: pipe: Bad file descriptor
expr: syntax error
expr: syntax error
I llama.cpp build info:
I UNAME_S:   Windows_NT
I UNAME_P:   unknown
I UNAME_M:   x86_64
I CFLAGS:    -I. -Icommon -D_XOPEN_SOURCE=600 -DNDEBUG -D_WIN32_WINNT=0x602  -std=c11   -fPIC -O3 -Wall -Wextra -Wpedantic -Wcast-qual -Wno-unused-function -Wshadow -Wstrict-prototypes -Wpointer-arith -Wmissing-prototypes -Werror=implicit-int -Werror=implicit-function-declaration -march=native -mtune=native -Xassembler -muse-unaligned-vector-move -Wdouble-promotion
I CXXFLAGS:  -I. -Icommon -D_XOPEN_SOURCE=600 -DNDEBUG -D_WIN32_WINNT=0x602  -std=c++11 -fPIC -O3 -Wall -Wextra -Wpedantic -Wcast-qual -Wno-unused-function -Wmissing-declarations -Wmissing-noreturn -Xassembler -muse-unaligned-vector-move  -march=native -mtune=native -Wno-array-bounds
I NVCCFLAGS:
I LDFLAGS:
process_begin: CreateProcess(C:\Users\Asus, C:/Users/Asus pc/Downloads/w64devkit-fortran-1.21.0/w64devkit/bin/sh.exe -c "cc --version | head -n 1", ...) failed.
Makefile:530: pipe: No error
I CC:
process_begin: CreateProcess(C:\Users\Asus, C:/Users/Asus pc/Downloads/w64devkit-fortran-1.21.0/w64devkit/bin/sh.exe -c "g++ --version | head -n 1", ...) failed.
Makefile:531: pipe: No error
I CXX:

g++ -I. -Icommon -D_XOPEN_SOURCE=600 -DNDEBUG -D_WIN32_WINNT=0x602  -std=c++11 -fPIC -O3 -Wall -Wextra -Wpedantic -Wcast-qual -Wno-unused-function -Wmissing-declarations -Wmissing-noreturn -Xassembler -muse-unaligned-vector-move  -march=native -mtune=native -Wno-array-bounds examples/main/main.cpp ggml.o llama.o common.o sampling.o grammar-parser.o build-info.o console.o ggml-alloc.o ggml-backend.o ggml-quants.o -o main
make: *** [Makefile:584: main] Error 3

In the above, the folders where w64devkit and the llama.cpp are located are different, and both the directory locations have spaces (i.e  Z:/Lab Work/llama.cpp and C:/Users/Asus pc/Downloads). I was able to build succesfully by placing the files in different folders named without spaces; however, I feel the need to support spaces in directory names is essential for a more flexible workflow.
I am raising this as an issue on both the repos (llama.cpp and wdevkit64) to both notify other users and the repo maintainers. Apologies for any typos.
Thanks

This is actually a known CreateProcess limitation, paths with spaces needs to be quoted.

I see it's hung up on a "$(shell ...)" in the Makefile. This should mostly
work even if the tools or your working directory contains spaces. If I put
both w64devkit and llama.cpp under paths with spaces, including different
drives like you showed, it works for me, and I'm unable to reproduce the
issue.
It's curious that the first argument to CreateProcess is populated. Make
normally leaves it null when starting sh.exe. That suggests it's picking
up something from your environment ($SHELL, etc.), or gets confused when
searching $PATH. However, nothing I try reproduces the issue. There must
be something in your environment triggering path-with-spaces bugs in GNU
Make.
As a kind of "strace" I ran make under gdb with dprintfs in kernel32.dll
(note: requires first starting once in order to load the DLL symbols):
(gdb) set new-console
(gdb) dprintf KERNEL32!CreateProcessA,"1=%s\n",$rcx
(gdb) dprintf KERNEL32!CreateProcessA,"2=%s\n",$rdx
(gdb) dprintf KERNEL32!SearchPathA,"fname=%s\n",$rdx
In my own experiments, and shown in your output, the command line string
is wrong, which is a Make bug. The executable path isn't quoted, making it
ambiguous, invoking CreateProcess magic following a documented process
that usually fixes it.
The SearchPathA argument also reveals Make is confused about $PATH and
searches for the wrong file names — another Make bug. I thought maybe if
you had something at "C:/Users/Asus" it would throw off that search, but
when I tried it myself I couldn't cause a build issue.

Can you suggest a way to log things better for debugging and reproducing the issue? Also there's no path as C:/Users/Asus on my system (so probably space is considered as a delimiter).

@VIS-WA  Could you try 1.19.0 version.
It's working well.


Bug: TableRowNode and TableCellNode's importDom methods don't take into account the element's height and width respectively

Every transformation (exportDOM, importJSON, exportJSON, createDOM) take into account a TableRowNode or TableCellNode's height or width, however trying to parse HTML (even if it was outputted by Lexical itself) doesn't set the height/width of the node. This seems like a mistake, however it's specifically only these two things that don't get imported.
Lexical version: 0.10.0
Steps To Reproduce

Create a lexical editor with the TablePlugin and the Table, TableRow and TableCell nodes
Implement some functionality for resizing TableCells or TableRows (I more or less replicated the logic provided in the playground.
Using $generateNodesFromDOM on some DOM that features a table, with rows that have style="height: xx" or cells that have style="width: xx"

The current behavior
The width/height in the DOM is ignored. Cell/Row nodes are added without these properties set
The expected behavior
These properties should get set, especially because they're already part of their corresponding classes.
Proposed solution
The constructors of these nodes already support receiving this sizing property, let's look at some code within the cell node. This code is ran to turn a dom node into a lexical table cell node.
export function convertTableCellNodeElement(
  domNode: Node,
): DOMConversionOutput {
  const domNode_ = domNode as HTMLTableCellElement;
  const nodeName = domNode.nodeName.toLowerCase();

  const tableCellNode = $createTableCellNode(
    nodeName === 'th'
      ? TableCellHeaderStates.ROW
      : TableCellHeaderStates.NO_STATUS,
  );
  tableCellNode.__colSpan = domNode_.colSpan;
  tableCellNode.__rowSpan = domNode_.rowSpan;
  const backgroundColor = domNode_.style.backgroundColor;
  if (backgroundColor !== '') {
    tableCellNode.__backgroundColor = backgroundColor;
  }

  return {
    forChild: (lexicalNode, parentLexicalNode) => {
      if ($isTableCellNode(parentLexicalNode) && !$isElementNode(lexicalNode)) {
        const paragraphNode = $createParagraphNode();
        if (
          $isLineBreakNode(lexicalNode) &&
          lexicalNode.getTextContent() === '\n'
        ) {
          return null;
        }
        paragraphNode.append(lexicalNode);
        return paragraphNode;
      }

      return lexicalNode;
    },
    node: tableCellNode,
  };
}

I believe the only necessary fix here is to include an additional line which reads the "width/height"
  const width = domNode._style.width;
  const tableCellNode = $createTableCellNode(
    nodeName === 'th'
      ? TableCellHeaderStates.ROW
      : TableCellHeaderStates.NO_STATUS,
      domNode_.colSpan,
      width || null,
  );
  tableCellNode.__colSpan =
  tableCellNode.__rowSpan = domNode_.rowSpan;
  const backgroundColor = domNode_.style.backgroundColor;
  if (backgroundColor !== '') {
    tableCellNode.__backgroundColor = backgroundColor;
  }

If the proposed solution works for you, I'd be willings to push a PR with the changes.

Makes sense, would appreciate PR for this one!

Hi is this issue still open

Hi @GMchris I would love to work on it.


why combine overseas and mainland together?

@l89669
Due to old title messing up data, e.g. "成神之日", "满溢的水果塔", etc. (They are overseas title, but moved to bilibili SEA, but some data still can access from main bilibili API, but you can only watch it from bilibili SEA), I decided to merged it.
(Something like "Running Man" entertainment series also included but it's overseas title)
You can just search "仅" to filter out some overseas title.


addTokenTransferWithDecimals() method not working

Description
Trying to use the addTokenTransferWithDecimals() to handle increasing the order of magnitude of a token but not making a difference.
Am on SDK "@hashgraph/sdk": "^2.45.0",
Steps to reproduce
e.g. this token has 4 decimals. would expect this to send 1 of tokenId but it sends 0.0001
const tx = await new TransferTransaction()
.addHbarTransfer(clientAccountId, -1)
.addHbarTransfer(secondId, 1)
.addTokenTransferWithDecimals(tokenId, secondId, 1, 4)
.addTokenTransferWithDecimals(tokenId, clientAccountId, -1, 4)
.setTransactionId(transactionId)
.setNodeAccountIds([new AccountId(3)])
.freeze()
.sign(PrivateKey.fromStringED25519(secondKey));
Additional context
No response
Hedera network
mainnet
Version
latest
Operating system
macOS

Hello @jaycoolslm
We tried to reproduce your issue by using the snippet you have provided. We made a transaction that transfers a token with decimals by executing addTokenTransferWithDecimals function.
After thoroughly done research, me and the team have concluded that addTokenTransferWithDecimals works as expected. Both addTokenTransferWithDecimals and addTokenTransfer both work the same way. They use the smallest part of a token similar to how hbar uses tiny bar when you transfer tokens and don't do any change to the amount like you expect.
The difference between the two functions is that addTokenTransfer skips the decimals validity check. addTokenTransferWithDecimals function checks if you've used the correct amount of decimals and it throws an INVALID_TOKEN_DECIMALS error if not. Other than that this function doesn't do any transformation like increasing the order of magnitude of a token you expected in your issue.
So given a token with 4 decimals and initial balance of receiver of 0 after the execution of this code snippet:
  const transferToken2 = await new TransferTransaction()
    .addTokenTransferWithDecimals(tokenId, receiverId, 1, 4)
    .addTokenTransferWithDecimals(tokenId, OPERATOR_ID, -1, 4)
    .addTokenTransfer(tokenId, receiverId, 4)
    .addTokenTransfer(tokenId, OPERATOR_ID, -4)
    .execute(client);

Receiver should have 5 of the smallest parts of a token or 0,0005.

Okay, so it's working as expected - but can't just be me who thinks it sounds quite counter intuitive?

We think Hedera SDKs should behave the same way in every aspect so we follow the same approach as the other SDKs. If we see a bump of issues similar to this we might have to rethink our strategy and change this everywhere. As of right now I think the thing we could do is we might have to improve the documentation to help other users like you.
Thank you for the feedback!


Reinforcement-learning Task Page

This is the tracker for completion of task page for reinforcement-learning task. Link to task page is here: https://huggingface.co/tasks/reinforcement-learning You can contribute parts of a task or the whole task! (There's no single assignee to a task, these are wikipedia-like pages)
You can refer to #369 if you want to contribute! 🤗
List of items to contribute:

[x] Task description
[x] Subtasks (if there is any)
[x] Most used dataset for the task
[x] Most used model for the task
[x] Metrics that are used to evaluate the task
[x] Libraries used for the task
[x] Use cases
[x]  Small snippet for inference that demonstrates the task
[x] Task Schema
[ ] Model for Widget

@merveenoyan I will be happy to contribute :)

Great!!! I'd like to briefly go through on what we want to do here 🙂 Task pages are documentation related to machine learning tasks. This is primarily aimed to educate software developers who want to simply know about the task, find a model, call a pipeline and build their first PoC. Some of the task pages are empty, some are full. The empty ones are the ones we appreciate community contributions for.
This is an example task page for text generation task: https://huggingface.co/tasks/text-generation and this is the page for RL, which is empty: https://huggingface.co/tasks/reinforcement-learning. We want community to help us fill these pages.
I explained the details in this issue: https://github.com/huggingface/hub-docs/issues/369
Would you like to fill the whole task or parts of it? Note that it might be overwhelming to take over all of it so I suggest taking a couple of parts and see if this works for you.
Please let me know of any questions if you have any 🙂

@osmanalenbey These are wikipedia-like pages, so you can contribute basic information about a task. Some task pages are already full, you can take a look at the page of text-classification for inspiration: https://huggingface.co/tasks/text-classification. The list of what you can contribute is already given above.

Task description
Subtasks (if there is any)
Most used dataset for the task
Most used model for the task
Metrics that are used to evaluate the task
Libraries used for the task
Use cases
Small snippet for inference that demonstrates the task

Hello!! I would like to contribute
can add one or two parts :)

@utkarsh0308 yes! you can! @02shanks can you both write down what you'd like to contribute to avoid duplication of efforts 🙂

I can work on Task description and then on Most used model for the task

@merveenoyan  I can't find the reinforcement-learning folder in my fork

Added reinforcement learning use cases #388

#388 Added Reinforcement learning use cases

@emiliolehoucq sure! 🙂

Awesome, thanks, @merveenoyan! I added to my to-do list. I'll ping you if I run into problems.

Hey @merveenoyan i can see the Inference and the Variants task is still open. will it be ok if i can contribute to those?

@shreyansjainn yep, you can :)

@merveenoyan great, thanks, will start working on this!!! if I can ask what is generally the timeline for these tasks? this is my first time contributing to OSS.

@shreyansjainn feel free to take your time, we have no hurry!

Lots of cool contributions! This is just missing the snippet now


Track expense - In track expense, edit amount shows dollar briefly

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.65-0
Reproducible in staging?: Y
Reproducible in production?: N
Found when validating PR : https://github.com/Expensify/App/pull/39956
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team
Action Performed:

Go to https://staging.new.expensify.com/home
Tap fab--- track expense
Enter an amount and tap next
Tap track expense
Tap on newly created expense to open details page
Tap amount to edit

Expected Result:
In track expense while amount in indian Rupee, edit amount must not show dollar briefly.
Actual Result:
In track expense while amount in indian Rupee, edit amount shows dollar briefly.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[x] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
https://github.com/Expensify/App/assets/115492554/3e90961c-8e37-4cc6-b53e-5597cfcb874c

View all open jobs on GitHub

@Christinadobrzyn I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

Seems like a second regression from https://github.com/Expensify/App/pull/39956 @shubham1206agra @thienlnam @allroundexperts
Its minor as well, can you follow up with a quick fix

demoting this as its minor but @shubham1206agra @allroundexperts assinging you as this is most likely coming from your PR

I think @shubham1206agra were unable to reproduce this. Is this correct @shubham1206agra?

I can't reproduce this either. I'll ask QA to test - https://expensify.slack.com/archives/C9YU7BX5M/p1714468168251599

Bug is still reproduced.
https://github.com/Expensify/App/assets/43996225/bdb940c5-553f-4106-9862-fea6f9447848

I'm still not able to reproduce this... @shubham1206agra or @allroundexperts can you test again and let me know if you get this?

Okay, I was able to reproduce this again when testing on iOS app - I uploaded the video to the OP and updated the steps.
Since this only seems to be affecting RP expenses, I'm kinda inclined to close this as a not critical, edge case, not part of our ROI. We can reevaluate it at a later time.
@thienlnam @allroundexperts what are your thoughts?

I agree, doesn't seem like something we need to fix at this time


Mask flags

Similar to
https://github.com/senzing-garage/g2-sdk-java/blob/53c4901e357bc222c7f6db005ef4267adb31cb0a/src/main/java/com/senzing/g2/engine/SzCoreEngine.java#L523
Mask out the SDK-only bits before passing a flag to the native SzEngine.

Fixed via https://github.com/senzing-garage/sz-sdk-go-core/issues/232


[BUG] ARC Tool issue - Empty Lable Text

Describe the Bug
An accessibility issue has been identified where a form control lacks an associated label text. This issue causes screen readers and assistive technologies to struggle in conveying the purpose of the control, violating WCAG 2.2 Success Criterion 1.3.1 (Info and Relationships).
To Reproduce
Steps to reproduce the behavior:

Open the web application.

Navigate to the "Confirm exchange set content" page.

Use a web accessibility testing tool (e.g., ARC Toolkit).

Observe the error regarding empty label text for checkboxes.

Expected Behavior
Each checkbox should have an associated <label> element with a clear and descriptive text to explain its function, enhancing accessibility and user experience.
Screenshots

Additional Context
This issue affects the accessibility of checkboxes used for selecting ENC items. The checkboxes lack proper label associations, making it difficult for users who rely on screen readers to understand the purpose of these controls. Ensure that each checkbox has an associated <label> element with a descriptive text to resolve this issue.

We need a mechanism to have aria - label without rendering the label text

https://github.com/UKHO/admiralty-design-system/pull/269


⭐  Token creation tool integration with nSPV, UI/UX improvements

Closes #203
Closes #100
Closes #216
Closes #199
Closes #173
Closes #223
This PR connects our token creation UI to actual RPC calls. It adds various UX/UI and validation improvements to the tool.
It also adds support for token creation outputs to be show as token balances in the dashboard (see worker changes).
That's it! 🎉

@acnebs addressed your comments.
Should we not optimistically add the token to your wallet as soon as it is created, without waiting for confirmation?
I tend to prefer to have the network tell us the state of any transactions. Thoughts @piggydoughnut?
Not sure I understand why "Collection" fills ID and they're not just the same field, yet if I enter the collection number manually the collection field does not fill with the collection name.
Collection ID and Collection name serve different purposes. We don't hold state of the full collection in the blockchain just yet, so saving collection name in each NFT is fine (for now). Once we have a better way to handle this (maybe having a token that represents the whole collection), we can drop name and keep just ID.
I've changed behavior just so typing an existing collection ID sets the correct name.

Looks great. Last two things are to change to this for performance and rather than individually setting tokenData types as identical Record<>s, defining that as a type in token-types.ts and using it wherever needed.

Ok, fantastic work @lenilsonjr, if nobody objects I will merge this into feature/token-creation now. Then we can let the binaries build and try to run them, then merge into development.

sounds good to me @acnebs 🙌 thanks for the review and committed improvements.


Support replication mode control

What is changed and how it works?
Part of #7097.
This PR adds a global group registry that stores the group ID of every met store. The information will be used for further implement of label based replication.
Check List
Tests

Unit test
Integration test

LGTM.


Coral Spectrum Tab uses only the color red to indicate that it's invalid

Expected Behavior
The Coral Spectrum Tab component shouldn't use only the color red to show that it is invalid, but also have a more obvious element. This would be an accessibility improvement, especially for color blind users.
Actual Behavior
Coral Spectrum Tab only uses the color red to indicate that it's invalid.
Reproduce Scenario (including but not limited to)
When working with a Coral Spectrum Tablist component and you have a Tab component set to invalid, the only difference is the red color.
Steps to Reproduce

Add Chromelens plugin for Google Chrome (https://chrome.google.com/webstore/detail/chromelens/idikgljglpfilbhaboonnpnnincjhjkd).
Start up the Coral Spectrum Tablist component examples page ( coral-component-tablist/examples/index.html ) by using gulp.
Go to http://<IP_ADDRESS>:9001/examples/.
From Developer Tools, go to Chromelens and select one of the following: Achromatopsia (RGB-Blind), Protanopia ( Red - blind ).
Check that the invalid tab is resembling all the other tabs.

Browser name/version/os (ie Chrome Version 62.0.3202.94 (Official Build) (64-bit) MacOS)
Google Chrome Version 80.0.3987.149 (Official Build) (64-bit)
Coral Spectrum version
4.3.1
Sample Code that illustrates the problem (use the Playground if possible)
Check coral-component-tablist/examples/index.html.
Screenshots (if applicable)
Example with Chromelens Achromatopsia:

Fixed with https://github.com/adobe/coral-spectrum/commit/282b4018145f78429ca5646936866e324f85694b


DocumentIndex: support for Elastic Search

Implement a Document Index backed by Elasatic Search.
References:

Implementation manual: https://github.com/docarray/docarray/blob/feat-rewrite-v2/docs/tutorials/add_doc_index.md
Document Index design doc (slightly outdated, but the main ideas remain): https://lightning-scent-57a.notion.site/Document-Stores-v2-design-doc-f11d6fe6ecee43f49ef88e0f1bf80b7f
Original PR adding Document Index base class: https://github.com/docarray/docarray/pull/1124

@JohannesMessner if this issue is still open, I would like to work on it, since the guide for the implementation is already stated there

Hi @JohannesMessner , I would like to take upon this issue , it would be my pleasue if you could assign it to me

should we do something similar for opensearch? happy to take this on

Hi @jay-bhambhani, definitely happy to take that PR! I suggest you wait until @AnneYang720's ES PRs are merged so you can base your PR off of her implementation. Looking forward!

@jay-bhambhani ES v7 and v8 have been merged now. If you are still up for building the open search integration, we would love to see it!

Excellent! I'll take a pass soon

Yes! Apologies am in the middle of moving to my new house, but will jump on
this ASAP
On Mon, Apr 17, 2023, 5:33 AM Johannes Messner @.***>
wrote:

@jay-bhambhani https://github.com/jay-bhambhani ES v7 and v8 have been
merged now. If you are still up for building the open search integration,
we would love to see it!
—
Reply to this email directly, view it on GitHub
https://github.com/docarray/docarray/issues/1209#issuecomment-1511014078,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADJ2LDRXOAUER7SSTDI6TATXBUE77ANCNFSM6AAAAAAVQ6BDXI
.
You are receiving this because you were mentioned.Message ID:
@.***>

Hi man @jay-bhambhani, are there any updates on this?

Hi man @jay-bhambhani, are there any updates on this?

Is this something you'd require for your work? I can revisit this ticket during the New Year. Unfortunately I will be unavailable until then


Problems with the results of the experiment

Hello!As you can see in the picture below, I'd like to ask you about your article where the results are accurate to two decimal places and more precise, but after executing the eval.py file I only get results like 0.10 or 0.15, etc. that end in 0 and 5. What is the reason for this?

Hi
Thanks for your interest in our work.
If you are interested in getting more decimal places, feel free to modify this line of code:
https://github.com/arnold-benchmark/arnold/blob/main/eval.py#L224

Hi Thanks for your interest in our work. If you are interested in getting more decimal places, feel free to modify this line of code: https://github.com/arnold-benchmark/arnold/blob/main/eval.py#L224

Thank you for your timely reply!But I would also like to ask what is the variable total in line 224 of the code? 20 or some other number?

total is the number of evaluated data. For normal evaluation, it is the size of the corresponding eval split. For challenge-oriented evaluation, this number is much smaller.

I got you. Thank you so much!I hope you'll produce more exciting results in the future！


Fix namespace

Related PR: https://github.com/ddf-project/DDF/pull/218

Fix the issue that current namespace can't be configured.


Rocket fires when git pull fails

Sometimes the git rocket fires even when the "git push" command fails. Are you checking the return status the git push command and making sure it's zero before firing the rocket?

Thanks for leaving this issue! PR #5 should fix this issue once it's released. I'll leave this open until I merge it and release a new version.

This should be fixed in version 1.0.5 of gitrocket. Please reopen if you're still having the issue!


chore(ui-templates): snow effet on loading screen

https://github.com/user-attachments/assets/cac06ab3-2490-470f-9b2a-13f3ddbc5318
📚 Description
This PR adds a seasonal (temporary) snow effect on Nuxt 3 loading screen. It's just an idea I wanted to play with after a discussion during our last meeting. If we don't like it, we can trash it, or see how to make it better ☺
I tried to keep the code as minimal as possible. It also respects the user's preferences regarding animations.
For credits, the snow effect is inspired by Boris Šehovac previous WebGL work on Codepen, but written using the Canvas's 2d context for conciseness here.

Glad you like it ☺
I believe it's enough on the loading template, and that having it everywhere would be a bit overkill, at least for now while we experiment with seasonal effects.
If it's something the community likes, maybe we could later on just load instead a hosted script from nuxt.com, this way we can change it/remove it without prompting a package release. This would also allow us to change it more often and let the community contribute to it, a bit like with Google's doodles

For some reason I'm getting this:

Can investigate more.

I'll investigate and make it Nov - December - January only if that works :)

Just curious what do you run to get the above result? Looks like Tailwind as a whole struggle to load as even the Nuxt logo is not centered 🤔

I ran:
pnpm i
pnpm dev:prepare

pnpm nuxi dev test/fixtures/basic

and then opened localhost:3000 in the browser.

OK thank you so much! This should be good ☺
💅 Style fixes
📆 Winter-bound

The first time I felt that not having DST was not a good thing🤔Maybe we can add a button to toggle it manually?
??

Thanks for your feedback @typed-sigterm, you have a toggle animation button at the top right of the loading screen :)


The specified version of Microsoft.NetCore.App or Microsoft.AspNetCore.App was not found.

Describe the bug
HTTP Error 500.31 - ANCM Failed to Find Native Dependencies
Common solutions to this issue:
The specified version of Microsoft.NetCore.App or Microsoft.AspNetCore.App was not found.
Specific error detected by ANCM:
It was not possible to find any compatible framework version The framework 'Microsoft.NETCore.App', version '3.1.1-servicing.19572.8' was not found.
The following frameworks were found:
2.2.4 at [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
3.0.0 at [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
3.1.0 at [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
You can resolve the problem by installing the specified framework and/or SDK.
The specified framework can be found at: https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=3.1.1-servicing.19572.8&arch=x64&rid=win10-x64
Troubleshooting steps:
Check the system event log for error messages
Enable logging the application process' stdout messages
Attach a debugger to the application process and inspect
For more information visit: https://go.microsoft.com/fwlink/?LinkID=2028526

@pranavkm @JunTaoLuo can you help me look at this issue? This prevented me from working properly

@Varorbc where did you install the ASP.NET Core shared framework from? It looks like you are installing a nightly aspnetcore shared framework without installing a nightly netcore shared framework.
I have double checked our released 3.1.0 release and there are no issues with the framework dependencies.

@JunTaoLuo By updating vs to 16.4

I suspect that an incorrect version of ASP.NET Core 3.1 was inserted into VS. I'll need to check our releases.
cc @leecow @mmitche

@JunTaoLuo finally I resolved the issue by reinstalling


Multiply add column in migration

HI! I can not find, can i adding multiply column in migration in one alter table?
I have a problem: we have a big size of table in producation-base and Sequential execution of addColumn methods get really many time.
Can i execute query from migration use ORM like a
ALTER TABLE table ADD COLUMN col1 ADD COLUMN col2

Thank you for feedback!


⚠ BCR Bot has degraded performance

In 4376ccf, BCR Bot (https://bcr.alternativasinteligentes.com/BCRApi/web/chatbot) experienced degraded performance:

HTTP code: 200
Response time: 913 ms

Resolved: BCR Bot performance has improved in c8ee56b.


Scene Descriptor

Do you have the scene descriptor in the pre-generated dataset provided? Such that we can reconstruct the scene while leverage the annotated grasping pose? Thanks!

Do you mean the occupancy annotations by scene descriptor?

Thanks for replying so fast.
I mean a .json or .yaml file which contains the shape ids, positions and orientations of each objects that was added to the scene, such that I may reconstruct the scene in simulator by loading the objects.


Tension works as inertia

I am trying to create charts with curve lines between points. I have found the property tension useful but I am not sure if it is the expected behaviour that when we have two points with the same Y axis value it look as a curve instead of as a plain line.

Has anybody found a way to get this done? Or why is the reason about this behavior?

Hey,
Thanks for raising an issue!
Just a little reminder: Small reproducible examples help me a lot when answering these types of issues. It saves me a lot of time setting up an example fitting your use-case, and you get a faster reply. So it's a win-win 😉
The setting you are looking for is called cubicInterpolationMode, which can be set in the data properties of each dataset. The Chart.js documentation states

The 'default' algorithm uses a custom weighted cubic interpolation, which produces pleasant curves for all types of datasets.

In your specific use case, you may prefer cubicInterpolationMode: "monotone", which does the following:

The 'monotone' algorithm is more suited to y = f(x) datasets: it preserves monotonicity (or piecewise monotonicity) of the dataset being interpolated, and ensures local extremums (if any) stay at input data points

Here's an example chart comparing the two settings:

https://jsfiddle.net/9h5be8xk/4/
Closing this as answered, please re-open if this doesn't solve your issue

Thanks a lot for your answer. @chrispahm


Client can't switch to working node [JIRA: CLIENTS-254]

Client can't switch from broken node to working node when we using connection timeout.
For testing we need have a Riak node on localhost and any domain without Riak.
The following code should complete without exceptions.
from riak import RiakClient

# We need check many times, because a node will be chosen randomly
for i in xrange(100):
    RiakClient(
        protocol='pbc',
        transport_options={'timeout': 1},  # timeout in seconds!!!
        nodes=[{'host': 'basho.com'}, {'host': 'localhost'}]
    ).ping()

What errors are you seeing, @etarasenko ?

Traceback (most recent call last):
  File "<stdin>", line 5, in <module>
  File "/home/etarasenko/projects/riak/env/local/lib/python2.7/site-packages/riak/client/transport.py", line 196, in wrapper
    return self._with_retries(pool, thunk)
  File "/home/etarasenko/projects/riak/env/local/lib/python2.7/site-packages/riak/client/transport.py", line 138, in _with_retries
    return fn(transport)
  File "/home/etarasenko/projects/riak/env/local/lib/python2.7/site-packages/riak/client/transport.py", line 194, in thunk
    return fn(self, transport, *args, **kwargs)
  File "/home/etarasenko/projects/riak/env/local/lib/python2.7/site-packages/riak/client/operations.py", line 136, in ping
    return transport.ping()
  File "/home/etarasenko/projects/riak/env/local/lib/python2.7/site-packages/riak/transports/pbc/transport.py", line 115, in ping
    msg_code, msg = self._request(MSG_CODE_PING_REQ)
  File "/home/etarasenko/projects/riak/env/local/lib/python2.7/site-packages/riak/transports/pbc/connection.py", line 55, in _request
    self._send_msg(msg_code, msg)
  File "/home/etarasenko/projects/riak/env/local/lib/python2.7/site-packages/riak/transports/pbc/connection.py", line 74, in _send_msg
    self._connect()
  File "/home/etarasenko/projects/riak/env/local/lib/python2.7/site-packages/riak/transports/pbc/connection.py", line 220, in _connect
    self._timeout)
  File "/usr/lib/python2.7/socket.py", line 571, in create_connection
    raise err
socket.timeout: timed out

@etarasenko I'm a bit confused.  It seems to be doing what it's intended to be doing: timing out if it cannot connect.  All that's being done is socket.settimeout().  You just need to handle the timeout exception.
You were expecting the client to silently switch to another host?

I have too long timeout without option transport_options={'timeout': 1} about 3-5 minutes.
I can't handle exception in my code because I can't control order of Riak nodes in pool for switching to another.
But I using the following monkey patch for fixing this bug:
# Monkey patch official python riak client
# for correct switching to new node on timeout
from riak.transports import http
http.CONN_CLOSED_ERRORS += (socket.timeout, )

Yes, I'm expecting switch to another node.

Looks like you can do the same thing with Protocol Buffers:
from riak.transports import pbc
pbc.CONN_CLOSED_ERRORS += (socket.timeout, )

I'm a bit loathe to change this as the default behavior as others might be expecting an exception.

I'm closing the issue if you don't want change this behavior but for me it's bug when working with Riak cluster.

@etarasenko I'm surprised that you got your change to work with HTTP.  I'm finding when I test it that I get connection errors instead of timeout errors.  On the HTTP side of things, it looks like it interrogates the server when setting up the connection pool.  I have a pretty simple fix for PBC, however.


MRG: 2nd tracker dealer example

Here's the second example that @Eric89GXL asked for.

@Eric89GXL @drammock I'm still trying to figure out why this PR includes all the commits from the last example, but wanted to put this up anyway so you could see the actual example you asked for.

You were probably on your old branch when you created your new branch, i.e. left out the first command in this two-command sequence:
git checkout master
git checkout -b 2nd_tracker_ex

@Eric89GXL Very much oops, you are correct. Shall I kill the branch and do a new PR without the extra files?

Yes please. Note that after making the new branch you can do git cherry-pick ####### to get your relevant commits.


SetDefaultColumnValues sets SPEventReceiver with wrong Synchronization property

When using SetDefaultColumnValues this gives issue when working with folders or document sets. On document sets and folders my default values are not set when uploading a new document, while it works when doing it directly on the library. So I started to configure it on a plain site without using PnP Provisioning and performing the configuration manually. Then I found out that there is a difference in the configuration of the LocationBasedMetadataDefaultsReceiver ItemAdded eventreceiver. On the PnP configured site the Synchronization property is set to DefaultSynchronization in code, which results in Asynchronous on my library:

I compared this value with the value of the library which has been manually configured and found out that this one is set to Synchronous:

After setting the eventreceivers on the other list as well to Synchronous my issue with default values on document sets and folders has been disappeared. Can this be changed in the code such that the eventreceiver works the same as when configuring the default values using the UI?

Hi,
Thanks for your feedback. We fixed the issue with PR #399.


ascii() and wait(WaitMode.Output) function is not working properly

Hi There,
I am using J3270 API for mainframe screen scrapping purpose.
I came across 2 issues:

ascii() - which is not working as expected - its not getting the latest screen in the list.
wait(WaitMode.Output)  - its not waiting for the OUTPUT screen to change.
Can you please help what should be done.

In first case how we can get the latest mainframe screen in the buffer?
What is the better we to check the response screen after pressing the any function keys ?
Thank you in advance!
You can reach out to me on<EMAIL_ADDRESS>Thanks,
Ravi

Hi Ravi.
j3270 is a wrapper around s3270, so you can try out your sequence of actions using s3270 direcly: all commands available through j3270 are directly translated to the same s3270 commands. I also find s3270 useful to try out things before writing code using j3270.
If the behaviour differs between j3270 and s3270 then it probably is a bug on our end, but in my experience there's always some weird behavior on the mainframe that we're ignoring. For example if "Ascii" works in s3270 but not in j3270 then it's a bug.
Another thing to check is browsing your system using either x3270 (GUI version) or c3270 (terminal version), both use s3270 to do the actual work, so if they don't work then it may be an issue with your mainframe (maybe networking issues).

Thanks for you response


Expose SDK version of client libraries to developers.

As a developer, I want a programatic way to be able to see the SDK version that is currently being used, so that my projects which use Ably SDKs can make use this information.
Currently there is no way to discover the version of the SDK in use by making a call to the SDK. Propose exposing SDK version in the SDK API. This would allow a developer using the SDK to see which version of the SDK is in use.
To ensure this functionality is added to all Ably client library SDKs, the first step would be to update the client library specification.
┆Issue is synchronized with this Jira Task by Unito

Related: #113.


Enhancement/updated c template

Checklist

[x] I tested all changes and all related features with different users (student, tutor, instructor, admin) on the test server https://artemistest.ase.in.tum.de.

Description

The GBS course updated their C template. I integrated their update into our own template. I also moved the basic compile test from all tests to the structural tests, so that we can have proper sequential test runs if so desired.
Steps for Testing

Log in to Artemis
Navigate to Course Administration
Create a C programming exercise with sequential runs
The template should only have one failing test, but the solution all 11 (successful)

I tested it on the server:
* template fails all tests heavy_check_mark

* solution randomly fails tests (sometimes 1, sometimes more, I guess we can't really improve this with the given template?)

* Also for me there were 20 and not 11 tests in total (not sure if relevant)

Yes, we are dependent on the template from GBS and can't really do a lot about the non deterministic results. But I will mention it the next time I'm in contact with them, so we can find a solution.
About the 11 tests: That's my bad, I had a bug, which is fixed now. 20 tests are correct just like it was the case for you


Rewriting of sequence logo object into pyplot object

Hi LogoMaker team,
Thank you for a very nice library! I am working on a website using the python library Streamlit. On this website, I am displaying sequence logos using LogoMaker. Producing a logo, I saw it is of the class 'logomaker.src.Logo.Logo'. However, this class is not compatible with a display on Streamlit, and with the purpose of what I am doing, I do not have the option of saving the figure as an image and then display that image to Streamlit. My question is thus, whether there is a way to turn the Sequence logos I produce with LogoMaker of the class 'logomaker.src.Logo.Logo' into a pyplot object directly?
Thank you in advance!
Best,
Line

Hi,
Have you tried using the fig attribute in a logo? e.g.
logo = logomaker.Logo(...)
logo.fig <- this should be a matplotlib object.
This logo object should also have a matplotlib axis attribute, i.e., logo.ax, that you may be able to use. I used logomaker on a flask server to plot logos and it was straight forward, but I haven't used streamlit yet. Let me know how it goes and I'll look into it more.
Ammar

Were you able to try the above?

Hi,
Thank you for the answer. I actually found another solution in the meantime (using in-memory storage to convert the logo into an image), but I just tested this and it worked too! Will definitely go with this solution from now on.
Best,
Line


Containerize the microservice with Docker.

Containerizing the microservice.
Adding subsections to the README doc with fine-grained instructions regarding creating, running a Docker image, and exploring a Docker image payload (the latter is incomplete yet).
Bumping version number to 0.3.0.

She looks beautiful ! :+1: — Approved. :blue_heart:


add new maintainer

@kmomar @zkamvar  - I don't know why the checks are failing. All I did was add one name to the lesson table. Please help!

It looks like the yaml validator is getting upset at a post from 2019:
File : _posts/2019/06/2019-06-25-developing-data-skills.md, error: (_posts/2019/06/2019-06-25-developing-data-skills.md): did not find expected ',' or ']' while parsing a flow sequence at line 7 column 7

I'll have a look and see what's happening on line 7.

OH, it looks like François fixed it in https://github.com/LibraryCarpentry/librarycarpentry.github.io/commit/2f8daa22e586d7636aadb177fdc046138e4ecbc4

The checks are failing to to an unrelated error that is fixed. I'm going to merge this.
For full context and a timeline:
The error originally appeared in #78, but it went undetected because the fork was made in 2019, which did not have the automated checks available (which were introduced in October 2020 with https://github.com/LibraryCarpentry/librarycarpentry.github.io/commit/98c4e2ef36b79fd937402d15a89ed8a4735de932).
PR #78 was only merged yesterday with the yaml error still undetected: https://github.com/LibraryCarpentry/librarycarpentry.github.io/commit/e94becf54b1e87d83ad9efff4864accc76c83d93
Erin created this PR from a point in the repository where the erroneous yaml was present.
François fixed it on the main branch: https://github.com/LibraryCarpentry/librarycarpentry.github.io/commit/2f8daa22e586d7636aadb177fdc046138e4ecbc4
Despite the fix Erin's fork is still throwing the error because it has not yet received the fix.

Thanks a million @zkamvar!!


[SDK] Feature: Adds Multiwrap and LoyaltyCard Extensions

CNCT-2438

PR-Codex overview
This PR adds support for Multiwrap and LoyaltyCard extensions to the ERC721 contract, enhancing its functionality for managing token minting and wrapping.
Detailed summary

Introduced tokensMintedEvent, tokensUnwrappedEvent, and tokensWrappedEvent functions.
Added TokensMinted, TokensWrapped, and TokensUnwrapped events to respective JSON files.
Implemented mintTo, revoke, cancel, and unwrap functions for LoyaltyCard and Multiwrap.
Added support functions for reading contract data, such as totalMinted, nextTokenIdToMint, and getWrappedContents.
Updated deployment scripts to handle new contract types.

The following files were skipped due to too many changes: packages/thirdweb/src/extensions/erc721/__generated__/Multiwrap/write/wrap.ts, packages/thirdweb/src/extensions/erc721/__generated__/LoyaltyCard/write/mintWithSignature.ts, packages/thirdweb/src/extensions/erc721/__generated__/Multiwrap/write/initialize.ts, packages/thirdweb/src/extensions/erc721/__generated__/LoyaltyCard/write/initialize.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Merge activity

Nov 26, 5:35 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.


Increase celery pool broker limit

It should be equal to the concurrent tasks running

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
5 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-0.08%) to 88.042%

Files with Coverage Reduction
New Missed Lines
%

safe_transaction_service/tokens/clients/binance_client.py
1
77.78%

safe_transaction_service/tokens/clients/coingecko_client.py
1
80.65%

safe_transaction_service/history/indexers/ethereum_indexer.py
3
86.09%

Totals

Change from base Build<PHONE_NUMBER>:
-0.08%

Covered Lines:
5706

Relevant Lines:
6481

💛  - Coveralls


Invert TranslatorInterface feature detection logic

This PR inverts the feature detection logic for the TranslatorInterface - so instead of testing for the non-existence of the old interface from Symfony\Components this now checks if the one from Symfony\Contracts exists.
The idea behind this change is that the detection fails if you're using a polyfill (for instance https://github.com/contao/polyfill-symfony/blob/main/src/TranslatorInterface.php). We're using this over at Contao CMS to ease providing bundles that are compatible with multiple Symfony versions.
Otherwise, you will get an error like this in this case you're using Symfony 5 (the DataCollectorTranslator implements the new interface):
 Craue\FormFlowBundle\EventListener\FlowExpiredEventListener::setTranslator():
 Argument #1 ($translator) must be of type Symfony\Component\Translation\TranslatorInterface, Contao\CoreBundle\Translation\DataCollectorTranslator given

Coverage decreased (-1.2%) to 97.277% when pulling ec7e3fd9014fa31195630f055aa7183a0eee9cdf on m-vo:bugfix/translator-feature-detection into a416ea040ed180e46b5cbc3d02d5c9f33dd5df3e on craue:master.

Interesting. The code initially used to be checking for the interface from Contracts but was then inverted already to fix #347. There's now a failing Travis job due to this.
Maybe only checking for this interface is not enough so we need to fine-tune the condition. Suggestions?

The code initially used to be checking for the interface from Contracts but was then inverted already to fix #347.

I see. :-/. I'm not sure there is a solid straightforward solution to this.
So if I get this correctly the whole BC layer is there to provide a type hint for the setTranslator() method which is probably only used with setter injection? What about just dropping the type hint in this case? Or maybe we could add a runtime check like so:
/**
 * @param TranslatorInterface|LegacyTranslatorInterface $translator
*/
public function setTranslator($translator) {
    if(!$translator instanceof TranslatorInterface || !$translator instanceof LegacyTranslatorInterface) {
       throw new \InvalidArgumentException('$translator must implement … ');
    }

    $this->translator = $translator;
}

So if I get this correctly the whole BC layer is there to provide a type hint for the setTranslator() method which is probably only used with setter injection?

Yup. Now I wonder why I did it this way in the first place. 😆

What about just dropping the type hint in this case? Or maybe we could add a runtime check...

Sounds good to me. Not sure if there are any drawbacks but we can try. I'll gonna prepare a PR if you don't mind.

@m-vo, given this patch is applied, when will it be safe to re-add a type-hint for only \Symfony\Contracts\Translation\TranslatorInterface? As soon as Symfony >= 4.2 (when the Contracts one was added and the Component one got deprecated) is required, or even >= 5.0?

I guess it's >= 5.0 because the injected translator instance could very well only implement the old \Symfony\Component\Translation\TranslatorInterface as long it exists in 4.


[bug] load_image_file can't load some bytes broken image

I just want to know whether the image has faces. So, I use the code:
import face_recognition
img = face_recognition.load_image_file(imgname, mode='RGB')
faces = face_recognition.face_locations(img)

Suddenly, it raise error, the img must be uint8 or a PIL image.
I saw you use the function scipy.misc.imread() function to read image.
It's a combination of scipy.misc.fromimage(), PIL.Image.open().
If an image has some bytes broken, the scipy.misc.fromimage()gets unexpected result.
After my endeaver, you just to add
from PIL import ImageFile
ImageFile.LOAD_TRUNCATED_IMAGES = True

And everything goes perfect.
more details tomorrow.

I wouldn't call it a bug that it won't load corrupted files. But thanks for the tip to solve it for those that have this special case need.

Noted here: https://github.com/ageitgey/face_recognition/wiki/Loading-corrupted-or-partially-downloaded-image-files


Not able to complete some files and also after excution not able to find completed code on stackblitz

Describe the bug
Command to setup basic React js application
Link to the Bolt URL that caused the error
https://bolt.new/~/sb1-e7cnkn
Steps to reproduce
NA
Expected behavior
Should Be previewed
Screen Recording / Screenshot
No response
Platform
Browser name = Chrome
Full version = <IP_ADDRESS>
Major version = 130
navigator.appName = Netscape
navigator.userAgent = Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
performance.memory = {
  "totalJSHeapSize": 138238403,
  "usedJSHeapSize": 120548415,
  "jsHeapSizeLimit":<PHONE_NUMBER>
}
Username = yashsisodiya
Chat ID = 4a9c614ee702

Additional context
No response

Your daily limit is exhausted that's why it is showing this error

Yes i might have exceeded daily limit but still where is the code which was written in earlier promts before exceeding
@sshekamz

@yashsisodiya at https://bolt.new/ in bottom left there is a sidebar icon where you can find your recent chat.


Ts add lfq vignette

Addresses one more of the vignettes in #15, this time LFQ, with some minimal QC, basic normalisation and the summarising to protein-level abundance, plus two extended sections comparing recommended summarisation to MaxLFQ (very similar) and alternative normalisation against reference 'housekeeping' proteins.

Thanks for the polishing etc, @csdaw. You happy to approve PR?

Thanks for the polishing etc, @csdaw. You happy to approve PR?

Just one last commit to resolve some R CMD check notes. Then happy for merge!


Move online documentation to Readthedocs

The old PyPI doesn't allow to upload new documentation to pythonhosted.org, so we need remove the docs hosted there and move them to readthedocs.

Looks like it is already on rdt: http://spyderide.readthedocs.io/en/latest/
Last build was generated 3 months ago.

We don't have control on that. I really don't who has it.

The RTD user that has control of it is maxgam : https://readthedocs.org/profiles/maxgam/

Unfortunately, i think there is no free organization option for open source project on RTD. There is only a paid option: https://readthedocs.com/pricing/.
So I think we will have to contact a RTD admin and ask them to delete the current project that is own by maxgam. Then we will be able to claim back the ownership of the spyder repo on RTD. Maybe we could used Spyder bot for this purpose?

@ccordoba12 Hey, any progress on your end with this? What's the current status?

I just created the new repository for our docs:
https://github.com/spyder-ide/spyder-docs
@CAM-Gerlach, please move our current docs from here to that repo. There you can update the Sphinx theme to use a more modern one and add new content.
Once that's ready, please use doctr:
https://github.com/drdoctr/doctr
to deploy the docs to the GitHub pages of the repo.
The last step of the plan is to add a link in our new homepage to the generated documentation.

One thing I'm not sure we should do or not is to stop distributing our docs with the package. I mean, we can certainly do that for Spyder 4, but I think we should not do it for Spyder 3 because it's in maintenance mode and I'm sure some people are using that feature.

Once that's ready, please use doctr to deploy the docs to the GitHub pages of the repo.

Do I understand correctly or we won't be using RTD to deploy the docs? It's going to be directly hosted on github?

@ccordoba12 Will do, thanks.

There you can update the Sphinx theme to use a more modern one

Want me to offer up a few good options in a PR or Issue on that repo and have the team vote/give feedback?

add new content.

Anything particular in mind that's high priority before we deploy them?

One thing I'm not sure we should do or not is to stop distributing our docs with the package.

I guess the biggest major downside is if we make any changes before we drop support for 3.x, we'll have to submit two PRs against two different repos, right?

@CAM-Gerlach even if we don't use RTD (which I'm not sure) maybe that would be a good idea to claim the name anyway just in case?

maybe that would be a good idea to claim the name anyway just in case?

We can't claim it. We can just become co-admins of the Spyder project (which we already are). But once the docs are removed from the Spyder repo, the project will cease to be valid and we'll be admins of the spyder-docs one.

Want me to offer up a few good options in a PR or Issue on that repo and have the team vote/give feedback?

Sure, thanks!

Anything particular in mind that's high priority before we deploy them?

We should probably go with our current content to start. Then you could add new content in different PRs. There are a lot of new things we could talk about, but let's leave that for later.

I guess the biggest major downside is if we make any changes before we drop support for 3.x, we'll have to submit two PRs against two different repos, right?

We could have two branches in spyder-docs, one for master and another one for 3.x. Then before every 3.x release we could create a new PR in spyder to update the docs contents. I don't see a need to do a PR in spyder after every change in spyder-docs.

We can't claim it. We can just become co-admins of the Spyder project (which we already are). But once the docs are removed from the Spyder repo, the project will cease to be valid and we'll be admins of the spyder-docs one.

That's what I meant. Claiming the spyder-docs one. I can already claim it if I wanted I think. So better you do it before someone else does?

Yes, please claim it.

Yes, please claim it.

Done. I've added you and @CAM-Gerlach as admins.

@ccordoba12 So are we still deploying directly to github pages with doctr, to RtD as discussed previously or both? If both, which should be the preferred/canonical outlet to link users to, e.g. from our site?

Let's try with Github pages first.

@ccordoba12 I've done everything except for the final deployment with doctr, as that's currently blocked by needing to build with Travis. Can you (or someone else who has admin rights) enable Travis on spyder-docs ? It should be ready to test building the docs with my latest PR (#2) there, then I just need to add doctr and #5986 will be complete , but I need to make sure Travis is working before I do that.
Also, since I apparently can't see the settings page on the repo likely due to lack of permissions, can you setup the proper tags, description line, branch protection, and other settings for that repo; or, if possible, grant me the appropriate permissions on that repo so I can do so? Thanks.

@ccordoba12 Okay; all that's done and the current docs are live on Github pages. However, there remains the question of what to do about supporting docs for multiple versions of Spyder simultaneously, given we have separate docs for 3.x (Spyder 3) and master (Spyder 4). They currently only have a few small differences, and we only have a need to publish those for 3.x fight now as Spyder 4 isn't even in beta yet, but both of those will rapidly change as the latter gets closer to release.
Right now, I have it set up to build and test-deploy docs with PRs to both branches, so we know they work, but to only actually deploy them to the live site from the 3.x. That could work for now, but at least for the long term if not sooner we'll need to do something about that. The options I can think of:

Keep the 3.x docs up until Spyder 4 is released, and then do a hard swich-over to the latter, simply setting the docs to deploy automatically from that branch instead.
Advantages: Requires zero additional effort now, and a nearly trivial amount to switch over. Keeps things simple and avoids near-term user confusion.
Disadvantages: No ability for users to view docs for any release other than whatever we consider the "current" one.

Have doctr output each branch to a separate directory on the gh-pages branch, and manually create a main index page in the root of the repo, or on the main Spyder website linking to the two versions; link to that page from the documentation link on our homepage/main site.).
Advantages: Shouldn't be too difficult to get set up, and even less effort than the first option to "switch" which one is "live" if necessary at all—just changing what is linked to, or the text on the main index page, if that. Allows users to view either set of docs as they choose, so long as they make it to the main index page.
Disadvantages: Somewhat inelegant; requires creating a main index page either from scratch on the spyder-docs gh-pages and maintaining it by hand (possibly cleaner, but much worse from a design perspective and we'll have to use yet a third theme from our website and docs themselves), or probably better just creating a dedicated page on the main Spyder website to link to both doc version indices. No ability for the user to easily switch from one version to another while within one version's docs, only from the main doc page, unless we hack something in.

Abandon doctr and gh-pages and setup and use Read the Docs with the spyder-docs repo instead, and link to that.
Advantages: Has built in support for not only versioned branches, but also can automatically use tags to organize docs for each released version, and automatically categorize them as stable or development based on PEP 440. Can customize handling much of this, including what version is the default, etc. without much work or changes to the code. Users should be able to easily switch between different versions from any page, right from the familiar popup menu. Also, would make the choice of theme straightforward—just the standard, fairly nice RTD one.
Disadvantages: Would need a (hopefully modest) amount of additional setup. Reliant on RTD as a platform. Less direct control than github pages.

Or, there might be another, better option entirely...thoughts @ccordoba12 @jnsebgosselin ?

Keep the 3.x docs up until Spyder 4 is released

I'm in favor of this option, that's what we've done so far. Besides, from our issue tracker here on Github we can conclude very few people is using master.
Let's start with this and see how things evolve (now that everything is setup in spyder-docs). Another thing I like about using our own deployment, instead of RTD, is that can render our docs inside our website.
Finally, where our docs live is not the most important thing but its content. So @CAM-Gerlach, we rely on you to expand our docs and better explain people how to use the many features Spyder has to offer. We also need a more modern Sphinx theme, with a color scheme similar to the one we're using in our website.

I'm in favor of this option, that's what we've done so far.

Cool; that's the current status quo as of now if and until we want to change it.

that can render our docs inside our website.

Especially since its on a subpath of our nominal domain, is there an easy way to set this up? Or have them in an iframe beneath the top bar or something? I have very little in the way of actual web glueing; I'm only done some stuff on the very high level (design, consulting, CMS, etc), and a very little bit on the scripting side (a taste of PHP and JS). At least for starters, absent something better, I'll just link it to a "documentation" link on the top bar and then solicit feedback on people's preferences for a more modern sphinx theme that matches the site.

we rely on you to expand our docs and better explain people how to use the many features Spyder has to offer.

Yep, will do right after I get all the legal stuff taken care of, help get us funded, fix the outstanding bugs I'm assigned, and hopefully pitch in getting the website into better shape, alongside the usual tide of user issue reports, PR reviews and repo management...oh and don't forget my courses, internship job, personal research, funded research, and volunteer outreach :)
Hopefully this summer I can do a big push on it, especially if I'm not already too busy with my next big funded project designing new sensors and ML/ANN processing algorithms for NOAA's satellite fleet. In the meantime, I'll try to get in incremental improvements, but it seems my primary short term focus is funding (both Spyder's and my own) and getting as much as practicable low hanging fruit done for 3.2.9.

I can help with writing the docs once we get to that part.

Especially since its on a subpath of our nominal domain, is there an easy way to set this up?

Once @dalthviz finish our blog (which is almost done), he'll add an entry in our nav bar to easily access them. After that, we could remove the deployment in pythonhosted.org, which can't be updated anymore.

then solicit feedback on people's preferences for a more modern sphinx theme that matches the site.

Yes, please open an issue in spyder-docs to discuss about it.

Hopefully this summer I can do a big push on it

Great! I think we can set up some tasks and ask people what they want to work on.

I can help with writing the docs once we get to that part.

Thanks a lot @jitseniesen! I'd say you can start right now, if you have time, by opening a document in Dropbox paper first, then ask for feedback and finally, when the discussion has finished, open a PR in spyder-docs.
I think we should start with a Dropbox paper because we have attested that reviewing content in a PR is very cumbersome.

@ccordoba12

Once @dalthviz finish our blog (which is almost done), he'll add an entry in our nav bar to easily access them.

Okay, so this is in work right now? Any idea on an ETA? I'm guessing quick enough that you're implicitly recommending that I just wait for that to proceed rather than going ahead and submitting a PR to do it myself, since this is the last blocker toward resolving this work item?

Yes, please open an issue in spyder-docs to discuss about it.

Will do shortly. Should I notify our core and juniors on the issue directly with @ to weigh in, or announce it with @ all on the Gitter?

Great! I think we can set up some tasks and ask people what they want to work on.

I'd say you can start right now, if you have time

I'll try to get a basic framework setup with issues on that repo. Right now, my proposed plan for 3.2.9

Do a baseline editing pass through all the docs to make sure they're at least up to date and free of major grammar/style issues—I can do this pretty quickly
Implement the new theme once people decide on one
Update the out of date screenshots and perhaps add a few more (in overview, and possibly elsewhere) showing different layouts, themes and features/panels as you suggested on the other issue; and as I mentioned over there, I can take them all in one go with those.

I can commit to at least doing all of that for the time being; beyond that I would think the next shorter-term priority for me and/or @jitseniesen is hitting some of the low-hanging fruit content improvements like filling out features that aren't described, and describing more of the "how" and not just the "what" when explaining a feature or capability. But really, almost anything is helpful at this point.

I think we should start with a Dropbox paper

@ccordoba12 Are we sure Dropbox paper won't mangle any of the formatting, spacing, characters in our rsts? I know it has good markdown support and can input and output md but none that I'm aware of for rst. Would setting the font to monospaced and disabling any automatic formatting get us there?

Okay, so this is in work right now? Any idea on an ETA?

It should be ready by the end of next week, but I'd like to have a new theme in place for our docs before doing the transition.

Should I notify our core and juniors on the issue directly with @ to weigh in, or announce it with @ all on the Gitter?

As you wish ;-)

Right now, my proposed plan for 3.2.9

Good plan. Please go ahead with it.

hitting some of the low-hanging fruit content improvements like filling out features that aren't described, and describing more of the "how" and not just the "what" when explaining a feature or capability

That would be a great start!

It should be ready by the end of next week, but I'd like to have a new theme in place for our docs before doing the transition.

That's quite a while, but I suppose it makes sense if it takes us that long to decide on a theme. Hopefully I'll have the baseline editing pass and the screenshots done sooner, as well.

That would be a great start!

I can't promise how much in-depth content work I can prioritize for 3.2.9 considering my many other tasks for that and other near-term milestones (website, funding, etc), but hopefully @jitseniesen can pitch in there at some point.


Point in time recovery using Patroni

Hello team,
Thanks for this awesome tool and all the good stuff.
My understanding from documentation is that I can do point in time recovery using pgbackrest with custom_bootstrap method.  I have setup patroni (3 nodes) with pgbackrest and consul. I used below script.
custom bootstrap
bootstrap:
method: pgbackrest
pgbackrest:
command: /etc/patroni/bootstrap.sh
keep_existing_recovery_conf: False
recovery_conf:
recovery_target: immediate
recovery_target_action: promote
restore_command: /bin/pgbackrest --stanza=pgadmin archive-get %f %p
And used below script to do create replica.
custom create replica
postgresql:
create_replica_methods:
- pgbackrest
pgbackrest:
command: /etc/patroni/bootstrap.sh
keep_data: True
keep_existing_recovery_conf: True
no_params: false
/etc/patroni/bootstrap.sh
/bin/pgbackrest --stanza=pgadmin --delta restore --set=20191127-153046F_20191127-154126I --log-level-console=info
with above setup, this is how I start to do PITR.

Stop patroni on all nodes.
Wipe data directory on all nodes - rm -rf /app/pgsql/12/data.
Start patroni on all nodes.
This simulates a race condition.
Remove initialize key from consul.
Patroni chooses a leader and starts to bootstrap it from above script.
Once the leader is boostrapped, patroni calls create-replica method for all the slave nodes.
The entire cluster is back online successfully to the backup set which I have provided in boostrap.sh

My doubts:

Are there any other ways to do PITR without bootstrapping.
In above scenario i am forced to do bootstrap from scratch inorder to do PITR and unable to make use of --delta restore option of pgbackrest for custom_bootstrap.
Is my understanding correct here?

Are there any other ways to do PITR without bootstrapping.

Yes, but it is a bit hacky.
Stop all nodes. On one of the nodes define the custom replica creation method with recovery_target_time and recovrery_target_action, remove pgdata and start patroni.
After that you should not forget to change the custom replica creation method back.

In above scenario i am forced to do bootstrap from scratch inorder to do PITR and unable to make use of --delta restore option of pgbackrest for custom_bootstrap.

Yes, Patroni will not start the bootstrap process if PGDATA is not empty.
There is a workaround though. You can rename it and later in the bootstrap script rename it back

Will the following work:

Stop the nodes running the replicas
Stop patroni service on the node (say n1) running the leader
Stop postgres on n1
Do PITR using a command like pgbackrest --stanza=app --log-level-console=info --delta --type=time --target="2021-02-11 06:47:32" --target-action=promote restore
Start postgres on n1
Start the patroni service on n1. This may lead to the leader being demoted to a replica because of patroni's internal logic as in here and here.
Monitor for a few loops to see if n1 is not the leader. If n1 loses leadership, put patroni in maintenance mode and failover to n1. Patroni makes sure n1 is leader now. Remove patroni from maintenance mode.
Bring up the other nodes hosting replicas and reinitialize the replicas using patroni.

I am also trying to achieve same thing.
Following the below :

Stop patroni on all nodes.
Doing the Point in time recovery using delta restore on primary.
Start patroni on primary node.
I see the full database is restored and PITR does not work.

But when I follow the bootstrap method for point in time recovery it works.
So as per all the comments here, does that mean that PITR does not work with delta restores?


Playground execution failed: expression failed to parse, unknown error

This occurs when opening AudioKit for IOS XCode Project, and prevents any part of the project from running:
`Playground execution failed: expression failed to parse, unknown error

thread #1: tid = 0x54310, 0x00000001096d23c0 FM Oscillator Operation`executePlayground, queue = 'com.apple.main-thread', stop reason = breakpoint 1.2

frame #0: 0x00000001096d23c0 FM Oscillator OperationexecutePlayground frame #1: 0x00000001096d19c0 FM Oscillator Operation__37-[XCPAppDelegate enqueueRunLoopBlock]_block_invoke + 32
frame #2: 0x000000010a1ed6ac CoreFoundation__CFRUNLOOP_IS_CALLING_OUT_TO_A_BLOCK__ + 12 frame #3: 0x000000010a1d26f4 CoreFoundation__CFRunLoopDoBlocks + 356
frame #4: 0x000000010a1d1e65 CoreFoundation__CFRunLoopRun + 901 frame #5: 0x000000010a1d1884 CoreFoundationCFRunLoopRunSpecific + 420
frame #6: 0x000000010f671a6f GraphicsServicesGSEventRunModal + 161 frame #7: 0x000000010ad7fc68 UIKitUIApplicationMain + 159
frame #8: 0x00000001096d16e9 FM Oscillator Operationmain + 201 frame #9: 0x000000010d7b368d libdyld.dylibstart + 1`

@DAC17 How did you solve the issue?

Playgrounds do not support external frameworks, therefore you must open the project named "AudioKit For IOS" in the IOS folder of the audiokit package, and make sure all of the playgrounds are present in that project(and if not open them there) and then run the project. This might throw up a few warnings, but should still work.

This is actually true only in AudioKit 3.5.x.  In AudioKit 3.6 AudioKit Playgrounds are located at the top level Playgrounds folder.  You can still run playgrounds the way @DAC17 is describing, but I think the new way is a lot easier.


Do not throw an error when restarting instead of refreshing

AB#4015
When the summarizer is stopped because we want to restart it instead of refreshing from an ack, we throw an error to close the container and prevent a network call.
Reference PR: https://github.com/microsoft/FluidFramework/pull/15009
The goal of this PR is to

send a generic telemetry event without sending any error telemetry events when we decide to stop the summarizer instead of refreshing the ack.
prevent the execution of making a network call to fetch the snapshot (I don't know if this is important or not)

If we don't implement this fix, we'll see these events, some as error events.
Spot checking a few docs, we would raise 5 error events each time we close the summarizer instead of refreshing.
fluid:telemetry:Container:ContainerClose | Restarting summarizer instead of refreshing | genericError | Restarting summarizer instead of refreshing
fluid:telemetry:SummarizerNode:refreshLatestSummary_cancel | Restarting summarizer instead of refreshing | genericError | Restarting summarizer instead of refreshing
fluid:telemetry:Summarizer:Running:HandleLastSummaryAckError | Restarting summarizer instead of refreshing | genericError | Restarting summarizer instead of refreshing
fluid:telemetry:Summarizer:Running:FailToSummarize | Restarting summarizer instead of refreshing | genericError | submitSummaryFailure: Error while generating, uploading, or submitting summary

  	this.summarizerNode.startSummary(summaryRefSeqNum, summaryNumberLogger);

do we need to invoke this in case refreshLatestAckFailed ?
Shuldn't we simply return  on line 2581-2 ?
return {
stage: "base",
referenceSequenceNumber: summaryRefSeqNum,
minimumSequenceNumber,
error: continueResult.error,
};

Refers to: packages/runtime/container-runtime/src/containerRuntime.ts:2599 in 8e3c39c. [](commit_id = 8e3c39c0436bed33f5d9e5c531ee34b60aa708e6, deletion_comment = False)

I am not sure I understand what the issue is and how this change prevents it. What causes the cascade of errors? Is the goal to send a telemetry instead of throwing an error when restarting?
Can you add some more context in the description?

I am not sure I understand what the issue is and how this change prevents it. What causes the cascade of errors? Is the goal to send a telemetry instead of throwing an error when restarting? Can you add some more context in the description?

updated

  	this.summarizerNode.startSummary(summaryRefSeqNum, summaryNumberLogger);

do we need to invoke this in case refreshLatestAckFailed ?
Shuldn't we simply return on line 2581-2 ? return { stage: "base", referenceSequenceNumber: summaryRefSeqNum, minimumSequenceNumber, error: continueResult.error, };
Or even invoke checkContinue there ?
Refers to: packages/runtime/container-runtime/src/containerRuntime.ts:2599 in 8e3c39c. [](commit_id = 8e3c39c, deletion_comment = False)

I sync up with Tyler and the container is closed already at this point - we should be good.

If we don't implement this fix, we'll see these events, some as error events.
Spot checking a few docs, we would raise 5 error events each time we close the summarizer instead of refreshing.
fluid:telemetry:Container:ContainerClose | Restarting summarizer instead of refreshing | genericError | Restarting summarizer instead of refreshing
fluid:telemetry:SummarizerNode:refreshLatestSummary_cancel | Restarting summarizer instead of refreshing | genericError | Restarting summarizer instead of refreshing
fluid:telemetry:Summarizer:Running:HandleLastSummaryAckError | Restarting summarizer instead of refreshing | genericError | Restarting summarizer instead of refreshing
fluid:telemetry:Summarizer:Running:FailToSummarize | Restarting summarizer instead of refreshing | genericError | submitSummaryFailure: Error while generating, uploading, or submitting summary

You will see these 4 (not 5) errors during the second summary attempt. Bascially, there are 2 cases:

Second summary attempt here - This will always fail with your change and the 4 errors will be seen. We should just not do this attempt if the feature flag for restarting is enabled. Instead, close the summarizer there itself rather than doing this when attempting to refresh from snapshot.
Refresh on getting an ack - This is the more interesting one and you will see the first 4 errors. You should remove the HandleLastSummaryAckError error altogether because it's a duplicate of refreshLatestSummary_cancel. That would leave only 2 errors which is fine IMO.

If we don't implement this fix, we'll see these events, some as error events.
Spot checking a few docs, we would raise 5 error events each time we close the summarizer instead of refreshing.
fluid:telemetry:Container:ContainerClose | Restarting summarizer instead of refreshing | genericError | Restarting summarizer instead of refreshing
fluid:telemetry:SummarizerNode:refreshLatestSummary_cancel | Restarting summarizer instead of refreshing | genericError | Restarting summarizer instead of refreshing
fluid:telemetry:Summarizer:Running:HandleLastSummaryAckError | Restarting summarizer instead of refreshing | genericError | Restarting summarizer instead of refreshing
fluid:telemetry:Summarizer:Running:FailToSummarize | Restarting summarizer instead of refreshing | genericError | submitSummaryFailure: Error while generating, uploading, or submitting summary

You will see these 4 (not 5) errors during the second summary attempt. Bascially, there are 2 cases:

Second summary attempt here - This will always fail with your change and the 4 errors will be seen. We should just not do this attempt if the feature flag for restarting is enabled. Instead, close the summarizer there itself rather than doing this when attempting to refresh from snapshot.
Refresh on getting an ack - This is the more interesting one and you will see the first 4 errors. You should remove the HandleLastSummaryAckError error altogether because it's a duplicate of refreshLatestSummary_cancel. That would leave only 2 errors which is fine IMO.

I actually like it !

If we don't implement this fix, we'll see these events, some as error events.
Spot checking a few docs, we would raise 5 error events each time we close the summarizer instead of refreshing.
fluid:telemetry:Container:ContainerClose | Restarting summarizer instead of refreshing | genericError | Restarting summarizer instead of refreshing
fluid:telemetry:SummarizerNode:refreshLatestSummary_cancel | Restarting summarizer instead of refreshing | genericError | Restarting summarizer instead of refreshing
fluid:telemetry:Summarizer:Running:HandleLastSummaryAckError | Restarting summarizer instead of refreshing | genericError | Restarting summarizer instead of refreshing
fluid:telemetry:Summarizer:Running:FailToSummarize | Restarting summarizer instead of refreshing | genericError | submitSummaryFailure: Error while generating, uploading, or submitting summary

You will see these 4 (not 5) errors during the second summary attempt. Bascially, there are 2 cases:

Second summary attempt here - This will always fail with your change and the 4 errors will be seen. We should just not do this attempt if the feature flag for restarting is enabled. Instead, close the summarizer there itself rather than doing this when attempting to refresh from snapshot.
Refresh on getting an ack - This is the more interesting one and you will see the first 4 errors. You should remove the HandleLastSummaryAckError error altogether because it's a duplicate of refreshLatestSummary_cancel. That would leave only 2 errors which is fine IMO.

In case it wasn't clear, with these, you don't need any of the changes in container runtime / summarizer node. Basically, the errors thrown in refresh code is just fine.


[SQLITE3] Add reset API to reset sqlite3 statement

As I keep sqlite3 statement in a cache I need to reset them once they have been used. reset_if_needed was not enough as it was not reseting statement if it was not done SQLITE3_DONE

Looks OK to me

Apparently, this partially (SQLite3 only part) implements https://github.com/SOCI/soci/issues/52


[Bug]: Teams AI Bot has no response in chat after deploying to non-Testing environment and uploading to Teams.

Language
Javascript/Typescript
Version
latest
Description
Trying to deploy bot to Azure and upload it to Teams, it has no response to my questions in chat.
Reproduction steps:

Followed LightBot sample and tested it working in local with my Microsoft 365 Testing Tenant;
js/samples/04.ai.c.actionMapping.lightBot
Trying to deploy to MSIT tenant and Teams by following below steps.
In VS code Teams toolkit, log out Microsoft 365 testing tenant, and login M365 and Azure with my MSIT account;
Delete "openAIKey": { "value": "${{SECRET_OPENAI_KEY}}"} from infra/azure.parameters.json, and added "AZURE_OPENAI_KEY=<>" and "AZURE_OPENAI_ENDPOINT=<>" to env/.env.staging
Click "Provision" and select a resource group from a MSIT subscription;
Click "Deploy",
Click "Publish", it completed but I can't find the application in Teams,
Try another way, click utility "Zip Teams App Package", and then in Teams -> Apps -> Manage your Apps -> Upload an App, select the package, now I can add the bot to my Teams.
Chat with the bot in Teams, but it has no response to me.
I also Validate the app package, no errors.
I don't know how to figure out the problem, is there any logs I can check?
I also checked Azure bot, there is a "Test in Web chat" function, I tried it, and then in channels blade, I found there're some errors in Web chat.
...

and the error message is something like this:
"There was an error sending this message to your bot: HTTP status code Unauthorized"
Probably I missed something when trying to deploy the Teams application to MSIT Azure and Teams. Is there a document I can follow to do a real deployment after testing with "Microsoft 365 Testing tenant"?
[Update 3/18 - A]
I checked developer portal and uploaded the app package to developer portal, and clicked "Preview in Teams", and selected to use "web app", and login with my Microsoft account, it gave me this error:

"MSIT" is the Microsoft 365 Testing Tenant, for some reason it messed up with Microsoft tenant with "Microsoft 365 Testing Tenant", the app was uploaded to Microsoft developer portal and it thought it belongs to a Testing tenant.
[Update 3/18 - B]
I cleaned up everything and restarted the whole process, Provision/Deploy/build package/upload to Teams, the last error gone - "Selected user account does not exist in tenant 'MSFT' and cannot access the application '5e3ce6c0-2b1f-4285-8d4b-75ee78787346' in that tenant", unfortunately it still does not work, the bot has not response. And this time, in Azure, Teams bot has different issue in Teams channel with message "Error occurred while communicating with bot", and I also queried logs in Azure portal, got empty records for "Activities Sent from Clients to Direct Line", "Bot To Channels", "Channel to Bot", "Clients To Direct Line Channel", "Failed Requests", etc.

Reproduction Steps
see description.

Please note that these issues you are filing are not related to Teams Ai itself, so the help we'll be able to provide is limited. What you're experiencing is partially related to the tenant rules that have been modified recently on the Microsoft tenant, and therefore affects all apps. Teams Toolkit team is your best bet for getting help in this area.
The first error (Pick an account) means that your browser is either logged into the incorrect tenant (i.e., you are logged into your FTE account while trying to access your alt tenant or vice versa). I recently had problems where, even on an incognito browser, my credentials were mixed with my alt tenant even after signing out of FTE and into alt. Possibly a caching issue.
For #4 on your steps to repro, please see the other issue you filed which I converted to a discussion.
HTTP status code unauthorized: Means your bot id and/or password credentials are incorrect.

@corinagum , appreciated your inputs!
Could you please tell me how I can reach out to "Teams Toolkit team"? Github repo or an internal DG?
And in my last deployment, unauthorized issue gone, now only one left is the issue "Error occurred while communicating with bot" in Teams channel in Azure portal. I have no idea where to start investigating.

I'll try this one: https://github.com/microsoft/botframework-sdk

@dylanw-oss Correct repo is https://github.com/OfficeDev/TeamsFx

@corinagum
I found that the deployed bot app service has some problem.

the provision does not work for openAIKey, even it is defined in infra/azure.parameters.json, the bicep file doesn't have reference to it. I'll open another bug for it.
I deployed the sample by removing openAIKey from infra/azure.parameters.json and then in Azure portal, bot App service environment variable, manually add "AZURE_OPENAI_KEY" and "AZURE_OPENAI_ENDPOINT"

And in Kudu, I found there is an error log in site/LogFiles/Application/logging-errors.txt
  Error: Cannot find module 'dotenv'
  Require stack:
  - C:\home\site\wwwroot\lib\index.js
  - C:\Program Files (x86)\iisnode\interceptor.js
      at Function.Module._resolveFilename (node:internal/modules/cjs/loader:933:15)
      at Function.Module._load (node:internal/modules/cjs/loader:778:27)
      at Module.require (node:internal/modules/cjs/loader:1005:19)
      at require (node:internal/modules/cjs/helpers:102:18)
      at Object.<anonymous> (C:\home\site\wwwroot\lib\index.js:29:18)
      at Module._compile (node:internal/modules/cjs/loader:1105:14)
      at Object.Module._extensions..js (node:internal/modules/cjs/loader:1159:10)
      at Module.load (node:internal/modules/cjs/loader:981:32)
      at Function.Module._load (node:internal/modules/cjs/loader:822:12)
      at Module.require (node:internal/modules/cjs/loader:1005:19)```
And there is no dotenv under C:\home\site\wwwroot\node_modules>
![image](https://github.com/microsoft/teams-ai/assets/53635739/4c0e6270-06d7-4bf2-a91d-ac57f9fa4984)

@corinagum, there is no such issue on my local, no matter I run yarn install under js folder or the specific sample folder. When we use provision/deploy we need to start from sample folder in VS Code, and the problem happens in Azure, the package.json does have the reference of dotenv, it seems that yarn install wasn't run during publishing? Can you confirm if js sample works in Azure, I suspect it's some common issue.

@corinagum, I know what you mean. The dotenv package was installed under /teams-ai/js/node_modules/dotenv folder, but when we run provision and deploy in VS Code, we have to open specific sample folder, right? I think the install/build/package during the Deploy step will only use the packages under the sample folder, for example, /teams-ai/js/samples/04.ai.c.actionMapping.lightBot/node_modules/
That's the reason why we got "Error: Cannot find module 'dotenv'" in Azure bot service.

@corinagum, I know what you mean. The dotenv package was installed under /teams-ai/js/node_modules/dotenv folder, but when we run provision and deploy in VS Code, we have to open specific sample folder, right? I think the install/build/package during the Deploy step will only use the packages under the sample folder, for example, /teams-ai/js/samples/04.ai.c.actionMapping.lightBot/node_modules/ That's the reason why we got "Error: Cannot find module 'dotenv'" in Azure bot service.

Sorry for the confusion. What I meant was, I do see "dotenv" under the sample's package.json, so theoretically it should be added on the deploy step.
If you haven't already, could you try the following?

delete node modules in the sample folder
do yarn && yarn build inside the sample folder
Test the sample / deploy
Publish to Azure bot service

Could you tell me what steps you run into errors? You're also welcome to message me internally; my alias is the same as my github username.

@corinagum, I tried these 4 steps with sample 01.messaging.a.echoBot and it works. But it does not work with sample 04.ai.c.actionMapping.lightBot.
My observation: step 1 and 2 can recover all packages in sample folder for both samples, but when run deploy from VS code, sample 04.ai.c.actionMapping.lightBot node_modules folder was refreshed and only a few packages lefts, and this didn't happen for sample 01, which is very weird.
I workaround this by removing the first two cli/runNpmCommand from /teams-ai/js/samples/04.ai.c.actionMapping.lightBot/teamsapp.yml, and VS Code Teams Toolkit / Deploy can deploy all required packages to Azure Bot service.

@corinagum, I can successfully run sample 01.messaging.a.echoBot with its bot and service deployed in Azure! :nerd_face:
But the same issue (bot has no response) still occurs for sample using Azure OpenAI, e.g. 04.ai.c.actionMapping.lightBot, I suspected that there is some issue happened when it communicating with Azure OpeanAI endpoint, but if it's the case it should at least respond something like "The bot encountered an error or bug."?

Issue was found, and new bug filed: https://github.com/microsoft/teams-ai/issues/1439
closing this as resolved :)


Update MD file on new branch 2017-16-13_20-11-35

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestRef.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Update interface to support object translation, scaling and rotation features.

https://github.com/ramnasidharta/graphical-recipe/pull/16


unintended escaped string for hover

🔎 Search Terms
"lsp"
🕗 Version & Regression Information
version "typescript": "5.3.3"
⏯ Playground Link
No response
💻 Code
// 🦁.ts
export const foo = "bar";

// main.ts
import { bar } from './🦁.ts';

🙁 Actual behavior
The lsp message shows Module '"./\uD83E\uDD81.ts"' has no exported member 'bar'.ts(2305).
🙂 Expected behavior
It should be Module '"./🦁.ts"' has no exported member 'bar'.ts(2305).
Additional information about the issue

This likely falls under the umbrella here (it's worked on here)

@Andarist Wait, is that even related?  That looks like it's about arbitrary import names, e.g.
import { "😊" as yay } from "foo";

...which doesn't work at all today (i.e. it's a feature request), whereas this issue is about unicode characters in module specifiers, which does work today, the specifier is just not being rendered property in error messages.

You are totally right. I'm trying to do to much lately and it seems my circuits are overheating :v

My penance: https://github.com/microsoft/TypeScript/pull/57550