#88 logout functionality

What does this PR do?
adds logout functionality
Description of Task to be completed?

adds logout fuction
revokes the token from local storage

How should this be manually tested?
go to http://<IP_ADDRESS>:5173/dashboard and press logout

there are two AuthUser.jsx files in redux/reducers folder you can also remove one of them


Feat - Added test build command

Description of change
Added test build command based on start command to ensure the wiki can build properly with the user's changes and avoid build errors in the wiki
Open Questions
Since 99% of the code is the same as the code in the start command, it may be better to:

Add a flag in start to switch the yarn action.
Create a base class which is later extended by both test and start.

Type of change

Enhancement (a non-breaking change that adds functionality)

How the change has been tested
Locally.
Change checklist

[x] I have followed the contribution guidelines for this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas

@eike-hass , whenever you have a moment, could you have a look at this?

LGTM, release as v1.6.0

LGTM, release as v1.6.0

Thanks!


Critical CVE vulnerabilities in Go versions < 1.17.8

Our scanning tools have picked up several high and critical CVE vulnerabilities in tigera/operator:v1.25.3. All these vulnerabilities are related to the Go version. It looks like upgrading to Go version 1.17.8+ would fix these issues.
Is there a plan to upgrade the go version to 1.17.8 or higher?
Is there any way to mitigate the severity of these vulnerabilities?
Any help would be very much appreciated!
Critical: https://nvd.nist.gov/vuln/detail/CVE-2022-23806
High: https://nvd.nist.gov/vuln/detail/CVE-2022-27191
High: https://nvd.nist.gov/vuln/detail/CVE-2022-24921
High: https://nvd.nist.gov/vuln/detail/CVE-2022-23773
High: https://nvd.nist.gov/vuln/detail/CVE-2022-23772

The latest branches have been updated and will be built with the new golang version.
Here are some PRs for older branches as well:

https://github.com/projectcalico/calico/pull/5898
https://github.com/tigera/operator/pull/1899
https://github.com/tigera/operator/pull/1901
https://github.com/tigera/operator/pull/1902

^ PRs are merged, next releases will be built with 1.17.8

Hi @caseydavenport can we please use 1.17.9, it fixes a critical CVE CVE-2022-27191
cc @zander312


Problem with Julia API on Ubuntu 24.04

Hi @findmyway, as promised here is some more information on the breakage of the Julia API on Ubuntu 24.04.
Interestingly, it still works on Ubuntu-22.04 as it is included in one of our CI tests which we've run several times recently (i.e. on the current head of master).
Here's how to reproduce:
(venv) lanctot@nitro-exp:~/open_spiel$ OPEN_SPIEL_BUILD_WITH_JULIA=ON ./install.sh
               .
               .
               .
++ bash open_spiel/scripts/jill.sh -y -v 1.6.1
JILL - Julia Installer 4 Linux - Light
Copyright (C) 2017-2023 Abel Soares Siqueira<EMAIL_ADDRESS>Distributed under terms of the GPLv3 license.

This script will:

  - Try to download julia version '1.6.1'
  - Create a link for julia
  - Create a link for julia-VER

Download folder: '/home/lanctot/packages/julias'
Link folder: '/home/lanctot/.local/bin'

Download folder will be created if required
Downloading Julia version 1.6.1
++ [[ -f /usr/lib/x86_64-linux-gnu/libstdc++.so.6 ]]
++ cp /usr/lib/x86_64-linux-gnu/libstdc++.so.6 /home/lanctot/packages/julias/julia-1.6.1/lib/julia
+++ which julia
++ [[ -x /home/lanctot/.local/bin/julia ]]
+++ julia -e 'println(VERSION >= v"1.6.1")'
++ '[' true == true ']'
++ julia --project=/home/lanctot/open_spiel/open_spiel/julia -e 'using Pkg; Pkg.instantiate();'
  Installing known registries into `~/.julia`
       Added registry `General` to `~/.julia/registries/General`
   Installed MacroTools ─────────── v0.5.13
   Installed JLLWrappers ────────── v1.5.0
   Installed Preferences ────────── v1.4.3
   Installed libcxxwrap_julia_jll ─ v0.8.8+1
   Installed CxxWrap ────────────── v0.11.2
  Downloaded artifact: libcxxwrap_julia
Precompiling project...
  ✗ OpenSpiel
  8 dependencies successfully precompiled in 9 seconds
  1 dependency errored. To see a full report either run `import Pkg; Pkg.precompile()` or load the package

(venv) lanctot@nitro-exp:~/open_spiel$ which julia
/home/lanctot/.local/bin/julia
(venv) lanctot@nitro-exp:~/open_spiel$ julia --project=/home/lanctot/open_spiel/open_spiel/julia
               _
   _       _ _(_)_     |  Documentation: https://docs.julialang.org
  (_)     | (_) (_)    |
   _ _   _| |_  __ _   |  Type "?" for help, "]?" for Pkg help.
  | | | | | | |/ _` |  |
  | | |_| | | | (_| |  |  Version 1.6.1 (2021-04-23)
 _/ |\__'_|_|_|\__'_|  |  Official https://julialang.org/ release
|__/                   |

julia> using Pkg; Pkg.instantiate();
Precompiling project...
  ✗ OpenSpiel
  0 dependencies successfully precompiled in 2 seconds (8 already precompiled)
  1 dependency errored. To see a full report either run `import Pkg; Pkg.precompile()` or load the package

julia> import Pkg; Pkg.precompile()
Precompiling project...
  ✗ OpenSpiel
  0 dependencies successfully precompiled in 2 seconds (8 already precompiled)

ERROR: The following 1 direct dependency failed to precompile:

OpenSpiel [7e5d8dc8-489f-4be6-9273-f4c3010e6ec1]

ERROR: LoadError: could not load library "/home/lanctot/open_spiel/open_spiel/julia/deps/../../../build/julia/libspieljl"
/home/lanctot/open_spiel/open_spiel/julia/deps/../../../build/julia/libspieljl.so: cannot open shared object file: No such file or directory
Stacktrace:
  [1] dlopen(s::String, flags::UInt32; throw_error::Bool)
    @ Base.Libc.Libdl ./libdl.jl:114
  [2] dlopen
    @ ./libdl.jl:114 [inlined]
  [3] readmodule(so_path::String, funcname::Symbol, m::Module, flags::Nothing)
    @ CxxWrap.CxxWrapCore ~/.julia/packages/CxxWrap/OcN1Z/src/CxxWrap.jl:724
  [4] wrapmodule(so_path::String, funcname::Symbol, m::Module, flags::Nothing)
    @ CxxWrap.CxxWrapCore ~/.julia/packages/CxxWrap/OcN1Z/src/CxxWrap.jl:729
  [5] top-level scope
    @ ~/open_spiel/open_spiel/julia/src/OpenSpiel.jl:9
  [6] include
    @ ./Base.jl:386 [inlined]
  [7] include_package_for_output(pkg::Base.PkgId, input::String, depot_path::Vector{String}, dl_load_path::Vector{String}, load_path::Vector{String}, concrete_deps::Vector{Pair{Base.PkgId, UInt64}}, source::Nothing)
    @ Base ./loading.jl:1213
  [8] top-level scope
    @ none:1
  [9] eval
    @ ./boot.jl:360 [inlined]
 [10] eval(x::Expr)
    @ Base.MainInclude ./client.jl:446
 [11] top-level scope
    @ none:1
in expression starting at /home/lanctot/open_spiel/open_spiel/julia/src/OpenSpiel.jl:1
Stacktrace:
 [1] pkgerror(msg::String)
   @ Pkg.Types /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.6/Pkg/src/Types.jl:55
 [2] precompile(ctx::Pkg.Types.Context; internal_call::Bool, strict::Bool, kwargs::Base.Iterators.Pairs{Union{}, Union{}, Tuple{}, NamedTuple{(), Tuple{}}})
   @ Pkg.API /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.6/Pkg/src/API.jl:1244
 [3] precompile
   @ /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.6/Pkg/src/API.jl:920 [inlined]
 [4] #precompile#196
   @ /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.6/Pkg/src/API.jl:918 [inlined]
 [5] precompile()
   @ Pkg.API /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.6/Pkg/src/API.jl:918
 [6] top-level scope
   @ REPL[2]:1

julia>
(venv) lanctot@nitro-exp:~/open_spiel$ mkdir build
(venv) lanctot@nitro-exp:~/open_spiel$ cd build/
(venv) lanctot@nitro-exp:~/open_spiel/build$ OPEN_SPIEL_BUILD_WITH_JULIA=ON cmake -DPython3_EXECUTABLE=python -DCMAKE_CXX_COMPILER=clang++ ../open_spiel
              .
              .
              .
CMake Error at julia/CMakeLists.txt:1 (find_package):
  By not providing "FindJlCxx.cmake" in CMAKE_MODULE_PATH this project has
  asked CMake to find a package configuration file provided by "JlCxx", but
  CMake did not find one.

  Could not find a package configuration file provided by "JlCxx" with any of
  the following names:

    JlCxxConfig.cmake
    jlcxx-config.cmake

  Add the installation prefix of "JlCxx" to CMAKE_PREFIX_PATH or set
  "JlCxx_DIR" to a directory containing one of the above files.  If "JlCxx"
  provides a separate development package or SDK, be sure it has been
  installed.

-- Configuring incomplete, errors occurred!
(venv) lanctot@nitro-exp:~/open_spiel/build$

Note: I tried increasing the versions of Julia and CxxWrap in Project.toml but that didn't seem to work.

Note: you should not need to build with python, so you can safely remove -DPython3_EXECUTABLE=python.. I'm just used to always including it.

Got it, I'll look into it soon.

Here's what I found:

The error with install.sh can be safely ignored. Because at that time, the openspiel lib is not built yet.

https://github.com/google-deepmind/open_spiel/blob/1208f832568063c36d0e3076069e103d5b00cf5b/open_spiel/scripts/install.sh#L219

The above line needs to be updated:

- cp /usr/lib/x86_64-linux-gnu/libstdc++.so.6 $HOME/packages/julias/julia-1.6.1/lib/julia
+ cp /usr/lib/x86_64-linux-gnu/libstdc++.so.6 /opt/julias/julia-1.6.1/bin/../lib/julia/libstdc++.so.6

Hmm, I retried and I am still getting that CMake error above that it cannot find the configuration file.
There is also nothing in /opt, because the installer is putting it into $HOME/packages/julias like before.
This is on a fresh install of Ubuntu 24.04.

Ohhh, I had totally forgotten about that extra environment variable. Good call, and I just checked: it works!  I will add a test that re-enables the Julia API test. Thanks for helping with this!


Log4net assumes xml configuration

When using
AWSConfigs.LoggingConfig.LogTo = LoggingOptions.Log4Net;

it calls
XmlConfigurator.Configure()

in https://github.com/aws/aws-sdk-net/blob/5f19301ee9fa1ec29b11b3dfdee82071a04ed5ae/AWSSDK_DotNet35/Amazon.Runtime/Internal/Util/Logger.Log4net.cs#L119.
This results in the following error:
log4net:ERROR XmlConfigurator: Failed to find configuration section 'log4net' in the application's .config file. Check your .config file for the <log4net> and <configSections> elements. The configuration section should look like:

log4net:ERROR XmlConfigurator: Failed to find configuration section 'log4net' in the application's .config file. Check your .config file for the <log4net> and <configSections> elements. The configuration section should look like:

While this is a common way of configuring log4net, it is definitely not the only way (I am configuring in code, as I do not want to ship a config file with my application).
It might be worth checking whether the logging is already configured before calling this method.

Thanks for pointing this out. I will add a call to LogManager.GetRepository().Configured to see if log4net is already configured, this way we can avoid the extraneous XmlConfigurator.Configure() call.

I've created a fix for it, with some tests, but I'm not convinced that it should be merged.
It seems the code goes to a lot of effort to ensure that it doesn't have a dependency on log4net, so adding a dependency to be able to test this seems wrong.
I've also had to make public some internal classes to make it work (InternalLog4netLogger & InternalLogger) which didn't feel great. (I tried the InternalsVisibleTo approach, but it didn't work too well given its strongly named).
So... you may just want the actual fix to InternalLog4netLogger, without the tests.
Let me know if you want a PR for that.

I was thinking of making a reflection-only call to LogManager.GetRepository().Configured (similar to the code here) , so the change itself should be fairly straightforward, but I agree with you, adding tests for this is problematic.
Though, giving it some more thought, it sounds like overall this would be a breaking change: existing customers could be attaching listeners as you are doing, through code, but if they also have an app.config, they may be "relying" on the SDK to make the XmlConfigurator.Configure() call to pick up the log4net config.
In essence, we're currently performing log4net XML configuration, and if this was suddenly removed then the above customers would have to make the call on their own, which would require a code change.
I'll keep thinking about this, but at the moment I don't think we should make this change.

Hmmm... I think that case is unlikely, but it is definitely possible... It also doesn't seem the kind of thing that merits a major version bump as well.
Maybe we could add a check for the config file to see if it exists before calling XmlConfigurator.Configure() using the same logic as log4net uses to determine the config file name - https://github.com/apache/log4net/blob/84a6c6c2af369ee525effc4e6f3262b08a82459b/src/log4net/Util/SystemInfo.cs#L167.
Either that, or we expose a boolean flag that defaults to true that we check before we call the method? This might be the easiest / lowest impact approach.

I like your first approach, though I believe it should be enough to attempt and retrieve the config element, and then check if it is null, in which case we can skip the XmlConfigurator.Configure() call. I don't think we need to use log4net's SystemInfo.ConfigurationFileLocation for this purpose.

Okay, sounds like we are on the same page.
Want me to create a PR?

No need, we've already made the changes internally. This fix should be out with the next release of the SDK.

Great, thanks.

Version 2.3.26 of the SDK has just been released and it contains this fix.

Brilliant. Thanks @PavelSafronov!


plugin dev question - check for local files

My iterm2 is loading really slow.  I had some pyenv init commands that add 1 second to my load time.  Without those (not via the pyenv plugin) my shell loads quick.
with out pyenv plugin or pyenv init hard coded
machine-d 福 ~
10022 ◯ : /usr/bin/time zsh -i -c exit
        0.38 real         0.17 user         0.12 sys

with the pyenv -init scripts in my .zshrc, it takes about 1.5 seconds.
with the pyenv plugin, it's even worse!
machine-id 福 ~
10018 ◯ : /usr/bin/time zsh -i -c exit
        4.99 real         1.54 user         0.95 sys

So I want to write my own pyenv plugin, and just make it very quick.

check for .python-version file
if that exists, run the init scripts

I've looked at a few plugins but not sure how in a plugin to check to see if a specific file exists in the current working directory.   Is there a plugin I could look at to figure this out?

check for .python-version file
if that exists, run the init scripts

You want to check if the .python-version exists in current working directory on zsh start? If so, you just use a conditional:
if [[ -f .python-version ]]; then

See zsh conditional expressions.


String kernels can exploit biases in SMILES string format, skewing performance metrics

Just a heads up on this issue:
https://github.com/deepchem/moleculenet/issues/15
I propose that string-based classifiers canonicalize smiles prior to processing to prevent confounded performance, CI, etc. estimates.

Thanks for raising this! I made a change to the photoswitch dataset to canonicalise all SMILES as a preprocessing step a couple of weeks ago, will make sure this is implemented for the other datasets!

It's possible canonicalization doesn't fully eliminate the bias (e.g. if one set calculates smiles at a different pH or is more likely to include salt forms. You can see that in the enrichment for "." and "+" characters between positive and negative examples in clintox.

Interesting! @henrymoss and I will keep track of this conversation you guys are having in DeepChem!

This is interesting indeed!
I wonder if this aligns with the observed lack of improvements we were getting when augmenting the data by adding extra (non-canonical) SMILES. Basically, we could only learn from training data in canonical form, as our test data was also canonical. Even increasing the data x5 (through augmentation), we couldn't improve performance.


Remove container fails on 1.11 due to root filesystem busy - regression

Something changed between commits c48439a...dd51e85 in 1.11 development where the daemon now fails removal of containers in some circumstances.  I haven't managed to figure out exactly what is unique about our use-case that triggers the failure yet.  Here's what I do know:

We've seen it fail primarily on AWS.
It fails with aufs and devicemapper (tested with debian AMIs and centos AMIs)
I have repro'd on debian running under KVM (but not with boot2docker+machine)
Our use-case is a bit complicated and involves a container mounting the docker.sock and spawning a second container with various additional volume/host mounts, which in turn attempts to stop/remove containers that share some of the same volume mounts.  It seems some portion of this is required to trigger this failure mode, as running docker stop and docker rm by hand works without failure.

I've been attempting a git bisect on the docker/docker tree to find the exact commit that broke it but I'm having some challenges as the containerd integration was going through churn during this timeframe so many commits aren't yielding a testable setup for me.
Examples from the client's perspective:
DEBU[0000] daemon reported: Error response from daemon: Driver aufs failed to remove root filesystem 25693d520e87d334fedbfd8f1bc31748be35cae690ab3e1f8fad0c79a5ca3946: rename /var/lib/docker/aufs/diff/7aa440b05939346200bec909079a4e280303dfebd6898c665ed119b537f7c3ed /var/lib/docker/aufs/diff/7aa440b05939346200bec909079a4e280303dfebd6898c665ed119b537f7c3ed-removing: device or resource busy

What you see on the damon log:
Apr 12 23:28:13 dh-manual-test1 docker[29379]: time="2016-04-12T23:28:13.135946618Z" level=error msg="Error removing mounted layer 25693d520e87d334fedbfd8f1bc31748be35cae690ab3e1f8fad0c79a5ca3946: rename /var/lib/docker/aufs/diff/7aa440b05939346200bec909079a4e280303dfebd6898c665ed119b537f7c3ed /var/lib/docker/aufs/diff/7aa440b05939346200bec909079a4e280303dfebd6898c665ed119b537f7c3ed-removing: device or resource busy"
Apr 12 23:28:13 dh-manual-test1 docker[29379]: time="2016-04-12T23:28:13.136021604Z" level=error msg="Handler for DELETE /containers/25693d520e87d334fedbfd8f1bc31748be35cae690ab3e1f8fad0c79a5ca3946 returned error: Driver aufs failed to remove root filesystem 25693d520e87d334fedbfd8f1bc31748be35cae690ab3e1f8fad0c79a5ca3946: rename /var/lib/docker/aufs/diff/7aa440b05939346200bec909079a4e280303dfebd6898c665ed119b537f7c3ed /var/lib/docker/aufs/diff/7aa440b05939346200bec909079a4e280303dfebd6898c665ed119b537f7c3ed-removing: device or resource busy"

I'll continue my investigation and update this issue as I uncover more details.

I think your link is backwards: https://github.com/docker/docker/compare/c48439a...dd51e85

Oops, git CLI is fine with it reversed but not github - fixed.

@vikstrous is this the same as https://github.com/docker/docker/issues/21704?

@thaJeztah I can't repro #21704 any more, so that makes me suspect that this is not the same. If you guys manage to track this one down, it might shed some light on whether or not they are the same.

It appears this issue correlates to older kernels.  The common theme on all the systems I've reproduced it on are older kernels, and the systems where it doesn't happen are much newer.
Failures seen on:
Linux dockerexp 3.16.0-4-amd64 #1 SMP Debian 3.16.7-ckt11-1+deb8u4 (2015-09-19) x86_64 GNU/Linux
Linux dh-manual-test2 3.16.0-4-amd64 #1 SMP Debian 3.16.7-ckt11-1 (2015-05-24) x86_64 GNU/Linux
Linux dh-manual-test7 3.10.0-229.14.1.el7.x86_64 #1 SMP Tue Sep 15 15:05:51 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux

I'm not sure if this is related, but based on our observations this error appears in the same set of kernels that exhibit this behavior:
docker inspect $(docker run -d -m 15MB --privileged busybox tail -f) | grep \"Memory\"
WARNING: Your kernel does not support memory limit capabilities. Limitation discarded.
           "Memory": 0,

I just upgraded my kernel and am seeing this bug constantly.
Linux clone3 3.16.0-70-generic #90~14.04.1-Ubuntu SMP Wed Apr 6 22:56:34 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux

Same here
Linux 3.16.0-4-amd64 #1 SMP Debian 3.16.7-ckt25-2 (2016-04-08) x86_64 GNU/Linux

@pdevine @ugurarpaci do you have any way to reproduce this? Is your use case similar to @dhiltgen with additional volume mounts? Are you also using aufs (or dm?).

I think @dhiltgen may have the most reproducible work around.  It's very intermittent for me.

It appears that the scenario I'm hitting is related to /var/run being mounted in any container on these systems.  On these older kernels, if any container mounts /var/run from the host, then other containers can't be removed.

@justincormack the first problem occurrence could be about /var/run  mounting, but that is the convention we have been using for months so I have ignored It. Therefore I thought that could be related to kernel version and I have migrated to the containers to a new VM with updated kernel (Debian 3.16.7). After that I have reproduced the problem once and I have removed and restarted all the file layers under /var/lib/docker but now that seems okay.

Found something related to this issue that got fixed in 3.19 kernels, which could explain why the issue doesnt happen on newer kernels.
http://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/commit/?h=linux-3.19.y&id=8ed936b5671bfb33d89bc60bdcc7cf0470ba52fe
@ugurarpaci , would you be able to test with a 3.19 kernel?

@anusha-ragunathan  For sure, I will try that. My experience about the problem is that this is more like a meta data problem somehow. I have tried the 1.11.0 version on different kernel versions like 3.2 and newer (3.16 for the latest scenario). The problem occurs randomly; the daemon complains about the aufs layers (which does not exist on the filesystem -interestingly-) which blocks the rm therefore rmi operations. After the docker daemon restart, everything becomes shiny. I try to collect more data about my scenario anyway =)

@ugurarpaci kernel 3.2 is expected; docker does not run on kernels older than 3.10

A simple experiment confirms that 3.19 kernel has robust handling of file removal, which is what fixes the reported issue.
On Debian 8 (which ships with 3.16.0-4-amd64 by default)
$ docker run -d --name test busybox top
$ docker run -d --name test2 -v /var/run:/var/run busybox top
$ docker kill test && docker rm test # rm FAILS with EBUSY
On Ubuntu 15.04 (which ships with 3.19.0-58-generic by default)
$ docker run -d --name test busybox top
$ docker run -d --name test2 -v /var/run:/var/run busybox top
$ docker kill test && docker rm test # rm SUCCEEDS

Seeing similar issue, but with a container that did not have any mounts. It had a restart policy of on-failure and a syslog driver. Problem occurred when stopping the container using docker stop and failing to rm it. Restarting docker engine fixed the problem and the container was removed.

@pheuter That sounds like a different issue.
Can you open a new issue with all the details?
Thanks!

@cpuguy83 gotcha, will do!

@mlaventure should this be resolved by https://github.com/docker/docker/issues/22256?

Yep. Closing since this is resolved now by not mounting the container's rootfs into /var/run

@thaJeztah @cpuguy83 Will nested bind mounts still be an issue for paths other than /var/run on kernels < 3.19? I anticipate it will but just want to be clear.

/var/lib will also be an issue.

@anusha-ragunathan Thanks for the clarification


https://dapp.neutralproject.com/ is not working in DApp Browser

Works in Trust.

https://dapp.neutralproject.com/ is still not working in DApp Browser on Version 2.0(276)

Doesn't work on 2.02(282)

@zhangzhongnan928 I see this after the prompt to sign the message and signing.

How do we reproduce the error?

The popup window doesn’t show up on my phone, build 2.01(281)
Victor Zhang
CEO, AlphaWallet
Not only display information, @Alpha_Wallet let you preform the functions: DEPOSIT, WITHDRAW, PAYBACK, GENERATE, MO… https://t.co/6dJfdvnM3i

On 11 Jun 2019, at 17:43, Hwee-Boon Yar<EMAIL_ADDRESS>wrote:
@zhangzhongnan928 I see this after the prompt to sign the message and signing.
How do we reproduce the error?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@hboon tested on James's iPhone and my iPad, all works fine besides my iPhone.
We think it may be an issue from the browser cache.
We should provide a Clear Browser Cache function in the setting page
https://github.com/AlphaWallet/alpha-wallet-ios/issues/1244

Closed to follow discussions on #1244


Tracks being a .json

Wouldn't be better if the tracks were .json files?

Do you mean the model of the track or the python script?

It would take like forever to change all of them from .py files to .json files, Plus why? You could've just edited the .py script of them, You don't need .json files.

It would take like forever to change all of them from .py files to .json files, Plus why? You could've just edited the .py script of them, You don't need .json files.

Wait what? The tracks aren't json files, they're .obj's. I use json files for saving the highscores and the unlocks

He ment the python files but ok.

Ah ok, sorry I misunderstood


Use flush to accelerate in-memory big data write to storage.

fp.Sync() may take serval minutes to write in-memory big data to storage.
Use Flush method instead to accelarate it.

/ok-to-test

/ok-to-test

/ok-to-test


Backport HBASE-25281 Bulkload split hfile too many times due to unreasonable split point

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 17s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
4m  4s
branch-2 passed

+1 :green_heart:
checkstyle
1m 15s
branch-2 passed

+1 :green_heart:
spotbugs
2m  8s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 39s
the patch passed

+1 :green_heart:
checkstyle
1m 14s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
12m 51s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

-1 :x:
spotbugs
2m 21s
hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

+1 :green_heart:
asflicense
0m 13s
The patch does not generate ASF License warnings.

36m 54s

Reason
Tests

FindBugs
module:hbase-server

Computation of average could overflow in org.apache.hadoop.hbase.tool.LoadIncrementalHFiles.groupOrSplit(Multimap, LoadIncrementalHFiles$LoadQueueItem, Table, Pair)  At LoadIncrementalHFiles.java:in org.apache.hadoop.hbase.tool.LoadIncrementalHFiles.groupOrSplit(Multimap, LoadIncrementalHFiles$LoadQueueItem, Table, Pair)  At LoadIncrementalHFiles.java:[line 807]

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2692/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2692

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 9002f4487ba6 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 0a1decdf18

spotbugs
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2692/1/artifact/yetus-general-check/output/new-spotbugs-hbase-server.html

Max. process+thread count
84 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2692/1/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 38s
Docker mode activated.

-0 :warning:
yetus
0m  7s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
3m 44s
branch-2 passed

+1 :green_heart:
compile
0m 57s
branch-2 passed

+1 :green_heart:
shadedjars
5m 58s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 37s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 13s
the patch passed

+1 :green_heart:
compile
0m 56s
the patch passed

+1 :green_heart:
javac
0m 56s
the patch passed

+1 :green_heart:
shadedjars
6m  2s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 37s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
150m  6s
hbase-server in the patch passed.

174m 55s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2692/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2692

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 80ade34d6890 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 0a1decdf18

Default Java
AdoptOpenJDK-1.8.0_232-b09

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2692/1/testReport/

Max. process+thread count
3723 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2692/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
2m 30s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
4m 47s
branch-2 passed

+1 :green_heart:
compile
1m 10s
branch-2 passed

+1 :green_heart:
shadedjars
7m 25s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 43s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 32s
the patch passed

+1 :green_heart:
compile
1m 12s
the patch passed

+1 :green_heart:
javac
1m 12s
the patch passed

+1 :green_heart:
shadedjars
7m 18s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 41s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
198m 24s
hbase-server in the patch passed.

230m 40s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2692/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2692

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux f7e9dfea7752 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 0a1decdf18

Default Java
AdoptOpenJDK-11.0.6+10

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2692/1/testReport/

Max. process+thread count
2820 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2692/1/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 35s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
3m 43s
branch-2 passed

+1 :green_heart:
checkstyle
1m  8s
branch-2 passed

+1 :green_heart:
spotbugs
2m  0s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 14s
the patch passed

+1 :green_heart:
checkstyle
1m  6s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
11m 41s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
2m  6s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 15s
The patch does not generate ASF License warnings.

33m  7s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2692/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2692

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux d58afbee1e02 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 0a1decdf18

Max. process+thread count
94 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2692/2/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 10s
Docker mode activated.

-0 :warning:
yetus
0m  7s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
4m 24s
branch-2 passed

+1 :green_heart:
compile
1m 11s
branch-2 passed

+1 :green_heart:
shadedjars
7m 22s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 41s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 28s
the patch passed

+1 :green_heart:
compile
1m 10s
the patch passed

+1 :green_heart:
javac
1m 10s
the patch passed

+1 :green_heart:
shadedjars
7m 19s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 41s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
196m 42s
hbase-server in the patch passed.

227m  5s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2692/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2692

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 71ee63894c49 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 0a1decdf18

Default Java
AdoptOpenJDK-11.0.6+10

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2692/2/testReport/

Max. process+thread count
2982 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2692/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 18s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
4m  0s
branch-2 passed

+1 :green_heart:
compile
1m  1s
branch-2 passed

+1 :green_heart:
shadedjars
6m 31s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 37s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 43s
the patch passed

+1 :green_heart:
compile
0m 58s
the patch passed

+1 :green_heart:
javac
0m 58s
the patch passed

+1 :green_heart:
shadedjars
6m 28s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 36s
the patch passed

_ Other Tests _

-1 :x:
unit
213m 18s
hbase-server in the patch failed.

240m 27s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2692/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2692

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux a34dd50c56e1 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / 0a1decdf18

Default Java
AdoptOpenJDK-1.8.0_232-b09

unit
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2692/2/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2692/2/testReport/

Max. process+thread count
2889 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2692/2/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

The failed ut https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2692/2/testReport/org.apache.hadoop.hbase.quotas/TestLowLatencySpaceQuotas/precommit_checks___yetus_jdk8_Hadoop2_checks___testBulkLoading/ seems related? @nyl3532016

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 57s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
4m 18s
branch-2 passed

+1 :green_heart:
checkstyle
1m 20s
branch-2 passed

+1 :green_heart:
spotbugs
2m 22s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 54s
the patch passed

+1 :green_heart:
checkstyle
1m 17s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
13m 22s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
2m 31s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 14s
The patch does not generate ASF License warnings.

39m 25s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2692/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2692

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux dbc917894060 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / d523d758af

Max. process+thread count
84 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2692/3/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 30s
Docker mode activated.

-0 :warning:
yetus
0m  7s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
4m 15s
branch-2 passed

+1 :green_heart:
compile
1m  6s
branch-2 passed

+1 :green_heart:
shadedjars
6m 37s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 42s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 59s
the patch passed

+1 :green_heart:
compile
1m  5s
the patch passed

+1 :green_heart:
javac
1m  5s
the patch passed

+1 :green_heart:
shadedjars
6m 40s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 41s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
130m 57s
hbase-server in the patch passed.

159m 53s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2692/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2692

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 02569410cd31 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / d523d758af

Default Java
AdoptOpenJDK-11.0.6+10

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2692/3/testReport/

Max. process+thread count
4041 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2692/3/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 18s
Docker mode activated.

-0 :warning:
yetus
0m  7s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2 Compile Tests _

+1 :green_heart:
mvninstall
3m 59s
branch-2 passed

+1 :green_heart:
compile
0m 59s
branch-2 passed

+1 :green_heart:
shadedjars
6m 31s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 37s
branch-2 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 41s
the patch passed

+1 :green_heart:
compile
1m  1s
the patch passed

+1 :green_heart:
javac
1m  1s
the patch passed

+1 :green_heart:
shadedjars
6m 30s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 36s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
205m 41s
hbase-server in the patch passed.

232m 52s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2692/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2692

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux d4afdb70ecf3 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2 / d523d758af

Default Java
AdoptOpenJDK-1.8.0_232-b09

Test Results
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2692/3/testReport/

Max. process+thread count
2937 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2692/3/console

versions
git=2.17.1 maven=3.6.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


npm install step

Needed to also npm install for the front end app relevant piece. Noting in the documentation.
Without it, i got this error after step 5:
ActionView::Template::Error (Unable to run node_modules/.bin/browserify. Ensure you have installed it with npm.
  (in /home/yuvilio/ws/apps/ruby/farmbot-web-app/app/assets/javascripts/application.js.jsx))
    10:     = stylesheet_link_tag "application"
    11:     = csrf_meta_tags
    12:     = javascript_include_tag "//cdnjs.cloudflare.com/ajax/libs/redux/1.0.1/redux.min.js"
    13:     = javascript_include_tag "application"
    14:   %body{'ng-app' => 'FarmBot'}
    15:     .row
    16:       %nav.drop-shadow{ng_app: 'farmbot', ng_controller: 'nav'}

Hey @yuvilio, thanks for getting involved! I don't write any of the software myself except for some occasional CSS stuff so I can't help too much. But I do know that the npm stuff was added just last week as our main developer @RickCarlino gets stuff setup for the farm designer.

@yuvilio Welcome! Thanks for the help. So here's what's going on at the moment:
For the past 2 years, I've been the only dev on this particular project, which has gotten me into a bad habit of leaving master unstable. Here's what happened this week, and why things are in a somewhat half finished state:

Started adding React components to the Farm Designer, which was previously just a static HTML mockup.
hit some big issues with rails-assets, a bower component wrapper for Rails apps.
Discovered that ReduxJS does not officially support Bower, which we have used for js asset management up until this point.
decided to try NPM as an asset packager instead.
Pulled the farm designer JS files out of the Rails asset pipeline and into a [possibly] temporary /javascripts folder that uses Gulp + NPM.

This week saw several sweeping changes (and admittedly, I didn't realize @roryaronson was going to send out the call for help email this weekend). As a result, things are in a somewhat half finished state over the weekend. Bear with me as I work towards a more stable master branch in the coming days and thanks again for the help!

No worries @RickCarlino.  I found you guys through google searches. I'm dipping in React/Redux as well. They sound like great choices for the interactive UI end.  Have you considered webpack as an approach? Not sure if that's too far an adjustment from your current setup.

@yuvilio I've considered it. What kind of cool stuff can WebPack do vs. Browserify? I really hadn't put much thought into the module bundler for the app, to be honest. Prior to this, we were just using the asset pipeline (which is problematic now that everyone is using NPM instead of Bower.
If you think WebPack will be a win for the project and can maintain backwards compatibility with the codebase, sure, let's try it out.


Print library in error message during ref conflict

User needs to know repo/name, simple repo is not enough

/packit test

/packit test

/packit test

Merged as part of #545.


Refined create_vm method in Softlayer VM package

In this PR, the create_vm action had been refined, moved common methods, such like CreateVirtualGuestTemplate, CreateAgentMetadata, CreateDisksSpec, AppendPowerDNSToNetworks, Base64EncodeData, TimeStampForTime into vm_utils.go in softlayer vm package.

One minor comment @jianqiu, please address soon so I can merge.
Looking good.

@maximilien  A new unit tests for network.go had been created, please review the code again, thanks!

@maximilien  A new test network_test.go is covering test cases for all the public methods in network.go

Cool. Merging. Cheers :beers:


Add save feature

Add save feature to merge addon.

Thanks for this solution! It may be worth adding it to the master branch for users who install the extension directly from Brackets.

Add on line 158 of main.js:
MainViewManager.setActivePaneId(panes[0])
var document = DocumentManager.getCurrentDocument()
document.setText(compareView.editor().getValue())

Done, to no affect.
Is the intended use of this extension to only be a read-only comparison?

I do have the same issue, I can compare, copy the changes to the file (left) but then when turning off compare changes are not saved.


Add various themes options which make it more interactive like instead of just x&O we can use various emoji options themes

Add me as a contributor

Add me as a contributor

please go ahead , remember changer must be in new branch

I really like your app and want to work on your project ,please assign this issue to me under gssoc-ext 2024


rate/amount limit of the unoffical api

Thank you for creating this wrap of unoffical API!
I was using the API to generate summaries of text in batch, do you know what the rate/amount limit is? My access seems blocked after hundreds of requests at a very low rate (<10 RPM), thanks!

Based on Notion's FAQ, it is not clear how much usage is allowed.
However, it seems that if you use it more than 30 times a day, it will respond slower.


[SD-333] - added missing computed import to popup component

…component

Issue:
What I did

How to test

Checklist

For all PR's

[ ] I've added relevant changes to the project Readme if needed
[ ] I've updated the documentation site as needed
[ ] I have added tests to cover my changes (if not applicable, please state why in a comment)

For new UI components only

[ ] I have added a storybook story covering all variants
[ ] I have checked a11y tab in storybook passes
[ ] I have added cypress component tests (if the component is interactive)
[ ] Any events are emitted on the event bus using emitRplEvent

No longer needed


Converter for LogicalNot operation

Converter for LogicalNot operation is using the same base class (ConvertUnaryImpl) as other Unary operations.
The special converter for Rsqrt was removed and now for this operation regular Unary Op converter is used.
New templated class implemented for testing ConvertUnary, ConvertBooleanUnary, ConvertActivation.
A new check and corresponding subtests were added to Validate: at least 1 dimension is required for input of any Unary and UnaryBoolean operation. (Similar subtest for ConvertActivation operations is blocked and after refactoring of ConvertActivation it will be activated)

Replacement for PR#55428

still seeing the same error:
In file included from third_party/tensorflow/compiler/tf2tensorrt/convert/convert_nodes_test.cc:16:
In file included from ./third_party/tensorflow/compiler/tf2tensorrt/convert/convert_nodes.h:26:
In file included from ./third_party/tensorflow/compiler/tf2tensorrt/convert/op_converter.h:25:
In file included from ./third_party/tensorflow/compiler/tf2tensorrt/convert/weights.h:22:
./third_party/tensorflow/compiler/tf2tensorrt/convert/utils.h:98:30: error: no matching function for call to 'DebugString'
StrAppend(&tmp_s, StrCat(DebugString(el), ", "));
^~~~~~~~~~~
third_party/tensorflow/compiler/tf2tensorrt/convert/convert_nodes_test.cc:1706:58: note: in instantiation of function template specialization 'tensorflow::tensorrt::DebugString' requested here
<< ", Received Input Tensor: " << DebugString(values);
^
third_party/tensorflow/compiler/tf2tensorrt/convert/convert_nodes_test.cc:1888:7: note: in instantiation of function template specialization 'tensorflow::tensorrt::convert::ParameterizedOpConverterTestBase::AddTestTensor' requested here
AddTestTensor("input", p.input_dims, input_tf_type, input_values);
^
third_party/tensorflow/compiler/tf2tensorrt/convert/convert_nodes_test.cc:7057:3: note: in instantiation of function template specialization 'tensorflow::tensorrt::convert::OpConverter_UnaryTest::RunTestsnvinfer1::UnaryOperation' requested here
RunTests("LogicalUnary", ops_to_test, *UnaryBooleanOperationMap(), op_map,
^
./third_party/tensorflow/compiler/tf2tensorrt/convert/trt_parameters.h:46:8: note: candidate function not viable: no known conversion from 'const std::__bit_iterator<std::vector, true, 0>::reference' (aka 'const std::__bit_const_reference<std::vector>') to 'const tensorflow::tensorrt::TrtPrecisionMode' for 1st argument
string DebugString(const TrtPrecisionMode mode);
^
./third_party/tensorflow/compiler/tf2tensorrt/convert/utils.h:95:8: note: candidate template ignored: could not match 'vector' against '__bit_const_reference'
string DebugString(const std::vector& vector) {
^
./third_party/tensorflow/compiler/tf2tensorrt/convert/utils.h:86:8: note: candidate template ignored: requirement 'std::is_arithmetic<std::__bit_const_reference<std::vector<bool, std::allocator>>>::value' was not satisfied [with CType = std::__bit_const_reference<std::vector>]
string DebugString(const CType& el) {
^
1 error generated.

@bixia1 : It looks like bool's are represented differently by the compilers we are using. After replacement bool by int the compilation should be fine.

I am fine with change bool in the test or having another print method.

 It looks like DT_BOOL is not fully supported for TRT < 8.2. I will add
#if IS_TRT_VERSION_GE(8, 2, 0, 0)

@bixia1 : Could you, please try with the latest changes?


ACME renewal logic is wrong

I received an alert from LetsEncrypt one of the servers that's running ACME issued through BonsiaDb hasn't renewed its certificate. Last night, I ssh'ed in and updated the server and rebooted it, figuring that would trigger the renewal logic for sure.
This morning, I noticed it still hadn't updated. I tracked it down to the use of a helper function from the acme library. I assumed it did something a little different than what it does -- it returns half the duration remaining on the certificate.
The way the loop is currently written, the err_cnt parameter is never incremented, which means this function will always return half the remaining time on the certificate -- not the duration until the halfway point of the certificate's lifetime. That's where my misunderstanding came from.
We should move the renewal logic from being completely stateless to tracking the next renewal timestamp on the TlsCertificate entity. We should keep track of the renewal attempts as well, to help with debugging certificate issuance problems.

On second thought, the scheduling of this could be a good job service (#78) function. Regardless, the logic should be fixed in the loop to make sure we actually try renewing starting 2 weeks out.


React 16

related to https://github.com/surveyjs/surveyjs/issues/718
need to support the latest react 16 version
https://reactjs.org/blog/2017/09/26/react-v16.0.html#breaking-changes
from @mikecousins  ( https://github.com/surveyjs/surveyjs/issues/703 ):

We still get some warnings when we install packages:
warning<EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>warning<EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>Maybe the dependency in package.json needs to be updated?

Input fields cannot be filled out with React 16. They do not update.

Hello Enric, sorry for the late response, I can't reproduced the issue. I created an example with inputs and React16 and it looks ok. https://plnkr.co/edit/g7b506tzx7rf8jyqCoh9?p=preview. Could you please check it?

Had a chance to look into it, and it seems that the issue is with Found router, and React 16 and not with surveyjs. Thank you for looking into it. We will have to deal with replacing our router... again. :(

Sorry guys, but I am still having an issue but only with surveyjs fields. I cannot edit them. I thought it was found-router but I replaced that with react-router. Then I thought it was css_modules, so I removed that.
So now with react-router, react 16, and surveyjs fields are not editable. Other non-surveyjs fields are editable and work fine. So there is some issue with react-router, react 16 and surveyjs

@enricribas it would be great if you will create a small example with css modules, react 16 and surveyjs. I haven't work with css modules yet.

@enricribas We use react v16 now.
Thank you,
Andrew


Sync Not Working

Describe the bug
When using the latest beta version, there's an issue with the sync feature. When I create and push a snapshot, no one else in my org can see it.
To Reproduce
Steps to reproduce the behavior:

Click on master in the lower left hand corner
Notice that the Pull and Push snapshots options is greyed out
I can see the changes locally, but no one else can

Expected behavior
Every one in the org should be able to see the changes
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: MacOS 10.15.7
Installation Method: dmg
App Version: 2020.5.2

Hi @scooter3,
Please send an email to<EMAIL_ADDRESS>and we'll be able to help you troubleshoot this further.


z-index?

Hello, I'm coding using the ReactJS library.
I've created small components that can be used anywhere, and upon clicking one it would open a modal on top of everything for data display, edit, delete, etc. For that I have created a modal component that is fixed and have a high z-index to be displayed above everything.
My issue occurred when I started using simplebar (to get the same scrollbars across browsers), there's a div in the SimpleBar component that has a z-index of 0, and my small components being all the way to the bottom are restricted by that z-index, which means the modal component they use as well. Is there a way to remove this z-index or would it break everything?
EDIT: I overrode the simplebar-mask class z-index with a z-index: auto, it didn't break anything and my modals are now working correctly. I'm not really sure what was this z-index here for

Can't answer your question about z-index: 0 but here's how I do modal without having to change core CSS:

 {/* this has z-index: 1; */}
  <Scrollbar>

 {/* "dark background" - height: auto; min-height: 100vh; */}
       <ModalWindow /> {/* actual modal window and content, centered with flex CSS on "background" */}

  </Scrollbar>

Oh so you're basically wrapping the simplebar in a higher z-index so that it becomes the new z-index limit for the childs ...
I'm not particularly fond of making a div just for that but I suppose that works, I'll probably just keep my z-index auto overwrite method as long as nothing break, this feels more clean

How are you positioning modal then? position: fixed; directly on scroll root? That's the main reason for my div.

SimpleBar is using absolutely positionned elements so it creates a new stacking context. I think @gitcatrat solution is great!

Hmmm I see, I suppose I could do it then. Thanks for the advice


Uploading FIles with the File Manager shows wrong uploading green bar

I want to report a bug with uploading green bar at the bottom of the page

When you upload something it will always fill the greenbar fastly even thought it is not uploaded completely yet so you have to keep waiting even thought the bar already filled

Ok so this isn't fixed...
Can you see if there are any browser console errors that show up, and what OS and Browser are you using?

Duplicate of #231 report in that for me.

Sorry didn't saw it, will close this and comment there


Fix: Text overlow on score cell when penalties

Change the "shared" styles. The other lines were changed by prettier.
Mobile:

Before:

After:

Desktop:

Before:

After:

Genial! 👍


NullAway complaining about returning null for a return type of CompletableFuture

// The purpose of this method is to run some heavy code of publish data on a separate thread pool
// as that is blocking code. Whereas once published switch back to application thread pool.
// The response needs to be a CompletableFuture<Void>  that informs if publish has successfully
// happened.
  @SuppressWarnings("NullAway")
  public CompletableFuture<Void> produceAsync(
      @Nonnull Parameter1, @Nonnull Parameter2) {

    return CompletableFuture.supplyAsync(
            () -> {
              // Some method that will publish data, also might throw an error as RuntimeException
              return null;
            },
            someExecutorService)
        // If an exception occurs or not we move the flow to application thread pool.
        .handleAsync(
            (ignored, throwable) -> {
              if (throwable != null) {
                if (throwable instanceof RuntimeException) {
                  throw (RuntimeException) throwable;
                }

                throw new RuntimeException(throwable);
              }
              // In case there was no exception return null.
              // NullAway is complaining we are returning null. Hence using suppress warning annotation.
              // The null is converted to CompletableFuture<Object> and then to CompletbaleFuture<Void>.
              return null;
            },
            applicationExecutorService)
        // Convert to Void completable future. whenCompleteAsync returns Object completable future.
        .thenRun(() -> {});
  }
}

Linter complaining about null when contract of method is @Nonnull. However, the null is converted from CompletableFuture -> CompletableFuture
We might need to fix the edge case for the linter. In general I think, NullAway for the special case of T is unable to handle it.

Sorry, I can't understand what error you are seeing.  Can you point out the exact location where the error is reported and what the error message is?  And also can you fix the formatting of your example code?  Thanks!

I also run into this issue, it seems that the Void return objective used with Generics is not detected correctly in every case. I wrote a  simple example code showing the issue:
package org.betonquest.betonquest;

public class Test {

    public TestInterface<Void> getTest() {
        return () -> {
            return null;
        };
    }

    @FunctionalInterface
    interface TestInterface<T> {
        T test();
    }
}

NullAway reports:
[7,13] [NullAway] returning @Nullable expression from method with @NonNull return type

Thanks for the repro case, @Wolf2323, I see this behavior as well.  Unfortunately fixing this issue will require better support for generics / JSpecify; I don't we can easily fix it otherwise.  I added a test case in #990 that shows how this code can be type checked in JSpecify mode.  This mode is still a work in progress and not ready for production I think, but you are free to try it on your code base by adding the option -XepOpt:NullAway:JSpecifyMode=true to see how it does.
Note that in JSpecify mode you need to write @Nullable Void to allow for null values; see https://github.com/jspecify/jspecify/issues/51 for discussion.
I'll leave this issue open so I can comment back once we think JSpecify mode is ready for broader testing, at which point we can close it.

sounds good in general. We use jetbrains annotations, when i understand correctly @Nullable Void is from jspecify and i will currently not add this to the project, so i can not test this out


Why are a large number of connections disconnected every hour

Describe what you would like to know or do
The maximum number of connections is 640. If it exceeds 640, a large number of connections will be disconnected
Describe the solution you'd considered
When I increase the number of threads to 50, I still have this problem. It is deployed on an independent server without any other services
how to solve this， plz

The server closes the log and prompts 1006 code. The nginx log shows upstream time out (110: unknown error) while connecting to upstream ，we have no through cloudflare

No clear information.
Closing issue


number of samples is less than 98K

Hi,
I have converted the jason data from the drive to csv, number of samples in dev,test,train totally is  ~10k but in the main article it has reported that eqasc has ~98k samples. What can I do to have all the samples?

There are ~10K questions, each with about ~10 chains, leading to a total of around ~98K annotated chains


[Website] Action.Execute doesn't enable to use in designer of Adaptive Cards

In doc described not deprecated action "Action.Execute", but when I try to use it in Adaptive Cards Designer but it doesn't render whichever host app I choose. Does it a bug or "Action.Execute" now is deprecated action?

URL: https://adaptivecards.io/explorer/Action.Execute.html

The designer defaults to version 1.3 which does not support Action.Execture. If you change the target version (upper right corner) to 1.4 this should work for you. Please reactivate if you run into any issues.


[17.12] update vndr of swarmkit to a7680ec

brings in this change:

https://github.com/docker/swarmkit/pull/2513 [17.12] Fix IP overlap with empty EndpointSpec

comparison of changes on the engine: https://github.com/docker/swarmkit/compare/7598f7a...a7680ecc
comparison of changes on the cli: https://github.com/docker/swarmkit/compare/de950a7...a7680ecc

the changes to protobuf are just a weird import path changing thing. not sure how they got introduced, but they're part of a higher-level repository so vendoring that package isn't a concern, and if this builds fine then it works.

Not sure what went wrong in the s390x CI;
01:56:34 ----------------------------------------------------------------------
01:56:34 FAIL: docker_cli_swarm_test.go:1539: DockerSwarmSuite.TestSwarmNetworkIPAMOptions
01:56:34
01:56:34 [d8ccc6685ba4c] waiting for daemon to start
01:56:34 [d8ccc6685ba4c] daemon started
01:56:34
01:56:34 docker_cli_swarm_test.go:1549:
01:56:34     c.Assert(strings.TrimSpace(out), checker.Contains, "com.docker.network.ipam.serial:true")
01:56:34 ... obtained string = "map[foo:bar]"
01:56:34 ... substring string = "com.docker.network.ipam.serial:true"
01:56:34
01:56:34 [d8ccc6685ba4c] exiting daemon

Also include https://github.com/docker/swarmkit/pull/2519 in this ? @andrewhsu

what about the failing ce-tests-s390x


Make the logger in example clearer

Which problem is this PR solving?

The log information in the previous example cannot truly show the file and line number of the printed log, which caused a certain degree of trouble for the learning of exmaple.

Short description of the changes

Explicitly increase zap.AddCallerSkip(1), so that the logger can output the actual print log files and lines.

Nice!
Could you please attach the log output to this PR?

Nice!
Could you please attach the log output to this PR?

Previous logger output:
$ ./hotrod all
2020-05-26T11:48:48.316+0800    INFO    cmd/root.go:91  Using expvar as metrics backend
2020-05-26T11:48:48.316+0800    INFO    cmd/all.go:28   Starting all services
2020-05-26T11:48:48.431+0800    INFO    log/logger.go:38        Starting        {"service": "route", "address": "http://<IP_ADDRESS>:8083"}
2020-05-26T11:48:48.431+0800    INFO    log/logger.go:38        Starting        {"service": "frontend", "address": "http://<IP_ADDRESS>:8080"}
2020-05-26T11:48:48.539+0800    INFO    log/logger.go:38        Starting        {"service": "customer", "address": "http://<IP_ADDRESS>:8081"}
2020-05-26T11:48:48.540+0800    INFO    log/logger.go:38        TChannel listening      {"service": "driver", "hostPort": "[::]:8082"}
2020-05-26T11:48:52.707+0800    INFO    log/spanlogger.go:35    HTTP request received   {"service": "frontend", "method": "GET", "url": "/dispatch?customer=392&nonse=0.6589479032350802"}
2020-05-26T11:48:52.707+0800    INFO    log/spanlogger.go:35    Getting customer        {"service": "frontend", "component": "customer_client", "customer_id": "392"}
http://<IP_ADDRESS>:8081/customer?customer=392
2020-05-26T11:48:52.709+0800    INFO    log/spanlogger.go:35    HTTP request received   {"service": "customer", "method": "GET", "url": "/customer?customer=392"}
2020-05-26T11:48:52.710+0800    INFO    log/spanlogger.go:35    Loading customer        {"service": "customer", "component": "mysql", "customer_id": "392"}

New logger output：
$ ./hotrod all
2020-05-26T11:43:02.305+0800    INFO    cobra@v0.0.3/command.go:792     Using expvar as metrics backend
2020-05-26T11:43:02.306+0800    INFO    cobra@v0.0.3/command.go:762     Starting all services
2020-05-26T11:43:02.415+0800    INFO    frontend/server.go:67   Starting        {"service": "frontend", "address": "http://<IP_ADDRESS>:8080"}
2020-05-26T11:43:02.417+0800    INFO    route/server.go:57      Starting        {"service": "route", "address": "http://<IP_ADDRESS>:8083"}
2020-05-26T11:43:02.519+0800    INFO    customer/server.go:55   Starting        {"service": "customer", "address": "http://<IP_ADDRESS>:8081"}
2020-05-26T11:43:02.520+0800    INFO    driver/server.go:70     TChannel listening      {"service": "driver", "hostPort": "[::]:8082"}
2020-05-26T11:46:38.531+0800    INFO    frontend/server.go:81   HTTP request received   {"service": "frontend", "method": "GET", "url": "/dispatch?customer=392&nonse=0.8836180000485636"}
2020-05-26T11:46:38.531+0800    INFO    customer/client.go:54   Getting customer        {"service": "frontend", "component": "customer_client", "customer_id": "392"}
http://<IP_ADDRESS>:8081/customer?customer=392
2020-05-26T11:46:38.533+0800    INFO    customer/server.go:67   HTTP request received   {"service": "customer", "method": "GET", "url": "/customer?customer=392"}
2020-05-26T11:46:38.533+0800    INFO    customer/database.go:73 Loading customer        {"service": "customer", "component": "mysql", "customer_id": "392"}


[BUG] Action ordering in template multiwoz nlg.py

Describe the bug
Greetings,
It seems like the actions are sorted in reverse order in the function sorted_dialog_act(self, dialog_acts) in nlg.py. On line 103, you have new_action = new_action_group[domain][k] + new_action Wouldn't this put all the actions in reverse order? When I was informing something, name always appeared after everything else which makes me think if my model is wrong. But it seems like the nlg creates this issue...
new_action = new_action + new_action_group[domain][k]maybe?
BTW: May I ask why you choose to use an Ordereddict as the datastructure of actions on line 115?
Thanks

Wouldn't this put all the actions in reverse order?
You're right! fixed it

BTW: May I ask why you choose to use an Ordereddict as the datastructure of actions on line 115?
to keep the same order as the input dialog acts


Usernames enumeration

Hi,
As of now, Authelia's login page respond to failed login attempts with a redish notification stating Authentication failed. Please double check your credentials.: this is good.
On the other hand, the HTTP status code that is sent back to the client differs based on whether authentication failed due to non-existing user (500) or failed pasword (401): an attacker can therefore enumerate valid usenames.
Note: f Authelia is responsible for logging login attempts – cf. issue #116 –, we don't have to rely on Nginx access logs to get this information, and we can then make Authelia stop responding with HTTP error 5xx or 4xx upon failed login. and simply answer wwith HTTP status 200.

By the way, just wondering: are credentials “sanitized” in some way before getting processed?
I have not dug into it; I was just thinking that they are somehow used in an LDAP query: it would be safer to ensure that the so called query does actually what it is meant to.

Unfortunately, they are not sanitized and query injection is a possible attack, I guess. What do you recommend to avoid it? Accepting only few characters?
Thanks,
Clément.

I open a new issue, since it is not related to the one from this thread.

To get back to usernames enumeration (well, input sanitization too), the same applies to the password reset page: an HTTP status 500 is sent back to the client upon submission of a non-existing username. The response that is sent back to the client should be identicial regardless the the usename validity: a small notification saying something like “Your request has been sent. If you don't receive any e-mail, check your SPAM folder and make sure you submitted a valid username.” (well, it's a bit lengthy, but I'm sure you get the idea) and same HTTP status code.

For the username enumeration I had in mind to always return 200 (for all requests sent from frontend) with a JSON containing an error message. Error message would be the same when credentials are wrong or user does not exist. Would that be ok?

As explained in my previous post, the point is to give relevant information to the user but without making the slightest distinction between between failed password / non existing username (login attempt) / existing username (password recovery). Hopefully, this only applies to what is sent back to the client – not to what is logged.

I'm currently reviewing every responses that is sent from Authelia. For authentication and password reset the response will always be 200 (since the service is responding correctly) but there will be an error message in the JSON body and this message will be the same for technical errors (connection problems, bugs) and functional errors (user does not exist, bad authentication). That way, an attacker cannot even tell there is a bug on server side. Less insight from a end user perspective but much more secure.
For unauthorized endpoints the error code will be 401, though.
@n4kre , what do you think of that?

Hello @clems4ever,
For now, I won't have much free time to experiment this, but it sounds indeed very good!

Should be fixed with #140 . Thanks @n4kre .


ValueError: The file 'admin/css/pagedown.css' could not be found with <whitenoise.storage.CompressedManifestStaticFilesStorage

I am getting below error;
emote: -----> Running post-compile hook
remote: ----->Post-compile hook
remote: -----> Running run_collectstatic
remote: -----> Collecting static files
remote:        Traceback (most recent call last):
remote:        ValueError: The file 'admin/css/pagedown.css' could not be found with <whitenoise.storage.CompressedManifestStaticFilesStorage object at 0x7f5e80231710>.
remote:  !     Push rejected, failed to compile Python app.

I added below in base.py file.
STATICFILES_DIRS = (
    base_dir_join('assets'),
    base_dir_join('static'),
    base_dir_join('assets/static'),
    base_dir_join('assets/static2'),
    base_dir_join('apps/wedding/static')
)
STATICFILES_FINDERS = (
    'django.contrib.staticfiles.finders.FileSystemFinder',
    'django.contrib.staticfiles.finders.AppDirectoriesFinder',
    # other finders..
    'compressor.finders.CompressorFinder',
)

Sorry, I am unable to reproduce this issue!

@andersonresende  do you need more info may be settings? or something else?

@taqiofficial I think this problem is on the pagdown lib. Take a look at this issue https://github.com/timmyomahony/django-pagedown/issues/25. Try to open a new issue there.


chore: move orientation and label position to content tab"

Fixes #29428

Summary by CodeRabbit

New Features

Introduced new configuration options for widget orientation and label position, allowing users to customize their widgets to be either horizontal or vertical and to position labels on the left or right.

Refactor

Simplified the property pane configurations by removing unused style configurations, streamlining the setup for users.

Chores

Cleaned up widget configuration code for Checkbox Group, Radio Group, and Switch Group widgets to enhance maintainability and user experience.

/build-deploy-preview

Yes! Definitely for checkbox / radio buttons. For switches convention is a bit less defined, but keeping it same as others helps when building an app, I think.

/build-deploy-preview

@ichik @KelvinOm Change the default of label position as right for all three of them.

@ichik @KelvinOm Changed the default value of label position as right for all three of them. 👍

We have to change this for switch and checkbox as well.

Yes


pgadmin - query tool raises Invalid HTTP error

Trying to launch the pgadmin query tool raises the error:
Bad Request

Invalid HTTP Version 'Invalid HTTP Version: 'on testuser@test1?query_url=&server_type=pg HTTP/1.1''

See also this related SO question on pgadmin in docker.

I haven't seen it before but I can reproduce it with your repo on mybinder:

This issue sounds vaguely similar in that both appear to concern background requests in certain situations https://github.com/jupyterhub/jupyter-server-proxy/issues/95
Have you tried running it locally and checking the jupyter logs? I'd give it a go but I can't get repo2docker to work.

repo2docker not working properly for me atm (docker issue on mac I think); I'll see if I can reproduce it on another machine.


Kernel Lack nftables Support

Hi,
I use nftables as the firewall on my systems, but the appropriate kernel modules seem not to be enabled on the Alpine default selection.
I have also tried the 4.5.7 option and it doesn't appear to be compiled into that either. :)

Hi @Simnol,
Can you retry with the latest bootscript ? 4.5.7 std #1 and enter depmod -a after the reboot.

depmod: can't change directory to 'lib/modules/4.5.7CONFIG_EPOLL-std-1': No such file or directory
Result ^

Amending this, kernel does have nf_tables configured, checking /proc/config.gz, however, it isn't syncing them properly.
Looks like it uses scw-sync-kernel-extras?

Looks like the URL is out of date in your modules sync script, among other issues with it.

Hi @Simnol,
Yes, you are right, we have an issue with this kernel, I fix it with the latest (4.5.7 std #2 (latest)), can you switch your bootscript and retry ?

Hi Quentin,
I can't see std #2 yet, does it take a minute?

Which architecture are you using ?

ARM :)

:/ I have the same issue, for know you can use the kernel arm 4.5.7 std #2 (latest) copy paste the following command.
$ cd /lib/modules
$ wget --no-check-certificate -r --no-parent --reject index.html* --reject robots.txt --no-host-directories --cut-dirs 3  http://mirror.scaleway.com/kernel/4.5.7-std-2/modules/4.5.7-std-2/
$ mv 4.5.7-std-2/ 4.5.7CONFIG_EPOLL-std-2/
$ depmod -a
$ zcat /proc/config.gz | grep NF_TABLES
CONFIG_NF_TABLES=m
CONFIG_NF_TABLES_INET=m
CONFIG_NF_TABLES_NETDEV=m
CONFIG_NF_TABLES_IPV4=m
# CONFIG_NF_TABLES_ARP is not set
CONFIG_NF_TABLES_IPV6=m
CONFIG_NF_TABLES_BRIDGE=m


"Hub clients" can discover Hub but not vice versa

Hi,
So we're attempting to setup a hub toplogy using the new listen_mcast and send_mcast settings.  Our hub clients have listen_mcast set to True and send_mcast set to False.  The hub itself has listen_mcast and send_mcast set to True.
When we run in this type of configuration our clients can see the hub just fine (and not each other which is great!) but unfortunately the hub can't see the clients since the client never sends out anything as part of its heartbeat.  We actually need them to see each other as there is topics and services that must be synchronized between the two.
A simple change that would allow a client to see a hub and vice versa would be to modify the send_heartbeat() to send the master discovery current state to each address in self._address if listen_mcast is True but send_mcast is False:
# New method for sending out current state just to addresses that have been detected
 def _send_current_state2addresses(self):
        try:
            if not self._send_mcast and self._listen_mcast:
                msg = self._create_current_state_msg()
                if msg is not None:
                    for addr in self._address:
                      rospy.logdebug('Send current state to address %s' % addr)
                      self.socket.send2addr(msg, addr)
        except Exception as e:
            rospy.logwarn('Send current state to addresses failed: %s\n' % e)
            self._init_socket()

 def send_heartbeat(self):
      with self.__lock:
            try:
                self._timer_heartbeat.cancel()
            except:
                pass
            invalid_uri = (self.master_monitor.getMasteruri() is None)
            invalid_state = (self.master_monitor.getCurrentState() is None)
            if not (invalid_uri or invalid_state or rospy.is_shutdown() or self.do_finish):
              if self._send_mcast:
                self._send_current_state2group()
             elif self._listen_mcast:
               # So in the case where send_mcast is disabled but not listen_mcast, we allow sending
               # of our state to known addresses (the hubs basically)
               self._send_current_state2addresses()

I'm not sure what you think of this.
Thanks.

Hi,
you are right, there is a bug. But the new fix leads also to a deadlock. I will try to fix it.
regards

Hi,
I fixed this issue. Can you try it out, please.
regards

The issue appears to have been fixed based on my initial testing of the latest master branch. Thanks!  I consider this solved.  If possible can we get the master branch tagged or have a merge into indigo-devel so we can start testing the fixes in our larger test bed?

I merged the changed into indigo-devel.

@atiderko  Happy New Year!  This bug is fixed and can be closed.  Would it be possible to get a release?

Happy New Year!
there are some other small bugs in node manager. I will fix it and then create a release.

@deng02: I created a release 0.7.0


Consider adding https://github.com/yt-dlp/yt-dlp

Consider adding https://github.com/yt-dlp/yt-dlp

❯ scoop info main/yt-dlp
Could not find manifest for 'yt-dlp'.

Filed a bug ScoopInstaller/Main/issues/3298.


update mongoose to stable release: 4.0.1 (fix to undefined length bug)

Hey Joe,
Feel free to experiment with / disregard this.  For me, every time I run fsg I have to update mongoose to 4.0.1.  The mongoose version packaged with fsg does say "this is an unstable release (yada yada)" and I always get:
TypeError: Cannot read property 'length' of undefined
    at processResults (/Users/my_name/my_project/node_modules/mongoose/node_modules/mongodb/lib/mongodb/db.js:1581:31)

Hey Pat,
I ran into this problem near the beginning of your senior phase and fixed it by rolling back the mongoose version to 3.8.23. 4.0.1 (as you've included in your PR) works for the length bug but does break the included server tests in a pretty unacceptable way.
I'm assuming your installed version of fsg is outdated. If you update your version of fsg using npm update -g fsg, it should use 3.8.23 which is the version I'm going to stick with for now. Thanks for the PR though!


XFA - Fix font scale factors (bug 1720888)

All the scale factors in for the substitution font were wrong because of different glyph positions between Liberation and the other ones:

regenerate all the factors

Text may have polish chars for example and in this case the glyph widths were wrong:

treat substitution font as a composite one
add a map glyphIndex to unicode for Liberation in order to generate width array for cid font

I always suspected that something was wrong with glyphs widths for substitution font because of scale factors (the rendering always annoyed me) and this patch will fix that, it means a lot of regression on text rendering but overall it's better.
/botio test

/botio makeref


Milestone and task render schedule (range of date) not working correctly

Version

Development Environment
Chrome
Current Behavior
Date of milestone is from 25/11 to 28/11 but it only renders on the end date (28/11). How can I make it show as a range across the 4 days?

const schedules = [
      {
        id: '1',
        calendarId: '0',
        title: 'Sprint Meeting',
        body: 'Sprint meeting',
        category: 'milestone',
        dueDateClass: '',
        start: '2019-11-25T17:31:00+09:00',
        end: '2019-11-28T17:31:00+09:00',
      },
    ];

Expected Behavior
I want milestone to show as this:

This only occurs when the category is 'time/allday' but not 'milestone/task'

@elenacyl I publish v1.12.8. Please check it out.


How to modify elastalert Server port ??

When I excute  "python elastalert/elastalert.py --verbose" command , have "INFO:elastalert:Found no values for ip_address"
at server is no open 3030 port, so my kibana web UI  have error log "connect ECONNREFUSED <IP_ADDRESS>:3030"
elastalert server config:
rules_folder: example_rules
run_every:
minutes: 1
buffer_time:
minutes: 15
es_host: <IP_ADDRESS>
es_port: 9200
writeback_index: elastalert_status
alert_time_limit:
days: 2

How can i do ??
kibana version 6.3.2
ElastAlert Kibana Plugin version 1.0.1

The official Elastalert doesn't run any server process to which the Kibana plugin can connect. So, there is no config to modify any port, because it simply doesn't run a server. However, the folks at Bitsensor have developed their own fork of Elastalert that runs a server (running on port 3030) that exposes REST API's for manipulating rules and alerts and for that they have developed a Kibana Plugin which you are using. So, to use the Kibana plugin you should use their fork.
Relevant Links:
Bitsensor Elastalert
Kibana Plugin for Bitsensor Elastalert


[UT] stop the Daemon correctly

Why I'm doing:

The isStop and isStart state are not set correctly when starting and stopping, which would affect the UT

What I'm doing:
Fixes #issue
What type of PR is this:

[ ] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[x] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

[ ] This is a backport pr

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.2
[x] 3.1
[ ] 3.0
[ ] 2.5

@Mergifyio backport branch-3.2 branch-3.1


Add github action to run e2e command "on-demand"

Signed-off-by: jorturfer<EMAIL_ADDRESS>We have been discussing how to run e2e test in PRs before merge them when anyone with writing permissions requests it.
There are several options to achieve this behavior, in this PR I propose to use several actions in a row to allow it.
When someone with writing permissions comment the PR with the message /e2e, automatically this action will be executed reacting the comment with 🚀  to refer that the pipeline is in process, and also with 👍 / 👎  to notify if the e2e tests have passed or not.
Also, the trigger supports setting the e2e test discovery regex using if you want, using this format /e2e REGEX, ex:

/e2e *.test.ts
/e2e cron*

Note: To use this feature, we should build and push this image ghcr.io/kedacore/build-tools:main because a few extra packages are needed like up-to-dated git, or hub pr
Note2: Because of this, a PAT with delete permissions in the packages should be added also in order to be able to drop the e2e-test-tag from ghcr. GITHUB_TOKEN is not enough. The expected secret name is GHCR_AUTH_PAT
Achievements:

[x] Execute e2e test on demand using a command
[x] Allow providing the regex to select a subset of the tests
[x] Execute the process to ensure that it works

Checklist

[x] Commits are signed with Developer Certificate of Origin (DCO - learn more)
[x] Tests have been added
[x] A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
[x] A PR is opened to update the documentation on (repo) (if applicable)
[x] Changelog has been updated

Fixes https://github.com/kedacore/keda/discussions/2224

e2e

Looking great so far, minor nit, I'd change the trigger command e2e -> /e2e, so we avoid unintentional execution :)

I think that I'm near of the solution :)
https://github.com/JorTurFer/keda2/pull/8#issuecomment-960047587
https://github.com/JorTurFer/keda2/runs/4098101471?check_suite_focus=true

Another sample is this other PR
The first comment (/e2e cron*) passed the tests and has 👍
The second comment (/e2e) didn't pass the tests and has 👎

Finally caught up on the idea and it's great 👍
I'd suggest renaming the command to /run e2e-tests though to be open and feel more natural, it's just a suggestion.

We should also have a follow-up item to refactor our actions and reduce the duplication by using reusable workflows: https://docs.github.com/en/actions/learn-github-actions/reusing-workflows

Finally caught up on the idea and it's great 👍
I'd suggest renaming the command to /run e2e-tests though to be open and feel more natural, it's just a suggestion.

Honestly, I'd like to have the command shorter than possible to reduce the possibility of errors. But maybe we can rename to /test. WDYT?

I think that now all the goals are achieved:
The PR
The comment (/e2e cron*) passed the tests and has 🚀 👍
The  comment (/e2e azure-blob*) didn't pass the tests and has 🚀 👎
The images used during the process are deleted after the e2e tests have finished.
'm going to update this PR with the latest changes from my working repository and I think that all is done except the setup of the final "triggering comment".
Please, take a look at the PR description, I updated it to add 2 important notes related with the requirements to do this usable

@JorTurFer excellent!
ad Note1: the image will be automatically build once we merge this PR
ad Note2: @tomkerkhove might help?

agree on making the command short, /e2e is fine for me or /run-e2e too.

@zroubalik @tomkerkhove PTAL.
I think that I haven't forgotten any change and all should work with this PR. Finally, I keep /e2e as a trigger, it's short and it's clear. Let me know if you agree or not, we can change for another easily (the requirement is only 1 word command to don't break the regex extraction).
We will need to create a PAT with delete permission in packages and add it in this secret GHCR_AUTH_PAT.
Apart from that, 🤞

agree on making the command short, /e2e is fine for me or /run-e2e too.

Let's do /run-e2e then if that's ok for everyone and not too much work?

Note2: Because of this, a PAT with delete permissions in the packages should be added also in order to be able to drop the e2e-test-tag from ghcr. GITHUB_TOKEN is not enough. The expected secret name is GHCR_AUTH_PAT

I don't want to be a maniac but deleting images is dangerous - If we mess up or get abused, we can be deleting all our "production" images.
We also have the kedacore-sandbox org, what if we push the test images to that one? Would that be OK if I create a PAT for that org? I'm happy to create kedacore-testing if you prefer that instead.

Note2: Because of this, a PAT with delete permissions in the packages should be added also in order to be able to drop the e2e-test-tag from ghcr. GITHUB_TOKEN is not enough. The expected secret name is GHCR_AUTH_PAT

I don't want to be a maniac but deleting images is dangerous - If we mess up or get abused, we can be deleting all our "production" images.
We also have the kedacore-sandbox org, what if we push the test images to that one? Would that be OK if I create a PAT for that org? I'm happy to create kedacore-testing if you prefer that instead.

I think that it's not a real problem, Github has their own deletion policies an it's so much "protector":

30 days for restore the packages
The package version is protected if it has more than 5k downloads
The package is protected if any versión has mora than 5k downloads.

But if you still thinking that it's a risk, we can use other package.

agree on making the command short, /e2e is fine for me or /run-e2e too.

Let's do /run-e2e then if that's ok for everyone and not too much work?

Sure! SGTM :)

Note2: Because of this, a PAT with delete permissions in the packages should be added also in order to be able to drop the e2e-test-tag from ghcr. GITHUB_TOKEN is not enough. The expected secret name is GHCR_AUTH_PAT

I don't want to be a maniac but deleting images is dangerous - If we mess up or get abused, we can be deleting all our "production" images.
We also have the kedacore-sandbox org, what if we push the test images to that one? Would that be OK if I create a PAT for that org? I'm happy to create kedacore-testing if you prefer that
* The package is protected if any version has more than 5k downloads.

Wouldn't this cause problems? Other versions have definitely more the 5k downloads.
We could made create a special images for this. With -test suffix?
Something like:
CONTROLLER_NAME ?= keda
METRICS_SERVER_NAME ?= keda-metrics-apiserver

IMAGE_CONTROLLER = $(IMAGE_REGISTRY)/$(IMAGE_REPO)/$(CONTROLLER_NAME):$(VERSION)
IMAGE_ADAPTER    = $(IMAGE_REGISTRY)/$(IMAGE_REPO)/$(METRICS_SERVER_NAME):$(VERSION)

I'm just afraid of having flaws in our automation but if I'm the only one then that's fine for me.

Note2: Because of this, a PAT with delete permissions in the packages should be added also in order to be able to drop the e2e-test-tag from ghcr. GITHUB_TOKEN is not enough. The expected secret name is GHCR_AUTH_PAT

I don't want to be a maniac but deleting images is dangerous - If we mess up or get abused, we can be deleting all our "production" images.
We also have the kedacore-sandbox org, what if we push the test images to that one? Would that be OK if I create a PAT for that org? I'm happy to create kedacore-testing if you prefer that

The package is protected if any version has more than 5k downloads.

Wouldn't this cause problems? Other versions have definitely more the 5k downloads.
We could made create a special images for this. With -test suffix? Something like:
CONTROLLER_NAME ?= keda
METRICS_SERVER_NAME ?= keda-metrics-apiserver

IMAGE_CONTROLLER = $(IMAGE_REGISTRY)/$(IMAGE_REPO)/$(CONTROLLER_NAME):$(VERSION)
IMAGE_ADAPTER    = $(IMAGE_REGISTRY)/$(IMAGE_REPO)/$(METRICS_SERVER_NAME):$(VERSION)

do you mean if we would have problems deleting pr- tags because other tags have more than 5k?
If this is the question, I think that we will not have the problem because (at least this is that I understand) you can't delete the package (totally) if there is any version (tag) with more than 5K downloads but you can delete each version (tag) with less than 5k downloads. Our testing tags will have less than 5 (?) downloads

@tomkerkhove I see your concern and based on the qutation in the comment above, we need to use different images anyway.

@JorTurFer so it doens't make that if any tag has > 5k download the whole package (thus all the other tags) are protected?

Let's make it very explicit and use dedicated images to fully isolate - Better safe than sorry.

@JorTurFer so it doens't mean that if any tag has > 5k downloads, the whole package (thus all the other tags) is protected?

I don't understand that. I understand that the package itself it's protected but not all the versions. You could delete one version or whole package.
We can do a test easily, you could create a tag manually and try to delete it

Let's make it very explicit and use dedicated images to fully isolate - Better safe than sorry.

💯

do you want to use other organization or only other package?
I could do something like this:
# If E2E_IMAGE_TAG is defined, we are on pr e2e test and we have to use the new tag and append -test to the repository
ifneq '${E2E_IMAGE_TAG}' ''
VERSION = main
SUFFIX = ''
endif

ifeq '${E2E_IMAGE_TAG}' ''
VERSION = ${E2E_IMAGE_TAG}
SUFFIX = '-test'
endif

IMAGE_REGISTRY ?= ghcr.io
IMAGE_REPO     ?= kedacore

IMAGE_CONTROLLER = $(IMAGE_REGISTRY)/$(IMAGE_REPO)/keda$(SUFFIX):$(VERSION)
IMAGE_ADAPTER    = $(IMAGE_REGISTRY)/$(IMAGE_REPO)/keda-metrics-apiserver$(SUFFIX):$(VERSION)

This change will append -test to the package name if we set E2E_IMAGE_TAG.
In this second case, we have to create at least 1 tag manual because it's not possible to keep the repository without any version (tag), you will get an error if you try it saying that you should delete the whole package. We can create an empty image manually and push to only to have one tag always.
WDYT?

@JorTurFer yeah, that would be probably the best approach.

I'll try it and I hope this afternoon the PR will be ready :)
Testing this changes is a bit tedious because I have to adapt them in other organization xD

@JorTurFer no worries, if you change the target images we can merge this PR and do the testing direclty in here.

@zroubalik FYI

could you create the *-test packages with one dummy tag? Have I got enough permissions to do that?

@tomkerkhove could you please help here, I am afk

could you create the *-test packages with one dummy tag? Have I got enough permissions to do that?

Why is that? Can't you just push them?

In this second case, we have to create at least 1 tag manual because it's not possible to keep the repository without any version (tag), you will get an error if you try it saying that you should delete the whole package. We can create an empty image manually and push to only to have one tag always.

Yes, but we can't delete a tag if it's the only tag that keep there, so I think that could be better if we create a dummy tag in order to be able to delete others

Frankly, if it's a test image we don't have to delete the tags perse which allow us to reduce the scope of the PAT anyway.

Frankly, if it's a test image we don't have to delete the tags perse which allow us to reduce the scope of the PAT anyway.

If we don't want to remove the test images, we don't need the PAT, for pushing proposes it's enough the GITHUB_TOKEN available in the runner

Yes, that was what I was suggesting indeed - This feels better.

For me it's totally enough. If it's another package, we could delete them manually from time to time if we want
Do you agree with this @zroubalik ?

For me it's totally enough. If it's another package, we could delete them manually from time to time if we want Do you agree with this @zroubalik (with not delete them during the execution)?

Ack, It's not my storage 😄

I've just deleted the steps of removing both images, I don't have any other change pending

:shipit:

Let's wait until the build-tools image is being built.
This is awesome @JorTurFer!!! I was hoping to have something like this for more than a year :)


Add Finnish translation for README

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: annikaol sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for taking the time to contribute this localization pull request. However, we are not able to accept contributions to this historical reference repository at this time.


Sort methods by name

Sort the method signatures and implementations by method name within the same visibility (public, protected and private) and method type (instance vs. class method) alphabetically.

Hi Marius,
there is already a discussion on this, see #49!
Kind regards,
Jörg-Michael