simp produces a term that doesn't typecheck (Nat.gcdA_zero_right)

Prerequisites

[x] Put an X between the brackets on this line if you have done all of the following:

Checked that your issue isn't already filed.
Reduced the issue to a self-contained, reproducible test case.

May be related to #2021
Description
Steps to Reproduce
/-
Copyright (c) 2018 Guy Leroy. All rights reserved.
Released under Apache 2.0 license as described in the file LICENSE.
Authors: Sangwoo Jo (aka Jason), Guy Leroy, Johannes Hölzl, Mario Carneiro
-/
import Lean.Elab.Tactic.Induction

notation "ℕ" => Nat
notation "ℤ" => Int

namespace Nat

/-- Helper function for the extended GCD algorithm (`Nat.xgcd`). -/
def xgcdAux : ℕ → ℤ → ℤ → ℕ → ℤ → ℤ → ℕ × ℤ × ℤ
  | 0, _, _, r', s', t' => (r', s', t')
  | succ k, s, t, r', s', t' =>
    have : r' % succ k < succ k := mod_lt _ <| (succ_pos _)
    let q := r' / succ k
    xgcdAux (r' % succ k) (s' - q * s) (t' - q * t) (succ k) s t

def xgcd (x y : ℕ) : ℤ × ℤ :=
  (xgcdAux x 1 0 y 0 1).2

def gcdA (x y : ℕ) : ℤ :=
  (xgcd x y).1

theorem xgcdAux_succ : xgcdAux (succ k) s t r' s' t' =
  xgcdAux (r' % succ k) (s' - (r' / succ k) * s) (t' - (r' / succ k) * t) (succ k) s t := rfl

-- Works
theorem gcdA_zero_right {s : ℕ} : gcdA (succ s) 0 = 1 := by
  unfold gcdA xgcd
  rw [xgcdAux_succ]
  rfl

-- Fails
theorem gcdA_zero_right' {s : ℕ} : gcdA (succ s) 0 = 1 := by
  unfold gcdA xgcd
  simp only [xgcdAux_succ]
  rfl

end Nat

Expected behavior: [What you expect to happen]
Proof is accepted
Actual behavior: [What actually happens]
"No goals" in the tactic state, but error
application type mismatch
  id
    (Eq.refl
      (xgcdAux (0 % succ s) (0 - Int.ofNat 0 / Int.ofNat (succ s) * 1) (1 - Int.ofNat 0 / Int.ofNat (succ s) * 0)
            (succ s) 1 0).snd.fst)
argument has type
  (xgcdAux (0 % succ s) (0 - Int.ofNat 0 / Int.ofNat (succ s) * 1) (1 - Int.ofNat 0 / Int.ofNat (succ s) * 0) (succ s) 1
          0).snd.fst =
    (xgcdAux (0 % succ s) (0 - Int.ofNat 0 / Int.ofNat (succ s) * 1) (1 - Int.ofNat 0 / Int.ofNat (succ s) * 0) (succ s)
          1 0).snd.fst
but function has type
  (xgcdAux (succ s) 1 0 0 0 1).snd.fst = 1 → (xgcdAux (succ s) 1 0 0 0 1).snd.fst = 1

Reproduces how often: 100%
Versions
leanprover/lean4:nightly-2023-07-12
Appears to have worked before https://github.com/leanprover-community/mathlib4/pull/1499 (leanprover/lean4:nightly-2023-01-10 → leanprover/lean4:nightly-2023-01-12) which would suggest it was broken in https://github.com/leanprover/lean4/commit/8cd9ce06843c9d42d6d6dc43d3e81e3b49dfc20f.
Additional Information
Any additional information, configuration or data that might be necessary to reproduce the issue.

The problem here comes even before simp:
namespace Nat

def xgcdAux : Nat → Int → Int → Nat → Int → Int → Nat × Int × Int
  | 0, _, _, r', s', t' => (r', s', t')
  | succ k, s, t, r', s', t' =>
    have : r' % succ k < succ k := mod_lt _ <| (succ_pos _)
    let q := r' / succ k
    xgcdAux (r' % succ k) (s' - q * s) (t' - q * t) (succ k) s t

theorem xgcdAux_succ : xgcdAux (succ k) s t r' s' t' =
  xgcdAux (r' % succ k) (s' - (r' / succ k) * s) (t' - (r' / succ k) * t) (succ k) s t := rfl

example (s : Nat) : (xgcdAux (succ k) 1 0 0 0 1) =
    xgcdAux (0 % succ k) (0 - (0 / succ k) * 1) (1 - (0 / succ k) * 0) (succ k) 1 0 :=
  xgcdAux_succ
example (s : Nat) : (xgcdAux (succ k) 1 0 0 0 1) =
    xgcdAux (0 % succ k) (0 - (0 / succ k) * 1) (1 - (0 / succ k) * 0) (succ k) 1 0 :=
  rfl -- fails, despite `xgcdAux_succ` being proved by `rfl`!


Make tests for all of these cases

w/ global variables
w/o global variables

function call is expression

function call is statement

See PR: 98


Add API for getting the instance from the object implementation

@GuillaumeGomez should be good to merge :)

@sdroege Thanks.
👍


BAMOE Canvas installtion fails for 9.1 due to extended service pod crashloopbackoff.

Hi,
We attempted installation of BAMOE 9.1 on EKS (v1.28.12-eks-a18cd3a ). We followed IBM's document. Please find link for the document as follows.

Issue :
After running
 helm install my-bamoe-canvas ./canvas-helm-chart --values ./canvas-helm-chart/values-kubernetes.yaml --set global.kubernetesClusterDomain="<YOUR_KUBERNETES_CLUSTER_DOMAIN>" --set global.kubernetesIngressClass="<YOUR_KUBERNETES_INGRESS_CLASS>"
with updated values from terminal extended-service pods keep failing with error log saying expected integer value.
What is Fix ?
To fix above issue we need pass this environment variable to extended service deployment Key: "EXTENDED_SERVICES_PORT" Value: 21345 Then pods become up and running.
OR
Upgrade Kubernetes to v1.30.3+
Please find GIF with action attached with Issue and Fix.

Hi @skaraleDMS, thanks for reporting the issue!
This is probably related to the pre-populated Environment Variables that Kubernetes generates.
Check these links:

https://github.com/kubernetes/kubernetes/issues/18219
https://docs.docker.com/engine/network/links/#environment-variables
https://github.com/kubernetes/kubernetes/issues/87366
https://github.com/kubernetes/kubernetes/issues/60099#issuecomment-367820278
https://github.com/redis/docker-library-redis/issues/53
https://stackoverflow.com/questions/60736684/kubernetes-exposes-more-environment-variables-than-expected

Our solution would be to explicitly override these environment variables on the Helm Chart or rename the variable so that it is not overwritten.
Upgrading to Kubernetes v1.30.3+ probably works because these environment variables are no longer pre-populated.

Okay, Thanks for the information.


Inconsistency in the subcountry definitions (of France)

There seems to be some inconsistency in the subcountries.yaml definitions of the French subgrid regions.
Specfically, the following nuts regions cannot be found in the nuts3.yaml (or recent shape layer information from https://gisco-services.ec.europa.eu/distribution/v2/nuts/):
Cannot find nuts id FR613
Cannot find nuts id FR627
Cannot find nuts id FR824
Cannot find nuts id FR515
Cannot find nuts id FR246
Cannot find nuts id FR715
Cannot find nuts id FR521
Cannot find nuts id FR252
Cannot find nuts id FR223
If it is not possible to match the definition with current NUTS versions used in the nuts3.yaml definitions (2016/21), it might help to further specify the NUTS version the subregion definition is referring to.
Thanks

Indeed, thank you @philipphaertel for highlighting this error...
This was added by in PR #20. @sandrinecharousset, could you please review the mapping of ehighways2050 regions to NUTS-codes? For reference, the xlsx source file used to generate the NUTS-region classification is available in a separate branch danielhuppmann:attachment/nuts-regions  (see the region/data folder).

@philipphaertel thank you for noticing this
The error came from a bug in the macro converting nuts2013 to nuts 2021 (as ehighway uses the nuts2013 nomenclature and we are using nuts2021....)
I have corrected all subregions for france

Thanks for fixing the definitions, @sandrinecharousset
New definitions work on my end.


Adding option for output as csv

Abandoning this as it turned out to be more complicated than i imagined


livecheck: improve host checks to instead check domains

Fixes an issue where some host checks could be tricked due to the use of host.ends_with?. This is a bug, but it is not a security issue.
Fixes https://github.com/Homebrew/brew/security/code-scanning/1.

Review period skipped due to critical label.


🚧Add total nuget downloads badge

Complete The Item Below

[X] I have updated the title without removing the 🚧 emoji.

Description
Replace all of the badges from the old section with the badges in the new section.
Old Badge Section:

![](https://img.shields.io/github/workflow/status/KinsonDigital/Velaptor/%F0%9F%9A%80Production%20Release?label=Production%20Release%20%F0%9F%9A%80&logo=GitHub&style=flat)
![GitHub Workflow Status](https://img.shields.io/github/workflow/status/kinsondigital/velaptor/%F0%9F%9A%80Preview%20Release?color=%23238636&label=Preview%20Release%20%F0%9F%9A%80&logo=github)
![Nuget (with prereleases)](https://img.shields.io/nuget/vpre/kinsondigital.velaptor?label=Latest%20Release&logo=nuget)

![GitHub Workflow Status](https://img.shields.io/github/workflow/status/kinsondigital/velaptor/%E2%9C%94Unit%20Testing%20Status%20Check?color=%23238636&label=Unit%20Tests)
![](https://img.shields.io/codecov/c/github/KinsonDigital/Velaptor/master?label=Code%20Coverage&logo=CodeCov&style=flat)
![GitHub issues by-label](https://img.shields.io/github/issues/kinsondigital/velaptor/good%20first%20issue?color=%23238636&label=Good%20First%20Issues)

![Discord](https://img.shields.io/discord/481597721199902720?color=%23575CCB&label=discord&logo=discord&logoColor=white)
![Twitter URL](https://img.shields.io/twitter/url?color=%235c5c5c&label=Follow%20%40KDCoder&logo=twitter&url=https%3A%2F%2Ftwitter.com%2FKDCoder)

New Badge Section:

![Production Release Status](https://img.shields.io/github/workflow/status/KinsonDigital/Velaptor/%F0%9F%9A%80Production%20Release?label=Production%20Release%20%F0%9F%9A%80&logo=GitHub&style=flat)
[![Preview Release Status](https://img.shields.io/github/workflow/status/kinsondigital/Velaptor/%F0%9F%9A%80Preview%20Release?color=%23238636&label=Preview%20Release%20%F0%9F%9A%80&logo=github)](https://github.com/KinsonDigital/Velaptor/actions/workflows/preview-release.yml)
[![Latest Nuget Release](https://img.shields.io/nuget/vpre/kinsondigital.Velaptor?label=Latest%20Release&logo=nuget)](https://www.nuget.org/packages/KinsonDigital.Velaptor)
![Nuget](https://img.shields.io/nuget/dt/KinsonDigital.Velaptor?color=0094FF&label=nuget%20downloads&logo=nuget)

![Unit Test Status](https://img.shields.io/github/workflow/status/kinsondigital/Velaptor/%E2%9C%94Unit%20Testing%20Status%20Check?color=%23238636&label=Unit%20Tests)
[![Code Coverage](https://img.shields.io/codecov/c/github/KinsonDigital/Velaptor/master?label=Code%20Coverage&logo=CodeCov&style=flat)](https://app.codecov.io/gh/KinsonDigital/Velaptor)
[![Good First GitHub Issues](https://img.shields.io/github/issues/kinsondigital/Velaptor/good%20first%20issue?color=7057ff&label=Good%20First%20Issues)](https://github.com/KinsonDigital/Velaptor/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22)

[![Discord](https://img.shields.io/discord/481597721199902720?color=%23575CCB&label=discord&logo=discord&logoColor=white)](https://discord.gg/qewu6fNgv7)
[![Twitter URL](https://img.shields.io/twitter/url?color=%235c5c5c&label=Follow%20%40KDCoder&logo=twitter&url=https%3A%2F%2Ftwitter.com%2FKDCoder)](https://twitter.com/KDCoder)

Acceptance Criteria

[ ] Nuget downloads badge added to README

ToDo Items

[X] Change type labels added to this issue.  Refer to the Change Type Labels section below.
[X] Priority label added to this issue.  Refer to the Priority Type Labels section below.
[X] Issue linked to the correct project (if applicable).
[X] Issue linked to the correct milestone (if applicable).
[ ] Draft pull request created and linked to this issue (only required with code changes).

Issue Dependencies
No response
Related Work
No response
Additional Information:
Change Type Labels

Change Type
Label

Bug Fixes
🐛bug

Breaking Changes
🧨breaking changes

New Feature
✨new feature

Workflow Changes
workflow

Code Doc Changes
🗒documentation/code

Product Doc Changes
📝documentation/product

Priority Type Labels

Priority Type
Label

Low Priority
low priority

Medium Priority
medium priority

High Priority
high priority

Code of Conduct

[X] I agree to follow this project's Code of Conduct.

Can you assign me this one?

@CalvinWilkinson kindly remove me from this issue.


Optionally use an image as map instead of rendering terrain

This is useful for custom maps that don't use the terrain scene or to make prettier maps.

This one is ready for review


Feedback

Please put IPFS Weekly feedback in here, unless you think something warrants it's own issue! Thanks!

Best overview / update I've seen in my lists so far @RichardLitt (build up of content maybe; but, very comprehensive. https://github.com/ipfs/pm/issues/76 )
I've been searching for tools for user commit tracking [things similar to: http://code.google.com/p/gource | http://gource.io ]; I think that this is extremely valuable for attribution & users' internal motivations.
Thanks @eminence for tools/get_commits.py
Will the "Active Stuff" be expanded and possibly be looking more at something like 'to come' or Next Focus / Coming Priorities?
Would like to follow more from 32c3 more closely; is there more than the image and "Not (Just) Made in China"; is there more content from this event?
Broken Link:
https://github.com/ipfs/registry-mirror

Yeah, excellent update :) :+1:

Broken Link:
https://github.com/ipfs/registry-mirror

Correct link: https://github.com/diasdavid/registry-mirror
@diasdavid, maybe move that over to ipfs though?

Thanks, @NDuma. I'm not sure if the active stuff will be expanded to "What's to come" - that is a bit harder to estimate, and this is a roundup, not a forecast. The closest thing to that is the weekly sprints, at the moment.
There isn't more content afaik for 32c3, but you could always talk to the people who were there.
Fixed the links. Thanks!

Is the IPFS Weekly available on IPFS?

@windemut of course. it's on the blog. these are all the same and served through ipfs:

/ipns/ipfs.io/blog/  <-- in a local gateway.
https://ipfs.io/ipns/ipfs.io/blog/
https://ipfs.io/blog/

(yes, even the https://ipfs.io/blog/ is served via ipfs :), using the "dnslink" text record)

32c3 Content:
https://media.ccc.de/c/32c3
via tweets on https://github.com/ipfs/archives/issues/52
Add Archive %'s and Completions to Weekly?

Total Data Stored / Available Space -- Compression Metrics etc?

Is it possible to subscribe to the blog? Didn't see any way. Just thinking there's probably a twitter account to follow, but .. which one?

There is an rss feed. The IPFS Twitter account is https://twitter.com/IPFSbot.

Also there is https://tinyletter.com/ipfsweekly/

In January I added all repositories here:
https://www.openhub.net/p/ipfs
and included 1 new one within the last 2 days.
I think the metrics & graphs would be a valuable addition.
Contributors Stats
Project Summary
@PeterDP

That is actually pretty cool!

Really loving the newsletter, thank you for putting it together. :) Not just this week in particular, but every week—one of the few newsletters I look forward to.
One thing I'd love to see in addition: A regular "check in" with important on-going ipfs projects and their status/progress/opportunities to help. Things like ipns, pubsub, etc.

Thanks, @shazow! I really appreciate that.
Check-ins are hard, because we're trying to keep our signal-to-noise ratio optimal, which means not having check ins with all of the dozens (no really, dozens) of projects going on under the IPFS flag. I try to include updates and encourage participation as much as possible, when there is movement on any particular endeavor. If you've got questions about anything, let me know and I can find someone to help you dive in to whichever project you like. :)

For sure, I agree it's not reasonable to cover every ipfs project in every newsletter, but a light sampling of "we haven't talked about ipns in a while, and there's no release yet, but here's how progress is going and the big blockers: ..."

@shazow I'll work on it! Totally hear you. If you have any suggestions for particular projects, let me know in the future and I'll see if I can add something.

Just wanted to point out the newsletter link doesn't work!

@Porco-Rosso Which one? I changed it recently, may not have gotten them all!

https://ipfs.io/blog/16-ipfs-weekly-10/ links to https://tinyletter.com/ipfsweekly which gives a 404 error.
I've also checked week 8 and 9 and they all link to the same url that always gives a 404.

Thanks! I've raised the issue here; for now, use this web address: https://tinyletter.com/ipfsnewsletter. :)

Closing. Reopen as needed.


fix: Declare CodeMirror as external variable

The current var CodeMirror statement is creating a new variable in this file that is never being set. Based on comments, it appears that the original intention is to access the global variable we get from pulling in the CodeMirror library. This updates it to use the syntax for declaring an external variable.

:tada: This PR is included in version 3.1.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[changed] Update overview.md

Tiny swap to bring docs up to date.
Hey, it's something!

Thanks, good catch.


SQL Bindings Readme Instructions

This PR adds context for SQL Bindings readme. Discussed with @dzsquared on the content. But looking for feedback.
Link to markdown preview here.

FYI - you can also just link directly to the .md file on your branch so people can go see the preview themselves and ensures they're always seeing the latest version.
https://github.com/microsoft/azuredatastudio/blob/vabhog/readmeSQLBindings/extensions/sql-bindings/README.md

FYI - you can also just link directly to the .md file on your branch so people can go see the preview themselves and ensures they're always seeing the latest version.
https://github.com/microsoft/azuredatastudio/blob/vabhog/readmeSQLBindings/extensions/sql-bindings/README.md

there's also the rich diff view

Even better!

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 42.053%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
27997

Relevant Lines:
62275

💛  - Coveralls


"Like" particular comments in a chat.

can be nice

We can track this in #176.

#176 is closed, could one of them be opened?


add typechain support

Support the return of typechain types from hre.ignition.deploy(module).
This will likely involve codegen and/or changes in typechain.
Part of #205.

We need to add changes to the types to support typechain. We will send a PR, hopefully it comes in before 0.5.

K


Failed prop type isRequired on Modal

Issue description

components: Modal
reactstrap version #8.0.0
import method npm
react version #16.8.6
bootstrap version #4.0.0

What is happening?
I noticed a warning on the console which was not present previously. It appears immediately when the Modal component is mounted. I can't seem to find the prop listed anywhere on the docs. The modal still works correctly.
Error message in console
Warning: Failed prop type: Cannot read property 'isRequired' of undefined
    in Modal (at CustomModal.js:117)

Code
   <Modal       isOpen={this.props.modal.show}       toggle={this.toggle}>       ...  </Modal>

Looks like an issue with your code --- CustomModal.js line 117.

That's the line where the Modal component is used. I've used it as shown above

Here are the prop types for modal. None of them are .isRequired. Some of them are imported from react-transition-group and react-transition-group does have some required props. Maybe the issue is stemming from react-transition-group's props?
https://github.com/reactstrap/reactstrap/blob/315bb00b31790e2046e2ac9b10e03abf3e35f199/src/Modal.js#L20-L60


RNA004 support

Hi! I saw that you've been working on adding RNA004 support on the dev branch. I was wondering if you think it's already at a state that is functional enough to allow some preliminary testing by users?

Yes! The dev RNA004 implementation is working pretty well. It's possible I'll refine it slightly after testing on modification data, but it already looks better than RNA002 on unmodified RNA. I added a note about it to the README.

This is great! Thanks! I'll try it out over the weekend and may even be able to do some comparisons against Remora.

Hello,
I am trying to use the Uncalled4 dev version for RNA004 data. I am using this command:
uncalled4 align ref.fasta.fai paths foo/pod5_pass/ --bam-in doradobasecalled.bam --bam-out foo.aligned4.bam
The program is able to identify the flowcell etc, however then I get an error:
ValueError: file has no sequences defined (mode='rb') - is it SAM/BAM format? Consider opening with check_sq=False
I checked the bam/sam file (large size, sequences included) and the header is as follows:
@HD     VN:1.6  SO:unknown @PG     ID:basecaller   PN:dorado       VN:0.5.2+7969fab        CL:dorado basecaller -x cpu --emit-moves --emit-sam fast /mnt/data/PV256/pv256/20240110_1119_MC-111221_FAX71856_9d4ea012/pod5_pass @PG     ID:samtools     PN:samtools     PP:basecaller   VN:1.13 CL:samtools view -H PV256_FAST.sam @RG<EMAIL_ADDRESS> PU:FAX71856     PM:MC-111221        DT:2024-01-10T11:20:10.328+00:00        PL:ONT<EMAIL_ADDRESS>runid=49b5d364678660a4f3c96fc45ef24d1dc53321aa  LB:pv256        SM:pv256
Do you have any idea how fix this?
Thank you very much,
Pavel

Does your BAM file contain aligned reads, or are all reads unaligned? It looks like you didn't include a --reference flag for Dorado, which is required to align during basecalling. This exact error was caused by missing @SQ headers, which are only included for aligned BAMs. I realize I wasn't explicit about aligning during basecalling in the README, so I just expanded the "Overview" README section, where you can also find instructions to re-align your reads while preserving "move" tags.

You are right, indeed, I did not use a .sam file aligned to a reference. Now I am using another .sam that had been aligned and the reference during dorado basecalling, and uncalled4 seems to be processing and generating its output .bam file as it should. Great!
Thank you so much also for including it to the documentation!

dsd

ds


Doc about replacement cycling attacks

Hi @t-bast,
I am sure that your pages about lightning are a great learning resource for many lightning devs and enthusiats.
It would be great to see a document in this repo about mempool replacement cycling attacks that everyone got aware of now through this post, maybe in a similar fashion as you describe pinning attacks.
All the best.

Good idea! A detailed post about mempool subtleties and their impact on L2 protocols would be generally useful, I'll do that when I find some time.


Conditional creation of triples

In the current implementation, conditions, which need to be fulfilled such that triples are created, are not covered. This also allows user-defined functions which return Booleans. These conditions are silently ignored and triples are created without the defined restriction.
Several examples are provided in yarrrml-parser's folders test/condition-on-*.
When looking into _translate_yarrrml_to_rml(), only join conditions with parameters 'str1' and 'str2' are considered. This refers to YARRRML Section 9.7. It seems that user-defined functions are not expected to be part of conditions in current implementation, as defined in YARRRML Chapter 11.

I have a case, where I need to implement it , can you please guide me how should implement condition on morph
KeyEventMapping
KeyEventMapping:
    sources:
      - source5
      - source6
    subjects:
      - value: "http://www.example.com/keyEvent/$(@id)"
    predicateobjects:
      - [rdf:type, aop:keyEvent]
      - [dc:title, $(title)]
      - [aop:short-name, $(short-name)]
      - [aop:biological-organization-level, $(biological-organization-level)]
      - [dc:Description, $(description)]
      - [aop:hasRefrences, $(references)]
      - predicates: aop:hasBiologicalObject
        objects:
          - mapping: BiologicalObject
            condition:
              function: equal
              parameters:
                - [str1, $(biological-events/biological-event/@object-id), s]
                - [str2, $(@id), o]
      - predicates: aop:hasBiologicalAction
        objects:
          - mapping: BiologicalAction
            condition:
              function: equal
              parameters:
                - [str1, $(biological-events/biological-event/@action-id), s]
                - [str2, $(@id), o]
      - predicates: aop:hasBiologicalProcess
        objects:
          - mapping: BiologicalProcess
            condition:
              function: equal
              parameters:
                - [str1, $(biological-events/biological-event/@process-id), s]
                - [str2, $(@id), o]
      - predicates: dc:identifier
        objects: $(source6/@aop-wiki-id)  # Corrected reference to source6
        condition:
          function: equal
          parameters:
            - [str1, $(@id)]  # Ensure comparison is based on source6
            - [str2, $(@id)]

Hi @midorna ,
Indeed, conditions as defined in YARRRML Chapter 11 are not covered yet. This behaviour can still be achieved via RML-FNML.
The case of @Crispae has associated issue #275.

Use the example in #275 for testing.

Use the example in #275 for testing.

THX! I will do so.


Too many paths in one query! Currently allowed max deduplicated path number is 28, this query contains 29 deduplicated path.

Since 0.11.0:
This is due to that currently allocated memory for the query is occupied by other query instances, the left memory could only support a query with 28 series.
You could enlarge the memory allocated for read in write_read_schema_free_memory_proportion=4:3:1:2
Or decrease the fetch_size in each query, the default is 10000.
We calculate the memory usage for a query by : number of series in this query * fetch_size

fetch_size controls how many rows are return from the server each time.
For example:
If your SQL is: SELECT S11,S14 FROM root.6.438,root.3.435 WHERE time =<PHONE_NUMBER>000 fill (TEXT[PREVIOUS])
You could set fetch_size to 1.

If you use the session pool, you can't set the fetchSize alone for each query. So you can change the default fetchSize 10000 to 1000 while constructing the session pool.


 The rest are the result of var name changes and a change to the parameters the the itemLink function accepts.
This PR changes the form in the IIIFSearchWithin component to update the item page url with the search query, rather than just holding it in state. This means searching within an item results in a page view, that will be tracked via Segment, with a source of 'search_within_submit':

Other bonuses include:

changing the volume now causes the search to be redone for the volume being viewed. Previously, if a user switched volumes after conducting a search, the old results would remain and the search result links wouldn't work.
clearing the text input now also clears the search results.
people can bookmark/share links with the search query included.

Thanks for updating the source field.


fix: 0.66 introduced great error messages

read more here:
https://medium.com/flow-type/better-flow-error-messages-for-the-javascript-ecosystem-73b6da948ae2

Hi @FezVrasta. Thanks for your contribution. However, even though the errors have improved a lot in 0.66, they are still not as good as those of TypeScript (in my personal opinion). I use most recent Flow and TypeScript in large codebases daily, so these have been my impressions. It would be great to include a more "scientific" analysis, where we compare a set of 10 or 20 similar errors, and ultimately leave it up to the reader to judge what is "better".
Thanks, and I hope you understand my point of view.


Fix appName on post-deployment test

Description
Fixes app-name on post-deployment test as the ClowdJobInvocation was failing due to not finding a ClowdApp named edge.
Type of change
What is it?

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Documentation update
[x] Tests update

Checklist:

[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] I run go fmt ./... to check that my code is properly formatted
[ ] I run go vet ./... to check that my code is free of common Go style mistakes

Codecov Report

Merging #437 (e076880) into main (7c36336) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #437   +/-   ##
=======================================
  Coverage   30.97%   30.97%
=======================================
  Files          31       31
  Lines        3112     3112
=======================================
  Hits          964      964
  Misses       2066     2066
  Partials       82       82

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c36336...e076880. Read the comment docs.

/lgtm


remove io/util for advanced golang

We should clean all io/util package according the url: https://go.dev/doc/go1.16#ioutil
/kind cleanup

https://github.com/submariner-io/submariner/actions/runs/3404610115/jobs/5661968307
the ci test is wrong , but i think is not relevance with the pr..
:blush:


project generated by create-valaxy fail to resolve import<EMAIL_ADDRESS>

procedures
pnpm create valaxy

# use all default set
code valaxy-blog
pnpm i
pnpm dev

@YunYouJun It also don't work in<EMAIL_ADDRESS>It seems that @waline is not installed and I can't find it in node_modules.
demo/yun set it as dev deps and valaxy set it as external in tsup.config.ts, therefore the project generated by create valaxy will fail to work.


Recursively read all files info included in a squashfs filesystem

Hi @CalebQ42,
Thanks for implementing this handy library, it's been a real help for us.
Is there a function to iterate over all included files in the squashfs filesystem recursively to get all included file info?
Thanks!

No, there isn't, but since it implements fs.FS you can use https://pkg.go.dev/io/fs#WalkDir for that functionality.

Let me know if you think there would be a benefit to implementing this in library, but I think for most use cases, fs.WalkDir is good enough.


[Fix #5576] Treat relativity of Include parameters correctly

For configuration files whose name begins with .rubocop, the paths in Include parameters are relative to the directory of the configuration file.
When another configuration file inherits from such a file, we cannot just copy the Include paths. We must modify them so they select the files that were originally intended.

That's one important fix! Thanks!


add python 3.8, remove 3.4

Coverage remained the same at 95.132% when pulling 478e1961bd724b1a7cb15db791db2cf89d20f3c3 on hendrikmuhs:python3.8 into be5955caa6258ed3db1a284f2b7f39f820c5f9c2 on KeyviDev:master.


If a RNN is stateful, it needs to know its batch size. Specify the batch size of your input tensors:

I am using API to build the SimpleRNN network model. Then I ran into a problem, if I use shape in keras.input to determine the input size, I run into this problem

my code is

If I use batch_shape to determine the input size, there is a problem at model.fit

my model.fit is

my new code is

tensorflow2.0.0   kears2.6.0

Hi @sz97z ,
The problem may be due to the argument y passed to model.fit . As per documentation the argument y supports numpy arrays or TF tensors. But dict is being passed to y which might be creating ambiguity.
You can pass both inputs and outputs as tf.data.Dataset object in which case there should not pass anything to argument 'y' in model.fit().
Providing more details or a minimal code snippet can help us to resolve the problem.


Test: creating room reservation event, invoked by submission button click, show on calendar.

thank you adam please don't forget to push you changes... before commencing new ones


[historical] throw error if given a string for period{1,2} that is invalid input for new Date()

Closes #457  .
Changes

Fixes #457
Fixes small typo in CONTRIBUTING.md

Type

[ ] New Module
[ ] Other New Feature
[ ] Validation Fix
[X] Other Bugfix
[X] Docs
[ ] Chore/other

Comments/notes

First time submitting a 'real' pull request with code. I didn't add tests because I'm not familiar with it.
Also, I'm not 100% sure if my change is the best decision for this issue, but I try a few different options and I liked this the most. Please let me know if I can improve this further and if I made something wrong so I can improve next time. Thanks for the amazing project, as always! :)

Hey @glaucoheitor, awesome work!  Thanks for stepping up :raised_hands:  It's really great for maintainers when users are contributing back and this is greatly appreciated :grin:
Yes, I was also thinking of using isNaN, so we're on the same page.  And throwing an error exactly as you have.
I have two minor comments which I'll place inline.  And no problem re the test, I'll do that after we merge and I think it will make a lot of sense to you once you see it :D
Thanks again!

I'm glad to help @gadicc. I really like this project and makes me happy to be able to help just a lil bit. Thanks for the opportunity and your patience.

Awesome, thanks @glaucoheitor!  For sure, and all help is super appreciated, so thanks again!
This will be in the next release.    I'll also tag this PR when I add the test for the new code path.
:tada::pray:

@glaucoheitor, quoting from above commit:
describe("historical", () => {
  // ...

  it("throws if period{1,2} gets an invalid string for new Date()", async () => {
    await expect(yf.historical("TSLA", { period1: "invalid" })).rejects.toThrow(
      /invalid date provided/
    );

    await expect(
      yf.historical("TSLA", { period1: "2022-02-022", period2: "invalid" })
    ).rejects.toThrow(/invalid date provided/);
  });

  //...
});

So, we:

describe a test suite called "historical".
have a test to check if it (historical) "throws if period{1,2} is invalid"
expect the yf.historical() command to reject (since it's a promise) and toThrow (an error), which we can match with a regexp (against the error message)

Hope that helps :)  If you want to familiarize yourself further, you pull in the latest devel (with the tests above), run yarn test --watch src/modules/historical.spec.ts and see what happens when you play with the test a little bit (you could e.g. give a valid string so the command won't throw, which will cause the test (which is expecting it to throw) to fail (because now it's not throwing).  Hope that makes sense!

:tada: This PR is included in version 2.3.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Change literal casting function to return from AstValue to Value,

Add Value::TryFromLiteral to replace cast_ast_value in evaluated.rs.
Now it can handle CAST(1 AS FLOAT).
Test cases in function::cast::cast_literal reach all branches in Value::TryFromLiteral match.
@KyGost You even left a comment about CAST(1 AS FLOAT) issue but I missed to check it.
I just figured out and that was because of... function return value type.
Previous: AstValue -> AstValue
Current: AstValue -> Value
This was possible because CAST provides DataType information.
And I modified cast_literal test cases little bit to reach every branches in match
impl TryFromLiteral for Value {
    fn try_from_literal(data_type: &DataType, literal: &AstValue) -> Result<Value> {
       match ...
    }
}

Order of match branches (try_from_literal) and test cases (function::cast::cast_literal) is same, you will be able to check simply following the code lines.
CAST were too big task so my review was.... not sufficient, sorry for that. Writing test cases to reach every branches would be helpful for you to work on https://github.com/gluesql/gluesql/pull/157
I also found some issues on handling cast_value, I might work for casting value on Sunday, then I'll also share with you. :)

Oh, we've gone back to always converting AstValue to Value I thought we were avoiding this?
I figured we'd be able to fix the float issue with natural conversion.

@KyGost
AstValue -> Value is good and it's right direction because our execute's return data is Vec<Value>.
Value -> AstValue is the thing that we need to avoid, it can make cycle in Evaluated.
Though Evaluated has 5 types, basically you can simplify into two, Literal (AstValue) and Value.

Literal -> Literal or Value
Value -> Value

It's all :)
https://github.com/gluesql/gluesql/blob/d642c75a84267f1a60e4505119ca6fdcde516e1f/src/data/value/mod.rs#L132
pub fn from_data_type(
        data_type: &DataType,
        nullable: bool,
        literal: &AstValue,
    ) -> Result<Self> {

Here, the condition to make Value requires three params, data type, nullable and literal.
It's little bit different from TryFromLiteral because it only takes two, there's no nullable.
However, it is ok for TryFromLiteral not to use nullable.
This is due to...

CAST cannot provide that.
All compare & calculation methods in Value (PartialEq, PartialOrd, add, subtract.. ) supports operation between non-nullable enums and Opt- prefixed nullable enums.

e.g.
Value::I64(100) + Value::OptI64(Some(200)) => Value::OptI64(Some(300))


The expression may only be indexed by a constant

Describe the bug
people talking about  the bug
note: naga moved into main wgpu repo so might be the problem?
To Reproduce
edit the triangle example such that positions is constant.
Observed behavior
Device::create_shader_module error:
Shader validation error:
   ┌─ :23:25
   │
23 │     out.pos = vec4<f32>(positions[in.vertex_index], 0.0, 1.0);
   │                         ^^^^^^^^^^^^^^^^^^^^^^^^^^ naga::Expression [29]

Traceback (most recent call last):
  File "/home/lizelive/Documents/doom/./headless.py", line 163, in <module>
    main(canvas)
  File "/home/lizelive/Documents/doom/./headless.py", line 68, in main
    return _main(canvas, device)
  File "/home/lizelive/Documents/doom/./headless.py", line 79, in _main
    shader = device.create_shader_module(code=shader_source)
  File "/usr/local/lib/python3.10/dist-packages/wgpu/backends/wgpu_native/_api.py", line 1325, in create_shader_module
    id = libf.wgpuDeviceCreateShaderModule(self._internal, struct)
  File "/usr/local/lib/python3.10/dist-packages/wgpu/backends/wgpu_native/_helpers.py", line 322, in proxy_func
    raise wgpu_error  # the frame above is more interesting ↑↑
wgpu._classes.GPUValidationError: Validation Error

Caused by:
    In wgpuDeviceCreateShaderModule

Shader validation error:
   ┌─ :23:25
   │
23 │     out.pos = vec4<f32>(positions[in.vertex_index], 0.0, 1.0);
   │                         ^^^^^^^^^^^^^^^^^^^^^^^^^^ naga::Expression [29]

    Entry point vs_main at Vertex is invalid
    Expression [29] is invalid
    The expression [11] may only be indexed by a constant

Can you share the exact changes you made to the triangle example?
Otherwise it will be pretty difficult for us to help you.

I recognize this. Indeed, if you change var positions = array<vec2<f32>, 3>(...)  to  let positions = array<vec2<f32>, 3>(...), i.e. replace var  with let, then this error is raised. This has been the case since I can remember. I've never viewed this a being a bug, TBH. And if it is, it's a Naga issue; we can't do anything about it here.

As Almar said, please open an issue at the naga repo.


fix virtual package transformation

Pass empty string instead of null to avoid "missing transformation" exception

I just forgot to update the MPS-extensions version.

@slisson can we release a .44 with the new dependency because 43 is broken.

Build for 0.0.44 is running: https://app.travis-ci.com/github/slisson/modelix/builds/238412577


Add feedback repo to open-repositories.txt

Dear @luismompohanden,
In order to potentially merge your code in this open-source repository and therefore proceed with your contribution, we need to have your approval on DFINITY's CLA.
If you decide to agree with it, please visit this issue and read the instructions there. Once you have signed it, re-trigger the workflow on this PR to see if your code can be merged.
— The DFINITY Foundation


nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit

Issue reference: #788
Description:
In cases where CCCDs are exceeding MYNEWT_VAL(BLE_STORE_MAX_CCCDS) (overflow event), we can end up in continuous while loop.
Change list:

In ble_gap_unpair_oldest_peer changed return value from 0 to BLE_HS_ENOENT when there is no entry found.
Modified ble_store_util_status_rr to address overflow event of CCCDs.

Previous to this PR, if CCCDs used to exceed the MAX_CCCDs then in ble_store_write call there used to come OVERFLOW event, which used to call ble_store_delete_oldest_peer, now here as we do not have any peer to be deleted, we should have identified that we need to make space for CCCDs and not peer_sec or our_sec. The PR tries to address this issue.

@h2zero That is a valid point, will update if I find anything. Maybe @rymanluk can explain it to us.


Prevent ClusterQueue with pending workloads to block borrowing in other flavors in the cohort

What would you like to be added:
In #475 and #805, we guaranteed the following:
If a ClusterQueue has pending workloads that could fit in the nominalQuota if other workloads finish (regardless of whether preemption is enabled), we don't admit other workloads in the cohort that can fit by borrowing. This allows the pending workloads to be admitted as soon as the quota becomes available without needing to trigger extra preemptions (or waiting for more jobs to finish, if preemption is disabled).
However, the check is too coarse: if the borrowing is happening in a different flavor, we shouldn't block it.
A possible solution is to track not just which cohorts already had workloads admitted in a cycle, but also which combinations of (flavor, resource).
Current check per cohort:
https://github.com/kubernetes-sigs/kueue/blob/913d53674ec0f535b28e37a3e854b29575eecce0/pkg/scheduler/scheduler.go#L145-L160
Why is this needed:
As users start setting up complex ClusterQueues, with multiple flavors and multiple CQs per cohort, the current check doesn't match user expectations, specially if low priority pending workloads in a ClusterQueue could end up blocking other ClusterQueue.
Completion requirements:
This enhancement requires the following artifacts:

[ ] Design doc
[ ] API change
[ ] Docs update

The artifacts should be linked in subsequent comments.

/assign @trasc


SimpleLauncher behaviour not reflected in slot calculation for scaling

**Describe the bug**
When using localprovider with simpleLauncher() having nodes_per_blocks>1, active_slots is calculated from the user requested nodes_per_block rather than from SimpleLauncher() behaviour.
To Reproduce
Steps to reproduce the behavior, for e.g:
local_htex = Config(
        executors=[
            HighThroughputExecutor(
                label="HTEX",
                heartbeat_period=1,
                heartbeat_threshold=2,
                poll_period=100,
                address="<IP_ADDRESS>",
                max_workers_per_node=1,
                provider=LocalProvider(
                    `init_blocks=3,`
                    nodes_per_block = 5,
                    max_blocks=4,
                    min_blocks=2,
                    launcher=SimpleLauncher()
                ),
            )
        ],
        max_idletime=0.5,
        strategy='simple',
    )

Load this Config in parsl.
Let it run and you will see in logs that the active slots will be 15 not 3.
Expected behavior
As SimpleLauncher only supports single node per block, the active slots (active_blocks times the nodes_per_block times the tasks_per_node) should be 3, (with default tasks_per_node=1) not 15.

Possible fix can be updating the nodes per block after logging the warning, this way the nodes_per_block will be updated to one.


"Contact" in the footer area

When Aoife and my sister were asked to contact us, they had a hard time to find the respective button. Reasons:

Color of the text button to light
Position of the text button not user frienldy

A new solution will be designed asap.

The pages have been created in #96


Installer file count foot print increased by 2000 files

Azure Data Studio Version: Feb release

Steps to Reproduce:

Install Feb release

Actual: number of installed files ~2000 more

@YurongHe this is most likely related to the additional node modules added for unified connection.  Please take a look to confirm that the 2000 new files added to the installer are all required to be included in the bundled build.

@YurongHe Karl mentioned there are ways to minimize the footprint by excluding unused parts of the new dependencies. Can you sync with him and get this resolved?

mssql extension footprint:

Here are the new modules:

I carefully removed the above highlight modules one by one. mssql extension can be loaded only without dashdash and tunnel-agent modules. Not sure if any scenario will be broken by removing them. For some manually testing, ADS seems working.
All the other modules are required for mssql extension. Without them, running time error:
Activating extension 'Microsoft.mssql' failed: Cannot find module 'ajv'.
@kevcunnane, can we rewrite any code by using vs code dependencies, so we can reduce the number of modules?

3 files are in zip.
Folder list from previous - old.txt and new release - new.txt
File count excel in each folders for new release
fileCountsInfo.zip

@YurongHe thanks for investigating.  I think we should wait for the next VS Code source refresh to merge to master then try to enable ASAR on the extension node_modules.  Once that's done we can reassess if this is still relevant.

@anthonydresser please verify we're below the ~8100 file count now.  thanks!

The current packaged build contains ~4400 files, so I'll close this.


chore(api, tests): refactor api tests to centralize file pathing

Description
Addresses a mounting issue with our python tests where we are reconstructing relative file paths and throwing various not found exceptions while reading test data.
BREAKING CHANGES
None
CHANGES
Moves all test data file pathing into one central test util and attempt to replace as many instances as possible
Related Issue
None
Checklist before merging

[X] Tests, documentation, ADR added or updated as needed
[X] Followed the Contributor Guide Steps

Not sure if this is the PR for this, but would you be able to add a section to tests/README.md covering the how/why of the conformance tests? Unless I'm missing something I don't think I see where this info lives.


Crossing inner cells

Discussed in https://github.com/Fields2Cover/Fields2Cover/discussions/130

Originally posted by Donald-MH May  2, 2024
I am trying your library, I found that some directions may cause the path crossing inner cells (or no go zone)
is this issue going to be solved ? or I should modify the code to adapt this problem?
you can try with the following setup
  F2CRobot robot_c (3);

  F2CCells cells_c {
    F2CCell(F2CLinearRing({
          F2CPoint(0,0), F2CPoint(50,0),F2CPoint(50,50),F2CPoint(0,50), F2CPoint(0,0)
    }))
  };
  cells_c.addRing(0, F2CLinearRing({
        F2CPoint(10,10), F2CPoint(10,25),F2CPoint(15,25),F2CPoint(15,10),F2CPoint(10,10)
        }));
  cells_c.addRing(0, F2CLinearRing({
      F2CPoint(20,20), F2CPoint(20,25),F2CPoint(25,25),F2CPoint(25,20),F2CPoint(20,20)
      }));
  f2c::hg::ConstHL const_hl;
  //F2CCells mid_hl_c = const_hl.generateHeadlands(cells_c, 1 * robot_c.getWidth());
  F2CCells no_hl_c = const_hl.generateHeadlands(cells_c, 1.0 * robot_c.getWidth());

  f2c::Visualizer::figure();
  f2c::Visualizer::plot(cells_c);
  f2c::Visualizer::plot(no_hl_c);
  f2c::Visualizer::xlim(-5,65);
  f2c::Visualizer::ylim(-5,65);
  f2c::Visualizer::save("Tutorial_5_0_field.png");

  std::cout << robot_c.getWidth() << std::endl;
  std::cout << robot_c.getCovWidth() << std::endl;

  f2c::sg::BruteForce bf;
  F2CSwathsByCells swaths_c = bf.generateSwaths(M_PI/3.0, 1.5* robot_c.getWidth(), no_hl_c);
  f2c::rp::RoutePlannerBase route_planner;
  F2CRoute route = route_planner.genRoute(no_hl_c, swaths_c);

  f2c::Visualizer::figure();
  f2c::Visualizer::plot(cells_c);
  f2c::Visualizer::plot(no_hl_c);
  f2c::Visualizer::plot(route);
//  f2c::Visualizer::plot(swaths_c);
  f2c::Visualizer::xlim(-5,65);
  f2c::Visualizer::ylim(-5,65);
  f2c::Visualizer::save("Tutorial_5_0_route.png");

Hi @Donald-MH, I cannot see where the no-go zones are being crossed. The route is made to travel through headlands instead of crossing obstacles.
Following the tutorials (https://fields2cover.github.io/source/tutorials/path_planning.html), adding this will give you the final path:
f2c::pp::PathPlanning path_planner;
f2c::pp::DubinsCurves dubins;
F2CPath path = path_planner.planPath(robot_c, route, dubins);

This is the part I mean crossing no go zone
is this means I have to further extend the robot width ?

The problem is actually a rather small field. The path doesn't check if it crosses the borders in this version. If someone wants to improve it, we are open for PR.


When clicking over a card, I guess that should be a good idea to pass…

… the laneId too. It gonna be much more easy to find the card inside the specific lane.

Thanks for the changes 👍


Cursor stay "busy" after startup on Linux

Godot version
3.x (ef8401edf5327a41dcb9aa3bb66a27b5d0e78c3c) 4.0 (52952edafcbbc42185db8e5371119c1df9afca83)
System information
Arch Linux, GLES 3, Mesa Intel(R) UHD Graphics (CML GT2)
Issue description
Godot on Linux sets the mouse cursor shape to Busy (arrow with hourglass) on startup. This is not done on other platforms.
3.x OS_X11::initialize():
https://github.com/godotengine/godot/blob/ef8401edf5327a41dcb9aa3bb66a27b5d0e78c3c/platform/x11/os_x11.cpp#L587
4.0 DisplayServerX11::DisplayServerX11():
https://github.com/godotengine/godot/blob/52952edafcbbc42185db8e5371119c1df9afca83/platform/linuxbsd/display_server_x11.cpp#L4918
The cursor shape is not updated to a regular arrow shape when initialization is done. So the cursor will stay "Busy" as long as the user don't move the mouse. But some users like me prefer to leave the mouse alone until the cursor becomes normal :rofl:
Steps to reproduce
Start any project (or open it with the editor) on Linux. Leave your cursor inside the newly opened window and don't move it.
Minimal reproduction project
No response

I believe, that this was fixed for 4.0 by #58995
related to #50772


Add hydrogen 0.9.7-rc1

After making all changes to the cask:

[X] brew cask audit --download {{cask_file}} is error-free.
[X] brew cask style --fix {{cask_file}} reports no offenses.
[X] The commit message includes the cask’s name and version.

Additionally, if adding a new cask:

[X] Named the cask according to the [token reference].
[X] brew cask install {{cask_file}} worked successfully.
[X] brew cask uninstall {{cask_file}} worked successfully.
[X] Checked there are no [open pull requests] for the same cask.
[X] Checked that the cask was not already refused in [closed issues].

Closes #26865.

audit for hydrogen: failed
 - download not possible: sha256 mismatch
Expected: 606a33ad624beecc849f8d651b267ee9cea28dbf7e3aea951b9ad4b48c73b0b3
Actual: 86eb2a3cefd7e07ad41d1332b681a75a9ea052cb96910dec0cc4429b65a9c7a8
File: /Users/travis/Library/Caches/Homebrew/Cask/hydrogen--0.9.7,rc1.dmg

This has got me confused - running brew cask fetch https://raw.githubusercontent.com/miccal/homebrew-cask/e078eb9d8aa2a9a9f0c7ff84774aca5dd81b956c/Casks/hydrogen.rb results in a file with a different sha256 every time?
-bash-4.4.5- /Users/miccal [> brew cask fetch https://raw.githubusercontent.com/miccal/homebrew-cask/e078eb9d8aa2a9a9f0c7ff84774aca5dd81b956c/Casks/hydrogen.rb
==> Downloading external files for Cask https://raw.githubusercontent.com/miccal/homebrew-cask/e078eb9d8aa2a9a9f0c7ff84774aca5dd81b956c/Casks/hydrogen.rb
==> Downloading https://raw.githubusercontent.com/miccal/homebrew-cask/e078eb9d8aa2a9a9f0c7ff84774aca5dd81b956c/Casks/hydrogen.rb
######################################################################## 100.0%
==> Downloading https://downloads.sourceforge.net/projects/hydrogen/files/Hydrogen/0.9.7%20Binaries/hydrogen-0.9.7-rc1.dmg
######################################################################## 100.0%
==> Verifying checksum for Cask hydrogen
==> Note: running "brew update" may fix sha256 checksum errors
Error: sha256 mismatch
Expected: 606a33ad624beecc849f8d651b267ee9cea28dbf7e3aea951b9ad4b48c73b0b3
\[\e[1;38;5;2m\] Actual: cdb5de0a182d49f2e0be28203e62a42debf7a0035fe9f55d27b960ff17d3cf8f
File: /Users/miccal/Library/Caches/Homebrew/Cask/hydrogen--0.9.7,rc1.dmg
To retry an incomplete download, remove the file above.
-bash-4.4.5- /Users/miccal [> brew cask cleanup
==> Removing cached downloads
/Users/miccal/Library/Caches/Homebrew/Cask/hydrogen--0.9.7,rc1.dmg
/Users/miccal/Library/Caches/Homebrew/Cask/hydrogen.rb
==> This operation has freed approximately 43K of disk space.
-bash-4.4.5- /Users/miccal [> brew cask fetch https://raw.githubusercontent.com/miccal/homebrew-cask/e078eb9d8aa2a9a9f0c7ff84774aca5dd81b956c/Casks/hydrogen.rb
==> Downloading external files for Cask https://raw.githubusercontent.com/miccal/homebrew-cask/e078eb9d8aa2a9a9f0c7ff84774aca5dd81b956c/Casks/hydrogen.rb
==> Downloading https://raw.githubusercontent.com/miccal/homebrew-cask/e078eb9d8aa2a9a9f0c7ff84774aca5dd81b956c/Casks/hydrogen.rb
######################################################################## 100.0%
==> Downloading https://downloads.sourceforge.net/projects/hydrogen/files/Hydrogen/0.9.7%20Binaries/hydrogen-0.9.7-rc1.dmg
######################################################################## 100.0%
==> Verifying checksum for Cask hydrogen
==> Note: running "brew update" may fix sha256 checksum errors
Error: sha256 mismatch
Expected: 606a33ad624beecc849f8d651b267ee9cea28dbf7e3aea951b9ad4b48c73b0b3
Actual: 52fdb8412329037449773b93968a036b7fb789e7906028828b5cd6271c6234ee
File: /Users/miccal/Library/Caches/Homebrew/Cask/hydrogen--0.9.7,rc1.dmg
To retry an incomplete download, remove the file above.
-bash-4.4.5- /Users/miccal [> brew cask cleanup
==> Removing cached downloads
/Users/miccal/Library/Caches/Homebrew/Cask/hydrogen--0.9.7,rc1.dmg
/Users/miccal/Library/Caches/Homebrew/Cask/hydrogen.rb
==> This operation has freed approximately 43K of disk space.
-bash-4.4.5- /Users/miccal [> brew cask fetch https://raw.githubusercontent.com/miccal/homebrew-cask/e078eb9d8aa2a9a9f0c7ff84774aca5dd81b956c/Casks/hydrogen.rb
==> Downloading external files for Cask https://raw.githubusercontent.com/miccal/homebrew-cask/e078eb9d8aa2a9a9f0c7ff84774aca5dd81b956c/Casks/hydrogen.rb
==> Downloading https://raw.githubusercontent.com/miccal/homebrew-cask/e078eb9d8aa2a9a9f0c7ff84774aca5dd81b956c/Casks/hydrogen.rb
######################################################################## 100.0%
==> Downloading https://downloads.sourceforge.net/projects/hydrogen/files/Hydrogen/0.9.7%20Binaries/hydrogen-0.9.7-rc1.dmg
######################################################################## 100.0%
==> Verifying checksum for Cask hydrogen
==> Note: running "brew update" may fix sha256 checksum errors
Error: sha256 mismatch
Expected: 606a33ad624beecc849f8d651b267ee9cea28dbf7e3aea951b9ad4b48c73b0b3
Actual: 27688040de26b906d85b454b788cbe78c5177c5fffdefe49e22c556d590d81b6
File: /Users/miccal/Library/Caches/Homebrew/Cask/hydrogen--0.9.7,rc1.dmg
To retry an incomplete download, remove the file above.

Not sure what's happening there, but I just tried downloading it three times from this link https://sourceforge.net/projects/hydrogen/files/Hydrogen/0.9.7%20Binaries/hydrogen-0.9.7-rc1.dmg/download and seem to be getting the same shasum each time.
daeaa3e7a6fc5ee61a4c59116c90104d2393fd71c8782f136b48bed58d6082db  hydrogen-0.9.7-rc1.dmg
daeaa3e7a6fc5ee61a4c59116c90104d2393fd71c8782f136b48bed58d6082db  hydrogen-0.9.7-rc1.dmg
daeaa3e7a6fc5ee61a4c59116c90104d2393fd71c8782f136b48bed58d6082db  hydrogen-0.9.7-rc1.dmg

OK, I changed the URL, but now brew cask audit will complain that the sourceforge URL is not in the right form, which is why I changed it in the first place.

audit for hydrogen: warning
 - SourceForge URL format incorrect. See https://github.com/caskroom/homebrew-cask/blob/master/doc/cask_language_reference/stanzas/url.md#sourceforgeosdn-urls

All done.
Very strange, when I first created the cask I am certain I followed the advice in url.md and initially had the url as https://downloads.sourceforge.net/{{project_name}}/{{filename}}.{{ext}}, but it would not download when I ran brew cask audit --download.
Sorry for all the trouble.

Sorry for all the trouble.

No trouble at all. All your contributions are appreciated.


Data Normalization #1857

Description 📜
I did an extensive documentation on Data Normalization, and how it's applied using sample code. Added one MD and one IPYNB files.
Fixed #1857

Type of change 📝

[x] Documentation (Content Creation in the form of codes or tutorials)

Domain of Contribution 📊

[x] Datascience with Python

Checklist ✅

[x] I follow Contributing Guidelines & Code of conduct of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I'm GWOC'21 contributor

Screenshots / Gif (Optional) 📸

Interested in working on this issue.

This is not an issue but a PR. @manthan89-py

@prathimacode-hub please check, i have added the benifits, usage purpose and as for application and why its preferred i think its covered in Is Normalization helpful and importance if normalization, please check


The script fails when used with JDK 9 and higher

This is to track an upstream issue: https://github.com/holgerbrandl/kscript/issues/239
tl;dr Kotlin up to 1.3.70 (included) have some classloading issues that are triggered when KScript tries loading Maven dependencies into itself. Nothing that can be fixed here, waiting for upstream changes.

It works now.


Fix bug of ShardingEncryptorStrategy throwing outOfIndex exception.

Fixes #2205.

Pull Request Test Coverage Report for Build 7612

1 of 2 (50.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.0006%) to 54.814%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

sharding-core/sharding-core-common/src/main/java/org/apache/shardingsphere/core/strategy/encrypt/ShardingEncryptorStrategy.java
1
2
50.0%

Totals

Change from base Build 7611:
-0.0006%

Covered Lines:
8671

Relevant Lines:
15819

💛  - Coveralls


Resolve localization issue warnings in docs build system

When running a docs build, there's apparently a new warning about locale-specific URLs referencing other APIs.
https://docs.microsoft.com/en-us/contribute/validation-reference/locale-specific-links
The warning looks like this:
Link https://msdn.microsoft.com/en-us/library/windows/desktop/aa365152(v=vs.85).aspx contains locale code en-us. For localizability, remove en-us from links to Microsoft sites. For more information, see https://aka.ms/LocaleSpecificLinks.
This represents scrubbing these out of our docs.

This looks like it was done in #102


Conflict with vi-mode default plugin

This issue is the same as #319, but it's still a root of problems. The oh_my_zsh.sh firstly sources the used plugins, in this case vi-mode plugin, which defines the widget zle-keymap-select. After that, the zsh theme (in our case the powerlevel9k) is sourced and the widget zle-keymap-select is then overridden, breaking part of the vi-mode plugin. Three solutions come to my mind:

make a pull request to oh-my-zsh to invert the source order, so the plugins files are the last things to be sourced;
remove the zle-keymap-select from powerlevel9k.zsh-theme file
manually source the plugin at the end of your .zshrc

How is .zshrc configured to fix the conflict and insure a working vi_mode indicator?
This following configuration does not work for me when using powerlevel9k release v0.6.7

source $ZSH/oh-my-zsh.sh

# Fix for vi-mode indicator on powerlevel9k
source $ZSH/custom/plugins/vi-mode/vi-mode.plugin.zsh

It's been almost a year and this is still a problem. The workaround I've been using since then is to source custom plugins manually at the end of the ~.zshrc file. Just make sure source $ZSH/custom/plugins/vi-mode/vi-mode.plugin.zsh is the last line.

It's been almost a year and this is still a problem.

If it's any consolation, there's been no commits in the last year: https://github.com/Powerlevel9k/powerlevel9k/graphs/commit-activity. This doesn't help with your issue but at least you know it's not being deprioritized compared to other issues.

Oh, it's a shame the development was put on hold, I didn't know that. But for this issue in specific, I believe the most adequate solution is for the oh-my-zsh to change the order of their sourcing files. The custom plugins must have priority over the system ones. They already ensure this with the command alias:

Set personal aliases, overriding those provided by oh-my-zsh libs, plugins, and themes

But they fail to do the same with the plugins. I'll open an issue there about this.

But for this issue in specific, I believe the most adequate solution is for the oh-my-zsh to change the order of their sourcing files.

This is a bug in powerlevel9k and it can be fixed. I know it because I've fixed it in my fork.

I tried your powerlevel10K plugin. It indeed fixes this bug, now I can add vi-mode plugin in the intended way. No workarounds needed anymore. Also it is waaaaayy faster than powerlevel9K, and I got 100% compatibility with my previous config as simple as that. Just needed to add POWERLEVEL9K_LEGACY_ICON_SPACING="true" and ZLE_RPROMPT_INDENT=0. Simply amazing dude!

I second @FreddieOliveira's remarks. Just installed powerlevel10k quick and painless with no issues.


Machines disappeared after updating SF

Description (Required)
Dynatech blocks can't be replaced when they were removed out of no where
Steps to reproduce the Issue (Required)

Place Dynatech machines
Update to the latest SF + Dynatech
Machines are removed by the plugin
Try replacing them with the same machine
Blocks place than disappear

Expected behavior (Required)
Machines not disappearing and if they do, you can replace them
Server Log / Error Report
https://pastebin.com/0xrMG9Gc
Environment (Required)

Minecraft Version: 1.16.5
CS-CoreLib Version: -
Slimefun Version: 921
Plugin Version: 120

Convo I had in the SF discord https://s.pingu.ga/H5l1E

I did... This error happened after I updated. Will try again

There was a hotfix applied for it roughly ~4 days ago

Looked just now looks to be fixed


Make the DeclarationEngine a lazy_static as a semi-temporary bandaid

Per https://github.com/FuelLabs/sway/pull/2637#discussion_r957856030, many standard traits like PartialEq need to be special-cased for DeclarationId because each DeclarationId needs to index into the DeclarationEngine (much the same as TypeEngine and TypeId). Of course, the standard traits like PartialEq don't allow for extra arguments, so we have to come up with another solution.
We could either:

create a wrapper type CompileWrapper<'a, T> that takes a &'a T and &'a DeclarationEngine, for example CompileWrapper<'a, DeclarationId>. Then implement PartialEq on CompileWrapper<'a, DeclarationId>. The downside of this is that it introduces a layer of indirection in the compiler (draft branch here: https://github.com/FuelLabs/sway/tree/emilyaherbert/add-partial-eq)
give DeclarationId a &'de DeclarationEngine field so that we can implement PartialEq on DeclarationId directly, meaning that DeclarationId would then require a lifetime annotation DeclarationId<'de>. The downside of this is that it requires the lifetime annotation to bubble up through everything that DeclarationId<'de> touches---including TypedExpression, TypeInfo, etc. (draft branch here: https://github.com/FuelLabs/sway/tree/emilyaherbert/update-declaration-wrapper)

Both of these are big PRs that will take some time to introduce and will create a blocker to the DeclarationEngine. So, I propose that we move the DeclarationEngine to being a lazy_static (similar to the TypeEngine). Then, in the future if/when we remove the lazy_static implementation of TypeEngine, we can do the same operation for DeclarationEngine.

The more that we lean into and depend on these global APIs, the trickier it's going to be to untangle their use throughout semantic analysis (Namespace alone was tricky enough). I think I would have recommended we focus on #2063 and your work in #2483 rather than adding more global state.

Per https://github.com/FuelLabs/sway/pull/2637#discussion_r957856030, many standard traits like PartialEq need to be special-cased for DeclarationId because each DeclarationId needs to index into the DeclarationEngine (much the same as TypeEngine and TypeId). Of course, the standard traits like PartialEq don't allow for extra arguments, so we have to come up with another solution.

I think part of the issue here might be that we're talking about equivalence of the underlying declarations, and not the IDs themselves. I think we should be careful not to confuse the two.
Perhaps we could consider a 3rd option: rather than using a PartialEq implementation for DeclarationId to represent DeclarationWrapper equivalence, we instead use a dedicated trait or method for our particular use-case?
In the described case, we can't know if two declarations referred to by two separate IDs are equivalent without access to the DeclarationEngine. Rather than moving the DeclarationEngine to global state and having a PartialEq implementation for the DeclarationId type that is now side-effectful (due to the global lookup), perhaps we could consider adding a method to DeclarationEngine along the lines of decl_eq(&self, a: Id, b: Id) that can be used for checking declaration equivalence? I think having a method along these lines has the benefit of clearly indicating that we're comparing equivalence of the underlying declarations, and not just the IDs.


boards/risc-v, xtensa: Remove CONFIG_DEV_ZERO

Summary
CONFIG_DEV_ZERO is no longer needed in some defconfig files due to

https://github.com/apache/nuttx/pull/15223

This PR removes CONFIG_DEV_ZERO from the affected defconfig files:
make distclean ; tools/refresh.sh --silent canmv230:knsh
make distclean ; tools/refresh.sh --silent canmv230:master
make distclean ; tools/refresh.sh --silent canmv230:nsbi
...

The failed builds above were extracted from nuttx-prometheus-to-mastodon.json
Impact
This PR fixes the failed builds reported by nuttx-dashboard.org

Testing
TODO: Test with docker
https://github.com/NuttX/nuttx/actions/runs/12548591697/job/34988157321#step:7:220
Configuration/Tool: canmv230/knsh
  Normalize canmv230/knsh
< CONFIG_DEV_ZERO=y

[Experimental Bot, please feedback here]
Yes, this PR mostly meets the NuttX requirements, but could use some improvements.
Here's a breakdown:
Strengths:

Clear Summary:  The summary clearly explains the "why" (failed builds, obsolete config), "what" (removing CONFIG_DEV_ZERO), and "how" (using refresh.sh).  The links to the related PR and build logs are helpful.
Impact Description:  The impact on the user, build process, hardware, security, compatibility, and documentation are implicitly addressed (though could be more explicit). The screenshot visually confirms the issue and its impact.
Testing Evidence (Partial):  The PR acknowledges the need for testing and provides a starting point with the Docker reference and the CI log snippet.

Weaknesses:

Impact Specificity: While the impact is addressed, it could be more explicit by stating "NO" or "YES" for each category, as required by the template. For instance:

Impact on user: NO
Impact on build: YES (Fixes failed builds for specified configurations)
Impact on hardware: NO
Impact on documentation: NO
Impact on security: NO
Impact on compatibility:  NO (Removing unnecessary config should not impact compatibility)

Incomplete Testing: The "TODO: Test with docker" indicates incomplete testing. The provided CI log snippet is helpful, but insufficient to confirm the fix. Actual "before" and "after" build logs for at least one affected configuration should be included.  The build host information is also missing.

Recommendations for Improvement:

Explicitly address each impact category with "YES" or "NO" and a brief explanation.
Complete the testing. Build and test at least one of the affected configurations locally using Docker (or another suitable environment).  Capture and include the "before" and "after" build logs.  Provide your build host information (OS, CPU, compiler).
Consider removing the "normalize canmv230/knsh" line from the CI log snippet. It's not clear what that signifies and it doesn't demonstrate the fix.

By addressing these points, the PR will more fully comply with the NuttX requirements and be easier to review and merge.


Add Debian support

Pull Request (PR) description
This Pull Request (PR) fixes the following issues
Closes #248

@root-expert could you please rebase your branch?

Seems like debian10 is hitting the same apparmor issues as Ubuntu2004 with mysql being installed in the action runner and the acceptance test installing mariadb ....
I tried forcing mqsql as I did for ubuntu but mysql packages that worked in ubuntu does not exist in debian ..
Another thing to notice here is that running jira with mariadb is not supported by Atlassian
See databases/mysql here https://confluence.atlassian.com/adminjiraserver/supported-platforms-938846830.html

Seems like the puppet repo package is not available on Debian 12
Beaker::Host::CommandFailure:
  Host 'debian12-64-1' exited with 8 running:
   wget -O '/tmp/puppet-release-bookworm-gh2sZt.deb' 'https://apt.puppet.com/puppet-release-bookworm.deb'
  Last 10 lines of output were:
  	--2024-02-19 13:55:00--  https://apt.puppet.com/puppet-release-bookworm.deb
  	Resolving apt.puppet.com (apt.puppet.com)... <IP_ADDRESS>, <IP_ADDRESS>, <IP_ADDRESS>, ...
  	Connecting to apt.puppet.com (apt.puppet.com)|<IP_ADDRESS>|:443... connected.
  	HTTP request sent, awaiting response... 404 Not Found
  	2024-02-19 13:55:00 ERROR 404: Not Found.

I'll just remove Debian 10


Rework exit signals and task creation

ExitSignal is no longer Arc. Don't add extra overhead by default, its up to runtime implementations whether they need to count references.
Renames get_task_service to create_task_service to highlight that we expect task service to be created from there (and don't do clonable objects).
Create ShimTask from create_task_service to avoid extra creation during shim --start call.
Replaces Arc<Mutex<Option<ShutdownType>>> with Once.

Signed-off-by: Maksym Pavlenko<EMAIL_ADDRESS>

lgtm


Fix formatting of new member example

Deploy preview for openbuildservice ready!
Built with commit 5e3b1c8b7a9b83511349fe1594668383fbb834da
https://deploy-preview-194--openbuildservice.netlify.com


Bootloop  in "Starting Zabbix Agent (classic) 5.4.9"

After starting the docker with docker-compose up -d, it never goes beyond that point, it continues indefinitely until I stop it manually.
The database does not have any table created.
Log

[s6-init] making user provided files available at /var/run/s6/etc...exited 0.
[s6-init] ensuring user provided files have correct perms...exited 0.
[fix-attrs.d] applying ownership & permissions fixes...
[fix-attrs.d] 00-functions: applying...
[fix-attrs.d] 00-functions: exited 0.
[fix-attrs.d] 01-s6: applying...
[fix-attrs.d] 01-s6: exited 0.
[fix-attrs.d] 02-zabbix: applying...
[fix-attrs.d] 02-zabbix: exited 0.
[fix-attrs.d] 03-logrotate: applying...
[fix-attrs.d] 03-logrotate: exited 0.
[fix-attrs.d] done.
[cont-init.d] executing container initialization scripts...
[cont-init.d] 00-startup: executing...
[cont-init.d] 00-startup: exited 0.
[cont-init.d] 01-timezone: executing...
[cont-init.d] 01-timezone: exited 0.
[cont-init.d] 02-permissions: executing...
[cont-init.d] 02-permissions: exited 0.
[cont-init.d] 03-monitoring: executing...
2022-01-14-09:43:31 [NOTICE] ** [monitoring] Container configured for monitoring with 'zabbix classic'
[cont-init.d] 03-monitoring: exited 0.
[cont-init.d] 04-scheduling: executing...
2022-01-14-09:43:31 [NOTICE] ** [scheduling] Container configured for scheduled tasks with 'cron'
[cont-init.d] 04-scheduling: exited 0.
[cont-init.d] 05-logging: executing...
2022-01-14-09:43:31 [NOTICE] ** [logging] Disabling Log Shipping Functionality
[cont-init.d] 05-logging: exited 0.
[cont-init.d] 06-messaging: executing...
2022-01-14-09:43:31 [NOTICE] ** [messaging] Container configured to route mail via SMTP to 'smtp.gmail.com'
[cont-init.d] 06-messaging: exited 0.
[cont-init.d] 10-nginx: executing...
2022-01-14-09:43:31 [NOTICE] ** [nginx] Disable Nginx FastCGI HTTPS Termination Support
[cont-init.d] 10-nginx: exited 0.
[cont-init.d] 11-nginx-config-reload: executing...
[cont-init.d] 11-nginx-config-reload: exited 0.
[cont-init.d] 20-php-fpm: executing...
2022-01-14-09:43:36 [ERROR] ** [php-fpm] Requested enabling openssl however it doesn't exist!
2022-01-14-09:43:37 [ERROR] ** [php-fpm] Requested enabling session however it doesn't exist!
2022-01-14-09:43:38 [NOTICE] ** [php-fpm] PHP-FPM Preparing to start with the following plugins enabled:  apcu bcmath bz2 ctype curl dom exif fileinfo gd iconv imap intl json ldap mbstring mysqli mysqlnd opcache pdo pdo_mysql pgsql phar simplexml tokenizer xml xmlreader xmlwriter
[cont-init.d] 20-php-fpm: exited 0.
[cont-init.d] 30-osticket: executing...
2022-01-14-09:43:39 [NOTICE] ** [osticket] Applying configuration file security
[cont-init.d] 30-osticket: exited 0.
[cont-init.d] 99-container: executing...
[cont-init.d] 99-container: exited 0.
[cont-init.d] done.
[services.d] starting services
[services.d] done.
2022-01-14-09:43:40 [STARTING] ** [nginx] [1] Starting nginx 1.21.5
2022-01-14-09:43:40 [STARTING] ** [monitoring] [1] Starting Zabbix Agent (classic) 5.4.9
2022-01-14-09:43:40 [STARTING] ** [php-fpm] [1] Starting php-fpm 7.4.27
2022-01-14-09:43:40 [STARTING] ** [scheduling] [1] Starting cron
2022-01-14-09:43:41 [STARTING] ** [monitoring] [2] Starting Zabbix Agent (classic) 5.4.9
2022-01-14-09:43:42 [STARTING] ** [monitoring] [3] Starting Zabbix Agent (classic) 5.4.9
2022-01-14-09:43:43 [STARTING] ** [monitoring] [4] Starting Zabbix Agent (classic) 5.4.9
2022-01-14-09:43:44 [STARTING] ** [monitoring] [5] Starting Zabbix Agent (classic) 5.4.9
2022-01-14-09:43:45 [STARTING] ** [monitoring] [6] Starting Zabbix Agent (classic) 5.4.9
...
[s6-finish] sending all processes the KILL signal and exiting.
[s6-finish] sending all processes the TERM signal.
[s6-finish] waiting for services.
[cont-finish.d] done.
[cont-finish.d] executing container finish scripts...
basename: write error: Broken pipe

I'm going to issue a rebuild of the image (:latest) just to see if something has snuck in from one of the many base images I am using. Have a peek at this new image.

CONTAINER_ENABLE_MONITORING=FALSE

That's the solution, thanks.


Update Spring Boot and Spring Cloud versions for the Spring compatibility tests

Update Spring Boot and Spring Cloud versions for the compatibility test.
If you merged this PR, please update Spring Cloud Azure Timeline.
This PR is created by GitHub Actions: https://github.com/Azure/spring-cloud-azure-tools/actions/runs/3784185110

@Netyyyy
Why close this PR?


Make code snippes non-editable

This fixes a problem where code snippets could be edited, e.g. you could select code and delete it. The effect would only last one frame, but was still weird.

Looks like this removes the code block's background colour. It's hard to tell that it is a code block without it.


Tokenizer char_level issue

I receive this error:
AttributeError: 'Tokenizer' object has no attribute 'char_level'
when I load a pickled Tokenizer and attempt to re-use it.
Please make sure that the boxes below are checked before you submit your issue. Thank you!

[x] Check that you are up-to-date with the master branch of Keras. You can update with:
pip install git+git://github.com/fchollet/keras.git --upgrade --no-deps

[X] If running on Theano, check that you are up-to-date with the master branch of Theano. You can update with:
pip install git+git://github.com/Theano/Theano.git --upgrade --no-deps

[X] Provide a link to a GitHub Gist of a Python script that can reproduce your issue (or just copy the script here if it is short).

Solved by explicitly setting tokenizer.char_level = False after loading.


Added Optimized version of Sieve of Eratosthenes

Please read how to contribute first!
Description
Added Optimized version of Sieve of Eratosthenes
Checklist

[x] I've checked the issue list BEFORE deciding what to submit
[x] I've read the contribution guidelines
[x] I've edited the README.md link to my code

Don't forget to visit our website!
Feel free to add this badge after your submission is accepted!

@ricardoprins Can you review this

Awesome, thanks!

@all-contributors please add @iamrajiv for code


Copy relative path key sequence

Issue Type: Bug
It says "Ctrl+K Ctrl+Shift+C".
On the status bar it says "The combination Ctrl-K Ctrl+Shit+C is not a command."
Sounds like a bug to me!  Could you please try the following:

Run the command Developer: Toggle Keyboard Shortcuts Troubleshooting
This will activate logging of dispatched keyboard shortcuts and will open an output panel with the corresponding log file.
Press exactly the keybinding you desire Ctrl+K followed quickly by Ctrl+Shift+C.
check what VS Code detects and what command is invoked.

If you are having trouble understanding the output, please feel free to paste here and I can try to help.

/duplicate #137216


Change Asana Auth to use an Asana application rather than PAT

As a user, I want the sync to use an Asana app, so I don't have to create a user to perform the sync tasks.

Duplicate of #88


(WIP) Update to Angular 8.0.6

WIP

Update delayed due to https://github.com/angular/angular-cli/issues/14566
Using the new syntax for lazy loading results in
ERROR in ./src/app/app-routing.module.ts 27:28
Module parse failed: Unexpected token (27:28)
You may need an appropriate loader to handle this file type.
|     {
|         path: 'projector',
>         loadChildren: () => import('./fullscreen-projector/fullscreen-projector.module').then(m => m.FullscreenProjectorModule),
|         data: { noInterruption: true }
|     },


Check if there will be a Wardrobe and where

Additionally mark this in the venue plan (if possible)

Information requested at cineplexx vienna - will get notice soon.


Add failure logs

Issue #31
Add logs for failure cases.

The test that is failing on the build, is passing locally:

Is there a command or some way to re-run build/unit test?


[SPARK-25220] Seperate kubernetes node selector config between driver and executors.

Seperated node selector config option between executors and driver.
This removes the spark.kubernetes.node.selector config option and seperates it to
spark.kubernetes.driver.selector and spark.kubernetes.executor.selector
to allow seperate node selectors on drivers and executors.
My personal use case for this change is that on AWS we have cheap spotinstances that can terminate at any moment which is okay for executors but not the driver.
With a single node selector option I am unable to use the spot instances to save costs on the executor nodes.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

I agree there's an argument for keeping this, but an alternative would be to leave the original for backward compatability, deprecate it, and recommend people make use of custom pod templates (#22146)

I agree there's an argument for keeping this, but an alternative would be to leave the original for backward compatability, deprecate it, and recommend people make use of custom pod templates (#22146)

+1 on recommending users do this sort of customizations using the new pod template support.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Closing this since it seems the consensus is that pod templates (SPARK-24434) should be used instead.

BTW feel free to open a separate PR to deprecate the config and / or update the docs.

@mccheah @erikerlandson .. Any chance of getting this accepted into 2.4 ?
You literally can't use Spark with Spot instances. And it's likely that us AWS users would have to wait until 3.1 or even 3.2 until it is available to use.

@liyinan926 @erikerlandson Any chance the changes proposed in this PR can be reconsidered for inclusion? I don't mind to update it/create a new PR to make the naming of the arguments more correct.
It's a very small change for Spark for a case that applies to pretty much everyone that's running Spark on Kubernetes in a cloud. In pretty much all cases users want to (or should be) using preemptible machines/spot instances for their executors.
I don't think it's reasonable to require users to maintain their own pod templates (which is quiet an additional maintenance burden, there's no documentation for what should go in there and Spark updates mean the pod templates need to be checked making the upgrade process more painful) for such a common usecase.

Nvm, was looking at updating the code in the PR an it's already been fixed :) :tada:
See https://github.com/apache/spark/pull/33283