Fix build error ImportError: libgthread-2.0.so.0

Step 10 : RUN python -c "import numpy, scipy, pandas, matplotlib, matplotlib.pyplot, sklearn, seaborn, statsmodels, theano"
---> Running in c4cbd41cc586
/opt/miniconda3/lib/python3.5/site-packages/matplotlib/font_manager.py:273: UserWarning: Matplotlib is building the font cache using fc-list. This may take a moment.
warnings.warn('Matplotlib is building the font cache using fc-list. This may take a moment.')
/opt/miniconda3/lib/python3.5/site-packages/matplotlib/font_manager.py:273: UserWarning: Matplotlib is building the font cache using fc-list. This may take a moment.
warnings.warn('Matplotlib is building the font cache using fc-list. This may take a moment.')
Traceback (most recent call last):
File "", line 1, in
File "/opt/miniconda3/lib/python3.5/site-packages/matplotlib/pyplot.py", line 114, in
_backend_mod, new_figure_manager, draw_if_interactive, _show = pylab_setup()
File "/opt/miniconda3/lib/python3.5/site-packages/matplotlib/backends/init.py", line 32, in pylab_setup
globals(),locals(),[backend_name],0)
File "/opt/miniconda3/lib/python3.5/site-packages/matplotlib/backends/backend_qt4agg.py", line 18, in
from .backend_qt5agg import FigureCanvasQTAggBase as _FigureCanvasQTAggBase
File "/opt/miniconda3/lib/python3.5/site-packages/matplotlib/backends/backend_qt5agg.py", line 15, in
from .backend_qt5 import QtCore
File "/opt/miniconda3/lib/python3.5/site-packages/matplotlib/backends/backend_qt5.py", line 31, in
from .qt_compat import QtCore, QtGui, QtWidgets, _getSaveFileName, version
File "/opt/miniconda3/lib/python3.5/site-packages/matplotlib/backends/qt_compat.py", line 124, in
from PyQt4 import QtCore, QtGui
ImportError: libgthread-2.0.so.0: cannot open shared object file: No such file or directory
The command '/bin/sh -c python -c "import numpy, scipy, pandas, matplotlib, matplotlib.pyplot, sklearn, seaborn, statsmodels, theano"' returned a non-zero code: 1

Thanks!


Primary key not exhibit aggregation type when executing show column statement

remember issue #799 ? there is another case, show column statement, so this PR is a supplement of PR #800.
before this PR:
mysql> create table test (`pk` int not null, `col1` int) ENGINE=OLAP primary key (`pk`) COMMENT "OLAP" DISTRIBUTED BY HASH(`pk`) BUCKETS 1 PROPERTIES("replication_num" = "1", "storage_format" = "v2");
Query OK, 0 rows affected (0.00 sec)

mysql> show columns from test;
+-------+------+------+------+---------+-------+
| Field | Type | Null | Key  | Default | Extra |
+-------+------+------+------+---------+-------+
| pk    | int  | NO   | YES  | NULL    |       |
| col1  | int  | YES  | NO   | NULL    |REPLACE|
+-------+------+------+------+---------+-------+
2 rows in set (0.00 sec)

mysql>

after this PR:
mysql> create table test (`pk` int not null, `col1` int) ENGINE=OLAP primary key (`pk`) COMMENT "OLAP" DISTRIBUTED BY HASH(`pk`) BUCKETS 1 PROPERTIES("replication_num" = "1", "storage_format" = "v2");
Query OK, 0 rows affected (0.00 sec)

mysql> show columns from test;
+-------+------+------+------+---------+-------+
| Field | Type | Null | Key  | Default | Extra |
+-------+------+------+------+---------+-------+
| pk    | int  | NO   | YES  | NULL    |       |
| col1  | int  | YES  | NO   | NULL    |       |
+-------+------+------+------+---------+-------+
2 rows in set (0.00 sec)

mysql>

isAggregationTypeImplicit of duplicate table can be also set to true, see https://github.com/StarRocks/starrocks/pull/2912

maybe "One Pull Request. One Concern." is better.
----  _https://fagnerbrack.com/one-pull-request-one-concern-e84a27dfe9f1_

isAggregationTypeImplicit of duplicate table can be also set to true, see #2912

maybe "One Pull Request. One Concern." is better.
----  _https://fagnerbrack.com/one-pull-request-one-concern-e84a27dfe9f1_


[Intel MKL] Conditionally enabling bfloat16

This commit conditionally enables BFloat16 support in MKL CPU backend.
It also adds BFloat16 support for some eigen operators only for MKL CPU backend.
This support is needed to avoid graph pass failures (in placer) related to Eigen
operators not supporting BFloat16 type before MKL graph rewrite pass kicks in.
This temporary support will be removed once Eigen operators support BFloat16 type.

Thank you for the PR! My comments are mostly about formatting.
How do you plan to define ENABLE_INTEL_MKL_BFLOAT16? Later in some build config?
Also, is bfloat16 always on with TF-MKL? If so, maybe we should just use #ifdef INTEL_MKL?

Plan is to remove ENABLE_INTEL_MKL_BFLOAT16 macro sometime later and then Bfloat16 support will be enabled with INTEL_MKL. It is currently disabled, pending some internal testing.

Hi @penpornk , thanks for your review! I have addressed your comments. Pls take a look.

@penpornk Addressed your comments. Pls take a look.


Add new entry next in the queue with /qan

I often find myself adding a video to the queue with /qa, and then dragging the video up to the point in the queue below the current video. A /qan command would simplify the process.
A /qans command (queue add next and select) would also be useful, though the command would probably need a better name.

These additional commands seem reasonable to me and shouldn't be too hard to code. I actually half thought we might already had a queue next feature so had to double check (you can see I mostly use the GUI) because it seems like a common enough use case for CLI users. The downside is of course that it adds yet more commands which could be a bit daunting to non-power users, but they will mostly use the GUI rather than CLI in any case.
Based on the other commands I think /qan and /quans seem like the logical names even if they are a bit cumbersome as we use 'qa for queue add, 'qas' for queue add and select' and 'qn' for select next in queue and so this would just be re-using the existing meanings.

I agree it's a bit tricky and don't really have a preference on the options you gave. But here's another option:
If you were to rework the queue commands entirely, we could have /queue add <file> (/q a <file>), with additional flags (for only the add subcommand) like /queue add --next <file> (/q an <file>) and /queue add --select <file> (/q as <file>). These could be able to be combined so that the user would be able to use /q ans <file> or /q asn <file> to add a video next in the queue, and select it for playback. Other existing queue management commands like /ql, /qs, /qn, /qd could get their own /queue subcommands (list, select/sel, next, delete/del), possibly even keeping the old commands as aliases. That way the only old command that would break is /queue, though I'd guess most people (including me) typically use /qa, which currently does the same thing.
I assume (without having looked at the code) that this would involve a rework of the command system. I don't think this is the absolute necessary solution, nor am I sure it is even better than simply adding /qan and /qans (might be a bit too convoluted). Just a suggestion.
FYI I am not a CLI user - I use the GUI but add to the queue with /qa (usually from youtube).

If there were any changes to rationalise things then I'd still probably want the old commands to still work for backwards compatibility reasons.
I will tag some people who have made commits or issue comments relating to CLI to give them an opportunity to comment on these proposed changes: @crabdancing @gospodin55 @rtix @csandras05 @odrling @xNinjaKittyx @luke-jr

If you were to rework the queue commands entirely, we could have /queue add <file> (/q a <file>), with additional flags (for the add subcommand) like /queue add --next <file> (/q an <file>) and /queue add --select <file> (/q as <file>). These should be able to be combined so that the user would be able to use /q ans <file> or /q asn <file> to add a video next in the queue, and select it for playback. Other existing queue management commands like /ql, /qs, /qn, /qd could get their own /queue subcommands (list, select/sel, next, delete/del), possibly even keeping the old commands as aliases. That way the only old command that would break is /queue, though I'd guess most people (including me) typically use /qa, which currently does the same thing.
I assume (without having looked at the code) that this would involve a rework of the command system. I don't think this is the absolute necessary solution, nor am I sure it is even better than simply adding /qan and /qans (might be a bit too convoluted). Just a suggestion.

While it feels instinctively right to implement commands this way, I feel like in practice most users would still prefer to use short aliases in Syncplay (if they even use them) because having more characters to type means you have more chances to make a typo (and it also just takes more time).
That said I think a good thing that could come from having longer commands (without necessarily implementing subcommands and flags) is user defined aliases. These aliases could still default to mimicking the commands we have currently to keep backwards compatibility, and then it would be possible e.g. to alias the /t command to /r (which then would replace the /r alias) and /qa to /a.


Migrate axum integration to use with_state over layer(Extension

In axum, State provides compile-time type safety that Extension does not (https://github.com/tokio-rs/axum/discussions/1830).
When using with_state the axum router becomes Router<_your state_> rather than Router, meaning that LeptosRoutes is not impl'd for it. Update the default impl to work with a stateful router, provided the state can provide the options.
The addition of the LeptosOptionProvider trait allows the impl to be generic on any custom state struct, as long as it can provide the options. I added an impl for LeptosOptions itself, so all the examples continue to work when updated to with_state.
The session_auth_axum might be a good candidate to illustrate integration with a custom state, as it also uses other Extension layers, I'd be happy to do this 🙂

This is failing running cargo check on errors_axum with the following—I haven't taken a look at it otherwise!
error[E0599]: the method `leptos_routes` exists for struct `Router<Arc<LeptosOptions>>`, but its trait bounds were not satisfied
  --> src/main.rs:55:10
   |
52 |       let app = Router::new()
   |  _______________-
53 | |         .route("/api/*fn_name", post(leptos_axum::handle_server_fns))
54 | |         .route("/special/:id", get(custom_handler))
55 | |         .leptos_routes(
   | |         -^^^^^^^^^^^^^ method cannot be called on `Router<Arc<LeptosOptions>>` due to unsatisfied trait bounds
   | |_________|
   |
   |
  ::: /home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/axum-0.6.18/src/routing/mod.rs:59:1
   |
59 |   pub struct Router<S = (), B = Body> {
   |   ----------------------------------- doesn't satisfy `_: LeptosRoutes<Arc<LeptosOptions>>`
  --> /rustc/cba14074bb4cc12bfe918eabd0d52a3999b2a461/library/alloc/src/sync.rs:249:1
   |
   = note: doesn't satisfy `Arc<leptos::LeptosOptions>: LeptosOptionProvider`
   |
   = note: the following trait bounds were not satisfied:
           `Arc<leptos::LeptosOptions>: LeptosOptionProvider`
           which is required by `Router<Arc<leptos::LeptosOptions>>: LeptosRoutes<Arc<leptos::LeptosOptions>>`

warning: unused import: `LeptosRoutes`
  --> src/main.rs:16:44
   |
16 |     use leptos_axum::{generate_route_list, LeptosRoutes};
   |                                            ^^^^^^^^^^^^
   |
   = note: `#[warn(unused_imports)]` on by default

For more information about this error, try `rustc --explain E0599`.
warning: `errors_axum` (bin "errors_axum") generated 1 warning
error: could not compile `errors_axum` (bin "errors_axum") due to previous error; 1 warning emitted
[cargo-make][1] ERROR - Error while executing command, exit code: 101
[cargo-make][1] WARN - Build Failed.
[cargo-make] ERROR - Error while executing command, exit code: 1
[cargo-make] WARN - Build Failed.
Error: Process completed with exit code 1.

This is failing running cargo check on errors_axum with the following—I haven't taken a look at it otherwise!

Yeah, I saw those, hence putting back to draft state, I'd been testing with my own setup rather than with the examples available (bar changing them to State), so clearly missed something that's different in the examples. Will mark ready when/if I can resolve 🙂

All sorted!

So State is a type-safe replacement for Extension - so it should be safer than before (you could forget to add the extension layer, and it would be a run time error rather than compile time. But otherwise, it should all function exactly the same. 🙂

Yeah, I don't see a problem with this. Looks good to me

Thanks!


Shameless plug for jupi

Just a new project I've been building, without using the overload of frameworks that are the rave these days.

Can you link to the https version?

I don’t have certs right now. I’ll get back to you.
/lk

Am 04.02.2016 um 12:43 schrieb Tom Wiesing<EMAIL_ADDRESS>Can you link to the https version?
—
Reply to this email directly or view it on GitHub https://github.com/OpenJUB/jPeople/pull/10#issuecomment-179784545.

@kuboschek  Try https://letsencrypt.org/

It's hosted on GitHub Pages, so there's no SSL on the everyone.wtf domain. Also, any comms with OpenJUB are HTTPS by default, so I don't see an issue here.


Upgrade kind dependency to v0.6.1 to acquire k8s 1.16+

@yue9944882 It seems the kubernetes cluster doesn't reach the readiness, and times out. I suggest you run it locally.

@hectorj2f thanks, sadly i didn't re'pro the failure locally.. let me figure out the gap..

@yue9944882
Why not bump kind to v0.7.0?

closing in favor of #1221


Angular 8 Question

Hey, first off thanks for the great work.  Your plugin made a DLL possible for Angular 7 using @angular-builders/custom-webpack and I can't say how happy that made me.
I am now trying to upgrade the project to v8 and I've found that the lazy loaded modules are generated with @angular/core bundled in a DLL now without using the plugin.  However I do see you have a Angular v8 branch you are working on.   Is your plugin still needed for v8 and if so what are the reason for it?

Hi, the angular 8 branch works when ivy is not enabled. I haven't investigate what would happen when ivy is enabled. If you found lazy modules are built then you probably don't need this plugin.


Prevent using 3.9 with Rails 6.1

There's an issue with Rails 6.1 that caused error WrongScopeError, which was only fixed in rspec-rails 4.0 by #2215.
This should warn the user that rspec-rails need to be upgraded.

Sorry thats not possible, bundler will just go further down the dependency chain.

What do you mean?

We can't alter existing released versions of gems, and when you have some versions of a gem, say 3.9.1 and 3.9.2 and only 3.9.2 restricts Rails to < 6.1 from bundlers point of view its ok to install 3.9.1 and Rails 6.1
So it is not possible to fix, you'll just get older versions of gems that don't have the restriction.

Aha, I see. Makes totally sense. Thanks for the explanation!


recommended sources link in readme returns 404

In the Create an Index section of the readme the link recommended sources results in a 404 error. I was made aware of this by @patrickbr

Good find, looks like I forgot adding that and lost the file. Will have to rebuild from an old version.


Edit date range under "Company" Tab

Describe the bug
When the user chooses the data range from when they want to show the data from, it is showing the starting date January 2005. It is a bit confusing how to change the date or what format of the data you should use (the format shows up only when you click on some date).
To Reproduce
Steps to reproduce the behavior:

Go to 'Company Tab'
Click on 'Start Date' or 'End Date" of any of the charts

Expected behavior

When somebody wants to choose the date range, it is undestandable, what a date format person should use, for example "dd/mm/yyyy"
The data range starts with the current month and year instead of January 2005

Screenshots
If applicable, add screenshots to help explain your problem.

@lenicatko Thanks for the bug report! We'll add this to our roadmap.

Thank you @JamesKunstle for the update! And let me know if you need to test it or anything!


Fixed the copy function to look in the right place for a parent_link

Currently, if you try to copy a Page while using a OneToOneField of any kind, it will fail. The code iterates over each field of Page checking to see if it is a OneToOneField and then checking the attribute field.parent_link which does not exist, it should instead be looking for field.rel.parent_link.

Thanks @SableWalnut! Would you be able to add a test for this, please? I'm guessing you could probably base it on b77dfd20d792bdfc47366d0b5a566f6f84ff60d8 and 9db24387fe0f64810c871d2ad6a98abc3813b663 (which were similar fixes for copying pages with other kinds of relation).

Sure thing! Just added them @gasman! :)

Merged in a1a294049519ea9cba24c554ad0c0ab13731b3f1...0ead79d286b6c74503c0de6efd8acaab8cb291eb. Thanks!


Team member available in the project are removed, when project status is changed from Active to Halted

Describe the bug
When a project is started ,its status is Active, team members are available in the Project. In case if we change status of project from Active to Halted then team members are not available in project detail page.
To Reproduce
Steps to reproduce the behavior:

Go to CRM
Click on Projects, then click on Add new project
Fill form and select status as Active, then click on Save button
Click on the project created in step 3
Click on  Edit button and then click on Project Team members tabs
Click on Add new team member
7.Enter name ,designation and efforts for team members
Click on Save button
Go to project details tab and change status to halted, then click on save button
Click on <- back icon

Expected behavior
The team member should not be removed from project details, if status of project is updated from Active to Halted
Screenshots

@amanbhatt2022 I am working on this issue.

Task is complete
Refer screenshot


Prevent multiple files from being returned

Description

sentry
feels like a bandaid-- why are there multiple files with the same external id in the team in the first place? but that should be resolved in another PR since this check doesn't hurt to add
User Impact

prevents it from erroring out
Demo

n/a
Docs

n/a

:x: 2 Tests Failed:

Tests completed
Failed
Passed
Skipped

684
2
682
0

View the top 2 failed tests by shortest run time

apps/service_providers/tests/test_assistant_runnable.py::::test_assistant_response_with_annotations[without_tools-False]

Stack Traces | 0.74s run time

.../service_providers/tests/test_assistant_runnable.py:418: in test_assistant_response_with_annotations
    result = assistant.invoke("test", attachments=[])
.../service_providers/llm_service/runnables.py:282: in invoke
    output, annotation_file_ids = self._get_output_with_annotations(thread_id, run_id)
.../hostedtoolcache/Python/3.11.10.../x64/lib/python3.11/contextlib.py:81: in inner
    return func(*args, **kwds)
.../service_providers/llm_service/runnables.py:361: in _get_output_with_annotations
    file_name, file_link = self._get_file_link_for_citation(
.../service_providers/llm_service/runnables.py:439: in _get_file_link_for_citation
    file = File.objects.get(external_id=file_id, team_id=team.id).first()
E   AttributeError: 'File' object has no attribute 'first'

apps/service_providers/tests/test_assistant_runnable.py::::test_assistant_response_with_annotations[with_tools-False]

Stack Traces | 0.743s run time

.../service_providers/tests/test_assistant_runnable.py:418: in test_assistant_response_with_annotations
    result = assistant.invoke("test", attachments=[])
.../service_providers/llm_service/runnables.py:282: in invoke
    output, annotation_file_ids = self._get_output_with_annotations(thread_id, run_id)
.../hostedtoolcache/Python/3.11.10.../x64/lib/python3.11/contextlib.py:81: in inner
    return func(*args, **kwds)
.../service_providers/llm_service/runnables.py:361: in _get_output_with_annotations
    file_name, file_link = self._get_file_link_for_citation(
.../service_providers/llm_service/runnables.py:439: in _get_file_link_for_citation
    file = File.objects.get(external_id=file_id, team_id=team.id).first()
E   AttributeError: 'File' object has no attribute 'first'

To view more test analytics, go to the Test Analytics Dashboard
Got feedback? Let us know on Github

feels like a bandaid-- why are there multiple files with the same external id in the team

See comment on https://github.com/dimagi/open-chat-studio/pull/882


Prevent "Address already in use" for HTTP server

When using automatic port selection, the port is bound once and kept bound
rather than unbinding and hoping the OS does not reuse the port number
before it can be explicitly bound again.

We can remove the reflection in Jetty 9.4.7


provisioningState property should always be marked as readonly

Provisioning state is an outcome of a request (mostly a deployment request) made to a service in Azure.
I have not come across a use case where the client needs to modify the value of the provisioning state while making a request to the service.
Even while cancelling a deployment, there is an action associated with the deployment request and the outcome is specified with the provisioning state being "cancelled".

closing due to  lack of data.


feat(planner_manager): run multiple candidate module simlunateously

Description
:arrow_down: This PR must be merged before this PR.
https://github.com/autowarefoundation/autoware_launch/pull/266
In this PR, I modified planner manager logic so that multiple candidate module can run simultaneously, and it is able to select each modules behaivor whether to allow simultaneous execution by following options.
      enable_simultaneous_execution_as_approved_module: true or false
      enable_simultaneous_execution_as_candidate_module: true or false

The following fig shows an example process to pick up candidate modules that run in this planning cycle.

Other example of Step2

Other example of Step4

Related links

Tests performed
Please set following flag to FALSE, and confirm to pass all build.
https://github.com/autowarefoundation/autoware.universe/blob/ad5595389a629346476ee06391260ffea53159ef/planning/behavior_path_planner/CMakeLists.txt#L10
Enable ext LC modules
https://github.com/autowarefoundation/autoware_launch/pull/266
...
    # NOTE: The smaller the priority number is, the higher the module priority is.
    ext_request_lane_change_left:
      enable_module: true # false -> true
      enable_simultaneous_execution_as_approved_module: false
      enable_simultaneous_execution_as_candidate_module: true
      priority: 6
      max_module_size: 1

    ext_request_lane_change_right:
      enable_module: true # false -> true
      enable_simultaneous_execution_as_approved_module: false
      enable_simultaneous_execution_as_candidate_module: true
      priority: 6
      max_module_size: 1
...

Notes for reviewers

Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.
[ ] The PR has been properly tested.
[ ] The PR has been reviewed by the code owners.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.
[ ] The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

NOTE: these two commits will be removed.

https://github.com/autowarefoundation/autoware.universe/pull/3147/commits/004e55536db88ef21b20a723285e37f227d06cb7
https://github.com/autowarefoundation/autoware.universe/pull/3147/commits/a4c83bca1d29d98899be010c245959937b748eea

Tested and everything works!

@satoshi-ota
I think it is LGTM.
Just confirmation on this suggestion. If you're okay with it, I'll commit the suggestion.

Note:
The external request lane change path has a little bit of bug now and I'll make a PR today for the fix.

There is no critical regression caused by this PR. (test result)


flarectl: 0.111.0 -> 0.112.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/cloudflare/cloudflare-go/releases.
meta.description for flarectl is: CLI application for interacting with a Cloudflare account
meta.homepage for flarectl is: https://github.com/cloudflare/cloudflare-go
meta.changelog for flarectl is: https://github.com/cloudflare/cloudflare-go/blob/v0.112.0/CHANGELOG.md
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.112.0 in filename of file in /nix/store/818s7gq65y29dn2wrb2apwp7i3pis6nj-flarectl-0.112.0

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

flarectl

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/818s7gq65y29dn2wrb2apwp7i3pis6nj-flarectl-0.112.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A flarectl https://github.com/r-ryantm/nixpkgs/archive/9e67e8aeeed7b5742b8f75a5487b91d5b3858d4e.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/9e67e8aeeed7b5742b8f75a5487b91d5b3858d4e#flarectl

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/818s7gq65y29dn2wrb2apwp7i3pis6nj-flarectl-0.112.0
ls -la /nix/store/818s7gq65y29dn2wrb2apwp7i3pis6nj-flarectl-0.112.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review

x86_64-linux

:white_check_mark: 1 package built:

flarectl

Maintainer pings
cc @jmbaur for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

@NixOS/nixpkgs-merge-bot merge


feat: enable multi mint payments

This pr allows a lnv2 client to specify a custom amount that should be payed instead of the invoices own amount. This allows to use lightning multi path payments to pay the same invoice from multiple mints and thereby simplifies liquidity management between mints and allows for a unified balance across mints.
These so called multi mint payments where originally invented by the Cashu project.

@m1sterc001guy here's the issue for the missing test coverage: https://github.com/fedimint/fedimint/issues/5490


Allow delete of a grazing schedule

@Kyubinhan This is still a WIP. Open a PR for discussion.
I think that DELETE should not accept a hierarchy; If you want to delete an entry you delete it like:
DELETE /planId/schedule/scheduleId/entry/entryId
If you DELETE an entire schedule, do it like this:
DELETE /planId/schedule/scheduleId
This will delete all related grazing schedule entries because I set ON DELETE CASCADE set as part of the foresight key constraint. No other relations will be touched (pasture, livestock, etc).
The DELETE will just return 204 in both cases (Accepted / No Response).

I've added the second DELETE endpoint to remove a specific grazing schedule entry.


[C++] ARROW_ORC=ON breaks: fatal error: 'orc/OrcFile.hh' file not found

FAILED: src/arrow/CMakeFiles/arrow_objlib.dir/adapters/orc/adapter_util.cc.o
/usr/bin/c++ -DARROW_WITH_LZ4 -DARROW_WITH_SNAPPY -DARROW_WITH_TIMING_TESTS -DARROW_WITH_ZLIB -DARROW_WITH_ZSTD -DURI_STATIC_BUILD -Isrc -I/disk-samsung/freebsd-ports/databases/arrow/work/apache-arrow-4.0.0/cpp/src -I/disk-samsung/freebsd-ports/databases/arrow/work/apache-arrow-4.0.0/cpp/src/generated -isystem /disk-samsung/freebsd-ports/databases/arrow/work/apache-arrow-4.0.0/cpp/thirdparty/flatbuffers/include -isystem /disk-samsung/freebsd-ports/databases/arrow/work/apache-arrow-4.0.0/cpp/thirdparty/hadoop/include -isystem orc_ep-install/include -O2 -pipe -fno-omit-frame-pointer -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -fno-omit-frame-pointer  -isystem /usr/local/include -Qunused-arguments -fcolor-diagnostics -O3 -DNDEBUG  -Wall -Wno-unknown-warning-option -Wno-pass-failed  -O2 -pipe -fno-omit-frame-pointer -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -fno-omit-frame-pointer  -isystem /usr/local/include -fPIC -std=c++11 -MD -MT src/arrow/CMakeFiles/arrow_objlib.dir/adapters/orc/adapter_util.cc.o -MF src/arrow/CMakeFiles/arrow_objlib.dir/adapters/orc/adapter_util.cc.o.d -o src/arrow/CMakeFiles/arrow_objlib.dir/adapters/orc/adapter_util.cc.o -c /disk-samsung/freebsd-ports/databases/arrow/work/apache-arrow-4.0.0/cpp/src/arrow/adapters/orc/adapter_util.cc
In file included from /disk-samsung/freebsd-ports/databases/arrow/work/apache-arrow-4.0.0/cpp/src/arrow/adapters/orc/adapter_util.cc:18:
/disk-samsung/freebsd-ports/databases/arrow/work/apache-arrow-4.0.0/cpp/src/arrow/adapters/orc/adapter_util.h:25:10: fatal error: 'orc/OrcFile.hh' file not found
#include "orc/OrcFile.hh"
         ^~~~~~~~~~~~~~~~
1 error generated.

This file is present:

$ find . -name OrcFile.hh
./work/stage/disk-samsung/freebsd-ports/databases/arrow/work/.build/orc_ep-install/include/orc/OrcFile.hh
./work/.build/orc_ep-prefix/src/orc_ep/c++/include/orc/OrcFile.hh

but the build fails to find it.
The build is outsource.
Environment: OS: FreeBSD 12.2
Reporter: Yuri / @yurivict
Note: This issue was originally created as ARROW-12624. Please see the migration documentation for further details.

In 17.0.0 the error is:
CMake Error in src/arrow/CMakeLists.txt:
  Imported target "orc::orc" includes non-existent path

    "/usr/ports/databases/arrow/work/.build/_deps/orc-build/c++/include"

  in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:

  * The path was deleted, renamed, or moved to another location.

  * An install or uninstall procedure did not complete successfully.

  * The installation package was faulty and references files it does not
  provide.

Are you using FETCHCONTENT_FULLY_DISCONNECTED https://cmake.org/cmake/help/latest/module/FetchContent.html#variable:FETCHCONTENT_FULLY_DISCONNECTED ?

Are you using FETCHCONTENT_FULLY_DISCONNECTED [...]

Yes. Downloads are not allowed during build.

If you want to use it, you must download Apache ORC manually.
See also: https://arrow.apache.org/docs/developers/cpp/building.html#offline-builds
Or you must install Apache ORC by yourself and use separately installed Apache ORC in Apache Arrow C++ build.


Qt: 5.6.0 -> 5.6.1

Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] OS X
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Tested Krita (#15891) with this, works fine. Notice changes in the build process for qtbase -- qt-everywhere-* archive is no longer required (nor available). Patches was modified with regular expressions to accommodate for changes. cc @ttuegel

Could you investigate that Travis failure? There is a missing attribute in some package that depends on Qt.

Fixed -- it was yours truly using more internal qtbase attributes than usually (that said, tdesktop continues to amaze me on how... bad... a build system can be).

Thanks!


Should we have Airspeed telemetry

Airspeed perhaps not so important on copter, but very important for Fixed Wing and for VTOL, particularly around transition.
Should we expose this? What is our strategy for exposing telemetry or features that aren't supported on a particular vehicle?

I would vot that it makes sense to have it.

Added in #957.


Standardize order of release notes sections across GitHub and Blog

The release notes is automatically generated for both the GitHub release and for the release announcement blog post, however the sections appear in a different order in each.
GitHub Release notes sections (in order):

Feature
Bugs
Improvements
Documentation
Build (not auto-generated, see https://github.com/cake-build/cake/issues/3560)

Blog Post Release notes sections (in order):

Feature
Improvement
Documentation
Build
Bug

Suggested new Release notes sections and order for both above:

New Features
Improvements
Bug Fixes
Documentation
Build / Deployment (do not include, as per @pascalberger's suggestion below)

As an initial step changed the sort order to below, not renamed any labels

Breaking change
Feature
Improvement
Bug Fixes
Documentation

Does this match the order in the GRM tank file, or does this need updated?

Just in the blog generator, not looked at GRM yet.


Failed to run the Question Answering example

Hello,
I tried to run the notebook located here: https://github.com/vespa-engine/pyvespa/blob/master/docs/sphinx/source/examples/semantic-retrieval-for-question-answering-applications.ipynb
Everything works fine until I reach the cell where it makes a query, I get an empty list as the result of the query (result.hits = []).
I'm running python 3.10 and made no modification to the notebook.
Any idea? Help would be appreciated. Thanks
PS: Thanks for this nice library.

Thanks for reporting! I will see if I can reproduce and update here.

Forgot to mention i'm using latest version from pypi (pyvespa==0.31.0). Didn't try using master branch directly

I was running this notebook earlier this week with no issues, so I suspect there is something with your environment. Often too little Docker memory is the culprit, you can review https://pyvespa.readthedocs.io/en/latest/troubleshooting.html. You will see in the Docker output if a process crashes.
I will try again with a 4G setting but this notebook takes some time to run so probably update here tomorrow

Thanks for the quick help. What was strange is that I didn't got any error message on the notebook and no error on the docker logs also. I'll try with manually setting more ram to the docker container. Will update tomorrow.

In step 18 I just got:

{'id': 'id:sentence:sentence::2',
 'relevance': 0.5540203635649571,
 'source': 'qa_content',
 'fields': {'sddocname': 'sentence',
  'documentid': 'id:sentence:sentence::2',
  'questions': [0],
  'dataset': 'squad',
  'context_id': 0,
  'text': 'It is a replica of the grotto at Lourdes, France where the Virgin Mary reputedly appeared to Saint Bernadette Soubirous in 1858.'}}

I run pyvespa from head (checked out local version), and 3.10, too

I added
    @property
    def json(self):
        return self.json

to my local pyvespa install to be able to dump the full response object, I think we will add this to future releases

https://github.com/vespa-engine/pyvespa/pull/465/files

Actually I just found the error. When feeding the data with app.feed_data_point(), I got a 'NO SPACE' error. Related to this: https://docs.vespa.ai/en/operations/feed-block.html. Will try to make space for docker and it should fix it.
Just as a note, maybe the notebook could be updated with a check for the returned code of feed_data_point() and throw an error with link to this feed-block page if NO SPACE error is found.

Awesome!
Yes, totally agree on the error check - will look into - and also add to troubleshooting (this is a common problem), keeping this issue open until done

https://github.com/vespa-engine/pyvespa/pull/466

Hey, when are you planning on releasing a new version of pyvespa? (0.32). Cause currently, on the 0.31, package.Field doesn't have the argument 'match'.
Thanks

We hope to release it this sprint, meaning in a week or two


Directional Light gets turned off

Describe the bug
On runtime something is switching of the light component of the directional lights (in my scene but also the example scenes)
To reproduce
Steps to reproduce the behavior:

Open the hand interaction scene
Click on play
See light getting turned of

Expected behavior
Light stays on
Screenshots

Your setup (please complete the following information)

Unity Version [2020.2.0f1]
MRTK Version [2.5]

Target platform (please complete the following information)

HoloLens 2

I've this issue on my project. The weird thing is that my directionnal lights worked fine until today, when I merge my git branches and the project reloaded. Even if I create new lights it turns off on play mode, any suggestions about this issue?

We appreciate your feedback and thank you for reporting this issue.
Microsoft Mixed Reality Toolkit version 2 (MRTK2) is currently in limited support. This means that Microsoft is only fixing high priority security issues. Unfortunately, this issue does not meet the necessary priority and will be closed. If you strongly feel that this issue deserves more attention, please open a new issue and explain why it is important.
Microsoft recommends that all new HoloLens 2 Unity applications use MRTK3 instead of MRTK2.
Please note that MRTK3 was released in August 2023. It features an all new architecture for developing rich mixed reality experiences and has a minimum requirement of Unity 2021.3 LTS. For more information about MRTK3, please visithttps://www.mixedrealitytoolkit.org.
Thank you for your continued support of the Mixed Reality Toolkit!


[completed-docs] group exports are not checked

Bug Report

TSLint version: 5.12.0
TypeScript version: 3.2.2
Running TSLint via: (pick one) CLI

TypeScript code being linted
export const b = 1;
const a = 1;
export { a };

with tslint.json configuration:
{
  "rules": {
    "completed-docs": [
      true,
      {
        "variables": { "visibilities": ["exported"] }
      }
    ]
  }
}

Actual behavior
ERROR: ./test.ts:1:14 - Documentation must exist for exported variables.

Expected behavior
ERROR: ./test.ts:1:14 - Documentation must exist for exported variables.
ERROR: ./test.ts:3:10 - Documentation must exist for exported variables.

💀 It's time! 💀
TSLint is deprecated and no longer accepting pull requests other than security fixes. See #4534. ☠
We recommend you instead use typescript-eslint to lint your TypeScript code with ESLint. ✅
👋 It was a pleasure open sourcing with you!

🤖 Beep boop! 👉  TSLint is deprecated 👈 (#4534)  and you should switch to typescript-eslint! 🤖
🔒 This issue is being locked to prevent further unnecessary discussions. Thank you! 👋


Some of the things that arise about using textarea?

Vue.js version
2.0.0
Reproduction Link
demo
Steps to reproduce
Click on the left to add the picture, add more than two, if you remove the front of any one
What is Expected?
You will find only textarea data has changed, the value of which is shown from start to finish, but the last one removed
The reason why I do not have v-model, is to enter after the end, textarea and vuex before the current value stored in the contents of the inside is a result.
What is actually happening?
Pictures and textarea can correspond to one another, and textarea before the contents of the vuex and stored inside the contents of the same time, the preservation of the database, which is a pop-up tips "different data can be saved"
I do this only to the same data in the case of less preservation of the database, after all, such a poor performance. Such a page, the user clicks back and forth from the operation, is very possible. Each of the previous step, the next step, I will save the database. product demand.
I also used this method

Through the calculation, to the assignment, but the first problem is the following prompts at least enter the judgment of some ten words, the input to ten words, the contents of the emptied. If you click Delete, the textarea will appear two on the page.
Refer to this link forms
Note: I asked in other forums, some people say that this complex situation can not be resolved.
I do not know how it is, so I hope to be resolved.

Please use v-mode. Refer: https://vuejs.org/v2/guide/forms.html#Multiline-text

I know this, however, to determine whether the data and store the last store the value of the method, not you, if you encounter this demand, we must keep the database？


SSL certificate needs full certificate chain.

Added new tls secret to istio-system namespace for cert that has intermediate cert chain in it.
kubectl -n istio-system create secret tls ortelius-credential --cert=ortelius.io.cert+chain.crt --key=ortelius.io.key


Ensure we apply the exception converter consistently

Thrown exceptions were being properly routed through the "convertException" utilities, but when it's wrapped in a CompletionException we'd fail to recognize it.

@DavideD FYI ^
I'll merge this already as it's trivial


Netsarlacc joeddy

Removed connlogger kept applogger unless we want to rewrite a logger for syslog, I think the issue we had was not being able to rotate logs based on time and not knowing if we would lose connection logs.
This is what I have done I created a new goroutine call writelogger that takes connection JSON logs from a channel called Logchan. In writelogger I create a goroutine that will tick every 10 minutes and close the current file and create a new one based on the current time/date. later in writelogger I have a loop that writes to file if the ticker isnt rotating a file.
Removed lumberjack dependencies

@joeddy Please see my other comment on the closed PR. You also didn't squash the commit messages into one.
I usually use these commands to squash my commits into one.


Remove consumer start up delay config for Kafka source

Earlier, Kafka spout in storm-kafka-client used by SAM used auto assignment for partitions.  There were some issues related to that because of which we added consumer start up delay. Auto assignment has been switched to manual assignment in Apache storm community. This issue is to remove that config property from SAM

https://github.com/hortonworks/streamline/pull/842


Should notify some callbacks, like ViewPager.

Now,　ObservableScrollView/ListView/WebView/GridView/RecyclerView has 1-1 relationship between callback.
And, ViewPager was modified to add/remove OnPageChangeListener. Then, that change it was enable to more useful.
I think, should this library been change, like ViewPager ?

@numa08 Thank you for the PR! Looks good to me.

Thanks, I've merged it. I'll release it soon.


Contact us overlay

Type

[ ] Bug fix
[x] New feature
[ ] Improvement to existing feature

Related JIRA Issue(s)
https://www.ebi.ac.uk/panda/jira/browse/ENSWBSITES-1222
Description

Added the contact us icon to all the apps
Created the contact us overlay
Contact us icon will be hidden on production

Deployment URL
http://contact-us-overlay.review.ensembl.org
Views affected

All apps
Homepage

Other effects

[ ] I have checked any requirements for Google Analytics
[x] I have created any required tests
[ ] The PR has as its final commit a WASM/JS update commit if any Rust files were updated.

Notice that, according to the design spec, the right border of the popup does not have rounded corners.

What we should eventually get should be something like this:

Which makes me wonder what benefit, apart from the box-shadow, does the reuse of the Panel component bring at all.

What we should eventually get should be something like this:

Which makes me wonder what benefit, apart from the box-shadow, does the reuse of the Panel component bring at all.


Unable to receive HTTPExportSize metrics

🐞 Bug Report
Affected Services [REQUIRED]

 The issue is located in: app-services
Is this a regression?

 Yes
Description and Minimal Reproduction [REQUIRED]
This issue still existed after fixing edgexfoundry/app-functions-sdk-go#1266

Deploy EdgeX with attached compose file.(For the recreation I used the TAF sample http server, If you use your own http server, please modify the compose file for HTTPExport URL parameter)
Set app-sample LogLevel to DEBUG
Set app-sample ExectionOrder to HTTPExport
Set HTTPExportSize Metrics to true
docker-compose-no-secty-with-app-sample.yml.zip

🔥 Exception or Error

After the metrics default interval time(30s), No any didn't receive the metrics for HTTPExportSize.
`Publish 0 metrics to the 'edgex/telemetry/app-sample' base topic` found In app-sample log.

🌍  Your Environment
Deployment Environment: x86 / Ubuntu
EdgeX Version [REQUIRED]: Main
Anything else relevant?

@cherrycl , this is because ASC was never updated to use latest SDK with the fix. It has now been updated. Please verify this has been resolved. THX!


Switching to TypeScript

One of the reasons why I chose logdown was that it has type definitions which makes it a great choice when using TypeScript. With logdown v3 the type definitions got removed and thus this project is not very user-friendly for TypeScript developers.
Because I ♥ TypeScript I suggest to upgrade the logdown code base to TypeScript. It's not much code that needs to get translated and I can help with it. 😃
TypeScript was already an option when planning the logdown rewrite (https://github.com/caiogondim/logdown.js/issues/72), so it's a great time to bring up that topic again. WDYT?

My main concern regarding that is that we "lose control" over the final bundle.
Bundle size for a frontend library is important, and I don't see much value on switching to TS on such a small lib.
Even though I think we should provide the type definitions since TS is very popular.
@bennyn Can you make a PR for type definitions? :)

Or maybe we can use JSDoc for that https://github.com/Microsoft/TypeScript/wiki/JSDoc-support-in-JavaScript

Just made a small exp with JSDoc + TypeScript: https://github.com/caiogondim/parse-price.js/blob/master/src/index.js
This way we gain type annotations and don't lose control from final output.

Uh, great! I didn't knew that TypeScripts can read types from JSDoc out of the box.
At Wire we did some experiments with tsd-jsdoc. But we had to use a special version to make it work: https://github.com/wireapp/proteus.js/blob/v5.2.0/package.json#L14

I did some more reading on this regard, because I want to implement here at work but without transpilation (so we can deliver a as-is JS file for modern browsers).
TypeScript with JSDoc supports only a subset of TypeScript.
With Flow we can do the same approach and get 100% features.
I would go with Flow.
But honestly, for this lib, I wouldn't implement neither of them.
Tests should be enough and we don't have big data pipelines (which static type would help).

Should we close this issue and create one providing the typings for logdown again? 😉

without transpilation

If you'll use flow. You can use babel plugin, that will only strip type annotations from source code leaving the rest as it was before.
I agree, that such small lib can live without static typing, but I love, when they are present in code :)
Regarding chose logdown was that it has type definitions. This things can be provided without covering the entire code base with type annotations if I'm not mistaken (at least for flow-type it is true)

Since TypeScript is getting more and more popular, guess we should provide a .d.ts file.

hello. is there any update on when you can provide a *.d.ts file for Typescript?

Type definition here https://github.com/caiogondim/logdown.js/blob/master/index.d.ts


Draw Interaction doesn't handle successive clicks if they were performed very fast

Describe the bug
Draw Interaction doesn't handle successive clicks if they were performed very fast.
To Reproduce
Steps to reproduce the behavior:

Go to https://codesandbox.io/s/draw-features-forked-j42gq7 (Drag Pan interaction is removed)
Start drawing a polygon
Try to draw many points while moving cursor and clicking very fast
No point is added to geometry

Demonstration: Screencast from 11-02-23 22:42:59.webm. While moving a cursor I were clicking very fast trying to add points
Expected behavior
I would like points to be added, even if there was little delay between successive clicks.
If it's by design, is there a way to work around?

If you are moving and clicking very fast some of those events might be drag events. These are not handled by the Draw interaction.
Use this to check:
map.on('pointerdrag', (e) => console.log(e.type, e.dragging));

I don't think there is a way to make it work currently.

Yes, that seems to be the case
But the problem is that professional GIS users draw points very quickly while vectorizing images...

There is the moveTolerance config which might help in this case.


Only downloads the video file but NOT exactly the video

Hi, I downloaded all the video of a series but it is just 133KB file, not the exact video. Why is that?

Do you have a valid subscription?

I just have an account, but not have any subscription. I that required?  Even if I just want to download the free videos/series?  I just want to download free videos, not the paid videos.

Oh this means that this project is for users with subscription ONLY, then you might have to put it in the documentation so they know that they have to subscribe first before using it. Thanks :)

Is already in the README ehehe.
https://github.com/iamfreee/laracasts-downloader#an-account-with-an-active-subscription-is-necessary


Arithmetic operators in C++

Description
Explaining briefly about operators using example and code snippets.
Domain
C/CPP
Type of Contribution
Documentation
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

/assign

/assign


When the [Bug Report] select component implements focus, it does not expand. Interactions like native select elements?

Element UI version
1.3.3
OS/Browsers version
win10 Chrome
Vue version
2.3.3
Reproduction Link
https://jsfiddle.net/pj71jkyw/209/
Steps to reproduce
从input按下键盘tab，让el-select不展开，点击的时候展开关闭
What is Expected?
提供一个属性设置 ，focus不展开
What is actually happening?
自己给el-select下的el-input 绑定click事件来触发el-select 的toggleMenu
需要关闭el-select的handleMouseDown
elInput.$off('mousedown.native')
elInput.$el.removeEventListener('mousedown',vm.handleMouseDown)
2种关闭方式都失效
最后选择 elSelect.handleMouseDown = () => {}

First of all, this is not a bug. Using internal props / methods to customize component interactions is not recommended, for the DOM structure and props / methods names are subject to change in the future.

提供一个属性设置 ，focus不展开
This will not be supported.


DO-1168 added the static-files dir and test file to push the dir

This addition is required to unzip the artifact in locally

Codecov Report

Merging #533 into cassandra-triggers will increase coverage by 0.26%.
The diff coverage is n/a.

@@                   Coverage Diff                    @@
##             cassandra-triggers     #533      +/-   ##
========================================================
+ Coverage                 31.71%   31.97%   +0.26%
- Complexity                 1203     1210       +7
========================================================
  Files                       172      172
  Lines                     15116    15116
  Branches                   2396     2396
========================================================
+ Hits                       4794     4834      +40
+ Misses                     9600     9559      -41
- Partials                    722      723       +1

Impacted Files
Coverage Δ
Complexity Δ

...org/ekstep/graph/engine/router/ActorBootstrap.java
56.29% <0%> (-1.33%)
16% <0%> (ø)

.../ekstep/searchindex/processor/SearchProcessor.java
66.36% <0%> (+0.9%)
99% <0%> (ø)
:arrow_down:

...p/searchindex/elasticsearch/ElasticSearchUtil.java
48.05% <0%> (+4.44%)
51% <0%> (+3%)
:arrow_up:

...dex/transformer/AggregationsResultTransformer.java
100% <0%> (+100%)
4% <0%> (+4%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be972f9...22c2e40. Read the comment docs.


Fixes workflow event states unmarshalling methods

Many thanks for submitting your Pull Request :heart:!
What this PR does / why we need it:
Actually, there's a small bug preventing to have Event Switch State and Event Data State on the same definition, this creates a small case where the other of the states only works if they are placed certain way, it's not deterministic.
We are using the sdk but we had to fork it in order to make it work correctly, I think, others will benefit from it.
How to reproduce it.
Given this definition:
{
		"id": "testWorkflow",
		"name": "Validation Workflow Test",
		"version": "1.0",
		"specVersion": "0.7",
		"start": "Sample",
		"states": [
                       {
				"name": "Sample",
				"type": "switch",
				"dataConditions": [
				  {
					"condition": "${  .total > 10 }",
					"transition": "Sample2"
				  }
				]
		      },
                       {
				"name": "Sample2",
				"type": "switch",
				"eventConditions": [
					{
                                                  "eventRef": "eventOne",
						"transition": "HandleEventFinishOne"
				  	},
					{
						"eventRef": "eventFinishTwo",
						"transition": "HandleEventFinishTwo"
				  	}
				]
			}
                 ]
}

This line it's causing that when trying to unmashalling Sample2, mapState is not cleared for the next loop iteration, so map[dataConditions] is not nil. This cause this line to be trigger wrongly, when there are 2 switch events and a Switch Event Database is place before the Switch Event.
Clearing  mapState before the next iteration of the loop should solve the issue.
Please, let me know, if anything else is needed.
Special notes for reviewers:
Additional information (if needed):

@ricardozanini should be good now, I added a small case with both states and making sure it compiles which is the small issue I'm solving, you can quickly confirm the issue changing the code back to the original way and run the test. Let me know if something else is required ^^. Thank u!

@andresmijares let me know if you need a new patch release.

@ricardozanini after the merge, that would be great! i've been using a fork of the project only cause this :)

@ricardozanini after the merge, that would be great! i've been using a fork of the project only cause this :)

Actually, I'll upgrade the Go version and try to fix the CI. Something is not quite right. See #63

@andresmijares, I've fixed all these CI bugs and dependencies problems here: #66
Can you please take a look and try that PR locally to see if it's fine on your side so I can merge it? We then rebase this and do a release.

@ricardozanini i just sourced this branch on my project and ran without problem (without considering the issues fixed in this PR)!

@andresmijares can you rebase now that I've merged #63?

@ricardozanini done! thank you!

@ricardozanini last question, not related to the PR, is there any slack channel for ppl sharing ideas about this project?

i need an invitation, could u send me one pls? email is github user, gmail, thanks!!

@ricardozanini i think it's disabled, i tried joining and it says i dont have an account and i need one :(

You just have to create a free account, I believe.

it seems it is set as invited only, not public joining option

thank you!

Worked?

yes sir!

Great, I'll update our docs.


Signatone support

This PR adds support for the signatone prober in paris.

wait, why are there commits from 2 years ago being pushed with this PR?


Fix TLS handling in the self-monitoring scrape job

Problem
In the self-monitoring scrape job:

Code ordering problem: scrape URL has http instead of https after relating to ca.
The scrape url is an ingress URL instead of always being fqdn.

Solution

Always use fqdn for self-monitoring scrape job, even when ingress is present.
Enable TLS only when certs/key are on disk.
Update scrape job and ingress spec in common exit hook to make sure we write certs on upgrade.

Drive-by fixes:

fetch-lib.
Clear workload version on stop.

Testing
Deploy this bundle:
bundle: kubernetes
applications:
  alertmanager:
    charm: ../../alertmanager-k8s_ubuntu-20.04-amd64.charm
    series: focal
    resources:
      alertmanager-image: ghcr.io/canonical/alertmanager:0.25.0
    scale: 1
    trust: true
  prometheus:
    charm: prometheus-k8s
    channel: edge
    scale: 1
    trust: true
  local-ca:
    charm: self-signed-certificates
    channel: edge
    scale: 1
  external-ca:
    charm: self-signed-certificates
    channel: edge
    scale: 1
  traefik:
    # Use traefik from https://github.com/canonical/traefik-k8s-operator/pull/245
    charm: ../../../traefik-k8s-operator/traefik-k8s_ubuntu-20.04-amd64.charm
    resources:
      traefik-image: ghcr.io/canonical/traefik:2.10.4
#    channel: edge
    series: focal
    scale: 1
    trust: true
relations:
- - traefik:ingress
  - alertmanager:ingress
- - local-ca:send-ca-cert
  - traefik:receive-ca-cert
- - local-ca:certificates
  - alertmanager:certificates
- - local-ca:certificates
  - prometheus:certificates
- - traefik:certificates
  - external-ca:certificates
- - alertmanager:alerting
  - prometheus:alertmanager
- - traefik:ingress-per-unit
  - prometheus:ingress
- - alertmanager:self-metrics-endpoint
  - prometheus:metrics-endpoint

Then make sure the alertmanager target is healthy:
curl -sk https://<IP_ADDRESS>/bndl-prometheus-0/api/v1/targets | jq | grep -E "scrapeUrl|health"

AM blocks for me:
_on_certificate_available
    self.on.cert_changed.emit()  # pyright: ignore
  File "/var/lib/juju/agents/unit-alertmanager-0/charm/venv/ops/framework.py", line 344, in emit
    framework._emit(event)
  File "/var/lib/juju/agents/unit-alertmanager-0/charm/venv/ops/framework.py", line 833, in _emit
    self._reemit(event_path)
  File "/var/lib/juju/agents/unit-alertmanager-0/charm/venv/ops/framework.py", line 922, in _reemit
    custom_handler(event)
  File "./src/charm.py", line 461, in _on_server_cert_changed
    self._common_exit_hook(update_ca_certs=True)
  File "./src/charm.py", line 446, in _common_exit_hook
    self._update_ca_certs()
  File "./src/charm.py", line 518, in _update_ca_certs
    self.container.exec(["update-ca-certificates", "--fresh"]).wait()
  File "/var/lib/juju/agents/unit-alertmanager-0/charm/venv/ops/model.py", line 2427, in exec
    return self._pebble.exec(
  File "/var/lib/juju/agents/unit-alertmanager-0/charm/venv/ops/pebble.py", line 2337, in exec
    resp = self._request('POST', '/v1/exec', body=body)
  File "/var/lib/juju/agents/unit-alertmanager-0/charm/venv/ops/pebble.py", line 1538, in _request
    response = self._request_raw(method, path, query, headers, data)
  File "/var/lib/juju/agents/unit-alertmanager-0/charm/venv/ops/pebble.py", line 1582, in _request_raw
    raise APIError(body, code, status, message)
ops.pebble.APIError: exec: "update-ca-certificates": executable file not found in $PATH
unit-alertmanager-0: 09:48:59 ERROR juju.worker.uniter.operation hook "certificates-relation-changed" (via hook dispatc
hing script: dispatch) failed: exit status 1

@sed-i seems like we need to check alertmanager's target in Prometheus, but we are not deploying Prometheus in the bundle. Am I missing something here?

ops.pebble.APIError: exec: "update-ca-certificates": executable file not found in $PATH

This is really odd @PietroPasotti, because:
$ juju ssh --container alertmanager alertmanager/0 which update-ca-certificates
/usr/sbin/update-ca-certificates

Any chance you're using an old resource?

we are not deploying Prometheus in the bundle

Oops! Updated. Thanks!

good news is: when packing this, loki from main and traefik from #245, only loki remains blocked with "errors in alert rule groups". the rest is green.
Catalogue shows all urls, through ingress, with https.
Bad news is: grafana dashboard still reports broken datasources with:

Error reading Prometheus: Post "https://<IP_ADDRESS>/clite-tls-prometheus-0/api/v1/query": x509: cannot validate certificate for <IP_ADDRESS> because it doesn't contain any IP SANs
I guess that's related to what @tlm said in https://github.com/canonical/operator/issues/970 ?
Unable to fetch labels from Loki (Failed to call resource), please check the server logs for more details
Health check failed. (this is alertmanager)

Release CI failed. Released manually:
Revision 87 of charm 'alertmanager-k8s' released to edge (attaching resources: 'alertmanager-image' r75)


Bugfix Allow for scrolling in Lobby

Probably not needed as with PR: https://github.com/sopra-fs22-group-36/screw-your-neighbor-react/pull/86 the rooms that have started will not be displayed anymore

e58f18136cddc2bdc6d7f39fc9faa0358ddca590

The Demo presentation has shown us, that we need to make our game more immune to trolls, who would just create endless rooms but never start them to mess with other players
This is why this bugfix is still important

The Demo presentation has shown us, that we need to make our game more immune to trolls, who would just create endless rooms but never start them to mess with other players This is why this bugfix is still important

Good Point!


feat: add UI french translations

Add french translations in UI.

Thanks for offering this @jufab! We've run into problems with translations in the past due to lack of participation after first merge. Can you help find 2 other french-speaking folks to review this and possibly help maintain this? cc @fedj

just sent a tweet on our account to help rally support also

No problem @adriancole
I used your post on Tweeter to find other french people 👍

@ImFlog Thanks for your review, I pushed new version.
Just I have no better word than "section"... :D

I see three independent folks interested in this besides me, as well two who can help maintain this. Let's do it!


User Logout

Hi,
Cheers to the commendable work that you have done.
Can you shed some light on the "user logout" as well, I do not see a method for that.
Though the token expires after some time from KeyCloak but a user logout would be great.
Also, can you shed some light on maybe your documentation about how the [admin-cli] and [auth-flow] endpoints are supposed to work so that your docs become more powerful and user-friendly.
Looking forward to hear from you.
Cheers,
Kaustuv.

Hi @kaustuv-zb,
Indeed we do not have any support for logouts yet.
Regarding the explicitness of our docs; could you please provide specific information on what you're missing here? I agree that it could definitely use some improvement, but I don't want to unnecessarily prolong the docs as well.
In general, we do not have the capacity to actively develop this library at the moment, but pull requests are always welcome and reviewed conscientiously :)

Hi @yannicschroeer,
Thank you for getting back on this.
I require 2 things right now:

How to use the APIs with the tags -> [admin-cli] and [auth-flow].
User logout.

Once that it added, your docs and APIs can be much better than what it is now.
Best regards.

Hi @kaustuv-zb,
the API endpoints with the tags admin-cli and auth-flow are basically proxies for some common requests to Keycloak. The purpose of them is to have a unique interface so that users of the API don't have to call Keycloak directly, they should be able to only interact with the API. Since the names of those endpoints mirror exactly the endpoints / functionalities from Keycloak there is not always an explicit documentation for this, it wouldn't add more information (however, PRs always welcome for this :D). fastapi-keycloak is not an own auth solution and just provides some functionality for integrating Keycloak in FastAPI, so if you want to know how to use the endpoints you can find a more detailed explanation for most of the endpoints in the Keycloak documentation.
Regarding the user logout:
As @yannicschroeer already mentioned, we are always open and thankful for any contributions / pull requests since we maintain this project only by the way and don't have time for implementing every new feature.
Additionally I just wanted to mention that already issued tokens are still valid after the logout, it just terminates the session on the side of Keycloak 😄
Best regards.


Front page needs to have prominent links to our other repos

If we're calling this repo "calico" a bunch of people are going to end up here first. They need to be guided to the right place

I agree we need to direct them better from our home page, but I don't know that sending them to sub-repos is the answer. Instead:

Front page should push users onto getting-started page.
Getting-started page should be improved to be more welcoming

Closing in favor of, that's right, #1


Add folder structure to UI components

I took a stab at organizing the various component files into folders. I tried to group them up by related purpose and those used together to make bigger chunks of the UI, and then went back fixing up the imports and finding the various weird dependencies that emerged. A further task is to split out some of the more general-purpose interfaces implemented among the components & organize them, but that's outside the scope of this PR.
I also deleted 6 unused files.
Head on over to the branch to explore the new structure: https://github.com/allenai/scholarphi/tree/mjlangan/folders/ui/src
Also please let me know if I misinterpreted anything or grouped things that shouldn't with how the files were arranged :)
/ui/src/
- /api
- /components
  - /common
  - /control
  - /drawer
  - /entity
    - /citation
    - /creation
    - /equation
  - /icon
  - /mask
  - /overlay
  - /pdfjs
  - /preview
  - /primer

This looks lovely @mjlangan.
The current organization is crisp and thoughtful. I don't take issue with any of it. That said, I'll raise a few questions which might suggest other places that some of the components could fit conceptually:

Perhaps the entity/creation folder should be moved into the control folder. I do not anticipate us exposing entity creation tools to users any time soon; they're more of an admin capability when one of us needs to clean up data quality.

Same question for EntityPropertyEditor and EntityPropertyField

Would search be a more appropriate name for the folder currently named pdfjs? All the components in that directory are currently related to search functionality. Alternatively, maybe another name could be pdfjs-integration to suggest that the components are meant to plug into the PDF.js interface.

Should the TextSelectionMenu be moved into a new folder?

I could imagine moving EntityLink and EntityPageLink into common/ as they feel like small utility components that will appear in many places (i.e., they appear both in the drawer and the glosses), though this is not a strong preference.

Btw, great catch on the dead files!


CUDA test failed

We encountered a failure when running benchmark. The specific process is shown in the picture.
ubuntu 20.04
cuda 11.4

Have you solved this problem? i run this in cuda11.4, but ndtcuda get nan result


How can I specify "--insecure" using this library?

I install openwhisk in ubuntu in my own computer and I can access it using wsk -i ....... However, I have problems using this library to access openwhisk.
For example:
I can run the following command to list all the actions I have created in openwhisk.
wsk -i action list
The output is
actions
/guest/test                                                          private blackbox

However, when I try to do the same thing in a GO program using this library, something wrong happens. Here are my codes:
config := &whisk.Config{
                Host: "http://<IP_ADDRESS>",
		Version: "v1",
		Verbose: true,
		Namespace: "_",
		AuthToken: "23bc46b1-71f6-4ed5-8c54-816aa4f8c502:123zO3xZCLrMN6v2BKK1dXYFpXlPkccOFqm12CdAsMgRU4VrNZ9lyGVCGuMDGIwP",
		Debug: true,
		Insecure: true,
	}
client, err := whisk.NewClient(http.DefaultClient, config)

if err != nil {
	fmt.Println(err)
	os.Exit(-1)
}

options := &whisk.ActionListOptions{
        Limit: 30,
  	Skip: 0,
}

actions, resp, err := client.Actions.List("",options)
if err != nil {
        fmt.Println(err)
        os.Exit(-1)
}
fmt.Println("Returned with status: ", resp.Status)
fmt.Println("Returned actions: \n%+v", actions)

The error message is:
The resource requires authentication, which was not supplied with the request (code df76048ef1abc23514e2a73aa26c910b)

I wonder if I did something wrong in the GO program. Thanks!

The problem is fixed. I just use ~/.wskprop and set AUTH as well as APIHOST in it. Then I can access openwhisk using the following codes:
client, _ := whisk.NewClient(http.DefaultClient, nil)
options := &whisk.ActionListOptions{
	  Limit: 30,
	  Skip: 0,
}
actions, resp, err := client.Actions.List("", options)

New question is, why there is no need to specify something like "--insecure"?

Hello. The first comment shows you’re using http as your app host. Is that correct? If so the insecure option has no effect.
The second comment is puzzling to me as you should be able to use the client without a WskProps file at all.

Hello. The first comment shows you’re using http as your app host. Is that correct? If so the insecure option has no effect.
The second comment is puzzling to me as you should be able to use the client without a WskProps file at all.

For the first comment, when I remove the configuration of Insecure: true in config, I get the following error:
Get https://<IP_ADDRESS>/api/v1/namespaces/_/actions?limit=30&skip=0: x509: cannot validate certificate for <IP_ADDRESS> because it doesn't contain any IP SANs

I don't know why it is still trying to access openwhisk via https even if I configure http in Host.
For the second comment, I try to remove ~/.wskprops and re-run the program and it fails. It seems that when we create a new client, GetDefaultConfig is called to load default configurations. I guess this function will load data from ~/.wskprops by default.


Another attempt to add ga-beacon analytics to .md file (except Godeps folder)

Redid PR #6826 because it was easier to re-submit than resolving a gazillion conflicts.

@mansoorj This needs a rebase. :/

You need a script that verifies the presence of this stuff, or it'll get broken in about 10 seconds.

Please don't modify any of the files in third_party.
All generated files MUST have the analytics line added to the generator source, not just to the generated output. Otherwise, you won't be able to submit this PR. Run hack/verify-gendocs.sh to find out which files this affects.

@mansoorj I think your best bet would be to write a script that verifies that the appropriate include is part of all new .md files. Then new files that get added (even before your changes go in) will have the boilerplate. I think that will also make it easier for you to keep your PR sync'd with head.

I think the analytics line could be appended/inserted by the gen-docs script approx. here:
https://github.com/GoogleCloudPlatform/kubernetes/blob/master/hack/lib/util.sh#L141
cc @jlowdermilk

@mansoorj It's looking like you'll need to take the approach @roberthbailey and @bgrant0607 described to get this in. I'm assuming you'll do this in a separate PR, so I'm closing this one, but please feel free to re-open if you'd rather do it on the same branch.


[VCM] Restore microphone muted states to their original state on exit

Summary of the Pull Request
Do not unmute devices on exit due to privacy issues.
What is this about:
Possible concerns: need to start PT again or change camera device in the app if you want to unmute it again.
What is included in the PR:
How does someone test / validate:
Quality Checklist

[x] Linked issue: #15310
[ ] Communication: I've discussed this with core contributors in the issue.
[ ] Tests: Added/updated and all pass
[ ] Installer: Added/updated and all pass
[ ] Localization: All end user facing strings can be localized
[ ] Docs: Added/ updated
[ ] Binaries: Any new files are added to WXS / YML

[ ] No new binaries
[ ] YML for signing for new binaries
[ ] WXS for installer for new binaries

Contributor License Agreement (CLA)
A CLA must be signed. If not, go over here and sign the CLA.

/azp run

Perhaps the way to fix this should be to record the state it was at before we started.
Something like: If it was unmuted when we started, restore that state. Otherwise, let it be.

Perhaps the way to fix this should be to record the state it was at before we started. Something like: If it was unmuted when we started, restore that state. Otherwise, let it be.

This is the way.

on start: read (and remember) states
do work
on exit: reset to previous

Updated, now we restore devices to their original states.

@jaimecbernardo, good point, I've moved init_settings from ctor to enable(), since it triggers updateControlledMicrophones which in turn populates _microphonesInitialMutedState. Now _microphonesInitialMutedState stays empty if VCM was disabled the whole time.
I'm not sure what we should do when VCM was disabled during the session, since it's hard to determine whether mic state was changed by VCM or by other means, e.g. manually by user, but it sounds like an edge case scenario?

Actually, shouldn't the state be restored on disabling the module too, then?
Does init_settings need to be called on enable? why not just move the call that populates _microphonesInitialMutedState  to enable() instead?

@jaimecbernardo sure, updated. It makes more sense to init_settings on enable though, since, as I understand, module's flow is to init only minimal functionality necessary for later toggling (enable/disable).

What is the expected behavior now if I disable the module/exit PT?
Change to on, change to off or do nothing?

Testing behavior with teams.

Mute mic via settings
Do a call
Teams unmutes mic automatically
Hang up
Mic left unmuted by teams

This leads me to believe the behavior should be: VCM should do nothing when the call ends.  Apps leave the mic unmuted even if it entered muted. We’ll never get it perfect trying to restore prior state and we introduce possible change in behavior (like we did with unmuting everything)
End of the day, an app can toggle the microphone without an end user knowing.  Win11 does add in the Mic icon to system tray when the mic is being accessed (at least in the few tests i ran).

Updated again to not do anything on exit


Cluster creating fails with "sidecar service was not available"

Hello,
I am trying to setup a simple 3 node mysql cluster.
However, it keeps failing with the following log in the init container of the 2nd stateful set pod:
1st pod of the stateful set does come online fine
Create rclone.conf file.
1/30/2021 4:06:57 PM 2021-01-31T00:06:57.484330358Z	INFO	sidecar	environment is not set	{"key": "MY_SERVER_ID_OFFSET"}
1/30/2021 4:06:57 PM 2021-01-31T00:06:57.484406759Z	INFO	sidecar	environment is not set	{"key": "INIT_BUCKET_URI"}
1/30/2021 4:06:57 PM 2021-01-31T00:06:57.48441406Z	INFO	sidecar	environment is not set	{"key": "RCLONE_EXTRA_ARGS"}
1/30/2021 4:06:57 PM 2021-01-31T00:06:57.48441786Z	INFO	sidecar	environment is not set	{"key": "XBSTREAM_EXTRA_ARGS"}
1/30/2021 4:06:57 PM 2021-01-31T00:06:57.48442466Z	INFO	sidecar	environment is not set	{"key": "XTRABACKUP_EXTRA_ARGS"}
1/30/2021 4:06:57 PM 2021-01-31T00:06:57.48442896Z	INFO	sidecar	environment is not set	{"key": "XTRABACKUP_PREPARE_EXTRA_ARGS"}
1/30/2021 4:06:57 PM 2021-01-31T00:06:57.48443326Z	INFO	sidecar	environment is not set	{"key": "XTRABACKUP_TARGET_DIR"}
1/30/2021 4:06:57 PM 2021-01-31T00:06:57.48443716Z	INFO	sidecar	environment is not set	{"key": "INITFILE_EXTRA_SQL"}
1/30/2021 4:06:57 PM 2021-01-31T00:06:57.48447076Z	INFO	sidecar	cloning command	{"host": "my-dev-cluster-mysql-1"}
1/30/2021 4:06:58 PM 2021-01-31T00:06:58.517420291Z	INFO	sidecar	service was not available	{"service": "my-dev-cluster-mysql-replicas", "error": "Get http://my-dev-cluster-mysql-replicas:8080/health: dial tcp <IP_ADDRESS>:8080: connect: connection refused"}
1/30/2021 4:06:59 PM 2021-01-31T00:06:59.541378169Z	INFO	sidecar	service was not available	{"service": "my-dev-cluster-mysql-master", "error": "Get http://my-dev-cluster-mysql-master:8080/health: dial tcp <IP_ADDRESS>:8080: connect: connection refused"}
1/30/2021 4:06:59 PM 2021-01-31T00:06:59.54144527Z	ERROR	sidecar	clone command failed	{"error": "nothing to clone from: no existing data found, no replicas and no master available, and no clone bucket url found"}
1/30/2021 4:06:59 PM github.com/presslabs/mysql-operator/vendor/github.com/go-logr/zapr.(*zapLogger).Error
1/30/2021 4:06:59 PM 	/go/src/github.com/presslabs/mysql-operator/vendor/github.com/go-logr/zapr/zapr.go:128
1/30/2021 4:06:59 PM main.main.func2
1/30/2021 4:06:59 PM 	/go/src/github.com/presslabs/mysql-operator/cmd/mysql-operator-sidecar/main.go:67
1/30/2021 4:06:59 PM github.com/presslabs/mysql-operator/vendor/github.com/spf13/cobra.(*Command).execute
1/30/2021 4:06:59 PM 	/go/src/github.com/presslabs/mysql-operator/vendor/github.com/spf13/cobra/command.go:766
1/30/2021 4:06:59 PM github.com/presslabs/mysql-operator/vendor/github.com/spf13/cobra.(*Command).ExecuteC
1/30/2021 4:06:59 PM 	/go/src/github.com/presslabs/mysql-operator/vendor/github.com/spf13/cobra/command.go:852
1/30/2021 4:06:59 PM github.com/presslabs/mysql-operator/vendor/github.com/spf13/cobra.(*Command).Execute
1/30/2021 4:06:59 PM 	/go/src/github.com/presslabs/mysql-operator/vendor/github.com/spf13/cobra/command.go:800
1/30/2021 4:06:59 PM main.main
1/30/2021 4:06:59 PM 	/go/src/github.com/presslabs/mysql-operator/cmd/mysql-operator-sidecar/main.go:111
1/30/2021 4:06:59 PM runtime.main
1/30/2021 4:06:59 PM 	/usr/local/go/src/runtime/proc.go:203

Here is my cluster definition:
apiVersion: mysql.presslabs.org/v1alpha1
kind: MysqlCluster
metadata:
  name: my-dev-cluster
spec:
  replicas: 3
  secretName: my-dev-cluster
  maxUnavailable: 1
  backupSchedule: 0 * * * *
  backupURL: azure://azurestorageaccount
  backupSecretName: my-dev-cluster-azstore
  backupScheduleJobsHistoryLimit: 10
  podSpec:
    labels:
      app: my-dev-cluster
    affinity:
      podAntiAffinity:
        requiredDuringSchedulingIgnoredDuringExecution:
        - topologyKey: kubernetes.io/hostname
          labelSelector:
            matchLabels:
              app: my-dev-cluster
    backupTolerations:
      - effect: NoSchedule
        key: kubernetes.azure.com/scalesetpriority
        operator: Equal
        value: spot
    resources:
      requests:
        memory: 256Mi
        cpu:    100m
      limits:
        memory: 512Mi
        cpu:    200m
    tolerations:
      - effect: NoSchedule
        key: kubernetes.azure.com/scalesetpriority
        operator: Equal
        value: spot
    priorityClassName: high-priority
  volumeSpec:
    persistentVolumeClaim:
      accessModes: [ "ReadWriteOnce" ]
      resources:
        requests:
          storage: 5Gi
      storageClassName: "default"

Never mind! My installation of operator was corrupted.

Never mind! My installation of operator was corrupted.

Never mind! My installation of operator was corrupted.

same problem to me,can you explain how to fix it?


Throw error if npm is not installed

First of all! Great work! Just deployed my first lambda function!
Not having npm in my path on shell load causes lein cljs-lambda deploy to silently fail, maybe an error would be great? I just lost half an hour because of this as I didn't expect node to be involved with deploying.

@jellea Thanks for reporting, and glad your deploy (eventually) worked out.  I think this issue may fall within the purview of lein-npm, which is handling all of the node/npm interaction.  I can check whether we're swallowing any log messages, but checking for the existence of a Node executable seems like it may be something lein-npm ought to doing.


Internal server error when accesing "/exception" servlet

Currently the server has a servlet to handle errors, this servlet is bounded to the location "/exception". This location may be used internally, but still it can be accessed externally; so when somebody access "rdap-server/exception" the server throws a NullPointerException and responds a 500 error.
I would like to make a suggestion: why not use a filter instead of a servlet? The servlet works fine, but it can give this kind of problems. Also, just in case that you decide to stay with the servlet, I suggest this: when the servlet is directly accessed it should respond with a 404 code, since that service is not part of the RDAP specs.

If the servlet is directly accesed it will respond a 404 error code, since this service shouldn't exist.

Verified. If an user send a request to rdap server like

http://localhost:8080/rdap-server/exception

the server returns the following answer

{"rdapConformance":["rdap_level_0"],"notices":[{"title":"TOS","description":["TOS"],"type":"TOS","links":[{"value":"TOS","href":"example.com/TOS"}]}], "errorCode":"404","title":"Object not found","description":"/rdap-server/exception"}


Add linter to project

I added a linter to the project.
It uses googles java format.
Use this to add linter support to vscode
Basically just add
"java.format.settings.url": "https://raw.githubusercontent.com/google/styleguide/gh-pages/eclipse-java-google-style.xml", "java.format.settings.profile": "GoogleStyle",
to your vscode settings.json

The above comment is wrong. To add linting to vscode add the check style plugin to vscode and use the rule file located at .github/linters/linter.xml

The above comment is wrong. To add linting to vscode add the check style plugin to vscode and use the rule file located at .github/linters/linter.xml


Fix invalid record referencing in records issue

Purpose
Resolves #12388

Codecov Report

Merging #12628 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master   #12628      +/-   ##
============================================
+ Coverage     59.85%   59.85%   +<.01%
  Complexity      659      659
============================================
  Files          2065     2065
  Lines        101682   101689       +7
  Branches      12936    12938       +2
============================================
+ Hits          60862    60868       +6
- Misses        35625    35629       +4
+ Partials       5195     5192       -3

Impacted Files
Coverage Δ
Complexity Δ

...ng/compiler/semantics/analyzer/SymbolResolver.java
84.7% <100%> (+0.09%)
0 <0> (ø)
:arrow_down:

...alang/compiler/semantics/analyzer/SymbolEnter.java
83.6% <100%> (+0.08%)
0 <0> (ø)
:arrow_down:

...ang/net/http/actions/websocketconnector/Close.java
70.45% <0%> (-4.55%)
0% <0%> (ø)

...a/org/ballerinalang/bre/bvm/WorkerDataChannel.java
82.71% <0%> (-3.71%)
0% <0%> (ø)

...rg/ballerinalang/net/http/WebSocketDispatcher.java
90.57% <0%> (+1.04%)
0% <0%> (ø)
:arrow_down:

...org/ballerinalang/bre/bvm/WaitCallbackHandler.java
84.4% <0%> (+1.83%)
0% <0%> (ø)
:arrow_down:

...va/org/ballerinalang/channels/ChannelRegistry.java
97.29% <0%> (+8.1%)
0% <0%> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0547701...032ac31. Read the comment docs.


Decide on a more elegant solution to make gql work with npm link

To fix the current npm-link issue, where the module apollo-client/gql cannot be found, we will place gql.js in the root of the repo and redirect it to lib/src/gql.js`.
After a deep discussion about separate modules or not, we decided to go ahead with the current strategy while we think of something better to do.
This is that issue.

I also ran into the same issue when importing from writeToStore and readFromStore in relation to #180. Hopefully not nearly as important long-term as gql, but I thought it worth mentioning anyway.

@stubailo when do you think we can get the hacky version in. Again if you just wanna write down what you want down, im sure we can do it

PR #243 will place gql in root. Circle back later for elegant fix


HIVE-26631: Remove unused variable requestTimeout and beBackoffSlotLength in the initServer method of the ThriftBinaryCLIService class

What changes were proposed in this pull request?

Remove variable requestTimeout and beBackoffSlotLength in method initServer of class ThriftBinaryCLIService
Remove hive.server2.thrift.exponential.backoff.slot.length and hive.server2.thrift.login.timeout in HiveConf

Why are the changes needed?

Remove unused variable and hiveConf for ThriftBinaryCLIService class
Does this PR introduce any user-facing change?

No
How was this patch tested?

Existing tests

@ayushtkn I was wondering if you got the chance to read my PR？I will thank you very much！

@zabetak  I don't think the variables unused are intentional. In thrift issuse（https://issues.apache.org/jira/browse/THRIFT-5297 ），the parameters requestTimeout and beBackoffSlotLength are removed, because it adds a lot of complexity to the code and doesn't make a whole lot of sense.


Mark Coverr videos as having no sound

Bug Description

Currently, the pre-publish checklist shows a message for a video with missing captions.
Videos from Coverr inserted via the 3P Media tab don't have any sound though, so the message is very misleading in that case.
Just like we want to enable creators to mark videos as having no sound (see #7730), we should videos from Coverr as having no sound, and don't show the pre-publish checklist message in that case.
Expected Behaviour

Videos from Coverr should not trigger this pre-publish check message.
Steps to Reproduce

Insert video from 3P media tab
Go to pre-publish checklist
See message

Screenshots

Additional Context

Plugin Version: 1.7.2
WordPress Version: 5.7
Operating System: macOS
Browser: Chrome

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria

No PPC message for missing captions on Coverr videos.
Coverr resources are marked as muted.
Migration exists for pre-existing video resources in stories

Implementation Brief

Add new isMuted parameter to createResource, defaulting to false.
Update Resource JSDoc typedef accordingly.
Update getVideoResourceFromMedia3p() to set isMuted to true.
Add a new data migration similar to mark3pVideoAsOptimized to set the isMuted attribute to false for all existing videos, but to true for all existing Coverr resources.
Update videoElementMissingCaptions to not return a message if element.resource.isMuted is true

Another suggestion from #7371 is to use a hasAudio flag instead of a isMuted flag. That seems reasonable.

Same thing will be needed for any videos in templates

Created: #7885

Here's how it could be implemented in the output & display layer (ignore the design panel changes): https://github.com/rtCamp/web-stories-ad-tool/pull/44

Verified in QA


Catch failure to open clipboard

Summary of the Pull Request
Unfortunately, we can't necessarily guarantee that you can open the clipboard. It just happens -.-. So, let's catch this error and not crash the Terminal.

References

PR Checklist

[x] Closes #2570
[x] CLA signed.
[x] ~Tests added/passed~
[x] ~Requires documentation to be updated~
[x] I am a core contributor

Yes, we should service.

Thank you @carlos-zamora for addressing this issue so quickly!

Yes, we should service.

@DHowett-MSFT Any ETA for the hotfix? The build of Terminal that is in MS Store is pretty much unusable and it's not even possible to downgrade to a previous release, which I was pretty happy with.


added required async alarm module

it worked on .py but it return an error when i convert it to .exe, because of win10toast lib

i changed it to plyer, it worked, but it still detected as viruses by windows defender, maybe because the subporcess module


RE:Rework, refactor, revamp

Fresh fork to use Svelte.

Git wont update my commits dem

@xnetcat I'm a bit busy now on work projects. But rest assured will finish the rework when I have time.


PrettyPrinter: Check if match is valid before accessing group

[Describe your pull request here. Please read the text below the line, and make sure you follow the checklist.]
Is closing #3919 by checking if match group is available. Also converts argument to string.
Pull request checklist
Read the Contribution Guidelines for detailed information.

[X]  Changes are described in the pull request, or an existing issue is referenced.
[X]  The test suite compiles and runs without error.
[X]  Code coverage is 100%. Test cases can be added by editing the test suite.
[X]  The source code is amalgamated; that is, after making changes to the sources in the include/nlohmann directory, run make amalgamate to create the single-header files single_include/nlohmann/json.hpp and single_include/nlohmann/json_fwd.hpp. The whole process is described here.

Please don't

The C++11 support varies between different compilers and versions. Please note the list of supported compilers. Some compilers like GCC 4.7 (and earlier), Clang 3.3 (and earlier), or Microsoft Visual Studio 13.0 and earlier are known not to work due to missing or incomplete C++11 support. Please refrain from proposing changes that work around these compiler's limitations with #ifdefs or other means.
Specifically, I am aware of compilation problems with Microsoft Visual Studio (there even is an issue label for this kind of bug). I understand that even in 2016, complete C++11 support isn't there yet. But please also understand that I do not want to drop features or uglify the code just to make Microsoft's sub-standard compiler happy. The past has shown that there are ways to express the functionality such that the code compiles with the most recent MSVC - unfortunately, this is not the main objective of the project.
Please refrain from proposing changes that would break JSON conformance. If you propose a conformant extension of JSON to be supported by the library, please motivate this extension.
Please do not open pull requests that address multiple issues.

Thanks!


ES Bulk API response does not respect API spec

items field is not populated
404 is returned on index not found, whereas the error should be described in items (but Airmail currently relies on this behavior)

#4900 populates the items field for a few errors and returns the correct status codes.


Read Manga link broken

The read manga link goes to cubari.moe and 404s. This is because for some reason the git.io short link used is not there anymore. You could replace it with https://cubari.moe/read/gist/cmF3L3RlbnN1cmFmYW4vdGVuc3VyYWZhbi5naXRodWIuaW8vbWFzdGVyL21hbmdhLWluZGV4Lmpzb24 which directly references the url.

Oh yeah, I heard they were deprecating git.io, should've acted sooner. Thanks!


Added more tests to Lesson and Timetable

Codecov Report

Merging #216 (4818899) into master (ddee9e3) will increase coverage by 1.07%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #216      +/-   ##
============================================
+ Coverage     78.05%   79.13%   +1.07%
- Complexity      959      974      +15
============================================
  Files           132      132
  Lines          2885     2885
  Branches        360      360
============================================
+ Hits           2252     2283      +31
+ Misses          561      531      -30
+ Partials         72       71       -1

Impacted Files
Coverage Δ

src/main/java/seedu/address/model/module/Lab.java
88.23% <0.00%> (+17.64%)
:arrow_up:

src/main/java/seedu/address/model/Timetable.java
93.10% <0.00%> (+41.37%)
:arrow_up:

.../main/java/seedu/address/model/module/Lecture.java
88.23% <0.00%> (+47.05%)
:arrow_up:

...in/java/seedu/address/model/module/Recitation.java
88.23% <0.00%> (+47.05%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


classToPlain fails to transform mongo ObjectId to string

Hello guys,
I created an endpoint with routing-controller, from @pleerock :
import { JsonController, Param, Get, NotFoundError } from "routing-controllers";

@JsonController("my-route")
export class MyController {
    @Get("/:marketingId")
    async getOne(@Param("marketingId") marketingId: string) {
        let marketing: MarketingAutomation = await MyDB().findOne({
            '_id': new ObjectId(marketingId)
        });
        console.log(marketing._id instanceOf ObjectId) // writes true

        if (!!marketing && marketing._id) {
            return classToPlain(marketing);
        }

        throw new NotFoundError(`User was not found.`);
    }
}

The model, MarketingAutomation is:
import { ObjectId } from "mongodb";
import { IsDefined, IsString } from 'class-validator';
import { Expose } from 'class-transformer';

export class MarketingAutomation {
    _id?: ObjectId;
    companyId?: ObjectId;

    @IsDefined()
    @IsString()
    name: string;

    @Expose({name: '_id', toPlainOnly: true})
    id() { return this._id.toHexString();}

    @Expose({name: 'companyId', toPlainOnly: true})
    _companyId() { return this.companyId.toHexString();}
}

The response is :
{
    "_id": {
        "_bsontype": "ObjectID",
        "id": {"0":89,"1":186,"2":173,"3":122,"4":253,"5":210,"6":194,"7":101,"8":17,"9":9,"10":73,"11":26}
    },
    "name": "test",
    "companyId": {
        "_bsontype": "ObjectID",
        "id": {"0":87,"1":63,"2":67,"3":251,"4":214,"5":195,"6":157,"7":16,"8":0,"9":72,"10":9,"11":211}
    }
}

The response I would like to receive is:
{
    "_id": "59baad7afdd2c2651109491a",
    "name": "test",
    "companyId": "rf41237afdd2c2651109gt45"
}

When you look at the response, you see that  _id and companyId are not transformed in strings
Do you know how to achieve it ?
Thank you very much !

Can't reproduce this behavior, but I think you have name conflict. Try to add @Exclude to ObjectId properties:
  @Exclude({toPlainOnly: true})
  _id?: ObjectID;
  @Exclude({toPlainOnly: true})
  companyId?: ObjectID;

Do you really need these id and _companyId getters?
You can add @Transform decorator to existing properties instead:
@Transform((id: ObjectID) => id.toHexString(), {toPlainOnly: true})
_id?: ObjectID;
@Transform((id: ObjectID) => id.toHexString(), {toPlainOnly: true})
companyId?: ObjectID;

Thank @Petr0vi4, I will try this.
fyi, I found an alternative:
let instance = plainToClass(classType, JSON.parse(JSON.stringify(plain)));
return classToPlain(instance);

I have the same issue. Looks like there is some implicit to string conversion.  I found the following workaround:
    @Expose()
    public get id() {
        return this._id ? this._id.toHexString() : undefined;
    }

    @Exclude()
    // tslint:disable-next-line:variable-name
    public _id?: ObjectId;

@VivienAdnot The reason for this is that when the JS engine transforms the object it calls the toJSON function recursively under the hood and ObjectId doesn't provide a custom implementation for it, so the default built-in will run what outputs the underlying object.
The proper solution is what @Petr0vi4 wrote in his second comment.
I will go ahead and close this, feel free to continue the discussion if you still have any question.


Address comments from #928

Addresses comments left in PR #928
Signed-off-by: Brett Logan<EMAIL_ADDRESS>

No big deal for this one, but in general it's good to see at least a short summary of the change in the commit message.


(winpcap) AU + guidelines + fixes

I fixed this one, I beleive few tools depend on it.
I couldn't execute AHK using Start-ChocolateyProcessAsAdmin so I invoked AHK as is.
If somebody wants to fix it, please do. If not, I will push it as it is.

O yeah, it also depends on core extension 1.0.

I thought its not released yet. Ignore.

@majkinetor said...
I thought its not released yet. Ignore.

Ah, gotcha.  I pushed it last night, and that is why I merged @AdmiringWorm PR for aptana-studio.

No... i imported core.. no need to cheery pick.
On Nov 14, 2016 1:06 PM, "Kim Nordmo"<EMAIL_ADDRESS>wrote:

@AdmiringWorm commented on this pull request.
In automatic/WinPcap/update.ps1
https://github.com/chocolatey/chocolatey-coreteampackages/pull/396#pullrequestreview-8384845
:

@@ -0,0 +1,27 @@
+import-module au

Missing import for the Get-PackageCacheLocation function?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/chocolatey/chocolatey-coreteampackages/pull/396#pullrequestreview-8384845,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAFPB0tY3C_uVoqr4hi4pQBM3A0qTrBxks5q-E7TgaJpZM4Kw0dt
.

@majkinetor
sure, no need to cherry pick. but there isn't any import for core though.

Meh... lost during branching and merging I guess, it was there :).
Added.

If you are not against this line:
AutoHotkey $ahkScript $packageArgs.fileFullPath

I would merge. I think its what @ferventcoder called antipattern, but I am not 100% sure.
I tried above line as
Start-ChocolateyProcessAsAdmin  "$ahkScript '$($packageArgs.fileFullPath)'" 'Autohotkey'

But AHK complained that it can't find the path. I fail to see how can I make it work hence I used direct call.

What does $toolsPath contain at runtime? An absolute path, or a relative path?

@majkinetor I tried a few different ways to call the Start-ChocolateyProcessAsAdmin, no luck though.
@gep13 I think the $toolsPath is an aboslute path during runtime.

I almost always use absolute paths. That is the only way to make sure script run no matter what is current dir.
I think we should merge this. If the need arises we can always later fix it.

I agree.
@gep13 ?


fix: Asset resolution bug

Closes #321

Current dependencies on/for this PR:

main

PR #324   👈

This stack of pull requests is managed by Graphite.