References in the Known Drugs table are invalid

The Source column in the Known Drugs table for a disease is not correct.
For example, for the disease MONDO_0002974, this column is mostly blank and the name of the references we are capturing is not nicely formatted (undefined entry instead of the urls.name field from the API response):

The GraphQL query returns the data correctly, so it must come from the FE side.
query assocs {
  disease(efoId:"MONDO_0002974") {
    name
		knownDrugs {
      rows {
        target {
          approvedSymbol
        }
      	drug {
          name
        }
        urls {
          url
          name
        }
      }
    }
}
}

Scoping this for inclusion in the 21.06 release.
This issue has been found on the target and disease/phenotype profile pages (Known Drugs) and drug profile pages (Clinical Precedence).

closing this as work is done


Adds 'todo list set' command. Closes #1612

Closes #1612

Coverage remained the same at 100.0% when pulling 091a0422f9fc7c7ae18a75664047b78b6447f92b on ypcode:issue/1612-set-todo-task-list into 20117d60c25e36a1a2427f9a6eb30096148edfb6 on pnp:dev.

👏 Cool! We'll review it shortly

This pull request has been converted to draft to signify that it is still a work in progress as we wait for the Microsoft Graph team to fully release the To Do APIs.
More Information

Changing the stage of a pull request

Merged manually. Thank you! 🚀 👏


load_setup_py_data() support

From some evaluation of boa, my thoughts are a) it's wildly faster than conda-build, and b) we should be able to, and would love to, switch to it for most/all of our packages. Unfortunately, as it stands, that would currently be blocked in many cases by the lack of support for load_setup_py_data() (docs) or equivalent.
Is this something that you would be open to supporting in some form? I think it would also require some looping and maybe conditional support along the lines of what you outline in https://github.com/mamba-org/boa/issues/191#issuecomment-935540102
I think that the support for providing the data could be lifted directly from conda-build here. I'd be happy to provide a PR for that, but adding other templating constructs would presumably be a bit more involved.

Yes, good point - it is a bit more complicated than I was originally suggesting, in that I agree that some multi-stage process results.
We certainly could deal with this ourselves, externally to boa, probably based upon that same conda-build function. I think it would have some downsides though - e.g. building a package locally outside CI would be more awkward.
As I say, I would like to offer some help with this but implementing the (sensible-sounding) solution you outline in your first bullet point might involve deeper changes than would be very practical for me to take on.
I don't know how widely used this conda-build feature is, and therefore of how much general interest it might be for boa. I suppose one way of evaluating that would be searching here in GitHub, for which there seems to be ~1.5k hits in recipe files: https://github.com/search?l=YAML&q=load_setup_py_data&type=Code

I think the first solution won't take that much effort.
This is the source download function: https://github.com/mamba-org/boa/blob/fe4d93b2ad7b323d46e770962e9aa5848a6379c4/boa/core/build.py#L554

Is there a reason to use load_setup_py_data other than setting the version? If it's just for that, there may be better solutions.
As a general-purpose solution, load_setup_py_data has a critical flaw (at least as-implemented) in that missing setup.py dependencies can prevent the recipe from even being parsed:
https://github.com/conda/conda-build/issues/2458#issuecomment-424906994

Well, I can't speak for the 1.5k usages in GitHub! However, our main use case is to share setup/config between the conda/boa recipe and things like tox.

@dhirschfeld right, that's exactly the kind of "recursive" chicken - and - egg situation that I would love to avoid.
Ideally instead of reading a setup.py, one would specify dependencies in a toml file or similar static metadata file and generate the boa and pypi "recipes" from that.
Or, you coudl use the setup.py file to simply parse the dependencies out of the boa recipe (since it's pure yaml it's straightforward!)

Ideally instead of reading a setup.py, one would specify dependencies in a toml file or similar static metadata file and generate the boa and pypi "recipes" from that.

It seems this functionality is now part of conda-build as load_file_data:

https://docs.conda.io/projects/conda-build/en/stable/resources/define-metadata.html#loading-data-from-other-files

Added in https://github.com/conda/conda-build/pull/4480
@wolfv - is it planned to support load_file_data? If not, would that be a reasonable feature request?

Perhaps made redundant by https://github.com/mamba-org/boa/pull/345?


Upgrade to use JDK11

probably available from CXF 3.3 (https://stackoverflow.com/questions/52857820/cxf-codegen-maven-plugin-doesnt-work-openjdk-11)

fixed and verified by build #18


Fix armeria-retrofit throws IllegalArgumentException when using armer…

…ia specific session protocol
Motivations:
Currently, retrofit only allows supports http(s) protocol string, so using h1(c)/h2(c) will throw IllegalArgumentException at retrofit parsing phase.
Modifications:
Convert h1(c)/h2(c) to http(s).
Results:
Make aremria-retrofit won't throw IllegalArgumentException when using h1(c)/h2(c) in url.

Current coverage is 65.42% (diff: 77.77%)

Merging #381 into master will decrease coverage by 0.01%

@@             master       #381   diff @@
==========================================
  Files           355        355
  Lines         14033      14039     +6
  Methods           0          0
  Messages          0          0
  Branches       2099       2100     +1
==========================================
+ Hits           9183       9185     +2
- Misses         3883       3885     +2
- Partials        967        969     +2

Powered by Codecov. Last update cfa1cf8...b79ab9a

updated :)


python: remove unrecognized configure options

What does this PR do?
It removes ignored configure parameters

Motivation
The --with-ssl leads to the impression that this is how the SSL library is detected/enabled, but it isn't

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
[ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
[ ] If applicable, the config template has been updated.

❓ question: Aren't there replacement flags for --enable-shared and --disable-static?

It can be available on a per-project basis. Usually if the project uses libtool then it automatically supports those flags.
In the case of python, yes, but:
--without-static-libpython
Do not build libpythonMAJOR.MINOR.a and do not install python.o (built and enabled by default).

New in version 3.10.

(https://docs.python.org/3/using/configure.html#cmdoption-without-static-libpython)
So not until we upgrade python to 3.10+


Odetta is missing

Original Odetta (4* light sword) is missing from the builder.

fixed
Cy set _IsPlayable = 0 for Odetta and Orion (Valentine's Ver.)
So was ignored by my parser.


Training errror

Traceback (most recent call last):
File "monodepth2.py", line 63, in
args.func(config, output_dir, args)
File "monodepth2.py", line 17, in _cli_train
monodepth2_learner.train(output_dir)
File "/home/jiatian/project/depth/tf-monodepth2/model/monodepth2_learner.py", line 404, in train
self.save(sess, ckpt_dir, 'latest')
File "/usr/lib/python3.6/contextlib.py", line 88, in exit
next(self.gen)
File "/home/jiatian/venv/lib/python3.6/site-packages/tensorflow_core/python/training/supervisor.py", line 1014, in managed_session
self.stop(close_summary_writer=close_summary_writer)
File "/home/jiatian/venv/lib/python3.6/site-packages/tensorflow_core/python/training/supervisor.py", line 839, in stop
ignore_live_threads=ignore_live_threads)
File "/home/jiatian/venv/lib/python3.6/site-packages/tensorflow_core/python/training/coordinator.py", line 389, in join
six.reraise(*self._exc_info_to_raise)
File "/home/jiatian/venv/lib/python3.6/site-packages/six.py", line 696, in reraise
raise value
File "/home/jiatian/venv/lib/python3.6/site-packages/tensorflow_core/python/training/queue_runner_impl.py", line 257, in _run
enqueue_callable()
File "/home/jiatian/venv/lib/python3.6/site-packages/tensorflow_core/python/client/session.py", line 1287, in _single_operation_run
self._call_tf_sessionrun(None, {}, [], target_list, None)
File "/home/jiatian/venv/lib/python3.6/site-packages/tensorflow_core/python/client/session.py", line 1443, in _call_tf_sessionrun
run_metadata)
tensorflow.python.framework.errors_impl.InvalidArgumentError: 2 root error(s) found.
(0) Invalid argument: Expected size[1] in [0, 608], but got 640
[[{{node data_loading/Slice}}]]
[[data_loading/Slice_4/_1053]]
(1) Invalid argument: Expected size[1] in [0, 608], but got 640
[[{{node data_loading/Slice}}]]
0 successful operations.
0 derived errors ignored.
Hi, do you know why does this error happens? Thanks

I did not encounter with this problem, and did some research on this issue at stackoverflow, someone says that this may be caused by tensorflow version, which version did you use in the project?

HI Fang, thank you for the reply.
I use TensorFlow 1.15.0 to train. I tried TensorFlow 1.6.0, but it has some compatible issues with my CUDA, which is cuda9.0.
Do you mind upgrading ur code to a newer TensorFlow version for popularity? Since 1.6 is pretty old,
but thanks anyway :-)

And also the real reason for the above problem is some data loading error:
parameter_count = 26824602
Traceback (most recent call last):
File "/home/jiatian/venv/lib/python3.6/site-packages/tensorflow_core/python/client/session.py", line 1365, in _do_call
return fn(*args)
File "/home/jiatian/venv/lib/python3.6/site-packages/tensorflow_core/python/client/session.py", line 1350, in _run_fn
target_list, run_metadata)
File "/home/jiatian/venv/lib/python3.6/site-packages/tensorflow_core/python/client/session.py", line 1443, in _call_tf_sessionrun
run_metadata)
tensorflow.python.framework.errors_impl.OutOfRangeError: FIFOQueue '_2_data_loading/batch/fifo_queue' is closed and has insufficient elements (requested 8, current size 0)
[[{{node data_loading/batch}}]]

A little busy recently, but I will try upgrading tensorflow asap. The data loading code is adapted from SFMLearner, and work fine for my machine, I'll also do a deeper into that.

Thanks Fang! Just sent you an email about monodepth and slam stuff.
On Thu, Jan 2, 2020 at 7:33 PM Fangget<EMAIL_ADDRESS>wrote:

A little busy recently, but I will try upgrading tensorflow asap. The data
loading code is adapted from SFMLearner, and work fine for my machine, I'll
also do a deeper into that.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/FangGet/tf-monodepth2/issues/6?email_source=notifications&email_token=AEW55HGKBRZH6SNWJVSITLLQ32WZ7A5CNFSM4KBSJYE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIAF5LI#issuecomment-570449581,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEW55HFY5MS756OSS32JHG3Q32WZ7ANCNFSM4KBSJYEQ
.

--
Jiatian Wu
Master of Science in Robotics Technology
Carnegie Mellon University
Mobile:<PHONE_NUMBER>
E-mail<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Address: 1148 Commonwealth Avenue, Apt 56, Allston, MA, 02134

 I tried to install tensorflow 1.15.0 but get an incompatiable problem for cuda driver version and runtime version. Then I found I also use cuda 9.0 accompanied with tensorflow 1.6.0, I suggest you downgrade cudatoolkit in conda from 10.0 -> 9.0, then tensorflow 1.6.0 should be work well with cuda 9.0.
 cudnn version may also need downgraded, I give my virtual environment config for you:

CUDA driver version: CUDA 9.0 (from system)
cudatoolkit version: 9.0 (from virtual env)
cudnn version: 7.1.2 (from virtual env)
tensorflow-gpu version: 1.6.0 (from virtual env)
hope it helps.

Hi,
Conda env details -
Cudatoolkit version : 9.0
cudnn version : 7.1.2
tensorflow-gpu : 1.6.0
I am facing the same issue
Is there anything else, Am I missing?
Attaching the error below
Traceback (most recent call last):
File "monodepth2.py", line 63, in
args.func(config, output_dir, args)
File "monodepth2.py", line 17, in _cli_train
monodepth2_learner.train(output_dir)
File "/home/GML/DEPTH_MODEL/tf-monodepth2/model/monodepth2_learner.py", line 405, in train
self.save(sess, ckpt_dir, 'latest')
File "/home/anaconda3/envs/tf_mono/lib/python3.6/contextlib.py", line 99, in exit
self.gen.throw(type, value, traceback)
File "/home/anaconda3/envs/tf_mono/lib/python3.6/site-packages/tensorflow/python/training/supervisor.py", line 1000, in managed_session
self.stop(close_summary_writer=close_summary_writer)
File "/home/anaconda3/envs/tf_mono/lib/python3.6/site-packages/tensorflow/python/training/supervisor.py", line 828, in stop
ignore_live_threads=ignore_live_threads)
File "/home/anaconda3/envs/tf_mono/lib/python3.6/site-packages/tensorflow/python/training/coordinator.py", line 389, in join
six.reraise(*self._exc_info_to_raise)
File "/home/anaconda3/envs/tf_mono/lib/python3.6/site-packages/six.py", line 703, in reraise
raise value
File "/home/anaconda3/envs/tf_mono/lib/python3.6/site-packages/tensorflow/python/training/queue_runner_impl.py", line 252, in _run
enqueue_callable()
File "/home/anaconda3/envs/tf_mono/lib/python3.6/site-packages/tensorflow/python/client/session.py", line 1259, in _single_operation_run
None)
File "/home/anaconda3/envs/tf_mono/lib/python3.6/site-packages/tensorflow/python/framework/errors_impl.py", line 516, in exit
c_api.TF_GetCode(self.status.status))
tensorflow.python.framework.errors_impl.InvalidArgumentError: Expected size[1] in [0, 608], but got 640
[[Node: data_loading/Slice = Slice[Index=DT_INT32, T=DT_UINT8, _device="/job:localhost/replica:0/task:0/device:CPU:0"](data_loading/DecodeJpeg, data_loading/Slice_4/begin, data_loading/Slice_3/size)]]


[Feature]: fill contribute guide

What problem does this feature solve?
After i clone the repo and run pnpm install, i do not know how to debug the code.
What does the proposed API look like?
I try to do like this:

at repress repo exec pnpm link --global
at debug repo exec pnpm link --global rspress
if i want to debug package / core. at repress repo exec cd ./package/core & pnpm run dev

after this action, so i can debug code. Am I doing the right thing? if right, i want to write these into CONTRIBUTING.md, if wrong, please give me some advice. :)

Nice! Welcome to add these guide docs.


UR Testing - re the make content about skin symptoms more inclusive in the Content style guide

UR Testing of this page in the Content style guide https://service-manual.nhs.uk/content/make-content-about-skin-symptoms-more-inclusive.
UR Testing:
•	Produce the Draft Discussion guide
•	Talk through the Draft Discussion guide with the rest of the team

To add here

This issue relates to issue #1269 (UR Planning).
Also, this issue relates to issue #1183 but further to a discussion with @sarawilcox as the UR will be broken down into various steps and as ticket #1183 displays the various content related discussions between the Content designers over the months have decided to create tickets re the UR

Done
Skin Symptoms Guidance Analysis Summary Matrix_090821.docx


docs/os: add hardening guide for CoreOS

Many people have asked for best practices for hardening CoreOS. This
documents some of the basic practices to check out when considering
CoreOS.

LGTM, I'm not sure what our markdown renderer is gonna do to those headings touching the paragraphs. I can fix if needed.


error of build, cannot convert value

Apple m1 macbook pro 13
1. download zip
2. cd blm-master
3. swift build

Resolved in f240f37.


Issue with scanning Code 128 codes on black background

I'm looking into issues with scanning a particular style of packaging which has a black label with white lines drawn onto it.  I believe the issue is due to the reflectance of the package which is causing GlobalHistogramBinarizer::EstimateBlackPoint to pick a black point that is too low.
Sample photo:

Manually editing the file to set the black point threshold to 195 to manually account for the glare allows scanning to succeed:

Is there any advice or thoughts on how we could improve scanning reliability in this scenario?

The problem here is that the narrow black lines are relatively bright compared to the thick black lines. The fact that the surrounding of the symbol is black is not really of importance here (it could be an issue if the image contained more of the background). What would help is a sharper image, because that would increase the contrast. zxing-cpp itself does not currently have anything to offer to help detect this.

Thanks for the reply @axxel. Yeah, I figured the issue was with the camera saturation light bleed on the thinner lines causing an inconsistent black point for a given row in the image which is also exacerbated by the reflection/dustiness of the package.
I will look into seeing if adjusting the camera contrast settings helps in this scenario.

Update: the other mentioned issue is now fixed. Unfortunatelly, your sample still does not get detected. But I know why and there is still hope - just more work to be done (implement a edge-2-edge based FindLeftGuard).

Thanks for the update!  The first fix did help improve the reliability when scanning these barcodes when running on device with a live camera feed.  Looking forward to testing out the additional fix!


 Its very annoying to see. Can u change the cooldown so its matches java edition.

Yes, I think that should be improved! Great idea!

How do you imagine us doing that?
We offer 3 options atm, which each player can choose while playing (pause menu -> settings -> server settings tab while on the server with geyser)
There are three options for the cooldown:

actionbar
title
no cooldown indicator.
That's what's currently implemented - if you have a specific idea for an indicator that's possible with the technical limitations of bedrock, feel free to tell us ;)

In response to onebeastchris: I'm not fully aware of how texture packs work, but could you have it so that a select set of unicode characters are retextured to show the cooldown stages? Then, rather than showing those dots under your crosshair, you cycle through the retextured characters?

It could be changed using unicode, and a custom texture, however this would cause issues for players who dont have the texture pack because texture packs arent forced to on in geysers config.
If there was a "enable-geyser-optional-pack-features" option in the geyser config, or even, "start-cooldown-text","middle-cooldown-text","end-cooldown-text" in the geyser config, this could be made.

a better name could be "enable-optional-pack-cooldown"

some links that might be helpful with this:
https://wiki.bedrock.dev/concepts/emojis.html#custom-emoji
https://wiki.bedrock.dev/json-ui/json-ui-documentation.html#text

some links that might be helpful with this:
https://wiki.bedrock.dev/concepts/emojis.html#custom-emoji
https://wiki.bedrock.dev/json-ui/json-ui-documentation.html#text

this line seems to be the line that defines what text the cooldown shows: https://github.com/GeyserMC/Geyser/blob/90c4ea78a7285aa734e94400ec7f75e5b2f8ef0e/core/src/main/java/org/geysermc/geyser/util/CooldownUtils.java#L129C12-L129C12
so ill mess around with the code and see if i can make a better cooldown

I have just created the java cooldown in minecraft bedrock with the same texture, however this requires changes to the geysermc code itsself, here is how it looks https://www.youtube.com/watch?v=DrMvQ_-YxNU

I have just created the java cooldown in minecraft bedrock with the same texture, however this requires changes to the geysermc code itsself, here is how it looks https://www.youtube.com/watch?v=DrMvQ_-YxNU

That looks way better!! It would be really cool if that could get implimented

I have just created the java cooldown in minecraft bedrock with the same texture, however this requires changes to the geysermc code itsself, here is how it looks https://www.youtube.com/watch?v=DrMvQ_-YxNU

That looks way better!! It would be really cool if that could get implimented

Also, could you send me the bedrock resource pack just for interest..?

ill do that when i get home but thanks for your interest! ill also make a fork of geyser with the code changed for it and i might make a pull request but obviously make it toggleable

like i said, it wont work with the current geyser code. so you cant use the texture pack on any geyser server, unless its my fork of geyser that ill make public when i get home

but im planning to make a pull request when its properly implemented so it can be added to the main geyser plugin

Okay cool!

the plan for the geyser code is that it will auto detect if the geyseroptionalpack is in the packs folder, then if it is, if the player accepts it then use the custom cooldown.
i also need to figure out how i can extract the java attack indicator texture to be used in the bedrock texture pack automatically in the prepare_packs.sh file but it seems like it will be really hard as java only uses two textures for the cooldown and overlaps them

For complete transparency, it has been in long-term plans to create the GeyserOptionalPack within Geyser and make it a mandatory pack (for things like block and item display entities). The only time this would be an inconvenience would be proxies, which can be easily rectified if we still provide a place to download or create the pack separately.

if you make it mandatory, then maybe geyser could generate the pack when it downloads the locale's from the minecraft jar, because correct me if im wrong but isnt that the full minecraft jar? meaning we could extract the assets and generate the pack that way
and why would it be an issue for some proxies? im not sure why proxies could mess up downloading texture packs

Also, here is the custom geyser code i was talking about
https://github.com/letsgoawaydev/Geyser
and the pack with the texture: https://github.com/letsgoawaydev/GeyserOptionalPack

Also, here is the custom geyser code i was talking about https://github.com/letsgoawaydev/Geyser and the pack with the texture: https://github.com/letsgoawaydev/GeyserOptionalPack
Also just wanted to add, because this only uses one character at a time, it should lag less on lower end devices like the Nintendo Switch that struggle with rendering text.

Did you open a pull request for that? If not you should, it would be cool to see that implimented

Also, here is the custom geyser code i was talking about https://github.com/letsgoawaydev/Geyser and the pack with the texture: https://github.com/letsgoawaydev/GeyserOptionalPack

Also just wanted to add, because this only uses one character at a time, it should lag less on lower end devices like the Nintendo Switch that struggle with rendering text.

Did you open a pull request for that? If not you should, it would be cool to see that implimented

there are a few caveats with making a pull request
it uses a bedrock texture, which
cant be extracted officially as using the bedrock-samples repository from mojang doesnt seem to have the specific texture used for the cooldown afaik
it also would be hard to extract from java as java only uses two textures, one for it being fully charged and one for it being fully depleted, then it overlays the two images accordingly and crops them, where as my texture is already precropped and switched to each frame accordingly
if we just pull requested the texture, im pretty sure it would break minecrafts eula as it uses mojang's copyrighted texture property
what geyser does is extract the files using the extract_assets.sh script in the repository files. however, my texture isnt officially from mojang and is custom modified by me using mojangs textures.

ive made a pull request which helps with the above issue, it will be much easier for me to generate the sprite sheet if the pull request is merged

ive made a pull request which helps with the above issue, it will be much easier for me to generate the sprite sheet if the pull request is merged

I would like to test this version of geyser and the resource pack, how can I test it before time?

the pull request i made doesnt include the custom cooldown, but just python code of the asset extractor
ill make it extract the cooldown eventually if there ever is support added

UPDATE ON THIS
it now seems like it is easier than ever to make this possible as in 1.20.2, mojang have kindly split the image from being a sprite sheet on java to seperate images

UPDATE ON THIS
it is now more possible as mojang have split the attack indicators

Can we possibly bump this or someone please reply with a solution, as I'd love a client side texture pack attack cooldown so that the lag won't mess with the cooldown indicator.

Can we possibly bump this or someone please reply with a solution, as I'd love a client side texture pack attack cooldown so that the lag won't mess with the cooldown indicator.

I recently created a plugin that has this custom cooldown workaround. Heres the github, but its a workaround for now until its eventually added to the GeyserOptionalPack https://github.com/GeyserExtras/GeyserExtras

Can we possibly bump this or someone please reply with a solution, as I'd love a client side texture pack attack cooldown so that the lag won't mess with the cooldown indicator.

I recently created a plugin that has this custom cooldown workaround. Heres the github, but its a workaround for now until its eventually added to the GeyserOptionalPack https://github.com/GeyserExtras/GeyserExtras
Also I made the plugin delay the cooldown indicator based on ping if you have forward player ping enabled in geysers config to ensure that its as accurate as possible.

Is there any chance you can push an update for latest version with 1.20.4 support? This would be the biggest favor in the world and I'd love you forever.


Add support for php_version variable

Trellis now uses a variable php_version for defining the PHP version: https://github.com/roots/trellis/commit/5f398b2e27f1838b2eb4998a961c43db81c7aa57
Note: The PHP version variable can be interpolated like this: {{ php_version }}
Example of its usage in Trellis: https://github.com/roots/trellis/search?q={{+php_version+}}
It would be therefore nice if trellis-redis also uses this variable, as in
https://github.com/jasonsbarr/trellis-redis/blob/1538a4db1efba5ce2007995cc96105e52dbe5059/handlers/main.yml#L19

A good idea and is actually implemented in this fork:
https://github.com/E-VANCE/trellis-redis

@im-mortal, @E-VANCE: This is nice. Though having so many forks will end up in siloing these improvements.
Could this also be added to this fork? And can we somehow negotiate a singular successor fork, at least for fixes and smaller improvements?

@strarsis Totally agree, this should be consolidated...
@im-mortal Would you be willing to carry on? If so then I'll create a PR. I'd maintain the project also, just let me know.

@strarsis, @E-VANCE, thank you for replying.
@strarsis, of course I can merge @E-VANCE's latest changes into my fork as I think using {{ php_version }} is the way.
@E-VANCE, still, I would gladly redirect to your fork if you wish to maintain it, or invite you as a collaborator if you think my fork should be up to date, or just merge your PRs as they go. I'm good either way.

That would be great! Also because not all forked repositories have the issue tracker enabled.
E.g. @E-VANCE: The Trellis PHP version variable is used, but also the default PHP redis extension package is installed -
which means that sometimes also PHP 8.0 redis extension is also installed, an unnecessary extension when PHP7.x is still used.

@im-mortal
OK, I would be happy to co-maintain so let's collaborate on your fork. I'll get the PR ready asap.
@strarsis
Good point, will look into this once we have merged the forks.

@E-VANCE Thank you! I've sent you an invite for collaboration.

In the meantime, I've opened the pull request myself:
https://github.com/im-mortal/trellis-redis/pull/2
Due to some additional changes in the fork (which don't quite belong to the scope of the pull request), I welcome any discussion there.


Revert "Remove periodic single and multi-zone upgrade test jobs"

Reverts gardener/ci-infra#570
Now tests are more stable.
cc: @rfranzke

/kind test


When running hugo server, http is not prepended to localhost making a broken URL

What version of Hugo are you using (hugo version)?

$ hugo version
hugo v0.82.0+extended darwin/amd64 BuildDate=unknown

If you run, it will show a bunch of output:
hugo server -D
Start building sites …

                   | EN
-------------------+-----
  Pages            | 14
  Paginator pages  |  2
  Non-page files   |  1
  Static files     | 18
  Processed images |  0
  Aliases          |  4
  Sitemaps         |  1
  Cleaned          |  0

Built in 42 ms
Watching for changes in /Users/dglasser/developer/webdev/blog/{archetypes,content,static,themes}
Watching for config changes in /Users/dglasser/developer/webdev/blog/config.toml
Environment: "development"
Serving pages from memory
Running in Fast Render Mode. For full rebuilds on change: hugo server --disableFastRender
Web Server is available at //localhost:1313/ (bind address <IP_ADDRESS>)

But note the: Web Server is available at //localhost:1313/ (bind address <IP_ADDRESS>) which should have http://localhost:1313, otherwise it is pointing to a weird file path.
Does this issue reproduce with the latest release?
This is the latest release. I have not tested with master.

The baseURL in config.toml should be something like http://example.org/, not /. In the future please ask questions at https://discourse.gohugo.io/. We prefer to use GitHub to track bugs and enhancements.

It still seems like a bug that unless you prepend http(s):// to your baseURL it does not properly show http://localhost in output. base urls are generally not bound by their transfer type (http, https, tcp, ws, etc.) and that removing it removes the transfer type at the beginning.
IIRC the hugo server only serves over http, so it should always prepend http to the baseURL. I don't think it's ever right to leave the transfer type out, or replace it with a different one.


[12.1.x] ISPN-13116 SFS failures on upgrade from 11.0.9.Final -> 12.1.3.Final

https://issues.redhat.com/browse/ISPN-13116
https://issues.redhat.com/browse/ISPN-13128

I pushed a commit here that should fix the SingleFileMigrateCorruptTest test. The big thing was the header didn't write the new version, which actually meant it would migrate it every time, oops.

Also purgeOnStartup for the 12.1.bad version was set, which obviously doesn't work :)

:see_no_evil: That was never going to help! :smile:
Thanks for looking into this @wburns and good observation about expiration. Just adding a commit to fix checkstyle and get CI running.

Rebased. I've added you both as co-authors on the commit.

Integrated into 12.1.x, thanks @ryanemerson and @pruivo !


Removed not needed Avalonia.Desktop dependency for ScottPlot4

Like discussed in #2748.
@swharden @bclehmann @Xerxes004 @PremekTill
Works for ScottPlot4 as well.

Thanks @Fruchtzwerg94!
Don't worry about the failing autoformat check 😅
I'll fix the formatting CI job tonight then merge this in 👍

Note to self:
https://github.com/ScottPlot/ScottPlot/blob/e9dbc1dc29f069a221d0501a19f525bb7915a065/.github/workflows/autoformat.yaml#L32-L35
Break this step into two:

if: github.event_name == 'pull_request' - no token
if: github.event_name != 'pull_request' - token with push access


🐞 - Ionic Version 3 doesn't support Ionic Non-Standalone Ionic Apps

Which ngx-ui-tour-* package is the source of the bug?
ionic
Description
I've updated my Ionic App to use the latest version of Ionic [ 7.6.x ] and Angular 17. However, I'm not implement Ionic's standalone components yet because this would require a tremendous amount of effort to migrate all of the components in my application as it is very large.
With that said I still want to update to the latest version of Angular so that my dependencies aren't out of date.
The latest Ionic version of this library uses standalone Ionic components. But since my Ionic App is not setup to use standalone components this causes issues because I'm loading the IonicModule instead of the standalone components.
Ionic now providers a starter template for both "standalone" and "module" based applications.
Can we update the library so that it also supports both?
Angular version
17.x.x
Ngx UI Tour version
3.x.x
Which browsers have you used?

[ ] Chrome
[ ] Firefox
[ ] Safari
[ ] Edge

Which operating systems have you used?

[ ] macOS
[ ] Windows
[ ] Linux
[ ] iOS
[ ] Android

What issue exactly are you facing with the new version of the library in app module app? Can you provide some reproduction, errors you are experiencing?

BTW, they have a script to automatically convert non-standalone Ionic app into standalone. Have you tried it?

Actually, no I cannot provide any errors. There were none being thrown. The styles for the Ionic components were simply not being loaded.
As I've stated and confirmed with the Ionic team. If my Ionic application is setup to use angular modules, specifically the IonicModule and not Ionic Standalone components this will result in issues.
Since the updated ngx-ui-tour library for Ionic is using Standalone Ionic components and my Ionic application is not configured to use Ionic Standalone components this will cause issues and your library will not load correctly.
My application is very larger and contains a lot of nested child routes. The migration tools only get me so far and then I have to go in and fix issues related to routing, child routing and nested routers. I spent a day trying to migrate it all and was still running into issues at the end of that day.

In that case, you should be able to use the old version of the library with Angular 17 even the peer dependencies don't match.
I have no plans to maintain two separate versions of Ionic UI.

I'm pretty sure that when I try to install the older version it throws NPM errors. I'm fine with that, but I just can't install it.

Just use npm with --legacy-peer-deps. You can set it in npm config file as well.


Is there any exchange group about music generation research direction

I am a newbie who just started to study the direction of music generation, and I have a lot of confusion about this, so I hope we can communicate with each other

There is this discord server dedicated to musicgen if thats what youre looking for: https://discord.gg/aSTTaUfm


Add JIS(109-key) layout support

Supporting JIS keyboard layout.
Sorry, this is first time of sending pull request for me. And also my English is bad. :(
Many developers (mostly students) are learning about OS and Rust based on "Writing an OS in Rust" project which uses this crate in my country Japan.
And lots of them were confused about difference in keyboard layout.
So I tried to implement JIS keyboard layout which is commonly used in our country.
(If there is problem, please let me know!! I will try to fix it!!!)

I knew that there was also wrong code in README.md, so I want to also pull request this commit.
Wrong ) HandleControlPlusLetter
Correct ) HandleControl
Wrong ) HandleControlPlusLetter::MapToUnicode
Correct )  HandleControl::MapLettersToUnicode

I've just fixed few keys that wasn't on the right positions.
(Now it's all good.)

Hi! Thank you so much for this. I don't think I've ever even seen a JIS layout keyboard, so I'll have to take your word for it if you say it's correct!
With three layouts the file was starting to get a bit large, so if you see the jis_support branch I've just created, I've moved each layout into its own module. What would be really helpful for me is if you could determine how similar the JIS layout is to the US104 layout and if over half the keys are the same, perhaps you could do something like I've done for the UK layout where the 'different' keys are handled first, and for anything else it just defaults to the US layout. This will help keep the code size down and avoid duplication. It would also make it easier for you to support the handle_ctrl argument (which makes it so that pressing Control + C generates an ASCII 0x03, and likewise for Control + A all the way to Control + Z) because I think the JIS layout is just QWERTY for the roman letter keys, and therefore matches the US and UK layouts.
As an aside, would you expect a JIS keyboard driver to support hiragana input, or is that something best left to an application?

Thank you so much for your reply!!
I have just shortened layout.rs, and applied changes in jis_support branch.
(There was small mistake in uk105.rs, so I've just fixed that one too.)
I would expect that we can left hiragana input to application.
Because most people aren't using hiragana input on JIS keyboards these days, and it will make code size very large.

Nice


Doesn't work with Forge 31.1.47 or higher

I have tested this with Forge 31.1.51 and 31.1.59 and the mod didn't work on these versions. Also saw someone reporting that 31.1.47 doesn't work. It works on version 31.1.41 but on aforementioned versions all modes just trigger full bright mode (but with the correct name of the mode in the upper left corner).

Yes the problem persists...Please fix this.


Bumps version to 0.7.11

@nilskj are you okay with being mentioned in the changelog?

@nilskj are you okay with being mentioned in the changelog?

Totally okay! Happy to contribute


Fix site metadata not being crawled

Discord/Google embeds are always the default page, assumedly because it's not resolving markdown fast enough
There might be a fix at the bottom of issue #1235 in docsify

this might actually just be because we're using the og:title property, which isn't getting changed

Fixed with vitepress migration


Implementing the t-SNE algorithm

WIP
The tasks are:

[ ] Apply PCA on input data to bring dimensions down to 50
[ ] Hbeta method; which, for a given pairwise distance, calculates Gaussian kernel values
[ ] Complete the x2p method
[ ] Apply gradient descent
[ ] Write examples and remaining tests

Can someone with write access update these tasks in the "Projects" tab?
@SergeStinckwich I modified the structure of the class to include params and gradientDescentParams, please review it.
In future, if we create a seperate gradientDescent class/method, it will become easier to refactor. Also, if we want to include additional parameters, such as earlyExaggeration and earlyExaggerationIteration as suggested in FItSNE paper, having a dictionary will improve readability.
Should I use the new structure or continue with the old one?

Please review fcdd24ae8081b77239349540cf5ac0670e779378, especially the tests.
entropyOf:  andPRow:  withBeta: will automatically get tested when x2p method is completed and tests are written for x2p.

@SergeStinckwich regarding your two comments on the tests, I have:

Removed the obvious comment on tests
Removed self assert: pVector == pVectorRef. - I thought it was necessary, but it's not something that's needed.

@SergeStinckwich
Please review, the algorithm is complete and has been tested on small examples, I will test on MNIST tomorrow and show the results.

Here is one of the examples:
Input:

Output:

I don't know why a single guy is out of place, it is replicable over different runs

The speed is quite slow. Upon profiling, it looks like most of the time is spent on doing PMVector sum. Here is the profiler output:
 - 336067 tallies, 336072 msec.

**Tree**
--------------------------------
Process: (40s) Morphic UI Process: nil
--------------------------------
99.8% {335432ms} UndefinedObject>>DoIt
  99.8% {335432ms} PMTSNE>>start
    99.8% {335432ms} Job>>run
      99.8% {335432ms} BlockClosure>>ensure:
        99.8% {335428ms} Job>>run
          99.8% {335425ms} CurrentJob class(DynamicVariable class)>>value:during:
            99.8% {335425ms} CurrentJob(DynamicVariable)>>value:during:
              99.8% {335425ms} BlockClosure>>ensure:
                99.8% {335425ms} CurrentJob(DynamicVariable)>>value:during:
                  99.8% {335425ms} Job>>run
                    99.8% {335425ms} BlockClosure>>cull:
                      99.8% {335425ms} PMTSNE>>initializeJob
                        99.8% {335381ms} PMTSNE>>gradientDescent
                          99.0% {332802ms} PMTSNE>>computeGradient:withProgressUpdate:
                            93.5% {314071ms} PMMatrix>>sum
                              |93.4% {314036ms} PMVector>>sum
                              |  91.8% {308598ms} SmallFloat64>>+
                              |    |90.9% {305367ms} PMVector(Object)>>adaptToFloat:andSend:
                              |    |  90.8% {305162ms} PMVector(Collection)>>adaptToNumber:andSend:
                              |    |    90.7% {304947ms} PMVector(SequenceableCollection)>>collect:
                              |    |      51.2% {172224ms} PMVector(Collection)>>adaptToNumber:andSend:
                              |    |      39.5% {132723ms} primitives
                              |  1.2% {4178ms} SmallInteger>>+
                              |    1.2% {4161ms} SmallInteger(Integer)>>+
                              |      1.2% {4150ms} PMVector(Object)>>adaptToInteger:andSend:
                              |        1.2% {4114ms} PMVector(Collection)>>adaptToNumber:andSend:
                              |          1.2% {4105ms} PMVector(SequenceableCollection)>>collect:
                            2.3% {7676ms} PMTSNE>>computeLowDimensionalStudentT
                              |1.3% {4518ms} PMMatrix>>*
                              |  1.2% {3949ms} PMMatrix>>productWithMatrix:
                              |    1.2% {3949ms} PMMatrix>>productWithMatrixFinal:
                              |      1.2% {3918ms} PMMatrix>>rowsCollect:
                              |        1.2% {3918ms} PMVector(SequenceableCollection)>>collect:
                              |          1.2% {3916ms} PMMatrix>>productWithMatrixFinal:
                              |            1.2% {3914ms} PMMatrix>>rowsCollect:
                              |              1.2% {3905ms} PMVector(SequenceableCollection)>>collect:
                              |                1.1% {3676ms} PMMatrix>>productWithMatrixFinal:
                            1.0% {3398ms} PMMatrix>>rowsCollect:
                              1.0% {3390ms} PMVector(SequenceableCollection)>>collect:

**Leaves**
52.1% {175196ms} PMVector(Collection)>>adaptToNumber:andSend:
41.0% {137626ms} PMVector(SequenceableCollection)>>collect:

**Memory**
	old			-16,777,216 bytes
	young		+20,077,240 bytes
	used		+3,300,024 bytes
	free		-20,077,240 bytes

**GCs**
	full			1 totalling 141ms (0.0% uptime), avg 141.0ms
	incr		24140 totalling 5,099ms (2.0% uptime), avg 0.0ms
	tenures		40,165 (avg 0 GCs/tenure)
	root table	0 overflows

Any ideas for speedup of PMVector sum?


Support .ejsrc.ts and .ejsrc.mjs

Would be great to have support for config written in TypeScript or module js

Hello @alshdavid, that sounds like a great idea, however I personally recommend using JSON config files.


Delete all does not delete requests.

Deleting all doubles does not appar to delete the corresponding requests in the database which means that when you create another double you end up seeing the old requests since the numbering scheme appears to start again from 1.
Steps to reproduce:
rest-assured &
curl -d 'fullpath=%2Fapi' http://localhost:4578/doubles
curl http://localhost:4578/api
curl http://localhost:4578/doubles/1.json | jq .requests

At this point I see my request as would be expected:
[
  {
    "id": 1,
    "double_id": 1,
    "params": "{}",
    "body": ""
     ...
  }
]

Now delete all the doubles and create a new one
curl -X DELETE http://localhost:4578/doubles/all
curl -d 'fullpath=%2Fsomethingelse' http://localhost:4578/doubles
curl http://localhost:4578/somethingelse
curl http://localhost:4578/doubles/1.json | jq .requests

Now I should expect to only see my new request but actually I see the original one as well:
[
  {
    "id": 1,
    "double_id": 1,
    "params": "{}",
    "body": ""
...
  },
  {
    "id": 4,
    "double_id": 1,
    "params": "{}",
    "body": "",
    "created_at": "2018-02-26T19:43:17.941Z"
...
  }
]

So I think there are two problems.

The IDs of the doubles appear to get recycled - I'm not sure why but the code doesn't seem to explicity create the id field so I think this is some rails magic?
The call back to delete the children of the original double is not happening.  I think this is because you use Models::Double.delete_all rather than Models::Double.destroy_all.  According to the documentation "... Be careful with relations though, in particular :dependent rules defined on associations are not honored ..." (https://apidock.com/rails/ActiveRecord/Base/delete_all/class)

Unless you have an objection I propose to change the delete_all to be destroy_all.

Nice catch! destroy_all seems like the right thing to do.

Thanks @artemave it took a fair bit of digging to figure out what the issue was! PR submitted :)

New version is pushed to rubygems. Thanks @slukes !


Add postinstall script for apps under cfgov-refresh

Additions

Adds scripts/npm/apps-install/index.js script for running npm install on ./cfgov/unprocessed/apps/[app namespace]/package.json.

Testing

Throw out ./cfgov/unprocessed/apps/[app namespace]/node_modules
Run gulp build, get App dependencies not installed… message. (Do not follow message.)
Run npm install from the project root.
Re-run gulp build and check that ./cfgov/unprocessed/apps/[app namespace]/node_modules exists.

Why not leave it how it is, and just run  exec( npm --prefix ${ appsPath } install ${ appsPath } instead of writing to the console?

Also not directly related to this PR: Is there a way to bubble the App dependencies not installed, please run from project root: npm --prefix ./cfgov/unprocessed/apps/owning-a-home install ./cfgov/unprocessed/apps/owning-a-home message down to the bottom when the script completes? If you're looking away while gulp build runs, it's easy to miss.


Tiny little bug in blacklist ?

Hi,
I installed ldap2pg for testing, i don't want to synchronize all my roles and privileges with ldap2pg, but just manage named users on our database, assign to 2 roles : 'dba' and 'analysts'
So i look into the blacklist section and found this problem :
this works :
postgres:
  blacklist: [postgres, pg_*,bob_*,lol_*,twt_*, a*_ro]

this doesn't :
postgres:
  blacklist: [postgres, pg_*,*_adm,*_ro,*_rw]

And get me the following error :
Starting ldap2pg 4.6.
Using /home/perette/git/ldap2pg/ldap2pg.yml.
YAML error with /home/perette/git/ldap2pg/ldap2pg.yml: found undefined alias '_adm'
  in "/home/perette/git/ldap2pg/ldap2pg.yml", line 3, column 30

it seems the issue appear only if the wildcard is put  first  ? Or maybe i'm doing wrong something else :)

in fact like that, it works
postgres:
  blacklist: [postgres, pg_*,'*_adm','*_rw', '*_ro']

Ah, yes. A bare word preceded by * is a YAML alias.

@cbandy i added a mention on this gotcha in #200 . YAML error is obvious but still surprising.


Determine the needed K8S permissions that kubearmor needs to function properly

Feature Request
Short Description
Kubearmor is running as cluster admin, we should inventory the needed permissions and create a kubearmor role ( leeast privilege principle)
Is your feature request related to a problem? Please describe the use case.
fixes point 3 in https://github.com/kubearmor/KubeArmor/issues/733

I'd like to work on this issue!


svg2pdf: 0.7.1 -> 0.8.0

Diff: https://github.com/typst/svg2pdf/compare/v0.7.1...v0.8.0
Changelog: https://github.com/typst/svg2pdf/releases/tag/v0.8.0
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Thanks for the PR!


Setting SignatureMethod and DigestMethod  to SHA256

I have set 'signatureAlgorithm' => 'http://www.w3.org/2001/04/xmldsig-more#rsa-sha256'  for my SP. However, when create meta data XML. I still see the values as rsa-sha1 and not rsa-sha256 and sha256 respectively. My SP certificate has SHA256 as shown in the picture below. And the snippet of XML Meta data is below.   I'm setting the security options in same way as in advanced_settings.php. Anything else specifically needed to make sure of SHA256 instead of SHA1 for  signing SP requests?
<ds:Signature xmlns:ds="http://www.w3.org/2000/09/xmldsig#">
  <ds:SignedInfo><ds:CanonicalizationMethod Algorithm="http://www.w3.org/2001/10/xml-exc-c14n#"/>
    <ds:SignatureMethod Algorithm="http://www.w3.org/2000/09/xmldsig#rsa-sha1"/>
  <ds:Reference URI="#pfxb50d66b5-24bf-dbcf-b1e0-39ae44b7e0cf"><ds:Transforms><ds:Transform Algorithm="http://www.w3.org/2000/09/xmldsig#enveloped-signature"/><ds:Transform Algorithm="http://www.w3.org/2001/10/xml-exc-c14n#"/></ds:Transforms><ds:DigestMethod Algorithm="http://www.w3.org/2000/09/xmldsig#sha1"/>

.

There is a bug signing metadata.
The signMetadata method expects a $signAlgorithm parameter, but the toolkit is not providing it when calling the method at the Setting class.
We will fix it, meanwhile, can you try the patch yourself, just replace the Line 731 of lib/Saml2/Settings.php
$metadata = OneLogin_Saml2_Metadata::signMetadata($metadata, $keyMetadata, $certMetadata);

by the following code:
$signatureAlgorithm = $this->_security['signatureAlgorithm'];
$metadata = OneLogin_Saml2_Metadata::signMetadata($metadata, $keyMetadata, $certMetadata, $signatureAlgorithm);

Thanks. I tested it and it works. Please commit the fix to the next release,
krishna
  From: Sixto Martin<EMAIL_ADDRESS>
To: onelogin/php-saml<EMAIL_ADDRESS>Cc: krishnasathyanarayana<EMAIL_ADDRESS>Sent: Tuesday, March 22, 2016 10:11 PM
Subject: Re: [php-saml] Setting SignatureMethod and DigestMethod to SHA256 (#122)
There is a bug signing metadata.The signMetadata method expects a $signAlgorithm parameter, but the toolkit is not providing it when calling the method at the Setting class.We will fix it, meanwhile, can you try the patch yourself, just replace the Line 731 of lib/Saml2/Settings.php $metadata = OneLogin_Saml2_Metadata::signMetadata($metadata, $keyMetadata, $certMetadata);
by the following code:$signatureAlgorithm = $this->_security['signatureAlgorithm'];
$metadata = OneLogin_Saml2_Metadata::signMetadata($metadata, $keyMetadata, $certMetadata, $signatureAlgorithm);
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub


Two joined swipers occasionally vanish when transition with buttons

Check that this is really a bug

[X] I confirm

Reproduction link
https://paslay-group.flywheelsites.com/team/colleen-von-hoene/
Bug description
whenever you press the previous or next buttons, the slides vanish, but can appear again if you manually drag or press the previous or next button again
Expected Behavior
For the slides to not vanish
Actual Behavior
Slides occasionally vanish
Swiper version
8
Platform/Target and Browser Versions
Chrome on WIndows 11
Validations

[X] Follow our Code of Conduct
[X] Read the docs.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
[X] Make sure this is a Swiper issue and not a framework-specific issue

Would you like to open a PR for this bug?

[ ] I'm willing to open a PR

The link you provided doesn't illustrate the issue (at least I can't see it), would be good to see live isolated example with the issue in CodeSandbox


AppVeyor tests every commit in a PR rather than the latest

Take https://github.com/dart-lang/angular/pull/1515 for example. This was a rather large PR (in terms of number of commits). Taking a look at the AppVeyor History shows that every individual commit is queued up and tested, rather than skipping right to the latest commit of the PR.
Is this a shortcoming of AppVeyor, or is our https://github.com/dart-lang/angular/blob/master/appveyor.yml poorly configured?

I'll look into https://www.appveyor.com/docs/build-configuration/#rolling-builds, this sounds like what we want.

@kevmoo It looks like rolling builds can only be configured via the AppVeyor UI (similar to Travis). Could you please enable rolling build for our project?

Fixed – I think!


XML and JSON links in html are not copied to output.

manifest.json and browserconfig.xml should be copied to output but aren't.

This also affects icon files within these files.


Proposal to widen the scope of syllabus to DS in general

I think we should edit the guide so that it would be inclusive of topics in DS. Also please include some courses on Algorithms and data structures

@umairrafique85 cs50 already covers data structures.
@anasayubi i can add another section if you need ; i have a repo with data structure resources on java,python,c++


[move-prover] Update Prover to reject the programs with compile warnings

If the input program has compile warnings, Prover's model building step does not finish normally. So, Prover should stop the proving process, and produces the proper error message "exiting with model building errors".
This PR updates Prover to treat the compile warnings same as it treats the compile errors.
Resolves https://github.com/diem/diem/issues/8970.
Motivation
To fix the bug regarding the input programs with the compile warnings
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
cargo test

Interesting... it seems that when there are compiler warnings, the generated output.bpl does not have any code related to the move program and I am wondering why that happens...

Interesting... it seems that when there are compiler warnings, the generated output.bpl does not have any code related to the move program and I am wondering why that happens...

Yes we should definitely be able to run the prover when the compiler has warnings only, so bailing out on warnings is not the right solution, at least in the medium run.

The option 2 from @junkil-park's proposal (see issue #8970) is implemented in #8972. That version allows the prover to continue on programs with compiler warnings only but also allows the warnings to be printed after the model building phase, together with other model building issues and or prover errors.

Closing this. Handing over the baton to the Meng's PR (#8972).


Change STDC documentation

In anticipation of commit https://devdiv.visualstudio.com/DevDiv/_git/msvc/pullrequest/372495 preparing the doc changed going along with this.

@eldakesh-ms Which version of VS will this fix appear in?

I anticipate 17.2.

@eldakesh-ms : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#label:"aq-pr-triaged"

#label:"aq-pr-triaged"

Closing in favor of MicrosoftDocs/cpp-docs-pr/pull/4043.


Scripts cannot be loaded from additional C# projects.

Godot version
v4.0.3.stable.mono.official [5222a99f5]
System information
Windows 10 - Godot 4.0.3.stable
Issue description
Currently in Godot 4.0.3 you cannot have an additional C# project included in the solution with scripts. It would be nice for organization to allow multiple assemblies. As Godot uses source distribution for addons it would be very beneficial to allow csproj files to be included in this, so the csproj can define nuget/other references.
Assigning a script to a Node from another assembly results in this error at runtime:
Cannot instance script because the associated class could not be found. Script: 'res://SecondaryCsproj/ScriptB.cs'. Make sure the script exists and contains a class definition with a name that matches the filename of the script exactly (it's case-sensitive).
I would expect it to load normally in the same way as other scripts in the project.
This may be related to #75352 but is not the same issue, the issue described by that ticket seems specific to runtime loading of assemblies.
Steps to reproduce
In the attached reproduction project I have created a second C# project in the solution and excluded the contents from the main project. It may be beneficial to allow the main csproj to occupy a subfolder instead of being required in the root of the project to avoid the necessity of excluding other csproj's source.
Just open the main scene and run, note that ScriptA executes normally, ScriptB fails to load.
Minimal reproduction project
MultipleCsprojBugReport.zip

It is the same underlying cause as the linked issue, currently scripts are fundamentally only looked up in the main assembly, so the same enhancement will likely enable both use cases.

I've added this to my external project, I tested that abstract node with _Process are called when inherited by the main godot project, and it worked.
  <ItemGroup>
    <PackageReference Include="Godot.SourceGenerators" Version="4.1.1"
					  OutputItemType="Analyzer"
					  ReferenceOutputAssembly="false" />
    <PackageReference Include="GodotSharp" Version="4.1.1" />
  </ItemGroup>

  <PropertyGroup>
	<GodotProjectDir>$(MSBuildProjectDirectory)</GodotProjectDir>
  </PropertyGroup>

Whether or not its accidental that this is possible im not sure. I figured that the same source generators that provide the event method metadata for the main project could be used on an external one. GodotProjectDir is mandatory though.
This might solve the issue on https://github.com/godotengine/godot/issues/75352

Does this issue still exist? Is there a work around?
Can scripts in other assemblies be manually registered with godot?

Closing to consolidate in #75352.


Adding support for font styles

This suggestion is about adding support for font styles, i believe right now, the font manager in SP5 is hard coded to look at "normal" weight fonts, but if a font has some other settings, they won't get recognized by SP5.
For example, these are different weights supported by windows
https://learn.microsoft.com/en-us/dotnet/api/system.windows.fontweights?view=windowsdesktop-8.0
so hard coding to look for "normal" or "regular" can exclude various font families.
similar to css supporting various font-weight vs font-style.
for example, i think sp5 has an issue with Arial Narrow
https://learn.microsoft.com/en-us/typography/font-list/arial-narrow

I'm in favor of adding this feature, but there hasn't been movement here in a while so I'll close this issue for now and we can take a closer look in the future. If someone wants to create a PR to add this in, I'd be happy to review it in good time!


Fix error "Cannot read property 'Documentation' of undefined"

Monkey patch for #561

LGTM!  Thanks!


[stable/locust] add options for headless

Also removing liveliness probe as I don't think it's ever useful to have the master restarted.
Add separate env vars for master/worker
Add doc for master/worker args

Resolves https://github.com/deliveryhero/helm-charts/issues/108
Checklist

[x] Title of the PR starts with chart name (e.g. [stable/mychartname])
[x] Github actions are passing

Hi Max, thank you for your work to add headless mode support in the chart.
I have tested this PR, both in non-headless and headless mode.  Based on what we have here, we need to support more test configurations binding to --headless. The chart now only allow users to do it via environment variables (loadtest.environment).
So I think it is really necessary for us to split loadtest.environment into master.environment and worker.environment. In this way, we can support something like this:
helm install my-release ./ \
  --set worker.hpa.enabled=true \
  --set worker.replicas=3 \
  --set loadtest.headless=true \
  --set master.environment.LOCUST_SPAWN_RATE=10 \
  --set master.environment.LOCUST_USERS=100 \
  --set master.environment.LOCUST_RUN_TIME=1m \
  --set master.environment.LOCUST_EXPECT_WORKERS=3

Acctually loadtest.headless can also be replaced by master.LOCUST_HEADLESS and worker.LOCUST_HEADLESS, but this is purely optional and the current way seems just fine.
Once again great work Max! And I hope this helps.

So I think it is really necessary for us to split loadtest.environment into master.environment and worker.environment

OK done
I think you can also achieve what you want by using the args instead of env vars, but this wasn't documented in the README, so I've added it.
Let me know if it works 🙂

@max-rocket-internet Hi Max, I have tested it with env vars. Everything looks great.
However I don't know how to use args to install the chart, can you please provide with an example like this?
helm install my-release ./ \
  --set worker.hpa.enabled=true \
  --set worker.replicas=3 \
  --set loadtest.headless=true \
  --set master.environment.LOCUST_SPAWN_RATE=10 \
  --set master.environment.LOCUST_USERS=100 \
  --set master.environment.LOCUST_RUN_TIME=1m \
  --set master.environment.LOCUST_EXPECT_WORKERS=3

Thank you!

Hi @lsl-2020

I have tested it with env vars. Everything looks great.

Cool, let's merge then.

I don't know how to use args to install the chart, can you please provide with an example like this?

By args, I meant locust command args. So if you use a chart values file like this:
master:
  args:
    - --headless
    - --users=1000
    - --spawn-rate=0.3

Then the locust master will be started like this:
locust --master - --locustfile=/mnt/locust/xxx --host=xxx --loglevel=xxx --headless --users=1000 --spawn-rate=0.3

This is templated here: https://github.com/deliveryhero/helm-charts/blob/master/stable/locust/templates/master-deployment.yaml#L45-L53
All the best!

Hi Max,

By args, I meant locust command args. So if you use a chart values file like this:
master:
  args:
    - --headless
    - --users=1000
    - --spawn-rate=0.3

I was asking how to specify args when using "--set" in command line. But I guess using values.yaml as you mentioned above is a better way. Btw I have already tested it :-)
Thanks for the great work!


[Bug] False positive and false negative messages displayed while system handles incorrect variable naming for a GSheets datasource

Description
False success and failure messages displayed when user follows incorrect variable naming convention for datasource on Google Sheets.
Steps to reproduce the behaviour:

Go to add datasources, add and authorize Google Sheets
Go to 'create new query' and type in a query name that begins with a number
Run the query
App displays an error for naming convention (expected behaviour)
Edit query name to add alphabets at the start to follow naming convention and click 'Run' - still displays an error (false negative)
Click on 'Run' again - displays response and success message (expected behaviour)
Edit name again to remove the added alphabets and hit 'Run' - displays success message and 'Logs' republishes the same json response from step 6 (false positive)

Important Note
Method 'List Sheets' in query does check for naming convention - unsure if this is a requirement hence no errors are displayed and this scenario is void for the method.
Important Details

Version: Cloud
OS: Windows 10
Browser: Chrome
Environment: production
https://www.loom.com/share/aed0b0acf8bc436785b4ede03e607ca9

@nidhi-nair could you have a look at this?

Multiple issues here, which is applicable for all query editors:

The refactor call is made after the execute call on button click Run. So the false positive happens because the execution happens with the old valid name, and then the refactor happens.
The refactor itself should fail at UI level with the same rules as the backend is failing this execution for
The backend should have also returned with an error for the refactor call.

@ajinkyakulkarni I'll pick up # 3 from the above, but the others look like client side changes. Could you please help?

Unassigning myself from this issue since the backend fix for this has been merged. Please feel free to bring me back in if anything more is required.

Let's close this. I just checked and all rename calls are only checked from the backend there's no frontend validation


Tailwind 3 & Footer alignment

Great contribution, thank you! Only thing: the green is somewhat "greener" now :thinking:.
Before: #047857
After: #15803D
Could you please fix that, as the original green has kind of become part of Wakapi's "CI". Feel free to merge yourself afterwards.


Line height

I might be missing it but is there an option to set the line height? I just switched from cotEditor to SubEthaEdit and it feels snappier for me (both editors are great though). i'm missing a feature to set the line height though.
Anecdote, I used to use SEE when it just came out an eternity ago. Nice to have it again.

Just to be curious: what is the range you would like to change the line height? And in what unit?

I have set it to 1.2 times whatever times it refers to. em? So anything between 1 and 1.5 is probably a nice to have and easier on the eye.
I made a screenshot for comparison.

Doing it this way now:

That looks incredibly beautiful. Nice solution and thank you very much!

@hmt please do try the pre release version at https://subethaedit.net/Releases/SubEthaEdit-5.2.1-9757.zip if that fulfills your wishes. It might be some time until the final 5.2.1 is released if there aren't any major issues with 5.2

It's perfect. Just works as expected. Thank you.


Add support for BMP

Hello,
MimeMagic.by_magic(bmp_file) respond me invalid/invalid content_type
when file --mime-type -b bmp_file respond me image/bmp
I've found a workaround by doing this:
[ [ 'image/bmp',
    { magic: [[0, "BM", [[0..2, 'BM']]]], extensions: %w[bmp], parents: %w[], comment: 'BMP' } ]
].each do |magic|
  MimeMagic.add(*magic)
end

(if someone can check the validity of this for me)
If you (little github user) encounter content_type invalid/invalid issues, I've found the solution on wikipedia:
https://en.wikipedia.org/wiki/List_of_file_signatures

Invalid, this should be fixed in the shared-mime-info database upstream.

Invalid, this should be fixed in the shared-mime-info database upstream.


webhooks: Improve test coverage and fix minor bugs.

@timabbott: FYI :)

Merged, after discussion offline. Tim: would be good to get a post-merge review when you get the chance.

Seems generally reasonable, thanks for dealing!  It's great to have so many files moved off the "incomplete coverage" list.


training on 2 GPUs

I am training trying to train your model on 2 GPUs as shown in your script.
scripts/train_r2plus1d_kinetics.sh
Is it right that epoch size is 1M? Will I be able to reproduce your result in table 2 of paper using that script? I would just need to change the model type?

Another question about optimization step. Does parameter update by SGD is done every iteration or 64 training clips in case of 2 GPUs? Or is there any other of asynchronous implementation of SGD is being used?

yes (at the end of page 5: " Although Kinetics has only about 240k training videos, we set epoch size to be 1M for temporal jittering"). You supposed to get those numbers in table 2 using test_net.
yes.

Thank you very much for your reply.
I am trying to reproduce your results from Table 2 in Pytorch. I am starting form R3D model.
Base model type is resnet 18.
Input transformations are the random crop to the entire input sequence, random horizontal flip, and normalisation with mean and std. Am I missing something?
You mentioned temporal jittering, what is that?
Many thanks,
Gurkirt

Also, where are input transformations are specified in this code?

I am training the networks from scratch like you and see if I can reproduce your results using just 2 GPUs?

you should be able to do so. The transformations are implemented in VideoInputOp in caffe2 (pytorch).


Use also key opening_hours:covid19

During these weeks of lockdown it's perhaps very useful to parse also key opening_hours:covid19 for showing opening hours - as already suggested here https://twitter.com/sfkeller/status/1245838357135065099 .
The docs about key opening_hours:covid19 are here https://wiki.openstreetmap.org/wiki/Key:opening_hours:covid19 and there's following web app which displays it already - but only for France: "Ça reste ouvert" https://www.caresteouvert.fr/ (repo: https://github.com/osmontrouge/caresteouvert ).

We are already using these tags opening_hours:covid19 and description:covid19 for points of interest located in France, with a direct link to caresteouvert.fr in order to promote contribution to the project.
There would be little technical difficulty to use these tags in other countries. But displaying relevant information, in compliance with local legislation and recommendations is more challenging.
We will do our best.

@amatissart Any update on this? I don't see how it'd violate local legislation in other countries.


Proposal: add DOCKER_MACHINE_NAME in machine env

Goal: add following line when execute machine env dev
export DOCKER_MACHINE_NAME=dev

Why?
When we want to control more than more machine in the same time, we need to open several terminal tabs, set the different env for each tabs, and switch between these tabs. It's easy to forget where we are. Currently, we can use export | grep DOCKER_HOST to see which host we are using. However, sometimes they are only the ipv4/ipv6 addresses and hard to remember.
To release this pain, I propose that we can add a new environment variable DOCKER_MACHINE_NAME so that we can get it by export | grep DOCKER_MACHINE_NAME.
Moreover, we can set $PS1 as something like
export PS1="(\$DOCKER_MACHINE_NAME) \W \u$ "

Then the machine name will always be displayed in the bash promt.
I know that sometimes active drifts from DOCKER_HOST, but I'd rather fix that issue directly than introducing additional complexity to env.

Hi @nathanleclaire thank you for the feedback.
In my case, I manipulate more than one docker hosts in different terminal tabs in the same time. But we can only have an active machine. Any thoughts for fixing this issue?

I use tmux to switch~~~ :)

I think without getting hung up on the specific shell configuration, I like the idea of having more info about the active settings in the environment.  I'm not sure it adds too much complexity -- simply another export to env.

I prefer adding machine name as an env variable because its something like the primary_id in the database. We could use this name to query other information by the docker-machine command (maybe a machine restful server in the future)

In my case, I manipulate more than one docker hosts in different terminal tabs in the same time. But we can only have an active machine. Any thoughts for fixing this issue?

Ah, I see.  I'm in favor of another environment variable in env for this purpose, and if we do something like https://github.com/docker/machine/pull/777 too "active" will be tracked transparently and you will be able to have different "active" hosts in different windows.

I was bored... so I implemented this in #1175 :smile:


Add liveness tracking to LazyTensor

Tracks list of LazyTensorOperation instances held in LazyTensor instances. This is required to perform batch materialization of all live tensors during lazy evaluation.

@rxwei Thanks for the review. I addressed your comments. PTAL.


automate etcd image mirror release

introduces a simple circle ci workflow that can be run on demand. Also start a documentation for all circle ci work since its starting to get larger. this allows for anyone to update etcd images in our pachyderm repo with reproducible steps rather than hunting down or guessing who did what from where. postgresql and pgbouncer steps/instruction to follow this PR.
kubeevent tail will most likely be merged into the pachd process instead of maintaining yet another "vendor" image.
CORE-807

@chainlink got time for another review?


[Bug]: Move to Postgres - GCP URI - Performance issues

Is there an existing issue for this?

[X] I have searched the existing issues

Description
We are noticing performance issues while doing basic actions such as creating applications, adding queries/JS Objects, deleting application & workspaces.
Steps To Reproduce

Pull this image: appsmith/appsmith-ee:pg
After the image is up and running go to Advanced section in Settings and replace the Appsmith DB URI with the GCP URI.
Perform basic actions such as creating applications, adding queries/JS Objects, deleting application & workspaces.

Expected: There should be no performance lag & the time taken to perform all these actions should be on par with release.
Public Sample App
No response
Environment
Deploy Preview
Severity
High (Blocker to building or releasing)
Issue video log
https://jam.dev/c/4417ff82-a952-4388-b878-33261b000ca4
Version
Self hosted

@AnaghHegde just like we have expected this morning. Please take a look into this.

FYI @AnaghHegde performance issues are also being seen on git actions

The time difference seen
Generate page  took 6.86s, while on release it takes 1.64s
New page - 1.85s, while on release it is 213ms
New DS Save and authorize click on. gsheets - 1.98s, while on release it is 254.94ms
Create new application - 3.01s, while on release it is 472.36ms
Import action to bring up the modal for a json file: 10.04s, while on release it is 1.13s for the same file

As per Anagh we are seeing the connection pool limit reached exception which is causing the DBOps to queue. We have reached devops to check tghe connection limit set on GCP to verify if this is the issue.

@RakshaKShetty @shadabbuchh let's retest this as we have moved the DB and VM with same provider, in same region.
DP: http://<IP_ADDRESS>/applications

Verified actions such as creating applications, adding queries/JS Objects, deleting application & workspaces. The performance seems to have improved & is now at par with release. However there is still some lag in performance when trying to delete bigger applications: https://jam.dev/c/02eec56a-aaa6-4dd7-971b-0b4cfd00399f
Time taken to delete an app in release:

Time taken to delete an app in the new DP:

@RakshaKShetty Are we good to close this issue? The performance is on par with release.

@AnaghHegde Did we fix the slowness seen on Delete application

@RakshaKShetty Can you check the dp now?

@AnaghHegde the delete performance issue is still reproducible in the DP. Also I see the error on importing apps that was fixed couple of days ago:
https://jam.dev/c/17df82b5-c3d1-4d10-8e2e-0581596c8370

@shadabbuchh The delete issue is fixed in 4517. The gcp instance does not have latest code. Its the same since last week. I am not sure why the import is failing now.

Tried it on 4517 as well. There seems to be a lag in deleting the apps:
https://jam.dev/c/1f7c54c1-3f0a-48ee-9eae-fe9cddd45520
DP:

Release:

#36650 can be used to tackle the performance issues.


Task description in Key distribution Kata is not correct

I found that tasks 2.4 and 2.5 in the Key Distribution Kata are a bit confusing, and I wanted to make a few suggestions as a researcher in QKD.
Firstly, task 2.5 is not verifying that the key is secure. Task 2.5 really is just checking the error rate/key yield of the raw key exchange process. The error rate is one of multiple parameters and assumptions that go into verifying if the key is secure.
Secondly, it seems to make more logical sense given 2.5 calculates an error rate to swap the order of 2.4 and 2.5 since 2.4 currently yield the distilled key and would come at the very end of any classical post processing steps.

I agree, task 2.5 could use a better task title.
It might be the case that task 2.4 needs a better title and details as well, but I'm not sure they should be swapped. Right now 2.4 filters out the measurement results where measurement basis used by A and B don't match; in the end-to-end scenario this has to happen before task 2.5 in which A and B use subsets of the results of filtering to calculate error rate.
(Sorry for the delay replying! Last week was crazier than usual, and I haven't looked at this kata for a while... I really hope to catch up with the issues and pull requests this week!)

I'll take a stab at a new task title and leave the order alone for now.

Closing per #297.


Fixed Quill v2.0.0-dev.4 implementation

Hi,
Here is the link to my the build - https://github.com/artknight/quill-mention/tree/master/dist. I did not do a fork (as I probably should have) so my repo is just a clone. However, all issues with v2 are fixed!
Feel free to implement it, port it over :)

Give this guy a medal! Thousand thanks.

@artknight can you raise a PR to make it easy to get your changes accepted upstream?

@artknight How about I give you access as contributor, and you implement your changes here?

Thank you so much !

@MadSpindel I am ok with being a contributor to this repo, and getting my changes in.


Train the model with custom dataset

🚀 The feature
Hello,
Can you guide me how to train the doctr model for text detection and recognition using a custom dataset?
Thank you for your guidance
Motivation, pitch
I am working on persian and English text detection and recognition in the images.
Alternatives
No response
Additional context
No response

Please take a look at: https://mindee.github.io/doctr/using_doctr/custom_models_training.html
:)


SpringBoot java.lang.UnsatisfiedLinkError: C:\Users*.pytorch\cache\1.4.0-20200327cpu-win-x86_64\fbgemm.dll: Can't find dependent libraries

Description
I use pytorch as engine,the version is 0.5,firtsly 1.4.0/fbgemm.dll is not exist,i download 1.5.0 manually,and install Visual C++ Redistributable Packages still not working
Error Message
java.lang.UnsatisfiedLinkError: C:\Users\sn78083.pytorch\cache\1.4.0-20200327cpu-win-x86_64\fbgemm.dll: Can't find dependent libraries
POM:
    <dependency>
        <groupId>ai.djl.spring</groupId>
        <artifactId>djl-spring-boot-starter-pytorch-auto</artifactId>
        <version>0.5</version>
    </dependency>

    <dependency>
        <groupId>ai.djl.spring</groupId>
        <artifactId>djl-spring-boot-starter-autoconfigure</artifactId>
        <version>0.5</version>
    </dependency>

Could you please check if fbgemm is there. If not, could you please try to install a visual studio 2017 to get the most up-to-date vc compiler? I will take some time to investigate the issue you have.

@hackedbyxx
Your dependency looks fine, most likely still related to VC++ redistributable package version.
Would you please try the sample application: https://github.com/awslabs/djl-spring-boot-starter/tree/master/djl-spring-boot-console-sample
I just tried on a fresh Windows (with VC++ 2019 pack), and changed dependency to pytorch, it works fine for me.

Could you please check if fbgemm is there. If fbgemm is there, could you please try to install a VC++ 2019 redistributable package (https://github.com/awslabs/djl/blob/master/docs/development/troubleshooting.md#3-build-fails-on-windows-caused-by-unsatisfiedlinkerror) to get the most up-to-date vc compiler? I will take some time to investigate the issue you have. You can also use Depedency Walker to figure out what are the missing piece in the dependencies. You can bring a screen shot after doing so and we can help you with this information provided

I've tried to install VC++2019 and reboot,it does not work,i think the problem is i cant't download dll of pytorch, it seems the remote websites doesnt have  1.4.0-20200327cpu-win-x86_64\fbgemm.dll matched.I just find and download 1.5

@hackedbyxx
Your dependency looks fine, most likely still related to VC++ redistributable package version.
Would you please try the sample application: https://github.com/awslabs/djl-spring-boot-starter/tree/master/djl-spring-boot-console-sample
I just tried on a fresh Windows (with VC++ 2019 pack), and changed dependency to pytorch, it works fine for me.
i've install VC++ 2019 pack,I've tried mxnet,it works ok,but pytorch not work well

@hackedbyxx
Your dependency looks fine, most likely still related to VC++ redistributable package version.
Would you please try the sample application: https://github.com/awslabs/djl-spring-boot-starter/tree/master/djl-spring-boot-console-sample
I just tried on a fresh Windows (with VC++ 2019 pack), and changed dependency to pytorch, it works fine for me.

i've install VC++ 2019 pack,I've tried mxnet,it works ok,but pytorch not work well

@hackedbyxx
Would you please try to clean your pytorch cache directory: C:\Users*.pytorch\cache\1.4.0-20200327cpu-win-x86_64
and try to run our examples project from DJL repo:
cd djl
gradlew :examples:run -Dai.djl.default_engine=PyTorch -Dai.djl.logging.level=debug

It should print out more debug informations about loading pytorch engine
If that doesn't work
cd djl
gradle debugEnv -Dai.djl.default_engine=PyTorch

above command can print more information about your system configuration.

@hackedbyxx Would you have the chance to try out the above comment?

I have seen this issue with NiFi, I get an issue if two apps/processors/microservices use the same library (say both use Pytorch)

@hackedbyxx Any updates, do you still have this issue? @tspannhw as well

close the stale issue. @hackedbyxx feel free to reopen it

close the stale issue. @hackedbyxx feel free to reopen it


Speedup for rolling functionality, support for uneven/latlon grids, testing/CI, and small changes

Major changes:

Speed-up from numpy.roll
numpy.roll is relatively slow since it makes copies of the original array, so the rolling (or padding) functionality is now handled iteratively with indexing to shift the array with or without replacement, depending on the boundary conditions. The example below is the case for periodic boundary conditions.
for i in range(10):
    xroll[:i] = x[-i:]
    xroll[i:] = x[:-i]
    adv_E_roll[:, :i] = adv_E[:, -i:]
    adv_E_roll[:, i:] = adv_E[:, :-i]

Support for more grid types (rectangular, uneven spacing, latitude-longitude)

This support is primarily handled through function arguments.
Rectangular grids will result in binned structure functions and separation distances for the zonal direction only

Number of bins can be set as a function argument

In the future we could rebase to a more class-based structure.

Set up continuous integration with GitHub Actions to test and check formatting

Using pytest for testing modules. Currently only testing calculate_velocity_advection with very simple test cases.
Using Ruff as a linter with black as the formatting standard.

Miscellaneous updates

Dictionary data output
Gradient calculation updates throughout advection modules and structure function modules

Clear next steps related to these updates

Rectangular grid support for the meridional direction
More testing for the latlon and uneven grids -- still somewhat a work in progress
Work on getting the linter to pass
Add additional pytest tests for other modules.

I updated the main title and content of this pull request to include some information about new continuous integration with GitHub Actions to check the formatting and use pytest to complete some initial tests on multiple machines.
This is an addition I'm very excited about! The pull request is a bit bulkier now, but the CI tests and formatting will be very helpful to maintain this software package and encourage collaboration! 🎉


Sharing save/load tricks (DRY, WASM)

Hey @thebracket! Thank you for the amazing library and book, I'm having a blast following along. This is not so much an "issue", but rather sharing what I learned in case you want to use it in the book at some point. I'll do it tl;dr style to respect your time:

I've added saving / loading under WASM in https://github.com/abesto/rktrl/commit/b0da9c00125ba9bc2335f0403576b28e56c063f5. Basically it uses local storage (base64 encoded, because I GZip the saved file on the cross-platform code path).

FWIW, the sentence "Supporting saving via LocalStorage (a browser/JavaScript feature) is planned for a future version of RLTK." confused me for a second - RLTK doesn't explicitly support saving / loading outside the browser either, it's all serde and specs (AFAICT at least).

Reaching for increasingly big hammers, I managed to set up a procedural macro so that for the save / load systems there is zero repetition of the components (check out the macro and its usage). The big idea here is using the macro to split the tuple of components into chunks of at most 16, so that we can then rely on the the specs_derive-provided implementations for those.

I'm toying with the idea of creating a similar macro to cut down on the boilerplate involved with creating system data structs (but that's less relevant as currently the tutorial doesn't use them)

Getting things to compile for WASM in the first place was a bit tricky as dependencies pulled in parallel Specs features in their default-features, which trigger threading. Had to disable them in cargo.toml (see https://github.com/abesto/rktrl/commit/72a7a119385ca6ae5c6871dd31d281ba842d0ffe). I guess there might be a better way of doing this (maybe controlling whether a parallel dispatcher is used from code).

Finally, I wanted to add that I know how overwhelming input about big huge changes to writing projects can be, so wanted to explicitly say: no pressure, take these when and if they're useful. Even until then, maybe this will in itself be useful for someone else. Thank you again!

I ended up implementing a macro for generating SystemData structs with ~zero boilerplate. At some point I might try to contribute this properly into Specs; for now, I'll just link to it here so it's shared somewhere.

Definition: https://github.com/abesto/rktrl/blob/master/rktrl_macros/src/lib.rs#L129
Complex usage example: https://github.com/abesto/rktrl/blob/master/src/systems/spawner.rs#L21-L48


GridFunction::ProjectBdrCoefficient for L2-space

Hello,
I am trying to project a coefficient onto the boundary of a GridFunction defined for an L2 finite element space. My plan is to then use this grid function in a GridFunctionCoefficient to weakly enforce Dirichlet boundary conditions in my solver, where I can just update the underlying grid function and re-assemble my LinearForm. Currently, ProjectBdrCoefficient leads to a segfault when used for a GridFunction defined on a L2-space. I am very new to finite-element (and DG), so if I am trying to do something that makes no sense, please just let me know.
I've been able to track the segfault to the method void GridFunction::AccumulateAndCountBdrValues, where it occurs due to fdof = fe->GetDof();, where fe is actually a nullptr returned via the previous line fe = fes->GetBE(i);. I noticed in the construction of L2_FECollection, L2_Elements[Geometry::SEGMENT] is indeed not set for dim != 1, so it makes sense that it would segfault. Ultimately, I guess my question is if the construction of the L2_FECollection should be using if statements like in the H1_FECollection where inclusion of segments is done for if (dim >= 1), or if there is indeed a limitation for returning border elements in L2 spaces that I am not aware of.
In case this is something that might be worth adding, I have included a minimal example below as well, which uses the beam-quad.mesh from MFEM's data directory.
#include <mfem/mfem.hpp>

int main(void) {
  mfem::Mesh mesh("beam-quad.mesh", 1, 1);
  mfem::L2_FECollection fe_collection(2, 2);
  mfem::FiniteElementSpace fespace(&mesh, &fe_collection);

  mfem::GridFunction gf(&fespace);

  mfem::Array<int> bdr_marker(mesh.bdr_attributes.Size());
  bdr_marker = 0;
  bdr_marker[0] = 1;
  mfem::ConstantCoefficient one(1.0);
  gf.ProjectBdrCoefficient(one, bdr_marker);

  return 0;
}

Hi @robert-chiodi ,
Let me just start by saying that the ProjectBdrCoefficient is designed to work for the H1 space where the trace is mathematically well defined. For the L2 space this is not the case. For an L2 space you can weakly enforce Dirichlet boundary conditions using DGDirichletLFIntegrator. A simple example for DG diffusion with non-homogeneous Dirichlet BCs can be found here: https://github.com/mfem/mfem/blob/1155c003a8e8c6eeaa1287414db4f0df0c63748c/tests/convergence/rates.cpp#L192-L200
I hope this helps.
Best,
Socratis

Hi @robert-chiodi ,
Let me just start by saying that the ProjectBdrCoefficient is designed to work for the H1 space where the trace is mathematically well defined. For the L2 space this is not the case. For an L2 space you can weakly enforce Dirichlet boundary conditions using DGDirichletLFIntegrator. A simple example for DG diffusion with non-homogeneous Dirichlet BCs can be found here: https://github.com/mfem/mfem/blob/1155c003a8e8c6eeaa1287414db4f0df0c63748c/tests/convergence/rates.cpp#L192-L200
I hope this helps.
Best,
Socratis

Yes, it does, thank you very much. I have been really enjoying MFEM but still have much to learn!

Yes, it does, thank you very much. I have been really enjoying MFEM but still have much to learn!


main_plan.py cannot run multiprocessing program, i.e., num_workers >0. When I set num_workers = 0, there are some bugs.

I fixed the bug while using num_workers = 0, but you have data types unmatch problem between the input data and the weights of the model in the encoders.

highest_return_idx does not match the dimension of start_poses

Could you please make sure your code runs properly if you want others to use and compare against? Thanks :)

Hi,
Thanks for your interest in our project. Can you detail the command you run, and the corresponding error message?

I ran the command
python VCD/main_plan.py --edge_model_path <provided pretrained model> \
   --partial_dyn_path <provided pretrained model> \
   --num_worker 0

on a square fabric simulated environment.

When I ran
python VCD/main_plan.py --edge_model_path <provided pretrained model> \
   --partial_dyn_path <provided pretrained model>

I got error
Traceback (most recent call last):
  File "VCD/main_plan.py", line 386, in <module>
    main(get_default_args())
  File "VCD/main_plan.py", line 273, in main
    = planner.get_action(data, cloth_mask=cloth_mask)
  File "/home/ah390/project/VCD/VCD/rs_planner.py", line 184, in get_action
    results = self.pool.map(self.dynamics.rollout, params, chunksize=max(1, pick_try_num // self.num_worker))
  File "/home/ah390/anaconda3/envs/softgym/lib/python3.7/multiprocessing/pool.py", line 268, in map
    return self._map_async(func, iterable, mapstar, chunksize).get()
  File "/home/ah390/anaconda3/envs/softgym/lib/python3.7/multiprocessing/pool.py", line 657, in get
    raise self._value
  File "/home/ah390/anaconda3/envs/softgym/lib/python3.7/multiprocessing/pool.py", line 431, in _handle_tasks
    put(task)
  File "/home/ah390/anaconda3/envs/softgym/lib/python3.7/multiprocessing/connection.py", line 206, in send
    self._send_bytes(_ForkingPickler.dumps(obj))
  File "/home/ah390/anaconda3/envs/softgym/lib/python3.7/multiprocessing/reduction.py", line 51, in dumps
    cls(buf, protocol).dump(obj)
_pickle.PicklingError: Can't pickle <class 'torch_geometric.deprecation.DataLoader'>: attribute lookup DataLoader on torch_geometric.deprecation failed
[W CudaIPCTypes.cpp:15] Producer process has been terminated before all shared CUDA tensors released. See Note [Sharing CUDA tensors]

Hi @halid1020 could you please provide more details about how you solve the problem? We are having the same issues. Thanks!


Adding a checkpoint system? (Related to #51)

I was browsing around for other daily puzzles to do, and on this website I discovered puzzles with a checkpoint system (hidden behind "Show checkpoints" in the little settings wheel at the top). I like the way it's implemented, and I've been thinking about how useful this would be for hexapipes.
When a daily is particularly difficult, I like to do some exploratory locking of promising tiles to see if I reach a contradiction to rule out one of their sometimes only two possible orientations. It's dangerous to lock and unlock tiles like this, because I might lose track of which tiles are genuinely locked, and which ones just have an exploratory temporary lock.
A checkpoint system would take care of this, without necessarily having to do a full undo/redo stack. A complete state is stored as-is and then simply restored whenever the user wishes. The timer should of course remain untouched!
I saw that it was mentioned here, but feel like it deserves its own issue.

May 22 octagonal was brutal, wasn't it? =)
The problem I usually have with checkpoints on that site is that by the time I find a contradiction I've already forgotten my initial assumption. Then it's like - ok, state restored but what exactly did I learn? :thinking: So some indication of how the trial started could be really helpful too.
I have undo/redo stack implemented somewhere in an unpublished branch, maybe I'll have some free time to finish that in a month or two. Then I'll think about checkpoints as well, thanks for the suggestion =).

May 22 octagonal was brutal, wasn't it? =)

Haha exactly why I opened this issue!

by the time I find a contradiction I've already forgotten my initial assumption.

I'm the kind of person to just write it down on a notepad in front of me, but an actual solution could be to highlight the first change made after creating a checkpoint.
Say I create a new checkpoint and then lock a tile and later find a contradiction. Then I load the checkpoint, and the tile I first locked gets highlighted.
Having an undo/redo stack would also be amazing!


Improve Package.swift not found diagnostic error SR-14829

Improve Package.swift not found diagnostic error
Motivation:
The current error message when running swift-build in a folder that has no Package.swift file is not descriptive enough.
SR-14829
Modifications:
Changed the error message and the relevant unit test.
Result:
When running swift-build  in a folder that doesn't contain a Package.swift the below error is emitted:
error: Could not find Package.swift in this folder or any of it's parent folders.
@neonichu

@swift-ci please smoke test

@swift-ci smoke test

Linux failure looks spurious:

:0: error: module file '/home/buildnode/jenkins/workspace/swift-package-manager-Linux-smoke-test/branch-main/build/buildbot_incremental/llbuild-linux-x86_64/module-cache/37VD0X1G0MMFQ/SwiftShims-3849312O4BV1I.pcm' is out of date and needs to be rebuilt: signature mismatch

@swift-ci please smoke test

thanks @a-sarris

https://github.com/apple/swift-driver.git @ main: error: package at 'https://github.com/apple/swift-driver.git' @ 39009f4edaaf489574a4ab0698235c5d51834d65 is using Swift tools version 5.5.0 but the installed version is 5.3.0

@artemcm @shahmishal this seems like a change in driver ?

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please smoke test


Not reproducible when a project is copied to another directory

Problem
-Cmetadata Inconsistency Caused by Directory Change, please see this:
https://github.com/rust-lang/cargo/issues/13586
Steps
-Cmetadata Inconsistency Caused by Directory Change
Possible Solution(s)
No response
Notes
No response
Version
rustc 1.76.0-nightly (f5dc2653f 2023-11-25)
binary: rustc
commit-hash: f5dc2653fdd8b5d177b2ccbd84057954340a89fc
commit-date: 2023-11-25
host: aarch64-unknown-linux-gnu
release: 1.76.0-nightly
LLVM version: 17.0.5

https://github.com/rust-lang/cargo/issues/13586 is transferred so close this in favor of that.


fix: Handle no internet on serverbrowser fetch

Instead of panic, simply return an error.
When there's no connection to master server, either due to it being down or the user's internet connection being offline, there's no need to panic the thread. Rather simply return an error (which is silently logged in frontend)
Closes #263

Servers list fetching is not the only place where things go wrong with no Internet connection; could we have like a global error handler that returns an error for all methods requiring an Internet connection?

Servers list fetching is not the only place where things go wrong with no Internet connection; could we have like a global error handler that returns an error for all methods requiring an Internet connection?

Hmm not sure how to implement that tbh. The way I'd solve it, is by replacing all unwraps with ?s and bubble up the error to then handle properly on frontend (maybe even using custom error types as described in #323)
There might also be a way to send a message to frontend on panic but that's likely limited in what kind of information it can pass back which would make it difficult to differentiate the cause of error.
Overall there isn't really a catch all exceptions kinda thing as panics are more like a exit(-1) kinda deal (though in most cases in FlightCore it's just that thread that panics)
For some reason /client/servers reading failing due to lack of connection is one of the primary cause of thread crashes according to sentry. My assumption is that some firewalls are blocking it due to being an "unknown domain name". Hence I'm prioritising this function in the quest of removing all unwraps. ^^


option support for proxy download ?

option support for proxy download ?

I believe if you properly configure proxy in Windows, it will pick it up.

I believe if you properly configure proxy in Windows, it will pick it up.